gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
   4         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
   5         (MAX_PID_WIDTH): Move to tui-stack.c.
   6         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
   7         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
   8         (MAX_PID_WIDTH): Move from tui-data.h.
   9
  10 2019-08-20  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  13         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  14         (box_win): Update.
  15         (tui_gen_win_info::make_window): Rename from tui_make_window.
  16         (tui_win_info::make_window): New method.
  17         (tui_gen_win_info::make_visible): Update.
  18         * tui/tui-source.c (tui_source_window::set_contents): Update.
  19         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  20         (tui_data_window::display_registers_from): Update.
  21         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  22         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  23         Declare.
  24         <can_box>: Remove.
  25         <title>: Remove.
  26         (struct tui_win_info) <make_window>: Declare.
  27         <can_box>: Now virtual.
  28         <title>: New member.
  29         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  30         * tui/tui-command.c (tui_cmd_window::resize): Update.
  31
  32 2019-08-20  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  35         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  36         (tui_data_window::check_register_values): Update.
  37
  38 2019-08-20  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-regs.h (struct tui_data_window): Use
  41         DISABLE_COPY_AND_ASSIGN.
  42         <regs_content>: Change type, removing unique_ptr.
  43         <tui_data_window>: Add move constructor.
  44         * tui/tui-regs.c (tui_data_window::show_registers)
  45         (tui_data_window::show_register_group)
  46         (tui_data_window::display_registers_from)
  47         (tui_data_window::display_registers_from)
  48         (tui_data_window::first_data_item_displayed)
  49         (tui_data_window::delete_data_content_windows)
  50         (tui_data_window::rerender, tui_data_window::refresh_window)
  51         (tui_data_window::check_register_values): Update.
  52
  53 2019-08-20  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  56         show_register_group>: Declare.
  57         (tui_show_register_group): Don't declare.
  58         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  59         tui_show_registers.
  60         (tui_data_window::show_register_group): Rename from
  61         tui_show_register_group.
  62         (tui_data_window::check_register_values, tui_reg_command):
  63         Update.
  64         * tui/tui-layout.c (tui_set_layout): Update.
  65
  66 2019-08-20  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  69         Declare.
  70         (tui_check_register_values): Don't declare.
  71         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  72         from tui_check_register_values.
  73         * tui/tui-hooks.c (tui_register_changed): Update.
  74
  75 2019-08-20  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-regs.c (tui_reg_layout): Move later.
  78         (tui_show_registers): Don't enable TUI mode or change layout.
  79
  80 2019-08-20  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-regs.h (struct tui_data_item_window)
  83         <~tui_data_item_window>: Remove.
  84         <content>: Now a unique_xmalloc_ptr.
  85         * tui/tui-regs.c (tui_register_format): Return a
  86         unique_xmalloc_ptr.
  87         (tui_get_register): Update.
  88         (~tui_data_item_window): Remove.
  89         (tui_data_window::display_registers_from, tui_display_register):
  90         Update.
  91         * tui/tui-io.h (tui_expand_tabs): Update.
  92         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
  93         Remove "col" parameter.
  94
  95 2019-08-20  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
  98         field.
  99         * tui/tui-regs.c (~tui_data_item_window): Update.
 100
 101 2019-08-20  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 104         earlier.
 105
 106 2019-08-20  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 109
 110 2019-08-20  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-source.h (struct tui_source_window): Update.
 113         * tui/tui-regs.c (tui_show_registers): Update.
 114         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 115         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 116         (NO_REGS_STRING): Remove defines.
 117
 118 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 119
 120         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 121         unnecessary thread walk if remote doesn't support the packet.
 122
 123 2019-08-19  Tom Tromey  <tromey@adacore.com>
 124
 125         * python/py-value.c (value_has_field): Fix indentation.
 126
 127 2019-08-19  Tom Tromey  <tromey@adacore.com>
 128
 129         * printcmd.c (do_one_display, info_display_command): Update.
 130         * block.h (contained_in): Return bool.  Add allow_nested
 131         parameter.
 132         * block.c (contained_in): Return bool.  Add allow_nested
 133         parameter.
 134
 135 2019-08-19  Tom Tromey  <tom@tromey.com>
 136
 137         * configure: Rebuild.
 138         * configure.ac: Disallow the combination of -static-libstdc++ and
 139         source highlight.
 140         * source-cache.c (get_language_name): Handle rust.
 141         (source_cache::get_source_lines): Ignore highlighting exceptions.
 142
 143 2019-08-16  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 146         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 147         (struct tui_source_window_base) <make_visible, refresh_window,
 148         resize>: Remove methods.
 149         <execution_info>: Remove field.
 150         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 151         (tui_show_source_line, tui_source_window_base)
 152         (~tui_source_window_base): Update.
 153         (tui_source_window_base::resize)
 154         (tui_source_window_base::make_visible)
 155         (tui_source_window_base::refresh_window): Remove.
 156         (tui_source_window_base::update_exec_info): Update.
 157         * tui/tui-source.c (tui_source_window::set_contents): Update.
 158         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 159
 160 2019-08-16  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 163         deprecated_query_hook.
 164
 165 2019-08-16  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 168         (tui_update_source_windows_with_line): Update.
 169         * tui/tui-source.h (struct tui_source_window)
 170         <show_symtab_source>: Declare.
 171         (tui_show_symtab_source): Don't declare.
 172         * tui/tui-source.c (tui_show_symtab_source): Rename from
 173         tui_show_symtab_source.
 174
 175 2019-08-16  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-winsource.h (struct tui_source_window_base)
 178         <set_contents>: Declare.
 179         * tui/tui-winsource.c
 180         (tui_source_window_base::update_source_window_as_is): Update.
 181         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 182         Declare.
 183         (tui_set_source_content): Don't declare.
 184         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 185         tui_set_source_content.
 186         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 187         Declare.
 188         (tui_set_disassem_content): Don't declare.
 189         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 190         tui_set_disassem_content.
 191
 192 2019-08-16  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-winsource.h (struct tui_source_window_base)
 195         <update_breakpoint_info>: Declare.
 196         (tui_update_breakpoint_info): Don't declare.
 197         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 198         (tui_update_all_breakpoint_info): Update.
 199         (tui_source_window_base::update_breakpoint_info): Rename from
 200         tui_update_breakpoint_info.
 201         (tui_source_window_base::update_exec_info): Update.
 202
 203 2019-08-16  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-winsource.h (struct tui_source_window_base)
 206         <update_source_window>: Declare.
 207         (tui_update_source_window): Don't declare.
 208         * tui/tui-winsource.c
 209         (tui_source_window_base::update_source_window): Rename from
 210         tui_update_source_window.
 211         (tui_source_window_base::rerender): Update.
 212         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 213         * tui/tui-disasm.c (tui_show_disassem)
 214         (tui_show_disassem_and_update_source)
 215         (tui_disasm_window::maybe_update): Update.
 216
 217 2019-08-16  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-winsource.h (struct tui_source_window_base)
 220         <update_source_window_as_is>: Declare.
 221         (tui_update_source_window_as_is): Don't declare.
 222         * tui/tui-winsource.c (tui_update_source_window): Update
 223         (tui_source_window_base::update_source_window_as_is): Rename from
 224         tui_update_source_window_as_is.
 225         (tui_source_window_base::refill): Update.
 226         * tui/tui-source.c (tui_show_symtab_source): Update.
 227         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 228         Update.
 229
 230 2019-08-16  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-winsource.h (tui_update_source_window)
 233         (tui_update_source_window_as_is): Remove "noerror" parameter.
 234         * tui/tui-winsource.c (tui_update_source_window)
 235         (tui_update_source_window_as_is): Remove "noerror" parameter.
 236         (tui_update_source_windows_with_addr)
 237         (tui_update_source_windows_with_line)
 238         (tui_source_window_base::rerender)
 239         (tui_source_window_base::refill): Update.
 240         * tui/tui-source.h (tui_set_source_content)
 241         (tui_show_symtab_source): Remove "noerror" parameter.
 242         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 243         parameter.
 244         (tui_show_symtab_source): Likewise.
 245         (tui_source_window::maybe_update): Update.
 246         * tui/tui-disasm.c (tui_show_disassem)
 247         (tui_show_disassem_and_update_source)
 248         (tui_disasm_window::do_scroll_vertical)
 249         (tui_disasm_window::maybe_update): Update.
 250
 251 2019-08-16  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui.c (tui_is_window_visible): Update.
 254         * tui/tui-wingeneral.c (tui_make_window)
 255         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 256         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 257         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 258         (tui_set_win_height_command, parse_scrolling_args): Update.
 259         * tui/tui-source.c (tui_source_window::style_changed): Update.
 260         * tui/tui-regs.c (tui_show_registers)
 261         (tui_data_window::first_data_item_displayed)
 262         (tui_data_window::delete_data_content_windows)
 263         (tui_check_register_values, tui_reg_command): Update.
 264         * tui/tui-disasm.c (tui_show_disassem): Update.
 265         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 266         method.
 267         <is_visible>: Remove field.
 268         * tui/tui-data.c (tui_next_win, tui_prev_win)
 269         (tui_delete_invisible_windows): Update.
 270
 271 2019-08-16  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-winsource.h (struct tui_source_window_base)
 274         <m_has_locator>: Remove.
 275         * tui/tui-layout.c (show_source_disasm_command, show_data)
 276         (show_source_or_disasm_and_command): Update.
 277
 278 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 279
 280         * NEWS (Other MI changes): New subsection.
 281         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 282         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 283         * arch-utils.c (default_get_pc_address_flags): New function.
 284         * arch-utils.h (default_get_pc_address_flags): New declaration.
 285         * gdbarch.sh: Add get_pc_address_flags.
 286         * gdbarch.c: Regenerate.
 287         * gdbarch.h: Likewise.
 288         * stack.c (print_pc): New function.
 289         (print_frame_info) (print_frame): Call print_pc.
 290
 291 2019-08-16  Tom de Vries  <tdevries@suse.de>
 292
 293         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 294         print_objfile_section_info.
 295
 296 2019-08-15  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 299         calling update_cmdwin_start_line.
 300         * tui/tui-winsource.h (struct tui_source_window_base)
 301         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 302         <rerender>: Declare.
 303         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 304         Call rerender.
 305         (tui_source_window_base::set_new_height): Remove.
 306         (tui_source_window_base::rerender): Rename from
 307         do_make_visible_with_new_height.
 308         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 309         resize method.
 310         (tui_win_info::make_invisible_and_set_new_height)
 311         (tui_win_info::make_visible_with_new_height): Remove.
 312         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 313         Declare.
 314         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 315         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 316         do_make_visible_with_new_height>: Don't declare.
 317         <rerender>: Declare.
 318         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 319         set_new_height.
 320         (tui_data_window::do_make_visible_with_new_height): Remove.
 321         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 322         call tui_show_locator_content.
 323         (tui_gen_win_info::resize): Call rerender.
 324         (show_source_or_disasm_and_command): Don't call
 325         tui_show_locator_content.
 326         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 327         method.
 328         (struct tui_win_info) <rerender>: Declare.
 329         <set_new_height, make_invisible_and_set_new_height,
 330         make_visible_with_new_height>: Don't declare.
 331         * tui/tui-data.c (tui_win_list::rerender): New method.
 332         * tui/tui-command.h (struct tui_cmd_window)
 333         <do_make_visible_with_new_height>: Don't declare.
 334         * tui/tui-command.c
 335         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 336
 337 2019-08-15  Tom Tromey  <tromey@adacore.com>
 338
 339         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 340         * ada-lang.c (ada_enum_name): Likewise.
 341
 342 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 345         leading underscore.
 346         (GdbOutputErrorFile): Likewise.
 347         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 348         accordingly.
 349         (execute_unwinders): Rename to have a leading underscore.
 350         (auto_load_packages): Likewise.
 351         (global scope): Adjust call to auto_load_packages accordingly.
 352         (GdbSetPythonDirectory): Likewise.
 353         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 354         instead of execute_unwinders.
 355
 356 2019-08-15  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 359         (show_data): Don't change window visibility.
 360         (tui_gen_win_info::resize): Remove special case for command
 361         window.  Use wresize, when available.
 362         (show_source_or_disasm_and_command): Don't change window
 363         visibility.
 364         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 365         <make_visible>: New method.
 366         * tui/tui-command.c (tui_cmd_window::resize): New method.
 367
 368 2019-08-15  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 371         (struct tui_source_windows): New.
 372         * tui/tui-winsource.c (tui_display_main): Update.
 373         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 374         (new_height_ok, parse_scrolling_args): Update.
 375         * tui/tui-layout.c (show_layout, show_data): Update.
 376         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 377         (tui_add_to_source_windows): Don't declare.
 378         * tui/tui-data.c (source_windows, tui_source_windows)
 379         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 380
 381 2019-08-15  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 384         Rename from reset.
 385         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 386         * tui/tui-layout.c (show_source_disasm_command, show_data):
 387         Update.
 388         (tui_gen_win_info::resize): Rename.
 389         (show_source_or_disasm_and_command): Update.
 390         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 391         reset.
 392
 393 2019-08-15  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 396         * tui/tui-interp.c (tui_interp::init): Don't call
 397         tui_initialize_static_data.
 398         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 399
 400 2019-08-15  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 403         examine tui_win_list.
 404
 405 2019-08-15  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 408         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 409         tui_clear_source_content.
 410         (tui_clear_source_content): Remove.
 411         (tui_source_window_base::do_erase_source_content): Hoist call to
 412         content.clear().
 413         * tui/tui-stack.c (tui_show_frame_info): Don't call
 414         tui_clear_source_content.
 415
 416 2019-08-15  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-winsource.h (struct tui_source_window_base)
 419         <do_erase_source_content>: New method.
 420         <erase_source_content>: New method.
 421         (tui_erase_source_content): Don't declare.
 422         * tui/tui-winsource.c (tui_clear_source_content): Update.
 423         (tui_source_window_base::do_erase_source_content): Rename from
 424         tui_erase_source_content.
 425         (tui_source_window_base::show_source_content): Update.
 426         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 427         * tui/tui-source.h (struct tui_source_window)
 428         <erase_source_content>: New method.
 429         * tui/tui-disasm.h (struct tui_disasm_window)
 430         <erase_source_content>: New method.
 431
 432 2019-08-15  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 435         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 436         constructor.
 437         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 438         * tui/tui-source.c (tui_set_source_content): Update.
 439         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 440
 441 2019-08-15  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 444         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 445         tui-source.c.
 446         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 447         Declare.
 448         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 449         method.
 450         (tui_source_window::maybe_update): Update.
 451
 452 2019-08-15  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 455         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 456         tui-disasm.c.
 457         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 458         Declare.
 459         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 460         method.
 461         (tui_disasm_window::maybe_update): Update.
 462
 463 2019-08-15  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-winsource.h (struct tui_source_window_base)
 466         <maybe_update>: Declare.
 467         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 468         method.
 469         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 470         Declare.
 471         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 472         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 473         Declare.
 474         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 475
 476 2019-08-15  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 479
 480 2019-08-15  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-wingeneral.c: Include tui-stack.h.
 483         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 484         (struct tui_locator_window): Move from tui-data.h.
 485         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 486         (tui_initialize_static_data): Move from tui-data.c.
 487         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 488         (struct tui_locator_window): Move to tui-stack.c.
 489         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 490         (tui_initialize_static_data): Move to tui-stack.c.
 491
 492 2019-08-15  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-layout.c (show_source_disasm_command)
 495         (show_source_or_disasm_and_command): Use make_visible method, not
 496         tui_make_window.
 497         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 498         Remove.
 499
 500 2019-08-15  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-wingeneral.h (tui_make_window): Update.
 503         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 504         parameter.
 505         (tui_gen_win_info::make_visible): Update.
 506         * tui/tui-regs.c (tui_data_window::display_registers_from):
 507         Update.
 508         * tui/tui-layout.c (show_source_disasm_command)
 509         (show_source_or_disasm_and_command): Update.
 510         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 511         (enum tui_box): Remove.
 512         (struct tui_win_info) <can_box>: New method.
 513         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 514         method.
 515
 516 2019-08-15  Tom de Vries  <tdevries@suse.de>
 517
 518         * linux-nat-trad.c: Include gdbarch.h.
 519
 520 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 521
 522         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 523         register sizes.
 524
 525 2019-08-14  Tom Tromey  <tromey@adacore.com>
 526
 527         * darwin-nat.c: Include gdbarch.h.
 528         * darwin-nat-info.c: Include gdbarch.h.
 529
 530 2019-08-13  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 533         Remove.
 534         * tui/tui-data.c (tui_initialize_static_data): Update.
 535
 536 2019-08-13  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-winsource.h (struct tui_exec_info_window)
 539         <~tui_exec_info_window, maybe_allocate_content, get_content,
 540         m_content>: Remove.
 541         (struct tui_source_window_base) <set_exec_info_content,
 542         show_exec_info_content>: Don't declare.
 543         * tui/tui-winsource.c
 544         (tui_exec_info_window::maybe_allocate_content): Remove.
 545         (tui_source_window_base::update_exec_info): Rename from
 546         set_exec_info_content.
 547         (tui_source_window_base::show_exec_info_content)
 548         (tui_source_window_base::update_exec_info): Remove.
 549
 550 2019-08-13  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 553         declare.
 554         * tui/tui-winsource.c (tui_update_source_window_as_is)
 555         (tui_update_source_windows_with_addr, tui_erase_source_content):
 556         Update.
 557         (tui_clear_exec_info_content): Remove.
 558
 559 2019-08-13  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 562         declare.
 563         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 564         call tui_erase_exec_info_content.
 565         (tui_clear_exec_info_content): Rename from
 566         tui_erase_exec_info_content.
 567         (tui_clear_exec_info_content): Delete.
 568
 569 2019-08-13  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-winsource.h (struct tui_source_window_base)
 572         <show_exec_info_content>: Declare.
 573         (tui_show_exec_info_content): Don't declare.
 574         * tui/tui-winsource.c
 575         (tui_source_window_base::show_exec_info_content): Rename from
 576         tui_show_exec_info_content.
 577         (tui_source_window_base::update_exec_info): Update.
 578
 579 2019-08-13  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 582         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 583         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 584         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 585         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 586         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 587         ... here.
 588
 589 2019-08-13  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-winsource.h (struct tui_source_window_base)
 592         <update_exec_info>: Declare.
 593         (tui_update_exec_info): Don't declare.
 594         * tui/tui-winsource.c (tui_update_source_window_as_is)
 595         (tui_source_window_base::refresh_all)
 596         (tui_update_all_breakpoint_info): Update.
 597         (tui_source_window_base::update_exec_info): Rename from
 598         tui_update_exec_info.
 599         * tui/tui-stack.c (tui_show_frame_info): Update.
 600
 601 2019-08-13  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-winsource.h (struct tui_source_window_base)
 604         <set_exec_info_content>: Declare.
 605         (tui_set_exec_info_content): Don't declare.
 606         * tui/tui-winsource.c
 607         (tui_source_window_base::set_exec_info_content): Rename from
 608         tui_set_exec_info_content.
 609         (tui_update_exec_info): Update.
 610
 611 2019-08-13  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-winsource.h (struct tui_source_window_base)
 614         <show_source_content>: Declare.
 615         (tui_show_source_content): Don't declare.
 616         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 617         (tui_source_window_base::show_source_content): Rename from
 618         tui_show_source_content.
 619         (tui_source_window_base::refresh_all): Update.
 620         * tui/tui-layout.c (show_source_disasm_command)
 621         (show_source_or_disasm_and_command): Update.
 622
 623 2019-08-13  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-winsource.c (tui_erase_source_content)
 626         (tui_show_source_content, tui_source_window_base::refresh_all):
 627         Update.
 628         * tui/tui-wingeneral.h
 629         (tui_check_and_display_highlight_if_needed): Don't declare.
 630         * tui/tui-wingeneral.c
 631         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 632         check_and_display_highlight_if_needed.
 633         * tui/tui-win.c (tui_rehighlight_all)
 634         (tui_win_info::make_visible_with_new_height): Update.
 635         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 636         (tui_data_window::erase_data_content)
 637         (tui_data_window::display_all_data): Update.
 638         * tui/tui-data.h (struct tui_win_info)
 639         <check_and_display_highlight_if_needed>: Declare.
 640
 641 2019-08-13  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-win.c (tui_resize_all): Call
 644         tui_delete_invisible_windows.
 645         * tui/tui-layout.c (show_layout): Call
 646         tui_delete_invisible_windows.
 647         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 648         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 649
 650 2019-08-13  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 653         tui_add_win_to_layout.
 654
 655 2019-08-13  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 658         * tui/tui-layout.c (tui_default_win_height): Now static.
 659
 660 2019-08-13  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 663         single switch.
 664         (show_source_disasm_command, show_source_or_disasm_and_command):
 665         Don't check current layout.
 666
 667 2019-08-13  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-wingeneral.c (make_all_visible): Remove.
 670         (tui_make_all_invisible): Simplify.
 671         * tui/tui-layout.c (tui_make_all_invisible): Move from
 672         tui-wingeneral.c; simplify.
 673         (show_layout): Hoist call to tui_make_all_invisible.
 674         (show_data): Don't call tui_make_all_invisible.
 675
 676 2019-08-13  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 679         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 680
 681 2019-08-13  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 684         tui-data.c.
 685         (show_source_disasm_command, show_data)
 686         (show_source_or_disasm_and_command): Don't use
 687         tui_set_current_layout_to.
 688         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 689         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 690         tui-layout.c.
 691         (tui_set_current_layout_to): Remove.
 692
 693 2019-08-13  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-layout.c (tui_set_layout): Update.
 696         * tui/tui-data.h (struct tui_layout_def): Remove.
 697         (tui_layout_def): Don't declare.
 698         * tui/tui-data.c (layout_def): Remove.
 699         (tui_layout_def): Remove.
 700
 701 2019-08-13  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-winsource.h (struct tui_source_window_base)
 704         <clear_detail>: No longer "override".
 705         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 706         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 707         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 708         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 709         Remove.
 710         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 711
 712 2019-08-13  Tom Tromey  <tromey@adacore.com>
 713
 714         * tracepoint.c: Don't include readline.h or history.h.
 715
 716 2019-08-12  Tom Tromey  <tom@tromey.com>
 717
 718         * configure: Rebuild.
 719         * configure.ac: Check for readline 7.
 720         * NEWS: Mention readline 7 requirement.
 721         * README: Update.
 722
 723 2019-08-12  Tom Tromey  <tom@tromey.com>
 724
 725         * mingw-hdep.c (gdb_select): Remove readline hack.
 726
 727 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 728
 729         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 730         when the function fails.
 731
 732 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 733
 734         * s390-tdep.c (s390_type_align): New function.
 735         (s390_gdbarch_init): Set it as type_align gdbarch method.
 736
 737 2019-08-09  Tom de Vries  <tdevries@suse.de>
 738
 739         PR gdb/24591
 740         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 741         pc_low with relocation offset.
 742
 743 2019-08-07  Tom Tromey  <tromey@adacore.com>
 744
 745         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 746         (print_frame_args): Update.
 747         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 748         Update.
 749         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 750         * frame.h (struct frame_arg): Add initializers.
 751         <error>: Now a unique_xmalloc_ptr.
 752
 753 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 754
 755         * NEWS: Expand the Pointer Authentication entry.
 756         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 757         (aarch64_frame_unmask_lr): ... to this.
 758         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 759         Call aarch64_frame_unmask_lr.
 760         * frame.c (struct frame_info): Add "masked" variable.
 761         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 762         (fprint_frame): Check for masked pc.
 763         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 764         declarations.
 765         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 766         * stack.c (print_frame): Check for masked pc.
 767
 768 2019-08-06  Tom Tromey  <tom@tromey.com>
 769
 770         * stabsread.c (patch_block_stabs, read_one_struct_field)
 771         (read_enum_type): Use obstack_strndup.
 772         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 773         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 774         * dwarf2read.c (guess_full_die_structure_name)
 775         (anonymous_struct_prefix): Use obstack_strndup.
 776         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 777         * c-exp.y (yylex): Use obstack_strndup.
 778         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 779         (write_var_or_type): Use obstack_strndup.
 780
 781 2019-08-06  Tom Tromey  <tom@tromey.com>
 782
 783         * symfile.c (reread_symbols): Use obstack_strdup.
 784         * stabsread.c (read_type): Use obstack_strdup.
 785         * gdb_obstack.h (obstack_strdup): New overload.
 786         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 787         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 788         (dwarf2_canonicalize_name): Use obstack_strdup.
 789         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 790         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 791         Use obstack_strdup.
 792
 793 2019-08-06  Tom Tromey  <tom@tromey.com>
 794
 795         * gdb_obstack.h (obstack_strdup): Define.
 796         * gdb_obstack.c (obstack_strdup): Don't define.
 797
 798 2019-08-06  Tom Tromey  <tom@tromey.com>
 799
 800         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 801         obstack_strdup.
 802         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 803         obstack_strdup.
 804         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 805         * stabsread.c (common_block_start): Use obstack_strdup.
 806         * objfiles.c (set_objfile_main_name, objfile): Use
 807         obstack_strdup.
 808         * namespace.c (add_using_directive): Use obstack_strdup.
 809         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 810         * jit.c (finalize_symtab): Use obstack_strdup.
 811         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 812         (guess_partial_die_structure_name, partial_die_info::fixup)
 813         (dwarf2_name): Use obstack_strdup.
 814         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 815         obstack_strdup.
 816         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 817         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 818         obstack_strdup.
 819         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 820
 821 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 822
 823         * unittests/help-doc-selftests.c: New file.
 824         * Makefile.in: Add the new file.
 825
 826 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 827
 828         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 829         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 830         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 831         the trailing '.' is not output, and the first character is uppercased.
 832         (print_help_for_command): Update call to print_doc_line.
 833         (print_doc_of_command): Likewise.
 834         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 835         * cli/cli-option.c (append_indented_doc): Do not append newline.
 836         (build_help_option): Append newline after first appended_indented_doc
 837         only if a second call is done.
 838         (build_help): Append 2 new lines before each option, except the first
 839         one.
 840         * compile/compile.c (_initialize_compile): Add new lines after
 841         %OPTIONS%, when not at the end of the help.
 842         Change help doc or code
 843         producing the help doc to respect the invariants.
 844         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 845         Also removed the new line after 'Options:', as all other commands
 846         do not put an empty line between 'Options:' and the first option.
 847         * printcmd.c (_initialize_printcmd): Likewise.
 848         * stack.c (_initialize_stack): Likewise.
 849         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 850         incorrectly telling COMMAND is optional.
 851         * ada-lang.c (_initialize_ada_language): Change help doc or code
 852         producing the help doc to respect the invariants.
 853         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 854         * breakpoint.c (_initialize_breakpoint): Likewise.
 855         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 856         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 857         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 858         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 859         _initialize_cli_style): Likewise.
 860         * corelow.c (core_target_info): Likewise.
 861         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 862         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 863         * filesystem.c (_initialize_filesystem): Likewise.
 864         * frame.c (_initialize_frame): Likewise.
 865         * gnu-nat.c (add_task_commands): Likewise.
 866         * infcall.c (_initialize_infcall): Likewise.
 867         * infcmd.c (_initialize_infcmd): Likewise.
 868         * interps.c (_initialize_interpreter): Likewise.
 869         * language.c (_initialize_language): Likewise.
 870         * linux-fork.c (_initialize_linux_fork): Likewise.
 871         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 872         * maint.c (_initialize_maint_cmds): Likewise.
 873         * memattr.c (_initialize_mem): Likewise.
 874         * printcmd.c (_initialize_printcmd): Likewise.
 875         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 876         _RegEx): Likewise.
 877         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 878         * record-btrace.c (_initialize_record_btrace): Likewise.
 879         * record-full.c (_initialize_record_full): Likewise.
 880         * record.c (_initialize_record): Likewise.
 881         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 882         * regcache.c (_initialize_regcache): Likewise.
 883         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 884         _initialize_remote): Likewise.
 885         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 886         * serial.c (_initialize_serial): Likewise.
 887         * skip.c (_initialize_step_skip): Likewise.
 888         * source.c (_initialize_source): Likewise.
 889         * stack.c (_initialize_stack): Likewise.
 890         * symfile.c (_initialize_symfile): Likewise.
 891         * symtab.c (_initialize_symtab): Likewise.
 892         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 893         * top.c (init_main): Likewise.
 894         * tracefile-tfile.c (tfile_target_info): Likewise.
 895         * tracepoint.c (_initialize_tracepoint): Likewise.
 896         * tui/tui-win.c (_initialize_tui_win): Likewise.
 897         * utils.c (add_internal_problem_command): Likewise.
 898         * valprint.c (value_print_option_defs): Likewise.
 899
 900 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 901
 902         PR build/24886
 903         * configure.ac: Drop enable-libmcheck support.
 904         * configure, config.in: Rebuild.
 905         * libmcheck.m4: Remove.
 906         * acinclude.m4: Don't include it.
 907         * Makefile.in: Don't distribute it.
 908         * top.c (print_gdb_configuration): Don't mention it.
 909
 910 2019-08-06  Tom Tromey  <tom@tromey.com>
 911
 912         * utils.c (set_output_style): Sometimes pass stream to
 913         emit_style_escape.
 914         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 915         * record-btrace.c (btrace_insn_history): Update.
 916         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 917         method.
 918         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 919         Update initializers.
 920         <m_uiout>: New field.
 921         <m_di>: Move lower.
 922         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 923         Remove "uiout" parameter.
 924         (dump_insns): Update.
 925         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 926         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 927
 928 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 929
 930         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 931         (error_in_psymtab_expansion): Likewise.
 932         (lookup_symbol_via_quick_fns): Likewise.
 933         (basic_lookup_transparent_type_quick): Likewise.
 934         (basic_lookup_transparent_type_1): Likewise.
 935
 936 2019-08-06  Tom Tromey  <tromey@adacore.com>
 937
 938         * source.c (last_source_error): Now bool.
 939         (print_source_lines_base): Make "noprint" bool.  Only open
 940         source file when last_source_visited changes.
 941
 942 2019-08-06  Tom Tromey  <tromey@adacore.com>
 943
 944         * annotate.c (annotate_source_line): Use g_source_cache.
 945         * source-cache.c (source_cache::get_plain_source_lines): Change
 946         parameters.  Populate m_offset_cache.
 947         (source_cache::ensure): New method.
 948         (source_cache::get_line_charpos): New method.
 949         (extract_lines): Move lower.  Change parameters.
 950         (source_cache::get_source_lines): Move lower.
 951         * source-cache.h (class source_cache): Update comment.
 952         <get_line_charpos>: New method.
 953         <get_source_lines>: Update comment.
 954         <clear>: Clear m_offset_cache.
 955         <get_plain_source_lines>: Change parameters.
 956         <ensure>: New method
 957         <m_offset_cache>: New member.
 958         * source.c (forget_cached_source_info_for_objfile): Update.
 959         (info_source_command): Use g_source_cache.
 960         (find_source_lines, open_source_file_with_line_charpos): Remove.
 961         (print_source_lines_base, search_command_helper): Use g_source_cache.
 962         * source.h (open_source_file_with_line_charpos): Don't declare.
 963         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 964         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 965         Use g_source_cache.
 966
 967 2019-08-06  Tom Tromey  <tromey@adacore.com>
 968
 969         * source-cache.c (source_cache::get_plain_source_lines):
 970         Remove "first_line" and "last_line" parameters.
 971         (source_cache::get_source_lines): Cache plain text.
 972         * source-cache.h (class source_cache)
 973         <get_plain_source_lines>: Update.
 974
 975 2019-08-06  Tom Tromey  <tromey@adacore.com>
 976
 977         * source-cache.c (extract_lines): No longer a method.
 978         Changed type of parameter.  Include final newline.
 979         (selftests::extract_lines_test): New function.
 980         (_initialize_source_cache): Likewise.
 981         * source-cache.h (class source_cache)
 982         <extract_lines>: Don't declare.
 983
 984 2019-08-06  Tom Tromey  <tromey@adacore.com>
 985
 986         * breakpoint.c (init_breakpoint_sal): Update.
 987         (breakpoint): Update.
 988         * breakpoint.h (struct breakpoint) <filter>: Now a
 989         unique_xmalloc_ptr.
 990
 991 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 992
 993         * NEWS: Mention dictionary access on blocks.
 994         * python/py-block.c (blpy_getitem): New function.
 995         (block_object_as_mapping): New struct.
 996         (block_object_type): Use new struct for tp_as_mapping field.
 997
 998 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 999
1000         * objfiles.h (objfile): Add a comment describing partial symbols.
1001
1002 2019-08-05  Tom Tromey  <tromey@adacore.com>
1003
1004         * compile/compile.c (_initialize_compile): Use _(), not N_().
1005         * thread.c (_initialize_thread): Use _(), not N_().
1006         * stack.c (_initialize_stack): Use _(), not N_().
1007         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1008
1009 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1010
1011         * dwarf2read.c (struct dw2_symtab_iterator):
1012         <want_specific_block>: Remove.
1013         <block_index>: Change type to gdb::optional.
1014         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1015         change type of BLOCK_INDEX parameter to gdb::optional.
1016         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1017         (dw2_lookup_symbol): Don't pass argument for
1018         WANT_SPECIFIC_BLOCK.
1019         (dw2_expand_symtabs_for_function): Don't pass argument for
1020         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1021         (class dw2_debug_names_iterator)
1022         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1023         parameter, change BLOCK_INDEX type to gdb::optional.
1024         <m_want_specific_block>: Remove.
1025         <m_block_index>: Change type to gdb::optional.
1026         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1027         gdb::optional.  Re-write in function of gdb::optional.
1028         (dw2_debug_names_lookup_symbol): Don't pass argument for
1029         WANT_SPECIFIC_BLOCK.
1030         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1031         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1032         BLOCK_INDEX.
1033
1034 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1035
1036         * NEWS: Mention changes to "info sources" command.
1037
1038 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1039
1040         * symtab.c (filename_partial_match_opts): New struct type.
1041         (struct output_source_filename_data): New members
1042         regexp, c_regexp, partial_match.
1043         (output_source_filename): Use new members to decide to print file.
1044         (info_sources_option_defs): New variable.
1045         (make_info_sources_options_def_group, print_info_sources_header,
1046         info_sources_command_completer):
1047         New functions.
1048         (info_sources_command): Read new optional arguments.
1049         (_initialize_symtab): Update info sources help.
1050
1051 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1052
1053         * ada-lang.c (exception_support_info_v0): Renamed from...
1054         (default_exception_support_info): ... this.  Create new
1055         definition for v1.
1056         (ada_has_this_exception_support): Look up catch_handlers_sym.
1057         (ada_exception_support_info_sniffer): Try v0 after default.
1058
1059 2019-08-01  Tom Tromey  <tromey@adacore.com>
1060
1061         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1062         gdbarch.h.
1063
1064 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1065
1066         * s12z-tdep.c: Fix include path for s12z-opc.h.
1067
1068 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1069
1070         * NEWS: Require GNU make 3.82.
1071
1072 2019-07-16  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1075         declare.
1076
1077 2019-07-30  Tom Tromey  <tromey@adacore.com>
1078
1079         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1080
1081 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1082
1083         * printcmd.c (print_address_symbolic): Print negative offsets.
1084         (build_address_symbolic): Force signed arithmetic when computing
1085         offset.
1086
1087 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1088
1089         PR/24474: Add a function to lookup static variables.
1090         * NEWS: Mention this new function.
1091         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1092         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1093         * python/python.c (python_GdbMethods): Add new function.
1094
1095 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1096
1097         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1098         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1099         (objfpy_lookup_static_symbol): New function.
1100         (objfile_object_methods): Add new functions.
1101
1102 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1103
1104         * NEWS: Mention 'set|show print frame-info'.  Mention new
1105         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1106         backtrace argument.  Mention that python frame filtering code
1107         is now consistent with what 'backtrace' command prints.
1108
1109 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1110
1111         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1112         comments.
1113         (print_frame_info_auto, print_frame_info_source_line,
1114         print_frame_info_location, print_frame_info_source_and_location,
1115         print_frame_info_location_and_address, print_frame_info_short_location):
1116         New declarations.
1117         (struct frame_print_options): New member print_frame_info.
1118         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1119         * stack.h (get_user_print_what_frame_info): New declaration.
1120         (frame_show_address): New declaration.
1121         * stack.c (print_frame_arguments_choices): New value 'presence'.
1122         (print_frame_info_auto, print_frame_info_source_line,
1123         print_frame_info_location, print_frame_info_source_and_location,
1124         print_frame_info_location_and_address, print_frame_info_short_location,
1125         print_frame_info_choices, print_frame_info_print_what): New definitions.
1126         (print_frame_args): Only print dots for args if print frame-arguments
1127         is 'presence'.
1128         (frame_print_option_defs): New element for "frame-info".
1129         (get_user_print_what_frame_info): New function.
1130         (frame_show_address): Make non static.  Move comment to stack.h.
1131         (print_frame_info_to_print_what): New function.
1132         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1133         to decide what to print.
1134         (backtrace_command_1): Handle the new print_frame_arguments_presence
1135         value.
1136         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1137         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1138         (py_print_frame): In non-mi mode, use LOCATION as default for
1139         print_what, similarly to frame information printed directly by
1140         backtrace command. Handle frame-info user option in non MI mode.
1141
1142 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1143
1144         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1145         Add case for debugging 32-bit target on 64-bit host.  Revise
1146         comment.
1147
1148 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1149
1150         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1151         instead of find_function_entry_range_from_pc.
1152
1153 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1154
1155         * stack.c (find_frame_funname): Remove code which preferred
1156         minsym over symtab sym in "certain pathological cases".
1157
1158         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1159         parameter.  Change type of "do_demangle" to bool.
1160         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1161         Pass suitable "prefer_sym_over_minsym" flag to
1162         build_address_symbolic().  Don't output "+" for negative offsets.
1163         * printcmd.c (print_address_symbolic): Update invocation of
1164         build_address_symbolic to include a "prefer_sym_over_minsym"
1165         flag.
1166         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1167         Restrict cases in which use of minimal symbol is preferred to that
1168         of a found symbol.  Update comments.
1169
1170         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1171         for entry pc when entry pc is out of range for that FDE.
1172
1173 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1174
1175         PR gdb/24839:
1176         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1177         type.
1178
1179 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1180
1181         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1182         this function's Python signature.
1183
1184
1185 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1186
1187         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1188         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1189         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1190         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1191         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1192
1193
1194 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1195
1196         * h8300-tdep.c (h8300_register_name_common): New.
1197         h8300_register_name): Use h8300_register_name_common.
1198         (h8300s_register_name): Likewise.
1199         (h8300sx_register_name): Likewise.
1200         (h8300h_register_nam): New.
1201         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1202
1203
1204 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1205
1206         * arm-tdep.c (arm_skip_cmse_entry): New function.
1207         (arm_is_sgstubs_section): New function.
1208         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1209
1210 2019-07-22  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1213         Don't self-assign.
1214
1215 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1218         type_print.
1219
1220 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1223         so that GDB doesn't match any msymbols when searching in the
1224         TYPES_DOMAIN.
1225         (print_symbol_info): Print using typedef_print or type_print based
1226         on the type of the symbol.  Add updated FIXME comment moved from...
1227         (_initialize_symtab): ... move and update FIXME comment to above.
1228
1229 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * NEWS: Mention adding -q option to "info types".
1232         * symtab.c (struct info_types_options): New struct.
1233         (info_types_options_defs): New variable.
1234         (make_info_types_options_def_group): New function.
1235         (info_types_command): Use gdb::option framework to parse options.
1236         (info_types_command_completer): New function.
1237         (_initialize_symtab): Extend the help text on "info types" and
1238         register command completer.
1239
1240 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1241
1242         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1243         (lookup_symbol_in_objfile): Change int to block_enum and add a
1244         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1245
1246 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1247
1248         * MAINTAINERS (Write After Approval): Add self.
1249
1250 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1253         instruction to the dummy code region.
1254
1255 2019-07-19  Tom Tromey  <tromey@adacore.com>
1256
1257         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1258         (ARGSUSED, PARAMS, __func__): Remove rules.
1259
1260 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1261
1262         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1263         * features/arm/arm-with-iwmmxt.c: Remove.
1264         * features/arm/arm-with-iwmmxt.xml: Remove.
1265         * features/arm/arm-with-m-fpa-layout.c: Remove.
1266         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1267         * features/arm/arm-with-m-vfp-d16.c: Remove.
1268         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1269         * features/arm/arm-with-m.c: Remove.
1270         * features/arm/arm-with-m.xml: Remove.
1271         * features/arm/arm-with-neon.c: Remove.
1272         * features/arm/arm-with-neon.xml: Remove.
1273         * features/arm/arm-with-vfpv2.c: Remove.
1274         * features/arm/arm-with-vfpv2.xml: Remove.
1275         * features/arm/arm-with-vfpv3.c: Remove.
1276         * features/arm/arm-with-vfpv3.xml: Remove.
1277
1278 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1281
1282 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1283
1284         * arch/aarch32.c (aarch32_create_target_description): Create
1285         target descriptions using features.
1286         * arch/arm.c (arm_create_target_description)
1287         (arm_create_mprofile_target_description): Likewise.
1288         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1289
1290 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1291
1292         * Makefile.in: Add new files.
1293         * aarch32-tdep.c: New file.
1294         * aarch32-tdep.h: New file.
1295         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1296         Call aarch32_read_description.
1297         * arch/aarch32.c: New file.
1298         * arch/aarch32.h: New file.
1299         * arch/arm.c (arm_create_target_description)
1300         (arm_create_mprofile_target_description): New function.
1301         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1302         (arm_create_target_description)
1303         (arm_create_mprofile_target_description): New declaration.
1304         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1305         read_description functions.
1306         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1307         Likewise.
1308         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1309         * arm-tdep.c (tdesc_arm_list): New variable.
1310         (arm_register_g_packet_guesses): Call create description functions.
1311         (arm_read_description) (arm_read_mprofile_description): New
1312         function.
1313         * arm-tdep.h (arm_read_description)
1314         (arm_read_mprofile_description): Add declaration.
1315         * configure.tgt: Add new files.
1316
1317 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1318
1319         * top.c (new_ui_command): Open specified terminal just once.
1320
1321 2019-07-18  Tom Tromey  <tromey@adacore.com>
1322
1323         * symtab.c (main_name): Constify return type.
1324         * symfile.c (set_initial_language): Update.
1325         * symtab.h (main_name): Constify return type.
1326
1327 2019-07-17  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-winsource.c (tui_update_source_window)
1330         (tui_update_source_window_as_is)
1331         (tui_update_source_windows_with_line): Remove return.
1332         * tui/tui-disasm.c (tui_show_disassem)
1333         (tui_show_disassem_and_update_source): Remove return.
1334         * tui/tui.c (tui_reset): Remove return.
1335         * tui/tui-wingeneral.c
1336         (tui_check_and_display_highlight_if_needed): Remove return.
1337
1338 2019-07-17  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1341
1342 2019-07-17  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-winsource.h (struct tui_exec_info_window)
1345         (struct tui_source_window_base): Move from tui-data.h.
1346         * tui/tui-winsource.c: Move many method definitions from
1347         elsewhere.  Remove "structuring" comments.
1348         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1349         (tui_source_window_base::refresh_window): Move to
1350         tui-winsource.c.
1351         * tui/tui-win.c (tui_source_window_base::refresh_all)
1352         (tui_source_window_base::update_tab_width)
1353         (tui_source_window_base::set_new_height)
1354         (tui_source_window_base::do_make_visible_with_new_height): Move to
1355         tui-winsource.c.
1356         * tui/tui-source.h: Update.
1357         * tui/tui-source.c (tui_source_window_base::reset): Move to
1358         tui-winsource.c.
1359         * tui/tui-disasm.h: Update.
1360         * tui/tui-data.h (struct tui_exec_info_window): Move to
1361         tui-winsource.h.
1362         (struct tui_source_window_base): Likewise.
1363         * tui/tui-data.c (tui_source_window_base::clear_detail)
1364         (tui_source_window_base, ~tui_source_window_base): Move to
1365         tui-winsource.c.
1366
1367 2019-07-17  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-win.c (tui_resize_all)
1370         (tui_source_window_base::update_tab_width)
1371         (tui_adjust_win_heights): Update.
1372         (tui_win_info::make_invisible_and_set_new_height): Rename from
1373         make_invisible_and_set_new_height.
1374         * tui/tui-data.h (struct tui_win_info)
1375         <make_invisible_and_set_new_height>: New method.
1376
1377 2019-07-17  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui.c: Update.
1380         * tui/tui-source.h (struct tui_source_window): Move from
1381         tui-data.h.
1382         * tui/tui-layout.c: Update.
1383         * tui/tui-disasm.c: Update.
1384         * tui/tui-data.h (struct tui_source_window): Move to
1385         tui-source.h.
1386
1387 2019-07-17  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1390         tui-data.h.
1391         * tui/tui-data.h (struct tui_disasm_window): Move to
1392         tui-disasm.h.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-regs.h (struct tui_data_item_window): Move from
1397         tui-data.h.
1398         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1399         * tui/tui-data.h (struct tui_data_item_window): Move to
1400         tui-regs.h.
1401         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1402
1403 2019-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui.c: Update.
1406         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1407         (tui_cmd_window::max_height): Move to tui-command.c.
1408         * tui/tui-layout.c: Update.
1409         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1410         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1411         tui-command.c.
1412         * tui/tui-command.h (struct tui_cmd_window): Move from
1413         tui-data.h.
1414         * tui/tui-command.c: Remove "structuring" comments.
1415         (tui_cmd_window::clear_detail)
1416         (tui_cmd_window::do_make_visible_with_new_height)
1417         (tui_cmd_window::max_height): Move from elsewhere.
1418
1419 2019-07-17  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1422         Now static.
1423         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1424         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui.c: Update.
1429         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1430         tui-regs.c.
1431         * tui/tui-windata.h: Remove file.
1432         * tui/tui-windata.c: Remove file.
1433         * tui/tui-win.c (tui_data_window::set_new_height)
1434         (tui_data_window::do_make_visible_with_new_height): Move to
1435         tui-regs.c.
1436         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1437         * tui/tui-regs.c: Remove "structuring" comments.
1438         (tui_data_window::first_data_item_displayed)
1439         (tui_data_window::delete_data_content_windows)
1440         (tui_data_window::erase_data_content)
1441         (tui_data_window::display_all_data)
1442         (tui_data_window::refresh_all)
1443         (tui_data_window::do_scroll_vertical)
1444         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1445         (tui_data_window::do_make_visible_with_new_height)
1446         (tui_data_window::refresh_window): Move from elsewhere.
1447         (_initialize_tui_regs): Move to end of file.
1448         * tui/tui-layout.c: Update.
1449         * tui/tui-hooks.c: Update.
1450         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1451         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1452         tui-regs.c.
1453         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1454
1455 2019-07-17  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1458         seen.
1459
1460 2019-07-17  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-win.c (tui_source_window_base::set_new_height)
1463         (tui_source_window_base::do_make_visible_with_new_height): Use
1464         m_has_locator field directly.
1465         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1466         method.
1467         (struct tui_source_window_base) <has_locator>: Likewise.
1468
1469 2019-07-17  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1472         Don't declare.
1473         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1474         Remove.
1475         * tui/tui-win.c (tui_source_window_base::set_new_height)
1476         (tui_source_window_base::set_new_height)
1477         (make_invisible_and_set_new_height)
1478         (tui_source_window_base::do_make_visible_with_new_height)
1479         (tui_source_window_base::do_make_visible_with_new_height):
1480         Update.
1481         * tui/tui-layout.c (show_source_disasm_command, show_data)
1482         (show_source_or_disasm_and_command): Update.
1483         * tui/tui-layout.c (show_layout): Update.
1484
1485 2019-07-17  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-layout.c (make_data_window): Remove.
1488         (show_data): Unify creation and re-initialization cases.
1489
1490 2019-07-17  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-layout.c (make_source_window, make_disasm_window):
1493         Remove.
1494         (show_data): Unify creation and re-initialization cases.
1495
1496 2019-07-17  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-layout.c (make_command_window): Remove.
1499         (show_source_disasm_command, show_source_or_disasm_and_command):
1500         Unify creation and re-initialization cases.
1501
1502 2019-07-17  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1505         creation and re-initialization cases.
1506
1507 2019-07-17  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-regs.c (tui_get_register): Return void.
1510
1511 2019-07-17  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1514         Simplify.
1515
1516 2019-07-17  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1519         resetting.
1520
1521 2019-07-17  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1524         * tui/tui-regs.c (tui_reg_layout): New function.
1525         (tui_show_registers, tui_reg_command): Use it.
1526         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1527         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1528         parameters.
1529         (tui_layout_command): Remove.
1530
1531 2019-07-17  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-layout.h (tui/tui-layout): Return void.
1534         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1535
1536 2019-07-17  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-layout.c (show_source_disasm_command, show_data):
1539         Update.
1540         (reset_locator): Remove.
1541         (show_source_or_disasm_and_command): Update.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-source.c (tui_source_window_base::reset): Remove
1546         win_type parameter.
1547         * tui/tui-layout.c (make_command_window, make_source_window)
1548         (make_disasm_window, make_data_window)
1549         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1550         (reset_locator, show_source_or_disasm_and_command): Update.
1551         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1552         win_type parameter.
1553         (struct tui_source_window_base) <reset>: Likewise.
1554
1555 2019-07-17  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-layout.c (show_source_disasm_command): Use
1558         reset_locator.
1559         (reset_locator): New function.
1560         (init_and_make_win): Remove.
1561         (show_source_or_disasm_and_command): Use reset_locator.
1562
1563 2019-07-17  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1566         condition.
1567         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1568         Remove condition.
1569         * tui/tui-source.c (tui_source_window_base::reset): New method.
1570         * tui/tui-layout.c (make_command_window): Don't call
1571         init_and_make_win.
1572         (make_source_window, make_disasm_window): Don't call
1573         make_source_or_disasm_window.
1574         (make_data_window): Don't call init_and_make_win.  Change calling
1575         convention.
1576         (show_source_disasm_command, show_data): Simplify.
1577         (make_source_or_disasm_window): Remove.
1578         (show_source_or_disasm_and_command): Simplify.
1579         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1580         (struct tui_source_window_base) <reset>: Likewise.
1581         <execution_info>: Remove initializer.
1582         * tui/tui-data.c (tui_source_window_base): Initialize
1583         execution_info.
1584
1585 2019-07-17  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1588         variable.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui.c (tui_rl_other_window): Update.
1593         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1594         superclass method first.  Always iterate over regs_content.
1595         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1596         method.
1597         * tui/tui-win.c (tui_set_focus_command): Update.
1598
1599 2019-07-17  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-win.c (tui_set_focus_command): Rename from
1602         tui_set_focus.  Call tui_enable.
1603         (tui_set_focus_command): Remove.
1604
1605 2019-07-17  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1608         refresh_window.
1609         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1610         touchwin.
1611         (tui_data_window::refresh_window): Call refresh_window on data
1612         items.  Always call superclass refresh_window.
1613         (tui_win_info::refresh): Remove.
1614         (tui_source_window_base::refresh_window): Update.
1615         (tui_refresh_all): Update.
1616         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1617         refresh_window.
1618         (show_source_or_disasm_and_command): Likewise.
1619         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1620         (struct tui_source_window_base) <refresh>: Likewise.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-winsource.c (tui_clear_source_content)
1625         (tui_show_source_content): Update.
1626         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1627         whether content is empty.
1628         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1629         Remove.
1630
1631 2019-07-17  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1634         window's contents.
1635         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1636         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1637
1638 2019-07-17  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1641         (struct tui_data_item_window): Update.
1642
1643 2019-07-17  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1646         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1647         defines.
1648
1649 2019-07-17  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-winsource.h (tui_erase_source_content)
1652         (tui_clear_source_content): Remove "display_prompt" parameter.
1653         * tui/tui-winsource.c (tui_update_source_window_as_is)
1654         (tui_update_source_windows_with_addr): Update.
1655         (tui_clear_source_content): Remove "display_prompt" parameter.
1656         (tui_erase_source_content): Likewise.  Simplify.
1657         (tui_show_source_content): Update.
1658         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1659         * tui/tui-stack.c (tui_show_frame_info): Update.
1660         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1661         Remove defines.
1662
1663 2019-07-17  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1666         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1667         parameter.
1668         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1669         parameter.
1670
1671 2019-07-17  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-winsource.c (tui_clear_source_content)
1674         (tui_show_source_content, tui_show_exec_info_content)
1675         (tui_clear_exec_info_content): Update.
1676         * tui/tui-stack.c (tui_show_locator_content): Update.
1677         (tui_show_frame_info): Update.
1678         * tui/tui-source.h (tui_source_window): Don't declare.
1679         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1680         from tui_source_is_displayed.
1681         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1682         Remove field.
1683         (struct tui_source_window_base) <content_in_use>: New field.  Now
1684         bool.
1685         (struct tui_source_window) <showing_source_p>: New method.
1686         (TUI_SRC_WIN): Change cast.
1687         * tui/tui-data.c (tui_initialize_static_data): Update.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1692         location_matches_p.
1693         * tui/tui-source.c (tui_source_window::location_matches_p): New
1694         method.
1695         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1696         method.
1697         * tui/tui-data.h (struct tui_source_window_base)
1698         <location_matches_p>: New method.
1699         (struct tui_source_window, struct tui_disasm_window)
1700         <location_matches_p>: Likewise.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-win.c (tui_set_win_height_command): Rename from
1705         tui_set_win_height.
1706         (tui_set_win_height_command): Remove.
1707
1708 2019-07-17  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-source.c (tui_source_window): New constructor.  Add
1711         observer.
1712         (~tui_source_window): New destructor.
1713         (tui_source_window::style_changed): New method.
1714         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1715         (tui_attach_detach_observers): Update.
1716         * tui/tui-data.h (struct tui_source_window): Make constructor not
1717         inline.  Add destructor.
1718         (struct tui_source_window) <style_changed>: New method.
1719         <m_observable>: New member.
1720
1721 2019-07-17  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1724         * tui/tui-win.c (tui_resize_all): Fix typo.
1725
1726 2019-07-17  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1729         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1730         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1731         * tui/tui-win.c (window_name_completer): Use foreach.
1732         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1733         (update_tab_width): Likewise.
1734         * tui/tui-layout.c (show_layout): Update.
1735         * tui/tui-data.h (class tui_window_iterator): New.
1736         (struct all_tui_windows): New.
1737         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1738
1739 2019-07-17  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1742         parameter.  Don't reference globals.
1743         (tui_reg_command): Update.
1744
1745 2019-07-17  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-regs.c (tui_show_registers): Simplify.
1748
1749 2019-07-17  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-regs.c (tui_show_registers): Update.
1752         (tui_show_register_group): Add win_info parameter.
1753
1754 2019-07-17  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1757         Rename from tui_display_reg_element_at_line.
1758         (tui_data_window::display_registers_from_line): Update.
1759         * tui/tui-data.h (struct tui_data_window)
1760         <display_reg_element_at_line>: New method.
1761
1762 2019-07-17  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-regs.h (tui_display_registers_from)
1765         (tui_display_registers_from_line): Don't declare.
1766         * tui/tui-windata.c (tui_data_window::display_all_data)
1767         (tui_data_window::refresh_all)
1768         (tui_data_window::do_scroll_vertical): Update.
1769         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1770         from tui_display_registers_from.
1771         (tui_display_reg_element_at_line): Update.
1772         (tui_data_window::display_registers_from_line): Rename from
1773         tui_display_registers_from_line.
1774         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1775         display_registers_from_line>: New methods.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1780         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1781         from tui_erase_data_content.
1782         (tui_data_window::display_all_data)
1783         (tui_data_window::refresh_all)
1784         (tui_data_window::do_scroll_vertical): Update.
1785         * tui/tui-regs.c (tui_show_registers): Update.
1786         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1787         New method.
1788
1789 2019-07-17  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1792         declare.
1793         * tui/tui-windata.c
1794         (tui_data_window::delete_data_content_windows): Rename from
1795         tui_delete_data_content_windows.
1796         (tui_data_window::display_all_data)
1797         (tui_data_window::do_scroll_vertical): Update.
1798         * tui/tui-data.h (struct tui_data_window)
1799         <delete_data_content_windows>: New method.
1800
1801 2019-07-17  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1804         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1809         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1810         from tui_display_all_data.
1811         * tui/tui-win.c
1812         (tui_data_window::do_make_visible_with_new_height): Update.
1813         * tui/tui-regs.c (tui_show_registers): Update.
1814         * tui/tui-layout.c (tui_set_layout): Update.
1815         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1816         method.
1817
1818 2019-07-17  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1821         * tui/tui-windata.c (tui_display_data_from): Remove.
1822         (tui_data_window::refresh_all): Update.
1823
1824 2019-07-17  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1827         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1828         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1829         tui_display_registers_from_line.
1830         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1831         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1832         "force_display" parameter.
1833
1834 2019-07-17  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1837         declare.
1838         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1839         Rename from tui_first_reg_element_no_inline.
1840         (tui_display_reg_element_at_line)
1841         (tui_display_registers_from_line): Update.
1842         * tui/tui-data.h (struct tui_data_window)
1843         <first_reg_element_no_inline>: New method.
1844
1845 2019-07-17  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-windata.c (tui_display_data_from)
1848         (tui_data_window::do_scroll_vertical): Update.
1849         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1850         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1851         Rename from tui_line_from_reg_element_no.
1852         (tui_display_registers_from_line): Update.
1853         * tui/tui-data.h (struct tui_data_window)
1854         <line_from_reg_element_no>: New method.
1855
1856 2019-07-17  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1859         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1860         tui_last_regs_line_no.
1861         (tui_display_reg_element_at_line)
1862         (tui_display_registers_from_line): Update.
1863         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1864         method.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         PR tui/24722:
1869         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1870         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1871         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1872         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1873         (tui_update_breakpoint_info): Likewise.
1874         * tui/tui-hooks.c (tui_event_create_breakpoint)
1875         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1876         Update.
1877
1878 2019-07-17  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1881
1882 2019-07-17  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-winsource.c (tui_update_source_window_as_is)
1885         (tui_update_source_windows_with_addr): Update.
1886         * tui/tui-source.h (tui_set_source_content)
1887         (tui_show_symtab_source): Add "win_info" parameter.
1888         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1889         parameter.
1890         (tui_show_symtab_source): Likewise.
1891
1892 2019-07-17  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-wingeneral.c
1895         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1896
1897 2019-07-17  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1900         (struct tui_cmd_window) <can_scroll>: New method.
1901         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1902         method.
1903
1904 2019-07-17  Tom Tromey  <tromey@adacore.com>
1905
1906         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1907         do_field_signed>: Rename.  Change type of "value".
1908         * ui-out.c (ui_out::field_signed): Rename from field_int.
1909         Change type of "value".
1910         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1911         type of "value".
1912         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1913         do_field_int.  Change type of "value".
1914         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1915         do_field_int.  Change type of "value".
1916         * tracepoint.c (trace_status_mi, tfind_1)
1917         (print_one_static_tracepoint_marker): Update.
1918         * thread.c (print_thread_info_1, print_selected_thread_frame):
1919         Update.
1920         * stack.c (print_frame, print_frame_info): Update.
1921         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1922         Update.
1923         * source.c (print_source_lines_base): Update.
1924         * skip.c (info_skip_command): Update.
1925         * record-btrace.c (btrace_ui_out_decode_error)
1926         (btrace_call_history_src_line): Update.
1927         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1928         Update.
1929         * progspace.c (print_program_space): Update.
1930         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1931         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1932         do_field_int.  Change type of "value".
1933         * mi/mi-out.c (mi_ui_out::do_table_begin)
1934         (mi_ui_out::do_table_header): Update.
1935         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1936         type of "value".
1937         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1938         (mi_cmd_data_list_changed_registers, output_register)
1939         (mi_cmd_data_read_memory, mi_load_progress)
1940         (mi_cmd_trace_frame_collected): Update.
1941         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1942         Update.
1943         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1944         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1945         (mi_cmd_var_list_children, varobj_update_one): Update.
1946         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1947         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1948         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1949         * inferior.c (print_inferior): Update.
1950         * gdb_bfd.c (print_one_bfd): Update.
1951         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1952         Update.
1953         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1954         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1955         do_field_int.  Change type of "value".
1956         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1957         do_field_int.  Change type of "value".
1958         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1959         (print_one_breakpoint_location, print_it_catch_fork)
1960         (print_one_catch_fork, print_it_catch_vfork)
1961         (print_one_catch_vfork, print_it_catch_solib)
1962         (print_it_catch_exec, print_it_ranged_breakpoint)
1963         (print_mention_watchpoint, print_mention_masked_watchpoint)
1964         (bkpt_print_it, update_static_tracepoint): Update.
1965         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1966         * break-catch-syscall.c (print_it_catch_syscall): Update.
1967         * ada-tasks.c (print_ada_task_info): Update.
1968         * ada-lang.c (print_it_exception, print_mention_exception):
1969         Update.
1970
1971 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1972
1973         PR breakpoints/24541
1974         * gdbarch.c: Regenerate.
1975         * gdbarch.h: Regenerate.
1976         * gdbarch.sh: Adjust return type and parameter types for
1977         'stap_adjust_register'.
1978         (i386_stap_adjust_register): Adjust signature and return new
1979         register name.
1980         * stap-probe.c (stap_parse_register_operand): Adjust use of
1981         'gdbarch_stap_adjust_register'.
1982
1983 2019-07-17  Tom Tromey  <tromey@adacore.com>
1984
1985         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1986         declare VEC.
1987         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1988         std::vector.
1989         (struct s390_process_info): Add initializers.
1990         (s390_add_process): Use new.
1991         (s390_linux_nat_target::low_forget_process): Use delete.
1992         (s390_linux_nat_target::low_new_fork)
1993         (s390_linux_nat_target::stopped_by_watchpoint)
1994         (s390_linux_nat_target::low_prepare_to_resume)
1995         (s390_linux_nat_target::insert_watchpoint)
1996         (s390_linux_nat_target::insert_hw_breakpoint)
1997         (s390_linux_nat_target::remove_watchpoint)
1998         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1999
2000 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2001
2002         * aarch64-fbsd-nat.c: Include regcache.h.
2003         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2004         argument.
2005         (aarch64_fbsd_nat_target::fetch_registers)
2006         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2007         variable.
2008         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2009
2010 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2011
2012         * fbsd-nat.c: Include gdbarch.h.
2013
2014 2019-07-15  Tom Tromey  <tromey@adacore.com>
2015
2016         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2017
2018 2019-07-15  Tom Tromey  <tromey@adacore.com>
2019
2020         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2021         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2022         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2023         * cli-out.c (cli_ui_out::do_field_int): New method.
2024         * ui-out.c (ui_out::field_unsigned): New method.
2025         * symfile.c (generic_load): Use field_unsigned.
2026         (print_transfer_performance): Likewise.
2027         * record-btrace.c (ui_out_field_uint): Remove.
2028         (btrace_call_history_insn_range, btrace_call_history): Use
2029         field_unsigned.
2030         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2031         field_unsigned.
2032         * ui-out.h (class ui_out) <field_unsigned>: New method.
2033         <do_field_unsigned>: Likewise.
2034
2035 2019-07-15  Tom Tromey  <tromey@adacore.com>
2036
2037         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2038         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2039         * target.c (flash_erase_command): Use field_string.
2040         * infrun.c (print_signal_received_reason): Use field_string.
2041         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2042         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2043         field_string.
2044         * ada-tasks.c (print_ada_task_info): Use field_string.
2045
2046 2019-07-15  Tom Tromey  <tromey@adacore.com>
2047
2048         * target.c (flash_erase_command): Use field_core_addr.
2049         * symfile.c (generic_load): Use field_core_addr.
2050         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2051         Use field_core_addr.
2052         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2053         field_core_addr.
2054
2055 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2056
2057         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2058         value if its desired type is smaller than a CORE_ADDR and signed.
2059
2060 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2063         of changes to field names, and use new is_reference field to
2064         decide if a property is a reference or not.
2065         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2066         field.
2067         (struct dwarf2_property_baton): Update header comment, rename
2068         'referenced_type' to 'property_type' and update comments.
2069         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2070         default property type, store in property baton, update to take
2071         accound of renamed field.
2072         (read_func_scope): Update call to attr_to_dynamic_prop.
2073         (read_array_type): Likewise.
2074         (dwarf2_per_cu_addr_sized_int_type): New function.
2075         (read_subrange_index_type): Move type finding code to
2076         dwarf2_per_cu_addr_sized_int_type.
2077         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2078         (dwarf2_per_cu_addr_type): New function.
2079         (set_die_type): Update calls to attr_to_dynamic_prop.
2080
2081 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2082
2083         * dwarf2read.c (read_subrange_index_type): New function.
2084         (read_subrange_type): Move code into new function and call it.
2085         * gdbtypes.c (create_range_type): Add some asserts.
2086
2087 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2090         update return statements.
2091         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2092         declaration, and update comment to match.
2093         * gdbtypes.c (resolve_dynamic_array): Update call to
2094         dwarf2_evaluate_property to match new return type.
2095
2096 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         * valarith.c (value_subscripted_rvalue): Change lowerbound
2099         parameter type from int to LONGEST.
2100         * value.h (value_subscripted_rvalue): Likewise in declaration.
2101
2102 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2103
2104         * cli/cli-utils.c (info_print_command_completer): New function.
2105         * cli/cli-utils.h: Add 'completer.h' include, and forward
2106         declaration for 'struct cmd_list_element'.
2107         (info_print_command_completer): Declare.
2108         * stack.c (_initialize_stack): Add completer for 'info locals' and
2109         'info args'.
2110         * symtab.c (_initialize_symtab): Add completer for 'info
2111         variables' and 'info functions'.
2112         * NEWS: Mention completion for additional info commands.
2113
2114 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2115
2116         * cli/cli-utils.c (extract_info_print_args): Delete.
2117         (extract_arg_maybe_quoted): Delete.
2118         (info_print_options_defs): New variable.
2119         (make_info_print_options_def_group): New function.
2120         (extract_info_print_options): Define new function.
2121         * cli/cli-utils.h (extract_info_print_args): Delete.
2122         (struct info_print_options): New structure.
2123         (extract_info_print_options): Declare new function.
2124         * stack.c (info_locals_command): Update to use new
2125         extract_info_print_options, also add a header comment.
2126         (info_args_command): Likewise.
2127         * symtab.c (info_variables_command): Likewise.
2128         (info_functions_command): Likewise.
2129
2130 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2133         to extract string arguments.
2134         * common/common-utils.c (extract_string_maybe_quoted): New function.
2135         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2136
2137 2019-07-11  Tom Tromey  <tromey@adacore.com>
2138
2139         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2140         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2141         * top.h (gdbinit): Don't declare.
2142         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2143         into...
2144         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2145         * top.c (gdb_init): Don't call init_cli_cmds.
2146         (gdbinit): Remove.
2147         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2148
2149 2019-07-11  Tom Tromey  <tromey@adacore.com>
2150
2151         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2152         after it has been moved.
2153
2154 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2155
2156         * valops.c (value_must_coerce_to_target): Change return type to
2157         bool.
2158         * value.h (value_must_coerce_to_target): Likewise.
2159
2160 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2161
2162         * breakpoint.c (is_hardware_watchpoint): Remove
2163         forward-declaration.
2164         (is_masked_watchpoint): Change return type to bool.
2165         (is_tracepoint): Likewise.
2166         (is_breakpoint): Likewise.
2167         (is_hardware_watchpoint): Likewise.
2168         (is_watchpoint): Likewise.
2169         (is_no_memory_software_watchpoint): Likewise.
2170         (is_catchpoint): Likewise.
2171         (breakpoint_1): Make FILTER parameter's return type bool.
2172         is_masked_watchpoint): Change return type to bool.
2173         (save_breakpoints): Make FILTER parameter's return type bool.
2174         * breakpoint.h (is_breakpoint): Change return type to bool.
2175         (is_watchpoint): Likewise.
2176         (is_catchpoint): Likewise.
2177         (is_tracepoint): Likewise.
2178
2179 2019-07-10  Tom Tromey  <tom@tromey.com>
2180
2181         * defs.h: Don't include gdbarch.h.
2182         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2183         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2184         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2185         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2186         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2187         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2188         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2189         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2190         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2191         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2192         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2193         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2194         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2195         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2196         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2197         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2198         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2199         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2200         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2201         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2202         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2203         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2204         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2205         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2206         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2207         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2208         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2209
2210 2019-07-10  Tom Tromey  <tromey@adacore.com>
2211
2212         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2213         * breakpoint.c (init_ada_exception_breakpoint): Register as
2214         bp_catchpoint.
2215         (print_one_breakpoint_location, print_one_breakpoint): Use
2216         is_ada_exception_catchpoint.
2217         * ada-lang.c (class ada_catchpoint_location): Pass
2218         bp_loc_software_breakpoint to bp_location constructor.
2219         (is_ada_exception_catchpoint): New function.
2220
2221 2019-07-10  Tom Tromey  <tromey@adacore.com>
2222
2223         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2224         VEC.
2225         (struct arm_exidx_entry): New method operator<.
2226         (struct arm_exidx_data) <section_maps>: Change type.
2227         (arm_exidx_data_free): Remove.
2228         (arm_exidx_data_key): Change type.  Move lower.
2229         (arm_exidx_new_objfile): Update.
2230         (arm_compare_exidx_entries): Remove.
2231         (arm_find_exidx_entry, _initialize_arm_tdep)
2232
2233 2019-07-10  Tom Tromey  <tromey@adacore.com>
2234
2235         * solib-spu.c (ocl_program_data_key): Change type.
2236         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2237         Update.
2238
2239 2019-07-10  Tom Tromey  <tromey@adacore.com>
2240
2241         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2242         (struct solib_aix_inferior_data) <library_list>: Change type.
2243         (solib_aix_inferior_data_handle): Change type.
2244         (get_solib_aix_inferior_data): Update.
2245         (solib_aix_free_library_list): Remove.
2246         (library_list_start_library): Update.
2247         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2248         return type.
2249         (solib_aix_get_library_list)
2250         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2251         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2252
2253 2019-07-10  Tom Tromey  <tromey@adacore.com>
2254
2255         * solib-dsbt.c (struct dsbt_info): Add initializers.
2256         (solib_dsbt_pspace_data): Change type.
2257         (dsbt_pspace_data_cleanup): Remove.
2258         (get_dsbt_info, _initialize_dsbt_solib): Update.
2259
2260 2019-07-10  Tom Tromey  <tromey@adacore.com>
2261
2262         * spu-tdep.c (spu_overlay_data): Change type.
2263         (spu_get_overlay_table, spu_overlay_new_objfile)
2264         (_initialize_spu_tdep): Update.
2265
2266 2019-07-10  Tom Tromey  <tromey@adacore.com>
2267
2268         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2269         destructor.
2270         (dbx_objfile_data_key): Change type and declare later.
2271         (DBX_SYMFILE_INFO): Rewrite.
2272         * dbxread.c (dbx_objfile_data_key): Change type.
2273         (dbx_symfile_init): Update.
2274         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2275         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2276         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2277
2278 2019-07-10  Tom Tromey  <tromey@adacore.com>
2279
2280         * jit.c (jit_program_space_key): Change type.  Move lower.
2281         (get_jit_program_space_data): Update.
2282         (jit_program_space_data_cleanup): Remove.
2283         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2284         Update.
2285         (struct jit_program_space_data): Add initializers.
2286
2287 2019-07-10  Tom Tromey  <tromey@adacore.com>
2288
2289         * solib-darwin.c (struct darwin_info): Add initializers.
2290         (solib_darwin_pspace_data): Change type.
2291         (darwin_pspace_data_cleanup): Remove.
2292         (get_darwin_info, _initialize_darwin_solib): Update.
2293
2294 2019-07-10  Tom Tromey  <tromey@adacore.com>
2295
2296         * remote-sim.c (struct sim_inferior_data): Add initializers,
2297         constructor, and destructor.
2298         (sim_inferior_data_key): Change type.  Move lower.
2299         (check_for_duplicate_sim_descriptor): Update.
2300         (get_sim_inferior_data): Use new.  Update.
2301         (~sim_inferior_data_cleanup): Rename from
2302         sim_inferior_data_cleanup.  Simplify.
2303         (gdbsim_close_inferior, simulator_command)
2304         (sim_command_completer, _initialize_remote_sim): Update.
2305         (next_pid, INITIAL_PID): Move earlier.
2306
2307 2019-07-10  Tom Tromey  <tromey@adacore.com>
2308
2309         * python/python-internal.h (create_thread_object): Return
2310         gdbpy_ref.
2311         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2312         * python/py-inferior.c (struct threadlist_entry): Add
2313         constructor.
2314         <thread_obj>: Now a gdbpy_ref.
2315         (thread_to_thread_object): Update.
2316         (add_thread_object): Use new.
2317         (delete_thread_object): Use delete.
2318         (infpy_threads): Update.
2319         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2320         GIL.
2321
2322 2019-07-10  Tom Tromey  <tromey@adacore.com>
2323
2324         * valops.c (value_cast): Specialize error message for Ada.
2325
2326 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2327
2328         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2329
2330 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2331
2332         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2333         bpstat_should_step): Return bool, adjust comments.
2334         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2335         bpstat_should_step): Likewise.
2336
2337 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2338
2339         * features/Makefile: Use feature target descriptions for Arm.
2340         * features/arm/arm-core.c: Generate new file.
2341         * features/arm/arm-fpa.c: Likewise.
2342         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2343         * features/arm/arm-m-profile.c: Likewise.
2344         * features/arm/arm-vfpv2.c: Likewise.
2345         * features/arm/arm-vfpv3.c: Likewise.
2346         * features/arm/xscale-iwmmxt.c: Likewise.
2347         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2348
2349 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2350
2351         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2352         ptrace earlier.
2353
2354 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2355
2356         * features/aarch64-pauth.c: Regenerate.
2357
2358 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2359
2360         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2361         bool.
2362         (bpstat_what): Use false instead of 0.
2363
2364 2019-07-09  Pedro Alves  <palves@redhat.com>
2365
2366         * break-catch-throw.c (is_exception_catchpoint): New.
2367         * breakpoint.c (print_one_breakpoint_location): New parameter
2368         'raw_loc'.  Handle it.  Use
2369         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2370         looking at the breakpoint's type.
2371         (print_one_breakpoint): If handling "maint info breakpoints", also
2372         print locations of exception catchpoints.
2373         * breakpoint.h (is_exception_catchpoint): Declare.
2374
2375 2019-07-09  Pedro Alves  <palves@redhat.com>
2376
2377         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2378         "addr" field.
2379         (allocate_location_exception_catchpoint): New.
2380         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2381         (initialize_throw_catchpoint_ops): Install
2382         allocate_location_exception_catchpoint as allocate_location
2383         method.
2384         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2385         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2386         bp_loc_other.
2387         (breakpoint_address_is_meaningful): Delete.
2388         (bl_address_is_meaningful): New.
2389         (breakpoint_locations_match): Adjust comment.
2390         (bp_location_from_bp_type): New, factored out of...
2391         (bp_location::bp_location(breakpoint *)): ... this.
2392         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2393         factored out of...
2394         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2395         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2396         breakpoint_address_is_meaningful.
2397         (bp_locations_compare): Adjust comment.
2398         (update_global_location_list): Use bl_address_is_meaningful
2399         instead of breakpoint_address_is_meaningful.
2400         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2401         explicit.
2402         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2403         * python/py-breakpoint.c (bppy_get_location): No longer check
2404         whether location is null.
2405
2406 2019-07-09  Pedro Alves  <palves@redhat.com>
2407
2408         PR c++/15468
2409         * breakpoint.c (print_one_breakpoint_location): Remove
2410         single-location assert.
2411
2412 2019-07-09  Tom Tromey  <tom@tromey.com>
2413
2414         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2415         * configure: Rebuild.
2416         * configure.ac: Change common to gdbsupport.
2417         * gdbsupport: Rename from common.
2418         * acinclude.m4: Change common to gdbsupport.
2419         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2420         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2421         gdbsupport.
2422         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2423         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2424         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2425         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2426         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2427         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2428         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2429         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2430         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2431         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2432         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2433         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2434         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2435         coff-pe-read.c, command.h, compile/compile-c-support.c,
2436         compile/compile-c.h, compile/compile-cplus-symbols.c,
2437         compile/compile-cplus-types.c, compile/compile-cplus.h,
2438         compile/compile-loc2c.c, compile/compile.c, completer.c,
2439         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2440         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2441         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2442         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2443         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2444         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2445         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2446         features/aarch64-core.c, features/aarch64-fpu.c,
2447         features/aarch64-pauth.c, features/aarch64-sve.c,
2448         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2449         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2450         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2451         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2452         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2453         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2454         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2455         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2456         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2457         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2458         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2459         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2460         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2461         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2462         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2463         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2464         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2465         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2466         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2467         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2468         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2469         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2470         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2471         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2472         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2473         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2474         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2475         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2476         minsyms.c, mips-linux-tdep.c, namespace.h,
2477         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2478         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2479         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2480         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2481         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2482         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2483         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2484         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2485         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2486         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2487         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2488         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2489         procfs.c, producer.c, progspace.h, psymtab.h,
2490         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2491         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2492         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2493         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2494         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2495         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2496         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2497         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2498         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2499         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2500         target-memory.c, target.c, target.h, target/waitstatus.c,
2501         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2502         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2503         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2504         unittests/array-view-selftests.c,
2505         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2506         unittests/common-utils-selftests.c,
2507         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2508         unittests/format_pieces-selftests.c,
2509         unittests/function-view-selftests.c,
2510         unittests/lookup_name_info-selftests.c,
2511         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2512         unittests/mkdir-recursive-selftests.c,
2513         unittests/observable-selftests.c,
2514         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2515         unittests/parse-connection-spec-selftests.c,
2516         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2517         unittests/scoped_fd-selftests.c,
2518         unittests/scoped_mmap-selftests.c,
2519         unittests/scoped_restore-selftests.c,
2520         unittests/string_view-selftests.c, unittests/style-selftests.c,
2521         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2522         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2523         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2524         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2525         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2526         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2527
2528 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2531         bool value.
2532         (decode_digits_ordinary): Set explicit_line field in sal.
2533         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2534         symtab_and_line that was set on an explicit line number in
2535         assembler code.  Do always update the recorded symtab and line if
2536         we do skip the prologue.
2537
2538 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2539
2540         * breakpoint.c (set_breakpoint_location_function): Remove
2541         explicit_loc parameter.
2542         (momentary_breakpoint_from_master): Update call to
2543         set_breakpoint_location_function.
2544         (add_location_to_breakpoint): Likewise.
2545
2546 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2549         required features based on default bfd type when no specific bfd
2550         is present.
2551
2552 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2553
2554         * NEWS: Mention that GDB printf and eval commands can now print
2555         C-style and Ada-style convenience var strings without
2556         calling the inferior.
2557         * printcmd.c (printf_c_string): Locally print GDB internal var
2558         instead of transiting via the inferior.
2559         (printf_wide_c_string): Likewise.
2560
2561 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2562
2563         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2564
2565 2019-07-04  Tom Tromey  <tom@tromey.com>
2566
2567         PR tui/24724:
2568         * tui/tui-winsource.c (tui_clear_source_content): Update.
2569         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2570         (tui_update_breakpoint_info): Update.
2571         (tui_set_exec_info_content): Update.
2572         * tui/tui-source.c (tui_set_source_content_nil): Update.
2573         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2574         has_break.
2575         * tui/tui-data.h (enum tui_bp_flag): New.
2576         (tui_bp_flags): New enum flags type.
2577         (struct tui_source_element) <break_mode>: Change type.  Rename
2578         from has_break.
2579         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2580         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2581         constants.
2582         * tui/tui-winsource.h: Fix comment.
2583
2584 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2587         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2588         (store_fpregs_to_thread)
2589         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2590         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2591         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2592         (IWMMXT_REGS_SIZE): Add define.
2593         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2594         (fetch_vfp_regs, store_vfp_regs)
2595         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2596         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2597
2598 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2599
2600         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2601         defines.
2602         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2603         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2604         (ARM_INT_REGISTER_SIZE): ...to this.
2605         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2606         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2607         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2608         (arm_linux_collect_gregset, supply_nwfpe_register)
2609         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2610         defines.
2611         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2612         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2613         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2614         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2615         (arm_return_in_memory, arm_store_return_value)
2616         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2617         (arm_record_ld_st_multiple): Likewise.
2618         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2619         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2620
2621 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2622
2623         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2624         AARCH64_DISPLACED_MODIFIED_INSNS.
2625         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2626         (aarch64_displaced_step_copy_insn): Likewise.
2627         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2628         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2629         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2630         ARM_DISPLACED_MODIFIED_INSNS.
2631         * arm-tdep.c (arm_gdbarch_init): Likewise.
2632         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2633         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2634         (struct arm_displaced_step_closure): Use
2635         ARM_DISPLACED_MODIFIED_INSNS.
2636
2637 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2638
2639         * features/Makefile: Remove unused xml files.
2640         * features/aarch64.xml: Remove.
2641         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2642         * features/i386/amd64-avx-avx512.xml: Remove.
2643         * features/i386/amd64-avx-linux.xml: Remove.
2644         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2645         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2646         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2647         * features/i386/amd64-avx-mpx.xml: Remove.
2648         * features/i386/amd64-avx.xml: Remove.
2649         * features/i386/amd64-linux.xml: Remove.
2650         * features/i386/amd64-mpx-linux.xml: Remove.
2651         * features/i386/amd64-mpx.xml: Remove.
2652         * features/i386/amd64.xml: Remove.
2653         * features/i386/i386-avx-avx512-linux.xml: Remove.
2654         * features/i386/i386-avx-avx512.xml: Remove.
2655         * features/i386/i386-avx-linux.xml: Remove.
2656         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2657         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2658         * features/i386/i386-avx-mpx-linux.xml: Remove.
2659         * features/i386/i386-avx-mpx.xml: Remove.
2660         * features/i386/i386-avx.xml: Remove.
2661         * features/i386/i386-linux.xml: Remove.
2662         * features/i386/i386-mmx-linux.xml: Remove.
2663         * features/i386/i386-mmx.xml: Remove.
2664         * features/i386/i386-mpx-linux.xml: Remove.
2665         * features/i386/i386-mpx.xml: Remove.
2666         * features/i386/i386.xml: Remove.
2667         * features/i386/x32-avx-avx512-linux.xml: Remove.
2668         * features/i386/x32-avx-linux.xml: Remove.
2669         * features/i386/x32-linux.xml: Remove.
2670
2671 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2672
2673         * regformats/aarch64.dat: Remove.
2674         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2675         * regformats/i386/amd64-avx-linux.dat: Remove.
2676         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2677         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2678         * regformats/i386/amd64-linux.dat: Remove.
2679         * regformats/i386/amd64-mpx-linux.dat: Remove.
2680         * regformats/i386/amd64.dat: Remove.
2681         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2682         * regformats/i386/i386-avx-linux.dat: Remove.
2683         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2684         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2685         * regformats/i386/i386-linux.dat: Remove.
2686         * regformats/i386/i386-mmx-linux.dat: Remove.
2687         * regformats/i386/i386-mpx-linux.dat: Remove.
2688         * regformats/i386/i386.dat: Remove.
2689         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2690         * regformats/i386/x32-avx-linux.dat: Remove.
2691         * regformats/i386/x32-linux.dat: Remove.
2692
2693 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2694
2695         * aarch64-tdep.c: Remove xml self tests.
2696         * amd64-linux-tdep.c: Likewise.
2697         * amd64-tdep.c: Likewise.
2698         * i386-linux-tdep.c: Likewise.
2699         * i386-tdep.c: Likewise.
2700
2701 2019-07-03  Pedro Alves  <palves@redhat.com>
2702
2703         PR cli/24732
2704         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2705         (pipe_cmd_option_defs): New.
2706         (make_pipe_cmd_options_def_group): New.
2707         (pipe_command): Use gdb::option::process_options.
2708         (pipe_command_completer): New function.
2709         (_initialize_cli_cmds): Install completer for "pipe" command.
2710
2711 2019-07-03  Pedro Alves  <palves@redhat.com>
2712
2713         * cli/cli-option.c (union option_value) <string>: New field.
2714         (struct option_def_and_value): Add ctor, move ctor, dtor and
2715         use DISABLE_COPY_AND_ASSIGN.
2716         (option_def_and_value::clear_value): New.
2717         (parse_option, save_option_value_in_ctx, get_val_type_str)
2718         (add_setshow_cmds_for_options): Handle var_string.
2719         * cli-option.h (union option_def::var_address) <string>: New
2720         field.
2721         (struct string_option_def): New.
2722         * maint-test-options.c (struct test_options_opts): Add default
2723         ctor and use DISABLE_COPY_AND_ASSIGN.
2724         <string_opt>: New field.
2725         (test_options_opts::~test_options_opts): New.
2726         (test_options_opts::dump): Also dump "-string".
2727         (test_options_option_defs): Install "string.
2728
2729 2019-07-03  Pedro Alves  <palves@redhat.com>
2730
2731         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2732         option_value with a null enumeration.
2733         (complete_options): Save the option values in the context.
2734         (save_option_value_in_ctx): New, factored out from ...
2735         (process_options): ... here.
2736         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2737         of the function.
2738         * maint-test-options.c (test_options_opts::dump): New, factored
2739         out from ...
2740         (maintenance_test_options_command_mode): ... here.
2741         (maintenance_test_options_command_completion_result): Delete.
2742         (maintenance_test_options_command_completion_text): Update
2743         comment.
2744         (maintenance_show_test_options_completion_result): Change
2745         prototype.  Just print
2746         maintenance_test_options_command_completion_text.
2747         (save_completion_result): New.
2748         (maintenance_test_options_completer_mode): Pass options context to
2749         complete_options, and then save a dump.
2750         (_initialize_maint_test_options): Use add_cmd to install "maint
2751         show test-options-completion-result".
2752
2753 2019-07-03  Pedro Alves  <palves@redhat.com>
2754
2755         * NEWS (New commands): Mention "with" and "maint with".
2756         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2757         (with_command, with_command_completer): New.
2758         (pipe_command): Adjust to new repeat_previous
2759         interface.
2760         (_initialize_cli_cmds): Install the "with" command and its "w"
2761         alias.
2762         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2763         declarations.
2764         * cli/cli-setshow.c (parse_cli_var_uinteger)
2765         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2766         argument strings for all var_types.
2767         (get_setshow_command_value_string): New, factored out from ...
2768         (do_show_command): ... this.
2769         * cli/cli-setshow.h: Include <string>.
2770         (get_setshow_command_value_string): Declare.
2771         * command.h (repeat_previous): Now returns const char *.  Adjust
2772         comment.
2773         * maint.c: Include "cli/cli-cmds.h".
2774         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2775         (_initialize_maint_cmds): Register the "maintenance with" command.
2776         * top.c (repeat_previous): Move bits from pipe_command here:
2777         Return the saved command line, if any; error out if there's no
2778         command to relaunch.
2779
2780 2019-07-03  Pedro Alves  <palves@redhat.com>
2781
2782         * NEWS (New commands): Mention "maint set/show test-settings"
2783         instead of "maint test-settings".
2784         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2785         (maintenance_test_settings_set_list): Rename to ...
2786         (maintenance_set_test_settings_list): ... this.
2787         (maintenance_test_settings_show_list): Rename to  ...
2788         (maintenance_show_test_settings_list): ... this.
2789         (maintenance_test_settings_cmd): Delete.
2790         (maintenance_test_settings_set_cmd): ...
2791         (maintenance_set_test_settings_cmd): ... this.
2792         (maintenance_test_settings_show_cmd): ...
2793         (maintenance_show_test_settings_cmd): ... this.
2794         (maintenance_test_settings_show_value_cmd):
2795         (maintenance_show_test_settings_value_cmd): ... this.
2796         (_initialize_maint_test_settings): No longer install the "maint
2797         test-settings" prefix command.  Rename "maint test-settings set"
2798         to "maint set test-settings", and "maint test-settings show" to
2799         "maint show test-settings".  Adjust all subcommands.
2800
2801 2019-07-03  Pedro Alves  <palves@redhat.com>
2802
2803         * maint-test-settings.c: Fix file's intro comment.  Replace all
2804         references to "test-options" with references to "test-settings",
2805         in comments.
2806
2807 2019-07-03  Pedro Alves  <palves@redhat.com>
2808
2809         * maint-test-settings.c (maintenance_test_settings_xxx)
2810         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2811         New.
2812         (maintenance_test_settings_enums): Use them.
2813         (maintenance_test_settings_enum): Default to
2814         maintenance_test_settings_xxx.
2815         (_initialize_maint_test_settings): Initialize
2816         MAINTENANCE_TEST_SETTINGS_FILENAME.
2817
2818 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2819
2820         * breakpoint.h (remove_breakpoints_inf): Change return type to
2821         void, move function documentation here.
2822         * breakpoint.c (remove_breakpoints_inf): Change return type to
2823         void, move function documentation to header.
2824
2825 2019-07-02  Pedro Alves  <palves@redhat.com>
2826
2827         * NEWS (Completion improvements): Mention "info threads".
2828         * thread.c (struct info_threads_opts, info_threads_option_defs)
2829         (make_info_threads_options_def_group): New.
2830         (info_threads_command): Use gdb::option::process_options.
2831         (info_threads_command_completer): New.
2832         (_initialize_thread): Use gdb::option::build_help to build the
2833         help text for "info threads".
2834
2835 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2836
2837         * defs.h (generic_load): Move from here...
2838         * symfile.h (generic_load): ... to here.  Rename name parameter
2839         to args.
2840         * symfile.c (generic_load): Add comment.
2841
2842 2019-07-01  Tom Tromey  <tromey@adacore.com>
2843
2844         * dwarf2read.c
2845         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2846         declaration of without_params.  Fix formatting.
2847
2848 2019-07-01  Tom Tromey  <tromey@adacore.com>
2849
2850         * ada-exp.y (find_primitive_type): Update.
2851         * ada-lang.h (ada_lookup_symbol): Update.
2852         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2853         parameter.
2854         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2855
2856 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2857
2858         PR breakpoints/24541
2859         * gdbarch.c: Regenerate.
2860         * gdbarch.h: Regenerate.
2861         * gdbarch.sh: Add 'stap_adjust_register'.
2862         * i386-tdep.c: Include '<unordered_set>'.
2863         (i386_stap_adjust_register): New function.
2864         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2865         * stap-probe.c (stap_parse_register_operand): Call
2866         'gdbarch_stap_adjust_register'.
2867
2868 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2869
2870         PR python/24742
2871         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2872         * python/python.c (do_start_initialization): Use 'xmalloc'
2873         instead of 'PyMem_Malloc'.
2874
2875 2019-06-28  Tom Tromey  <tromey@adacore.com>
2876
2877         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2878         for Ada.
2879
2880 2019-06-27  Tom Tromey  <tromey@adacore.com>
2881
2882         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2883         objfile_key.
2884         (arm_find_mapping_symbol, arm_record_special_symbol)
2885         (_initialize_arm_tdep): Update.
2886         (arm_objfile_data_free): Remove.
2887
2888 2019-06-27  Tom Tromey  <tromey@adacore.com>
2889
2890         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2891         to cp_print_static_field.
2892
2893 2019-06-26  Tom Tromey  <tromey@adacore.com>
2894
2895         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2896         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2897         declare.
2898
2899 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2900
2901         * features/aarch64-core.c (create_feature_aarch64_core):
2902         Regenerate.
2903         * features/aarch64-core.xml: Add cpsr flags.
2904
2905 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2906
2907         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2908         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2909
2910 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2911
2912         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2913         field.
2914         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2915         use.
2916         (arm_record_special_symbol): Don't insert new symbol in sorted
2917         position, push it at the end.
2918
2919 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2920
2921         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2922         (arm_mapping_symbol_s): Remove.
2923         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2924         (arm_mapping_symbol_vec): New typedef.
2925         (struct arm_per_objfile): Add constructor.
2926         <section_maps>: Change type to
2927         std::unique_ptr<arm_mapping_symbol_vec[]>.
2928         (arm_compare_mapping_symbols): Remove.
2929         (arm_find_mapping_symbol): Adjust to section_maps type change.
2930         (arm_objfile_data_free): Call delete on arm_per_objfile.
2931         (arm_record_special_symbol): Adjust to section_maps type change.
2932         Allocate arm_per_objfile with new.
2933
2934 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2935
2936         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2937         with the command prefix.
2938
2939 2019-06-25  Tom Tromey  <tom@tromey.com>
2940
2941         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2942         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2943
2944 2019-06-25  Tom Tromey  <tom@tromey.com>
2945
2946         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2947         type.
2948         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2949         protected.
2950
2951 2019-06-25  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-winsource.c
2954         (tui_source_window_base::set_is_exec_point_at): Add check against
2955         LOA_ADDRESS.
2956
2957 2019-06-25  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-source.c (tui_set_source_content): Don't check before
2960         xfree.
2961         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-winsource.h (tui_update_source_window_as_is)
2966         (tui_alloc_source_buffer, tui_line_is_displayed)
2967         (tui_addr_is_displayed): Change type of win_info.
2968         * tui/tui-winsource.c (tui_update_source_window_as_is)
2969         (tui_clear_source_content, tui_show_source_line)
2970         (tui_show_source_content, tui_source_window_base::refill)
2971         (tui_source_window_base::set_is_exec_point_at)
2972         (tui_source_window_base::set_is_exec_point_at)
2973         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2974         (tui_alloc_source_buffer, tui_line_is_displayed)
2975         (tui_addr_is_displayed): Change type of win_info.  Update.
2976         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2977         (tui_source_window_base::do_make_visible_with_new_height):
2978         Update.
2979         * tui/tui-source.c (tui_set_source_content)
2980         (tui_set_source_content_nil)
2981         (tui_source_window::do_scroll_vertical): Update.
2982         * tui/tui-layout.c (show_layout): Update.
2983         * tui/tui-disasm.c (tui_set_disassem_content)
2984         (tui_disasm_window::do_scroll_vertical): Update.
2985         * tui/tui-data.h (tui_win_content): Remove.
2986         (struct tui_gen_win_info) <content, content_size>: Remove.
2987         (struct tui_source_element): Add initializers and destructor.
2988         (union tui_which_element, struct tui_win_element): Remove.
2989         (struct tui_source_window_base) <content>: New field.
2990         (struct tui_data_window): Remove destructor.
2991         (tui_alloc_content, tui_free_win_content)
2992         (tui_free_all_source_wins_content): Don't declare.
2993         * tui/tui-data.c (tui_initialize_static_data): Update.
2994         (init_content_element, tui_alloc_content): Remove.
2995         (~tui_gen_win_info): Update.
2996         (~tui_data_window, tui_free_all_source_wins_content)
2997         (tui_free_win_content, free_content, free_content_elements):
2998         Remove.
2999
3000 2019-06-25  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-winsource.h (tui_clear_source_content)
3003         (tui_erase_source_content, tui_show_source_content): Change type
3004         of win_info.
3005         * tui/tui-winsource.c (tui_clear_source_content)
3006         (tui_erase_source_content, tui_show_source_content): Change type
3007         of win_info.
3008         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3009         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3010         win_info.
3011         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3012         win_info.
3013         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3014
3015 2019-06-25  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-winsource.c (tui_clear_source_content)
3018         (tui_source_window_base::set_is_exec_point_at): Update.
3019         * tui/tui-source.c (tui_set_source_content_nil): Update.
3020         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3021         a bool.
3022         * tui/tui-data.c (init_content_element): Update.
3023
3024 2019-06-25  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3027         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3028         * tui/tui-layout.c (init_and_make_win): Update.
3029         * tui/tui.h (enum tui_win_type): Update.
3030         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3031         tui_win_is_auxillary.
3032         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3033         tui_win_is_auxillary.
3034
3035 2019-06-25  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3038         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3039         (tui_delete_data_content_windows, tui_display_all_data)
3040         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3041         Update.
3042         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3043         * tui/tui-regs.c (tui_last_regs_line_no)
3044         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3045         (tui_show_registers): Update.
3046         (tui_show_register_group): Return void.  Update.
3047         (tui_display_registers_from, tui_display_reg_element_at_line)
3048         (tui_display_registers_from_line, tui_check_register_values):
3049         Update.
3050         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3051         member.
3052         (struct tui_data_window) <regs_content>: Now a std::vector.
3053         <regs_content_count>: Remove.
3054         (tui_add_content_elements, tui_free_data_content): Don't declare.
3055         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3056         (init_content_element): Remove DATA_WIN case.  Add assert.
3057         (tui_add_content_elements): Remove.
3058         (tui_data_window): Update.
3059         (tui_free_data_content): Remove.
3060         (free_content_elements): Remove DATA_WIN case.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-data.c (tui_data_item_window): Update.
3065         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3066         * tui/tui-windata.c (tui_display_all_data)
3067         (tui_display_data_from_line): Update.
3068         (tui_check_data_values): Remove.
3069         * tui/tui-regs.c (tui_show_register_group)
3070         (tui_display_reg_element_at_line): Update.
3071         * tui/tui-hooks.c (tui_register_changed)
3072         (tui_refresh_frame_and_register_information): Call
3073         tui_check_register_values.
3074         * tui/tui-data.h (struct tui_data_window) <data_content,
3075         data_content_count, data_type>: Remove.
3076         (enum tui_data_type): Remove.
3077
3078         * tui/tui-data.c (tui_data_window::clear_detail)
3079         (~tui_data_window): Update.
3080
3081 2019-06-25  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3084         declare.
3085         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3086         Rename from tui_first_data_item_displayed.  Update.
3087         (tui_data_window::refresh_all)
3088         (tui_data_window::do_scroll_vertical): Update.
3089         * tui/tui-data.h (struct tui_data_window)
3090         <first_data_item_displayed>: Declare new method.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3095         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3096         contents...
3097         (tui_initialize_static_data): ...here.
3098
3099 2019-06-25  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3102         (tui_display_registers_from, tui_check_register_values): Update.
3103         (tui_display_register): Remove win_info parameter; update.
3104         (tui_get_register): Change type of parameters.
3105         * tui/tui-data.h (struct tui_data_element): Remove.
3106         (union tui_which_element) <data>: Remove.
3107         <data_window>: Change type.
3108         (struct tui_data_item_window): New.
3109         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3110         case.  Add assert.
3111         (~tui_data_item_window): New destructor.
3112         (free_content_elements): Remove DATA_ITEM_WIN case.
3113
3114 2019-06-25  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3117         Remove.
3118
3119 2019-06-25  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-data.h (struct tui_command_element): Remove.
3122         (union tui_which_element) <command>: Remove.
3123         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3124         assert.
3125         (free_content_elements): Remove CMD_WIN case.
3126
3127 2019-06-25  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-layout.c (tui_set_layout): Update.
3130         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3131         * tui/tui-data.c (layout_def): Update.
3132
3133 2019-06-25  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3136         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3137         (tui_source_window_base::set_new_height): Update.
3138         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3139         Update.
3140         (tui_set_locator_fullname, tui_set_locator_info)
3141         (tui_show_frame_info): Update.
3142         * tui/tui-source.c (tui_set_source_content)
3143         (tui_source_is_displayed): Update.
3144         * tui/tui-layout.c (show_source_disasm_command, show_data)
3145         (show_source_or_disasm_and_command): Update.
3146         * tui/tui-disasm.c (tui_set_disassem_content)
3147         (tui_get_begin_asm_address): Update.
3148         * tui/tui-data.h (struct tui_locator_element): Remove.
3149         (union tui_which_element) <locator>: Remove.
3150         (struct tui_locator_window): New.
3151         (tui_locator_win_info_ptr): Change return type.
3152         * tui/tui-data.c (_locator): Change type.
3153         (tui_locator_win_info_ptr): Change return type.
3154         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3155         (tui_alloc_content): Add assert.
3156
3157 2019-06-25  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-winsource.c
3160         (tui_exec_info_window::maybe_allocate_content): New method.
3161         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3162         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3163         (make_source_or_disasm_window): Add cast.
3164         * tui/tui-data.h (union tui_which_element) <simple_string>:
3165         Remove.
3166         (struct tui_source_info): New.
3167         (struct tui_source_window_base) <execution_info>: Change type.
3168         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3169         case, and add assert.
3170         (tui_alloc_content): Add assert.
3171
3172 2019-06-25  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3175         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3176         * tui/tui-data.c (tui_alloc_win_info): Remove.
3177
3178 2019-06-25  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3181         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3182         can_highlight.
3183
3184 2019-06-25  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3187         make_visible_with_new_height method.
3188         (tui_win_info::make_visible_with_new_height): New method.
3189         (tui_source_window_base::do_make_visible_with_new_height)
3190         (tui_data_window::do_make_visible_with_new_height)
3191         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3192         (make_visible_with_new_height): Remove.
3193         (tui_resize_all, tui_adjust_win_heights): Use
3194         make_visible_with_new_height method.
3195         * tui/tui-data.h (struct tui_win_info)
3196         <do_make_visible_with_new_height, make_visible_with_new_height>:
3197         New methods.
3198         (struct tui_source_window_base, struct tui_data_window)
3199         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3200         methods.
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3205         method.
3206         (update_tab_width): Call update_tab_width method.
3207         * tui/tui-data.h (struct tui_win_info)
3208         (struct tui_source_window_base) <update_tab_width>: New methods.
3209
3210 2019-06-25  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3213         parameter.
3214         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3215         parameter.
3216         (tui_gen_win_info::make_visible): Update.
3217         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3218         parameter.
3219         * tui/tui-data.h (enum tui_box): New enum.
3220         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3221
3222 2019-06-25  Tom Tromey  <tom@tromey.com>
3223
3224         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3225         init_and_make_win for EXEC_INFO_WIN.
3226         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3227         longer inline.
3228         (struct tui_win_info) <~tui_win_info>: Inline.
3229         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3230         Don't declare.
3231         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3232         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3233         Remove.
3234         (tui_initialize_static_data): Update.
3235         (~tui_gen_win_info): Handle more cleanup here.
3236         (~tui_source_window_base): Delete "execution_info".
3237         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3238
3239 2019-06-25  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-layout.c (make_command_window): Don't set
3242         can_highlight.
3243         (show_source_disasm_command): Call the reset method.
3244         (show_data): Don't set can_highlight.  Call the reset method.
3245         (tui_gen_win_info::reset): Rename from init_gen_win_info
3246         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3247         (show_source_or_disasm_and_command): Call the reset method.
3248         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3249         (struct tui_cmd_window): Set can_highlight.
3250
3251 2019-06-25  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3254         from make_visible.
3255         (tui_make_visible, tui_make_invisible): Rewrite.
3256         (tui_win_info::make_visible): Remove.
3257         (tui_source_window_base::make_visible): Update.
3258         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3259         method.  Moved from...
3260         (struct tui_win_info) <make_visible>: ...here.
3261
3262 2019-06-25  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-winsource.c
3265         (tui_source_window_base::do_scroll_horizontal): Remove direction
3266         parameter.
3267         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3268         direction parameter.
3269         * tui/tui-win.c (tui_win_info::forward_scroll)
3270         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3271         (tui_win_info::right_scroll): Update.
3272         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3273         direction parameter.
3274         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3275         direction parameter.
3276         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3277         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3278         Remove direction parameter.
3279         (struct tui_source_window_base, struct tui_source_window)
3280         (struct tui_disasm_window, struct tui_data_window)
3281         (struct tui_cmd_window): Update.
3282
3283 2019-06-25  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-winsource.h (tui_set_exec_info_content)
3286         (tui_show_exec_info_content, tui_erase_exec_info_content)
3287         (tui_clear_exec_info_content, tui_update_exec_info): Change
3288         argument to tui_source_window_base.
3289         * tui/tui-winsource.c (tui_set_exec_info_content)
3290         (tui_show_exec_info_content, tui_erase_exec_info_content)
3291         (tui_clear_exec_info_content, tui_update_exec_info): Change
3292         argument to tui_source_window_base.
3293
3294 2019-06-25  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3297         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3298
3299 2019-06-25  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3302         check.
3303
3304 2019-06-25  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3307         type to void.
3308         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3309         type to void.
3310         * tui/tui-source.c (tui_set_source_content): Update.
3311         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3312
3313 2019-06-25  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-win.c (window_name_completer, tui_set_focus)
3316         (tui_all_windows_info): Use name method.
3317         * tui/tui-data.h (struct tui_gen_win_info)
3318         (struct tui_source_window, struct tui_disasm_window)
3319         (struct tui_data_window, struct tui_cmd_window) <name>: New
3320         method.
3321         (tui_win_name): Don't declare.
3322         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3323         (tui_win_name): Remove.
3324
3325 2019-06-25  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.h (tui_update_source_window)
3328         (tui_update_source_window_as_is): Change parameter type.
3329         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3330         to be a tui_source_window_base.
3331         (tui_update_source_window_as_is): Likewise.
3332         * tui/tui-win.c (make_visible_with_new_height): Update.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-winsource.c (tui_erase_source_content)
3337         (tui_show_source_content, tui_show_exec_info_content)
3338         (tui_erase_exec_info_content): Use refresh_window method.
3339         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3340         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3341         from tui_refresh_win.
3342         (tui_data_window::refresh_window): New method.
3343         (tui_win_info::refresh, tui_source_window_base::refresh)
3344         (tui_refresh_all): Use refresh_window method.
3345         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3346         method.
3347         * tui/tui-regs.c (tui_display_register): Call refresh_window
3348         method.
3349         * tui/tui-layout.c (show_source_disasm_command)
3350         (show_source_or_disasm_and_command): Call refresh_window method.
3351         * tui/tui-data.h (struct tui_gen_win_info)
3352         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3353         New method.
3354
3355 2019-06-25  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui.c (tui_rl_other_window, tui_enable)
3358         (tui_is_window_visible, tui_get_command_dimension): Update.
3359         * tui/tui-winsource.c (tui_update_source_window_as_is)
3360         (tui_clear_source_content, tui_erase_source_content)
3361         (tui_show_source_line, tui_source_window_base::refill)
3362         (tui_source_window_base::do_scroll_horizontal)
3363         (tui_source_window_base::set_is_exec_point_at)
3364         (tui_update_breakpoint_info, tui_set_exec_info_content)
3365         (tui_alloc_source_buffer, tui_line_is_displayed)
3366         (tui_addr_is_displayed): Update.
3367         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3368         (tui_check_and_display_highlight_if_needed)
3369         (tui_win_info::make_visible, tui_win_info::refresh)
3370         (tui_refresh_all): Update.
3371         * tui/tui-windata.c (tui_first_data_item_displayed)
3372         (tui_delete_data_content_windows, tui_erase_data_content)
3373         (tui_display_all_data, tui_data_window::refresh_all)
3374         (tui_check_data_values): Update.
3375         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3376         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3377         (tui_win_info::backward_scroll, tui_refresh_all_win)
3378         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3379         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3380         (tui_source_window_base::set_new_height)
3381         (tui_data_window::set_new_height)
3382         (make_invisible_and_set_new_height)
3383         (make_visible_with_new_height, new_height_ok)
3384         (parse_scrolling_args): Update.
3385         * tui/tui-stack.c (tui_show_frame_info): Update.
3386         * tui/tui-source.c (tui_set_source_content)
3387         (tui_set_source_content_nil, tui_source_is_displayed)
3388         (tui_source_window::do_scroll_vertical): Update.
3389         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3390         (tui_display_registers_from, tui_display_reg_element_at_line)
3391         (tui_check_register_values, tui_reg_command): Update.
3392         * tui/tui-layout.c (tui_default_win_height)
3393         (show_source_disasm_command, show_data, init_and_make_win)
3394         (show_source_or_disasm_and_command): Update.
3395         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3396         (tui_redisplay_readline, tui_mld_flush)
3397         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3398         (tui_getc): Update.
3399         * tui/tui-disasm.c (tui_set_disassem_content)
3400         (tui_disasm_window::do_scroll_vertical): Update.
3401         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3402         Now virtual.
3403         (struct tui_win_info): Derive from tui_gen_win_info.
3404         <~tui_win_info>: Mark as override.
3405         <generic>: Remove member.
3406         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3407         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3408         (~tui_data_window, ~tui_win_info)
3409         (tui_free_all_source_wins_content): Update.
3410         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3411
3412 2019-06-25  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-layout.c (init_and_make_win): Use new.
3415         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3416         destructor, initializers.
3417         (tui_alloc_generic_win_info): Don't declare.
3418         * tui/tui-data.c (_locator): Add argument to constructor.
3419         (source_win, disasm_win): New globals.
3420         (exec_info): Remove.
3421         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3422         Update.
3423         (tui_alloc_generic_win_info): Remove.
3424         (init_content_element): Use new.
3425         (tui_win_info::tui_win_info): Update.
3426         (free_content_elements) <case DATA_WIN>: Use delete.
3427
3428 2019-06-25  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3431         * tui/tui-windata.c (tui_first_data_item_displayed)
3432         (tui_delete_data_content_windows): Update.
3433         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3434         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3435         (tui_display_registers_from, tui_check_register_values): Update.
3436         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3437         pointer.
3438         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3439         window.
3440         (tui_free_data_content): Update.
3441         (free_content_elements) <case DATA_WIN>: Free the window.
3442
3443 2019-06-25  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3446         Update.
3447         * tui/tui-layout.c (make_command_window)
3448         (show_source_disasm_command, show_data, init_and_make_win)
3449         (show_source_or_disasm_and_command): Update.
3450         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3451         method.
3452         <can_highight, is_highlighted>: Now bool.
3453         (tui_set_win_highlight): Don't declare.
3454         * tui/tui-data.c (tui_set_win_highlight): Remove.
3455
3456 2019-06-25  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-wingeneral.c (make_visible): Remove check of window
3459         type.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-win.c (tui_win_info::max_height)
3464         (tui_cmd_window::max_height): New methods.
3465         (new_height_ok): Call max_height.
3466         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3467         <max_height>: New method.
3468
3469 2019-06-25  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-win.c (tui_source_window_base::set_new_height)
3472         (tui_data_window::set_new_height): New methods.
3473         (make_invisible_and_set_new_height): Call set_new_height method.
3474         * tui/tui-data.h (struct tui_win_info)
3475         (struct tui_source_window_base, struct tui_data_window)
3476         <set_new_height>: New method.
3477
3478 2019-06-25  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3481         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3482         tui_refresh_data_win.
3483         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3484         method.
3485         (tui_refresh_all_win): Call the refresh_all method.
3486         (tui_set_focus): Likewise.
3487         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3488         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3489         Likewise.
3490
3491 2019-06-25  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-winsource.h (tui_refill_source_window)
3494         (tui_set_is_exec_point_at): Don't declare.
3495         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3496         (tui_source_window_base::refill): Rename from
3497         tui_refill_source_window.
3498         (tui_source_window_base::do_scroll_horizontal): Update.
3499         (tui_source_window_base::set_is_exec_point_at): Rename from
3500         tui_set_is_exec_point_at.
3501         (tui_update_all_breakpoint_info): Update.
3502         * tui/tui-stack.c (tui_show_frame_info): Update.
3503         * tui/tui-layout.c (show_data): Add cast.
3504         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3505         * tui/tui-data.h (struct tui_source_window_base) <refill,
3506         set_is_exec_point_at>: New methods.
3507         (tui_source_windows, tui_add_to_source_windows): Update types.
3508         (tui_add_to_source_windows): Remove redundant declaration.
3509         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3510         (tui_source_windows): Change return type.
3511         (tui_clear_source_windows_detail): Update.
3512         (tui_add_to_source_windows): Change type of parameter.
3513         (tui_free_all_source_wins_content): Update.
3514
3515 2019-06-25  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-wingeneral.c (tui_win_info::refresh)
3518         (tui_source_window_base::refresh): New methods.
3519         (tui_refresh_all): Call the refresh method.
3520         * tui/tui-data.h (struct tui_win_info)
3521         (struct tui_source_window_base) <refresh>: New method.
3522
3523 2019-06-25  Tom Tromey  <tom@tromey.com>
3524
3525         * tui/tui.h (tui_is_window_visible): Return bool.
3526         * tui/tui.c (tui_is_window_visible): Return bool.
3527         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3528         (tui_make_visible, tui_make_invisible)
3529         (tui_win_info::make_visible)
3530         (tui_source_window_base::make_visible, make_all_visible)
3531         (tui_make_all_visible, tui_make_all_invisible): Update.
3532         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3533         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3534         bool.
3535         (struct tui_win_info, struct tui_source_window_base)
3536         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3537         * tui/tui-data.c (tui_init_generic_part): Update.
3538
3539 2019-06-25  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3542         (tui_source_window_base::make_visible): New methods.
3543         (make_all_visible): Make method call.
3544         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3545         (struct tui_source_window_base, struct tui_cmd_window): Override
3546         make_visible.
3547         (tui_win_is_source_type): Don't declare.
3548         * tui/tui-data.c (tui_win_is_source_type): Remove.
3549
3550 2019-06-25  Tom Tromey  <tom@tromey.com>
3551
3552         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3553         NULL check.
3554
3555 2019-06-25  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3558         Inline constructor.  Add initializers for members.
3559         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3560         constructors; now inline in class.
3561
3562 2019-06-25  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-regs.c (tui_show_registers): Update.
3565         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3566         bool.
3567         * tui/tui-data.c (tui_data_window::clear_detail)
3568         (tui_data_window): Update.
3569
3570 2019-06-25  Tom Tromey  <tom@tromey.com>
3571
3572         * tui/tui-windata.c (tui_display_all_data)
3573         (tui_display_data_from_line, tui_display_data_from)
3574         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3575         Update.
3576         * tui/tui-regs.c (tui_last_regs_line_no)
3577         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3578         (tui_show_registers, tui_show_register_group)
3579         (tui_display_registers_from, tui_display_reg_element_at_line)
3580         (tui_display_registers_from_line, tui_check_register_values)
3581         (tui_reg_next, tui_reg_prev): Update.
3582         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3583         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3584         tui_data_window.
3585         (struct tui_win_info) <detail>: Remove.  Add new fields from
3586         tui_data_info.
3587         (TUI_DATA_WIN): Add cast.
3588         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3589         (~tui_data_window): Simplify.
3590
3591 2019-06-25  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui-layout.c (show_source_disasm_command)
3594         (show_source_or_disasm_and_command): Update.
3595         * tui/tui-io.c (update_cmdwin_start_line)
3596         (tui_redisplay_readline): Update.
3597         * tui/tui-data.h (struct tui_command_info): Remove.
3598         (struct tui_win_info) <detail>: Remove command_info member.
3599         (struct tui_data_window) <start_line>: New member, from
3600         tui_command_info.
3601         (TUI_CMD_WIN): Add casts.
3602
3603 2019-06-25  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-winsource.c (tui_update_source_window)
3606         (tui_refill_source_window)
3607         (tui_source_window_base::do_scroll_horizontal)
3608         (tui_update_breakpoint_info, tui_set_exec_info_content)
3609         (tui_show_exec_info_content, tui_erase_exec_info_content)
3610         (tui_clear_exec_info_content): Update.
3611         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3612         Update.
3613         * tui/tui-win.c (make_invisible_and_set_new_height)
3614         (make_visible_with_new_height): Update.
3615         * tui/tui-source.c (tui_set_source_content)
3616         (tui_show_symtab_source): Update.
3617         * tui/tui-layout.c (extract_display_start_addr)
3618         (show_source_disasm_command, show_data)
3619         (make_source_or_disasm_window)
3620         (show_source_or_disasm_and_command): Update.
3621         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3622         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3623         "gdbarch".
3624         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3625         to tui_source_window_base.
3626         (struct tui_win_info) <detail>: Remove source_info member.
3627         (struct tui_source_window_base) <has_locator>: Inline.
3628         Move contents from tui_source_info; rename has_locator member to
3629         m_has_locator.
3630         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3631         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3632         header file.
3633         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3634         Simplify.
3635         (tui_free_all_source_wins_content): Cast to
3636         tui_source_window_base.
3637
3638 2019-06-25  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-win.c (make_invisible_and_set_new_height)
3641         (make_visible_with_new_height): Call has_locator method.
3642         * tui/tui-layout.c (show_source_disasm_command, show_data)
3643         (show_source_or_disasm_and_command): Update for bool change.
3644         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3645         (tui_win_info) <has_locator>: New method.
3646         (struct tui_source_window_base) <has_locator>: New method.
3647         (tui_win_has_locator): Don't declare.
3648         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3649         from tui_win_has_locator.
3650         (tui_source_window_base): Use false, not FALSE.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3655         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3656         clear_detail method directly.
3657         (tui_clear_win_detail): Remove.
3658
3659 2019-06-25  Tom Tromey  <tom@tromey.com>
3660
3661         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3662         "this", not TUI_DISASM_WIN.
3663
3664 2019-06-25  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3667         declare.
3668         * tui/tui-winsource.c
3669         (tui_source_window_base::do_scroll_horizontal): Rename from
3670         tui_horizontal_source_scroll.
3671         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3672         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3673         from tui_vertical_data_scroll.
3674         * tui/tui-win.h (tui_scroll): Don't declare.
3675         * tui/tui-win.c (tui_win_info::forward_scroll)
3676         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3677         (tui_win_info::right_scroll): Rename and update.
3678         (tui_scroll_forward_command, tui_scroll_backward_command)
3679         (tui_scroll_left_command, tui_scroll_right_command): Update.
3680         (tui_scroll): Remove.
3681         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3682         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3683         from tui_vertical_source_scroll.
3684         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3685         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3686         from tui_vertical_disassem_scroll.
3687         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3688         do_scroll_horizontal>: New methods.
3689         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3690         Likewise.
3691         (struct tui_source_window_base): Add do_scroll_horizontal.
3692         (struct tui_source_window, struct tui_disasm_window): Add
3693         do_scroll_vertical.
3694         (struct tui_data_window, struct tui_cmd_window): Add
3695         do_scroll_horizontal and do_scroll_vertical.
3696         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3697
3698 2019-06-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-data.h (struct tui_source_window_base): New struct.
3701         (struct tui_source_window): Derive from tui_source_window_base.
3702         (struct tui_disasm_window): New struct.
3703         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3704         from tui_source_window::clear_detail.
3705         (tui_source_window_base): Rename from tui_source_window.
3706         (~tui_source_window_base): Rename from ~tui_source_window.
3707         (tui_alloc_win_info): Create a tui_disasm_window.
3708
3709 2019-06-25  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-data.h (struct tui_source_window)
3712         (struct tui_data_window): Declare destructors.
3713         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3714         destructors.
3715         (tui_win_info): Simplify.
3716
3717 2019-06-25  Tom Tromey  <tom@tromey.com>
3718
3719         * tui/tui-winsource.c (tui_display_main)
3720         (tui_update_source_windows_with_addr)
3721         (tui_update_all_breakpoint_info): Update.
3722         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3723         (new_height_ok, parse_scrolling_args): Update.
3724         * tui/tui-stack.c (tui_show_frame_info): Update.
3725         * tui/tui-data.h (struct tui_list): Remove.
3726         (tui_source_windows): Return a reference to a std::vector.
3727         * tui/tui-data.c (source_windows): Now a std::vector.
3728         (tui_source_windows): Change return type.
3729         (tui_clear_source_windows): Rewrite.
3730         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3731         (tui_free_all_source_wins_content): Rewrite.
3732
3733 2019-06-25  Tom Tromey  <tom@tromey.com>
3734
3735         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3736         (struct tui_data_window, struct tui_cmd_window): Declare
3737         clear_detail method.
3738         * tui/tui-data.c (tui_source_window::clear_detail)
3739         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3740         methods.
3741         (tui_clear_win_detail): Simplify.
3742
3743 2019-06-25  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-layout.c (make_source_window, make_disasm_window)
3746         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3747         Return the new window.
3748         (show_source_disasm_command, show_data)
3749         (show_source_or_disasm_and_command): Update.
3750
3751 2019-06-25  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3754         parameter.  Return the new window.
3755         (show_source_disasm_command): Update and remove NULL check.
3756         (show_source_or_disasm_and_command): Update.
3757
3758 2019-06-25  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3761
3762 2019-06-25  Tom Tromey  <tom@tromey.com>
3763
3764         * tui/tui-data.h (struct tui_win_info): Make constructor
3765         protected.  Make destructor virtual.  Add initializers.
3766         (tui_source_window, tui_data_window, tui_cmd_window): New
3767         classes.
3768         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3769         constructor.  Add "type" parameter.
3770         (tui_source_window, tui_data_window, tui_cmd_window): New
3771         constructors.
3772         (tui_alloc_win_info): Instantiate the appropriate subclass.
3773
3774 2019-06-25  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-win.c (tui_resize_all): Use delete.
3777         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3778         destructor.
3779         (tui_free_window): Don't declare.
3780         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3781         Update.
3782
3783 2019-06-25  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-data.h (struct tui_win_info): Add constructor.
3786         * tui/tui-data.c (tui_alloc_win_info): Use new.
3787         (tui_free_window): Use delete.
3788
3789 2019-06-22  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3792         declare.
3793         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3794
3795 2019-06-22  Tom Tromey  <tom@tromey.com>
3796
3797         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3798         declare.
3799         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3800
3801 2019-06-22  Tom de Vries  <tdevries@suse.de>
3802
3803         * dwarf2read.c (create_addrmap_from_aranges)
3804         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3805         instead of '%zu'.
3806
3807 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3808
3809         * dwarf2read.h (dwarf2_section_info_def): Remove.
3810         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3811         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3812         std::vector<dwarf2_section_info>.
3813         (struct dwo_file) <~dwo_file>: Remove.
3814         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3815         types field.
3816         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3817         (dwarf2_read_debug_names): Likewise.
3818         (create_debug_types_hash_table): Change parameter type to
3819         array_view, adjust code accordingly.
3820         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3821         (partial_die_info::fixup): Likewise.
3822         (determine_prefix): Likewise.
3823         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3824
3825 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3826
3827         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3828         gdb_bfd_ref_ptr.
3829         <~dwo_file>: Remove call to gdb_bfd_unref.
3830         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3831         gdb_bfd_ref_ptr::get.
3832
3833 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3834
3835         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3836         type to htab_up.
3837         * dwarf2read.c (struct dwo_file): Initialize fields.
3838         <~dwo_file>: New.
3839         (free_dwo_file): Remove, move content to ~dwo_file.
3840         (struct dwo_file_deleter): Remove.
3841         (dwo_file_up>: Remove custom deleter.
3842         (free_dwo_files): Remove.
3843         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3844         dwo_files.
3845         (process_skeletonless_type_units): Call unique_ptr::get.
3846         (allocate_dwo_file_hash_table): Add deleter to created hash
3847         table.  Change return type to htab_up.
3848         (lookup_dwo_file_slot): Don't memset dwo_file, call
3849         unique_ptr::get.
3850         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3851         (create_dwo_unit_in_dwp_v2): Likewise.
3852         (open_and_init_dwo_file): Likewise.
3853         (free_dwo_file_from_slot): Remove.
3854
3855 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3856
3857         * dwarf2read.h (struct dwarf2_section_info) <readin,
3858         is_virtual>: Change type to bool.
3859         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3860         true instead of 1.
3861
3862 2019-06-19  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui-data.h (tui_init_content_element): Don't declare.
3865
3866 2019-06-19  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-data.h (tui_init_win_info): Don't declare.
3869
3870 2019-06-19  Tom de Vries  <tdevries@suse.de>
3871
3872         * dwarf2read.h (abstract_to_concrete): Change type to
3873         std::unordered_map<sect_offset, std::vector<sect_offset>,
3874         gdb::hash_enum<sect_offset>>.
3875
3876 2019-06-19  Tom Tromey  <tromey@adacore.com>
3877
3878         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3879         EVAL_AVOID_SIDE_EFFECTS specially.
3880
3881 2019-06-19  Tom Tromey  <tromey@adacore.com>
3882
3883         * source-cache.c (highlighter): New global.
3884         (source_cache::get_source_lines): Create a highlighter on demand.
3885
3886 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3887
3888         * defs.h (deprecated_interactive_hook): Delete declaration.
3889         * interps.c (clear_interpreter_hooks): Remove use of
3890         deprecated_interactive_hook.
3891         * top.c (deprecated_interactive_hook): Delete definition.
3892         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3893
3894 2019-06-18  Tom de Vries  <tdevries@suse.de>
3895
3896         PR gdb/24515
3897         * dwarf2read.h (abstract_to_concrete): Change type from
3898         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3899         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3900         * dwarf2read.c (read_variable): Update.
3901         (dwarf2_fetch_die_loc_sect_off): Update.
3902
3903 2019-06-17  Tom de Vries  <tdevries@suse.de>
3904
3905         PR gdb/24617
3906         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3907         accessing parent[parent_len - 1].
3908
3909 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3910
3911         PR gdb/24364
3912         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3913         call dtrace_process_dof with NULL dof.
3914
3915 2019-06-16  Tom de Vries  <tdevries@suse.de>
3916
3917         PR gdb/24445
3918         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3919
3920 2019-06-16  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3923         (make_all_visible): Use address of member.
3924
3925 2019-06-16  Tom Tromey  <tom@tromey.com>
3926
3927         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3928         (tui_free_window, free_content, free_content_elements): Remove
3929         unnecessary cast.
3930         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3931         cast.
3932         * tui/tui-regs.c (tui_show_register_group)
3933         (tui_display_registers_from, tui_display_reg_element_at_line):
3934         Remove unnecessary cast.
3935
3936 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * linux-nat.c (normal_mask): Delete.
3939         (_initialize_linux_nat): Don't initialise normal_mask.
3940
3941 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3942
3943         PR gdb/24445
3944         * dwarf-index-write.h (write_psymtabs_to_index): Add
3945         dwz_basename parameter.
3946         * dwarf-index-write.c (write_gdbindex): Move file writing to
3947         write_gdbindex_1.  Change return type void.
3948         (assert_file_size): Move up, remove filename parameter.
3949         (write_gdbindex_1): New function.
3950         (write_debug_names): Change return type to void, call
3951         assert_file_size.
3952         (struct index_wip_file): New struct.
3953         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3954         file logic to index_wip_file.  Write index for dwz file if
3955         needed.
3956         (save_gdb_index_command): Pass basename of dwz file, if present.
3957         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3958         build-id of dwz file, if present.
3959         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3960         (dwarf2_get_dwz_file): Likewise.
3961         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3962         (dwarf2_get_dwz_file): Likewise.
3963
3964 2019-06-16  Tom Tromey  <tom@tromey.com>
3965
3966         * coffread.c (process_coff_symbol): Use xstrdup.
3967         * value.c (create_internalvar): Use xstrdup.
3968
3969 2019-06-16  Tom Tromey  <tom@tromey.com>
3970
3971         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3972         * breakpoint.c (stopin_command, stopat_command)
3973         (until_break_command, decode_location_default): Remove unnecessary
3974         cast.
3975         * utils.c (subset_compare): Remove unnecessary cast.
3976         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3977         cast.
3978         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3979         cast.
3980         * infcmd.c (path_command): Remove unnecessary cast.
3981         * coffread.c (decode_type): Remove unnecessary cast.
3982         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3983         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3984         * tui/tui-stack.c (tui_show_locator_content)
3985         (tui_show_frame_info): Remove unnecessary cast.
3986         * tui/tui-win.c (tui_scroll_forward_command)
3987         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3988         (parse_scrolling_args): Remove unnecessary cast.
3989         * tui/tui-data.c (init_win_info, tui_del_window)
3990         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3991         (free_content_elements): Remove unnecessary cast.
3992         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3993         unnecessary cast.
3994         * tui/tui-source.c (tui_set_source_content)
3995         (tui_vertical_source_scroll): Remove unnecessary cast.
3996         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3997         cast.
3998         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3999         * tui/tui-regs.c (tui_display_registers_from)
4000         (tui_display_register): Remove unnecessary cast.
4001         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4002         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4003         (make_visible): Remove unnecessary cast.
4004         * tui/tui-winsource.c (tui_erase_source_content)
4005         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4006         unnecessary cast.
4007         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4008         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4009         * stabsread.c (read_type, read_array_type, read_range_type):
4010         Remove unnecessary cast.
4011         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4012         (parse_symbol, parse_type, upgrade_type, parse_external)
4013         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4014         unnecessary cast.
4015         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4016
4017 2019-06-16  Tom Tromey  <tom@tromey.com>
4018
4019         * tui/tui-data.c (tui_alloc_generic_win_info)
4020         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4021         checks.
4022
4023 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4024             Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         * f-typeprint.c (f_print_type): Don't return early for not
4027         associated or not allocated types.
4028         (f_type_print_varspec_suffix): Add print_rank parameter and print
4029         ranks of array types in case they dangling.
4030         (f_type_print_base): Add print_rank parameter.
4031
4032 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * NEWS: Mention new MI commands.
4035         * break-catch-throw.c (enum exception_event_kind): Move to
4036         breakpoint.h.
4037         (print_mention_exception_catchpoint): Output text as a single
4038         message.
4039         (catch_exception_command_1): Rename to...
4040         (catch_exception_event): ...this, make non-static, update header
4041         command, and change some parameter types.
4042         (catch_catch_command): Update for changes to
4043         catch_exception_command_1.
4044         (catch_throw_command): Likewise.
4045         (catch_rethrow_command): Likewise.
4046         * breakpoint.c (enum exception_event_kind): Delete.
4047         * breakpoint.h (enum exception_event_kind): Moved here from
4048         break-catch-throw.c.
4049         (catch_exception_event): Declare.
4050         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4051         (mi_cmd_catch_throw): New function.
4052         (mi_cmd_catch_rethrow): New function.
4053         (mi_cmd_catch_catch): New function.
4054         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4055         'catch-catch' entries.
4056         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4057         (mi_cmd_catch_rethrow): Declare.
4058         (mi_cmd_catch_catch): Declare.
4059
4060 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4061
4062         * annotate.c (annotate_source_line): Change return type to void,
4063         update implementation to match.
4064         * annotate.h (annotate_source_line): Change return type to void,
4065         update header comment.
4066         * stack.c (print_frame_info): Don't change what frame information
4067         is printed based on whether annotations are on or not.
4068
4069 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4072         (annotate_source): Make static.
4073         (annotate_source_line): Moved from source.c and renamed from
4074         identify_source_line.  Update the return type.
4075         * annotate.h (annotate_source): Delete declaration.
4076         (annotate_source_line): Declaration moved from source.h, and
4077         renamed from identify_source_line.  Return type updated.
4078         * source.c (identify_source_line): Moved to annotate.c and renamed
4079         to annotate_source_line.
4080         (info_line_command): Remove check of annotation_level.
4081         * source.h (identify_source_line): Move declaration to annotate.h
4082         and rename to annotate_source_line.
4083         * stack.c: Add 'annotate.h' include.
4084         (print_frame_info): Remove check of annotation_level before
4085         calling annotate_source_line.
4086
4087 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * source-cache.c (source_cache::get_plain_source_lines): Use
4090         open_source_file_with_line_charpos instead of just
4091         open_source_file, remove call to find_source_lines.
4092         (source_cache::get_source_lines): Likewise.
4093         * source.c (find_source_lines): Make static.
4094         (get_filename_and_charpos): Renamed into...
4095         (open_source_file_with_line_charpos): ..this along with changes to
4096         return a scoped_fd, and some other minor clean ups.
4097         (identify_source_line): Use open_source_file_with_line_charpos.
4098         (search_command_helper): Use open_source_file_with_line_charpos
4099         instead of just open_source_file, remove call to
4100         find_source_lines.
4101         * source.h (open_source_file_with_line_charpos): Declare new
4102         function.
4103         (find_source_lines): Delete declaration.
4104
4105 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * source.c (get_filename_and_charpos): Remove fullname
4108         parameter.
4109         (identify_source_line): Update call to get_filename_and_charpos.
4110
4111 2019-06-14  Tom Tromey  <tromey@adacore.com>
4112
4113         PR gdb/24502:
4114         * ui-style.h (skip_ansi_escape): Update comment.
4115         * ui-file.h (class no_terminal_escape_file): New class.
4116         * ui-file.c (no_terminal_escape_file::write)
4117         (no_terminal_escape_file::puts): New methods.
4118         * cli/cli-logging.c (handle_redirections): Use
4119         no_terminal_escape_file.
4120
4121 2019-06-14  Tom Tromey  <tromey@adacore.com>
4122
4123         * NEWS: Move convenience variable news above Python news.
4124
4125 2019-06-14  Tom Tromey  <tom@tromey.com>
4126
4127         * gnulib: Move directory to top-level.
4128         * configure.ac: Don't configure gnulib.
4129         * configure: Rebuild.
4130         * common/common-defs.h: Use new path to gnulib.
4131         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4132         (GNULIB_H): Remove.
4133         (INCGNU): Look in new gnulib location.
4134         (HFILES_NO_SRCDIR): Remove gnulib files.
4135         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4136         (generated_files): Remove GNULIB_H.
4137         ($(LIBGNU), all-lib): Remove targets.
4138         (distclean): Don't mention GNULIB_BUILDDIR.
4139         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4140
4141 2019-06-14  Tom Tromey  <tromey@adacore.com>
4142
4143         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4144         Warn if symbol file does not provide any symbols.
4145
4146 2019-06-14  Tom Tromey  <tromey@adacore.com>
4147
4148         * source.c (find_and_open_source): Respect basenames_may_differ.
4149
4150 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4151
4152         * annotate.c (annotate_breakpoints_invalid): Make use of
4153         scoped_restore_terminal_state.
4154         (annotate_frames_invalid): Likewise.
4155
4156 2019-06-14  Tom Tromey  <tromey@adacore.com>
4157
4158         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4159         allow assignment to an internalvar.
4160
4161 2019-06-14  Tom Tromey  <tromey@adacore.com>
4162
4163         * ada-lex.l: Allow "_" in attribute names.
4164
4165 2019-06-14  Tom Tromey  <tromey@adacore.com>
4166
4167         PR gdb/24653:
4168         * regcache.c (registers_changed): Don't call alloca.
4169         * top.c (execute_command): Don't call alloca.
4170
4171 2019-06-13  Pedro Alves  <palves@redhat.com>
4172
4173         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4174         'expression'.  When parsing an expression, error out if there's
4175         junk after "unlimited".
4176         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4177         (do_set_command): Adjust calls to is_unlimited_literal.
4178
4179 2019-06-13  Pedro Alves  <palves@redhat.com>
4180
4181         * compile/compile.c (make_compile_options_def_group): Add braces
4182         around array_view initializer.
4183         * thread.c (make_thread_apply_all_options_def_group)
4184         (make_thread_apply_all_options_def_group): Likewise.
4185
4186 2019-06-13  Pedro Alves  <palves@redhat.com>
4187
4188         * NEWS (New commands): Mention "maint test-options
4189         require-delimiter", "maint test-options unknown-is-error", "maint
4190         test-options unknown-is-operand" and "maint show
4191         test-options-completion-result".
4192         (New command options, command completion): New section.
4193         (Completion improvements): New section.
4194         Mention that you can abbreviate "unlimited".
4195
4196 2019-06-13  Pedro Alves  <palves@redhat.com>
4197
4198         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4199         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4200         * unittests/cli-utils-selftests.c (test_parse_flags)
4201         (test_parse_flags_qcs): Delete.
4202         (test_cli_utils): Don't call deleted functions.
4203
4204 2019-06-13  Pedro Alves  <palves@redhat.com>
4205
4206         * thread.c: Include "cli/cli-option.h".
4207         (tp_array_compar_ascending): Global.
4208         (tp_array_compar): Delete function.
4209         (tp_array_compar_ascending, tp_array_compar_descending): New
4210         functions.
4211         (ascending_option_def, qcs_flag_option_def)
4212         (thr_qcs_flags_option_defs)
4213         (make_thread_apply_all_options_def_group)
4214         (make_thread_apply_options_def_group): New.
4215         (thread_apply_all_command): Use gdb::option::process_options.
4216         (thread_apply_command_completer)
4217         (thread_apply_all_command_completer): New.
4218         (thread_apply_command): Use gdb::option::process_options.
4219         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4220         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4221         to generate help text of "thread apply".  Adjust "taas"'s help.
4222         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4223         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4224
4225 2019-06-13  Pedro Alves  <palves@redhat.com>
4226
4227         * thread.c (thread_apply_command): Check for invalid TID with
4228         isdigit instead of !isalpha.
4229
4230 2019-06-13  Pedro Alves  <palves@redhat.com>
4231
4232         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4233         (validate_flags_qcs): New.
4234         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4235         (validate_flags_qcs): Declare.
4236         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4237         (make_frame_apply_options_def_group): New.
4238         (frame_apply_command_count): Process options with
4239         gdb::option::process_options.
4240         (frame_apply_completer): New.
4241         (frame_apply_level_completer, frame_apply_all_completer)
4242         (frame_apply_completer): New.
4243         (_initialize_stack): Update help of "frame apply", "frame apply
4244         level", "frame apply all" and "faas" to mention supported options
4245         and install command completers.
4246         * stack.h (frame_apply_all_completer): Declare.
4247         * thread.c: Include "stack.h".
4248         (tfaas_command): Add "--".
4249         (_initialize_thread): Update help "tfaas" to mention supported
4250         options and install command completer.
4251
4252 2019-06-13  Pedro Alves  <palves@redhat.com>
4253
4254         * completer.c (complete_nested_command_line): New.
4255         (gdb_completion_word_break_characters_throw): Add assertion.
4256         * completer.h (complete_nested_command_line): Declare.
4257
4258 2019-06-13  Pedro Alves  <palves@redhat.com>
4259
4260         * stack.c (parse_backtrace_qualifiers): New.
4261         (backtrace_command): Use it.
4262         (backtrace_command_completer): Complete on qualifiers.
4263
4264 2019-06-13  Pedro Alves  <palves@redhat.com>
4265
4266         * frame.c: Include "cli/cli-option.h.
4267         (user_set_backtrace_options): New.
4268         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4269         Delete.
4270         (get_prev_frame): Adjust.
4271         (boolean_option_def, uinteger_option_def)
4272         (set_backtrace_option_defs): New.
4273         (_initialize_frame): Adjust and use
4274         gdb::option::add_setshow_cmds_for_options to install "set
4275         backtrace past-main" and "set backtrace past-entry".
4276         * frame.h: Include "cli/cli-option.h".
4277         (struct frame_print_options): Forward declare.
4278         (print_frame_arguments_all, print_frame_arguments_scalars)
4279         (print_frame_arguments_none): Declare.
4280         (print_entry_values): Delete declaration.
4281         (struct frame_print_options, user_frame_print_options): New.
4282         (struct set_backtrace_options): New.
4283         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4284         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4285         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4286         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4287         (list_args_or_locals): Add frame_print_options parameter.
4288         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4289         * python/py-framefilter.c (enumerate_args): Pass down
4290         USER_FRAME_PRINT_OPTIONS.
4291         * stack.c: Include "cli/cli-option.h".
4292         (print_frame_arguments_all, print_frame_arguments_scalars)
4293         (print_frame_arguments_none): Declare.
4294         (print_raw_frame_arguments, print_entry_values): Delete.
4295         (user_frame_print_options): New.
4296         (boolean_option_def, enum_option_def, frame_print_option_defs):
4297         New.
4298         (struct backtrace_cmd_options): New.
4299         (bt_flag_option_def): New.
4300         (backtrace_command_option_defs): New.
4301         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4302         (print_frame_arg, read_frame_arg, print_frame_args)
4303         (print_frame_info, print_frame): Add frame_print_options parameter
4304         and use it.
4305         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4306         (backtrace_command_1): Add frame_print_options and
4307         backtrace_cmd_options parameters and use them.
4308         (make_backtrace_options_def_group): New.
4309         (backtrace_command): Process command options with
4310         gdb::option::process_options.
4311         (backtrace_command_completer): New.
4312         (_initialize_stack): Extend "backtrace"'s help to mention
4313         supported options.  Install completer for "backtrace".
4314         Install some settings commands with add_setshow_cmds_for_options.
4315
4316 2019-06-13  Pedro Alves  <palves@redhat.com>
4317
4318         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4319         and that "set/show print raw frame-arguments" are now deprecated.
4320
4321         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4322         command.
4323         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4324         * stack.c (_initialize_stack): Install "set/show print
4325         raw-frame-arguments", and deprecate "set/show print raw
4326         frame-arguments".
4327         * valprint.c (_initialize_valprint): Deprecate "set/show print
4328         raw".
4329
4330 2019-06-13  Pedro Alves  <palves@redhat.com>
4331
4332         * compile/compile.c (struct compile_options): New.
4333         (compile_flag_option_def, compile_command_option_defs)
4334         (make_compile_options_def_group): New.
4335         (compile_file_command): Handle options with
4336         gdb::option::process_options.
4337         (compile_file_command_completer): New function.
4338         (compile_code_command): Handle options with
4339         gdb::option::process_options.
4340         (compile_code_command_completer): New function.
4341         (_initialize_compiler): Install completers for "compile code" and
4342         "compile file".  Mention available options in "compile code" and
4343         "compile code"'s help.
4344         * completer.c (advance_to_completion_word): New, factored out from
4345         ...
4346         (advance_to_expression_complete_word_point): ... this.
4347         (advance_to_filename_complete_word_point): New.
4348         * completer.h (advance_to_filename_complete_word_point): New
4349         declaration.
4350
4351 2019-06-13  Pedro Alves  <palves@redhat.com>
4352
4353         * compile/compile.c: Include "cli/cli-option.h".
4354         (compile_print_value): Scope data pointer is now a
4355         value_print_options pointer; adjust.
4356         (compile_print_command): Process options.  Scope data pointer is
4357         now a value_print_options pointer; adjust.
4358         (_initialize_compile): Update "compile print"'s help to include
4359         supported options.  Install a completer for "compile print".
4360         * cp-valprint.c (show_vtblprint, show_objectprint)
4361         (show_static_field_print): Delete.
4362         (_initialize_cp_valprint): Don't install "set print
4363         static-members", "set print vtbl", "set print object" here.
4364         * printcmd.c: Include "cli/cli-option.h" and
4365         "common/gdb_optional.h".
4366         (print_command_parse_format): Rework to fill in a
4367         value_print_options instead of a format_data.
4368         (print_value): Change parameter type from format_data pointer to
4369         value_print_options reference.  Adjust.
4370         (print_command_1): Process options.  Adjust to pass down a
4371         value_print_options.
4372         (print_command_completer): New.
4373         (_initialize_printcmd): Install print_command_completer as
4374         handle_brkchars completer for the "print" command.  Update
4375         "print"'s help to include supported options.
4376         * valprint.c: Include "cli/cli-option.h".
4377         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4378         here from cp-valprint.c.
4379         (boolean_option_def, uinteger_option_def)
4380         (value_print_option_defs, make_value_print_options_def_group):
4381         New.  Use gdb::option::add_setshow_cmds_for_options to install
4382         "set print elements", "set print null-stop", "set print repeats",
4383         "set print pretty", "set print union", "set print array", "set
4384         print address", "set print symbol", "set print array-indexes".
4385         * valprint.h: Include <string> and "cli/cli-option.h".
4386         (make_value_print_options_def_group): Declare.
4387         (print_value): Change parameter type from format_data pointer to
4388         value_print_options reference.
4389         (print_command_completer): Declare.
4390
4391 2019-06-13  Pedro Alves  <palves@redhat.com>
4392
4393         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4394         (COMMON_SFILES): Add maint-test-settings.c.
4395         * cli/cli-decode.c (boolean_enums): New global, factored out from
4396         ...
4397         (add_setshow_boolean_cmd): ... here.
4398         * cli/cli-decode.h (boolean_enums): Declare.
4399         * cli/cli-option.c: New file.
4400         * cli/cli-option.h: New file.
4401         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4402         factored out from ...
4403         (parse_cli_boolean_value(const char *)): ... this.
4404         (is_unlimited_literal): Change parameter type to pointer to
4405         pointer.  Adjust and advance ARG pointer.
4406         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4407         (parse_cli_var_enum): New, factored out from ...
4408         (do_set_command): ... this.  Adjust.
4409         * cli/cli-setshow.h (parse_cli_boolean_value)
4410         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4411         (parse_cli_var_enum): Declare.
4412         * cli/cli-utils.c: Include "cli/cli-option.h".
4413         (get_ulongest): New.
4414         * cli/cli-utils.h (get_ulongest): Declare.
4415         (check_for_argument): New overloads.
4416         * maint-test-options.c: New file.
4417
4418 2019-06-13  Pedro Alves  <palves@redhat.com>
4419
4420         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4421         parse a range if "-" is at the end of the string.
4422
4423 2019-06-13  Pedro Alves  <palves@redhat.com>
4424
4425         * cli/cli-setshow.c (parse_auto_binary_operation)
4426         (parse_cli_boolean_value): Don't allow "o".
4427
4428 2019-06-13  Pedro Alves  <palves@redhat.com>
4429
4430         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4431         * NEWS: Mention maint test-settings KIND.
4432         * maint-test-settings.c: New file.
4433
4434 2019-06-13  Pedro Alves  <palves@redhat.com>
4435
4436         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4437         completer.
4438         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4439         "set" completers.
4440
4441 2019-06-13  Pedro Alves  <palves@redhat.com>
4442
4443         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4444         after item.
4445
4446 2019-06-13  Pedro Alves  <palves@redhat.com>
4447
4448         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4449
4450 2019-06-13  Pedro Alves <palves@redhat.com>
4451
4452         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4453         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4454         call.
4455         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4456         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4457         calls.
4458         (check_for_argument): Skip spaces after argument.
4459
4460 2019-06-13  Pedro Alves  <palves@redhat.com>
4461
4462         * thread.c (thread_apply_command): Adjust TID parsing.
4463         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4464         detected before end of string.
4465         (tid_is_in_list): Error out if LIST is invalid.
4466
4467 2019-06-13  Pedro Alves  <palves@redhat.com>
4468
4469         * completer.c (complete_line_internal_1): Rewind completion word
4470         point.
4471         (completion_tracker::advance_custom_word_point_by): Change
4472         parameter type to int.
4473         * completer.h (completion_tracker::advance_custom_word_point_by):
4474         Likewise.
4475
4476 2019-06-13  Pedro Alves  <palves@redhat.com>
4477
4478         * completer.c (advance_to_completion_word): Handle delimiters.
4479
4480 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4481
4482         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4483
4484 2019-06-11  Tom Tromey  <tom@tromey.com>
4485
4486         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4487         (xmalloc_failed): Move to alloc.c.
4488         * alloc.c: New file.
4489         * Makefile.in (COMMON_SFILES): Add alloc.c.
4490
4491 2019-06-11  Tom Tromey  <tom@tromey.com>
4492
4493         * nat/linux-waitpid.c: Don't include server.h.
4494         (linux_debug): Remove.
4495         (my_waitpid): Update.
4496
4497 2019-06-11  Tom Tromey  <tromey@adacore.com>
4498
4499         * infcall.c (_initialize_infcall): Remove trailing newline from
4500         help.
4501         * user-regs.c (_initialize_user_regs): Remove trailing newline
4502         from help.
4503         * typeprint.c (_initialize_typeprint): Remove trailing newline
4504         from help.
4505         * reverse.c (_initialize_reverse): Remove trailing newlines from
4506         help.
4507         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4508         from help.
4509         * language.c (add_set_language_command): Remove trailing newline
4510         from help.
4511         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4512         help.
4513         * disasm.c (_initialize_disasm): Remove trailing newline from
4514         help.
4515         * top.c (init_main): Remove trailing newline from help.
4516         * interps.c (_initialize_interpreter): Remove trailing newline
4517         from help.
4518         * btrace.c (_initialize_btrace): Remove trailing newlines from
4519         help.
4520         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4521         from help.
4522         * python/python.c (_initialize_python): Remove trailing newline
4523         from help.
4524         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4525         help.
4526         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4527         from help.  Reformat some text.
4528         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4529         from help.
4530         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4531         newline from help.
4532
4533 2019-06-11  Tom Tromey  <tromey@adacore.com>
4534
4535         * darwin-nat.c (darwin_decode_exception_message)
4536         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4537
4538 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * valops.c (value_slice): Check for not allocated or not
4541         associated values.
4542
4543 2019-06-10  Tom de Vries  <tdevries@suse.de>
4544
4545         PR gdb/24618
4546         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4547         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4548         invalid.
4549
4550 2019-06-10  Tom de Vries  <tdevries@suse.de>
4551
4552         PR gdb/24611
4553         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4554         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4555
4556 2019-06-10  Tom de Vries  <tdevries@suse.de>
4557
4558         PR symtab/24545
4559         * symtab.c (struct demangled_name_entry): Add language field.
4560         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4561         static minimal symbol".  Set and use language field.
4562
4563 2019-06-10  Tom Tromey  <tromey@adacore.com>
4564
4565         * ada-lang.c (_initialize_ada_language): Update help text.
4566
4567 2019-06-10  Tom Tromey  <tromey@adacore.com>
4568
4569         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4570         with a newline.
4571         * guile/guile.c (handle_boot_error): Don't end warning with a
4572         newline.
4573         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4574         warning with a newline.
4575         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4576         newline.
4577         (s12z_frame_cache): Likewise.
4578         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4579         a newline.
4580         * solib-svr4.c (disable_probes_interface): Don't end warning with
4581         a newline.
4582         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4583         newline.
4584         * python/python.c (do_finish_initialization): Don't end warning
4585         with a newline.
4586
4587 2019-06-10  Tom Tromey  <tom@tromey.com>
4588
4589         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4590         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4591         gdbpy_enter.
4592
4593 2019-06-10  Tom Tromey  <tromey@adacore.com>
4594
4595         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4596         data.
4597         (elf_new_init): Don't call stabsread_new_init.
4598         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4599         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4600         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4601
4602 2019-06-10  Tom de Vries  <tdevries@suse.de>
4603
4604         PR symtab/16264
4605         PR symtab/24517
4606         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4607
4608 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4609
4610         * source.c (find_and_open_source): Also rewrite relative file
4611         names.
4612
4613 2019-04-26  Amos Bird  <amosbird@gmail.com>
4614
4615         * annotate.c (annotate_thread_exited): Add "thread-exited"
4616         annotation.
4617
4618 2019-06-06  Tom Tromey  <tromey@adacore.com>
4619
4620         * maint.h (class scoped_command_stats): Use
4621         DISABLE_COPY_AND_ASSIGN.
4622         <print_time>: New method.
4623         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4624         print_time.
4625         (scoped_command_stats::print_time): New method.
4626
4627 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4628
4629         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4630         instructions of lengths 6 or 8 bytes.
4631
4632 2019-06-04  Pedro Alves  <palves@redhat.com>
4633
4634         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4635
4636         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4637         * breakpoint.c (condition_completer): Likewise.
4638         * cli/cli-dump.c (scan_expression): Likewise.
4639         * common/filestuff.c (mkdir_recursive): Likewise.
4640         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4641         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4642         (gdb_abspath): Likewise.
4643         * compile/compile-cplus-types.c
4644         (compile_cplus_instance::decl_name): Likewise.
4645         * completer.c (complete_explicit_location):
4646         (signal_completer, reg_or_group_completer_1): Likewise.
4647         * cp-support.c (cp_remove_params_if_any): Likewise.
4648         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4649         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4650         * infcmd.c (strip_bg_char): Likewise.
4651         * linespec.c (copy_token_string): Likewise.
4652         * mi/mi-main.c (output_cores): Likewise.
4653         * psymtab.c (psymtab_search_name):
4654         * symfile.c (test_set_ext_lang_command): Likewise.
4655         * target.c (target_fileio_read_stralloc): Likewise.
4656         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4657         * value.c (complete_internalvar): Likewise.
4658
4659 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4660
4661         Add objfile property to gdb.Type.
4662         * NEWS: Mention Python API addition.
4663         * python/py-type.c (typy_get_objfile): New method.
4664
4665 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4666
4667         * NEWS: Mention the new set|show style [title|highlight].
4668         Mention changes to "show style", "help" and "apropos".
4669
4670 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4671
4672         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4673         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4674         instead of print_help_for_command.
4675         (print_doc_of_command): New function.
4676         (help_list): Add 'apropos -v word' suggestion.
4677         (print_help_for_command): Style the command name using title style.
4678         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4679         (_initialize_cli_cmds): Describe -v in apropos_command help.
4680
4681 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4682
4683         * cli/cli-style.h (cli_style_option): Add name in constructor,
4684         add m_name class member, add constructor with intensity,
4685         add name class function.
4686         (cli_style_option::add_setshow_commands): Remove name argument.
4687         (highlight_style, title_style): New styles.
4688         * cli/cli-style.c (do_show): New function that shows a style
4689         characteristic styling the style name with itself.
4690         (set_style_name): New function.
4691         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4692         Update all callers according to the changes in cli/cli-style.h.
4693         * utils.h (fputs_highlighted): New function.
4694         * utils.c (fputs_highlighted): Likewise.
4695
4696 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4697
4698         * NEWS: Mention new pipe command and new convenience variables.
4699
4700 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4701
4702         * cli/cli-cmds.c (pipe_command): New function.
4703         (_initialize_cli_cmds): Call add_com for pipe_command.
4704         Define | as an alias for pipe.
4705         (exit_status_set_internal_vars): New function.
4706         (shell_escape): Call exit_status_set_internal_vars.
4707         cli/cli-decode.c (find_command_name_length): Recognize | as
4708         a single character command.
4709
4710 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4711
4712         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4713         top.c (execute_command_to_ui_file): New function, mostly a copy
4714         of execute_command_to_string.
4715         (execute_command_to_string): Implement by calling
4716         execute_command_to_ui_file.
4717
4718 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4719
4720         * top.h (saved_command_line): Remove declaration.
4721         * top.c (previous_saved_command_line, previous_repeat_arguments):
4722         New variables.
4723         (saved_command_line): Make static, define together with other
4724         'repeat variables'.
4725         (dont_repeat): Clear repeat_arguments.
4726         (repeat_previous, get_saved_command_line, save_command_line):
4727         New functions.
4728         (gdb_init): Initialize saved_command_line
4729         and previous_saved_command_line.
4730         * main.c (captured_main_1): Remove saved_command_line initialization.
4731         * event-top.c (handle_line_of_input): Update to use
4732         the new 'repeat' related functions instead of direct access to
4733         saved_command_line.
4734         * command.h (repeat_previous, get_saved_command_line,
4735         save_command_line): New declarations.
4736         (dont_repeat): Add comment.
4737
4738 2019-05-30  Tom Tromey  <tromey@adacore.com>
4739
4740         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4741         Fix comment.
4742         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4743
4744 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4745
4746         PR cli/24587
4747         * completer.c (complete): Initialize variable word.
4748
4749 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4750
4751         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4752         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4753         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4754         'body' is NULL to the outter 'if', protecting the '!is_define'
4755         situation as well.
4756
4757 2019-05-29  Tom Tromey  <tromey@adacore.com>
4758
4759         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4760         (dwarf_unknown): New function.
4761         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4762         (dwarf_type_encoding_name): Use dwarf_unknown.
4763
4764 2019-05-29  Tom Tromey  <tromey@adacore.com>
4765
4766         PR c++/20020:
4767         * cp-valprint.c (cp_print_value_fields): Call
4768         cp_print_static_field inside "try".
4769
4770 2019-05-29  Tom Tromey  <tromey@adacore.com>
4771
4772         * inflow.c (struct terminal_info): Add default operator=.
4773         * configure: Rebuild.
4774         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4775         -Wdeprecated-copy-dtor, -Wredundant-move.
4776
4777 2019-05-29  Tom Tromey  <tromey@adacore.com>
4778
4779         * NEWS: Add entry.
4780         * infcmd.c (print_return_value_1): Handle finish_print
4781         option.
4782         (show_print_finish): New function.
4783         (_initialize_infcmd): Add "set/show print finish" commands.
4784         * valprint.c (user_print_options): Initialize new member.
4785         * valprint.h (struct value_print_options) <finish_print>: New
4786         member.
4787
4788 2019-05-28  Tom Tromey  <tromey@adacore.com>
4789
4790         * ada-lang.c (ada_remove_Xbn_suffix)
4791         (find_old_style_renaming_symbol)
4792         (parse_old_style_renaming): Remove.
4793         (ada_find_renaming_symbol): Don't call
4794         find_old_style_renaming_symbol.
4795         (ada_is_renaming_symbol): Rename from
4796         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4797         bool.  Now static.
4798         (ada_read_var_value): Update and simplify.
4799         * ada-exp.y (write_var_or_type): Remove old code.
4800
4801 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4802
4803         * event-top.c: Remove include comment.
4804         * inflow.c (class scoped_ignore_sigttou): Move from here...
4805         * inflow.h (class scoped_ignore_sigttou): ...to here.
4806         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4807         * top.c:  Remove include comment.
4808
4809 2019-05-27  Tom Tromey  <tom@tromey.com>
4810
4811         * NEWS: Fix typo.
4812
4813 2019-05-22  Tom Tromey  <tromey@adacore.com>
4814
4815         * target.c (target_follow_exec): Constify parameter.
4816         * target-delegates.c: Rebuild.
4817         * remote.c (remote_target::follow_exec): Constify parameter.
4818         * infrun.c (follow_exec): Constify parameter.
4819         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4820         (target_follow_exec): Likewise.
4821
4822 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4823
4824         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4825         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4826
4827 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4828
4829         * NEWS: Add debugredirect and testsuite sections.
4830
4831 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4832
4833         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4834         target descriptions using exclusively floating point register name
4835         aliases.
4836
4837 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4838
4839         PR gdb/18644:
4840         * f-lang.c (build_fortran_types): Handle the case where
4841         gdbarch_floatformat_for_type returns a nullptr.
4842
4843 2019-05-21  Tom de Vries  <tdevries@suse.de>
4844
4845         PR cli/24587
4846         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4847
4848 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4849
4850         PR gdb/18644:
4851         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4852         16-byte floats.
4853         * i386-tdep.c (i386_floatformat_for_type): Use
4854         floatformats_ia64_quad for the 16-byte floating point component
4855         within a fortran 32-byte complex number.
4856
4857 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4858
4859         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4860         delete default constructor.
4861         (find_partial_die): Update to return const struct.
4862         (partial_die_parent_scope): Move variable declaration into scope
4863         of its use and change its type to auto.
4864         (guess_partial_die_structure_name): Likewise.
4865         (partial_die_info::fixup): Likewise.
4866
4867 2019-05-17  Tom Tromey  <tromey@adacore.com>
4868
4869         * source.c (find_and_open_source): Remove cast.
4870
4871 2019-05-17  Tom Tromey  <tromey@adacore.com>
4872
4873         * annotate.c (annotate_source): Make "filename" const.
4874         * annotate.h (annotate_source): Use const.
4875
4876 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4877
4878         * disasm.c (set_disassembler_options): Send errors to stderr.
4879
4880 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4881
4882         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4883         (cli_interp_base::set_logging): Check debug_redirect.
4884         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4885         * cli/cli-logging.c (debug_redirect): Add static variable.
4886         (pop_output_files): Add default param.
4887         (handle_redirections): Print debug setting.
4888         (show_logging_command): Likewise.
4889         (_initialize_cli_logging): Add debugredirect command.
4890         * interps.c (current_interp_set_logging): Add debug_redirect
4891         parameter.
4892         * interps.h (set_logging): Add debug_redirect parameter.
4893         (current_interp_set_logging): Likewise.
4894         * mi/mi-common.h: Likewise.
4895         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4896
4897 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4898             Tom Tromey  <tromey@adacore.com>
4899
4900         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4901         directly.
4902         * cli/cli-interp.h (make_logging_output): Remove declaration.
4903         * cli/cli-logging.c (make_logging_output): Remove function.
4904         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4905         directly.
4906         * ui-file.c (tee_file::tee_file): Remove bools.
4907         (tee_file::~tee_file): Remove deletes.
4908         * ui-file.h (tee_file): Remove bools.
4909
4910 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4911
4912         * mi/mi-cmds.h (mi_cmd_complete): New function.
4913         * mi/mi-main.c (mi_cmd_complete): Likewise.
4914         * mi/mi-cmds.c: Define new MI command -complete.
4915         * NEWS: Mention new -complete command.
4916
4917 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4918
4919         * completer.h (complete): New function.
4920         * completer.c (complete): Likewise.
4921         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4922         function defined in completer.h.
4923
4924 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4925
4926         * MAINTAINERS (Write After Approval): Add myself.
4927
4928 2019-05-17  Tom de Vries  <tdevries@suse.de>
4929
4930         PR gdb/24094
4931         * dwarf2read.c (struct cu_partial_die_info): New struct.
4932         (find_partial_die): Return cu_partial_die_info.
4933         (partial_die_parent_scope, guess_partial_die_structure_name)
4934         (partial_die_info::fixup): Handle new return type of find_partial_die.
4935
4936 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4937
4938         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4939         "std::string", simplifying the algorithm.
4940
4941 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4942
4943         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4944         (stap_static_probe_ops::get_probes): Likewise.
4945
4946 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4947
4948         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4949         '-')" and "else if".
4950         (stap_parse_single_operand): Join checks for
4951         "gdbarch_stap_parse_special_token_p" and
4952         "gdbarch_stap_parse_special_token" in the same "if" statement.
4953         Invert check when verifying for operation on register
4954         displacement.
4955
4956 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4957
4958         * stap-probe.c (stap_get_opcode): Update comment.
4959         (stap_get_expected_argument_type): Likewise.
4960         (handle_stap_probe): Likewise.
4961
4962 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4963
4964         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4965         return type to 'bool'.  Adjust comment.  Use 'bool' when
4966         appropriate.
4967         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4968         * stap-probe.c (stap_parse_argument_1): Likewise.
4969         (stap_is_operator): Likewise.
4970         (stap_is_generic_prefix): Likewise.
4971         (stap_is_register_prefix): Likewise.
4972         (stap_is_register_indirection_prefix): Likewise.
4973         (stap_is_integer_prefix): Likewise.
4974         (stap_generic_check_suffix): Likewise.
4975         (stap_check_integer_suffix): Likewise.
4976         (stap_check_register_suffix): Likewise.
4977         (stap_check_register_indirection_suffix): Likewise.
4978         (stap_parse_register_operand): Likewise.
4979         (stap_parse_single_operand): Likewise.
4980         (stap_parse_argument_1): Likewise.
4981         (stap_probe::get_argument_count): Likewise.
4982         (stap_is_operator): Likewise.
4983
4984 2019-05-16  Tom Tromey  <tromey@adacore.com>
4985
4986         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4987         keyword to foreach.
4988
4989 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4990
4991         * linux-thread-db.c (try_thread_db_load_1): Change return type
4992         to bool.
4993         (try_thread_db_load): Likewise.
4994         (try_thread_db_load_from_pdir_1): Likewise.
4995         (try_thread_db_load_from_pdir): Likewise.
4996         (try_thread_db_load_from_sdir): Likewise.
4997         (try_thread_db_load_from_dir): Likewise.
4998         (thread_db_load_search): Likewise.
4999         (has_libpthread): Likewise.
5000         (thread_db_load): Likewise.
5001
5002 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5003
5004         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5005         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5006         NULL, and complain/return if that's the case.
5007
5008 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5009
5010         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5011         (advance, posn, abstract_read_memory): New functions.
5012         [struct mem_read_abstraction]: New struct.
5013         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5014
5015 2019-05-14  Tom Tromey  <tromey@adacore.com>
5016
5017         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5018         value is not lval_memory.
5019
5020 2019-05-14  Tom Tromey  <tromey@adacore.com>
5021
5022         * solib.c (info_sharedlibrary_command): Style the file name.
5023
5024 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5025
5026         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5027         (aarch64_vnv_type): Likewise.
5028         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5029         * common/tdesc.c: Likewise.
5030         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5031         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5032         * features/aarch64-fpu.xml: Add ieee half view.
5033         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5034         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5035         * gdbtypes.h (struct builtin_type): Likewise.
5036         (struct objfile_type): Likewise.
5037
5038 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5039
5040         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5041         typo.
5042         * location.h (string_to_event_location): Likewise.
5043
5044 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5045
5046         GDB 8.3 released.
5047
5048 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5049
5050         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5051         New variable declaration.
5052         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5053         New variable.
5054         (print_one_breakpoint): Use ui_out::test_flags and new global
5055         variable to compute use_fixed_output.
5056         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5057         Remove.
5058         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5059         (mi_multi_location_breakpoint_output_fixed): Remove.
5060         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5061         new variable.
5062         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5063         fix_multi_location_breakpoint_output flag if version >= 3.
5064         * ui-out.h (enum ui_out_flag)
5065         <fix_multi_location_breakpoint_output>: New enumerator.
5066
5067 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5068
5069         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5070
5071 2019-05-10  Tom Tromey  <tromey@adacore.com>
5072
5073         * ada-lang.c (catch_ada_completer): New function.
5074         (_initialize_ada_language): Use it.
5075
5076 2019-05-10  Tom Tromey  <tromey@adacore.com>
5077
5078         * thread.c (print_thread_info): Make "requested_threads" const.
5079         * gdbthread.h (print_thread_info): Make "requested_threads"
5080         const.
5081         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5082         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5083
5084 2019-05-08  Tom Tromey  <tom@tromey.com>
5085
5086         * gdbtypes.c (objfile_type_data): Change type.
5087         (objfile_type, _initialize_gdbtypes): Update.
5088
5089 2019-05-08  Tom Tromey  <tom@tromey.com>
5090
5091         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5092         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5093         (_initialize_dwarf2_frame): Update.
5094
5095 2019-05-08  Tom Tromey  <tom@tromey.com>
5096
5097         * objc-lang.c (objc_objfile_data): Change type.
5098         (find_methods): Update.
5099         (_initialize_objc_lang): Remove.
5100
5101 2019-05-08  Tom Tromey  <tom@tromey.com>
5102
5103         * stabsread.c (rs6000_builtin_type_data): Change type.
5104         (rs6000_builtin_type, _initialize_stabsread): Update.
5105
5106 2019-05-08  Tom Tromey  <tom@tromey.com>
5107
5108         * mips-tdep.c (mips_pdr_data): Remove.
5109         (_initialize_mips_tdep): Update.
5110
5111 2019-05-08  Tom Tromey  <tom@tromey.com>
5112
5113         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5114         (hppa_init_objfile_priv_data, read_unwind_info)
5115         (find_unwind_entry, _initialize_hppa_tdep): Update.
5116
5117 2019-05-08  Tom Tromey  <tom@tromey.com>
5118
5119         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5120         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5121         on obstack.
5122         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5123
5124 2019-05-08  Tom Tromey  <tom@tromey.com>
5125
5126         * mdebugread.c (basic_type_data): Change type.
5127         (basic_type, _initialize_mdebugread): Update.
5128
5129 2019-05-08  Tom Tromey  <tom@tromey.com>
5130
5131         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5132
5133 2019-05-08  Tom Tromey  <tom@tromey.com>
5134
5135         * nto-tdep.c (nto_inferior_data_reg): Change type.
5136         (nto_inferior_data): Update.
5137         (nto_inferior_data_cleanup, nto_new_inferior_data)
5138         (_initialize_nto_tdep): Remove.
5139         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5140
5141 2019-05-08  Tom Tromey  <tom@tromey.com>
5142
5143         * ada-lang.c (struct ada_inferior_data): Add initializers.
5144         (ada_inferior_data): Change type.
5145         (ada_inferior_data_cleanup): Remove.
5146         (get_ada_inferior_data, ada_inferior_exit)
5147         (struct ada_pspace_data): Add initializers, destructor.
5148         (ada_pspace_data_handle): Change type.
5149         (get_ada_pspace_data): Update.
5150         (ada_pspace_data_cleanup): Remove.
5151
5152 2019-05-08  Tom Tromey  <tom@tromey.com>
5153
5154         * coffread.c (struct coff_symfile_info): Add initializers.
5155         (coff_objfile_data_key): Move lower.  Change type.
5156         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5157         Update.
5158         (coff_free_info): Remove.
5159
5160 2019-05-08  Tom Tromey  <tom@tromey.com>
5161
5162         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5163         (fbsd_pspace_data_handle): Move lower.  Change type.
5164         (get_fbsd_pspace_data): Update.
5165         (fbsd_pspace_data_cleanup): Remove.
5166         (_initialize_fbsd_tdep): Update.
5167
5168 2019-05-08  Tom Tromey  <tom@tromey.com>
5169
5170         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5171         (get_ada_tasks_pspace_data): Update.
5172         (ada_tasks_pspace_data_cleanup): Remove.
5173         (_initialize_tasks): Update.
5174         (ada_tasks_inferior_data_handle): Change type.
5175         (get_ada_tasks_inferior_data): Update.
5176         (ada_tasks_inferior_data_cleanup): Remove.
5177         (struct ada_tasks_pspace_data): Add initializers.
5178
5179 2019-05-08  Tom Tromey  <tom@tromey.com>
5180
5181         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5182         * symfile-debug.c (debug_sym_get_probes): Change type.
5183         * stap-probe.c (handle_stap_probe):
5184         (stap_static_probe_ops::get_probes): Change type.
5185         * probe.h (class static_probe_ops) <get_probes>: Change type.
5186         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5187         (parse_probes_in_pspace): Update.
5188         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5189         Update.
5190         (any_static_probe_ops::get_probes): Change type.
5191         * elfread.c (elfread_data): New typedef.
5192         (probe_key): Change type.
5193         (elf_get_probes): Likewise.  Update.
5194         (probe_key_free): Remove.
5195         (_initialize_elfread): Update.
5196         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5197         Change type.
5198         (dtrace_process_dof_probe, dtrace_process_dof)
5199         (dtrace_static_probe_ops::get_probe): Change type.
5200
5201 2019-05-08  Tom Tromey  <tom@tromey.com>
5202
5203         * xcoffread.c (struct xcoff_symfile_info): Rename from
5204         coff_symfile_info.  Add initializers.
5205         (xcoff_objfile_data_key): Move lower.  Change type.
5206         (XCOFF_DATA): Rewrite.
5207         (xcoff_free_info): Remove.
5208         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5209         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5210         (xcoff_initial_scan): Update.
5211
5212 2019-05-08  Tom Tromey  <tom@tromey.com>
5213
5214         * solib-svr4.c (struct svr4_info): Add initializers and
5215         destructor.
5216         <probes_table>: Now an htab_up.
5217         (solib_svr4_pspace_data): Change type.
5218         (free_probes_table): Simplify.
5219         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5220         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5221         (probes_table_remove_objfile_probes, register_solib_event_probe)
5222         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5223         (_initialize_svr4_solib): Update.
5224
5225 2019-05-08  Tom Tromey  <tom@tromey.com>
5226
5227         * remote.c (remote_pspace_data): Change type.
5228         (remote_pspace_data_cleanup): Remove.
5229         (get_remote_exec_file, set_pspace_remote_exec_file)
5230         (_initialize_remote): Update.
5231
5232 2019-05-08  Tom Tromey  <tom@tromey.com>
5233
5234         * breakpoint.c (breakpoint_objfile_key): Change type.
5235         (get_breakpoint_objfile_data): Update.
5236         (free_breakpoint_objfile_data): Remove.
5237         (_initialize_breakpoint): Update.
5238
5239 2019-05-08  Tom Tromey  <tom@tromey.com>
5240
5241         * linux-tdep.c (struct linux_info): Add initializers.
5242         (linux_inferior_data): Move.  Change type.
5243         (invalidate_linux_cache_inf): Update.
5244         (linux_inferior_data_cleanup): Remove.
5245         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5246
5247 2019-05-08  Tom Tromey  <tom@tromey.com>
5248
5249         * auxv.c (auxv_inferior_data): Move.  Change type.
5250         (auxv_inferior_data_cleanup): Remove.
5251         (invalidate_auxv_cache_inf): Rewrite.
5252         (get_auxv_inferior_data, _initialize_auxv): Update.
5253
5254 2019-05-08  Tom Tromey  <tom@tromey.com>
5255
5256         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5257         (symfile_debug_objfile_data_key): Change type.
5258         (symfile_debug_installed, debug_qf_has_symbols)
5259         (debug_qf_find_last_source_symtab)
5260         (debug_qf_forget_cached_source_info)
5261         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5262         (debug_qf_print_stats, debug_qf_dump)
5263         (debug_qf_expand_symtabs_for_function)
5264         (debug_qf_expand_all_symtabs)
5265         (debug_qf_expand_symtabs_with_fullname)
5266         (debug_qf_map_matching_symbols)
5267         (debug_qf_expand_symtabs_matching)
5268         (debug_qf_find_pc_sect_compunit_symtab)
5269         (debug_qf_map_symbol_filenames)
5270         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5271         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5272         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5273         (debug_sym_read_linetable, debug_sym_relocate): Update.
5274         (symfile_debug_free_objfile): Remove.
5275         (install_symfile_debug_logging, _initialize_symfile_debug):
5276         Update.
5277
5278 2019-05-08  Tom Tromey  <tom@tromey.com>
5279
5280         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5281         allocate_on_obstack.
5282         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5283         (get_dwarf2_per_objfile): Update.
5284         (set_dwarf2_per_objfile): Remove.
5285         (dwarf2_has_info, dwarf2_get_section_info): Update.
5286         (dwarf2_free_objfile): Remove.
5287         (_initialize_dwarf2_read): Update.
5288
5289 2019-05-08  Tom Tromey  <tom@tromey.com>
5290
5291         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5292         initializers.
5293         <unsupported_script_warning_printed,
5294         script_not_found_warning_printed>: Now bool.
5295         (auto_load_pspace_data): Change type.
5296         (~auto_load_pspace_info): Rename from
5297         auto_load_pspace_data_cleanup.
5298         (get_auto_load_pspace_data, init_loaded_scripts_info)
5299         (clear_section_scripts, maybe_print_unsupported_script_warning)
5300         (maybe_print_script_not_found_warning, _initialize_auto_load):
5301         Update.
5302
5303 2019-05-08  Tom Tromey  <tom@tromey.com>
5304
5305         * objfiles.c (objfile_pspace_info): Add destructor and
5306         initializers.
5307         (objfiles_pspace_data): Change type.
5308         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5309         (get_objfile_pspace_data): Update.
5310         (objfiles_bfd_data): Change type.
5311         (get_objfile_bfd_data): Update.
5312         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5313
5314 2019-05-08  Tom Tromey  <tom@tromey.com>
5315
5316         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5317         Change type.
5318         (get_catch_syscall_inferior_data): Update.
5319         (catch_syscall_inferior_data_cleanup): Remove.
5320         (_initialize_break_catch_syscall): Update.
5321
5322 2019-05-08  Tom Tromey  <tom@tromey.com>
5323
5324         * inflow.c (struct terminal_info): Add destructor and
5325         initializers.
5326         (inflow_inferior_data): Change type.
5327         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5328         (get_inflow_inferior_data, inflow_inferior_exit)
5329         (swap_terminal_info, _initialize_inflow): Update.
5330
5331 2019-05-08  Tom Tromey  <tom@tromey.com>
5332
5333         * target-dcache.c (target_dcache_cleanup): Remove.
5334         (target_dcache_aspace_key): Change type.
5335         (target_dcache_init_p, target_dcache_invalidate)
5336         (target_dcache_get, target_dcache_get_or_init)
5337         (_initialize_target_dcache): Update.
5338         * dcache.h (struct dcache_deleter): New.
5339
5340 2019-05-08  Tom Tromey  <tom@tromey.com>
5341
5342         * symtab.c (struct symbol_cache): Add destructor and
5343         initializers.
5344         (symbol_cache_key): Move.  Change type.
5345         (make_symbol_cache, free_symbol_cache): Remove.
5346         (get_symbol_cache): Update.
5347         (symbol_cache_cleanup): Remove.
5348         (ALL_PSPACES, symbol_cache_flush)
5349         (maintenance_print_symbol_cache)
5350         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5351         Update.
5352
5353 2019-05-08  Tom Tromey  <tom@tromey.com>
5354
5355         * symtab.c (struct main_info): Add destructor and initializers.
5356         (main_progspace_key): Move.  Change type.
5357         (get_main_info): Update.
5358         (main_info_cleanup): Remove.
5359         (_initialize_symtab): Update.
5360
5361 2019-05-08  Tom Tromey  <tom@tromey.com>
5362
5363         * registry.h (DECLARE_REGISTRY): Define the _key class.
5364
5365 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5366
5367         * NEWS: Merge two 'New commands' sections.
5368
5369 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5370
5371         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5372         parameter and use Ada language definition instead.
5373         (ada_val_print_ptr): Remove unused language parameter.
5374         (ada_val_print_num): Remove language parameter and use Ada language
5375         definition instead.
5376         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5377         parameter.
5378         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5379         parameter and use Ada language definition instead.
5380         (ada_val_print_1): Update all ada_val_print_xxx calls.
5381         Remove language parameter.
5382         (ada_val_print): Update ada_val_print_1 call.
5383
5384 2019-05-08  Tom Tromey  <tromey@adacore.com>
5385
5386         * remote.c (remote_hw_watchpoint_limit)
5387         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5388         Now static.
5389
5390 2019-05-08  Tom Tromey  <tromey@adacore.com>
5391
5392         * maint.c (_initialize_maint_cmds): Move initialization code to
5393         remote.c.
5394         (watchdog, show_watchdog): Move to remote.c.
5395         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5396         "watchdog" static.
5397         (_initialize_remote): Move initialization code from maint.c.
5398         * defs.h (watchdog): Don't declare.
5399
5400 2019-05-08  Tom Tromey  <tromey@adacore.com>
5401
5402         * tui/tui-interp.c: Include main.h.
5403         * interps.c: Include main.h.
5404         * main.h (interpreter_p): Declare.
5405         * defs.h (interpreter_p): Don't declare.
5406
5407 2019-05-08  Tom Tromey  <tromey@adacore.com>
5408
5409         * dwarf2loc.c: Include dwarf2read.h.
5410         * defs.h (read_unsigned_leb128): Don't declare.
5411         * dwarf2read.h (read_unsigned_leb128): Declare.
5412
5413 2019-05-08  Tom Tromey  <tromey@adacore.com>
5414
5415         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5416         method.
5417
5418 2019-05-08  Tom Tromey  <tromey@adacore.com>
5419
5420         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5421         when no wrap column is set.
5422
5423 2019-05-08  Tom Tromey  <tromey@adacore.com>
5424
5425         * c-lang.c (c_get_string): Handle non-C-style arrays.
5426
5427 2019-05-08  Tom Tromey  <tromey@adacore.com>
5428
5429         * typeprint.c (print_offset_data::update): Print the bit offset,
5430         not the number of bits remaining.
5431
5432 2019-05-08  Tom Tromey  <tromey@adacore.com>
5433
5434         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5435         padding at end of comment.
5436
5437 2019-05-08  Tom Tromey  <tromey@adacore.com>
5438
5439         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5440         Compare main types.
5441
5442 2019-05-06  Tom Tromey  <tom@tromey.com>
5443
5444         * common/scoped_mmap.c: Include common-defs.h.
5445         * common/scoped_mmap.h: Don't include config.h.
5446
5447 2019-05-04  Tom Tromey  <tom@tromey.com>
5448
5449         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5450         (struct aarch64_call_info): Add initializers.
5451         <si>: Now a std::vector.
5452         (pass_on_stack, aarch64_push_dummy_call): Update.
5453
5454 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5455             Tom Tromey  <tom@tromey.com>
5456
5457         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5458         (ppc_threads): Now a std::vector.  Now static.
5459         (hwdebug_find_thread_points_by_tid)
5460         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5461         Update.
5462
5463 2019-05-04  Tom Tromey  <tom@tromey.com>
5464
5465         * arc-tdep.c (arc_tdesc_init): Return bool.
5466
5467 2019-05-04  Tom Tromey  <tom@tromey.com>
5468
5469         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5470         Use gdb_assert_not_reached.
5471
5472 2019-05-04  Tom Tromey  <tom@tromey.com>
5473
5474         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5475         "false".
5476
5477 2019-05-04  Tom Tromey  <tom@tromey.com>
5478
5479         * arc-tdep.c (arc_tdesc_init): Use bool.
5480
5481 2019-05-04  Tom Tromey  <tom@tromey.com>
5482
5483         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5484
5485 2019-05-04  Tom Tromey  <tom@tromey.com>
5486
5487         * cli/cli-cmds.c (valid_command_p): Return bool.
5488
5489 2019-05-04  Tom Tromey  <tom@tromey.com>
5490
5491         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5492         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5493
5494 2019-05-04  Raul Tambre  <raul@tambre.ee>
5495
5496         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5497         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5498         operator for comparison.
5499
5500 2019-05-04  Tom Tromey  <tom@tromey.com>
5501
5502         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5503         (lookup_partial_symbol, print_partial_symbols)
5504         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5505         (psymbol_compare): Update.
5506         (add_psymbol_to_bcache): Clear the entire psymbol.
5507         (maintenance_check_psymtabs): Update.
5508         * psympriv.h (struct partial_symbol): Don't derive from
5509         general_symbol_info.
5510         <obj_section, unrelocated_address, address,
5511         set_unrelocated_address>: Update.
5512         <ginfo>: New member.
5513         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5514         (debug_names::write_psymbols): Update.
5515
5516 2019-05-04  Tom de Vries  <tdevries@suse.de>
5517
5518         * contrib/cc-with-tweaks.sh: Support -n arg.
5519
5520 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5521
5522         * corelow.c (core_target::detach): Ensure frame cache and
5523         register caches are cleared.
5524         inferior.c (exit_inferior_1): Likewise.
5525
5526 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5527             Tom Tromey  <tom@tromey.com>
5528
5529         * dictionary.c (collate_pending_symbols_by_language): Remove
5530         "struct" from foreach.
5531         * symtab.c (lookup_global_symbol_from_objfile)
5532         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5533         foreach.
5534         * ser-tcp.c (net_open): Remove "struct" from foreach.
5535         * objfiles.c (objfile_relocate, objfile_rebase)
5536         (objfile_has_symbols): Remove "struct" from foreach.
5537         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5538         from foreach.
5539         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5540         foreach.
5541         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5542         "struct" from foreach.
5543         * ada-lang.c (create_excep_cond_exprs)
5544         (ada_exception_catchpoint_cond_string): Remove "struct" from
5545         foreach.
5546
5547 2019-05-03  Tom Tromey  <tromey@adacore.com>
5548
5549         * ada-exp.y (convert_char_literal): Check suffix of each
5550         enumerator.
5551
5552 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5553
5554         PR ada/21406:
5555         * ada-exp.y (yywrap): Don't define.
5556         * ada-lex.l (%option): Add noyywrap
5557         (yywrap): Remove.
5558
5559 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5560
5561         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5562         _WIN32_WINNT to the XP level, unless already defined to a higher
5563         level.
5564
5565         * unittests/parse-connection-spec-selftests.c:
5566         * ser-tcp.c:
5567         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5568         override.
5569
5570         * symfile.c (find_separate_debug_file): Remove colon from the
5571         drive spec of DOS/Windows file names of the target, so that the
5572         file name produced from DEBUGDIR and the target's directory will
5573         be valid on DOS/Windows systems.
5574
5575 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5576
5577         * rust-lang.c (val_print_struct): Handle printing structures
5578         containing strings.
5579
5580 2019-05-02  Tom Tromey  <tromey@adacore.com>
5581
5582         * valarith.c (_initialize_valarith): Remove.
5583
5584 2019-05-01  Tom Tromey  <tromey@adacore.com>
5585
5586         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5587         bitfields.
5588
5589 2019-05-01  Tom Tromey  <tromey@adacore.com>
5590
5591         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5592         for big-endian copies.
5593
5594 2019-04-30  Ali Tamur  <tamur@google.com>
5595         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5596         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5597         (read_3_bytes): New function.
5598
5599 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5600
5601         * windows-nat.c (main_thread_id): Delete.
5602         (handle_output_debug_string): Replace main_thread_id by
5603         current_event.dwThreadId.
5604         (fake_create_process): Likewise.
5605         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5606         Do not set main_thread_id.
5607         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5608         current_event.dwThreadId.
5609         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5610
5611 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5612
5613         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5614         Use current_event.dwThreadId instead of main_thread_id.
5615
5616 2019-04-30  Tom Tromey  <tromey@adacore.com>
5617
5618         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5619         (create_excep_cond_exprs): Iterate over program spaces.
5620         (ada_exception_catchpoint_cond_string): Examine all minimal
5621         symbols for exception types.
5622
5623 2019-04-30  Tom Tromey  <tromey@adacore.com>
5624
5625         PR c++/24470:
5626         * dwarf2read.c (process_structure_scope): Handle case where type
5627         has template parameters but no symbol was created.
5628
5629 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5630             Chris January  <chris.january@arm.com>
5631
5632         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5633         qualifier.
5634         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5635
5636 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5637
5638         * f-typeprint.c (f_print_type): Update rules for printing
5639         whitespace.
5640         (f_type_print_varspec_suffix): Likewise.
5641
5642 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5643             Chris January  <chris.january@arm.com>
5644
5645         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5646         function arguments.
5647
5648 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * f-lang.c (build_fortran_types): Change name of void type to
5651         lower case.
5652         * f-typeprint.c (f_type_print_base): Print the name of the void
5653         type, rather than a fixed string.
5654         * f-valprint.c (f_decorations): Use lower case void string.
5655
5656 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5657             Chris January  <chris.january@arm.com>
5658
5659         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5660         types for Fortran.
5661
5662 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5663             Chris January  <chris.january@arm.com>
5664             David Lecomber  <david.lecomber@arm.com>
5665
5666         * f-exp.y (BINOP_INTRINSIC): New token.
5667         (exp): New parser rule handling BINOP_INTRINSIC.
5668         (f77_keywords): Add new builtin procedures.
5669         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5670         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5671         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5672         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5673         (print_unop_subexp_f): New function.
5674         (print_binop_subexp_f): New function.
5675         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5676         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5677         (dump_subexp_body_f): Likewise.
5678         (operator_check_f): Likewise.
5679         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5680         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5681
5682 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5683
5684         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5685         UNOP_KIND.
5686         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5687         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5688         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5689         (operator_length_f): New fuction.
5690         (print_subexp_f): New function.
5691         (op_name_f): New function.
5692         (dump_subexp_body_f): New function.
5693         (operator_check_f): New function.
5694         (exp_descriptor_f): Replace standard expression handling functions
5695         with new functions.
5696         * gdb/fortran-operator.def: New file.
5697         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5698         * gdb/std-operator.def: Remove UNOP_KIND.
5699
5700 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5701
5702         * std-operator.def: Remove unbalanced, stray double quote
5703         character.
5704
5705 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5706             Chris January  <chris.january@arm.com>
5707             Daniel Everett  <daniel.everett@arm.com>
5708             Nick Forrington  <nick.forrington@arm.com>
5709             Richard Bunt  <richard.bunt@arm.com>
5710
5711         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5712         of depth when printing anonymous structs or unions.
5713         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5714         Don't print either the top-level value, or the children if the
5715         max-depth is exceeded.
5716         (ppscm_print_children): When printing the key of a map, allow one
5717         extra level of depth.
5718         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5719         print either the top-level value, or the children if the max-depth
5720         is exceeded.
5721         (print_children): When printing the key of a map, allow one extra
5722         level of depth.
5723         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5724         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5725         (user_print_options): Initialise max_depth field.
5726         (val_print_scalar_or_string_type_p): New function.
5727         (val_print): Check to see if the max depth has been reached.
5728         (val_print_check_max_depth): Define new function.
5729         (show_print_max_depth): New function.
5730         (_initialize_valprint): Add 'print max-depth' option.
5731         * valprint.h (struct value_print_options) <max_depth>: New field.
5732         (val_print_check_max_depth): Declare new function.
5733         * NEWS: Document new feature.
5734
5735 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * ada-lang.c (ada_language_defn): Initialise new field.
5738         * c-lang.c (c_is_string_type_p): New function.
5739         (c_language_defn): Initialise new field.
5740         (cplus_language_defn): Initialise new field.
5741         (asm_language_defn): Initialise new field.
5742         (minimal_language_defn): Initialise new field.
5743         * c-lang.h (c_is_string_type_p): Declare new function.
5744         * d-lang.c (d_language_defn): Initialise new field.
5745         * f-lang.c (f_is_string_type_p): New function.
5746         (f_language_defn): Initialise new field.
5747         * go-lang.c (go_is_string_type_p): New function.
5748         (go_language_defn): Initialise new field.
5749         * language.c (default_is_string_type_p): New function.
5750         (unknown_language_defn): Initialise new field.
5751         (auto_language_defn): Initialise new field.
5752         * language.h (struct language_defn) <la_is_string_type_p>: New
5753         member variable.
5754         (default_is_string_type_p): Declare new function.
5755         * m2-lang.c (m2_language_defn): Initialise new field.
5756         * objc-lang.c (objc_language_defn): Initialise new field.
5757         * opencl-lang.c (opencl_language_defn): Initialise new field.
5758         * p-lang.c (pascal_is_string_type_p): New function.
5759         (pascal_language_defn): Initialise new field.
5760         * rust-lang.c (rust_is_string_type_p): New function.
5761         (rust_language_defn): Initialise new field.
5762
5763 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5764
5765         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5766         New field.
5767         * ada-lang.c (ada_language_defn): Initialise new field.
5768         * c-lang.c (c_language_defn): Likewise.
5769         (cplus_language_defn): Likewise.
5770         (asm_language_defn): Likewise.
5771         (minimal_language_defn): Likewise.
5772         * d-lang.c (d_language_defn): Likewise.
5773         * f-lang.c (f_language_defn): Likewise.
5774         * go-lang.c (go_language_defn): Likewise.
5775         * language.c (unknown_language_defn): Likewise.
5776         (auto_language_defn): Likewise.
5777         * m2-lang.c (m2_language_defn): Likewise.
5778         * objc-lang.c (objc_language_defn): Likewise.
5779         * opencl-lang.c (opencl_language_defn): Likewise.
5780         * p-lang.c (pascal_language_defn): Likewise.
5781         * rust-lang.c (rust_language_defn): Likewise.
5782
5783 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * ada-lang.c (ada_is_character_type): Change return type to bool.
5786         (ada_is_string_type): Likewise.
5787         * ada-lang.h (ada_is_character_type): Update declaration
5788         (ada_is_string_type): Likewise.
5789
5790 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5791
5792         Support style in 'frame|thread apply'
5793
5794         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5795         * record.c (record_start, record_stop): Update callers of
5796         execute_command_to_string with false.
5797         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5798         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5799         methods.
5800         (class string_file): New constructor with term_out parameter.
5801         Override methods term_out and can_emit_style_escape.  New member
5802         term_out.
5803         (class stdio_file): Override can_emit_style_escape.
5804         (class tee_file): Override term_out and can_emit_style_escape.
5805         * utils.h (can_emit_style_escape): Remove.
5806         * utils.c (can_emit_style_escape): Likewise.
5807         Update all callers of can_emit_style_escape (SOMESTREAM) to
5808         SOMESTREAM->can_emit_style_escape.
5809         * source-cache.c (source_cache::get_source_lines): Likewise.
5810         * stack.c (frame_apply_command_count): Call execute_command_to_string
5811         passing the term_out characteristic of the current gdb_stdout.
5812         * thread.c (thr_try_catch_cmd): Likewise.
5813         * top.c (execute_command_to_string): pass term_out parameter
5814         to construct the string_file for the command output.
5815         * ui-file.c (term_cli_styling): New function (most code moved
5816         from utils.c can_emit_style_escape).
5817         (string_file::string_file, string_file::can_emit_style_escape,
5818         stdio_file::can_emit_style_escape, tee_file::term_out,
5819         tee_file::can_emit_style_escape): New functions.
5820
5821 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5822
5823         * NEWS: Mention the new set|show may-call-functions.
5824         * infcall.c (may_call_functions_p): New variable.
5825         (show_may_call_functions_p): New function.
5826         (call_function_by_hand_dummy): Throws an error if not
5827         may-call-functions.
5828         (_initialize_infcall): Call add_setshow_boolean_cmd for
5829         may-call-functions.
5830
5831 2019-04-25  Keith Seitz  <keiths@redhat.com>
5832
5833         PR c++/24367
5834         * cp-support.c (inspect_type): Don't attempt substitutions
5835         of symbol with the same name.
5836
5837 2019-04-25  Tom Tromey  <tromey@adacore.com>
5838
5839         PR gdb/24475:
5840         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5841         static.
5842
5843 2019-04-25  Tom Tromey  <tromey@adacore.com>
5844
5845         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5846         rvalue reference.
5847         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5848         (gdb_xml_parser::parse): Use std::move.
5849         * python/python-internal.h (gdbpy_convert_exception): Take a const
5850         reference.
5851         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5852         std::move.
5853         * python/py-utils.c (gdbpy_convert_exception): Take a const
5854         reference.
5855         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5856         Use std::move.
5857         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5858         Use std::move.
5859         * mi/mi-main.c (mi_print_exception): Take a const reference.
5860         * main.c (handle_command_errors): Take a const reference.
5861         * linespec.c (parse_linespec): Use std::move.
5862         * infcall.c (run_inferior_call): Use std::move.
5863         (call_function_by_hand_dummy): Use std::move.
5864         * exec.c (try_open_exec_file): Use std::move.
5865         * exceptions.h (exception_print, exception_fprintf)
5866         (exception_print_same): Update.
5867         * exceptions.c (print_exception, exception_print)
5868         (exception_fprintf, exception_print_same): Change parameters to
5869         const reference.
5870         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5871         * common/new-op.c: Use std::move.
5872         * common/common-exceptions.h (struct gdb_exception): Add move
5873         constructor.
5874         (struct gdb_exception_error, struct gdb_exception_quit, struct
5875         gdb_quit_bad_alloc): Change constructor to move constructor.
5876         (throw_exception): Change parameter to rvalue reference.
5877         * common/common-exceptions.c (throw_exception): Take rvalue
5878         reference.
5879         * cli/cli-interp.c (safe_execute_command): Use std::move.
5880         * breakpoint.c (insert_bp_location, location_to_sals): Use
5881         std::move.
5882
5883 2019-04-25  Tom Tromey  <tromey@adacore.com>
5884
5885         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5886         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5887         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5888         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5889         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5890         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5891         guile/scm-value.c: Use unpack.
5892         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5893         gdbscm_gdb_exception.
5894         (gdbscm_throw_gdb_exception): Likewise.
5895         (struct gdbscm_gdb_exception): New.
5896         (unpack): New function.
5897         (gdbscm_wrap): Use unpack.
5898
5899 2019-04-25  Tom Tromey  <tromey@adacore.com>
5900
5901         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5902         (gdb_rl_callback_handler): Use std::move.
5903         * common/common-exceptions.h (struct gdb_exception): Add move
5904         assignment operator.
5905         (throw_exception_sjlj): Change "exception" to const reference.
5906         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5907         (throw_exception_sjlj): Change "exception" to const reference.
5908
5909 2019-04-25  Tom Tromey  <tromey@adacore.com>
5910
5911         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5912         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5913         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5914         Update.
5915         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5916         Update.
5917         * mi/mi-interp.c (mi_interp::exec): Update.
5918         * linespec.c (parse_linespec): Update.
5919         * infcall.c (run_inferior_call): Update.
5920         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5921         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5922         (gdbscm_lookup_global_symbol): Update.
5923         * guile/scm-param.c (gdbscm_parameter_value): Update.
5924         * guile/scm-frame.c (gdbscm_frame_read_register)
5925         (gdbscm_frame_read_var): Update.
5926         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5927         * exec.c (try_open_exec_file): Update.
5928         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5929         (gdb_rl_callback_handler): Update.
5930         * common/common-exceptions.h (exception_none): Don't declare.
5931         * common/common-exceptions.c (exception_none): Don't define.
5932         (struct catcher) <exception>: Update.
5933         * cli/cli-interp.c (safe_execute_command): Update.
5934         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5935
5936 2019-04-25  Ali Tamur  <tamur@google.com>
5937
5938         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5939         (read_attribute_value): Likewise.
5940         (dwarf2_read_addr_index): Update comment.
5941         (read_str_index): Add DW_FORM_strx.
5942         (dwarf2_string_attr): Likewise.
5943         (dwarf2_const_value_attr): Likewise.
5944         (dump_die_shallow): Likewise.
5945         (dwarf2_fetch_constant_bytes): Likewise.
5946         (skip_form_bytes): Likewise.
5947         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5948
5949 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5950
5951         PR corefiles/11608
5952         PR corefiles/18187
5953         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5954         OFFSET.  Verify if current mapping contains an ELF header.
5955         (linux_find_memory_regions_full): Adjust call to
5956         dump_mapping_p.
5957
5958 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5959             Kang Li <kanglictf@gmail.com>
5960
5961         PR gdb/21600
5962
5963         * dwarf2-frame.c (read_initial_length): Be consistent about using
5964         unsigned representation of length.
5965         (decode_frame_entry_1): Likewise.  Check for wraparound of
5966         end pointer as well as buffer overflow.
5967
5968 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5969
5970         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5971         "vq".
5972
5973 2019-04-24  Tom Tromey  <tromey@adacore.com>
5974
5975         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5976
5977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5978
5979         * s12z-tdep.c (s12z_unwind_pc): Delete.
5980         (s12z_unwind_sp): Delete.
5981         (s12z_gdbarch_init): Don't register deleted functions with
5982         gdbarch.
5983
5984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5985
5986         * rl78-tdep.c (rl78_unwind_sp): Delete.
5987         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5988
5989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5990
5991         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5992         (xstormy16_unwind_pc): Delete.
5993         (xstormy16_dummy_id): Delete.
5994         (xstormy16_gdbarch_init): Don't register deleted functions with
5995         gdbarch.
5996
5997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * vax-tdep.c (vax_unwind_pc): Delete.
6000         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6001
6002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * v850-tdep.c (v850_unwind_sp): Delete.
6005         (v850_unwind_pc): Delete.
6006         (v850_dummy_id): Delete.
6007         (v850_gdbarch_init): Don't register deleted functions with
6008         gdbarch.
6009
6010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6011
6012         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6013         (tilegx_unwind_pc): Delete.
6014         (tilegx_unwind_dummy_id): Delete.
6015         (tilegx_gdbarch_init): Don't register deleted functions with
6016         gdbarch.
6017
6018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6019
6020         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6021         (tic6x_dummy_id): Delete.
6022         (tic6x_gdbarch_init): Don't register deleted functions with
6023         gdbarch.
6024
6025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * sparc-tdep.c (sparc_unwind_pc): Delete.
6028         (sparc32_gdbarch_init): Don't register deleted function with
6029         gdbarch.
6030
6031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * sh-tdep.c (sh_unwind_sp): Delete.
6034         (sh_unwind_pc): Delete.
6035         (sh_dummy_id): Delete.
6036         (sh_gdbarch_init): Don't register deleted functions with
6037         gdbarch.
6038
6039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * score-tdep.c (score_unwind_sp): Delete.
6042         (score_unwind_pc): Delete.
6043         (score_dummy_id): Delete.
6044         (score_gdbarch_init): Don't register deleted functions with
6045         gdbarch.
6046
6047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6048
6049         * rx-tdep.c (rx_unwind_pc): Delete.
6050         (rx_unwind_sp): Delete.
6051         (rx_dummy_id): Delete.
6052         (rx_gdbarch_init): Don't register deleted functions with
6053         gdbarch.  Update comment.
6054
6055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6058         (rs6000_dummy_id): Delete.
6059         (rs6000_gdbarch_init): Don't register deleted functions with
6060         gdbarch.
6061
6062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6063
6064         * or1k-tdep.c (or1k_dummy_id): Delete.
6065         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6066
6067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6068
6069         * nios2-tdep.c (nios2_dummy_id): Delete.
6070         (nios2_unwind_sp): Delete.
6071         (nios2_gdbarch_init): Don't register deleted functions with
6072         gdbarch.
6073
6074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * nds32-tdep.c (nds32_dummy_id): Delete.
6077         (nds32_unwind_pc): Delete.
6078         (nds32_unwind_sp): Delete.
6079         (nds32_gdbarch_init): Don't register deleted functions with
6080         gdbarch.
6081
6082 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6083
6084         * msp430-tdep.c (msp430_unwind_pc): Delete.
6085         (msp430_unwind_sp): Delete.
6086         (msp430_dummy_id): Delete.
6087         (msp430_gdbarch_init): Don't register deleted functions with
6088         gdbarch.
6089
6090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * moxie-tdep.c (moxie_unwind_sp): Delete.
6093         (moxie_unwind_pc): Delete.
6094         (moxie_dummy_id): Delete.
6095         (moxie_gdbarch_init): Don't register deleted functions with
6096         gdbarch.
6097
6098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6099
6100         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6101         (mn10300_unwind_pc): Delete.
6102         (mn10300_unwind_sp): Delete.
6103         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6104         mn10300_unwind_sp.
6105         (mn10300_frame_unwind_init): Don't register deleted functions with
6106         gdbarch.
6107
6108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * mep-tdep.c (mep_unwind_pc): Delete.
6111         (mep_unwind_sp): Delete.
6112         (mep_dummy_id): Delete.
6113         (mep_gdbarch_init): Don't register deleted functions with
6114         gdbarch.
6115
6116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6119         (m68hc11_unwind_sp): Delete.
6120         (m68hc11_gdbarch_init): Don't register deleted functions with
6121         gdbarch.
6122
6123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * m32r-tdep.c (m32r_unwind_sp): Delete.
6126         (m32r_unwind_pc): Delete.
6127         (m32r_dummy_id): Delete.
6128         (m32r_gdbarch_init): Don't register deleted functions with
6129         gdbarch.
6130
6131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6132
6133         * m32c-tdep.c (m32c_unwind_pc): Delete.
6134         (m32c_unwind_sp): Delete.
6135         (m32c_dummy_id): Delete.
6136         (m32c_gdbarch_init): Don't register deleted functions with
6137         gdbarch.
6138
6139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6142         (lm32_unwind_pc): Delete.
6143         (lm32_dummy_id): Delete.
6144         (lm32_gdbarch_init): Don't register deleted functions with
6145         gdbarch.
6146
6147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6148
6149         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6150         (iq2000_unwind_pc): Delete.
6151         (iq2000_dummy_id): Delete.
6152         (iq2000_gdbarch_init): Don't register deleted functions with
6153         gdbarch.
6154
6155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6156
6157         * nds32-tdep.c (nds32_type_align): Delete.
6158         (nds32_push_dummy_call): Use type_align instead.
6159
6160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6161
6162         * arm-tdep.c (arm_type_align): Only handle vector override case.
6163         (arm_push_dummy_call): Use type_align.
6164         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6165
6166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6169         case.
6170         (pass_on_stack): Use type_align.
6171         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6172         function.
6173
6174 2019-04-23  Tom Tromey  <tromey@adacore.com>
6175
6176         * dwarf2read.c (line_header::file_name_at): Remove unused
6177         overload.
6178
6179 2019-04-23  Tom de Vries  <tdevries@suse.de>
6180
6181         PR gdb/24438
6182         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6183         invocation.
6184
6185
6186 2019-03-27  Ali Tamur  <tamur@google.com>
6187
6188         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6189         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6190         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6191         (dwarf_expr_context::get_addr_index): Likewise
6192         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6193         (symbol_needs_eval_context::get_addr_index): Likewise
6194         (disassemble_dwarf_expression): Add DW_OP_addrx
6195         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6196         (read_cutu_die_from_dwo): Update comment
6197         (skip_one_die): Add DW_FORM_addrx
6198         (read_attribute_value): Likewise
6199         (var_decode_location): Add DW_OP_addrx
6200         (dwarf2_const_value_attr): Add DW_FORM_addrx
6201         (dump_die_shallow): Likewise
6202         (dwarf2_fetch_constant_bytes): Likewise
6203         (decode_locdesc): Add DW_OP_addrx
6204         (skip_form_bytes): Add DW_FORM_addrx
6205
6206 2019-04-22  Ali Tamur  <tamur@google.com>
6207
6208         * MAINTAINERS (Write After Approval): Add self.
6209
6210 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6211
6212         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6213         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6214         (open_symbol_file_object): Likewise.
6215         (svr4_default_sos): Add info parameter.
6216         (svr4_read_so_list): Likewise.
6217         (svr4_current_sos_direct): Adjust functions calls to pass down
6218         info.
6219         (svr4_current_sos_1): Add info parameter.
6220         (svr4_current_sos): Call get_svr4_info, pass info down to
6221         svr4_current_sos_1.
6222         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6223         get_svr4_info.
6224         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6225         get_svr4_info.
6226         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6227         to get_svr4_info.
6228         (probes_table_remove_objfile_probes): Likewise.
6229         (register_solib_event_probe): Add info parameter.
6230         (solist_update_incremental): Pass info parameter down to
6231         svr4_read_so_list.
6232         (disable_probes_interface): Add info parameter.
6233         (svr4_handle_solib_event): Pass current_program_space to
6234         get_svr4_info.  Adjust disable_probes_interface cleanup.
6235         (svr4_create_probe_breakpoints): Add info parameter, pass it
6236         down to register_solib_event_probe.
6237         (svr4_create_solib_event_breakpoints): Add info parameter,
6238         pass it down to svr4_create_probe_breakpoints.
6239         (enable_break): Pass info down to
6240         svr4_create_solib_event_breakpoints.
6241         (svr4_solib_create_inferior_hook): Pass current_program_space to
6242         get_svr4_info.
6243         (svr4_clear_solib): Likewise.
6244
6245 2019-04-22  Pedro Alves  <palves@redhat.com>
6246
6247         * solib-svr4.c (svr4_free_objfile_observer): New.
6248         (probe_and_action::objfile): New field.
6249         (probes_table_htab_remove_objfile_probes)
6250         (probes_table_remove_objfile_probes): New functions.
6251         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6252         in the new probe_and_action.  Don't store the probe in 'lookup'.
6253         (svr4_create_probe_breakpoints): Pass objfile to
6254         register_solib_event_probe.
6255         (_initialize_svr4_solib): Register a free_objfile observer.
6256
6257 2019-04-19  Tom Tromey  <tom@tromey.com>
6258
6259         * common/queue.h: Remove.
6260
6261 2019-04-19  Tom Tromey  <tom@tromey.com>
6262
6263         * event-loop.c: Don't include "common/queue.h".
6264
6265 2019-04-19  Tom Tromey  <tom@tromey.com>
6266
6267         * remote.c (remote_target): Use delete.
6268         * remote-notif.h: Include <list>, not "common/queue.h".
6269         (notif_client_p): Remove typedef.
6270         (remote_notif_state): Add constructor, destructor, initializer.
6271         <notif_queue>: Now a std::list.
6272         (remote_notif_state_xfree): Don't declare.
6273         * remote-notif.c (remote_notif_process, handle_notification)
6274         (remote_notif_state_allocate): Update.
6275         (~remote_notif_state): Rename from remote_notif_state_xfree.
6276
6277 2019-04-19  Tom Tromey  <tom@tromey.com>
6278
6279         * symfile.c (reread_symbols): Update.
6280         * objfiles.c (objfile_register_static_link)
6281         (objfile_lookup_static_link): Update
6282         (~objfile) Don't delete static_links.
6283         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6284
6285 2019-04-19  Tom Tromey  <tom@tromey.com>
6286
6287         * type-stack.h (struct type_stack) <insert>: Constify string.
6288         * type-stack.c (type_stack::insert): Constify string.
6289         * gdbtypes.h (lookup_template_type): Update.
6290         (address_space_name_to_int): Update.
6291         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6292         const.
6293         (lookup_template_type): Make name const.
6294         * c-exp.y: Update rules.
6295         (lex_one_token, classify_name, classify_inner_name)
6296         (c_print_token): Update.
6297         * p-exp.y: Update rules.
6298         (yylex): Update.
6299         * f-exp.y: Update rules.
6300         (yylex): Update.
6301         * d-exp.y: Update rules.
6302         (lex_one_token, classify_name, classify_inner_name): Update.
6303         * parse.c (write_dollar_variable, copy_name): Return std::string.
6304         * parser-defs.h (copy_name): Change return type.
6305         * m2-exp.y: Update rules.
6306         (yylex): Update.
6307         * go-exp.y (lex_one_token): Update.
6308         Update rules.
6309         (classify_unsafe_function, classify_packaged_name)
6310         (classify_name, yylex): Update.
6311
6312 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6313
6314         * configure.ac: add --enable-source-highlight switch.
6315         * configure: Regenerate.
6316         * top.c (print_gdb_version): plumb --enable-source-highlight
6317         status to "show configuration".
6318
6319 2019-04-19  Tom Tromey  <tromey@adacore.com>
6320
6321         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6322         Check ADA_TYPE_P.
6323         (empty_record, ada_template_to_fixed_record_type_1)
6324         (template_to_static_fixed_type)
6325         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6326         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6327         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6328         macros.
6329
6330 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6331
6332         PR symtab/24423:
6333         * source.c (print_source_lines_base): Advance "iter" when a
6334         control character is seen.
6335
6336 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6337
6338         * inferior.h (struct infcall_suspend_state_deleter):
6339         Catch exception in destructor to avoid crash.
6340
6341 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6342
6343         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6344         close to the add_com "shell".
6345
6346 2019-04-18  Tom Tromey  <tromey@adacore.com>
6347
6348         * process-stratum-target.h (class process_stratum_target)
6349         <stratum>: Add "final".
6350
6351 2019-04-17  Tom Tromey  <tromey@adacore.com>
6352
6353         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6354         against nullptr before use.
6355
6356 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6357
6358         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6359
6360 2019-04-17  Jim Wilson  <jimw@sifive.com>
6361             Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6364         code read might fail, assume 4-byte breakpoint in that case.
6365
6366 2019-04-15  Leszek Swirski  <leszeks@google.com>
6367
6368         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6369         rather than a hand-rolled POD check when checking for forced MEMORY
6370         classification.
6371
6372 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6373
6374         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6375         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6376         function.
6377         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6378         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6379         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6380         declaration.
6381
6382 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6383
6384         * aarch64-linux-nat.c
6385         (aarch64_linux_nat_target::thread_architecture): Add override.
6386         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6387         each VQ.
6388
6389 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6390
6391         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6392
6393 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6394
6395         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6396         target types of size 96-bits, add some additional comments, and
6397         check that the builtin type we found was the correct size.
6398
6399 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6400
6401         * utils.c (prompt_for_continue): Don't restore the styling at the
6402         end, as applied_style has the wrong value.  This fixes styling in
6403         long lists of file names that are interrupted by the "Continue?"
6404         prompt.
6405
6406 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6409         * c-lang.c (c_language_defn): Likewise.
6410         (cplus_language_defn): Likewise.
6411         (asm_language_defn): Likewise.
6412         (minimal_language_defn): Likewise.
6413         * d-lang.c (d_language_defn): Likewise.
6414         * f-lang.c (f_language_defn): Likewise.
6415         * go-lang.c (go_language_defn): Likewise.
6416         * language.c (unknown_language_defn): Likewise.
6417         (auto_language_defn): Likewise.
6418         * language.h (struct language_defn): Remove la_magic field.
6419         (LANG_MAGIC): Delete.
6420         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6421         * objc-lang.c (objc_language_defn): Likewise.
6422         * opencl-lang.c (opencl_language_defn): Likewise.
6423         * p-lang.c (pascal_language_defn): Likewise.
6424         * rust-lang.c (rust_language_defn): Likewise.
6425
6426 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * riscv-tdep.c (riscv_type_align): New function.
6429         (riscv_type_alignment): Delete.
6430         (riscv_arg_location): Use 'type_align'.
6431         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6432
6433 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * gdbtypes.c (type_align): A struct with no non-static fields also
6436         has alignment of 1.
6437
6438 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6441         component to 0.
6442         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6443         member.
6444         (riscv_struct_info::analyse): New implementation using new
6445         analyse_inner member function.
6446         (riscv_struct_info::field_offset): New member function.
6447         (riscv_struct_info::m_offsets): New member variable.
6448         (riscv_struct_info::analyse_inner): New private member function,
6449         takes the old implementation of riscv_struct_info::analyse but
6450         extended to track field offsets.
6451         (riscv_call_arg_struct): Update the struct folding special cases
6452         to handle cases where empty C++ structs, which are non-zero
6453         length, are found.
6454         (riscv_arg_location): Initialise the length of each location, a
6455         non-zero length now indicates the location is in use.
6456         (riscv_push_dummy_call): Allow for the first location having a
6457         non-zero offset when setting up arguments.
6458         (riscv_return_value): Likewise, but for return values.
6459
6460 2019-04-11  Tom Tromey  <tromey@adacore.com>
6461
6462         * utils.c (internal_vproblem): Make "msg" const.
6463
6464 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6465
6466         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6467         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6468         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6469         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6470
6471 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6472
6473         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6474         function.
6475         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6476         of amd64_collect_native_gregset.
6477         (amd64_linux_nat_target::store_registers): Likewise.
6478
6479 2019-04-10  Tom Tromey  <tom@tromey.com>
6480
6481         * symtab.c (lookup_global_symbol_from_objfile)
6482         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6483         * objfiles.h (class separate_debug_iterator): New.
6484         (class separate_debug_range): New.
6485         (struct objfile) <separate_debug_objfiles>: New method.
6486         (objfile_separate_debug_iterate): Don't declare.
6487         * objfiles.c (separate_debug_iterator::operator++): Rename from
6488         objfile_separate_debug_iterate.
6489         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6490         iterator.
6491         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6492         iterator.
6493
6494 2019-04-10  Tom Tromey  <tom@tromey.com>
6495
6496         * symfile.c (reread_symbols): Remove old comment.
6497         * objfiles.c (free_all_objfiles): Fix a typo.
6498
6499 2019-04-10  Tom Tromey  <tom@tromey.com>
6500
6501         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6502         * minsyms.c (lookup_minimal_symbol): Use foreach.
6503         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6504         (lookup_minimal_symbol_solib_trampoline): Likewise.
6505         * symfile.c (reread_symbols): Use foreach.
6506
6507 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6508             Tom Tromey  <tromey@adacore.com>
6509
6510         PR rust/24414:
6511         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6512         (rust_lex_int_test): Change "value" to be LONGEST.
6513         (rust_lex_tests): Add test for long integer literal.
6514
6515 2019-04-09  Tom Tromey  <tromey@adacore.com>
6516
6517         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6518         to bool.
6519         (extended_remote_target::attach): Update.
6520         (remote_target::remote_notice_new_inferior): Update.
6521         (remote_target::add_current_inferior_and_thread): Update.
6522         * inferior.c (exit_inferior_1): Use "false".
6523         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6524
6525 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6526
6527         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6528         the "start" command.
6529
6530 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6531
6532         * python/py-inferior.c (infpy_thread_from_thread_handle):
6533         Adjust comments to reflect renaming of thread_from_thread_handle
6534         to thread_from_handle.  Adjust keywords.  Fix type error message.
6535         (inferior_object_methods): Add thread_from_handle.  Retain
6536         thread_from_thread_handle, but mark it as deprecated.
6537
6538 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6539
6540         * gdbthread.h (find_thread_by_handle): Revise declaration.
6541         * thread.c (find_thread_by_handle): Likewise.  Adjust
6542         implementation too.
6543         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6544         support for buffer objects as handles.
6545
6546 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6547
6548         * python/py-infthread.c (thpy_thread_handle): New function.
6549         (thread_object_methods): Register thpy_thread_handle.
6550
6551 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6552
6553         * gdbthread.h (thread_to_thread_handle): Declare.
6554         * thread.c (gdbtypes.h): Include.
6555         (thread_to_thread_handle): New function.
6556
6557         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6558         (target_thread_info_to_thread_handle): Declare.
6559         * target.c (target_thread_info_to_thread_handle): New function.
6560         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6561         * target-delegates.c: Regenerate.
6562
6563         * linux-thread-db.c (class thread_db_target): Add method
6564         thread_info_to_thread_handle.
6565         (thread_db_target::thread_info_to_thread_handle): Define.
6566         * remote.c (class remote_target): Add new method
6567         thread_info_to_thread_handle.
6568         (remote_target::thread_info_to_thread_handle): Define.
6569
6570 2019-04-08  Pedro Alves  <palves@redhat.com>
6571
6572         * common/common-exceptions.c (throw_exception): Don't create
6573         named object to throw; throw directly.
6574         (throw_it): Likewise.  Don't initialize gdb_exception::message
6575         here, with new; pass FMT and AP to the ctor instead.
6576         * common/common-exceptions.h: Include <string>.
6577         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6578         const char *, va_list)): New ctor.  Use std::make_shared.
6579         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6580         errors)): Delete.
6581         (gdb_exception_error::gdb_exception_error(enum errors, const char
6582         *, va_list)): New.
6583         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6584         Add assertion.
6585         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6586         errors)): Delete.
6587         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6588         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6589         Add assertion.
6590
6591 2019-04-08  Tom Tromey  <tom@tromey.com>
6592
6593         * valops.c (value_rtti_indirect_type): Replace throw_exception
6594         with throw.
6595         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6596         with throw.
6597         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6598         throw.
6599         * target.c (target_translate_tls_address): Replace throw_exception
6600         with throw.
6601         * stack.c (frame_apply_command_count): Replace throw_exception
6602         with throw.
6603         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6604         throw.
6605         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6606         with throw.
6607         * rs6000-tdep.c (rs6000_frame_cache)
6608         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6609         * remote.c: Replace throw_exception with throw.
6610         * record-full.c (record_full_message, record_full_wait_1)
6611         (record_full_restore): Replace throw_exception with throw.
6612         * record-btrace.c:
6613         (get_thread_current_frame_id, record_btrace_start_replaying)
6614         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6615         (cmd_record_btrace_start): Replace throw_exception with throw.
6616         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6617         throw.
6618         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6619         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6620         * linespec.c:
6621         (find_linespec_symbols): Replace throw_exception with throw.
6622         * infrun.c (displaced_step_prepare, resume): Replace
6623         throw_exception with throw.
6624         * infcmd.c (post_create_inferior): Replace throw_exception with
6625         throw.
6626         * inf-loop.c (inferior_event_handler): Replace throw_exception
6627         with throw.
6628         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6629         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6630         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6631         (get_prev_frame_always, get_frame_pc_if_available)
6632         (get_frame_address_in_block_if_available, get_frame_language):
6633         Replace throw_exception with throw.
6634         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6635         throw_exception with throw.
6636         * eval.c (fetch_subexp_value, evaluate_var_value)
6637         (evaluate_funcall, evaluate_subexp_standard): Replace
6638         throw_exception with throw.
6639         * dwarf2loc.c (call_site_find_chain)
6640         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6641         Replace throw_exception with throw.
6642         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6643         with throw.
6644         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6645         throw.
6646         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6647         * completer.c (complete_line_internal): Replace throw_exception
6648         with throw.
6649         * compile/compile-object-run.c (compile_object_run): Replace
6650         throw_exception with throw.
6651         * cli/cli-script.c (process_next_line): Replace throw_exception
6652         with throw.
6653         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6654         (btrace_enable, btrace_maint_update_pt_packets): Replace
6655         throw_exception with throw.
6656         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6657         throw_exception with throw.
6658         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6659         throw_exception with throw.
6660         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6661         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6662         * aarch64-tdep.c (aarch64_make_prologue_cache)
6663         (aarch64_make_stub_cache): Replace throw_exception with throw.
6664
6665 2019-04-08  Tom Tromey  <tom@tromey.com>
6666
6667         * common/common-exceptions.c (throw_exception): Rename from
6668         throw_exception_cxx.  Remove old copy.  Make argument const.
6669         (throw_it): Create and throw exception objects directly.
6670         * common/common-exceptions.h (throw_exception): Make argument
6671         const.
6672         (struct gdb_exception_error): Add constructor.
6673         (struct gdb_exception_quit): Add constructor.
6674
6675 2019-04-08  Tom Tromey  <tom@tromey.com>
6676
6677         * common/common-exceptions.h (exception_rethrow): Don't declare.
6678         (TRY_SJLJ): Update comment.
6679         (TRY, CATCH, END_CATCH): Remove.
6680         * common/common-exceptions.c (exception_rethrow): Remove.
6681
6682 2019-04-08  Tom Tromey  <tom@tromey.com>
6683
6684         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6685         Remove.
6686         (gdb_exception_error): Rename from
6687         gdb_exception_RETURN_MASK_ERROR.
6688         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6689         (gdb_quit_bad_alloc): Update.
6690         * aarch64-tdep.c: Update.
6691         * ada-lang.c: Update.
6692         * ada-typeprint.c: Update.
6693         * ada-valprint.c: Update.
6694         * amd64-tdep.c: Update.
6695         * arch-utils.c: Update.
6696         * break-catch-throw.c: Update.
6697         * breakpoint.c: Update.
6698         * btrace.c: Update.
6699         * c-varobj.c: Update.
6700         * cli/cli-cmds.c: Update.
6701         * cli/cli-interp.c: Update.
6702         * cli/cli-script.c: Update.
6703         * common/common-exceptions.c: Update.
6704         * common/new-op.c: Update.
6705         * common/selftest.c: Update.
6706         * compile/compile-c-symbols.c: Update.
6707         * compile/compile-cplus-symbols.c: Update.
6708         * compile/compile-object-load.c: Update.
6709         * compile/compile-object-run.c: Update.
6710         * completer.c: Update.
6711         * corelow.c: Update.
6712         * cp-abi.c: Update.
6713         * cp-support.c: Update.
6714         * cp-valprint.c: Update.
6715         * darwin-nat.c: Update.
6716         * disasm-selftests.c: Update.
6717         * dtrace-probe.c: Update.
6718         * dwarf-index-cache.c: Update.
6719         * dwarf-index-write.c: Update.
6720         * dwarf2-frame-tailcall.c: Update.
6721         * dwarf2-frame.c: Update.
6722         * dwarf2loc.c: Update.
6723         * dwarf2read.c: Update.
6724         * eval.c: Update.
6725         * event-loop.c: Update.
6726         * event-top.c: Update.
6727         * exec.c: Update.
6728         * f-valprint.c: Update.
6729         * fbsd-tdep.c: Update.
6730         * frame-unwind.c: Update.
6731         * frame.c: Update.
6732         * gdbtypes.c: Update.
6733         * gnu-v3-abi.c: Update.
6734         * guile/guile-internal.h: Update.
6735         * guile/scm-block.c: Update.
6736         * guile/scm-breakpoint.c: Update.
6737         * guile/scm-cmd.c: Update.
6738         * guile/scm-disasm.c: Update.
6739         * guile/scm-frame.c: Update.
6740         * guile/scm-lazy-string.c: Update.
6741         * guile/scm-math.c: Update.
6742         * guile/scm-param.c: Update.
6743         * guile/scm-ports.c: Update.
6744         * guile/scm-pretty-print.c: Update.
6745         * guile/scm-symbol.c: Update.
6746         * guile/scm-symtab.c: Update.
6747         * guile/scm-type.c: Update.
6748         * guile/scm-value.c: Update.
6749         * i386-linux-tdep.c: Update.
6750         * i386-tdep.c: Update.
6751         * inf-loop.c: Update.
6752         * infcall.c: Update.
6753         * infcmd.c: Update.
6754         * infrun.c: Update.
6755         * jit.c: Update.
6756         * language.c: Update.
6757         * linespec.c: Update.
6758         * linux-fork.c: Update.
6759         * linux-nat.c: Update.
6760         * linux-tdep.c: Update.
6761         * linux-thread-db.c: Update.
6762         * main.c: Update.
6763         * mi/mi-cmd-break.c: Update.
6764         * mi/mi-cmd-stack.c: Update.
6765         * mi/mi-interp.c: Update.
6766         * mi/mi-main.c: Update.
6767         * objc-lang.c: Update.
6768         * p-valprint.c: Update.
6769         * parse.c: Update.
6770         * ppc-linux-tdep.c: Update.
6771         * printcmd.c: Update.
6772         * python/py-arch.c: Update.
6773         * python/py-breakpoint.c: Update.
6774         * python/py-cmd.c: Update.
6775         * python/py-finishbreakpoint.c: Update.
6776         * python/py-frame.c: Update.
6777         * python/py-framefilter.c: Update.
6778         * python/py-gdb-readline.c: Update.
6779         * python/py-inferior.c: Update.
6780         * python/py-infthread.c: Update.
6781         * python/py-lazy-string.c: Update.
6782         * python/py-linetable.c: Update.
6783         * python/py-objfile.c: Update.
6784         * python/py-param.c: Update.
6785         * python/py-prettyprint.c: Update.
6786         * python/py-progspace.c: Update.
6787         * python/py-record-btrace.c: Update.
6788         * python/py-record.c: Update.
6789         * python/py-symbol.c: Update.
6790         * python/py-type.c: Update.
6791         * python/py-unwind.c: Update.
6792         * python/py-utils.c: Update.
6793         * python/py-value.c: Update.
6794         * python/python.c: Update.
6795         * record-btrace.c: Update.
6796         * record-full.c: Update.
6797         * remote-fileio.c: Update.
6798         * remote.c: Update.
6799         * riscv-tdep.c: Update.
6800         * rs6000-aix-tdep.c: Update.
6801         * rs6000-tdep.c: Update.
6802         * rust-exp.y: Update.
6803         * rust-lang.c: Update.
6804         * s390-tdep.c: Update.
6805         * selftest-arch.c: Update.
6806         * solib-dsbt.c: Update.
6807         * solib-frv.c: Update.
6808         * solib-spu.c: Update.
6809         * solib-svr4.c: Update.
6810         * solib.c: Update.
6811         * sparc64-linux-tdep.c: Update.
6812         * stack.c: Update.
6813         * symfile-mem.c: Update.
6814         * symmisc.c: Update.
6815         * target.c: Update.
6816         * thread.c: Update.
6817         * top.c: Update.
6818         * tracefile-tfile.c: Update.
6819         * tui/tui.c: Update.
6820         * typeprint.c: Update.
6821         * unittests/cli-utils-selftests.c: Update.
6822         * unittests/parse-connection-spec-selftests.c: Update.
6823         * valops.c: Update.
6824         * valprint.c: Update.
6825         * value.c: Update.
6826         * varobj.c: Update.
6827         * windows-nat.c: Update.
6828         * x86-linux-nat.c: Update.
6829         * xml-support.c: Update.
6830
6831 2019-04-08  Tom Tromey  <tom@tromey.com>
6832
6833         * xml-support.c: Use C++ exception handling.
6834         * x86-linux-nat.c: Use C++ exception handling.
6835         * windows-nat.c: Use C++ exception handling.
6836         * varobj.c: Use C++ exception handling.
6837         * value.c: Use C++ exception handling.
6838         * valprint.c: Use C++ exception handling.
6839         * valops.c: Use C++ exception handling.
6840         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6841         handling.
6842         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6843         * typeprint.c: Use C++ exception handling.
6844         * tui/tui.c: Use C++ exception handling.
6845         * tracefile-tfile.c: Use C++ exception handling.
6846         * top.c: Use C++ exception handling.
6847         * thread.c: Use C++ exception handling.
6848         * target.c: Use C++ exception handling.
6849         * symmisc.c: Use C++ exception handling.
6850         * symfile-mem.c: Use C++ exception handling.
6851         * stack.c: Use C++ exception handling.
6852         * sparc64-linux-tdep.c: Use C++ exception handling.
6853         * solib.c: Use C++ exception handling.
6854         * solib-svr4.c: Use C++ exception handling.
6855         * solib-spu.c: Use C++ exception handling.
6856         * solib-frv.c: Use C++ exception handling.
6857         * solib-dsbt.c: Use C++ exception handling.
6858         * selftest-arch.c: Use C++ exception handling.
6859         * s390-tdep.c: Use C++ exception handling.
6860         * rust-lang.c: Use C++ exception handling.
6861         * rust-exp.y: Use C++ exception handling.
6862         * rs6000-tdep.c: Use C++ exception handling.
6863         * rs6000-aix-tdep.c: Use C++ exception handling.
6864         * riscv-tdep.c: Use C++ exception handling.
6865         * remote.c: Use C++ exception handling.
6866         * remote-fileio.c: Use C++ exception handling.
6867         * record-full.c: Use C++ exception handling.
6868         * record-btrace.c: Use C++ exception handling.
6869         * python/python.c: Use C++ exception handling.
6870         * python/py-value.c: Use C++ exception handling.
6871         * python/py-utils.c: Use C++ exception handling.
6872         * python/py-unwind.c: Use C++ exception handling.
6873         * python/py-type.c: Use C++ exception handling.
6874         * python/py-symbol.c: Use C++ exception handling.
6875         * python/py-record.c: Use C++ exception handling.
6876         * python/py-record-btrace.c: Use C++ exception handling.
6877         * python/py-progspace.c: Use C++ exception handling.
6878         * python/py-prettyprint.c: Use C++ exception handling.
6879         * python/py-param.c: Use C++ exception handling.
6880         * python/py-objfile.c: Use C++ exception handling.
6881         * python/py-linetable.c: Use C++ exception handling.
6882         * python/py-lazy-string.c: Use C++ exception handling.
6883         * python/py-infthread.c: Use C++ exception handling.
6884         * python/py-inferior.c: Use C++ exception handling.
6885         * python/py-gdb-readline.c: Use C++ exception handling.
6886         * python/py-framefilter.c: Use C++ exception handling.
6887         * python/py-frame.c: Use C++ exception handling.
6888         * python/py-finishbreakpoint.c: Use C++ exception handling.
6889         * python/py-cmd.c: Use C++ exception handling.
6890         * python/py-breakpoint.c: Use C++ exception handling.
6891         * python/py-arch.c: Use C++ exception handling.
6892         * printcmd.c: Use C++ exception handling.
6893         * ppc-linux-tdep.c: Use C++ exception handling.
6894         * parse.c: Use C++ exception handling.
6895         * p-valprint.c: Use C++ exception handling.
6896         * objc-lang.c: Use C++ exception handling.
6897         * mi/mi-main.c: Use C++ exception handling.
6898         * mi/mi-interp.c: Use C++ exception handling.
6899         * mi/mi-cmd-stack.c: Use C++ exception handling.
6900         * mi/mi-cmd-break.c: Use C++ exception handling.
6901         * main.c: Use C++ exception handling.
6902         * linux-thread-db.c: Use C++ exception handling.
6903         * linux-tdep.c: Use C++ exception handling.
6904         * linux-nat.c: Use C++ exception handling.
6905         * linux-fork.c: Use C++ exception handling.
6906         * linespec.c: Use C++ exception handling.
6907         * language.c: Use C++ exception handling.
6908         * jit.c: Use C++ exception handling.
6909         * infrun.c: Use C++ exception handling.
6910         * infcmd.c: Use C++ exception handling.
6911         * infcall.c: Use C++ exception handling.
6912         * inf-loop.c: Use C++ exception handling.
6913         * i386-tdep.c: Use C++ exception handling.
6914         * i386-linux-tdep.c: Use C++ exception handling.
6915         * guile/scm-value.c: Use C++ exception handling.
6916         * guile/scm-type.c: Use C++ exception handling.
6917         * guile/scm-symtab.c: Use C++ exception handling.
6918         * guile/scm-symbol.c: Use C++ exception handling.
6919         * guile/scm-pretty-print.c: Use C++ exception handling.
6920         * guile/scm-ports.c: Use C++ exception handling.
6921         * guile/scm-param.c: Use C++ exception handling.
6922         * guile/scm-math.c: Use C++ exception handling.
6923         * guile/scm-lazy-string.c: Use C++ exception handling.
6924         * guile/scm-frame.c: Use C++ exception handling.
6925         * guile/scm-disasm.c: Use C++ exception handling.
6926         * guile/scm-cmd.c: Use C++ exception handling.
6927         * guile/scm-breakpoint.c: Use C++ exception handling.
6928         * guile/scm-block.c: Use C++ exception handling.
6929         * guile/guile-internal.h: Use C++ exception handling.
6930         * gnu-v3-abi.c: Use C++ exception handling.
6931         * gdbtypes.c: Use C++ exception handling.
6932         * frame.c: Use C++ exception handling.
6933         * frame-unwind.c: Use C++ exception handling.
6934         * fbsd-tdep.c: Use C++ exception handling.
6935         * f-valprint.c: Use C++ exception handling.
6936         * exec.c: Use C++ exception handling.
6937         * event-top.c: Use C++ exception handling.
6938         * event-loop.c: Use C++ exception handling.
6939         * eval.c: Use C++ exception handling.
6940         * dwarf2read.c: Use C++ exception handling.
6941         * dwarf2loc.c: Use C++ exception handling.
6942         * dwarf2-frame.c: Use C++ exception handling.
6943         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6944         * dwarf-index-write.c: Use C++ exception handling.
6945         * dwarf-index-cache.c: Use C++ exception handling.
6946         * dtrace-probe.c: Use C++ exception handling.
6947         * disasm-selftests.c: Use C++ exception handling.
6948         * darwin-nat.c: Use C++ exception handling.
6949         * cp-valprint.c: Use C++ exception handling.
6950         * cp-support.c: Use C++ exception handling.
6951         * cp-abi.c: Use C++ exception handling.
6952         * corelow.c: Use C++ exception handling.
6953         * completer.c: Use C++ exception handling.
6954         * compile/compile-object-run.c: Use C++ exception handling.
6955         * compile/compile-object-load.c: Use C++ exception handling.
6956         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6957         * compile/compile-c-symbols.c: Use C++ exception handling.
6958         * common/selftest.c: Use C++ exception handling.
6959         * common/new-op.c: Use C++ exception handling.
6960         * cli/cli-script.c: Use C++ exception handling.
6961         * cli/cli-interp.c: Use C++ exception handling.
6962         * cli/cli-cmds.c: Use C++ exception handling.
6963         * c-varobj.c: Use C++ exception handling.
6964         * btrace.c: Use C++ exception handling.
6965         * breakpoint.c: Use C++ exception handling.
6966         * break-catch-throw.c: Use C++ exception handling.
6967         * arch-utils.c: Use C++ exception handling.
6968         * amd64-tdep.c: Use C++ exception handling.
6969         * ada-valprint.c: Use C++ exception handling.
6970         * ada-typeprint.c: Use C++ exception handling.
6971         * ada-lang.c: Use C++ exception handling.
6972         * aarch64-tdep.c: Use C++ exception handling.
6973
6974 2019-04-08  Tom Tromey  <tom@tromey.com>
6975
6976         * xml-support.c (gdb_xml_parser::parse): Update.
6977         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6978         * value.c (show_convenience): Update.
6979         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6980         (test_parse_flags_qcs): Update.
6981         * thread.c (thr_try_catch_cmd): Update.
6982         * target.c (target_translate_tls_address): Update.
6983         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6984         (info_frame_command_core, frame_apply_command_count): Update.
6985         * rust-exp.y (rust_lex_exception_test): Update.
6986         * riscv-tdep.c (riscv_print_one_register_info): Update.
6987         * remote.c (remote_target::enable_btrace): Update.
6988         * record-btrace.c (record_btrace_enable_warn): Update.
6989         * python/py-utils.c (gdbpy_convert_exception): Update.
6990         * printcmd.c (do_one_display, print_variable_and_value): Update.
6991         * mi/mi-main.c (mi_print_exception): Update.
6992         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6993         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6994         * linux-nat.c (linux_nat_target::attach): Update.
6995         * linux-fork.c (class scoped_switch_fork_info): Update.
6996         * infrun.c (displaced_step_prepare): Update.
6997         * infcall.c (call_function_by_hand_dummy): Update.
6998         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6999         * gnu-v3-abi.c (print_one_vtable): Update.
7000         * frame.c (get_prev_frame_always): Update.
7001         * f-valprint.c (info_common_command_for_block): Update.
7002         * exec.c (try_open_exec_file): Update.
7003         * exceptions.c (print_exception, exception_print)
7004         (exception_fprintf, exception_print_same): Update.
7005         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7006         * dwarf-index-cache.c (index_cache::store)
7007         (index_cache::lookup_gdb_index): Update.
7008         * darwin-nat.c (maybe_cache_shell): Update.
7009         * cp-valprint.c (cp_print_value_fields): Update.
7010         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7011         (gcc_cplus_symbol_address): Update.
7012         * compile/compile-c-symbols.c (gcc_convert_symbol)
7013         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7014         * common/selftest.c: Update.
7015         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7016         a std::string.
7017         (exception_try_scope_entry, exception_try_scope_exit): Don't
7018         declare.
7019         (struct exception_try_scope): Remove.
7020         (TRY): Don't use exception_try_scope.
7021         (struct gdb_exception): Add constructor, operator=.
7022         <what>: New method.
7023         (struct gdb_exception_RETURN_MASK_ALL)
7024         (struct gdb_exception_RETURN_MASK_ERROR)
7025         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7026         (struct gdb_quit_bad_alloc): Update.
7027         * common/common-exceptions.c (exception_none): Change
7028         initializer.
7029         (struct catcher) <state, exception>: Initialize inline.
7030         <prev>: Remove member.
7031         (current_catcher): Remove.
7032         (catchers): New global.
7033         (exceptions_state_mc_init): Simplify.
7034         (catcher_pop): Remove.
7035         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7036         (try_scope_depth, exception_try_scope_entry)
7037         (exception_try_scope_exit): Remove.
7038         (throw_exception_sjlj): Update.
7039         (exception_messages, exception_messages_size): Remove.
7040         (throw_it): Simplify.
7041         (gdb_exception_sliced_copy): Remove.
7042         (throw_exception_cxx): Update.
7043         * cli/cli-script.c (script_from_file): Update.
7044         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7045         Update.
7046         * ada-valprint.c (ada_val_print): Update.
7047         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7048         (create_excep_cond_exprs): Update.
7049
7050 2019-04-08  Tom Tromey  <tom@tromey.com>
7051
7052         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7053         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7054         (TRY, CATCH, END_CATCH): Remove some definitions.
7055         * common/common-exceptions.c: Don't use GDB_XCPT.
7056         (catcher_list_size): Remove.
7057         (throw_exception, throw_it): Simplify.
7058
7059 2019-04-05  Tom Tromey  <tom@tromey.com>
7060
7061         Revert the header-sorting patch.
7062         * ft32-tdep.c: Revert.
7063         * frv-tdep.c: Revert.
7064         * frv-linux-tdep.c: Revert.
7065         * frame.c: Revert.
7066         * frame-unwind.c: Revert.
7067         * frame-base.c: Revert.
7068         * fork-child.c: Revert.
7069         * findvar.c: Revert.
7070         * findcmd.c: Revert.
7071         * filesystem.c: Revert.
7072         * filename-seen-cache.h: Revert.
7073         * filename-seen-cache.c: Revert.
7074         * fbsd-tdep.c: Revert.
7075         * fbsd-nat.h: Revert.
7076         * fbsd-nat.c: Revert.
7077         * f-valprint.c: Revert.
7078         * f-typeprint.c: Revert.
7079         * f-lang.c: Revert.
7080         * extension.h: Revert.
7081         * extension.c: Revert.
7082         * extension-priv.h: Revert.
7083         * expprint.c: Revert.
7084         * exec.h: Revert.
7085         * exec.c: Revert.
7086         * exceptions.c: Revert.
7087         * event-top.c: Revert.
7088         * event-loop.c: Revert.
7089         * eval.c: Revert.
7090         * elfread.c: Revert.
7091         * dwarf2read.h: Revert.
7092         * dwarf2read.c: Revert.
7093         * dwarf2loc.c: Revert.
7094         * dwarf2expr.h: Revert.
7095         * dwarf2expr.c: Revert.
7096         * dwarf2-frame.c: Revert.
7097         * dwarf2-frame-tailcall.c: Revert.
7098         * dwarf-index-write.h: Revert.
7099         * dwarf-index-write.c: Revert.
7100         * dwarf-index-common.c: Revert.
7101         * dwarf-index-cache.h: Revert.
7102         * dwarf-index-cache.c: Revert.
7103         * dummy-frame.c: Revert.
7104         * dtrace-probe.c: Revert.
7105         * disasm.h: Revert.
7106         * disasm.c: Revert.
7107         * disasm-selftests.c: Revert.
7108         * dictionary.c: Revert.
7109         * dicos-tdep.c: Revert.
7110         * demangle.c: Revert.
7111         * dcache.h: Revert.
7112         * dcache.c: Revert.
7113         * darwin-nat.h: Revert.
7114         * darwin-nat.c: Revert.
7115         * darwin-nat-info.c: Revert.
7116         * d-valprint.c: Revert.
7117         * d-namespace.c: Revert.
7118         * d-lang.c: Revert.
7119         * ctf.c: Revert.
7120         * csky-tdep.c: Revert.
7121         * csky-linux-tdep.c: Revert.
7122         * cris-tdep.c: Revert.
7123         * cris-linux-tdep.c: Revert.
7124         * cp-valprint.c: Revert.
7125         * cp-support.c: Revert.
7126         * cp-namespace.c: Revert.
7127         * cp-abi.c: Revert.
7128         * corelow.c: Revert.
7129         * corefile.c: Revert.
7130         * continuations.c: Revert.
7131         * completer.h: Revert.
7132         * completer.c: Revert.
7133         * complaints.c: Revert.
7134         * coffread.c: Revert.
7135         * coff-pe-read.c: Revert.
7136         * cli-out.h: Revert.
7137         * cli-out.c: Revert.
7138         * charset.c: Revert.
7139         * c-varobj.c: Revert.
7140         * c-valprint.c: Revert.
7141         * c-typeprint.c: Revert.
7142         * c-lang.c: Revert.
7143         * buildsym.c: Revert.
7144         * buildsym-legacy.c: Revert.
7145         * build-id.h: Revert.
7146         * build-id.c: Revert.
7147         * btrace.c: Revert.
7148         * bsd-uthread.c: Revert.
7149         * breakpoint.h: Revert.
7150         * breakpoint.c: Revert.
7151         * break-catch-throw.c: Revert.
7152         * break-catch-syscall.c: Revert.
7153         * break-catch-sig.c: Revert.
7154         * blockframe.c: Revert.
7155         * block.c: Revert.
7156         * bfin-tdep.c: Revert.
7157         * bfin-linux-tdep.c: Revert.
7158         * bfd-target.c: Revert.
7159         * bcache.c: Revert.
7160         * ax-general.c: Revert.
7161         * ax-gdb.h: Revert.
7162         * ax-gdb.c: Revert.
7163         * avr-tdep.c: Revert.
7164         * auxv.c: Revert.
7165         * auto-load.c: Revert.
7166         * arm-wince-tdep.c: Revert.
7167         * arm-tdep.c: Revert.
7168         * arm-symbian-tdep.c: Revert.
7169         * arm-pikeos-tdep.c: Revert.
7170         * arm-obsd-tdep.c: Revert.
7171         * arm-nbsd-tdep.c: Revert.
7172         * arm-nbsd-nat.c: Revert.
7173         * arm-linux-tdep.c: Revert.
7174         * arm-linux-nat.c: Revert.
7175         * arm-fbsd-tdep.c: Revert.
7176         * arm-fbsd-nat.c: Revert.
7177         * arm-bsd-tdep.c: Revert.
7178         * arch-utils.c: Revert.
7179         * arc-tdep.c: Revert.
7180         * arc-newlib-tdep.c: Revert.
7181         * annotate.h: Revert.
7182         * annotate.c: Revert.
7183         * amd64-windows-tdep.c: Revert.
7184         * amd64-windows-nat.c: Revert.
7185         * amd64-tdep.c: Revert.
7186         * amd64-sol2-tdep.c: Revert.
7187         * amd64-obsd-tdep.c: Revert.
7188         * amd64-obsd-nat.c: Revert.
7189         * amd64-nbsd-tdep.c: Revert.
7190         * amd64-nbsd-nat.c: Revert.
7191         * amd64-nat.c: Revert.
7192         * amd64-linux-tdep.c: Revert.
7193         * amd64-linux-nat.c: Revert.
7194         * amd64-fbsd-tdep.c: Revert.
7195         * amd64-fbsd-nat.c: Revert.
7196         * amd64-dicos-tdep.c: Revert.
7197         * amd64-darwin-tdep.c: Revert.
7198         * amd64-bsd-nat.c: Revert.
7199         * alpha-tdep.c: Revert.
7200         * alpha-obsd-tdep.c: Revert.
7201         * alpha-nbsd-tdep.c: Revert.
7202         * alpha-mdebug-tdep.c: Revert.
7203         * alpha-linux-tdep.c: Revert.
7204         * alpha-linux-nat.c: Revert.
7205         * alpha-bsd-tdep.c: Revert.
7206         * alpha-bsd-nat.c: Revert.
7207         * aix-thread.c: Revert.
7208         * agent.c: Revert.
7209         * addrmap.c: Revert.
7210         * ada-varobj.c: Revert.
7211         * ada-valprint.c: Revert.
7212         * ada-typeprint.c: Revert.
7213         * ada-tasks.c: Revert.
7214         * ada-lang.c: Revert.
7215         * aarch64-tdep.c: Revert.
7216         * aarch64-ravenscar-thread.c: Revert.
7217         * aarch64-newlib-tdep.c: Revert.
7218         * aarch64-linux-tdep.c: Revert.
7219         * aarch64-linux-nat.c: Revert.
7220         * aarch64-fbsd-tdep.c: Revert.
7221         * aarch64-fbsd-nat.c: Revert.
7222         * aarch32-linux-nat.c: Revert.
7223
7224 2019-04-05  Tom Tromey  <tom@tromey.com>
7225
7226         * ft32-tdep.c: Sort headers.
7227         * frv-tdep.c: Sort headers.
7228         * frv-linux-tdep.c: Sort headers.
7229         * frame.c: Sort headers.
7230         * frame-unwind.c: Sort headers.
7231         * frame-base.c: Sort headers.
7232         * fork-child.c: Sort headers.
7233         * findvar.c: Sort headers.
7234         * findcmd.c: Sort headers.
7235         * filesystem.c: Sort headers.
7236         * filename-seen-cache.h: Sort headers.
7237         * filename-seen-cache.c: Sort headers.
7238         * fbsd-tdep.c: Sort headers.
7239         * fbsd-nat.h: Sort headers.
7240         * fbsd-nat.c: Sort headers.
7241         * f-valprint.c: Sort headers.
7242         * f-typeprint.c: Sort headers.
7243         * f-lang.c: Sort headers.
7244         * extension.h: Sort headers.
7245         * extension.c: Sort headers.
7246         * extension-priv.h: Sort headers.
7247         * expprint.c: Sort headers.
7248         * exec.h: Sort headers.
7249         * exec.c: Sort headers.
7250         * exceptions.c: Sort headers.
7251         * event-top.c: Sort headers.
7252         * event-loop.c: Sort headers.
7253         * eval.c: Sort headers.
7254         * elfread.c: Sort headers.
7255         * dwarf2read.h: Sort headers.
7256         * dwarf2read.c: Sort headers.
7257         * dwarf2loc.c: Sort headers.
7258         * dwarf2expr.h: Sort headers.
7259         * dwarf2expr.c: Sort headers.
7260         * dwarf2-frame.c: Sort headers.
7261         * dwarf2-frame-tailcall.c: Sort headers.
7262         * dwarf-index-write.h: Sort headers.
7263         * dwarf-index-write.c: Sort headers.
7264         * dwarf-index-common.c: Sort headers.
7265         * dwarf-index-cache.h: Sort headers.
7266         * dwarf-index-cache.c: Sort headers.
7267         * dummy-frame.c: Sort headers.
7268         * dtrace-probe.c: Sort headers.
7269         * disasm.h: Sort headers.
7270         * disasm.c: Sort headers.
7271         * disasm-selftests.c: Sort headers.
7272         * dictionary.c: Sort headers.
7273         * dicos-tdep.c: Sort headers.
7274         * demangle.c: Sort headers.
7275         * dcache.h: Sort headers.
7276         * dcache.c: Sort headers.
7277         * darwin-nat.h: Sort headers.
7278         * darwin-nat.c: Sort headers.
7279         * darwin-nat-info.c: Sort headers.
7280         * d-valprint.c: Sort headers.
7281         * d-namespace.c: Sort headers.
7282         * d-lang.c: Sort headers.
7283         * ctf.c: Sort headers.
7284         * csky-tdep.c: Sort headers.
7285         * csky-linux-tdep.c: Sort headers.
7286         * cris-tdep.c: Sort headers.
7287         * cris-linux-tdep.c: Sort headers.
7288         * cp-valprint.c: Sort headers.
7289         * cp-support.c: Sort headers.
7290         * cp-namespace.c: Sort headers.
7291         * cp-abi.c: Sort headers.
7292         * corelow.c: Sort headers.
7293         * corefile.c: Sort headers.
7294         * continuations.c: Sort headers.
7295         * completer.h: Sort headers.
7296         * completer.c: Sort headers.
7297         * complaints.c: Sort headers.
7298         * coffread.c: Sort headers.
7299         * coff-pe-read.c: Sort headers.
7300         * cli-out.h: Sort headers.
7301         * cli-out.c: Sort headers.
7302         * charset.c: Sort headers.
7303         * c-varobj.c: Sort headers.
7304         * c-valprint.c: Sort headers.
7305         * c-typeprint.c: Sort headers.
7306         * c-lang.c: Sort headers.
7307         * buildsym.c: Sort headers.
7308         * buildsym-legacy.c: Sort headers.
7309         * build-id.h: Sort headers.
7310         * build-id.c: Sort headers.
7311         * btrace.c: Sort headers.
7312         * bsd-uthread.c: Sort headers.
7313         * breakpoint.h: Sort headers.
7314         * breakpoint.c: Sort headers.
7315         * break-catch-throw.c: Sort headers.
7316         * break-catch-syscall.c: Sort headers.
7317         * break-catch-sig.c: Sort headers.
7318         * blockframe.c: Sort headers.
7319         * block.c: Sort headers.
7320         * bfin-tdep.c: Sort headers.
7321         * bfin-linux-tdep.c: Sort headers.
7322         * bfd-target.c: Sort headers.
7323         * bcache.c: Sort headers.
7324         * ax-general.c: Sort headers.
7325         * ax-gdb.h: Sort headers.
7326         * ax-gdb.c: Sort headers.
7327         * avr-tdep.c: Sort headers.
7328         * auxv.c: Sort headers.
7329         * auto-load.c: Sort headers.
7330         * arm-wince-tdep.c: Sort headers.
7331         * arm-tdep.c: Sort headers.
7332         * arm-symbian-tdep.c: Sort headers.
7333         * arm-pikeos-tdep.c: Sort headers.
7334         * arm-obsd-tdep.c: Sort headers.
7335         * arm-nbsd-tdep.c: Sort headers.
7336         * arm-nbsd-nat.c: Sort headers.
7337         * arm-linux-tdep.c: Sort headers.
7338         * arm-linux-nat.c: Sort headers.
7339         * arm-fbsd-tdep.c: Sort headers.
7340         * arm-fbsd-nat.c: Sort headers.
7341         * arm-bsd-tdep.c: Sort headers.
7342         * arch-utils.c: Sort headers.
7343         * arc-tdep.c: Sort headers.
7344         * arc-newlib-tdep.c: Sort headers.
7345         * annotate.h: Sort headers.
7346         * annotate.c: Sort headers.
7347         * amd64-windows-tdep.c: Sort headers.
7348         * amd64-windows-nat.c: Sort headers.
7349         * amd64-tdep.c: Sort headers.
7350         * amd64-sol2-tdep.c: Sort headers.
7351         * amd64-obsd-tdep.c: Sort headers.
7352         * amd64-obsd-nat.c: Sort headers.
7353         * amd64-nbsd-tdep.c: Sort headers.
7354         * amd64-nbsd-nat.c: Sort headers.
7355         * amd64-nat.c: Sort headers.
7356         * amd64-linux-tdep.c: Sort headers.
7357         * amd64-linux-nat.c: Sort headers.
7358         * amd64-fbsd-tdep.c: Sort headers.
7359         * amd64-fbsd-nat.c: Sort headers.
7360         * amd64-dicos-tdep.c: Sort headers.
7361         * amd64-darwin-tdep.c: Sort headers.
7362         * amd64-bsd-nat.c: Sort headers.
7363         * alpha-tdep.c: Sort headers.
7364         * alpha-obsd-tdep.c: Sort headers.
7365         * alpha-nbsd-tdep.c: Sort headers.
7366         * alpha-mdebug-tdep.c: Sort headers.
7367         * alpha-linux-tdep.c: Sort headers.
7368         * alpha-linux-nat.c: Sort headers.
7369         * alpha-bsd-tdep.c: Sort headers.
7370         * alpha-bsd-nat.c: Sort headers.
7371         * aix-thread.c: Sort headers.
7372         * agent.c: Sort headers.
7373         * addrmap.c: Sort headers.
7374         * ada-varobj.c: Sort headers.
7375         * ada-valprint.c: Sort headers.
7376         * ada-typeprint.c: Sort headers.
7377         * ada-tasks.c: Sort headers.
7378         * ada-lang.c: Sort headers.
7379         * aarch64-tdep.c: Sort headers.
7380         * aarch64-ravenscar-thread.c: Sort headers.
7381         * aarch64-newlib-tdep.c: Sort headers.
7382         * aarch64-linux-tdep.c: Sort headers.
7383         * aarch64-linux-nat.c: Sort headers.
7384         * aarch64-fbsd-tdep.c: Sort headers.
7385         * aarch64-fbsd-nat.c: Sort headers.
7386         * aarch32-linux-nat.c: Sort headers.
7387
7388 2019-04-04  Tom Tromey  <tom@tromey.com>
7389
7390         * varobj.c (varobj_create): Update.
7391         * rust-exp.y (struct rust_parser) <update_innermost_block,
7392         lookup_symbol>: New methods.
7393         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7394         Rename.
7395         (rust_parser::rust_lookup_type)
7396         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7397         * printcmd.c (display_command, do_one_display): Update.
7398         * parser-defs.h (struct parser_state) <parser_state>: Add
7399         "tracker" parameter.
7400         (block_tracker): New member.
7401         (class innermost_block_tracker) <innermost_block_tracker>: Add
7402         "types" parameter.
7403         <reset>: Remove method.
7404         (innermost_block): Don't declare.
7405         (null_post_parser): Update.
7406         * parse.c (innermost_block): Remove global.
7407         (write_dollar_variable): Update.
7408         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7409         Remove "tracker_types" parameter.
7410         (parse_expression): Add "tracker" parameter.
7411         (parse_expression_for_completion): Update.
7412         (null_post_parser): Add "tracker" parameter.
7413         * p-exp.y: Update rules.
7414         * m2-exp.y: Update rules.
7415         * language.h (struct language_defn) <la_post_parser>: Add
7416         "tracker" parameter.
7417         * go-exp.y: Update rules.
7418         * f-exp.y: Update rules.
7419         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7420         parameter.
7421         * d-exp.y: Update rules.
7422         * c-exp.y: Update rules.
7423         * breakpoint.c (set_breakpoint_condition): Create an
7424         innermost_block_tracker.
7425         (watch_command_1): Likewise.
7426         * ada-lang.c (resolve): Add "tracker" parameter.
7427         (resolve_subexp): Likewise.
7428         * ada-exp.y (write_var_from_sym): Update.
7429
7430 2019-04-04  Tom Tromey  <tom@tromey.com>
7431
7432         * type-stack.h: New file.
7433         * type-stack.c: New file.
7434         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7435         type-stack.h.
7436         (insert_into_type_stack, insert_type, push_type, push_type_int)
7437         (insert_type_address_space, pop_type, pop_type_int)
7438         (pop_typelist, pop_type_stack, append_type_stack)
7439         (push_type_stack, get_type_stack, push_typelist)
7440         (follow_type_instance_flags, follow_types): Don't declare.
7441         * parse.c (type_stack): Remove global.
7442         (parse_exp_in_context): Update.
7443         (insert_into_type_stack, insert_type, push_type, push_type_int)
7444         (insert_type_address_space, pop_type, pop_type_int)
7445         (pop_typelist, pop_type_stack, append_type_stack)
7446         (push_type_stack, get_type_stack, push_typelist)
7447         (follow_type_instance_flags, follow_types): Remove (moved to
7448         type-stack.c).
7449         * f-exp.y (type_stack): New global.
7450         Update rules.
7451         (push_kind_type, f_parse): Update.
7452         * d-exp.y (type_stack): New global.
7453         Update rules.
7454         (d_parse): Update.
7455         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7456         Update rules.
7457         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7458         (HFILES_NO_SRCDIR): Add type-stack.h.
7459
7460 2019-04-04  Tom Tromey  <tom@tromey.com>
7461
7462         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7463         (rust_parser::convert_ast_to_expression, rust_parse)
7464         (rust_lex_test_completion, rust_lex_tests): Update.
7465         * parser-defs.h (struct expr_completion_state): New.
7466         (struct parser_state) <parser_state>: Add completion parameter.
7467         <mark_struct_expression, mark_completion_tag>: New methods.
7468         <parse_completion, m_completion_state>: New members.
7469         (prefixify_expression, null_post_parser): Update.
7470         (mark_struct_expression, mark_completion_tag): Don't declare.
7471         * parse.c (parse_completion, expout_last_struct)
7472         (expout_tag_completion_type, expout_completion_name): Remove
7473         globals.
7474         (parser_state::mark_struct_expression)
7475         (parser_state::mark_completion_tag): Now methods.
7476         (prefixify_expression): Add last_struct parameter.
7477         (prefixify_subexp): Likewise.
7478         (parse_exp_1): Update.
7479         (parse_exp_in_context): Add cstate parameter.  Update.
7480         (parse_expression_for_completion): Create an
7481         expr_completion_state.
7482         (null_post_parser): Add "completion" parameter.
7483         * p-exp.y: Update rules.
7484         (yylex): Update.
7485         * language.h (struct language_defn) <la_post_parser>: Add
7486         "completing" parameter.
7487         * go-exp.y: Update rules.
7488         (lex_one_token): Update.
7489         * expression.h (parse_completion): Don't declare.
7490         * d-exp.y: Update rules.
7491         (lex_one_token): Update rules.
7492         * c-exp.y: Update rules.
7493         (lex_one_token): Update.
7494         * ada-lang.c (resolve): Add "parse_completion" parameter.
7495         (resolve_subexp): Likewise.
7496         (ada_resolve_function): Likewise.
7497
7498 2019-04-04  Tom Tromey  <tom@tromey.com>
7499
7500         * parser-defs.h (struct parser_state) <start_arglist,
7501         end_arglist>: New methods.
7502         <arglist_len, m_funcall_chain>: New members.
7503         (arglist_len, start_arglist, end_arglist): Don't declare.
7504         * parse.c (arglist_len, funcall_chain): Remove global.
7505         (start_arglist, end_arglist): Remove functions.
7506         (parse_exp_in_context): Update.
7507         * p-exp.y: Update rules.
7508         * m2-exp.y: Update rules.
7509         * go-exp.y: Update rules.
7510         * f-exp.y: Update rules.
7511         * d-exp.y: Update rules.
7512         * c-exp.y: Update rules.
7513
7514 2019-04-04  Tom Tromey  <tom@tromey.com>
7515
7516         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7517         lex_operator, push_back>: New methods.
7518         Update all rules.
7519         (rust_parser::lex_hex, lex_escape): Rename and update.
7520         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7521         (rust_parser::lex_operator): Rename and update.
7522         (rust_parser::lex_number, rustyylex, rustyyerror)
7523         (rust_lex_test_init, rust_lex_test_sequence)
7524         (rust_lex_test_push_back, rust_lex_tests): Update.
7525         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7526         parameter.
7527         <lexptr, prev_lexptr>: New members.
7528         (lexptr, prev_lexptr): Don't declare.
7529         * parse.c (lexptr, prev_lexptr): Remove globals.
7530         (parse_exp_in_context): Update.
7531         * p-exp.y (yylex, yyerror): Update.
7532         * m2-exp.y (parse_number, yylex, yyerror): Update.
7533         * go-exp.y (lex_one_token, yyerror): Update.
7534         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7535         * d-exp.y (lex_one_token, yyerror): Update.
7536         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7537         (lex_one_token, yyerror): Update.
7538         * ada-lex.l (YY_INPUT): Update.
7539         (rewind_to_char): Update.
7540         * ada-exp.y (yyerror): Update.
7541
7542 2019-04-04  Tom Tromey  <tom@tromey.com>
7543
7544         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7545         * parser-defs.h (struct parser_state) <parser_state>: Add new
7546         parameter.
7547         <comma_terminates>: New member.
7548         (comma_terminates): Don't declare global.
7549         * parse.c (comma_terminates): Remove global.
7550         (parse_exp_in_context): Update.
7551         * p-exp.y (yylex): Update.
7552         * m2-exp.y (yylex): Update.
7553         * go-exp.y (lex_one_token): Update.
7554         * f-exp.y (yylex): Update.
7555         * d-exp.y (lex_one_token): Update.
7556         * c-exp.y (lex_one_token): Update.
7557         * ada-lex.l: Update.
7558
7559 2019-04-04  Tom Tromey  <tom@tromey.com>
7560
7561         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7562         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7563         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7564         * parser-defs.h (paren_depth): Don't declare.
7565         * parse.c (paren_depth): Remove global.
7566         (parse_exp_in_context): Update.
7567         * p-exp.y (paren_depth): New global.
7568         (pascal_parse): Initialize it.
7569         * m2-exp.y (paren_depth): New global.
7570         (m2_parse): Initialize it.
7571         * go-exp.y (paren_depth): New global.
7572         (go_parse): Initialize it.
7573         * f-exp.y (paren_depth): New global.
7574         (f_parse): Initialize it.
7575         * d-exp.y (paren_depth): New global.
7576         (d_parse): Initialize it.
7577         * c-exp.y (paren_depth): New global.
7578         (c_parse): Initialize it.
7579         * ada-lex.l (paren_depth): New global.
7580         (lexer_init): Initialize it.
7581
7582 2019-04-04  Tom Tromey  <tom@tromey.com>
7583
7584         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7585         (rust_parser::convert_ast_to_type)
7586         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7587         * parser-defs.h (struct parser_state) <parser_state>: Add
7588         parameters.  Initialize new members.
7589         <expression_context_block, expression_context_pc>: New members.
7590         * parse.c (expression_context_block, expression_context_pc):
7591         Remove globals.
7592         (parse_exp_in_context): Update.
7593         * p-exp.y: Update all rules.
7594         (yylex): Update.
7595         * m2-exp.y: Update all rules.
7596         (yylex): Update.
7597         * go-exp.y (yylex): Update.
7598         * f-exp.y (yylex): Update.
7599         * d-exp.y: Update all rules.
7600         (yylex): Update.
7601         * c-exp.y: Update all rules.
7602         (lex_one_token, classify_name, yylex, c_parse): Update.
7603         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7604
7605 2019-04-04  Tom Tromey  <tom@tromey.com>
7606
7607         * gdbarch.h, gdbarch.c: Rebuild.
7608         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7609         * stap-probe.h:
7610         (struct stap_parse_info): Replace "parser_state" with
7611         "expr_builder".
7612         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7613         (parser_state): New class.
7614         * parse.c (expr_builder): Rename.
7615         (expr_builder::release): Rename.
7616         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7617         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7618         (write_exp_elt_longcst, write_exp_elt_floatcst)
7619         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7620         (write_exp_string_vector, write_exp_bitstring)
7621         (write_exp_msymbol, mark_struct_expression)
7622         (write_dollar_variable)
7623         (insert_type_address_space, increase_expout_size): Replace
7624         "parser_state" with "expr_builder".
7625         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7626         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7627         "parser_state" with "expr_builder".
7628
7629 2019-04-04  Tom Tromey  <tom@tromey.com>
7630
7631         * rust-exp.y: Replace "parse_language" with method call.
7632         * p-exp.y:
7633         (yylex): Replace "parse_language" with method call.
7634         * m2-exp.y:
7635         (yylex): Replace "parse_language" with method call.
7636         * go-exp.y (classify_name): Replace "parse_language" with method
7637         call.
7638         * f-exp.y (yylex): Replace "parse_language" with method call.
7639         * d-exp.y (lex_one_token): Replace "parse_language" with method
7640         call.
7641         * c-exp.y:
7642         (lex_one_token, classify_name, yylex): Replace "parse_language"
7643         with method call.
7644         * ada-exp.y (find_primitive_type, type_char)
7645         (type_system_address): Replace "parse_language" with method call.
7646
7647 2019-04-04  Tom Tromey  <tom@tromey.com>
7648
7649         * rust-exp.y: Replace "parse_gdbarch" with method call.
7650         * parse.c (write_dollar_variable, insert_type_address_space):
7651         Replace "parse_gdbarch" with method call.
7652         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7653         call.
7654         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7655         call.
7656         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7657         "parse_gdbarch" with method call.
7658         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7659         with method call.
7660         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7661         "parse_gdbarch" with method call.
7662         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7663         "parse_gdbarch" with method call.
7664         * c-exp.y (parse_type, parse_number, classify_name): Replace
7665         "parse_gdbarch" with method call.
7666         * ada-lex.l: Replace "parse_gdbarch" with method call.
7667         * ada-exp.y (parse_type, find_primitive_type, type_char)
7668         (type_system_address): Replace "parse_gdbarch" with method call.
7669
7670 2019-04-04  Tom Tromey  <tom@tromey.com>
7671
7672         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7673         * stap-probe.c (stap_parse_argument): Update.
7674         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7675         initial_size parameter.
7676         * rust-exp.y (rust_lex_tests): Update.
7677         * parse.c (parser_state): Update.
7678         (parse_exp_in_context): Update.
7679         * parser-defs.h (struct parser_state) <parser_state>: Remove
7680         "initial_size" parameter.
7681
7682 2019-04-04  Tom Tromey  <tom@tromey.com>
7683
7684         * parser-defs.h (increase_expout_size): Don't declare.
7685         * parse.c (increase_expout_size): Now static.
7686
7687 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7688
7689         * gnu-nat.c (gnu_nat_target::wait): Fix
7690         target_waitstatus_to_string call.
7691
7692 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * eval.c (evaluate_subexp_standard): Handle internal functions
7695         during Fortran function call handling.
7696
7697 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * NEWS: Mention new internal functions.
7700         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7701         (read_base_type): Use dwarf2_init_complex_target_type.
7702         * value.c (creal_internal_fn): New function.
7703         (cimag_internal_fn): New function.
7704         (_initialize_values): Register new internal functions.
7705
7706 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7707
7708         * infrun.c (stop_all_threads): If debug_infrun, always
7709         trace the wait status after wait_one, using
7710         target_waitstatus_to_string and target_pid_to_str.
7711         (handle_inferior_event): Replace various trace of
7712         wait status kind by a single trace.
7713         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7714         wait status kind image by target_waitstatus_to_string.
7715         * target/waitstatus.c (target_waitstatus_to_string): Fix
7716         obsolete comment.
7717
7718 2019-04-01  Tom Tromey  <tromey@adacore.com>
7719
7720         PR symtab/23331:
7721         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7722
7723 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7724             Pedro Alves  <palves@redhat.com>
7725
7726         * top.c (quit_force): Call 'finalize_values'.
7727         * value.c (finalize_values): New function.
7728         * value.h (finalize_values): Declare.
7729
7730 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7731
7732         * NEWS: Announce $_gdb_major and $_gdb_minor.
7733
7734         * top.c (init_gdb_version_vars): New function.
7735         (gdb_init): Call init_gdb_version_vars.
7736
7737 2019-03-29  Tom Tromey  <tromey@adacore.com>
7738
7739         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7740         help text.  Remove dead code.
7741
7742 2019-03-29  Keith Seitz  <keiths@redhat.com>
7743
7744         From Siddhesh Poyarekar:
7745         * f-lang.h (f77_get_upperbound): Return LONGEST.
7746         (f77_get_lowerbound): Likewise.
7747         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7748         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7749         print them.
7750         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7751         plongest to format print it.
7752         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7753         (f77_get_upperbound): Likewise.
7754         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7755         LOWER_BOUND to LONGEST.
7756         (f77_create_arrayprint_offset_tbl): Likewise.
7757
7758 2019-03-29  Keith Seitz  <keiths@redhat.com>
7759
7760         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7761         %s/pulongest for TYPE_LENGTH instead of %d in format
7762         strings.
7763         * ada-typerint.c (ada_print_type): Likewise.
7764         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7765         * compile/compile-c-support.c (generate_register_struct): Likewise.
7766         * gdbtypes.c (recursive_dump_type): Likewise.
7767         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7768         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7769         instead of %d in format strings.
7770         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7771         to std::min to ULONGEST.
7772         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7773         instead of %d in format strings.
7774         * tracepoint.c (info_scope_command): Likewise.
7775         * typeprint.c (print_offset_data::update)
7776         (print_offset_data::finish): Likewise.
7777         * xtensa-tdep.c (xtensa_store_return_value)
7778         (xtensa_push_dummy_call): Likewise.
7779
7780 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7781
7782         * windows-nat.c (display_selector): Fixed format specifications
7783         for 64-bit Cygwin.
7784
7785 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7786
7787         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7788
7789 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7790
7791         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7792         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7793         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7794         (nios2_linux_init_abi): Install it.
7795
7796 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7797
7798         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7799
7800 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7801
7802         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7803
7804 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7805             Tom Tromey  <tromey@adacore.com>
7806
7807         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7808
7809 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7810
7811         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7812         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7813         method to compute the bounds of range types. Also print "[evaluated]"
7814         if the bounds' values come from a dynamic evaluation.
7815
7816 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7817
7818         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7819         whitespace when pretty printing is on.
7820
7821 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7822
7823         * ppc-linux-nat.c: Add include.
7824
7825 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7826
7827         * NEWS: Mention AArch64 Pointer Authentication.
7828
7829 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7830
7831         * arm-linux-nat.c: Add include.
7832
7833 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7834
7835         * source-cache.c (source_cache::get_source_lines): Re-read
7836         fullname after calling open_source_file.
7837
7838 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7839
7840         * NEWS: Mention TLS support for FreeBSD.
7841
7842 2019-03-25  Tom Tromey  <tromey@adacore.com>
7843
7844         * minsyms.c (BUNCH_SIZE): Update comment.
7845         (~minimal_symbol_reader): Remove old comment.
7846         (compact_minimal_symbols): Update comment.
7847         (minimal_symbol_reader::install): Remove old comment.  Update
7848         other comments.
7849
7850 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7851
7852         * s390-linux-nat.c: Add include.
7853
7854 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7855
7856         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7857         Call linux_get_hwcap.
7858         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7859         Likewise.
7860         (aarch64_linux_get_hwcap): Remove function.
7861         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7862         declaration.
7863         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7864         linux_get_hwcap.
7865         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7866         * linux-tdep.c (linux_get_hwcap): Add function.
7867         (linux_get_hwcap2): Likewise.
7868         * linux-tdep.h (linux_get_hwcap): Add declaration.
7869         (linux_get_hwcap2): Likewise.
7870         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7871         (ppc_linux_get_hwcap2): Likewise.
7872         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7873         linux_get_hwcap.
7874         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7875         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7876         (ppc_linux_nat_target::read_description): Likewise.
7877         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7878         * s390-linux-nat.c: Likewise.
7879         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7880
7881 2019-03-24  Tom Tromey  <tom@tromey.com>
7882
7883         * ada-lang.c (standard_lookup): Simplify initialization.
7884         (ada_lookup_symbol_nonlocal): Simplify return.
7885         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7886         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7887         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7888         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7889         initialization.
7890         * solib.c (solib_global_lookup): Simplify.
7891         * symtab.c (null_block_symbol): Remove.
7892         (symbol_cache_lookup): Simplify returns.
7893         (lookup_language_this): Simplify returns.
7894         (lookup_symbol_aux): Simplify return.
7895         (lookup_local_symbol): Simplify returns.
7896         (lookup_global_symbol_from_objfile): Simplify return.
7897         (lookup_symbol_in_objfile_symtabs)
7898         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7899         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7900         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7901         * cp-namespace.c (cp_lookup_bare_symbol)
7902         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7903         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7904         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7905         (cp_lookup_symbol_via_imports): Simplify initialization.
7906         (find_symbol_in_baseclass): Likewise.
7907         * symtab.h (null_block_symbol): Remove.
7908         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7909         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7910         (d_lookup_symbol_module): Likewise.
7911         (find_symbol_in_baseclass): Simplify initialization.
7912
7913 2019-03-24  Tom Tromey  <tom@tromey.com>
7914
7915         * expression.h: Don't include symtab.h.
7916         (struct block): Forward declare.
7917
7918 2019-03-24  Tom Tromey  <tom@tromey.com>
7919
7920         * c-exp.y (typebase): Remove casts.
7921         * gdbtypes.c (lookup_unsigned_typename, )
7922         (lookup_signed_typename): Remove cast.
7923         * eval.c (parse_to_comma_and_eval): Remove cast.
7924         * parse.c (write_dollar_variable): Remove cast.
7925         * block.h (struct block) <superblock>: Now const.
7926         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7927         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7928         (map_block): Make "block" const.
7929         * symfile.h (struct quick_symbol_functions)
7930         <map_matching_symbols>: Constify block argument to "callback".
7931         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7932         const.
7933         (find_pc_sect_compunit_symtab): Make "b" const.
7934         (find_symbol_at_address): Likewise.
7935         (search_symbols): Likewise.
7936         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7937         (dw2_debug_names_lookup_symbol): Likewise.
7938         (dw2_map_matching_symbols): Update.
7939         * p-valprint.c (pascal_val_print): Remove "block".
7940         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7941         (aux_add_nonlocal_symbols): Make "block" const.
7942         (resolve_subexp): Remove cast.
7943         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7944         const.
7945         (iterate_over_file_blocks): Likewise.
7946         * f-exp.y (%union) <bval>: Remove.
7947         * coffread.c (patch_opaque_types): Make "b" const.
7948         * spu-tdep.c (spu_catch_start): Make "block" const.
7949         * c-valprint.c (print_unpacked_pointer): Remove "block".
7950         * symmisc.c (dump_symtab_1): Make "b" const.
7951         (block_depth): Make "block" const.
7952         * d-exp.y (%union) <bval>: Remove.
7953         * cp-support.h (cp_lookup_rtti_type): Update.
7954         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7955         * psymtab.c (psym_lookup_symbol): Make "block" const.
7956         (maintenance_check_psymtabs): Make "b" const.
7957         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7958         (enumerate_locals, enumerate_args): Update.
7959         * python/py-symtab.c (stpy_global_block): Make "block" const.
7960         (stpy_static_block): Likewise.
7961         * inline-frame.c (block_starting_point_at): Make "new_block"
7962         const.
7963         * block.c (find_block_in_blockvector): Make return type const.
7964         (blockvector_for_pc_sect): Make "b" const.
7965         (find_block_in_blockvector): Make "b" const.
7966
7967 2019-03-23  Tom Tromey  <tom@tromey.com>
7968
7969         * varobj.c (varobj_create): Update.
7970         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7971         * printcmd.c (display_command, do_one_display): Don't reset
7972         innermost_block.
7973         * parser-defs.h (enum innermost_block_tracker_type): Move to
7974         expression.h.
7975         (innermost_block): Update comment.
7976         * parse.c (parse_exp_1): Add tracker_types parameter.
7977         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7978         tracker_types parameter.  Reset innermost_block.
7979         (parse_exp_in_context): Remove.
7980         (parse_expression_for_completion): Update.
7981         * objfiles.c (~objfile): Don't reset expression_context_block or
7982         innermost_block.
7983         * expression.h (enum innermost_block_tracker_type): Move from
7984         parser-defs.h.
7985         (parse_exp_1): Add tracker_types parameter.
7986         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7987         reset innermost_block.
7988
7989 2019-03-23  Tom Tromey  <tom@tromey.com>
7990
7991         * objfiles.h: Include bcache.h.
7992
7993 2019-03-23  Tom Tromey  <tom@tromey.com>
7994
7995         * linespec.c (get_current_search_block): Use
7996         scoped_restore_current_language.
7997         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7998
7999 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8000             Jiong Wang  <jiong.wang@arm.com>
8001
8002         * aarch64-linux-tdep.c
8003         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8004         section.
8005         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8006
8007 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8008             Jiong Wang  <jiong.wang@arm.com>
8009
8010         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8011         instructions.
8012         (aarch64_analyze_prologue_test): Add PACIASP test.
8013         (aarch64_prologue_prev_register): Unmask PC value.
8014
8015 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8016             Jiong Wang  <jiong.wang@arm.com>
8017
8018         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8019         (aarch64_dwarf2_prev_register): Unmask PC value.
8020         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8021         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8022         DW_CFA_AARCH64_negate_ra_state.
8023         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8024
8025 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8026             Jiong Wang  <jiong.wang@arm.com>
8027
8028         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8029         registers.
8030         (aarch64_pseudo_register_name): Likewise.
8031         (aarch64_pseudo_register_type): Likewise.
8032         (aarch64_pseudo_register_reggroup_p): Likewise.
8033         (aarch64_gdbarch_init): Add pauth registers.
8034         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8035         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8036         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8037         (struct gdbarch_tdep): Add regnum for ra_state.
8038
8039 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8040             Jiong Wang  <jiong.wang@arm.com>
8041
8042         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8043
8044 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8045             Jiong Wang  <jiong.wang@arm.com>
8046
8047         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8048         function.
8049         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8050         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8051         (aarch64_gdbarch_init): Add puth registers.
8052         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8053         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8054         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8055
8056 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8057             Jiong Wang  <jiong.wang@arm.com>
8058
8059         * aarch64-linux-nat.c
8060         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8061         * aarch64-linux-tdep.c
8062         (aarch64_linux_core_read_description): Likewise.
8063         (aarch64_linux_get_hwcap): New function.
8064         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8065         (aarch64_linux_get_hwcap): New declaration.
8066
8067 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8068             Jiong Wang  <jiong.wang@arm.com>
8069
8070         * aarch64-linux-nat.c
8071         (aarch64_linux_nat_target::read_description): Add pauth param.
8072         * aarch64-linux-tdep.c
8073         (aarch64_linux_core_read_description): Likewise.
8074         * aarch64-tdep.c (struct target_desc): Add in pauth.
8075         (aarch64_read_description): Add pauth param.
8076         (aarch64_gdbarch_init): Likewise.
8077         * aarch64-tdep.h (aarch64_read_description): Likewise.
8078         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8079         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8080         * features/Makefile: Add new files.
8081         * features/aarch64-pauth.c: New file.
8082         * features/aarch64-pauth.xml: New file.
8083
8084 2019-03-20  Tom Tromey  <tromey@adacore.com>
8085
8086         * infrun.c (handle_inferior_event): Rename from
8087         handle_inferior_event_1.  Create a scoped_value_mark.
8088         (handle_inferior_event): Remove.
8089
8090 2019-03-19  Tom Tromey  <tromey@adacore.com>
8091
8092         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8093         * infrun.h (print_stop_event): Add "displays" parameter.
8094         * infrun.c (print_stop_event): Add "displays" parameter.
8095
8096 2019-03-19  Pedro Alves  <palves@redhat.com>
8097
8098         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8099         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8100         to -1.  Fix TABs vs spaces.
8101         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8102         * tui/tui-out.h (tui_ui_out) Add intro comments.
8103         <m_line, m_start_of_line>: In-class initialize, and add describing
8104         comment.
8105
8106 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8107
8108         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8109         variable names.
8110         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8111
8112 2019-03-18  Pedro Alves  <palves@redhat.com>
8113             Eli Zaretskii <eliz@gnu.org>
8114
8115         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8116         m_line and m_start_of_line.
8117
8118 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8119
8120         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8121         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8122         it returns a newline.  This fixes a regression in TU mode, whereby
8123         the next line is output on the same screen line as the user input.
8124
8125 2019-03-18  Tom Tromey  <tromey@adacore.com>
8126
8127         * minsyms.c (minimal_symbol_reader::install): Remove call to
8128         obstack_blank.
8129
8130 2019-03-18  Pedro Alves  <palves@redhat.com>
8131
8132         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8133         New globals.
8134         (apply_style): New, factored out from ...
8135         (apply_ansi_escape): ... this.  Handle reverse video mode.
8136         (tui_set_reverse_mode): New function.
8137         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8138         * tui/tui-winsource.c (tui_show_source_line): Use
8139         tui_set_reverse_mode instead of setting A_STANDOUT.
8140         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8141         New setter methods.
8142
8143 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8144
8145         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8146         Handle tabs.
8147
8148 2019-03-18  Tom Tromey  <tromey@adacore.com>
8149
8150         * ada-lang.c (empty_array): Add "high" parameter.
8151         (ada_evaluate_subexp): Update.
8152
8153 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8154
8155         * unittests/string_view-selftests.c: Define
8156         _initialize_string_view_selftests unconditionally.
8157
8158 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8159
8160         PR gdb/24350
8161         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8162
8163 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8164
8165         PR gdb/24351
8166         * windows-nat.c (display_selector): Fix format specifiers.
8167
8168 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8169
8170         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8171         tui_refill_source_window instead of tui_refresh_win, to update the
8172         current execution line.  This fixes redisplay of the current line
8173         when stepping through the code with "next" or "step".
8174
8175 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8176
8177         * source-cache.c (source_cache::get_source_lines): Call
8178         find_source_lines to initialize s->nlines.  This fixes vertical
8179         scrolling of TUI source window when the DOWN arrow is pressed.
8180
8181 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8182
8183         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8184         linux-thread-db.c (_initialize_thread_db): Likewise.
8185
8186 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8187
8188         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8189         wclrtoeol in tui_show_source_line".  This reverts changes made in
8190         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8191
8192 2019-03-15  Tom Tromey  <tom@tromey.com>
8193
8194         * symtab.h (struct minimal_symbol): Derive from
8195         general_symbol_info.
8196         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8197         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8198         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8199         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8200         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8201         (MSYMBOL_SEARCH_NAME): Update.
8202         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8203         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8204         * minsyms.c (minimal_symbol_reader::record_full): Update.
8205
8206 2019-03-15  Tom Tromey  <tom@tromey.com>
8207
8208         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8209
8210 2019-03-15  Tom Tromey  <tom@tromey.com>
8211
8212         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8213         unique_xmalloc_ptr.
8214         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8215         Update.
8216         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8217         (build_minimal_symbol_hash_tables)
8218         (minimal_symbol_reader::install): Update.
8219
8220 2019-03-15  Tom Tromey  <tom@tromey.com>
8221
8222         * symtab.c (create_demangled_names_hash): Update.
8223         (symbol_set_names): Update.
8224         * objfiles.h (struct objfile_per_bfd_storage)
8225         <demangled_names_hash>: Now an htab_up.
8226         * objfiles.c (objfile_per_bfd_storage): Simplify.
8227
8228 2019-03-15  Tom Tromey  <tom@tromey.com>
8229
8230         * objfiles.h (struct objfile_per_bfd_storage): Declare
8231         destructor.
8232         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8233         New.
8234         (get_objfile_bfd_data): Use new.  Don't initialize
8235         language_of_main.
8236         (free_objfile_per_bfd_storage): Remove.
8237         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8238
8239 2019-03-15  Tom Tromey  <tom@tromey.com>
8240
8241         * symfile.c (reread_symbols): Update.
8242         * objfiles.c (objfile::objfile): Update.
8243         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8244         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8245         comment.
8246         (minimal_symbol_reader::install): Update.
8247         (terminate_minimal_symbol_table): Remove.
8248         * jit.c (jit_object_close_impl): Update.
8249
8250 2019-03-15  Tom Tromey  <tom@tromey.com>
8251
8252         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8253         initializations.
8254
8255 2019-03-15  Tom Tromey  <tom@tromey.com>
8256
8257         * objfiles.h (struct objfile_per_bfd_storage)
8258         <demangled_hash_languages>: Now a bitset.
8259         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8260         (lookup_minimal_symbol): Update.
8261
8262 2019-03-15  Tom Tromey  <tom@tromey.com>
8263
8264         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8265         Don't return the symbol.
8266         * coffread.c (record_minimal_symbol): Use record_full.
8267
8268 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8269
8270         The MS-Windows port of ncurses fails to switch to a color pair if
8271         one or both of the colors are the implicit default colors.  This
8272         change records the default colors when TUI is initialized, and
8273         then specifies them explicitly when a color pair uses the default
8274         colors.  This allows color styling in TUI mode on MS-Windows.
8275
8276         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8277         ncurses_norm_attr.
8278         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8279         colors in ncurses_norm_attr.
8280         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8281         "none", replace it with the default color recorded in
8282         ncurses_norm_attr.
8283
8284 2019-03-14  Tom Tromey  <tromey@adacore.com>
8285
8286         * source-cache.h (class source_cache) <get_source_lines>: Return
8287         std::string.
8288         * source-cache.c (source_cache::extract_lines): Handle case where
8289         first_pos==npos.  Return std::string.
8290         (source_cache::get_source_lines): Update.
8291
8292 2019-03-14  Tom Tromey  <tromey@adacore.com>
8293
8294         * NEWS: Add item for "style sources" commands.
8295         * source-cache.c (source_cache::get_source_lines): Check
8296         source_styling.
8297         * cli/cli-style.c (source_styling): New global.
8298         (_initialize_cli_style): Add "style sources" commands.
8299         (show_style_sources): New function.
8300         * cli/cli-style.h (source_styling): Declare.
8301
8302 2019-03-14  Pedro Alves  <palves@redhat.com>
8303             Tom Tromey  <tromey@adacore.com>
8304
8305         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8306         * tui/tui-winsource.c (tui_refill_source_window): New function,
8307         from...
8308         (tui_horizontal_source_scroll): ... here.  Move some logic.
8309         * cli/cli-style.c (set_style_enabled): Notify new observable.
8310         * tui/tui-hooks.c (tui_redisplay_source): New function.
8311         (tui_attach_detach_observers): Attach or detach
8312         tui_redisplay_source.
8313         * observable.h (source_styling_changed): New observable.
8314         * observable.c: Define source_styling_changed observable.
8315
8316 2019-03-13  Tom Tromey  <tromey@adacore.com>
8317
8318         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8319         (i386_gnu_nat_target::store_registers): Update.
8320         * target-debug.h (target_debug_print_std_string): New macro.
8321         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8322         * windows-tdep.c (display_one_tib): Update.
8323         * tui/tui-stack.c (tui_make_status_line): Update.
8324         * top.c (print_inferior_quit_action): Update.
8325         * thread.c (thr_try_catch_cmd): Update.
8326         (add_thread_with_info): Update.
8327         (thread_target_id_str): Update.
8328         (thr_try_catch_cmd): Update.
8329         (thread_command): Update.
8330         (thread_find_command): Update.
8331         * record-btrace.c (record_btrace_target::info_record)
8332         (record_btrace_resume_thread, record_btrace_target::resume)
8333         (record_btrace_cancel_resume, record_btrace_step_thread)
8334         (record_btrace_target::wait, record_btrace_target::wait)
8335         (record_btrace_target::wait, record_btrace_target::stop): Update.
8336         * progspace.c (print_program_space): Update.
8337         * process-stratum-target.c
8338         (process_stratum_target::thread_address_space): Update.
8339         * linux-fork.c (linux_fork_mourn_inferior)
8340         (detach_checkpoint_command, info_checkpoints_command)
8341         (linux_fork_context): Update.
8342         (linux_fork_detach): Update.
8343         (class scoped_switch_fork_info): Update.
8344         (delete_checkpoint_command): Update.
8345         * infrun.c (follow_fork_inferior): Update.
8346         (follow_fork_inferior): Update.
8347         (proceed_after_vfork_done): Update.
8348         (handle_vfork_child_exec_or_exit): Update.
8349         (follow_exec): Update.
8350         (displaced_step_prepare_throw): Update.
8351         (displaced_step_restore): Update.
8352         (start_step_over): Update.
8353         (resume_1): Update.
8354         (clear_proceed_status_thread): Update.
8355         (proceed): Update.
8356         (print_target_wait_results): Update.
8357         (do_target_wait): Update.
8358         (context_switch): Update.
8359         (stop_all_threads): Update.
8360         (restart_threads): Update.
8361         (finish_step_over): Update.
8362         (handle_signal_stop): Update.
8363         (switch_back_to_stepped_thread): Update.
8364         (keep_going_pass_signal): Update.
8365         (print_exited_reason): Update.
8366         (normal_stop): Update.
8367         * inferior.c (inferior_pid_to_str): Change return type.
8368         (print_selected_inferior): Update.
8369         (add_inferior): Update.
8370         (detach_inferior): Update.
8371         * dummy-frame.c (fprint_dummy_frames): Update.
8372         * dcache.c (dcache_info_1): Update.
8373         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8374         (btrace_fetch, btrace_clear): Update.
8375         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8376         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8377         type.
8378         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8379         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8380         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8381         * gdbarch.c, gdbarch.h: Rebuild.
8382         * gdbarch.sh (core_pid_to_str): Change return type.
8383         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8384         return type.
8385         (windows_nat_target::pid_to_str): Change return type.
8386         (windows_delete_thread): Update.
8387         (windows_nat_target::attach): Update.
8388         (windows_nat_target::files_info): Update.
8389         * target-delegates.c: Rebuild.
8390         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8391         return type.
8392         (sol_thread_target::pid_to_str): Change return type.
8393         * remote.c (class remote_target) <pid_to_str>: Change return
8394         type.
8395         (remote_target::pid_to_str): Change return type.
8396         (extended_remote_target::attach, remote_target::remote_stop_ns)
8397         (remote_target::remote_notif_remove_queued_reply)
8398         (remote_target::push_stop_reply, remote_target::disable_btrace):
8399         Update.
8400         (extended_remote_target::attach): Update.
8401         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8402         type.
8403         (gdbsim_target::pid_to_str): Change return type.
8404         * ravenscar-thread.c (struct ravenscar_thread_target)
8405         <pid_to_str>: Change return type.
8406         (ravenscar_thread_target::pid_to_str): Change return type.
8407         * procfs.c (class procfs_target) <pid_to_str>: Change return
8408         type.
8409         (procfs_target::pid_to_str): Change return type.
8410         (procfs_target::attach): Update.
8411         (procfs_target::detach): Update.
8412         (procfs_target::fetch_registers): Update.
8413         (procfs_target::store_registers): Update.
8414         (procfs_target::wait): Update.
8415         (procfs_target::files_info): Update.
8416         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8417         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8418         return type.
8419         (nto_procfs_target::pid_to_str): Change return type.
8420         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8421         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8422         return type.
8423         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8424         (exit_lwp): Update.
8425         (attach_proc_task_lwp_callback, get_detach_signal)
8426         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8427         (linux_nat_target::resume, wait_lwp, stop_callback)
8428         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8429         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8430         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8431         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8432         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8433         type.
8434         (inf_ptrace_target::attach): Update.
8435         (inf_ptrace_target::files_info): Update.
8436         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8437         type.
8438         (go32_nat_target::pid_to_str): Change return type.
8439         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8440         (gnu_nat_target::wait): Update.
8441         (gnu_nat_target::wait): Update.
8442         (gnu_nat_target::resume): Update.
8443         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8444         (fbsd_nat_target::wait): Update.
8445         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8446         type.
8447         (darwin_nat_target::attach): Update.
8448         * corelow.c (class core_target) <pid_to_str>: Change return type.
8449         (core_target::pid_to_str): Change return type.
8450         * target.c (normal_pid_to_str): Change return type.
8451         (default_pid_to_str): Likewise.
8452         (target_pid_to_str): Change return type.
8453         (target_translate_tls_address): Update.
8454         (target_announce_detach): Update.
8455         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8456         return type.
8457         (bsd_uthread_target::pid_to_str): Change return type.
8458         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8459         type.
8460         (bsd_kvm_target::pid_to_str): Change return type.
8461         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8462         return type.
8463         (aix_thread_target::pid_to_str): Change return type.
8464         * target.h (struct target_ops) <pid_to_str>: Change return type.
8465         (target_pid_to_str, normal_pid_to_str): Likewise.
8466         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8467         type.
8468         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8469         type.
8470         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8471         return type.
8472         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8473         type.
8474         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8475         type.
8476         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8477         return type.
8478
8479 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8480
8481         * NEWS: Mention that the new default MI version is 3.  Mention
8482         changes to the output of commands and events that deal with
8483         multi-location breakpoints.
8484         * breakpoint.c: Include "mi/mi-out.h".
8485         (print_one_breakpoint): Change output syntax if using MI version
8486         >= 3.
8487         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8488         New.
8489         (mi_multi_location_breakpoint_output_fixed): New.
8490         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8491         (mi_cmd_fix_multi_location_breakpoint_output): New.
8492         (mi_multi_location_breakpoint_output_fixed): New.
8493         * mi/mi-cmds.c (mi_cmds): Register command
8494         -fix-multi-location-breakpoint-output.
8495         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8496         interpreter "mi".
8497
8498 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8499
8500         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8501         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8502         instantiate mi_ui_out based on interpreter name.
8503         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8504         * mi/mi-main.c (mi_load_progress): Likewise.
8505
8506 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8507
8508         * NEWS: Combine separate "New targets" sections for 8.3.
8509
8510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8511
8512         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8513         (ppcfbsd_init_abi): Install gdbarch
8514         "fetch_tls_load_module_address" and "get_thread_local_address"
8515         methods.
8516
8517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8518
8519         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8520         (riscv_fbsd_init_abi): Install gdbarch
8521         "fetch_tls_load_module_address" and "get_thread_local_address"
8522         methods.
8523
8524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8525
8526         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8527         (i386fbsd_init_abi): Install gdbarch
8528         "fetch_tls_load_module_address" and "get_thread_local_address"
8529         methods.
8530
8531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8532
8533         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8534         (amd64fbsd_init_abi): Install gdbarch
8535         "fetch_tls_load_module_address" and "get_thread_local_address"
8536         methods.
8537
8538 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8539
8540         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8541         (struct fbsd_pspace_data): New type.
8542         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8543         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8544         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8545         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8546         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8547
8548 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8549
8550         * gdbtypes.c (lookup_struct_elt): New function.
8551         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8552         * gdbtypes.h (struct struct_elt): New type.
8553         (lookup_struct_elt): New prototype.
8554
8555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8556
8557         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8558         remove disabled code block.
8559
8560 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8561
8562         * gdbarch.sh (get_thread_local_address): New method.
8563         * gdbarch.h, gdbarch.c: Regenerate.
8564         * target.c (target_translate_tls_address): Use
8565         gdbarch_get_thread_local_address if present instead of
8566         target::get_thread_local_address.
8567
8568 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8569
8570         * target.h (target::get_thread_local_address): Update comment.
8571
8572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8573
8574         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8575         objfile->separate_debug_objfile_backlink if not NULL.
8576
8577 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8578
8579         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8580         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8581         (amd64bsd_store_inferior_registers): Likewise.
8582         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8583         Enable segment base registers.
8584         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8585         PT_GETFSBASE and PT_GETGSBASE.
8586         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8587         PT_SETGSBASE.
8588         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8589         segment base registers.
8590         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8591
8592 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8593
8594         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8595         Update calls to i386_target_description to add 'segments'
8596         parameter.
8597         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8598         add segment base registers.
8599         * arch/i386.c (i386_create_target_description): Add 'segments'
8600         parameter to enable segment base registers.
8601         * arch/i386.h (i386_create_target_description): Likewise.
8602         * features/i386/32bit-segments.xml: New file.
8603         * features/i386/32bit-segments.c: Generate.
8604         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8605         call to i386_target_description to add 'segments' parameter.
8606         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8607         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8608         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8609         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8610         if feature is present.
8611         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8612         Add 'segments' parameter to call to i386_target_description.
8613         (i386_target_description): Add 'segments' parameter to enable
8614         segment base registers.
8615         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8616         to call to i386_target_description.
8617         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8618         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8619         Define I386_NUM_REGS.
8620         (i386_target_description): Add 'segments' parameter to enable
8621         segment base registers.
8622
8623 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8624
8625         PR/24325
8626         * source-cache.c: #undef open and close, to avoid unresolved
8627         externals during linking.
8628
8629 2019-03-12  Tom Tromey  <tromey@adacore.com>
8630
8631         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8632         const.  Add initializers.
8633         (_initialize_remote): Don't initialize ptid globals.
8634
8635 2019-03-12  Pedro Alves  <palves@redhat.com>
8636
8637         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8638
8639 2019-03-12  Pedro Alves  <palves@redhat.com>
8640
8641         * cp-name-parser.y (main): Remove unused 'len' variable.
8642
8643 2019-03-12  Tom Tromey  <tromey@adacore.com>
8644
8645         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8646         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8647
8648 2019-03-12  Tom Tromey  <tromey@adacore.com>
8649
8650         * linux-nat.c (iterate_over_lwps): Update.
8651         (stop_callback): Remove parameter.
8652         (stop_wait_callback, detach_callback, resume_set_callback)
8653         (select_singlestep_lwp_callback, set_ignore_sigint)
8654         (status_callback, resumed_callback, resume_clear_callback)
8655         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8656         data parameter.
8657         (linux_nat_target::detach, linux_nat_target::resume)
8658         (linux_stop_and_wait_all_lwps, select_event_lwp)
8659         (linux_nat_filter_event, linux_nat_wait_1)
8660         (linux_nat_target::kill, linux_nat_target::stop)
8661         (linux_nat_target::stop): Update.
8662         (linux_nat_resume_callback): Change type.
8663         (resume_stopped_resumed_lwps, count_events_callback)
8664         (select_event_lwp_callback): Likewise.
8665         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8666         * arm-linux-nat.c (struct update_registers_data): Remove.
8667         (update_registers_callback): Change type.
8668         (arm_linux_insert_hw_breakpoint1): Update.
8669         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8670         parameter.
8671         (x86_linux_dr_set_addr): Update.
8672         (x86_linux_dr_set_control): Update.
8673         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8674         (iterate_over_lwps): Use gdb::function_view.
8675         * nat/aarch64-linux-hw-point.c (struct
8676         aarch64_dr_update_callback_param): Remove.
8677         (debug_reg_change_callback): Change type.
8678         (aarch64_notify_debug_reg_change): Update.
8679         * s390-linux-nat.c (s390_refresh_per_info): Update.
8680
8681 2019-03-11  Tom Tromey  <tromey@adacore.com>
8682
8683         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8684         redundant assignment to "this_cu".
8685
8686 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8687
8688         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8689
8690 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8691
8692         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8693         from...
8694         (rank_one_type): ... this.
8695
8696 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8697
8698         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8699         from...
8700         (rank_one_type): ... this.
8701
8702 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8703
8704         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8705         from...
8706         (rank_one_type): ... this.
8707
8708 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8709
8710         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8711         from...
8712         (rank_one_type): ... this.
8713
8714 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8715
8716         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8717         from...
8718         (rank_one_type): ... this.
8719
8720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8721
8722         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8723         from...
8724         (rank_one_type): ... this.
8725
8726 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8727
8728         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8729         from...
8730         (rank_one_type): ... this.
8731
8732 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8733
8734         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8735         from...
8736         (rank_one_type): ... this.
8737
8738 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8739
8740         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8741         from...
8742         (rank_one_type): ... this.
8743
8744 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8745
8746         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8747         from...
8748         (rank_one_type): ... this.
8749
8750 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8751
8752         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8753         from...
8754         (rank_one_type): ... this.
8755
8756 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8757
8758         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8759         from...
8760         (rank_one_type): ... this.
8761
8762 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8763
8764         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8765         inferior-events' shows the example events.
8766
8767 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8768
8769         Support styling on native MS-Windows console
8770
8771         PR/24315
8772         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8773         on MS-Windows if $TERM is not defined.
8774
8775         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8776
8777         * posix-hdep.c (gdb_console_fputs):
8778         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8779         functions.
8780         * ui-file.h (gdb_console_fputs): Add prototype.
8781
8782         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8783         back to fputs only if the former returns zero.
8784
8785 2019-03-07  Tom Tromey  <tom@tromey.com>
8786
8787         * symmisc.c (print_symbol_bcache_statistics): Update.
8788         (print_objfile_statistics): Update.
8789         * symfile.c (allocate_symtab): Update.
8790         * stabsread.c: Don't include bcache.h.
8791         * psymtab.h (struct psymbol_bcache): Don't declare.
8792         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8793         (psymbol_bcache_init, psymbol_bcache_free)
8794         (psymbol_bcache_get_bcache): Don't declare.
8795         * psymtab.c (struct psymbol_bcache): Remove.
8796         (psymtab_storage::psymtab_storage): Update.
8797         (psymtab_storage::~psymtab_storage): Update.
8798         (psymbol_bcache_init, psymbol_bcache_free)
8799         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8800         (add_psymbol_to_bcache): Update.
8801         (allocate_psymtab): Update.
8802         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8803         macro_cache>: No longer pointers.
8804         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8805         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8806         * macrotab.c (macro_bcache): Update.
8807         * macroexp.c: Don't include bcache.h.
8808         * gdbtypes.c (check_types_worklist): Update.
8809         (types_deeply_equal): Remove TRY/CATCH.  Update.
8810         * elfread.c (elf_symtab_read): Update.
8811         * dwarf2read.c: Don't include bcache.h.
8812         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8813         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8814         (print_bcache_statistics, bcache_memory_used): Don't declare.
8815         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8816         methods.  Rename all data members.
8817         * bcache.c (struct bcache): Move to bcache.h.
8818         (bcache::expand_hash_table): Rename from expand_hash_table.
8819         (bcache): Remove.
8820         (bcache::insert): Rename from bcache_full.
8821         (bcache::compare): Rename from bcache_compare.
8822         (bcache_xmalloc): Remove.
8823         (bcache::~bcache): Rename from bcache_xfree.
8824         (bcache::print_statistics): Rename from print_bcache_statistics.
8825         (bcache::memory_used): Rename from bcache_memory_used.
8826
8827 2019-03-07  Pedro Alves  <palves@redhat.com>
8828
8829         * infrun.c (normal_stop): Also check for
8830         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8831
8832 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * f-lang.c (value_from_host_double): Moved to...
8835         * value.c (value_from_host_double): ...here.
8836         * value.h (value_from_host_double): Declare.
8837         * guile/scm-math.c (vlscm_convert_typed_number): Use
8838         value_from_host_double.
8839         (vlscm_convert_number): Likewise.
8840         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8841         * python/py-value.c (convert_value_from_python): Likewise.
8842
8843 2019-03-06  Tom Tromey  <tom@tromey.com>
8844
8845         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8846
8847 2019-03-06  Tom Tromey  <tom@tromey.com>
8848
8849         * utils.h (free_current_contents): Don't declare.
8850         * utils.c (free_current_contents): Remove.
8851
8852 2019-03-06  Tom Tromey  <tom@tromey.com>
8853
8854         * top.c (quit_force): Update.
8855         * main.c (captured_command_loop): Update.
8856         * common/new-op.c (operator new): Update.
8857         * common/common-exceptions.c (struct catcher)
8858         <save_cleanup_chain>: Remove member.
8859         (exceptions_state_mc_init): Update.
8860         (exception_try_scope_entry): Return nullptr.
8861         (exception_try_scope_exit, exception_rethrow)
8862         (throw_exception_sjlj, throw_exception_cxx): Update.
8863         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8864         (all_cleanups, do_cleanups, discard_cleanups)
8865         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8866         (restore_cleanups, restore_final_cleanups): Don't declare.
8867         (do_final_cleanups): Remove parameter.
8868         * common/cleanups.c (cleanup_chain, make_cleanup)
8869         (make_cleanup_dtor, all_cleanups, do_cleanups)
8870         (discard_my_cleanups, discard_cleanups)
8871         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8872         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8873         (null_cleanup): Remove.
8874         (do_final_cleanups): Remove parameter.
8875
8876 2019-03-06  Tom Tromey  <tom@tromey.com>
8877
8878         * remote.c (remote_target::remote_parse_stop_reply): Use
8879         unique_xmalloc_ptr.
8880
8881 2019-03-06  Tom Tromey  <tom@tromey.com>
8882
8883         * stabsread.c (struct stabs_field_info): Rename from field_info.
8884         <list, fnlist>: Add initializers.
8885         <obstack>: New member.
8886         (read_member_functions, read_struct_fields, read_baseclasses):
8887         Allocate on obstack.  Don't use cleanups.
8888         (read_one_struct_field, read_member_functions, read_struct_fields)
8889         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8890         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8891         (read_struct_type): Update.
8892
8893 2019-03-06  Tom Tromey  <tom@tromey.com>
8894
8895         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8896         * common/filestuff.h (make_cleanup_close): Don't declare.
8897         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8898         Remove.
8899
8900 2019-03-06  Tom Tromey  <tom@tromey.com>
8901
8902         * solib-aix.c: Use make_scope_exit.
8903
8904 2019-03-06  Tom Tromey  <tom@tromey.com>
8905
8906         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8907         Use make_scope_exit.
8908
8909 2019-03-06  Tom Tromey  <tom@tromey.com>
8910
8911         * solib-svr4.c (disable_probes_interface): Remove parameter.
8912         (svr4_handle_solib_event): Use make_scope_exit.
8913
8914 2019-03-06  Tom Tromey  <tom@tromey.com>
8915
8916         * remote.c (struct stop_reply_deleter): Remove.
8917         (stop_reply_up): Update.
8918         (struct stop_reply): Derive from notif_event.  Don't typedef.
8919         <regcache>: Now a std::vector.
8920         (stop_reply_xfree): Remove.
8921         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8922         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8923         (remote_target::discard_pending_stop_replies): Use delete.
8924         (remote_target::remote_parse_stop_reply): Update.
8925         (remote_target::process_stop_reply): Update.
8926         * remote-notif.h (struct notif_event): Add virtual destructor.
8927         Remove "dtr" member.
8928         (struct notif_client) <alloc_event>: Return a unique_ptr.
8929         (notif_event_xfree): Don't declare.
8930         (notif_event_up): New typedef.
8931         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8932         (notif_event_xfree, do_notif_event_xfree): Remove.
8933         (remote_notif_state_xfree): Update.
8934
8935 2019-03-06  Tom Tromey  <tom@tromey.com>
8936
8937         * infrun.c (displaced_step_clear_cleanup): Now a
8938         forward_scope_exit type.
8939         (displaced_step_prepare_throw): Update.
8940         (displaced_step_fixup): Update.
8941
8942 2019-03-06  Tom Tromey  <tom@tromey.com>
8943
8944         * inferior.h (class inferior): Update comment.
8945         * gdbthread.h (class thread_info): Update comment.
8946
8947 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8948             Tom Tromey  <tom@tromey.com>
8949
8950         * stabsread.h (struct stab_section_list): Remove.
8951         (coffstab_build_psymtabs): Update.
8952         * dbxread.c (symbuf_sections): Now a std::vector.
8953         (sect_idx): New global.
8954         (fill_symbuf): Update.
8955         (coffstab_build_psymtabs): Change type of stabsects parameter.
8956         Update.
8957         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8958         std::vector.
8959         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8960         (coff_locate_sections): Update.
8961         (coff_symfile_read): Remove cleanups.  Update.
8962         (init_stringtab): Add storage parameter.
8963         (free_stringtab, free_stringtab_cleanup): Remove.
8964         (init_lineno): Add storage parameter.
8965         (free_linetab, free_linetab_cleanup): Remove.
8966
8967 2019-03-06  Pedro Alves  <palves@redhat.com>
8968
8969         * linux-fork.c (fork_info::clobber_regs): Delete.
8970         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8971         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8972         comment.  Adjust.
8973         (scoped_switch_fork_info::scoped_switch_fork_info)
8974         (checkpoint_command, linux_fork_context): Adjust
8975         fork_save_infrun_state calls.
8976
8977 2019-03-06  Pedro Alves  <palves@redhat.com>
8978
8979         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8980         (inf_has_multiple_threads): Return 'bool' and rewrite using
8981         inferior_info::threads().
8982
8983 2019-03-06  Pedro Alves  <palves@redhat.com>
8984
8985         * linux-fork.c: Include <list>.
8986         (fork_list): Now a std::list instance.
8987         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8988         (forks_exist_p, find_last_fork): Adjust.
8989         (new_fork): Delete.
8990         (one_fork_p): New.
8991         (add_fork): Adjust.
8992         (free_fork): Delete, folded into fork_info::~fork_info().
8993         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8994         Adjust.
8995         (init_fork_list): Delete.
8996         (linux_fork_killall, linux_fork_mourn_inferior)
8997         (linux_fork_detach, info_checkpoints_command): Adjust.
8998         (_initialize_linux_fork): No longer call init_fork_list.
8999
9000 2019-03-06  Pedro Alves  <palves@redhat.com>
9001
9002         * linux-fork.c (new_fork): New, split out of ...
9003         (add_fork): ... this.  Return void.  Move "first fork" special
9004         case from here, to ...
9005         (checkpoint_command): ... here.
9006         * linux-linux.h (add_fork): Return void.
9007
9008 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9009
9010         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9011
9012 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9013             Chris January  <chris.january@arm.com>
9014             David Lecomber  <david.lecomber@arm.com>
9015
9016         * f-exp.y: New token, UNOP_INTRINSIC.
9017         (exp): New pattern using UNOP_INTRINSIC token.
9018         (f77_keywords): Add 'abs' keyword.
9019         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9020         (value_from_host_double): New function.
9021         (evaluate_subexp_f): Support UNOP_ABS.
9022
9023 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9024
9025         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9026         types.
9027
9028 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9029
9030         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9031         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9032         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9033
9034 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9035
9036         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9037
9038 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9039             Chris January  <chris.january@arm.com>
9040
9041         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9042         * f-exp.y: Define 'KIND' token.
9043         (exp): New pattern for KIND expressions.
9044         (ptype): Handle types with a kind extension.
9045         (direct_abs_decl): Extend to spot kind extensions.
9046         (f77_keywords): Add 'kind' to the list.
9047         (push_kind_type): New function.
9048         (convert_to_kind_type): New function.
9049         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9050         * parse.c (operator_length_standard): Likewise.
9051         * parser-defs.h (enum type_pieces): Add tp_kind.
9052         * std-operator.def: Add UNOP_KIND.
9053
9054 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9055
9056         * f-exp.y (f_parse): Set yydebug.
9057
9058 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9059
9060         * f-lang.c (evaluate_subexp_f): New function.
9061         (exp_descriptor_f): New global.
9062         (f_language_defn): Use exp_descriptor_f instead of
9063         exp_descriptor_standard.
9064
9065 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9066
9067         * f-exp.y (struct token): Add comments.
9068         (dot_ops): Remove uppercase versions and the end marker.
9069         (f77_keywords): Likewise.
9070         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9071         entries in the dot_ops array are case insensitive, and use
9072         strncasecmp to compare strings.  Also some whitespace cleanup in
9073         this area.  Similar for the f77_keywords array, except entries in
9074         this list might be case sensitive.
9075
9076 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9077
9078         * f-exp.y (struct f77_boolean_val): Add comments.
9079         (boolean_values): Remove uppercase versions, and end marker.
9080         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9081         and use strncasecmp to achieve case insensitivity.  Additionally,
9082         perform whitespace cleanup around this code.
9083
9084 2019-03-06  Tom Tromey  <tromey@adacore.com>
9085
9086         * remote-sim.c (gdbsim_target_open): Use result of
9087         gdb_argv::release.
9088
9089 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9090         Dirk Schubert  <dirk.schubert@arm.com>
9091         Chris January  <chris.january@arm.com>
9092
9093         * eval.c (evaluate_subexp_standard): Call Fortran argument
9094         wrapping logic.
9095         * f-lang.c (struct value): A value which can be passed into a
9096         Fortran function call.
9097         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9098         where appropriate.
9099         (struct type): Value ready for a Fortran function call.
9100         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9101         is needed.
9102         * f-lang.h (fortran_argument_convert): Declaration.
9103         (fortran_preserve_arg_pointer): Declaration.
9104         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9105
9106 2019-03-05  Tom Tromey  <tromey@adacore.com>
9107
9108         * python/py-prettyprint.c (print_string_repr): Remove #if.
9109         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9110
9111 2019-03-05  Tom Tromey  <tromey@adacore.com>
9112
9113         * target.c (the_dummy_target): Move later.  Change type to
9114         "dummy_target".
9115         (initialize_targets): Don't initialize the_dummy_target.
9116
9117 2019-03-05  Tom Tromey  <tromey@adacore.com>
9118
9119         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9120         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9121
9122 2019-03-05  Tom Tromey  <tromey@adacore.com>
9123
9124         * windows-nat.c (windows_nat_target::attach)
9125         (windows_nat_target::detach): Don't call gdb_flush.
9126         * valprint.c (generic_val_print, val_print, val_print_string):
9127         Don't call gdb_flush.
9128         * utils.c (defaulted_query): Don't call gdb_flush.
9129         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9130         * target.c (target_announce_detach): Don't call gdb_flush.
9131         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9132         * remote.c (extended_remote_target::attach): Don't call
9133         gdb_flush.
9134         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9135         * printcmd.c (do_examine): Don't call gdb_flush.
9136         (info_display_command): Don't call gdb_flush.
9137         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9138         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9139         * memattr.c (info_mem_command): Don't call gdb_flush.
9140         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9141         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9142         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9143         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9144         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9145         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9146         (gnu_nat_target::detach): Don't call gdb_flush.
9147         * f-valprint.c (f_val_print): Don't call gdb_flush.
9148         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9149         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9150         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9151         gdb_flush.
9152         * c-valprint.c (c_val_print): Don't call gdb_flush.
9153         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9154
9155 2019-03-05  Tom Tromey  <tromey@adacore.com>
9156
9157         * varobj.c (update_dynamic_varobj_children): Update.
9158         (install_default_visualizer): Use reset, not release.
9159         * value.c (set_internalvar): Update.
9160         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9161         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9162         ATTRIBUTE_UNUSED_RESULT.
9163
9164 2019-03-05  Tom Tromey  <tromey@adacore.com>
9165
9166         * remote.c (class scoped_remote_fd) <release>: Add
9167         ATTRIBUTE_UNUSED_RESULT.
9168
9169 2019-03-05  Tom Tromey  <tromey@adacore.com>
9170
9171         * macroexp.c (struct macro_buffer) <release>: Add
9172         ATTRIBUTE_UNUSED_RESULT.
9173
9174 2019-03-05  Tom Tromey  <tromey@adacore.com>
9175
9176         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9177         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9178         ATTRIBUTE_UNUSED_RESULT.
9179
9180 2019-03-05  Tom Tromey  <tromey@adacore.com>
9181
9182         * common/scoped_fd.h (class scoped_fd) <release>: Add
9183         ATTRIBUTE_UNUSED_RESULT.
9184
9185 2019-03-05  Tom Tromey  <tromey@adacore.com>
9186
9187         * parser-defs.h (struct parser_state) <release>: Add
9188         ATTRIBUTE_UNUSED_RESULT.
9189
9190 2019-03-05  Tom Tromey  <tromey@adacore.com>
9191
9192         * utils.h (class gdb_argv) <release>: Add
9193         ATTRIBUTE_UNUSED_RESULT.
9194         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9195
9196 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9197
9198         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9199         for-loop range, to avoid compiler warnings.
9200
9201         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9202         avoid compiler warnings about unused variables.
9203
9204         * NEWS: Mention end of support for native debugging on MS-Windows
9205         before XP.
9206
9207         PR gdb/24292
9208         * common/netstuff.c:
9209         * gdbserver/gdbreplay.c
9210         * gdbserver/remote-utils.c:
9211         * ser-tcp.c:
9212         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9213         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9214         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9215         'getaddrinfo' and 'freeaddrinfo' were not available before
9216         Windows XP, and mingw.org's MinGW headers by default define
9217         _WIN32_WINNT to 0x500.
9218
9219 2019-03-01  Gary Benson <gbenson@redhat.com>
9220
9221         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9222
9223 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9224             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9225
9226         PR gdb/8527
9227         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9228         set_sigint_trap, clear_sigint_trap.
9229
9230 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9231
9232         * target.c (target_detach): Clear the regcache and the
9233         frame cache.
9234
9235 2019-02-27  Pedro Alves  <palves@redhat.com>
9236
9237         * utils.c (set_screen_size): When we cap the height/width sizes,
9238         tweak the corresponding command variable to show "unlimited":
9239
9240 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9241             Pedro Alves  <palves@redhat.com>
9242
9243         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9244         before calling rl_set_screen_size.
9245
9246 2019-02-27  Tom Tromey  <tromey@adacore.com>
9247
9248         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9249         define.
9250         * python/py-value.c: Remove Python 2.4 workaround.
9251         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9252         workaround.
9253         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9254         Python 2.4 workaround.
9255         * python/python-internal.h: Remove Python 2.4 comment.
9256         (Py_ssize_t): Don't define.
9257         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9258         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9259         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9260         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9261         * python/python.c (do_start_initialization): Remove Python 2.4
9262         workaround.
9263         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9264         (print_children): Remove Python 2.4 workaround.
9265         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9266         workaround.
9267         (CHARBUFFERPROC_NAME): Remove.
9268         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9269         Python 2.4 workaround.
9270
9271 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9272
9273         * NEWS: Note minimum Python version.
9274
9275 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9276
9277         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9278         code from these functions.  Remove corresponding ifdefs.  Use
9279         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9280         Remove gotos and target of gotos.
9281         (infpy_search_memory): Likewise.
9282
9283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9284
9285         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9286         (hppa_gdbarch_init): Don't register deleted functions with
9287         gdbarch.
9288
9289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9292         (h8300_unwind_sp): Delete.
9293         (h8300_dummy_id): Delete.
9294         (h8300_gdbarch_init): Don't register deleted functions with
9295         gdbarch.
9296
9297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9300         (ft32_unwind_pc): Delete.
9301         (ft32_unwind_sp): Delete.
9302         (ft32_gdbarch_init): Don't register deleted functions with
9303         gdbarch.
9304
9305 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9306
9307         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9308         (frv_unwind_pc): Delete.
9309         (frv_unwind_sp): Delete.
9310         (frv_gdbarch_init): Don't register deleted functions with
9311         gdbarch.
9312
9313 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9316         (riscv_unwind_pc): Delete.
9317         (riscv_unwind_sp): Delete.
9318         (riscv_gdbarch_init): Don't register deleted functions with
9319         gdbarch.
9320
9321 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9324         (csky_unwind_pc): Delete.
9325         (csky_unwind_sp): Delete.
9326         (csky_gdbarch_init): Don't register deleted functions with
9327         gdbarch.
9328
9329 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9330
9331         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9332         (cris_unwind_pc): Delete.
9333         (cris_unwind_sp): Delete.
9334         (cris_gdbarch_init): Don't register deleted functions with
9335         gdbarch.
9336
9337 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9338
9339         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9340         (bfin_unwind_pc): Delete.
9341         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9342
9343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9344
9345         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9346         (arm_unwind_pc): Delete.
9347         (arm_unwind_sp): Delete.
9348         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9349
9350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9353         (arc_unwind_pc): Delete.
9354         (arc_unwind_sp): Delete.
9355         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9356
9357 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9360         (alpha_unwind_pc): Delete.
9361         (alpha_gdbarch_init): Don't register deleted functions with
9362         gdbarch.
9363
9364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9365
9366         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9367         (aarch64_unwind_pc): Delete.
9368         (aarch64_unwind_sp): Delete.
9369         (aarch64_gdbarch_init): Don't register deleted functions with
9370         gdbarch.
9371
9372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * gdbtypes.c (type_align): Don't consider static members when
9375         computing structure alignment.
9376
9377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9378
9379         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9380         return 0 for other types.
9381         * arch-utils.c (default_type_align): Always return 0.
9382         * gdbarch.h: Regenerate.
9383         * gdbarch.sh (type_align): Extend comment.
9384         * gdbtypes.c (type_align): Add additional comments, always call
9385         gdbarch_type_align before applying the default rules.
9386         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9387         generic code will then apply a suitable default.
9388         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9389         types, return 0 for other types.
9390
9391 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9392
9393         * NEWS: Create a new section for the next release branch.
9394         Rename the section of the current branch, now that it has
9395         been cut.
9396
9397 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9398
9399         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9400         * version.in: Bump version to 8.3.50.DATE-git.
9401
9402 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9403
9404         * aix-thread.c (ptid_cmp): Remove unused variable.
9405         (get_signaled_thread): Likewise.
9406         (store_regs_user_thread): Likewise.
9407         (store_regs_kernel_thread): Likewise.
9408         (fetch_regs_kernel_thread): Remove shadowed variable.
9409
9410 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9411
9412         * features/riscv/32bit-cpu.xml: Add register numbers.
9413         * features/riscv/32bit-fpu.c: Regenerate.
9414         * features/riscv/32bit-fpu.xml: Add register numbers.
9415         * features/riscv/64bit-cpu.xml: Add register numbers.
9416         * features/riscv/64bit-fpu.c: Regenerate.
9417         * features/riscv/64bit-fpu.xml: Add register numbers.
9418
9419 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9420
9421         * NEWS: Mention two argument form of gdb.Value constructor.
9422         * python/py-value.c (convert_buffer_and_type_to_value): New
9423         function.
9424         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9425         Add support for handling an optional second argument.  Call
9426         convert_buffer_and_type_to_value as appropriate.
9427         * python/python-internal.h (Py_buffer_deleter): New struct.
9428         (Py_buffer_up): New typedef.
9429
9430 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9431
9432         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9433         instead of releasing ownership.
9434
9435 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9436
9437         * dwarf2read.c (open_and_init_dwp_file): Call
9438         elf_numsections instead of bfd_count_sections to initialize
9439         dwp_file->num_sections.
9440
9441 2019-02-25  Tom Tromey  <tromey@adacore.com>
9442
9443         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9444
9445 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9446
9447         * gcore.in: Add '--readnever' option when invoking GDB.
9448
9449 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9450
9451         * MAINTAINERS: Update my email address.
9452
9453 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9454
9455         * build-id.c (build_id_to_debug_bfd_1): New function.
9456         (build_id_to_debug_bfd): Look for separate debug file in
9457         sysroot.
9458
9459 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9460
9461         * gdbarch.sh: Update the copyright year range that is placed into
9462         generated files.
9463
9464 2019-02-22  Keith Seitz  <keiths@redhat.com>
9465
9466         PR symtab/23853
9467         * linespec.c (create_sals_line_offset): Search for the default
9468         symtab's filename instead of its fullname.
9469
9470 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9471
9472         * NEWS: Update style defaults.
9473
9474 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9475
9476         * main.c (captured_main_1): Disable styling in batch mode.
9477
9478 2019-02-20  Tom Tromey  <tom@tromey.com>
9479
9480         * symtab.c (symtab_symbol_info): Fix typos.
9481
9482 2019-02-20  Tom Tromey  <tromey@adacore.com>
9483
9484         * findcmd.c (_initialize_mem_search): Use upper case for
9485         metasyntactic variables.
9486
9487 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9488
9489         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9490         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9491
9492 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9493
9494         * top.h (source_file_name): Change to std::string.
9495         * top.c (source_file_name): Likewise.
9496         (command_line_input): Adjust.
9497         * cli/cli-script.c (script_from_file): Adjust.
9498
9499 2019-02-19  Tom Tromey  <tromey@adacore.com>
9500
9501         * ravenscar-thread.c
9502         (ravenscar_thread_target::update_thread_list): Don't call
9503         ada_build_task_list.
9504         * ada-lang.h (ada_build_task_list): Don't declare.
9505         * ada-tasks.c (struct ada_tasks_inferior_data)
9506         <task_list_valid_p>: Now bool.
9507         (read_known_tasks, ada_task_list_changed)
9508         (ada_tasks_invalidate_inferior_data): Update.
9509         (read_known_tasks_array): Return bool.
9510         (read_known_tasks_list): Likewise.
9511         (read_known_tasks): Return void.
9512         (ada_build_task_list): Now static.
9513
9514 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9517         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9518
9519 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9520
9521         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9522         variant for ada_tasks_pspace_data_handle and
9523         ada_tasks_inferior_data_handle.
9524         (ada_tasks_pspace_data_cleanup): New function.
9525         (ada_tasks_inferior_data_cleanup): New function.
9526
9527 2019-02-17  Tom Tromey  <tom@tromey.com>
9528
9529         * macrotab.h (macro_source_fullname): Return a std::string.
9530         * macrotab.c (macro_include, check_for_redefinition)
9531         (macro_undef, macro_lookup_definition, foreach_macro)
9532         (foreach_macro_in_scope): Update.
9533         (macro_source_fullname): Return a std::string.
9534         * macrocmd.c (show_pp_source_pos): Update.
9535
9536 2019-02-17  Tom Tromey  <tom@tromey.com>
9537
9538         * macrocmd.c (show_pp_source_pos): Style the file names.
9539
9540 2019-02-17  Tom Tromey  <tom@tromey.com>
9541
9542         PR tui/24197:
9543         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9544
9545 2019-02-17  Tom Tromey  <tom@tromey.com>
9546
9547         * ada-lang.c (user_select_syms): Use filtered printing.
9548         * utils.c (wrap_style): New global.
9549         (desired_style): Remove.
9550         (emit_style_escape): Add stream parameter.
9551         (set_output_style, reset_terminal_style, prompt_for_continue):
9552         Update.
9553         (flush_wrap_buffer): Only flush gdb_stdout.
9554         (wrap_here): Set wrap_style.
9555         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9556         treat escape sequences as a character.  Change when wrap buffer is
9557         flushed.
9558         (fputs_styled): Do not set the output style when the default is
9559         requested.
9560         * ui-style.h (struct ui_file_style) <is_default>: New method.
9561         * source.c (print_source_lines_base): Emit escape sequences in one
9562         piece.
9563
9564 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9565
9566         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9567         integers and enumeration types.
9568
9569 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9570
9571         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9572         instead of lookup_symbol_in_language
9573         (do_exact_match): New function.
9574         (ada_get_symbol_name_matcher): Return do_exact_match when
9575         doing a verbatim match.
9576
9577 2019-02-15  Tom Tromey  <tromey@adacore.com>
9578
9579         * ravenscar-thread.c (ravenscar_thread_target::resume)
9580         (ravenscar_thread_target::wait): Special case wildcard requests.
9581
9582 2019-02-15  Tom Tromey  <tromey@adacore.com>
9583
9584         * ravenscar-thread.c (base_ptid): Remove.
9585         (struct ravenscar_thread_target) <close>: New method.
9586         <m_base_ptid>: New member.
9587         <update_inferior_ptid, active_task, task_is_currently_active,
9588         runtime_initialized>: Declare methods.
9589         <ravenscar_thread_target>: Add constructor.
9590         (ravenscar_thread_target::task_is_currently_active)
9591         (ravenscar_thread_target::update_inferior_ptid)
9592         (ravenscar_runtime_initialized): Rename.  Now methods.
9593         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9594         (ravenscar_thread_target::update_thread_list): Update.
9595         (ravenscar_thread_target::active_task): Now method.
9596         (ravenscar_thread_target::store_registers)
9597         (ravenscar_thread_target::prepare_to_store)
9598         (ravenscar_thread_target::prepare_to_store)
9599         (ravenscar_thread_target::mourn_inferior): Update.
9600         (ravenscar_inferior_created): Use "new" to create target.
9601         (ravenscar_thread_target::get_ada_task_ptid): Update.
9602         (_initialize_ravenscar): Don't initialize base_ptid.
9603         (ravenscar_ops): Remove global.
9604
9605 2019-02-15  Tom Tromey  <tromey@adacore.com>
9606
9607         * target.h (push_target): Declare new overload.
9608         * target.c (push_target): New overload, taking an rvalue reference.
9609         * remote.c (remote_target::open_1): Use push_target overload.
9610         * corelow.c (core_target_open): Use push_target overload.
9611
9612 2019-02-15  Tom Tromey  <tromey@adacore.com>
9613
9614         * ravenscar-thread.c (is_ravenscar_task)
9615         (ravenscar_task_is_currently_active): Return bool.
9616         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9617         (_initialize_ravenscar): Remove "(void)".
9618         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9619         Return bool.
9620
9621 2019-02-15  Tom Tromey  <tromey@adacore.com>
9622
9623         * ravenscar-thread.c (ravenscar_runtime_initializer)
9624         (has_ravenscar_runtime, get_running_thread_id)
9625         (ravenscar_thread_target::resume): Fix indentation.
9626
9627 2019-02-15  Tom Tromey  <tromey@adacore.com>
9628
9629         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9630         from ravenscar_arch_ops.
9631         (sparc_ravenscar_ops::fetch_registers)
9632         (sparc_ravenscar_ops::store_registers): Now methods.
9633         (sparc_ravenscar_prepare_to_store): Remove.
9634         (sparc_ravenscar_ops): Redefine.
9635         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9636         methods and destructor.  Remove members.
9637         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9638         (ravenscar_thread_target::store_registers)
9639         (ravenscar_thread_target::prepare_to_store): Update.
9640         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9641         Remove.
9642         (struct ppc_ravenscar_powerpc_ops): Derive from
9643         ravenscar_arch_ops.
9644         (ppc_ravenscar_powerpc_ops::fetch_registers)
9645         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9646         (ppc_ravenscar_powerpc_ops): Redefine.
9647         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9648         (ppc_ravenscar_e500_ops::fetch_registers)
9649         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9650         (ppc_ravenscar_e500_ops): Redefine.
9651         * aarch64-ravenscar-thread.c
9652         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9653         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9654         (aarch64_ravenscar_fetch_registers)
9655         (aarch64_ravenscar_store_registers): Now methods.
9656         (aarch64_ravenscar_ops): Redefine.
9657
9658 2019-02-15  Tom Tromey  <tromey@adacore.com>
9659
9660         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9661         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9662         (ravenscar_thread_target::stopped_by_watchpoint)
9663         (ravenscar_thread_target::stopped_data_address)
9664         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9665
9666 2019-02-15  Tom Tromey  <tromey@adacore.com>
9667
9668         * ravenscar-thread.c: Fix some typos.
9669
9670 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9671             Tom Tromey  <tromey@adacore.com>
9672
9673         * ada-lang.c (ada_exception_sal): Change addr_string to a
9674         std::string.
9675         (create_ada_exception_catchpoint): Update.
9676
9677 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9678             Tom Tromey  <tromey@adacore.com>
9679
9680         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9681         (bp_location_ops): Remove.
9682         (base_breakpoint_allocate_location): Update.
9683         (free_bp_location): Update.
9684         * ada-lang.c (class ada_catchpoint_location)
9685         <ada_catchpoint_location>: Remove ops parameter.
9686         (ada_catchpoint_location_dtor): Remove.
9687         (ada_catchpoint_location_ops): Remove.
9688         (allocate_location_exception): Update.
9689         * breakpoint.h (struct bp_location_ops): Remove.
9690         (class bp_location) <bp_location>: Remove bp_location_ops
9691         parameter.
9692         <~bp_location>: Add destructor.
9693         <ops>: Remove.
9694
9695 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9696             Pedro Alves  <palves@redhat.com>
9697
9698         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9699         'PATH_MAX'.
9700
9701 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9702             Samuel Thibault  <samuel.thibault@gnu.org>
9703             Thomas Schwinge  <thomas@codesourcery.com>
9704
9705         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9706         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9707
9708 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9709
9710         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9711         (check_empty): Use "const char *".
9712
9713         * gnu-nat.c (gnu_nat_target::detach): Instead of
9714         'detach_inferior (pid)' call
9715         'detach_inferior (find_inferior_pid (pid))'.
9716
9717         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9718         'nat/fork-inferior.o'.
9719         * gnu-nat.c: #include "nat/fork-inferior.h".
9720
9721         * gnu-nat.c (gnu_nat_target::detach): Instead of
9722         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9723         * gnu-nat.h: #include "inf-child.h".
9724         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9725         'i386_gnu_nat_target::fetch_registers'.
9726         (gnu_store_registers): Rename/move to
9727         'i386_gnu_nat_target::store_registers'.
9728
9729         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9730         * gnu-nat.h (mach_thread_info): New function.
9731         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9732
9733         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9734
9735 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9736
9737         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9738
9739 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9740
9741         * windows-nat.c (windows_add_thread): Add new parameter
9742         "main_thread_p" with default value set to false.  Update
9743         function documentation as well as all callers.
9744         (windows_delete_thread): Likewise.
9745         (fake_create_process): Update call to windows_add_thread.
9746         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9747         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9748         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9749         call to windows_delete_thread.
9750
9751 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9752
9753         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9754
9755 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9756
9757         * symfile.c (find_separate_debug_file): Use canonical path of
9758         sysroot with child_path instead of gdb_sysroot if it is valid.
9759
9760 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9761
9762         * symfile.c (find_separate_debug_file): Use child_path to
9763         determine if an object file is under a sysroot.
9764
9765 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9766
9767         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9768         unittests/child-path-selftests.c.
9769         * common/pathstuff.c (child_path): New function.
9770         * common/pathstuff.h (child_path): New prototype.
9771         * unittests/child-path-selftests.c: New file.
9772
9773 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9774
9775         * symfile.c (find_separate_debug_file): Look for separate debug
9776         files in debug directories under the sysroot.
9777
9778 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9779
9780         * symtab.h (struct minimal_symbol data_p): New const method.
9781         (struct minimal_symbol text_p): Likewise.
9782         * symtab.c (output_source_filename): Use file name style
9783         to print file name.
9784         (print_symbol_info): Likewise.
9785         (print_msymbol_info): Use address style to print addresses.
9786         Use function name style to print executable text symbols.
9787         (expand_symtab_containing_pc): Use data_p.
9788         (find_pc_sect_compunit_symtab): Likewise.
9789
9790 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9791
9792         * breakpoint.c (describe_other_breakpoints): Use address style
9793         to print addresses.
9794         (say_where): Likewise.
9795
9796 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9797
9798         * ada-typeprint.c (print_func_type): Print function name
9799         style to print function name.
9800         * c-typeprint.c (c_print_type_1): Likewise.
9801
9802 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9803
9804         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9805         for execve.
9806
9807 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9808
9809         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9810         type_stack.
9811
9812 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9813
9814         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9815         TYPE_CODE_REF types.
9816
9817 2019-02-08  Jim Wilson  <jimw@sifive.com>
9818
9819         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9820         (riscv_linux_fregset): New.
9821         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9822
9823 2019-02-07  Tom Tromey  <tom@tromey.com>
9824
9825         * thread.c (thread_cancel_execution_command): Update.
9826         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9827         methods.
9828         (struct thread_fsm_ops): Remove.
9829         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9830         (thread_fsm_should_stop, thread_fsm_return_value)
9831         (thread_fsm_set_finished, thread_fsm_finished_p)
9832         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9833         Don't declare.
9834         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9835         * infrun.c (clear_proceed_status_thread)
9836         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9837         (print_stop_event): Update.
9838         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9839         Add constructor.
9840         (step_command_fsm_ops): Remove.
9841         (new_step_command_fsm): Remove.
9842         (step_1): Update.
9843         (step_command_fsm::should_stop): Rename from
9844         step_command_fsm_should_stop.
9845         (step_command_fsm::clean_up): Rename from
9846         step_command_fsm_clean_up.
9847         (step_command_fsm::do_async_reply_reason): Rename from
9848         step_command_fsm_async_reply_reason.
9849         (struct until_next_fsm): Inherit from thread_fsm.  Add
9850         constructor.
9851         (until_next_fsm_ops): Remove.
9852         (new_until_next_fsm): Remove.
9853         (until_next_fsm::should_stop): Rename from
9854         until_next_fsm_should_stop.
9855         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9856         (until_next_fsm::do_async_reply_reason): Rename from
9857         until_next_fsm_async_reply_reason.
9858         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9859         constructor.  Change type of breakpoint.
9860         (finish_command_fsm_ops): Remove.
9861         (new_finish_command_fsm): Remove.
9862         (finish_command_fsm::should_stop): Rename from
9863         finish_command_fsm_should_stop.
9864         (finish_command_fsm::clean_up): Rename from
9865         finish_command_fsm_clean_up.
9866         (finish_command_fsm::return_value): Rename from
9867         finish_command_fsm_return_value.
9868         (finish_command_fsm::do_async_reply_reason): Rename from
9869         finish_command_fsm_async_reply_reason.
9870         (finish_command): Update.
9871         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9872         Add constructor.
9873         (call_thread_fsm_ops): Remove.
9874         (call_thread_fsm::call_thread_fsm): Rename from
9875         new_call_thread_fsm.
9876         (call_thread_fsm::should_stop): Rename from
9877         call_thread_fsm_should_stop.
9878         (call_thread_fsm::should_notify_stop): Rename from
9879         call_thread_fsm_should_notify_stop.
9880         (run_inferior_call, call_function_by_hand_dummy): Update.
9881         * cli/cli-interp.c (should_print_stop_to_console): Update.
9882         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9883         Add constructor.  Change type of location_breakpoint,
9884         caller_breakpoint.
9885         (until_break_fsm_ops): Remove.
9886         (new_until_break_fsm): Remove.
9887         (until_break_fsm::should_stop): Rename from
9888         until_break_fsm_should_stop.
9889         (until_break_fsm::clean_up): Rename from
9890         until_break_fsm_clean_up.
9891         (until_break_fsm::do_async_reply_reason): Rename from
9892         until_break_fsm_async_reply_reason.
9893         (until_break_command): Update.
9894         * thread-fsm.c: Remove.
9895         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9896
9897 2019-02-07  Tom Tromey  <tom@tromey.com>
9898
9899         * yy-remap.h: Add include guard.
9900         * xtensa-tdep.h: Add include guard.
9901         * xcoffread.h: Rename include guard.
9902         * varobj-iter.h: Add include guard.
9903         * tui/tui.h: Rename include guard.
9904         * tui/tui-winsource.h: Rename include guard.
9905         * tui/tui-wingeneral.h: Rename include guard.
9906         * tui/tui-windata.h: Rename include guard.
9907         * tui/tui-win.h: Rename include guard.
9908         * tui/tui-stack.h: Rename include guard.
9909         * tui/tui-source.h: Rename include guard.
9910         * tui/tui-regs.h: Rename include guard.
9911         * tui/tui-out.h: Rename include guard.
9912         * tui/tui-layout.h: Rename include guard.
9913         * tui/tui-io.h: Rename include guard.
9914         * tui/tui-hooks.h: Rename include guard.
9915         * tui/tui-file.h: Rename include guard.
9916         * tui/tui-disasm.h: Rename include guard.
9917         * tui/tui-data.h: Rename include guard.
9918         * tui/tui-command.h: Rename include guard.
9919         * tic6x-tdep.h: Add include guard.
9920         * target/waitstatus.h: Rename include guard.
9921         * target/wait.h: Rename include guard.
9922         * target/target.h: Rename include guard.
9923         * target/resume.h: Rename include guard.
9924         * target-float.h: Rename include guard.
9925         * stabsread.h: Add include guard.
9926         * rs6000-tdep.h: Add include guard.
9927         * riscv-fbsd-tdep.h: Add include guard.
9928         * regformats/regdef.h: Rename include guard.
9929         * record.h: Rename include guard.
9930         * python/python.h: Rename include guard.
9931         * python/python-internal.h: Rename include guard.
9932         * python/py-stopevent.h: Rename include guard.
9933         * python/py-ref.h: Rename include guard.
9934         * python/py-record.h: Rename include guard.
9935         * python/py-record-full.h: Rename include guard.
9936         * python/py-record-btrace.h: Rename include guard.
9937         * python/py-instruction.h: Rename include guard.
9938         * python/py-events.h: Rename include guard.
9939         * python/py-event.h: Rename include guard.
9940         * procfs.h: Add include guard.
9941         * proc-utils.h: Add include guard.
9942         * p-lang.h: Add include guard.
9943         * or1k-tdep.h: Rename include guard.
9944         * observable.h: Rename include guard.
9945         * nto-tdep.h: Rename include guard.
9946         * nat/x86-linux.h: Rename include guard.
9947         * nat/x86-linux-dregs.h: Rename include guard.
9948         * nat/x86-gcc-cpuid.h: Add include guard.
9949         * nat/x86-dregs.h: Rename include guard.
9950         * nat/x86-cpuid.h: Rename include guard.
9951         * nat/ppc-linux.h: Rename include guard.
9952         * nat/mips-linux-watch.h: Rename include guard.
9953         * nat/linux-waitpid.h: Rename include guard.
9954         * nat/linux-ptrace.h: Rename include guard.
9955         * nat/linux-procfs.h: Rename include guard.
9956         * nat/linux-osdata.h: Rename include guard.
9957         * nat/linux-nat.h: Rename include guard.
9958         * nat/linux-namespaces.h: Rename include guard.
9959         * nat/linux-btrace.h: Rename include guard.
9960         * nat/glibc_thread_db.h: Rename include guard.
9961         * nat/gdb_thread_db.h: Rename include guard.
9962         * nat/gdb_ptrace.h: Rename include guard.
9963         * nat/fork-inferior.h: Rename include guard.
9964         * nat/amd64-linux-siginfo.h: Rename include guard.
9965         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9966         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9967         * nat/aarch64-linux.h: Rename include guard.
9968         * nat/aarch64-linux-hw-point.h: Rename include guard.
9969         * mn10300-tdep.h: Add include guard.
9970         * mips-linux-tdep.h: Add include guard.
9971         * mi/mi-parse.h: Rename include guard.
9972         * mi/mi-out.h: Rename include guard.
9973         * mi/mi-main.h: Rename include guard.
9974         * mi/mi-interp.h: Rename include guard.
9975         * mi/mi-getopt.h: Rename include guard.
9976         * mi/mi-console.h: Rename include guard.
9977         * mi/mi-common.h: Rename include guard.
9978         * mi/mi-cmds.h: Rename include guard.
9979         * mi/mi-cmd-break.h: Rename include guard.
9980         * m2-lang.h: Add include guard.
9981         * location.h: Rename include guard.
9982         * linux-record.h: Rename include guard.
9983         * linux-nat.h: Add include guard.
9984         * linux-fork.h: Add include guard.
9985         * i386-darwin-tdep.h: Rename include guard.
9986         * hppa-linux-offsets.h: Add include guard.
9987         * guile/guile.h: Rename include guard.
9988         * guile/guile-internal.h: Rename include guard.
9989         * gnu-nat.h: Rename include guard.
9990         * gdb-stabs.h: Rename include guard.
9991         * frv-tdep.h: Add include guard.
9992         * f-lang.h: Add include guard.
9993         * event-loop.h: Add include guard.
9994         * darwin-nat.h: Rename include guard.
9995         * cp-abi.h: Rename include guard.
9996         * config/sparc/nm-sol2.h: Rename include guard.
9997         * config/nm-nto.h: Rename include guard.
9998         * config/nm-linux.h: Add include guard.
9999         * config/i386/nm-i386gnu.h: Rename include guard.
10000         * config/djgpp/nl_types.h: Rename include guard.
10001         * config/djgpp/langinfo.h: Rename include guard.
10002         * compile/gcc-cp-plugin.h: Add include guard.
10003         * compile/gcc-c-plugin.h: Add include guard.
10004         * compile/compile.h: Rename include guard.
10005         * compile/compile-object-run.h: Rename include guard.
10006         * compile/compile-object-load.h: Rename include guard.
10007         * compile/compile-internal.h: Rename include guard.
10008         * compile/compile-cplus.h: Rename include guard.
10009         * compile/compile-c.h: Rename include guard.
10010         * common/xml-utils.h: Rename include guard.
10011         * common/x86-xstate.h: Rename include guard.
10012         * common/version.h: Rename include guard.
10013         * common/vec.h: Rename include guard.
10014         * common/tdesc.h: Rename include guard.
10015         * common/selftest.h: Rename include guard.
10016         * common/scoped_restore.h: Rename include guard.
10017         * common/scoped_mmap.h: Rename include guard.
10018         * common/scoped_fd.h: Rename include guard.
10019         * common/safe-iterator.h: Rename include guard.
10020         * common/run-time-clock.h: Rename include guard.
10021         * common/refcounted-object.h: Rename include guard.
10022         * common/queue.h: Rename include guard.
10023         * common/ptid.h: Rename include guard.
10024         * common/print-utils.h: Rename include guard.
10025         * common/preprocessor.h: Rename include guard.
10026         * common/pathstuff.h: Rename include guard.
10027         * common/observable.h: Rename include guard.
10028         * common/netstuff.h: Rename include guard.
10029         * common/job-control.h: Rename include guard.
10030         * common/host-defs.h: Rename include guard.
10031         * common/gdb_wait.h: Rename include guard.
10032         * common/gdb_vecs.h: Rename include guard.
10033         * common/gdb_unlinker.h: Rename include guard.
10034         * common/gdb_unique_ptr.h: Rename include guard.
10035         * common/gdb_tilde_expand.h: Rename include guard.
10036         * common/gdb_sys_time.h: Rename include guard.
10037         * common/gdb_string_view.h: Rename include guard.
10038         * common/gdb_splay_tree.h: Rename include guard.
10039         * common/gdb_setjmp.h: Rename include guard.
10040         * common/gdb_ref_ptr.h: Rename include guard.
10041         * common/gdb_optional.h: Rename include guard.
10042         * common/gdb_locale.h: Rename include guard.
10043         * common/gdb_assert.h: Rename include guard.
10044         * common/filtered-iterator.h: Rename include guard.
10045         * common/filestuff.h: Rename include guard.
10046         * common/fileio.h: Rename include guard.
10047         * common/environ.h: Rename include guard.
10048         * common/common-utils.h: Rename include guard.
10049         * common/common-types.h: Rename include guard.
10050         * common/common-regcache.h: Rename include guard.
10051         * common/common-inferior.h: Rename include guard.
10052         * common/common-gdbthread.h: Rename include guard.
10053         * common/common-exceptions.h: Rename include guard.
10054         * common/common-defs.h: Rename include guard.
10055         * common/common-debug.h: Rename include guard.
10056         * common/cleanups.h: Rename include guard.
10057         * common/buffer.h: Rename include guard.
10058         * common/btrace-common.h: Rename include guard.
10059         * common/break-common.h: Rename include guard.
10060         * cli/cli-utils.h: Rename include guard.
10061         * cli/cli-style.h: Rename include guard.
10062         * cli/cli-setshow.h: Rename include guard.
10063         * cli/cli-script.h: Rename include guard.
10064         * cli/cli-interp.h: Rename include guard.
10065         * cli/cli-decode.h: Rename include guard.
10066         * cli/cli-cmds.h: Rename include guard.
10067         * charset-list.h: Add include guard.
10068         * buildsym-legacy.h: Rename include guard.
10069         * bfin-tdep.h: Add include guard.
10070         * ax.h: Rename include guard.
10071         * arm-linux-tdep.h: Add include guard.
10072         * arm-fbsd-tdep.h: Add include guard.
10073         * arch/xtensa.h: Rename include guard.
10074         * arch/tic6x.h: Add include guard.
10075         * arch/i386.h: Add include guard.
10076         * arch/arm.h: Rename include guard.
10077         * arch/arm-linux.h: Rename include guard.
10078         * arch/arm-get-next-pcs.h: Rename include guard.
10079         * arch/amd64.h: Add include guard.
10080         * arch/aarch64-insn.h: Rename include guard.
10081         * arch-utils.h: Rename include guard.
10082         * annotate.h: Add include guard.
10083         * amd64-darwin-tdep.h: Rename include guard.
10084         * aarch64-linux-tdep.h: Add include guard.
10085         * aarch64-fbsd-tdep.h: Add include guard.
10086         * aarch32-linux-nat.h: Add include guard.
10087
10088 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10089
10090         * macrotab.c (macro_define_internal): New function that
10091         factorizes macro_define_object_internal and macro_define_function
10092         code.
10093         (macro_define_object_internal): Use macro_define_internal.
10094         (macro_define_function): Likewise.
10095
10096 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10097
10098         * macrocmd.c (extract_identifier): Return
10099         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10100         callers.
10101
10102 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10103
10104         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10105
10106 2019-02-05  Tom Tromey  <tom@tromey.com>
10107
10108         * target.c (target_stack::unpush): Move assertion earlier.
10109
10110 2019-01-30  Tom Tromey  <tom@tromey.com>
10111
10112         PR python/23615:
10113         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10114         (gdbpy_parse_and_eval): Likewise.
10115         * python/python-internal.h (gdbpy_allow_threads): New class.
10116
10117 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10118
10119         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10120         (aarch64_fbsd_fpregmap): Move earlier.
10121         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10122         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10123         instead of individual calls to trad_frame_set_reg_addr.
10124         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10125         earlier.
10126         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10127         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10128         instead of individual calls to trad_frame_set_reg_addr.
10129
10130 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10131
10132         * CONTRIBUTE: Replace contribution list with wiki link.
10133
10134 2019-01-25  Tom Tromey  <tom@tromey.com>
10135
10136         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10137
10138 2019-01-25  Tom Tromey  <tom@tromey.com>
10139
10140         * xtensa-linux-nat.c: Fix common/ includes.
10141         * xml-support.h: Fix common/ includes.
10142         * xml-support.c: Fix common/ includes.
10143         * x86-linux-nat.c: Fix common/ includes.
10144         * windows-nat.c: Fix common/ includes.
10145         * varobj.h: Fix common/ includes.
10146         * varobj.c: Fix common/ includes.
10147         * value.c: Fix common/ includes.
10148         * valops.c: Fix common/ includes.
10149         * utils.c: Fix common/ includes.
10150         * unittests/xml-utils-selftests.c: Fix common/ includes.
10151         * unittests/utils-selftests.c: Fix common/ includes.
10152         * unittests/unpack-selftests.c: Fix common/ includes.
10153         * unittests/tracepoint-selftests.c: Fix common/ includes.
10154         * unittests/style-selftests.c: Fix common/ includes.
10155         * unittests/string_view-selftests.c: Fix common/ includes.
10156         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10157         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10158         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10159         * unittests/rsp-low-selftests.c: Fix common/ includes.
10160         * unittests/parse-connection-spec-selftests.c: Fix common/
10161         includes.
10162         * unittests/optional-selftests.c: Fix common/ includes.
10163         * unittests/offset-type-selftests.c: Fix common/ includes.
10164         * unittests/observable-selftests.c: Fix common/ includes.
10165         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10166         * unittests/memrange-selftests.c: Fix common/ includes.
10167         * unittests/memory-map-selftests.c: Fix common/ includes.
10168         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10169         * unittests/function-view-selftests.c: Fix common/ includes.
10170         * unittests/environ-selftests.c: Fix common/ includes.
10171         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10172         * unittests/common-utils-selftests.c: Fix common/ includes.
10173         * unittests/cli-utils-selftests.c: Fix common/ includes.
10174         * unittests/array-view-selftests.c: Fix common/ includes.
10175         * ui-file.c: Fix common/ includes.
10176         * tui/tui-io.c: Fix common/ includes.
10177         * tracepoint.h: Fix common/ includes.
10178         * tracepoint.c: Fix common/ includes.
10179         * tracefile-tfile.c: Fix common/ includes.
10180         * top.h: Fix common/ includes.
10181         * top.c: Fix common/ includes.
10182         * thread.c: Fix common/ includes.
10183         * target/waitstatus.h: Fix common/ includes.
10184         * target/waitstatus.c: Fix common/ includes.
10185         * target.h: Fix common/ includes.
10186         * target.c: Fix common/ includes.
10187         * target-memory.c: Fix common/ includes.
10188         * target-descriptions.c: Fix common/ includes.
10189         * symtab.h: Fix common/ includes.
10190         * symfile.c: Fix common/ includes.
10191         * stap-probe.c: Fix common/ includes.
10192         * spu-linux-nat.c: Fix common/ includes.
10193         * sparc-nat.c: Fix common/ includes.
10194         * source.c: Fix common/ includes.
10195         * solib.c: Fix common/ includes.
10196         * solib-target.c: Fix common/ includes.
10197         * ser-unix.c: Fix common/ includes.
10198         * ser-tcp.c: Fix common/ includes.
10199         * ser-pipe.c: Fix common/ includes.
10200         * ser-base.c: Fix common/ includes.
10201         * selftest-arch.c: Fix common/ includes.
10202         * s12z-tdep.c: Fix common/ includes.
10203         * rust-exp.y: Fix common/ includes.
10204         * rs6000-aix-tdep.c: Fix common/ includes.
10205         * riscv-tdep.c: Fix common/ includes.
10206         * remote.c: Fix common/ includes.
10207         * remote-notif.h: Fix common/ includes.
10208         * remote-fileio.h: Fix common/ includes.
10209         * remote-fileio.c: Fix common/ includes.
10210         * regcache.h: Fix common/ includes.
10211         * regcache.c: Fix common/ includes.
10212         * record-btrace.c: Fix common/ includes.
10213         * python/python.c: Fix common/ includes.
10214         * python/py-type.c: Fix common/ includes.
10215         * python/py-inferior.c: Fix common/ includes.
10216         * progspace.h: Fix common/ includes.
10217         * producer.c: Fix common/ includes.
10218         * procfs.c: Fix common/ includes.
10219         * proc-api.c: Fix common/ includes.
10220         * printcmd.c: Fix common/ includes.
10221         * ppc-linux-nat.c: Fix common/ includes.
10222         * parser-defs.h: Fix common/ includes.
10223         * osdata.c: Fix common/ includes.
10224         * obsd-nat.c: Fix common/ includes.
10225         * nat/x86-linux.c: Fix common/ includes.
10226         * nat/x86-linux-dregs.c: Fix common/ includes.
10227         * nat/x86-dregs.h: Fix common/ includes.
10228         * nat/x86-dregs.c: Fix common/ includes.
10229         * nat/ppc-linux.c: Fix common/ includes.
10230         * nat/mips-linux-watch.h: Fix common/ includes.
10231         * nat/mips-linux-watch.c: Fix common/ includes.
10232         * nat/linux-waitpid.c: Fix common/ includes.
10233         * nat/linux-ptrace.h: Fix common/ includes.
10234         * nat/linux-ptrace.c: Fix common/ includes.
10235         * nat/linux-procfs.c: Fix common/ includes.
10236         * nat/linux-personality.c: Fix common/ includes.
10237         * nat/linux-osdata.c: Fix common/ includes.
10238         * nat/linux-namespaces.c: Fix common/ includes.
10239         * nat/linux-btrace.h: Fix common/ includes.
10240         * nat/linux-btrace.c: Fix common/ includes.
10241         * nat/fork-inferior.c: Fix common/ includes.
10242         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10243         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10244         * nat/aarch64-linux.c: Fix common/ includes.
10245         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10246         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10247         * namespace.h: Fix common/ includes.
10248         * mips-linux-tdep.c: Fix common/ includes.
10249         * minsyms.c: Fix common/ includes.
10250         * mi/mi-parse.h: Fix common/ includes.
10251         * mi/mi-main.c: Fix common/ includes.
10252         * mi/mi-cmd-env.c: Fix common/ includes.
10253         * memrange.h: Fix common/ includes.
10254         * memattr.c: Fix common/ includes.
10255         * maint.h: Fix common/ includes.
10256         * maint.c: Fix common/ includes.
10257         * main.c: Fix common/ includes.
10258         * machoread.c: Fix common/ includes.
10259         * location.c: Fix common/ includes.
10260         * linux-thread-db.c: Fix common/ includes.
10261         * linux-nat.c: Fix common/ includes.
10262         * linux-fork.c: Fix common/ includes.
10263         * inline-frame.c: Fix common/ includes.
10264         * infrun.c: Fix common/ includes.
10265         * inflow.c: Fix common/ includes.
10266         * inferior.h: Fix common/ includes.
10267         * inferior.c: Fix common/ includes.
10268         * infcmd.c: Fix common/ includes.
10269         * inf-ptrace.c: Fix common/ includes.
10270         * inf-child.c: Fix common/ includes.
10271         * ia64-linux-nat.c: Fix common/ includes.
10272         * i387-tdep.c: Fix common/ includes.
10273         * i386-tdep.c: Fix common/ includes.
10274         * i386-linux-tdep.c: Fix common/ includes.
10275         * i386-linux-nat.c: Fix common/ includes.
10276         * i386-go32-tdep.c: Fix common/ includes.
10277         * i386-fbsd-tdep.c: Fix common/ includes.
10278         * i386-fbsd-nat.c: Fix common/ includes.
10279         * guile/scm-type.c: Fix common/ includes.
10280         * guile/guile.c: Fix common/ includes.
10281         * go32-nat.c: Fix common/ includes.
10282         * gnu-nat.c: Fix common/ includes.
10283         * gdbthread.h: Fix common/ includes.
10284         * gdbarch-selftests.c: Fix common/ includes.
10285         * gdb_usleep.c: Fix common/ includes.
10286         * gdb_select.h: Fix common/ includes.
10287         * gdb_bfd.c: Fix common/ includes.
10288         * gcore.c: Fix common/ includes.
10289         * fork-child.c: Fix common/ includes.
10290         * findvar.c: Fix common/ includes.
10291         * fbsd-nat.c: Fix common/ includes.
10292         * event-top.c: Fix common/ includes.
10293         * event-loop.c: Fix common/ includes.
10294         * dwarf2read.c: Fix common/ includes.
10295         * dwarf2loc.c: Fix common/ includes.
10296         * dwarf2-frame.c: Fix common/ includes.
10297         * dwarf-index-cache.c: Fix common/ includes.
10298         * dtrace-probe.c: Fix common/ includes.
10299         * disasm-selftests.c: Fix common/ includes.
10300         * defs.h: Fix common/ includes.
10301         * csky-tdep.c: Fix common/ includes.
10302         * cp-valprint.c: Fix common/ includes.
10303         * cp-support.h: Fix common/ includes.
10304         * cp-support.c: Fix common/ includes.
10305         * corelow.c: Fix common/ includes.
10306         * completer.h: Fix common/ includes.
10307         * completer.c: Fix common/ includes.
10308         * compile/compile.c: Fix common/ includes.
10309         * compile/compile-loc2c.c: Fix common/ includes.
10310         * compile/compile-cplus-types.c: Fix common/ includes.
10311         * compile/compile-cplus-symbols.c: Fix common/ includes.
10312         * command.h: Fix common/ includes.
10313         * cli/cli-dump.c: Fix common/ includes.
10314         * cli/cli-cmds.c: Fix common/ includes.
10315         * charset.c: Fix common/ includes.
10316         * build-id.c: Fix common/ includes.
10317         * btrace.h: Fix common/ includes.
10318         * btrace.c: Fix common/ includes.
10319         * breakpoint.h: Fix common/ includes.
10320         * breakpoint.c: Fix common/ includes.
10321         * ax.h:
10322         (enum agent_op): Fix common/ includes.
10323         * ax-general.c (struct aop_map): Fix common/ includes.
10324         * ax-gdb.c: Fix common/ includes.
10325         * auxv.c: Fix common/ includes.
10326         * auto-load.c: Fix common/ includes.
10327         * arm-tdep.c: Fix common/ includes.
10328         * arch/riscv.c: Fix common/ includes.
10329         * arch/ppc-linux-common.c: Fix common/ includes.
10330         * arch/i386.c: Fix common/ includes.
10331         * arch/arm.c: Fix common/ includes.
10332         * arch/arm-linux.c: Fix common/ includes.
10333         * arch/arm-get-next-pcs.c: Fix common/ includes.
10334         * arch/amd64.c: Fix common/ includes.
10335         * arch/aarch64.c: Fix common/ includes.
10336         * arch/aarch64-insn.c: Fix common/ includes.
10337         * arch-utils.c: Fix common/ includes.
10338         * amd64-windows-tdep.c: Fix common/ includes.
10339         * amd64-tdep.c: Fix common/ includes.
10340         * amd64-sol2-tdep.c: Fix common/ includes.
10341         * amd64-obsd-tdep.c: Fix common/ includes.
10342         * amd64-nbsd-tdep.c: Fix common/ includes.
10343         * amd64-linux-tdep.c: Fix common/ includes.
10344         * amd64-linux-nat.c: Fix common/ includes.
10345         * amd64-fbsd-tdep.c: Fix common/ includes.
10346         * amd64-fbsd-nat.c: Fix common/ includes.
10347         * amd64-dicos-tdep.c: Fix common/ includes.
10348         * amd64-darwin-tdep.c: Fix common/ includes.
10349         * agent.c: Fix common/ includes.
10350         * ada-lang.h: Fix common/ includes.
10351         * ada-lang.c: Fix common/ includes.
10352         * aarch64-tdep.c: Fix common/ includes.
10353
10354 2019-01-25  Tom Tromey  <tom@tromey.com>
10355
10356         * common/create-version.sh: Use common/version.h.
10357
10358 2019-01-24  Pedro Alves  <palves@redhat.com>
10359
10360         * infrun.c (signal_stop, signal_print, signal_program)
10361         (signal_catch, signal_pass): Now arrays instead of pointers.
10362         (update_signals_program_target, do_target_resume)
10363         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10364         * linux-nat.c (linux_nat_target::pass_signals)
10365         (linux_nat_target::create_inferior, linux_nat_target::attach):
10366         Adjust.
10367         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10368         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10369         * procfs.c (procfs_target::pass_signals): Adjust.
10370         * record-full.c (record_full_target::resume): Adjust.
10371         * remote.c (remote_target::pass_signals)
10372         (remote_target::program_signals): Adjust.
10373         * target-debug.h (target_debug_print_signals): Now takes a
10374         gdb::array_view as parameter.  Adjust.
10375         * target.h (target_ops) <pass_signals, program_signals>: Replace
10376         pointer and length parameters with gdb::array_view.
10377         (target_pass_signals, target_program_signals): Likewise.
10378         * target-delegates.c: Regenerate.
10379
10380 2019-01-24  Pedro Alves  <palves@redhat.com>
10381
10382         * common/forward-scope-exit.h
10383         (forward_scope_exit::forward_scope_exit): Pass arguments to
10384         m_bind_function directly, instead of creating a std::bind and
10385         copying that.
10386
10387 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10388
10389         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10390         for static members.
10391         (pass_in_v_vfp_candidate): Likewise.
10392
10393 2019-01-23  Tom Tromey  <tom@tromey.com>
10394             Pedro Alves  <palves@redhat.com>
10395
10396         * regcache.c (class regcache_invalidator): Remove.
10397         (regcache::raw_write): Use make_scope_exit.
10398
10399 2019-01-23  Tom Tromey  <tom@tromey.com>
10400
10401         * ui-out.h (class ui_out_emit_type): Update comment.
10402
10403 2019-01-23  Tom Tromey  <tom@tromey.com>
10404
10405         * infrun.c (fetch_inferior_event): Update comment.
10406
10407 2019-01-23  Tom Tromey  <tom@tromey.com>
10408             Pedro Alves  <palves@redhat.com>
10409
10410         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10411         parameter.
10412         (fetch_inferior_event): Use SCOPE_EXIT.
10413
10414
10415 2019-01-23  Tom Tromey  <tom@tromey.com>
10416             Pedro Alves  <palves@redhat.com>
10417
10418         * infrun.c (disable_thread_events): Delete.
10419         (stop_all_threads): Use SCOPE_EXIT.
10420
10421 2019-01-23  Tom Tromey  <tom@tromey.com>
10422             Pedro Alves  <palves@redhat.com>
10423
10424         * symfile.c: Include forward-scope-exit.h.
10425         (clear_symtab_users_cleanup): Replace forward declaration with
10426         a FORWARD_SCOPE_EXIT.
10427         (syms_from_objfile_1): Use the forward_scope_exit and
10428         gdb::optional instead of cleanup_function.
10429         (reread_symbols): Use the forward_scope_exit instead of
10430         cleanup_function.
10431         (clear_symtab_users_cleanup): Remove function.
10432
10433 2019-01-23  Tom Tromey  <tom@tromey.com>
10434             Pedro Alves  <palves@redhat.com>
10435
10436         * linux-nat.c: Include scope-exit.h.
10437         (cleanup_target_stop): Remove.
10438         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10439         SCOPE_EXIT.
10440
10441 2019-01-23  Tom Tromey  <tom@tromey.com>
10442             Pedro Alves  <palves@redhat.com>
10443
10444         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10445         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10446
10447 2019-01-23  Tom Tromey  <tom@tromey.com>
10448             Andrew Burgess  <andrew.burgess@embecosm.com>
10449             Pedro Alves  <palves@redhat.com>
10450
10451         * infrun.c (fetch_inferior_event): Use scope_exit.
10452         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10453         * top.c (execute_command): Use scope_exit.
10454         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10455         * utils.c (do_bpstat_clear_actions_cleanup)
10456         (make_bpstat_clear_actions_cleanup): Remove.
10457
10458 2019-01-23  Tom Tromey  <tom@tromey.com>
10459             Pedro Alves  <palves@redhat.com>
10460
10461         * infrun.c: Include "common/scope-exit.h"
10462         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10463         (wait_for_inferior): Use SCOPE_EXIT.
10464         (fetch_inferior_event): Use scope_exit.
10465
10466 2019-01-23  Tom Tromey  <tom@tromey.com>
10467             Pedro Alves  <palves@redhat.com>
10468
10469         * breakpoint.c (create_breakpoint): Remove cleanup.
10470
10471 2019-01-23  Tom Tromey  <tom@tromey.com>
10472             Andrew Burgess  <andrew.burgess@embecosm.com>
10473             Pedro Alves  <palves@redhat.com>
10474
10475 2019-01-23  Pedro Alves  <palves@redhat.com>
10476
10477         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10478
10479 2019-01-23  Pedro Alves  <palves@redhat.com>
10480             Andrew Burgess  <andrew.burgess@embecosm.com>
10481
10482         * gdbthread.h: Include "common/forward-scope-exit.h".
10483         (scoped_finish_thread_state): Redefine custom class in terms of
10484         forward_scope_exit.
10485
10486 2019-01-23  Pedro Alves  <palves@redhat.com>
10487             Andrew Burgess  <andrew.burgess@embecosm.com>
10488
10489         * common/forward-scope-exit.h: New file.
10490
10491 2019-01-23  Pedro Alves  <palves@redhat.com>
10492             Andrew Burgess  <andrew.burgess@embecosm.com>
10493             Tom Tromey  <tom@tromey.com>
10494
10495         * common/scope-exit.h: New file.
10496
10497 2019-01-23  Pedro Alves  <palves@redhat.com>
10498
10499         * common/preprocessor.h (ESC): Rename to ...
10500         (ESC_PARENS): ... this.
10501         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10502         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10503
10504 2019-01-23  Tom Tromey  <tom@tromey.com>
10505
10506         * language.h (class scoped_switch_to_sym_language_if_auto):
10507         Initialize m_lang in both cases.
10508
10509 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10510
10511         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10512         with XCNEW.
10513
10514 2019-01-22  Tom Tromey  <tom@tromey.com>
10515
10516         * corelow.c: Do not include sys/file.h.
10517
10518 2019-01-22  Tom Tromey  <tom@tromey.com>
10519
10520         * tui/tui-wingeneral.h: Include gdb_curses.h.
10521
10522 2019-01-22  Tom Tromey  <tom@tromey.com>
10523
10524         * source-cache.h (class source_cache) <get_source_lines,
10525         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10526
10527 2019-01-22  Tom Tromey  <tom@tromey.com>
10528
10529         * remote-fileio.h (struct remote_target): Declare.
10530
10531 2019-01-22  Tom Tromey  <tom@tromey.com>
10532
10533         * python/py-arch.c: Do not include py-ref.h.
10534         * python/py-bpevent.c: Do not include py-ref.h.
10535         * python/py-cmd.c: Do not include py-ref.h.
10536         * python/py-continueevent.c: Do not include py-ref.h.
10537         * python/py-event.h: Do not include py-ref.h.
10538         * python/py-evtregistry.c: Do not include py-ref.h.
10539         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10540         * python/py-frame.c: Do not include py-ref.h.
10541         * python/py-framefilter.c: Do not include py-ref.h.
10542         * python/py-function.c: Do not include py-ref.h.
10543         * python/py-infevents.c: Do not include py-ref.h.
10544         * python/py-linetable.c: Do not include py-ref.h.
10545         * python/py-objfile.c: Do not include py-ref.h.
10546         * python/py-param.c: Do not include py-ref.h.
10547         * python/py-prettyprint.c: Do not include py-ref.h.
10548         * python/py-progspace.c: Do not include py-ref.h.
10549         * python/py-symbol.c: Do not include py-ref.h.
10550         * python/py-symtab.c: Do not include py-ref.h.
10551         * python/py-type.c: Do not include py-ref.h.
10552         * python/py-unwind.c: Do not include py-ref.h.
10553         * python/py-utils.c: Do not include py-ref.h.
10554         * python/py-value.c: Do not include py-ref.h.
10555         * python/py-varobj.c: Do not include py-ref.h.
10556         * python/py-xmethods.c: Do not include py-ref.h.
10557         * python/python.c: Do not include py-ref.h.
10558         * varobj.c: Do not include py-ref.h.
10559
10560 2019-01-22  Tom Tromey  <tom@tromey.com>
10561
10562         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10563         keyword for bcache.
10564
10565 2019-01-22  Tom Tromey  <tom@tromey.com>
10566
10567         * compile/compile-cplus-types.c: Remove a comment by #include.
10568
10569 2019-01-22  Tom Tromey  <tom@tromey.com>
10570
10571         * compile/gcc-c-plugin.h: Include compile-internal.h.
10572
10573 2019-01-22  Tom Tromey  <tom@tromey.com>
10574
10575         * stabsread.c (EXTERN): Do not define.
10576         (symnum, next_symbol_text_func, processing_gcc_compilation)
10577         (within_function, global_sym_chain, global_stabs)
10578         (previous_stab_code, this_object_header_files)
10579         (n_this_object_header_files)
10580         (n_allocated_this_object_header_files): Define.
10581         * stabsread.h (EXTERN): Never define.  Use "extern".
10582
10583 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10584
10585         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10586         history_value.
10587
10588 2019-01-21  Tom Tromey  <tom@tromey.com>
10589
10590         * ui-out.c: Fix includes.
10591         * tui/tui-source.c: Fix includes.
10592         * target.c: Fix includes.
10593         * remote.c: Fix includes.
10594         * regcache.c: Fix includes.
10595         * python/py-block.c: Fix includes.
10596         * printcmd.c: Fix includes.
10597         * or1k-tdep.c: Fix includes.
10598         * mi/mi-main.c: Fix includes.
10599         * m32r-tdep.c: Fix includes.
10600         * csky-tdep.c: Fix includes.
10601         * compile/compile-cplus-types.c: Fix includes.
10602         * cli/cli-interp.c: Fix includes.
10603
10604 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10605
10606         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10607         for padding.
10608
10609 2019-01-16  Tom Tromey  <tom@tromey.com>
10610
10611         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10612         earlier.
10613         (struct objfile) <msymbols_range>: Move from top level.
10614         <msymbols>: New method.
10615         (class objfile_msymbols): Remove.
10616         * symtab.c (default_collect_symbol_completion_matches_break_on):
10617         Update.
10618         * symmisc.c (dump_msymbols): Update.
10619         * stabsread.c (scan_file_globals): Update.
10620         * objc-lang.c (info_selectors_command, info_classes_command)
10621         (find_methods): Update.
10622         * minsyms.c (find_solib_trampoline_target): Update.
10623         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10624         * coffread.c (coff_symfile_read): Update.
10625         * ada-lang.c (ada_lookup_simple_minsym)
10626         (ada_collect_symbol_completion_matches): Update.
10627
10628 2019-01-16  Tom Tromey  <tom@tromey.com>
10629
10630         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10631         type.  Remove no-argument constructor.
10632         <iterator::operator++>: Simplify.
10633         <begin>: Update.
10634         <end>: Use minimal_symbol_count.
10635
10636 2019-01-16  Tom Tromey  <tom@tromey.com>
10637
10638         * objfiles.h (struct objfile) <psymtabs>: New method.
10639         (class objfile_psymtabs): Remove.
10640         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10641         typedef.
10642         <range>: New method.
10643         (require_partial_symbols): Change return type.
10644         * psymtab.c (require_partial_symbols)
10645         (psym_expand_symtabs_matching): Update.
10646         * mdebugread.c (parse_partial_symbols): Update.
10647         * dbxread.c (dbx_end_psymtab): Update.
10648
10649 2019-01-15  Tom Tromey  <tom@tromey.com>
10650
10651         * symtab.c (lookup_objfile_from_block)
10652         (lookup_symbol_in_objfile_symtabs)
10653         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10654         (find_line_symtab, info_sources_command)
10655         (default_collect_symbol_completion_matches_break_on)
10656         (make_source_files_completion_list): Update.
10657         * symmisc.c (print_objfile_statistics, dump_objfile)
10658         (maintenance_print_symbols, maintenance_info_symtabs)
10659         (maintenance_check_symtabs, maintenance_info_line_tables):
10660         Update.
10661         * source.c (select_source_symtab)
10662         (forget_cached_source_info_for_objfile): Update.
10663         * objfiles.h (class objfile_compunits): Remove.
10664         (struct objfile) <compunits_range>: New typedef.
10665         (compunits): New method.
10666         * objfiles.c (objfile_relocate1): Update.
10667         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10668         * maint.c (count_symtabs_and_blocks): Update.
10669         * linespec.c (iterate_over_all_matching_symtabs): Update.
10670         * cp-support.c (add_symbol_overload_list_qualified): Update.
10671         * coffread.c (coff_symtab_read): Update.
10672         * ada-lang.c (add_nonlocal_symbols)
10673         (ada_collect_symbol_completion_matches)
10674         (ada_add_global_exceptions): Update.
10675
10676 2019-01-15  Tom Tromey  <tom@tromey.com>
10677
10678         * progspace.h (program_space) <objfiles_safe_range>: New
10679         typedef.
10680         <objfiles_safe>: New method.
10681         * objfiles.h (class all_objfiles_safe): Remove.
10682         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10683         * jit.c (jit_inferior_exit_hook): Update.
10684
10685 2019-01-17  Tom Tromey  <tom@tromey.com>
10686
10687         * progspace.h (program_space) <objfiles_range>: New typedef.
10688         <objfiles>: New method.
10689         <objfiles_head>: Rename from objfiles.
10690         (object_files): Update.
10691         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10692         * guile/scm-pretty-print.c
10693         (ppscm_find_pretty_printer_from_objfiles): Update.
10694         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10695         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10696         Update.
10697         * python/py-progspace.c (pspy_get_objfiles): Update.
10698         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10699         Update.
10700         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10701         (objfpy_lookup_objfile_by_build_id): Update.
10702         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10703         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10704         Update.
10705         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10706         (expand_symtab_containing_pc, lookup_objfile_from_block)
10707         (lookup_static_symbol, basic_lookup_transparent_type)
10708         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10709         (find_line_symtab, info_sources_command)
10710         (default_collect_symbol_completion_matches_break_on)
10711         (make_source_files_completion_list, find_main_name): Update.
10712         * symmisc.c (print_symbol_bcache_statistics)
10713         (print_objfile_statistics, maintenance_print_symbols)
10714         (maintenance_print_msymbols, maintenance_print_objfiles)
10715         (maintenance_info_symtabs, maintenance_check_symtabs)
10716         (maintenance_expand_symtabs, maintenance_info_line_tables):
10717         Update.
10718         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10719         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10720         (map_overlay_command, unmap_overlay_command)
10721         (simple_overlay_update, expand_symtabs_matching)
10722         (map_symbol_filenames): Update.
10723         * symfile-debug.c (set_debug_symfile): Update.
10724         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10725         Update.
10726         * source.c (select_source_symtab, forget_cached_source_info):
10727         Update.
10728         * solib.c (solib_read_symbols): Update.
10729         * solib-spu.c (append_ocl_sos): Update.
10730         * psymtab.c (maintenance_print_psymbols)
10731         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10732         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10733         * printcmd.c (info_symbol_command): Update.
10734         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10735         Update.
10736         * objfiles.h (class all_objfiles): Remove.
10737         * objfiles.c (have_partial_symbols, have_full_symbols)
10738         (have_minimal_symbols, qsort_cmp, update_section_map)
10739         (shared_objfile_contains_address_p)
10740         (default_iterate_over_objfiles_in_search_order): Update.
10741         * objc-lang.c (info_selectors_command, info_classes_command)
10742         (find_methods): Update.
10743         * minsyms.c (find_solib_trampoline_target): Update.
10744         * maint.c (maintenance_info_sections)
10745         (maintenance_translate_address, count_symtabs_and_blocks):
10746         Update.
10747         * main.c (captured_main_1): Update.
10748         * linux-thread-db.c (try_thread_db_load_from_pdir)
10749         (has_libpthread): Update.
10750         * linespec.c (iterate_over_all_matching_symtabs)
10751         (search_minsyms_for_name): Update.
10752         * jit.c (jit_find_objf_with_entry_addr): Update.
10753         * hppa-tdep.c (find_unwind_entry)
10754         (hppa_lookup_stub_minimal_symbol): Update.
10755         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10756         Update.
10757         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10758         (elf_gnu_ifunc_resolve_by_got): Update.
10759         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10760         * dwarf-index-write.c (save_gdb_index_command): Update.
10761         * cp-support.c (add_symbol_overload_list_qualified): Update.
10762         * breakpoint.c (create_overlay_event_breakpoint)
10763         (create_longjmp_master_breakpoint)
10764         (create_std_terminate_master_breakpoint)
10765         (create_exception_master_breakpoint): Update.
10766         * blockframe.c (find_pc_partial_function): Update.
10767         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10768         (ada_collect_symbol_completion_matches)
10769         (ada_add_global_exceptions): Update.
10770
10771 2019-01-17  Tom Tromey  <tom@tromey.com>
10772
10773         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10774         declare VEC.
10775         (solib_target_parse_libraries): Change return type.
10776         (library_list_start_segment, library_list_start_section)
10777         (library_list_end_library, library_list_start_library); Update.
10778         (solib_target_free_library_list): Remove.
10779         (solib_target_parse_libraries): Remove cleanup.  Change return
10780         type.
10781         (solib_target_current_sos): Update.
10782
10783 2019-01-17  Tom Tromey  <tromey@bapiya>
10784
10785         * valprint.c: Replace "the the" with "the".
10786         * symtab.c: Replace "the the" with "the".
10787         * solib.c: Replace "the the" with "the".
10788         * solib-dsbt.c: Replace "the the" with "the".
10789         * linespec.c: Replace "the the" with "the".
10790         * dwarf2loc.h: Replace "the the" with "the".
10791         * amd64-windows-tdep.c: Replace "the the" with "the".
10792         * aarch64-tdep.c: Replace "the the" with "the".
10793
10794 2019-01-16  Keith Seitz  <keiths@redhat.com>
10795
10796         PR gdb/23773
10797         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10798         <builder>: Rename to ..
10799         <m_builder>: ... this and make private.
10800         (dwarf2_cu::get_builder): New method.  Change all users of
10801         `builder' to use this method.
10802         (dwarf2_start_symtab): Move to ...
10803         (dwarf2_cu::start_symtab): ... here.  Update all callers
10804         (setup_type_unit_groups): Move to ...
10805         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10806         callers.
10807         (dwarf2_cu::reset_builder): New method.
10808         (process_full_compunit, process_full_type_unit): Use
10809         dwarf2_cu::reset_builder.
10810         (follow_die_offset): Record the ancestor CU if it is different
10811         from the followed DIE's CU.
10812         (follow_die_sig_1): Likewise.
10813
10814 2019-01-15  Tom Tromey  <tom@tromey.com>
10815
10816         * remote.c (class remote_state) <buf>: Now a char_vector.
10817         <buf_size>: Remove.
10818         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10819         parameter.
10820         (remote_target::getpkt_or_notif_sane_1)
10821         (remote_target::getpkt_sane)
10822         (remote_target::getpkt_or_notif_sane): Likewise.
10823         (class remote_target) <putpkt>: New overload.
10824         (remote_target::read_frame): Change type of "buf_p".  Remove
10825         sizeof_p parameter.
10826         (packet_ok): New overload.
10827         (packet_check_result): New overload.
10828         Update all uses.
10829
10830 2019-01-14  Tom Tromey  <tom@tromey.com>
10831
10832         * remote-notif.c (handle_notification, remote_notif_ack)
10833         (remote_notif_parse): Make "buf" const.
10834         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10835         const.
10836         (remote_notif_parse, remote_notif_ack, handle_notification):
10837         Likewise.
10838         * remote.c (remote_notif_stop_parse): Make "buf" const.
10839         (remote_target::remote_parse_stop_reply): Make "buf" const.
10840         (remote_notif_stop_ack): Make "buf" const.
10841
10842 2019-01-14  Tom Tromey  <tom@tromey.com>
10843
10844         * remote.c (remote_console_output): Make parameter const.
10845
10846 2019-01-14  Tom Tromey  <tom@tromey.com>
10847
10848         * target-debug.h (target_debug_print_signals): Constify.
10849         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10850         * procfs.c (procfs_target::pass_signals): Update.
10851         * linux-nat.c (linux_nat_target::pass_signals): Update.
10852         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10853         * target-delegates.c: Rebuild.
10854         * remote.c (remote_target::program_signals): Update.
10855         (remote_target::pass_signals): Update.
10856         * target.c (target_pass_signals): Constify argument.
10857         (target_program_signals): Likewise.
10858         * target.h (struct target_ops) <pass_signals, program_signals>:
10859         Constify argument.
10860         (target_pass_signals, target_program_signals): Constify argument.
10861
10862 2019-01-14  Tom Tromey  <tom@tromey.com>
10863
10864         PR tui/28819:
10865         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10866
10867 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10868
10869         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10870         field.
10871         * rs6000-tdep.c: Include reggroups.h.
10872         (IS_V_ALIAS_PSEUDOREG): Define.
10873         (rs6000_register_name): Return names for the "vX" aliases.
10874         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10875         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10876         aliases.  Call default_register_reggroup_p for all other
10877         pseudo-registers.
10878         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10879         New functions.
10880         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10881         Handle "vX" aliases.
10882         (v_alias_pseudo_register_collect): New function.
10883         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10884         (rs6000_gdbarch_init): Initialize "vX" aliases as
10885         pseudo-registers.  Restore registration of
10886         rs6000_pseudo_register_reggroup_p with
10887         set_tdesc_pseudo_register_reggroup_p.
10888
10889 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10890
10891         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10892         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10893         set_gdbarch_num_pseudo_regs.
10894
10895 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10896
10897         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10898         Remove arg prefixname, add do_set and do_show.
10899         Add member functions set_list and show_list.
10900         * cli/cli-style.c (class cli_style_option): Update accordingly.
10901         (style_set_list): Move to file scope.
10902         (style_show_list): Likewise.
10903         (set_style): Call help_list.
10904         (show_style): Call cmd_show_list.
10905         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10906         Update to use the new macro.
10907
10908 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10909
10910         * ada-lang.c (_initialize_ada_language): Expand the help text
10911         for the "catch exception" command.
10912
10913 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10914
10915         * symtab.c (matching_obj_sections): Initialize obj,
10916         declare it closer to its usage.
10917
10918 2019-01-10  Tom Tromey  <tom@tromey.com>
10919
10920         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10921         (basic_inf_threads_range): Remove.
10922         (inf_threads_range, inf_non_exited_threads_range)
10923         (safe_inf_threads_range): Use next_adapter.
10924
10925 2019-01-10  Keith Seitz  <keiths@redhat.com>
10926
10927         PR gdb/23712
10928         PR symtab/23010
10929         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10930         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10931
10932 2019-01-10  Keith Seitz  <keiths@redhat.com>
10933
10934         PR gdb/23712
10935         PR symtab/23010
10936         * dictionary.c (pending_to_vector): Remove.
10937         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10938         Remove _1 suffix, replacing functions of the same name.  Update
10939         all callers.
10940         (dict_create_hashed, dict_create_hashed_expandable)
10941         (dict_create_linear, dict_create_linear_expandable, dict_free)
10942         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10943         Make functions static.
10944
10945 2019-01-10  Keith Seitz  <keiths@redhat.com>
10946
10947         PR gdb/23712
10948         PR symtab/23010
10949         * dictionary.h (struct dictionary): Replace declaration with
10950         multidictionary.
10951         (dict_create_hashed, dict_create_hashed_expandable)
10952         (dict_create_linear, dict_create_linear_expandable)
10953         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10954         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10955         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10956         taking multidictionary argument.
10957         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10958         * block.h (struct block) <dict>: Change to multidictionary
10959         and rename `multidict'.
10960         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10961         symmisc.c: Update all dictionary references to multidictionary.
10962
10963 2019-01-10  Keith Seitz  <keiths@redhat.com>
10964
10965         PR gdb/23712
10966         PR symtab/23010
10967         * dictionary.c: Include unordered_map.
10968         (pending_to_vector): New function.
10969         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10970         Rewrite the non-"_1" functions to take vector instead
10971         of linked list.
10972         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10973         "new" _1 versions of the same name.
10974         (multidictionary): Define.
10975         (std::hash<enum language): New definition.
10976         (collate_pending_symbols_by_language, mdict_create_hashed)
10977         (mdict_create_hashed_expandable, mdict_create_linear)
10978         (mdict_create_linear_expandable, mdict_free)
10979         (find_language_dictionary, create_new_language_dictionary)
10980         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10981         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10982         (mdict_size, mdict_empty): New functions.
10983         * dictionary.h (mdict_iterator): Define.
10984
10985 2019-01-10  Pedro Alves  <palves@redhat.com>
10986
10987         * breakpoint.c (read_uploaded_action)
10988         (create_tracepoint_from_upload): Adjust to use
10989         gdb::unique_xmalloc_ptr.
10990         * ctf.c (ctf_write_uploaded_tp):
10991         (SET_ARRAY_FIELD): Use emplace_back.
10992         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10993         * tracefile-tfile.c (tfile_write_uploaded_tp):
10994         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10995         gdb::unique_xmalloc_ptr.
10996         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10997         at_string, cond_string, cmd_strings>: Replace char pointers
10998         with gdb::unique_xmalloc_ptr.
10999
11000 2019-01-10  Pedro Alves  <palves@redhat.com>
11001
11002         * solib-target.c (library_list_start_library): Don't xstrdup name.
11003
11004 2019-01-10  Pedro Alves  <palves@redhat.com>
11005
11006         * mdebugread.c (parse_partial_symbols): Use
11007         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11008
11009 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11010
11011         * linux-fork.c (scoped_switch_fork_info)
11012         <~scoped_switch_fork_info>: Fix incorrect variable name.
11013
11014 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11015
11016         * linux-fork.c (scoped_switch_fork_info)
11017         <scoped_switch_fork_info>: Make explicit.
11018         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11019
11020 2019-01-10  Tom Tromey  <tom@tromey.com>
11021
11022         * objfiles.h (objfile::reset_psymtabs): Update.
11023         * objfiles.c (objfile::objfile): Update.
11024         * psymtab.h (psymtab_storage::obstack): Update.
11025         (psymtab_storage::m_obstack): Use gdb::optional.
11026         (class psymtab_storage): Update comment.  Remove objfile
11027         parameter.
11028         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11029
11030 2019-01-10  Tom Tromey  <tom@tromey.com>
11031
11032         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11033         <free_psymtabs>: Now private.
11034         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11035         (allocate_psymtab): Use new method.
11036
11037 2019-01-10  Tom Tromey  <tom@tromey.com>
11038
11039         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11040         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11041         * mdebugread.c (parse_partial_symbols): Use
11042         allocate_dependencies.
11043         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11044         allocate_dependencies.
11045         (process_psymtab_comp_unit_reader)
11046         (build_type_psymtab_dependencies): Likewise.
11047         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11048
11049 2019-01-10  Tom Tromey  <tom@tromey.com>
11050
11051         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11052         PSYMBOL_SET_LANGUAGE.
11053         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11054
11055 2019-01-10  Tom Tromey  <tom@tromey.com>
11056
11057         * psymtab.h (psymtab_storage::obstack): New method.
11058         <m_obstack>: Rename from obstack; now private.
11059         * psymtab.c (psymtab_storage): Update.
11060         * dwarf2read.c (create_addrmap_from_index)
11061         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11062         Update.
11063
11064 2019-01-10  Tom Tromey  <tom@tromey.com>
11065
11066         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11067         * objfiles.h (objfile::reset_psymtabs): New method.
11068
11069 2019-01-10  Tom Tromey  <tom@tromey.com>
11070
11071         * symmisc.c (print_symbol_bcache_statistics): Update.
11072         (print_objfile_statistics): Update.
11073         * symfile.c (reread_symbols): Update.
11074         * psymtab.h (class psymtab_storage): New.
11075         * psymtab.c (psymtab_storage): New constructor.
11076         (~psymtab_storage): New destructor.
11077         (require_partial_symbols): Update.
11078         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11079         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11080         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11081         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11082         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11083         (start_psymtab_common, end_psymtab_common)
11084         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11085         (allocate_psymtab): Update.
11086         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11087         Update.
11088         (dump_psymtab_addrmap, maintenance_print_psymbols)
11089         (maintenance_check_psymtabs): Update.
11090         (class objfile_psymtabs): Move to objfiles.h.
11091         * psympriv.h (discard_psymtab): Now inline.
11092         (psymtab_discarder::psymtab_discarder): Update.
11093         (psymtab_discarder::~psymtab_discarder): Update.
11094         (ALL_OBJFILE_PSYMTABS): Rewrite.
11095         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11096         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11097         Remove fields.
11098         <partial_symtabs>: New field.
11099         (class objfile_psymtabs): Move from psymtab.h.  Update.
11100         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11101         psymbol_cache.
11102         (objfile::~objfile): Don't destroy psymbol_cache.
11103         * mdebugread.c (parse_partial_symbols): Update.
11104         * dwarf2read.c (create_addrmap_from_index)
11105         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11106         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11107         (add_partial_subprogram, dwarf2_ranges_read): Update.
11108         * dwarf-index-write.c (write_address_map)
11109         (write_one_signatured_type, recursively_write_psymbols)
11110         (class debug_names, class debug_names, write_psymtabs_to_index):
11111         Update.
11112
11113 2019-01-10  Tom Tromey  <tom@tromey.com>
11114
11115         * symtab.h (SYMBOL_SET_NAMES): Update.
11116         (symbol_set_names): Update.
11117         (MSYMBOL_SET_NAMES): Update.
11118         * symtab.c (symbol_set_names): Change argument to be an
11119         objfile_per_bfd_storage.
11120         * psymtab.c (add_psymbol_to_bcache): Update.
11121         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11122
11123 2019-01-10  Tom Tromey  <tom@tromey.com>
11124
11125         * symtab.c (create_demangled_names_hash): Change argument to be an
11126         objfile_per_bfd_storage.
11127         (symbol_set_names): Update.
11128
11129 2019-01-10  Tom Tromey  <tom@tromey.com>
11130
11131         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11132         init_psymbol_list.
11133         * psymtab.c (init_psymbol_list): Do nothing if already called.
11134         * psympriv.h (init_psymbol_list): Add comment.
11135         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11136         init_psymbol_list.
11137         * dbxread.c (dbx_symfile_read): Unconditionally call
11138         init_psymbol_list.
11139
11140 2019-01-10  Tom Tromey  <tom@tromey.com>
11141
11142         * xcoffread.c (scan_xcoff_symtab): Update.
11143         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11144         "where".
11145         * mdebugread.c (parse_partial_symbols)
11146         (handle_psymbol_enumerators): Update.
11147         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11148         * dbxread.c (read_dbx_symtab): Update.
11149         * psympriv.h (psymbol_placement): New enum.
11150         (add_psymbol_to_list): Update.
11151
11152 2019-01-10  Tom Tromey  <tom@tromey.com>
11153
11154         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11155         static_psymbols parameters.
11156         (scan_xcoff_symtab): Update.
11157         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11158         static_psymbols parameters.
11159         * psympriv.h (start_psymtab_common): Update.
11160         * mdebugread.c (parse_partial_symbols): Update.
11161         * dwarf2read.c (create_partial_symtab): Update.
11162         * dbxread.c (read_dbx_symtab): Update.
11163         (start_psymtab): Remove global_psymbols and static_psymbols
11164         parameters.
11165
11166 2019-01-10  Tom Tromey  <tom@tromey.com>
11167
11168         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11169         * psymtab.c (allocate_psymtab): Add comment.
11170         * psympriv.h (allocate_psymtab): Add comment.
11171         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11172         initializations.
11173         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11174
11175 2019-01-10  Tom Tromey  <tom@tromey.com>
11176
11177         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11178         Don't declare.
11179         * mipsread.c: Include mdebugread.h.
11180         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11181         Declare.
11182         * elfread.c: Include mdebugread.h.
11183
11184 2019-01-09  Tom Tromey  <tom@tromey.com>
11185
11186         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11187         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11188         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11189         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11190         (psym_lookup_symbol, psym_find_last_source_symtab)
11191         (psym_forget_cached_source_info, psym_print_stats)
11192         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11193         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11194         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11195         (psym_find_compunit_symtab_by_address)
11196         (maintenance_print_psymbols, maintenance_info_psymtabs)
11197         (maintenance_check_psymtabs): Use ranged for.
11198         * psymtab.h (class objfile_psymtabs): New.
11199         (require_partial_symbols): Return objfile_psymtabs.
11200         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11201
11202 2019-01-09  Tom Tromey  <tom@tromey.com>
11203
11204         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11205         (find_pc_mapped_section, list_overlays_command)
11206         (map_overlay_command, unmap_overlay_command)
11207         (simple_overlay_update): Use all_objfiles.
11208         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11209         * printcmd.c (info_symbol_command): Use all_objfiles.
11210         * objfiles.h (ALL_OBJSECTIONS): Remove.
11211         * maint.c (maintenance_translate_address): Use all_objfiles.
11212         * gcore.c (gcore_create_callback): Use all_objfiles.
11213         (objfile_find_memory_regions): Likewise.
11214
11215 2019-01-09  Tom Tromey  <tom@tromey.com>
11216
11217         * symtab.c (find_line_symtab, info_sources_command)
11218         (make_source_files_completion_list): Use objfile_compunits.
11219         * source.c (select_source_symtab): Use objfile_compunits.
11220         * objfiles.h (struct objfile): Update comment.
11221         (ALL_OBJFILES): Remove.
11222         (ALL_FILETABS): Remove.
11223         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11224         objfile_compunits.
11225
11226 2019-01-09  Tom Tromey  <tom@tromey.com>
11227
11228         * symmisc.c (print_objfile_statistics, dump_objfile)
11229         (maintenance_print_symbols): Use compunit_filetabs.
11230         * source.c (forget_cached_source_info_for_objfile): Use
11231         compunit_filetabs.
11232         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11233         (ALL_FILETABS): Use compunit_filetabs.
11234         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11235         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11236
11237 2019-01-09  Tom Tromey  <tom@tromey.com>
11238
11239         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11240         (compunit_filetabs): New.
11241         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11242         compunit_filetabs.
11243         (info_sources_command, make_source_files_completion_list): Remove
11244         declaration.
11245         * symmisc.c (print_objfile_statistics, dump_objfile)
11246         (maintenance_print_symbols): Remove declaration.
11247         (maintenance_info_symtabs): Use compunit_filetabs.
11248         (maintenance_info_line_tables): Likewise.
11249         * source.c (select_source_symtab): Change local variable name.
11250         (forget_cached_source_info_for_objfile): Remove declaration.
11251         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11252         * objfiles.c (objfile_relocate1): Remove declaration.
11253         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11254         declaration.
11255         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11256         * coffread.c (coff_symtab_read): Remove declaration.
11257         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11258         compunit_filetabs.
11259
11260 2019-01-09  Tom Tromey  <tom@tromey.com>
11261
11262         * symtab.c (lookup_objfile_from_block)
11263         (find_pc_sect_compunit_symtab, search_symbols)
11264         (default_collect_symbol_completion_matches_break_on): Use
11265         objfile_compunits.
11266         * objfiles.h (ALL_COMPUNITS): Remove.
11267         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11268         * cp-support.c (add_symbol_overload_list_qualified): Use
11269         objfile_compunits.
11270         * ada-lang.c (ada_collect_symbol_completion_matches)
11271         (ada_add_global_exceptions): Use objfile_compunits.
11272
11273 2019-01-09  Tom Tromey  <tom@tromey.com>
11274
11275         * source.c (select_source_symtab)
11276         (forget_cached_source_info_for_objfile): Remove declaration.
11277         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11278         declaration.
11279         * maint.c (count_symtabs_and_blocks): Remove declaration.
11280         * cp-support.c (add_symbol_overload_list_qualified): Remove
11281         declaration.
11282         * coffread.c (coff_symtab_read): Remove declaration.
11283         * symtab.c (lookup_symbol_in_objfile_symtabs)
11284         (basic_lookup_transparent_type_1): Use objfile_compunits.
11285         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11286         (info_sources_command, search_symbols)
11287         (default_collect_symbol_completion_matches_break_on)
11288         (make_source_files_completion_list): Remove declaration.
11289         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11290         (ada_collect_symbol_completion_matches)
11291         (ada_add_global_exceptions): Remove declaration.
11292         * linespec.c (iterate_over_all_matching_symtabs): Use
11293         objfile_compunits.
11294         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11295         (class objfile_compunits): New.
11296         (ALL_COMPUNITS): Use objfile_compunits.
11297         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11298         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11299         objfile_compunits.
11300         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11301
11302 2019-01-09  Tom Tromey  <tom@tromey.com>
11303
11304         * symtab.c (search_symbols)
11305         (default_collect_symbol_completion_matches_break_on): Use
11306         objfile_msymbols.
11307         * ada-lang.c (ada_lookup_simple_minsym)
11308         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11309         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11310         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11311         objfile_msymbols.
11312         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11313         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11314         * objc-lang.c (find_methods): Use objfile_msymbols.
11315         (info_selectors_command, info_classes_command): Likewise.
11316         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11317         * objfiles.h (class objfile_msymbols): New.
11318         (ALL_OBJFILE_MSYMBOLS): Remove.
11319         (ALL_MSYMBOLS): Remove.
11320
11321 2019-01-09  Tom Tromey  <tom@tromey.com>
11322
11323         * common/next-iterator.h (next_adapter): Add Iterator template
11324         parameter.
11325         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11326         (class all_objfiles_safe): New.
11327         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11328         * objfiles.c (put_objfile_before): Update comment.
11329         (add_separate_debug_objfile): Likewise.
11330         (free_all_objfiles): Use all_objfiles_safe.
11331         (objfile_purge_solibs): Likewise.
11332
11333 2019-01-09  Tom Tromey  <tom@tromey.com>
11334
11335         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11336         (expand_symtab_containing_pc, lookup_static_symbol)
11337         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11338         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11339         all_objfiles.
11340         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11341         * breakpoint.c (create_overlay_event_breakpoint)
11342         (create_longjmp_master_breakpoint)
11343         (create_std_terminate_master_breakpoint)
11344         (create_exception_master_breakpoint): Use all_objfiles.
11345         * linux-thread-db.c (try_thread_db_load_from_pdir)
11346         (has_libpthread): Use all_objfiles.
11347         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11348         * linespec.c (iterate_over_all_matching_symtabs)
11349         (search_minsyms_for_name): Use all_objfiles.
11350         * maint.c (maintenance_info_sections): Use all_objfiles.
11351         * main.c (captured_main_1): Use all_objfiles.
11352         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11353         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11354         * guile/scm-pretty-print.c
11355         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11356         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11357         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11358         (maintenance_print_msymbols): Use all_objfiles.
11359         * source.c (select_source_symtab): Use all_objfiles.
11360         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11361         * symfile.c (remove_symbol_file_command)
11362         (expand_symtabs_matching, map_symbol_filenames): Use
11363         all_objfiles.
11364         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11365         all_objfiles.
11366         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11367         * objc-lang.c (find_methods): Use all_objfiles.
11368         * objfiles.c (have_partial_symbols, have_full_symbols)
11369         (have_minimal_symbols, qsort_cmp)
11370         (default_iterate_over_objfiles_in_search_order): Use
11371         all_objfiles.
11372         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11373         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11374         (maintenance_check_psymtabs): Use all_objfiles.
11375         (ALL_PSYMTABS): Remove.
11376         * compile/compile-object-run.c (do_module_cleanup): Use
11377         all_objfiles.
11378         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11379         * cp-support.c (add_symbol_overload_list_qualified): Use
11380         all_objfiles.
11381         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11382         Use all_objfiles.
11383         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11384         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11385         all_objfiles.
11386         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11387         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11388         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11389         Uses all_objfiles.
11390         * solib.c (solib_read_symbols): Use all_objfiles
11391
11392 2019-01-09  Tom Tromey  <tom@tromey.com>
11393
11394         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11395         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11396         all_objfiles.
11397         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11398         * symmisc.c (print_symbol_bcache_statistics)
11399         (print_objfile_statistics, maintenance_print_objfiles)
11400         (maintenance_info_symtabs, maintenance_check_symtabs)
11401         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11402         all_objfiles.
11403         * source.c (forget_cached_source_info): Use all_objfiles.
11404         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11405         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11406         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11407         * objfiles.c (update_section_map): Use all_objfiles.
11408         (shared_objfile_contains_address_p): Likewise.
11409         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11410         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11411
11412 2019-01-09  Tom Tromey  <tom@tromey.com>
11413
11414         * common/next-iterator.h: New file.
11415         * objfiles.h (class all_objfiles): New.
11416         (struct objfile_iterator): New.
11417
11418 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11419
11420         * NEWS: Move the description of the changed "frame", "select-frame",
11421          and "info frame" commands to the Changed commands section.
11422
11423 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11424
11425         * gdbtypes.c (check_stub_method_group): Remove handling of old
11426         mangling schemes.
11427         * linespec.c (find_methods): Likewise.
11428         * stabsread.c (read_member_functions): Likewise.
11429         * valops.c (search_struct_method): Likewise.
11430         (value_struct_elt_for_reference): Likewise.
11431         * NEWS: Mention this change.
11432
11433 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11434
11435         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11436         print_source_lines.
11437         * source.c (print_source_lines_base): Update line number check.
11438         (print_source_lines): New function.
11439         (source_lines_range::source_lines_range): New function.
11440         * source.h (class source_lines_range): New class.
11441         (print_source_lines): New declaration.
11442
11443 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11444
11445         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11446
11447 2019-01-08  Tom Tromey  <tom@tromey.com>
11448             Simon Marchi  <simon.marchi@ericsson.com>
11449
11450         PR gdb/24060
11451         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11452         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11453         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11454         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11455         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11456         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11457
11458 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11459
11460         * source.c (select_source_symtab): Move header comment to
11461         declaration in source.h.
11462         (forget_cached_source_info_for_objfile): Likewise.
11463         (forget_cached_source_info): Likewise.
11464         (identify_source_line): Likewise.
11465         * source.h (identify_source_line): Move declaration from symtab.h
11466         and add comment from source.c
11467         (print_source_lines): Likewise.
11468         (forget_cached_source_info_for_objfile): Likewise.
11469         (forget_cached_source_info): Likewise.
11470         (select_source_symtab): Likewise.
11471         (enum print_source_lines_flag): Move definition from symtab.h.
11472         * symtab.h (identify_source_line): Move declaration to source.h.
11473         (print_source_lines): Likewise.
11474         (forget_cached_source_info_for_objfile): Likewise.
11475         (forget_cached_source_info): Likewise.
11476         (select_source_symtab): Likewise.
11477         (enum print_source_lines_flag): Move definition to source.h.
11478         * tui/tui-hooks.c: Add 'source.h' include.
11479
11480 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11481
11482         * source.c (print_source_lines_base): Handle requests to print
11483         reverse line number sequences, and guard against empty lines
11484         string.
11485
11486 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11487
11488         * source.c (print_source_lines_base): Fix skip of '\r' if next
11489         character is '\n'.
11490
11491 2019-01-06  Tom Tromey  <tom@tromey.com>
11492
11493         * c-exp.y (struct c_parse_state) <macro_original_text,
11494         expansion_obstack>: New member.
11495         (macro_original_text, expansion_obstack): Remove globals.
11496         (scan_macro_expansion, scanning_macro_expansion)
11497         (finished_macro_expansion): Update.
11498         (scan_macro_cleanup): Remove.
11499         (yylex, c_parse): Update.
11500
11501 2019-01-06  Tom Tromey  <tom@tromey.com>
11502
11503         * c-exp.y (struct c_parse_state) <strings>: New member.
11504         (operator_stoken): Update.
11505
11506 2019-01-06  Tom Tromey  <tom@tromey.com>
11507
11508         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11509         (union type_stack_elt) <typelist_val>: Now a pointer to
11510         std::vector.
11511         (type_stack_cleanup): Don't declare.
11512         (push_typelist): Update.
11513         * parse.c (pop_typelist): Return a std::vector.
11514         (push_typelist): Take a std::vector.
11515         (follow_types): Update.  Do not free args.
11516         (type_stack_cleanup): Remove.
11517         * c-exp.y (struct c_parse_state): New.
11518         (cpstate): New global.
11519         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11520         (nonempty_typelist): Update.
11521         (func_mod): Create a new vector.
11522         (c_parse): Create a c_parse_state.
11523         (check_parameter_typelist): Do not delete params.
11524         (function_method): Update.  Do not delete type_list.
11525
11526 2019-01-06  Tom Tromey  <tom@tromey.com>
11527
11528         PR gdb/28155:
11529         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11530         check_typedef.
11531         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11532         (print_return_value): Likewise.
11533
11534 2019-01-05  Tom Tromey  <tom@tromey.com>
11535
11536         * contrib/cleanup_check.py: Remove.
11537         * contrib/gcc-with-excheck: Remove.
11538         * contrib/exsummary.py: Remove.
11539         * contrib/excheck.py: Remove.
11540
11541 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11542
11543         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11544         NULL. Initialize tpprev to NULL instead of assigning it
11545         to NULL on the next statement.
11546         * windows-nat.c (windows_delete_thread): Remove check for
11547         main_thread_id before printing thread exit notifications.
11548         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11549         Remove thread ID check against main_thread_id.
11550         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11551         windows_delete_thread.
11552         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11553
11554 2019-01-04  Tom Tromey  <tom@tromey.com>
11555
11556         * compile/compile.c (_initialize_compile): Use upper case for
11557         metasyntactic variables.
11558         * symmisc.c (_initialize_symmisc): Use upper case for
11559         metasyntactic variables.
11560         * psymtab.c (_initialize_psymtab): Use upper case for
11561         metasyntactic variables.
11562         * demangle.c (demangle_command): Use upper case for metasyntactic
11563         variables.
11564         (_initialize_demangler): Likewise.
11565         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11566         variables.
11567
11568 2019-01-03  Tom Tromey  <tom@tromey.com>
11569
11570         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11571
11572 2019-01-03  Tom Tromey  <tom@tromey.com>
11573
11574         * python/py-symtab.c (salpy_str): Update.
11575         (struct salpy_sal_object) <symtab>: Now a PyObject.
11576         (salpy_dealloc): Update.
11577         (del_objfile_sal): Use gdbpy_ref.
11578
11579 2019-01-03  Tom Tromey  <tom@tromey.com>
11580
11581         * python/py-type.c (convert_field): Use new_reference.  Return
11582         gdbpy_ref.
11583         (make_fielditem): Return gdbpy_ref.
11584         (typy_fields): Update.
11585         (typy_getitem): Update.
11586         (field_name): Return gdbpy_ref.  Use new_reference.
11587         (typy_iterator_iternext): Update.
11588
11589 2019-01-03  Tom Tromey  <tom@tromey.com>
11590
11591         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11592
11593 2019-01-03  Tom Tromey  <tom@tromey.com>
11594
11595         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11596         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11597         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11598         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11599         (pspy_set_type_printers): Likewise.
11600         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11601         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11602         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11603         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11604         (objfpy_set_type_printers): Likewise.
11605
11606 2019-01-03  Tom Tromey  <tom@tromey.com>
11607
11608         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11609         (gdbpy_print_stack): Use gdbpy_err_fetch.
11610         * python/python-internal.h (class gdbpy_err_fetch): New class.
11611         (class gdbpy_enter) <m_error_type, m_error_value,
11612         m_error_traceback>: Remove.
11613         <m_error>: New member.
11614         (gdbpy_exception_to_string): Don't declare.
11615         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11616         * python/py-value.c (convert_value_from_python): Use
11617         gdbpy_err_fetch.
11618         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11619         gdbpy_exception_to_string.
11620         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11621         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11622         gdbpy_err_fetch.
11623
11624 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11625
11626         * linux-nat.c (delete_lwp_cleanup): Delete.
11627         (struct lwp_deleter): New struct.
11628         (lwp_info_up): New typedef.
11629         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11630         lwp_info_up.
11631
11632 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11633
11634         * linux-fork.c (class scoped_switch_fork_info): New class.
11635         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11636
11637 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11638
11639         * valops.c (find_overload_match): Remove use of null_cleanup, and
11640         calls to do_cleanups.
11641
11642 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11643
11644         * compile/compile-cplus-types.c
11645         (compile_cplus_instance::decl_name): Handle changes to
11646         cp_func_name.
11647         * cp-support.c (cp_func_name): Update header comment, update
11648         return type.
11649         * cp-support.h (cp_func_name): Update return type in declaration.
11650         * valops.c (find_overload_match): Move temp_func local to top
11651         level of function and change its type.  Use temp_func to hold and
11652         delete temporary string obtained from cp_func_name.
11653
11654 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11655
11656         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11657         gdb::char_vector, remove cleanup, and update uses of `msg`.
11658
11659 2019-01-03  Jim Wilson  <jimw@sifive.com>
11660
11661         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11662
11663 2019-01-02  Tom Tromey  <tom@tromey.com>
11664
11665         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11666         (tdesc_parse_xml): Remove cleanups.
11667         * target-descriptions.h (make_cleanup_free_target_description):
11668         Don't declare.
11669         (target_desc_deleter): New struct.
11670         (target_desc_up): New typedef.
11671         * target-descriptions.c (target_desc_deleter::operator()): Rename
11672         from free_target_description.
11673         (make_cleanup_free_target_description): Remove.
11674
11675 2019-01-02  Tom Tromey  <tom@tromey.com>
11676
11677         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11678         constructor, destructor.
11679         (linespec_parser): Remove typedef.
11680         (~linespec_parser): Rename from linespec_parser_delete.
11681         (linespec_lex_to_end, linespec_complete_label)
11682         (linespec_complete): Update.
11683         (decode_line_full): Remove cleanups.
11684         (decode_line_1): Update.
11685
11686 2019-01-02  Tom Tromey  <tom@tromey.com>
11687
11688         * python/python-internal.h (inferior_to_inferior_object): Change
11689         return type.
11690         * python/py-exitedevent.c (create_exited_event_object): Update.
11691         * python/py-inferior.c (inferior_to_inferior_object): Return
11692         gdbpy_ref.
11693         (python_new_inferior, python_inferior_deleted)
11694         (thread_to_thread_object, delete_thread_object)
11695         (build_inferior_list, gdbpy_selected_inferior): Update.
11696         * python/py-infthread.c (create_thread_object): Update.  Also fail
11697         if inferior_to_inferior_object fails.
11698
11699 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11700
11701         * inferior.h (class inferior) <displaced_step_state>: New field.
11702         * infrun.h (struct displaced_step_state): Move here from
11703         infrun.c.  Initialize fields, add constructor.
11704         <inf>: Remove field.
11705         <reset>: New method.
11706         * infrun.c (struct displaced_step_inferior_state): Move to
11707         infrun.h.
11708         (displaced_step_inferior_states): Remove.
11709         (get_displaced_stepping_state): Adust.
11710         (displaced_step_in_progress_any_inferior): Adjust.
11711         (displaced_step_in_progress_thread): Adjust.
11712         (displaced_step_in_progress): Adjust.
11713         (add_displaced_stepping_state): Remove.
11714         (get_displaced_step_closure_by_addr): Adjust.
11715         (remove_displaced_stepping_state): Remove.
11716         (infrun_inferior_exit): Call displaced_step_state.reset.
11717         (use_displaced_stepping): Don't check for NULL.
11718         (displaced_step_prepare_throw): Call
11719         get_displaced_stepping_state.
11720         (displaced_step_fixup): Don't check for NULL.
11721         (prepare_for_detach): Don't check for NULL.
11722
11723 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11724
11725         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11726          in case of call that did not complete.
11727
11728 2019-01-02  Andrey Utkin  <autkin@undo.io>
11729
11730         * symfile.c (find_separate_debug_file): Fix search of debug files for
11731         remote debuggee.
11732
11733 2019-01-02  Tom Tromey  <tom@tromey.com>
11734
11735         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11736         indentation.
11737         * python/py-frame.c (frapy_older): Remove cast.
11738         (frapy_newer): Likewise.
11739         * python/py-breakpoint.c (local_setattro): Remove cast.
11740         * python/py-arch.c (archpy_name): Remove local variable.
11741         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11742
11743 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11744
11745         * unittests/basic_string_view/element_access/char/empty.cc:
11746         Fix year range in copyright header.
11747
11748 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11749
11750         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11751         Delete.
11752         <operator==>: Update with for removed field.
11753         <hash>: Likewise.
11754         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11755         <isa_features>: ...this.
11756         <abi_features>: New field.
11757         (riscv_isa_flen): Update comment.
11758         (riscv_abi_xlen): New declaration.
11759         (riscv_abi_flen): New declaration.
11760         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11761         isa_features.
11762         (riscv_abi_xlen): New function.
11763         (riscv_isa_flen): Update to get answer from isa_features.
11764         (riscv_abi_flen): New function.
11765         (riscv_has_fp_abi): Update to get answer from abi_features.
11766         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11767         xlen and flen.
11768         (riscv_call_info) <xlen, flen>: Update comment.
11769         (riscv_call_arg_struct): Remove invalid assertions
11770         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11771         is removed.
11772         (riscv_gdbarch_init): Gather isa features and abi features
11773         separately, ensure both match on the gdbarch when reusing an old
11774         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11775         a target with 64-bit float hardware.
11776
11777 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11778
11779         * source.c (search_command_helper): Stop reverse search
11780         when line 1 has been searched.
11781
11782 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11783
11784         * record-full.c (record_full_base_target::close): Rewrite
11785         record_full_core_buf_list free logic.
11786
11787 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11788
11789         * break-catch-syscall.c (print_one_catch_syscall): xfree
11790         the last text.
11791
11792 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11793
11794         * top.c (print_gdb_version): Update Copyright year in version
11795         message.
11796
11797 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11798
11799         Update copyright year range in all GDB files.
11800
11801 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11802
11803         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11804
11805 For older changes see ChangeLog-2018.
11806 \f
11807 Local Variables:
11808 mode: change-log
11809 left-margin: 8
11810 fill-column: 74
11811 version-control: never
11812 coding: utf-8
11813 End:
11814