gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
   4         (tui_locator_window::rerender): Rewrite using body of previous
   5         tui_show_locator_content.
   6
   7 2019-08-30  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  10         set_locator_fullname>: New methods.
  11         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  12         Rename from tui_set_locator_fullname.
  13         (tui_locator_window::set_locator_info): Rename from
  14         tui_set_locator_info.  Return bool.
  15         (tui_update_locator_fullname, tui_show_frame_info): Update.
  16
  17 2019-08-30  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  20
  21 2019-08-30  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  24         call touchwin.
  25
  26 2019-08-30  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-wingeneral.c (box_win): Assume win_info and
  29         win_info->handle cannot be NULL.
  30
  31 2019-08-30  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  34         refresh_window>: Declare.
  35         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  36         resize.
  37         (tui_data_item_window::rerender): Rename from
  38         tui_display_register.
  39         (tui_data_item_window::refresh_window): New method.
  40         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  41         no-op.
  42
  43 2019-08-30  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  46         regs_column_count, current_group>: Move later.  Now private.
  47         <get_current_group>: New method.
  48         * tui/tui-regs.c (tui_reg_command): Update.
  49         * tui/tui-layout.c (tui_set_layout): Update.
  50
  51 2019-08-30  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  54         (tui_data_window::rerender): Don't call
  55         check_and_display_highlight_if_needed.
  56         (tui_data_window::refresh_all): Remove call to
  57         erase_data_content.
  58
  59 2019-08-30  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  62         (tui_data_window::display_registers_from)
  63         (tui_data_window::display_reg_element_at_line)
  64         (tui_data_window::display_registers_from_line): Remove checks of
  65         "empty".
  66
  67 2019-08-30  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  70         Don't declare.
  71         * tui/tui-regs.c (tui_data_window::show_registers): Call
  72         rerender.
  73         (tui_data_window::rerender): Rename from display_all_data.
  74         (tui_data_window::rerender): Remove old implementation.
  75
  76 2019-08-30  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  79         text.
  80         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  81
  82 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  83             Sergio Durigan Junior  <sergiodj@redhat.com>
  84
  85         PR win32/24284
  86         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  87
  88 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  91         when searching for types.
  92
  93 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  94
  95         * f-lang.c (f_language_defn): Use f_print_typedef.
  96         * f-lang.h (f_print_typedef): Declare.
  97         * f-typeprint.c (f_print_typedef): Define.
  98
  99 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 100
 101         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 102
 103 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 104
 105         * cli/cli-utils.c (info_print_options_defs): Delete.
 106         (make_info_print_options_def_group): Delete.
 107         (extract_info_print_options): Delete.
 108         (info_print_command_completer): Delete.
 109         (info_print_args_help): Add extra parameter, and optionally
 110         include text about -n flag.
 111         * cli/cli-utils.h (struct info_print_options): Delete.
 112         (extract_info_print_options): Delete declaration.
 113         (info_print_command_completer): Delete declaration.
 114         (info_print_args_help): Add extra parameter, extend header
 115         comment.
 116         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 117         search_symbols.
 118         * stack.c (struct info_print_options): New type.
 119         (info_print_options_defs): New file scoped variable.
 120         (make_info_print_options_def_group): New static function.
 121         (info_print_command_completer): New static function.
 122         (info_locals_command): Update to use new local functions.
 123         (info_args_command): Likewise.
 124         (_initialize_stack): Add extra parameter to calls to
 125         info_print_args_help.
 126         * symtab.c (search_symbols): Add extra parameter, use this to
 127         possibly excluse non-debug symbols.
 128         (symtab_symbol_info): Add extra parameter, which is passed on to
 129         search_symbols.
 130         (struct info_print_options): New type.
 131         (info_print_options_defs): New file scoped variable.
 132         (make_info_print_options_def_group): New static function.
 133         (info_print_command_completer): New static function.
 134         (info_variables_command): Update to use local functions, and pass
 135         extra parameter through to symtab_symbol_info.
 136         (info_functions_command): Likewise.
 137         (info_types_command): Pass additional argument through to
 138         symtab_symbol_info.
 139         (rbreak_command): Pass extra argument to search_symbols.
 140         (_initialize_symtab): Add extra arguments for calls to
 141         info_print_args_help, and update help text for 'info variables',
 142         'whereis', and 'info functions' commands.
 143         * symtab.h (search_symbols): Add extra argument to declaration.
 144         * NEWS: Mention new flags.
 145
 146 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 147
 148         * symtab.c (lookup_static_symbol): Call the new function (and move
 149         it down to be next to lookup_global_symbol).
 150         (struct global_sym_lookup_data): Add block_enum member and rename to...
 151         (struct global_or_static_sym_lookup_data): ...this.
 152         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 153         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 154         (lookup_symbol_global_or_static_iterator_cb): ...this.
 155         (lookup_global_or_static_symbol): New function.
 156         (lookup_global_symbol): Call new function.
 157
 158 2019-08-26  Tom de Vries  <tdevries@suse.de>
 159
 160         PR c++/24852
 161         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 162         when pc_probe.prob == NULL.
 163
 164 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 165
 166         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 167         variable symbol_linkage to symbol_linkage_.
 168
 169 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 170
 171         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 172         represent whether the symbol is static, dynamic, or we don't
 173         know.
 174
 175 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 176
 177         * gdb/rx-tdep.c (rx_register_names): New.
 178         (rx_register_name): Delete.
 179         (rx_psw_type): Delete.
 180         (rx_fpsw_type): Delete.
 181         (rx_register_type): Delete.
 182         (rx_gdbarch_init): Convert target-descriptions.
 183         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 184         * gdb/features/Makefile: Add rx.xml.
 185         * gdb/features/rx.xml: New.
 186         * gdb/features/rx.c: Generated.
 187         * gdb/NEWS: Mention target description support.
 188
 189 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 190
 191         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 192         *slot_ptr.
 193
 194 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 195
 196         * configure.ac: Don't check for 'dlfcn.h' (moved to
 197         gdbsupport/common.m4).
 198         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 199         'gdbsupport/'.
 200         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 201         * compile/compile-c-support.c: Include
 202         'gdbsupport/gdb-dlfcn.h'.
 203         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 204         * gdb-dlfcn.c: Move to...
 205         * gdbsupport/gdb-dlfcn.c: ... here.
 206         * gdb-dlfcn.h: Move to...
 207         * gdbsupport/gdb-dlfcn.h: ... here.
 208
 209 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 210
 211         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 212         the offset field signed.
 213
 214 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 215
 216         * python/lib/gdb/__init__.py (_execute_file): New function.
 217         * python/python.c (python_run_simple_file): Call gdb._execute_file
 218         on Windows.
 219
 220 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 221
 222         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 223         all uses as this was never set to anything but a zero value.
 224
 225 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 226
 227         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 228
 229 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 230
 231         * tui/tui-data.h (tui_gen_win_info): Add an =default
 232         move constructor, required by some GCC versions.
 233
 234 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 235
 236         * go32-nat.c (go32_sysinfo): Add hygon_p.
 237
 238 2019-08-20  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 241         line_from_reg_element_no, first_reg_element_no_inline,
 242         display_all_data, delete_data_content_windows,
 243         erase_data_content>: Now private.
 244
 245 2019-08-20  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 248         (tui_unhighlight_win, tui_highlight_win)
 249         (tui_win_info::make_window): Update.
 250         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 251
 252 2019-08-20  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 255         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 256         (MAX_PID_WIDTH): Move to tui-stack.c.
 257         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 258         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 259         (MAX_PID_WIDTH): Move from tui-data.h.
 260
 261 2019-08-20  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 264         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 265         (box_win): Update.
 266         (tui_gen_win_info::make_window): Rename from tui_make_window.
 267         (tui_win_info::make_window): New method.
 268         (tui_gen_win_info::make_visible): Update.
 269         * tui/tui-source.c (tui_source_window::set_contents): Update.
 270         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 271         (tui_data_window::display_registers_from): Update.
 272         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 273         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 274         Declare.
 275         <can_box>: Remove.
 276         <title>: Remove.
 277         (struct tui_win_info) <make_window>: Declare.
 278         <can_box>: Now virtual.
 279         <title>: New member.
 280         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 281         * tui/tui-command.c (tui_cmd_window::resize): Update.
 282
 283 2019-08-20  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 286         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 287         (tui_data_window::check_register_values): Update.
 288
 289 2019-08-20  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-regs.h (struct tui_data_window): Use
 292         DISABLE_COPY_AND_ASSIGN.
 293         <regs_content>: Change type, removing unique_ptr.
 294         <tui_data_window>: Add move constructor.
 295         * tui/tui-regs.c (tui_data_window::show_registers)
 296         (tui_data_window::show_register_group)
 297         (tui_data_window::display_registers_from)
 298         (tui_data_window::display_registers_from)
 299         (tui_data_window::first_data_item_displayed)
 300         (tui_data_window::delete_data_content_windows)
 301         (tui_data_window::rerender, tui_data_window::refresh_window)
 302         (tui_data_window::check_register_values): Update.
 303
 304 2019-08-20  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 307         show_register_group>: Declare.
 308         (tui_show_register_group): Don't declare.
 309         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 310         tui_show_registers.
 311         (tui_data_window::show_register_group): Rename from
 312         tui_show_register_group.
 313         (tui_data_window::check_register_values, tui_reg_command):
 314         Update.
 315         * tui/tui-layout.c (tui_set_layout): Update.
 316
 317 2019-08-20  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 320         Declare.
 321         (tui_check_register_values): Don't declare.
 322         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 323         from tui_check_register_values.
 324         * tui/tui-hooks.c (tui_register_changed): Update.
 325
 326 2019-08-20  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-regs.c (tui_reg_layout): Move later.
 329         (tui_show_registers): Don't enable TUI mode or change layout.
 330
 331 2019-08-20  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-regs.h (struct tui_data_item_window)
 334         <~tui_data_item_window>: Remove.
 335         <content>: Now a unique_xmalloc_ptr.
 336         * tui/tui-regs.c (tui_register_format): Return a
 337         unique_xmalloc_ptr.
 338         (tui_get_register): Update.
 339         (~tui_data_item_window): Remove.
 340         (tui_data_window::display_registers_from, tui_display_register):
 341         Update.
 342         * tui/tui-io.h (tui_expand_tabs): Update.
 343         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 344         Remove "col" parameter.
 345
 346 2019-08-20  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 349         field.
 350         * tui/tui-regs.c (~tui_data_item_window): Update.
 351
 352 2019-08-20  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 355         earlier.
 356
 357 2019-08-20  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 360
 361 2019-08-20  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-source.h (struct tui_source_window): Update.
 364         * tui/tui-regs.c (tui_show_registers): Update.
 365         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 366         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 367         (NO_REGS_STRING): Remove defines.
 368
 369 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 370
 371         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 372         unnecessary thread walk if remote doesn't support the packet.
 373
 374 2019-08-19  Tom Tromey  <tromey@adacore.com>
 375
 376         * python/py-value.c (value_has_field): Fix indentation.
 377
 378 2019-08-19  Tom Tromey  <tromey@adacore.com>
 379
 380         * printcmd.c (do_one_display, info_display_command): Update.
 381         * block.h (contained_in): Return bool.  Add allow_nested
 382         parameter.
 383         * block.c (contained_in): Return bool.  Add allow_nested
 384         parameter.
 385
 386 2019-08-19  Tom Tromey  <tom@tromey.com>
 387
 388         * configure: Rebuild.
 389         * configure.ac: Disallow the combination of -static-libstdc++ and
 390         source highlight.
 391         * source-cache.c (get_language_name): Handle rust.
 392         (source_cache::get_source_lines): Ignore highlighting exceptions.
 393
 394 2019-08-16  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 397         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 398         (struct tui_source_window_base) <make_visible, refresh_window,
 399         resize>: Remove methods.
 400         <execution_info>: Remove field.
 401         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 402         (tui_show_source_line, tui_source_window_base)
 403         (~tui_source_window_base): Update.
 404         (tui_source_window_base::resize)
 405         (tui_source_window_base::make_visible)
 406         (tui_source_window_base::refresh_window): Remove.
 407         (tui_source_window_base::update_exec_info): Update.
 408         * tui/tui-source.c (tui_source_window::set_contents): Update.
 409         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 410
 411 2019-08-16  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 414         deprecated_query_hook.
 415
 416 2019-08-16  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 419         (tui_update_source_windows_with_line): Update.
 420         * tui/tui-source.h (struct tui_source_window)
 421         <show_symtab_source>: Declare.
 422         (tui_show_symtab_source): Don't declare.
 423         * tui/tui-source.c (tui_show_symtab_source): Rename from
 424         tui_show_symtab_source.
 425
 426 2019-08-16  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-winsource.h (struct tui_source_window_base)
 429         <set_contents>: Declare.
 430         * tui/tui-winsource.c
 431         (tui_source_window_base::update_source_window_as_is): Update.
 432         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 433         Declare.
 434         (tui_set_source_content): Don't declare.
 435         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 436         tui_set_source_content.
 437         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 438         Declare.
 439         (tui_set_disassem_content): Don't declare.
 440         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 441         tui_set_disassem_content.
 442
 443 2019-08-16  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-winsource.h (struct tui_source_window_base)
 446         <update_breakpoint_info>: Declare.
 447         (tui_update_breakpoint_info): Don't declare.
 448         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 449         (tui_update_all_breakpoint_info): Update.
 450         (tui_source_window_base::update_breakpoint_info): Rename from
 451         tui_update_breakpoint_info.
 452         (tui_source_window_base::update_exec_info): Update.
 453
 454 2019-08-16  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-winsource.h (struct tui_source_window_base)
 457         <update_source_window>: Declare.
 458         (tui_update_source_window): Don't declare.
 459         * tui/tui-winsource.c
 460         (tui_source_window_base::update_source_window): Rename from
 461         tui_update_source_window.
 462         (tui_source_window_base::rerender): Update.
 463         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 464         * tui/tui-disasm.c (tui_show_disassem)
 465         (tui_show_disassem_and_update_source)
 466         (tui_disasm_window::maybe_update): Update.
 467
 468 2019-08-16  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-winsource.h (struct tui_source_window_base)
 471         <update_source_window_as_is>: Declare.
 472         (tui_update_source_window_as_is): Don't declare.
 473         * tui/tui-winsource.c (tui_update_source_window): Update
 474         (tui_source_window_base::update_source_window_as_is): Rename from
 475         tui_update_source_window_as_is.
 476         (tui_source_window_base::refill): Update.
 477         * tui/tui-source.c (tui_show_symtab_source): Update.
 478         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 479         Update.
 480
 481 2019-08-16  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-winsource.h (tui_update_source_window)
 484         (tui_update_source_window_as_is): Remove "noerror" parameter.
 485         * tui/tui-winsource.c (tui_update_source_window)
 486         (tui_update_source_window_as_is): Remove "noerror" parameter.
 487         (tui_update_source_windows_with_addr)
 488         (tui_update_source_windows_with_line)
 489         (tui_source_window_base::rerender)
 490         (tui_source_window_base::refill): Update.
 491         * tui/tui-source.h (tui_set_source_content)
 492         (tui_show_symtab_source): Remove "noerror" parameter.
 493         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 494         parameter.
 495         (tui_show_symtab_source): Likewise.
 496         (tui_source_window::maybe_update): Update.
 497         * tui/tui-disasm.c (tui_show_disassem)
 498         (tui_show_disassem_and_update_source)
 499         (tui_disasm_window::do_scroll_vertical)
 500         (tui_disasm_window::maybe_update): Update.
 501
 502 2019-08-16  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui.c (tui_is_window_visible): Update.
 505         * tui/tui-wingeneral.c (tui_make_window)
 506         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 507         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 508         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 509         (tui_set_win_height_command, parse_scrolling_args): Update.
 510         * tui/tui-source.c (tui_source_window::style_changed): Update.
 511         * tui/tui-regs.c (tui_show_registers)
 512         (tui_data_window::first_data_item_displayed)
 513         (tui_data_window::delete_data_content_windows)
 514         (tui_check_register_values, tui_reg_command): Update.
 515         * tui/tui-disasm.c (tui_show_disassem): Update.
 516         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 517         method.
 518         <is_visible>: Remove field.
 519         * tui/tui-data.c (tui_next_win, tui_prev_win)
 520         (tui_delete_invisible_windows): Update.
 521
 522 2019-08-16  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-winsource.h (struct tui_source_window_base)
 525         <m_has_locator>: Remove.
 526         * tui/tui-layout.c (show_source_disasm_command, show_data)
 527         (show_source_or_disasm_and_command): Update.
 528
 529 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 530
 531         * NEWS (Other MI changes): New subsection.
 532         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 533         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 534         * arch-utils.c (default_get_pc_address_flags): New function.
 535         * arch-utils.h (default_get_pc_address_flags): New declaration.
 536         * gdbarch.sh: Add get_pc_address_flags.
 537         * gdbarch.c: Regenerate.
 538         * gdbarch.h: Likewise.
 539         * stack.c (print_pc): New function.
 540         (print_frame_info) (print_frame): Call print_pc.
 541
 542 2019-08-16  Tom de Vries  <tdevries@suse.de>
 543
 544         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 545         print_objfile_section_info.
 546
 547 2019-08-15  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 550         calling update_cmdwin_start_line.
 551         * tui/tui-winsource.h (struct tui_source_window_base)
 552         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 553         <rerender>: Declare.
 554         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 555         Call rerender.
 556         (tui_source_window_base::set_new_height): Remove.
 557         (tui_source_window_base::rerender): Rename from
 558         do_make_visible_with_new_height.
 559         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 560         resize method.
 561         (tui_win_info::make_invisible_and_set_new_height)
 562         (tui_win_info::make_visible_with_new_height): Remove.
 563         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 564         Declare.
 565         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 566         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 567         do_make_visible_with_new_height>: Don't declare.
 568         <rerender>: Declare.
 569         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 570         set_new_height.
 571         (tui_data_window::do_make_visible_with_new_height): Remove.
 572         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 573         call tui_show_locator_content.
 574         (tui_gen_win_info::resize): Call rerender.
 575         (show_source_or_disasm_and_command): Don't call
 576         tui_show_locator_content.
 577         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 578         method.
 579         (struct tui_win_info) <rerender>: Declare.
 580         <set_new_height, make_invisible_and_set_new_height,
 581         make_visible_with_new_height>: Don't declare.
 582         * tui/tui-data.c (tui_win_list::rerender): New method.
 583         * tui/tui-command.h (struct tui_cmd_window)
 584         <do_make_visible_with_new_height>: Don't declare.
 585         * tui/tui-command.c
 586         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 587
 588 2019-08-15  Tom Tromey  <tromey@adacore.com>
 589
 590         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 591         * ada-lang.c (ada_enum_name): Likewise.
 592
 593 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 594
 595         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 596         leading underscore.
 597         (GdbOutputErrorFile): Likewise.
 598         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 599         accordingly.
 600         (execute_unwinders): Rename to have a leading underscore.
 601         (auto_load_packages): Likewise.
 602         (global scope): Adjust call to auto_load_packages accordingly.
 603         (GdbSetPythonDirectory): Likewise.
 604         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 605         instead of execute_unwinders.
 606
 607 2019-08-15  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 610         (show_data): Don't change window visibility.
 611         (tui_gen_win_info::resize): Remove special case for command
 612         window.  Use wresize, when available.
 613         (show_source_or_disasm_and_command): Don't change window
 614         visibility.
 615         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 616         <make_visible>: New method.
 617         * tui/tui-command.c (tui_cmd_window::resize): New method.
 618
 619 2019-08-15  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 622         (struct tui_source_windows): New.
 623         * tui/tui-winsource.c (tui_display_main): Update.
 624         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 625         (new_height_ok, parse_scrolling_args): Update.
 626         * tui/tui-layout.c (show_layout, show_data): Update.
 627         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 628         (tui_add_to_source_windows): Don't declare.
 629         * tui/tui-data.c (source_windows, tui_source_windows)
 630         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 631
 632 2019-08-15  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 635         Rename from reset.
 636         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 637         * tui/tui-layout.c (show_source_disasm_command, show_data):
 638         Update.
 639         (tui_gen_win_info::resize): Rename.
 640         (show_source_or_disasm_and_command): Update.
 641         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 642         reset.
 643
 644 2019-08-15  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 647         * tui/tui-interp.c (tui_interp::init): Don't call
 648         tui_initialize_static_data.
 649         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 650
 651 2019-08-15  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 654         examine tui_win_list.
 655
 656 2019-08-15  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 659         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 660         tui_clear_source_content.
 661         (tui_clear_source_content): Remove.
 662         (tui_source_window_base::do_erase_source_content): Hoist call to
 663         content.clear().
 664         * tui/tui-stack.c (tui_show_frame_info): Don't call
 665         tui_clear_source_content.
 666
 667 2019-08-15  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-winsource.h (struct tui_source_window_base)
 670         <do_erase_source_content>: New method.
 671         <erase_source_content>: New method.
 672         (tui_erase_source_content): Don't declare.
 673         * tui/tui-winsource.c (tui_clear_source_content): Update.
 674         (tui_source_window_base::do_erase_source_content): Rename from
 675         tui_erase_source_content.
 676         (tui_source_window_base::show_source_content): Update.
 677         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 678         * tui/tui-source.h (struct tui_source_window)
 679         <erase_source_content>: New method.
 680         * tui/tui-disasm.h (struct tui_disasm_window)
 681         <erase_source_content>: New method.
 682
 683 2019-08-15  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 686         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 687         constructor.
 688         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 689         * tui/tui-source.c (tui_set_source_content): Update.
 690         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 691
 692 2019-08-15  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 695         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 696         tui-source.c.
 697         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 698         Declare.
 699         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 700         method.
 701         (tui_source_window::maybe_update): Update.
 702
 703 2019-08-15  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 706         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 707         tui-disasm.c.
 708         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 709         Declare.
 710         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 711         method.
 712         (tui_disasm_window::maybe_update): Update.
 713
 714 2019-08-15  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-winsource.h (struct tui_source_window_base)
 717         <maybe_update>: Declare.
 718         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 719         method.
 720         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 721         Declare.
 722         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 723         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 724         Declare.
 725         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 726
 727 2019-08-15  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 730
 731 2019-08-15  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-wingeneral.c: Include tui-stack.h.
 734         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 735         (struct tui_locator_window): Move from tui-data.h.
 736         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 737         (tui_initialize_static_data): Move from tui-data.c.
 738         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 739         (struct tui_locator_window): Move to tui-stack.c.
 740         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 741         (tui_initialize_static_data): Move to tui-stack.c.
 742
 743 2019-08-15  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-layout.c (show_source_disasm_command)
 746         (show_source_or_disasm_and_command): Use make_visible method, not
 747         tui_make_window.
 748         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 749         Remove.
 750
 751 2019-08-15  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-wingeneral.h (tui_make_window): Update.
 754         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 755         parameter.
 756         (tui_gen_win_info::make_visible): Update.
 757         * tui/tui-regs.c (tui_data_window::display_registers_from):
 758         Update.
 759         * tui/tui-layout.c (show_source_disasm_command)
 760         (show_source_or_disasm_and_command): Update.
 761         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 762         (enum tui_box): Remove.
 763         (struct tui_win_info) <can_box>: New method.
 764         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 765         method.
 766
 767 2019-08-15  Tom de Vries  <tdevries@suse.de>
 768
 769         * linux-nat-trad.c: Include gdbarch.h.
 770
 771 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 772
 773         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 774         register sizes.
 775
 776 2019-08-14  Tom Tromey  <tromey@adacore.com>
 777
 778         * darwin-nat.c: Include gdbarch.h.
 779         * darwin-nat-info.c: Include gdbarch.h.
 780
 781 2019-08-13  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 784         Remove.
 785         * tui/tui-data.c (tui_initialize_static_data): Update.
 786
 787 2019-08-13  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-winsource.h (struct tui_exec_info_window)
 790         <~tui_exec_info_window, maybe_allocate_content, get_content,
 791         m_content>: Remove.
 792         (struct tui_source_window_base) <set_exec_info_content,
 793         show_exec_info_content>: Don't declare.
 794         * tui/tui-winsource.c
 795         (tui_exec_info_window::maybe_allocate_content): Remove.
 796         (tui_source_window_base::update_exec_info): Rename from
 797         set_exec_info_content.
 798         (tui_source_window_base::show_exec_info_content)
 799         (tui_source_window_base::update_exec_info): Remove.
 800
 801 2019-08-13  Tom Tromey  <tom@tromey.com>
 802
 803         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 804         declare.
 805         * tui/tui-winsource.c (tui_update_source_window_as_is)
 806         (tui_update_source_windows_with_addr, tui_erase_source_content):
 807         Update.
 808         (tui_clear_exec_info_content): Remove.
 809
 810 2019-08-13  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 813         declare.
 814         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 815         call tui_erase_exec_info_content.
 816         (tui_clear_exec_info_content): Rename from
 817         tui_erase_exec_info_content.
 818         (tui_clear_exec_info_content): Delete.
 819
 820 2019-08-13  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-winsource.h (struct tui_source_window_base)
 823         <show_exec_info_content>: Declare.
 824         (tui_show_exec_info_content): Don't declare.
 825         * tui/tui-winsource.c
 826         (tui_source_window_base::show_exec_info_content): Rename from
 827         tui_show_exec_info_content.
 828         (tui_source_window_base::update_exec_info): Update.
 829
 830 2019-08-13  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 833         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 834         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 835         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 836         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 837         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 838         ... here.
 839
 840 2019-08-13  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-winsource.h (struct tui_source_window_base)
 843         <update_exec_info>: Declare.
 844         (tui_update_exec_info): Don't declare.
 845         * tui/tui-winsource.c (tui_update_source_window_as_is)
 846         (tui_source_window_base::refresh_all)
 847         (tui_update_all_breakpoint_info): Update.
 848         (tui_source_window_base::update_exec_info): Rename from
 849         tui_update_exec_info.
 850         * tui/tui-stack.c (tui_show_frame_info): Update.
 851
 852 2019-08-13  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-winsource.h (struct tui_source_window_base)
 855         <set_exec_info_content>: Declare.
 856         (tui_set_exec_info_content): Don't declare.
 857         * tui/tui-winsource.c
 858         (tui_source_window_base::set_exec_info_content): Rename from
 859         tui_set_exec_info_content.
 860         (tui_update_exec_info): Update.
 861
 862 2019-08-13  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-winsource.h (struct tui_source_window_base)
 865         <show_source_content>: Declare.
 866         (tui_show_source_content): Don't declare.
 867         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 868         (tui_source_window_base::show_source_content): Rename from
 869         tui_show_source_content.
 870         (tui_source_window_base::refresh_all): Update.
 871         * tui/tui-layout.c (show_source_disasm_command)
 872         (show_source_or_disasm_and_command): Update.
 873
 874 2019-08-13  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-winsource.c (tui_erase_source_content)
 877         (tui_show_source_content, tui_source_window_base::refresh_all):
 878         Update.
 879         * tui/tui-wingeneral.h
 880         (tui_check_and_display_highlight_if_needed): Don't declare.
 881         * tui/tui-wingeneral.c
 882         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 883         check_and_display_highlight_if_needed.
 884         * tui/tui-win.c (tui_rehighlight_all)
 885         (tui_win_info::make_visible_with_new_height): Update.
 886         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 887         (tui_data_window::erase_data_content)
 888         (tui_data_window::display_all_data): Update.
 889         * tui/tui-data.h (struct tui_win_info)
 890         <check_and_display_highlight_if_needed>: Declare.
 891
 892 2019-08-13  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-win.c (tui_resize_all): Call
 895         tui_delete_invisible_windows.
 896         * tui/tui-layout.c (show_layout): Call
 897         tui_delete_invisible_windows.
 898         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 899         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 900
 901 2019-08-13  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 904         tui_add_win_to_layout.
 905
 906 2019-08-13  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 909         * tui/tui-layout.c (tui_default_win_height): Now static.
 910
 911 2019-08-13  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 914         single switch.
 915         (show_source_disasm_command, show_source_or_disasm_and_command):
 916         Don't check current layout.
 917
 918 2019-08-13  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-wingeneral.c (make_all_visible): Remove.
 921         (tui_make_all_invisible): Simplify.
 922         * tui/tui-layout.c (tui_make_all_invisible): Move from
 923         tui-wingeneral.c; simplify.
 924         (show_layout): Hoist call to tui_make_all_invisible.
 925         (show_data): Don't call tui_make_all_invisible.
 926
 927 2019-08-13  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 930         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 931
 932 2019-08-13  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 935         tui-data.c.
 936         (show_source_disasm_command, show_data)
 937         (show_source_or_disasm_and_command): Don't use
 938         tui_set_current_layout_to.
 939         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 940         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 941         tui-layout.c.
 942         (tui_set_current_layout_to): Remove.
 943
 944 2019-08-13  Tom Tromey  <tom@tromey.com>
 945
 946         * tui/tui-layout.c (tui_set_layout): Update.
 947         * tui/tui-data.h (struct tui_layout_def): Remove.
 948         (tui_layout_def): Don't declare.
 949         * tui/tui-data.c (layout_def): Remove.
 950         (tui_layout_def): Remove.
 951
 952 2019-08-13  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-winsource.h (struct tui_source_window_base)
 955         <clear_detail>: No longer "override".
 956         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 957         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 958         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 959         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 960         Remove.
 961         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 962
 963 2019-08-13  Tom Tromey  <tromey@adacore.com>
 964
 965         * tracepoint.c: Don't include readline.h or history.h.
 966
 967 2019-08-12  Tom Tromey  <tom@tromey.com>
 968
 969         * configure: Rebuild.
 970         * configure.ac: Check for readline 7.
 971         * NEWS: Mention readline 7 requirement.
 972         * README: Update.
 973
 974 2019-08-12  Tom Tromey  <tom@tromey.com>
 975
 976         * mingw-hdep.c (gdb_select): Remove readline hack.
 977
 978 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 979
 980         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 981         when the function fails.
 982
 983 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 984
 985         * s390-tdep.c (s390_type_align): New function.
 986         (s390_gdbarch_init): Set it as type_align gdbarch method.
 987
 988 2019-08-09  Tom de Vries  <tdevries@suse.de>
 989
 990         PR gdb/24591
 991         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 992         pc_low with relocation offset.
 993
 994 2019-08-07  Tom Tromey  <tromey@adacore.com>
 995
 996         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 997         (print_frame_args): Update.
 998         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 999         Update.
1000         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1001         * frame.h (struct frame_arg): Add initializers.
1002         <error>: Now a unique_xmalloc_ptr.
1003
1004 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1005
1006         * NEWS: Expand the Pointer Authentication entry.
1007         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1008         (aarch64_frame_unmask_lr): ... to this.
1009         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1010         Call aarch64_frame_unmask_lr.
1011         * frame.c (struct frame_info): Add "masked" variable.
1012         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1013         (fprint_frame): Check for masked pc.
1014         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1015         declarations.
1016         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1017         * stack.c (print_frame): Check for masked pc.
1018
1019 2019-08-06  Tom Tromey  <tom@tromey.com>
1020
1021         * stabsread.c (patch_block_stabs, read_one_struct_field)
1022         (read_enum_type): Use obstack_strndup.
1023         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1024         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1025         * dwarf2read.c (guess_full_die_structure_name)
1026         (anonymous_struct_prefix): Use obstack_strndup.
1027         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1028         * c-exp.y (yylex): Use obstack_strndup.
1029         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1030         (write_var_or_type): Use obstack_strndup.
1031
1032 2019-08-06  Tom Tromey  <tom@tromey.com>
1033
1034         * symfile.c (reread_symbols): Use obstack_strdup.
1035         * stabsread.c (read_type): Use obstack_strdup.
1036         * gdb_obstack.h (obstack_strdup): New overload.
1037         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1038         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1039         (dwarf2_canonicalize_name): Use obstack_strdup.
1040         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1041         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1042         Use obstack_strdup.
1043
1044 2019-08-06  Tom Tromey  <tom@tromey.com>
1045
1046         * gdb_obstack.h (obstack_strdup): Define.
1047         * gdb_obstack.c (obstack_strdup): Don't define.
1048
1049 2019-08-06  Tom Tromey  <tom@tromey.com>
1050
1051         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1052         obstack_strdup.
1053         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1054         obstack_strdup.
1055         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1056         * stabsread.c (common_block_start): Use obstack_strdup.
1057         * objfiles.c (set_objfile_main_name, objfile): Use
1058         obstack_strdup.
1059         * namespace.c (add_using_directive): Use obstack_strdup.
1060         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1061         * jit.c (finalize_symtab): Use obstack_strdup.
1062         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1063         (guess_partial_die_structure_name, partial_die_info::fixup)
1064         (dwarf2_name): Use obstack_strdup.
1065         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1066         obstack_strdup.
1067         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1068         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1069         obstack_strdup.
1070         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1071
1072 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1073
1074         * unittests/help-doc-selftests.c: New file.
1075         * Makefile.in: Add the new file.
1076
1077 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1078
1079         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1080         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1081         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1082         the trailing '.' is not output, and the first character is uppercased.
1083         (print_help_for_command): Update call to print_doc_line.
1084         (print_doc_of_command): Likewise.
1085         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1086         * cli/cli-option.c (append_indented_doc): Do not append newline.
1087         (build_help_option): Append newline after first appended_indented_doc
1088         only if a second call is done.
1089         (build_help): Append 2 new lines before each option, except the first
1090         one.
1091         * compile/compile.c (_initialize_compile): Add new lines after
1092         %OPTIONS%, when not at the end of the help.
1093         Change help doc or code
1094         producing the help doc to respect the invariants.
1095         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1096         Also removed the new line after 'Options:', as all other commands
1097         do not put an empty line between 'Options:' and the first option.
1098         * printcmd.c (_initialize_printcmd): Likewise.
1099         * stack.c (_initialize_stack): Likewise.
1100         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1101         incorrectly telling COMMAND is optional.
1102         * ada-lang.c (_initialize_ada_language): Change help doc or code
1103         producing the help doc to respect the invariants.
1104         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1105         * breakpoint.c (_initialize_breakpoint): Likewise.
1106         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1107         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1108         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1109         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1110         _initialize_cli_style): Likewise.
1111         * corelow.c (core_target_info): Likewise.
1112         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1113         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1114         * filesystem.c (_initialize_filesystem): Likewise.
1115         * frame.c (_initialize_frame): Likewise.
1116         * gnu-nat.c (add_task_commands): Likewise.
1117         * infcall.c (_initialize_infcall): Likewise.
1118         * infcmd.c (_initialize_infcmd): Likewise.
1119         * interps.c (_initialize_interpreter): Likewise.
1120         * language.c (_initialize_language): Likewise.
1121         * linux-fork.c (_initialize_linux_fork): Likewise.
1122         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1123         * maint.c (_initialize_maint_cmds): Likewise.
1124         * memattr.c (_initialize_mem): Likewise.
1125         * printcmd.c (_initialize_printcmd): Likewise.
1126         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1127         _RegEx): Likewise.
1128         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1129         * record-btrace.c (_initialize_record_btrace): Likewise.
1130         * record-full.c (_initialize_record_full): Likewise.
1131         * record.c (_initialize_record): Likewise.
1132         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1133         * regcache.c (_initialize_regcache): Likewise.
1134         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1135         _initialize_remote): Likewise.
1136         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1137         * serial.c (_initialize_serial): Likewise.
1138         * skip.c (_initialize_step_skip): Likewise.
1139         * source.c (_initialize_source): Likewise.
1140         * stack.c (_initialize_stack): Likewise.
1141         * symfile.c (_initialize_symfile): Likewise.
1142         * symtab.c (_initialize_symtab): Likewise.
1143         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1144         * top.c (init_main): Likewise.
1145         * tracefile-tfile.c (tfile_target_info): Likewise.
1146         * tracepoint.c (_initialize_tracepoint): Likewise.
1147         * tui/tui-win.c (_initialize_tui_win): Likewise.
1148         * utils.c (add_internal_problem_command): Likewise.
1149         * valprint.c (value_print_option_defs): Likewise.
1150
1151 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1152
1153         PR build/24886
1154         * configure.ac: Drop enable-libmcheck support.
1155         * configure, config.in: Rebuild.
1156         * libmcheck.m4: Remove.
1157         * acinclude.m4: Don't include it.
1158         * Makefile.in: Don't distribute it.
1159         * top.c (print_gdb_configuration): Don't mention it.
1160
1161 2019-08-06  Tom Tromey  <tom@tromey.com>
1162
1163         * utils.c (set_output_style): Sometimes pass stream to
1164         emit_style_escape.
1165         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1166         * record-btrace.c (btrace_insn_history): Update.
1167         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1168         method.
1169         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1170         Update initializers.
1171         <m_uiout>: New field.
1172         <m_di>: Move lower.
1173         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1174         Remove "uiout" parameter.
1175         (dump_insns): Update.
1176         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1177         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1178
1179 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1180
1181         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1182         (error_in_psymtab_expansion): Likewise.
1183         (lookup_symbol_via_quick_fns): Likewise.
1184         (basic_lookup_transparent_type_quick): Likewise.
1185         (basic_lookup_transparent_type_1): Likewise.
1186
1187 2019-08-06  Tom Tromey  <tromey@adacore.com>
1188
1189         * source.c (last_source_error): Now bool.
1190         (print_source_lines_base): Make "noprint" bool.  Only open
1191         source file when last_source_visited changes.
1192
1193 2019-08-06  Tom Tromey  <tromey@adacore.com>
1194
1195         * annotate.c (annotate_source_line): Use g_source_cache.
1196         * source-cache.c (source_cache::get_plain_source_lines): Change
1197         parameters.  Populate m_offset_cache.
1198         (source_cache::ensure): New method.
1199         (source_cache::get_line_charpos): New method.
1200         (extract_lines): Move lower.  Change parameters.
1201         (source_cache::get_source_lines): Move lower.
1202         * source-cache.h (class source_cache): Update comment.
1203         <get_line_charpos>: New method.
1204         <get_source_lines>: Update comment.
1205         <clear>: Clear m_offset_cache.
1206         <get_plain_source_lines>: Change parameters.
1207         <ensure>: New method
1208         <m_offset_cache>: New member.
1209         * source.c (forget_cached_source_info_for_objfile): Update.
1210         (info_source_command): Use g_source_cache.
1211         (find_source_lines, open_source_file_with_line_charpos): Remove.
1212         (print_source_lines_base, search_command_helper): Use g_source_cache.
1213         * source.h (open_source_file_with_line_charpos): Don't declare.
1214         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1215         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1216         Use g_source_cache.
1217
1218 2019-08-06  Tom Tromey  <tromey@adacore.com>
1219
1220         * source-cache.c (source_cache::get_plain_source_lines):
1221         Remove "first_line" and "last_line" parameters.
1222         (source_cache::get_source_lines): Cache plain text.
1223         * source-cache.h (class source_cache)
1224         <get_plain_source_lines>: Update.
1225
1226 2019-08-06  Tom Tromey  <tromey@adacore.com>
1227
1228         * source-cache.c (extract_lines): No longer a method.
1229         Changed type of parameter.  Include final newline.
1230         (selftests::extract_lines_test): New function.
1231         (_initialize_source_cache): Likewise.
1232         * source-cache.h (class source_cache)
1233         <extract_lines>: Don't declare.
1234
1235 2019-08-06  Tom Tromey  <tromey@adacore.com>
1236
1237         * breakpoint.c (init_breakpoint_sal): Update.
1238         (breakpoint): Update.
1239         * breakpoint.h (struct breakpoint) <filter>: Now a
1240         unique_xmalloc_ptr.
1241
1242 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1243
1244         * NEWS: Mention dictionary access on blocks.
1245         * python/py-block.c (blpy_getitem): New function.
1246         (block_object_as_mapping): New struct.
1247         (block_object_type): Use new struct for tp_as_mapping field.
1248
1249 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1250
1251         * objfiles.h (objfile): Add a comment describing partial symbols.
1252
1253 2019-08-05  Tom Tromey  <tromey@adacore.com>
1254
1255         * compile/compile.c (_initialize_compile): Use _(), not N_().
1256         * thread.c (_initialize_thread): Use _(), not N_().
1257         * stack.c (_initialize_stack): Use _(), not N_().
1258         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1259
1260 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1261
1262         * dwarf2read.c (struct dw2_symtab_iterator):
1263         <want_specific_block>: Remove.
1264         <block_index>: Change type to gdb::optional.
1265         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1266         change type of BLOCK_INDEX parameter to gdb::optional.
1267         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1268         (dw2_lookup_symbol): Don't pass argument for
1269         WANT_SPECIFIC_BLOCK.
1270         (dw2_expand_symtabs_for_function): Don't pass argument for
1271         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1272         (class dw2_debug_names_iterator)
1273         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1274         parameter, change BLOCK_INDEX type to gdb::optional.
1275         <m_want_specific_block>: Remove.
1276         <m_block_index>: Change type to gdb::optional.
1277         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1278         gdb::optional.  Re-write in function of gdb::optional.
1279         (dw2_debug_names_lookup_symbol): Don't pass argument for
1280         WANT_SPECIFIC_BLOCK.
1281         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1282         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1283         BLOCK_INDEX.
1284
1285 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1286
1287         * NEWS: Mention changes to "info sources" command.
1288
1289 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1290
1291         * symtab.c (filename_partial_match_opts): New struct type.
1292         (struct output_source_filename_data): New members
1293         regexp, c_regexp, partial_match.
1294         (output_source_filename): Use new members to decide to print file.
1295         (info_sources_option_defs): New variable.
1296         (make_info_sources_options_def_group, print_info_sources_header,
1297         info_sources_command_completer):
1298         New functions.
1299         (info_sources_command): Read new optional arguments.
1300         (_initialize_symtab): Update info sources help.
1301
1302 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1303
1304         * ada-lang.c (exception_support_info_v0): Renamed from...
1305         (default_exception_support_info): ... this.  Create new
1306         definition for v1.
1307         (ada_has_this_exception_support): Look up catch_handlers_sym.
1308         (ada_exception_support_info_sniffer): Try v0 after default.
1309
1310 2019-08-01  Tom Tromey  <tromey@adacore.com>
1311
1312         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1313         gdbarch.h.
1314
1315 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1316
1317         * s12z-tdep.c: Fix include path for s12z-opc.h.
1318
1319 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1320
1321         * NEWS: Require GNU make 3.82.
1322
1323 2019-07-16  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1326         declare.
1327
1328 2019-07-30  Tom Tromey  <tromey@adacore.com>
1329
1330         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1331
1332 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1333
1334         * printcmd.c (print_address_symbolic): Print negative offsets.
1335         (build_address_symbolic): Force signed arithmetic when computing
1336         offset.
1337
1338 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1339
1340         PR/24474: Add a function to lookup static variables.
1341         * NEWS: Mention this new function.
1342         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1343         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1344         * python/python.c (python_GdbMethods): Add new function.
1345
1346 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1347
1348         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1349         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1350         (objfpy_lookup_static_symbol): New function.
1351         (objfile_object_methods): Add new functions.
1352
1353 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1354
1355         * NEWS: Mention 'set|show print frame-info'.  Mention new
1356         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1357         backtrace argument.  Mention that python frame filtering code
1358         is now consistent with what 'backtrace' command prints.
1359
1360 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1361
1362         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1363         comments.
1364         (print_frame_info_auto, print_frame_info_source_line,
1365         print_frame_info_location, print_frame_info_source_and_location,
1366         print_frame_info_location_and_address, print_frame_info_short_location):
1367         New declarations.
1368         (struct frame_print_options): New member print_frame_info.
1369         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1370         * stack.h (get_user_print_what_frame_info): New declaration.
1371         (frame_show_address): New declaration.
1372         * stack.c (print_frame_arguments_choices): New value 'presence'.
1373         (print_frame_info_auto, print_frame_info_source_line,
1374         print_frame_info_location, print_frame_info_source_and_location,
1375         print_frame_info_location_and_address, print_frame_info_short_location,
1376         print_frame_info_choices, print_frame_info_print_what): New definitions.
1377         (print_frame_args): Only print dots for args if print frame-arguments
1378         is 'presence'.
1379         (frame_print_option_defs): New element for "frame-info".
1380         (get_user_print_what_frame_info): New function.
1381         (frame_show_address): Make non static.  Move comment to stack.h.
1382         (print_frame_info_to_print_what): New function.
1383         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1384         to decide what to print.
1385         (backtrace_command_1): Handle the new print_frame_arguments_presence
1386         value.
1387         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1388         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1389         (py_print_frame): In non-mi mode, use LOCATION as default for
1390         print_what, similarly to frame information printed directly by
1391         backtrace command. Handle frame-info user option in non MI mode.
1392
1393 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1394
1395         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1396         Add case for debugging 32-bit target on 64-bit host.  Revise
1397         comment.
1398
1399 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1400
1401         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1402         instead of find_function_entry_range_from_pc.
1403
1404 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1405
1406         * stack.c (find_frame_funname): Remove code which preferred
1407         minsym over symtab sym in "certain pathological cases".
1408
1409         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1410         parameter.  Change type of "do_demangle" to bool.
1411         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1412         Pass suitable "prefer_sym_over_minsym" flag to
1413         build_address_symbolic().  Don't output "+" for negative offsets.
1414         * printcmd.c (print_address_symbolic): Update invocation of
1415         build_address_symbolic to include a "prefer_sym_over_minsym"
1416         flag.
1417         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1418         Restrict cases in which use of minimal symbol is preferred to that
1419         of a found symbol.  Update comments.
1420
1421         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1422         for entry pc when entry pc is out of range for that FDE.
1423
1424 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1425
1426         PR gdb/24839:
1427         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1428         type.
1429
1430 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1431
1432         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1433         this function's Python signature.
1434
1435
1436 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1437
1438         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1439         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1440         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1441         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1442         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1443
1444
1445 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1446
1447         * h8300-tdep.c (h8300_register_name_common): New.
1448         h8300_register_name): Use h8300_register_name_common.
1449         (h8300s_register_name): Likewise.
1450         (h8300sx_register_name): Likewise.
1451         (h8300h_register_nam): New.
1452         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1453
1454
1455 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1456
1457         * arm-tdep.c (arm_skip_cmse_entry): New function.
1458         (arm_is_sgstubs_section): New function.
1459         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1460
1461 2019-07-22  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1464         Don't self-assign.
1465
1466 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1467
1468         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1469         type_print.
1470
1471 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1474         so that GDB doesn't match any msymbols when searching in the
1475         TYPES_DOMAIN.
1476         (print_symbol_info): Print using typedef_print or type_print based
1477         on the type of the symbol.  Add updated FIXME comment moved from...
1478         (_initialize_symtab): ... move and update FIXME comment to above.
1479
1480 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * NEWS: Mention adding -q option to "info types".
1483         * symtab.c (struct info_types_options): New struct.
1484         (info_types_options_defs): New variable.
1485         (make_info_types_options_def_group): New function.
1486         (info_types_command): Use gdb::option framework to parse options.
1487         (info_types_command_completer): New function.
1488         (_initialize_symtab): Extend the help text on "info types" and
1489         register command completer.
1490
1491 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1492
1493         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1494         (lookup_symbol_in_objfile): Change int to block_enum and add a
1495         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1496
1497 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1498
1499         * MAINTAINERS (Write After Approval): Add self.
1500
1501 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1504         instruction to the dummy code region.
1505
1506 2019-07-19  Tom Tromey  <tromey@adacore.com>
1507
1508         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1509         (ARGSUSED, PARAMS, __func__): Remove rules.
1510
1511 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1512
1513         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1514         * features/arm/arm-with-iwmmxt.c: Remove.
1515         * features/arm/arm-with-iwmmxt.xml: Remove.
1516         * features/arm/arm-with-m-fpa-layout.c: Remove.
1517         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1518         * features/arm/arm-with-m-vfp-d16.c: Remove.
1519         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1520         * features/arm/arm-with-m.c: Remove.
1521         * features/arm/arm-with-m.xml: Remove.
1522         * features/arm/arm-with-neon.c: Remove.
1523         * features/arm/arm-with-neon.xml: Remove.
1524         * features/arm/arm-with-vfpv2.c: Remove.
1525         * features/arm/arm-with-vfpv2.xml: Remove.
1526         * features/arm/arm-with-vfpv3.c: Remove.
1527         * features/arm/arm-with-vfpv3.xml: Remove.
1528
1529 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1532
1533 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1534
1535         * arch/aarch32.c (aarch32_create_target_description): Create
1536         target descriptions using features.
1537         * arch/arm.c (arm_create_target_description)
1538         (arm_create_mprofile_target_description): Likewise.
1539         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1540
1541 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1542
1543         * Makefile.in: Add new files.
1544         * aarch32-tdep.c: New file.
1545         * aarch32-tdep.h: New file.
1546         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1547         Call aarch32_read_description.
1548         * arch/aarch32.c: New file.
1549         * arch/aarch32.h: New file.
1550         * arch/arm.c (arm_create_target_description)
1551         (arm_create_mprofile_target_description): New function.
1552         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1553         (arm_create_target_description)
1554         (arm_create_mprofile_target_description): New declaration.
1555         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1556         read_description functions.
1557         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1558         Likewise.
1559         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1560         * arm-tdep.c (tdesc_arm_list): New variable.
1561         (arm_register_g_packet_guesses): Call create description functions.
1562         (arm_read_description) (arm_read_mprofile_description): New
1563         function.
1564         * arm-tdep.h (arm_read_description)
1565         (arm_read_mprofile_description): Add declaration.
1566         * configure.tgt: Add new files.
1567
1568 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1569
1570         * top.c (new_ui_command): Open specified terminal just once.
1571
1572 2019-07-18  Tom Tromey  <tromey@adacore.com>
1573
1574         * symtab.c (main_name): Constify return type.
1575         * symfile.c (set_initial_language): Update.
1576         * symtab.h (main_name): Constify return type.
1577
1578 2019-07-17  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-winsource.c (tui_update_source_window)
1581         (tui_update_source_window_as_is)
1582         (tui_update_source_windows_with_line): Remove return.
1583         * tui/tui-disasm.c (tui_show_disassem)
1584         (tui_show_disassem_and_update_source): Remove return.
1585         * tui/tui.c (tui_reset): Remove return.
1586         * tui/tui-wingeneral.c
1587         (tui_check_and_display_highlight_if_needed): Remove return.
1588
1589 2019-07-17  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1592
1593 2019-07-17  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-winsource.h (struct tui_exec_info_window)
1596         (struct tui_source_window_base): Move from tui-data.h.
1597         * tui/tui-winsource.c: Move many method definitions from
1598         elsewhere.  Remove "structuring" comments.
1599         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1600         (tui_source_window_base::refresh_window): Move to
1601         tui-winsource.c.
1602         * tui/tui-win.c (tui_source_window_base::refresh_all)
1603         (tui_source_window_base::update_tab_width)
1604         (tui_source_window_base::set_new_height)
1605         (tui_source_window_base::do_make_visible_with_new_height): Move to
1606         tui-winsource.c.
1607         * tui/tui-source.h: Update.
1608         * tui/tui-source.c (tui_source_window_base::reset): Move to
1609         tui-winsource.c.
1610         * tui/tui-disasm.h: Update.
1611         * tui/tui-data.h (struct tui_exec_info_window): Move to
1612         tui-winsource.h.
1613         (struct tui_source_window_base): Likewise.
1614         * tui/tui-data.c (tui_source_window_base::clear_detail)
1615         (tui_source_window_base, ~tui_source_window_base): Move to
1616         tui-winsource.c.
1617
1618 2019-07-17  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-win.c (tui_resize_all)
1621         (tui_source_window_base::update_tab_width)
1622         (tui_adjust_win_heights): Update.
1623         (tui_win_info::make_invisible_and_set_new_height): Rename from
1624         make_invisible_and_set_new_height.
1625         * tui/tui-data.h (struct tui_win_info)
1626         <make_invisible_and_set_new_height>: New method.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui.c: Update.
1631         * tui/tui-source.h (struct tui_source_window): Move from
1632         tui-data.h.
1633         * tui/tui-layout.c: Update.
1634         * tui/tui-disasm.c: Update.
1635         * tui/tui-data.h (struct tui_source_window): Move to
1636         tui-source.h.
1637
1638 2019-07-17  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1641         tui-data.h.
1642         * tui/tui-data.h (struct tui_disasm_window): Move to
1643         tui-disasm.h.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-regs.h (struct tui_data_item_window): Move from
1648         tui-data.h.
1649         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1650         * tui/tui-data.h (struct tui_data_item_window): Move to
1651         tui-regs.h.
1652         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui.c: Update.
1657         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1658         (tui_cmd_window::max_height): Move to tui-command.c.
1659         * tui/tui-layout.c: Update.
1660         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1661         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1662         tui-command.c.
1663         * tui/tui-command.h (struct tui_cmd_window): Move from
1664         tui-data.h.
1665         * tui/tui-command.c: Remove "structuring" comments.
1666         (tui_cmd_window::clear_detail)
1667         (tui_cmd_window::do_make_visible_with_new_height)
1668         (tui_cmd_window::max_height): Move from elsewhere.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1673         Now static.
1674         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1675         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1676
1677 2019-07-17  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui.c: Update.
1680         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1681         tui-regs.c.
1682         * tui/tui-windata.h: Remove file.
1683         * tui/tui-windata.c: Remove file.
1684         * tui/tui-win.c (tui_data_window::set_new_height)
1685         (tui_data_window::do_make_visible_with_new_height): Move to
1686         tui-regs.c.
1687         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1688         * tui/tui-regs.c: Remove "structuring" comments.
1689         (tui_data_window::first_data_item_displayed)
1690         (tui_data_window::delete_data_content_windows)
1691         (tui_data_window::erase_data_content)
1692         (tui_data_window::display_all_data)
1693         (tui_data_window::refresh_all)
1694         (tui_data_window::do_scroll_vertical)
1695         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1696         (tui_data_window::do_make_visible_with_new_height)
1697         (tui_data_window::refresh_window): Move from elsewhere.
1698         (_initialize_tui_regs): Move to end of file.
1699         * tui/tui-layout.c: Update.
1700         * tui/tui-hooks.c: Update.
1701         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1702         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1703         tui-regs.c.
1704         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1705
1706 2019-07-17  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1709         seen.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-win.c (tui_source_window_base::set_new_height)
1714         (tui_source_window_base::do_make_visible_with_new_height): Use
1715         m_has_locator field directly.
1716         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1717         method.
1718         (struct tui_source_window_base) <has_locator>: Likewise.
1719
1720 2019-07-17  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1723         Don't declare.
1724         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1725         Remove.
1726         * tui/tui-win.c (tui_source_window_base::set_new_height)
1727         (tui_source_window_base::set_new_height)
1728         (make_invisible_and_set_new_height)
1729         (tui_source_window_base::do_make_visible_with_new_height)
1730         (tui_source_window_base::do_make_visible_with_new_height):
1731         Update.
1732         * tui/tui-layout.c (show_source_disasm_command, show_data)
1733         (show_source_or_disasm_and_command): Update.
1734         * tui/tui-layout.c (show_layout): Update.
1735
1736 2019-07-17  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-layout.c (make_data_window): Remove.
1739         (show_data): Unify creation and re-initialization cases.
1740
1741 2019-07-17  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-layout.c (make_source_window, make_disasm_window):
1744         Remove.
1745         (show_data): Unify creation and re-initialization cases.
1746
1747 2019-07-17  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-layout.c (make_command_window): Remove.
1750         (show_source_disasm_command, show_source_or_disasm_and_command):
1751         Unify creation and re-initialization cases.
1752
1753 2019-07-17  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1756         creation and re-initialization cases.
1757
1758 2019-07-17  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-regs.c (tui_get_register): Return void.
1761
1762 2019-07-17  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1765         Simplify.
1766
1767 2019-07-17  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1770         resetting.
1771
1772 2019-07-17  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1775         * tui/tui-regs.c (tui_reg_layout): New function.
1776         (tui_show_registers, tui_reg_command): Use it.
1777         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1778         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1779         parameters.
1780         (tui_layout_command): Remove.
1781
1782 2019-07-17  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-layout.h (tui/tui-layout): Return void.
1785         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1786
1787 2019-07-17  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-layout.c (show_source_disasm_command, show_data):
1790         Update.
1791         (reset_locator): Remove.
1792         (show_source_or_disasm_and_command): Update.
1793
1794 2019-07-17  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-source.c (tui_source_window_base::reset): Remove
1797         win_type parameter.
1798         * tui/tui-layout.c (make_command_window, make_source_window)
1799         (make_disasm_window, make_data_window)
1800         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1801         (reset_locator, show_source_or_disasm_and_command): Update.
1802         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1803         win_type parameter.
1804         (struct tui_source_window_base) <reset>: Likewise.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-layout.c (show_source_disasm_command): Use
1809         reset_locator.
1810         (reset_locator): New function.
1811         (init_and_make_win): Remove.
1812         (show_source_or_disasm_and_command): Use reset_locator.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1817         condition.
1818         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1819         Remove condition.
1820         * tui/tui-source.c (tui_source_window_base::reset): New method.
1821         * tui/tui-layout.c (make_command_window): Don't call
1822         init_and_make_win.
1823         (make_source_window, make_disasm_window): Don't call
1824         make_source_or_disasm_window.
1825         (make_data_window): Don't call init_and_make_win.  Change calling
1826         convention.
1827         (show_source_disasm_command, show_data): Simplify.
1828         (make_source_or_disasm_window): Remove.
1829         (show_source_or_disasm_and_command): Simplify.
1830         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1831         (struct tui_source_window_base) <reset>: Likewise.
1832         <execution_info>: Remove initializer.
1833         * tui/tui-data.c (tui_source_window_base): Initialize
1834         execution_info.
1835
1836 2019-07-17  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1839         variable.
1840
1841 2019-07-17  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui.c (tui_rl_other_window): Update.
1844         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1845         superclass method first.  Always iterate over regs_content.
1846         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1847         method.
1848         * tui/tui-win.c (tui_set_focus_command): Update.
1849
1850 2019-07-17  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-win.c (tui_set_focus_command): Rename from
1853         tui_set_focus.  Call tui_enable.
1854         (tui_set_focus_command): Remove.
1855
1856 2019-07-17  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1859         refresh_window.
1860         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1861         touchwin.
1862         (tui_data_window::refresh_window): Call refresh_window on data
1863         items.  Always call superclass refresh_window.
1864         (tui_win_info::refresh): Remove.
1865         (tui_source_window_base::refresh_window): Update.
1866         (tui_refresh_all): Update.
1867         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1868         refresh_window.
1869         (show_source_or_disasm_and_command): Likewise.
1870         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1871         (struct tui_source_window_base) <refresh>: Likewise.
1872
1873 2019-07-17  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-winsource.c (tui_clear_source_content)
1876         (tui_show_source_content): Update.
1877         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1878         whether content is empty.
1879         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1880         Remove.
1881
1882 2019-07-17  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1885         window's contents.
1886         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1887         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1892         (struct tui_data_item_window): Update.
1893
1894 2019-07-17  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1897         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1898         defines.
1899
1900 2019-07-17  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-winsource.h (tui_erase_source_content)
1903         (tui_clear_source_content): Remove "display_prompt" parameter.
1904         * tui/tui-winsource.c (tui_update_source_window_as_is)
1905         (tui_update_source_windows_with_addr): Update.
1906         (tui_clear_source_content): Remove "display_prompt" parameter.
1907         (tui_erase_source_content): Likewise.  Simplify.
1908         (tui_show_source_content): Update.
1909         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1910         * tui/tui-stack.c (tui_show_frame_info): Update.
1911         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1912         Remove defines.
1913
1914 2019-07-17  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1917         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1918         parameter.
1919         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1920         parameter.
1921
1922 2019-07-17  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-winsource.c (tui_clear_source_content)
1925         (tui_show_source_content, tui_show_exec_info_content)
1926         (tui_clear_exec_info_content): Update.
1927         * tui/tui-stack.c (tui_show_locator_content): Update.
1928         (tui_show_frame_info): Update.
1929         * tui/tui-source.h (tui_source_window): Don't declare.
1930         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1931         from tui_source_is_displayed.
1932         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1933         Remove field.
1934         (struct tui_source_window_base) <content_in_use>: New field.  Now
1935         bool.
1936         (struct tui_source_window) <showing_source_p>: New method.
1937         (TUI_SRC_WIN): Change cast.
1938         * tui/tui-data.c (tui_initialize_static_data): Update.
1939
1940 2019-07-17  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1943         location_matches_p.
1944         * tui/tui-source.c (tui_source_window::location_matches_p): New
1945         method.
1946         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1947         method.
1948         * tui/tui-data.h (struct tui_source_window_base)
1949         <location_matches_p>: New method.
1950         (struct tui_source_window, struct tui_disasm_window)
1951         <location_matches_p>: Likewise.
1952
1953 2019-07-17  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-win.c (tui_set_win_height_command): Rename from
1956         tui_set_win_height.
1957         (tui_set_win_height_command): Remove.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-source.c (tui_source_window): New constructor.  Add
1962         observer.
1963         (~tui_source_window): New destructor.
1964         (tui_source_window::style_changed): New method.
1965         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1966         (tui_attach_detach_observers): Update.
1967         * tui/tui-data.h (struct tui_source_window): Make constructor not
1968         inline.  Add destructor.
1969         (struct tui_source_window) <style_changed>: New method.
1970         <m_observable>: New member.
1971
1972 2019-07-17  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1975         * tui/tui-win.c (tui_resize_all): Fix typo.
1976
1977 2019-07-17  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1980         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1981         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1982         * tui/tui-win.c (window_name_completer): Use foreach.
1983         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1984         (update_tab_width): Likewise.
1985         * tui/tui-layout.c (show_layout): Update.
1986         * tui/tui-data.h (class tui_window_iterator): New.
1987         (struct all_tui_windows): New.
1988         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1989
1990 2019-07-17  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1993         parameter.  Don't reference globals.
1994         (tui_reg_command): Update.
1995
1996 2019-07-17  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-regs.c (tui_show_registers): Simplify.
1999
2000 2019-07-17  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-regs.c (tui_show_registers): Update.
2003         (tui_show_register_group): Add win_info parameter.
2004
2005 2019-07-17  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2008         Rename from tui_display_reg_element_at_line.
2009         (tui_data_window::display_registers_from_line): Update.
2010         * tui/tui-data.h (struct tui_data_window)
2011         <display_reg_element_at_line>: New method.
2012
2013 2019-07-17  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-regs.h (tui_display_registers_from)
2016         (tui_display_registers_from_line): Don't declare.
2017         * tui/tui-windata.c (tui_data_window::display_all_data)
2018         (tui_data_window::refresh_all)
2019         (tui_data_window::do_scroll_vertical): Update.
2020         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2021         from tui_display_registers_from.
2022         (tui_display_reg_element_at_line): Update.
2023         (tui_data_window::display_registers_from_line): Rename from
2024         tui_display_registers_from_line.
2025         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2026         display_registers_from_line>: New methods.
2027
2028 2019-07-17  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2031         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2032         from tui_erase_data_content.
2033         (tui_data_window::display_all_data)
2034         (tui_data_window::refresh_all)
2035         (tui_data_window::do_scroll_vertical): Update.
2036         * tui/tui-regs.c (tui_show_registers): Update.
2037         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2038         New method.
2039
2040 2019-07-17  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2043         declare.
2044         * tui/tui-windata.c
2045         (tui_data_window::delete_data_content_windows): Rename from
2046         tui_delete_data_content_windows.
2047         (tui_data_window::display_all_data)
2048         (tui_data_window::do_scroll_vertical): Update.
2049         * tui/tui-data.h (struct tui_data_window)
2050         <delete_data_content_windows>: New method.
2051
2052 2019-07-17  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2055         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2056
2057 2019-07-17  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2060         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2061         from tui_display_all_data.
2062         * tui/tui-win.c
2063         (tui_data_window::do_make_visible_with_new_height): Update.
2064         * tui/tui-regs.c (tui_show_registers): Update.
2065         * tui/tui-layout.c (tui_set_layout): Update.
2066         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2067         method.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2072         * tui/tui-windata.c (tui_display_data_from): Remove.
2073         (tui_data_window::refresh_all): Update.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2078         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2079         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2080         tui_display_registers_from_line.
2081         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2082         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2083         "force_display" parameter.
2084
2085 2019-07-17  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2088         declare.
2089         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2090         Rename from tui_first_reg_element_no_inline.
2091         (tui_display_reg_element_at_line)
2092         (tui_display_registers_from_line): Update.
2093         * tui/tui-data.h (struct tui_data_window)
2094         <first_reg_element_no_inline>: New method.
2095
2096 2019-07-17  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-windata.c (tui_display_data_from)
2099         (tui_data_window::do_scroll_vertical): Update.
2100         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2101         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2102         Rename from tui_line_from_reg_element_no.
2103         (tui_display_registers_from_line): Update.
2104         * tui/tui-data.h (struct tui_data_window)
2105         <line_from_reg_element_no>: New method.
2106
2107 2019-07-17  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2110         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2111         tui_last_regs_line_no.
2112         (tui_display_reg_element_at_line)
2113         (tui_display_registers_from_line): Update.
2114         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2115         method.
2116
2117 2019-07-17  Tom Tromey  <tom@tromey.com>
2118
2119         PR tui/24722:
2120         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2121         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2122         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2123         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2124         (tui_update_breakpoint_info): Likewise.
2125         * tui/tui-hooks.c (tui_event_create_breakpoint)
2126         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2127         Update.
2128
2129 2019-07-17  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2132
2133 2019-07-17  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-winsource.c (tui_update_source_window_as_is)
2136         (tui_update_source_windows_with_addr): Update.
2137         * tui/tui-source.h (tui_set_source_content)
2138         (tui_show_symtab_source): Add "win_info" parameter.
2139         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2140         parameter.
2141         (tui_show_symtab_source): Likewise.
2142
2143 2019-07-17  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-wingeneral.c
2146         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2147
2148 2019-07-17  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2151         (struct tui_cmd_window) <can_scroll>: New method.
2152         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2153         method.
2154
2155 2019-07-17  Tom Tromey  <tromey@adacore.com>
2156
2157         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2158         do_field_signed>: Rename.  Change type of "value".
2159         * ui-out.c (ui_out::field_signed): Rename from field_int.
2160         Change type of "value".
2161         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2162         type of "value".
2163         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2164         do_field_int.  Change type of "value".
2165         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2166         do_field_int.  Change type of "value".
2167         * tracepoint.c (trace_status_mi, tfind_1)
2168         (print_one_static_tracepoint_marker): Update.
2169         * thread.c (print_thread_info_1, print_selected_thread_frame):
2170         Update.
2171         * stack.c (print_frame, print_frame_info): Update.
2172         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2173         Update.
2174         * source.c (print_source_lines_base): Update.
2175         * skip.c (info_skip_command): Update.
2176         * record-btrace.c (btrace_ui_out_decode_error)
2177         (btrace_call_history_src_line): Update.
2178         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2179         Update.
2180         * progspace.c (print_program_space): Update.
2181         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2182         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2183         do_field_int.  Change type of "value".
2184         * mi/mi-out.c (mi_ui_out::do_table_begin)
2185         (mi_ui_out::do_table_header): Update.
2186         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2187         type of "value".
2188         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2189         (mi_cmd_data_list_changed_registers, output_register)
2190         (mi_cmd_data_read_memory, mi_load_progress)
2191         (mi_cmd_trace_frame_collected): Update.
2192         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2193         Update.
2194         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2195         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2196         (mi_cmd_var_list_children, varobj_update_one): Update.
2197         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2198         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2199         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2200         * inferior.c (print_inferior): Update.
2201         * gdb_bfd.c (print_one_bfd): Update.
2202         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2203         Update.
2204         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2205         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2206         do_field_int.  Change type of "value".
2207         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2208         do_field_int.  Change type of "value".
2209         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2210         (print_one_breakpoint_location, print_it_catch_fork)
2211         (print_one_catch_fork, print_it_catch_vfork)
2212         (print_one_catch_vfork, print_it_catch_solib)
2213         (print_it_catch_exec, print_it_ranged_breakpoint)
2214         (print_mention_watchpoint, print_mention_masked_watchpoint)
2215         (bkpt_print_it, update_static_tracepoint): Update.
2216         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2217         * break-catch-syscall.c (print_it_catch_syscall): Update.
2218         * ada-tasks.c (print_ada_task_info): Update.
2219         * ada-lang.c (print_it_exception, print_mention_exception):
2220         Update.
2221
2222 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         PR breakpoints/24541
2225         * gdbarch.c: Regenerate.
2226         * gdbarch.h: Regenerate.
2227         * gdbarch.sh: Adjust return type and parameter types for
2228         'stap_adjust_register'.
2229         (i386_stap_adjust_register): Adjust signature and return new
2230         register name.
2231         * stap-probe.c (stap_parse_register_operand): Adjust use of
2232         'gdbarch_stap_adjust_register'.
2233
2234 2019-07-17  Tom Tromey  <tromey@adacore.com>
2235
2236         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2237         declare VEC.
2238         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2239         std::vector.
2240         (struct s390_process_info): Add initializers.
2241         (s390_add_process): Use new.
2242         (s390_linux_nat_target::low_forget_process): Use delete.
2243         (s390_linux_nat_target::low_new_fork)
2244         (s390_linux_nat_target::stopped_by_watchpoint)
2245         (s390_linux_nat_target::low_prepare_to_resume)
2246         (s390_linux_nat_target::insert_watchpoint)
2247         (s390_linux_nat_target::insert_hw_breakpoint)
2248         (s390_linux_nat_target::remove_watchpoint)
2249         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2250
2251 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2252
2253         * aarch64-fbsd-nat.c: Include regcache.h.
2254         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2255         argument.
2256         (aarch64_fbsd_nat_target::fetch_registers)
2257         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2258         variable.
2259         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2260
2261 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2262
2263         * fbsd-nat.c: Include gdbarch.h.
2264
2265 2019-07-15  Tom Tromey  <tromey@adacore.com>
2266
2267         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2268
2269 2019-07-15  Tom Tromey  <tromey@adacore.com>
2270
2271         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2272         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2273         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2274         * cli-out.c (cli_ui_out::do_field_int): New method.
2275         * ui-out.c (ui_out::field_unsigned): New method.
2276         * symfile.c (generic_load): Use field_unsigned.
2277         (print_transfer_performance): Likewise.
2278         * record-btrace.c (ui_out_field_uint): Remove.
2279         (btrace_call_history_insn_range, btrace_call_history): Use
2280         field_unsigned.
2281         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2282         field_unsigned.
2283         * ui-out.h (class ui_out) <field_unsigned>: New method.
2284         <do_field_unsigned>: Likewise.
2285
2286 2019-07-15  Tom Tromey  <tromey@adacore.com>
2287
2288         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2289         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2290         * target.c (flash_erase_command): Use field_string.
2291         * infrun.c (print_signal_received_reason): Use field_string.
2292         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2293         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2294         field_string.
2295         * ada-tasks.c (print_ada_task_info): Use field_string.
2296
2297 2019-07-15  Tom Tromey  <tromey@adacore.com>
2298
2299         * target.c (flash_erase_command): Use field_core_addr.
2300         * symfile.c (generic_load): Use field_core_addr.
2301         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2302         Use field_core_addr.
2303         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2304         field_core_addr.
2305
2306 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2309         value if its desired type is smaller than a CORE_ADDR and signed.
2310
2311 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2312
2313         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2314         of changes to field names, and use new is_reference field to
2315         decide if a property is a reference or not.
2316         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2317         field.
2318         (struct dwarf2_property_baton): Update header comment, rename
2319         'referenced_type' to 'property_type' and update comments.
2320         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2321         default property type, store in property baton, update to take
2322         accound of renamed field.
2323         (read_func_scope): Update call to attr_to_dynamic_prop.
2324         (read_array_type): Likewise.
2325         (dwarf2_per_cu_addr_sized_int_type): New function.
2326         (read_subrange_index_type): Move type finding code to
2327         dwarf2_per_cu_addr_sized_int_type.
2328         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2329         (dwarf2_per_cu_addr_type): New function.
2330         (set_die_type): Update calls to attr_to_dynamic_prop.
2331
2332 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * dwarf2read.c (read_subrange_index_type): New function.
2335         (read_subrange_type): Move code into new function and call it.
2336         * gdbtypes.c (create_range_type): Add some asserts.
2337
2338 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2341         update return statements.
2342         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2343         declaration, and update comment to match.
2344         * gdbtypes.c (resolve_dynamic_array): Update call to
2345         dwarf2_evaluate_property to match new return type.
2346
2347 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * valarith.c (value_subscripted_rvalue): Change lowerbound
2350         parameter type from int to LONGEST.
2351         * value.h (value_subscripted_rvalue): Likewise in declaration.
2352
2353 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2354
2355         * cli/cli-utils.c (info_print_command_completer): New function.
2356         * cli/cli-utils.h: Add 'completer.h' include, and forward
2357         declaration for 'struct cmd_list_element'.
2358         (info_print_command_completer): Declare.
2359         * stack.c (_initialize_stack): Add completer for 'info locals' and
2360         'info args'.
2361         * symtab.c (_initialize_symtab): Add completer for 'info
2362         variables' and 'info functions'.
2363         * NEWS: Mention completion for additional info commands.
2364
2365 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2366
2367         * cli/cli-utils.c (extract_info_print_args): Delete.
2368         (extract_arg_maybe_quoted): Delete.
2369         (info_print_options_defs): New variable.
2370         (make_info_print_options_def_group): New function.
2371         (extract_info_print_options): Define new function.
2372         * cli/cli-utils.h (extract_info_print_args): Delete.
2373         (struct info_print_options): New structure.
2374         (extract_info_print_options): Declare new function.
2375         * stack.c (info_locals_command): Update to use new
2376         extract_info_print_options, also add a header comment.
2377         (info_args_command): Likewise.
2378         * symtab.c (info_variables_command): Likewise.
2379         (info_functions_command): Likewise.
2380
2381 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2384         to extract string arguments.
2385         * common/common-utils.c (extract_string_maybe_quoted): New function.
2386         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2387
2388 2019-07-11  Tom Tromey  <tromey@adacore.com>
2389
2390         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2391         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2392         * top.h (gdbinit): Don't declare.
2393         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2394         into...
2395         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2396         * top.c (gdb_init): Don't call init_cli_cmds.
2397         (gdbinit): Remove.
2398         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2399
2400 2019-07-11  Tom Tromey  <tromey@adacore.com>
2401
2402         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2403         after it has been moved.
2404
2405 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2406
2407         * valops.c (value_must_coerce_to_target): Change return type to
2408         bool.
2409         * value.h (value_must_coerce_to_target): Likewise.
2410
2411 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2412
2413         * breakpoint.c (is_hardware_watchpoint): Remove
2414         forward-declaration.
2415         (is_masked_watchpoint): Change return type to bool.
2416         (is_tracepoint): Likewise.
2417         (is_breakpoint): Likewise.
2418         (is_hardware_watchpoint): Likewise.
2419         (is_watchpoint): Likewise.
2420         (is_no_memory_software_watchpoint): Likewise.
2421         (is_catchpoint): Likewise.
2422         (breakpoint_1): Make FILTER parameter's return type bool.
2423         is_masked_watchpoint): Change return type to bool.
2424         (save_breakpoints): Make FILTER parameter's return type bool.
2425         * breakpoint.h (is_breakpoint): Change return type to bool.
2426         (is_watchpoint): Likewise.
2427         (is_catchpoint): Likewise.
2428         (is_tracepoint): Likewise.
2429
2430 2019-07-10  Tom Tromey  <tom@tromey.com>
2431
2432         * defs.h: Don't include gdbarch.h.
2433         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2434         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2435         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2436         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2437         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2438         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2439         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2440         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2441         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2442         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2443         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2444         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2445         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2446         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2447         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2448         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2449         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2450         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2451         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2452         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2453         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2454         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2455         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2456         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2457         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2458         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2459         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2460
2461 2019-07-10  Tom Tromey  <tromey@adacore.com>
2462
2463         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2464         * breakpoint.c (init_ada_exception_breakpoint): Register as
2465         bp_catchpoint.
2466         (print_one_breakpoint_location, print_one_breakpoint): Use
2467         is_ada_exception_catchpoint.
2468         * ada-lang.c (class ada_catchpoint_location): Pass
2469         bp_loc_software_breakpoint to bp_location constructor.
2470         (is_ada_exception_catchpoint): New function.
2471
2472 2019-07-10  Tom Tromey  <tromey@adacore.com>
2473
2474         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2475         VEC.
2476         (struct arm_exidx_entry): New method operator<.
2477         (struct arm_exidx_data) <section_maps>: Change type.
2478         (arm_exidx_data_free): Remove.
2479         (arm_exidx_data_key): Change type.  Move lower.
2480         (arm_exidx_new_objfile): Update.
2481         (arm_compare_exidx_entries): Remove.
2482         (arm_find_exidx_entry, _initialize_arm_tdep)
2483
2484 2019-07-10  Tom Tromey  <tromey@adacore.com>
2485
2486         * solib-spu.c (ocl_program_data_key): Change type.
2487         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2488         Update.
2489
2490 2019-07-10  Tom Tromey  <tromey@adacore.com>
2491
2492         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2493         (struct solib_aix_inferior_data) <library_list>: Change type.
2494         (solib_aix_inferior_data_handle): Change type.
2495         (get_solib_aix_inferior_data): Update.
2496         (solib_aix_free_library_list): Remove.
2497         (library_list_start_library): Update.
2498         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2499         return type.
2500         (solib_aix_get_library_list)
2501         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2502         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2503
2504 2019-07-10  Tom Tromey  <tromey@adacore.com>
2505
2506         * solib-dsbt.c (struct dsbt_info): Add initializers.
2507         (solib_dsbt_pspace_data): Change type.
2508         (dsbt_pspace_data_cleanup): Remove.
2509         (get_dsbt_info, _initialize_dsbt_solib): Update.
2510
2511 2019-07-10  Tom Tromey  <tromey@adacore.com>
2512
2513         * spu-tdep.c (spu_overlay_data): Change type.
2514         (spu_get_overlay_table, spu_overlay_new_objfile)
2515         (_initialize_spu_tdep): Update.
2516
2517 2019-07-10  Tom Tromey  <tromey@adacore.com>
2518
2519         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2520         destructor.
2521         (dbx_objfile_data_key): Change type and declare later.
2522         (DBX_SYMFILE_INFO): Rewrite.
2523         * dbxread.c (dbx_objfile_data_key): Change type.
2524         (dbx_symfile_init): Update.
2525         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2526         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2527         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2528
2529 2019-07-10  Tom Tromey  <tromey@adacore.com>
2530
2531         * jit.c (jit_program_space_key): Change type.  Move lower.
2532         (get_jit_program_space_data): Update.
2533         (jit_program_space_data_cleanup): Remove.
2534         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2535         Update.
2536         (struct jit_program_space_data): Add initializers.
2537
2538 2019-07-10  Tom Tromey  <tromey@adacore.com>
2539
2540         * solib-darwin.c (struct darwin_info): Add initializers.
2541         (solib_darwin_pspace_data): Change type.
2542         (darwin_pspace_data_cleanup): Remove.
2543         (get_darwin_info, _initialize_darwin_solib): Update.
2544
2545 2019-07-10  Tom Tromey  <tromey@adacore.com>
2546
2547         * remote-sim.c (struct sim_inferior_data): Add initializers,
2548         constructor, and destructor.
2549         (sim_inferior_data_key): Change type.  Move lower.
2550         (check_for_duplicate_sim_descriptor): Update.
2551         (get_sim_inferior_data): Use new.  Update.
2552         (~sim_inferior_data_cleanup): Rename from
2553         sim_inferior_data_cleanup.  Simplify.
2554         (gdbsim_close_inferior, simulator_command)
2555         (sim_command_completer, _initialize_remote_sim): Update.
2556         (next_pid, INITIAL_PID): Move earlier.
2557
2558 2019-07-10  Tom Tromey  <tromey@adacore.com>
2559
2560         * python/python-internal.h (create_thread_object): Return
2561         gdbpy_ref.
2562         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2563         * python/py-inferior.c (struct threadlist_entry): Add
2564         constructor.
2565         <thread_obj>: Now a gdbpy_ref.
2566         (thread_to_thread_object): Update.
2567         (add_thread_object): Use new.
2568         (delete_thread_object): Use delete.
2569         (infpy_threads): Update.
2570         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2571         GIL.
2572
2573 2019-07-10  Tom Tromey  <tromey@adacore.com>
2574
2575         * valops.c (value_cast): Specialize error message for Ada.
2576
2577 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2578
2579         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2580
2581 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2582
2583         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2584         bpstat_should_step): Return bool, adjust comments.
2585         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2586         bpstat_should_step): Likewise.
2587
2588 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2589
2590         * features/Makefile: Use feature target descriptions for Arm.
2591         * features/arm/arm-core.c: Generate new file.
2592         * features/arm/arm-fpa.c: Likewise.
2593         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2594         * features/arm/arm-m-profile.c: Likewise.
2595         * features/arm/arm-vfpv2.c: Likewise.
2596         * features/arm/arm-vfpv3.c: Likewise.
2597         * features/arm/xscale-iwmmxt.c: Likewise.
2598         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2599
2600 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2601
2602         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2603         ptrace earlier.
2604
2605 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2606
2607         * features/aarch64-pauth.c: Regenerate.
2608
2609 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2610
2611         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2612         bool.
2613         (bpstat_what): Use false instead of 0.
2614
2615 2019-07-09  Pedro Alves  <palves@redhat.com>
2616
2617         * break-catch-throw.c (is_exception_catchpoint): New.
2618         * breakpoint.c (print_one_breakpoint_location): New parameter
2619         'raw_loc'.  Handle it.  Use
2620         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2621         looking at the breakpoint's type.
2622         (print_one_breakpoint): If handling "maint info breakpoints", also
2623         print locations of exception catchpoints.
2624         * breakpoint.h (is_exception_catchpoint): Declare.
2625
2626 2019-07-09  Pedro Alves  <palves@redhat.com>
2627
2628         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2629         "addr" field.
2630         (allocate_location_exception_catchpoint): New.
2631         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2632         (initialize_throw_catchpoint_ops): Install
2633         allocate_location_exception_catchpoint as allocate_location
2634         method.
2635         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2636         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2637         bp_loc_other.
2638         (breakpoint_address_is_meaningful): Delete.
2639         (bl_address_is_meaningful): New.
2640         (breakpoint_locations_match): Adjust comment.
2641         (bp_location_from_bp_type): New, factored out of...
2642         (bp_location::bp_location(breakpoint *)): ... this.
2643         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2644         factored out of...
2645         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2646         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2647         breakpoint_address_is_meaningful.
2648         (bp_locations_compare): Adjust comment.
2649         (update_global_location_list): Use bl_address_is_meaningful
2650         instead of breakpoint_address_is_meaningful.
2651         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2652         explicit.
2653         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2654         * python/py-breakpoint.c (bppy_get_location): No longer check
2655         whether location is null.
2656
2657 2019-07-09  Pedro Alves  <palves@redhat.com>
2658
2659         PR c++/15468
2660         * breakpoint.c (print_one_breakpoint_location): Remove
2661         single-location assert.
2662
2663 2019-07-09  Tom Tromey  <tom@tromey.com>
2664
2665         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2666         * configure: Rebuild.
2667         * configure.ac: Change common to gdbsupport.
2668         * gdbsupport: Rename from common.
2669         * acinclude.m4: Change common to gdbsupport.
2670         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2671         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2672         gdbsupport.
2673         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2674         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2675         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2676         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2677         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2678         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2679         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2680         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2681         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2682         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2683         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2684         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2685         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2686         coff-pe-read.c, command.h, compile/compile-c-support.c,
2687         compile/compile-c.h, compile/compile-cplus-symbols.c,
2688         compile/compile-cplus-types.c, compile/compile-cplus.h,
2689         compile/compile-loc2c.c, compile/compile.c, completer.c,
2690         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2691         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2692         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2693         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2694         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2695         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2696         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2697         features/aarch64-core.c, features/aarch64-fpu.c,
2698         features/aarch64-pauth.c, features/aarch64-sve.c,
2699         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2700         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2701         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2702         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2703         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2704         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2705         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2706         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2707         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2708         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2709         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2710         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2711         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2712         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2713         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2714         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2715         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2716         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2717         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2718         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2719         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2720         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2721         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2722         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2723         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2724         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2725         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2726         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2727         minsyms.c, mips-linux-tdep.c, namespace.h,
2728         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2729         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2730         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2731         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2732         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2733         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2734         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2735         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2736         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2737         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2738         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2739         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2740         procfs.c, producer.c, progspace.h, psymtab.h,
2741         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2742         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2743         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2744         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2745         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2746         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2747         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2748         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2749         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2750         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2751         target-memory.c, target.c, target.h, target/waitstatus.c,
2752         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2753         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2754         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2755         unittests/array-view-selftests.c,
2756         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2757         unittests/common-utils-selftests.c,
2758         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2759         unittests/format_pieces-selftests.c,
2760         unittests/function-view-selftests.c,
2761         unittests/lookup_name_info-selftests.c,
2762         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2763         unittests/mkdir-recursive-selftests.c,
2764         unittests/observable-selftests.c,
2765         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2766         unittests/parse-connection-spec-selftests.c,
2767         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2768         unittests/scoped_fd-selftests.c,
2769         unittests/scoped_mmap-selftests.c,
2770         unittests/scoped_restore-selftests.c,
2771         unittests/string_view-selftests.c, unittests/style-selftests.c,
2772         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2773         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2774         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2775         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2776         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2777         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2778
2779 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2780
2781         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2782         bool value.
2783         (decode_digits_ordinary): Set explicit_line field in sal.
2784         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2785         symtab_and_line that was set on an explicit line number in
2786         assembler code.  Do always update the recorded symtab and line if
2787         we do skip the prologue.
2788
2789 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * breakpoint.c (set_breakpoint_location_function): Remove
2792         explicit_loc parameter.
2793         (momentary_breakpoint_from_master): Update call to
2794         set_breakpoint_location_function.
2795         (add_location_to_breakpoint): Likewise.
2796
2797 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2798
2799         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2800         required features based on default bfd type when no specific bfd
2801         is present.
2802
2803 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2804
2805         * NEWS: Mention that GDB printf and eval commands can now print
2806         C-style and Ada-style convenience var strings without
2807         calling the inferior.
2808         * printcmd.c (printf_c_string): Locally print GDB internal var
2809         instead of transiting via the inferior.
2810         (printf_wide_c_string): Likewise.
2811
2812 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2813
2814         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2815
2816 2019-07-04  Tom Tromey  <tom@tromey.com>
2817
2818         PR tui/24724:
2819         * tui/tui-winsource.c (tui_clear_source_content): Update.
2820         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2821         (tui_update_breakpoint_info): Update.
2822         (tui_set_exec_info_content): Update.
2823         * tui/tui-source.c (tui_set_source_content_nil): Update.
2824         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2825         has_break.
2826         * tui/tui-data.h (enum tui_bp_flag): New.
2827         (tui_bp_flags): New enum flags type.
2828         (struct tui_source_element) <break_mode>: Change type.  Rename
2829         from has_break.
2830         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2831         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2832         constants.
2833         * tui/tui-winsource.h: Fix comment.
2834
2835 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2836
2837         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2838         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2839         (store_fpregs_to_thread)
2840         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2841         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2842         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2843         (IWMMXT_REGS_SIZE): Add define.
2844         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2845         (fetch_vfp_regs, store_vfp_regs)
2846         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2847         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2848
2849 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2850
2851         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2852         defines.
2853         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2854         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2855         (ARM_INT_REGISTER_SIZE): ...to this.
2856         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2857         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2858         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2859         (arm_linux_collect_gregset, supply_nwfpe_register)
2860         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2861         defines.
2862         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2863         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2864         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2865         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2866         (arm_return_in_memory, arm_store_return_value)
2867         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2868         (arm_record_ld_st_multiple): Likewise.
2869         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2870         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2871
2872 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2873
2874         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2875         AARCH64_DISPLACED_MODIFIED_INSNS.
2876         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2877         (aarch64_displaced_step_copy_insn): Likewise.
2878         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2879         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2880         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2881         ARM_DISPLACED_MODIFIED_INSNS.
2882         * arm-tdep.c (arm_gdbarch_init): Likewise.
2883         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2884         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2885         (struct arm_displaced_step_closure): Use
2886         ARM_DISPLACED_MODIFIED_INSNS.
2887
2888 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2889
2890         * features/Makefile: Remove unused xml files.
2891         * features/aarch64.xml: Remove.
2892         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2893         * features/i386/amd64-avx-avx512.xml: Remove.
2894         * features/i386/amd64-avx-linux.xml: Remove.
2895         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2896         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2897         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2898         * features/i386/amd64-avx-mpx.xml: Remove.
2899         * features/i386/amd64-avx.xml: Remove.
2900         * features/i386/amd64-linux.xml: Remove.
2901         * features/i386/amd64-mpx-linux.xml: Remove.
2902         * features/i386/amd64-mpx.xml: Remove.
2903         * features/i386/amd64.xml: Remove.
2904         * features/i386/i386-avx-avx512-linux.xml: Remove.
2905         * features/i386/i386-avx-avx512.xml: Remove.
2906         * features/i386/i386-avx-linux.xml: Remove.
2907         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2908         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2909         * features/i386/i386-avx-mpx-linux.xml: Remove.
2910         * features/i386/i386-avx-mpx.xml: Remove.
2911         * features/i386/i386-avx.xml: Remove.
2912         * features/i386/i386-linux.xml: Remove.
2913         * features/i386/i386-mmx-linux.xml: Remove.
2914         * features/i386/i386-mmx.xml: Remove.
2915         * features/i386/i386-mpx-linux.xml: Remove.
2916         * features/i386/i386-mpx.xml: Remove.
2917         * features/i386/i386.xml: Remove.
2918         * features/i386/x32-avx-avx512-linux.xml: Remove.
2919         * features/i386/x32-avx-linux.xml: Remove.
2920         * features/i386/x32-linux.xml: Remove.
2921
2922 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2923
2924         * regformats/aarch64.dat: Remove.
2925         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2926         * regformats/i386/amd64-avx-linux.dat: Remove.
2927         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2928         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2929         * regformats/i386/amd64-linux.dat: Remove.
2930         * regformats/i386/amd64-mpx-linux.dat: Remove.
2931         * regformats/i386/amd64.dat: Remove.
2932         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2933         * regformats/i386/i386-avx-linux.dat: Remove.
2934         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2935         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2936         * regformats/i386/i386-linux.dat: Remove.
2937         * regformats/i386/i386-mmx-linux.dat: Remove.
2938         * regformats/i386/i386-mpx-linux.dat: Remove.
2939         * regformats/i386/i386.dat: Remove.
2940         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2941         * regformats/i386/x32-avx-linux.dat: Remove.
2942         * regformats/i386/x32-linux.dat: Remove.
2943
2944 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2945
2946         * aarch64-tdep.c: Remove xml self tests.
2947         * amd64-linux-tdep.c: Likewise.
2948         * amd64-tdep.c: Likewise.
2949         * i386-linux-tdep.c: Likewise.
2950         * i386-tdep.c: Likewise.
2951
2952 2019-07-03  Pedro Alves  <palves@redhat.com>
2953
2954         PR cli/24732
2955         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2956         (pipe_cmd_option_defs): New.
2957         (make_pipe_cmd_options_def_group): New.
2958         (pipe_command): Use gdb::option::process_options.
2959         (pipe_command_completer): New function.
2960         (_initialize_cli_cmds): Install completer for "pipe" command.
2961
2962 2019-07-03  Pedro Alves  <palves@redhat.com>
2963
2964         * cli/cli-option.c (union option_value) <string>: New field.
2965         (struct option_def_and_value): Add ctor, move ctor, dtor and
2966         use DISABLE_COPY_AND_ASSIGN.
2967         (option_def_and_value::clear_value): New.
2968         (parse_option, save_option_value_in_ctx, get_val_type_str)
2969         (add_setshow_cmds_for_options): Handle var_string.
2970         * cli-option.h (union option_def::var_address) <string>: New
2971         field.
2972         (struct string_option_def): New.
2973         * maint-test-options.c (struct test_options_opts): Add default
2974         ctor and use DISABLE_COPY_AND_ASSIGN.
2975         <string_opt>: New field.
2976         (test_options_opts::~test_options_opts): New.
2977         (test_options_opts::dump): Also dump "-string".
2978         (test_options_option_defs): Install "string.
2979
2980 2019-07-03  Pedro Alves  <palves@redhat.com>
2981
2982         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2983         option_value with a null enumeration.
2984         (complete_options): Save the option values in the context.
2985         (save_option_value_in_ctx): New, factored out from ...
2986         (process_options): ... here.
2987         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2988         of the function.
2989         * maint-test-options.c (test_options_opts::dump): New, factored
2990         out from ...
2991         (maintenance_test_options_command_mode): ... here.
2992         (maintenance_test_options_command_completion_result): Delete.
2993         (maintenance_test_options_command_completion_text): Update
2994         comment.
2995         (maintenance_show_test_options_completion_result): Change
2996         prototype.  Just print
2997         maintenance_test_options_command_completion_text.
2998         (save_completion_result): New.
2999         (maintenance_test_options_completer_mode): Pass options context to
3000         complete_options, and then save a dump.
3001         (_initialize_maint_test_options): Use add_cmd to install "maint
3002         show test-options-completion-result".
3003
3004 2019-07-03  Pedro Alves  <palves@redhat.com>
3005
3006         * NEWS (New commands): Mention "with" and "maint with".
3007         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3008         (with_command, with_command_completer): New.
3009         (pipe_command): Adjust to new repeat_previous
3010         interface.
3011         (_initialize_cli_cmds): Install the "with" command and its "w"
3012         alias.
3013         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3014         declarations.
3015         * cli/cli-setshow.c (parse_cli_var_uinteger)
3016         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3017         argument strings for all var_types.
3018         (get_setshow_command_value_string): New, factored out from ...
3019         (do_show_command): ... this.
3020         * cli/cli-setshow.h: Include <string>.
3021         (get_setshow_command_value_string): Declare.
3022         * command.h (repeat_previous): Now returns const char *.  Adjust
3023         comment.
3024         * maint.c: Include "cli/cli-cmds.h".
3025         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3026         (_initialize_maint_cmds): Register the "maintenance with" command.
3027         * top.c (repeat_previous): Move bits from pipe_command here:
3028         Return the saved command line, if any; error out if there's no
3029         command to relaunch.
3030
3031 2019-07-03  Pedro Alves  <palves@redhat.com>
3032
3033         * NEWS (New commands): Mention "maint set/show test-settings"
3034         instead of "maint test-settings".
3035         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3036         (maintenance_test_settings_set_list): Rename to ...
3037         (maintenance_set_test_settings_list): ... this.
3038         (maintenance_test_settings_show_list): Rename to  ...
3039         (maintenance_show_test_settings_list): ... this.
3040         (maintenance_test_settings_cmd): Delete.
3041         (maintenance_test_settings_set_cmd): ...
3042         (maintenance_set_test_settings_cmd): ... this.
3043         (maintenance_test_settings_show_cmd): ...
3044         (maintenance_show_test_settings_cmd): ... this.
3045         (maintenance_test_settings_show_value_cmd):
3046         (maintenance_show_test_settings_value_cmd): ... this.
3047         (_initialize_maint_test_settings): No longer install the "maint
3048         test-settings" prefix command.  Rename "maint test-settings set"
3049         to "maint set test-settings", and "maint test-settings show" to
3050         "maint show test-settings".  Adjust all subcommands.
3051
3052 2019-07-03  Pedro Alves  <palves@redhat.com>
3053
3054         * maint-test-settings.c: Fix file's intro comment.  Replace all
3055         references to "test-options" with references to "test-settings",
3056         in comments.
3057
3058 2019-07-03  Pedro Alves  <palves@redhat.com>
3059
3060         * maint-test-settings.c (maintenance_test_settings_xxx)
3061         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3062         New.
3063         (maintenance_test_settings_enums): Use them.
3064         (maintenance_test_settings_enum): Default to
3065         maintenance_test_settings_xxx.
3066         (_initialize_maint_test_settings): Initialize
3067         MAINTENANCE_TEST_SETTINGS_FILENAME.
3068
3069 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3070
3071         * breakpoint.h (remove_breakpoints_inf): Change return type to
3072         void, move function documentation here.
3073         * breakpoint.c (remove_breakpoints_inf): Change return type to
3074         void, move function documentation to header.
3075
3076 2019-07-02  Pedro Alves  <palves@redhat.com>
3077
3078         * NEWS (Completion improvements): Mention "info threads".
3079         * thread.c (struct info_threads_opts, info_threads_option_defs)
3080         (make_info_threads_options_def_group): New.
3081         (info_threads_command): Use gdb::option::process_options.
3082         (info_threads_command_completer): New.
3083         (_initialize_thread): Use gdb::option::build_help to build the
3084         help text for "info threads".
3085
3086 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3087
3088         * defs.h (generic_load): Move from here...
3089         * symfile.h (generic_load): ... to here.  Rename name parameter
3090         to args.
3091         * symfile.c (generic_load): Add comment.
3092
3093 2019-07-01  Tom Tromey  <tromey@adacore.com>
3094
3095         * dwarf2read.c
3096         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3097         declaration of without_params.  Fix formatting.
3098
3099 2019-07-01  Tom Tromey  <tromey@adacore.com>
3100
3101         * ada-exp.y (find_primitive_type): Update.
3102         * ada-lang.h (ada_lookup_symbol): Update.
3103         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3104         parameter.
3105         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3106
3107 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3108
3109         PR breakpoints/24541
3110         * gdbarch.c: Regenerate.
3111         * gdbarch.h: Regenerate.
3112         * gdbarch.sh: Add 'stap_adjust_register'.
3113         * i386-tdep.c: Include '<unordered_set>'.
3114         (i386_stap_adjust_register): New function.
3115         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3116         * stap-probe.c (stap_parse_register_operand): Call
3117         'gdbarch_stap_adjust_register'.
3118
3119 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3120
3121         PR python/24742
3122         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3123         * python/python.c (do_start_initialization): Use 'xmalloc'
3124         instead of 'PyMem_Malloc'.
3125
3126 2019-06-28  Tom Tromey  <tromey@adacore.com>
3127
3128         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3129         for Ada.
3130
3131 2019-06-27  Tom Tromey  <tromey@adacore.com>
3132
3133         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3134         objfile_key.
3135         (arm_find_mapping_symbol, arm_record_special_symbol)
3136         (_initialize_arm_tdep): Update.
3137         (arm_objfile_data_free): Remove.
3138
3139 2019-06-27  Tom Tromey  <tromey@adacore.com>
3140
3141         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3142         to cp_print_static_field.
3143
3144 2019-06-26  Tom Tromey  <tromey@adacore.com>
3145
3146         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3147         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3148         declare.
3149
3150 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3151
3152         * features/aarch64-core.c (create_feature_aarch64_core):
3153         Regenerate.
3154         * features/aarch64-core.xml: Add cpsr flags.
3155
3156 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3157
3158         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3159         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3160
3161 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3162
3163         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3164         field.
3165         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3166         use.
3167         (arm_record_special_symbol): Don't insert new symbol in sorted
3168         position, push it at the end.
3169
3170 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3171
3172         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3173         (arm_mapping_symbol_s): Remove.
3174         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3175         (arm_mapping_symbol_vec): New typedef.
3176         (struct arm_per_objfile): Add constructor.
3177         <section_maps>: Change type to
3178         std::unique_ptr<arm_mapping_symbol_vec[]>.
3179         (arm_compare_mapping_symbols): Remove.
3180         (arm_find_mapping_symbol): Adjust to section_maps type change.
3181         (arm_objfile_data_free): Call delete on arm_per_objfile.
3182         (arm_record_special_symbol): Adjust to section_maps type change.
3183         Allocate arm_per_objfile with new.
3184
3185 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3186
3187         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3188         with the command prefix.
3189
3190 2019-06-25  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3193         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3194
3195 2019-06-25  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3198         type.
3199         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3200         protected.
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-winsource.c
3205         (tui_source_window_base::set_is_exec_point_at): Add check against
3206         LOA_ADDRESS.
3207
3208 2019-06-25  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-source.c (tui_set_source_content): Don't check before
3211         xfree.
3212         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3213
3214 2019-06-25  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-winsource.h (tui_update_source_window_as_is)
3217         (tui_alloc_source_buffer, tui_line_is_displayed)
3218         (tui_addr_is_displayed): Change type of win_info.
3219         * tui/tui-winsource.c (tui_update_source_window_as_is)
3220         (tui_clear_source_content, tui_show_source_line)
3221         (tui_show_source_content, tui_source_window_base::refill)
3222         (tui_source_window_base::set_is_exec_point_at)
3223         (tui_source_window_base::set_is_exec_point_at)
3224         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3225         (tui_alloc_source_buffer, tui_line_is_displayed)
3226         (tui_addr_is_displayed): Change type of win_info.  Update.
3227         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3228         (tui_source_window_base::do_make_visible_with_new_height):
3229         Update.
3230         * tui/tui-source.c (tui_set_source_content)
3231         (tui_set_source_content_nil)
3232         (tui_source_window::do_scroll_vertical): Update.
3233         * tui/tui-layout.c (show_layout): Update.
3234         * tui/tui-disasm.c (tui_set_disassem_content)
3235         (tui_disasm_window::do_scroll_vertical): Update.
3236         * tui/tui-data.h (tui_win_content): Remove.
3237         (struct tui_gen_win_info) <content, content_size>: Remove.
3238         (struct tui_source_element): Add initializers and destructor.
3239         (union tui_which_element, struct tui_win_element): Remove.
3240         (struct tui_source_window_base) <content>: New field.
3241         (struct tui_data_window): Remove destructor.
3242         (tui_alloc_content, tui_free_win_content)
3243         (tui_free_all_source_wins_content): Don't declare.
3244         * tui/tui-data.c (tui_initialize_static_data): Update.
3245         (init_content_element, tui_alloc_content): Remove.
3246         (~tui_gen_win_info): Update.
3247         (~tui_data_window, tui_free_all_source_wins_content)
3248         (tui_free_win_content, free_content, free_content_elements):
3249         Remove.
3250
3251 2019-06-25  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-winsource.h (tui_clear_source_content)
3254         (tui_erase_source_content, tui_show_source_content): Change type
3255         of win_info.
3256         * tui/tui-winsource.c (tui_clear_source_content)
3257         (tui_erase_source_content, tui_show_source_content): Change type
3258         of win_info.
3259         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3260         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3261         win_info.
3262         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3263         win_info.
3264         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3265
3266 2019-06-25  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-winsource.c (tui_clear_source_content)
3269         (tui_source_window_base::set_is_exec_point_at): Update.
3270         * tui/tui-source.c (tui_set_source_content_nil): Update.
3271         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3272         a bool.
3273         * tui/tui-data.c (init_content_element): Update.
3274
3275 2019-06-25  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3278         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3279         * tui/tui-layout.c (init_and_make_win): Update.
3280         * tui/tui.h (enum tui_win_type): Update.
3281         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3282         tui_win_is_auxillary.
3283         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3284         tui_win_is_auxillary.
3285
3286 2019-06-25  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3289         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3290         (tui_delete_data_content_windows, tui_display_all_data)
3291         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3292         Update.
3293         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3294         * tui/tui-regs.c (tui_last_regs_line_no)
3295         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3296         (tui_show_registers): Update.
3297         (tui_show_register_group): Return void.  Update.
3298         (tui_display_registers_from, tui_display_reg_element_at_line)
3299         (tui_display_registers_from_line, tui_check_register_values):
3300         Update.
3301         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3302         member.
3303         (struct tui_data_window) <regs_content>: Now a std::vector.
3304         <regs_content_count>: Remove.
3305         (tui_add_content_elements, tui_free_data_content): Don't declare.
3306         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3307         (init_content_element): Remove DATA_WIN case.  Add assert.
3308         (tui_add_content_elements): Remove.
3309         (tui_data_window): Update.
3310         (tui_free_data_content): Remove.
3311         (free_content_elements): Remove DATA_WIN case.
3312
3313 2019-06-25  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-data.c (tui_data_item_window): Update.
3316         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3317         * tui/tui-windata.c (tui_display_all_data)
3318         (tui_display_data_from_line): Update.
3319         (tui_check_data_values): Remove.
3320         * tui/tui-regs.c (tui_show_register_group)
3321         (tui_display_reg_element_at_line): Update.
3322         * tui/tui-hooks.c (tui_register_changed)
3323         (tui_refresh_frame_and_register_information): Call
3324         tui_check_register_values.
3325         * tui/tui-data.h (struct tui_data_window) <data_content,
3326         data_content_count, data_type>: Remove.
3327         (enum tui_data_type): Remove.
3328
3329         * tui/tui-data.c (tui_data_window::clear_detail)
3330         (~tui_data_window): Update.
3331
3332 2019-06-25  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3335         declare.
3336         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3337         Rename from tui_first_data_item_displayed.  Update.
3338         (tui_data_window::refresh_all)
3339         (tui_data_window::do_scroll_vertical): Update.
3340         * tui/tui-data.h (struct tui_data_window)
3341         <first_data_item_displayed>: Declare new method.
3342
3343 2019-06-25  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3346         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3347         contents...
3348         (tui_initialize_static_data): ...here.
3349
3350 2019-06-25  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3353         (tui_display_registers_from, tui_check_register_values): Update.
3354         (tui_display_register): Remove win_info parameter; update.
3355         (tui_get_register): Change type of parameters.
3356         * tui/tui-data.h (struct tui_data_element): Remove.
3357         (union tui_which_element) <data>: Remove.
3358         <data_window>: Change type.
3359         (struct tui_data_item_window): New.
3360         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3361         case.  Add assert.
3362         (~tui_data_item_window): New destructor.
3363         (free_content_elements): Remove DATA_ITEM_WIN case.
3364
3365 2019-06-25  Tom Tromey  <tom@tromey.com>
3366
3367         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3368         Remove.
3369
3370 2019-06-25  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-data.h (struct tui_command_element): Remove.
3373         (union tui_which_element) <command>: Remove.
3374         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3375         assert.
3376         (free_content_elements): Remove CMD_WIN case.
3377
3378 2019-06-25  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui-layout.c (tui_set_layout): Update.
3381         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3382         * tui/tui-data.c (layout_def): Update.
3383
3384 2019-06-25  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3387         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3388         (tui_source_window_base::set_new_height): Update.
3389         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3390         Update.
3391         (tui_set_locator_fullname, tui_set_locator_info)
3392         (tui_show_frame_info): Update.
3393         * tui/tui-source.c (tui_set_source_content)
3394         (tui_source_is_displayed): Update.
3395         * tui/tui-layout.c (show_source_disasm_command, show_data)
3396         (show_source_or_disasm_and_command): Update.
3397         * tui/tui-disasm.c (tui_set_disassem_content)
3398         (tui_get_begin_asm_address): Update.
3399         * tui/tui-data.h (struct tui_locator_element): Remove.
3400         (union tui_which_element) <locator>: Remove.
3401         (struct tui_locator_window): New.
3402         (tui_locator_win_info_ptr): Change return type.
3403         * tui/tui-data.c (_locator): Change type.
3404         (tui_locator_win_info_ptr): Change return type.
3405         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3406         (tui_alloc_content): Add assert.
3407
3408 2019-06-25  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-winsource.c
3411         (tui_exec_info_window::maybe_allocate_content): New method.
3412         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3413         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3414         (make_source_or_disasm_window): Add cast.
3415         * tui/tui-data.h (union tui_which_element) <simple_string>:
3416         Remove.
3417         (struct tui_source_info): New.
3418         (struct tui_source_window_base) <execution_info>: Change type.
3419         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3420         case, and add assert.
3421         (tui_alloc_content): Add assert.
3422
3423 2019-06-25  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3426         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3427         * tui/tui-data.c (tui_alloc_win_info): Remove.
3428
3429 2019-06-25  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3432         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3433         can_highlight.
3434
3435 2019-06-25  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3438         make_visible_with_new_height method.
3439         (tui_win_info::make_visible_with_new_height): New method.
3440         (tui_source_window_base::do_make_visible_with_new_height)
3441         (tui_data_window::do_make_visible_with_new_height)
3442         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3443         (make_visible_with_new_height): Remove.
3444         (tui_resize_all, tui_adjust_win_heights): Use
3445         make_visible_with_new_height method.
3446         * tui/tui-data.h (struct tui_win_info)
3447         <do_make_visible_with_new_height, make_visible_with_new_height>:
3448         New methods.
3449         (struct tui_source_window_base, struct tui_data_window)
3450         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3451         methods.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3456         method.
3457         (update_tab_width): Call update_tab_width method.
3458         * tui/tui-data.h (struct tui_win_info)
3459         (struct tui_source_window_base) <update_tab_width>: New methods.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3464         parameter.
3465         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3466         parameter.
3467         (tui_gen_win_info::make_visible): Update.
3468         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3469         parameter.
3470         * tui/tui-data.h (enum tui_box): New enum.
3471         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3472
3473 2019-06-25  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3476         init_and_make_win for EXEC_INFO_WIN.
3477         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3478         longer inline.
3479         (struct tui_win_info) <~tui_win_info>: Inline.
3480         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3481         Don't declare.
3482         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3483         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3484         Remove.
3485         (tui_initialize_static_data): Update.
3486         (~tui_gen_win_info): Handle more cleanup here.
3487         (~tui_source_window_base): Delete "execution_info".
3488         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3489
3490 2019-06-25  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-layout.c (make_command_window): Don't set
3493         can_highlight.
3494         (show_source_disasm_command): Call the reset method.
3495         (show_data): Don't set can_highlight.  Call the reset method.
3496         (tui_gen_win_info::reset): Rename from init_gen_win_info
3497         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3498         (show_source_or_disasm_and_command): Call the reset method.
3499         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3500         (struct tui_cmd_window): Set can_highlight.
3501
3502 2019-06-25  Tom Tromey  <tom@tromey.com>
3503
3504         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3505         from make_visible.
3506         (tui_make_visible, tui_make_invisible): Rewrite.
3507         (tui_win_info::make_visible): Remove.
3508         (tui_source_window_base::make_visible): Update.
3509         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3510         method.  Moved from...
3511         (struct tui_win_info) <make_visible>: ...here.
3512
3513 2019-06-25  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-winsource.c
3516         (tui_source_window_base::do_scroll_horizontal): Remove direction
3517         parameter.
3518         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3519         direction parameter.
3520         * tui/tui-win.c (tui_win_info::forward_scroll)
3521         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3522         (tui_win_info::right_scroll): Update.
3523         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3524         direction parameter.
3525         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3526         direction parameter.
3527         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3528         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3529         Remove direction parameter.
3530         (struct tui_source_window_base, struct tui_source_window)
3531         (struct tui_disasm_window, struct tui_data_window)
3532         (struct tui_cmd_window): Update.
3533
3534 2019-06-25  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-winsource.h (tui_set_exec_info_content)
3537         (tui_show_exec_info_content, tui_erase_exec_info_content)
3538         (tui_clear_exec_info_content, tui_update_exec_info): Change
3539         argument to tui_source_window_base.
3540         * tui/tui-winsource.c (tui_set_exec_info_content)
3541         (tui_show_exec_info_content, tui_erase_exec_info_content)
3542         (tui_clear_exec_info_content, tui_update_exec_info): Change
3543         argument to tui_source_window_base.
3544
3545 2019-06-25  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3548         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3549
3550 2019-06-25  Tom Tromey  <tom@tromey.com>
3551
3552         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3553         check.
3554
3555 2019-06-25  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3558         type to void.
3559         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3560         type to void.
3561         * tui/tui-source.c (tui_set_source_content): Update.
3562         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3563
3564 2019-06-25  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-win.c (window_name_completer, tui_set_focus)
3567         (tui_all_windows_info): Use name method.
3568         * tui/tui-data.h (struct tui_gen_win_info)
3569         (struct tui_source_window, struct tui_disasm_window)
3570         (struct tui_data_window, struct tui_cmd_window) <name>: New
3571         method.
3572         (tui_win_name): Don't declare.
3573         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3574         (tui_win_name): Remove.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-winsource.h (tui_update_source_window)
3579         (tui_update_source_window_as_is): Change parameter type.
3580         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3581         to be a tui_source_window_base.
3582         (tui_update_source_window_as_is): Likewise.
3583         * tui/tui-win.c (make_visible_with_new_height): Update.
3584
3585 2019-06-25  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-winsource.c (tui_erase_source_content)
3588         (tui_show_source_content, tui_show_exec_info_content)
3589         (tui_erase_exec_info_content): Use refresh_window method.
3590         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3591         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3592         from tui_refresh_win.
3593         (tui_data_window::refresh_window): New method.
3594         (tui_win_info::refresh, tui_source_window_base::refresh)
3595         (tui_refresh_all): Use refresh_window method.
3596         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3597         method.
3598         * tui/tui-regs.c (tui_display_register): Call refresh_window
3599         method.
3600         * tui/tui-layout.c (show_source_disasm_command)
3601         (show_source_or_disasm_and_command): Call refresh_window method.
3602         * tui/tui-data.h (struct tui_gen_win_info)
3603         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3604         New method.
3605
3606 2019-06-25  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui.c (tui_rl_other_window, tui_enable)
3609         (tui_is_window_visible, tui_get_command_dimension): Update.
3610         * tui/tui-winsource.c (tui_update_source_window_as_is)
3611         (tui_clear_source_content, tui_erase_source_content)
3612         (tui_show_source_line, tui_source_window_base::refill)
3613         (tui_source_window_base::do_scroll_horizontal)
3614         (tui_source_window_base::set_is_exec_point_at)
3615         (tui_update_breakpoint_info, tui_set_exec_info_content)
3616         (tui_alloc_source_buffer, tui_line_is_displayed)
3617         (tui_addr_is_displayed): Update.
3618         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3619         (tui_check_and_display_highlight_if_needed)
3620         (tui_win_info::make_visible, tui_win_info::refresh)
3621         (tui_refresh_all): Update.
3622         * tui/tui-windata.c (tui_first_data_item_displayed)
3623         (tui_delete_data_content_windows, tui_erase_data_content)
3624         (tui_display_all_data, tui_data_window::refresh_all)
3625         (tui_check_data_values): Update.
3626         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3627         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3628         (tui_win_info::backward_scroll, tui_refresh_all_win)
3629         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3630         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3631         (tui_source_window_base::set_new_height)
3632         (tui_data_window::set_new_height)
3633         (make_invisible_and_set_new_height)
3634         (make_visible_with_new_height, new_height_ok)
3635         (parse_scrolling_args): Update.
3636         * tui/tui-stack.c (tui_show_frame_info): Update.
3637         * tui/tui-source.c (tui_set_source_content)
3638         (tui_set_source_content_nil, tui_source_is_displayed)
3639         (tui_source_window::do_scroll_vertical): Update.
3640         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3641         (tui_display_registers_from, tui_display_reg_element_at_line)
3642         (tui_check_register_values, tui_reg_command): Update.
3643         * tui/tui-layout.c (tui_default_win_height)
3644         (show_source_disasm_command, show_data, init_and_make_win)
3645         (show_source_or_disasm_and_command): Update.
3646         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3647         (tui_redisplay_readline, tui_mld_flush)
3648         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3649         (tui_getc): Update.
3650         * tui/tui-disasm.c (tui_set_disassem_content)
3651         (tui_disasm_window::do_scroll_vertical): Update.
3652         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3653         Now virtual.
3654         (struct tui_win_info): Derive from tui_gen_win_info.
3655         <~tui_win_info>: Mark as override.
3656         <generic>: Remove member.
3657         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3658         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3659         (~tui_data_window, ~tui_win_info)
3660         (tui_free_all_source_wins_content): Update.
3661         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-layout.c (init_and_make_win): Use new.
3666         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3667         destructor, initializers.
3668         (tui_alloc_generic_win_info): Don't declare.
3669         * tui/tui-data.c (_locator): Add argument to constructor.
3670         (source_win, disasm_win): New globals.
3671         (exec_info): Remove.
3672         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3673         Update.
3674         (tui_alloc_generic_win_info): Remove.
3675         (init_content_element): Use new.
3676         (tui_win_info::tui_win_info): Update.
3677         (free_content_elements) <case DATA_WIN>: Use delete.
3678
3679 2019-06-25  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3682         * tui/tui-windata.c (tui_first_data_item_displayed)
3683         (tui_delete_data_content_windows): Update.
3684         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3685         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3686         (tui_display_registers_from, tui_check_register_values): Update.
3687         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3688         pointer.
3689         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3690         window.
3691         (tui_free_data_content): Update.
3692         (free_content_elements) <case DATA_WIN>: Free the window.
3693
3694 2019-06-25  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3697         Update.
3698         * tui/tui-layout.c (make_command_window)
3699         (show_source_disasm_command, show_data, init_and_make_win)
3700         (show_source_or_disasm_and_command): Update.
3701         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3702         method.
3703         <can_highight, is_highlighted>: Now bool.
3704         (tui_set_win_highlight): Don't declare.
3705         * tui/tui-data.c (tui_set_win_highlight): Remove.
3706
3707 2019-06-25  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-wingeneral.c (make_visible): Remove check of window
3710         type.
3711
3712 2019-06-25  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-win.c (tui_win_info::max_height)
3715         (tui_cmd_window::max_height): New methods.
3716         (new_height_ok): Call max_height.
3717         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3718         <max_height>: New method.
3719
3720 2019-06-25  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-win.c (tui_source_window_base::set_new_height)
3723         (tui_data_window::set_new_height): New methods.
3724         (make_invisible_and_set_new_height): Call set_new_height method.
3725         * tui/tui-data.h (struct tui_win_info)
3726         (struct tui_source_window_base, struct tui_data_window)
3727         <set_new_height>: New method.
3728
3729 2019-06-25  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3732         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3733         tui_refresh_data_win.
3734         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3735         method.
3736         (tui_refresh_all_win): Call the refresh_all method.
3737         (tui_set_focus): Likewise.
3738         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3739         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3740         Likewise.
3741
3742 2019-06-25  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-winsource.h (tui_refill_source_window)
3745         (tui_set_is_exec_point_at): Don't declare.
3746         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3747         (tui_source_window_base::refill): Rename from
3748         tui_refill_source_window.
3749         (tui_source_window_base::do_scroll_horizontal): Update.
3750         (tui_source_window_base::set_is_exec_point_at): Rename from
3751         tui_set_is_exec_point_at.
3752         (tui_update_all_breakpoint_info): Update.
3753         * tui/tui-stack.c (tui_show_frame_info): Update.
3754         * tui/tui-layout.c (show_data): Add cast.
3755         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3756         * tui/tui-data.h (struct tui_source_window_base) <refill,
3757         set_is_exec_point_at>: New methods.
3758         (tui_source_windows, tui_add_to_source_windows): Update types.
3759         (tui_add_to_source_windows): Remove redundant declaration.
3760         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3761         (tui_source_windows): Change return type.
3762         (tui_clear_source_windows_detail): Update.
3763         (tui_add_to_source_windows): Change type of parameter.
3764         (tui_free_all_source_wins_content): Update.
3765
3766 2019-06-25  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui-wingeneral.c (tui_win_info::refresh)
3769         (tui_source_window_base::refresh): New methods.
3770         (tui_refresh_all): Call the refresh method.
3771         * tui/tui-data.h (struct tui_win_info)
3772         (struct tui_source_window_base) <refresh>: New method.
3773
3774 2019-06-25  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui.h (tui_is_window_visible): Return bool.
3777         * tui/tui.c (tui_is_window_visible): Return bool.
3778         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3779         (tui_make_visible, tui_make_invisible)
3780         (tui_win_info::make_visible)
3781         (tui_source_window_base::make_visible, make_all_visible)
3782         (tui_make_all_visible, tui_make_all_invisible): Update.
3783         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3784         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3785         bool.
3786         (struct tui_win_info, struct tui_source_window_base)
3787         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3788         * tui/tui-data.c (tui_init_generic_part): Update.
3789
3790 2019-06-25  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3793         (tui_source_window_base::make_visible): New methods.
3794         (make_all_visible): Make method call.
3795         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3796         (struct tui_source_window_base, struct tui_cmd_window): Override
3797         make_visible.
3798         (tui_win_is_source_type): Don't declare.
3799         * tui/tui-data.c (tui_win_is_source_type): Remove.
3800
3801 2019-06-25  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3804         NULL check.
3805
3806 2019-06-25  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3809         Inline constructor.  Add initializers for members.
3810         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3811         constructors; now inline in class.
3812
3813 2019-06-25  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-regs.c (tui_show_registers): Update.
3816         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3817         bool.
3818         * tui/tui-data.c (tui_data_window::clear_detail)
3819         (tui_data_window): Update.
3820
3821 2019-06-25  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-windata.c (tui_display_all_data)
3824         (tui_display_data_from_line, tui_display_data_from)
3825         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3826         Update.
3827         * tui/tui-regs.c (tui_last_regs_line_no)
3828         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3829         (tui_show_registers, tui_show_register_group)
3830         (tui_display_registers_from, tui_display_reg_element_at_line)
3831         (tui_display_registers_from_line, tui_check_register_values)
3832         (tui_reg_next, tui_reg_prev): Update.
3833         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3834         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3835         tui_data_window.
3836         (struct tui_win_info) <detail>: Remove.  Add new fields from
3837         tui_data_info.
3838         (TUI_DATA_WIN): Add cast.
3839         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3840         (~tui_data_window): Simplify.
3841
3842 2019-06-25  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-layout.c (show_source_disasm_command)
3845         (show_source_or_disasm_and_command): Update.
3846         * tui/tui-io.c (update_cmdwin_start_line)
3847         (tui_redisplay_readline): Update.
3848         * tui/tui-data.h (struct tui_command_info): Remove.
3849         (struct tui_win_info) <detail>: Remove command_info member.
3850         (struct tui_data_window) <start_line>: New member, from
3851         tui_command_info.
3852         (TUI_CMD_WIN): Add casts.
3853
3854 2019-06-25  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-winsource.c (tui_update_source_window)
3857         (tui_refill_source_window)
3858         (tui_source_window_base::do_scroll_horizontal)
3859         (tui_update_breakpoint_info, tui_set_exec_info_content)
3860         (tui_show_exec_info_content, tui_erase_exec_info_content)
3861         (tui_clear_exec_info_content): Update.
3862         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3863         Update.
3864         * tui/tui-win.c (make_invisible_and_set_new_height)
3865         (make_visible_with_new_height): Update.
3866         * tui/tui-source.c (tui_set_source_content)
3867         (tui_show_symtab_source): Update.
3868         * tui/tui-layout.c (extract_display_start_addr)
3869         (show_source_disasm_command, show_data)
3870         (make_source_or_disasm_window)
3871         (show_source_or_disasm_and_command): Update.
3872         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3873         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3874         "gdbarch".
3875         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3876         to tui_source_window_base.
3877         (struct tui_win_info) <detail>: Remove source_info member.
3878         (struct tui_source_window_base) <has_locator>: Inline.
3879         Move contents from tui_source_info; rename has_locator member to
3880         m_has_locator.
3881         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3882         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3883         header file.
3884         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3885         Simplify.
3886         (tui_free_all_source_wins_content): Cast to
3887         tui_source_window_base.
3888
3889 2019-06-25  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-win.c (make_invisible_and_set_new_height)
3892         (make_visible_with_new_height): Call has_locator method.
3893         * tui/tui-layout.c (show_source_disasm_command, show_data)
3894         (show_source_or_disasm_and_command): Update for bool change.
3895         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3896         (tui_win_info) <has_locator>: New method.
3897         (struct tui_source_window_base) <has_locator>: New method.
3898         (tui_win_has_locator): Don't declare.
3899         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3900         from tui_win_has_locator.
3901         (tui_source_window_base): Use false, not FALSE.
3902
3903 2019-06-25  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3906         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3907         clear_detail method directly.
3908         (tui_clear_win_detail): Remove.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3913         "this", not TUI_DISASM_WIN.
3914
3915 2019-06-25  Tom Tromey  <tom@tromey.com>
3916
3917         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3918         declare.
3919         * tui/tui-winsource.c
3920         (tui_source_window_base::do_scroll_horizontal): Rename from
3921         tui_horizontal_source_scroll.
3922         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3923         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3924         from tui_vertical_data_scroll.
3925         * tui/tui-win.h (tui_scroll): Don't declare.
3926         * tui/tui-win.c (tui_win_info::forward_scroll)
3927         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3928         (tui_win_info::right_scroll): Rename and update.
3929         (tui_scroll_forward_command, tui_scroll_backward_command)
3930         (tui_scroll_left_command, tui_scroll_right_command): Update.
3931         (tui_scroll): Remove.
3932         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3933         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3934         from tui_vertical_source_scroll.
3935         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3936         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3937         from tui_vertical_disassem_scroll.
3938         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3939         do_scroll_horizontal>: New methods.
3940         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3941         Likewise.
3942         (struct tui_source_window_base): Add do_scroll_horizontal.
3943         (struct tui_source_window, struct tui_disasm_window): Add
3944         do_scroll_vertical.
3945         (struct tui_data_window, struct tui_cmd_window): Add
3946         do_scroll_horizontal and do_scroll_vertical.
3947         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3948
3949 2019-06-25  Tom Tromey  <tom@tromey.com>
3950
3951         * tui/tui-data.h (struct tui_source_window_base): New struct.
3952         (struct tui_source_window): Derive from tui_source_window_base.
3953         (struct tui_disasm_window): New struct.
3954         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3955         from tui_source_window::clear_detail.
3956         (tui_source_window_base): Rename from tui_source_window.
3957         (~tui_source_window_base): Rename from ~tui_source_window.
3958         (tui_alloc_win_info): Create a tui_disasm_window.
3959
3960 2019-06-25  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-data.h (struct tui_source_window)
3963         (struct tui_data_window): Declare destructors.
3964         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3965         destructors.
3966         (tui_win_info): Simplify.
3967
3968 2019-06-25  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-winsource.c (tui_display_main)
3971         (tui_update_source_windows_with_addr)
3972         (tui_update_all_breakpoint_info): Update.
3973         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3974         (new_height_ok, parse_scrolling_args): Update.
3975         * tui/tui-stack.c (tui_show_frame_info): Update.
3976         * tui/tui-data.h (struct tui_list): Remove.
3977         (tui_source_windows): Return a reference to a std::vector.
3978         * tui/tui-data.c (source_windows): Now a std::vector.
3979         (tui_source_windows): Change return type.
3980         (tui_clear_source_windows): Rewrite.
3981         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3982         (tui_free_all_source_wins_content): Rewrite.
3983
3984 2019-06-25  Tom Tromey  <tom@tromey.com>
3985
3986         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3987         (struct tui_data_window, struct tui_cmd_window): Declare
3988         clear_detail method.
3989         * tui/tui-data.c (tui_source_window::clear_detail)
3990         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3991         methods.
3992         (tui_clear_win_detail): Simplify.
3993
3994 2019-06-25  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-layout.c (make_source_window, make_disasm_window)
3997         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3998         Return the new window.
3999         (show_source_disasm_command, show_data)
4000         (show_source_or_disasm_and_command): Update.
4001
4002 2019-06-25  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4005         parameter.  Return the new window.
4006         (show_source_disasm_command): Update and remove NULL check.
4007         (show_source_or_disasm_and_command): Update.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4012
4013 2019-06-25  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui-data.h (struct tui_win_info): Make constructor
4016         protected.  Make destructor virtual.  Add initializers.
4017         (tui_source_window, tui_data_window, tui_cmd_window): New
4018         classes.
4019         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4020         constructor.  Add "type" parameter.
4021         (tui_source_window, tui_data_window, tui_cmd_window): New
4022         constructors.
4023         (tui_alloc_win_info): Instantiate the appropriate subclass.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-win.c (tui_resize_all): Use delete.
4028         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4029         destructor.
4030         (tui_free_window): Don't declare.
4031         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4032         Update.
4033
4034 2019-06-25  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-data.h (struct tui_win_info): Add constructor.
4037         * tui/tui-data.c (tui_alloc_win_info): Use new.
4038         (tui_free_window): Use delete.
4039
4040 2019-06-22  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4043         declare.
4044         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4045
4046 2019-06-22  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4049         declare.
4050         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4051
4052 2019-06-22  Tom de Vries  <tdevries@suse.de>
4053
4054         * dwarf2read.c (create_addrmap_from_aranges)
4055         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4056         instead of '%zu'.
4057
4058 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4059
4060         * dwarf2read.h (dwarf2_section_info_def): Remove.
4061         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4062         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4063         std::vector<dwarf2_section_info>.
4064         (struct dwo_file) <~dwo_file>: Remove.
4065         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4066         types field.
4067         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4068         (dwarf2_read_debug_names): Likewise.
4069         (create_debug_types_hash_table): Change parameter type to
4070         array_view, adjust code accordingly.
4071         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4072         (partial_die_info::fixup): Likewise.
4073         (determine_prefix): Likewise.
4074         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4075
4076 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4077
4078         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4079         gdb_bfd_ref_ptr.
4080         <~dwo_file>: Remove call to gdb_bfd_unref.
4081         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4082         gdb_bfd_ref_ptr::get.
4083
4084 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4085
4086         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4087         type to htab_up.
4088         * dwarf2read.c (struct dwo_file): Initialize fields.
4089         <~dwo_file>: New.
4090         (free_dwo_file): Remove, move content to ~dwo_file.
4091         (struct dwo_file_deleter): Remove.
4092         (dwo_file_up>: Remove custom deleter.
4093         (free_dwo_files): Remove.
4094         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4095         dwo_files.
4096         (process_skeletonless_type_units): Call unique_ptr::get.
4097         (allocate_dwo_file_hash_table): Add deleter to created hash
4098         table.  Change return type to htab_up.
4099         (lookup_dwo_file_slot): Don't memset dwo_file, call
4100         unique_ptr::get.
4101         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4102         (create_dwo_unit_in_dwp_v2): Likewise.
4103         (open_and_init_dwo_file): Likewise.
4104         (free_dwo_file_from_slot): Remove.
4105
4106 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4107
4108         * dwarf2read.h (struct dwarf2_section_info) <readin,
4109         is_virtual>: Change type to bool.
4110         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4111         true instead of 1.
4112
4113 2019-06-19  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui-data.h (tui_init_content_element): Don't declare.
4116
4117 2019-06-19  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-data.h (tui_init_win_info): Don't declare.
4120
4121 2019-06-19  Tom de Vries  <tdevries@suse.de>
4122
4123         * dwarf2read.h (abstract_to_concrete): Change type to
4124         std::unordered_map<sect_offset, std::vector<sect_offset>,
4125         gdb::hash_enum<sect_offset>>.
4126
4127 2019-06-19  Tom Tromey  <tromey@adacore.com>
4128
4129         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4130         EVAL_AVOID_SIDE_EFFECTS specially.
4131
4132 2019-06-19  Tom Tromey  <tromey@adacore.com>
4133
4134         * source-cache.c (highlighter): New global.
4135         (source_cache::get_source_lines): Create a highlighter on demand.
4136
4137 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * defs.h (deprecated_interactive_hook): Delete declaration.
4140         * interps.c (clear_interpreter_hooks): Remove use of
4141         deprecated_interactive_hook.
4142         * top.c (deprecated_interactive_hook): Delete definition.
4143         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4144
4145 2019-06-18  Tom de Vries  <tdevries@suse.de>
4146
4147         PR gdb/24515
4148         * dwarf2read.h (abstract_to_concrete): Change type from
4149         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4150         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4151         * dwarf2read.c (read_variable): Update.
4152         (dwarf2_fetch_die_loc_sect_off): Update.
4153
4154 2019-06-17  Tom de Vries  <tdevries@suse.de>
4155
4156         PR gdb/24617
4157         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4158         accessing parent[parent_len - 1].
4159
4160 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4161
4162         PR gdb/24364
4163         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4164         call dtrace_process_dof with NULL dof.
4165
4166 2019-06-16  Tom de Vries  <tdevries@suse.de>
4167
4168         PR gdb/24445
4169         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4170
4171 2019-06-16  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4174         (make_all_visible): Use address of member.
4175
4176 2019-06-16  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4179         (tui_free_window, free_content, free_content_elements): Remove
4180         unnecessary cast.
4181         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4182         cast.
4183         * tui/tui-regs.c (tui_show_register_group)
4184         (tui_display_registers_from, tui_display_reg_element_at_line):
4185         Remove unnecessary cast.
4186
4187 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * linux-nat.c (normal_mask): Delete.
4190         (_initialize_linux_nat): Don't initialise normal_mask.
4191
4192 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4193
4194         PR gdb/24445
4195         * dwarf-index-write.h (write_psymtabs_to_index): Add
4196         dwz_basename parameter.
4197         * dwarf-index-write.c (write_gdbindex): Move file writing to
4198         write_gdbindex_1.  Change return type void.
4199         (assert_file_size): Move up, remove filename parameter.
4200         (write_gdbindex_1): New function.
4201         (write_debug_names): Change return type to void, call
4202         assert_file_size.
4203         (struct index_wip_file): New struct.
4204         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4205         file logic to index_wip_file.  Write index for dwz file if
4206         needed.
4207         (save_gdb_index_command): Pass basename of dwz file, if present.
4208         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4209         build-id of dwz file, if present.
4210         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4211         (dwarf2_get_dwz_file): Likewise.
4212         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4213         (dwarf2_get_dwz_file): Likewise.
4214
4215 2019-06-16  Tom Tromey  <tom@tromey.com>
4216
4217         * coffread.c (process_coff_symbol): Use xstrdup.
4218         * value.c (create_internalvar): Use xstrdup.
4219
4220 2019-06-16  Tom Tromey  <tom@tromey.com>
4221
4222         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4223         * breakpoint.c (stopin_command, stopat_command)
4224         (until_break_command, decode_location_default): Remove unnecessary
4225         cast.
4226         * utils.c (subset_compare): Remove unnecessary cast.
4227         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4228         cast.
4229         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4230         cast.
4231         * infcmd.c (path_command): Remove unnecessary cast.
4232         * coffread.c (decode_type): Remove unnecessary cast.
4233         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4234         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4235         * tui/tui-stack.c (tui_show_locator_content)
4236         (tui_show_frame_info): Remove unnecessary cast.
4237         * tui/tui-win.c (tui_scroll_forward_command)
4238         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4239         (parse_scrolling_args): Remove unnecessary cast.
4240         * tui/tui-data.c (init_win_info, tui_del_window)
4241         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4242         (free_content_elements): Remove unnecessary cast.
4243         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4244         unnecessary cast.
4245         * tui/tui-source.c (tui_set_source_content)
4246         (tui_vertical_source_scroll): Remove unnecessary cast.
4247         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4248         cast.
4249         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4250         * tui/tui-regs.c (tui_display_registers_from)
4251         (tui_display_register): Remove unnecessary cast.
4252         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4253         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4254         (make_visible): Remove unnecessary cast.
4255         * tui/tui-winsource.c (tui_erase_source_content)
4256         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4257         unnecessary cast.
4258         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4259         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4260         * stabsread.c (read_type, read_array_type, read_range_type):
4261         Remove unnecessary cast.
4262         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4263         (parse_symbol, parse_type, upgrade_type, parse_external)
4264         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4265         unnecessary cast.
4266         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4267
4268 2019-06-16  Tom Tromey  <tom@tromey.com>
4269
4270         * tui/tui-data.c (tui_alloc_generic_win_info)
4271         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4272         checks.
4273
4274 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4275             Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * f-typeprint.c (f_print_type): Don't return early for not
4278         associated or not allocated types.
4279         (f_type_print_varspec_suffix): Add print_rank parameter and print
4280         ranks of array types in case they dangling.
4281         (f_type_print_base): Add print_rank parameter.
4282
4283 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * NEWS: Mention new MI commands.
4286         * break-catch-throw.c (enum exception_event_kind): Move to
4287         breakpoint.h.
4288         (print_mention_exception_catchpoint): Output text as a single
4289         message.
4290         (catch_exception_command_1): Rename to...
4291         (catch_exception_event): ...this, make non-static, update header
4292         command, and change some parameter types.
4293         (catch_catch_command): Update for changes to
4294         catch_exception_command_1.
4295         (catch_throw_command): Likewise.
4296         (catch_rethrow_command): Likewise.
4297         * breakpoint.c (enum exception_event_kind): Delete.
4298         * breakpoint.h (enum exception_event_kind): Moved here from
4299         break-catch-throw.c.
4300         (catch_exception_event): Declare.
4301         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4302         (mi_cmd_catch_throw): New function.
4303         (mi_cmd_catch_rethrow): New function.
4304         (mi_cmd_catch_catch): New function.
4305         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4306         'catch-catch' entries.
4307         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4308         (mi_cmd_catch_rethrow): Declare.
4309         (mi_cmd_catch_catch): Declare.
4310
4311 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * annotate.c (annotate_source_line): Change return type to void,
4314         update implementation to match.
4315         * annotate.h (annotate_source_line): Change return type to void,
4316         update header comment.
4317         * stack.c (print_frame_info): Don't change what frame information
4318         is printed based on whether annotations are on or not.
4319
4320 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4323         (annotate_source): Make static.
4324         (annotate_source_line): Moved from source.c and renamed from
4325         identify_source_line.  Update the return type.
4326         * annotate.h (annotate_source): Delete declaration.
4327         (annotate_source_line): Declaration moved from source.h, and
4328         renamed from identify_source_line.  Return type updated.
4329         * source.c (identify_source_line): Moved to annotate.c and renamed
4330         to annotate_source_line.
4331         (info_line_command): Remove check of annotation_level.
4332         * source.h (identify_source_line): Move declaration to annotate.h
4333         and rename to annotate_source_line.
4334         * stack.c: Add 'annotate.h' include.
4335         (print_frame_info): Remove check of annotation_level before
4336         calling annotate_source_line.
4337
4338 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * source-cache.c (source_cache::get_plain_source_lines): Use
4341         open_source_file_with_line_charpos instead of just
4342         open_source_file, remove call to find_source_lines.
4343         (source_cache::get_source_lines): Likewise.
4344         * source.c (find_source_lines): Make static.
4345         (get_filename_and_charpos): Renamed into...
4346         (open_source_file_with_line_charpos): ..this along with changes to
4347         return a scoped_fd, and some other minor clean ups.
4348         (identify_source_line): Use open_source_file_with_line_charpos.
4349         (search_command_helper): Use open_source_file_with_line_charpos
4350         instead of just open_source_file, remove call to
4351         find_source_lines.
4352         * source.h (open_source_file_with_line_charpos): Declare new
4353         function.
4354         (find_source_lines): Delete declaration.
4355
4356 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4357
4358         * source.c (get_filename_and_charpos): Remove fullname
4359         parameter.
4360         (identify_source_line): Update call to get_filename_and_charpos.
4361
4362 2019-06-14  Tom Tromey  <tromey@adacore.com>
4363
4364         PR gdb/24502:
4365         * ui-style.h (skip_ansi_escape): Update comment.
4366         * ui-file.h (class no_terminal_escape_file): New class.
4367         * ui-file.c (no_terminal_escape_file::write)
4368         (no_terminal_escape_file::puts): New methods.
4369         * cli/cli-logging.c (handle_redirections): Use
4370         no_terminal_escape_file.
4371
4372 2019-06-14  Tom Tromey  <tromey@adacore.com>
4373
4374         * NEWS: Move convenience variable news above Python news.
4375
4376 2019-06-14  Tom Tromey  <tom@tromey.com>
4377
4378         * gnulib: Move directory to top-level.
4379         * configure.ac: Don't configure gnulib.
4380         * configure: Rebuild.
4381         * common/common-defs.h: Use new path to gnulib.
4382         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4383         (GNULIB_H): Remove.
4384         (INCGNU): Look in new gnulib location.
4385         (HFILES_NO_SRCDIR): Remove gnulib files.
4386         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4387         (generated_files): Remove GNULIB_H.
4388         ($(LIBGNU), all-lib): Remove targets.
4389         (distclean): Don't mention GNULIB_BUILDDIR.
4390         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4391
4392 2019-06-14  Tom Tromey  <tromey@adacore.com>
4393
4394         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4395         Warn if symbol file does not provide any symbols.
4396
4397 2019-06-14  Tom Tromey  <tromey@adacore.com>
4398
4399         * source.c (find_and_open_source): Respect basenames_may_differ.
4400
4401 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * annotate.c (annotate_breakpoints_invalid): Make use of
4404         scoped_restore_terminal_state.
4405         (annotate_frames_invalid): Likewise.
4406
4407 2019-06-14  Tom Tromey  <tromey@adacore.com>
4408
4409         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4410         allow assignment to an internalvar.
4411
4412 2019-06-14  Tom Tromey  <tromey@adacore.com>
4413
4414         * ada-lex.l: Allow "_" in attribute names.
4415
4416 2019-06-14  Tom Tromey  <tromey@adacore.com>
4417
4418         PR gdb/24653:
4419         * regcache.c (registers_changed): Don't call alloca.
4420         * top.c (execute_command): Don't call alloca.
4421
4422 2019-06-13  Pedro Alves  <palves@redhat.com>
4423
4424         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4425         'expression'.  When parsing an expression, error out if there's
4426         junk after "unlimited".
4427         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4428         (do_set_command): Adjust calls to is_unlimited_literal.
4429
4430 2019-06-13  Pedro Alves  <palves@redhat.com>
4431
4432         * compile/compile.c (make_compile_options_def_group): Add braces
4433         around array_view initializer.
4434         * thread.c (make_thread_apply_all_options_def_group)
4435         (make_thread_apply_all_options_def_group): Likewise.
4436
4437 2019-06-13  Pedro Alves  <palves@redhat.com>
4438
4439         * NEWS (New commands): Mention "maint test-options
4440         require-delimiter", "maint test-options unknown-is-error", "maint
4441         test-options unknown-is-operand" and "maint show
4442         test-options-completion-result".
4443         (New command options, command completion): New section.
4444         (Completion improvements): New section.
4445         Mention that you can abbreviate "unlimited".
4446
4447 2019-06-13  Pedro Alves  <palves@redhat.com>
4448
4449         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4450         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4451         * unittests/cli-utils-selftests.c (test_parse_flags)
4452         (test_parse_flags_qcs): Delete.
4453         (test_cli_utils): Don't call deleted functions.
4454
4455 2019-06-13  Pedro Alves  <palves@redhat.com>
4456
4457         * thread.c: Include "cli/cli-option.h".
4458         (tp_array_compar_ascending): Global.
4459         (tp_array_compar): Delete function.
4460         (tp_array_compar_ascending, tp_array_compar_descending): New
4461         functions.
4462         (ascending_option_def, qcs_flag_option_def)
4463         (thr_qcs_flags_option_defs)
4464         (make_thread_apply_all_options_def_group)
4465         (make_thread_apply_options_def_group): New.
4466         (thread_apply_all_command): Use gdb::option::process_options.
4467         (thread_apply_command_completer)
4468         (thread_apply_all_command_completer): New.
4469         (thread_apply_command): Use gdb::option::process_options.
4470         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4471         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4472         to generate help text of "thread apply".  Adjust "taas"'s help.
4473         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4474         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4475
4476 2019-06-13  Pedro Alves  <palves@redhat.com>
4477
4478         * thread.c (thread_apply_command): Check for invalid TID with
4479         isdigit instead of !isalpha.
4480
4481 2019-06-13  Pedro Alves  <palves@redhat.com>
4482
4483         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4484         (validate_flags_qcs): New.
4485         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4486         (validate_flags_qcs): Declare.
4487         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4488         (make_frame_apply_options_def_group): New.
4489         (frame_apply_command_count): Process options with
4490         gdb::option::process_options.
4491         (frame_apply_completer): New.
4492         (frame_apply_level_completer, frame_apply_all_completer)
4493         (frame_apply_completer): New.
4494         (_initialize_stack): Update help of "frame apply", "frame apply
4495         level", "frame apply all" and "faas" to mention supported options
4496         and install command completers.
4497         * stack.h (frame_apply_all_completer): Declare.
4498         * thread.c: Include "stack.h".
4499         (tfaas_command): Add "--".
4500         (_initialize_thread): Update help "tfaas" to mention supported
4501         options and install command completer.
4502
4503 2019-06-13  Pedro Alves  <palves@redhat.com>
4504
4505         * completer.c (complete_nested_command_line): New.
4506         (gdb_completion_word_break_characters_throw): Add assertion.
4507         * completer.h (complete_nested_command_line): Declare.
4508
4509 2019-06-13  Pedro Alves  <palves@redhat.com>
4510
4511         * stack.c (parse_backtrace_qualifiers): New.
4512         (backtrace_command): Use it.
4513         (backtrace_command_completer): Complete on qualifiers.
4514
4515 2019-06-13  Pedro Alves  <palves@redhat.com>
4516
4517         * frame.c: Include "cli/cli-option.h.
4518         (user_set_backtrace_options): New.
4519         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4520         Delete.
4521         (get_prev_frame): Adjust.
4522         (boolean_option_def, uinteger_option_def)
4523         (set_backtrace_option_defs): New.
4524         (_initialize_frame): Adjust and use
4525         gdb::option::add_setshow_cmds_for_options to install "set
4526         backtrace past-main" and "set backtrace past-entry".
4527         * frame.h: Include "cli/cli-option.h".
4528         (struct frame_print_options): Forward declare.
4529         (print_frame_arguments_all, print_frame_arguments_scalars)
4530         (print_frame_arguments_none): Declare.
4531         (print_entry_values): Delete declaration.
4532         (struct frame_print_options, user_frame_print_options): New.
4533         (struct set_backtrace_options): New.
4534         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4535         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4536         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4537         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4538         (list_args_or_locals): Add frame_print_options parameter.
4539         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4540         * python/py-framefilter.c (enumerate_args): Pass down
4541         USER_FRAME_PRINT_OPTIONS.
4542         * stack.c: Include "cli/cli-option.h".
4543         (print_frame_arguments_all, print_frame_arguments_scalars)
4544         (print_frame_arguments_none): Declare.
4545         (print_raw_frame_arguments, print_entry_values): Delete.
4546         (user_frame_print_options): New.
4547         (boolean_option_def, enum_option_def, frame_print_option_defs):
4548         New.
4549         (struct backtrace_cmd_options): New.
4550         (bt_flag_option_def): New.
4551         (backtrace_command_option_defs): New.
4552         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4553         (print_frame_arg, read_frame_arg, print_frame_args)
4554         (print_frame_info, print_frame): Add frame_print_options parameter
4555         and use it.
4556         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4557         (backtrace_command_1): Add frame_print_options and
4558         backtrace_cmd_options parameters and use them.
4559         (make_backtrace_options_def_group): New.
4560         (backtrace_command): Process command options with
4561         gdb::option::process_options.
4562         (backtrace_command_completer): New.
4563         (_initialize_stack): Extend "backtrace"'s help to mention
4564         supported options.  Install completer for "backtrace".
4565         Install some settings commands with add_setshow_cmds_for_options.
4566
4567 2019-06-13  Pedro Alves  <palves@redhat.com>
4568
4569         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4570         and that "set/show print raw frame-arguments" are now deprecated.
4571
4572         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4573         command.
4574         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4575         * stack.c (_initialize_stack): Install "set/show print
4576         raw-frame-arguments", and deprecate "set/show print raw
4577         frame-arguments".
4578         * valprint.c (_initialize_valprint): Deprecate "set/show print
4579         raw".
4580
4581 2019-06-13  Pedro Alves  <palves@redhat.com>
4582
4583         * compile/compile.c (struct compile_options): New.
4584         (compile_flag_option_def, compile_command_option_defs)
4585         (make_compile_options_def_group): New.
4586         (compile_file_command): Handle options with
4587         gdb::option::process_options.
4588         (compile_file_command_completer): New function.
4589         (compile_code_command): Handle options with
4590         gdb::option::process_options.
4591         (compile_code_command_completer): New function.
4592         (_initialize_compiler): Install completers for "compile code" and
4593         "compile file".  Mention available options in "compile code" and
4594         "compile code"'s help.
4595         * completer.c (advance_to_completion_word): New, factored out from
4596         ...
4597         (advance_to_expression_complete_word_point): ... this.
4598         (advance_to_filename_complete_word_point): New.
4599         * completer.h (advance_to_filename_complete_word_point): New
4600         declaration.
4601
4602 2019-06-13  Pedro Alves  <palves@redhat.com>
4603
4604         * compile/compile.c: Include "cli/cli-option.h".
4605         (compile_print_value): Scope data pointer is now a
4606         value_print_options pointer; adjust.
4607         (compile_print_command): Process options.  Scope data pointer is
4608         now a value_print_options pointer; adjust.
4609         (_initialize_compile): Update "compile print"'s help to include
4610         supported options.  Install a completer for "compile print".
4611         * cp-valprint.c (show_vtblprint, show_objectprint)
4612         (show_static_field_print): Delete.
4613         (_initialize_cp_valprint): Don't install "set print
4614         static-members", "set print vtbl", "set print object" here.
4615         * printcmd.c: Include "cli/cli-option.h" and
4616         "common/gdb_optional.h".
4617         (print_command_parse_format): Rework to fill in a
4618         value_print_options instead of a format_data.
4619         (print_value): Change parameter type from format_data pointer to
4620         value_print_options reference.  Adjust.
4621         (print_command_1): Process options.  Adjust to pass down a
4622         value_print_options.
4623         (print_command_completer): New.
4624         (_initialize_printcmd): Install print_command_completer as
4625         handle_brkchars completer for the "print" command.  Update
4626         "print"'s help to include supported options.
4627         * valprint.c: Include "cli/cli-option.h".
4628         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4629         here from cp-valprint.c.
4630         (boolean_option_def, uinteger_option_def)
4631         (value_print_option_defs, make_value_print_options_def_group):
4632         New.  Use gdb::option::add_setshow_cmds_for_options to install
4633         "set print elements", "set print null-stop", "set print repeats",
4634         "set print pretty", "set print union", "set print array", "set
4635         print address", "set print symbol", "set print array-indexes".
4636         * valprint.h: Include <string> and "cli/cli-option.h".
4637         (make_value_print_options_def_group): Declare.
4638         (print_value): Change parameter type from format_data pointer to
4639         value_print_options reference.
4640         (print_command_completer): Declare.
4641
4642 2019-06-13  Pedro Alves  <palves@redhat.com>
4643
4644         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4645         (COMMON_SFILES): Add maint-test-settings.c.
4646         * cli/cli-decode.c (boolean_enums): New global, factored out from
4647         ...
4648         (add_setshow_boolean_cmd): ... here.
4649         * cli/cli-decode.h (boolean_enums): Declare.
4650         * cli/cli-option.c: New file.
4651         * cli/cli-option.h: New file.
4652         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4653         factored out from ...
4654         (parse_cli_boolean_value(const char *)): ... this.
4655         (is_unlimited_literal): Change parameter type to pointer to
4656         pointer.  Adjust and advance ARG pointer.
4657         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4658         (parse_cli_var_enum): New, factored out from ...
4659         (do_set_command): ... this.  Adjust.
4660         * cli/cli-setshow.h (parse_cli_boolean_value)
4661         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4662         (parse_cli_var_enum): Declare.
4663         * cli/cli-utils.c: Include "cli/cli-option.h".
4664         (get_ulongest): New.
4665         * cli/cli-utils.h (get_ulongest): Declare.
4666         (check_for_argument): New overloads.
4667         * maint-test-options.c: New file.
4668
4669 2019-06-13  Pedro Alves  <palves@redhat.com>
4670
4671         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4672         parse a range if "-" is at the end of the string.
4673
4674 2019-06-13  Pedro Alves  <palves@redhat.com>
4675
4676         * cli/cli-setshow.c (parse_auto_binary_operation)
4677         (parse_cli_boolean_value): Don't allow "o".
4678
4679 2019-06-13  Pedro Alves  <palves@redhat.com>
4680
4681         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4682         * NEWS: Mention maint test-settings KIND.
4683         * maint-test-settings.c: New file.
4684
4685 2019-06-13  Pedro Alves  <palves@redhat.com>
4686
4687         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4688         completer.
4689         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4690         "set" completers.
4691
4692 2019-06-13  Pedro Alves  <palves@redhat.com>
4693
4694         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4695         after item.
4696
4697 2019-06-13  Pedro Alves  <palves@redhat.com>
4698
4699         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4700
4701 2019-06-13  Pedro Alves <palves@redhat.com>
4702
4703         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4704         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4705         call.
4706         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4707         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4708         calls.
4709         (check_for_argument): Skip spaces after argument.
4710
4711 2019-06-13  Pedro Alves  <palves@redhat.com>
4712
4713         * thread.c (thread_apply_command): Adjust TID parsing.
4714         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4715         detected before end of string.
4716         (tid_is_in_list): Error out if LIST is invalid.
4717
4718 2019-06-13  Pedro Alves  <palves@redhat.com>
4719
4720         * completer.c (complete_line_internal_1): Rewind completion word
4721         point.
4722         (completion_tracker::advance_custom_word_point_by): Change
4723         parameter type to int.
4724         * completer.h (completion_tracker::advance_custom_word_point_by):
4725         Likewise.
4726
4727 2019-06-13  Pedro Alves  <palves@redhat.com>
4728
4729         * completer.c (advance_to_completion_word): Handle delimiters.
4730
4731 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4732
4733         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4734
4735 2019-06-11  Tom Tromey  <tom@tromey.com>
4736
4737         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4738         (xmalloc_failed): Move to alloc.c.
4739         * alloc.c: New file.
4740         * Makefile.in (COMMON_SFILES): Add alloc.c.
4741
4742 2019-06-11  Tom Tromey  <tom@tromey.com>
4743
4744         * nat/linux-waitpid.c: Don't include server.h.
4745         (linux_debug): Remove.
4746         (my_waitpid): Update.
4747
4748 2019-06-11  Tom Tromey  <tromey@adacore.com>
4749
4750         * infcall.c (_initialize_infcall): Remove trailing newline from
4751         help.
4752         * user-regs.c (_initialize_user_regs): Remove trailing newline
4753         from help.
4754         * typeprint.c (_initialize_typeprint): Remove trailing newline
4755         from help.
4756         * reverse.c (_initialize_reverse): Remove trailing newlines from
4757         help.
4758         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4759         from help.
4760         * language.c (add_set_language_command): Remove trailing newline
4761         from help.
4762         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4763         help.
4764         * disasm.c (_initialize_disasm): Remove trailing newline from
4765         help.
4766         * top.c (init_main): Remove trailing newline from help.
4767         * interps.c (_initialize_interpreter): Remove trailing newline
4768         from help.
4769         * btrace.c (_initialize_btrace): Remove trailing newlines from
4770         help.
4771         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4772         from help.
4773         * python/python.c (_initialize_python): Remove trailing newline
4774         from help.
4775         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4776         help.
4777         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4778         from help.  Reformat some text.
4779         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4780         from help.
4781         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4782         newline from help.
4783
4784 2019-06-11  Tom Tromey  <tromey@adacore.com>
4785
4786         * darwin-nat.c (darwin_decode_exception_message)
4787         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4788
4789 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * valops.c (value_slice): Check for not allocated or not
4792         associated values.
4793
4794 2019-06-10  Tom de Vries  <tdevries@suse.de>
4795
4796         PR gdb/24618
4797         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4798         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4799         invalid.
4800
4801 2019-06-10  Tom de Vries  <tdevries@suse.de>
4802
4803         PR gdb/24611
4804         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4805         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4806
4807 2019-06-10  Tom de Vries  <tdevries@suse.de>
4808
4809         PR symtab/24545
4810         * symtab.c (struct demangled_name_entry): Add language field.
4811         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4812         static minimal symbol".  Set and use language field.
4813
4814 2019-06-10  Tom Tromey  <tromey@adacore.com>
4815
4816         * ada-lang.c (_initialize_ada_language): Update help text.
4817
4818 2019-06-10  Tom Tromey  <tromey@adacore.com>
4819
4820         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4821         with a newline.
4822         * guile/guile.c (handle_boot_error): Don't end warning with a
4823         newline.
4824         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4825         warning with a newline.
4826         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4827         newline.
4828         (s12z_frame_cache): Likewise.
4829         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4830         a newline.
4831         * solib-svr4.c (disable_probes_interface): Don't end warning with
4832         a newline.
4833         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4834         newline.
4835         * python/python.c (do_finish_initialization): Don't end warning
4836         with a newline.
4837
4838 2019-06-10  Tom Tromey  <tom@tromey.com>
4839
4840         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4841         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4842         gdbpy_enter.
4843
4844 2019-06-10  Tom Tromey  <tromey@adacore.com>
4845
4846         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4847         data.
4848         (elf_new_init): Don't call stabsread_new_init.
4849         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4850         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4851         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4852
4853 2019-06-10  Tom de Vries  <tdevries@suse.de>
4854
4855         PR symtab/16264
4856         PR symtab/24517
4857         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4858
4859 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4860
4861         * source.c (find_and_open_source): Also rewrite relative file
4862         names.
4863
4864 2019-04-26  Amos Bird  <amosbird@gmail.com>
4865
4866         * annotate.c (annotate_thread_exited): Add "thread-exited"
4867         annotation.
4868
4869 2019-06-06  Tom Tromey  <tromey@adacore.com>
4870
4871         * maint.h (class scoped_command_stats): Use
4872         DISABLE_COPY_AND_ASSIGN.
4873         <print_time>: New method.
4874         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4875         print_time.
4876         (scoped_command_stats::print_time): New method.
4877
4878 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4881         instructions of lengths 6 or 8 bytes.
4882
4883 2019-06-04  Pedro Alves  <palves@redhat.com>
4884
4885         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4886
4887         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4888         * breakpoint.c (condition_completer): Likewise.
4889         * cli/cli-dump.c (scan_expression): Likewise.
4890         * common/filestuff.c (mkdir_recursive): Likewise.
4891         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4892         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4893         (gdb_abspath): Likewise.
4894         * compile/compile-cplus-types.c
4895         (compile_cplus_instance::decl_name): Likewise.
4896         * completer.c (complete_explicit_location):
4897         (signal_completer, reg_or_group_completer_1): Likewise.
4898         * cp-support.c (cp_remove_params_if_any): Likewise.
4899         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4900         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4901         * infcmd.c (strip_bg_char): Likewise.
4902         * linespec.c (copy_token_string): Likewise.
4903         * mi/mi-main.c (output_cores): Likewise.
4904         * psymtab.c (psymtab_search_name):
4905         * symfile.c (test_set_ext_lang_command): Likewise.
4906         * target.c (target_fileio_read_stralloc): Likewise.
4907         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4908         * value.c (complete_internalvar): Likewise.
4909
4910 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4911
4912         Add objfile property to gdb.Type.
4913         * NEWS: Mention Python API addition.
4914         * python/py-type.c (typy_get_objfile): New method.
4915
4916 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4917
4918         * NEWS: Mention the new set|show style [title|highlight].
4919         Mention changes to "show style", "help" and "apropos".
4920
4921 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4922
4923         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4924         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4925         instead of print_help_for_command.
4926         (print_doc_of_command): New function.
4927         (help_list): Add 'apropos -v word' suggestion.
4928         (print_help_for_command): Style the command name using title style.
4929         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4930         (_initialize_cli_cmds): Describe -v in apropos_command help.
4931
4932 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4933
4934         * cli/cli-style.h (cli_style_option): Add name in constructor,
4935         add m_name class member, add constructor with intensity,
4936         add name class function.
4937         (cli_style_option::add_setshow_commands): Remove name argument.
4938         (highlight_style, title_style): New styles.
4939         * cli/cli-style.c (do_show): New function that shows a style
4940         characteristic styling the style name with itself.
4941         (set_style_name): New function.
4942         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4943         Update all callers according to the changes in cli/cli-style.h.
4944         * utils.h (fputs_highlighted): New function.
4945         * utils.c (fputs_highlighted): Likewise.
4946
4947 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4948
4949         * NEWS: Mention new pipe command and new convenience variables.
4950
4951 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4952
4953         * cli/cli-cmds.c (pipe_command): New function.
4954         (_initialize_cli_cmds): Call add_com for pipe_command.
4955         Define | as an alias for pipe.
4956         (exit_status_set_internal_vars): New function.
4957         (shell_escape): Call exit_status_set_internal_vars.
4958         cli/cli-decode.c (find_command_name_length): Recognize | as
4959         a single character command.
4960
4961 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4962
4963         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4964         top.c (execute_command_to_ui_file): New function, mostly a copy
4965         of execute_command_to_string.
4966         (execute_command_to_string): Implement by calling
4967         execute_command_to_ui_file.
4968
4969 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4970
4971         * top.h (saved_command_line): Remove declaration.
4972         * top.c (previous_saved_command_line, previous_repeat_arguments):
4973         New variables.
4974         (saved_command_line): Make static, define together with other
4975         'repeat variables'.
4976         (dont_repeat): Clear repeat_arguments.
4977         (repeat_previous, get_saved_command_line, save_command_line):
4978         New functions.
4979         (gdb_init): Initialize saved_command_line
4980         and previous_saved_command_line.
4981         * main.c (captured_main_1): Remove saved_command_line initialization.
4982         * event-top.c (handle_line_of_input): Update to use
4983         the new 'repeat' related functions instead of direct access to
4984         saved_command_line.
4985         * command.h (repeat_previous, get_saved_command_line,
4986         save_command_line): New declarations.
4987         (dont_repeat): Add comment.
4988
4989 2019-05-30  Tom Tromey  <tromey@adacore.com>
4990
4991         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4992         Fix comment.
4993         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4994
4995 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4996
4997         PR cli/24587
4998         * completer.c (complete): Initialize variable word.
4999
5000 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5001
5002         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5003         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5004         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5005         'body' is NULL to the outter 'if', protecting the '!is_define'
5006         situation as well.
5007
5008 2019-05-29  Tom Tromey  <tromey@adacore.com>
5009
5010         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5011         (dwarf_unknown): New function.
5012         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5013         (dwarf_type_encoding_name): Use dwarf_unknown.
5014
5015 2019-05-29  Tom Tromey  <tromey@adacore.com>
5016
5017         PR c++/20020:
5018         * cp-valprint.c (cp_print_value_fields): Call
5019         cp_print_static_field inside "try".
5020
5021 2019-05-29  Tom Tromey  <tromey@adacore.com>
5022
5023         * inflow.c (struct terminal_info): Add default operator=.
5024         * configure: Rebuild.
5025         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5026         -Wdeprecated-copy-dtor, -Wredundant-move.
5027
5028 2019-05-29  Tom Tromey  <tromey@adacore.com>
5029
5030         * NEWS: Add entry.
5031         * infcmd.c (print_return_value_1): Handle finish_print
5032         option.
5033         (show_print_finish): New function.
5034         (_initialize_infcmd): Add "set/show print finish" commands.
5035         * valprint.c (user_print_options): Initialize new member.
5036         * valprint.h (struct value_print_options) <finish_print>: New
5037         member.
5038
5039 2019-05-28  Tom Tromey  <tromey@adacore.com>
5040
5041         * ada-lang.c (ada_remove_Xbn_suffix)
5042         (find_old_style_renaming_symbol)
5043         (parse_old_style_renaming): Remove.
5044         (ada_find_renaming_symbol): Don't call
5045         find_old_style_renaming_symbol.
5046         (ada_is_renaming_symbol): Rename from
5047         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5048         bool.  Now static.
5049         (ada_read_var_value): Update and simplify.
5050         * ada-exp.y (write_var_or_type): Remove old code.
5051
5052 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5053
5054         * event-top.c: Remove include comment.
5055         * inflow.c (class scoped_ignore_sigttou): Move from here...
5056         * inflow.h (class scoped_ignore_sigttou): ...to here.
5057         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5058         * top.c:  Remove include comment.
5059
5060 2019-05-27  Tom Tromey  <tom@tromey.com>
5061
5062         * NEWS: Fix typo.
5063
5064 2019-05-22  Tom Tromey  <tromey@adacore.com>
5065
5066         * target.c (target_follow_exec): Constify parameter.
5067         * target-delegates.c: Rebuild.
5068         * remote.c (remote_target::follow_exec): Constify parameter.
5069         * infrun.c (follow_exec): Constify parameter.
5070         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5071         (target_follow_exec): Likewise.
5072
5073 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5074
5075         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5076         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5077
5078 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5079
5080         * NEWS: Add debugredirect and testsuite sections.
5081
5082 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5083
5084         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5085         target descriptions using exclusively floating point register name
5086         aliases.
5087
5088 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         PR gdb/18644:
5091         * f-lang.c (build_fortran_types): Handle the case where
5092         gdbarch_floatformat_for_type returns a nullptr.
5093
5094 2019-05-21  Tom de Vries  <tdevries@suse.de>
5095
5096         PR cli/24587
5097         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5098
5099 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5100
5101         PR gdb/18644:
5102         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5103         16-byte floats.
5104         * i386-tdep.c (i386_floatformat_for_type): Use
5105         floatformats_ia64_quad for the 16-byte floating point component
5106         within a fortran 32-byte complex number.
5107
5108 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5111         delete default constructor.
5112         (find_partial_die): Update to return const struct.
5113         (partial_die_parent_scope): Move variable declaration into scope
5114         of its use and change its type to auto.
5115         (guess_partial_die_structure_name): Likewise.
5116         (partial_die_info::fixup): Likewise.
5117
5118 2019-05-17  Tom Tromey  <tromey@adacore.com>
5119
5120         * source.c (find_and_open_source): Remove cast.
5121
5122 2019-05-17  Tom Tromey  <tromey@adacore.com>
5123
5124         * annotate.c (annotate_source): Make "filename" const.
5125         * annotate.h (annotate_source): Use const.
5126
5127 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5128
5129         * disasm.c (set_disassembler_options): Send errors to stderr.
5130
5131 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5132
5133         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5134         (cli_interp_base::set_logging): Check debug_redirect.
5135         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5136         * cli/cli-logging.c (debug_redirect): Add static variable.
5137         (pop_output_files): Add default param.
5138         (handle_redirections): Print debug setting.
5139         (show_logging_command): Likewise.
5140         (_initialize_cli_logging): Add debugredirect command.
5141         * interps.c (current_interp_set_logging): Add debug_redirect
5142         parameter.
5143         * interps.h (set_logging): Add debug_redirect parameter.
5144         (current_interp_set_logging): Likewise.
5145         * mi/mi-common.h: Likewise.
5146         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5147
5148 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5149             Tom Tromey  <tromey@adacore.com>
5150
5151         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5152         directly.
5153         * cli/cli-interp.h (make_logging_output): Remove declaration.
5154         * cli/cli-logging.c (make_logging_output): Remove function.
5155         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5156         directly.
5157         * ui-file.c (tee_file::tee_file): Remove bools.
5158         (tee_file::~tee_file): Remove deletes.
5159         * ui-file.h (tee_file): Remove bools.
5160
5161 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5162
5163         * mi/mi-cmds.h (mi_cmd_complete): New function.
5164         * mi/mi-main.c (mi_cmd_complete): Likewise.
5165         * mi/mi-cmds.c: Define new MI command -complete.
5166         * NEWS: Mention new -complete command.
5167
5168 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5169
5170         * completer.h (complete): New function.
5171         * completer.c (complete): Likewise.
5172         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5173         function defined in completer.h.
5174
5175 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5176
5177         * MAINTAINERS (Write After Approval): Add myself.
5178
5179 2019-05-17  Tom de Vries  <tdevries@suse.de>
5180
5181         PR gdb/24094
5182         * dwarf2read.c (struct cu_partial_die_info): New struct.
5183         (find_partial_die): Return cu_partial_die_info.
5184         (partial_die_parent_scope, guess_partial_die_structure_name)
5185         (partial_die_info::fixup): Handle new return type of find_partial_die.
5186
5187 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5188
5189         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5190         "std::string", simplifying the algorithm.
5191
5192 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5193
5194         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5195         (stap_static_probe_ops::get_probes): Likewise.
5196
5197 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5198
5199         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5200         '-')" and "else if".
5201         (stap_parse_single_operand): Join checks for
5202         "gdbarch_stap_parse_special_token_p" and
5203         "gdbarch_stap_parse_special_token" in the same "if" statement.
5204         Invert check when verifying for operation on register
5205         displacement.
5206
5207 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5208
5209         * stap-probe.c (stap_get_opcode): Update comment.
5210         (stap_get_expected_argument_type): Likewise.
5211         (handle_stap_probe): Likewise.
5212
5213 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5214
5215         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5216         return type to 'bool'.  Adjust comment.  Use 'bool' when
5217         appropriate.
5218         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5219         * stap-probe.c (stap_parse_argument_1): Likewise.
5220         (stap_is_operator): Likewise.
5221         (stap_is_generic_prefix): Likewise.
5222         (stap_is_register_prefix): Likewise.
5223         (stap_is_register_indirection_prefix): Likewise.
5224         (stap_is_integer_prefix): Likewise.
5225         (stap_generic_check_suffix): Likewise.
5226         (stap_check_integer_suffix): Likewise.
5227         (stap_check_register_suffix): Likewise.
5228         (stap_check_register_indirection_suffix): Likewise.
5229         (stap_parse_register_operand): Likewise.
5230         (stap_parse_single_operand): Likewise.
5231         (stap_parse_argument_1): Likewise.
5232         (stap_probe::get_argument_count): Likewise.
5233         (stap_is_operator): Likewise.
5234
5235 2019-05-16  Tom Tromey  <tromey@adacore.com>
5236
5237         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5238         keyword to foreach.
5239
5240 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5241
5242         * linux-thread-db.c (try_thread_db_load_1): Change return type
5243         to bool.
5244         (try_thread_db_load): Likewise.
5245         (try_thread_db_load_from_pdir_1): Likewise.
5246         (try_thread_db_load_from_pdir): Likewise.
5247         (try_thread_db_load_from_sdir): Likewise.
5248         (try_thread_db_load_from_dir): Likewise.
5249         (thread_db_load_search): Likewise.
5250         (has_libpthread): Likewise.
5251         (thread_db_load): Likewise.
5252
5253 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5254
5255         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5256         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5257         NULL, and complain/return if that's the case.
5258
5259 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5260
5261         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5262         (advance, posn, abstract_read_memory): New functions.
5263         [struct mem_read_abstraction]: New struct.
5264         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5265
5266 2019-05-14  Tom Tromey  <tromey@adacore.com>
5267
5268         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5269         value is not lval_memory.
5270
5271 2019-05-14  Tom Tromey  <tromey@adacore.com>
5272
5273         * solib.c (info_sharedlibrary_command): Style the file name.
5274
5275 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5276
5277         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5278         (aarch64_vnv_type): Likewise.
5279         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5280         * common/tdesc.c: Likewise.
5281         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5282         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5283         * features/aarch64-fpu.xml: Add ieee half view.
5284         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5285         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5286         * gdbtypes.h (struct builtin_type): Likewise.
5287         (struct objfile_type): Likewise.
5288
5289 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5290
5291         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5292         typo.
5293         * location.h (string_to_event_location): Likewise.
5294
5295 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5296
5297         GDB 8.3 released.
5298
5299 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5300
5301         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5302         New variable declaration.
5303         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5304         New variable.
5305         (print_one_breakpoint): Use ui_out::test_flags and new global
5306         variable to compute use_fixed_output.
5307         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5308         Remove.
5309         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5310         (mi_multi_location_breakpoint_output_fixed): Remove.
5311         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5312         new variable.
5313         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5314         fix_multi_location_breakpoint_output flag if version >= 3.
5315         * ui-out.h (enum ui_out_flag)
5316         <fix_multi_location_breakpoint_output>: New enumerator.
5317
5318 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5319
5320         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5321
5322 2019-05-10  Tom Tromey  <tromey@adacore.com>
5323
5324         * ada-lang.c (catch_ada_completer): New function.
5325         (_initialize_ada_language): Use it.
5326
5327 2019-05-10  Tom Tromey  <tromey@adacore.com>
5328
5329         * thread.c (print_thread_info): Make "requested_threads" const.
5330         * gdbthread.h (print_thread_info): Make "requested_threads"
5331         const.
5332         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5333         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5334
5335 2019-05-08  Tom Tromey  <tom@tromey.com>
5336
5337         * gdbtypes.c (objfile_type_data): Change type.
5338         (objfile_type, _initialize_gdbtypes): Update.
5339
5340 2019-05-08  Tom Tromey  <tom@tromey.com>
5341
5342         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5343         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5344         (_initialize_dwarf2_frame): Update.
5345
5346 2019-05-08  Tom Tromey  <tom@tromey.com>
5347
5348         * objc-lang.c (objc_objfile_data): Change type.
5349         (find_methods): Update.
5350         (_initialize_objc_lang): Remove.
5351
5352 2019-05-08  Tom Tromey  <tom@tromey.com>
5353
5354         * stabsread.c (rs6000_builtin_type_data): Change type.
5355         (rs6000_builtin_type, _initialize_stabsread): Update.
5356
5357 2019-05-08  Tom Tromey  <tom@tromey.com>
5358
5359         * mips-tdep.c (mips_pdr_data): Remove.
5360         (_initialize_mips_tdep): Update.
5361
5362 2019-05-08  Tom Tromey  <tom@tromey.com>
5363
5364         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5365         (hppa_init_objfile_priv_data, read_unwind_info)
5366         (find_unwind_entry, _initialize_hppa_tdep): Update.
5367
5368 2019-05-08  Tom Tromey  <tom@tromey.com>
5369
5370         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5371         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5372         on obstack.
5373         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5374
5375 2019-05-08  Tom Tromey  <tom@tromey.com>
5376
5377         * mdebugread.c (basic_type_data): Change type.
5378         (basic_type, _initialize_mdebugread): Update.
5379
5380 2019-05-08  Tom Tromey  <tom@tromey.com>
5381
5382         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5383
5384 2019-05-08  Tom Tromey  <tom@tromey.com>
5385
5386         * nto-tdep.c (nto_inferior_data_reg): Change type.
5387         (nto_inferior_data): Update.
5388         (nto_inferior_data_cleanup, nto_new_inferior_data)
5389         (_initialize_nto_tdep): Remove.
5390         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5391
5392 2019-05-08  Tom Tromey  <tom@tromey.com>
5393
5394         * ada-lang.c (struct ada_inferior_data): Add initializers.
5395         (ada_inferior_data): Change type.
5396         (ada_inferior_data_cleanup): Remove.
5397         (get_ada_inferior_data, ada_inferior_exit)
5398         (struct ada_pspace_data): Add initializers, destructor.
5399         (ada_pspace_data_handle): Change type.
5400         (get_ada_pspace_data): Update.
5401         (ada_pspace_data_cleanup): Remove.
5402
5403 2019-05-08  Tom Tromey  <tom@tromey.com>
5404
5405         * coffread.c (struct coff_symfile_info): Add initializers.
5406         (coff_objfile_data_key): Move lower.  Change type.
5407         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5408         Update.
5409         (coff_free_info): Remove.
5410
5411 2019-05-08  Tom Tromey  <tom@tromey.com>
5412
5413         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5414         (fbsd_pspace_data_handle): Move lower.  Change type.
5415         (get_fbsd_pspace_data): Update.
5416         (fbsd_pspace_data_cleanup): Remove.
5417         (_initialize_fbsd_tdep): Update.
5418
5419 2019-05-08  Tom Tromey  <tom@tromey.com>
5420
5421         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5422         (get_ada_tasks_pspace_data): Update.
5423         (ada_tasks_pspace_data_cleanup): Remove.
5424         (_initialize_tasks): Update.
5425         (ada_tasks_inferior_data_handle): Change type.
5426         (get_ada_tasks_inferior_data): Update.
5427         (ada_tasks_inferior_data_cleanup): Remove.
5428         (struct ada_tasks_pspace_data): Add initializers.
5429
5430 2019-05-08  Tom Tromey  <tom@tromey.com>
5431
5432         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5433         * symfile-debug.c (debug_sym_get_probes): Change type.
5434         * stap-probe.c (handle_stap_probe):
5435         (stap_static_probe_ops::get_probes): Change type.
5436         * probe.h (class static_probe_ops) <get_probes>: Change type.
5437         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5438         (parse_probes_in_pspace): Update.
5439         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5440         Update.
5441         (any_static_probe_ops::get_probes): Change type.
5442         * elfread.c (elfread_data): New typedef.
5443         (probe_key): Change type.
5444         (elf_get_probes): Likewise.  Update.
5445         (probe_key_free): Remove.
5446         (_initialize_elfread): Update.
5447         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5448         Change type.
5449         (dtrace_process_dof_probe, dtrace_process_dof)
5450         (dtrace_static_probe_ops::get_probe): Change type.
5451
5452 2019-05-08  Tom Tromey  <tom@tromey.com>
5453
5454         * xcoffread.c (struct xcoff_symfile_info): Rename from
5455         coff_symfile_info.  Add initializers.
5456         (xcoff_objfile_data_key): Move lower.  Change type.
5457         (XCOFF_DATA): Rewrite.
5458         (xcoff_free_info): Remove.
5459         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5460         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5461         (xcoff_initial_scan): Update.
5462
5463 2019-05-08  Tom Tromey  <tom@tromey.com>
5464
5465         * solib-svr4.c (struct svr4_info): Add initializers and
5466         destructor.
5467         <probes_table>: Now an htab_up.
5468         (solib_svr4_pspace_data): Change type.
5469         (free_probes_table): Simplify.
5470         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5471         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5472         (probes_table_remove_objfile_probes, register_solib_event_probe)
5473         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5474         (_initialize_svr4_solib): Update.
5475
5476 2019-05-08  Tom Tromey  <tom@tromey.com>
5477
5478         * remote.c (remote_pspace_data): Change type.
5479         (remote_pspace_data_cleanup): Remove.
5480         (get_remote_exec_file, set_pspace_remote_exec_file)
5481         (_initialize_remote): Update.
5482
5483 2019-05-08  Tom Tromey  <tom@tromey.com>
5484
5485         * breakpoint.c (breakpoint_objfile_key): Change type.
5486         (get_breakpoint_objfile_data): Update.
5487         (free_breakpoint_objfile_data): Remove.
5488         (_initialize_breakpoint): Update.
5489
5490 2019-05-08  Tom Tromey  <tom@tromey.com>
5491
5492         * linux-tdep.c (struct linux_info): Add initializers.
5493         (linux_inferior_data): Move.  Change type.
5494         (invalidate_linux_cache_inf): Update.
5495         (linux_inferior_data_cleanup): Remove.
5496         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5497
5498 2019-05-08  Tom Tromey  <tom@tromey.com>
5499
5500         * auxv.c (auxv_inferior_data): Move.  Change type.
5501         (auxv_inferior_data_cleanup): Remove.
5502         (invalidate_auxv_cache_inf): Rewrite.
5503         (get_auxv_inferior_data, _initialize_auxv): Update.
5504
5505 2019-05-08  Tom Tromey  <tom@tromey.com>
5506
5507         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5508         (symfile_debug_objfile_data_key): Change type.
5509         (symfile_debug_installed, debug_qf_has_symbols)
5510         (debug_qf_find_last_source_symtab)
5511         (debug_qf_forget_cached_source_info)
5512         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5513         (debug_qf_print_stats, debug_qf_dump)
5514         (debug_qf_expand_symtabs_for_function)
5515         (debug_qf_expand_all_symtabs)
5516         (debug_qf_expand_symtabs_with_fullname)
5517         (debug_qf_map_matching_symbols)
5518         (debug_qf_expand_symtabs_matching)
5519         (debug_qf_find_pc_sect_compunit_symtab)
5520         (debug_qf_map_symbol_filenames)
5521         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5522         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5523         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5524         (debug_sym_read_linetable, debug_sym_relocate): Update.
5525         (symfile_debug_free_objfile): Remove.
5526         (install_symfile_debug_logging, _initialize_symfile_debug):
5527         Update.
5528
5529 2019-05-08  Tom Tromey  <tom@tromey.com>
5530
5531         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5532         allocate_on_obstack.
5533         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5534         (get_dwarf2_per_objfile): Update.
5535         (set_dwarf2_per_objfile): Remove.
5536         (dwarf2_has_info, dwarf2_get_section_info): Update.
5537         (dwarf2_free_objfile): Remove.
5538         (_initialize_dwarf2_read): Update.
5539
5540 2019-05-08  Tom Tromey  <tom@tromey.com>
5541
5542         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5543         initializers.
5544         <unsupported_script_warning_printed,
5545         script_not_found_warning_printed>: Now bool.
5546         (auto_load_pspace_data): Change type.
5547         (~auto_load_pspace_info): Rename from
5548         auto_load_pspace_data_cleanup.
5549         (get_auto_load_pspace_data, init_loaded_scripts_info)
5550         (clear_section_scripts, maybe_print_unsupported_script_warning)
5551         (maybe_print_script_not_found_warning, _initialize_auto_load):
5552         Update.
5553
5554 2019-05-08  Tom Tromey  <tom@tromey.com>
5555
5556         * objfiles.c (objfile_pspace_info): Add destructor and
5557         initializers.
5558         (objfiles_pspace_data): Change type.
5559         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5560         (get_objfile_pspace_data): Update.
5561         (objfiles_bfd_data): Change type.
5562         (get_objfile_bfd_data): Update.
5563         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5564
5565 2019-05-08  Tom Tromey  <tom@tromey.com>
5566
5567         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5568         Change type.
5569         (get_catch_syscall_inferior_data): Update.
5570         (catch_syscall_inferior_data_cleanup): Remove.
5571         (_initialize_break_catch_syscall): Update.
5572
5573 2019-05-08  Tom Tromey  <tom@tromey.com>
5574
5575         * inflow.c (struct terminal_info): Add destructor and
5576         initializers.
5577         (inflow_inferior_data): Change type.
5578         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5579         (get_inflow_inferior_data, inflow_inferior_exit)
5580         (swap_terminal_info, _initialize_inflow): Update.
5581
5582 2019-05-08  Tom Tromey  <tom@tromey.com>
5583
5584         * target-dcache.c (target_dcache_cleanup): Remove.
5585         (target_dcache_aspace_key): Change type.
5586         (target_dcache_init_p, target_dcache_invalidate)
5587         (target_dcache_get, target_dcache_get_or_init)
5588         (_initialize_target_dcache): Update.
5589         * dcache.h (struct dcache_deleter): New.
5590
5591 2019-05-08  Tom Tromey  <tom@tromey.com>
5592
5593         * symtab.c (struct symbol_cache): Add destructor and
5594         initializers.
5595         (symbol_cache_key): Move.  Change type.
5596         (make_symbol_cache, free_symbol_cache): Remove.
5597         (get_symbol_cache): Update.
5598         (symbol_cache_cleanup): Remove.
5599         (ALL_PSPACES, symbol_cache_flush)
5600         (maintenance_print_symbol_cache)
5601         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5602         Update.
5603
5604 2019-05-08  Tom Tromey  <tom@tromey.com>
5605
5606         * symtab.c (struct main_info): Add destructor and initializers.
5607         (main_progspace_key): Move.  Change type.
5608         (get_main_info): Update.
5609         (main_info_cleanup): Remove.
5610         (_initialize_symtab): Update.
5611
5612 2019-05-08  Tom Tromey  <tom@tromey.com>
5613
5614         * registry.h (DECLARE_REGISTRY): Define the _key class.
5615
5616 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * NEWS: Merge two 'New commands' sections.
5619
5620 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5621
5622         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5623         parameter and use Ada language definition instead.
5624         (ada_val_print_ptr): Remove unused language parameter.
5625         (ada_val_print_num): Remove language parameter and use Ada language
5626         definition instead.
5627         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5628         parameter.
5629         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5630         parameter and use Ada language definition instead.
5631         (ada_val_print_1): Update all ada_val_print_xxx calls.
5632         Remove language parameter.
5633         (ada_val_print): Update ada_val_print_1 call.
5634
5635 2019-05-08  Tom Tromey  <tromey@adacore.com>
5636
5637         * remote.c (remote_hw_watchpoint_limit)
5638         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5639         Now static.
5640
5641 2019-05-08  Tom Tromey  <tromey@adacore.com>
5642
5643         * maint.c (_initialize_maint_cmds): Move initialization code to
5644         remote.c.
5645         (watchdog, show_watchdog): Move to remote.c.
5646         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5647         "watchdog" static.
5648         (_initialize_remote): Move initialization code from maint.c.
5649         * defs.h (watchdog): Don't declare.
5650
5651 2019-05-08  Tom Tromey  <tromey@adacore.com>
5652
5653         * tui/tui-interp.c: Include main.h.
5654         * interps.c: Include main.h.
5655         * main.h (interpreter_p): Declare.
5656         * defs.h (interpreter_p): Don't declare.
5657
5658 2019-05-08  Tom Tromey  <tromey@adacore.com>
5659
5660         * dwarf2loc.c: Include dwarf2read.h.
5661         * defs.h (read_unsigned_leb128): Don't declare.
5662         * dwarf2read.h (read_unsigned_leb128): Declare.
5663
5664 2019-05-08  Tom Tromey  <tromey@adacore.com>
5665
5666         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5667         method.
5668
5669 2019-05-08  Tom Tromey  <tromey@adacore.com>
5670
5671         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5672         when no wrap column is set.
5673
5674 2019-05-08  Tom Tromey  <tromey@adacore.com>
5675
5676         * c-lang.c (c_get_string): Handle non-C-style arrays.
5677
5678 2019-05-08  Tom Tromey  <tromey@adacore.com>
5679
5680         * typeprint.c (print_offset_data::update): Print the bit offset,
5681         not the number of bits remaining.
5682
5683 2019-05-08  Tom Tromey  <tromey@adacore.com>
5684
5685         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5686         padding at end of comment.
5687
5688 2019-05-08  Tom Tromey  <tromey@adacore.com>
5689
5690         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5691         Compare main types.
5692
5693 2019-05-06  Tom Tromey  <tom@tromey.com>
5694
5695         * common/scoped_mmap.c: Include common-defs.h.
5696         * common/scoped_mmap.h: Don't include config.h.
5697
5698 2019-05-04  Tom Tromey  <tom@tromey.com>
5699
5700         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5701         (struct aarch64_call_info): Add initializers.
5702         <si>: Now a std::vector.
5703         (pass_on_stack, aarch64_push_dummy_call): Update.
5704
5705 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5706             Tom Tromey  <tom@tromey.com>
5707
5708         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5709         (ppc_threads): Now a std::vector.  Now static.
5710         (hwdebug_find_thread_points_by_tid)
5711         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5712         Update.
5713
5714 2019-05-04  Tom Tromey  <tom@tromey.com>
5715
5716         * arc-tdep.c (arc_tdesc_init): Return bool.
5717
5718 2019-05-04  Tom Tromey  <tom@tromey.com>
5719
5720         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5721         Use gdb_assert_not_reached.
5722
5723 2019-05-04  Tom Tromey  <tom@tromey.com>
5724
5725         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5726         "false".
5727
5728 2019-05-04  Tom Tromey  <tom@tromey.com>
5729
5730         * arc-tdep.c (arc_tdesc_init): Use bool.
5731
5732 2019-05-04  Tom Tromey  <tom@tromey.com>
5733
5734         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5735
5736 2019-05-04  Tom Tromey  <tom@tromey.com>
5737
5738         * cli/cli-cmds.c (valid_command_p): Return bool.
5739
5740 2019-05-04  Tom Tromey  <tom@tromey.com>
5741
5742         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5743         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5744
5745 2019-05-04  Raul Tambre  <raul@tambre.ee>
5746
5747         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5748         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5749         operator for comparison.
5750
5751 2019-05-04  Tom Tromey  <tom@tromey.com>
5752
5753         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5754         (lookup_partial_symbol, print_partial_symbols)
5755         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5756         (psymbol_compare): Update.
5757         (add_psymbol_to_bcache): Clear the entire psymbol.
5758         (maintenance_check_psymtabs): Update.
5759         * psympriv.h (struct partial_symbol): Don't derive from
5760         general_symbol_info.
5761         <obj_section, unrelocated_address, address,
5762         set_unrelocated_address>: Update.
5763         <ginfo>: New member.
5764         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5765         (debug_names::write_psymbols): Update.
5766
5767 2019-05-04  Tom de Vries  <tdevries@suse.de>
5768
5769         * contrib/cc-with-tweaks.sh: Support -n arg.
5770
5771 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5772
5773         * corelow.c (core_target::detach): Ensure frame cache and
5774         register caches are cleared.
5775         inferior.c (exit_inferior_1): Likewise.
5776
5777 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5778             Tom Tromey  <tom@tromey.com>
5779
5780         * dictionary.c (collate_pending_symbols_by_language): Remove
5781         "struct" from foreach.
5782         * symtab.c (lookup_global_symbol_from_objfile)
5783         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5784         foreach.
5785         * ser-tcp.c (net_open): Remove "struct" from foreach.
5786         * objfiles.c (objfile_relocate, objfile_rebase)
5787         (objfile_has_symbols): Remove "struct" from foreach.
5788         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5789         from foreach.
5790         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5791         foreach.
5792         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5793         "struct" from foreach.
5794         * ada-lang.c (create_excep_cond_exprs)
5795         (ada_exception_catchpoint_cond_string): Remove "struct" from
5796         foreach.
5797
5798 2019-05-03  Tom Tromey  <tromey@adacore.com>
5799
5800         * ada-exp.y (convert_char_literal): Check suffix of each
5801         enumerator.
5802
5803 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5804
5805         PR ada/21406:
5806         * ada-exp.y (yywrap): Don't define.
5807         * ada-lex.l (%option): Add noyywrap
5808         (yywrap): Remove.
5809
5810 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5811
5812         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5813         _WIN32_WINNT to the XP level, unless already defined to a higher
5814         level.
5815
5816         * unittests/parse-connection-spec-selftests.c:
5817         * ser-tcp.c:
5818         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5819         override.
5820
5821         * symfile.c (find_separate_debug_file): Remove colon from the
5822         drive spec of DOS/Windows file names of the target, so that the
5823         file name produced from DEBUGDIR and the target's directory will
5824         be valid on DOS/Windows systems.
5825
5826 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5827
5828         * rust-lang.c (val_print_struct): Handle printing structures
5829         containing strings.
5830
5831 2019-05-02  Tom Tromey  <tromey@adacore.com>
5832
5833         * valarith.c (_initialize_valarith): Remove.
5834
5835 2019-05-01  Tom Tromey  <tromey@adacore.com>
5836
5837         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5838         bitfields.
5839
5840 2019-05-01  Tom Tromey  <tromey@adacore.com>
5841
5842         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5843         for big-endian copies.
5844
5845 2019-04-30  Ali Tamur  <tamur@google.com>
5846         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5847         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5848         (read_3_bytes): New function.
5849
5850 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5851
5852         * windows-nat.c (main_thread_id): Delete.
5853         (handle_output_debug_string): Replace main_thread_id by
5854         current_event.dwThreadId.
5855         (fake_create_process): Likewise.
5856         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5857         Do not set main_thread_id.
5858         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5859         current_event.dwThreadId.
5860         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5861
5862 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5863
5864         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5865         Use current_event.dwThreadId instead of main_thread_id.
5866
5867 2019-04-30  Tom Tromey  <tromey@adacore.com>
5868
5869         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5870         (create_excep_cond_exprs): Iterate over program spaces.
5871         (ada_exception_catchpoint_cond_string): Examine all minimal
5872         symbols for exception types.
5873
5874 2019-04-30  Tom Tromey  <tromey@adacore.com>
5875
5876         PR c++/24470:
5877         * dwarf2read.c (process_structure_scope): Handle case where type
5878         has template parameters but no symbol was created.
5879
5880 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5881             Chris January  <chris.january@arm.com>
5882
5883         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5884         qualifier.
5885         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5886
5887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * f-typeprint.c (f_print_type): Update rules for printing
5890         whitespace.
5891         (f_type_print_varspec_suffix): Likewise.
5892
5893 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5894             Chris January  <chris.january@arm.com>
5895
5896         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5897         function arguments.
5898
5899 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5900
5901         * f-lang.c (build_fortran_types): Change name of void type to
5902         lower case.
5903         * f-typeprint.c (f_type_print_base): Print the name of the void
5904         type, rather than a fixed string.
5905         * f-valprint.c (f_decorations): Use lower case void string.
5906
5907 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5908             Chris January  <chris.january@arm.com>
5909
5910         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5911         types for Fortran.
5912
5913 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5914             Chris January  <chris.january@arm.com>
5915             David Lecomber  <david.lecomber@arm.com>
5916
5917         * f-exp.y (BINOP_INTRINSIC): New token.
5918         (exp): New parser rule handling BINOP_INTRINSIC.
5919         (f77_keywords): Add new builtin procedures.
5920         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5921         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5922         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5923         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5924         (print_unop_subexp_f): New function.
5925         (print_binop_subexp_f): New function.
5926         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5927         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5928         (dump_subexp_body_f): Likewise.
5929         (operator_check_f): Likewise.
5930         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5931         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5932
5933 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5936         UNOP_KIND.
5937         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5938         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5939         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5940         (operator_length_f): New fuction.
5941         (print_subexp_f): New function.
5942         (op_name_f): New function.
5943         (dump_subexp_body_f): New function.
5944         (operator_check_f): New function.
5945         (exp_descriptor_f): Replace standard expression handling functions
5946         with new functions.
5947         * gdb/fortran-operator.def: New file.
5948         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5949         * gdb/std-operator.def: Remove UNOP_KIND.
5950
5951 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5952
5953         * std-operator.def: Remove unbalanced, stray double quote
5954         character.
5955
5956 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5957             Chris January  <chris.january@arm.com>
5958             Daniel Everett  <daniel.everett@arm.com>
5959             Nick Forrington  <nick.forrington@arm.com>
5960             Richard Bunt  <richard.bunt@arm.com>
5961
5962         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5963         of depth when printing anonymous structs or unions.
5964         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5965         Don't print either the top-level value, or the children if the
5966         max-depth is exceeded.
5967         (ppscm_print_children): When printing the key of a map, allow one
5968         extra level of depth.
5969         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5970         print either the top-level value, or the children if the max-depth
5971         is exceeded.
5972         (print_children): When printing the key of a map, allow one extra
5973         level of depth.
5974         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5975         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5976         (user_print_options): Initialise max_depth field.
5977         (val_print_scalar_or_string_type_p): New function.
5978         (val_print): Check to see if the max depth has been reached.
5979         (val_print_check_max_depth): Define new function.
5980         (show_print_max_depth): New function.
5981         (_initialize_valprint): Add 'print max-depth' option.
5982         * valprint.h (struct value_print_options) <max_depth>: New field.
5983         (val_print_check_max_depth): Declare new function.
5984         * NEWS: Document new feature.
5985
5986 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5987
5988         * ada-lang.c (ada_language_defn): Initialise new field.
5989         * c-lang.c (c_is_string_type_p): New function.
5990         (c_language_defn): Initialise new field.
5991         (cplus_language_defn): Initialise new field.
5992         (asm_language_defn): Initialise new field.
5993         (minimal_language_defn): Initialise new field.
5994         * c-lang.h (c_is_string_type_p): Declare new function.
5995         * d-lang.c (d_language_defn): Initialise new field.
5996         * f-lang.c (f_is_string_type_p): New function.
5997         (f_language_defn): Initialise new field.
5998         * go-lang.c (go_is_string_type_p): New function.
5999         (go_language_defn): Initialise new field.
6000         * language.c (default_is_string_type_p): New function.
6001         (unknown_language_defn): Initialise new field.
6002         (auto_language_defn): Initialise new field.
6003         * language.h (struct language_defn) <la_is_string_type_p>: New
6004         member variable.
6005         (default_is_string_type_p): Declare new function.
6006         * m2-lang.c (m2_language_defn): Initialise new field.
6007         * objc-lang.c (objc_language_defn): Initialise new field.
6008         * opencl-lang.c (opencl_language_defn): Initialise new field.
6009         * p-lang.c (pascal_is_string_type_p): New function.
6010         (pascal_language_defn): Initialise new field.
6011         * rust-lang.c (rust_is_string_type_p): New function.
6012         (rust_language_defn): Initialise new field.
6013
6014 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6017         New field.
6018         * ada-lang.c (ada_language_defn): Initialise new field.
6019         * c-lang.c (c_language_defn): Likewise.
6020         (cplus_language_defn): Likewise.
6021         (asm_language_defn): Likewise.
6022         (minimal_language_defn): Likewise.
6023         * d-lang.c (d_language_defn): Likewise.
6024         * f-lang.c (f_language_defn): Likewise.
6025         * go-lang.c (go_language_defn): Likewise.
6026         * language.c (unknown_language_defn): Likewise.
6027         (auto_language_defn): Likewise.
6028         * m2-lang.c (m2_language_defn): Likewise.
6029         * objc-lang.c (objc_language_defn): Likewise.
6030         * opencl-lang.c (opencl_language_defn): Likewise.
6031         * p-lang.c (pascal_language_defn): Likewise.
6032         * rust-lang.c (rust_language_defn): Likewise.
6033
6034 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * ada-lang.c (ada_is_character_type): Change return type to bool.
6037         (ada_is_string_type): Likewise.
6038         * ada-lang.h (ada_is_character_type): Update declaration
6039         (ada_is_string_type): Likewise.
6040
6041 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6042
6043         Support style in 'frame|thread apply'
6044
6045         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6046         * record.c (record_start, record_stop): Update callers of
6047         execute_command_to_string with false.
6048         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6049         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6050         methods.
6051         (class string_file): New constructor with term_out parameter.
6052         Override methods term_out and can_emit_style_escape.  New member
6053         term_out.
6054         (class stdio_file): Override can_emit_style_escape.
6055         (class tee_file): Override term_out and can_emit_style_escape.
6056         * utils.h (can_emit_style_escape): Remove.
6057         * utils.c (can_emit_style_escape): Likewise.
6058         Update all callers of can_emit_style_escape (SOMESTREAM) to
6059         SOMESTREAM->can_emit_style_escape.
6060         * source-cache.c (source_cache::get_source_lines): Likewise.
6061         * stack.c (frame_apply_command_count): Call execute_command_to_string
6062         passing the term_out characteristic of the current gdb_stdout.
6063         * thread.c (thr_try_catch_cmd): Likewise.
6064         * top.c (execute_command_to_string): pass term_out parameter
6065         to construct the string_file for the command output.
6066         * ui-file.c (term_cli_styling): New function (most code moved
6067         from utils.c can_emit_style_escape).
6068         (string_file::string_file, string_file::can_emit_style_escape,
6069         stdio_file::can_emit_style_escape, tee_file::term_out,
6070         tee_file::can_emit_style_escape): New functions.
6071
6072 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6073
6074         * NEWS: Mention the new set|show may-call-functions.
6075         * infcall.c (may_call_functions_p): New variable.
6076         (show_may_call_functions_p): New function.
6077         (call_function_by_hand_dummy): Throws an error if not
6078         may-call-functions.
6079         (_initialize_infcall): Call add_setshow_boolean_cmd for
6080         may-call-functions.
6081
6082 2019-04-25  Keith Seitz  <keiths@redhat.com>
6083
6084         PR c++/24367
6085         * cp-support.c (inspect_type): Don't attempt substitutions
6086         of symbol with the same name.
6087
6088 2019-04-25  Tom Tromey  <tromey@adacore.com>
6089
6090         PR gdb/24475:
6091         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6092         static.
6093
6094 2019-04-25  Tom Tromey  <tromey@adacore.com>
6095
6096         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6097         rvalue reference.
6098         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6099         (gdb_xml_parser::parse): Use std::move.
6100         * python/python-internal.h (gdbpy_convert_exception): Take a const
6101         reference.
6102         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6103         std::move.
6104         * python/py-utils.c (gdbpy_convert_exception): Take a const
6105         reference.
6106         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6107         Use std::move.
6108         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6109         Use std::move.
6110         * mi/mi-main.c (mi_print_exception): Take a const reference.
6111         * main.c (handle_command_errors): Take a const reference.
6112         * linespec.c (parse_linespec): Use std::move.
6113         * infcall.c (run_inferior_call): Use std::move.
6114         (call_function_by_hand_dummy): Use std::move.
6115         * exec.c (try_open_exec_file): Use std::move.
6116         * exceptions.h (exception_print, exception_fprintf)
6117         (exception_print_same): Update.
6118         * exceptions.c (print_exception, exception_print)
6119         (exception_fprintf, exception_print_same): Change parameters to
6120         const reference.
6121         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6122         * common/new-op.c: Use std::move.
6123         * common/common-exceptions.h (struct gdb_exception): Add move
6124         constructor.
6125         (struct gdb_exception_error, struct gdb_exception_quit, struct
6126         gdb_quit_bad_alloc): Change constructor to move constructor.
6127         (throw_exception): Change parameter to rvalue reference.
6128         * common/common-exceptions.c (throw_exception): Take rvalue
6129         reference.
6130         * cli/cli-interp.c (safe_execute_command): Use std::move.
6131         * breakpoint.c (insert_bp_location, location_to_sals): Use
6132         std::move.
6133
6134 2019-04-25  Tom Tromey  <tromey@adacore.com>
6135
6136         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6137         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6138         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6139         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6140         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6141         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6142         guile/scm-value.c: Use unpack.
6143         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6144         gdbscm_gdb_exception.
6145         (gdbscm_throw_gdb_exception): Likewise.
6146         (struct gdbscm_gdb_exception): New.
6147         (unpack): New function.
6148         (gdbscm_wrap): Use unpack.
6149
6150 2019-04-25  Tom Tromey  <tromey@adacore.com>
6151
6152         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6153         (gdb_rl_callback_handler): Use std::move.
6154         * common/common-exceptions.h (struct gdb_exception): Add move
6155         assignment operator.
6156         (throw_exception_sjlj): Change "exception" to const reference.
6157         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6158         (throw_exception_sjlj): Change "exception" to const reference.
6159
6160 2019-04-25  Tom Tromey  <tromey@adacore.com>
6161
6162         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6163         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6164         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6165         Update.
6166         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6167         Update.
6168         * mi/mi-interp.c (mi_interp::exec): Update.
6169         * linespec.c (parse_linespec): Update.
6170         * infcall.c (run_inferior_call): Update.
6171         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6172         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6173         (gdbscm_lookup_global_symbol): Update.
6174         * guile/scm-param.c (gdbscm_parameter_value): Update.
6175         * guile/scm-frame.c (gdbscm_frame_read_register)
6176         (gdbscm_frame_read_var): Update.
6177         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6178         * exec.c (try_open_exec_file): Update.
6179         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6180         (gdb_rl_callback_handler): Update.
6181         * common/common-exceptions.h (exception_none): Don't declare.
6182         * common/common-exceptions.c (exception_none): Don't define.
6183         (struct catcher) <exception>: Update.
6184         * cli/cli-interp.c (safe_execute_command): Update.
6185         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6186
6187 2019-04-25  Ali Tamur  <tamur@google.com>
6188
6189         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6190         (read_attribute_value): Likewise.
6191         (dwarf2_read_addr_index): Update comment.
6192         (read_str_index): Add DW_FORM_strx.
6193         (dwarf2_string_attr): Likewise.
6194         (dwarf2_const_value_attr): Likewise.
6195         (dump_die_shallow): Likewise.
6196         (dwarf2_fetch_constant_bytes): Likewise.
6197         (skip_form_bytes): Likewise.
6198         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6199
6200 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6201
6202         PR corefiles/11608
6203         PR corefiles/18187
6204         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6205         OFFSET.  Verify if current mapping contains an ELF header.
6206         (linux_find_memory_regions_full): Adjust call to
6207         dump_mapping_p.
6208
6209 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6210             Kang Li <kanglictf@gmail.com>
6211
6212         PR gdb/21600
6213
6214         * dwarf2-frame.c (read_initial_length): Be consistent about using
6215         unsigned representation of length.
6216         (decode_frame_entry_1): Likewise.  Check for wraparound of
6217         end pointer as well as buffer overflow.
6218
6219 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6220
6221         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6222         "vq".
6223
6224 2019-04-24  Tom Tromey  <tromey@adacore.com>
6225
6226         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6227
6228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6229
6230         * s12z-tdep.c (s12z_unwind_pc): Delete.
6231         (s12z_unwind_sp): Delete.
6232         (s12z_gdbarch_init): Don't register deleted functions with
6233         gdbarch.
6234
6235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6236
6237         * rl78-tdep.c (rl78_unwind_sp): Delete.
6238         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6239
6240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6241
6242         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6243         (xstormy16_unwind_pc): Delete.
6244         (xstormy16_dummy_id): Delete.
6245         (xstormy16_gdbarch_init): Don't register deleted functions with
6246         gdbarch.
6247
6248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * vax-tdep.c (vax_unwind_pc): Delete.
6251         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6252
6253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * v850-tdep.c (v850_unwind_sp): Delete.
6256         (v850_unwind_pc): Delete.
6257         (v850_dummy_id): Delete.
6258         (v850_gdbarch_init): Don't register deleted functions with
6259         gdbarch.
6260
6261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6262
6263         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6264         (tilegx_unwind_pc): Delete.
6265         (tilegx_unwind_dummy_id): Delete.
6266         (tilegx_gdbarch_init): Don't register deleted functions with
6267         gdbarch.
6268
6269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6270
6271         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6272         (tic6x_dummy_id): Delete.
6273         (tic6x_gdbarch_init): Don't register deleted functions with
6274         gdbarch.
6275
6276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * sparc-tdep.c (sparc_unwind_pc): Delete.
6279         (sparc32_gdbarch_init): Don't register deleted function with
6280         gdbarch.
6281
6282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * sh-tdep.c (sh_unwind_sp): Delete.
6285         (sh_unwind_pc): Delete.
6286         (sh_dummy_id): Delete.
6287         (sh_gdbarch_init): Don't register deleted functions with
6288         gdbarch.
6289
6290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * score-tdep.c (score_unwind_sp): Delete.
6293         (score_unwind_pc): Delete.
6294         (score_dummy_id): Delete.
6295         (score_gdbarch_init): Don't register deleted functions with
6296         gdbarch.
6297
6298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * rx-tdep.c (rx_unwind_pc): Delete.
6301         (rx_unwind_sp): Delete.
6302         (rx_dummy_id): Delete.
6303         (rx_gdbarch_init): Don't register deleted functions with
6304         gdbarch.  Update comment.
6305
6306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6309         (rs6000_dummy_id): Delete.
6310         (rs6000_gdbarch_init): Don't register deleted functions with
6311         gdbarch.
6312
6313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6314
6315         * or1k-tdep.c (or1k_dummy_id): Delete.
6316         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6317
6318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6319
6320         * nios2-tdep.c (nios2_dummy_id): Delete.
6321         (nios2_unwind_sp): Delete.
6322         (nios2_gdbarch_init): Don't register deleted functions with
6323         gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * nds32-tdep.c (nds32_dummy_id): Delete.
6328         (nds32_unwind_pc): Delete.
6329         (nds32_unwind_sp): Delete.
6330         (nds32_gdbarch_init): Don't register deleted functions with
6331         gdbarch.
6332
6333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * msp430-tdep.c (msp430_unwind_pc): Delete.
6336         (msp430_unwind_sp): Delete.
6337         (msp430_dummy_id): Delete.
6338         (msp430_gdbarch_init): Don't register deleted functions with
6339         gdbarch.
6340
6341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * moxie-tdep.c (moxie_unwind_sp): Delete.
6344         (moxie_unwind_pc): Delete.
6345         (moxie_dummy_id): Delete.
6346         (moxie_gdbarch_init): Don't register deleted functions with
6347         gdbarch.
6348
6349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6352         (mn10300_unwind_pc): Delete.
6353         (mn10300_unwind_sp): Delete.
6354         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6355         mn10300_unwind_sp.
6356         (mn10300_frame_unwind_init): Don't register deleted functions with
6357         gdbarch.
6358
6359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6360
6361         * mep-tdep.c (mep_unwind_pc): Delete.
6362         (mep_unwind_sp): Delete.
6363         (mep_dummy_id): Delete.
6364         (mep_gdbarch_init): Don't register deleted functions with
6365         gdbarch.
6366
6367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6368
6369         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6370         (m68hc11_unwind_sp): Delete.
6371         (m68hc11_gdbarch_init): Don't register deleted functions with
6372         gdbarch.
6373
6374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * m32r-tdep.c (m32r_unwind_sp): Delete.
6377         (m32r_unwind_pc): Delete.
6378         (m32r_dummy_id): Delete.
6379         (m32r_gdbarch_init): Don't register deleted functions with
6380         gdbarch.
6381
6382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6383
6384         * m32c-tdep.c (m32c_unwind_pc): Delete.
6385         (m32c_unwind_sp): Delete.
6386         (m32c_dummy_id): Delete.
6387         (m32c_gdbarch_init): Don't register deleted functions with
6388         gdbarch.
6389
6390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6391
6392         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6393         (lm32_unwind_pc): Delete.
6394         (lm32_dummy_id): Delete.
6395         (lm32_gdbarch_init): Don't register deleted functions with
6396         gdbarch.
6397
6398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6399
6400         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6401         (iq2000_unwind_pc): Delete.
6402         (iq2000_dummy_id): Delete.
6403         (iq2000_gdbarch_init): Don't register deleted functions with
6404         gdbarch.
6405
6406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * nds32-tdep.c (nds32_type_align): Delete.
6409         (nds32_push_dummy_call): Use type_align instead.
6410
6411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * arm-tdep.c (arm_type_align): Only handle vector override case.
6414         (arm_push_dummy_call): Use type_align.
6415         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6416
6417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6420         case.
6421         (pass_on_stack): Use type_align.
6422         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6423         function.
6424
6425 2019-04-23  Tom Tromey  <tromey@adacore.com>
6426
6427         * dwarf2read.c (line_header::file_name_at): Remove unused
6428         overload.
6429
6430 2019-04-23  Tom de Vries  <tdevries@suse.de>
6431
6432         PR gdb/24438
6433         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6434         invocation.
6435
6436
6437 2019-03-27  Ali Tamur  <tamur@google.com>
6438
6439         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6440         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6441         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6442         (dwarf_expr_context::get_addr_index): Likewise
6443         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6444         (symbol_needs_eval_context::get_addr_index): Likewise
6445         (disassemble_dwarf_expression): Add DW_OP_addrx
6446         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6447         (read_cutu_die_from_dwo): Update comment
6448         (skip_one_die): Add DW_FORM_addrx
6449         (read_attribute_value): Likewise
6450         (var_decode_location): Add DW_OP_addrx
6451         (dwarf2_const_value_attr): Add DW_FORM_addrx
6452         (dump_die_shallow): Likewise
6453         (dwarf2_fetch_constant_bytes): Likewise
6454         (decode_locdesc): Add DW_OP_addrx
6455         (skip_form_bytes): Add DW_FORM_addrx
6456
6457 2019-04-22  Ali Tamur  <tamur@google.com>
6458
6459         * MAINTAINERS (Write After Approval): Add self.
6460
6461 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6462
6463         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6464         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6465         (open_symbol_file_object): Likewise.
6466         (svr4_default_sos): Add info parameter.
6467         (svr4_read_so_list): Likewise.
6468         (svr4_current_sos_direct): Adjust functions calls to pass down
6469         info.
6470         (svr4_current_sos_1): Add info parameter.
6471         (svr4_current_sos): Call get_svr4_info, pass info down to
6472         svr4_current_sos_1.
6473         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6474         get_svr4_info.
6475         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6476         get_svr4_info.
6477         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6478         to get_svr4_info.
6479         (probes_table_remove_objfile_probes): Likewise.
6480         (register_solib_event_probe): Add info parameter.
6481         (solist_update_incremental): Pass info parameter down to
6482         svr4_read_so_list.
6483         (disable_probes_interface): Add info parameter.
6484         (svr4_handle_solib_event): Pass current_program_space to
6485         get_svr4_info.  Adjust disable_probes_interface cleanup.
6486         (svr4_create_probe_breakpoints): Add info parameter, pass it
6487         down to register_solib_event_probe.
6488         (svr4_create_solib_event_breakpoints): Add info parameter,
6489         pass it down to svr4_create_probe_breakpoints.
6490         (enable_break): Pass info down to
6491         svr4_create_solib_event_breakpoints.
6492         (svr4_solib_create_inferior_hook): Pass current_program_space to
6493         get_svr4_info.
6494         (svr4_clear_solib): Likewise.
6495
6496 2019-04-22  Pedro Alves  <palves@redhat.com>
6497
6498         * solib-svr4.c (svr4_free_objfile_observer): New.
6499         (probe_and_action::objfile): New field.
6500         (probes_table_htab_remove_objfile_probes)
6501         (probes_table_remove_objfile_probes): New functions.
6502         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6503         in the new probe_and_action.  Don't store the probe in 'lookup'.
6504         (svr4_create_probe_breakpoints): Pass objfile to
6505         register_solib_event_probe.
6506         (_initialize_svr4_solib): Register a free_objfile observer.
6507
6508 2019-04-19  Tom Tromey  <tom@tromey.com>
6509
6510         * common/queue.h: Remove.
6511
6512 2019-04-19  Tom Tromey  <tom@tromey.com>
6513
6514         * event-loop.c: Don't include "common/queue.h".
6515
6516 2019-04-19  Tom Tromey  <tom@tromey.com>
6517
6518         * remote.c (remote_target): Use delete.
6519         * remote-notif.h: Include <list>, not "common/queue.h".
6520         (notif_client_p): Remove typedef.
6521         (remote_notif_state): Add constructor, destructor, initializer.
6522         <notif_queue>: Now a std::list.
6523         (remote_notif_state_xfree): Don't declare.
6524         * remote-notif.c (remote_notif_process, handle_notification)
6525         (remote_notif_state_allocate): Update.
6526         (~remote_notif_state): Rename from remote_notif_state_xfree.
6527
6528 2019-04-19  Tom Tromey  <tom@tromey.com>
6529
6530         * symfile.c (reread_symbols): Update.
6531         * objfiles.c (objfile_register_static_link)
6532         (objfile_lookup_static_link): Update
6533         (~objfile) Don't delete static_links.
6534         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6535
6536 2019-04-19  Tom Tromey  <tom@tromey.com>
6537
6538         * type-stack.h (struct type_stack) <insert>: Constify string.
6539         * type-stack.c (type_stack::insert): Constify string.
6540         * gdbtypes.h (lookup_template_type): Update.
6541         (address_space_name_to_int): Update.
6542         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6543         const.
6544         (lookup_template_type): Make name const.
6545         * c-exp.y: Update rules.
6546         (lex_one_token, classify_name, classify_inner_name)
6547         (c_print_token): Update.
6548         * p-exp.y: Update rules.
6549         (yylex): Update.
6550         * f-exp.y: Update rules.
6551         (yylex): Update.
6552         * d-exp.y: Update rules.
6553         (lex_one_token, classify_name, classify_inner_name): Update.
6554         * parse.c (write_dollar_variable, copy_name): Return std::string.
6555         * parser-defs.h (copy_name): Change return type.
6556         * m2-exp.y: Update rules.
6557         (yylex): Update.
6558         * go-exp.y (lex_one_token): Update.
6559         Update rules.
6560         (classify_unsafe_function, classify_packaged_name)
6561         (classify_name, yylex): Update.
6562
6563 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6564
6565         * configure.ac: add --enable-source-highlight switch.
6566         * configure: Regenerate.
6567         * top.c (print_gdb_version): plumb --enable-source-highlight
6568         status to "show configuration".
6569
6570 2019-04-19  Tom Tromey  <tromey@adacore.com>
6571
6572         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6573         Check ADA_TYPE_P.
6574         (empty_record, ada_template_to_fixed_record_type_1)
6575         (template_to_static_fixed_type)
6576         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6577         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6578         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6579         macros.
6580
6581 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6582
6583         PR symtab/24423:
6584         * source.c (print_source_lines_base): Advance "iter" when a
6585         control character is seen.
6586
6587 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6588
6589         * inferior.h (struct infcall_suspend_state_deleter):
6590         Catch exception in destructor to avoid crash.
6591
6592 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6593
6594         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6595         close to the add_com "shell".
6596
6597 2019-04-18  Tom Tromey  <tromey@adacore.com>
6598
6599         * process-stratum-target.h (class process_stratum_target)
6600         <stratum>: Add "final".
6601
6602 2019-04-17  Tom Tromey  <tromey@adacore.com>
6603
6604         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6605         against nullptr before use.
6606
6607 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6608
6609         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6610
6611 2019-04-17  Jim Wilson  <jimw@sifive.com>
6612             Andrew Burgess  <andrew.burgess@embecosm.com>
6613
6614         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6615         code read might fail, assume 4-byte breakpoint in that case.
6616
6617 2019-04-15  Leszek Swirski  <leszeks@google.com>
6618
6619         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6620         rather than a hand-rolled POD check when checking for forced MEMORY
6621         classification.
6622
6623 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6624
6625         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6626         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6627         function.
6628         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6629         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6630         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6631         declaration.
6632
6633 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6634
6635         * aarch64-linux-nat.c
6636         (aarch64_linux_nat_target::thread_architecture): Add override.
6637         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6638         each VQ.
6639
6640 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6643
6644 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6645
6646         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6647         target types of size 96-bits, add some additional comments, and
6648         check that the builtin type we found was the correct size.
6649
6650 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6651
6652         * utils.c (prompt_for_continue): Don't restore the styling at the
6653         end, as applied_style has the wrong value.  This fixes styling in
6654         long lists of file names that are interrupted by the "Continue?"
6655         prompt.
6656
6657 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6658
6659         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6660         * c-lang.c (c_language_defn): Likewise.
6661         (cplus_language_defn): Likewise.
6662         (asm_language_defn): Likewise.
6663         (minimal_language_defn): Likewise.
6664         * d-lang.c (d_language_defn): Likewise.
6665         * f-lang.c (f_language_defn): Likewise.
6666         * go-lang.c (go_language_defn): Likewise.
6667         * language.c (unknown_language_defn): Likewise.
6668         (auto_language_defn): Likewise.
6669         * language.h (struct language_defn): Remove la_magic field.
6670         (LANG_MAGIC): Delete.
6671         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6672         * objc-lang.c (objc_language_defn): Likewise.
6673         * opencl-lang.c (opencl_language_defn): Likewise.
6674         * p-lang.c (pascal_language_defn): Likewise.
6675         * rust-lang.c (rust_language_defn): Likewise.
6676
6677 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6678
6679         * riscv-tdep.c (riscv_type_align): New function.
6680         (riscv_type_alignment): Delete.
6681         (riscv_arg_location): Use 'type_align'.
6682         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6683
6684 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * gdbtypes.c (type_align): A struct with no non-static fields also
6687         has alignment of 1.
6688
6689 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6690
6691         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6692         component to 0.
6693         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6694         member.
6695         (riscv_struct_info::analyse): New implementation using new
6696         analyse_inner member function.
6697         (riscv_struct_info::field_offset): New member function.
6698         (riscv_struct_info::m_offsets): New member variable.
6699         (riscv_struct_info::analyse_inner): New private member function,
6700         takes the old implementation of riscv_struct_info::analyse but
6701         extended to track field offsets.
6702         (riscv_call_arg_struct): Update the struct folding special cases
6703         to handle cases where empty C++ structs, which are non-zero
6704         length, are found.
6705         (riscv_arg_location): Initialise the length of each location, a
6706         non-zero length now indicates the location is in use.
6707         (riscv_push_dummy_call): Allow for the first location having a
6708         non-zero offset when setting up arguments.
6709         (riscv_return_value): Likewise, but for return values.
6710
6711 2019-04-11  Tom Tromey  <tromey@adacore.com>
6712
6713         * utils.c (internal_vproblem): Make "msg" const.
6714
6715 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6716
6717         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6718         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6719         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6720         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6721
6722 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6723
6724         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6725         function.
6726         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6727         of amd64_collect_native_gregset.
6728         (amd64_linux_nat_target::store_registers): Likewise.
6729
6730 2019-04-10  Tom Tromey  <tom@tromey.com>
6731
6732         * symtab.c (lookup_global_symbol_from_objfile)
6733         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6734         * objfiles.h (class separate_debug_iterator): New.
6735         (class separate_debug_range): New.
6736         (struct objfile) <separate_debug_objfiles>: New method.
6737         (objfile_separate_debug_iterate): Don't declare.
6738         * objfiles.c (separate_debug_iterator::operator++): Rename from
6739         objfile_separate_debug_iterate.
6740         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6741         iterator.
6742         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6743         iterator.
6744
6745 2019-04-10  Tom Tromey  <tom@tromey.com>
6746
6747         * symfile.c (reread_symbols): Remove old comment.
6748         * objfiles.c (free_all_objfiles): Fix a typo.
6749
6750 2019-04-10  Tom Tromey  <tom@tromey.com>
6751
6752         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6753         * minsyms.c (lookup_minimal_symbol): Use foreach.
6754         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6755         (lookup_minimal_symbol_solib_trampoline): Likewise.
6756         * symfile.c (reread_symbols): Use foreach.
6757
6758 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6759             Tom Tromey  <tromey@adacore.com>
6760
6761         PR rust/24414:
6762         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6763         (rust_lex_int_test): Change "value" to be LONGEST.
6764         (rust_lex_tests): Add test for long integer literal.
6765
6766 2019-04-09  Tom Tromey  <tromey@adacore.com>
6767
6768         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6769         to bool.
6770         (extended_remote_target::attach): Update.
6771         (remote_target::remote_notice_new_inferior): Update.
6772         (remote_target::add_current_inferior_and_thread): Update.
6773         * inferior.c (exit_inferior_1): Use "false".
6774         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6775
6776 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6777
6778         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6779         the "start" command.
6780
6781 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6782
6783         * python/py-inferior.c (infpy_thread_from_thread_handle):
6784         Adjust comments to reflect renaming of thread_from_thread_handle
6785         to thread_from_handle.  Adjust keywords.  Fix type error message.
6786         (inferior_object_methods): Add thread_from_handle.  Retain
6787         thread_from_thread_handle, but mark it as deprecated.
6788
6789 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6790
6791         * gdbthread.h (find_thread_by_handle): Revise declaration.
6792         * thread.c (find_thread_by_handle): Likewise.  Adjust
6793         implementation too.
6794         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6795         support for buffer objects as handles.
6796
6797 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6798
6799         * python/py-infthread.c (thpy_thread_handle): New function.
6800         (thread_object_methods): Register thpy_thread_handle.
6801
6802 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6803
6804         * gdbthread.h (thread_to_thread_handle): Declare.
6805         * thread.c (gdbtypes.h): Include.
6806         (thread_to_thread_handle): New function.
6807
6808         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6809         (target_thread_info_to_thread_handle): Declare.
6810         * target.c (target_thread_info_to_thread_handle): New function.
6811         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6812         * target-delegates.c: Regenerate.
6813
6814         * linux-thread-db.c (class thread_db_target): Add method
6815         thread_info_to_thread_handle.
6816         (thread_db_target::thread_info_to_thread_handle): Define.
6817         * remote.c (class remote_target): Add new method
6818         thread_info_to_thread_handle.
6819         (remote_target::thread_info_to_thread_handle): Define.
6820
6821 2019-04-08  Pedro Alves  <palves@redhat.com>
6822
6823         * common/common-exceptions.c (throw_exception): Don't create
6824         named object to throw; throw directly.
6825         (throw_it): Likewise.  Don't initialize gdb_exception::message
6826         here, with new; pass FMT and AP to the ctor instead.
6827         * common/common-exceptions.h: Include <string>.
6828         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6829         const char *, va_list)): New ctor.  Use std::make_shared.
6830         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6831         errors)): Delete.
6832         (gdb_exception_error::gdb_exception_error(enum errors, const char
6833         *, va_list)): New.
6834         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6835         Add assertion.
6836         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6837         errors)): Delete.
6838         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6839         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6840         Add assertion.
6841
6842 2019-04-08  Tom Tromey  <tom@tromey.com>
6843
6844         * valops.c (value_rtti_indirect_type): Replace throw_exception
6845         with throw.
6846         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6847         with throw.
6848         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6849         throw.
6850         * target.c (target_translate_tls_address): Replace throw_exception
6851         with throw.
6852         * stack.c (frame_apply_command_count): Replace throw_exception
6853         with throw.
6854         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6855         throw.
6856         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6857         with throw.
6858         * rs6000-tdep.c (rs6000_frame_cache)
6859         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6860         * remote.c: Replace throw_exception with throw.
6861         * record-full.c (record_full_message, record_full_wait_1)
6862         (record_full_restore): Replace throw_exception with throw.
6863         * record-btrace.c:
6864         (get_thread_current_frame_id, record_btrace_start_replaying)
6865         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6866         (cmd_record_btrace_start): Replace throw_exception with throw.
6867         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6868         throw.
6869         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6870         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6871         * linespec.c:
6872         (find_linespec_symbols): Replace throw_exception with throw.
6873         * infrun.c (displaced_step_prepare, resume): Replace
6874         throw_exception with throw.
6875         * infcmd.c (post_create_inferior): Replace throw_exception with
6876         throw.
6877         * inf-loop.c (inferior_event_handler): Replace throw_exception
6878         with throw.
6879         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6880         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6881         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6882         (get_prev_frame_always, get_frame_pc_if_available)
6883         (get_frame_address_in_block_if_available, get_frame_language):
6884         Replace throw_exception with throw.
6885         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6886         throw_exception with throw.
6887         * eval.c (fetch_subexp_value, evaluate_var_value)
6888         (evaluate_funcall, evaluate_subexp_standard): Replace
6889         throw_exception with throw.
6890         * dwarf2loc.c (call_site_find_chain)
6891         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6892         Replace throw_exception with throw.
6893         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6894         with throw.
6895         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6896         throw.
6897         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6898         * completer.c (complete_line_internal): Replace throw_exception
6899         with throw.
6900         * compile/compile-object-run.c (compile_object_run): Replace
6901         throw_exception with throw.
6902         * cli/cli-script.c (process_next_line): Replace throw_exception
6903         with throw.
6904         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6905         (btrace_enable, btrace_maint_update_pt_packets): Replace
6906         throw_exception with throw.
6907         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6908         throw_exception with throw.
6909         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6910         throw_exception with throw.
6911         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6912         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6913         * aarch64-tdep.c (aarch64_make_prologue_cache)
6914         (aarch64_make_stub_cache): Replace throw_exception with throw.
6915
6916 2019-04-08  Tom Tromey  <tom@tromey.com>
6917
6918         * common/common-exceptions.c (throw_exception): Rename from
6919         throw_exception_cxx.  Remove old copy.  Make argument const.
6920         (throw_it): Create and throw exception objects directly.
6921         * common/common-exceptions.h (throw_exception): Make argument
6922         const.
6923         (struct gdb_exception_error): Add constructor.
6924         (struct gdb_exception_quit): Add constructor.
6925
6926 2019-04-08  Tom Tromey  <tom@tromey.com>
6927
6928         * common/common-exceptions.h (exception_rethrow): Don't declare.
6929         (TRY_SJLJ): Update comment.
6930         (TRY, CATCH, END_CATCH): Remove.
6931         * common/common-exceptions.c (exception_rethrow): Remove.
6932
6933 2019-04-08  Tom Tromey  <tom@tromey.com>
6934
6935         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6936         Remove.
6937         (gdb_exception_error): Rename from
6938         gdb_exception_RETURN_MASK_ERROR.
6939         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6940         (gdb_quit_bad_alloc): Update.
6941         * aarch64-tdep.c: Update.
6942         * ada-lang.c: Update.
6943         * ada-typeprint.c: Update.
6944         * ada-valprint.c: Update.
6945         * amd64-tdep.c: Update.
6946         * arch-utils.c: Update.
6947         * break-catch-throw.c: Update.
6948         * breakpoint.c: Update.
6949         * btrace.c: Update.
6950         * c-varobj.c: Update.
6951         * cli/cli-cmds.c: Update.
6952         * cli/cli-interp.c: Update.
6953         * cli/cli-script.c: Update.
6954         * common/common-exceptions.c: Update.
6955         * common/new-op.c: Update.
6956         * common/selftest.c: Update.
6957         * compile/compile-c-symbols.c: Update.
6958         * compile/compile-cplus-symbols.c: Update.
6959         * compile/compile-object-load.c: Update.
6960         * compile/compile-object-run.c: Update.
6961         * completer.c: Update.
6962         * corelow.c: Update.
6963         * cp-abi.c: Update.
6964         * cp-support.c: Update.
6965         * cp-valprint.c: Update.
6966         * darwin-nat.c: Update.
6967         * disasm-selftests.c: Update.
6968         * dtrace-probe.c: Update.
6969         * dwarf-index-cache.c: Update.
6970         * dwarf-index-write.c: Update.
6971         * dwarf2-frame-tailcall.c: Update.
6972         * dwarf2-frame.c: Update.
6973         * dwarf2loc.c: Update.
6974         * dwarf2read.c: Update.
6975         * eval.c: Update.
6976         * event-loop.c: Update.
6977         * event-top.c: Update.
6978         * exec.c: Update.
6979         * f-valprint.c: Update.
6980         * fbsd-tdep.c: Update.
6981         * frame-unwind.c: Update.
6982         * frame.c: Update.
6983         * gdbtypes.c: Update.
6984         * gnu-v3-abi.c: Update.
6985         * guile/guile-internal.h: Update.
6986         * guile/scm-block.c: Update.
6987         * guile/scm-breakpoint.c: Update.
6988         * guile/scm-cmd.c: Update.
6989         * guile/scm-disasm.c: Update.
6990         * guile/scm-frame.c: Update.
6991         * guile/scm-lazy-string.c: Update.
6992         * guile/scm-math.c: Update.
6993         * guile/scm-param.c: Update.
6994         * guile/scm-ports.c: Update.
6995         * guile/scm-pretty-print.c: Update.
6996         * guile/scm-symbol.c: Update.
6997         * guile/scm-symtab.c: Update.
6998         * guile/scm-type.c: Update.
6999         * guile/scm-value.c: Update.
7000         * i386-linux-tdep.c: Update.
7001         * i386-tdep.c: Update.
7002         * inf-loop.c: Update.
7003         * infcall.c: Update.
7004         * infcmd.c: Update.
7005         * infrun.c: Update.
7006         * jit.c: Update.
7007         * language.c: Update.
7008         * linespec.c: Update.
7009         * linux-fork.c: Update.
7010         * linux-nat.c: Update.
7011         * linux-tdep.c: Update.
7012         * linux-thread-db.c: Update.
7013         * main.c: Update.
7014         * mi/mi-cmd-break.c: Update.
7015         * mi/mi-cmd-stack.c: Update.
7016         * mi/mi-interp.c: Update.
7017         * mi/mi-main.c: Update.
7018         * objc-lang.c: Update.
7019         * p-valprint.c: Update.
7020         * parse.c: Update.
7021         * ppc-linux-tdep.c: Update.
7022         * printcmd.c: Update.
7023         * python/py-arch.c: Update.
7024         * python/py-breakpoint.c: Update.
7025         * python/py-cmd.c: Update.
7026         * python/py-finishbreakpoint.c: Update.
7027         * python/py-frame.c: Update.
7028         * python/py-framefilter.c: Update.
7029         * python/py-gdb-readline.c: Update.
7030         * python/py-inferior.c: Update.
7031         * python/py-infthread.c: Update.
7032         * python/py-lazy-string.c: Update.
7033         * python/py-linetable.c: Update.
7034         * python/py-objfile.c: Update.
7035         * python/py-param.c: Update.
7036         * python/py-prettyprint.c: Update.
7037         * python/py-progspace.c: Update.
7038         * python/py-record-btrace.c: Update.
7039         * python/py-record.c: Update.
7040         * python/py-symbol.c: Update.
7041         * python/py-type.c: Update.
7042         * python/py-unwind.c: Update.
7043         * python/py-utils.c: Update.
7044         * python/py-value.c: Update.
7045         * python/python.c: Update.
7046         * record-btrace.c: Update.
7047         * record-full.c: Update.
7048         * remote-fileio.c: Update.
7049         * remote.c: Update.
7050         * riscv-tdep.c: Update.
7051         * rs6000-aix-tdep.c: Update.
7052         * rs6000-tdep.c: Update.
7053         * rust-exp.y: Update.
7054         * rust-lang.c: Update.
7055         * s390-tdep.c: Update.
7056         * selftest-arch.c: Update.
7057         * solib-dsbt.c: Update.
7058         * solib-frv.c: Update.
7059         * solib-spu.c: Update.
7060         * solib-svr4.c: Update.
7061         * solib.c: Update.
7062         * sparc64-linux-tdep.c: Update.
7063         * stack.c: Update.
7064         * symfile-mem.c: Update.
7065         * symmisc.c: Update.
7066         * target.c: Update.
7067         * thread.c: Update.
7068         * top.c: Update.
7069         * tracefile-tfile.c: Update.
7070         * tui/tui.c: Update.
7071         * typeprint.c: Update.
7072         * unittests/cli-utils-selftests.c: Update.
7073         * unittests/parse-connection-spec-selftests.c: Update.
7074         * valops.c: Update.
7075         * valprint.c: Update.
7076         * value.c: Update.
7077         * varobj.c: Update.
7078         * windows-nat.c: Update.
7079         * x86-linux-nat.c: Update.
7080         * xml-support.c: Update.
7081
7082 2019-04-08  Tom Tromey  <tom@tromey.com>
7083
7084         * xml-support.c: Use C++ exception handling.
7085         * x86-linux-nat.c: Use C++ exception handling.
7086         * windows-nat.c: Use C++ exception handling.
7087         * varobj.c: Use C++ exception handling.
7088         * value.c: Use C++ exception handling.
7089         * valprint.c: Use C++ exception handling.
7090         * valops.c: Use C++ exception handling.
7091         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7092         handling.
7093         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7094         * typeprint.c: Use C++ exception handling.
7095         * tui/tui.c: Use C++ exception handling.
7096         * tracefile-tfile.c: Use C++ exception handling.
7097         * top.c: Use C++ exception handling.
7098         * thread.c: Use C++ exception handling.
7099         * target.c: Use C++ exception handling.
7100         * symmisc.c: Use C++ exception handling.
7101         * symfile-mem.c: Use C++ exception handling.
7102         * stack.c: Use C++ exception handling.
7103         * sparc64-linux-tdep.c: Use C++ exception handling.
7104         * solib.c: Use C++ exception handling.
7105         * solib-svr4.c: Use C++ exception handling.
7106         * solib-spu.c: Use C++ exception handling.
7107         * solib-frv.c: Use C++ exception handling.
7108         * solib-dsbt.c: Use C++ exception handling.
7109         * selftest-arch.c: Use C++ exception handling.
7110         * s390-tdep.c: Use C++ exception handling.
7111         * rust-lang.c: Use C++ exception handling.
7112         * rust-exp.y: Use C++ exception handling.
7113         * rs6000-tdep.c: Use C++ exception handling.
7114         * rs6000-aix-tdep.c: Use C++ exception handling.
7115         * riscv-tdep.c: Use C++ exception handling.
7116         * remote.c: Use C++ exception handling.
7117         * remote-fileio.c: Use C++ exception handling.
7118         * record-full.c: Use C++ exception handling.
7119         * record-btrace.c: Use C++ exception handling.
7120         * python/python.c: Use C++ exception handling.
7121         * python/py-value.c: Use C++ exception handling.
7122         * python/py-utils.c: Use C++ exception handling.
7123         * python/py-unwind.c: Use C++ exception handling.
7124         * python/py-type.c: Use C++ exception handling.
7125         * python/py-symbol.c: Use C++ exception handling.
7126         * python/py-record.c: Use C++ exception handling.
7127         * python/py-record-btrace.c: Use C++ exception handling.
7128         * python/py-progspace.c: Use C++ exception handling.
7129         * python/py-prettyprint.c: Use C++ exception handling.
7130         * python/py-param.c: Use C++ exception handling.
7131         * python/py-objfile.c: Use C++ exception handling.
7132         * python/py-linetable.c: Use C++ exception handling.
7133         * python/py-lazy-string.c: Use C++ exception handling.
7134         * python/py-infthread.c: Use C++ exception handling.
7135         * python/py-inferior.c: Use C++ exception handling.
7136         * python/py-gdb-readline.c: Use C++ exception handling.
7137         * python/py-framefilter.c: Use C++ exception handling.
7138         * python/py-frame.c: Use C++ exception handling.
7139         * python/py-finishbreakpoint.c: Use C++ exception handling.
7140         * python/py-cmd.c: Use C++ exception handling.
7141         * python/py-breakpoint.c: Use C++ exception handling.
7142         * python/py-arch.c: Use C++ exception handling.
7143         * printcmd.c: Use C++ exception handling.
7144         * ppc-linux-tdep.c: Use C++ exception handling.
7145         * parse.c: Use C++ exception handling.
7146         * p-valprint.c: Use C++ exception handling.
7147         * objc-lang.c: Use C++ exception handling.
7148         * mi/mi-main.c: Use C++ exception handling.
7149         * mi/mi-interp.c: Use C++ exception handling.
7150         * mi/mi-cmd-stack.c: Use C++ exception handling.
7151         * mi/mi-cmd-break.c: Use C++ exception handling.
7152         * main.c: Use C++ exception handling.
7153         * linux-thread-db.c: Use C++ exception handling.
7154         * linux-tdep.c: Use C++ exception handling.
7155         * linux-nat.c: Use C++ exception handling.
7156         * linux-fork.c: Use C++ exception handling.
7157         * linespec.c: Use C++ exception handling.
7158         * language.c: Use C++ exception handling.
7159         * jit.c: Use C++ exception handling.
7160         * infrun.c: Use C++ exception handling.
7161         * infcmd.c: Use C++ exception handling.
7162         * infcall.c: Use C++ exception handling.
7163         * inf-loop.c: Use C++ exception handling.
7164         * i386-tdep.c: Use C++ exception handling.
7165         * i386-linux-tdep.c: Use C++ exception handling.
7166         * guile/scm-value.c: Use C++ exception handling.
7167         * guile/scm-type.c: Use C++ exception handling.
7168         * guile/scm-symtab.c: Use C++ exception handling.
7169         * guile/scm-symbol.c: Use C++ exception handling.
7170         * guile/scm-pretty-print.c: Use C++ exception handling.
7171         * guile/scm-ports.c: Use C++ exception handling.
7172         * guile/scm-param.c: Use C++ exception handling.
7173         * guile/scm-math.c: Use C++ exception handling.
7174         * guile/scm-lazy-string.c: Use C++ exception handling.
7175         * guile/scm-frame.c: Use C++ exception handling.
7176         * guile/scm-disasm.c: Use C++ exception handling.
7177         * guile/scm-cmd.c: Use C++ exception handling.
7178         * guile/scm-breakpoint.c: Use C++ exception handling.
7179         * guile/scm-block.c: Use C++ exception handling.
7180         * guile/guile-internal.h: Use C++ exception handling.
7181         * gnu-v3-abi.c: Use C++ exception handling.
7182         * gdbtypes.c: Use C++ exception handling.
7183         * frame.c: Use C++ exception handling.
7184         * frame-unwind.c: Use C++ exception handling.
7185         * fbsd-tdep.c: Use C++ exception handling.
7186         * f-valprint.c: Use C++ exception handling.
7187         * exec.c: Use C++ exception handling.
7188         * event-top.c: Use C++ exception handling.
7189         * event-loop.c: Use C++ exception handling.
7190         * eval.c: Use C++ exception handling.
7191         * dwarf2read.c: Use C++ exception handling.
7192         * dwarf2loc.c: Use C++ exception handling.
7193         * dwarf2-frame.c: Use C++ exception handling.
7194         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7195         * dwarf-index-write.c: Use C++ exception handling.
7196         * dwarf-index-cache.c: Use C++ exception handling.
7197         * dtrace-probe.c: Use C++ exception handling.
7198         * disasm-selftests.c: Use C++ exception handling.
7199         * darwin-nat.c: Use C++ exception handling.
7200         * cp-valprint.c: Use C++ exception handling.
7201         * cp-support.c: Use C++ exception handling.
7202         * cp-abi.c: Use C++ exception handling.
7203         * corelow.c: Use C++ exception handling.
7204         * completer.c: Use C++ exception handling.
7205         * compile/compile-object-run.c: Use C++ exception handling.
7206         * compile/compile-object-load.c: Use C++ exception handling.
7207         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7208         * compile/compile-c-symbols.c: Use C++ exception handling.
7209         * common/selftest.c: Use C++ exception handling.
7210         * common/new-op.c: Use C++ exception handling.
7211         * cli/cli-script.c: Use C++ exception handling.
7212         * cli/cli-interp.c: Use C++ exception handling.
7213         * cli/cli-cmds.c: Use C++ exception handling.
7214         * c-varobj.c: Use C++ exception handling.
7215         * btrace.c: Use C++ exception handling.
7216         * breakpoint.c: Use C++ exception handling.
7217         * break-catch-throw.c: Use C++ exception handling.
7218         * arch-utils.c: Use C++ exception handling.
7219         * amd64-tdep.c: Use C++ exception handling.
7220         * ada-valprint.c: Use C++ exception handling.
7221         * ada-typeprint.c: Use C++ exception handling.
7222         * ada-lang.c: Use C++ exception handling.
7223         * aarch64-tdep.c: Use C++ exception handling.
7224
7225 2019-04-08  Tom Tromey  <tom@tromey.com>
7226
7227         * xml-support.c (gdb_xml_parser::parse): Update.
7228         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7229         * value.c (show_convenience): Update.
7230         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7231         (test_parse_flags_qcs): Update.
7232         * thread.c (thr_try_catch_cmd): Update.
7233         * target.c (target_translate_tls_address): Update.
7234         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7235         (info_frame_command_core, frame_apply_command_count): Update.
7236         * rust-exp.y (rust_lex_exception_test): Update.
7237         * riscv-tdep.c (riscv_print_one_register_info): Update.
7238         * remote.c (remote_target::enable_btrace): Update.
7239         * record-btrace.c (record_btrace_enable_warn): Update.
7240         * python/py-utils.c (gdbpy_convert_exception): Update.
7241         * printcmd.c (do_one_display, print_variable_and_value): Update.
7242         * mi/mi-main.c (mi_print_exception): Update.
7243         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7244         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7245         * linux-nat.c (linux_nat_target::attach): Update.
7246         * linux-fork.c (class scoped_switch_fork_info): Update.
7247         * infrun.c (displaced_step_prepare): Update.
7248         * infcall.c (call_function_by_hand_dummy): Update.
7249         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7250         * gnu-v3-abi.c (print_one_vtable): Update.
7251         * frame.c (get_prev_frame_always): Update.
7252         * f-valprint.c (info_common_command_for_block): Update.
7253         * exec.c (try_open_exec_file): Update.
7254         * exceptions.c (print_exception, exception_print)
7255         (exception_fprintf, exception_print_same): Update.
7256         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7257         * dwarf-index-cache.c (index_cache::store)
7258         (index_cache::lookup_gdb_index): Update.
7259         * darwin-nat.c (maybe_cache_shell): Update.
7260         * cp-valprint.c (cp_print_value_fields): Update.
7261         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7262         (gcc_cplus_symbol_address): Update.
7263         * compile/compile-c-symbols.c (gcc_convert_symbol)
7264         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7265         * common/selftest.c: Update.
7266         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7267         a std::string.
7268         (exception_try_scope_entry, exception_try_scope_exit): Don't
7269         declare.
7270         (struct exception_try_scope): Remove.
7271         (TRY): Don't use exception_try_scope.
7272         (struct gdb_exception): Add constructor, operator=.
7273         <what>: New method.
7274         (struct gdb_exception_RETURN_MASK_ALL)
7275         (struct gdb_exception_RETURN_MASK_ERROR)
7276         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7277         (struct gdb_quit_bad_alloc): Update.
7278         * common/common-exceptions.c (exception_none): Change
7279         initializer.
7280         (struct catcher) <state, exception>: Initialize inline.
7281         <prev>: Remove member.
7282         (current_catcher): Remove.
7283         (catchers): New global.
7284         (exceptions_state_mc_init): Simplify.
7285         (catcher_pop): Remove.
7286         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7287         (try_scope_depth, exception_try_scope_entry)
7288         (exception_try_scope_exit): Remove.
7289         (throw_exception_sjlj): Update.
7290         (exception_messages, exception_messages_size): Remove.
7291         (throw_it): Simplify.
7292         (gdb_exception_sliced_copy): Remove.
7293         (throw_exception_cxx): Update.
7294         * cli/cli-script.c (script_from_file): Update.
7295         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7296         Update.
7297         * ada-valprint.c (ada_val_print): Update.
7298         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7299         (create_excep_cond_exprs): Update.
7300
7301 2019-04-08  Tom Tromey  <tom@tromey.com>
7302
7303         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7304         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7305         (TRY, CATCH, END_CATCH): Remove some definitions.
7306         * common/common-exceptions.c: Don't use GDB_XCPT.
7307         (catcher_list_size): Remove.
7308         (throw_exception, throw_it): Simplify.
7309
7310 2019-04-05  Tom Tromey  <tom@tromey.com>
7311
7312         Revert the header-sorting patch.
7313         * ft32-tdep.c: Revert.
7314         * frv-tdep.c: Revert.
7315         * frv-linux-tdep.c: Revert.
7316         * frame.c: Revert.
7317         * frame-unwind.c: Revert.
7318         * frame-base.c: Revert.
7319         * fork-child.c: Revert.
7320         * findvar.c: Revert.
7321         * findcmd.c: Revert.
7322         * filesystem.c: Revert.
7323         * filename-seen-cache.h: Revert.
7324         * filename-seen-cache.c: Revert.
7325         * fbsd-tdep.c: Revert.
7326         * fbsd-nat.h: Revert.
7327         * fbsd-nat.c: Revert.
7328         * f-valprint.c: Revert.
7329         * f-typeprint.c: Revert.
7330         * f-lang.c: Revert.
7331         * extension.h: Revert.
7332         * extension.c: Revert.
7333         * extension-priv.h: Revert.
7334         * expprint.c: Revert.
7335         * exec.h: Revert.
7336         * exec.c: Revert.
7337         * exceptions.c: Revert.
7338         * event-top.c: Revert.
7339         * event-loop.c: Revert.
7340         * eval.c: Revert.
7341         * elfread.c: Revert.
7342         * dwarf2read.h: Revert.
7343         * dwarf2read.c: Revert.
7344         * dwarf2loc.c: Revert.
7345         * dwarf2expr.h: Revert.
7346         * dwarf2expr.c: Revert.
7347         * dwarf2-frame.c: Revert.
7348         * dwarf2-frame-tailcall.c: Revert.
7349         * dwarf-index-write.h: Revert.
7350         * dwarf-index-write.c: Revert.
7351         * dwarf-index-common.c: Revert.
7352         * dwarf-index-cache.h: Revert.
7353         * dwarf-index-cache.c: Revert.
7354         * dummy-frame.c: Revert.
7355         * dtrace-probe.c: Revert.
7356         * disasm.h: Revert.
7357         * disasm.c: Revert.
7358         * disasm-selftests.c: Revert.
7359         * dictionary.c: Revert.
7360         * dicos-tdep.c: Revert.
7361         * demangle.c: Revert.
7362         * dcache.h: Revert.
7363         * dcache.c: Revert.
7364         * darwin-nat.h: Revert.
7365         * darwin-nat.c: Revert.
7366         * darwin-nat-info.c: Revert.
7367         * d-valprint.c: Revert.
7368         * d-namespace.c: Revert.
7369         * d-lang.c: Revert.
7370         * ctf.c: Revert.
7371         * csky-tdep.c: Revert.
7372         * csky-linux-tdep.c: Revert.
7373         * cris-tdep.c: Revert.
7374         * cris-linux-tdep.c: Revert.
7375         * cp-valprint.c: Revert.
7376         * cp-support.c: Revert.
7377         * cp-namespace.c: Revert.
7378         * cp-abi.c: Revert.
7379         * corelow.c: Revert.
7380         * corefile.c: Revert.
7381         * continuations.c: Revert.
7382         * completer.h: Revert.
7383         * completer.c: Revert.
7384         * complaints.c: Revert.
7385         * coffread.c: Revert.
7386         * coff-pe-read.c: Revert.
7387         * cli-out.h: Revert.
7388         * cli-out.c: Revert.
7389         * charset.c: Revert.
7390         * c-varobj.c: Revert.
7391         * c-valprint.c: Revert.
7392         * c-typeprint.c: Revert.
7393         * c-lang.c: Revert.
7394         * buildsym.c: Revert.
7395         * buildsym-legacy.c: Revert.
7396         * build-id.h: Revert.
7397         * build-id.c: Revert.
7398         * btrace.c: Revert.
7399         * bsd-uthread.c: Revert.
7400         * breakpoint.h: Revert.
7401         * breakpoint.c: Revert.
7402         * break-catch-throw.c: Revert.
7403         * break-catch-syscall.c: Revert.
7404         * break-catch-sig.c: Revert.
7405         * blockframe.c: Revert.
7406         * block.c: Revert.
7407         * bfin-tdep.c: Revert.
7408         * bfin-linux-tdep.c: Revert.
7409         * bfd-target.c: Revert.
7410         * bcache.c: Revert.
7411         * ax-general.c: Revert.
7412         * ax-gdb.h: Revert.
7413         * ax-gdb.c: Revert.
7414         * avr-tdep.c: Revert.
7415         * auxv.c: Revert.
7416         * auto-load.c: Revert.
7417         * arm-wince-tdep.c: Revert.
7418         * arm-tdep.c: Revert.
7419         * arm-symbian-tdep.c: Revert.
7420         * arm-pikeos-tdep.c: Revert.
7421         * arm-obsd-tdep.c: Revert.
7422         * arm-nbsd-tdep.c: Revert.
7423         * arm-nbsd-nat.c: Revert.
7424         * arm-linux-tdep.c: Revert.
7425         * arm-linux-nat.c: Revert.
7426         * arm-fbsd-tdep.c: Revert.
7427         * arm-fbsd-nat.c: Revert.
7428         * arm-bsd-tdep.c: Revert.
7429         * arch-utils.c: Revert.
7430         * arc-tdep.c: Revert.
7431         * arc-newlib-tdep.c: Revert.
7432         * annotate.h: Revert.
7433         * annotate.c: Revert.
7434         * amd64-windows-tdep.c: Revert.
7435         * amd64-windows-nat.c: Revert.
7436         * amd64-tdep.c: Revert.
7437         * amd64-sol2-tdep.c: Revert.
7438         * amd64-obsd-tdep.c: Revert.
7439         * amd64-obsd-nat.c: Revert.
7440         * amd64-nbsd-tdep.c: Revert.
7441         * amd64-nbsd-nat.c: Revert.
7442         * amd64-nat.c: Revert.
7443         * amd64-linux-tdep.c: Revert.
7444         * amd64-linux-nat.c: Revert.
7445         * amd64-fbsd-tdep.c: Revert.
7446         * amd64-fbsd-nat.c: Revert.
7447         * amd64-dicos-tdep.c: Revert.
7448         * amd64-darwin-tdep.c: Revert.
7449         * amd64-bsd-nat.c: Revert.
7450         * alpha-tdep.c: Revert.
7451         * alpha-obsd-tdep.c: Revert.
7452         * alpha-nbsd-tdep.c: Revert.
7453         * alpha-mdebug-tdep.c: Revert.
7454         * alpha-linux-tdep.c: Revert.
7455         * alpha-linux-nat.c: Revert.
7456         * alpha-bsd-tdep.c: Revert.
7457         * alpha-bsd-nat.c: Revert.
7458         * aix-thread.c: Revert.
7459         * agent.c: Revert.
7460         * addrmap.c: Revert.
7461         * ada-varobj.c: Revert.
7462         * ada-valprint.c: Revert.
7463         * ada-typeprint.c: Revert.
7464         * ada-tasks.c: Revert.
7465         * ada-lang.c: Revert.
7466         * aarch64-tdep.c: Revert.
7467         * aarch64-ravenscar-thread.c: Revert.
7468         * aarch64-newlib-tdep.c: Revert.
7469         * aarch64-linux-tdep.c: Revert.
7470         * aarch64-linux-nat.c: Revert.
7471         * aarch64-fbsd-tdep.c: Revert.
7472         * aarch64-fbsd-nat.c: Revert.
7473         * aarch32-linux-nat.c: Revert.
7474
7475 2019-04-05  Tom Tromey  <tom@tromey.com>
7476
7477         * ft32-tdep.c: Sort headers.
7478         * frv-tdep.c: Sort headers.
7479         * frv-linux-tdep.c: Sort headers.
7480         * frame.c: Sort headers.
7481         * frame-unwind.c: Sort headers.
7482         * frame-base.c: Sort headers.
7483         * fork-child.c: Sort headers.
7484         * findvar.c: Sort headers.
7485         * findcmd.c: Sort headers.
7486         * filesystem.c: Sort headers.
7487         * filename-seen-cache.h: Sort headers.
7488         * filename-seen-cache.c: Sort headers.
7489         * fbsd-tdep.c: Sort headers.
7490         * fbsd-nat.h: Sort headers.
7491         * fbsd-nat.c: Sort headers.
7492         * f-valprint.c: Sort headers.
7493         * f-typeprint.c: Sort headers.
7494         * f-lang.c: Sort headers.
7495         * extension.h: Sort headers.
7496         * extension.c: Sort headers.
7497         * extension-priv.h: Sort headers.
7498         * expprint.c: Sort headers.
7499         * exec.h: Sort headers.
7500         * exec.c: Sort headers.
7501         * exceptions.c: Sort headers.
7502         * event-top.c: Sort headers.
7503         * event-loop.c: Sort headers.
7504         * eval.c: Sort headers.
7505         * elfread.c: Sort headers.
7506         * dwarf2read.h: Sort headers.
7507         * dwarf2read.c: Sort headers.
7508         * dwarf2loc.c: Sort headers.
7509         * dwarf2expr.h: Sort headers.
7510         * dwarf2expr.c: Sort headers.
7511         * dwarf2-frame.c: Sort headers.
7512         * dwarf2-frame-tailcall.c: Sort headers.
7513         * dwarf-index-write.h: Sort headers.
7514         * dwarf-index-write.c: Sort headers.
7515         * dwarf-index-common.c: Sort headers.
7516         * dwarf-index-cache.h: Sort headers.
7517         * dwarf-index-cache.c: Sort headers.
7518         * dummy-frame.c: Sort headers.
7519         * dtrace-probe.c: Sort headers.
7520         * disasm.h: Sort headers.
7521         * disasm.c: Sort headers.
7522         * disasm-selftests.c: Sort headers.
7523         * dictionary.c: Sort headers.
7524         * dicos-tdep.c: Sort headers.
7525         * demangle.c: Sort headers.
7526         * dcache.h: Sort headers.
7527         * dcache.c: Sort headers.
7528         * darwin-nat.h: Sort headers.
7529         * darwin-nat.c: Sort headers.
7530         * darwin-nat-info.c: Sort headers.
7531         * d-valprint.c: Sort headers.
7532         * d-namespace.c: Sort headers.
7533         * d-lang.c: Sort headers.
7534         * ctf.c: Sort headers.
7535         * csky-tdep.c: Sort headers.
7536         * csky-linux-tdep.c: Sort headers.
7537         * cris-tdep.c: Sort headers.
7538         * cris-linux-tdep.c: Sort headers.
7539         * cp-valprint.c: Sort headers.
7540         * cp-support.c: Sort headers.
7541         * cp-namespace.c: Sort headers.
7542         * cp-abi.c: Sort headers.
7543         * corelow.c: Sort headers.
7544         * corefile.c: Sort headers.
7545         * continuations.c: Sort headers.
7546         * completer.h: Sort headers.
7547         * completer.c: Sort headers.
7548         * complaints.c: Sort headers.
7549         * coffread.c: Sort headers.
7550         * coff-pe-read.c: Sort headers.
7551         * cli-out.h: Sort headers.
7552         * cli-out.c: Sort headers.
7553         * charset.c: Sort headers.
7554         * c-varobj.c: Sort headers.
7555         * c-valprint.c: Sort headers.
7556         * c-typeprint.c: Sort headers.
7557         * c-lang.c: Sort headers.
7558         * buildsym.c: Sort headers.
7559         * buildsym-legacy.c: Sort headers.
7560         * build-id.h: Sort headers.
7561         * build-id.c: Sort headers.
7562         * btrace.c: Sort headers.
7563         * bsd-uthread.c: Sort headers.
7564         * breakpoint.h: Sort headers.
7565         * breakpoint.c: Sort headers.
7566         * break-catch-throw.c: Sort headers.
7567         * break-catch-syscall.c: Sort headers.
7568         * break-catch-sig.c: Sort headers.
7569         * blockframe.c: Sort headers.
7570         * block.c: Sort headers.
7571         * bfin-tdep.c: Sort headers.
7572         * bfin-linux-tdep.c: Sort headers.
7573         * bfd-target.c: Sort headers.
7574         * bcache.c: Sort headers.
7575         * ax-general.c: Sort headers.
7576         * ax-gdb.h: Sort headers.
7577         * ax-gdb.c: Sort headers.
7578         * avr-tdep.c: Sort headers.
7579         * auxv.c: Sort headers.
7580         * auto-load.c: Sort headers.
7581         * arm-wince-tdep.c: Sort headers.
7582         * arm-tdep.c: Sort headers.
7583         * arm-symbian-tdep.c: Sort headers.
7584         * arm-pikeos-tdep.c: Sort headers.
7585         * arm-obsd-tdep.c: Sort headers.
7586         * arm-nbsd-tdep.c: Sort headers.
7587         * arm-nbsd-nat.c: Sort headers.
7588         * arm-linux-tdep.c: Sort headers.
7589         * arm-linux-nat.c: Sort headers.
7590         * arm-fbsd-tdep.c: Sort headers.
7591         * arm-fbsd-nat.c: Sort headers.
7592         * arm-bsd-tdep.c: Sort headers.
7593         * arch-utils.c: Sort headers.
7594         * arc-tdep.c: Sort headers.
7595         * arc-newlib-tdep.c: Sort headers.
7596         * annotate.h: Sort headers.
7597         * annotate.c: Sort headers.
7598         * amd64-windows-tdep.c: Sort headers.
7599         * amd64-windows-nat.c: Sort headers.
7600         * amd64-tdep.c: Sort headers.
7601         * amd64-sol2-tdep.c: Sort headers.
7602         * amd64-obsd-tdep.c: Sort headers.
7603         * amd64-obsd-nat.c: Sort headers.
7604         * amd64-nbsd-tdep.c: Sort headers.
7605         * amd64-nbsd-nat.c: Sort headers.
7606         * amd64-nat.c: Sort headers.
7607         * amd64-linux-tdep.c: Sort headers.
7608         * amd64-linux-nat.c: Sort headers.
7609         * amd64-fbsd-tdep.c: Sort headers.
7610         * amd64-fbsd-nat.c: Sort headers.
7611         * amd64-dicos-tdep.c: Sort headers.
7612         * amd64-darwin-tdep.c: Sort headers.
7613         * amd64-bsd-nat.c: Sort headers.
7614         * alpha-tdep.c: Sort headers.
7615         * alpha-obsd-tdep.c: Sort headers.
7616         * alpha-nbsd-tdep.c: Sort headers.
7617         * alpha-mdebug-tdep.c: Sort headers.
7618         * alpha-linux-tdep.c: Sort headers.
7619         * alpha-linux-nat.c: Sort headers.
7620         * alpha-bsd-tdep.c: Sort headers.
7621         * alpha-bsd-nat.c: Sort headers.
7622         * aix-thread.c: Sort headers.
7623         * agent.c: Sort headers.
7624         * addrmap.c: Sort headers.
7625         * ada-varobj.c: Sort headers.
7626         * ada-valprint.c: Sort headers.
7627         * ada-typeprint.c: Sort headers.
7628         * ada-tasks.c: Sort headers.
7629         * ada-lang.c: Sort headers.
7630         * aarch64-tdep.c: Sort headers.
7631         * aarch64-ravenscar-thread.c: Sort headers.
7632         * aarch64-newlib-tdep.c: Sort headers.
7633         * aarch64-linux-tdep.c: Sort headers.
7634         * aarch64-linux-nat.c: Sort headers.
7635         * aarch64-fbsd-tdep.c: Sort headers.
7636         * aarch64-fbsd-nat.c: Sort headers.
7637         * aarch32-linux-nat.c: Sort headers.
7638
7639 2019-04-04  Tom Tromey  <tom@tromey.com>
7640
7641         * varobj.c (varobj_create): Update.
7642         * rust-exp.y (struct rust_parser) <update_innermost_block,
7643         lookup_symbol>: New methods.
7644         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7645         Rename.
7646         (rust_parser::rust_lookup_type)
7647         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7648         * printcmd.c (display_command, do_one_display): Update.
7649         * parser-defs.h (struct parser_state) <parser_state>: Add
7650         "tracker" parameter.
7651         (block_tracker): New member.
7652         (class innermost_block_tracker) <innermost_block_tracker>: Add
7653         "types" parameter.
7654         <reset>: Remove method.
7655         (innermost_block): Don't declare.
7656         (null_post_parser): Update.
7657         * parse.c (innermost_block): Remove global.
7658         (write_dollar_variable): Update.
7659         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7660         Remove "tracker_types" parameter.
7661         (parse_expression): Add "tracker" parameter.
7662         (parse_expression_for_completion): Update.
7663         (null_post_parser): Add "tracker" parameter.
7664         * p-exp.y: Update rules.
7665         * m2-exp.y: Update rules.
7666         * language.h (struct language_defn) <la_post_parser>: Add
7667         "tracker" parameter.
7668         * go-exp.y: Update rules.
7669         * f-exp.y: Update rules.
7670         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7671         parameter.
7672         * d-exp.y: Update rules.
7673         * c-exp.y: Update rules.
7674         * breakpoint.c (set_breakpoint_condition): Create an
7675         innermost_block_tracker.
7676         (watch_command_1): Likewise.
7677         * ada-lang.c (resolve): Add "tracker" parameter.
7678         (resolve_subexp): Likewise.
7679         * ada-exp.y (write_var_from_sym): Update.
7680
7681 2019-04-04  Tom Tromey  <tom@tromey.com>
7682
7683         * type-stack.h: New file.
7684         * type-stack.c: New file.
7685         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7686         type-stack.h.
7687         (insert_into_type_stack, insert_type, push_type, push_type_int)
7688         (insert_type_address_space, pop_type, pop_type_int)
7689         (pop_typelist, pop_type_stack, append_type_stack)
7690         (push_type_stack, get_type_stack, push_typelist)
7691         (follow_type_instance_flags, follow_types): Don't declare.
7692         * parse.c (type_stack): Remove global.
7693         (parse_exp_in_context): Update.
7694         (insert_into_type_stack, insert_type, push_type, push_type_int)
7695         (insert_type_address_space, pop_type, pop_type_int)
7696         (pop_typelist, pop_type_stack, append_type_stack)
7697         (push_type_stack, get_type_stack, push_typelist)
7698         (follow_type_instance_flags, follow_types): Remove (moved to
7699         type-stack.c).
7700         * f-exp.y (type_stack): New global.
7701         Update rules.
7702         (push_kind_type, f_parse): Update.
7703         * d-exp.y (type_stack): New global.
7704         Update rules.
7705         (d_parse): Update.
7706         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7707         Update rules.
7708         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7709         (HFILES_NO_SRCDIR): Add type-stack.h.
7710
7711 2019-04-04  Tom Tromey  <tom@tromey.com>
7712
7713         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7714         (rust_parser::convert_ast_to_expression, rust_parse)
7715         (rust_lex_test_completion, rust_lex_tests): Update.
7716         * parser-defs.h (struct expr_completion_state): New.
7717         (struct parser_state) <parser_state>: Add completion parameter.
7718         <mark_struct_expression, mark_completion_tag>: New methods.
7719         <parse_completion, m_completion_state>: New members.
7720         (prefixify_expression, null_post_parser): Update.
7721         (mark_struct_expression, mark_completion_tag): Don't declare.
7722         * parse.c (parse_completion, expout_last_struct)
7723         (expout_tag_completion_type, expout_completion_name): Remove
7724         globals.
7725         (parser_state::mark_struct_expression)
7726         (parser_state::mark_completion_tag): Now methods.
7727         (prefixify_expression): Add last_struct parameter.
7728         (prefixify_subexp): Likewise.
7729         (parse_exp_1): Update.
7730         (parse_exp_in_context): Add cstate parameter.  Update.
7731         (parse_expression_for_completion): Create an
7732         expr_completion_state.
7733         (null_post_parser): Add "completion" parameter.
7734         * p-exp.y: Update rules.
7735         (yylex): Update.
7736         * language.h (struct language_defn) <la_post_parser>: Add
7737         "completing" parameter.
7738         * go-exp.y: Update rules.
7739         (lex_one_token): Update.
7740         * expression.h (parse_completion): Don't declare.
7741         * d-exp.y: Update rules.
7742         (lex_one_token): Update rules.
7743         * c-exp.y: Update rules.
7744         (lex_one_token): Update.
7745         * ada-lang.c (resolve): Add "parse_completion" parameter.
7746         (resolve_subexp): Likewise.
7747         (ada_resolve_function): Likewise.
7748
7749 2019-04-04  Tom Tromey  <tom@tromey.com>
7750
7751         * parser-defs.h (struct parser_state) <start_arglist,
7752         end_arglist>: New methods.
7753         <arglist_len, m_funcall_chain>: New members.
7754         (arglist_len, start_arglist, end_arglist): Don't declare.
7755         * parse.c (arglist_len, funcall_chain): Remove global.
7756         (start_arglist, end_arglist): Remove functions.
7757         (parse_exp_in_context): Update.
7758         * p-exp.y: Update rules.
7759         * m2-exp.y: Update rules.
7760         * go-exp.y: Update rules.
7761         * f-exp.y: Update rules.
7762         * d-exp.y: Update rules.
7763         * c-exp.y: Update rules.
7764
7765 2019-04-04  Tom Tromey  <tom@tromey.com>
7766
7767         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7768         lex_operator, push_back>: New methods.
7769         Update all rules.
7770         (rust_parser::lex_hex, lex_escape): Rename and update.
7771         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7772         (rust_parser::lex_operator): Rename and update.
7773         (rust_parser::lex_number, rustyylex, rustyyerror)
7774         (rust_lex_test_init, rust_lex_test_sequence)
7775         (rust_lex_test_push_back, rust_lex_tests): Update.
7776         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7777         parameter.
7778         <lexptr, prev_lexptr>: New members.
7779         (lexptr, prev_lexptr): Don't declare.
7780         * parse.c (lexptr, prev_lexptr): Remove globals.
7781         (parse_exp_in_context): Update.
7782         * p-exp.y (yylex, yyerror): Update.
7783         * m2-exp.y (parse_number, yylex, yyerror): Update.
7784         * go-exp.y (lex_one_token, yyerror): Update.
7785         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7786         * d-exp.y (lex_one_token, yyerror): Update.
7787         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7788         (lex_one_token, yyerror): Update.
7789         * ada-lex.l (YY_INPUT): Update.
7790         (rewind_to_char): Update.
7791         * ada-exp.y (yyerror): Update.
7792
7793 2019-04-04  Tom Tromey  <tom@tromey.com>
7794
7795         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7796         * parser-defs.h (struct parser_state) <parser_state>: Add new
7797         parameter.
7798         <comma_terminates>: New member.
7799         (comma_terminates): Don't declare global.
7800         * parse.c (comma_terminates): Remove global.
7801         (parse_exp_in_context): Update.
7802         * p-exp.y (yylex): Update.
7803         * m2-exp.y (yylex): Update.
7804         * go-exp.y (lex_one_token): Update.
7805         * f-exp.y (yylex): Update.
7806         * d-exp.y (lex_one_token): Update.
7807         * c-exp.y (lex_one_token): Update.
7808         * ada-lex.l: Update.
7809
7810 2019-04-04  Tom Tromey  <tom@tromey.com>
7811
7812         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7813         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7814         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7815         * parser-defs.h (paren_depth): Don't declare.
7816         * parse.c (paren_depth): Remove global.
7817         (parse_exp_in_context): Update.
7818         * p-exp.y (paren_depth): New global.
7819         (pascal_parse): Initialize it.
7820         * m2-exp.y (paren_depth): New global.
7821         (m2_parse): Initialize it.
7822         * go-exp.y (paren_depth): New global.
7823         (go_parse): Initialize it.
7824         * f-exp.y (paren_depth): New global.
7825         (f_parse): Initialize it.
7826         * d-exp.y (paren_depth): New global.
7827         (d_parse): Initialize it.
7828         * c-exp.y (paren_depth): New global.
7829         (c_parse): Initialize it.
7830         * ada-lex.l (paren_depth): New global.
7831         (lexer_init): Initialize it.
7832
7833 2019-04-04  Tom Tromey  <tom@tromey.com>
7834
7835         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7836         (rust_parser::convert_ast_to_type)
7837         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7838         * parser-defs.h (struct parser_state) <parser_state>: Add
7839         parameters.  Initialize new members.
7840         <expression_context_block, expression_context_pc>: New members.
7841         * parse.c (expression_context_block, expression_context_pc):
7842         Remove globals.
7843         (parse_exp_in_context): Update.
7844         * p-exp.y: Update all rules.
7845         (yylex): Update.
7846         * m2-exp.y: Update all rules.
7847         (yylex): Update.
7848         * go-exp.y (yylex): Update.
7849         * f-exp.y (yylex): Update.
7850         * d-exp.y: Update all rules.
7851         (yylex): Update.
7852         * c-exp.y: Update all rules.
7853         (lex_one_token, classify_name, yylex, c_parse): Update.
7854         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7855
7856 2019-04-04  Tom Tromey  <tom@tromey.com>
7857
7858         * gdbarch.h, gdbarch.c: Rebuild.
7859         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7860         * stap-probe.h:
7861         (struct stap_parse_info): Replace "parser_state" with
7862         "expr_builder".
7863         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7864         (parser_state): New class.
7865         * parse.c (expr_builder): Rename.
7866         (expr_builder::release): Rename.
7867         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7868         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7869         (write_exp_elt_longcst, write_exp_elt_floatcst)
7870         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7871         (write_exp_string_vector, write_exp_bitstring)
7872         (write_exp_msymbol, mark_struct_expression)
7873         (write_dollar_variable)
7874         (insert_type_address_space, increase_expout_size): Replace
7875         "parser_state" with "expr_builder".
7876         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7877         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7878         "parser_state" with "expr_builder".
7879
7880 2019-04-04  Tom Tromey  <tom@tromey.com>
7881
7882         * rust-exp.y: Replace "parse_language" with method call.
7883         * p-exp.y:
7884         (yylex): Replace "parse_language" with method call.
7885         * m2-exp.y:
7886         (yylex): Replace "parse_language" with method call.
7887         * go-exp.y (classify_name): Replace "parse_language" with method
7888         call.
7889         * f-exp.y (yylex): Replace "parse_language" with method call.
7890         * d-exp.y (lex_one_token): Replace "parse_language" with method
7891         call.
7892         * c-exp.y:
7893         (lex_one_token, classify_name, yylex): Replace "parse_language"
7894         with method call.
7895         * ada-exp.y (find_primitive_type, type_char)
7896         (type_system_address): Replace "parse_language" with method call.
7897
7898 2019-04-04  Tom Tromey  <tom@tromey.com>
7899
7900         * rust-exp.y: Replace "parse_gdbarch" with method call.
7901         * parse.c (write_dollar_variable, insert_type_address_space):
7902         Replace "parse_gdbarch" with method call.
7903         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7904         call.
7905         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7906         call.
7907         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7908         "parse_gdbarch" with method call.
7909         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7910         with method call.
7911         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7912         "parse_gdbarch" with method call.
7913         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7914         "parse_gdbarch" with method call.
7915         * c-exp.y (parse_type, parse_number, classify_name): Replace
7916         "parse_gdbarch" with method call.
7917         * ada-lex.l: Replace "parse_gdbarch" with method call.
7918         * ada-exp.y (parse_type, find_primitive_type, type_char)
7919         (type_system_address): Replace "parse_gdbarch" with method call.
7920
7921 2019-04-04  Tom Tromey  <tom@tromey.com>
7922
7923         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7924         * stap-probe.c (stap_parse_argument): Update.
7925         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7926         initial_size parameter.
7927         * rust-exp.y (rust_lex_tests): Update.
7928         * parse.c (parser_state): Update.
7929         (parse_exp_in_context): Update.
7930         * parser-defs.h (struct parser_state) <parser_state>: Remove
7931         "initial_size" parameter.
7932
7933 2019-04-04  Tom Tromey  <tom@tromey.com>
7934
7935         * parser-defs.h (increase_expout_size): Don't declare.
7936         * parse.c (increase_expout_size): Now static.
7937
7938 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7939
7940         * gnu-nat.c (gnu_nat_target::wait): Fix
7941         target_waitstatus_to_string call.
7942
7943 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7944
7945         * eval.c (evaluate_subexp_standard): Handle internal functions
7946         during Fortran function call handling.
7947
7948 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7949
7950         * NEWS: Mention new internal functions.
7951         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7952         (read_base_type): Use dwarf2_init_complex_target_type.
7953         * value.c (creal_internal_fn): New function.
7954         (cimag_internal_fn): New function.
7955         (_initialize_values): Register new internal functions.
7956
7957 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7958
7959         * infrun.c (stop_all_threads): If debug_infrun, always
7960         trace the wait status after wait_one, using
7961         target_waitstatus_to_string and target_pid_to_str.
7962         (handle_inferior_event): Replace various trace of
7963         wait status kind by a single trace.
7964         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7965         wait status kind image by target_waitstatus_to_string.
7966         * target/waitstatus.c (target_waitstatus_to_string): Fix
7967         obsolete comment.
7968
7969 2019-04-01  Tom Tromey  <tromey@adacore.com>
7970
7971         PR symtab/23331:
7972         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7973
7974 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7975             Pedro Alves  <palves@redhat.com>
7976
7977         * top.c (quit_force): Call 'finalize_values'.
7978         * value.c (finalize_values): New function.
7979         * value.h (finalize_values): Declare.
7980
7981 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7982
7983         * NEWS: Announce $_gdb_major and $_gdb_minor.
7984
7985         * top.c (init_gdb_version_vars): New function.
7986         (gdb_init): Call init_gdb_version_vars.
7987
7988 2019-03-29  Tom Tromey  <tromey@adacore.com>
7989
7990         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7991         help text.  Remove dead code.
7992
7993 2019-03-29  Keith Seitz  <keiths@redhat.com>
7994
7995         From Siddhesh Poyarekar:
7996         * f-lang.h (f77_get_upperbound): Return LONGEST.
7997         (f77_get_lowerbound): Likewise.
7998         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7999         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8000         print them.
8001         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8002         plongest to format print it.
8003         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8004         (f77_get_upperbound): Likewise.
8005         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8006         LOWER_BOUND to LONGEST.
8007         (f77_create_arrayprint_offset_tbl): Likewise.
8008
8009 2019-03-29  Keith Seitz  <keiths@redhat.com>
8010
8011         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8012         %s/pulongest for TYPE_LENGTH instead of %d in format
8013         strings.
8014         * ada-typerint.c (ada_print_type): Likewise.
8015         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8016         * compile/compile-c-support.c (generate_register_struct): Likewise.
8017         * gdbtypes.c (recursive_dump_type): Likewise.
8018         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8019         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8020         instead of %d in format strings.
8021         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8022         to std::min to ULONGEST.
8023         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8024         instead of %d in format strings.
8025         * tracepoint.c (info_scope_command): Likewise.
8026         * typeprint.c (print_offset_data::update)
8027         (print_offset_data::finish): Likewise.
8028         * xtensa-tdep.c (xtensa_store_return_value)
8029         (xtensa_push_dummy_call): Likewise.
8030
8031 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8032
8033         * windows-nat.c (display_selector): Fixed format specifications
8034         for 64-bit Cygwin.
8035
8036 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8037
8038         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8039
8040 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8041
8042         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8043         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8044         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8045         (nios2_linux_init_abi): Install it.
8046
8047 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8048
8049         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8050
8051 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8052
8053         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8054
8055 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8056             Tom Tromey  <tromey@adacore.com>
8057
8058         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8059
8060 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8061
8062         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8063         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8064         method to compute the bounds of range types. Also print "[evaluated]"
8065         if the bounds' values come from a dynamic evaluation.
8066
8067 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8068
8069         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8070         whitespace when pretty printing is on.
8071
8072 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8073
8074         * ppc-linux-nat.c: Add include.
8075
8076 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8077
8078         * NEWS: Mention AArch64 Pointer Authentication.
8079
8080 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8081
8082         * arm-linux-nat.c: Add include.
8083
8084 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8085
8086         * source-cache.c (source_cache::get_source_lines): Re-read
8087         fullname after calling open_source_file.
8088
8089 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8090
8091         * NEWS: Mention TLS support for FreeBSD.
8092
8093 2019-03-25  Tom Tromey  <tromey@adacore.com>
8094
8095         * minsyms.c (BUNCH_SIZE): Update comment.
8096         (~minimal_symbol_reader): Remove old comment.
8097         (compact_minimal_symbols): Update comment.
8098         (minimal_symbol_reader::install): Remove old comment.  Update
8099         other comments.
8100
8101 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8102
8103         * s390-linux-nat.c: Add include.
8104
8105 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8106
8107         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8108         Call linux_get_hwcap.
8109         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8110         Likewise.
8111         (aarch64_linux_get_hwcap): Remove function.
8112         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8113         declaration.
8114         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8115         linux_get_hwcap.
8116         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8117         * linux-tdep.c (linux_get_hwcap): Add function.
8118         (linux_get_hwcap2): Likewise.
8119         * linux-tdep.h (linux_get_hwcap): Add declaration.
8120         (linux_get_hwcap2): Likewise.
8121         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8122         (ppc_linux_get_hwcap2): Likewise.
8123         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8124         linux_get_hwcap.
8125         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8126         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8127         (ppc_linux_nat_target::read_description): Likewise.
8128         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8129         * s390-linux-nat.c: Likewise.
8130         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8131
8132 2019-03-24  Tom Tromey  <tom@tromey.com>
8133
8134         * ada-lang.c (standard_lookup): Simplify initialization.
8135         (ada_lookup_symbol_nonlocal): Simplify return.
8136         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8137         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8138         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8139         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8140         initialization.
8141         * solib.c (solib_global_lookup): Simplify.
8142         * symtab.c (null_block_symbol): Remove.
8143         (symbol_cache_lookup): Simplify returns.
8144         (lookup_language_this): Simplify returns.
8145         (lookup_symbol_aux): Simplify return.
8146         (lookup_local_symbol): Simplify returns.
8147         (lookup_global_symbol_from_objfile): Simplify return.
8148         (lookup_symbol_in_objfile_symtabs)
8149         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8150         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8151         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8152         * cp-namespace.c (cp_lookup_bare_symbol)
8153         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8154         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8155         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8156         (cp_lookup_symbol_via_imports): Simplify initialization.
8157         (find_symbol_in_baseclass): Likewise.
8158         * symtab.h (null_block_symbol): Remove.
8159         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8160         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8161         (d_lookup_symbol_module): Likewise.
8162         (find_symbol_in_baseclass): Simplify initialization.
8163
8164 2019-03-24  Tom Tromey  <tom@tromey.com>
8165
8166         * expression.h: Don't include symtab.h.
8167         (struct block): Forward declare.
8168
8169 2019-03-24  Tom Tromey  <tom@tromey.com>
8170
8171         * c-exp.y (typebase): Remove casts.
8172         * gdbtypes.c (lookup_unsigned_typename, )
8173         (lookup_signed_typename): Remove cast.
8174         * eval.c (parse_to_comma_and_eval): Remove cast.
8175         * parse.c (write_dollar_variable): Remove cast.
8176         * block.h (struct block) <superblock>: Now const.
8177         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8178         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8179         (map_block): Make "block" const.
8180         * symfile.h (struct quick_symbol_functions)
8181         <map_matching_symbols>: Constify block argument to "callback".
8182         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8183         const.
8184         (find_pc_sect_compunit_symtab): Make "b" const.
8185         (find_symbol_at_address): Likewise.
8186         (search_symbols): Likewise.
8187         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8188         (dw2_debug_names_lookup_symbol): Likewise.
8189         (dw2_map_matching_symbols): Update.
8190         * p-valprint.c (pascal_val_print): Remove "block".
8191         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8192         (aux_add_nonlocal_symbols): Make "block" const.
8193         (resolve_subexp): Remove cast.
8194         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8195         const.
8196         (iterate_over_file_blocks): Likewise.
8197         * f-exp.y (%union) <bval>: Remove.
8198         * coffread.c (patch_opaque_types): Make "b" const.
8199         * spu-tdep.c (spu_catch_start): Make "block" const.
8200         * c-valprint.c (print_unpacked_pointer): Remove "block".
8201         * symmisc.c (dump_symtab_1): Make "b" const.
8202         (block_depth): Make "block" const.
8203         * d-exp.y (%union) <bval>: Remove.
8204         * cp-support.h (cp_lookup_rtti_type): Update.
8205         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8206         * psymtab.c (psym_lookup_symbol): Make "block" const.
8207         (maintenance_check_psymtabs): Make "b" const.
8208         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8209         (enumerate_locals, enumerate_args): Update.
8210         * python/py-symtab.c (stpy_global_block): Make "block" const.
8211         (stpy_static_block): Likewise.
8212         * inline-frame.c (block_starting_point_at): Make "new_block"
8213         const.
8214         * block.c (find_block_in_blockvector): Make return type const.
8215         (blockvector_for_pc_sect): Make "b" const.
8216         (find_block_in_blockvector): Make "b" const.
8217
8218 2019-03-23  Tom Tromey  <tom@tromey.com>
8219
8220         * varobj.c (varobj_create): Update.
8221         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8222         * printcmd.c (display_command, do_one_display): Don't reset
8223         innermost_block.
8224         * parser-defs.h (enum innermost_block_tracker_type): Move to
8225         expression.h.
8226         (innermost_block): Update comment.
8227         * parse.c (parse_exp_1): Add tracker_types parameter.
8228         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8229         tracker_types parameter.  Reset innermost_block.
8230         (parse_exp_in_context): Remove.
8231         (parse_expression_for_completion): Update.
8232         * objfiles.c (~objfile): Don't reset expression_context_block or
8233         innermost_block.
8234         * expression.h (enum innermost_block_tracker_type): Move from
8235         parser-defs.h.
8236         (parse_exp_1): Add tracker_types parameter.
8237         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8238         reset innermost_block.
8239
8240 2019-03-23  Tom Tromey  <tom@tromey.com>
8241
8242         * objfiles.h: Include bcache.h.
8243
8244 2019-03-23  Tom Tromey  <tom@tromey.com>
8245
8246         * linespec.c (get_current_search_block): Use
8247         scoped_restore_current_language.
8248         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8249
8250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8251             Jiong Wang  <jiong.wang@arm.com>
8252
8253         * aarch64-linux-tdep.c
8254         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8255         section.
8256         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8257
8258 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8259             Jiong Wang  <jiong.wang@arm.com>
8260
8261         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8262         instructions.
8263         (aarch64_analyze_prologue_test): Add PACIASP test.
8264         (aarch64_prologue_prev_register): Unmask PC value.
8265
8266 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8267             Jiong Wang  <jiong.wang@arm.com>
8268
8269         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8270         (aarch64_dwarf2_prev_register): Unmask PC value.
8271         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8272         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8273         DW_CFA_AARCH64_negate_ra_state.
8274         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8275
8276 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8277             Jiong Wang  <jiong.wang@arm.com>
8278
8279         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8280         registers.
8281         (aarch64_pseudo_register_name): Likewise.
8282         (aarch64_pseudo_register_type): Likewise.
8283         (aarch64_pseudo_register_reggroup_p): Likewise.
8284         (aarch64_gdbarch_init): Add pauth registers.
8285         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8286         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8287         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8288         (struct gdbarch_tdep): Add regnum for ra_state.
8289
8290 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8291             Jiong Wang  <jiong.wang@arm.com>
8292
8293         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8294
8295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8296             Jiong Wang  <jiong.wang@arm.com>
8297
8298         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8299         function.
8300         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8301         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8302         (aarch64_gdbarch_init): Add puth registers.
8303         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8304         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8305         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8306
8307 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8308             Jiong Wang  <jiong.wang@arm.com>
8309
8310         * aarch64-linux-nat.c
8311         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8312         * aarch64-linux-tdep.c
8313         (aarch64_linux_core_read_description): Likewise.
8314         (aarch64_linux_get_hwcap): New function.
8315         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8316         (aarch64_linux_get_hwcap): New declaration.
8317
8318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8319             Jiong Wang  <jiong.wang@arm.com>
8320
8321         * aarch64-linux-nat.c
8322         (aarch64_linux_nat_target::read_description): Add pauth param.
8323         * aarch64-linux-tdep.c
8324         (aarch64_linux_core_read_description): Likewise.
8325         * aarch64-tdep.c (struct target_desc): Add in pauth.
8326         (aarch64_read_description): Add pauth param.
8327         (aarch64_gdbarch_init): Likewise.
8328         * aarch64-tdep.h (aarch64_read_description): Likewise.
8329         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8330         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8331         * features/Makefile: Add new files.
8332         * features/aarch64-pauth.c: New file.
8333         * features/aarch64-pauth.xml: New file.
8334
8335 2019-03-20  Tom Tromey  <tromey@adacore.com>
8336
8337         * infrun.c (handle_inferior_event): Rename from
8338         handle_inferior_event_1.  Create a scoped_value_mark.
8339         (handle_inferior_event): Remove.
8340
8341 2019-03-19  Tom Tromey  <tromey@adacore.com>
8342
8343         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8344         * infrun.h (print_stop_event): Add "displays" parameter.
8345         * infrun.c (print_stop_event): Add "displays" parameter.
8346
8347 2019-03-19  Pedro Alves  <palves@redhat.com>
8348
8349         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8350         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8351         to -1.  Fix TABs vs spaces.
8352         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8353         * tui/tui-out.h (tui_ui_out) Add intro comments.
8354         <m_line, m_start_of_line>: In-class initialize, and add describing
8355         comment.
8356
8357 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8358
8359         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8360         variable names.
8361         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8362
8363 2019-03-18  Pedro Alves  <palves@redhat.com>
8364             Eli Zaretskii <eliz@gnu.org>
8365
8366         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8367         m_line and m_start_of_line.
8368
8369 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8370
8371         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8372         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8373         it returns a newline.  This fixes a regression in TU mode, whereby
8374         the next line is output on the same screen line as the user input.
8375
8376 2019-03-18  Tom Tromey  <tromey@adacore.com>
8377
8378         * minsyms.c (minimal_symbol_reader::install): Remove call to
8379         obstack_blank.
8380
8381 2019-03-18  Pedro Alves  <palves@redhat.com>
8382
8383         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8384         New globals.
8385         (apply_style): New, factored out from ...
8386         (apply_ansi_escape): ... this.  Handle reverse video mode.
8387         (tui_set_reverse_mode): New function.
8388         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8389         * tui/tui-winsource.c (tui_show_source_line): Use
8390         tui_set_reverse_mode instead of setting A_STANDOUT.
8391         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8392         New setter methods.
8393
8394 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8395
8396         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8397         Handle tabs.
8398
8399 2019-03-18  Tom Tromey  <tromey@adacore.com>
8400
8401         * ada-lang.c (empty_array): Add "high" parameter.
8402         (ada_evaluate_subexp): Update.
8403
8404 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8405
8406         * unittests/string_view-selftests.c: Define
8407         _initialize_string_view_selftests unconditionally.
8408
8409 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8410
8411         PR gdb/24350
8412         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8413
8414 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8415
8416         PR gdb/24351
8417         * windows-nat.c (display_selector): Fix format specifiers.
8418
8419 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8420
8421         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8422         tui_refill_source_window instead of tui_refresh_win, to update the
8423         current execution line.  This fixes redisplay of the current line
8424         when stepping through the code with "next" or "step".
8425
8426 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8427
8428         * source-cache.c (source_cache::get_source_lines): Call
8429         find_source_lines to initialize s->nlines.  This fixes vertical
8430         scrolling of TUI source window when the DOWN arrow is pressed.
8431
8432 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8433
8434         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8435         linux-thread-db.c (_initialize_thread_db): Likewise.
8436
8437 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8438
8439         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8440         wclrtoeol in tui_show_source_line".  This reverts changes made in
8441         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8442
8443 2019-03-15  Tom Tromey  <tom@tromey.com>
8444
8445         * symtab.h (struct minimal_symbol): Derive from
8446         general_symbol_info.
8447         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8448         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8449         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8450         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8451         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8452         (MSYMBOL_SEARCH_NAME): Update.
8453         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8454         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8455         * minsyms.c (minimal_symbol_reader::record_full): Update.
8456
8457 2019-03-15  Tom Tromey  <tom@tromey.com>
8458
8459         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8460
8461 2019-03-15  Tom Tromey  <tom@tromey.com>
8462
8463         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8464         unique_xmalloc_ptr.
8465         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8466         Update.
8467         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8468         (build_minimal_symbol_hash_tables)
8469         (minimal_symbol_reader::install): Update.
8470
8471 2019-03-15  Tom Tromey  <tom@tromey.com>
8472
8473         * symtab.c (create_demangled_names_hash): Update.
8474         (symbol_set_names): Update.
8475         * objfiles.h (struct objfile_per_bfd_storage)
8476         <demangled_names_hash>: Now an htab_up.
8477         * objfiles.c (objfile_per_bfd_storage): Simplify.
8478
8479 2019-03-15  Tom Tromey  <tom@tromey.com>
8480
8481         * objfiles.h (struct objfile_per_bfd_storage): Declare
8482         destructor.
8483         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8484         New.
8485         (get_objfile_bfd_data): Use new.  Don't initialize
8486         language_of_main.
8487         (free_objfile_per_bfd_storage): Remove.
8488         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8489
8490 2019-03-15  Tom Tromey  <tom@tromey.com>
8491
8492         * symfile.c (reread_symbols): Update.
8493         * objfiles.c (objfile::objfile): Update.
8494         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8495         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8496         comment.
8497         (minimal_symbol_reader::install): Update.
8498         (terminate_minimal_symbol_table): Remove.
8499         * jit.c (jit_object_close_impl): Update.
8500
8501 2019-03-15  Tom Tromey  <tom@tromey.com>
8502
8503         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8504         initializations.
8505
8506 2019-03-15  Tom Tromey  <tom@tromey.com>
8507
8508         * objfiles.h (struct objfile_per_bfd_storage)
8509         <demangled_hash_languages>: Now a bitset.
8510         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8511         (lookup_minimal_symbol): Update.
8512
8513 2019-03-15  Tom Tromey  <tom@tromey.com>
8514
8515         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8516         Don't return the symbol.
8517         * coffread.c (record_minimal_symbol): Use record_full.
8518
8519 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8520
8521         The MS-Windows port of ncurses fails to switch to a color pair if
8522         one or both of the colors are the implicit default colors.  This
8523         change records the default colors when TUI is initialized, and
8524         then specifies them explicitly when a color pair uses the default
8525         colors.  This allows color styling in TUI mode on MS-Windows.
8526
8527         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8528         ncurses_norm_attr.
8529         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8530         colors in ncurses_norm_attr.
8531         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8532         "none", replace it with the default color recorded in
8533         ncurses_norm_attr.
8534
8535 2019-03-14  Tom Tromey  <tromey@adacore.com>
8536
8537         * source-cache.h (class source_cache) <get_source_lines>: Return
8538         std::string.
8539         * source-cache.c (source_cache::extract_lines): Handle case where
8540         first_pos==npos.  Return std::string.
8541         (source_cache::get_source_lines): Update.
8542
8543 2019-03-14  Tom Tromey  <tromey@adacore.com>
8544
8545         * NEWS: Add item for "style sources" commands.
8546         * source-cache.c (source_cache::get_source_lines): Check
8547         source_styling.
8548         * cli/cli-style.c (source_styling): New global.
8549         (_initialize_cli_style): Add "style sources" commands.
8550         (show_style_sources): New function.
8551         * cli/cli-style.h (source_styling): Declare.
8552
8553 2019-03-14  Pedro Alves  <palves@redhat.com>
8554             Tom Tromey  <tromey@adacore.com>
8555
8556         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8557         * tui/tui-winsource.c (tui_refill_source_window): New function,
8558         from...
8559         (tui_horizontal_source_scroll): ... here.  Move some logic.
8560         * cli/cli-style.c (set_style_enabled): Notify new observable.
8561         * tui/tui-hooks.c (tui_redisplay_source): New function.
8562         (tui_attach_detach_observers): Attach or detach
8563         tui_redisplay_source.
8564         * observable.h (source_styling_changed): New observable.
8565         * observable.c: Define source_styling_changed observable.
8566
8567 2019-03-13  Tom Tromey  <tromey@adacore.com>
8568
8569         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8570         (i386_gnu_nat_target::store_registers): Update.
8571         * target-debug.h (target_debug_print_std_string): New macro.
8572         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8573         * windows-tdep.c (display_one_tib): Update.
8574         * tui/tui-stack.c (tui_make_status_line): Update.
8575         * top.c (print_inferior_quit_action): Update.
8576         * thread.c (thr_try_catch_cmd): Update.
8577         (add_thread_with_info): Update.
8578         (thread_target_id_str): Update.
8579         (thr_try_catch_cmd): Update.
8580         (thread_command): Update.
8581         (thread_find_command): Update.
8582         * record-btrace.c (record_btrace_target::info_record)
8583         (record_btrace_resume_thread, record_btrace_target::resume)
8584         (record_btrace_cancel_resume, record_btrace_step_thread)
8585         (record_btrace_target::wait, record_btrace_target::wait)
8586         (record_btrace_target::wait, record_btrace_target::stop): Update.
8587         * progspace.c (print_program_space): Update.
8588         * process-stratum-target.c
8589         (process_stratum_target::thread_address_space): Update.
8590         * linux-fork.c (linux_fork_mourn_inferior)
8591         (detach_checkpoint_command, info_checkpoints_command)
8592         (linux_fork_context): Update.
8593         (linux_fork_detach): Update.
8594         (class scoped_switch_fork_info): Update.
8595         (delete_checkpoint_command): Update.
8596         * infrun.c (follow_fork_inferior): Update.
8597         (follow_fork_inferior): Update.
8598         (proceed_after_vfork_done): Update.
8599         (handle_vfork_child_exec_or_exit): Update.
8600         (follow_exec): Update.
8601         (displaced_step_prepare_throw): Update.
8602         (displaced_step_restore): Update.
8603         (start_step_over): Update.
8604         (resume_1): Update.
8605         (clear_proceed_status_thread): Update.
8606         (proceed): Update.
8607         (print_target_wait_results): Update.
8608         (do_target_wait): Update.
8609         (context_switch): Update.
8610         (stop_all_threads): Update.
8611         (restart_threads): Update.
8612         (finish_step_over): Update.
8613         (handle_signal_stop): Update.
8614         (switch_back_to_stepped_thread): Update.
8615         (keep_going_pass_signal): Update.
8616         (print_exited_reason): Update.
8617         (normal_stop): Update.
8618         * inferior.c (inferior_pid_to_str): Change return type.
8619         (print_selected_inferior): Update.
8620         (add_inferior): Update.
8621         (detach_inferior): Update.
8622         * dummy-frame.c (fprint_dummy_frames): Update.
8623         * dcache.c (dcache_info_1): Update.
8624         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8625         (btrace_fetch, btrace_clear): Update.
8626         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8627         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8628         type.
8629         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8630         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8631         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8632         * gdbarch.c, gdbarch.h: Rebuild.
8633         * gdbarch.sh (core_pid_to_str): Change return type.
8634         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8635         return type.
8636         (windows_nat_target::pid_to_str): Change return type.
8637         (windows_delete_thread): Update.
8638         (windows_nat_target::attach): Update.
8639         (windows_nat_target::files_info): Update.
8640         * target-delegates.c: Rebuild.
8641         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8642         return type.
8643         (sol_thread_target::pid_to_str): Change return type.
8644         * remote.c (class remote_target) <pid_to_str>: Change return
8645         type.
8646         (remote_target::pid_to_str): Change return type.
8647         (extended_remote_target::attach, remote_target::remote_stop_ns)
8648         (remote_target::remote_notif_remove_queued_reply)
8649         (remote_target::push_stop_reply, remote_target::disable_btrace):
8650         Update.
8651         (extended_remote_target::attach): Update.
8652         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8653         type.
8654         (gdbsim_target::pid_to_str): Change return type.
8655         * ravenscar-thread.c (struct ravenscar_thread_target)
8656         <pid_to_str>: Change return type.
8657         (ravenscar_thread_target::pid_to_str): Change return type.
8658         * procfs.c (class procfs_target) <pid_to_str>: Change return
8659         type.
8660         (procfs_target::pid_to_str): Change return type.
8661         (procfs_target::attach): Update.
8662         (procfs_target::detach): Update.
8663         (procfs_target::fetch_registers): Update.
8664         (procfs_target::store_registers): Update.
8665         (procfs_target::wait): Update.
8666         (procfs_target::files_info): Update.
8667         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8668         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8669         return type.
8670         (nto_procfs_target::pid_to_str): Change return type.
8671         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8672         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8673         return type.
8674         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8675         (exit_lwp): Update.
8676         (attach_proc_task_lwp_callback, get_detach_signal)
8677         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8678         (linux_nat_target::resume, wait_lwp, stop_callback)
8679         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8680         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8681         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8682         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8683         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8684         type.
8685         (inf_ptrace_target::attach): Update.
8686         (inf_ptrace_target::files_info): Update.
8687         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8688         type.
8689         (go32_nat_target::pid_to_str): Change return type.
8690         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8691         (gnu_nat_target::wait): Update.
8692         (gnu_nat_target::wait): Update.
8693         (gnu_nat_target::resume): Update.
8694         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8695         (fbsd_nat_target::wait): Update.
8696         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8697         type.
8698         (darwin_nat_target::attach): Update.
8699         * corelow.c (class core_target) <pid_to_str>: Change return type.
8700         (core_target::pid_to_str): Change return type.
8701         * target.c (normal_pid_to_str): Change return type.
8702         (default_pid_to_str): Likewise.
8703         (target_pid_to_str): Change return type.
8704         (target_translate_tls_address): Update.
8705         (target_announce_detach): Update.
8706         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8707         return type.
8708         (bsd_uthread_target::pid_to_str): Change return type.
8709         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8710         type.
8711         (bsd_kvm_target::pid_to_str): Change return type.
8712         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8713         return type.
8714         (aix_thread_target::pid_to_str): Change return type.
8715         * target.h (struct target_ops) <pid_to_str>: Change return type.
8716         (target_pid_to_str, normal_pid_to_str): Likewise.
8717         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8718         type.
8719         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8720         type.
8721         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8722         return type.
8723         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8724         type.
8725         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8726         type.
8727         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8728         return type.
8729
8730 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8731
8732         * NEWS: Mention that the new default MI version is 3.  Mention
8733         changes to the output of commands and events that deal with
8734         multi-location breakpoints.
8735         * breakpoint.c: Include "mi/mi-out.h".
8736         (print_one_breakpoint): Change output syntax if using MI version
8737         >= 3.
8738         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8739         New.
8740         (mi_multi_location_breakpoint_output_fixed): New.
8741         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8742         (mi_cmd_fix_multi_location_breakpoint_output): New.
8743         (mi_multi_location_breakpoint_output_fixed): New.
8744         * mi/mi-cmds.c (mi_cmds): Register command
8745         -fix-multi-location-breakpoint-output.
8746         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8747         interpreter "mi".
8748
8749 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8750
8751         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8752         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8753         instantiate mi_ui_out based on interpreter name.
8754         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8755         * mi/mi-main.c (mi_load_progress): Likewise.
8756
8757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8758
8759         * NEWS: Combine separate "New targets" sections for 8.3.
8760
8761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8762
8763         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8764         (ppcfbsd_init_abi): Install gdbarch
8765         "fetch_tls_load_module_address" and "get_thread_local_address"
8766         methods.
8767
8768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8769
8770         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8771         (riscv_fbsd_init_abi): Install gdbarch
8772         "fetch_tls_load_module_address" and "get_thread_local_address"
8773         methods.
8774
8775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8776
8777         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8778         (i386fbsd_init_abi): Install gdbarch
8779         "fetch_tls_load_module_address" and "get_thread_local_address"
8780         methods.
8781
8782 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8783
8784         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8785         (amd64fbsd_init_abi): Install gdbarch
8786         "fetch_tls_load_module_address" and "get_thread_local_address"
8787         methods.
8788
8789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8790
8791         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8792         (struct fbsd_pspace_data): New type.
8793         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8794         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8795         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8796         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8797         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8798
8799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8800
8801         * gdbtypes.c (lookup_struct_elt): New function.
8802         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8803         * gdbtypes.h (struct struct_elt): New type.
8804         (lookup_struct_elt): New prototype.
8805
8806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8807
8808         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8809         remove disabled code block.
8810
8811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8812
8813         * gdbarch.sh (get_thread_local_address): New method.
8814         * gdbarch.h, gdbarch.c: Regenerate.
8815         * target.c (target_translate_tls_address): Use
8816         gdbarch_get_thread_local_address if present instead of
8817         target::get_thread_local_address.
8818
8819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8820
8821         * target.h (target::get_thread_local_address): Update comment.
8822
8823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8824
8825         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8826         objfile->separate_debug_objfile_backlink if not NULL.
8827
8828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8829
8830         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8831         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8832         (amd64bsd_store_inferior_registers): Likewise.
8833         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8834         Enable segment base registers.
8835         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8836         PT_GETFSBASE and PT_GETGSBASE.
8837         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8838         PT_SETGSBASE.
8839         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8840         segment base registers.
8841         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8842
8843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8844
8845         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8846         Update calls to i386_target_description to add 'segments'
8847         parameter.
8848         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8849         add segment base registers.
8850         * arch/i386.c (i386_create_target_description): Add 'segments'
8851         parameter to enable segment base registers.
8852         * arch/i386.h (i386_create_target_description): Likewise.
8853         * features/i386/32bit-segments.xml: New file.
8854         * features/i386/32bit-segments.c: Generate.
8855         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8856         call to i386_target_description to add 'segments' parameter.
8857         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8858         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8859         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8860         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8861         if feature is present.
8862         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8863         Add 'segments' parameter to call to i386_target_description.
8864         (i386_target_description): Add 'segments' parameter to enable
8865         segment base registers.
8866         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8867         to call to i386_target_description.
8868         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8869         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8870         Define I386_NUM_REGS.
8871         (i386_target_description): Add 'segments' parameter to enable
8872         segment base registers.
8873
8874 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8875
8876         PR/24325
8877         * source-cache.c: #undef open and close, to avoid unresolved
8878         externals during linking.
8879
8880 2019-03-12  Tom Tromey  <tromey@adacore.com>
8881
8882         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8883         const.  Add initializers.
8884         (_initialize_remote): Don't initialize ptid globals.
8885
8886 2019-03-12  Pedro Alves  <palves@redhat.com>
8887
8888         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8889
8890 2019-03-12  Pedro Alves  <palves@redhat.com>
8891
8892         * cp-name-parser.y (main): Remove unused 'len' variable.
8893
8894 2019-03-12  Tom Tromey  <tromey@adacore.com>
8895
8896         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8897         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8898
8899 2019-03-12  Tom Tromey  <tromey@adacore.com>
8900
8901         * linux-nat.c (iterate_over_lwps): Update.
8902         (stop_callback): Remove parameter.
8903         (stop_wait_callback, detach_callback, resume_set_callback)
8904         (select_singlestep_lwp_callback, set_ignore_sigint)
8905         (status_callback, resumed_callback, resume_clear_callback)
8906         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8907         data parameter.
8908         (linux_nat_target::detach, linux_nat_target::resume)
8909         (linux_stop_and_wait_all_lwps, select_event_lwp)
8910         (linux_nat_filter_event, linux_nat_wait_1)
8911         (linux_nat_target::kill, linux_nat_target::stop)
8912         (linux_nat_target::stop): Update.
8913         (linux_nat_resume_callback): Change type.
8914         (resume_stopped_resumed_lwps, count_events_callback)
8915         (select_event_lwp_callback): Likewise.
8916         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8917         * arm-linux-nat.c (struct update_registers_data): Remove.
8918         (update_registers_callback): Change type.
8919         (arm_linux_insert_hw_breakpoint1): Update.
8920         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8921         parameter.
8922         (x86_linux_dr_set_addr): Update.
8923         (x86_linux_dr_set_control): Update.
8924         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8925         (iterate_over_lwps): Use gdb::function_view.
8926         * nat/aarch64-linux-hw-point.c (struct
8927         aarch64_dr_update_callback_param): Remove.
8928         (debug_reg_change_callback): Change type.
8929         (aarch64_notify_debug_reg_change): Update.
8930         * s390-linux-nat.c (s390_refresh_per_info): Update.
8931
8932 2019-03-11  Tom Tromey  <tromey@adacore.com>
8933
8934         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8935         redundant assignment to "this_cu".
8936
8937 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8938
8939         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8940
8941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8942
8943         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8944         from...
8945         (rank_one_type): ... this.
8946
8947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8948
8949         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8950         from...
8951         (rank_one_type): ... this.
8952
8953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8954
8955         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8956         from...
8957         (rank_one_type): ... this.
8958
8959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8960
8961         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8962         from...
8963         (rank_one_type): ... this.
8964
8965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8966
8967         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8968         from...
8969         (rank_one_type): ... this.
8970
8971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8972
8973         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8974         from...
8975         (rank_one_type): ... this.
8976
8977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8978
8979         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8980         from...
8981         (rank_one_type): ... this.
8982
8983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8984
8985         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8986         from...
8987         (rank_one_type): ... this.
8988
8989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8990
8991         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8992         from...
8993         (rank_one_type): ... this.
8994
8995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8996
8997         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8998         from...
8999         (rank_one_type): ... this.
9000
9001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9002
9003         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9004         from...
9005         (rank_one_type): ... this.
9006
9007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9008
9009         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9010         from...
9011         (rank_one_type): ... this.
9012
9013 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9014
9015         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9016         inferior-events' shows the example events.
9017
9018 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9019
9020         Support styling on native MS-Windows console
9021
9022         PR/24315
9023         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9024         on MS-Windows if $TERM is not defined.
9025
9026         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9027
9028         * posix-hdep.c (gdb_console_fputs):
9029         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9030         functions.
9031         * ui-file.h (gdb_console_fputs): Add prototype.
9032
9033         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9034         back to fputs only if the former returns zero.
9035
9036 2019-03-07  Tom Tromey  <tom@tromey.com>
9037
9038         * symmisc.c (print_symbol_bcache_statistics): Update.
9039         (print_objfile_statistics): Update.
9040         * symfile.c (allocate_symtab): Update.
9041         * stabsread.c: Don't include bcache.h.
9042         * psymtab.h (struct psymbol_bcache): Don't declare.
9043         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9044         (psymbol_bcache_init, psymbol_bcache_free)
9045         (psymbol_bcache_get_bcache): Don't declare.
9046         * psymtab.c (struct psymbol_bcache): Remove.
9047         (psymtab_storage::psymtab_storage): Update.
9048         (psymtab_storage::~psymtab_storage): Update.
9049         (psymbol_bcache_init, psymbol_bcache_free)
9050         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9051         (add_psymbol_to_bcache): Update.
9052         (allocate_psymtab): Update.
9053         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9054         macro_cache>: No longer pointers.
9055         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9056         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9057         * macrotab.c (macro_bcache): Update.
9058         * macroexp.c: Don't include bcache.h.
9059         * gdbtypes.c (check_types_worklist): Update.
9060         (types_deeply_equal): Remove TRY/CATCH.  Update.
9061         * elfread.c (elf_symtab_read): Update.
9062         * dwarf2read.c: Don't include bcache.h.
9063         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9064         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9065         (print_bcache_statistics, bcache_memory_used): Don't declare.
9066         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9067         methods.  Rename all data members.
9068         * bcache.c (struct bcache): Move to bcache.h.
9069         (bcache::expand_hash_table): Rename from expand_hash_table.
9070         (bcache): Remove.
9071         (bcache::insert): Rename from bcache_full.
9072         (bcache::compare): Rename from bcache_compare.
9073         (bcache_xmalloc): Remove.
9074         (bcache::~bcache): Rename from bcache_xfree.
9075         (bcache::print_statistics): Rename from print_bcache_statistics.
9076         (bcache::memory_used): Rename from bcache_memory_used.
9077
9078 2019-03-07  Pedro Alves  <palves@redhat.com>
9079
9080         * infrun.c (normal_stop): Also check for
9081         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9082
9083 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9084
9085         * f-lang.c (value_from_host_double): Moved to...
9086         * value.c (value_from_host_double): ...here.
9087         * value.h (value_from_host_double): Declare.
9088         * guile/scm-math.c (vlscm_convert_typed_number): Use
9089         value_from_host_double.
9090         (vlscm_convert_number): Likewise.
9091         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9092         * python/py-value.c (convert_value_from_python): Likewise.
9093
9094 2019-03-06  Tom Tromey  <tom@tromey.com>
9095
9096         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9097
9098 2019-03-06  Tom Tromey  <tom@tromey.com>
9099
9100         * utils.h (free_current_contents): Don't declare.
9101         * utils.c (free_current_contents): Remove.
9102
9103 2019-03-06  Tom Tromey  <tom@tromey.com>
9104
9105         * top.c (quit_force): Update.
9106         * main.c (captured_command_loop): Update.
9107         * common/new-op.c (operator new): Update.
9108         * common/common-exceptions.c (struct catcher)
9109         <save_cleanup_chain>: Remove member.
9110         (exceptions_state_mc_init): Update.
9111         (exception_try_scope_entry): Return nullptr.
9112         (exception_try_scope_exit, exception_rethrow)
9113         (throw_exception_sjlj, throw_exception_cxx): Update.
9114         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9115         (all_cleanups, do_cleanups, discard_cleanups)
9116         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9117         (restore_cleanups, restore_final_cleanups): Don't declare.
9118         (do_final_cleanups): Remove parameter.
9119         * common/cleanups.c (cleanup_chain, make_cleanup)
9120         (make_cleanup_dtor, all_cleanups, do_cleanups)
9121         (discard_my_cleanups, discard_cleanups)
9122         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9123         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9124         (null_cleanup): Remove.
9125         (do_final_cleanups): Remove parameter.
9126
9127 2019-03-06  Tom Tromey  <tom@tromey.com>
9128
9129         * remote.c (remote_target::remote_parse_stop_reply): Use
9130         unique_xmalloc_ptr.
9131
9132 2019-03-06  Tom Tromey  <tom@tromey.com>
9133
9134         * stabsread.c (struct stabs_field_info): Rename from field_info.
9135         <list, fnlist>: Add initializers.
9136         <obstack>: New member.
9137         (read_member_functions, read_struct_fields, read_baseclasses):
9138         Allocate on obstack.  Don't use cleanups.
9139         (read_one_struct_field, read_member_functions, read_struct_fields)
9140         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9141         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9142         (read_struct_type): Update.
9143
9144 2019-03-06  Tom Tromey  <tom@tromey.com>
9145
9146         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9147         * common/filestuff.h (make_cleanup_close): Don't declare.
9148         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9149         Remove.
9150
9151 2019-03-06  Tom Tromey  <tom@tromey.com>
9152
9153         * solib-aix.c: Use make_scope_exit.
9154
9155 2019-03-06  Tom Tromey  <tom@tromey.com>
9156
9157         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9158         Use make_scope_exit.
9159
9160 2019-03-06  Tom Tromey  <tom@tromey.com>
9161
9162         * solib-svr4.c (disable_probes_interface): Remove parameter.
9163         (svr4_handle_solib_event): Use make_scope_exit.
9164
9165 2019-03-06  Tom Tromey  <tom@tromey.com>
9166
9167         * remote.c (struct stop_reply_deleter): Remove.
9168         (stop_reply_up): Update.
9169         (struct stop_reply): Derive from notif_event.  Don't typedef.
9170         <regcache>: Now a std::vector.
9171         (stop_reply_xfree): Remove.
9172         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9173         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9174         (remote_target::discard_pending_stop_replies): Use delete.
9175         (remote_target::remote_parse_stop_reply): Update.
9176         (remote_target::process_stop_reply): Update.
9177         * remote-notif.h (struct notif_event): Add virtual destructor.
9178         Remove "dtr" member.
9179         (struct notif_client) <alloc_event>: Return a unique_ptr.
9180         (notif_event_xfree): Don't declare.
9181         (notif_event_up): New typedef.
9182         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9183         (notif_event_xfree, do_notif_event_xfree): Remove.
9184         (remote_notif_state_xfree): Update.
9185
9186 2019-03-06  Tom Tromey  <tom@tromey.com>
9187
9188         * infrun.c (displaced_step_clear_cleanup): Now a
9189         forward_scope_exit type.
9190         (displaced_step_prepare_throw): Update.
9191         (displaced_step_fixup): Update.
9192
9193 2019-03-06  Tom Tromey  <tom@tromey.com>
9194
9195         * inferior.h (class inferior): Update comment.
9196         * gdbthread.h (class thread_info): Update comment.
9197
9198 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9199             Tom Tromey  <tom@tromey.com>
9200
9201         * stabsread.h (struct stab_section_list): Remove.
9202         (coffstab_build_psymtabs): Update.
9203         * dbxread.c (symbuf_sections): Now a std::vector.
9204         (sect_idx): New global.
9205         (fill_symbuf): Update.
9206         (coffstab_build_psymtabs): Change type of stabsects parameter.
9207         Update.
9208         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9209         std::vector.
9210         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9211         (coff_locate_sections): Update.
9212         (coff_symfile_read): Remove cleanups.  Update.
9213         (init_stringtab): Add storage parameter.
9214         (free_stringtab, free_stringtab_cleanup): Remove.
9215         (init_lineno): Add storage parameter.
9216         (free_linetab, free_linetab_cleanup): Remove.
9217
9218 2019-03-06  Pedro Alves  <palves@redhat.com>
9219
9220         * linux-fork.c (fork_info::clobber_regs): Delete.
9221         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9222         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9223         comment.  Adjust.
9224         (scoped_switch_fork_info::scoped_switch_fork_info)
9225         (checkpoint_command, linux_fork_context): Adjust
9226         fork_save_infrun_state calls.
9227
9228 2019-03-06  Pedro Alves  <palves@redhat.com>
9229
9230         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9231         (inf_has_multiple_threads): Return 'bool' and rewrite using
9232         inferior_info::threads().
9233
9234 2019-03-06  Pedro Alves  <palves@redhat.com>
9235
9236         * linux-fork.c: Include <list>.
9237         (fork_list): Now a std::list instance.
9238         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9239         (forks_exist_p, find_last_fork): Adjust.
9240         (new_fork): Delete.
9241         (one_fork_p): New.
9242         (add_fork): Adjust.
9243         (free_fork): Delete, folded into fork_info::~fork_info().
9244         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9245         Adjust.
9246         (init_fork_list): Delete.
9247         (linux_fork_killall, linux_fork_mourn_inferior)
9248         (linux_fork_detach, info_checkpoints_command): Adjust.
9249         (_initialize_linux_fork): No longer call init_fork_list.
9250
9251 2019-03-06  Pedro Alves  <palves@redhat.com>
9252
9253         * linux-fork.c (new_fork): New, split out of ...
9254         (add_fork): ... this.  Return void.  Move "first fork" special
9255         case from here, to ...
9256         (checkpoint_command): ... here.
9257         * linux-linux.h (add_fork): Return void.
9258
9259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9262
9263 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9264             Chris January  <chris.january@arm.com>
9265             David Lecomber  <david.lecomber@arm.com>
9266
9267         * f-exp.y: New token, UNOP_INTRINSIC.
9268         (exp): New pattern using UNOP_INTRINSIC token.
9269         (f77_keywords): Add 'abs' keyword.
9270         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9271         (value_from_host_double): New function.
9272         (evaluate_subexp_f): Support UNOP_ABS.
9273
9274 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9277         types.
9278
9279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9280
9281         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9282         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9283         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9284
9285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9288
9289 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9290             Chris January  <chris.january@arm.com>
9291
9292         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9293         * f-exp.y: Define 'KIND' token.
9294         (exp): New pattern for KIND expressions.
9295         (ptype): Handle types with a kind extension.
9296         (direct_abs_decl): Extend to spot kind extensions.
9297         (f77_keywords): Add 'kind' to the list.
9298         (push_kind_type): New function.
9299         (convert_to_kind_type): New function.
9300         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9301         * parse.c (operator_length_standard): Likewise.
9302         * parser-defs.h (enum type_pieces): Add tp_kind.
9303         * std-operator.def: Add UNOP_KIND.
9304
9305 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9306
9307         * f-exp.y (f_parse): Set yydebug.
9308
9309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9310
9311         * f-lang.c (evaluate_subexp_f): New function.
9312         (exp_descriptor_f): New global.
9313         (f_language_defn): Use exp_descriptor_f instead of
9314         exp_descriptor_standard.
9315
9316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * f-exp.y (struct token): Add comments.
9319         (dot_ops): Remove uppercase versions and the end marker.
9320         (f77_keywords): Likewise.
9321         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9322         entries in the dot_ops array are case insensitive, and use
9323         strncasecmp to compare strings.  Also some whitespace cleanup in
9324         this area.  Similar for the f77_keywords array, except entries in
9325         this list might be case sensitive.
9326
9327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9328
9329         * f-exp.y (struct f77_boolean_val): Add comments.
9330         (boolean_values): Remove uppercase versions, and end marker.
9331         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9332         and use strncasecmp to achieve case insensitivity.  Additionally,
9333         perform whitespace cleanup around this code.
9334
9335 2019-03-06  Tom Tromey  <tromey@adacore.com>
9336
9337         * remote-sim.c (gdbsim_target_open): Use result of
9338         gdb_argv::release.
9339
9340 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9341         Dirk Schubert  <dirk.schubert@arm.com>
9342         Chris January  <chris.january@arm.com>
9343
9344         * eval.c (evaluate_subexp_standard): Call Fortran argument
9345         wrapping logic.
9346         * f-lang.c (struct value): A value which can be passed into a
9347         Fortran function call.
9348         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9349         where appropriate.
9350         (struct type): Value ready for a Fortran function call.
9351         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9352         is needed.
9353         * f-lang.h (fortran_argument_convert): Declaration.
9354         (fortran_preserve_arg_pointer): Declaration.
9355         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9356
9357 2019-03-05  Tom Tromey  <tromey@adacore.com>
9358
9359         * python/py-prettyprint.c (print_string_repr): Remove #if.
9360         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9361
9362 2019-03-05  Tom Tromey  <tromey@adacore.com>
9363
9364         * target.c (the_dummy_target): Move later.  Change type to
9365         "dummy_target".
9366         (initialize_targets): Don't initialize the_dummy_target.
9367
9368 2019-03-05  Tom Tromey  <tromey@adacore.com>
9369
9370         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9371         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9372
9373 2019-03-05  Tom Tromey  <tromey@adacore.com>
9374
9375         * windows-nat.c (windows_nat_target::attach)
9376         (windows_nat_target::detach): Don't call gdb_flush.
9377         * valprint.c (generic_val_print, val_print, val_print_string):
9378         Don't call gdb_flush.
9379         * utils.c (defaulted_query): Don't call gdb_flush.
9380         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9381         * target.c (target_announce_detach): Don't call gdb_flush.
9382         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9383         * remote.c (extended_remote_target::attach): Don't call
9384         gdb_flush.
9385         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9386         * printcmd.c (do_examine): Don't call gdb_flush.
9387         (info_display_command): Don't call gdb_flush.
9388         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9389         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9390         * memattr.c (info_mem_command): Don't call gdb_flush.
9391         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9392         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9393         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9394         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9395         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9396         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9397         (gnu_nat_target::detach): Don't call gdb_flush.
9398         * f-valprint.c (f_val_print): Don't call gdb_flush.
9399         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9400         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9401         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9402         gdb_flush.
9403         * c-valprint.c (c_val_print): Don't call gdb_flush.
9404         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9405
9406 2019-03-05  Tom Tromey  <tromey@adacore.com>
9407
9408         * varobj.c (update_dynamic_varobj_children): Update.
9409         (install_default_visualizer): Use reset, not release.
9410         * value.c (set_internalvar): Update.
9411         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9412         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9413         ATTRIBUTE_UNUSED_RESULT.
9414
9415 2019-03-05  Tom Tromey  <tromey@adacore.com>
9416
9417         * remote.c (class scoped_remote_fd) <release>: Add
9418         ATTRIBUTE_UNUSED_RESULT.
9419
9420 2019-03-05  Tom Tromey  <tromey@adacore.com>
9421
9422         * macroexp.c (struct macro_buffer) <release>: Add
9423         ATTRIBUTE_UNUSED_RESULT.
9424
9425 2019-03-05  Tom Tromey  <tromey@adacore.com>
9426
9427         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9428         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9429         ATTRIBUTE_UNUSED_RESULT.
9430
9431 2019-03-05  Tom Tromey  <tromey@adacore.com>
9432
9433         * common/scoped_fd.h (class scoped_fd) <release>: Add
9434         ATTRIBUTE_UNUSED_RESULT.
9435
9436 2019-03-05  Tom Tromey  <tromey@adacore.com>
9437
9438         * parser-defs.h (struct parser_state) <release>: Add
9439         ATTRIBUTE_UNUSED_RESULT.
9440
9441 2019-03-05  Tom Tromey  <tromey@adacore.com>
9442
9443         * utils.h (class gdb_argv) <release>: Add
9444         ATTRIBUTE_UNUSED_RESULT.
9445         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9446
9447 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9448
9449         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9450         for-loop range, to avoid compiler warnings.
9451
9452         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9453         avoid compiler warnings about unused variables.
9454
9455         * NEWS: Mention end of support for native debugging on MS-Windows
9456         before XP.
9457
9458         PR gdb/24292
9459         * common/netstuff.c:
9460         * gdbserver/gdbreplay.c
9461         * gdbserver/remote-utils.c:
9462         * ser-tcp.c:
9463         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9464         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9465         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9466         'getaddrinfo' and 'freeaddrinfo' were not available before
9467         Windows XP, and mingw.org's MinGW headers by default define
9468         _WIN32_WINNT to 0x500.
9469
9470 2019-03-01  Gary Benson <gbenson@redhat.com>
9471
9472         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9473
9474 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9475             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9476
9477         PR gdb/8527
9478         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9479         set_sigint_trap, clear_sigint_trap.
9480
9481 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9482
9483         * target.c (target_detach): Clear the regcache and the
9484         frame cache.
9485
9486 2019-02-27  Pedro Alves  <palves@redhat.com>
9487
9488         * utils.c (set_screen_size): When we cap the height/width sizes,
9489         tweak the corresponding command variable to show "unlimited":
9490
9491 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9492             Pedro Alves  <palves@redhat.com>
9493
9494         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9495         before calling rl_set_screen_size.
9496
9497 2019-02-27  Tom Tromey  <tromey@adacore.com>
9498
9499         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9500         define.
9501         * python/py-value.c: Remove Python 2.4 workaround.
9502         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9503         workaround.
9504         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9505         Python 2.4 workaround.
9506         * python/python-internal.h: Remove Python 2.4 comment.
9507         (Py_ssize_t): Don't define.
9508         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9509         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9510         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9511         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9512         * python/python.c (do_start_initialization): Remove Python 2.4
9513         workaround.
9514         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9515         (print_children): Remove Python 2.4 workaround.
9516         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9517         workaround.
9518         (CHARBUFFERPROC_NAME): Remove.
9519         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9520         Python 2.4 workaround.
9521
9522 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9523
9524         * NEWS: Note minimum Python version.
9525
9526 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9527
9528         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9529         code from these functions.  Remove corresponding ifdefs.  Use
9530         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9531         Remove gotos and target of gotos.
9532         (infpy_search_memory): Likewise.
9533
9534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9535
9536         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9537         (hppa_gdbarch_init): Don't register deleted functions with
9538         gdbarch.
9539
9540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9541
9542         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9543         (h8300_unwind_sp): Delete.
9544         (h8300_dummy_id): Delete.
9545         (h8300_gdbarch_init): Don't register deleted functions with
9546         gdbarch.
9547
9548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9549
9550         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9551         (ft32_unwind_pc): Delete.
9552         (ft32_unwind_sp): Delete.
9553         (ft32_gdbarch_init): Don't register deleted functions with
9554         gdbarch.
9555
9556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9557
9558         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9559         (frv_unwind_pc): Delete.
9560         (frv_unwind_sp): Delete.
9561         (frv_gdbarch_init): Don't register deleted functions with
9562         gdbarch.
9563
9564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9565
9566         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9567         (riscv_unwind_pc): Delete.
9568         (riscv_unwind_sp): Delete.
9569         (riscv_gdbarch_init): Don't register deleted functions with
9570         gdbarch.
9571
9572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9573
9574         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9575         (csky_unwind_pc): Delete.
9576         (csky_unwind_sp): Delete.
9577         (csky_gdbarch_init): Don't register deleted functions with
9578         gdbarch.
9579
9580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9581
9582         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9583         (cris_unwind_pc): Delete.
9584         (cris_unwind_sp): Delete.
9585         (cris_gdbarch_init): Don't register deleted functions with
9586         gdbarch.
9587
9588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9589
9590         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9591         (bfin_unwind_pc): Delete.
9592         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9593
9594 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9595
9596         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9597         (arm_unwind_pc): Delete.
9598         (arm_unwind_sp): Delete.
9599         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9600
9601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9602
9603         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9604         (arc_unwind_pc): Delete.
9605         (arc_unwind_sp): Delete.
9606         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9607
9608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9609
9610         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9611         (alpha_unwind_pc): Delete.
9612         (alpha_gdbarch_init): Don't register deleted functions with
9613         gdbarch.
9614
9615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9616
9617         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9618         (aarch64_unwind_pc): Delete.
9619         (aarch64_unwind_sp): Delete.
9620         (aarch64_gdbarch_init): Don't register deleted functions with
9621         gdbarch.
9622
9623 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9624
9625         * gdbtypes.c (type_align): Don't consider static members when
9626         computing structure alignment.
9627
9628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9629
9630         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9631         return 0 for other types.
9632         * arch-utils.c (default_type_align): Always return 0.
9633         * gdbarch.h: Regenerate.
9634         * gdbarch.sh (type_align): Extend comment.
9635         * gdbtypes.c (type_align): Add additional comments, always call
9636         gdbarch_type_align before applying the default rules.
9637         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9638         generic code will then apply a suitable default.
9639         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9640         types, return 0 for other types.
9641
9642 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9643
9644         * NEWS: Create a new section for the next release branch.
9645         Rename the section of the current branch, now that it has
9646         been cut.
9647
9648 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9649
9650         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9651         * version.in: Bump version to 8.3.50.DATE-git.
9652
9653 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9654
9655         * aix-thread.c (ptid_cmp): Remove unused variable.
9656         (get_signaled_thread): Likewise.
9657         (store_regs_user_thread): Likewise.
9658         (store_regs_kernel_thread): Likewise.
9659         (fetch_regs_kernel_thread): Remove shadowed variable.
9660
9661 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9662
9663         * features/riscv/32bit-cpu.xml: Add register numbers.
9664         * features/riscv/32bit-fpu.c: Regenerate.
9665         * features/riscv/32bit-fpu.xml: Add register numbers.
9666         * features/riscv/64bit-cpu.xml: Add register numbers.
9667         * features/riscv/64bit-fpu.c: Regenerate.
9668         * features/riscv/64bit-fpu.xml: Add register numbers.
9669
9670 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9671
9672         * NEWS: Mention two argument form of gdb.Value constructor.
9673         * python/py-value.c (convert_buffer_and_type_to_value): New
9674         function.
9675         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9676         Add support for handling an optional second argument.  Call
9677         convert_buffer_and_type_to_value as appropriate.
9678         * python/python-internal.h (Py_buffer_deleter): New struct.
9679         (Py_buffer_up): New typedef.
9680
9681 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9682
9683         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9684         instead of releasing ownership.
9685
9686 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9687
9688         * dwarf2read.c (open_and_init_dwp_file): Call
9689         elf_numsections instead of bfd_count_sections to initialize
9690         dwp_file->num_sections.
9691
9692 2019-02-25  Tom Tromey  <tromey@adacore.com>
9693
9694         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9695
9696 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9697
9698         * gcore.in: Add '--readnever' option when invoking GDB.
9699
9700 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9701
9702         * MAINTAINERS: Update my email address.
9703
9704 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9705
9706         * build-id.c (build_id_to_debug_bfd_1): New function.
9707         (build_id_to_debug_bfd): Look for separate debug file in
9708         sysroot.
9709
9710 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9711
9712         * gdbarch.sh: Update the copyright year range that is placed into
9713         generated files.
9714
9715 2019-02-22  Keith Seitz  <keiths@redhat.com>
9716
9717         PR symtab/23853
9718         * linespec.c (create_sals_line_offset): Search for the default
9719         symtab's filename instead of its fullname.
9720
9721 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9722
9723         * NEWS: Update style defaults.
9724
9725 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9726
9727         * main.c (captured_main_1): Disable styling in batch mode.
9728
9729 2019-02-20  Tom Tromey  <tom@tromey.com>
9730
9731         * symtab.c (symtab_symbol_info): Fix typos.
9732
9733 2019-02-20  Tom Tromey  <tromey@adacore.com>
9734
9735         * findcmd.c (_initialize_mem_search): Use upper case for
9736         metasyntactic variables.
9737
9738 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9739
9740         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9741         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9742
9743 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9744
9745         * top.h (source_file_name): Change to std::string.
9746         * top.c (source_file_name): Likewise.
9747         (command_line_input): Adjust.
9748         * cli/cli-script.c (script_from_file): Adjust.
9749
9750 2019-02-19  Tom Tromey  <tromey@adacore.com>
9751
9752         * ravenscar-thread.c
9753         (ravenscar_thread_target::update_thread_list): Don't call
9754         ada_build_task_list.
9755         * ada-lang.h (ada_build_task_list): Don't declare.
9756         * ada-tasks.c (struct ada_tasks_inferior_data)
9757         <task_list_valid_p>: Now bool.
9758         (read_known_tasks, ada_task_list_changed)
9759         (ada_tasks_invalidate_inferior_data): Update.
9760         (read_known_tasks_array): Return bool.
9761         (read_known_tasks_list): Likewise.
9762         (read_known_tasks): Return void.
9763         (ada_build_task_list): Now static.
9764
9765 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9766
9767         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9768         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9769
9770 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9771
9772         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9773         variant for ada_tasks_pspace_data_handle and
9774         ada_tasks_inferior_data_handle.
9775         (ada_tasks_pspace_data_cleanup): New function.
9776         (ada_tasks_inferior_data_cleanup): New function.
9777
9778 2019-02-17  Tom Tromey  <tom@tromey.com>
9779
9780         * macrotab.h (macro_source_fullname): Return a std::string.
9781         * macrotab.c (macro_include, check_for_redefinition)
9782         (macro_undef, macro_lookup_definition, foreach_macro)
9783         (foreach_macro_in_scope): Update.
9784         (macro_source_fullname): Return a std::string.
9785         * macrocmd.c (show_pp_source_pos): Update.
9786
9787 2019-02-17  Tom Tromey  <tom@tromey.com>
9788
9789         * macrocmd.c (show_pp_source_pos): Style the file names.
9790
9791 2019-02-17  Tom Tromey  <tom@tromey.com>
9792
9793         PR tui/24197:
9794         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9795
9796 2019-02-17  Tom Tromey  <tom@tromey.com>
9797
9798         * ada-lang.c (user_select_syms): Use filtered printing.
9799         * utils.c (wrap_style): New global.
9800         (desired_style): Remove.
9801         (emit_style_escape): Add stream parameter.
9802         (set_output_style, reset_terminal_style, prompt_for_continue):
9803         Update.
9804         (flush_wrap_buffer): Only flush gdb_stdout.
9805         (wrap_here): Set wrap_style.
9806         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9807         treat escape sequences as a character.  Change when wrap buffer is
9808         flushed.
9809         (fputs_styled): Do not set the output style when the default is
9810         requested.
9811         * ui-style.h (struct ui_file_style) <is_default>: New method.
9812         * source.c (print_source_lines_base): Emit escape sequences in one
9813         piece.
9814
9815 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9816
9817         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9818         integers and enumeration types.
9819
9820 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9821
9822         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9823         instead of lookup_symbol_in_language
9824         (do_exact_match): New function.
9825         (ada_get_symbol_name_matcher): Return do_exact_match when
9826         doing a verbatim match.
9827
9828 2019-02-15  Tom Tromey  <tromey@adacore.com>
9829
9830         * ravenscar-thread.c (ravenscar_thread_target::resume)
9831         (ravenscar_thread_target::wait): Special case wildcard requests.
9832
9833 2019-02-15  Tom Tromey  <tromey@adacore.com>
9834
9835         * ravenscar-thread.c (base_ptid): Remove.
9836         (struct ravenscar_thread_target) <close>: New method.
9837         <m_base_ptid>: New member.
9838         <update_inferior_ptid, active_task, task_is_currently_active,
9839         runtime_initialized>: Declare methods.
9840         <ravenscar_thread_target>: Add constructor.
9841         (ravenscar_thread_target::task_is_currently_active)
9842         (ravenscar_thread_target::update_inferior_ptid)
9843         (ravenscar_runtime_initialized): Rename.  Now methods.
9844         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9845         (ravenscar_thread_target::update_thread_list): Update.
9846         (ravenscar_thread_target::active_task): Now method.
9847         (ravenscar_thread_target::store_registers)
9848         (ravenscar_thread_target::prepare_to_store)
9849         (ravenscar_thread_target::prepare_to_store)
9850         (ravenscar_thread_target::mourn_inferior): Update.
9851         (ravenscar_inferior_created): Use "new" to create target.
9852         (ravenscar_thread_target::get_ada_task_ptid): Update.
9853         (_initialize_ravenscar): Don't initialize base_ptid.
9854         (ravenscar_ops): Remove global.
9855
9856 2019-02-15  Tom Tromey  <tromey@adacore.com>
9857
9858         * target.h (push_target): Declare new overload.
9859         * target.c (push_target): New overload, taking an rvalue reference.
9860         * remote.c (remote_target::open_1): Use push_target overload.
9861         * corelow.c (core_target_open): Use push_target overload.
9862
9863 2019-02-15  Tom Tromey  <tromey@adacore.com>
9864
9865         * ravenscar-thread.c (is_ravenscar_task)
9866         (ravenscar_task_is_currently_active): Return bool.
9867         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9868         (_initialize_ravenscar): Remove "(void)".
9869         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9870         Return bool.
9871
9872 2019-02-15  Tom Tromey  <tromey@adacore.com>
9873
9874         * ravenscar-thread.c (ravenscar_runtime_initializer)
9875         (has_ravenscar_runtime, get_running_thread_id)
9876         (ravenscar_thread_target::resume): Fix indentation.
9877
9878 2019-02-15  Tom Tromey  <tromey@adacore.com>
9879
9880         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9881         from ravenscar_arch_ops.
9882         (sparc_ravenscar_ops::fetch_registers)
9883         (sparc_ravenscar_ops::store_registers): Now methods.
9884         (sparc_ravenscar_prepare_to_store): Remove.
9885         (sparc_ravenscar_ops): Redefine.
9886         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9887         methods and destructor.  Remove members.
9888         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9889         (ravenscar_thread_target::store_registers)
9890         (ravenscar_thread_target::prepare_to_store): Update.
9891         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9892         Remove.
9893         (struct ppc_ravenscar_powerpc_ops): Derive from
9894         ravenscar_arch_ops.
9895         (ppc_ravenscar_powerpc_ops::fetch_registers)
9896         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9897         (ppc_ravenscar_powerpc_ops): Redefine.
9898         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9899         (ppc_ravenscar_e500_ops::fetch_registers)
9900         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9901         (ppc_ravenscar_e500_ops): Redefine.
9902         * aarch64-ravenscar-thread.c
9903         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9904         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9905         (aarch64_ravenscar_fetch_registers)
9906         (aarch64_ravenscar_store_registers): Now methods.
9907         (aarch64_ravenscar_ops): Redefine.
9908
9909 2019-02-15  Tom Tromey  <tromey@adacore.com>
9910
9911         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9912         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9913         (ravenscar_thread_target::stopped_by_watchpoint)
9914         (ravenscar_thread_target::stopped_data_address)
9915         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9916
9917 2019-02-15  Tom Tromey  <tromey@adacore.com>
9918
9919         * ravenscar-thread.c: Fix some typos.
9920
9921 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9922             Tom Tromey  <tromey@adacore.com>
9923
9924         * ada-lang.c (ada_exception_sal): Change addr_string to a
9925         std::string.
9926         (create_ada_exception_catchpoint): Update.
9927
9928 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9929             Tom Tromey  <tromey@adacore.com>
9930
9931         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9932         (bp_location_ops): Remove.
9933         (base_breakpoint_allocate_location): Update.
9934         (free_bp_location): Update.
9935         * ada-lang.c (class ada_catchpoint_location)
9936         <ada_catchpoint_location>: Remove ops parameter.
9937         (ada_catchpoint_location_dtor): Remove.
9938         (ada_catchpoint_location_ops): Remove.
9939         (allocate_location_exception): Update.
9940         * breakpoint.h (struct bp_location_ops): Remove.
9941         (class bp_location) <bp_location>: Remove bp_location_ops
9942         parameter.
9943         <~bp_location>: Add destructor.
9944         <ops>: Remove.
9945
9946 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9947             Pedro Alves  <palves@redhat.com>
9948
9949         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9950         'PATH_MAX'.
9951
9952 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9953             Samuel Thibault  <samuel.thibault@gnu.org>
9954             Thomas Schwinge  <thomas@codesourcery.com>
9955
9956         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9957         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9958
9959 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9960
9961         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9962         (check_empty): Use "const char *".
9963
9964         * gnu-nat.c (gnu_nat_target::detach): Instead of
9965         'detach_inferior (pid)' call
9966         'detach_inferior (find_inferior_pid (pid))'.
9967
9968         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9969         'nat/fork-inferior.o'.
9970         * gnu-nat.c: #include "nat/fork-inferior.h".
9971
9972         * gnu-nat.c (gnu_nat_target::detach): Instead of
9973         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9974         * gnu-nat.h: #include "inf-child.h".
9975         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9976         'i386_gnu_nat_target::fetch_registers'.
9977         (gnu_store_registers): Rename/move to
9978         'i386_gnu_nat_target::store_registers'.
9979
9980         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9981         * gnu-nat.h (mach_thread_info): New function.
9982         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9983
9984         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9985
9986 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9987
9988         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9989
9990 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9991
9992         * windows-nat.c (windows_add_thread): Add new parameter
9993         "main_thread_p" with default value set to false.  Update
9994         function documentation as well as all callers.
9995         (windows_delete_thread): Likewise.
9996         (fake_create_process): Update call to windows_add_thread.
9997         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9998         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9999         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10000         call to windows_delete_thread.
10001
10002 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10003
10004         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10005
10006 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10007
10008         * symfile.c (find_separate_debug_file): Use canonical path of
10009         sysroot with child_path instead of gdb_sysroot if it is valid.
10010
10011 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10012
10013         * symfile.c (find_separate_debug_file): Use child_path to
10014         determine if an object file is under a sysroot.
10015
10016 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10017
10018         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10019         unittests/child-path-selftests.c.
10020         * common/pathstuff.c (child_path): New function.
10021         * common/pathstuff.h (child_path): New prototype.
10022         * unittests/child-path-selftests.c: New file.
10023
10024 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10025
10026         * symfile.c (find_separate_debug_file): Look for separate debug
10027         files in debug directories under the sysroot.
10028
10029 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10030
10031         * symtab.h (struct minimal_symbol data_p): New const method.
10032         (struct minimal_symbol text_p): Likewise.
10033         * symtab.c (output_source_filename): Use file name style
10034         to print file name.
10035         (print_symbol_info): Likewise.
10036         (print_msymbol_info): Use address style to print addresses.
10037         Use function name style to print executable text symbols.
10038         (expand_symtab_containing_pc): Use data_p.
10039         (find_pc_sect_compunit_symtab): Likewise.
10040
10041 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10042
10043         * breakpoint.c (describe_other_breakpoints): Use address style
10044         to print addresses.
10045         (say_where): Likewise.
10046
10047 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10048
10049         * ada-typeprint.c (print_func_type): Print function name
10050         style to print function name.
10051         * c-typeprint.c (c_print_type_1): Likewise.
10052
10053 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10054
10055         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10056         for execve.
10057
10058 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10059
10060         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10061         type_stack.
10062
10063 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10064
10065         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10066         TYPE_CODE_REF types.
10067
10068 2019-02-08  Jim Wilson  <jimw@sifive.com>
10069
10070         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10071         (riscv_linux_fregset): New.
10072         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10073
10074 2019-02-07  Tom Tromey  <tom@tromey.com>
10075
10076         * thread.c (thread_cancel_execution_command): Update.
10077         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10078         methods.
10079         (struct thread_fsm_ops): Remove.
10080         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10081         (thread_fsm_should_stop, thread_fsm_return_value)
10082         (thread_fsm_set_finished, thread_fsm_finished_p)
10083         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10084         Don't declare.
10085         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10086         * infrun.c (clear_proceed_status_thread)
10087         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10088         (print_stop_event): Update.
10089         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10090         Add constructor.
10091         (step_command_fsm_ops): Remove.
10092         (new_step_command_fsm): Remove.
10093         (step_1): Update.
10094         (step_command_fsm::should_stop): Rename from
10095         step_command_fsm_should_stop.
10096         (step_command_fsm::clean_up): Rename from
10097         step_command_fsm_clean_up.
10098         (step_command_fsm::do_async_reply_reason): Rename from
10099         step_command_fsm_async_reply_reason.
10100         (struct until_next_fsm): Inherit from thread_fsm.  Add
10101         constructor.
10102         (until_next_fsm_ops): Remove.
10103         (new_until_next_fsm): Remove.
10104         (until_next_fsm::should_stop): Rename from
10105         until_next_fsm_should_stop.
10106         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10107         (until_next_fsm::do_async_reply_reason): Rename from
10108         until_next_fsm_async_reply_reason.
10109         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10110         constructor.  Change type of breakpoint.
10111         (finish_command_fsm_ops): Remove.
10112         (new_finish_command_fsm): Remove.
10113         (finish_command_fsm::should_stop): Rename from
10114         finish_command_fsm_should_stop.
10115         (finish_command_fsm::clean_up): Rename from
10116         finish_command_fsm_clean_up.
10117         (finish_command_fsm::return_value): Rename from
10118         finish_command_fsm_return_value.
10119         (finish_command_fsm::do_async_reply_reason): Rename from
10120         finish_command_fsm_async_reply_reason.
10121         (finish_command): Update.
10122         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10123         Add constructor.
10124         (call_thread_fsm_ops): Remove.
10125         (call_thread_fsm::call_thread_fsm): Rename from
10126         new_call_thread_fsm.
10127         (call_thread_fsm::should_stop): Rename from
10128         call_thread_fsm_should_stop.
10129         (call_thread_fsm::should_notify_stop): Rename from
10130         call_thread_fsm_should_notify_stop.
10131         (run_inferior_call, call_function_by_hand_dummy): Update.
10132         * cli/cli-interp.c (should_print_stop_to_console): Update.
10133         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10134         Add constructor.  Change type of location_breakpoint,
10135         caller_breakpoint.
10136         (until_break_fsm_ops): Remove.
10137         (new_until_break_fsm): Remove.
10138         (until_break_fsm::should_stop): Rename from
10139         until_break_fsm_should_stop.
10140         (until_break_fsm::clean_up): Rename from
10141         until_break_fsm_clean_up.
10142         (until_break_fsm::do_async_reply_reason): Rename from
10143         until_break_fsm_async_reply_reason.
10144         (until_break_command): Update.
10145         * thread-fsm.c: Remove.
10146         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10147
10148 2019-02-07  Tom Tromey  <tom@tromey.com>
10149
10150         * yy-remap.h: Add include guard.
10151         * xtensa-tdep.h: Add include guard.
10152         * xcoffread.h: Rename include guard.
10153         * varobj-iter.h: Add include guard.
10154         * tui/tui.h: Rename include guard.
10155         * tui/tui-winsource.h: Rename include guard.
10156         * tui/tui-wingeneral.h: Rename include guard.
10157         * tui/tui-windata.h: Rename include guard.
10158         * tui/tui-win.h: Rename include guard.
10159         * tui/tui-stack.h: Rename include guard.
10160         * tui/tui-source.h: Rename include guard.
10161         * tui/tui-regs.h: Rename include guard.
10162         * tui/tui-out.h: Rename include guard.
10163         * tui/tui-layout.h: Rename include guard.
10164         * tui/tui-io.h: Rename include guard.
10165         * tui/tui-hooks.h: Rename include guard.
10166         * tui/tui-file.h: Rename include guard.
10167         * tui/tui-disasm.h: Rename include guard.
10168         * tui/tui-data.h: Rename include guard.
10169         * tui/tui-command.h: Rename include guard.
10170         * tic6x-tdep.h: Add include guard.
10171         * target/waitstatus.h: Rename include guard.
10172         * target/wait.h: Rename include guard.
10173         * target/target.h: Rename include guard.
10174         * target/resume.h: Rename include guard.
10175         * target-float.h: Rename include guard.
10176         * stabsread.h: Add include guard.
10177         * rs6000-tdep.h: Add include guard.
10178         * riscv-fbsd-tdep.h: Add include guard.
10179         * regformats/regdef.h: Rename include guard.
10180         * record.h: Rename include guard.
10181         * python/python.h: Rename include guard.
10182         * python/python-internal.h: Rename include guard.
10183         * python/py-stopevent.h: Rename include guard.
10184         * python/py-ref.h: Rename include guard.
10185         * python/py-record.h: Rename include guard.
10186         * python/py-record-full.h: Rename include guard.
10187         * python/py-record-btrace.h: Rename include guard.
10188         * python/py-instruction.h: Rename include guard.
10189         * python/py-events.h: Rename include guard.
10190         * python/py-event.h: Rename include guard.
10191         * procfs.h: Add include guard.
10192         * proc-utils.h: Add include guard.
10193         * p-lang.h: Add include guard.
10194         * or1k-tdep.h: Rename include guard.
10195         * observable.h: Rename include guard.
10196         * nto-tdep.h: Rename include guard.
10197         * nat/x86-linux.h: Rename include guard.
10198         * nat/x86-linux-dregs.h: Rename include guard.
10199         * nat/x86-gcc-cpuid.h: Add include guard.
10200         * nat/x86-dregs.h: Rename include guard.
10201         * nat/x86-cpuid.h: Rename include guard.
10202         * nat/ppc-linux.h: Rename include guard.
10203         * nat/mips-linux-watch.h: Rename include guard.
10204         * nat/linux-waitpid.h: Rename include guard.
10205         * nat/linux-ptrace.h: Rename include guard.
10206         * nat/linux-procfs.h: Rename include guard.
10207         * nat/linux-osdata.h: Rename include guard.
10208         * nat/linux-nat.h: Rename include guard.
10209         * nat/linux-namespaces.h: Rename include guard.
10210         * nat/linux-btrace.h: Rename include guard.
10211         * nat/glibc_thread_db.h: Rename include guard.
10212         * nat/gdb_thread_db.h: Rename include guard.
10213         * nat/gdb_ptrace.h: Rename include guard.
10214         * nat/fork-inferior.h: Rename include guard.
10215         * nat/amd64-linux-siginfo.h: Rename include guard.
10216         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10217         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10218         * nat/aarch64-linux.h: Rename include guard.
10219         * nat/aarch64-linux-hw-point.h: Rename include guard.
10220         * mn10300-tdep.h: Add include guard.
10221         * mips-linux-tdep.h: Add include guard.
10222         * mi/mi-parse.h: Rename include guard.
10223         * mi/mi-out.h: Rename include guard.
10224         * mi/mi-main.h: Rename include guard.
10225         * mi/mi-interp.h: Rename include guard.
10226         * mi/mi-getopt.h: Rename include guard.
10227         * mi/mi-console.h: Rename include guard.
10228         * mi/mi-common.h: Rename include guard.
10229         * mi/mi-cmds.h: Rename include guard.
10230         * mi/mi-cmd-break.h: Rename include guard.
10231         * m2-lang.h: Add include guard.
10232         * location.h: Rename include guard.
10233         * linux-record.h: Rename include guard.
10234         * linux-nat.h: Add include guard.
10235         * linux-fork.h: Add include guard.
10236         * i386-darwin-tdep.h: Rename include guard.
10237         * hppa-linux-offsets.h: Add include guard.
10238         * guile/guile.h: Rename include guard.
10239         * guile/guile-internal.h: Rename include guard.
10240         * gnu-nat.h: Rename include guard.
10241         * gdb-stabs.h: Rename include guard.
10242         * frv-tdep.h: Add include guard.
10243         * f-lang.h: Add include guard.
10244         * event-loop.h: Add include guard.
10245         * darwin-nat.h: Rename include guard.
10246         * cp-abi.h: Rename include guard.
10247         * config/sparc/nm-sol2.h: Rename include guard.
10248         * config/nm-nto.h: Rename include guard.
10249         * config/nm-linux.h: Add include guard.
10250         * config/i386/nm-i386gnu.h: Rename include guard.
10251         * config/djgpp/nl_types.h: Rename include guard.
10252         * config/djgpp/langinfo.h: Rename include guard.
10253         * compile/gcc-cp-plugin.h: Add include guard.
10254         * compile/gcc-c-plugin.h: Add include guard.
10255         * compile/compile.h: Rename include guard.
10256         * compile/compile-object-run.h: Rename include guard.
10257         * compile/compile-object-load.h: Rename include guard.
10258         * compile/compile-internal.h: Rename include guard.
10259         * compile/compile-cplus.h: Rename include guard.
10260         * compile/compile-c.h: Rename include guard.
10261         * common/xml-utils.h: Rename include guard.
10262         * common/x86-xstate.h: Rename include guard.
10263         * common/version.h: Rename include guard.
10264         * common/vec.h: Rename include guard.
10265         * common/tdesc.h: Rename include guard.
10266         * common/selftest.h: Rename include guard.
10267         * common/scoped_restore.h: Rename include guard.
10268         * common/scoped_mmap.h: Rename include guard.
10269         * common/scoped_fd.h: Rename include guard.
10270         * common/safe-iterator.h: Rename include guard.
10271         * common/run-time-clock.h: Rename include guard.
10272         * common/refcounted-object.h: Rename include guard.
10273         * common/queue.h: Rename include guard.
10274         * common/ptid.h: Rename include guard.
10275         * common/print-utils.h: Rename include guard.
10276         * common/preprocessor.h: Rename include guard.
10277         * common/pathstuff.h: Rename include guard.
10278         * common/observable.h: Rename include guard.
10279         * common/netstuff.h: Rename include guard.
10280         * common/job-control.h: Rename include guard.
10281         * common/host-defs.h: Rename include guard.
10282         * common/gdb_wait.h: Rename include guard.
10283         * common/gdb_vecs.h: Rename include guard.
10284         * common/gdb_unlinker.h: Rename include guard.
10285         * common/gdb_unique_ptr.h: Rename include guard.
10286         * common/gdb_tilde_expand.h: Rename include guard.
10287         * common/gdb_sys_time.h: Rename include guard.
10288         * common/gdb_string_view.h: Rename include guard.
10289         * common/gdb_splay_tree.h: Rename include guard.
10290         * common/gdb_setjmp.h: Rename include guard.
10291         * common/gdb_ref_ptr.h: Rename include guard.
10292         * common/gdb_optional.h: Rename include guard.
10293         * common/gdb_locale.h: Rename include guard.
10294         * common/gdb_assert.h: Rename include guard.
10295         * common/filtered-iterator.h: Rename include guard.
10296         * common/filestuff.h: Rename include guard.
10297         * common/fileio.h: Rename include guard.
10298         * common/environ.h: Rename include guard.
10299         * common/common-utils.h: Rename include guard.
10300         * common/common-types.h: Rename include guard.
10301         * common/common-regcache.h: Rename include guard.
10302         * common/common-inferior.h: Rename include guard.
10303         * common/common-gdbthread.h: Rename include guard.
10304         * common/common-exceptions.h: Rename include guard.
10305         * common/common-defs.h: Rename include guard.
10306         * common/common-debug.h: Rename include guard.
10307         * common/cleanups.h: Rename include guard.
10308         * common/buffer.h: Rename include guard.
10309         * common/btrace-common.h: Rename include guard.
10310         * common/break-common.h: Rename include guard.
10311         * cli/cli-utils.h: Rename include guard.
10312         * cli/cli-style.h: Rename include guard.
10313         * cli/cli-setshow.h: Rename include guard.
10314         * cli/cli-script.h: Rename include guard.
10315         * cli/cli-interp.h: Rename include guard.
10316         * cli/cli-decode.h: Rename include guard.
10317         * cli/cli-cmds.h: Rename include guard.
10318         * charset-list.h: Add include guard.
10319         * buildsym-legacy.h: Rename include guard.
10320         * bfin-tdep.h: Add include guard.
10321         * ax.h: Rename include guard.
10322         * arm-linux-tdep.h: Add include guard.
10323         * arm-fbsd-tdep.h: Add include guard.
10324         * arch/xtensa.h: Rename include guard.
10325         * arch/tic6x.h: Add include guard.
10326         * arch/i386.h: Add include guard.
10327         * arch/arm.h: Rename include guard.
10328         * arch/arm-linux.h: Rename include guard.
10329         * arch/arm-get-next-pcs.h: Rename include guard.
10330         * arch/amd64.h: Add include guard.
10331         * arch/aarch64-insn.h: Rename include guard.
10332         * arch-utils.h: Rename include guard.
10333         * annotate.h: Add include guard.
10334         * amd64-darwin-tdep.h: Rename include guard.
10335         * aarch64-linux-tdep.h: Add include guard.
10336         * aarch64-fbsd-tdep.h: Add include guard.
10337         * aarch32-linux-nat.h: Add include guard.
10338
10339 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10340
10341         * macrotab.c (macro_define_internal): New function that
10342         factorizes macro_define_object_internal and macro_define_function
10343         code.
10344         (macro_define_object_internal): Use macro_define_internal.
10345         (macro_define_function): Likewise.
10346
10347 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10348
10349         * macrocmd.c (extract_identifier): Return
10350         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10351         callers.
10352
10353 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10354
10355         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10356
10357 2019-02-05  Tom Tromey  <tom@tromey.com>
10358
10359         * target.c (target_stack::unpush): Move assertion earlier.
10360
10361 2019-01-30  Tom Tromey  <tom@tromey.com>
10362
10363         PR python/23615:
10364         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10365         (gdbpy_parse_and_eval): Likewise.
10366         * python/python-internal.h (gdbpy_allow_threads): New class.
10367
10368 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10369
10370         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10371         (aarch64_fbsd_fpregmap): Move earlier.
10372         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10373         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10374         instead of individual calls to trad_frame_set_reg_addr.
10375         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10376         earlier.
10377         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10378         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10379         instead of individual calls to trad_frame_set_reg_addr.
10380
10381 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10382
10383         * CONTRIBUTE: Replace contribution list with wiki link.
10384
10385 2019-01-25  Tom Tromey  <tom@tromey.com>
10386
10387         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10388
10389 2019-01-25  Tom Tromey  <tom@tromey.com>
10390
10391         * xtensa-linux-nat.c: Fix common/ includes.
10392         * xml-support.h: Fix common/ includes.
10393         * xml-support.c: Fix common/ includes.
10394         * x86-linux-nat.c: Fix common/ includes.
10395         * windows-nat.c: Fix common/ includes.
10396         * varobj.h: Fix common/ includes.
10397         * varobj.c: Fix common/ includes.
10398         * value.c: Fix common/ includes.
10399         * valops.c: Fix common/ includes.
10400         * utils.c: Fix common/ includes.
10401         * unittests/xml-utils-selftests.c: Fix common/ includes.
10402         * unittests/utils-selftests.c: Fix common/ includes.
10403         * unittests/unpack-selftests.c: Fix common/ includes.
10404         * unittests/tracepoint-selftests.c: Fix common/ includes.
10405         * unittests/style-selftests.c: Fix common/ includes.
10406         * unittests/string_view-selftests.c: Fix common/ includes.
10407         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10408         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10409         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10410         * unittests/rsp-low-selftests.c: Fix common/ includes.
10411         * unittests/parse-connection-spec-selftests.c: Fix common/
10412         includes.
10413         * unittests/optional-selftests.c: Fix common/ includes.
10414         * unittests/offset-type-selftests.c: Fix common/ includes.
10415         * unittests/observable-selftests.c: Fix common/ includes.
10416         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10417         * unittests/memrange-selftests.c: Fix common/ includes.
10418         * unittests/memory-map-selftests.c: Fix common/ includes.
10419         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10420         * unittests/function-view-selftests.c: Fix common/ includes.
10421         * unittests/environ-selftests.c: Fix common/ includes.
10422         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10423         * unittests/common-utils-selftests.c: Fix common/ includes.
10424         * unittests/cli-utils-selftests.c: Fix common/ includes.
10425         * unittests/array-view-selftests.c: Fix common/ includes.
10426         * ui-file.c: Fix common/ includes.
10427         * tui/tui-io.c: Fix common/ includes.
10428         * tracepoint.h: Fix common/ includes.
10429         * tracepoint.c: Fix common/ includes.
10430         * tracefile-tfile.c: Fix common/ includes.
10431         * top.h: Fix common/ includes.
10432         * top.c: Fix common/ includes.
10433         * thread.c: Fix common/ includes.
10434         * target/waitstatus.h: Fix common/ includes.
10435         * target/waitstatus.c: Fix common/ includes.
10436         * target.h: Fix common/ includes.
10437         * target.c: Fix common/ includes.
10438         * target-memory.c: Fix common/ includes.
10439         * target-descriptions.c: Fix common/ includes.
10440         * symtab.h: Fix common/ includes.
10441         * symfile.c: Fix common/ includes.
10442         * stap-probe.c: Fix common/ includes.
10443         * spu-linux-nat.c: Fix common/ includes.
10444         * sparc-nat.c: Fix common/ includes.
10445         * source.c: Fix common/ includes.
10446         * solib.c: Fix common/ includes.
10447         * solib-target.c: Fix common/ includes.
10448         * ser-unix.c: Fix common/ includes.
10449         * ser-tcp.c: Fix common/ includes.
10450         * ser-pipe.c: Fix common/ includes.
10451         * ser-base.c: Fix common/ includes.
10452         * selftest-arch.c: Fix common/ includes.
10453         * s12z-tdep.c: Fix common/ includes.
10454         * rust-exp.y: Fix common/ includes.
10455         * rs6000-aix-tdep.c: Fix common/ includes.
10456         * riscv-tdep.c: Fix common/ includes.
10457         * remote.c: Fix common/ includes.
10458         * remote-notif.h: Fix common/ includes.
10459         * remote-fileio.h: Fix common/ includes.
10460         * remote-fileio.c: Fix common/ includes.
10461         * regcache.h: Fix common/ includes.
10462         * regcache.c: Fix common/ includes.
10463         * record-btrace.c: Fix common/ includes.
10464         * python/python.c: Fix common/ includes.
10465         * python/py-type.c: Fix common/ includes.
10466         * python/py-inferior.c: Fix common/ includes.
10467         * progspace.h: Fix common/ includes.
10468         * producer.c: Fix common/ includes.
10469         * procfs.c: Fix common/ includes.
10470         * proc-api.c: Fix common/ includes.
10471         * printcmd.c: Fix common/ includes.
10472         * ppc-linux-nat.c: Fix common/ includes.
10473         * parser-defs.h: Fix common/ includes.
10474         * osdata.c: Fix common/ includes.
10475         * obsd-nat.c: Fix common/ includes.
10476         * nat/x86-linux.c: Fix common/ includes.
10477         * nat/x86-linux-dregs.c: Fix common/ includes.
10478         * nat/x86-dregs.h: Fix common/ includes.
10479         * nat/x86-dregs.c: Fix common/ includes.
10480         * nat/ppc-linux.c: Fix common/ includes.
10481         * nat/mips-linux-watch.h: Fix common/ includes.
10482         * nat/mips-linux-watch.c: Fix common/ includes.
10483         * nat/linux-waitpid.c: Fix common/ includes.
10484         * nat/linux-ptrace.h: Fix common/ includes.
10485         * nat/linux-ptrace.c: Fix common/ includes.
10486         * nat/linux-procfs.c: Fix common/ includes.
10487         * nat/linux-personality.c: Fix common/ includes.
10488         * nat/linux-osdata.c: Fix common/ includes.
10489         * nat/linux-namespaces.c: Fix common/ includes.
10490         * nat/linux-btrace.h: Fix common/ includes.
10491         * nat/linux-btrace.c: Fix common/ includes.
10492         * nat/fork-inferior.c: Fix common/ includes.
10493         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10494         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10495         * nat/aarch64-linux.c: Fix common/ includes.
10496         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10497         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10498         * namespace.h: Fix common/ includes.
10499         * mips-linux-tdep.c: Fix common/ includes.
10500         * minsyms.c: Fix common/ includes.
10501         * mi/mi-parse.h: Fix common/ includes.
10502         * mi/mi-main.c: Fix common/ includes.
10503         * mi/mi-cmd-env.c: Fix common/ includes.
10504         * memrange.h: Fix common/ includes.
10505         * memattr.c: Fix common/ includes.
10506         * maint.h: Fix common/ includes.
10507         * maint.c: Fix common/ includes.
10508         * main.c: Fix common/ includes.
10509         * machoread.c: Fix common/ includes.
10510         * location.c: Fix common/ includes.
10511         * linux-thread-db.c: Fix common/ includes.
10512         * linux-nat.c: Fix common/ includes.
10513         * linux-fork.c: Fix common/ includes.
10514         * inline-frame.c: Fix common/ includes.
10515         * infrun.c: Fix common/ includes.
10516         * inflow.c: Fix common/ includes.
10517         * inferior.h: Fix common/ includes.
10518         * inferior.c: Fix common/ includes.
10519         * infcmd.c: Fix common/ includes.
10520         * inf-ptrace.c: Fix common/ includes.
10521         * inf-child.c: Fix common/ includes.
10522         * ia64-linux-nat.c: Fix common/ includes.
10523         * i387-tdep.c: Fix common/ includes.
10524         * i386-tdep.c: Fix common/ includes.
10525         * i386-linux-tdep.c: Fix common/ includes.
10526         * i386-linux-nat.c: Fix common/ includes.
10527         * i386-go32-tdep.c: Fix common/ includes.
10528         * i386-fbsd-tdep.c: Fix common/ includes.
10529         * i386-fbsd-nat.c: Fix common/ includes.
10530         * guile/scm-type.c: Fix common/ includes.
10531         * guile/guile.c: Fix common/ includes.
10532         * go32-nat.c: Fix common/ includes.
10533         * gnu-nat.c: Fix common/ includes.
10534         * gdbthread.h: Fix common/ includes.
10535         * gdbarch-selftests.c: Fix common/ includes.
10536         * gdb_usleep.c: Fix common/ includes.
10537         * gdb_select.h: Fix common/ includes.
10538         * gdb_bfd.c: Fix common/ includes.
10539         * gcore.c: Fix common/ includes.
10540         * fork-child.c: Fix common/ includes.
10541         * findvar.c: Fix common/ includes.
10542         * fbsd-nat.c: Fix common/ includes.
10543         * event-top.c: Fix common/ includes.
10544         * event-loop.c: Fix common/ includes.
10545         * dwarf2read.c: Fix common/ includes.
10546         * dwarf2loc.c: Fix common/ includes.
10547         * dwarf2-frame.c: Fix common/ includes.
10548         * dwarf-index-cache.c: Fix common/ includes.
10549         * dtrace-probe.c: Fix common/ includes.
10550         * disasm-selftests.c: Fix common/ includes.
10551         * defs.h: Fix common/ includes.
10552         * csky-tdep.c: Fix common/ includes.
10553         * cp-valprint.c: Fix common/ includes.
10554         * cp-support.h: Fix common/ includes.
10555         * cp-support.c: Fix common/ includes.
10556         * corelow.c: Fix common/ includes.
10557         * completer.h: Fix common/ includes.
10558         * completer.c: Fix common/ includes.
10559         * compile/compile.c: Fix common/ includes.
10560         * compile/compile-loc2c.c: Fix common/ includes.
10561         * compile/compile-cplus-types.c: Fix common/ includes.
10562         * compile/compile-cplus-symbols.c: Fix common/ includes.
10563         * command.h: Fix common/ includes.
10564         * cli/cli-dump.c: Fix common/ includes.
10565         * cli/cli-cmds.c: Fix common/ includes.
10566         * charset.c: Fix common/ includes.
10567         * build-id.c: Fix common/ includes.
10568         * btrace.h: Fix common/ includes.
10569         * btrace.c: Fix common/ includes.
10570         * breakpoint.h: Fix common/ includes.
10571         * breakpoint.c: Fix common/ includes.
10572         * ax.h:
10573         (enum agent_op): Fix common/ includes.
10574         * ax-general.c (struct aop_map): Fix common/ includes.
10575         * ax-gdb.c: Fix common/ includes.
10576         * auxv.c: Fix common/ includes.
10577         * auto-load.c: Fix common/ includes.
10578         * arm-tdep.c: Fix common/ includes.
10579         * arch/riscv.c: Fix common/ includes.
10580         * arch/ppc-linux-common.c: Fix common/ includes.
10581         * arch/i386.c: Fix common/ includes.
10582         * arch/arm.c: Fix common/ includes.
10583         * arch/arm-linux.c: Fix common/ includes.
10584         * arch/arm-get-next-pcs.c: Fix common/ includes.
10585         * arch/amd64.c: Fix common/ includes.
10586         * arch/aarch64.c: Fix common/ includes.
10587         * arch/aarch64-insn.c: Fix common/ includes.
10588         * arch-utils.c: Fix common/ includes.
10589         * amd64-windows-tdep.c: Fix common/ includes.
10590         * amd64-tdep.c: Fix common/ includes.
10591         * amd64-sol2-tdep.c: Fix common/ includes.
10592         * amd64-obsd-tdep.c: Fix common/ includes.
10593         * amd64-nbsd-tdep.c: Fix common/ includes.
10594         * amd64-linux-tdep.c: Fix common/ includes.
10595         * amd64-linux-nat.c: Fix common/ includes.
10596         * amd64-fbsd-tdep.c: Fix common/ includes.
10597         * amd64-fbsd-nat.c: Fix common/ includes.
10598         * amd64-dicos-tdep.c: Fix common/ includes.
10599         * amd64-darwin-tdep.c: Fix common/ includes.
10600         * agent.c: Fix common/ includes.
10601         * ada-lang.h: Fix common/ includes.
10602         * ada-lang.c: Fix common/ includes.
10603         * aarch64-tdep.c: Fix common/ includes.
10604
10605 2019-01-25  Tom Tromey  <tom@tromey.com>
10606
10607         * common/create-version.sh: Use common/version.h.
10608
10609 2019-01-24  Pedro Alves  <palves@redhat.com>
10610
10611         * infrun.c (signal_stop, signal_print, signal_program)
10612         (signal_catch, signal_pass): Now arrays instead of pointers.
10613         (update_signals_program_target, do_target_resume)
10614         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10615         * linux-nat.c (linux_nat_target::pass_signals)
10616         (linux_nat_target::create_inferior, linux_nat_target::attach):
10617         Adjust.
10618         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10619         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10620         * procfs.c (procfs_target::pass_signals): Adjust.
10621         * record-full.c (record_full_target::resume): Adjust.
10622         * remote.c (remote_target::pass_signals)
10623         (remote_target::program_signals): Adjust.
10624         * target-debug.h (target_debug_print_signals): Now takes a
10625         gdb::array_view as parameter.  Adjust.
10626         * target.h (target_ops) <pass_signals, program_signals>: Replace
10627         pointer and length parameters with gdb::array_view.
10628         (target_pass_signals, target_program_signals): Likewise.
10629         * target-delegates.c: Regenerate.
10630
10631 2019-01-24  Pedro Alves  <palves@redhat.com>
10632
10633         * common/forward-scope-exit.h
10634         (forward_scope_exit::forward_scope_exit): Pass arguments to
10635         m_bind_function directly, instead of creating a std::bind and
10636         copying that.
10637
10638 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10639
10640         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10641         for static members.
10642         (pass_in_v_vfp_candidate): Likewise.
10643
10644 2019-01-23  Tom Tromey  <tom@tromey.com>
10645             Pedro Alves  <palves@redhat.com>
10646
10647         * regcache.c (class regcache_invalidator): Remove.
10648         (regcache::raw_write): Use make_scope_exit.
10649
10650 2019-01-23  Tom Tromey  <tom@tromey.com>
10651
10652         * ui-out.h (class ui_out_emit_type): Update comment.
10653
10654 2019-01-23  Tom Tromey  <tom@tromey.com>
10655
10656         * infrun.c (fetch_inferior_event): Update comment.
10657
10658 2019-01-23  Tom Tromey  <tom@tromey.com>
10659             Pedro Alves  <palves@redhat.com>
10660
10661         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10662         parameter.
10663         (fetch_inferior_event): Use SCOPE_EXIT.
10664
10665
10666 2019-01-23  Tom Tromey  <tom@tromey.com>
10667             Pedro Alves  <palves@redhat.com>
10668
10669         * infrun.c (disable_thread_events): Delete.
10670         (stop_all_threads): Use SCOPE_EXIT.
10671
10672 2019-01-23  Tom Tromey  <tom@tromey.com>
10673             Pedro Alves  <palves@redhat.com>
10674
10675         * symfile.c: Include forward-scope-exit.h.
10676         (clear_symtab_users_cleanup): Replace forward declaration with
10677         a FORWARD_SCOPE_EXIT.
10678         (syms_from_objfile_1): Use the forward_scope_exit and
10679         gdb::optional instead of cleanup_function.
10680         (reread_symbols): Use the forward_scope_exit instead of
10681         cleanup_function.
10682         (clear_symtab_users_cleanup): Remove function.
10683
10684 2019-01-23  Tom Tromey  <tom@tromey.com>
10685             Pedro Alves  <palves@redhat.com>
10686
10687         * linux-nat.c: Include scope-exit.h.
10688         (cleanup_target_stop): Remove.
10689         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10690         SCOPE_EXIT.
10691
10692 2019-01-23  Tom Tromey  <tom@tromey.com>
10693             Pedro Alves  <palves@redhat.com>
10694
10695         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10696         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10697
10698 2019-01-23  Tom Tromey  <tom@tromey.com>
10699             Andrew Burgess  <andrew.burgess@embecosm.com>
10700             Pedro Alves  <palves@redhat.com>
10701
10702         * infrun.c (fetch_inferior_event): Use scope_exit.
10703         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10704         * top.c (execute_command): Use scope_exit.
10705         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10706         * utils.c (do_bpstat_clear_actions_cleanup)
10707         (make_bpstat_clear_actions_cleanup): Remove.
10708
10709 2019-01-23  Tom Tromey  <tom@tromey.com>
10710             Pedro Alves  <palves@redhat.com>
10711
10712         * infrun.c: Include "common/scope-exit.h"
10713         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10714         (wait_for_inferior): Use SCOPE_EXIT.
10715         (fetch_inferior_event): Use scope_exit.
10716
10717 2019-01-23  Tom Tromey  <tom@tromey.com>
10718             Pedro Alves  <palves@redhat.com>
10719
10720         * breakpoint.c (create_breakpoint): Remove cleanup.
10721
10722 2019-01-23  Tom Tromey  <tom@tromey.com>
10723             Andrew Burgess  <andrew.burgess@embecosm.com>
10724             Pedro Alves  <palves@redhat.com>
10725
10726 2019-01-23  Pedro Alves  <palves@redhat.com>
10727
10728         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10729
10730 2019-01-23  Pedro Alves  <palves@redhat.com>
10731             Andrew Burgess  <andrew.burgess@embecosm.com>
10732
10733         * gdbthread.h: Include "common/forward-scope-exit.h".
10734         (scoped_finish_thread_state): Redefine custom class in terms of
10735         forward_scope_exit.
10736
10737 2019-01-23  Pedro Alves  <palves@redhat.com>
10738             Andrew Burgess  <andrew.burgess@embecosm.com>
10739
10740         * common/forward-scope-exit.h: New file.
10741
10742 2019-01-23  Pedro Alves  <palves@redhat.com>
10743             Andrew Burgess  <andrew.burgess@embecosm.com>
10744             Tom Tromey  <tom@tromey.com>
10745
10746         * common/scope-exit.h: New file.
10747
10748 2019-01-23  Pedro Alves  <palves@redhat.com>
10749
10750         * common/preprocessor.h (ESC): Rename to ...
10751         (ESC_PARENS): ... this.
10752         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10753         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10754
10755 2019-01-23  Tom Tromey  <tom@tromey.com>
10756
10757         * language.h (class scoped_switch_to_sym_language_if_auto):
10758         Initialize m_lang in both cases.
10759
10760 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10761
10762         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10763         with XCNEW.
10764
10765 2019-01-22  Tom Tromey  <tom@tromey.com>
10766
10767         * corelow.c: Do not include sys/file.h.
10768
10769 2019-01-22  Tom Tromey  <tom@tromey.com>
10770
10771         * tui/tui-wingeneral.h: Include gdb_curses.h.
10772
10773 2019-01-22  Tom Tromey  <tom@tromey.com>
10774
10775         * source-cache.h (class source_cache) <get_source_lines,
10776         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10777
10778 2019-01-22  Tom Tromey  <tom@tromey.com>
10779
10780         * remote-fileio.h (struct remote_target): Declare.
10781
10782 2019-01-22  Tom Tromey  <tom@tromey.com>
10783
10784         * python/py-arch.c: Do not include py-ref.h.
10785         * python/py-bpevent.c: Do not include py-ref.h.
10786         * python/py-cmd.c: Do not include py-ref.h.
10787         * python/py-continueevent.c: Do not include py-ref.h.
10788         * python/py-event.h: Do not include py-ref.h.
10789         * python/py-evtregistry.c: Do not include py-ref.h.
10790         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10791         * python/py-frame.c: Do not include py-ref.h.
10792         * python/py-framefilter.c: Do not include py-ref.h.
10793         * python/py-function.c: Do not include py-ref.h.
10794         * python/py-infevents.c: Do not include py-ref.h.
10795         * python/py-linetable.c: Do not include py-ref.h.
10796         * python/py-objfile.c: Do not include py-ref.h.
10797         * python/py-param.c: Do not include py-ref.h.
10798         * python/py-prettyprint.c: Do not include py-ref.h.
10799         * python/py-progspace.c: Do not include py-ref.h.
10800         * python/py-symbol.c: Do not include py-ref.h.
10801         * python/py-symtab.c: Do not include py-ref.h.
10802         * python/py-type.c: Do not include py-ref.h.
10803         * python/py-unwind.c: Do not include py-ref.h.
10804         * python/py-utils.c: Do not include py-ref.h.
10805         * python/py-value.c: Do not include py-ref.h.
10806         * python/py-varobj.c: Do not include py-ref.h.
10807         * python/py-xmethods.c: Do not include py-ref.h.
10808         * python/python.c: Do not include py-ref.h.
10809         * varobj.c: Do not include py-ref.h.
10810
10811 2019-01-22  Tom Tromey  <tom@tromey.com>
10812
10813         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10814         keyword for bcache.
10815
10816 2019-01-22  Tom Tromey  <tom@tromey.com>
10817
10818         * compile/compile-cplus-types.c: Remove a comment by #include.
10819
10820 2019-01-22  Tom Tromey  <tom@tromey.com>
10821
10822         * compile/gcc-c-plugin.h: Include compile-internal.h.
10823
10824 2019-01-22  Tom Tromey  <tom@tromey.com>
10825
10826         * stabsread.c (EXTERN): Do not define.
10827         (symnum, next_symbol_text_func, processing_gcc_compilation)
10828         (within_function, global_sym_chain, global_stabs)
10829         (previous_stab_code, this_object_header_files)
10830         (n_this_object_header_files)
10831         (n_allocated_this_object_header_files): Define.
10832         * stabsread.h (EXTERN): Never define.  Use "extern".
10833
10834 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10835
10836         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10837         history_value.
10838
10839 2019-01-21  Tom Tromey  <tom@tromey.com>
10840
10841         * ui-out.c: Fix includes.
10842         * tui/tui-source.c: Fix includes.
10843         * target.c: Fix includes.
10844         * remote.c: Fix includes.
10845         * regcache.c: Fix includes.
10846         * python/py-block.c: Fix includes.
10847         * printcmd.c: Fix includes.
10848         * or1k-tdep.c: Fix includes.
10849         * mi/mi-main.c: Fix includes.
10850         * m32r-tdep.c: Fix includes.
10851         * csky-tdep.c: Fix includes.
10852         * compile/compile-cplus-types.c: Fix includes.
10853         * cli/cli-interp.c: Fix includes.
10854
10855 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10856
10857         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10858         for padding.
10859
10860 2019-01-16  Tom Tromey  <tom@tromey.com>
10861
10862         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10863         earlier.
10864         (struct objfile) <msymbols_range>: Move from top level.
10865         <msymbols>: New method.
10866         (class objfile_msymbols): Remove.
10867         * symtab.c (default_collect_symbol_completion_matches_break_on):
10868         Update.
10869         * symmisc.c (dump_msymbols): Update.
10870         * stabsread.c (scan_file_globals): Update.
10871         * objc-lang.c (info_selectors_command, info_classes_command)
10872         (find_methods): Update.
10873         * minsyms.c (find_solib_trampoline_target): Update.
10874         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10875         * coffread.c (coff_symfile_read): Update.
10876         * ada-lang.c (ada_lookup_simple_minsym)
10877         (ada_collect_symbol_completion_matches): Update.
10878
10879 2019-01-16  Tom Tromey  <tom@tromey.com>
10880
10881         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10882         type.  Remove no-argument constructor.
10883         <iterator::operator++>: Simplify.
10884         <begin>: Update.
10885         <end>: Use minimal_symbol_count.
10886
10887 2019-01-16  Tom Tromey  <tom@tromey.com>
10888
10889         * objfiles.h (struct objfile) <psymtabs>: New method.
10890         (class objfile_psymtabs): Remove.
10891         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10892         typedef.
10893         <range>: New method.
10894         (require_partial_symbols): Change return type.
10895         * psymtab.c (require_partial_symbols)
10896         (psym_expand_symtabs_matching): Update.
10897         * mdebugread.c (parse_partial_symbols): Update.
10898         * dbxread.c (dbx_end_psymtab): Update.
10899
10900 2019-01-15  Tom Tromey  <tom@tromey.com>
10901
10902         * symtab.c (lookup_objfile_from_block)
10903         (lookup_symbol_in_objfile_symtabs)
10904         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10905         (find_line_symtab, info_sources_command)
10906         (default_collect_symbol_completion_matches_break_on)
10907         (make_source_files_completion_list): Update.
10908         * symmisc.c (print_objfile_statistics, dump_objfile)
10909         (maintenance_print_symbols, maintenance_info_symtabs)
10910         (maintenance_check_symtabs, maintenance_info_line_tables):
10911         Update.
10912         * source.c (select_source_symtab)
10913         (forget_cached_source_info_for_objfile): Update.
10914         * objfiles.h (class objfile_compunits): Remove.
10915         (struct objfile) <compunits_range>: New typedef.
10916         (compunits): New method.
10917         * objfiles.c (objfile_relocate1): Update.
10918         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10919         * maint.c (count_symtabs_and_blocks): Update.
10920         * linespec.c (iterate_over_all_matching_symtabs): Update.
10921         * cp-support.c (add_symbol_overload_list_qualified): Update.
10922         * coffread.c (coff_symtab_read): Update.
10923         * ada-lang.c (add_nonlocal_symbols)
10924         (ada_collect_symbol_completion_matches)
10925         (ada_add_global_exceptions): Update.
10926
10927 2019-01-15  Tom Tromey  <tom@tromey.com>
10928
10929         * progspace.h (program_space) <objfiles_safe_range>: New
10930         typedef.
10931         <objfiles_safe>: New method.
10932         * objfiles.h (class all_objfiles_safe): Remove.
10933         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10934         * jit.c (jit_inferior_exit_hook): Update.
10935
10936 2019-01-17  Tom Tromey  <tom@tromey.com>
10937
10938         * progspace.h (program_space) <objfiles_range>: New typedef.
10939         <objfiles>: New method.
10940         <objfiles_head>: Rename from objfiles.
10941         (object_files): Update.
10942         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10943         * guile/scm-pretty-print.c
10944         (ppscm_find_pretty_printer_from_objfiles): Update.
10945         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10946         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10947         Update.
10948         * python/py-progspace.c (pspy_get_objfiles): Update.
10949         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10950         Update.
10951         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10952         (objfpy_lookup_objfile_by_build_id): Update.
10953         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10954         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10955         Update.
10956         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10957         (expand_symtab_containing_pc, lookup_objfile_from_block)
10958         (lookup_static_symbol, basic_lookup_transparent_type)
10959         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10960         (find_line_symtab, info_sources_command)
10961         (default_collect_symbol_completion_matches_break_on)
10962         (make_source_files_completion_list, find_main_name): Update.
10963         * symmisc.c (print_symbol_bcache_statistics)
10964         (print_objfile_statistics, maintenance_print_symbols)
10965         (maintenance_print_msymbols, maintenance_print_objfiles)
10966         (maintenance_info_symtabs, maintenance_check_symtabs)
10967         (maintenance_expand_symtabs, maintenance_info_line_tables):
10968         Update.
10969         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10970         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10971         (map_overlay_command, unmap_overlay_command)
10972         (simple_overlay_update, expand_symtabs_matching)
10973         (map_symbol_filenames): Update.
10974         * symfile-debug.c (set_debug_symfile): Update.
10975         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10976         Update.
10977         * source.c (select_source_symtab, forget_cached_source_info):
10978         Update.
10979         * solib.c (solib_read_symbols): Update.
10980         * solib-spu.c (append_ocl_sos): Update.
10981         * psymtab.c (maintenance_print_psymbols)
10982         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10983         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10984         * printcmd.c (info_symbol_command): Update.
10985         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10986         Update.
10987         * objfiles.h (class all_objfiles): Remove.
10988         * objfiles.c (have_partial_symbols, have_full_symbols)
10989         (have_minimal_symbols, qsort_cmp, update_section_map)
10990         (shared_objfile_contains_address_p)
10991         (default_iterate_over_objfiles_in_search_order): Update.
10992         * objc-lang.c (info_selectors_command, info_classes_command)
10993         (find_methods): Update.
10994         * minsyms.c (find_solib_trampoline_target): Update.
10995         * maint.c (maintenance_info_sections)
10996         (maintenance_translate_address, count_symtabs_and_blocks):
10997         Update.
10998         * main.c (captured_main_1): Update.
10999         * linux-thread-db.c (try_thread_db_load_from_pdir)
11000         (has_libpthread): Update.
11001         * linespec.c (iterate_over_all_matching_symtabs)
11002         (search_minsyms_for_name): Update.
11003         * jit.c (jit_find_objf_with_entry_addr): Update.
11004         * hppa-tdep.c (find_unwind_entry)
11005         (hppa_lookup_stub_minimal_symbol): Update.
11006         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11007         Update.
11008         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11009         (elf_gnu_ifunc_resolve_by_got): Update.
11010         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11011         * dwarf-index-write.c (save_gdb_index_command): Update.
11012         * cp-support.c (add_symbol_overload_list_qualified): Update.
11013         * breakpoint.c (create_overlay_event_breakpoint)
11014         (create_longjmp_master_breakpoint)
11015         (create_std_terminate_master_breakpoint)
11016         (create_exception_master_breakpoint): Update.
11017         * blockframe.c (find_pc_partial_function): Update.
11018         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11019         (ada_collect_symbol_completion_matches)
11020         (ada_add_global_exceptions): Update.
11021
11022 2019-01-17  Tom Tromey  <tom@tromey.com>
11023
11024         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11025         declare VEC.
11026         (solib_target_parse_libraries): Change return type.
11027         (library_list_start_segment, library_list_start_section)
11028         (library_list_end_library, library_list_start_library); Update.
11029         (solib_target_free_library_list): Remove.
11030         (solib_target_parse_libraries): Remove cleanup.  Change return
11031         type.
11032         (solib_target_current_sos): Update.
11033
11034 2019-01-17  Tom Tromey  <tromey@bapiya>
11035
11036         * valprint.c: Replace "the the" with "the".
11037         * symtab.c: Replace "the the" with "the".
11038         * solib.c: Replace "the the" with "the".
11039         * solib-dsbt.c: Replace "the the" with "the".
11040         * linespec.c: Replace "the the" with "the".
11041         * dwarf2loc.h: Replace "the the" with "the".
11042         * amd64-windows-tdep.c: Replace "the the" with "the".
11043         * aarch64-tdep.c: Replace "the the" with "the".
11044
11045 2019-01-16  Keith Seitz  <keiths@redhat.com>
11046
11047         PR gdb/23773
11048         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11049         <builder>: Rename to ..
11050         <m_builder>: ... this and make private.
11051         (dwarf2_cu::get_builder): New method.  Change all users of
11052         `builder' to use this method.
11053         (dwarf2_start_symtab): Move to ...
11054         (dwarf2_cu::start_symtab): ... here.  Update all callers
11055         (setup_type_unit_groups): Move to ...
11056         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11057         callers.
11058         (dwarf2_cu::reset_builder): New method.
11059         (process_full_compunit, process_full_type_unit): Use
11060         dwarf2_cu::reset_builder.
11061         (follow_die_offset): Record the ancestor CU if it is different
11062         from the followed DIE's CU.
11063         (follow_die_sig_1): Likewise.
11064
11065 2019-01-15  Tom Tromey  <tom@tromey.com>
11066
11067         * remote.c (class remote_state) <buf>: Now a char_vector.
11068         <buf_size>: Remove.
11069         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11070         parameter.
11071         (remote_target::getpkt_or_notif_sane_1)
11072         (remote_target::getpkt_sane)
11073         (remote_target::getpkt_or_notif_sane): Likewise.
11074         (class remote_target) <putpkt>: New overload.
11075         (remote_target::read_frame): Change type of "buf_p".  Remove
11076         sizeof_p parameter.
11077         (packet_ok): New overload.
11078         (packet_check_result): New overload.
11079         Update all uses.
11080
11081 2019-01-14  Tom Tromey  <tom@tromey.com>
11082
11083         * remote-notif.c (handle_notification, remote_notif_ack)
11084         (remote_notif_parse): Make "buf" const.
11085         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11086         const.
11087         (remote_notif_parse, remote_notif_ack, handle_notification):
11088         Likewise.
11089         * remote.c (remote_notif_stop_parse): Make "buf" const.
11090         (remote_target::remote_parse_stop_reply): Make "buf" const.
11091         (remote_notif_stop_ack): Make "buf" const.
11092
11093 2019-01-14  Tom Tromey  <tom@tromey.com>
11094
11095         * remote.c (remote_console_output): Make parameter const.
11096
11097 2019-01-14  Tom Tromey  <tom@tromey.com>
11098
11099         * target-debug.h (target_debug_print_signals): Constify.
11100         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11101         * procfs.c (procfs_target::pass_signals): Update.
11102         * linux-nat.c (linux_nat_target::pass_signals): Update.
11103         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11104         * target-delegates.c: Rebuild.
11105         * remote.c (remote_target::program_signals): Update.
11106         (remote_target::pass_signals): Update.
11107         * target.c (target_pass_signals): Constify argument.
11108         (target_program_signals): Likewise.
11109         * target.h (struct target_ops) <pass_signals, program_signals>:
11110         Constify argument.
11111         (target_pass_signals, target_program_signals): Constify argument.
11112
11113 2019-01-14  Tom Tromey  <tom@tromey.com>
11114
11115         PR tui/28819:
11116         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11117
11118 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11119
11120         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11121         field.
11122         * rs6000-tdep.c: Include reggroups.h.
11123         (IS_V_ALIAS_PSEUDOREG): Define.
11124         (rs6000_register_name): Return names for the "vX" aliases.
11125         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11126         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11127         aliases.  Call default_register_reggroup_p for all other
11128         pseudo-registers.
11129         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11130         New functions.
11131         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11132         Handle "vX" aliases.
11133         (v_alias_pseudo_register_collect): New function.
11134         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11135         (rs6000_gdbarch_init): Initialize "vX" aliases as
11136         pseudo-registers.  Restore registration of
11137         rs6000_pseudo_register_reggroup_p with
11138         set_tdesc_pseudo_register_reggroup_p.
11139
11140 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11141
11142         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11143         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11144         set_gdbarch_num_pseudo_regs.
11145
11146 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11147
11148         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11149         Remove arg prefixname, add do_set and do_show.
11150         Add member functions set_list and show_list.
11151         * cli/cli-style.c (class cli_style_option): Update accordingly.
11152         (style_set_list): Move to file scope.
11153         (style_show_list): Likewise.
11154         (set_style): Call help_list.
11155         (show_style): Call cmd_show_list.
11156         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11157         Update to use the new macro.
11158
11159 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11160
11161         * ada-lang.c (_initialize_ada_language): Expand the help text
11162         for the "catch exception" command.
11163
11164 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11165
11166         * symtab.c (matching_obj_sections): Initialize obj,
11167         declare it closer to its usage.
11168
11169 2019-01-10  Tom Tromey  <tom@tromey.com>
11170
11171         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11172         (basic_inf_threads_range): Remove.
11173         (inf_threads_range, inf_non_exited_threads_range)
11174         (safe_inf_threads_range): Use next_adapter.
11175
11176 2019-01-10  Keith Seitz  <keiths@redhat.com>
11177
11178         PR gdb/23712
11179         PR symtab/23010
11180         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11181         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11182
11183 2019-01-10  Keith Seitz  <keiths@redhat.com>
11184
11185         PR gdb/23712
11186         PR symtab/23010
11187         * dictionary.c (pending_to_vector): Remove.
11188         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11189         Remove _1 suffix, replacing functions of the same name.  Update
11190         all callers.
11191         (dict_create_hashed, dict_create_hashed_expandable)
11192         (dict_create_linear, dict_create_linear_expandable, dict_free)
11193         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11194         Make functions static.
11195
11196 2019-01-10  Keith Seitz  <keiths@redhat.com>
11197
11198         PR gdb/23712
11199         PR symtab/23010
11200         * dictionary.h (struct dictionary): Replace declaration with
11201         multidictionary.
11202         (dict_create_hashed, dict_create_hashed_expandable)
11203         (dict_create_linear, dict_create_linear_expandable)
11204         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11205         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11206         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11207         taking multidictionary argument.
11208         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11209         * block.h (struct block) <dict>: Change to multidictionary
11210         and rename `multidict'.
11211         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11212         symmisc.c: Update all dictionary references to multidictionary.
11213
11214 2019-01-10  Keith Seitz  <keiths@redhat.com>
11215
11216         PR gdb/23712
11217         PR symtab/23010
11218         * dictionary.c: Include unordered_map.
11219         (pending_to_vector): New function.
11220         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11221         Rewrite the non-"_1" functions to take vector instead
11222         of linked list.
11223         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11224         "new" _1 versions of the same name.
11225         (multidictionary): Define.
11226         (std::hash<enum language): New definition.
11227         (collate_pending_symbols_by_language, mdict_create_hashed)
11228         (mdict_create_hashed_expandable, mdict_create_linear)
11229         (mdict_create_linear_expandable, mdict_free)
11230         (find_language_dictionary, create_new_language_dictionary)
11231         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11232         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11233         (mdict_size, mdict_empty): New functions.
11234         * dictionary.h (mdict_iterator): Define.
11235
11236 2019-01-10  Pedro Alves  <palves@redhat.com>
11237
11238         * breakpoint.c (read_uploaded_action)
11239         (create_tracepoint_from_upload): Adjust to use
11240         gdb::unique_xmalloc_ptr.
11241         * ctf.c (ctf_write_uploaded_tp):
11242         (SET_ARRAY_FIELD): Use emplace_back.
11243         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11244         * tracefile-tfile.c (tfile_write_uploaded_tp):
11245         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11246         gdb::unique_xmalloc_ptr.
11247         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11248         at_string, cond_string, cmd_strings>: Replace char pointers
11249         with gdb::unique_xmalloc_ptr.
11250
11251 2019-01-10  Pedro Alves  <palves@redhat.com>
11252
11253         * solib-target.c (library_list_start_library): Don't xstrdup name.
11254
11255 2019-01-10  Pedro Alves  <palves@redhat.com>
11256
11257         * mdebugread.c (parse_partial_symbols): Use
11258         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11259
11260 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11261
11262         * linux-fork.c (scoped_switch_fork_info)
11263         <~scoped_switch_fork_info>: Fix incorrect variable name.
11264
11265 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11266
11267         * linux-fork.c (scoped_switch_fork_info)
11268         <scoped_switch_fork_info>: Make explicit.
11269         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11270
11271 2019-01-10  Tom Tromey  <tom@tromey.com>
11272
11273         * objfiles.h (objfile::reset_psymtabs): Update.
11274         * objfiles.c (objfile::objfile): Update.
11275         * psymtab.h (psymtab_storage::obstack): Update.
11276         (psymtab_storage::m_obstack): Use gdb::optional.
11277         (class psymtab_storage): Update comment.  Remove objfile
11278         parameter.
11279         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11280
11281 2019-01-10  Tom Tromey  <tom@tromey.com>
11282
11283         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11284         <free_psymtabs>: Now private.
11285         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11286         (allocate_psymtab): Use new method.
11287
11288 2019-01-10  Tom Tromey  <tom@tromey.com>
11289
11290         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11291         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11292         * mdebugread.c (parse_partial_symbols): Use
11293         allocate_dependencies.
11294         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11295         allocate_dependencies.
11296         (process_psymtab_comp_unit_reader)
11297         (build_type_psymtab_dependencies): Likewise.
11298         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11299
11300 2019-01-10  Tom Tromey  <tom@tromey.com>
11301
11302         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11303         PSYMBOL_SET_LANGUAGE.
11304         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11305
11306 2019-01-10  Tom Tromey  <tom@tromey.com>
11307
11308         * psymtab.h (psymtab_storage::obstack): New method.
11309         <m_obstack>: Rename from obstack; now private.
11310         * psymtab.c (psymtab_storage): Update.
11311         * dwarf2read.c (create_addrmap_from_index)
11312         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11313         Update.
11314
11315 2019-01-10  Tom Tromey  <tom@tromey.com>
11316
11317         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11318         * objfiles.h (objfile::reset_psymtabs): New method.
11319
11320 2019-01-10  Tom Tromey  <tom@tromey.com>
11321
11322         * symmisc.c (print_symbol_bcache_statistics): Update.
11323         (print_objfile_statistics): Update.
11324         * symfile.c (reread_symbols): Update.
11325         * psymtab.h (class psymtab_storage): New.
11326         * psymtab.c (psymtab_storage): New constructor.
11327         (~psymtab_storage): New destructor.
11328         (require_partial_symbols): Update.
11329         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11330         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11331         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11332         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11333         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11334         (start_psymtab_common, end_psymtab_common)
11335         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11336         (allocate_psymtab): Update.
11337         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11338         Update.
11339         (dump_psymtab_addrmap, maintenance_print_psymbols)
11340         (maintenance_check_psymtabs): Update.
11341         (class objfile_psymtabs): Move to objfiles.h.
11342         * psympriv.h (discard_psymtab): Now inline.
11343         (psymtab_discarder::psymtab_discarder): Update.
11344         (psymtab_discarder::~psymtab_discarder): Update.
11345         (ALL_OBJFILE_PSYMTABS): Rewrite.
11346         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11347         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11348         Remove fields.
11349         <partial_symtabs>: New field.
11350         (class objfile_psymtabs): Move from psymtab.h.  Update.
11351         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11352         psymbol_cache.
11353         (objfile::~objfile): Don't destroy psymbol_cache.
11354         * mdebugread.c (parse_partial_symbols): Update.
11355         * dwarf2read.c (create_addrmap_from_index)
11356         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11357         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11358         (add_partial_subprogram, dwarf2_ranges_read): Update.
11359         * dwarf-index-write.c (write_address_map)
11360         (write_one_signatured_type, recursively_write_psymbols)
11361         (class debug_names, class debug_names, write_psymtabs_to_index):
11362         Update.
11363
11364 2019-01-10  Tom Tromey  <tom@tromey.com>
11365
11366         * symtab.h (SYMBOL_SET_NAMES): Update.
11367         (symbol_set_names): Update.
11368         (MSYMBOL_SET_NAMES): Update.
11369         * symtab.c (symbol_set_names): Change argument to be an
11370         objfile_per_bfd_storage.
11371         * psymtab.c (add_psymbol_to_bcache): Update.
11372         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11373
11374 2019-01-10  Tom Tromey  <tom@tromey.com>
11375
11376         * symtab.c (create_demangled_names_hash): Change argument to be an
11377         objfile_per_bfd_storage.
11378         (symbol_set_names): Update.
11379
11380 2019-01-10  Tom Tromey  <tom@tromey.com>
11381
11382         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11383         init_psymbol_list.
11384         * psymtab.c (init_psymbol_list): Do nothing if already called.
11385         * psympriv.h (init_psymbol_list): Add comment.
11386         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11387         init_psymbol_list.
11388         * dbxread.c (dbx_symfile_read): Unconditionally call
11389         init_psymbol_list.
11390
11391 2019-01-10  Tom Tromey  <tom@tromey.com>
11392
11393         * xcoffread.c (scan_xcoff_symtab): Update.
11394         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11395         "where".
11396         * mdebugread.c (parse_partial_symbols)
11397         (handle_psymbol_enumerators): Update.
11398         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11399         * dbxread.c (read_dbx_symtab): Update.
11400         * psympriv.h (psymbol_placement): New enum.
11401         (add_psymbol_to_list): Update.
11402
11403 2019-01-10  Tom Tromey  <tom@tromey.com>
11404
11405         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11406         static_psymbols parameters.
11407         (scan_xcoff_symtab): Update.
11408         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11409         static_psymbols parameters.
11410         * psympriv.h (start_psymtab_common): Update.
11411         * mdebugread.c (parse_partial_symbols): Update.
11412         * dwarf2read.c (create_partial_symtab): Update.
11413         * dbxread.c (read_dbx_symtab): Update.
11414         (start_psymtab): Remove global_psymbols and static_psymbols
11415         parameters.
11416
11417 2019-01-10  Tom Tromey  <tom@tromey.com>
11418
11419         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11420         * psymtab.c (allocate_psymtab): Add comment.
11421         * psympriv.h (allocate_psymtab): Add comment.
11422         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11423         initializations.
11424         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11425
11426 2019-01-10  Tom Tromey  <tom@tromey.com>
11427
11428         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11429         Don't declare.
11430         * mipsread.c: Include mdebugread.h.
11431         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11432         Declare.
11433         * elfread.c: Include mdebugread.h.
11434
11435 2019-01-09  Tom Tromey  <tom@tromey.com>
11436
11437         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11438         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11439         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11440         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11441         (psym_lookup_symbol, psym_find_last_source_symtab)
11442         (psym_forget_cached_source_info, psym_print_stats)
11443         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11444         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11445         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11446         (psym_find_compunit_symtab_by_address)
11447         (maintenance_print_psymbols, maintenance_info_psymtabs)
11448         (maintenance_check_psymtabs): Use ranged for.
11449         * psymtab.h (class objfile_psymtabs): New.
11450         (require_partial_symbols): Return objfile_psymtabs.
11451         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11452
11453 2019-01-09  Tom Tromey  <tom@tromey.com>
11454
11455         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11456         (find_pc_mapped_section, list_overlays_command)
11457         (map_overlay_command, unmap_overlay_command)
11458         (simple_overlay_update): Use all_objfiles.
11459         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11460         * printcmd.c (info_symbol_command): Use all_objfiles.
11461         * objfiles.h (ALL_OBJSECTIONS): Remove.
11462         * maint.c (maintenance_translate_address): Use all_objfiles.
11463         * gcore.c (gcore_create_callback): Use all_objfiles.
11464         (objfile_find_memory_regions): Likewise.
11465
11466 2019-01-09  Tom Tromey  <tom@tromey.com>
11467
11468         * symtab.c (find_line_symtab, info_sources_command)
11469         (make_source_files_completion_list): Use objfile_compunits.
11470         * source.c (select_source_symtab): Use objfile_compunits.
11471         * objfiles.h (struct objfile): Update comment.
11472         (ALL_OBJFILES): Remove.
11473         (ALL_FILETABS): Remove.
11474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11475         objfile_compunits.
11476
11477 2019-01-09  Tom Tromey  <tom@tromey.com>
11478
11479         * symmisc.c (print_objfile_statistics, dump_objfile)
11480         (maintenance_print_symbols): Use compunit_filetabs.
11481         * source.c (forget_cached_source_info_for_objfile): Use
11482         compunit_filetabs.
11483         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11484         (ALL_FILETABS): Use compunit_filetabs.
11485         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11486         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11487
11488 2019-01-09  Tom Tromey  <tom@tromey.com>
11489
11490         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11491         (compunit_filetabs): New.
11492         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11493         compunit_filetabs.
11494         (info_sources_command, make_source_files_completion_list): Remove
11495         declaration.
11496         * symmisc.c (print_objfile_statistics, dump_objfile)
11497         (maintenance_print_symbols): Remove declaration.
11498         (maintenance_info_symtabs): Use compunit_filetabs.
11499         (maintenance_info_line_tables): Likewise.
11500         * source.c (select_source_symtab): Change local variable name.
11501         (forget_cached_source_info_for_objfile): Remove declaration.
11502         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11503         * objfiles.c (objfile_relocate1): Remove declaration.
11504         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11505         declaration.
11506         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11507         * coffread.c (coff_symtab_read): Remove declaration.
11508         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11509         compunit_filetabs.
11510
11511 2019-01-09  Tom Tromey  <tom@tromey.com>
11512
11513         * symtab.c (lookup_objfile_from_block)
11514         (find_pc_sect_compunit_symtab, search_symbols)
11515         (default_collect_symbol_completion_matches_break_on): Use
11516         objfile_compunits.
11517         * objfiles.h (ALL_COMPUNITS): Remove.
11518         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11519         * cp-support.c (add_symbol_overload_list_qualified): Use
11520         objfile_compunits.
11521         * ada-lang.c (ada_collect_symbol_completion_matches)
11522         (ada_add_global_exceptions): Use objfile_compunits.
11523
11524 2019-01-09  Tom Tromey  <tom@tromey.com>
11525
11526         * source.c (select_source_symtab)
11527         (forget_cached_source_info_for_objfile): Remove declaration.
11528         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11529         declaration.
11530         * maint.c (count_symtabs_and_blocks): Remove declaration.
11531         * cp-support.c (add_symbol_overload_list_qualified): Remove
11532         declaration.
11533         * coffread.c (coff_symtab_read): Remove declaration.
11534         * symtab.c (lookup_symbol_in_objfile_symtabs)
11535         (basic_lookup_transparent_type_1): Use objfile_compunits.
11536         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11537         (info_sources_command, search_symbols)
11538         (default_collect_symbol_completion_matches_break_on)
11539         (make_source_files_completion_list): Remove declaration.
11540         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11541         (ada_collect_symbol_completion_matches)
11542         (ada_add_global_exceptions): Remove declaration.
11543         * linespec.c (iterate_over_all_matching_symtabs): Use
11544         objfile_compunits.
11545         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11546         (class objfile_compunits): New.
11547         (ALL_COMPUNITS): Use objfile_compunits.
11548         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11549         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11550         objfile_compunits.
11551         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11552
11553 2019-01-09  Tom Tromey  <tom@tromey.com>
11554
11555         * symtab.c (search_symbols)
11556         (default_collect_symbol_completion_matches_break_on): Use
11557         objfile_msymbols.
11558         * ada-lang.c (ada_lookup_simple_minsym)
11559         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11560         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11561         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11562         objfile_msymbols.
11563         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11564         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11565         * objc-lang.c (find_methods): Use objfile_msymbols.
11566         (info_selectors_command, info_classes_command): Likewise.
11567         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11568         * objfiles.h (class objfile_msymbols): New.
11569         (ALL_OBJFILE_MSYMBOLS): Remove.
11570         (ALL_MSYMBOLS): Remove.
11571
11572 2019-01-09  Tom Tromey  <tom@tromey.com>
11573
11574         * common/next-iterator.h (next_adapter): Add Iterator template
11575         parameter.
11576         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11577         (class all_objfiles_safe): New.
11578         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11579         * objfiles.c (put_objfile_before): Update comment.
11580         (add_separate_debug_objfile): Likewise.
11581         (free_all_objfiles): Use all_objfiles_safe.
11582         (objfile_purge_solibs): Likewise.
11583
11584 2019-01-09  Tom Tromey  <tom@tromey.com>
11585
11586         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11587         (expand_symtab_containing_pc, lookup_static_symbol)
11588         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11589         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11590         all_objfiles.
11591         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11592         * breakpoint.c (create_overlay_event_breakpoint)
11593         (create_longjmp_master_breakpoint)
11594         (create_std_terminate_master_breakpoint)
11595         (create_exception_master_breakpoint): Use all_objfiles.
11596         * linux-thread-db.c (try_thread_db_load_from_pdir)
11597         (has_libpthread): Use all_objfiles.
11598         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11599         * linespec.c (iterate_over_all_matching_symtabs)
11600         (search_minsyms_for_name): Use all_objfiles.
11601         * maint.c (maintenance_info_sections): Use all_objfiles.
11602         * main.c (captured_main_1): Use all_objfiles.
11603         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11604         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11605         * guile/scm-pretty-print.c
11606         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11607         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11608         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11609         (maintenance_print_msymbols): Use all_objfiles.
11610         * source.c (select_source_symtab): Use all_objfiles.
11611         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11612         * symfile.c (remove_symbol_file_command)
11613         (expand_symtabs_matching, map_symbol_filenames): Use
11614         all_objfiles.
11615         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11616         all_objfiles.
11617         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11618         * objc-lang.c (find_methods): Use all_objfiles.
11619         * objfiles.c (have_partial_symbols, have_full_symbols)
11620         (have_minimal_symbols, qsort_cmp)
11621         (default_iterate_over_objfiles_in_search_order): Use
11622         all_objfiles.
11623         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11624         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11625         (maintenance_check_psymtabs): Use all_objfiles.
11626         (ALL_PSYMTABS): Remove.
11627         * compile/compile-object-run.c (do_module_cleanup): Use
11628         all_objfiles.
11629         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11630         * cp-support.c (add_symbol_overload_list_qualified): Use
11631         all_objfiles.
11632         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11633         Use all_objfiles.
11634         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11635         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11636         all_objfiles.
11637         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11638         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11639         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11640         Uses all_objfiles.
11641         * solib.c (solib_read_symbols): Use all_objfiles
11642
11643 2019-01-09  Tom Tromey  <tom@tromey.com>
11644
11645         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11646         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11647         all_objfiles.
11648         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11649         * symmisc.c (print_symbol_bcache_statistics)
11650         (print_objfile_statistics, maintenance_print_objfiles)
11651         (maintenance_info_symtabs, maintenance_check_symtabs)
11652         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11653         all_objfiles.
11654         * source.c (forget_cached_source_info): Use all_objfiles.
11655         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11656         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11657         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11658         * objfiles.c (update_section_map): Use all_objfiles.
11659         (shared_objfile_contains_address_p): Likewise.
11660         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11661         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11662
11663 2019-01-09  Tom Tromey  <tom@tromey.com>
11664
11665         * common/next-iterator.h: New file.
11666         * objfiles.h (class all_objfiles): New.
11667         (struct objfile_iterator): New.
11668
11669 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11670
11671         * NEWS: Move the description of the changed "frame", "select-frame",
11672          and "info frame" commands to the Changed commands section.
11673
11674 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11675
11676         * gdbtypes.c (check_stub_method_group): Remove handling of old
11677         mangling schemes.
11678         * linespec.c (find_methods): Likewise.
11679         * stabsread.c (read_member_functions): Likewise.
11680         * valops.c (search_struct_method): Likewise.
11681         (value_struct_elt_for_reference): Likewise.
11682         * NEWS: Mention this change.
11683
11684 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11685
11686         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11687         print_source_lines.
11688         * source.c (print_source_lines_base): Update line number check.
11689         (print_source_lines): New function.
11690         (source_lines_range::source_lines_range): New function.
11691         * source.h (class source_lines_range): New class.
11692         (print_source_lines): New declaration.
11693
11694 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11695
11696         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11697
11698 2019-01-08  Tom Tromey  <tom@tromey.com>
11699             Simon Marchi  <simon.marchi@ericsson.com>
11700
11701         PR gdb/24060
11702         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11703         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11704         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11705         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11706         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11707         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11708
11709 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11710
11711         * source.c (select_source_symtab): Move header comment to
11712         declaration in source.h.
11713         (forget_cached_source_info_for_objfile): Likewise.
11714         (forget_cached_source_info): Likewise.
11715         (identify_source_line): Likewise.
11716         * source.h (identify_source_line): Move declaration from symtab.h
11717         and add comment from source.c
11718         (print_source_lines): Likewise.
11719         (forget_cached_source_info_for_objfile): Likewise.
11720         (forget_cached_source_info): Likewise.
11721         (select_source_symtab): Likewise.
11722         (enum print_source_lines_flag): Move definition from symtab.h.
11723         * symtab.h (identify_source_line): Move declaration to source.h.
11724         (print_source_lines): Likewise.
11725         (forget_cached_source_info_for_objfile): Likewise.
11726         (forget_cached_source_info): Likewise.
11727         (select_source_symtab): Likewise.
11728         (enum print_source_lines_flag): Move definition to source.h.
11729         * tui/tui-hooks.c: Add 'source.h' include.
11730
11731 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11732
11733         * source.c (print_source_lines_base): Handle requests to print
11734         reverse line number sequences, and guard against empty lines
11735         string.
11736
11737 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11738
11739         * source.c (print_source_lines_base): Fix skip of '\r' if next
11740         character is '\n'.
11741
11742 2019-01-06  Tom Tromey  <tom@tromey.com>
11743
11744         * c-exp.y (struct c_parse_state) <macro_original_text,
11745         expansion_obstack>: New member.
11746         (macro_original_text, expansion_obstack): Remove globals.
11747         (scan_macro_expansion, scanning_macro_expansion)
11748         (finished_macro_expansion): Update.
11749         (scan_macro_cleanup): Remove.
11750         (yylex, c_parse): Update.
11751
11752 2019-01-06  Tom Tromey  <tom@tromey.com>
11753
11754         * c-exp.y (struct c_parse_state) <strings>: New member.
11755         (operator_stoken): Update.
11756
11757 2019-01-06  Tom Tromey  <tom@tromey.com>
11758
11759         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11760         (union type_stack_elt) <typelist_val>: Now a pointer to
11761         std::vector.
11762         (type_stack_cleanup): Don't declare.
11763         (push_typelist): Update.
11764         * parse.c (pop_typelist): Return a std::vector.
11765         (push_typelist): Take a std::vector.
11766         (follow_types): Update.  Do not free args.
11767         (type_stack_cleanup): Remove.
11768         * c-exp.y (struct c_parse_state): New.
11769         (cpstate): New global.
11770         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11771         (nonempty_typelist): Update.
11772         (func_mod): Create a new vector.
11773         (c_parse): Create a c_parse_state.
11774         (check_parameter_typelist): Do not delete params.
11775         (function_method): Update.  Do not delete type_list.
11776
11777 2019-01-06  Tom Tromey  <tom@tromey.com>
11778
11779         PR gdb/28155:
11780         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11781         check_typedef.
11782         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11783         (print_return_value): Likewise.
11784
11785 2019-01-05  Tom Tromey  <tom@tromey.com>
11786
11787         * contrib/cleanup_check.py: Remove.
11788         * contrib/gcc-with-excheck: Remove.
11789         * contrib/exsummary.py: Remove.
11790         * contrib/excheck.py: Remove.
11791
11792 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11793
11794         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11795         NULL. Initialize tpprev to NULL instead of assigning it
11796         to NULL on the next statement.
11797         * windows-nat.c (windows_delete_thread): Remove check for
11798         main_thread_id before printing thread exit notifications.
11799         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11800         Remove thread ID check against main_thread_id.
11801         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11802         windows_delete_thread.
11803         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11804
11805 2019-01-04  Tom Tromey  <tom@tromey.com>
11806
11807         * compile/compile.c (_initialize_compile): Use upper case for
11808         metasyntactic variables.
11809         * symmisc.c (_initialize_symmisc): Use upper case for
11810         metasyntactic variables.
11811         * psymtab.c (_initialize_psymtab): Use upper case for
11812         metasyntactic variables.
11813         * demangle.c (demangle_command): Use upper case for metasyntactic
11814         variables.
11815         (_initialize_demangler): Likewise.
11816         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11817         variables.
11818
11819 2019-01-03  Tom Tromey  <tom@tromey.com>
11820
11821         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11822
11823 2019-01-03  Tom Tromey  <tom@tromey.com>
11824
11825         * python/py-symtab.c (salpy_str): Update.
11826         (struct salpy_sal_object) <symtab>: Now a PyObject.
11827         (salpy_dealloc): Update.
11828         (del_objfile_sal): Use gdbpy_ref.
11829
11830 2019-01-03  Tom Tromey  <tom@tromey.com>
11831
11832         * python/py-type.c (convert_field): Use new_reference.  Return
11833         gdbpy_ref.
11834         (make_fielditem): Return gdbpy_ref.
11835         (typy_fields): Update.
11836         (typy_getitem): Update.
11837         (field_name): Return gdbpy_ref.  Use new_reference.
11838         (typy_iterator_iternext): Update.
11839
11840 2019-01-03  Tom Tromey  <tom@tromey.com>
11841
11842         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11843
11844 2019-01-03  Tom Tromey  <tom@tromey.com>
11845
11846         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11847         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11848         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11849         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11850         (pspy_set_type_printers): Likewise.
11851         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11852         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11853         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11854         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11855         (objfpy_set_type_printers): Likewise.
11856
11857 2019-01-03  Tom Tromey  <tom@tromey.com>
11858
11859         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11860         (gdbpy_print_stack): Use gdbpy_err_fetch.
11861         * python/python-internal.h (class gdbpy_err_fetch): New class.
11862         (class gdbpy_enter) <m_error_type, m_error_value,
11863         m_error_traceback>: Remove.
11864         <m_error>: New member.
11865         (gdbpy_exception_to_string): Don't declare.
11866         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11867         * python/py-value.c (convert_value_from_python): Use
11868         gdbpy_err_fetch.
11869         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11870         gdbpy_exception_to_string.
11871         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11872         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11873         gdbpy_err_fetch.
11874
11875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11876
11877         * linux-nat.c (delete_lwp_cleanup): Delete.
11878         (struct lwp_deleter): New struct.
11879         (lwp_info_up): New typedef.
11880         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11881         lwp_info_up.
11882
11883 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11884
11885         * linux-fork.c (class scoped_switch_fork_info): New class.
11886         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11887
11888 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11889
11890         * valops.c (find_overload_match): Remove use of null_cleanup, and
11891         calls to do_cleanups.
11892
11893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11894
11895         * compile/compile-cplus-types.c
11896         (compile_cplus_instance::decl_name): Handle changes to
11897         cp_func_name.
11898         * cp-support.c (cp_func_name): Update header comment, update
11899         return type.
11900         * cp-support.h (cp_func_name): Update return type in declaration.
11901         * valops.c (find_overload_match): Move temp_func local to top
11902         level of function and change its type.  Use temp_func to hold and
11903         delete temporary string obtained from cp_func_name.
11904
11905 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11906
11907         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11908         gdb::char_vector, remove cleanup, and update uses of `msg`.
11909
11910 2019-01-03  Jim Wilson  <jimw@sifive.com>
11911
11912         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11913
11914 2019-01-02  Tom Tromey  <tom@tromey.com>
11915
11916         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11917         (tdesc_parse_xml): Remove cleanups.
11918         * target-descriptions.h (make_cleanup_free_target_description):
11919         Don't declare.
11920         (target_desc_deleter): New struct.
11921         (target_desc_up): New typedef.
11922         * target-descriptions.c (target_desc_deleter::operator()): Rename
11923         from free_target_description.
11924         (make_cleanup_free_target_description): Remove.
11925
11926 2019-01-02  Tom Tromey  <tom@tromey.com>
11927
11928         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11929         constructor, destructor.
11930         (linespec_parser): Remove typedef.
11931         (~linespec_parser): Rename from linespec_parser_delete.
11932         (linespec_lex_to_end, linespec_complete_label)
11933         (linespec_complete): Update.
11934         (decode_line_full): Remove cleanups.
11935         (decode_line_1): Update.
11936
11937 2019-01-02  Tom Tromey  <tom@tromey.com>
11938
11939         * python/python-internal.h (inferior_to_inferior_object): Change
11940         return type.
11941         * python/py-exitedevent.c (create_exited_event_object): Update.
11942         * python/py-inferior.c (inferior_to_inferior_object): Return
11943         gdbpy_ref.
11944         (python_new_inferior, python_inferior_deleted)
11945         (thread_to_thread_object, delete_thread_object)
11946         (build_inferior_list, gdbpy_selected_inferior): Update.
11947         * python/py-infthread.c (create_thread_object): Update.  Also fail
11948         if inferior_to_inferior_object fails.
11949
11950 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11951
11952         * inferior.h (class inferior) <displaced_step_state>: New field.
11953         * infrun.h (struct displaced_step_state): Move here from
11954         infrun.c.  Initialize fields, add constructor.
11955         <inf>: Remove field.
11956         <reset>: New method.
11957         * infrun.c (struct displaced_step_inferior_state): Move to
11958         infrun.h.
11959         (displaced_step_inferior_states): Remove.
11960         (get_displaced_stepping_state): Adust.
11961         (displaced_step_in_progress_any_inferior): Adjust.
11962         (displaced_step_in_progress_thread): Adjust.
11963         (displaced_step_in_progress): Adjust.
11964         (add_displaced_stepping_state): Remove.
11965         (get_displaced_step_closure_by_addr): Adjust.
11966         (remove_displaced_stepping_state): Remove.
11967         (infrun_inferior_exit): Call displaced_step_state.reset.
11968         (use_displaced_stepping): Don't check for NULL.
11969         (displaced_step_prepare_throw): Call
11970         get_displaced_stepping_state.
11971         (displaced_step_fixup): Don't check for NULL.
11972         (prepare_for_detach): Don't check for NULL.
11973
11974 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11975
11976         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11977          in case of call that did not complete.
11978
11979 2019-01-02  Andrey Utkin  <autkin@undo.io>
11980
11981         * symfile.c (find_separate_debug_file): Fix search of debug files for
11982         remote debuggee.
11983
11984 2019-01-02  Tom Tromey  <tom@tromey.com>
11985
11986         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11987         indentation.
11988         * python/py-frame.c (frapy_older): Remove cast.
11989         (frapy_newer): Likewise.
11990         * python/py-breakpoint.c (local_setattro): Remove cast.
11991         * python/py-arch.c (archpy_name): Remove local variable.
11992         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11993
11994 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11995
11996         * unittests/basic_string_view/element_access/char/empty.cc:
11997         Fix year range in copyright header.
11998
11999 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12000
12001         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12002         Delete.
12003         <operator==>: Update with for removed field.
12004         <hash>: Likewise.
12005         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12006         <isa_features>: ...this.
12007         <abi_features>: New field.
12008         (riscv_isa_flen): Update comment.
12009         (riscv_abi_xlen): New declaration.
12010         (riscv_abi_flen): New declaration.
12011         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12012         isa_features.
12013         (riscv_abi_xlen): New function.
12014         (riscv_isa_flen): Update to get answer from isa_features.
12015         (riscv_abi_flen): New function.
12016         (riscv_has_fp_abi): Update to get answer from abi_features.
12017         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12018         xlen and flen.
12019         (riscv_call_info) <xlen, flen>: Update comment.
12020         (riscv_call_arg_struct): Remove invalid assertions
12021         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12022         is removed.
12023         (riscv_gdbarch_init): Gather isa features and abi features
12024         separately, ensure both match on the gdbarch when reusing an old
12025         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12026         a target with 64-bit float hardware.
12027
12028 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12029
12030         * source.c (search_command_helper): Stop reverse search
12031         when line 1 has been searched.
12032
12033 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12034
12035         * record-full.c (record_full_base_target::close): Rewrite
12036         record_full_core_buf_list free logic.
12037
12038 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12039
12040         * break-catch-syscall.c (print_one_catch_syscall): xfree
12041         the last text.
12042
12043 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12044
12045         * top.c (print_gdb_version): Update Copyright year in version
12046         message.
12047
12048 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12049
12050         Update copyright year range in all GDB files.
12051
12052 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12053
12054         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12055
12056 For older changes see ChangeLog-2018.
12057 \f
12058 Local Variables:
12059 mode: change-log
12060 left-margin: 8
12061 fill-column: 74
12062 version-control: never
12063 coding: utf-8
12064 End:
12065