gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
   4         Don't call tui_locator_win_info_ptr.
   5
   6 2019-09-20  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-win.c (tui_resize_all): Don't call refresh.
   9
  10 2019-09-20  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
  13         height for locator.
  14         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
  15         * tui/tui-layout.c (show_source_disasm_command, show_data)
  16         (show_source_or_disasm_and_command): Use 1 as height for locator.
  17
  18 2019-09-20  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui.c (tui_enable): Update.
  21         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
  22         Update.
  23         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
  24         Update.
  25         * tui/tui-data.c (win_resized): Now bool.
  26         (tui_win_resized): Return bool.
  27         (tui_set_win_resized_to): Accept a bool.
  28
  29 2019-09-20  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
  32         Change type of "refresh_values_only".
  33         * tui/tui-regs.c (tui_data_window::show_register_group): Change
  34         type of "refresh_values_only".
  35
  36 2019-09-20  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
  39         std::string.
  40         (tui_disassemble): Add "pos" parameter.
  41         (tui_disasm_window::set_contents): Simplify.
  42
  43 2019-09-20  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-winsource.h (struct tui_source_window_base)
  46         <show_source_content>: Now private.
  47         * tui/tui-winsource.c
  48         (tui_source_window_base::show_source_content): Don't handle empty
  49         content case.
  50
  51 2019-09-20  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-layout.c (show_source_disasm_command)
  54         (show_source_or_disasm_and_command): Don't call
  55         show_source_content.
  56
  57 2019-09-20  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
  60         Declare.
  61         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
  62         from tui_make_status_line.
  63         (tui_locator_window::rerender): Update.
  64
  65 2019-09-20  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-stack.c (tui_make_status_line): Return std::string.
  68         (tui_locator_window::rerender): Update.
  69
  70 2019-09-20  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.h (struct tui_source_window_base)
  73         <~tui_source_window_base>: Don't declare.
  74         <fullname>: Remove.
  75         * tui/tui-winsource.c (~tui_source_window_base): Remove.
  76         * tui/tui-source.h (struct tui_source_window) <fullname>: New
  77         member.
  78         * tui/tui-source.c (tui_source_window::set_contents): Update.
  79         (tui_source_window::location_matches_p)
  80         (tui_source_window::maybe_update): Update.
  81
  82 2019-09-20  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.h (~tui_source_element): Remove.
  85         (tui_source_element): Update.
  86         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
  87         * tui/tui-winsource.c (tui_show_source_line): Update.
  88         * tui/tui-source.c (tui_source_window::set_contents): Update.
  89         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  90
  91 2019-09-20  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
  94         declare.
  95         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
  96         tui_clear_source_windows_detail.
  97         * tui/tui-winsource.h (struct tui_source_window_base)
  98         <clear_detail>: Don't declare.
  99         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 100         Remove.
 101         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 102
 103 2019-09-20  Tom Tromey  <tromey@adacore.com>
 104
 105         PR ada/24919:
 106         * block.c (contained_in): Fix final return value.
 107
 108 2019-09-20  Alan Modra  <amodra@gmail.com>
 109
 110         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 111         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 112         (read_indirect_string_from_dwz): Use bfd accessor.
 113         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 114         * machoread.c (macho_symfile_read_all_oso): Likewise.
 115         * solib.c (solib_bfd_open): Likewise.
 116
 117 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 118
 119         * eval.c: Move declaration of overload_resolution to...
 120         * value.h: ...here.
 121
 122 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 123
 124         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 125         * arm-linux-tdep.c: Likewise.
 126         * arm-nbsd-nat.c: Likewise.
 127         * arm-tdep.h: Declare arm_apcs_32.
 128         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 129
 130 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 131
 132         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 133         * dwarf2read.h: Declare dwarf_always_disassemble.
 134
 135 2019-09-19  Tom de Vries  <tdevries@suse.de>
 136
 137         PR gdb/25009
 138         * source-cache.c (source_cache::ensure): Catch exception thrown during
 139         construction of the highlighter.
 140
 141 2019-09-18  Alan Modra  <amodra@gmail.com>
 142
 143         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 144         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 145         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 146         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 147         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 148         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 149         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 150         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 151         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 152         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 153         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 154         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 155         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 156         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 157         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 158         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 159         * mi/mi-interp.c: Update throughout for bfd section macro and
 160         function changes.
 161         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 162         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 163
 164 2019-09-18  Tom Tromey  <tom@tromey.com>
 165
 166         * NEWS: Add entry.
 167         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 168         call rl_initialize.
 169         (tui_enable): Do not call rl_initialize.
 170
 171 2019-09-18  Christian Groessler  <chris@groessler.org>
 172
 173         * alpha-linux-nat.c: Include gdbarch.h.
 174
 175 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 176
 177         * ui-file.c: Include cli/cli-style.h.
 178         (term_cli_styling): Remove cli_styling declaration.
 179
 180 2019-09-18  Alan Modra  <amodra@gmail.com>
 181
 182         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 183         to bfd_asymbol_section.
 184
 185 2019-09-18  Alan Modra  <amodra@gmail.com>
 186
 187         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 188         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 189         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 190
 191 2019-09-18  Alan Modra  <amodra@gmail.com>
 192
 193         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 194         * spu-linux-nat.c (spu_bfd_open): Likewise.
 195
 196 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 197
 198         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 199         to bool to match definition in dwarf2read.c.
 200
 201 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 202
 203         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 204         (print_signatures): Likewise.
 205         (trust_pad_over_xvs): Likewise.
 206         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 207         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 208         * arm-linux-nat.c (arm_apcs_32): Likewise.
 209         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 210         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 211         * arm-tdep.c (arm_debug): Likewise.
 212         (arm_apcs_32): Likewise.
 213         * auto-load.c (debug_auto_load): Likewise.
 214         (auto_load_gdb_scripts): Likewise.
 215         (global_auto_load): Likewise.
 216         (auto_load_local_gdbinit): Likewise.
 217         (auto_load_local_gdbinit_loaded): Likewise.
 218         * auto-load.h (global_auto_load): Likewise.
 219         (auto_load_local_gdbinit): Likewise.
 220         (auto_load_local_gdbinit_loaded): Likewise.
 221         * breakpoint.c (disconnected_dprintf): Likewise.
 222         (breakpoint_proceeded): Likewise.
 223         (automatic_hardware_breakpoints): Likewise.
 224         (always_inserted_mode): Likewise.
 225         (target_exact_watchpoints): Likewise.
 226         (_initialize_breakpoint): Update.
 227         * breakpoint.h (target_exact_watchpoints): Change to bool.
 228         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 229         * cli/cli-cmds.c (trace_commands): Likewise.
 230         * cli/cli-cmds.h (trace_commands): Likewise.
 231         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 232         to bool*.
 233         * cli/cli-logging.c (logging_overwrite): Change to bool.
 234         (logging_redirect): Likewise.
 235         (debug_redirect): Likewise.
 236         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 237         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 238         to bool.
 239         <boolean_option_def>: Update.
 240         (struct flag_option_def): Change default type of Context to bool
 241         from int.
 242         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 243         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 244         (get_setshow_command_value_string): Likewise.
 245         * cli/cli-style.c (cli_styling): Change to bool.
 246         (source_styling): Likewise.
 247         * cli/cli-style.h (source_styling): Likewise.
 248         (cli_styling): Likewise.
 249         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 250         to bool.
 251         * command.h (var_types): Update comment.
 252         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 253         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 254         bool.
 255         (debug_compile_cplus_scopes): Likewise.
 256         * compile/compile-internal.h (compile_debug): Likewise.
 257         * compile/compile.c (compile_debug): Likewise.
 258         (struct compile_options) <raw>: Likewise.
 259         * cp-support.c (catch_demangler_crashes): Likewise.
 260         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 261         (usr_cmd_cris_dwarf2_cfi): Likewise.
 262         * csky-tdep.c (csky_debug): Likewise.
 263         * darwin-nat.c (enable_mach_exceptions): Likewise.
 264         * dcache.c (dcache_enabled_p): Likewise.
 265         * defs.h (info_verbose): Likewise.
 266         * demangle.c (demangle): Likewise.
 267         (asm_demangle): Likewise.
 268         * dwarf-index-cache.c (debug_index_cache): Likewise.
 269         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 270         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 271         * dwarf2read.c (check_physname): Likewise.
 272         (use_deprecated_index_sections): Likewise.
 273         (dwarf_always_disassemble): Likewise.
 274         * eval.c (overload_resolution): Likewise.
 275         * event-top.c (set_editing_cmd_var): Likewise.
 276         (exec_done_display_p): Likewise.
 277         * event-top.h (set_editing_cmd_var): Likewise.
 278         (exec_done_display_p): Likewise.
 279         * exec.c (write_files): Likewise.
 280         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 281         (debug_fbsd_nat): Likewise.
 282         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 283         Likewise.
 284         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 285         <backtrace_past_entry> Likewise.
 286         * gdb-demangle.h (demangle): Likewise.
 287         (asm_demangle): Likewise.
 288         * gdb_bfd.c (bfd_sharing): Likewise.
 289         * gdbcore.h (write_files): Likewise.
 290         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 291         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 292         * gdbthread.h (print_thread_events): Likewise.
 293         * gdbtypes.c (opaque_type_resolution): Likewise.
 294         (strict_type_checking): Likewise.
 295         * gnu-nat.c (gnu_debug_flag): Likewise.
 296         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 297         * guile/scm-param.c (pascm_variable): Add boolval.
 298         (add_setshow_generic): Update.
 299         (pascm_param_value): Update.
 300         (pascm_set_param_value_x): Update.
 301         * hppa-tdep.c (hppa_debug): Change to bool..
 302         * infcall.c (may_call_functions_p): Likewise.
 303         (coerce_float_to_double_p): Likewise.
 304         (unwind_on_signal_p): Likewise.
 305         (unwind_on_terminating_exception_p): Likewise.
 306         * infcmd.c (startup_with_shell): Likewise.
 307         * inferior.c (print_inferior_events): Likewise.
 308         * inferior.h (startup_with_shell): Likewise.
 309         (print_inferior_events): Likewise.
 310         * infrun.c (step_stop_if_no_debug): Likewise.
 311         (detach_fork): Likewise.
 312         (debug_displaced): Likewise.
 313         (disable_randomization): Likewise.
 314         (non_stop): Likewise.
 315         (non_stop_1): Likewise.
 316         (observer_mode): Likewise.
 317         (observer_mode_1): Likewise.
 318         (set_observer_mode): Update.
 319         (sched_multi): Change to bool.
 320         * infrun.h (debug_displaced): Likewise.
 321         (sched_multi): Likewise.
 322         (step_stop_if_no_debug): Likewise.
 323         (non_stop): Likewise.
 324         (disable_randomization): Likewise.
 325         * linux-tdep.c (use_coredump_filter): Likewise.
 326         (dump_excluded_mappings): Likewise.
 327         * linux-thread-db.c (auto_load_thread_db): Likewise.
 328         (check_thread_db_on_load): Likewise.
 329         * main.c (captured_main_1): Update.
 330         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 331         xx2_opt, boolean_opt>: Change to bool.
 332         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 333         * maint.c (maintenance_profile_p): Likewise.
 334         (per_command_time): Likewise.
 335         (per_command_space): Likewise.
 336         (per_command_symtab): Likewise.
 337         * memattr.c (inaccessible_by_default): Likewise.
 338         * mi/mi-main.c (mi_async): Likewise.
 339         (mi_async_1): Likewise.
 340         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 341         * nat/fork-inferior.h (startup_with_shell): Likewise.
 342         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 343         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 344         * nios2-tdep.c (nios2_debug): Likewise.
 345         * or1k-tdep.c (or1k_debug): Likewise.
 346         * parse.c (parser_debug): Likewise.
 347         * parser-defs.h (parser_debug): Likewise.
 348         * printcmd.c (print_symbol_filename): Likewise.
 349         * proc-api.c (procfs_trace): Likewise.
 350         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 351         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 352         (set_parameter_value): Update.
 353         (add_setshow_generic): Update.
 354         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 355         to bool*.
 356         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 357         int*.
 358         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 359         * record-btrace.c (record_btrace_target::store_registers): Update.
 360         * record-full.c (record_full_memory_query): Change to bool.
 361         (record_full_stop_at_limit): Likewise.
 362         * record-full.h (record_full_memory_query): Likewise.
 363         * remote-notif.c (notif_debug): Likewise.
 364         * remote-notif.h (notif_debug): Likewise.
 365         * remote.c (use_range_stepping): Likewise.
 366         (interrupt_on_connect): Likewise.
 367         (remote_break): Likewise.
 368         * ser-tcp.c (tcp_auto_retry): Likewise.
 369         * ser-unix.c (serial_hwflow): Likewise.
 370         * skip.c (debug_skip): Likewise.
 371         * solib-aix.c (solib_aix_debug): Likewise.
 372         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 373         (spu_auto_flush_cache_p): Likewise.
 374         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 375         Likewise.
 376         (struct info_print_options) <quiet>: Likewise.
 377         * symfile-debug.c (debug_symfile): Likewise.
 378         * symfile.c (auto_solib_add): Likewise.
 379         (separate_debug_file_debug): Likewise.
 380         * symfile.h (auto_solib_add): Likewise.
 381         (separate_debug_file_debug): Likewise.
 382         * symtab.c (basenames_may_differ): Likewise.
 383         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 384         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 385         (struct info_types_options) <quiet>: Likewise.
 386         * symtab.h (demangle): Likewise.
 387         (basenames_may_differ): Likewise.
 388         * target-dcache.c (stack_cache_enabled_1): Likewise.
 389         (code_cache_enabled_1): Likewise.
 390         * target.c (trust_readonly): Likewise.
 391         (may_write_registers): Likewise.
 392         (may_write_memory): Likewise.
 393         (may_insert_breakpoints): Likewise.
 394         (may_insert_tracepoints): Likewise.
 395         (may_insert_fast_tracepoints): Likewise.
 396         (may_stop): Likewise.
 397         (auto_connect_native_target): Likewise.
 398         (target_stop_and_wait): Update.
 399         (target_async_permitted): Change to bool.
 400         (target_async_permitted_1): Likewise.
 401         (may_write_registers_1): Likewise.
 402         (may_write_memory_1): Likewise.
 403         (may_insert_breakpoints_1): Likewise.
 404         (may_insert_tracepoints_1): Likewise.
 405         (may_insert_fast_tracepoints_1): Likewise.
 406         (may_stop_1): Likewise.
 407         * target.h (target_async_permitted): Likewise.
 408         (may_write_registers): Likewise.
 409         (may_write_memory): Likewise.
 410         (may_insert_breakpoints): Likewise.
 411         (may_insert_tracepoints): Likewise.
 412         (may_insert_fast_tracepoints): Likewise.
 413         (may_stop): Likewise.
 414         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 415         (make_thread_apply_all_options_def_group): Change argument from int*
 416         to bool*.
 417         (thread_apply_all_command): Update.
 418         (print_thread_events): Change to bool.
 419         * top.c (confirm): Likewise.
 420         (command_editing_p): Likewise.
 421         (history_expansion_p): Likewise.
 422         (write_history_p): Likewise.
 423         (info_verbose): Likewise.
 424         * top.h (confirm): Likewise.
 425         (history_expansion_p): Likewise.
 426         * tracepoint.c (disconnected_tracing): Likewise.
 427         (circular_trace_buffer): Likewise.
 428         * typeprint.c (print_methods): Likewise.
 429         (print_typedefs): Likewise.
 430         * utils.c (debug_timestamp): Likewise.
 431         (sevenbit_strings): Likewise.
 432         (pagination_enabled): Likewise.
 433         * utils.h (sevenbit_strings): Likewise.
 434         (pagination_enabled): Likewise.
 435         * valops.c (overload_resolution): Likewise.
 436         * valprint.h (struct value_print_options) <prettyformat_arrays,
 437         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 438         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 439         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 440         Likewise.
 441         * windows-nat.c (new_console): Likewise.
 442         (cygwin_exceptions): Likewise.
 443         (new_group): Likewise.
 444         (debug_exec): Likewise.
 445         (debug_events): Likewise.
 446         (debug_memory): Likewise.
 447         (debug_exceptions): Likewise.
 448         (useshell): Likewise.
 449         * windows-tdep.c (maint_display_all_tib): Likewise.
 450         * xml-support.c (debug_xml): Likewise.
 451
 452 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 453
 454         * source.c (prepare_path_for_appending): New function.
 455         (openp): Make use of new function.
 456         (find_and_open_source): Search for the compilation directory and
 457         source file as a relative path beneath the directory search path.
 458
 459 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * source-cache.c (source_cache::get_line_charpos): Catch
 462         exceptions and return false, this matches the behaviour documented
 463         in the header file.
 464
 465 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 466
 467         * ada-tasks.c (info_task): Remove quoting of the task's name.
 468
 469 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 470
 471         * symfile.c (auto_solib_add): Replace comment with a reference
 472         to the header file.
 473
 474 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 475
 476         * NEWS: Mention that gdb can now be compiled with Python 3
 477         on Windows.
 478
 479 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 480
 481         * maint.c (maint_print_section_data::maint_print_section_data):
 482         Force use of 'float log10 (float)' by casting the argument to
 483         float.
 484
 485 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * maint.c: Add 'cmath' include.
 488         (struct maint_print_section_data): New structure.
 489         (print_section_index): New function.
 490         (print_bfd_section_info): Add header comment, small whitespace
 491         cleanup, and update to call new print_section_index function.
 492         (print_objfile_section_info): Likewise.
 493         (maint_obj_section_from_bfd_section): New function.
 494         (print_bfd_section_info_maybe_relocated): New function.
 495         (maintenance_info_sections): Add header comment, always use
 496         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 497
 498 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 501         inner scope, add check that the objfile has psymtabs before
 502         checking psymtabs_addrmap.
 503         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 504
 505 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 506
 507         * NEWS: Announce that Ada task names are now shown at more places,
 508         and between quotes (except in info task output).
 509         * gdb/ada-tasks.c (task_to_str): New function.
 510         (display_current_task_id): Call task_to_str.
 511         (task_command_1): Likewise.
 512         (print_ada_task_info): In non-mi mode, Properly align headers and data
 513         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 514
 515 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 516
 517         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 518         prstatus.pr_lwp.pr_info instead of making it up.
 519
 520 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 521
 522         * auto-load.c (auto_load_expand_dir_vars): Update.
 523         * defs.h (gdb_datadir): Change to std::string.
 524         (python_libdir): Likewise.
 525         (relocate_gdb_directory): Change return type to std::string.
 526         * guile/guile.c (gdbscm_data_directory): Update.
 527         (initialize_scheme_side): Update.
 528         * jit.c (jit_reader_dir): Change to std::string.
 529         (jit_reader_load_command): Update.
 530         * main.c (gdb_datadir): Change to std::string.
 531         (python_libdir): Likewise.
 532         (set_gdb_data_directory): Update.
 533         (relocate_path): Change to return std::string.
 534         (relocate_gdb_directory): Change to return std::string.
 535         (relocate_gdbinit_path_maybe_in_datadir): Update.
 536         (captured_main_1): Update.
 537         * python/python.c (do_start_initialization): Update.
 538         * top.c (show_gdb_datadir): Update.
 539         * xml-syscall.c (xml_init_syscalls_info): Update.
 540         (init_syscalls_info): Update.
 541
 542 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 543
 544         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 545         out of get_init_files.
 546         (get_init_files): Update.
 547
 548 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 549
 550         * main.c (get_init_files): Change to use std::string.
 551         (captured_main_1): Update.
 552         (print_gdb_help): Update.
 553
 554 2019-09-11  Ali Tamur  <tamur@google.com>
 555
 556         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 557         implementation.
 558
 559 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 560
 561         * dbxread.c (read_dbx_symtab): Update.
 562         * dwarf2read.c (load_partial_dies): Update.
 563         * mdebugread.c (parse_partial_symbols): Update.
 564         (handle_psymbol_enumerators): Update.
 565         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 566         * psymtab.c (add_psymbol_to_bcache): Likewise.
 567         (add_psymbol_to_list): Likewise.
 568         * symtab.c (symbol_set_names): Likewise.
 569         * symtab.h (symbol_set_names): Likewise.
 570         * xcoffread.c (scan_xcoff_symtab): Update.
 571
 572 2019-09-11  Tom Tromey  <tom@tromey.com>
 573
 574         * symfile-mem.c (symbol_file_add_from_memory): Use
 575         bfd_set_filename.
 576         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 577         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 578
 579 2019-09-10  Tom Tromey  <tromey@adacore.com>
 580
 581         * dwarf-index-write.c (write_psymbols): Extend error message.
 582         (debug_names::insert): Add Ada code.
 583         (debug_names::write_psymbols): Remove Ada check.
 584         (debug_names) <m_string_obstack>: New member.
 585         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 586         (gdb_index_symbol_name_matcher::matches): Remove.
 587         (mapped_index_base::find_name_components_bounds): Add "lang"
 588         parameter.
 589         (mapped_index_base::build_name_components): Also split names
 590         according to Ada syntax.
 591         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 592         type of "match_callback".
 593         (check_match, check_find_bounds_finds)
 594         (dw2_expand_symtabs_matching): Update.
 595         (dw2_debug_names_iterator): Add new constructor.
 596         (dw2_debug_names_map_matching_symbols): New function.
 597         (dw2_debug_names_expand_symtabs_matching): Update.
 598         (dwarf2_debug_names_functions): Use
 599         dw2_debug_names_map_matching_symbols.
 600
 601 2019-09-10  Tom Tromey  <tromey@adacore.com>
 602
 603         * dwarf2read.c (dw2_get_file_names_reader): Add the
 604         CU's file name to the results.
 605
 606 2019-09-10  Tom Tromey  <tromey@adacore.com>
 607
 608         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 609         map_matching_symbols.  Update.
 610         * dwarf2read.c (dw2_map_matching_symbols): Update.
 611         * psymtab.c (match_partial_symbol): Change type; update.
 612         (psym_map_matching_symbols): Likewise.
 613         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 614         type; update.
 615         * symfile.h (struct quick_symbol_functions)
 616         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 617         Remove "match".
 618
 619 2019-09-10  Tom Tromey  <tromey@adacore.com>
 620
 621         * psymtab.c (map_block): Remove.
 622         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 623         * symtab.c (iterate_over_symbols_terminated): New function.
 624         * symtab.c (iterate_over_symbols_terminated): Declare.
 625
 626 2019-09-10  Tom Tromey  <tromey@adacore.com>
 627
 628         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 629         * language.h (struct language_defn) <la_iterate_over_symbols>:
 630         Return bool.
 631         * symtab.c (iterate_over_symbols): Return bool.
 632         * symtab.h (iterate_over_symbols): Return bool.
 633
 634 2019-09-10  Tom Tromey  <tromey@adacore.com>
 635
 636         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 637         (add_nonlocal_symbols): Update.
 638         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 639         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 640         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 641         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 642         Change type of "callback".  Remove "data".
 643
 644
 645 2019-09-09  Ali Tamur  <tamur@google.com>
 646
 647         * dwarf2read.c (comp_unit_head): Update comment.
 648         (dwarf2_dwo_name): New function declaration.
 649         (dwarf_unit_type_name): New function declaration.
 650         (read_comp_unit_head): Add support for new compilation units,
 651         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 652         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 653         (currently named as "signature") in their header. Also clarify error
 654         messages.
 655         (lookup_dwo_id): New function. Returns the dwo id of the given
 656         compile unit.
 657         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 658         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 659         functions.
 660         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 661         (dwarf2_dwo_name): Get the dwo name if present.
 662         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 663         purposes.
 664
 665 2019-09-09  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 668
 669 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 670
 671         * python/python.c (do_start_initialization): Make progname_copy static,
 672         to avoid a leak report.
 673
 674 2019-09-08  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 677
 678 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 679
 680         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 681         Change type to gdb::optional<block_enum>.
 682         (dw2_symtab_iter_init): Change block_index parameter type
 683         to gdb::optional<block_enum>.
 684         (dw2_lookup_symbol): Change block_index parameter
 685         type to block_enum.c
 686         (dw2_debug_names_lookup_symbol): Likewise.
 687         * psymtab.c (psym_lookup_symbol): Likewise.
 688         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 689         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 690         Likewise.
 691
 692 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 693
 694         * defs.h (relocate_gdb_directory): Change int to bool in
 695         signature and rename flag to relocatable.
 696         * main.c (relocate_path): Likewise.
 697         (relocate_gdb_directory): Likewise.
 698
 699 2019-09-06  Alan Modra  <amodra@gmail.com>
 700
 701         * coffread.c (coff_symfile_read): Constify filename variable.
 702         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 703         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 704         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 705         * solib.c (reload_shared_libraries_1): Likewise.
 706         * symfile.c (reread_symbols): Likewise.
 707         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 708         * solib-darwin.c (darwin_bfd_open): Likewise.
 709         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 710
 711 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 714         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 715
 716 2019-09-03  Tom Tromey  <tromey@adacore.com>
 717
 718         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 719         types.
 720         (has_negatives): Unbias a range type bound.
 721         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 722         * gdbtypes.c (operator==): Handle new field.
 723         (create_range_type): Add "bias" parameter.
 724         (create_static_range_type, resolve_dynamic_range): Update.
 725         * gdbtypes.h (struct range_bounds) <bias>: New member.
 726         (create_range_type): Add bias parameter.
 727         * printcmd.c (print_scalar_formatted): Unbias range types.
 728         * value.c (unpack_long): Unbias range types.
 729         (pack_long): Bias range types.
 730
 731 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 732
 733         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 734         probe arguments.
 735
 736 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 737
 738         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 739         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 740         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 741         (compile_probe_arg): Likewise.
 742         * probe.h (get_argument_count): Likewise.
 743         * solib-svr4.c (solib_event_probe_action): Likewise.
 744         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 745
 746 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 747
 748         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 749         code to here...
 750         (svr4_create_solib_event_breakpoints): ...from here.
 751
 752 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 753
 754         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 755         suffix from warning message.
 756
 757 2019-08-30  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-winsource.h (struct tui_source_window_base)
 760         <refresh_all>: Don't declare.
 761         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 762         Remove.
 763         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 764         tui_show_locator_content.
 765         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 766         declare.
 767         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 768         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 769         declare.
 770
 771 2019-08-30  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 774
 775 2019-08-30  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 778         Remove unnecessary forward declarations.
 779
 780 2019-08-30  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 783         rerender.
 784         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 785         tui_show_locator_content.
 786
 787 2019-08-30  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 790         (tui_locator_window::rerender): Rewrite using body of previous
 791         tui_show_locator_content.
 792
 793 2019-08-30  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 796         set_locator_fullname>: New methods.
 797         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 798         Rename from tui_set_locator_fullname.
 799         (tui_locator_window::set_locator_info): Rename from
 800         tui_set_locator_info.  Return bool.
 801         (tui_update_locator_fullname, tui_show_frame_info): Update.
 802
 803 2019-08-30  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 806
 807 2019-08-30  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 810         call touchwin.
 811
 812 2019-08-30  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-wingeneral.c (box_win): Assume win_info and
 815         win_info->handle cannot be NULL.
 816
 817 2019-08-30  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 820         refresh_window>: Declare.
 821         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 822         resize.
 823         (tui_data_item_window::rerender): Rename from
 824         tui_display_register.
 825         (tui_data_item_window::refresh_window): New method.
 826         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 827         no-op.
 828
 829 2019-08-30  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 832         regs_column_count, current_group>: Move later.  Now private.
 833         <get_current_group>: New method.
 834         * tui/tui-regs.c (tui_reg_command): Update.
 835         * tui/tui-layout.c (tui_set_layout): Update.
 836
 837 2019-08-30  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 840         (tui_data_window::rerender): Don't call
 841         check_and_display_highlight_if_needed.
 842         (tui_data_window::refresh_all): Remove call to
 843         erase_data_content.
 844
 845 2019-08-30  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 848         (tui_data_window::display_registers_from)
 849         (tui_data_window::display_reg_element_at_line)
 850         (tui_data_window::display_registers_from_line): Remove checks of
 851         "empty".
 852
 853 2019-08-30  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 856         Don't declare.
 857         * tui/tui-regs.c (tui_data_window::show_registers): Call
 858         rerender.
 859         (tui_data_window::rerender): Rename from display_all_data.
 860         (tui_data_window::rerender): Remove old implementation.
 861
 862 2019-08-30  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 865         text.
 866         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 867
 868 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 869             Sergio Durigan Junior  <sergiodj@redhat.com>
 870
 871         PR win32/24284
 872         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 873
 874 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 877         when searching for types.
 878
 879 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * f-lang.c (f_language_defn): Use f_print_typedef.
 882         * f-lang.h (f_print_typedef): Declare.
 883         * f-typeprint.c (f_print_typedef): Define.
 884
 885 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 886
 887         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 888
 889 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 890
 891         * cli/cli-utils.c (info_print_options_defs): Delete.
 892         (make_info_print_options_def_group): Delete.
 893         (extract_info_print_options): Delete.
 894         (info_print_command_completer): Delete.
 895         (info_print_args_help): Add extra parameter, and optionally
 896         include text about -n flag.
 897         * cli/cli-utils.h (struct info_print_options): Delete.
 898         (extract_info_print_options): Delete declaration.
 899         (info_print_command_completer): Delete declaration.
 900         (info_print_args_help): Add extra parameter, extend header
 901         comment.
 902         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 903         search_symbols.
 904         * stack.c (struct info_print_options): New type.
 905         (info_print_options_defs): New file scoped variable.
 906         (make_info_print_options_def_group): New static function.
 907         (info_print_command_completer): New static function.
 908         (info_locals_command): Update to use new local functions.
 909         (info_args_command): Likewise.
 910         (_initialize_stack): Add extra parameter to calls to
 911         info_print_args_help.
 912         * symtab.c (search_symbols): Add extra parameter, use this to
 913         possibly excluse non-debug symbols.
 914         (symtab_symbol_info): Add extra parameter, which is passed on to
 915         search_symbols.
 916         (struct info_print_options): New type.
 917         (info_print_options_defs): New file scoped variable.
 918         (make_info_print_options_def_group): New static function.
 919         (info_print_command_completer): New static function.
 920         (info_variables_command): Update to use local functions, and pass
 921         extra parameter through to symtab_symbol_info.
 922         (info_functions_command): Likewise.
 923         (info_types_command): Pass additional argument through to
 924         symtab_symbol_info.
 925         (rbreak_command): Pass extra argument to search_symbols.
 926         (_initialize_symtab): Add extra arguments for calls to
 927         info_print_args_help, and update help text for 'info variables',
 928         'whereis', and 'info functions' commands.
 929         * symtab.h (search_symbols): Add extra argument to declaration.
 930         * NEWS: Mention new flags.
 931
 932 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 933
 934         * symtab.c (lookup_static_symbol): Call the new function (and move
 935         it down to be next to lookup_global_symbol).
 936         (struct global_sym_lookup_data): Add block_enum member and rename to...
 937         (struct global_or_static_sym_lookup_data): ...this.
 938         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 939         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 940         (lookup_symbol_global_or_static_iterator_cb): ...this.
 941         (lookup_global_or_static_symbol): New function.
 942         (lookup_global_symbol): Call new function.
 943
 944 2019-08-26  Tom de Vries  <tdevries@suse.de>
 945
 946         PR c++/24852
 947         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 948         when pc_probe.prob == NULL.
 949
 950 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 951
 952         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 953         variable symbol_linkage to symbol_linkage_.
 954
 955 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 956
 957         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 958         represent whether the symbol is static, dynamic, or we don't
 959         know.
 960
 961 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 962
 963         * gdb/rx-tdep.c (rx_register_names): New.
 964         (rx_register_name): Delete.
 965         (rx_psw_type): Delete.
 966         (rx_fpsw_type): Delete.
 967         (rx_register_type): Delete.
 968         (rx_gdbarch_init): Convert target-descriptions.
 969         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 970         * gdb/features/Makefile: Add rx.xml.
 971         * gdb/features/rx.xml: New.
 972         * gdb/features/rx.c: Generated.
 973         * gdb/NEWS: Mention target description support.
 974
 975 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 976
 977         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 978         *slot_ptr.
 979
 980 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 981
 982         * configure.ac: Don't check for 'dlfcn.h' (moved to
 983         gdbsupport/common.m4).
 984         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 985         'gdbsupport/'.
 986         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 987         * compile/compile-c-support.c: Include
 988         'gdbsupport/gdb-dlfcn.h'.
 989         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 990         * gdb-dlfcn.c: Move to...
 991         * gdbsupport/gdb-dlfcn.c: ... here.
 992         * gdb-dlfcn.h: Move to...
 993         * gdbsupport/gdb-dlfcn.h: ... here.
 994
 995 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 996
 997         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 998         the offset field signed.
 999
1000 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1001
1002         * python/lib/gdb/__init__.py (_execute_file): New function.
1003         * python/python.c (python_run_simple_file): Call gdb._execute_file
1004         on Windows.
1005
1006 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1009         all uses as this was never set to anything but a zero value.
1010
1011 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1012
1013         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1014
1015 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1016
1017         * tui/tui-data.h (tui_gen_win_info): Add an =default
1018         move constructor, required by some GCC versions.
1019
1020 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1021
1022         * go32-nat.c (go32_sysinfo): Add hygon_p.
1023
1024 2019-08-20  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1027         line_from_reg_element_no, first_reg_element_no_inline,
1028         display_all_data, delete_data_content_windows,
1029         erase_data_content>: Now private.
1030
1031 2019-08-20  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1034         (tui_unhighlight_win, tui_highlight_win)
1035         (tui_win_info::make_window): Update.
1036         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1037
1038 2019-08-20  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1041         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1042         (MAX_PID_WIDTH): Move to tui-stack.c.
1043         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1044         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1045         (MAX_PID_WIDTH): Move from tui-data.h.
1046
1047 2019-08-20  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1050         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1051         (box_win): Update.
1052         (tui_gen_win_info::make_window): Rename from tui_make_window.
1053         (tui_win_info::make_window): New method.
1054         (tui_gen_win_info::make_visible): Update.
1055         * tui/tui-source.c (tui_source_window::set_contents): Update.
1056         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1057         (tui_data_window::display_registers_from): Update.
1058         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1059         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1060         Declare.
1061         <can_box>: Remove.
1062         <title>: Remove.
1063         (struct tui_win_info) <make_window>: Declare.
1064         <can_box>: Now virtual.
1065         <title>: New member.
1066         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1067         * tui/tui-command.c (tui_cmd_window::resize): Update.
1068
1069 2019-08-20  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1072         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1073         (tui_data_window::check_register_values): Update.
1074
1075 2019-08-20  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-regs.h (struct tui_data_window): Use
1078         DISABLE_COPY_AND_ASSIGN.
1079         <regs_content>: Change type, removing unique_ptr.
1080         <tui_data_window>: Add move constructor.
1081         * tui/tui-regs.c (tui_data_window::show_registers)
1082         (tui_data_window::show_register_group)
1083         (tui_data_window::display_registers_from)
1084         (tui_data_window::display_registers_from)
1085         (tui_data_window::first_data_item_displayed)
1086         (tui_data_window::delete_data_content_windows)
1087         (tui_data_window::rerender, tui_data_window::refresh_window)
1088         (tui_data_window::check_register_values): Update.
1089
1090 2019-08-20  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1093         show_register_group>: Declare.
1094         (tui_show_register_group): Don't declare.
1095         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1096         tui_show_registers.
1097         (tui_data_window::show_register_group): Rename from
1098         tui_show_register_group.
1099         (tui_data_window::check_register_values, tui_reg_command):
1100         Update.
1101         * tui/tui-layout.c (tui_set_layout): Update.
1102
1103 2019-08-20  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1106         Declare.
1107         (tui_check_register_values): Don't declare.
1108         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1109         from tui_check_register_values.
1110         * tui/tui-hooks.c (tui_register_changed): Update.
1111
1112 2019-08-20  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-regs.c (tui_reg_layout): Move later.
1115         (tui_show_registers): Don't enable TUI mode or change layout.
1116
1117 2019-08-20  Tom Tromey  <tom@tromey.com>
1118
1119         * tui/tui-regs.h (struct tui_data_item_window)
1120         <~tui_data_item_window>: Remove.
1121         <content>: Now a unique_xmalloc_ptr.
1122         * tui/tui-regs.c (tui_register_format): Return a
1123         unique_xmalloc_ptr.
1124         (tui_get_register): Update.
1125         (~tui_data_item_window): Remove.
1126         (tui_data_window::display_registers_from, tui_display_register):
1127         Update.
1128         * tui/tui-io.h (tui_expand_tabs): Update.
1129         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1130         Remove "col" parameter.
1131
1132 2019-08-20  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1135         field.
1136         * tui/tui-regs.c (~tui_data_item_window): Update.
1137
1138 2019-08-20  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1141         earlier.
1142
1143 2019-08-20  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1146
1147 2019-08-20  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-source.h (struct tui_source_window): Update.
1150         * tui/tui-regs.c (tui_show_registers): Update.
1151         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1152         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1153         (NO_REGS_STRING): Remove defines.
1154
1155 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1156
1157         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1158         unnecessary thread walk if remote doesn't support the packet.
1159
1160 2019-08-19  Tom Tromey  <tromey@adacore.com>
1161
1162         * python/py-value.c (value_has_field): Fix indentation.
1163
1164 2019-08-19  Tom Tromey  <tromey@adacore.com>
1165
1166         * printcmd.c (do_one_display, info_display_command): Update.
1167         * block.h (contained_in): Return bool.  Add allow_nested
1168         parameter.
1169         * block.c (contained_in): Return bool.  Add allow_nested
1170         parameter.
1171
1172 2019-08-19  Tom Tromey  <tom@tromey.com>
1173
1174         * configure: Rebuild.
1175         * configure.ac: Disallow the combination of -static-libstdc++ and
1176         source highlight.
1177         * source-cache.c (get_language_name): Handle rust.
1178         (source_cache::get_source_lines): Ignore highlighting exceptions.
1179
1180 2019-08-16  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1183         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1184         (struct tui_source_window_base) <make_visible, refresh_window,
1185         resize>: Remove methods.
1186         <execution_info>: Remove field.
1187         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1188         (tui_show_source_line, tui_source_window_base)
1189         (~tui_source_window_base): Update.
1190         (tui_source_window_base::resize)
1191         (tui_source_window_base::make_visible)
1192         (tui_source_window_base::refresh_window): Remove.
1193         (tui_source_window_base::update_exec_info): Update.
1194         * tui/tui-source.c (tui_source_window::set_contents): Update.
1195         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1196
1197 2019-08-16  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1200         deprecated_query_hook.
1201
1202 2019-08-16  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1205         (tui_update_source_windows_with_line): Update.
1206         * tui/tui-source.h (struct tui_source_window)
1207         <show_symtab_source>: Declare.
1208         (tui_show_symtab_source): Don't declare.
1209         * tui/tui-source.c (tui_show_symtab_source): Rename from
1210         tui_show_symtab_source.
1211
1212 2019-08-16  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-winsource.h (struct tui_source_window_base)
1215         <set_contents>: Declare.
1216         * tui/tui-winsource.c
1217         (tui_source_window_base::update_source_window_as_is): Update.
1218         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1219         Declare.
1220         (tui_set_source_content): Don't declare.
1221         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1222         tui_set_source_content.
1223         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1224         Declare.
1225         (tui_set_disassem_content): Don't declare.
1226         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1227         tui_set_disassem_content.
1228
1229 2019-08-16  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-winsource.h (struct tui_source_window_base)
1232         <update_breakpoint_info>: Declare.
1233         (tui_update_breakpoint_info): Don't declare.
1234         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1235         (tui_update_all_breakpoint_info): Update.
1236         (tui_source_window_base::update_breakpoint_info): Rename from
1237         tui_update_breakpoint_info.
1238         (tui_source_window_base::update_exec_info): Update.
1239
1240 2019-08-16  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-winsource.h (struct tui_source_window_base)
1243         <update_source_window>: Declare.
1244         (tui_update_source_window): Don't declare.
1245         * tui/tui-winsource.c
1246         (tui_source_window_base::update_source_window): Rename from
1247         tui_update_source_window.
1248         (tui_source_window_base::rerender): Update.
1249         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1250         * tui/tui-disasm.c (tui_show_disassem)
1251         (tui_show_disassem_and_update_source)
1252         (tui_disasm_window::maybe_update): Update.
1253
1254 2019-08-16  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-winsource.h (struct tui_source_window_base)
1257         <update_source_window_as_is>: Declare.
1258         (tui_update_source_window_as_is): Don't declare.
1259         * tui/tui-winsource.c (tui_update_source_window): Update
1260         (tui_source_window_base::update_source_window_as_is): Rename from
1261         tui_update_source_window_as_is.
1262         (tui_source_window_base::refill): Update.
1263         * tui/tui-source.c (tui_show_symtab_source): Update.
1264         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1265         Update.
1266
1267 2019-08-16  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-winsource.h (tui_update_source_window)
1270         (tui_update_source_window_as_is): Remove "noerror" parameter.
1271         * tui/tui-winsource.c (tui_update_source_window)
1272         (tui_update_source_window_as_is): Remove "noerror" parameter.
1273         (tui_update_source_windows_with_addr)
1274         (tui_update_source_windows_with_line)
1275         (tui_source_window_base::rerender)
1276         (tui_source_window_base::refill): Update.
1277         * tui/tui-source.h (tui_set_source_content)
1278         (tui_show_symtab_source): Remove "noerror" parameter.
1279         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1280         parameter.
1281         (tui_show_symtab_source): Likewise.
1282         (tui_source_window::maybe_update): Update.
1283         * tui/tui-disasm.c (tui_show_disassem)
1284         (tui_show_disassem_and_update_source)
1285         (tui_disasm_window::do_scroll_vertical)
1286         (tui_disasm_window::maybe_update): Update.
1287
1288 2019-08-16  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui.c (tui_is_window_visible): Update.
1291         * tui/tui-wingeneral.c (tui_make_window)
1292         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1293         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1294         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1295         (tui_set_win_height_command, parse_scrolling_args): Update.
1296         * tui/tui-source.c (tui_source_window::style_changed): Update.
1297         * tui/tui-regs.c (tui_show_registers)
1298         (tui_data_window::first_data_item_displayed)
1299         (tui_data_window::delete_data_content_windows)
1300         (tui_check_register_values, tui_reg_command): Update.
1301         * tui/tui-disasm.c (tui_show_disassem): Update.
1302         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1303         method.
1304         <is_visible>: Remove field.
1305         * tui/tui-data.c (tui_next_win, tui_prev_win)
1306         (tui_delete_invisible_windows): Update.
1307
1308 2019-08-16  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-winsource.h (struct tui_source_window_base)
1311         <m_has_locator>: Remove.
1312         * tui/tui-layout.c (show_source_disasm_command, show_data)
1313         (show_source_or_disasm_and_command): Update.
1314
1315 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1316
1317         * NEWS (Other MI changes): New subsection.
1318         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1319         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1320         * arch-utils.c (default_get_pc_address_flags): New function.
1321         * arch-utils.h (default_get_pc_address_flags): New declaration.
1322         * gdbarch.sh: Add get_pc_address_flags.
1323         * gdbarch.c: Regenerate.
1324         * gdbarch.h: Likewise.
1325         * stack.c (print_pc): New function.
1326         (print_frame_info) (print_frame): Call print_pc.
1327
1328 2019-08-16  Tom de Vries  <tdevries@suse.de>
1329
1330         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1331         print_objfile_section_info.
1332
1333 2019-08-15  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1336         calling update_cmdwin_start_line.
1337         * tui/tui-winsource.h (struct tui_source_window_base)
1338         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1339         <rerender>: Declare.
1340         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1341         Call rerender.
1342         (tui_source_window_base::set_new_height): Remove.
1343         (tui_source_window_base::rerender): Rename from
1344         do_make_visible_with_new_height.
1345         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1346         resize method.
1347         (tui_win_info::make_invisible_and_set_new_height)
1348         (tui_win_info::make_visible_with_new_height): Remove.
1349         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1350         Declare.
1351         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1352         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1353         do_make_visible_with_new_height>: Don't declare.
1354         <rerender>: Declare.
1355         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1356         set_new_height.
1357         (tui_data_window::do_make_visible_with_new_height): Remove.
1358         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1359         call tui_show_locator_content.
1360         (tui_gen_win_info::resize): Call rerender.
1361         (show_source_or_disasm_and_command): Don't call
1362         tui_show_locator_content.
1363         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1364         method.
1365         (struct tui_win_info) <rerender>: Declare.
1366         <set_new_height, make_invisible_and_set_new_height,
1367         make_visible_with_new_height>: Don't declare.
1368         * tui/tui-data.c (tui_win_list::rerender): New method.
1369         * tui/tui-command.h (struct tui_cmd_window)
1370         <do_make_visible_with_new_height>: Don't declare.
1371         * tui/tui-command.c
1372         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1373
1374 2019-08-15  Tom Tromey  <tromey@adacore.com>
1375
1376         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1377         * ada-lang.c (ada_enum_name): Likewise.
1378
1379 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1380
1381         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1382         leading underscore.
1383         (GdbOutputErrorFile): Likewise.
1384         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1385         accordingly.
1386         (execute_unwinders): Rename to have a leading underscore.
1387         (auto_load_packages): Likewise.
1388         (global scope): Adjust call to auto_load_packages accordingly.
1389         (GdbSetPythonDirectory): Likewise.
1390         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1391         instead of execute_unwinders.
1392
1393 2019-08-15  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1396         (show_data): Don't change window visibility.
1397         (tui_gen_win_info::resize): Remove special case for command
1398         window.  Use wresize, when available.
1399         (show_source_or_disasm_and_command): Don't change window
1400         visibility.
1401         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1402         <make_visible>: New method.
1403         * tui/tui-command.c (tui_cmd_window::resize): New method.
1404
1405 2019-08-15  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1408         (struct tui_source_windows): New.
1409         * tui/tui-winsource.c (tui_display_main): Update.
1410         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1411         (new_height_ok, parse_scrolling_args): Update.
1412         * tui/tui-layout.c (show_layout, show_data): Update.
1413         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1414         (tui_add_to_source_windows): Don't declare.
1415         * tui/tui-data.c (source_windows, tui_source_windows)
1416         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1417
1418 2019-08-15  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1421         Rename from reset.
1422         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1423         * tui/tui-layout.c (show_source_disasm_command, show_data):
1424         Update.
1425         (tui_gen_win_info::resize): Rename.
1426         (show_source_or_disasm_and_command): Update.
1427         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1428         reset.
1429
1430 2019-08-15  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1433         * tui/tui-interp.c (tui_interp::init): Don't call
1434         tui_initialize_static_data.
1435         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1436
1437 2019-08-15  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1440         examine tui_win_list.
1441
1442 2019-08-15  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1445         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1446         tui_clear_source_content.
1447         (tui_clear_source_content): Remove.
1448         (tui_source_window_base::do_erase_source_content): Hoist call to
1449         content.clear().
1450         * tui/tui-stack.c (tui_show_frame_info): Don't call
1451         tui_clear_source_content.
1452
1453 2019-08-15  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-winsource.h (struct tui_source_window_base)
1456         <do_erase_source_content>: New method.
1457         <erase_source_content>: New method.
1458         (tui_erase_source_content): Don't declare.
1459         * tui/tui-winsource.c (tui_clear_source_content): Update.
1460         (tui_source_window_base::do_erase_source_content): Rename from
1461         tui_erase_source_content.
1462         (tui_source_window_base::show_source_content): Update.
1463         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1464         * tui/tui-source.h (struct tui_source_window)
1465         <erase_source_content>: New method.
1466         * tui/tui-disasm.h (struct tui_disasm_window)
1467         <erase_source_content>: New method.
1468
1469 2019-08-15  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1472         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1473         constructor.
1474         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1475         * tui/tui-source.c (tui_set_source_content): Update.
1476         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1477
1478 2019-08-15  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1481         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1482         tui-source.c.
1483         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1484         Declare.
1485         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1486         method.
1487         (tui_source_window::maybe_update): Update.
1488
1489 2019-08-15  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1492         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1493         tui-disasm.c.
1494         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1495         Declare.
1496         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1497         method.
1498         (tui_disasm_window::maybe_update): Update.
1499
1500 2019-08-15  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-winsource.h (struct tui_source_window_base)
1503         <maybe_update>: Declare.
1504         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1505         method.
1506         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1507         Declare.
1508         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1509         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1510         Declare.
1511         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1512
1513 2019-08-15  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1516
1517 2019-08-15  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-wingeneral.c: Include tui-stack.h.
1520         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1521         (struct tui_locator_window): Move from tui-data.h.
1522         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1523         (tui_initialize_static_data): Move from tui-data.c.
1524         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1525         (struct tui_locator_window): Move to tui-stack.c.
1526         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1527         (tui_initialize_static_data): Move to tui-stack.c.
1528
1529 2019-08-15  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-layout.c (show_source_disasm_command)
1532         (show_source_or_disasm_and_command): Use make_visible method, not
1533         tui_make_window.
1534         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1535         Remove.
1536
1537 2019-08-15  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-wingeneral.h (tui_make_window): Update.
1540         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1541         parameter.
1542         (tui_gen_win_info::make_visible): Update.
1543         * tui/tui-regs.c (tui_data_window::display_registers_from):
1544         Update.
1545         * tui/tui-layout.c (show_source_disasm_command)
1546         (show_source_or_disasm_and_command): Update.
1547         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1548         (enum tui_box): Remove.
1549         (struct tui_win_info) <can_box>: New method.
1550         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1551         method.
1552
1553 2019-08-15  Tom de Vries  <tdevries@suse.de>
1554
1555         * linux-nat-trad.c: Include gdbarch.h.
1556
1557 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1558
1559         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1560         register sizes.
1561
1562 2019-08-14  Tom Tromey  <tromey@adacore.com>
1563
1564         * darwin-nat.c: Include gdbarch.h.
1565         * darwin-nat-info.c: Include gdbarch.h.
1566
1567 2019-08-13  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1570         Remove.
1571         * tui/tui-data.c (tui_initialize_static_data): Update.
1572
1573 2019-08-13  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-winsource.h (struct tui_exec_info_window)
1576         <~tui_exec_info_window, maybe_allocate_content, get_content,
1577         m_content>: Remove.
1578         (struct tui_source_window_base) <set_exec_info_content,
1579         show_exec_info_content>: Don't declare.
1580         * tui/tui-winsource.c
1581         (tui_exec_info_window::maybe_allocate_content): Remove.
1582         (tui_source_window_base::update_exec_info): Rename from
1583         set_exec_info_content.
1584         (tui_source_window_base::show_exec_info_content)
1585         (tui_source_window_base::update_exec_info): Remove.
1586
1587 2019-08-13  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1590         declare.
1591         * tui/tui-winsource.c (tui_update_source_window_as_is)
1592         (tui_update_source_windows_with_addr, tui_erase_source_content):
1593         Update.
1594         (tui_clear_exec_info_content): Remove.
1595
1596 2019-08-13  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1599         declare.
1600         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1601         call tui_erase_exec_info_content.
1602         (tui_clear_exec_info_content): Rename from
1603         tui_erase_exec_info_content.
1604         (tui_clear_exec_info_content): Delete.
1605
1606 2019-08-13  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-winsource.h (struct tui_source_window_base)
1609         <show_exec_info_content>: Declare.
1610         (tui_show_exec_info_content): Don't declare.
1611         * tui/tui-winsource.c
1612         (tui_source_window_base::show_exec_info_content): Rename from
1613         tui_show_exec_info_content.
1614         (tui_source_window_base::update_exec_info): Update.
1615
1616 2019-08-13  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1619         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1620         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1621         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1622         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1623         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1624         ... here.
1625
1626 2019-08-13  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-winsource.h (struct tui_source_window_base)
1629         <update_exec_info>: Declare.
1630         (tui_update_exec_info): Don't declare.
1631         * tui/tui-winsource.c (tui_update_source_window_as_is)
1632         (tui_source_window_base::refresh_all)
1633         (tui_update_all_breakpoint_info): Update.
1634         (tui_source_window_base::update_exec_info): Rename from
1635         tui_update_exec_info.
1636         * tui/tui-stack.c (tui_show_frame_info): Update.
1637
1638 2019-08-13  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-winsource.h (struct tui_source_window_base)
1641         <set_exec_info_content>: Declare.
1642         (tui_set_exec_info_content): Don't declare.
1643         * tui/tui-winsource.c
1644         (tui_source_window_base::set_exec_info_content): Rename from
1645         tui_set_exec_info_content.
1646         (tui_update_exec_info): Update.
1647
1648 2019-08-13  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-winsource.h (struct tui_source_window_base)
1651         <show_source_content>: Declare.
1652         (tui_show_source_content): Don't declare.
1653         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1654         (tui_source_window_base::show_source_content): Rename from
1655         tui_show_source_content.
1656         (tui_source_window_base::refresh_all): Update.
1657         * tui/tui-layout.c (show_source_disasm_command)
1658         (show_source_or_disasm_and_command): Update.
1659
1660 2019-08-13  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-winsource.c (tui_erase_source_content)
1663         (tui_show_source_content, tui_source_window_base::refresh_all):
1664         Update.
1665         * tui/tui-wingeneral.h
1666         (tui_check_and_display_highlight_if_needed): Don't declare.
1667         * tui/tui-wingeneral.c
1668         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1669         check_and_display_highlight_if_needed.
1670         * tui/tui-win.c (tui_rehighlight_all)
1671         (tui_win_info::make_visible_with_new_height): Update.
1672         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1673         (tui_data_window::erase_data_content)
1674         (tui_data_window::display_all_data): Update.
1675         * tui/tui-data.h (struct tui_win_info)
1676         <check_and_display_highlight_if_needed>: Declare.
1677
1678 2019-08-13  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-win.c (tui_resize_all): Call
1681         tui_delete_invisible_windows.
1682         * tui/tui-layout.c (show_layout): Call
1683         tui_delete_invisible_windows.
1684         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1685         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1686
1687 2019-08-13  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1690         tui_add_win_to_layout.
1691
1692 2019-08-13  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1695         * tui/tui-layout.c (tui_default_win_height): Now static.
1696
1697 2019-08-13  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1700         single switch.
1701         (show_source_disasm_command, show_source_or_disasm_and_command):
1702         Don't check current layout.
1703
1704 2019-08-13  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-wingeneral.c (make_all_visible): Remove.
1707         (tui_make_all_invisible): Simplify.
1708         * tui/tui-layout.c (tui_make_all_invisible): Move from
1709         tui-wingeneral.c; simplify.
1710         (show_layout): Hoist call to tui_make_all_invisible.
1711         (show_data): Don't call tui_make_all_invisible.
1712
1713 2019-08-13  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1716         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1717
1718 2019-08-13  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1721         tui-data.c.
1722         (show_source_disasm_command, show_data)
1723         (show_source_or_disasm_and_command): Don't use
1724         tui_set_current_layout_to.
1725         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1726         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1727         tui-layout.c.
1728         (tui_set_current_layout_to): Remove.
1729
1730 2019-08-13  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-layout.c (tui_set_layout): Update.
1733         * tui/tui-data.h (struct tui_layout_def): Remove.
1734         (tui_layout_def): Don't declare.
1735         * tui/tui-data.c (layout_def): Remove.
1736         (tui_layout_def): Remove.
1737
1738 2019-08-13  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-winsource.h (struct tui_source_window_base)
1741         <clear_detail>: No longer "override".
1742         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1743         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1744         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1745         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1746         Remove.
1747         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1748
1749 2019-08-13  Tom Tromey  <tromey@adacore.com>
1750
1751         * tracepoint.c: Don't include readline.h or history.h.
1752
1753 2019-08-12  Tom Tromey  <tom@tromey.com>
1754
1755         * configure: Rebuild.
1756         * configure.ac: Check for readline 7.
1757         * NEWS: Mention readline 7 requirement.
1758         * README: Update.
1759
1760 2019-08-12  Tom Tromey  <tom@tromey.com>
1761
1762         * mingw-hdep.c (gdb_select): Remove readline hack.
1763
1764 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1765
1766         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1767         when the function fails.
1768
1769 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1770
1771         * s390-tdep.c (s390_type_align): New function.
1772         (s390_gdbarch_init): Set it as type_align gdbarch method.
1773
1774 2019-08-09  Tom de Vries  <tdevries@suse.de>
1775
1776         PR gdb/24591
1777         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1778         pc_low with relocation offset.
1779
1780 2019-08-07  Tom Tromey  <tromey@adacore.com>
1781
1782         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1783         (print_frame_args): Update.
1784         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1785         Update.
1786         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1787         * frame.h (struct frame_arg): Add initializers.
1788         <error>: Now a unique_xmalloc_ptr.
1789
1790 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1791
1792         * NEWS: Expand the Pointer Authentication entry.
1793         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1794         (aarch64_frame_unmask_lr): ... to this.
1795         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1796         Call aarch64_frame_unmask_lr.
1797         * frame.c (struct frame_info): Add "masked" variable.
1798         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1799         (fprint_frame): Check for masked pc.
1800         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1801         declarations.
1802         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1803         * stack.c (print_frame): Check for masked pc.
1804
1805 2019-08-06  Tom Tromey  <tom@tromey.com>
1806
1807         * stabsread.c (patch_block_stabs, read_one_struct_field)
1808         (read_enum_type): Use obstack_strndup.
1809         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1810         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1811         * dwarf2read.c (guess_full_die_structure_name)
1812         (anonymous_struct_prefix): Use obstack_strndup.
1813         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1814         * c-exp.y (yylex): Use obstack_strndup.
1815         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1816         (write_var_or_type): Use obstack_strndup.
1817
1818 2019-08-06  Tom Tromey  <tom@tromey.com>
1819
1820         * symfile.c (reread_symbols): Use obstack_strdup.
1821         * stabsread.c (read_type): Use obstack_strdup.
1822         * gdb_obstack.h (obstack_strdup): New overload.
1823         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1824         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1825         (dwarf2_canonicalize_name): Use obstack_strdup.
1826         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1827         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1828         Use obstack_strdup.
1829
1830 2019-08-06  Tom Tromey  <tom@tromey.com>
1831
1832         * gdb_obstack.h (obstack_strdup): Define.
1833         * gdb_obstack.c (obstack_strdup): Don't define.
1834
1835 2019-08-06  Tom Tromey  <tom@tromey.com>
1836
1837         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1838         obstack_strdup.
1839         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1840         obstack_strdup.
1841         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1842         * stabsread.c (common_block_start): Use obstack_strdup.
1843         * objfiles.c (set_objfile_main_name, objfile): Use
1844         obstack_strdup.
1845         * namespace.c (add_using_directive): Use obstack_strdup.
1846         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1847         * jit.c (finalize_symtab): Use obstack_strdup.
1848         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1849         (guess_partial_die_structure_name, partial_die_info::fixup)
1850         (dwarf2_name): Use obstack_strdup.
1851         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1852         obstack_strdup.
1853         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1854         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1855         obstack_strdup.
1856         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1857
1858 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1859
1860         * unittests/help-doc-selftests.c: New file.
1861         * Makefile.in: Add the new file.
1862
1863 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1864
1865         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1866         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1867         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1868         the trailing '.' is not output, and the first character is uppercased.
1869         (print_help_for_command): Update call to print_doc_line.
1870         (print_doc_of_command): Likewise.
1871         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1872         * cli/cli-option.c (append_indented_doc): Do not append newline.
1873         (build_help_option): Append newline after first appended_indented_doc
1874         only if a second call is done.
1875         (build_help): Append 2 new lines before each option, except the first
1876         one.
1877         * compile/compile.c (_initialize_compile): Add new lines after
1878         %OPTIONS%, when not at the end of the help.
1879         Change help doc or code
1880         producing the help doc to respect the invariants.
1881         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1882         Also removed the new line after 'Options:', as all other commands
1883         do not put an empty line between 'Options:' and the first option.
1884         * printcmd.c (_initialize_printcmd): Likewise.
1885         * stack.c (_initialize_stack): Likewise.
1886         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1887         incorrectly telling COMMAND is optional.
1888         * ada-lang.c (_initialize_ada_language): Change help doc or code
1889         producing the help doc to respect the invariants.
1890         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1891         * breakpoint.c (_initialize_breakpoint): Likewise.
1892         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1893         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1894         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1895         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1896         _initialize_cli_style): Likewise.
1897         * corelow.c (core_target_info): Likewise.
1898         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1899         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1900         * filesystem.c (_initialize_filesystem): Likewise.
1901         * frame.c (_initialize_frame): Likewise.
1902         * gnu-nat.c (add_task_commands): Likewise.
1903         * infcall.c (_initialize_infcall): Likewise.
1904         * infcmd.c (_initialize_infcmd): Likewise.
1905         * interps.c (_initialize_interpreter): Likewise.
1906         * language.c (_initialize_language): Likewise.
1907         * linux-fork.c (_initialize_linux_fork): Likewise.
1908         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1909         * maint.c (_initialize_maint_cmds): Likewise.
1910         * memattr.c (_initialize_mem): Likewise.
1911         * printcmd.c (_initialize_printcmd): Likewise.
1912         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1913         _RegEx): Likewise.
1914         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1915         * record-btrace.c (_initialize_record_btrace): Likewise.
1916         * record-full.c (_initialize_record_full): Likewise.
1917         * record.c (_initialize_record): Likewise.
1918         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1919         * regcache.c (_initialize_regcache): Likewise.
1920         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1921         _initialize_remote): Likewise.
1922         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1923         * serial.c (_initialize_serial): Likewise.
1924         * skip.c (_initialize_step_skip): Likewise.
1925         * source.c (_initialize_source): Likewise.
1926         * stack.c (_initialize_stack): Likewise.
1927         * symfile.c (_initialize_symfile): Likewise.
1928         * symtab.c (_initialize_symtab): Likewise.
1929         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1930         * top.c (init_main): Likewise.
1931         * tracefile-tfile.c (tfile_target_info): Likewise.
1932         * tracepoint.c (_initialize_tracepoint): Likewise.
1933         * tui/tui-win.c (_initialize_tui_win): Likewise.
1934         * utils.c (add_internal_problem_command): Likewise.
1935         * valprint.c (value_print_option_defs): Likewise.
1936
1937 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1938
1939         PR build/24886
1940         * configure.ac: Drop enable-libmcheck support.
1941         * configure, config.in: Rebuild.
1942         * libmcheck.m4: Remove.
1943         * acinclude.m4: Don't include it.
1944         * Makefile.in: Don't distribute it.
1945         * top.c (print_gdb_configuration): Don't mention it.
1946
1947 2019-08-06  Tom Tromey  <tom@tromey.com>
1948
1949         * utils.c (set_output_style): Sometimes pass stream to
1950         emit_style_escape.
1951         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1952         * record-btrace.c (btrace_insn_history): Update.
1953         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1954         method.
1955         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1956         Update initializers.
1957         <m_uiout>: New field.
1958         <m_di>: Move lower.
1959         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1960         Remove "uiout" parameter.
1961         (dump_insns): Update.
1962         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1963         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1964
1965 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1966
1967         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1968         (error_in_psymtab_expansion): Likewise.
1969         (lookup_symbol_via_quick_fns): Likewise.
1970         (basic_lookup_transparent_type_quick): Likewise.
1971         (basic_lookup_transparent_type_1): Likewise.
1972
1973 2019-08-06  Tom Tromey  <tromey@adacore.com>
1974
1975         * source.c (last_source_error): Now bool.
1976         (print_source_lines_base): Make "noprint" bool.  Only open
1977         source file when last_source_visited changes.
1978
1979 2019-08-06  Tom Tromey  <tromey@adacore.com>
1980
1981         * annotate.c (annotate_source_line): Use g_source_cache.
1982         * source-cache.c (source_cache::get_plain_source_lines): Change
1983         parameters.  Populate m_offset_cache.
1984         (source_cache::ensure): New method.
1985         (source_cache::get_line_charpos): New method.
1986         (extract_lines): Move lower.  Change parameters.
1987         (source_cache::get_source_lines): Move lower.
1988         * source-cache.h (class source_cache): Update comment.
1989         <get_line_charpos>: New method.
1990         <get_source_lines>: Update comment.
1991         <clear>: Clear m_offset_cache.
1992         <get_plain_source_lines>: Change parameters.
1993         <ensure>: New method
1994         <m_offset_cache>: New member.
1995         * source.c (forget_cached_source_info_for_objfile): Update.
1996         (info_source_command): Use g_source_cache.
1997         (find_source_lines, open_source_file_with_line_charpos): Remove.
1998         (print_source_lines_base, search_command_helper): Use g_source_cache.
1999         * source.h (open_source_file_with_line_charpos): Don't declare.
2000         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2001         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2002         Use g_source_cache.
2003
2004 2019-08-06  Tom Tromey  <tromey@adacore.com>
2005
2006         * source-cache.c (source_cache::get_plain_source_lines):
2007         Remove "first_line" and "last_line" parameters.
2008         (source_cache::get_source_lines): Cache plain text.
2009         * source-cache.h (class source_cache)
2010         <get_plain_source_lines>: Update.
2011
2012 2019-08-06  Tom Tromey  <tromey@adacore.com>
2013
2014         * source-cache.c (extract_lines): No longer a method.
2015         Changed type of parameter.  Include final newline.
2016         (selftests::extract_lines_test): New function.
2017         (_initialize_source_cache): Likewise.
2018         * source-cache.h (class source_cache)
2019         <extract_lines>: Don't declare.
2020
2021 2019-08-06  Tom Tromey  <tromey@adacore.com>
2022
2023         * breakpoint.c (init_breakpoint_sal): Update.
2024         (breakpoint): Update.
2025         * breakpoint.h (struct breakpoint) <filter>: Now a
2026         unique_xmalloc_ptr.
2027
2028 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2029
2030         * NEWS: Mention dictionary access on blocks.
2031         * python/py-block.c (blpy_getitem): New function.
2032         (block_object_as_mapping): New struct.
2033         (block_object_type): Use new struct for tp_as_mapping field.
2034
2035 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2036
2037         * objfiles.h (objfile): Add a comment describing partial symbols.
2038
2039 2019-08-05  Tom Tromey  <tromey@adacore.com>
2040
2041         * compile/compile.c (_initialize_compile): Use _(), not N_().
2042         * thread.c (_initialize_thread): Use _(), not N_().
2043         * stack.c (_initialize_stack): Use _(), not N_().
2044         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2045
2046 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2047
2048         * dwarf2read.c (struct dw2_symtab_iterator):
2049         <want_specific_block>: Remove.
2050         <block_index>: Change type to gdb::optional.
2051         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2052         change type of BLOCK_INDEX parameter to gdb::optional.
2053         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2054         (dw2_lookup_symbol): Don't pass argument for
2055         WANT_SPECIFIC_BLOCK.
2056         (dw2_expand_symtabs_for_function): Don't pass argument for
2057         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2058         (class dw2_debug_names_iterator)
2059         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2060         parameter, change BLOCK_INDEX type to gdb::optional.
2061         <m_want_specific_block>: Remove.
2062         <m_block_index>: Change type to gdb::optional.
2063         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2064         gdb::optional.  Re-write in function of gdb::optional.
2065         (dw2_debug_names_lookup_symbol): Don't pass argument for
2066         WANT_SPECIFIC_BLOCK.
2067         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2068         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2069         BLOCK_INDEX.
2070
2071 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2072
2073         * NEWS: Mention changes to "info sources" command.
2074
2075 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2076
2077         * symtab.c (filename_partial_match_opts): New struct type.
2078         (struct output_source_filename_data): New members
2079         regexp, c_regexp, partial_match.
2080         (output_source_filename): Use new members to decide to print file.
2081         (info_sources_option_defs): New variable.
2082         (make_info_sources_options_def_group, print_info_sources_header,
2083         info_sources_command_completer):
2084         New functions.
2085         (info_sources_command): Read new optional arguments.
2086         (_initialize_symtab): Update info sources help.
2087
2088 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2089
2090         * ada-lang.c (exception_support_info_v0): Renamed from...
2091         (default_exception_support_info): ... this.  Create new
2092         definition for v1.
2093         (ada_has_this_exception_support): Look up catch_handlers_sym.
2094         (ada_exception_support_info_sniffer): Try v0 after default.
2095
2096 2019-08-01  Tom Tromey  <tromey@adacore.com>
2097
2098         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2099         gdbarch.h.
2100
2101 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2102
2103         * s12z-tdep.c: Fix include path for s12z-opc.h.
2104
2105 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2106
2107         * NEWS: Require GNU make 3.82.
2108
2109 2019-07-16  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2112         declare.
2113
2114 2019-07-30  Tom Tromey  <tromey@adacore.com>
2115
2116         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2117
2118 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2119
2120         * printcmd.c (print_address_symbolic): Print negative offsets.
2121         (build_address_symbolic): Force signed arithmetic when computing
2122         offset.
2123
2124 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2125
2126         PR/24474: Add a function to lookup static variables.
2127         * NEWS: Mention this new function.
2128         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2129         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2130         * python/python.c (python_GdbMethods): Add new function.
2131
2132 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2133
2134         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2135         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2136         (objfpy_lookup_static_symbol): New function.
2137         (objfile_object_methods): Add new functions.
2138
2139 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2140
2141         * NEWS: Mention 'set|show print frame-info'.  Mention new
2142         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2143         backtrace argument.  Mention that python frame filtering code
2144         is now consistent with what 'backtrace' command prints.
2145
2146 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2147
2148         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2149         comments.
2150         (print_frame_info_auto, print_frame_info_source_line,
2151         print_frame_info_location, print_frame_info_source_and_location,
2152         print_frame_info_location_and_address, print_frame_info_short_location):
2153         New declarations.
2154         (struct frame_print_options): New member print_frame_info.
2155         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2156         * stack.h (get_user_print_what_frame_info): New declaration.
2157         (frame_show_address): New declaration.
2158         * stack.c (print_frame_arguments_choices): New value 'presence'.
2159         (print_frame_info_auto, print_frame_info_source_line,
2160         print_frame_info_location, print_frame_info_source_and_location,
2161         print_frame_info_location_and_address, print_frame_info_short_location,
2162         print_frame_info_choices, print_frame_info_print_what): New definitions.
2163         (print_frame_args): Only print dots for args if print frame-arguments
2164         is 'presence'.
2165         (frame_print_option_defs): New element for "frame-info".
2166         (get_user_print_what_frame_info): New function.
2167         (frame_show_address): Make non static.  Move comment to stack.h.
2168         (print_frame_info_to_print_what): New function.
2169         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2170         to decide what to print.
2171         (backtrace_command_1): Handle the new print_frame_arguments_presence
2172         value.
2173         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2174         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2175         (py_print_frame): In non-mi mode, use LOCATION as default for
2176         print_what, similarly to frame information printed directly by
2177         backtrace command. Handle frame-info user option in non MI mode.
2178
2179 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2180
2181         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2182         Add case for debugging 32-bit target on 64-bit host.  Revise
2183         comment.
2184
2185 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2186
2187         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2188         instead of find_function_entry_range_from_pc.
2189
2190 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2191
2192         * stack.c (find_frame_funname): Remove code which preferred
2193         minsym over symtab sym in "certain pathological cases".
2194
2195         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2196         parameter.  Change type of "do_demangle" to bool.
2197         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2198         Pass suitable "prefer_sym_over_minsym" flag to
2199         build_address_symbolic().  Don't output "+" for negative offsets.
2200         * printcmd.c (print_address_symbolic): Update invocation of
2201         build_address_symbolic to include a "prefer_sym_over_minsym"
2202         flag.
2203         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2204         Restrict cases in which use of minimal symbol is preferred to that
2205         of a found symbol.  Update comments.
2206
2207         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2208         for entry pc when entry pc is out of range for that FDE.
2209
2210 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2211
2212         PR gdb/24839:
2213         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2214         type.
2215
2216 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2217
2218         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2219         this function's Python signature.
2220
2221
2222 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2223
2224         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2225         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2226         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2227         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2228         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2229
2230
2231 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2232
2233         * h8300-tdep.c (h8300_register_name_common): New.
2234         h8300_register_name): Use h8300_register_name_common.
2235         (h8300s_register_name): Likewise.
2236         (h8300sx_register_name): Likewise.
2237         (h8300h_register_nam): New.
2238         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2239
2240
2241 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2242
2243         * arm-tdep.c (arm_skip_cmse_entry): New function.
2244         (arm_is_sgstubs_section): New function.
2245         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2246
2247 2019-07-22  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2250         Don't self-assign.
2251
2252 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2255         type_print.
2256
2257 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2260         so that GDB doesn't match any msymbols when searching in the
2261         TYPES_DOMAIN.
2262         (print_symbol_info): Print using typedef_print or type_print based
2263         on the type of the symbol.  Add updated FIXME comment moved from...
2264         (_initialize_symtab): ... move and update FIXME comment to above.
2265
2266 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * NEWS: Mention adding -q option to "info types".
2269         * symtab.c (struct info_types_options): New struct.
2270         (info_types_options_defs): New variable.
2271         (make_info_types_options_def_group): New function.
2272         (info_types_command): Use gdb::option framework to parse options.
2273         (info_types_command_completer): New function.
2274         (_initialize_symtab): Extend the help text on "info types" and
2275         register command completer.
2276
2277 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2278
2279         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2280         (lookup_symbol_in_objfile): Change int to block_enum and add a
2281         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2282
2283 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2284
2285         * MAINTAINERS (Write After Approval): Add self.
2286
2287 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2288
2289         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2290         instruction to the dummy code region.
2291
2292 2019-07-19  Tom Tromey  <tromey@adacore.com>
2293
2294         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2295         (ARGSUSED, PARAMS, __func__): Remove rules.
2296
2297 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2298
2299         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2300         * features/arm/arm-with-iwmmxt.c: Remove.
2301         * features/arm/arm-with-iwmmxt.xml: Remove.
2302         * features/arm/arm-with-m-fpa-layout.c: Remove.
2303         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2304         * features/arm/arm-with-m-vfp-d16.c: Remove.
2305         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2306         * features/arm/arm-with-m.c: Remove.
2307         * features/arm/arm-with-m.xml: Remove.
2308         * features/arm/arm-with-neon.c: Remove.
2309         * features/arm/arm-with-neon.xml: Remove.
2310         * features/arm/arm-with-vfpv2.c: Remove.
2311         * features/arm/arm-with-vfpv2.xml: Remove.
2312         * features/arm/arm-with-vfpv3.c: Remove.
2313         * features/arm/arm-with-vfpv3.xml: Remove.
2314
2315 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2316
2317         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2318
2319 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2320
2321         * arch/aarch32.c (aarch32_create_target_description): Create
2322         target descriptions using features.
2323         * arch/arm.c (arm_create_target_description)
2324         (arm_create_mprofile_target_description): Likewise.
2325         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2326
2327 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2328
2329         * Makefile.in: Add new files.
2330         * aarch32-tdep.c: New file.
2331         * aarch32-tdep.h: New file.
2332         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2333         Call aarch32_read_description.
2334         * arch/aarch32.c: New file.
2335         * arch/aarch32.h: New file.
2336         * arch/arm.c (arm_create_target_description)
2337         (arm_create_mprofile_target_description): New function.
2338         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2339         (arm_create_target_description)
2340         (arm_create_mprofile_target_description): New declaration.
2341         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2342         read_description functions.
2343         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2344         Likewise.
2345         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2346         * arm-tdep.c (tdesc_arm_list): New variable.
2347         (arm_register_g_packet_guesses): Call create description functions.
2348         (arm_read_description) (arm_read_mprofile_description): New
2349         function.
2350         * arm-tdep.h (arm_read_description)
2351         (arm_read_mprofile_description): Add declaration.
2352         * configure.tgt: Add new files.
2353
2354 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2355
2356         * top.c (new_ui_command): Open specified terminal just once.
2357
2358 2019-07-18  Tom Tromey  <tromey@adacore.com>
2359
2360         * symtab.c (main_name): Constify return type.
2361         * symfile.c (set_initial_language): Update.
2362         * symtab.h (main_name): Constify return type.
2363
2364 2019-07-17  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-winsource.c (tui_update_source_window)
2367         (tui_update_source_window_as_is)
2368         (tui_update_source_windows_with_line): Remove return.
2369         * tui/tui-disasm.c (tui_show_disassem)
2370         (tui_show_disassem_and_update_source): Remove return.
2371         * tui/tui.c (tui_reset): Remove return.
2372         * tui/tui-wingeneral.c
2373         (tui_check_and_display_highlight_if_needed): Remove return.
2374
2375 2019-07-17  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2378
2379 2019-07-17  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-winsource.h (struct tui_exec_info_window)
2382         (struct tui_source_window_base): Move from tui-data.h.
2383         * tui/tui-winsource.c: Move many method definitions from
2384         elsewhere.  Remove "structuring" comments.
2385         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2386         (tui_source_window_base::refresh_window): Move to
2387         tui-winsource.c.
2388         * tui/tui-win.c (tui_source_window_base::refresh_all)
2389         (tui_source_window_base::update_tab_width)
2390         (tui_source_window_base::set_new_height)
2391         (tui_source_window_base::do_make_visible_with_new_height): Move to
2392         tui-winsource.c.
2393         * tui/tui-source.h: Update.
2394         * tui/tui-source.c (tui_source_window_base::reset): Move to
2395         tui-winsource.c.
2396         * tui/tui-disasm.h: Update.
2397         * tui/tui-data.h (struct tui_exec_info_window): Move to
2398         tui-winsource.h.
2399         (struct tui_source_window_base): Likewise.
2400         * tui/tui-data.c (tui_source_window_base::clear_detail)
2401         (tui_source_window_base, ~tui_source_window_base): Move to
2402         tui-winsource.c.
2403
2404 2019-07-17  Tom Tromey  <tom@tromey.com>
2405
2406         * tui/tui-win.c (tui_resize_all)
2407         (tui_source_window_base::update_tab_width)
2408         (tui_adjust_win_heights): Update.
2409         (tui_win_info::make_invisible_and_set_new_height): Rename from
2410         make_invisible_and_set_new_height.
2411         * tui/tui-data.h (struct tui_win_info)
2412         <make_invisible_and_set_new_height>: New method.
2413
2414 2019-07-17  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui.c: Update.
2417         * tui/tui-source.h (struct tui_source_window): Move from
2418         tui-data.h.
2419         * tui/tui-layout.c: Update.
2420         * tui/tui-disasm.c: Update.
2421         * tui/tui-data.h (struct tui_source_window): Move to
2422         tui-source.h.
2423
2424 2019-07-17  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2427         tui-data.h.
2428         * tui/tui-data.h (struct tui_disasm_window): Move to
2429         tui-disasm.h.
2430
2431 2019-07-17  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-regs.h (struct tui_data_item_window): Move from
2434         tui-data.h.
2435         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2436         * tui/tui-data.h (struct tui_data_item_window): Move to
2437         tui-regs.h.
2438         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2439
2440 2019-07-17  Tom Tromey  <tom@tromey.com>
2441
2442         * tui/tui.c: Update.
2443         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2444         (tui_cmd_window::max_height): Move to tui-command.c.
2445         * tui/tui-layout.c: Update.
2446         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2447         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2448         tui-command.c.
2449         * tui/tui-command.h (struct tui_cmd_window): Move from
2450         tui-data.h.
2451         * tui/tui-command.c: Remove "structuring" comments.
2452         (tui_cmd_window::clear_detail)
2453         (tui_cmd_window::do_make_visible_with_new_height)
2454         (tui_cmd_window::max_height): Move from elsewhere.
2455
2456 2019-07-17  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2459         Now static.
2460         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2461         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2462
2463 2019-07-17  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui.c: Update.
2466         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2467         tui-regs.c.
2468         * tui/tui-windata.h: Remove file.
2469         * tui/tui-windata.c: Remove file.
2470         * tui/tui-win.c (tui_data_window::set_new_height)
2471         (tui_data_window::do_make_visible_with_new_height): Move to
2472         tui-regs.c.
2473         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2474         * tui/tui-regs.c: Remove "structuring" comments.
2475         (tui_data_window::first_data_item_displayed)
2476         (tui_data_window::delete_data_content_windows)
2477         (tui_data_window::erase_data_content)
2478         (tui_data_window::display_all_data)
2479         (tui_data_window::refresh_all)
2480         (tui_data_window::do_scroll_vertical)
2481         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2482         (tui_data_window::do_make_visible_with_new_height)
2483         (tui_data_window::refresh_window): Move from elsewhere.
2484         (_initialize_tui_regs): Move to end of file.
2485         * tui/tui-layout.c: Update.
2486         * tui/tui-hooks.c: Update.
2487         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2488         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2489         tui-regs.c.
2490         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2491
2492 2019-07-17  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2495         seen.
2496
2497 2019-07-17  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-win.c (tui_source_window_base::set_new_height)
2500         (tui_source_window_base::do_make_visible_with_new_height): Use
2501         m_has_locator field directly.
2502         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2503         method.
2504         (struct tui_source_window_base) <has_locator>: Likewise.
2505
2506 2019-07-17  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2509         Don't declare.
2510         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2511         Remove.
2512         * tui/tui-win.c (tui_source_window_base::set_new_height)
2513         (tui_source_window_base::set_new_height)
2514         (make_invisible_and_set_new_height)
2515         (tui_source_window_base::do_make_visible_with_new_height)
2516         (tui_source_window_base::do_make_visible_with_new_height):
2517         Update.
2518         * tui/tui-layout.c (show_source_disasm_command, show_data)
2519         (show_source_or_disasm_and_command): Update.
2520         * tui/tui-layout.c (show_layout): Update.
2521
2522 2019-07-17  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-layout.c (make_data_window): Remove.
2525         (show_data): Unify creation and re-initialization cases.
2526
2527 2019-07-17  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-layout.c (make_source_window, make_disasm_window):
2530         Remove.
2531         (show_data): Unify creation and re-initialization cases.
2532
2533 2019-07-17  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-layout.c (make_command_window): Remove.
2536         (show_source_disasm_command, show_source_or_disasm_and_command):
2537         Unify creation and re-initialization cases.
2538
2539 2019-07-17  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2542         creation and re-initialization cases.
2543
2544 2019-07-17  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-regs.c (tui_get_register): Return void.
2547
2548 2019-07-17  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2551         Simplify.
2552
2553 2019-07-17  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2556         resetting.
2557
2558 2019-07-17  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2561         * tui/tui-regs.c (tui_reg_layout): New function.
2562         (tui_show_registers, tui_reg_command): Use it.
2563         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2564         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2565         parameters.
2566         (tui_layout_command): Remove.
2567
2568 2019-07-17  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-layout.h (tui/tui-layout): Return void.
2571         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2572
2573 2019-07-17  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-layout.c (show_source_disasm_command, show_data):
2576         Update.
2577         (reset_locator): Remove.
2578         (show_source_or_disasm_and_command): Update.
2579
2580 2019-07-17  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-source.c (tui_source_window_base::reset): Remove
2583         win_type parameter.
2584         * tui/tui-layout.c (make_command_window, make_source_window)
2585         (make_disasm_window, make_data_window)
2586         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2587         (reset_locator, show_source_or_disasm_and_command): Update.
2588         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2589         win_type parameter.
2590         (struct tui_source_window_base) <reset>: Likewise.
2591
2592 2019-07-17  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-layout.c (show_source_disasm_command): Use
2595         reset_locator.
2596         (reset_locator): New function.
2597         (init_and_make_win): Remove.
2598         (show_source_or_disasm_and_command): Use reset_locator.
2599
2600 2019-07-17  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2603         condition.
2604         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2605         Remove condition.
2606         * tui/tui-source.c (tui_source_window_base::reset): New method.
2607         * tui/tui-layout.c (make_command_window): Don't call
2608         init_and_make_win.
2609         (make_source_window, make_disasm_window): Don't call
2610         make_source_or_disasm_window.
2611         (make_data_window): Don't call init_and_make_win.  Change calling
2612         convention.
2613         (show_source_disasm_command, show_data): Simplify.
2614         (make_source_or_disasm_window): Remove.
2615         (show_source_or_disasm_and_command): Simplify.
2616         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2617         (struct tui_source_window_base) <reset>: Likewise.
2618         <execution_info>: Remove initializer.
2619         * tui/tui-data.c (tui_source_window_base): Initialize
2620         execution_info.
2621
2622 2019-07-17  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2625         variable.
2626
2627 2019-07-17  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui.c (tui_rl_other_window): Update.
2630         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2631         superclass method first.  Always iterate over regs_content.
2632         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2633         method.
2634         * tui/tui-win.c (tui_set_focus_command): Update.
2635
2636 2019-07-17  Tom Tromey  <tom@tromey.com>
2637
2638         * tui/tui-win.c (tui_set_focus_command): Rename from
2639         tui_set_focus.  Call tui_enable.
2640         (tui_set_focus_command): Remove.
2641
2642 2019-07-17  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2645         refresh_window.
2646         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2647         touchwin.
2648         (tui_data_window::refresh_window): Call refresh_window on data
2649         items.  Always call superclass refresh_window.
2650         (tui_win_info::refresh): Remove.
2651         (tui_source_window_base::refresh_window): Update.
2652         (tui_refresh_all): Update.
2653         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2654         refresh_window.
2655         (show_source_or_disasm_and_command): Likewise.
2656         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2657         (struct tui_source_window_base) <refresh>: Likewise.
2658
2659 2019-07-17  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-winsource.c (tui_clear_source_content)
2662         (tui_show_source_content): Update.
2663         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2664         whether content is empty.
2665         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2666         Remove.
2667
2668 2019-07-17  Tom Tromey  <tom@tromey.com>
2669
2670         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2671         window's contents.
2672         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2673         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2674
2675 2019-07-17  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2678         (struct tui_data_item_window): Update.
2679
2680 2019-07-17  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2683         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2684         defines.
2685
2686 2019-07-17  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-winsource.h (tui_erase_source_content)
2689         (tui_clear_source_content): Remove "display_prompt" parameter.
2690         * tui/tui-winsource.c (tui_update_source_window_as_is)
2691         (tui_update_source_windows_with_addr): Update.
2692         (tui_clear_source_content): Remove "display_prompt" parameter.
2693         (tui_erase_source_content): Likewise.  Simplify.
2694         (tui_show_source_content): Update.
2695         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2696         * tui/tui-stack.c (tui_show_frame_info): Update.
2697         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2698         Remove defines.
2699
2700 2019-07-17  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2703         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2704         parameter.
2705         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2706         parameter.
2707
2708 2019-07-17  Tom Tromey  <tom@tromey.com>
2709
2710         * tui/tui-winsource.c (tui_clear_source_content)
2711         (tui_show_source_content, tui_show_exec_info_content)
2712         (tui_clear_exec_info_content): Update.
2713         * tui/tui-stack.c (tui_show_locator_content): Update.
2714         (tui_show_frame_info): Update.
2715         * tui/tui-source.h (tui_source_window): Don't declare.
2716         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2717         from tui_source_is_displayed.
2718         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2719         Remove field.
2720         (struct tui_source_window_base) <content_in_use>: New field.  Now
2721         bool.
2722         (struct tui_source_window) <showing_source_p>: New method.
2723         (TUI_SRC_WIN): Change cast.
2724         * tui/tui-data.c (tui_initialize_static_data): Update.
2725
2726 2019-07-17  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2729         location_matches_p.
2730         * tui/tui-source.c (tui_source_window::location_matches_p): New
2731         method.
2732         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2733         method.
2734         * tui/tui-data.h (struct tui_source_window_base)
2735         <location_matches_p>: New method.
2736         (struct tui_source_window, struct tui_disasm_window)
2737         <location_matches_p>: Likewise.
2738
2739 2019-07-17  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-win.c (tui_set_win_height_command): Rename from
2742         tui_set_win_height.
2743         (tui_set_win_height_command): Remove.
2744
2745 2019-07-17  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-source.c (tui_source_window): New constructor.  Add
2748         observer.
2749         (~tui_source_window): New destructor.
2750         (tui_source_window::style_changed): New method.
2751         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2752         (tui_attach_detach_observers): Update.
2753         * tui/tui-data.h (struct tui_source_window): Make constructor not
2754         inline.  Add destructor.
2755         (struct tui_source_window) <style_changed>: New method.
2756         <m_observable>: New member.
2757
2758 2019-07-17  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2761         * tui/tui-win.c (tui_resize_all): Fix typo.
2762
2763 2019-07-17  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2766         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2767         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2768         * tui/tui-win.c (window_name_completer): Use foreach.
2769         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2770         (update_tab_width): Likewise.
2771         * tui/tui-layout.c (show_layout): Update.
2772         * tui/tui-data.h (class tui_window_iterator): New.
2773         (struct all_tui_windows): New.
2774         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2775
2776 2019-07-17  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2779         parameter.  Don't reference globals.
2780         (tui_reg_command): Update.
2781
2782 2019-07-17  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-regs.c (tui_show_registers): Simplify.
2785
2786 2019-07-17  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-regs.c (tui_show_registers): Update.
2789         (tui_show_register_group): Add win_info parameter.
2790
2791 2019-07-17  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2794         Rename from tui_display_reg_element_at_line.
2795         (tui_data_window::display_registers_from_line): Update.
2796         * tui/tui-data.h (struct tui_data_window)
2797         <display_reg_element_at_line>: New method.
2798
2799 2019-07-17  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-regs.h (tui_display_registers_from)
2802         (tui_display_registers_from_line): Don't declare.
2803         * tui/tui-windata.c (tui_data_window::display_all_data)
2804         (tui_data_window::refresh_all)
2805         (tui_data_window::do_scroll_vertical): Update.
2806         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2807         from tui_display_registers_from.
2808         (tui_display_reg_element_at_line): Update.
2809         (tui_data_window::display_registers_from_line): Rename from
2810         tui_display_registers_from_line.
2811         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2812         display_registers_from_line>: New methods.
2813
2814 2019-07-17  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2817         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2818         from tui_erase_data_content.
2819         (tui_data_window::display_all_data)
2820         (tui_data_window::refresh_all)
2821         (tui_data_window::do_scroll_vertical): Update.
2822         * tui/tui-regs.c (tui_show_registers): Update.
2823         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2824         New method.
2825
2826 2019-07-17  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2829         declare.
2830         * tui/tui-windata.c
2831         (tui_data_window::delete_data_content_windows): Rename from
2832         tui_delete_data_content_windows.
2833         (tui_data_window::display_all_data)
2834         (tui_data_window::do_scroll_vertical): Update.
2835         * tui/tui-data.h (struct tui_data_window)
2836         <delete_data_content_windows>: New method.
2837
2838 2019-07-17  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2841         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2842
2843 2019-07-17  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2846         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2847         from tui_display_all_data.
2848         * tui/tui-win.c
2849         (tui_data_window::do_make_visible_with_new_height): Update.
2850         * tui/tui-regs.c (tui_show_registers): Update.
2851         * tui/tui-layout.c (tui_set_layout): Update.
2852         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2853         method.
2854
2855 2019-07-17  Tom Tromey  <tom@tromey.com>
2856
2857         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2858         * tui/tui-windata.c (tui_display_data_from): Remove.
2859         (tui_data_window::refresh_all): Update.
2860
2861 2019-07-17  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2864         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2865         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2866         tui_display_registers_from_line.
2867         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2868         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2869         "force_display" parameter.
2870
2871 2019-07-17  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2874         declare.
2875         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2876         Rename from tui_first_reg_element_no_inline.
2877         (tui_display_reg_element_at_line)
2878         (tui_display_registers_from_line): Update.
2879         * tui/tui-data.h (struct tui_data_window)
2880         <first_reg_element_no_inline>: New method.
2881
2882 2019-07-17  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-windata.c (tui_display_data_from)
2885         (tui_data_window::do_scroll_vertical): Update.
2886         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2887         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2888         Rename from tui_line_from_reg_element_no.
2889         (tui_display_registers_from_line): Update.
2890         * tui/tui-data.h (struct tui_data_window)
2891         <line_from_reg_element_no>: New method.
2892
2893 2019-07-17  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2896         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2897         tui_last_regs_line_no.
2898         (tui_display_reg_element_at_line)
2899         (tui_display_registers_from_line): Update.
2900         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2901         method.
2902
2903 2019-07-17  Tom Tromey  <tom@tromey.com>
2904
2905         PR tui/24722:
2906         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2907         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2908         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2909         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2910         (tui_update_breakpoint_info): Likewise.
2911         * tui/tui-hooks.c (tui_event_create_breakpoint)
2912         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2913         Update.
2914
2915 2019-07-17  Tom Tromey  <tom@tromey.com>
2916
2917         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2918
2919 2019-07-17  Tom Tromey  <tom@tromey.com>
2920
2921         * tui/tui-winsource.c (tui_update_source_window_as_is)
2922         (tui_update_source_windows_with_addr): Update.
2923         * tui/tui-source.h (tui_set_source_content)
2924         (tui_show_symtab_source): Add "win_info" parameter.
2925         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2926         parameter.
2927         (tui_show_symtab_source): Likewise.
2928
2929 2019-07-17  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-wingeneral.c
2932         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2933
2934 2019-07-17  Tom Tromey  <tom@tromey.com>
2935
2936         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2937         (struct tui_cmd_window) <can_scroll>: New method.
2938         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2939         method.
2940
2941 2019-07-17  Tom Tromey  <tromey@adacore.com>
2942
2943         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2944         do_field_signed>: Rename.  Change type of "value".
2945         * ui-out.c (ui_out::field_signed): Rename from field_int.
2946         Change type of "value".
2947         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2948         type of "value".
2949         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2950         do_field_int.  Change type of "value".
2951         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2952         do_field_int.  Change type of "value".
2953         * tracepoint.c (trace_status_mi, tfind_1)
2954         (print_one_static_tracepoint_marker): Update.
2955         * thread.c (print_thread_info_1, print_selected_thread_frame):
2956         Update.
2957         * stack.c (print_frame, print_frame_info): Update.
2958         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2959         Update.
2960         * source.c (print_source_lines_base): Update.
2961         * skip.c (info_skip_command): Update.
2962         * record-btrace.c (btrace_ui_out_decode_error)
2963         (btrace_call_history_src_line): Update.
2964         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2965         Update.
2966         * progspace.c (print_program_space): Update.
2967         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2968         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2969         do_field_int.  Change type of "value".
2970         * mi/mi-out.c (mi_ui_out::do_table_begin)
2971         (mi_ui_out::do_table_header): Update.
2972         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2973         type of "value".
2974         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2975         (mi_cmd_data_list_changed_registers, output_register)
2976         (mi_cmd_data_read_memory, mi_load_progress)
2977         (mi_cmd_trace_frame_collected): Update.
2978         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2979         Update.
2980         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2981         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2982         (mi_cmd_var_list_children, varobj_update_one): Update.
2983         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2984         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2985         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2986         * inferior.c (print_inferior): Update.
2987         * gdb_bfd.c (print_one_bfd): Update.
2988         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2989         Update.
2990         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2991         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2992         do_field_int.  Change type of "value".
2993         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2994         do_field_int.  Change type of "value".
2995         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2996         (print_one_breakpoint_location, print_it_catch_fork)
2997         (print_one_catch_fork, print_it_catch_vfork)
2998         (print_one_catch_vfork, print_it_catch_solib)
2999         (print_it_catch_exec, print_it_ranged_breakpoint)
3000         (print_mention_watchpoint, print_mention_masked_watchpoint)
3001         (bkpt_print_it, update_static_tracepoint): Update.
3002         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3003         * break-catch-syscall.c (print_it_catch_syscall): Update.
3004         * ada-tasks.c (print_ada_task_info): Update.
3005         * ada-lang.c (print_it_exception, print_mention_exception):
3006         Update.
3007
3008 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         PR breakpoints/24541
3011         * gdbarch.c: Regenerate.
3012         * gdbarch.h: Regenerate.
3013         * gdbarch.sh: Adjust return type and parameter types for
3014         'stap_adjust_register'.
3015         (i386_stap_adjust_register): Adjust signature and return new
3016         register name.
3017         * stap-probe.c (stap_parse_register_operand): Adjust use of
3018         'gdbarch_stap_adjust_register'.
3019
3020 2019-07-17  Tom Tromey  <tromey@adacore.com>
3021
3022         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3023         declare VEC.
3024         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3025         std::vector.
3026         (struct s390_process_info): Add initializers.
3027         (s390_add_process): Use new.
3028         (s390_linux_nat_target::low_forget_process): Use delete.
3029         (s390_linux_nat_target::low_new_fork)
3030         (s390_linux_nat_target::stopped_by_watchpoint)
3031         (s390_linux_nat_target::low_prepare_to_resume)
3032         (s390_linux_nat_target::insert_watchpoint)
3033         (s390_linux_nat_target::insert_hw_breakpoint)
3034         (s390_linux_nat_target::remove_watchpoint)
3035         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3036
3037 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3038
3039         * aarch64-fbsd-nat.c: Include regcache.h.
3040         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3041         argument.
3042         (aarch64_fbsd_nat_target::fetch_registers)
3043         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3044         variable.
3045         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3046
3047 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3048
3049         * fbsd-nat.c: Include gdbarch.h.
3050
3051 2019-07-15  Tom Tromey  <tromey@adacore.com>
3052
3053         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3054
3055 2019-07-15  Tom Tromey  <tromey@adacore.com>
3056
3057         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3058         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3059         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3060         * cli-out.c (cli_ui_out::do_field_int): New method.
3061         * ui-out.c (ui_out::field_unsigned): New method.
3062         * symfile.c (generic_load): Use field_unsigned.
3063         (print_transfer_performance): Likewise.
3064         * record-btrace.c (ui_out_field_uint): Remove.
3065         (btrace_call_history_insn_range, btrace_call_history): Use
3066         field_unsigned.
3067         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3068         field_unsigned.
3069         * ui-out.h (class ui_out) <field_unsigned>: New method.
3070         <do_field_unsigned>: Likewise.
3071
3072 2019-07-15  Tom Tromey  <tromey@adacore.com>
3073
3074         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3075         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3076         * target.c (flash_erase_command): Use field_string.
3077         * infrun.c (print_signal_received_reason): Use field_string.
3078         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3079         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3080         field_string.
3081         * ada-tasks.c (print_ada_task_info): Use field_string.
3082
3083 2019-07-15  Tom Tromey  <tromey@adacore.com>
3084
3085         * target.c (flash_erase_command): Use field_core_addr.
3086         * symfile.c (generic_load): Use field_core_addr.
3087         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3088         Use field_core_addr.
3089         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3090         field_core_addr.
3091
3092 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3095         value if its desired type is smaller than a CORE_ADDR and signed.
3096
3097 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3100         of changes to field names, and use new is_reference field to
3101         decide if a property is a reference or not.
3102         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3103         field.
3104         (struct dwarf2_property_baton): Update header comment, rename
3105         'referenced_type' to 'property_type' and update comments.
3106         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3107         default property type, store in property baton, update to take
3108         accound of renamed field.
3109         (read_func_scope): Update call to attr_to_dynamic_prop.
3110         (read_array_type): Likewise.
3111         (dwarf2_per_cu_addr_sized_int_type): New function.
3112         (read_subrange_index_type): Move type finding code to
3113         dwarf2_per_cu_addr_sized_int_type.
3114         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3115         (dwarf2_per_cu_addr_type): New function.
3116         (set_die_type): Update calls to attr_to_dynamic_prop.
3117
3118 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3119
3120         * dwarf2read.c (read_subrange_index_type): New function.
3121         (read_subrange_type): Move code into new function and call it.
3122         * gdbtypes.c (create_range_type): Add some asserts.
3123
3124 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3127         update return statements.
3128         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3129         declaration, and update comment to match.
3130         * gdbtypes.c (resolve_dynamic_array): Update call to
3131         dwarf2_evaluate_property to match new return type.
3132
3133 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * valarith.c (value_subscripted_rvalue): Change lowerbound
3136         parameter type from int to LONGEST.
3137         * value.h (value_subscripted_rvalue): Likewise in declaration.
3138
3139 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3140
3141         * cli/cli-utils.c (info_print_command_completer): New function.
3142         * cli/cli-utils.h: Add 'completer.h' include, and forward
3143         declaration for 'struct cmd_list_element'.
3144         (info_print_command_completer): Declare.
3145         * stack.c (_initialize_stack): Add completer for 'info locals' and
3146         'info args'.
3147         * symtab.c (_initialize_symtab): Add completer for 'info
3148         variables' and 'info functions'.
3149         * NEWS: Mention completion for additional info commands.
3150
3151 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3152
3153         * cli/cli-utils.c (extract_info_print_args): Delete.
3154         (extract_arg_maybe_quoted): Delete.
3155         (info_print_options_defs): New variable.
3156         (make_info_print_options_def_group): New function.
3157         (extract_info_print_options): Define new function.
3158         * cli/cli-utils.h (extract_info_print_args): Delete.
3159         (struct info_print_options): New structure.
3160         (extract_info_print_options): Declare new function.
3161         * stack.c (info_locals_command): Update to use new
3162         extract_info_print_options, also add a header comment.
3163         (info_args_command): Likewise.
3164         * symtab.c (info_variables_command): Likewise.
3165         (info_functions_command): Likewise.
3166
3167 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3170         to extract string arguments.
3171         * common/common-utils.c (extract_string_maybe_quoted): New function.
3172         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3173
3174 2019-07-11  Tom Tromey  <tromey@adacore.com>
3175
3176         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3177         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3178         * top.h (gdbinit): Don't declare.
3179         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3180         into...
3181         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3182         * top.c (gdb_init): Don't call init_cli_cmds.
3183         (gdbinit): Remove.
3184         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3185
3186 2019-07-11  Tom Tromey  <tromey@adacore.com>
3187
3188         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3189         after it has been moved.
3190
3191 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3192
3193         * valops.c (value_must_coerce_to_target): Change return type to
3194         bool.
3195         * value.h (value_must_coerce_to_target): Likewise.
3196
3197 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3198
3199         * breakpoint.c (is_hardware_watchpoint): Remove
3200         forward-declaration.
3201         (is_masked_watchpoint): Change return type to bool.
3202         (is_tracepoint): Likewise.
3203         (is_breakpoint): Likewise.
3204         (is_hardware_watchpoint): Likewise.
3205         (is_watchpoint): Likewise.
3206         (is_no_memory_software_watchpoint): Likewise.
3207         (is_catchpoint): Likewise.
3208         (breakpoint_1): Make FILTER parameter's return type bool.
3209         is_masked_watchpoint): Change return type to bool.
3210         (save_breakpoints): Make FILTER parameter's return type bool.
3211         * breakpoint.h (is_breakpoint): Change return type to bool.
3212         (is_watchpoint): Likewise.
3213         (is_catchpoint): Likewise.
3214         (is_tracepoint): Likewise.
3215
3216 2019-07-10  Tom Tromey  <tom@tromey.com>
3217
3218         * defs.h: Don't include gdbarch.h.
3219         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3220         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3221         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3222         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3223         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3224         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3225         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3226         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3227         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3228         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3229         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3230         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3231         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3232         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3233         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3234         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3235         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3236         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3237         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3238         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3239         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3240         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3241         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3242         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3243         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3244         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3245         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3246
3247 2019-07-10  Tom Tromey  <tromey@adacore.com>
3248
3249         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3250         * breakpoint.c (init_ada_exception_breakpoint): Register as
3251         bp_catchpoint.
3252         (print_one_breakpoint_location, print_one_breakpoint): Use
3253         is_ada_exception_catchpoint.
3254         * ada-lang.c (class ada_catchpoint_location): Pass
3255         bp_loc_software_breakpoint to bp_location constructor.
3256         (is_ada_exception_catchpoint): New function.
3257
3258 2019-07-10  Tom Tromey  <tromey@adacore.com>
3259
3260         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3261         VEC.
3262         (struct arm_exidx_entry): New method operator<.
3263         (struct arm_exidx_data) <section_maps>: Change type.
3264         (arm_exidx_data_free): Remove.
3265         (arm_exidx_data_key): Change type.  Move lower.
3266         (arm_exidx_new_objfile): Update.
3267         (arm_compare_exidx_entries): Remove.
3268         (arm_find_exidx_entry, _initialize_arm_tdep)
3269
3270 2019-07-10  Tom Tromey  <tromey@adacore.com>
3271
3272         * solib-spu.c (ocl_program_data_key): Change type.
3273         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3274         Update.
3275
3276 2019-07-10  Tom Tromey  <tromey@adacore.com>
3277
3278         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3279         (struct solib_aix_inferior_data) <library_list>: Change type.
3280         (solib_aix_inferior_data_handle): Change type.
3281         (get_solib_aix_inferior_data): Update.
3282         (solib_aix_free_library_list): Remove.
3283         (library_list_start_library): Update.
3284         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3285         return type.
3286         (solib_aix_get_library_list)
3287         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3288         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3289
3290 2019-07-10  Tom Tromey  <tromey@adacore.com>
3291
3292         * solib-dsbt.c (struct dsbt_info): Add initializers.
3293         (solib_dsbt_pspace_data): Change type.
3294         (dsbt_pspace_data_cleanup): Remove.
3295         (get_dsbt_info, _initialize_dsbt_solib): Update.
3296
3297 2019-07-10  Tom Tromey  <tromey@adacore.com>
3298
3299         * spu-tdep.c (spu_overlay_data): Change type.
3300         (spu_get_overlay_table, spu_overlay_new_objfile)
3301         (_initialize_spu_tdep): Update.
3302
3303 2019-07-10  Tom Tromey  <tromey@adacore.com>
3304
3305         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3306         destructor.
3307         (dbx_objfile_data_key): Change type and declare later.
3308         (DBX_SYMFILE_INFO): Rewrite.
3309         * dbxread.c (dbx_objfile_data_key): Change type.
3310         (dbx_symfile_init): Update.
3311         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3312         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3313         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3314
3315 2019-07-10  Tom Tromey  <tromey@adacore.com>
3316
3317         * jit.c (jit_program_space_key): Change type.  Move lower.
3318         (get_jit_program_space_data): Update.
3319         (jit_program_space_data_cleanup): Remove.
3320         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3321         Update.
3322         (struct jit_program_space_data): Add initializers.
3323
3324 2019-07-10  Tom Tromey  <tromey@adacore.com>
3325
3326         * solib-darwin.c (struct darwin_info): Add initializers.
3327         (solib_darwin_pspace_data): Change type.
3328         (darwin_pspace_data_cleanup): Remove.
3329         (get_darwin_info, _initialize_darwin_solib): Update.
3330
3331 2019-07-10  Tom Tromey  <tromey@adacore.com>
3332
3333         * remote-sim.c (struct sim_inferior_data): Add initializers,
3334         constructor, and destructor.
3335         (sim_inferior_data_key): Change type.  Move lower.
3336         (check_for_duplicate_sim_descriptor): Update.
3337         (get_sim_inferior_data): Use new.  Update.
3338         (~sim_inferior_data_cleanup): Rename from
3339         sim_inferior_data_cleanup.  Simplify.
3340         (gdbsim_close_inferior, simulator_command)
3341         (sim_command_completer, _initialize_remote_sim): Update.
3342         (next_pid, INITIAL_PID): Move earlier.
3343
3344 2019-07-10  Tom Tromey  <tromey@adacore.com>
3345
3346         * python/python-internal.h (create_thread_object): Return
3347         gdbpy_ref.
3348         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3349         * python/py-inferior.c (struct threadlist_entry): Add
3350         constructor.
3351         <thread_obj>: Now a gdbpy_ref.
3352         (thread_to_thread_object): Update.
3353         (add_thread_object): Use new.
3354         (delete_thread_object): Use delete.
3355         (infpy_threads): Update.
3356         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3357         GIL.
3358
3359 2019-07-10  Tom Tromey  <tromey@adacore.com>
3360
3361         * valops.c (value_cast): Specialize error message for Ada.
3362
3363 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3364
3365         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3366
3367 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3368
3369         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3370         bpstat_should_step): Return bool, adjust comments.
3371         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3372         bpstat_should_step): Likewise.
3373
3374 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3375
3376         * features/Makefile: Use feature target descriptions for Arm.
3377         * features/arm/arm-core.c: Generate new file.
3378         * features/arm/arm-fpa.c: Likewise.
3379         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3380         * features/arm/arm-m-profile.c: Likewise.
3381         * features/arm/arm-vfpv2.c: Likewise.
3382         * features/arm/arm-vfpv3.c: Likewise.
3383         * features/arm/xscale-iwmmxt.c: Likewise.
3384         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3385
3386 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3387
3388         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3389         ptrace earlier.
3390
3391 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3392
3393         * features/aarch64-pauth.c: Regenerate.
3394
3395 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3396
3397         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3398         bool.
3399         (bpstat_what): Use false instead of 0.
3400
3401 2019-07-09  Pedro Alves  <palves@redhat.com>
3402
3403         * break-catch-throw.c (is_exception_catchpoint): New.
3404         * breakpoint.c (print_one_breakpoint_location): New parameter
3405         'raw_loc'.  Handle it.  Use
3406         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3407         looking at the breakpoint's type.
3408         (print_one_breakpoint): If handling "maint info breakpoints", also
3409         print locations of exception catchpoints.
3410         * breakpoint.h (is_exception_catchpoint): Declare.
3411
3412 2019-07-09  Pedro Alves  <palves@redhat.com>
3413
3414         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3415         "addr" field.
3416         (allocate_location_exception_catchpoint): New.
3417         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3418         (initialize_throw_catchpoint_ops): Install
3419         allocate_location_exception_catchpoint as allocate_location
3420         method.
3421         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3422         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3423         bp_loc_other.
3424         (breakpoint_address_is_meaningful): Delete.
3425         (bl_address_is_meaningful): New.
3426         (breakpoint_locations_match): Adjust comment.
3427         (bp_location_from_bp_type): New, factored out of...
3428         (bp_location::bp_location(breakpoint *)): ... this.
3429         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3430         factored out of...
3431         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3432         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3433         breakpoint_address_is_meaningful.
3434         (bp_locations_compare): Adjust comment.
3435         (update_global_location_list): Use bl_address_is_meaningful
3436         instead of breakpoint_address_is_meaningful.
3437         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3438         explicit.
3439         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3440         * python/py-breakpoint.c (bppy_get_location): No longer check
3441         whether location is null.
3442
3443 2019-07-09  Pedro Alves  <palves@redhat.com>
3444
3445         PR c++/15468
3446         * breakpoint.c (print_one_breakpoint_location): Remove
3447         single-location assert.
3448
3449 2019-07-09  Tom Tromey  <tom@tromey.com>
3450
3451         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3452         * configure: Rebuild.
3453         * configure.ac: Change common to gdbsupport.
3454         * gdbsupport: Rename from common.
3455         * acinclude.m4: Change common to gdbsupport.
3456         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3457         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3458         gdbsupport.
3459         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3460         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3461         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3462         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3463         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3464         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3465         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3466         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3467         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3468         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3469         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3470         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3471         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3472         coff-pe-read.c, command.h, compile/compile-c-support.c,
3473         compile/compile-c.h, compile/compile-cplus-symbols.c,
3474         compile/compile-cplus-types.c, compile/compile-cplus.h,
3475         compile/compile-loc2c.c, compile/compile.c, completer.c,
3476         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3477         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3478         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3479         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3480         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3481         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3482         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3483         features/aarch64-core.c, features/aarch64-fpu.c,
3484         features/aarch64-pauth.c, features/aarch64-sve.c,
3485         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3486         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3487         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3488         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3489         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3490         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3491         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3492         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3493         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3494         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3495         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3496         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3497         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3498         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3499         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3500         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3501         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3502         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3503         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3504         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3505         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3506         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3507         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3508         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3509         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3510         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3511         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3512         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3513         minsyms.c, mips-linux-tdep.c, namespace.h,
3514         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3515         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3516         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3517         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3518         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3519         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3520         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3521         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3522         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3523         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3524         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3525         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3526         procfs.c, producer.c, progspace.h, psymtab.h,
3527         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3528         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3529         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3530         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3531         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3532         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3533         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3534         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3535         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3536         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3537         target-memory.c, target.c, target.h, target/waitstatus.c,
3538         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3539         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3540         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3541         unittests/array-view-selftests.c,
3542         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3543         unittests/common-utils-selftests.c,
3544         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3545         unittests/format_pieces-selftests.c,
3546         unittests/function-view-selftests.c,
3547         unittests/lookup_name_info-selftests.c,
3548         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3549         unittests/mkdir-recursive-selftests.c,
3550         unittests/observable-selftests.c,
3551         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3552         unittests/parse-connection-spec-selftests.c,
3553         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3554         unittests/scoped_fd-selftests.c,
3555         unittests/scoped_mmap-selftests.c,
3556         unittests/scoped_restore-selftests.c,
3557         unittests/string_view-selftests.c, unittests/style-selftests.c,
3558         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3559         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3560         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3561         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3562         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3563         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3564
3565 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3568         bool value.
3569         (decode_digits_ordinary): Set explicit_line field in sal.
3570         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3571         symtab_and_line that was set on an explicit line number in
3572         assembler code.  Do always update the recorded symtab and line if
3573         we do skip the prologue.
3574
3575 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3576
3577         * breakpoint.c (set_breakpoint_location_function): Remove
3578         explicit_loc parameter.
3579         (momentary_breakpoint_from_master): Update call to
3580         set_breakpoint_location_function.
3581         (add_location_to_breakpoint): Likewise.
3582
3583 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3586         required features based on default bfd type when no specific bfd
3587         is present.
3588
3589 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3590
3591         * NEWS: Mention that GDB printf and eval commands can now print
3592         C-style and Ada-style convenience var strings without
3593         calling the inferior.
3594         * printcmd.c (printf_c_string): Locally print GDB internal var
3595         instead of transiting via the inferior.
3596         (printf_wide_c_string): Likewise.
3597
3598 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3599
3600         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3601
3602 2019-07-04  Tom Tromey  <tom@tromey.com>
3603
3604         PR tui/24724:
3605         * tui/tui-winsource.c (tui_clear_source_content): Update.
3606         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3607         (tui_update_breakpoint_info): Update.
3608         (tui_set_exec_info_content): Update.
3609         * tui/tui-source.c (tui_set_source_content_nil): Update.
3610         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3611         has_break.
3612         * tui/tui-data.h (enum tui_bp_flag): New.
3613         (tui_bp_flags): New enum flags type.
3614         (struct tui_source_element) <break_mode>: Change type.  Rename
3615         from has_break.
3616         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3617         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3618         constants.
3619         * tui/tui-winsource.h: Fix comment.
3620
3621 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3622
3623         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3624         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3625         (store_fpregs_to_thread)
3626         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3627         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3628         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3629         (IWMMXT_REGS_SIZE): Add define.
3630         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3631         (fetch_vfp_regs, store_vfp_regs)
3632         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3633         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3634
3635 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3636
3637         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3638         defines.
3639         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3640         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3641         (ARM_INT_REGISTER_SIZE): ...to this.
3642         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3643         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3644         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3645         (arm_linux_collect_gregset, supply_nwfpe_register)
3646         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3647         defines.
3648         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3649         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3650         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3651         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3652         (arm_return_in_memory, arm_store_return_value)
3653         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3654         (arm_record_ld_st_multiple): Likewise.
3655         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3656         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3657
3658 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3659
3660         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3661         AARCH64_DISPLACED_MODIFIED_INSNS.
3662         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3663         (aarch64_displaced_step_copy_insn): Likewise.
3664         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3665         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3666         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3667         ARM_DISPLACED_MODIFIED_INSNS.
3668         * arm-tdep.c (arm_gdbarch_init): Likewise.
3669         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3670         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3671         (struct arm_displaced_step_closure): Use
3672         ARM_DISPLACED_MODIFIED_INSNS.
3673
3674 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3675
3676         * features/Makefile: Remove unused xml files.
3677         * features/aarch64.xml: Remove.
3678         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3679         * features/i386/amd64-avx-avx512.xml: Remove.
3680         * features/i386/amd64-avx-linux.xml: Remove.
3681         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3682         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3683         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3684         * features/i386/amd64-avx-mpx.xml: Remove.
3685         * features/i386/amd64-avx.xml: Remove.
3686         * features/i386/amd64-linux.xml: Remove.
3687         * features/i386/amd64-mpx-linux.xml: Remove.
3688         * features/i386/amd64-mpx.xml: Remove.
3689         * features/i386/amd64.xml: Remove.
3690         * features/i386/i386-avx-avx512-linux.xml: Remove.
3691         * features/i386/i386-avx-avx512.xml: Remove.
3692         * features/i386/i386-avx-linux.xml: Remove.
3693         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3694         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3695         * features/i386/i386-avx-mpx-linux.xml: Remove.
3696         * features/i386/i386-avx-mpx.xml: Remove.
3697         * features/i386/i386-avx.xml: Remove.
3698         * features/i386/i386-linux.xml: Remove.
3699         * features/i386/i386-mmx-linux.xml: Remove.
3700         * features/i386/i386-mmx.xml: Remove.
3701         * features/i386/i386-mpx-linux.xml: Remove.
3702         * features/i386/i386-mpx.xml: Remove.
3703         * features/i386/i386.xml: Remove.
3704         * features/i386/x32-avx-avx512-linux.xml: Remove.
3705         * features/i386/x32-avx-linux.xml: Remove.
3706         * features/i386/x32-linux.xml: Remove.
3707
3708 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3709
3710         * regformats/aarch64.dat: Remove.
3711         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3712         * regformats/i386/amd64-avx-linux.dat: Remove.
3713         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3714         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3715         * regformats/i386/amd64-linux.dat: Remove.
3716         * regformats/i386/amd64-mpx-linux.dat: Remove.
3717         * regformats/i386/amd64.dat: Remove.
3718         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3719         * regformats/i386/i386-avx-linux.dat: Remove.
3720         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3721         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3722         * regformats/i386/i386-linux.dat: Remove.
3723         * regformats/i386/i386-mmx-linux.dat: Remove.
3724         * regformats/i386/i386-mpx-linux.dat: Remove.
3725         * regformats/i386/i386.dat: Remove.
3726         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3727         * regformats/i386/x32-avx-linux.dat: Remove.
3728         * regformats/i386/x32-linux.dat: Remove.
3729
3730 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3731
3732         * aarch64-tdep.c: Remove xml self tests.
3733         * amd64-linux-tdep.c: Likewise.
3734         * amd64-tdep.c: Likewise.
3735         * i386-linux-tdep.c: Likewise.
3736         * i386-tdep.c: Likewise.
3737
3738 2019-07-03  Pedro Alves  <palves@redhat.com>
3739
3740         PR cli/24732
3741         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3742         (pipe_cmd_option_defs): New.
3743         (make_pipe_cmd_options_def_group): New.
3744         (pipe_command): Use gdb::option::process_options.
3745         (pipe_command_completer): New function.
3746         (_initialize_cli_cmds): Install completer for "pipe" command.
3747
3748 2019-07-03  Pedro Alves  <palves@redhat.com>
3749
3750         * cli/cli-option.c (union option_value) <string>: New field.
3751         (struct option_def_and_value): Add ctor, move ctor, dtor and
3752         use DISABLE_COPY_AND_ASSIGN.
3753         (option_def_and_value::clear_value): New.
3754         (parse_option, save_option_value_in_ctx, get_val_type_str)
3755         (add_setshow_cmds_for_options): Handle var_string.
3756         * cli-option.h (union option_def::var_address) <string>: New
3757         field.
3758         (struct string_option_def): New.
3759         * maint-test-options.c (struct test_options_opts): Add default
3760         ctor and use DISABLE_COPY_AND_ASSIGN.
3761         <string_opt>: New field.
3762         (test_options_opts::~test_options_opts): New.
3763         (test_options_opts::dump): Also dump "-string".
3764         (test_options_option_defs): Install "string.
3765
3766 2019-07-03  Pedro Alves  <palves@redhat.com>
3767
3768         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3769         option_value with a null enumeration.
3770         (complete_options): Save the option values in the context.
3771         (save_option_value_in_ctx): New, factored out from ...
3772         (process_options): ... here.
3773         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3774         of the function.
3775         * maint-test-options.c (test_options_opts::dump): New, factored
3776         out from ...
3777         (maintenance_test_options_command_mode): ... here.
3778         (maintenance_test_options_command_completion_result): Delete.
3779         (maintenance_test_options_command_completion_text): Update
3780         comment.
3781         (maintenance_show_test_options_completion_result): Change
3782         prototype.  Just print
3783         maintenance_test_options_command_completion_text.
3784         (save_completion_result): New.
3785         (maintenance_test_options_completer_mode): Pass options context to
3786         complete_options, and then save a dump.
3787         (_initialize_maint_test_options): Use add_cmd to install "maint
3788         show test-options-completion-result".
3789
3790 2019-07-03  Pedro Alves  <palves@redhat.com>
3791
3792         * NEWS (New commands): Mention "with" and "maint with".
3793         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3794         (with_command, with_command_completer): New.
3795         (pipe_command): Adjust to new repeat_previous
3796         interface.
3797         (_initialize_cli_cmds): Install the "with" command and its "w"
3798         alias.
3799         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3800         declarations.
3801         * cli/cli-setshow.c (parse_cli_var_uinteger)
3802         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3803         argument strings for all var_types.
3804         (get_setshow_command_value_string): New, factored out from ...
3805         (do_show_command): ... this.
3806         * cli/cli-setshow.h: Include <string>.
3807         (get_setshow_command_value_string): Declare.
3808         * command.h (repeat_previous): Now returns const char *.  Adjust
3809         comment.
3810         * maint.c: Include "cli/cli-cmds.h".
3811         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3812         (_initialize_maint_cmds): Register the "maintenance with" command.
3813         * top.c (repeat_previous): Move bits from pipe_command here:
3814         Return the saved command line, if any; error out if there's no
3815         command to relaunch.
3816
3817 2019-07-03  Pedro Alves  <palves@redhat.com>
3818
3819         * NEWS (New commands): Mention "maint set/show test-settings"
3820         instead of "maint test-settings".
3821         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3822         (maintenance_test_settings_set_list): Rename to ...
3823         (maintenance_set_test_settings_list): ... this.
3824         (maintenance_test_settings_show_list): Rename to  ...
3825         (maintenance_show_test_settings_list): ... this.
3826         (maintenance_test_settings_cmd): Delete.
3827         (maintenance_test_settings_set_cmd): ...
3828         (maintenance_set_test_settings_cmd): ... this.
3829         (maintenance_test_settings_show_cmd): ...
3830         (maintenance_show_test_settings_cmd): ... this.
3831         (maintenance_test_settings_show_value_cmd):
3832         (maintenance_show_test_settings_value_cmd): ... this.
3833         (_initialize_maint_test_settings): No longer install the "maint
3834         test-settings" prefix command.  Rename "maint test-settings set"
3835         to "maint set test-settings", and "maint test-settings show" to
3836         "maint show test-settings".  Adjust all subcommands.
3837
3838 2019-07-03  Pedro Alves  <palves@redhat.com>
3839
3840         * maint-test-settings.c: Fix file's intro comment.  Replace all
3841         references to "test-options" with references to "test-settings",
3842         in comments.
3843
3844 2019-07-03  Pedro Alves  <palves@redhat.com>
3845
3846         * maint-test-settings.c (maintenance_test_settings_xxx)
3847         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3848         New.
3849         (maintenance_test_settings_enums): Use them.
3850         (maintenance_test_settings_enum): Default to
3851         maintenance_test_settings_xxx.
3852         (_initialize_maint_test_settings): Initialize
3853         MAINTENANCE_TEST_SETTINGS_FILENAME.
3854
3855 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3856
3857         * breakpoint.h (remove_breakpoints_inf): Change return type to
3858         void, move function documentation here.
3859         * breakpoint.c (remove_breakpoints_inf): Change return type to
3860         void, move function documentation to header.
3861
3862 2019-07-02  Pedro Alves  <palves@redhat.com>
3863
3864         * NEWS (Completion improvements): Mention "info threads".
3865         * thread.c (struct info_threads_opts, info_threads_option_defs)
3866         (make_info_threads_options_def_group): New.
3867         (info_threads_command): Use gdb::option::process_options.
3868         (info_threads_command_completer): New.
3869         (_initialize_thread): Use gdb::option::build_help to build the
3870         help text for "info threads".
3871
3872 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3873
3874         * defs.h (generic_load): Move from here...
3875         * symfile.h (generic_load): ... to here.  Rename name parameter
3876         to args.
3877         * symfile.c (generic_load): Add comment.
3878
3879 2019-07-01  Tom Tromey  <tromey@adacore.com>
3880
3881         * dwarf2read.c
3882         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3883         declaration of without_params.  Fix formatting.
3884
3885 2019-07-01  Tom Tromey  <tromey@adacore.com>
3886
3887         * ada-exp.y (find_primitive_type): Update.
3888         * ada-lang.h (ada_lookup_symbol): Update.
3889         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3890         parameter.
3891         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3892
3893 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3894
3895         PR breakpoints/24541
3896         * gdbarch.c: Regenerate.
3897         * gdbarch.h: Regenerate.
3898         * gdbarch.sh: Add 'stap_adjust_register'.
3899         * i386-tdep.c: Include '<unordered_set>'.
3900         (i386_stap_adjust_register): New function.
3901         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3902         * stap-probe.c (stap_parse_register_operand): Call
3903         'gdbarch_stap_adjust_register'.
3904
3905 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3906
3907         PR python/24742
3908         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3909         * python/python.c (do_start_initialization): Use 'xmalloc'
3910         instead of 'PyMem_Malloc'.
3911
3912 2019-06-28  Tom Tromey  <tromey@adacore.com>
3913
3914         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3915         for Ada.
3916
3917 2019-06-27  Tom Tromey  <tromey@adacore.com>
3918
3919         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3920         objfile_key.
3921         (arm_find_mapping_symbol, arm_record_special_symbol)
3922         (_initialize_arm_tdep): Update.
3923         (arm_objfile_data_free): Remove.
3924
3925 2019-06-27  Tom Tromey  <tromey@adacore.com>
3926
3927         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3928         to cp_print_static_field.
3929
3930 2019-06-26  Tom Tromey  <tromey@adacore.com>
3931
3932         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3933         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3934         declare.
3935
3936 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3937
3938         * features/aarch64-core.c (create_feature_aarch64_core):
3939         Regenerate.
3940         * features/aarch64-core.xml: Add cpsr flags.
3941
3942 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3943
3944         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3945         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3946
3947 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3948
3949         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3950         field.
3951         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3952         use.
3953         (arm_record_special_symbol): Don't insert new symbol in sorted
3954         position, push it at the end.
3955
3956 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3957
3958         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3959         (arm_mapping_symbol_s): Remove.
3960         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3961         (arm_mapping_symbol_vec): New typedef.
3962         (struct arm_per_objfile): Add constructor.
3963         <section_maps>: Change type to
3964         std::unique_ptr<arm_mapping_symbol_vec[]>.
3965         (arm_compare_mapping_symbols): Remove.
3966         (arm_find_mapping_symbol): Adjust to section_maps type change.
3967         (arm_objfile_data_free): Call delete on arm_per_objfile.
3968         (arm_record_special_symbol): Adjust to section_maps type change.
3969         Allocate arm_per_objfile with new.
3970
3971 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3972
3973         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3974         with the command prefix.
3975
3976 2019-06-25  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3979         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3980
3981 2019-06-25  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3984         type.
3985         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3986         protected.
3987
3988 2019-06-25  Tom Tromey  <tom@tromey.com>
3989
3990         * tui/tui-winsource.c
3991         (tui_source_window_base::set_is_exec_point_at): Add check against
3992         LOA_ADDRESS.
3993
3994 2019-06-25  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-source.c (tui_set_source_content): Don't check before
3997         xfree.
3998         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3999
4000 2019-06-25  Tom Tromey  <tom@tromey.com>
4001
4002         * tui/tui-winsource.h (tui_update_source_window_as_is)
4003         (tui_alloc_source_buffer, tui_line_is_displayed)
4004         (tui_addr_is_displayed): Change type of win_info.
4005         * tui/tui-winsource.c (tui_update_source_window_as_is)
4006         (tui_clear_source_content, tui_show_source_line)
4007         (tui_show_source_content, tui_source_window_base::refill)
4008         (tui_source_window_base::set_is_exec_point_at)
4009         (tui_source_window_base::set_is_exec_point_at)
4010         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4011         (tui_alloc_source_buffer, tui_line_is_displayed)
4012         (tui_addr_is_displayed): Change type of win_info.  Update.
4013         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4014         (tui_source_window_base::do_make_visible_with_new_height):
4015         Update.
4016         * tui/tui-source.c (tui_set_source_content)
4017         (tui_set_source_content_nil)
4018         (tui_source_window::do_scroll_vertical): Update.
4019         * tui/tui-layout.c (show_layout): Update.
4020         * tui/tui-disasm.c (tui_set_disassem_content)
4021         (tui_disasm_window::do_scroll_vertical): Update.
4022         * tui/tui-data.h (tui_win_content): Remove.
4023         (struct tui_gen_win_info) <content, content_size>: Remove.
4024         (struct tui_source_element): Add initializers and destructor.
4025         (union tui_which_element, struct tui_win_element): Remove.
4026         (struct tui_source_window_base) <content>: New field.
4027         (struct tui_data_window): Remove destructor.
4028         (tui_alloc_content, tui_free_win_content)
4029         (tui_free_all_source_wins_content): Don't declare.
4030         * tui/tui-data.c (tui_initialize_static_data): Update.
4031         (init_content_element, tui_alloc_content): Remove.
4032         (~tui_gen_win_info): Update.
4033         (~tui_data_window, tui_free_all_source_wins_content)
4034         (tui_free_win_content, free_content, free_content_elements):
4035         Remove.
4036
4037 2019-06-25  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-winsource.h (tui_clear_source_content)
4040         (tui_erase_source_content, tui_show_source_content): Change type
4041         of win_info.
4042         * tui/tui-winsource.c (tui_clear_source_content)
4043         (tui_erase_source_content, tui_show_source_content): Change type
4044         of win_info.
4045         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4046         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4047         win_info.
4048         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4049         win_info.
4050         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4051
4052 2019-06-25  Tom Tromey  <tom@tromey.com>
4053
4054         * tui/tui-winsource.c (tui_clear_source_content)
4055         (tui_source_window_base::set_is_exec_point_at): Update.
4056         * tui/tui-source.c (tui_set_source_content_nil): Update.
4057         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4058         a bool.
4059         * tui/tui-data.c (init_content_element): Update.
4060
4061 2019-06-25  Tom Tromey  <tom@tromey.com>
4062
4063         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4064         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4065         * tui/tui-layout.c (init_and_make_win): Update.
4066         * tui/tui.h (enum tui_win_type): Update.
4067         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4068         tui_win_is_auxillary.
4069         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4070         tui_win_is_auxillary.
4071
4072 2019-06-25  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4075         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4076         (tui_delete_data_content_windows, tui_display_all_data)
4077         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4078         Update.
4079         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4080         * tui/tui-regs.c (tui_last_regs_line_no)
4081         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4082         (tui_show_registers): Update.
4083         (tui_show_register_group): Return void.  Update.
4084         (tui_display_registers_from, tui_display_reg_element_at_line)
4085         (tui_display_registers_from_line, tui_check_register_values):
4086         Update.
4087         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4088         member.
4089         (struct tui_data_window) <regs_content>: Now a std::vector.
4090         <regs_content_count>: Remove.
4091         (tui_add_content_elements, tui_free_data_content): Don't declare.
4092         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4093         (init_content_element): Remove DATA_WIN case.  Add assert.
4094         (tui_add_content_elements): Remove.
4095         (tui_data_window): Update.
4096         (tui_free_data_content): Remove.
4097         (free_content_elements): Remove DATA_WIN case.
4098
4099 2019-06-25  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui-data.c (tui_data_item_window): Update.
4102         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4103         * tui/tui-windata.c (tui_display_all_data)
4104         (tui_display_data_from_line): Update.
4105         (tui_check_data_values): Remove.
4106         * tui/tui-regs.c (tui_show_register_group)
4107         (tui_display_reg_element_at_line): Update.
4108         * tui/tui-hooks.c (tui_register_changed)
4109         (tui_refresh_frame_and_register_information): Call
4110         tui_check_register_values.
4111         * tui/tui-data.h (struct tui_data_window) <data_content,
4112         data_content_count, data_type>: Remove.
4113         (enum tui_data_type): Remove.
4114
4115         * tui/tui-data.c (tui_data_window::clear_detail)
4116         (~tui_data_window): Update.
4117
4118 2019-06-25  Tom Tromey  <tom@tromey.com>
4119
4120         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4121         declare.
4122         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4123         Rename from tui_first_data_item_displayed.  Update.
4124         (tui_data_window::refresh_all)
4125         (tui_data_window::do_scroll_vertical): Update.
4126         * tui/tui-data.h (struct tui_data_window)
4127         <first_data_item_displayed>: Declare new method.
4128
4129 2019-06-25  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4132         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4133         contents...
4134         (tui_initialize_static_data): ...here.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4139         (tui_display_registers_from, tui_check_register_values): Update.
4140         (tui_display_register): Remove win_info parameter; update.
4141         (tui_get_register): Change type of parameters.
4142         * tui/tui-data.h (struct tui_data_element): Remove.
4143         (union tui_which_element) <data>: Remove.
4144         <data_window>: Change type.
4145         (struct tui_data_item_window): New.
4146         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4147         case.  Add assert.
4148         (~tui_data_item_window): New destructor.
4149         (free_content_elements): Remove DATA_ITEM_WIN case.
4150
4151 2019-06-25  Tom Tromey  <tom@tromey.com>
4152
4153         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4154         Remove.
4155
4156 2019-06-25  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-data.h (struct tui_command_element): Remove.
4159         (union tui_which_element) <command>: Remove.
4160         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4161         assert.
4162         (free_content_elements): Remove CMD_WIN case.
4163
4164 2019-06-25  Tom Tromey  <tom@tromey.com>
4165
4166         * tui/tui-layout.c (tui_set_layout): Update.
4167         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4168         * tui/tui-data.c (layout_def): Update.
4169
4170 2019-06-25  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4173         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4174         (tui_source_window_base::set_new_height): Update.
4175         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4176         Update.
4177         (tui_set_locator_fullname, tui_set_locator_info)
4178         (tui_show_frame_info): Update.
4179         * tui/tui-source.c (tui_set_source_content)
4180         (tui_source_is_displayed): Update.
4181         * tui/tui-layout.c (show_source_disasm_command, show_data)
4182         (show_source_or_disasm_and_command): Update.
4183         * tui/tui-disasm.c (tui_set_disassem_content)
4184         (tui_get_begin_asm_address): Update.
4185         * tui/tui-data.h (struct tui_locator_element): Remove.
4186         (union tui_which_element) <locator>: Remove.
4187         (struct tui_locator_window): New.
4188         (tui_locator_win_info_ptr): Change return type.
4189         * tui/tui-data.c (_locator): Change type.
4190         (tui_locator_win_info_ptr): Change return type.
4191         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4192         (tui_alloc_content): Add assert.
4193
4194 2019-06-25  Tom Tromey  <tom@tromey.com>
4195
4196         * tui/tui-winsource.c
4197         (tui_exec_info_window::maybe_allocate_content): New method.
4198         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4199         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4200         (make_source_or_disasm_window): Add cast.
4201         * tui/tui-data.h (union tui_which_element) <simple_string>:
4202         Remove.
4203         (struct tui_source_info): New.
4204         (struct tui_source_window_base) <execution_info>: Change type.
4205         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4206         case, and add assert.
4207         (tui_alloc_content): Add assert.
4208
4209 2019-06-25  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4212         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4213         * tui/tui-data.c (tui_alloc_win_info): Remove.
4214
4215 2019-06-25  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4218         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4219         can_highlight.
4220
4221 2019-06-25  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4224         make_visible_with_new_height method.
4225         (tui_win_info::make_visible_with_new_height): New method.
4226         (tui_source_window_base::do_make_visible_with_new_height)
4227         (tui_data_window::do_make_visible_with_new_height)
4228         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4229         (make_visible_with_new_height): Remove.
4230         (tui_resize_all, tui_adjust_win_heights): Use
4231         make_visible_with_new_height method.
4232         * tui/tui-data.h (struct tui_win_info)
4233         <do_make_visible_with_new_height, make_visible_with_new_height>:
4234         New methods.
4235         (struct tui_source_window_base, struct tui_data_window)
4236         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4237         methods.
4238
4239 2019-06-25  Tom Tromey  <tom@tromey.com>
4240
4241         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4242         method.
4243         (update_tab_width): Call update_tab_width method.
4244         * tui/tui-data.h (struct tui_win_info)
4245         (struct tui_source_window_base) <update_tab_width>: New methods.
4246
4247 2019-06-25  Tom Tromey  <tom@tromey.com>
4248
4249         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4250         parameter.
4251         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4252         parameter.
4253         (tui_gen_win_info::make_visible): Update.
4254         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4255         parameter.
4256         * tui/tui-data.h (enum tui_box): New enum.
4257         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4258
4259 2019-06-25  Tom Tromey  <tom@tromey.com>
4260
4261         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4262         init_and_make_win for EXEC_INFO_WIN.
4263         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4264         longer inline.
4265         (struct tui_win_info) <~tui_win_info>: Inline.
4266         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4267         Don't declare.
4268         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4269         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4270         Remove.
4271         (tui_initialize_static_data): Update.
4272         (~tui_gen_win_info): Handle more cleanup here.
4273         (~tui_source_window_base): Delete "execution_info".
4274         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4275
4276 2019-06-25  Tom Tromey  <tom@tromey.com>
4277
4278         * tui/tui-layout.c (make_command_window): Don't set
4279         can_highlight.
4280         (show_source_disasm_command): Call the reset method.
4281         (show_data): Don't set can_highlight.  Call the reset method.
4282         (tui_gen_win_info::reset): Rename from init_gen_win_info
4283         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4284         (show_source_or_disasm_and_command): Call the reset method.
4285         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4286         (struct tui_cmd_window): Set can_highlight.
4287
4288 2019-06-25  Tom Tromey  <tom@tromey.com>
4289
4290         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4291         from make_visible.
4292         (tui_make_visible, tui_make_invisible): Rewrite.
4293         (tui_win_info::make_visible): Remove.
4294         (tui_source_window_base::make_visible): Update.
4295         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4296         method.  Moved from...
4297         (struct tui_win_info) <make_visible>: ...here.
4298
4299 2019-06-25  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-winsource.c
4302         (tui_source_window_base::do_scroll_horizontal): Remove direction
4303         parameter.
4304         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4305         direction parameter.
4306         * tui/tui-win.c (tui_win_info::forward_scroll)
4307         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4308         (tui_win_info::right_scroll): Update.
4309         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4310         direction parameter.
4311         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4312         direction parameter.
4313         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4314         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4315         Remove direction parameter.
4316         (struct tui_source_window_base, struct tui_source_window)
4317         (struct tui_disasm_window, struct tui_data_window)
4318         (struct tui_cmd_window): Update.
4319
4320 2019-06-25  Tom Tromey  <tom@tromey.com>
4321
4322         * tui/tui-winsource.h (tui_set_exec_info_content)
4323         (tui_show_exec_info_content, tui_erase_exec_info_content)
4324         (tui_clear_exec_info_content, tui_update_exec_info): Change
4325         argument to tui_source_window_base.
4326         * tui/tui-winsource.c (tui_set_exec_info_content)
4327         (tui_show_exec_info_content, tui_erase_exec_info_content)
4328         (tui_clear_exec_info_content, tui_update_exec_info): Change
4329         argument to tui_source_window_base.
4330
4331 2019-06-25  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4334         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4335
4336 2019-06-25  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4339         check.
4340
4341 2019-06-25  Tom Tromey  <tom@tromey.com>
4342
4343         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4344         type to void.
4345         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4346         type to void.
4347         * tui/tui-source.c (tui_set_source_content): Update.
4348         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4349
4350 2019-06-25  Tom Tromey  <tom@tromey.com>
4351
4352         * tui/tui-win.c (window_name_completer, tui_set_focus)
4353         (tui_all_windows_info): Use name method.
4354         * tui/tui-data.h (struct tui_gen_win_info)
4355         (struct tui_source_window, struct tui_disasm_window)
4356         (struct tui_data_window, struct tui_cmd_window) <name>: New
4357         method.
4358         (tui_win_name): Don't declare.
4359         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4360         (tui_win_name): Remove.
4361
4362 2019-06-25  Tom Tromey  <tom@tromey.com>
4363
4364         * tui/tui-winsource.h (tui_update_source_window)
4365         (tui_update_source_window_as_is): Change parameter type.
4366         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4367         to be a tui_source_window_base.
4368         (tui_update_source_window_as_is): Likewise.
4369         * tui/tui-win.c (make_visible_with_new_height): Update.
4370
4371 2019-06-25  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui-winsource.c (tui_erase_source_content)
4374         (tui_show_source_content, tui_show_exec_info_content)
4375         (tui_erase_exec_info_content): Use refresh_window method.
4376         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4377         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4378         from tui_refresh_win.
4379         (tui_data_window::refresh_window): New method.
4380         (tui_win_info::refresh, tui_source_window_base::refresh)
4381         (tui_refresh_all): Use refresh_window method.
4382         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4383         method.
4384         * tui/tui-regs.c (tui_display_register): Call refresh_window
4385         method.
4386         * tui/tui-layout.c (show_source_disasm_command)
4387         (show_source_or_disasm_and_command): Call refresh_window method.
4388         * tui/tui-data.h (struct tui_gen_win_info)
4389         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4390         New method.
4391
4392 2019-06-25  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui.c (tui_rl_other_window, tui_enable)
4395         (tui_is_window_visible, tui_get_command_dimension): Update.
4396         * tui/tui-winsource.c (tui_update_source_window_as_is)
4397         (tui_clear_source_content, tui_erase_source_content)
4398         (tui_show_source_line, tui_source_window_base::refill)
4399         (tui_source_window_base::do_scroll_horizontal)
4400         (tui_source_window_base::set_is_exec_point_at)
4401         (tui_update_breakpoint_info, tui_set_exec_info_content)
4402         (tui_alloc_source_buffer, tui_line_is_displayed)
4403         (tui_addr_is_displayed): Update.
4404         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4405         (tui_check_and_display_highlight_if_needed)
4406         (tui_win_info::make_visible, tui_win_info::refresh)
4407         (tui_refresh_all): Update.
4408         * tui/tui-windata.c (tui_first_data_item_displayed)
4409         (tui_delete_data_content_windows, tui_erase_data_content)
4410         (tui_display_all_data, tui_data_window::refresh_all)
4411         (tui_check_data_values): Update.
4412         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4413         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4414         (tui_win_info::backward_scroll, tui_refresh_all_win)
4415         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4416         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4417         (tui_source_window_base::set_new_height)
4418         (tui_data_window::set_new_height)
4419         (make_invisible_and_set_new_height)
4420         (make_visible_with_new_height, new_height_ok)
4421         (parse_scrolling_args): Update.
4422         * tui/tui-stack.c (tui_show_frame_info): Update.
4423         * tui/tui-source.c (tui_set_source_content)
4424         (tui_set_source_content_nil, tui_source_is_displayed)
4425         (tui_source_window::do_scroll_vertical): Update.
4426         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4427         (tui_display_registers_from, tui_display_reg_element_at_line)
4428         (tui_check_register_values, tui_reg_command): Update.
4429         * tui/tui-layout.c (tui_default_win_height)
4430         (show_source_disasm_command, show_data, init_and_make_win)
4431         (show_source_or_disasm_and_command): Update.
4432         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4433         (tui_redisplay_readline, tui_mld_flush)
4434         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4435         (tui_getc): Update.
4436         * tui/tui-disasm.c (tui_set_disassem_content)
4437         (tui_disasm_window::do_scroll_vertical): Update.
4438         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4439         Now virtual.
4440         (struct tui_win_info): Derive from tui_gen_win_info.
4441         <~tui_win_info>: Mark as override.
4442         <generic>: Remove member.
4443         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4444         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4445         (~tui_data_window, ~tui_win_info)
4446         (tui_free_all_source_wins_content): Update.
4447         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4448
4449 2019-06-25  Tom Tromey  <tom@tromey.com>
4450
4451         * tui/tui-layout.c (init_and_make_win): Use new.
4452         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4453         destructor, initializers.
4454         (tui_alloc_generic_win_info): Don't declare.
4455         * tui/tui-data.c (_locator): Add argument to constructor.
4456         (source_win, disasm_win): New globals.
4457         (exec_info): Remove.
4458         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4459         Update.
4460         (tui_alloc_generic_win_info): Remove.
4461         (init_content_element): Use new.
4462         (tui_win_info::tui_win_info): Update.
4463         (free_content_elements) <case DATA_WIN>: Use delete.
4464
4465 2019-06-25  Tom Tromey  <tom@tromey.com>
4466
4467         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4468         * tui/tui-windata.c (tui_first_data_item_displayed)
4469         (tui_delete_data_content_windows): Update.
4470         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4471         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4472         (tui_display_registers_from, tui_check_register_values): Update.
4473         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4474         pointer.
4475         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4476         window.
4477         (tui_free_data_content): Update.
4478         (free_content_elements) <case DATA_WIN>: Free the window.
4479
4480 2019-06-25  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4483         Update.
4484         * tui/tui-layout.c (make_command_window)
4485         (show_source_disasm_command, show_data, init_and_make_win)
4486         (show_source_or_disasm_and_command): Update.
4487         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4488         method.
4489         <can_highight, is_highlighted>: Now bool.
4490         (tui_set_win_highlight): Don't declare.
4491         * tui/tui-data.c (tui_set_win_highlight): Remove.
4492
4493 2019-06-25  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-wingeneral.c (make_visible): Remove check of window
4496         type.
4497
4498 2019-06-25  Tom Tromey  <tom@tromey.com>
4499
4500         * tui/tui-win.c (tui_win_info::max_height)
4501         (tui_cmd_window::max_height): New methods.
4502         (new_height_ok): Call max_height.
4503         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4504         <max_height>: New method.
4505
4506 2019-06-25  Tom Tromey  <tom@tromey.com>
4507
4508         * tui/tui-win.c (tui_source_window_base::set_new_height)
4509         (tui_data_window::set_new_height): New methods.
4510         (make_invisible_and_set_new_height): Call set_new_height method.
4511         * tui/tui-data.h (struct tui_win_info)
4512         (struct tui_source_window_base, struct tui_data_window)
4513         <set_new_height>: New method.
4514
4515 2019-06-25  Tom Tromey  <tom@tromey.com>
4516
4517         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4518         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4519         tui_refresh_data_win.
4520         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4521         method.
4522         (tui_refresh_all_win): Call the refresh_all method.
4523         (tui_set_focus): Likewise.
4524         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4525         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4526         Likewise.
4527
4528 2019-06-25  Tom Tromey  <tom@tromey.com>
4529
4530         * tui/tui-winsource.h (tui_refill_source_window)
4531         (tui_set_is_exec_point_at): Don't declare.
4532         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4533         (tui_source_window_base::refill): Rename from
4534         tui_refill_source_window.
4535         (tui_source_window_base::do_scroll_horizontal): Update.
4536         (tui_source_window_base::set_is_exec_point_at): Rename from
4537         tui_set_is_exec_point_at.
4538         (tui_update_all_breakpoint_info): Update.
4539         * tui/tui-stack.c (tui_show_frame_info): Update.
4540         * tui/tui-layout.c (show_data): Add cast.
4541         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4542         * tui/tui-data.h (struct tui_source_window_base) <refill,
4543         set_is_exec_point_at>: New methods.
4544         (tui_source_windows, tui_add_to_source_windows): Update types.
4545         (tui_add_to_source_windows): Remove redundant declaration.
4546         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4547         (tui_source_windows): Change return type.
4548         (tui_clear_source_windows_detail): Update.
4549         (tui_add_to_source_windows): Change type of parameter.
4550         (tui_free_all_source_wins_content): Update.
4551
4552 2019-06-25  Tom Tromey  <tom@tromey.com>
4553
4554         * tui/tui-wingeneral.c (tui_win_info::refresh)
4555         (tui_source_window_base::refresh): New methods.
4556         (tui_refresh_all): Call the refresh method.
4557         * tui/tui-data.h (struct tui_win_info)
4558         (struct tui_source_window_base) <refresh>: New method.
4559
4560 2019-06-25  Tom Tromey  <tom@tromey.com>
4561
4562         * tui/tui.h (tui_is_window_visible): Return bool.
4563         * tui/tui.c (tui_is_window_visible): Return bool.
4564         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4565         (tui_make_visible, tui_make_invisible)
4566         (tui_win_info::make_visible)
4567         (tui_source_window_base::make_visible, make_all_visible)
4568         (tui_make_all_visible, tui_make_all_invisible): Update.
4569         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4570         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4571         bool.
4572         (struct tui_win_info, struct tui_source_window_base)
4573         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4574         * tui/tui-data.c (tui_init_generic_part): Update.
4575
4576 2019-06-25  Tom Tromey  <tom@tromey.com>
4577
4578         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4579         (tui_source_window_base::make_visible): New methods.
4580         (make_all_visible): Make method call.
4581         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4582         (struct tui_source_window_base, struct tui_cmd_window): Override
4583         make_visible.
4584         (tui_win_is_source_type): Don't declare.
4585         * tui/tui-data.c (tui_win_is_source_type): Remove.
4586
4587 2019-06-25  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4590         NULL check.
4591
4592 2019-06-25  Tom Tromey  <tom@tromey.com>
4593
4594         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4595         Inline constructor.  Add initializers for members.
4596         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4597         constructors; now inline in class.
4598
4599 2019-06-25  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-regs.c (tui_show_registers): Update.
4602         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4603         bool.
4604         * tui/tui-data.c (tui_data_window::clear_detail)
4605         (tui_data_window): Update.
4606
4607 2019-06-25  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-windata.c (tui_display_all_data)
4610         (tui_display_data_from_line, tui_display_data_from)
4611         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4612         Update.
4613         * tui/tui-regs.c (tui_last_regs_line_no)
4614         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4615         (tui_show_registers, tui_show_register_group)
4616         (tui_display_registers_from, tui_display_reg_element_at_line)
4617         (tui_display_registers_from_line, tui_check_register_values)
4618         (tui_reg_next, tui_reg_prev): Update.
4619         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4620         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4621         tui_data_window.
4622         (struct tui_win_info) <detail>: Remove.  Add new fields from
4623         tui_data_info.
4624         (TUI_DATA_WIN): Add cast.
4625         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4626         (~tui_data_window): Simplify.
4627
4628 2019-06-25  Tom Tromey  <tom@tromey.com>
4629
4630         * tui/tui-layout.c (show_source_disasm_command)
4631         (show_source_or_disasm_and_command): Update.
4632         * tui/tui-io.c (update_cmdwin_start_line)
4633         (tui_redisplay_readline): Update.
4634         * tui/tui-data.h (struct tui_command_info): Remove.
4635         (struct tui_win_info) <detail>: Remove command_info member.
4636         (struct tui_data_window) <start_line>: New member, from
4637         tui_command_info.
4638         (TUI_CMD_WIN): Add casts.
4639
4640 2019-06-25  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-winsource.c (tui_update_source_window)
4643         (tui_refill_source_window)
4644         (tui_source_window_base::do_scroll_horizontal)
4645         (tui_update_breakpoint_info, tui_set_exec_info_content)
4646         (tui_show_exec_info_content, tui_erase_exec_info_content)
4647         (tui_clear_exec_info_content): Update.
4648         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4649         Update.
4650         * tui/tui-win.c (make_invisible_and_set_new_height)
4651         (make_visible_with_new_height): Update.
4652         * tui/tui-source.c (tui_set_source_content)
4653         (tui_show_symtab_source): Update.
4654         * tui/tui-layout.c (extract_display_start_addr)
4655         (show_source_disasm_command, show_data)
4656         (make_source_or_disasm_window)
4657         (show_source_or_disasm_and_command): Update.
4658         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4659         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4660         "gdbarch".
4661         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4662         to tui_source_window_base.
4663         (struct tui_win_info) <detail>: Remove source_info member.
4664         (struct tui_source_window_base) <has_locator>: Inline.
4665         Move contents from tui_source_info; rename has_locator member to
4666         m_has_locator.
4667         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4668         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4669         header file.
4670         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4671         Simplify.
4672         (tui_free_all_source_wins_content): Cast to
4673         tui_source_window_base.
4674
4675 2019-06-25  Tom Tromey  <tom@tromey.com>
4676
4677         * tui/tui-win.c (make_invisible_and_set_new_height)
4678         (make_visible_with_new_height): Call has_locator method.
4679         * tui/tui-layout.c (show_source_disasm_command, show_data)
4680         (show_source_or_disasm_and_command): Update for bool change.
4681         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4682         (tui_win_info) <has_locator>: New method.
4683         (struct tui_source_window_base) <has_locator>: New method.
4684         (tui_win_has_locator): Don't declare.
4685         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4686         from tui_win_has_locator.
4687         (tui_source_window_base): Use false, not FALSE.
4688
4689 2019-06-25  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4692         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4693         clear_detail method directly.
4694         (tui_clear_win_detail): Remove.
4695
4696 2019-06-25  Tom Tromey  <tom@tromey.com>
4697
4698         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4699         "this", not TUI_DISASM_WIN.
4700
4701 2019-06-25  Tom Tromey  <tom@tromey.com>
4702
4703         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4704         declare.
4705         * tui/tui-winsource.c
4706         (tui_source_window_base::do_scroll_horizontal): Rename from
4707         tui_horizontal_source_scroll.
4708         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4709         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4710         from tui_vertical_data_scroll.
4711         * tui/tui-win.h (tui_scroll): Don't declare.
4712         * tui/tui-win.c (tui_win_info::forward_scroll)
4713         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4714         (tui_win_info::right_scroll): Rename and update.
4715         (tui_scroll_forward_command, tui_scroll_backward_command)
4716         (tui_scroll_left_command, tui_scroll_right_command): Update.
4717         (tui_scroll): Remove.
4718         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4719         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4720         from tui_vertical_source_scroll.
4721         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4722         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4723         from tui_vertical_disassem_scroll.
4724         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4725         do_scroll_horizontal>: New methods.
4726         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4727         Likewise.
4728         (struct tui_source_window_base): Add do_scroll_horizontal.
4729         (struct tui_source_window, struct tui_disasm_window): Add
4730         do_scroll_vertical.
4731         (struct tui_data_window, struct tui_cmd_window): Add
4732         do_scroll_horizontal and do_scroll_vertical.
4733         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4734
4735 2019-06-25  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-data.h (struct tui_source_window_base): New struct.
4738         (struct tui_source_window): Derive from tui_source_window_base.
4739         (struct tui_disasm_window): New struct.
4740         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4741         from tui_source_window::clear_detail.
4742         (tui_source_window_base): Rename from tui_source_window.
4743         (~tui_source_window_base): Rename from ~tui_source_window.
4744         (tui_alloc_win_info): Create a tui_disasm_window.
4745
4746 2019-06-25  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-data.h (struct tui_source_window)
4749         (struct tui_data_window): Declare destructors.
4750         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4751         destructors.
4752         (tui_win_info): Simplify.
4753
4754 2019-06-25  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-winsource.c (tui_display_main)
4757         (tui_update_source_windows_with_addr)
4758         (tui_update_all_breakpoint_info): Update.
4759         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4760         (new_height_ok, parse_scrolling_args): Update.
4761         * tui/tui-stack.c (tui_show_frame_info): Update.
4762         * tui/tui-data.h (struct tui_list): Remove.
4763         (tui_source_windows): Return a reference to a std::vector.
4764         * tui/tui-data.c (source_windows): Now a std::vector.
4765         (tui_source_windows): Change return type.
4766         (tui_clear_source_windows): Rewrite.
4767         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4768         (tui_free_all_source_wins_content): Rewrite.
4769
4770 2019-06-25  Tom Tromey  <tom@tromey.com>
4771
4772         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4773         (struct tui_data_window, struct tui_cmd_window): Declare
4774         clear_detail method.
4775         * tui/tui-data.c (tui_source_window::clear_detail)
4776         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4777         methods.
4778         (tui_clear_win_detail): Simplify.
4779
4780 2019-06-25  Tom Tromey  <tom@tromey.com>
4781
4782         * tui/tui-layout.c (make_source_window, make_disasm_window)
4783         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4784         Return the new window.
4785         (show_source_disasm_command, show_data)
4786         (show_source_or_disasm_and_command): Update.
4787
4788 2019-06-25  Tom Tromey  <tom@tromey.com>
4789
4790         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4791         parameter.  Return the new window.
4792         (show_source_disasm_command): Update and remove NULL check.
4793         (show_source_or_disasm_and_command): Update.
4794
4795 2019-06-25  Tom Tromey  <tom@tromey.com>
4796
4797         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4798
4799 2019-06-25  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-data.h (struct tui_win_info): Make constructor
4802         protected.  Make destructor virtual.  Add initializers.
4803         (tui_source_window, tui_data_window, tui_cmd_window): New
4804         classes.
4805         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4806         constructor.  Add "type" parameter.
4807         (tui_source_window, tui_data_window, tui_cmd_window): New
4808         constructors.
4809         (tui_alloc_win_info): Instantiate the appropriate subclass.
4810
4811 2019-06-25  Tom Tromey  <tom@tromey.com>
4812
4813         * tui/tui-win.c (tui_resize_all): Use delete.
4814         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4815         destructor.
4816         (tui_free_window): Don't declare.
4817         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4818         Update.
4819
4820 2019-06-25  Tom Tromey  <tom@tromey.com>
4821
4822         * tui/tui-data.h (struct tui_win_info): Add constructor.
4823         * tui/tui-data.c (tui_alloc_win_info): Use new.
4824         (tui_free_window): Use delete.
4825
4826 2019-06-22  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4829         declare.
4830         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4831
4832 2019-06-22  Tom Tromey  <tom@tromey.com>
4833
4834         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4835         declare.
4836         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4837
4838 2019-06-22  Tom de Vries  <tdevries@suse.de>
4839
4840         * dwarf2read.c (create_addrmap_from_aranges)
4841         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4842         instead of '%zu'.
4843
4844 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4845
4846         * dwarf2read.h (dwarf2_section_info_def): Remove.
4847         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4848         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4849         std::vector<dwarf2_section_info>.
4850         (struct dwo_file) <~dwo_file>: Remove.
4851         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4852         types field.
4853         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4854         (dwarf2_read_debug_names): Likewise.
4855         (create_debug_types_hash_table): Change parameter type to
4856         array_view, adjust code accordingly.
4857         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4858         (partial_die_info::fixup): Likewise.
4859         (determine_prefix): Likewise.
4860         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4861
4862 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4863
4864         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4865         gdb_bfd_ref_ptr.
4866         <~dwo_file>: Remove call to gdb_bfd_unref.
4867         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4868         gdb_bfd_ref_ptr::get.
4869
4870 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4871
4872         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4873         type to htab_up.
4874         * dwarf2read.c (struct dwo_file): Initialize fields.
4875         <~dwo_file>: New.
4876         (free_dwo_file): Remove, move content to ~dwo_file.
4877         (struct dwo_file_deleter): Remove.
4878         (dwo_file_up>: Remove custom deleter.
4879         (free_dwo_files): Remove.
4880         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4881         dwo_files.
4882         (process_skeletonless_type_units): Call unique_ptr::get.
4883         (allocate_dwo_file_hash_table): Add deleter to created hash
4884         table.  Change return type to htab_up.
4885         (lookup_dwo_file_slot): Don't memset dwo_file, call
4886         unique_ptr::get.
4887         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4888         (create_dwo_unit_in_dwp_v2): Likewise.
4889         (open_and_init_dwo_file): Likewise.
4890         (free_dwo_file_from_slot): Remove.
4891
4892 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4893
4894         * dwarf2read.h (struct dwarf2_section_info) <readin,
4895         is_virtual>: Change type to bool.
4896         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4897         true instead of 1.
4898
4899 2019-06-19  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-data.h (tui_init_content_element): Don't declare.
4902
4903 2019-06-19  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-data.h (tui_init_win_info): Don't declare.
4906
4907 2019-06-19  Tom de Vries  <tdevries@suse.de>
4908
4909         * dwarf2read.h (abstract_to_concrete): Change type to
4910         std::unordered_map<sect_offset, std::vector<sect_offset>,
4911         gdb::hash_enum<sect_offset>>.
4912
4913 2019-06-19  Tom Tromey  <tromey@adacore.com>
4914
4915         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4916         EVAL_AVOID_SIDE_EFFECTS specially.
4917
4918 2019-06-19  Tom Tromey  <tromey@adacore.com>
4919
4920         * source-cache.c (highlighter): New global.
4921         (source_cache::get_source_lines): Create a highlighter on demand.
4922
4923 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * defs.h (deprecated_interactive_hook): Delete declaration.
4926         * interps.c (clear_interpreter_hooks): Remove use of
4927         deprecated_interactive_hook.
4928         * top.c (deprecated_interactive_hook): Delete definition.
4929         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4930
4931 2019-06-18  Tom de Vries  <tdevries@suse.de>
4932
4933         PR gdb/24515
4934         * dwarf2read.h (abstract_to_concrete): Change type from
4935         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4936         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4937         * dwarf2read.c (read_variable): Update.
4938         (dwarf2_fetch_die_loc_sect_off): Update.
4939
4940 2019-06-17  Tom de Vries  <tdevries@suse.de>
4941
4942         PR gdb/24617
4943         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4944         accessing parent[parent_len - 1].
4945
4946 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4947
4948         PR gdb/24364
4949         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4950         call dtrace_process_dof with NULL dof.
4951
4952 2019-06-16  Tom de Vries  <tdevries@suse.de>
4953
4954         PR gdb/24445
4955         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4956
4957 2019-06-16  Tom Tromey  <tom@tromey.com>
4958
4959         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4960         (make_all_visible): Use address of member.
4961
4962 2019-06-16  Tom Tromey  <tom@tromey.com>
4963
4964         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4965         (tui_free_window, free_content, free_content_elements): Remove
4966         unnecessary cast.
4967         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4968         cast.
4969         * tui/tui-regs.c (tui_show_register_group)
4970         (tui_display_registers_from, tui_display_reg_element_at_line):
4971         Remove unnecessary cast.
4972
4973 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * linux-nat.c (normal_mask): Delete.
4976         (_initialize_linux_nat): Don't initialise normal_mask.
4977
4978 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4979
4980         PR gdb/24445
4981         * dwarf-index-write.h (write_psymtabs_to_index): Add
4982         dwz_basename parameter.
4983         * dwarf-index-write.c (write_gdbindex): Move file writing to
4984         write_gdbindex_1.  Change return type void.
4985         (assert_file_size): Move up, remove filename parameter.
4986         (write_gdbindex_1): New function.
4987         (write_debug_names): Change return type to void, call
4988         assert_file_size.
4989         (struct index_wip_file): New struct.
4990         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4991         file logic to index_wip_file.  Write index for dwz file if
4992         needed.
4993         (save_gdb_index_command): Pass basename of dwz file, if present.
4994         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4995         build-id of dwz file, if present.
4996         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4997         (dwarf2_get_dwz_file): Likewise.
4998         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4999         (dwarf2_get_dwz_file): Likewise.
5000
5001 2019-06-16  Tom Tromey  <tom@tromey.com>
5002
5003         * coffread.c (process_coff_symbol): Use xstrdup.
5004         * value.c (create_internalvar): Use xstrdup.
5005
5006 2019-06-16  Tom Tromey  <tom@tromey.com>
5007
5008         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5009         * breakpoint.c (stopin_command, stopat_command)
5010         (until_break_command, decode_location_default): Remove unnecessary
5011         cast.
5012         * utils.c (subset_compare): Remove unnecessary cast.
5013         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5014         cast.
5015         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5016         cast.
5017         * infcmd.c (path_command): Remove unnecessary cast.
5018         * coffread.c (decode_type): Remove unnecessary cast.
5019         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5020         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5021         * tui/tui-stack.c (tui_show_locator_content)
5022         (tui_show_frame_info): Remove unnecessary cast.
5023         * tui/tui-win.c (tui_scroll_forward_command)
5024         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5025         (parse_scrolling_args): Remove unnecessary cast.
5026         * tui/tui-data.c (init_win_info, tui_del_window)
5027         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5028         (free_content_elements): Remove unnecessary cast.
5029         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5030         unnecessary cast.
5031         * tui/tui-source.c (tui_set_source_content)
5032         (tui_vertical_source_scroll): Remove unnecessary cast.
5033         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5034         cast.
5035         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5036         * tui/tui-regs.c (tui_display_registers_from)
5037         (tui_display_register): Remove unnecessary cast.
5038         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5039         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5040         (make_visible): Remove unnecessary cast.
5041         * tui/tui-winsource.c (tui_erase_source_content)
5042         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5043         unnecessary cast.
5044         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5045         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5046         * stabsread.c (read_type, read_array_type, read_range_type):
5047         Remove unnecessary cast.
5048         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5049         (parse_symbol, parse_type, upgrade_type, parse_external)
5050         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5051         unnecessary cast.
5052         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5053
5054 2019-06-16  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-data.c (tui_alloc_generic_win_info)
5057         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5058         checks.
5059
5060 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5061             Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * f-typeprint.c (f_print_type): Don't return early for not
5064         associated or not allocated types.
5065         (f_type_print_varspec_suffix): Add print_rank parameter and print
5066         ranks of array types in case they dangling.
5067         (f_type_print_base): Add print_rank parameter.
5068
5069 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         * NEWS: Mention new MI commands.
5072         * break-catch-throw.c (enum exception_event_kind): Move to
5073         breakpoint.h.
5074         (print_mention_exception_catchpoint): Output text as a single
5075         message.
5076         (catch_exception_command_1): Rename to...
5077         (catch_exception_event): ...this, make non-static, update header
5078         command, and change some parameter types.
5079         (catch_catch_command): Update for changes to
5080         catch_exception_command_1.
5081         (catch_throw_command): Likewise.
5082         (catch_rethrow_command): Likewise.
5083         * breakpoint.c (enum exception_event_kind): Delete.
5084         * breakpoint.h (enum exception_event_kind): Moved here from
5085         break-catch-throw.c.
5086         (catch_exception_event): Declare.
5087         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5088         (mi_cmd_catch_throw): New function.
5089         (mi_cmd_catch_rethrow): New function.
5090         (mi_cmd_catch_catch): New function.
5091         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5092         'catch-catch' entries.
5093         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5094         (mi_cmd_catch_rethrow): Declare.
5095         (mi_cmd_catch_catch): Declare.
5096
5097 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * annotate.c (annotate_source_line): Change return type to void,
5100         update implementation to match.
5101         * annotate.h (annotate_source_line): Change return type to void,
5102         update header comment.
5103         * stack.c (print_frame_info): Don't change what frame information
5104         is printed based on whether annotations are on or not.
5105
5106 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5109         (annotate_source): Make static.
5110         (annotate_source_line): Moved from source.c and renamed from
5111         identify_source_line.  Update the return type.
5112         * annotate.h (annotate_source): Delete declaration.
5113         (annotate_source_line): Declaration moved from source.h, and
5114         renamed from identify_source_line.  Return type updated.
5115         * source.c (identify_source_line): Moved to annotate.c and renamed
5116         to annotate_source_line.
5117         (info_line_command): Remove check of annotation_level.
5118         * source.h (identify_source_line): Move declaration to annotate.h
5119         and rename to annotate_source_line.
5120         * stack.c: Add 'annotate.h' include.
5121         (print_frame_info): Remove check of annotation_level before
5122         calling annotate_source_line.
5123
5124 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * source-cache.c (source_cache::get_plain_source_lines): Use
5127         open_source_file_with_line_charpos instead of just
5128         open_source_file, remove call to find_source_lines.
5129         (source_cache::get_source_lines): Likewise.
5130         * source.c (find_source_lines): Make static.
5131         (get_filename_and_charpos): Renamed into...
5132         (open_source_file_with_line_charpos): ..this along with changes to
5133         return a scoped_fd, and some other minor clean ups.
5134         (identify_source_line): Use open_source_file_with_line_charpos.
5135         (search_command_helper): Use open_source_file_with_line_charpos
5136         instead of just open_source_file, remove call to
5137         find_source_lines.
5138         * source.h (open_source_file_with_line_charpos): Declare new
5139         function.
5140         (find_source_lines): Delete declaration.
5141
5142 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * source.c (get_filename_and_charpos): Remove fullname
5145         parameter.
5146         (identify_source_line): Update call to get_filename_and_charpos.
5147
5148 2019-06-14  Tom Tromey  <tromey@adacore.com>
5149
5150         PR gdb/24502:
5151         * ui-style.h (skip_ansi_escape): Update comment.
5152         * ui-file.h (class no_terminal_escape_file): New class.
5153         * ui-file.c (no_terminal_escape_file::write)
5154         (no_terminal_escape_file::puts): New methods.
5155         * cli/cli-logging.c (handle_redirections): Use
5156         no_terminal_escape_file.
5157
5158 2019-06-14  Tom Tromey  <tromey@adacore.com>
5159
5160         * NEWS: Move convenience variable news above Python news.
5161
5162 2019-06-14  Tom Tromey  <tom@tromey.com>
5163
5164         * gnulib: Move directory to top-level.
5165         * configure.ac: Don't configure gnulib.
5166         * configure: Rebuild.
5167         * common/common-defs.h: Use new path to gnulib.
5168         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5169         (GNULIB_H): Remove.
5170         (INCGNU): Look in new gnulib location.
5171         (HFILES_NO_SRCDIR): Remove gnulib files.
5172         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5173         (generated_files): Remove GNULIB_H.
5174         ($(LIBGNU), all-lib): Remove targets.
5175         (distclean): Don't mention GNULIB_BUILDDIR.
5176         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5177
5178 2019-06-14  Tom Tromey  <tromey@adacore.com>
5179
5180         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5181         Warn if symbol file does not provide any symbols.
5182
5183 2019-06-14  Tom Tromey  <tromey@adacore.com>
5184
5185         * source.c (find_and_open_source): Respect basenames_may_differ.
5186
5187 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5188
5189         * annotate.c (annotate_breakpoints_invalid): Make use of
5190         scoped_restore_terminal_state.
5191         (annotate_frames_invalid): Likewise.
5192
5193 2019-06-14  Tom Tromey  <tromey@adacore.com>
5194
5195         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5196         allow assignment to an internalvar.
5197
5198 2019-06-14  Tom Tromey  <tromey@adacore.com>
5199
5200         * ada-lex.l: Allow "_" in attribute names.
5201
5202 2019-06-14  Tom Tromey  <tromey@adacore.com>
5203
5204         PR gdb/24653:
5205         * regcache.c (registers_changed): Don't call alloca.
5206         * top.c (execute_command): Don't call alloca.
5207
5208 2019-06-13  Pedro Alves  <palves@redhat.com>
5209
5210         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5211         'expression'.  When parsing an expression, error out if there's
5212         junk after "unlimited".
5213         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5214         (do_set_command): Adjust calls to is_unlimited_literal.
5215
5216 2019-06-13  Pedro Alves  <palves@redhat.com>
5217
5218         * compile/compile.c (make_compile_options_def_group): Add braces
5219         around array_view initializer.
5220         * thread.c (make_thread_apply_all_options_def_group)
5221         (make_thread_apply_all_options_def_group): Likewise.
5222
5223 2019-06-13  Pedro Alves  <palves@redhat.com>
5224
5225         * NEWS (New commands): Mention "maint test-options
5226         require-delimiter", "maint test-options unknown-is-error", "maint
5227         test-options unknown-is-operand" and "maint show
5228         test-options-completion-result".
5229         (New command options, command completion): New section.
5230         (Completion improvements): New section.
5231         Mention that you can abbreviate "unlimited".
5232
5233 2019-06-13  Pedro Alves  <palves@redhat.com>
5234
5235         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5236         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5237         * unittests/cli-utils-selftests.c (test_parse_flags)
5238         (test_parse_flags_qcs): Delete.
5239         (test_cli_utils): Don't call deleted functions.
5240
5241 2019-06-13  Pedro Alves  <palves@redhat.com>
5242
5243         * thread.c: Include "cli/cli-option.h".
5244         (tp_array_compar_ascending): Global.
5245         (tp_array_compar): Delete function.
5246         (tp_array_compar_ascending, tp_array_compar_descending): New
5247         functions.
5248         (ascending_option_def, qcs_flag_option_def)
5249         (thr_qcs_flags_option_defs)
5250         (make_thread_apply_all_options_def_group)
5251         (make_thread_apply_options_def_group): New.
5252         (thread_apply_all_command): Use gdb::option::process_options.
5253         (thread_apply_command_completer)
5254         (thread_apply_all_command_completer): New.
5255         (thread_apply_command): Use gdb::option::process_options.
5256         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5257         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5258         to generate help text of "thread apply".  Adjust "taas"'s help.
5259         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5260         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5261
5262 2019-06-13  Pedro Alves  <palves@redhat.com>
5263
5264         * thread.c (thread_apply_command): Check for invalid TID with
5265         isdigit instead of !isalpha.
5266
5267 2019-06-13  Pedro Alves  <palves@redhat.com>
5268
5269         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5270         (validate_flags_qcs): New.
5271         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5272         (validate_flags_qcs): Declare.
5273         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5274         (make_frame_apply_options_def_group): New.
5275         (frame_apply_command_count): Process options with
5276         gdb::option::process_options.
5277         (frame_apply_completer): New.
5278         (frame_apply_level_completer, frame_apply_all_completer)
5279         (frame_apply_completer): New.
5280         (_initialize_stack): Update help of "frame apply", "frame apply
5281         level", "frame apply all" and "faas" to mention supported options
5282         and install command completers.
5283         * stack.h (frame_apply_all_completer): Declare.
5284         * thread.c: Include "stack.h".
5285         (tfaas_command): Add "--".
5286         (_initialize_thread): Update help "tfaas" to mention supported
5287         options and install command completer.
5288
5289 2019-06-13  Pedro Alves  <palves@redhat.com>
5290
5291         * completer.c (complete_nested_command_line): New.
5292         (gdb_completion_word_break_characters_throw): Add assertion.
5293         * completer.h (complete_nested_command_line): Declare.
5294
5295 2019-06-13  Pedro Alves  <palves@redhat.com>
5296
5297         * stack.c (parse_backtrace_qualifiers): New.
5298         (backtrace_command): Use it.
5299         (backtrace_command_completer): Complete on qualifiers.
5300
5301 2019-06-13  Pedro Alves  <palves@redhat.com>
5302
5303         * frame.c: Include "cli/cli-option.h.
5304         (user_set_backtrace_options): New.
5305         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5306         Delete.
5307         (get_prev_frame): Adjust.
5308         (boolean_option_def, uinteger_option_def)
5309         (set_backtrace_option_defs): New.
5310         (_initialize_frame): Adjust and use
5311         gdb::option::add_setshow_cmds_for_options to install "set
5312         backtrace past-main" and "set backtrace past-entry".
5313         * frame.h: Include "cli/cli-option.h".
5314         (struct frame_print_options): Forward declare.
5315         (print_frame_arguments_all, print_frame_arguments_scalars)
5316         (print_frame_arguments_none): Declare.
5317         (print_entry_values): Delete declaration.
5318         (struct frame_print_options, user_frame_print_options): New.
5319         (struct set_backtrace_options): New.
5320         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5321         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5322         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5323         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5324         (list_args_or_locals): Add frame_print_options parameter.
5325         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5326         * python/py-framefilter.c (enumerate_args): Pass down
5327         USER_FRAME_PRINT_OPTIONS.
5328         * stack.c: Include "cli/cli-option.h".
5329         (print_frame_arguments_all, print_frame_arguments_scalars)
5330         (print_frame_arguments_none): Declare.
5331         (print_raw_frame_arguments, print_entry_values): Delete.
5332         (user_frame_print_options): New.
5333         (boolean_option_def, enum_option_def, frame_print_option_defs):
5334         New.
5335         (struct backtrace_cmd_options): New.
5336         (bt_flag_option_def): New.
5337         (backtrace_command_option_defs): New.
5338         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5339         (print_frame_arg, read_frame_arg, print_frame_args)
5340         (print_frame_info, print_frame): Add frame_print_options parameter
5341         and use it.
5342         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5343         (backtrace_command_1): Add frame_print_options and
5344         backtrace_cmd_options parameters and use them.
5345         (make_backtrace_options_def_group): New.
5346         (backtrace_command): Process command options with
5347         gdb::option::process_options.
5348         (backtrace_command_completer): New.
5349         (_initialize_stack): Extend "backtrace"'s help to mention
5350         supported options.  Install completer for "backtrace".
5351         Install some settings commands with add_setshow_cmds_for_options.
5352
5353 2019-06-13  Pedro Alves  <palves@redhat.com>
5354
5355         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5356         and that "set/show print raw frame-arguments" are now deprecated.
5357
5358         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5359         command.
5360         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5361         * stack.c (_initialize_stack): Install "set/show print
5362         raw-frame-arguments", and deprecate "set/show print raw
5363         frame-arguments".
5364         * valprint.c (_initialize_valprint): Deprecate "set/show print
5365         raw".
5366
5367 2019-06-13  Pedro Alves  <palves@redhat.com>
5368
5369         * compile/compile.c (struct compile_options): New.
5370         (compile_flag_option_def, compile_command_option_defs)
5371         (make_compile_options_def_group): New.
5372         (compile_file_command): Handle options with
5373         gdb::option::process_options.
5374         (compile_file_command_completer): New function.
5375         (compile_code_command): Handle options with
5376         gdb::option::process_options.
5377         (compile_code_command_completer): New function.
5378         (_initialize_compiler): Install completers for "compile code" and
5379         "compile file".  Mention available options in "compile code" and
5380         "compile code"'s help.
5381         * completer.c (advance_to_completion_word): New, factored out from
5382         ...
5383         (advance_to_expression_complete_word_point): ... this.
5384         (advance_to_filename_complete_word_point): New.
5385         * completer.h (advance_to_filename_complete_word_point): New
5386         declaration.
5387
5388 2019-06-13  Pedro Alves  <palves@redhat.com>
5389
5390         * compile/compile.c: Include "cli/cli-option.h".
5391         (compile_print_value): Scope data pointer is now a
5392         value_print_options pointer; adjust.
5393         (compile_print_command): Process options.  Scope data pointer is
5394         now a value_print_options pointer; adjust.
5395         (_initialize_compile): Update "compile print"'s help to include
5396         supported options.  Install a completer for "compile print".
5397         * cp-valprint.c (show_vtblprint, show_objectprint)
5398         (show_static_field_print): Delete.
5399         (_initialize_cp_valprint): Don't install "set print
5400         static-members", "set print vtbl", "set print object" here.
5401         * printcmd.c: Include "cli/cli-option.h" and
5402         "common/gdb_optional.h".
5403         (print_command_parse_format): Rework to fill in a
5404         value_print_options instead of a format_data.
5405         (print_value): Change parameter type from format_data pointer to
5406         value_print_options reference.  Adjust.
5407         (print_command_1): Process options.  Adjust to pass down a
5408         value_print_options.
5409         (print_command_completer): New.
5410         (_initialize_printcmd): Install print_command_completer as
5411         handle_brkchars completer for the "print" command.  Update
5412         "print"'s help to include supported options.
5413         * valprint.c: Include "cli/cli-option.h".
5414         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5415         here from cp-valprint.c.
5416         (boolean_option_def, uinteger_option_def)
5417         (value_print_option_defs, make_value_print_options_def_group):
5418         New.  Use gdb::option::add_setshow_cmds_for_options to install
5419         "set print elements", "set print null-stop", "set print repeats",
5420         "set print pretty", "set print union", "set print array", "set
5421         print address", "set print symbol", "set print array-indexes".
5422         * valprint.h: Include <string> and "cli/cli-option.h".
5423         (make_value_print_options_def_group): Declare.
5424         (print_value): Change parameter type from format_data pointer to
5425         value_print_options reference.
5426         (print_command_completer): Declare.
5427
5428 2019-06-13  Pedro Alves  <palves@redhat.com>
5429
5430         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5431         (COMMON_SFILES): Add maint-test-settings.c.
5432         * cli/cli-decode.c (boolean_enums): New global, factored out from
5433         ...
5434         (add_setshow_boolean_cmd): ... here.
5435         * cli/cli-decode.h (boolean_enums): Declare.
5436         * cli/cli-option.c: New file.
5437         * cli/cli-option.h: New file.
5438         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5439         factored out from ...
5440         (parse_cli_boolean_value(const char *)): ... this.
5441         (is_unlimited_literal): Change parameter type to pointer to
5442         pointer.  Adjust and advance ARG pointer.
5443         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5444         (parse_cli_var_enum): New, factored out from ...
5445         (do_set_command): ... this.  Adjust.
5446         * cli/cli-setshow.h (parse_cli_boolean_value)
5447         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5448         (parse_cli_var_enum): Declare.
5449         * cli/cli-utils.c: Include "cli/cli-option.h".
5450         (get_ulongest): New.
5451         * cli/cli-utils.h (get_ulongest): Declare.
5452         (check_for_argument): New overloads.
5453         * maint-test-options.c: New file.
5454
5455 2019-06-13  Pedro Alves  <palves@redhat.com>
5456
5457         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5458         parse a range if "-" is at the end of the string.
5459
5460 2019-06-13  Pedro Alves  <palves@redhat.com>
5461
5462         * cli/cli-setshow.c (parse_auto_binary_operation)
5463         (parse_cli_boolean_value): Don't allow "o".
5464
5465 2019-06-13  Pedro Alves  <palves@redhat.com>
5466
5467         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5468         * NEWS: Mention maint test-settings KIND.
5469         * maint-test-settings.c: New file.
5470
5471 2019-06-13  Pedro Alves  <palves@redhat.com>
5472
5473         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5474         completer.
5475         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5476         "set" completers.
5477
5478 2019-06-13  Pedro Alves  <palves@redhat.com>
5479
5480         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5481         after item.
5482
5483 2019-06-13  Pedro Alves  <palves@redhat.com>
5484
5485         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5486
5487 2019-06-13  Pedro Alves <palves@redhat.com>
5488
5489         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5490         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5491         call.
5492         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5493         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5494         calls.
5495         (check_for_argument): Skip spaces after argument.
5496
5497 2019-06-13  Pedro Alves  <palves@redhat.com>
5498
5499         * thread.c (thread_apply_command): Adjust TID parsing.
5500         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5501         detected before end of string.
5502         (tid_is_in_list): Error out if LIST is invalid.
5503
5504 2019-06-13  Pedro Alves  <palves@redhat.com>
5505
5506         * completer.c (complete_line_internal_1): Rewind completion word
5507         point.
5508         (completion_tracker::advance_custom_word_point_by): Change
5509         parameter type to int.
5510         * completer.h (completion_tracker::advance_custom_word_point_by):
5511         Likewise.
5512
5513 2019-06-13  Pedro Alves  <palves@redhat.com>
5514
5515         * completer.c (advance_to_completion_word): Handle delimiters.
5516
5517 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5518
5519         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5520
5521 2019-06-11  Tom Tromey  <tom@tromey.com>
5522
5523         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5524         (xmalloc_failed): Move to alloc.c.
5525         * alloc.c: New file.
5526         * Makefile.in (COMMON_SFILES): Add alloc.c.
5527
5528 2019-06-11  Tom Tromey  <tom@tromey.com>
5529
5530         * nat/linux-waitpid.c: Don't include server.h.
5531         (linux_debug): Remove.
5532         (my_waitpid): Update.
5533
5534 2019-06-11  Tom Tromey  <tromey@adacore.com>
5535
5536         * infcall.c (_initialize_infcall): Remove trailing newline from
5537         help.
5538         * user-regs.c (_initialize_user_regs): Remove trailing newline
5539         from help.
5540         * typeprint.c (_initialize_typeprint): Remove trailing newline
5541         from help.
5542         * reverse.c (_initialize_reverse): Remove trailing newlines from
5543         help.
5544         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5545         from help.
5546         * language.c (add_set_language_command): Remove trailing newline
5547         from help.
5548         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5549         help.
5550         * disasm.c (_initialize_disasm): Remove trailing newline from
5551         help.
5552         * top.c (init_main): Remove trailing newline from help.
5553         * interps.c (_initialize_interpreter): Remove trailing newline
5554         from help.
5555         * btrace.c (_initialize_btrace): Remove trailing newlines from
5556         help.
5557         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5558         from help.
5559         * python/python.c (_initialize_python): Remove trailing newline
5560         from help.
5561         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5562         help.
5563         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5564         from help.  Reformat some text.
5565         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5566         from help.
5567         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5568         newline from help.
5569
5570 2019-06-11  Tom Tromey  <tromey@adacore.com>
5571
5572         * darwin-nat.c (darwin_decode_exception_message)
5573         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5574
5575 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5576
5577         * valops.c (value_slice): Check for not allocated or not
5578         associated values.
5579
5580 2019-06-10  Tom de Vries  <tdevries@suse.de>
5581
5582         PR gdb/24618
5583         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5584         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5585         invalid.
5586
5587 2019-06-10  Tom de Vries  <tdevries@suse.de>
5588
5589         PR gdb/24611
5590         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5591         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5592
5593 2019-06-10  Tom de Vries  <tdevries@suse.de>
5594
5595         PR symtab/24545
5596         * symtab.c (struct demangled_name_entry): Add language field.
5597         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5598         static minimal symbol".  Set and use language field.
5599
5600 2019-06-10  Tom Tromey  <tromey@adacore.com>
5601
5602         * ada-lang.c (_initialize_ada_language): Update help text.
5603
5604 2019-06-10  Tom Tromey  <tromey@adacore.com>
5605
5606         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5607         with a newline.
5608         * guile/guile.c (handle_boot_error): Don't end warning with a
5609         newline.
5610         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5611         warning with a newline.
5612         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5613         newline.
5614         (s12z_frame_cache): Likewise.
5615         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5616         a newline.
5617         * solib-svr4.c (disable_probes_interface): Don't end warning with
5618         a newline.
5619         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5620         newline.
5621         * python/python.c (do_finish_initialization): Don't end warning
5622         with a newline.
5623
5624 2019-06-10  Tom Tromey  <tom@tromey.com>
5625
5626         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5627         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5628         gdbpy_enter.
5629
5630 2019-06-10  Tom Tromey  <tromey@adacore.com>
5631
5632         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5633         data.
5634         (elf_new_init): Don't call stabsread_new_init.
5635         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5636         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5637         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5638
5639 2019-06-10  Tom de Vries  <tdevries@suse.de>
5640
5641         PR symtab/16264
5642         PR symtab/24517
5643         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5644
5645 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5646
5647         * source.c (find_and_open_source): Also rewrite relative file
5648         names.
5649
5650 2019-04-26  Amos Bird  <amosbird@gmail.com>
5651
5652         * annotate.c (annotate_thread_exited): Add "thread-exited"
5653         annotation.
5654
5655 2019-06-06  Tom Tromey  <tromey@adacore.com>
5656
5657         * maint.h (class scoped_command_stats): Use
5658         DISABLE_COPY_AND_ASSIGN.
5659         <print_time>: New method.
5660         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5661         print_time.
5662         (scoped_command_stats::print_time): New method.
5663
5664 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5665
5666         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5667         instructions of lengths 6 or 8 bytes.
5668
5669 2019-06-04  Pedro Alves  <palves@redhat.com>
5670
5671         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5672
5673         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5674         * breakpoint.c (condition_completer): Likewise.
5675         * cli/cli-dump.c (scan_expression): Likewise.
5676         * common/filestuff.c (mkdir_recursive): Likewise.
5677         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5678         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5679         (gdb_abspath): Likewise.
5680         * compile/compile-cplus-types.c
5681         (compile_cplus_instance::decl_name): Likewise.
5682         * completer.c (complete_explicit_location):
5683         (signal_completer, reg_or_group_completer_1): Likewise.
5684         * cp-support.c (cp_remove_params_if_any): Likewise.
5685         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5686         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5687         * infcmd.c (strip_bg_char): Likewise.
5688         * linespec.c (copy_token_string): Likewise.
5689         * mi/mi-main.c (output_cores): Likewise.
5690         * psymtab.c (psymtab_search_name):
5691         * symfile.c (test_set_ext_lang_command): Likewise.
5692         * target.c (target_fileio_read_stralloc): Likewise.
5693         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5694         * value.c (complete_internalvar): Likewise.
5695
5696 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5697
5698         Add objfile property to gdb.Type.
5699         * NEWS: Mention Python API addition.
5700         * python/py-type.c (typy_get_objfile): New method.
5701
5702 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5703
5704         * NEWS: Mention the new set|show style [title|highlight].
5705         Mention changes to "show style", "help" and "apropos".
5706
5707 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5708
5709         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5710         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5711         instead of print_help_for_command.
5712         (print_doc_of_command): New function.
5713         (help_list): Add 'apropos -v word' suggestion.
5714         (print_help_for_command): Style the command name using title style.
5715         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5716         (_initialize_cli_cmds): Describe -v in apropos_command help.
5717
5718 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5719
5720         * cli/cli-style.h (cli_style_option): Add name in constructor,
5721         add m_name class member, add constructor with intensity,
5722         add name class function.
5723         (cli_style_option::add_setshow_commands): Remove name argument.
5724         (highlight_style, title_style): New styles.
5725         * cli/cli-style.c (do_show): New function that shows a style
5726         characteristic styling the style name with itself.
5727         (set_style_name): New function.
5728         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5729         Update all callers according to the changes in cli/cli-style.h.
5730         * utils.h (fputs_highlighted): New function.
5731         * utils.c (fputs_highlighted): Likewise.
5732
5733 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5734
5735         * NEWS: Mention new pipe command and new convenience variables.
5736
5737 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5738
5739         * cli/cli-cmds.c (pipe_command): New function.
5740         (_initialize_cli_cmds): Call add_com for pipe_command.
5741         Define | as an alias for pipe.
5742         (exit_status_set_internal_vars): New function.
5743         (shell_escape): Call exit_status_set_internal_vars.
5744         cli/cli-decode.c (find_command_name_length): Recognize | as
5745         a single character command.
5746
5747 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5748
5749         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5750         top.c (execute_command_to_ui_file): New function, mostly a copy
5751         of execute_command_to_string.
5752         (execute_command_to_string): Implement by calling
5753         execute_command_to_ui_file.
5754
5755 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5756
5757         * top.h (saved_command_line): Remove declaration.
5758         * top.c (previous_saved_command_line, previous_repeat_arguments):
5759         New variables.
5760         (saved_command_line): Make static, define together with other
5761         'repeat variables'.
5762         (dont_repeat): Clear repeat_arguments.
5763         (repeat_previous, get_saved_command_line, save_command_line):
5764         New functions.
5765         (gdb_init): Initialize saved_command_line
5766         and previous_saved_command_line.
5767         * main.c (captured_main_1): Remove saved_command_line initialization.
5768         * event-top.c (handle_line_of_input): Update to use
5769         the new 'repeat' related functions instead of direct access to
5770         saved_command_line.
5771         * command.h (repeat_previous, get_saved_command_line,
5772         save_command_line): New declarations.
5773         (dont_repeat): Add comment.
5774
5775 2019-05-30  Tom Tromey  <tromey@adacore.com>
5776
5777         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5778         Fix comment.
5779         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5780
5781 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5782
5783         PR cli/24587
5784         * completer.c (complete): Initialize variable word.
5785
5786 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5787
5788         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5789         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5790         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5791         'body' is NULL to the outter 'if', protecting the '!is_define'
5792         situation as well.
5793
5794 2019-05-29  Tom Tromey  <tromey@adacore.com>
5795
5796         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5797         (dwarf_unknown): New function.
5798         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5799         (dwarf_type_encoding_name): Use dwarf_unknown.
5800
5801 2019-05-29  Tom Tromey  <tromey@adacore.com>
5802
5803         PR c++/20020:
5804         * cp-valprint.c (cp_print_value_fields): Call
5805         cp_print_static_field inside "try".
5806
5807 2019-05-29  Tom Tromey  <tromey@adacore.com>
5808
5809         * inflow.c (struct terminal_info): Add default operator=.
5810         * configure: Rebuild.
5811         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5812         -Wdeprecated-copy-dtor, -Wredundant-move.
5813
5814 2019-05-29  Tom Tromey  <tromey@adacore.com>
5815
5816         * NEWS: Add entry.
5817         * infcmd.c (print_return_value_1): Handle finish_print
5818         option.
5819         (show_print_finish): New function.
5820         (_initialize_infcmd): Add "set/show print finish" commands.
5821         * valprint.c (user_print_options): Initialize new member.
5822         * valprint.h (struct value_print_options) <finish_print>: New
5823         member.
5824
5825 2019-05-28  Tom Tromey  <tromey@adacore.com>
5826
5827         * ada-lang.c (ada_remove_Xbn_suffix)
5828         (find_old_style_renaming_symbol)
5829         (parse_old_style_renaming): Remove.
5830         (ada_find_renaming_symbol): Don't call
5831         find_old_style_renaming_symbol.
5832         (ada_is_renaming_symbol): Rename from
5833         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5834         bool.  Now static.
5835         (ada_read_var_value): Update and simplify.
5836         * ada-exp.y (write_var_or_type): Remove old code.
5837
5838 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5839
5840         * event-top.c: Remove include comment.
5841         * inflow.c (class scoped_ignore_sigttou): Move from here...
5842         * inflow.h (class scoped_ignore_sigttou): ...to here.
5843         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5844         * top.c:  Remove include comment.
5845
5846 2019-05-27  Tom Tromey  <tom@tromey.com>
5847
5848         * NEWS: Fix typo.
5849
5850 2019-05-22  Tom Tromey  <tromey@adacore.com>
5851
5852         * target.c (target_follow_exec): Constify parameter.
5853         * target-delegates.c: Rebuild.
5854         * remote.c (remote_target::follow_exec): Constify parameter.
5855         * infrun.c (follow_exec): Constify parameter.
5856         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5857         (target_follow_exec): Likewise.
5858
5859 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5860
5861         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5862         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5863
5864 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5865
5866         * NEWS: Add debugredirect and testsuite sections.
5867
5868 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5869
5870         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5871         target descriptions using exclusively floating point register name
5872         aliases.
5873
5874 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         PR gdb/18644:
5877         * f-lang.c (build_fortran_types): Handle the case where
5878         gdbarch_floatformat_for_type returns a nullptr.
5879
5880 2019-05-21  Tom de Vries  <tdevries@suse.de>
5881
5882         PR cli/24587
5883         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5884
5885 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5886
5887         PR gdb/18644:
5888         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5889         16-byte floats.
5890         * i386-tdep.c (i386_floatformat_for_type): Use
5891         floatformats_ia64_quad for the 16-byte floating point component
5892         within a fortran 32-byte complex number.
5893
5894 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5897         delete default constructor.
5898         (find_partial_die): Update to return const struct.
5899         (partial_die_parent_scope): Move variable declaration into scope
5900         of its use and change its type to auto.
5901         (guess_partial_die_structure_name): Likewise.
5902         (partial_die_info::fixup): Likewise.
5903
5904 2019-05-17  Tom Tromey  <tromey@adacore.com>
5905
5906         * source.c (find_and_open_source): Remove cast.
5907
5908 2019-05-17  Tom Tromey  <tromey@adacore.com>
5909
5910         * annotate.c (annotate_source): Make "filename" const.
5911         * annotate.h (annotate_source): Use const.
5912
5913 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5914
5915         * disasm.c (set_disassembler_options): Send errors to stderr.
5916
5917 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5918
5919         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5920         (cli_interp_base::set_logging): Check debug_redirect.
5921         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5922         * cli/cli-logging.c (debug_redirect): Add static variable.
5923         (pop_output_files): Add default param.
5924         (handle_redirections): Print debug setting.
5925         (show_logging_command): Likewise.
5926         (_initialize_cli_logging): Add debugredirect command.
5927         * interps.c (current_interp_set_logging): Add debug_redirect
5928         parameter.
5929         * interps.h (set_logging): Add debug_redirect parameter.
5930         (current_interp_set_logging): Likewise.
5931         * mi/mi-common.h: Likewise.
5932         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5933
5934 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5935             Tom Tromey  <tromey@adacore.com>
5936
5937         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5938         directly.
5939         * cli/cli-interp.h (make_logging_output): Remove declaration.
5940         * cli/cli-logging.c (make_logging_output): Remove function.
5941         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5942         directly.
5943         * ui-file.c (tee_file::tee_file): Remove bools.
5944         (tee_file::~tee_file): Remove deletes.
5945         * ui-file.h (tee_file): Remove bools.
5946
5947 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5948
5949         * mi/mi-cmds.h (mi_cmd_complete): New function.
5950         * mi/mi-main.c (mi_cmd_complete): Likewise.
5951         * mi/mi-cmds.c: Define new MI command -complete.
5952         * NEWS: Mention new -complete command.
5953
5954 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5955
5956         * completer.h (complete): New function.
5957         * completer.c (complete): Likewise.
5958         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5959         function defined in completer.h.
5960
5961 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5962
5963         * MAINTAINERS (Write After Approval): Add myself.
5964
5965 2019-05-17  Tom de Vries  <tdevries@suse.de>
5966
5967         PR gdb/24094
5968         * dwarf2read.c (struct cu_partial_die_info): New struct.
5969         (find_partial_die): Return cu_partial_die_info.
5970         (partial_die_parent_scope, guess_partial_die_structure_name)
5971         (partial_die_info::fixup): Handle new return type of find_partial_die.
5972
5973 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5974
5975         PR breakpoints/24541
5976         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5977         "std::string", simplifying the algorithm.
5978
5979 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5980
5981         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5982         (stap_static_probe_ops::get_probes): Likewise.
5983
5984 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5985
5986         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5987         '-')" and "else if".
5988         (stap_parse_single_operand): Join checks for
5989         "gdbarch_stap_parse_special_token_p" and
5990         "gdbarch_stap_parse_special_token" in the same "if" statement.
5991         Invert check when verifying for operation on register
5992         displacement.
5993
5994 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5995
5996         * stap-probe.c (stap_get_opcode): Update comment.
5997         (stap_get_expected_argument_type): Likewise.
5998         (handle_stap_probe): Likewise.
5999
6000 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6001
6002         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6003         return type to 'bool'.  Adjust comment.  Use 'bool' when
6004         appropriate.
6005         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6006         * stap-probe.c (stap_parse_argument_1): Likewise.
6007         (stap_is_operator): Likewise.
6008         (stap_is_generic_prefix): Likewise.
6009         (stap_is_register_prefix): Likewise.
6010         (stap_is_register_indirection_prefix): Likewise.
6011         (stap_is_integer_prefix): Likewise.
6012         (stap_generic_check_suffix): Likewise.
6013         (stap_check_integer_suffix): Likewise.
6014         (stap_check_register_suffix): Likewise.
6015         (stap_check_register_indirection_suffix): Likewise.
6016         (stap_parse_register_operand): Likewise.
6017         (stap_parse_single_operand): Likewise.
6018         (stap_parse_argument_1): Likewise.
6019         (stap_probe::get_argument_count): Likewise.
6020         (stap_is_operator): Likewise.
6021
6022 2019-05-16  Tom Tromey  <tromey@adacore.com>
6023
6024         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6025         keyword to foreach.
6026
6027 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6028
6029         * linux-thread-db.c (try_thread_db_load_1): Change return type
6030         to bool.
6031         (try_thread_db_load): Likewise.
6032         (try_thread_db_load_from_pdir_1): Likewise.
6033         (try_thread_db_load_from_pdir): Likewise.
6034         (try_thread_db_load_from_sdir): Likewise.
6035         (try_thread_db_load_from_dir): Likewise.
6036         (thread_db_load_search): Likewise.
6037         (has_libpthread): Likewise.
6038         (thread_db_load): Likewise.
6039
6040 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6041
6042         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6043         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6044         NULL, and complain/return if that's the case.
6045
6046 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6047
6048         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6049         (advance, posn, abstract_read_memory): New functions.
6050         [struct mem_read_abstraction]: New struct.
6051         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6052
6053 2019-05-14  Tom Tromey  <tromey@adacore.com>
6054
6055         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6056         value is not lval_memory.
6057
6058 2019-05-14  Tom Tromey  <tromey@adacore.com>
6059
6060         * solib.c (info_sharedlibrary_command): Style the file name.
6061
6062 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6063
6064         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6065         (aarch64_vnv_type): Likewise.
6066         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6067         * common/tdesc.c: Likewise.
6068         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6069         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6070         * features/aarch64-fpu.xml: Add ieee half view.
6071         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6072         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6073         * gdbtypes.h (struct builtin_type): Likewise.
6074         (struct objfile_type): Likewise.
6075
6076 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6077
6078         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6079         typo.
6080         * location.h (string_to_event_location): Likewise.
6081
6082 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6083
6084         GDB 8.3 released.
6085
6086 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6087
6088         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6089         New variable declaration.
6090         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6091         New variable.
6092         (print_one_breakpoint): Use ui_out::test_flags and new global
6093         variable to compute use_fixed_output.
6094         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6095         Remove.
6096         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6097         (mi_multi_location_breakpoint_output_fixed): Remove.
6098         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6099         new variable.
6100         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6101         fix_multi_location_breakpoint_output flag if version >= 3.
6102         * ui-out.h (enum ui_out_flag)
6103         <fix_multi_location_breakpoint_output>: New enumerator.
6104
6105 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6106
6107         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6108
6109 2019-05-10  Tom Tromey  <tromey@adacore.com>
6110
6111         * ada-lang.c (catch_ada_completer): New function.
6112         (_initialize_ada_language): Use it.
6113
6114 2019-05-10  Tom Tromey  <tromey@adacore.com>
6115
6116         * thread.c (print_thread_info): Make "requested_threads" const.
6117         * gdbthread.h (print_thread_info): Make "requested_threads"
6118         const.
6119         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6120         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6121
6122 2019-05-08  Tom Tromey  <tom@tromey.com>
6123
6124         * gdbtypes.c (objfile_type_data): Change type.
6125         (objfile_type, _initialize_gdbtypes): Update.
6126
6127 2019-05-08  Tom Tromey  <tom@tromey.com>
6128
6129         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6130         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6131         (_initialize_dwarf2_frame): Update.
6132
6133 2019-05-08  Tom Tromey  <tom@tromey.com>
6134
6135         * objc-lang.c (objc_objfile_data): Change type.
6136         (find_methods): Update.
6137         (_initialize_objc_lang): Remove.
6138
6139 2019-05-08  Tom Tromey  <tom@tromey.com>
6140
6141         * stabsread.c (rs6000_builtin_type_data): Change type.
6142         (rs6000_builtin_type, _initialize_stabsread): Update.
6143
6144 2019-05-08  Tom Tromey  <tom@tromey.com>
6145
6146         * mips-tdep.c (mips_pdr_data): Remove.
6147         (_initialize_mips_tdep): Update.
6148
6149 2019-05-08  Tom Tromey  <tom@tromey.com>
6150
6151         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6152         (hppa_init_objfile_priv_data, read_unwind_info)
6153         (find_unwind_entry, _initialize_hppa_tdep): Update.
6154
6155 2019-05-08  Tom Tromey  <tom@tromey.com>
6156
6157         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6158         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6159         on obstack.
6160         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6161
6162 2019-05-08  Tom Tromey  <tom@tromey.com>
6163
6164         * mdebugread.c (basic_type_data): Change type.
6165         (basic_type, _initialize_mdebugread): Update.
6166
6167 2019-05-08  Tom Tromey  <tom@tromey.com>
6168
6169         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6170
6171 2019-05-08  Tom Tromey  <tom@tromey.com>
6172
6173         * nto-tdep.c (nto_inferior_data_reg): Change type.
6174         (nto_inferior_data): Update.
6175         (nto_inferior_data_cleanup, nto_new_inferior_data)
6176         (_initialize_nto_tdep): Remove.
6177         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6178
6179 2019-05-08  Tom Tromey  <tom@tromey.com>
6180
6181         * ada-lang.c (struct ada_inferior_data): Add initializers.
6182         (ada_inferior_data): Change type.
6183         (ada_inferior_data_cleanup): Remove.
6184         (get_ada_inferior_data, ada_inferior_exit)
6185         (struct ada_pspace_data): Add initializers, destructor.
6186         (ada_pspace_data_handle): Change type.
6187         (get_ada_pspace_data): Update.
6188         (ada_pspace_data_cleanup): Remove.
6189
6190 2019-05-08  Tom Tromey  <tom@tromey.com>
6191
6192         * coffread.c (struct coff_symfile_info): Add initializers.
6193         (coff_objfile_data_key): Move lower.  Change type.
6194         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6195         Update.
6196         (coff_free_info): Remove.
6197
6198 2019-05-08  Tom Tromey  <tom@tromey.com>
6199
6200         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6201         (fbsd_pspace_data_handle): Move lower.  Change type.
6202         (get_fbsd_pspace_data): Update.
6203         (fbsd_pspace_data_cleanup): Remove.
6204         (_initialize_fbsd_tdep): Update.
6205
6206 2019-05-08  Tom Tromey  <tom@tromey.com>
6207
6208         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6209         (get_ada_tasks_pspace_data): Update.
6210         (ada_tasks_pspace_data_cleanup): Remove.
6211         (_initialize_tasks): Update.
6212         (ada_tasks_inferior_data_handle): Change type.
6213         (get_ada_tasks_inferior_data): Update.
6214         (ada_tasks_inferior_data_cleanup): Remove.
6215         (struct ada_tasks_pspace_data): Add initializers.
6216
6217 2019-05-08  Tom Tromey  <tom@tromey.com>
6218
6219         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6220         * symfile-debug.c (debug_sym_get_probes): Change type.
6221         * stap-probe.c (handle_stap_probe):
6222         (stap_static_probe_ops::get_probes): Change type.
6223         * probe.h (class static_probe_ops) <get_probes>: Change type.
6224         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6225         (parse_probes_in_pspace): Update.
6226         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6227         Update.
6228         (any_static_probe_ops::get_probes): Change type.
6229         * elfread.c (elfread_data): New typedef.
6230         (probe_key): Change type.
6231         (elf_get_probes): Likewise.  Update.
6232         (probe_key_free): Remove.
6233         (_initialize_elfread): Update.
6234         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6235         Change type.
6236         (dtrace_process_dof_probe, dtrace_process_dof)
6237         (dtrace_static_probe_ops::get_probe): Change type.
6238
6239 2019-05-08  Tom Tromey  <tom@tromey.com>
6240
6241         * xcoffread.c (struct xcoff_symfile_info): Rename from
6242         coff_symfile_info.  Add initializers.
6243         (xcoff_objfile_data_key): Move lower.  Change type.
6244         (XCOFF_DATA): Rewrite.
6245         (xcoff_free_info): Remove.
6246         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6247         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6248         (xcoff_initial_scan): Update.
6249
6250 2019-05-08  Tom Tromey  <tom@tromey.com>
6251
6252         * solib-svr4.c (struct svr4_info): Add initializers and
6253         destructor.
6254         <probes_table>: Now an htab_up.
6255         (solib_svr4_pspace_data): Change type.
6256         (free_probes_table): Simplify.
6257         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6258         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6259         (probes_table_remove_objfile_probes, register_solib_event_probe)
6260         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6261         (_initialize_svr4_solib): Update.
6262
6263 2019-05-08  Tom Tromey  <tom@tromey.com>
6264
6265         * remote.c (remote_pspace_data): Change type.
6266         (remote_pspace_data_cleanup): Remove.
6267         (get_remote_exec_file, set_pspace_remote_exec_file)
6268         (_initialize_remote): Update.
6269
6270 2019-05-08  Tom Tromey  <tom@tromey.com>
6271
6272         * breakpoint.c (breakpoint_objfile_key): Change type.
6273         (get_breakpoint_objfile_data): Update.
6274         (free_breakpoint_objfile_data): Remove.
6275         (_initialize_breakpoint): Update.
6276
6277 2019-05-08  Tom Tromey  <tom@tromey.com>
6278
6279         * linux-tdep.c (struct linux_info): Add initializers.
6280         (linux_inferior_data): Move.  Change type.
6281         (invalidate_linux_cache_inf): Update.
6282         (linux_inferior_data_cleanup): Remove.
6283         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6284
6285 2019-05-08  Tom Tromey  <tom@tromey.com>
6286
6287         * auxv.c (auxv_inferior_data): Move.  Change type.
6288         (auxv_inferior_data_cleanup): Remove.
6289         (invalidate_auxv_cache_inf): Rewrite.
6290         (get_auxv_inferior_data, _initialize_auxv): Update.
6291
6292 2019-05-08  Tom Tromey  <tom@tromey.com>
6293
6294         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6295         (symfile_debug_objfile_data_key): Change type.
6296         (symfile_debug_installed, debug_qf_has_symbols)
6297         (debug_qf_find_last_source_symtab)
6298         (debug_qf_forget_cached_source_info)
6299         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6300         (debug_qf_print_stats, debug_qf_dump)
6301         (debug_qf_expand_symtabs_for_function)
6302         (debug_qf_expand_all_symtabs)
6303         (debug_qf_expand_symtabs_with_fullname)
6304         (debug_qf_map_matching_symbols)
6305         (debug_qf_expand_symtabs_matching)
6306         (debug_qf_find_pc_sect_compunit_symtab)
6307         (debug_qf_map_symbol_filenames)
6308         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6309         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6310         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6311         (debug_sym_read_linetable, debug_sym_relocate): Update.
6312         (symfile_debug_free_objfile): Remove.
6313         (install_symfile_debug_logging, _initialize_symfile_debug):
6314         Update.
6315
6316 2019-05-08  Tom Tromey  <tom@tromey.com>
6317
6318         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6319         allocate_on_obstack.
6320         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6321         (get_dwarf2_per_objfile): Update.
6322         (set_dwarf2_per_objfile): Remove.
6323         (dwarf2_has_info, dwarf2_get_section_info): Update.
6324         (dwarf2_free_objfile): Remove.
6325         (_initialize_dwarf2_read): Update.
6326
6327 2019-05-08  Tom Tromey  <tom@tromey.com>
6328
6329         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6330         initializers.
6331         <unsupported_script_warning_printed,
6332         script_not_found_warning_printed>: Now bool.
6333         (auto_load_pspace_data): Change type.
6334         (~auto_load_pspace_info): Rename from
6335         auto_load_pspace_data_cleanup.
6336         (get_auto_load_pspace_data, init_loaded_scripts_info)
6337         (clear_section_scripts, maybe_print_unsupported_script_warning)
6338         (maybe_print_script_not_found_warning, _initialize_auto_load):
6339         Update.
6340
6341 2019-05-08  Tom Tromey  <tom@tromey.com>
6342
6343         * objfiles.c (objfile_pspace_info): Add destructor and
6344         initializers.
6345         (objfiles_pspace_data): Change type.
6346         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6347         (get_objfile_pspace_data): Update.
6348         (objfiles_bfd_data): Change type.
6349         (get_objfile_bfd_data): Update.
6350         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6351
6352 2019-05-08  Tom Tromey  <tom@tromey.com>
6353
6354         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6355         Change type.
6356         (get_catch_syscall_inferior_data): Update.
6357         (catch_syscall_inferior_data_cleanup): Remove.
6358         (_initialize_break_catch_syscall): Update.
6359
6360 2019-05-08  Tom Tromey  <tom@tromey.com>
6361
6362         * inflow.c (struct terminal_info): Add destructor and
6363         initializers.
6364         (inflow_inferior_data): Change type.
6365         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6366         (get_inflow_inferior_data, inflow_inferior_exit)
6367         (swap_terminal_info, _initialize_inflow): Update.
6368
6369 2019-05-08  Tom Tromey  <tom@tromey.com>
6370
6371         * target-dcache.c (target_dcache_cleanup): Remove.
6372         (target_dcache_aspace_key): Change type.
6373         (target_dcache_init_p, target_dcache_invalidate)
6374         (target_dcache_get, target_dcache_get_or_init)
6375         (_initialize_target_dcache): Update.
6376         * dcache.h (struct dcache_deleter): New.
6377
6378 2019-05-08  Tom Tromey  <tom@tromey.com>
6379
6380         * symtab.c (struct symbol_cache): Add destructor and
6381         initializers.
6382         (symbol_cache_key): Move.  Change type.
6383         (make_symbol_cache, free_symbol_cache): Remove.
6384         (get_symbol_cache): Update.
6385         (symbol_cache_cleanup): Remove.
6386         (ALL_PSPACES, symbol_cache_flush)
6387         (maintenance_print_symbol_cache)
6388         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6389         Update.
6390
6391 2019-05-08  Tom Tromey  <tom@tromey.com>
6392
6393         * symtab.c (struct main_info): Add destructor and initializers.
6394         (main_progspace_key): Move.  Change type.
6395         (get_main_info): Update.
6396         (main_info_cleanup): Remove.
6397         (_initialize_symtab): Update.
6398
6399 2019-05-08  Tom Tromey  <tom@tromey.com>
6400
6401         * registry.h (DECLARE_REGISTRY): Define the _key class.
6402
6403 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * NEWS: Merge two 'New commands' sections.
6406
6407 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6408
6409         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6410         parameter and use Ada language definition instead.
6411         (ada_val_print_ptr): Remove unused language parameter.
6412         (ada_val_print_num): Remove language parameter and use Ada language
6413         definition instead.
6414         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6415         parameter.
6416         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6417         parameter and use Ada language definition instead.
6418         (ada_val_print_1): Update all ada_val_print_xxx calls.
6419         Remove language parameter.
6420         (ada_val_print): Update ada_val_print_1 call.
6421
6422 2019-05-08  Tom Tromey  <tromey@adacore.com>
6423
6424         * remote.c (remote_hw_watchpoint_limit)
6425         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6426         Now static.
6427
6428 2019-05-08  Tom Tromey  <tromey@adacore.com>
6429
6430         * maint.c (_initialize_maint_cmds): Move initialization code to
6431         remote.c.
6432         (watchdog, show_watchdog): Move to remote.c.
6433         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6434         "watchdog" static.
6435         (_initialize_remote): Move initialization code from maint.c.
6436         * defs.h (watchdog): Don't declare.
6437
6438 2019-05-08  Tom Tromey  <tromey@adacore.com>
6439
6440         * tui/tui-interp.c: Include main.h.
6441         * interps.c: Include main.h.
6442         * main.h (interpreter_p): Declare.
6443         * defs.h (interpreter_p): Don't declare.
6444
6445 2019-05-08  Tom Tromey  <tromey@adacore.com>
6446
6447         * dwarf2loc.c: Include dwarf2read.h.
6448         * defs.h (read_unsigned_leb128): Don't declare.
6449         * dwarf2read.h (read_unsigned_leb128): Declare.
6450
6451 2019-05-08  Tom Tromey  <tromey@adacore.com>
6452
6453         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6454         method.
6455
6456 2019-05-08  Tom Tromey  <tromey@adacore.com>
6457
6458         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6459         when no wrap column is set.
6460
6461 2019-05-08  Tom Tromey  <tromey@adacore.com>
6462
6463         * c-lang.c (c_get_string): Handle non-C-style arrays.
6464
6465 2019-05-08  Tom Tromey  <tromey@adacore.com>
6466
6467         * typeprint.c (print_offset_data::update): Print the bit offset,
6468         not the number of bits remaining.
6469
6470 2019-05-08  Tom Tromey  <tromey@adacore.com>
6471
6472         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6473         padding at end of comment.
6474
6475 2019-05-08  Tom Tromey  <tromey@adacore.com>
6476
6477         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6478         Compare main types.
6479
6480 2019-05-06  Tom Tromey  <tom@tromey.com>
6481
6482         * common/scoped_mmap.c: Include common-defs.h.
6483         * common/scoped_mmap.h: Don't include config.h.
6484
6485 2019-05-04  Tom Tromey  <tom@tromey.com>
6486
6487         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6488         (struct aarch64_call_info): Add initializers.
6489         <si>: Now a std::vector.
6490         (pass_on_stack, aarch64_push_dummy_call): Update.
6491
6492 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6493             Tom Tromey  <tom@tromey.com>
6494
6495         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6496         (ppc_threads): Now a std::vector.  Now static.
6497         (hwdebug_find_thread_points_by_tid)
6498         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6499         Update.
6500
6501 2019-05-04  Tom Tromey  <tom@tromey.com>
6502
6503         * arc-tdep.c (arc_tdesc_init): Return bool.
6504
6505 2019-05-04  Tom Tromey  <tom@tromey.com>
6506
6507         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6508         Use gdb_assert_not_reached.
6509
6510 2019-05-04  Tom Tromey  <tom@tromey.com>
6511
6512         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6513         "false".
6514
6515 2019-05-04  Tom Tromey  <tom@tromey.com>
6516
6517         * arc-tdep.c (arc_tdesc_init): Use bool.
6518
6519 2019-05-04  Tom Tromey  <tom@tromey.com>
6520
6521         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6522
6523 2019-05-04  Tom Tromey  <tom@tromey.com>
6524
6525         * cli/cli-cmds.c (valid_command_p): Return bool.
6526
6527 2019-05-04  Tom Tromey  <tom@tromey.com>
6528
6529         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6530         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6531
6532 2019-05-04  Raul Tambre  <raul@tambre.ee>
6533
6534         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6535         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6536         operator for comparison.
6537
6538 2019-05-04  Tom Tromey  <tom@tromey.com>
6539
6540         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6541         (lookup_partial_symbol, print_partial_symbols)
6542         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6543         (psymbol_compare): Update.
6544         (add_psymbol_to_bcache): Clear the entire psymbol.
6545         (maintenance_check_psymtabs): Update.
6546         * psympriv.h (struct partial_symbol): Don't derive from
6547         general_symbol_info.
6548         <obj_section, unrelocated_address, address,
6549         set_unrelocated_address>: Update.
6550         <ginfo>: New member.
6551         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6552         (debug_names::write_psymbols): Update.
6553
6554 2019-05-04  Tom de Vries  <tdevries@suse.de>
6555
6556         * contrib/cc-with-tweaks.sh: Support -n arg.
6557
6558 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6559
6560         * corelow.c (core_target::detach): Ensure frame cache and
6561         register caches are cleared.
6562         inferior.c (exit_inferior_1): Likewise.
6563
6564 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6565             Tom Tromey  <tom@tromey.com>
6566
6567         * dictionary.c (collate_pending_symbols_by_language): Remove
6568         "struct" from foreach.
6569         * symtab.c (lookup_global_symbol_from_objfile)
6570         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6571         foreach.
6572         * ser-tcp.c (net_open): Remove "struct" from foreach.
6573         * objfiles.c (objfile_relocate, objfile_rebase)
6574         (objfile_has_symbols): Remove "struct" from foreach.
6575         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6576         from foreach.
6577         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6578         foreach.
6579         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6580         "struct" from foreach.
6581         * ada-lang.c (create_excep_cond_exprs)
6582         (ada_exception_catchpoint_cond_string): Remove "struct" from
6583         foreach.
6584
6585 2019-05-03  Tom Tromey  <tromey@adacore.com>
6586
6587         * ada-exp.y (convert_char_literal): Check suffix of each
6588         enumerator.
6589
6590 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6591
6592         PR ada/21406:
6593         * ada-exp.y (yywrap): Don't define.
6594         * ada-lex.l (%option): Add noyywrap
6595         (yywrap): Remove.
6596
6597 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6598
6599         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6600         _WIN32_WINNT to the XP level, unless already defined to a higher
6601         level.
6602
6603         * unittests/parse-connection-spec-selftests.c:
6604         * ser-tcp.c:
6605         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6606         override.
6607
6608         * symfile.c (find_separate_debug_file): Remove colon from the
6609         drive spec of DOS/Windows file names of the target, so that the
6610         file name produced from DEBUGDIR and the target's directory will
6611         be valid on DOS/Windows systems.
6612
6613 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6614
6615         * rust-lang.c (val_print_struct): Handle printing structures
6616         containing strings.
6617
6618 2019-05-02  Tom Tromey  <tromey@adacore.com>
6619
6620         * valarith.c (_initialize_valarith): Remove.
6621
6622 2019-05-01  Tom Tromey  <tromey@adacore.com>
6623
6624         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6625         bitfields.
6626
6627 2019-05-01  Tom Tromey  <tromey@adacore.com>
6628
6629         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6630         for big-endian copies.
6631
6632 2019-04-30  Ali Tamur  <tamur@google.com>
6633         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6634         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6635         (read_3_bytes): New function.
6636
6637 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6638
6639         * windows-nat.c (main_thread_id): Delete.
6640         (handle_output_debug_string): Replace main_thread_id by
6641         current_event.dwThreadId.
6642         (fake_create_process): Likewise.
6643         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6644         Do not set main_thread_id.
6645         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6646         current_event.dwThreadId.
6647         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6648
6649 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6650
6651         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6652         Use current_event.dwThreadId instead of main_thread_id.
6653
6654 2019-04-30  Tom Tromey  <tromey@adacore.com>
6655
6656         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6657         (create_excep_cond_exprs): Iterate over program spaces.
6658         (ada_exception_catchpoint_cond_string): Examine all minimal
6659         symbols for exception types.
6660
6661 2019-04-30  Tom Tromey  <tromey@adacore.com>
6662
6663         PR c++/24470:
6664         * dwarf2read.c (process_structure_scope): Handle case where type
6665         has template parameters but no symbol was created.
6666
6667 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6668             Chris January  <chris.january@arm.com>
6669
6670         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6671         qualifier.
6672         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6673
6674 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6675
6676         * f-typeprint.c (f_print_type): Update rules for printing
6677         whitespace.
6678         (f_type_print_varspec_suffix): Likewise.
6679
6680 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6681             Chris January  <chris.january@arm.com>
6682
6683         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6684         function arguments.
6685
6686 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6687
6688         * f-lang.c (build_fortran_types): Change name of void type to
6689         lower case.
6690         * f-typeprint.c (f_type_print_base): Print the name of the void
6691         type, rather than a fixed string.
6692         * f-valprint.c (f_decorations): Use lower case void string.
6693
6694 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6695             Chris January  <chris.january@arm.com>
6696
6697         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6698         types for Fortran.
6699
6700 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6701             Chris January  <chris.january@arm.com>
6702             David Lecomber  <david.lecomber@arm.com>
6703
6704         * f-exp.y (BINOP_INTRINSIC): New token.
6705         (exp): New parser rule handling BINOP_INTRINSIC.
6706         (f77_keywords): Add new builtin procedures.
6707         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6708         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6709         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6710         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6711         (print_unop_subexp_f): New function.
6712         (print_binop_subexp_f): New function.
6713         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6714         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6715         (dump_subexp_body_f): Likewise.
6716         (operator_check_f): Likewise.
6717         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6718         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6719
6720 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6721
6722         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6723         UNOP_KIND.
6724         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6725         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6726         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6727         (operator_length_f): New fuction.
6728         (print_subexp_f): New function.
6729         (op_name_f): New function.
6730         (dump_subexp_body_f): New function.
6731         (operator_check_f): New function.
6732         (exp_descriptor_f): Replace standard expression handling functions
6733         with new functions.
6734         * gdb/fortran-operator.def: New file.
6735         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6736         * gdb/std-operator.def: Remove UNOP_KIND.
6737
6738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * std-operator.def: Remove unbalanced, stray double quote
6741         character.
6742
6743 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6744             Chris January  <chris.january@arm.com>
6745             Daniel Everett  <daniel.everett@arm.com>
6746             Nick Forrington  <nick.forrington@arm.com>
6747             Richard Bunt  <richard.bunt@arm.com>
6748
6749         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6750         of depth when printing anonymous structs or unions.
6751         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6752         Don't print either the top-level value, or the children if the
6753         max-depth is exceeded.
6754         (ppscm_print_children): When printing the key of a map, allow one
6755         extra level of depth.
6756         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6757         print either the top-level value, or the children if the max-depth
6758         is exceeded.
6759         (print_children): When printing the key of a map, allow one extra
6760         level of depth.
6761         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6762         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6763         (user_print_options): Initialise max_depth field.
6764         (val_print_scalar_or_string_type_p): New function.
6765         (val_print): Check to see if the max depth has been reached.
6766         (val_print_check_max_depth): Define new function.
6767         (show_print_max_depth): New function.
6768         (_initialize_valprint): Add 'print max-depth' option.
6769         * valprint.h (struct value_print_options) <max_depth>: New field.
6770         (val_print_check_max_depth): Declare new function.
6771         * NEWS: Document new feature.
6772
6773 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6774
6775         * ada-lang.c (ada_language_defn): Initialise new field.
6776         * c-lang.c (c_is_string_type_p): New function.
6777         (c_language_defn): Initialise new field.
6778         (cplus_language_defn): Initialise new field.
6779         (asm_language_defn): Initialise new field.
6780         (minimal_language_defn): Initialise new field.
6781         * c-lang.h (c_is_string_type_p): Declare new function.
6782         * d-lang.c (d_language_defn): Initialise new field.
6783         * f-lang.c (f_is_string_type_p): New function.
6784         (f_language_defn): Initialise new field.
6785         * go-lang.c (go_is_string_type_p): New function.
6786         (go_language_defn): Initialise new field.
6787         * language.c (default_is_string_type_p): New function.
6788         (unknown_language_defn): Initialise new field.
6789         (auto_language_defn): Initialise new field.
6790         * language.h (struct language_defn) <la_is_string_type_p>: New
6791         member variable.
6792         (default_is_string_type_p): Declare new function.
6793         * m2-lang.c (m2_language_defn): Initialise new field.
6794         * objc-lang.c (objc_language_defn): Initialise new field.
6795         * opencl-lang.c (opencl_language_defn): Initialise new field.
6796         * p-lang.c (pascal_is_string_type_p): New function.
6797         (pascal_language_defn): Initialise new field.
6798         * rust-lang.c (rust_is_string_type_p): New function.
6799         (rust_language_defn): Initialise new field.
6800
6801 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6802
6803         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6804         New field.
6805         * ada-lang.c (ada_language_defn): Initialise new field.
6806         * c-lang.c (c_language_defn): Likewise.
6807         (cplus_language_defn): Likewise.
6808         (asm_language_defn): Likewise.
6809         (minimal_language_defn): Likewise.
6810         * d-lang.c (d_language_defn): Likewise.
6811         * f-lang.c (f_language_defn): Likewise.
6812         * go-lang.c (go_language_defn): Likewise.
6813         * language.c (unknown_language_defn): Likewise.
6814         (auto_language_defn): Likewise.
6815         * m2-lang.c (m2_language_defn): Likewise.
6816         * objc-lang.c (objc_language_defn): Likewise.
6817         * opencl-lang.c (opencl_language_defn): Likewise.
6818         * p-lang.c (pascal_language_defn): Likewise.
6819         * rust-lang.c (rust_language_defn): Likewise.
6820
6821 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         * ada-lang.c (ada_is_character_type): Change return type to bool.
6824         (ada_is_string_type): Likewise.
6825         * ada-lang.h (ada_is_character_type): Update declaration
6826         (ada_is_string_type): Likewise.
6827
6828 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6829
6830         Support style in 'frame|thread apply'
6831
6832         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6833         * record.c (record_start, record_stop): Update callers of
6834         execute_command_to_string with false.
6835         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6836         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6837         methods.
6838         (class string_file): New constructor with term_out parameter.
6839         Override methods term_out and can_emit_style_escape.  New member
6840         term_out.
6841         (class stdio_file): Override can_emit_style_escape.
6842         (class tee_file): Override term_out and can_emit_style_escape.
6843         * utils.h (can_emit_style_escape): Remove.
6844         * utils.c (can_emit_style_escape): Likewise.
6845         Update all callers of can_emit_style_escape (SOMESTREAM) to
6846         SOMESTREAM->can_emit_style_escape.
6847         * source-cache.c (source_cache::get_source_lines): Likewise.
6848         * stack.c (frame_apply_command_count): Call execute_command_to_string
6849         passing the term_out characteristic of the current gdb_stdout.
6850         * thread.c (thr_try_catch_cmd): Likewise.
6851         * top.c (execute_command_to_string): pass term_out parameter
6852         to construct the string_file for the command output.
6853         * ui-file.c (term_cli_styling): New function (most code moved
6854         from utils.c can_emit_style_escape).
6855         (string_file::string_file, string_file::can_emit_style_escape,
6856         stdio_file::can_emit_style_escape, tee_file::term_out,
6857         tee_file::can_emit_style_escape): New functions.
6858
6859 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6860
6861         * NEWS: Mention the new set|show may-call-functions.
6862         * infcall.c (may_call_functions_p): New variable.
6863         (show_may_call_functions_p): New function.
6864         (call_function_by_hand_dummy): Throws an error if not
6865         may-call-functions.
6866         (_initialize_infcall): Call add_setshow_boolean_cmd for
6867         may-call-functions.
6868
6869 2019-04-25  Keith Seitz  <keiths@redhat.com>
6870
6871         PR c++/24367
6872         * cp-support.c (inspect_type): Don't attempt substitutions
6873         of symbol with the same name.
6874
6875 2019-04-25  Tom Tromey  <tromey@adacore.com>
6876
6877         PR gdb/24475:
6878         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6879         static.
6880
6881 2019-04-25  Tom Tromey  <tromey@adacore.com>
6882
6883         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6884         rvalue reference.
6885         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6886         (gdb_xml_parser::parse): Use std::move.
6887         * python/python-internal.h (gdbpy_convert_exception): Take a const
6888         reference.
6889         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6890         std::move.
6891         * python/py-utils.c (gdbpy_convert_exception): Take a const
6892         reference.
6893         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6894         Use std::move.
6895         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6896         Use std::move.
6897         * mi/mi-main.c (mi_print_exception): Take a const reference.
6898         * main.c (handle_command_errors): Take a const reference.
6899         * linespec.c (parse_linespec): Use std::move.
6900         * infcall.c (run_inferior_call): Use std::move.
6901         (call_function_by_hand_dummy): Use std::move.
6902         * exec.c (try_open_exec_file): Use std::move.
6903         * exceptions.h (exception_print, exception_fprintf)
6904         (exception_print_same): Update.
6905         * exceptions.c (print_exception, exception_print)
6906         (exception_fprintf, exception_print_same): Change parameters to
6907         const reference.
6908         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6909         * common/new-op.c: Use std::move.
6910         * common/common-exceptions.h (struct gdb_exception): Add move
6911         constructor.
6912         (struct gdb_exception_error, struct gdb_exception_quit, struct
6913         gdb_quit_bad_alloc): Change constructor to move constructor.
6914         (throw_exception): Change parameter to rvalue reference.
6915         * common/common-exceptions.c (throw_exception): Take rvalue
6916         reference.
6917         * cli/cli-interp.c (safe_execute_command): Use std::move.
6918         * breakpoint.c (insert_bp_location, location_to_sals): Use
6919         std::move.
6920
6921 2019-04-25  Tom Tromey  <tromey@adacore.com>
6922
6923         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6924         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6925         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6926         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6927         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6928         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6929         guile/scm-value.c: Use unpack.
6930         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6931         gdbscm_gdb_exception.
6932         (gdbscm_throw_gdb_exception): Likewise.
6933         (struct gdbscm_gdb_exception): New.
6934         (unpack): New function.
6935         (gdbscm_wrap): Use unpack.
6936
6937 2019-04-25  Tom Tromey  <tromey@adacore.com>
6938
6939         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6940         (gdb_rl_callback_handler): Use std::move.
6941         * common/common-exceptions.h (struct gdb_exception): Add move
6942         assignment operator.
6943         (throw_exception_sjlj): Change "exception" to const reference.
6944         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6945         (throw_exception_sjlj): Change "exception" to const reference.
6946
6947 2019-04-25  Tom Tromey  <tromey@adacore.com>
6948
6949         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6950         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6951         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6952         Update.
6953         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6954         Update.
6955         * mi/mi-interp.c (mi_interp::exec): Update.
6956         * linespec.c (parse_linespec): Update.
6957         * infcall.c (run_inferior_call): Update.
6958         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6959         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6960         (gdbscm_lookup_global_symbol): Update.
6961         * guile/scm-param.c (gdbscm_parameter_value): Update.
6962         * guile/scm-frame.c (gdbscm_frame_read_register)
6963         (gdbscm_frame_read_var): Update.
6964         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6965         * exec.c (try_open_exec_file): Update.
6966         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6967         (gdb_rl_callback_handler): Update.
6968         * common/common-exceptions.h (exception_none): Don't declare.
6969         * common/common-exceptions.c (exception_none): Don't define.
6970         (struct catcher) <exception>: Update.
6971         * cli/cli-interp.c (safe_execute_command): Update.
6972         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6973
6974 2019-04-25  Ali Tamur  <tamur@google.com>
6975
6976         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6977         (read_attribute_value): Likewise.
6978         (dwarf2_read_addr_index): Update comment.
6979         (read_str_index): Add DW_FORM_strx.
6980         (dwarf2_string_attr): Likewise.
6981         (dwarf2_const_value_attr): Likewise.
6982         (dump_die_shallow): Likewise.
6983         (dwarf2_fetch_constant_bytes): Likewise.
6984         (skip_form_bytes): Likewise.
6985         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6986
6987 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6988
6989         PR corefiles/11608
6990         PR corefiles/18187
6991         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6992         OFFSET.  Verify if current mapping contains an ELF header.
6993         (linux_find_memory_regions_full): Adjust call to
6994         dump_mapping_p.
6995
6996 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6997             Kang Li <kanglictf@gmail.com>
6998
6999         PR gdb/21600
7000
7001         * dwarf2-frame.c (read_initial_length): Be consistent about using
7002         unsigned representation of length.
7003         (decode_frame_entry_1): Likewise.  Check for wraparound of
7004         end pointer as well as buffer overflow.
7005
7006 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7007
7008         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7009         "vq".
7010
7011 2019-04-24  Tom Tromey  <tromey@adacore.com>
7012
7013         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7014
7015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * s12z-tdep.c (s12z_unwind_pc): Delete.
7018         (s12z_unwind_sp): Delete.
7019         (s12z_gdbarch_init): Don't register deleted functions with
7020         gdbarch.
7021
7022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         * rl78-tdep.c (rl78_unwind_sp): Delete.
7025         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7026
7027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7030         (xstormy16_unwind_pc): Delete.
7031         (xstormy16_dummy_id): Delete.
7032         (xstormy16_gdbarch_init): Don't register deleted functions with
7033         gdbarch.
7034
7035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7036
7037         * vax-tdep.c (vax_unwind_pc): Delete.
7038         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7039
7040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7041
7042         * v850-tdep.c (v850_unwind_sp): Delete.
7043         (v850_unwind_pc): Delete.
7044         (v850_dummy_id): Delete.
7045         (v850_gdbarch_init): Don't register deleted functions with
7046         gdbarch.
7047
7048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7051         (tilegx_unwind_pc): Delete.
7052         (tilegx_unwind_dummy_id): Delete.
7053         (tilegx_gdbarch_init): Don't register deleted functions with
7054         gdbarch.
7055
7056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7059         (tic6x_dummy_id): Delete.
7060         (tic6x_gdbarch_init): Don't register deleted functions with
7061         gdbarch.
7062
7063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7064
7065         * sparc-tdep.c (sparc_unwind_pc): Delete.
7066         (sparc32_gdbarch_init): Don't register deleted function with
7067         gdbarch.
7068
7069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7070
7071         * sh-tdep.c (sh_unwind_sp): Delete.
7072         (sh_unwind_pc): Delete.
7073         (sh_dummy_id): Delete.
7074         (sh_gdbarch_init): Don't register deleted functions with
7075         gdbarch.
7076
7077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * score-tdep.c (score_unwind_sp): Delete.
7080         (score_unwind_pc): Delete.
7081         (score_dummy_id): Delete.
7082         (score_gdbarch_init): Don't register deleted functions with
7083         gdbarch.
7084
7085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * rx-tdep.c (rx_unwind_pc): Delete.
7088         (rx_unwind_sp): Delete.
7089         (rx_dummy_id): Delete.
7090         (rx_gdbarch_init): Don't register deleted functions with
7091         gdbarch.  Update comment.
7092
7093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7094
7095         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7096         (rs6000_dummy_id): Delete.
7097         (rs6000_gdbarch_init): Don't register deleted functions with
7098         gdbarch.
7099
7100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * or1k-tdep.c (or1k_dummy_id): Delete.
7103         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7104
7105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * nios2-tdep.c (nios2_dummy_id): Delete.
7108         (nios2_unwind_sp): Delete.
7109         (nios2_gdbarch_init): Don't register deleted functions with
7110         gdbarch.
7111
7112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * nds32-tdep.c (nds32_dummy_id): Delete.
7115         (nds32_unwind_pc): Delete.
7116         (nds32_unwind_sp): Delete.
7117         (nds32_gdbarch_init): Don't register deleted functions with
7118         gdbarch.
7119
7120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7121
7122         * msp430-tdep.c (msp430_unwind_pc): Delete.
7123         (msp430_unwind_sp): Delete.
7124         (msp430_dummy_id): Delete.
7125         (msp430_gdbarch_init): Don't register deleted functions with
7126         gdbarch.
7127
7128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7129
7130         * moxie-tdep.c (moxie_unwind_sp): Delete.
7131         (moxie_unwind_pc): Delete.
7132         (moxie_dummy_id): Delete.
7133         (moxie_gdbarch_init): Don't register deleted functions with
7134         gdbarch.
7135
7136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7137
7138         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7139         (mn10300_unwind_pc): Delete.
7140         (mn10300_unwind_sp): Delete.
7141         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7142         mn10300_unwind_sp.
7143         (mn10300_frame_unwind_init): Don't register deleted functions with
7144         gdbarch.
7145
7146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         * mep-tdep.c (mep_unwind_pc): Delete.
7149         (mep_unwind_sp): Delete.
7150         (mep_dummy_id): Delete.
7151         (mep_gdbarch_init): Don't register deleted functions with
7152         gdbarch.
7153
7154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7155
7156         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7157         (m68hc11_unwind_sp): Delete.
7158         (m68hc11_gdbarch_init): Don't register deleted functions with
7159         gdbarch.
7160
7161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7162
7163         * m32r-tdep.c (m32r_unwind_sp): Delete.
7164         (m32r_unwind_pc): Delete.
7165         (m32r_dummy_id): Delete.
7166         (m32r_gdbarch_init): Don't register deleted functions with
7167         gdbarch.
7168
7169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7170
7171         * m32c-tdep.c (m32c_unwind_pc): Delete.
7172         (m32c_unwind_sp): Delete.
7173         (m32c_dummy_id): Delete.
7174         (m32c_gdbarch_init): Don't register deleted functions with
7175         gdbarch.
7176
7177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7180         (lm32_unwind_pc): Delete.
7181         (lm32_dummy_id): Delete.
7182         (lm32_gdbarch_init): Don't register deleted functions with
7183         gdbarch.
7184
7185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7188         (iq2000_unwind_pc): Delete.
7189         (iq2000_dummy_id): Delete.
7190         (iq2000_gdbarch_init): Don't register deleted functions with
7191         gdbarch.
7192
7193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * nds32-tdep.c (nds32_type_align): Delete.
7196         (nds32_push_dummy_call): Use type_align instead.
7197
7198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7199
7200         * arm-tdep.c (arm_type_align): Only handle vector override case.
7201         (arm_push_dummy_call): Use type_align.
7202         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7203
7204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7205
7206         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7207         case.
7208         (pass_on_stack): Use type_align.
7209         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7210         function.
7211
7212 2019-04-23  Tom Tromey  <tromey@adacore.com>
7213
7214         * dwarf2read.c (line_header::file_name_at): Remove unused
7215         overload.
7216
7217 2019-04-23  Tom de Vries  <tdevries@suse.de>
7218
7219         PR gdb/24438
7220         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7221         invocation.
7222
7223
7224 2019-03-27  Ali Tamur  <tamur@google.com>
7225
7226         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7227         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7228         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7229         (dwarf_expr_context::get_addr_index): Likewise
7230         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7231         (symbol_needs_eval_context::get_addr_index): Likewise
7232         (disassemble_dwarf_expression): Add DW_OP_addrx
7233         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7234         (read_cutu_die_from_dwo): Update comment
7235         (skip_one_die): Add DW_FORM_addrx
7236         (read_attribute_value): Likewise
7237         (var_decode_location): Add DW_OP_addrx
7238         (dwarf2_const_value_attr): Add DW_FORM_addrx
7239         (dump_die_shallow): Likewise
7240         (dwarf2_fetch_constant_bytes): Likewise
7241         (decode_locdesc): Add DW_OP_addrx
7242         (skip_form_bytes): Add DW_FORM_addrx
7243
7244 2019-04-22  Ali Tamur  <tamur@google.com>
7245
7246         * MAINTAINERS (Write After Approval): Add self.
7247
7248 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7249
7250         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7251         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7252         (open_symbol_file_object): Likewise.
7253         (svr4_default_sos): Add info parameter.
7254         (svr4_read_so_list): Likewise.
7255         (svr4_current_sos_direct): Adjust functions calls to pass down
7256         info.
7257         (svr4_current_sos_1): Add info parameter.
7258         (svr4_current_sos): Call get_svr4_info, pass info down to
7259         svr4_current_sos_1.
7260         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7261         get_svr4_info.
7262         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7263         get_svr4_info.
7264         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7265         to get_svr4_info.
7266         (probes_table_remove_objfile_probes): Likewise.
7267         (register_solib_event_probe): Add info parameter.
7268         (solist_update_incremental): Pass info parameter down to
7269         svr4_read_so_list.
7270         (disable_probes_interface): Add info parameter.
7271         (svr4_handle_solib_event): Pass current_program_space to
7272         get_svr4_info.  Adjust disable_probes_interface cleanup.
7273         (svr4_create_probe_breakpoints): Add info parameter, pass it
7274         down to register_solib_event_probe.
7275         (svr4_create_solib_event_breakpoints): Add info parameter,
7276         pass it down to svr4_create_probe_breakpoints.
7277         (enable_break): Pass info down to
7278         svr4_create_solib_event_breakpoints.
7279         (svr4_solib_create_inferior_hook): Pass current_program_space to
7280         get_svr4_info.
7281         (svr4_clear_solib): Likewise.
7282
7283 2019-04-22  Pedro Alves  <palves@redhat.com>
7284
7285         * solib-svr4.c (svr4_free_objfile_observer): New.
7286         (probe_and_action::objfile): New field.
7287         (probes_table_htab_remove_objfile_probes)
7288         (probes_table_remove_objfile_probes): New functions.
7289         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7290         in the new probe_and_action.  Don't store the probe in 'lookup'.
7291         (svr4_create_probe_breakpoints): Pass objfile to
7292         register_solib_event_probe.
7293         (_initialize_svr4_solib): Register a free_objfile observer.
7294
7295 2019-04-19  Tom Tromey  <tom@tromey.com>
7296
7297         * common/queue.h: Remove.
7298
7299 2019-04-19  Tom Tromey  <tom@tromey.com>
7300
7301         * event-loop.c: Don't include "common/queue.h".
7302
7303 2019-04-19  Tom Tromey  <tom@tromey.com>
7304
7305         * remote.c (remote_target): Use delete.
7306         * remote-notif.h: Include <list>, not "common/queue.h".
7307         (notif_client_p): Remove typedef.
7308         (remote_notif_state): Add constructor, destructor, initializer.
7309         <notif_queue>: Now a std::list.
7310         (remote_notif_state_xfree): Don't declare.
7311         * remote-notif.c (remote_notif_process, handle_notification)
7312         (remote_notif_state_allocate): Update.
7313         (~remote_notif_state): Rename from remote_notif_state_xfree.
7314
7315 2019-04-19  Tom Tromey  <tom@tromey.com>
7316
7317         * symfile.c (reread_symbols): Update.
7318         * objfiles.c (objfile_register_static_link)
7319         (objfile_lookup_static_link): Update
7320         (~objfile) Don't delete static_links.
7321         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7322
7323 2019-04-19  Tom Tromey  <tom@tromey.com>
7324
7325         * type-stack.h (struct type_stack) <insert>: Constify string.
7326         * type-stack.c (type_stack::insert): Constify string.
7327         * gdbtypes.h (lookup_template_type): Update.
7328         (address_space_name_to_int): Update.
7329         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7330         const.
7331         (lookup_template_type): Make name const.
7332         * c-exp.y: Update rules.
7333         (lex_one_token, classify_name, classify_inner_name)
7334         (c_print_token): Update.
7335         * p-exp.y: Update rules.
7336         (yylex): Update.
7337         * f-exp.y: Update rules.
7338         (yylex): Update.
7339         * d-exp.y: Update rules.
7340         (lex_one_token, classify_name, classify_inner_name): Update.
7341         * parse.c (write_dollar_variable, copy_name): Return std::string.
7342         * parser-defs.h (copy_name): Change return type.
7343         * m2-exp.y: Update rules.
7344         (yylex): Update.
7345         * go-exp.y (lex_one_token): Update.
7346         Update rules.
7347         (classify_unsafe_function, classify_packaged_name)
7348         (classify_name, yylex): Update.
7349
7350 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7351
7352         * configure.ac: add --enable-source-highlight switch.
7353         * configure: Regenerate.
7354         * top.c (print_gdb_version): plumb --enable-source-highlight
7355         status to "show configuration".
7356
7357 2019-04-19  Tom Tromey  <tromey@adacore.com>
7358
7359         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7360         Check ADA_TYPE_P.
7361         (empty_record, ada_template_to_fixed_record_type_1)
7362         (template_to_static_fixed_type)
7363         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7364         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7365         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7366         macros.
7367
7368 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7369
7370         PR symtab/24423:
7371         * source.c (print_source_lines_base): Advance "iter" when a
7372         control character is seen.
7373
7374 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7375
7376         * inferior.h (struct infcall_suspend_state_deleter):
7377         Catch exception in destructor to avoid crash.
7378
7379 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7380
7381         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7382         close to the add_com "shell".
7383
7384 2019-04-18  Tom Tromey  <tromey@adacore.com>
7385
7386         * process-stratum-target.h (class process_stratum_target)
7387         <stratum>: Add "final".
7388
7389 2019-04-17  Tom Tromey  <tromey@adacore.com>
7390
7391         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7392         against nullptr before use.
7393
7394 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7395
7396         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7397
7398 2019-04-17  Jim Wilson  <jimw@sifive.com>
7399             Andrew Burgess  <andrew.burgess@embecosm.com>
7400
7401         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7402         code read might fail, assume 4-byte breakpoint in that case.
7403
7404 2019-04-15  Leszek Swirski  <leszeks@google.com>
7405
7406         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7407         rather than a hand-rolled POD check when checking for forced MEMORY
7408         classification.
7409
7410 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7411
7412         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7413         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7414         function.
7415         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7416         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7417         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7418         declaration.
7419
7420 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7421
7422         * aarch64-linux-nat.c
7423         (aarch64_linux_nat_target::thread_architecture): Add override.
7424         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7425         each VQ.
7426
7427 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7428
7429         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7430
7431 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7432
7433         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7434         target types of size 96-bits, add some additional comments, and
7435         check that the builtin type we found was the correct size.
7436
7437 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7438
7439         * utils.c (prompt_for_continue): Don't restore the styling at the
7440         end, as applied_style has the wrong value.  This fixes styling in
7441         long lists of file names that are interrupted by the "Continue?"
7442         prompt.
7443
7444 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7445
7446         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7447         * c-lang.c (c_language_defn): Likewise.
7448         (cplus_language_defn): Likewise.
7449         (asm_language_defn): Likewise.
7450         (minimal_language_defn): Likewise.
7451         * d-lang.c (d_language_defn): Likewise.
7452         * f-lang.c (f_language_defn): Likewise.
7453         * go-lang.c (go_language_defn): Likewise.
7454         * language.c (unknown_language_defn): Likewise.
7455         (auto_language_defn): Likewise.
7456         * language.h (struct language_defn): Remove la_magic field.
7457         (LANG_MAGIC): Delete.
7458         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7459         * objc-lang.c (objc_language_defn): Likewise.
7460         * opencl-lang.c (opencl_language_defn): Likewise.
7461         * p-lang.c (pascal_language_defn): Likewise.
7462         * rust-lang.c (rust_language_defn): Likewise.
7463
7464 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * riscv-tdep.c (riscv_type_align): New function.
7467         (riscv_type_alignment): Delete.
7468         (riscv_arg_location): Use 'type_align'.
7469         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7470
7471 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7472
7473         * gdbtypes.c (type_align): A struct with no non-static fields also
7474         has alignment of 1.
7475
7476 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7479         component to 0.
7480         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7481         member.
7482         (riscv_struct_info::analyse): New implementation using new
7483         analyse_inner member function.
7484         (riscv_struct_info::field_offset): New member function.
7485         (riscv_struct_info::m_offsets): New member variable.
7486         (riscv_struct_info::analyse_inner): New private member function,
7487         takes the old implementation of riscv_struct_info::analyse but
7488         extended to track field offsets.
7489         (riscv_call_arg_struct): Update the struct folding special cases
7490         to handle cases where empty C++ structs, which are non-zero
7491         length, are found.
7492         (riscv_arg_location): Initialise the length of each location, a
7493         non-zero length now indicates the location is in use.
7494         (riscv_push_dummy_call): Allow for the first location having a
7495         non-zero offset when setting up arguments.
7496         (riscv_return_value): Likewise, but for return values.
7497
7498 2019-04-11  Tom Tromey  <tromey@adacore.com>
7499
7500         * utils.c (internal_vproblem): Make "msg" const.
7501
7502 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7503
7504         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7505         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7506         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7507         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7508
7509 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7510
7511         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7512         function.
7513         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7514         of amd64_collect_native_gregset.
7515         (amd64_linux_nat_target::store_registers): Likewise.
7516
7517 2019-04-10  Tom Tromey  <tom@tromey.com>
7518
7519         * symtab.c (lookup_global_symbol_from_objfile)
7520         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7521         * objfiles.h (class separate_debug_iterator): New.
7522         (class separate_debug_range): New.
7523         (struct objfile) <separate_debug_objfiles>: New method.
7524         (objfile_separate_debug_iterate): Don't declare.
7525         * objfiles.c (separate_debug_iterator::operator++): Rename from
7526         objfile_separate_debug_iterate.
7527         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7528         iterator.
7529         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7530         iterator.
7531
7532 2019-04-10  Tom Tromey  <tom@tromey.com>
7533
7534         * symfile.c (reread_symbols): Remove old comment.
7535         * objfiles.c (free_all_objfiles): Fix a typo.
7536
7537 2019-04-10  Tom Tromey  <tom@tromey.com>
7538
7539         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7540         * minsyms.c (lookup_minimal_symbol): Use foreach.
7541         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7542         (lookup_minimal_symbol_solib_trampoline): Likewise.
7543         * symfile.c (reread_symbols): Use foreach.
7544
7545 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7546             Tom Tromey  <tromey@adacore.com>
7547
7548         PR rust/24414:
7549         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7550         (rust_lex_int_test): Change "value" to be LONGEST.
7551         (rust_lex_tests): Add test for long integer literal.
7552
7553 2019-04-09  Tom Tromey  <tromey@adacore.com>
7554
7555         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7556         to bool.
7557         (extended_remote_target::attach): Update.
7558         (remote_target::remote_notice_new_inferior): Update.
7559         (remote_target::add_current_inferior_and_thread): Update.
7560         * inferior.c (exit_inferior_1): Use "false".
7561         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7562
7563 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7564
7565         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7566         the "start" command.
7567
7568 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7569
7570         * python/py-inferior.c (infpy_thread_from_thread_handle):
7571         Adjust comments to reflect renaming of thread_from_thread_handle
7572         to thread_from_handle.  Adjust keywords.  Fix type error message.
7573         (inferior_object_methods): Add thread_from_handle.  Retain
7574         thread_from_thread_handle, but mark it as deprecated.
7575
7576 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7577
7578         * gdbthread.h (find_thread_by_handle): Revise declaration.
7579         * thread.c (find_thread_by_handle): Likewise.  Adjust
7580         implementation too.
7581         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7582         support for buffer objects as handles.
7583
7584 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7585
7586         * python/py-infthread.c (thpy_thread_handle): New function.
7587         (thread_object_methods): Register thpy_thread_handle.
7588
7589 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7590
7591         * gdbthread.h (thread_to_thread_handle): Declare.
7592         * thread.c (gdbtypes.h): Include.
7593         (thread_to_thread_handle): New function.
7594
7595         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7596         (target_thread_info_to_thread_handle): Declare.
7597         * target.c (target_thread_info_to_thread_handle): New function.
7598         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7599         * target-delegates.c: Regenerate.
7600
7601         * linux-thread-db.c (class thread_db_target): Add method
7602         thread_info_to_thread_handle.
7603         (thread_db_target::thread_info_to_thread_handle): Define.
7604         * remote.c (class remote_target): Add new method
7605         thread_info_to_thread_handle.
7606         (remote_target::thread_info_to_thread_handle): Define.
7607
7608 2019-04-08  Pedro Alves  <palves@redhat.com>
7609
7610         * common/common-exceptions.c (throw_exception): Don't create
7611         named object to throw; throw directly.
7612         (throw_it): Likewise.  Don't initialize gdb_exception::message
7613         here, with new; pass FMT and AP to the ctor instead.
7614         * common/common-exceptions.h: Include <string>.
7615         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7616         const char *, va_list)): New ctor.  Use std::make_shared.
7617         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7618         errors)): Delete.
7619         (gdb_exception_error::gdb_exception_error(enum errors, const char
7620         *, va_list)): New.
7621         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7622         Add assertion.
7623         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7624         errors)): Delete.
7625         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7626         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7627         Add assertion.
7628
7629 2019-04-08  Tom Tromey  <tom@tromey.com>
7630
7631         * valops.c (value_rtti_indirect_type): Replace throw_exception
7632         with throw.
7633         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7634         with throw.
7635         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7636         throw.
7637         * target.c (target_translate_tls_address): Replace throw_exception
7638         with throw.
7639         * stack.c (frame_apply_command_count): Replace throw_exception
7640         with throw.
7641         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7642         throw.
7643         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7644         with throw.
7645         * rs6000-tdep.c (rs6000_frame_cache)
7646         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7647         * remote.c: Replace throw_exception with throw.
7648         * record-full.c (record_full_message, record_full_wait_1)
7649         (record_full_restore): Replace throw_exception with throw.
7650         * record-btrace.c:
7651         (get_thread_current_frame_id, record_btrace_start_replaying)
7652         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7653         (cmd_record_btrace_start): Replace throw_exception with throw.
7654         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7655         throw.
7656         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7657         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7658         * linespec.c:
7659         (find_linespec_symbols): Replace throw_exception with throw.
7660         * infrun.c (displaced_step_prepare, resume): Replace
7661         throw_exception with throw.
7662         * infcmd.c (post_create_inferior): Replace throw_exception with
7663         throw.
7664         * inf-loop.c (inferior_event_handler): Replace throw_exception
7665         with throw.
7666         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7667         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7668         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7669         (get_prev_frame_always, get_frame_pc_if_available)
7670         (get_frame_address_in_block_if_available, get_frame_language):
7671         Replace throw_exception with throw.
7672         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7673         throw_exception with throw.
7674         * eval.c (fetch_subexp_value, evaluate_var_value)
7675         (evaluate_funcall, evaluate_subexp_standard): Replace
7676         throw_exception with throw.
7677         * dwarf2loc.c (call_site_find_chain)
7678         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7679         Replace throw_exception with throw.
7680         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7681         with throw.
7682         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7683         throw.
7684         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7685         * completer.c (complete_line_internal): Replace throw_exception
7686         with throw.
7687         * compile/compile-object-run.c (compile_object_run): Replace
7688         throw_exception with throw.
7689         * cli/cli-script.c (process_next_line): Replace throw_exception
7690         with throw.
7691         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7692         (btrace_enable, btrace_maint_update_pt_packets): Replace
7693         throw_exception with throw.
7694         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7695         throw_exception with throw.
7696         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7697         throw_exception with throw.
7698         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7699         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7700         * aarch64-tdep.c (aarch64_make_prologue_cache)
7701         (aarch64_make_stub_cache): Replace throw_exception with throw.
7702
7703 2019-04-08  Tom Tromey  <tom@tromey.com>
7704
7705         * common/common-exceptions.c (throw_exception): Rename from
7706         throw_exception_cxx.  Remove old copy.  Make argument const.
7707         (throw_it): Create and throw exception objects directly.
7708         * common/common-exceptions.h (throw_exception): Make argument
7709         const.
7710         (struct gdb_exception_error): Add constructor.
7711         (struct gdb_exception_quit): Add constructor.
7712
7713 2019-04-08  Tom Tromey  <tom@tromey.com>
7714
7715         * common/common-exceptions.h (exception_rethrow): Don't declare.
7716         (TRY_SJLJ): Update comment.
7717         (TRY, CATCH, END_CATCH): Remove.
7718         * common/common-exceptions.c (exception_rethrow): Remove.
7719
7720 2019-04-08  Tom Tromey  <tom@tromey.com>
7721
7722         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7723         Remove.
7724         (gdb_exception_error): Rename from
7725         gdb_exception_RETURN_MASK_ERROR.
7726         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7727         (gdb_quit_bad_alloc): Update.
7728         * aarch64-tdep.c: Update.
7729         * ada-lang.c: Update.
7730         * ada-typeprint.c: Update.
7731         * ada-valprint.c: Update.
7732         * amd64-tdep.c: Update.
7733         * arch-utils.c: Update.
7734         * break-catch-throw.c: Update.
7735         * breakpoint.c: Update.
7736         * btrace.c: Update.
7737         * c-varobj.c: Update.
7738         * cli/cli-cmds.c: Update.
7739         * cli/cli-interp.c: Update.
7740         * cli/cli-script.c: Update.
7741         * common/common-exceptions.c: Update.
7742         * common/new-op.c: Update.
7743         * common/selftest.c: Update.
7744         * compile/compile-c-symbols.c: Update.
7745         * compile/compile-cplus-symbols.c: Update.
7746         * compile/compile-object-load.c: Update.
7747         * compile/compile-object-run.c: Update.
7748         * completer.c: Update.
7749         * corelow.c: Update.
7750         * cp-abi.c: Update.
7751         * cp-support.c: Update.
7752         * cp-valprint.c: Update.
7753         * darwin-nat.c: Update.
7754         * disasm-selftests.c: Update.
7755         * dtrace-probe.c: Update.
7756         * dwarf-index-cache.c: Update.
7757         * dwarf-index-write.c: Update.
7758         * dwarf2-frame-tailcall.c: Update.
7759         * dwarf2-frame.c: Update.
7760         * dwarf2loc.c: Update.
7761         * dwarf2read.c: Update.
7762         * eval.c: Update.
7763         * event-loop.c: Update.
7764         * event-top.c: Update.
7765         * exec.c: Update.
7766         * f-valprint.c: Update.
7767         * fbsd-tdep.c: Update.
7768         * frame-unwind.c: Update.
7769         * frame.c: Update.
7770         * gdbtypes.c: Update.
7771         * gnu-v3-abi.c: Update.
7772         * guile/guile-internal.h: Update.
7773         * guile/scm-block.c: Update.
7774         * guile/scm-breakpoint.c: Update.
7775         * guile/scm-cmd.c: Update.
7776         * guile/scm-disasm.c: Update.
7777         * guile/scm-frame.c: Update.
7778         * guile/scm-lazy-string.c: Update.
7779         * guile/scm-math.c: Update.
7780         * guile/scm-param.c: Update.
7781         * guile/scm-ports.c: Update.
7782         * guile/scm-pretty-print.c: Update.
7783         * guile/scm-symbol.c: Update.
7784         * guile/scm-symtab.c: Update.
7785         * guile/scm-type.c: Update.
7786         * guile/scm-value.c: Update.
7787         * i386-linux-tdep.c: Update.
7788         * i386-tdep.c: Update.
7789         * inf-loop.c: Update.
7790         * infcall.c: Update.
7791         * infcmd.c: Update.
7792         * infrun.c: Update.
7793         * jit.c: Update.
7794         * language.c: Update.
7795         * linespec.c: Update.
7796         * linux-fork.c: Update.
7797         * linux-nat.c: Update.
7798         * linux-tdep.c: Update.
7799         * linux-thread-db.c: Update.
7800         * main.c: Update.
7801         * mi/mi-cmd-break.c: Update.
7802         * mi/mi-cmd-stack.c: Update.
7803         * mi/mi-interp.c: Update.
7804         * mi/mi-main.c: Update.
7805         * objc-lang.c: Update.
7806         * p-valprint.c: Update.
7807         * parse.c: Update.
7808         * ppc-linux-tdep.c: Update.
7809         * printcmd.c: Update.
7810         * python/py-arch.c: Update.
7811         * python/py-breakpoint.c: Update.
7812         * python/py-cmd.c: Update.
7813         * python/py-finishbreakpoint.c: Update.
7814         * python/py-frame.c: Update.
7815         * python/py-framefilter.c: Update.
7816         * python/py-gdb-readline.c: Update.
7817         * python/py-inferior.c: Update.
7818         * python/py-infthread.c: Update.
7819         * python/py-lazy-string.c: Update.
7820         * python/py-linetable.c: Update.
7821         * python/py-objfile.c: Update.
7822         * python/py-param.c: Update.
7823         * python/py-prettyprint.c: Update.
7824         * python/py-progspace.c: Update.
7825         * python/py-record-btrace.c: Update.
7826         * python/py-record.c: Update.
7827         * python/py-symbol.c: Update.
7828         * python/py-type.c: Update.
7829         * python/py-unwind.c: Update.
7830         * python/py-utils.c: Update.
7831         * python/py-value.c: Update.
7832         * python/python.c: Update.
7833         * record-btrace.c: Update.
7834         * record-full.c: Update.
7835         * remote-fileio.c: Update.
7836         * remote.c: Update.
7837         * riscv-tdep.c: Update.
7838         * rs6000-aix-tdep.c: Update.
7839         * rs6000-tdep.c: Update.
7840         * rust-exp.y: Update.
7841         * rust-lang.c: Update.
7842         * s390-tdep.c: Update.
7843         * selftest-arch.c: Update.
7844         * solib-dsbt.c: Update.
7845         * solib-frv.c: Update.
7846         * solib-spu.c: Update.
7847         * solib-svr4.c: Update.
7848         * solib.c: Update.
7849         * sparc64-linux-tdep.c: Update.
7850         * stack.c: Update.
7851         * symfile-mem.c: Update.
7852         * symmisc.c: Update.
7853         * target.c: Update.
7854         * thread.c: Update.
7855         * top.c: Update.
7856         * tracefile-tfile.c: Update.
7857         * tui/tui.c: Update.
7858         * typeprint.c: Update.
7859         * unittests/cli-utils-selftests.c: Update.
7860         * unittests/parse-connection-spec-selftests.c: Update.
7861         * valops.c: Update.
7862         * valprint.c: Update.
7863         * value.c: Update.
7864         * varobj.c: Update.
7865         * windows-nat.c: Update.
7866         * x86-linux-nat.c: Update.
7867         * xml-support.c: Update.
7868
7869 2019-04-08  Tom Tromey  <tom@tromey.com>
7870
7871         * xml-support.c: Use C++ exception handling.
7872         * x86-linux-nat.c: Use C++ exception handling.
7873         * windows-nat.c: Use C++ exception handling.
7874         * varobj.c: Use C++ exception handling.
7875         * value.c: Use C++ exception handling.
7876         * valprint.c: Use C++ exception handling.
7877         * valops.c: Use C++ exception handling.
7878         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7879         handling.
7880         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7881         * typeprint.c: Use C++ exception handling.
7882         * tui/tui.c: Use C++ exception handling.
7883         * tracefile-tfile.c: Use C++ exception handling.
7884         * top.c: Use C++ exception handling.
7885         * thread.c: Use C++ exception handling.
7886         * target.c: Use C++ exception handling.
7887         * symmisc.c: Use C++ exception handling.
7888         * symfile-mem.c: Use C++ exception handling.
7889         * stack.c: Use C++ exception handling.
7890         * sparc64-linux-tdep.c: Use C++ exception handling.
7891         * solib.c: Use C++ exception handling.
7892         * solib-svr4.c: Use C++ exception handling.
7893         * solib-spu.c: Use C++ exception handling.
7894         * solib-frv.c: Use C++ exception handling.
7895         * solib-dsbt.c: Use C++ exception handling.
7896         * selftest-arch.c: Use C++ exception handling.
7897         * s390-tdep.c: Use C++ exception handling.
7898         * rust-lang.c: Use C++ exception handling.
7899         * rust-exp.y: Use C++ exception handling.
7900         * rs6000-tdep.c: Use C++ exception handling.
7901         * rs6000-aix-tdep.c: Use C++ exception handling.
7902         * riscv-tdep.c: Use C++ exception handling.
7903         * remote.c: Use C++ exception handling.
7904         * remote-fileio.c: Use C++ exception handling.
7905         * record-full.c: Use C++ exception handling.
7906         * record-btrace.c: Use C++ exception handling.
7907         * python/python.c: Use C++ exception handling.
7908         * python/py-value.c: Use C++ exception handling.
7909         * python/py-utils.c: Use C++ exception handling.
7910         * python/py-unwind.c: Use C++ exception handling.
7911         * python/py-type.c: Use C++ exception handling.
7912         * python/py-symbol.c: Use C++ exception handling.
7913         * python/py-record.c: Use C++ exception handling.
7914         * python/py-record-btrace.c: Use C++ exception handling.
7915         * python/py-progspace.c: Use C++ exception handling.
7916         * python/py-prettyprint.c: Use C++ exception handling.
7917         * python/py-param.c: Use C++ exception handling.
7918         * python/py-objfile.c: Use C++ exception handling.
7919         * python/py-linetable.c: Use C++ exception handling.
7920         * python/py-lazy-string.c: Use C++ exception handling.
7921         * python/py-infthread.c: Use C++ exception handling.
7922         * python/py-inferior.c: Use C++ exception handling.
7923         * python/py-gdb-readline.c: Use C++ exception handling.
7924         * python/py-framefilter.c: Use C++ exception handling.
7925         * python/py-frame.c: Use C++ exception handling.
7926         * python/py-finishbreakpoint.c: Use C++ exception handling.
7927         * python/py-cmd.c: Use C++ exception handling.
7928         * python/py-breakpoint.c: Use C++ exception handling.
7929         * python/py-arch.c: Use C++ exception handling.
7930         * printcmd.c: Use C++ exception handling.
7931         * ppc-linux-tdep.c: Use C++ exception handling.
7932         * parse.c: Use C++ exception handling.
7933         * p-valprint.c: Use C++ exception handling.
7934         * objc-lang.c: Use C++ exception handling.
7935         * mi/mi-main.c: Use C++ exception handling.
7936         * mi/mi-interp.c: Use C++ exception handling.
7937         * mi/mi-cmd-stack.c: Use C++ exception handling.
7938         * mi/mi-cmd-break.c: Use C++ exception handling.
7939         * main.c: Use C++ exception handling.
7940         * linux-thread-db.c: Use C++ exception handling.
7941         * linux-tdep.c: Use C++ exception handling.
7942         * linux-nat.c: Use C++ exception handling.
7943         * linux-fork.c: Use C++ exception handling.
7944         * linespec.c: Use C++ exception handling.
7945         * language.c: Use C++ exception handling.
7946         * jit.c: Use C++ exception handling.
7947         * infrun.c: Use C++ exception handling.
7948         * infcmd.c: Use C++ exception handling.
7949         * infcall.c: Use C++ exception handling.
7950         * inf-loop.c: Use C++ exception handling.
7951         * i386-tdep.c: Use C++ exception handling.
7952         * i386-linux-tdep.c: Use C++ exception handling.
7953         * guile/scm-value.c: Use C++ exception handling.
7954         * guile/scm-type.c: Use C++ exception handling.
7955         * guile/scm-symtab.c: Use C++ exception handling.
7956         * guile/scm-symbol.c: Use C++ exception handling.
7957         * guile/scm-pretty-print.c: Use C++ exception handling.
7958         * guile/scm-ports.c: Use C++ exception handling.
7959         * guile/scm-param.c: Use C++ exception handling.
7960         * guile/scm-math.c: Use C++ exception handling.
7961         * guile/scm-lazy-string.c: Use C++ exception handling.
7962         * guile/scm-frame.c: Use C++ exception handling.
7963         * guile/scm-disasm.c: Use C++ exception handling.
7964         * guile/scm-cmd.c: Use C++ exception handling.
7965         * guile/scm-breakpoint.c: Use C++ exception handling.
7966         * guile/scm-block.c: Use C++ exception handling.
7967         * guile/guile-internal.h: Use C++ exception handling.
7968         * gnu-v3-abi.c: Use C++ exception handling.
7969         * gdbtypes.c: Use C++ exception handling.
7970         * frame.c: Use C++ exception handling.
7971         * frame-unwind.c: Use C++ exception handling.
7972         * fbsd-tdep.c: Use C++ exception handling.
7973         * f-valprint.c: Use C++ exception handling.
7974         * exec.c: Use C++ exception handling.
7975         * event-top.c: Use C++ exception handling.
7976         * event-loop.c: Use C++ exception handling.
7977         * eval.c: Use C++ exception handling.
7978         * dwarf2read.c: Use C++ exception handling.
7979         * dwarf2loc.c: Use C++ exception handling.
7980         * dwarf2-frame.c: Use C++ exception handling.
7981         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7982         * dwarf-index-write.c: Use C++ exception handling.
7983         * dwarf-index-cache.c: Use C++ exception handling.
7984         * dtrace-probe.c: Use C++ exception handling.
7985         * disasm-selftests.c: Use C++ exception handling.
7986         * darwin-nat.c: Use C++ exception handling.
7987         * cp-valprint.c: Use C++ exception handling.
7988         * cp-support.c: Use C++ exception handling.
7989         * cp-abi.c: Use C++ exception handling.
7990         * corelow.c: Use C++ exception handling.
7991         * completer.c: Use C++ exception handling.
7992         * compile/compile-object-run.c: Use C++ exception handling.
7993         * compile/compile-object-load.c: Use C++ exception handling.
7994         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7995         * compile/compile-c-symbols.c: Use C++ exception handling.
7996         * common/selftest.c: Use C++ exception handling.
7997         * common/new-op.c: Use C++ exception handling.
7998         * cli/cli-script.c: Use C++ exception handling.
7999         * cli/cli-interp.c: Use C++ exception handling.
8000         * cli/cli-cmds.c: Use C++ exception handling.
8001         * c-varobj.c: Use C++ exception handling.
8002         * btrace.c: Use C++ exception handling.
8003         * breakpoint.c: Use C++ exception handling.
8004         * break-catch-throw.c: Use C++ exception handling.
8005         * arch-utils.c: Use C++ exception handling.
8006         * amd64-tdep.c: Use C++ exception handling.
8007         * ada-valprint.c: Use C++ exception handling.
8008         * ada-typeprint.c: Use C++ exception handling.
8009         * ada-lang.c: Use C++ exception handling.
8010         * aarch64-tdep.c: Use C++ exception handling.
8011
8012 2019-04-08  Tom Tromey  <tom@tromey.com>
8013
8014         * xml-support.c (gdb_xml_parser::parse): Update.
8015         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8016         * value.c (show_convenience): Update.
8017         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8018         (test_parse_flags_qcs): Update.
8019         * thread.c (thr_try_catch_cmd): Update.
8020         * target.c (target_translate_tls_address): Update.
8021         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8022         (info_frame_command_core, frame_apply_command_count): Update.
8023         * rust-exp.y (rust_lex_exception_test): Update.
8024         * riscv-tdep.c (riscv_print_one_register_info): Update.
8025         * remote.c (remote_target::enable_btrace): Update.
8026         * record-btrace.c (record_btrace_enable_warn): Update.
8027         * python/py-utils.c (gdbpy_convert_exception): Update.
8028         * printcmd.c (do_one_display, print_variable_and_value): Update.
8029         * mi/mi-main.c (mi_print_exception): Update.
8030         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8031         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8032         * linux-nat.c (linux_nat_target::attach): Update.
8033         * linux-fork.c (class scoped_switch_fork_info): Update.
8034         * infrun.c (displaced_step_prepare): Update.
8035         * infcall.c (call_function_by_hand_dummy): Update.
8036         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8037         * gnu-v3-abi.c (print_one_vtable): Update.
8038         * frame.c (get_prev_frame_always): Update.
8039         * f-valprint.c (info_common_command_for_block): Update.
8040         * exec.c (try_open_exec_file): Update.
8041         * exceptions.c (print_exception, exception_print)
8042         (exception_fprintf, exception_print_same): Update.
8043         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8044         * dwarf-index-cache.c (index_cache::store)
8045         (index_cache::lookup_gdb_index): Update.
8046         * darwin-nat.c (maybe_cache_shell): Update.
8047         * cp-valprint.c (cp_print_value_fields): Update.
8048         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8049         (gcc_cplus_symbol_address): Update.
8050         * compile/compile-c-symbols.c (gcc_convert_symbol)
8051         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8052         * common/selftest.c: Update.
8053         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8054         a std::string.
8055         (exception_try_scope_entry, exception_try_scope_exit): Don't
8056         declare.
8057         (struct exception_try_scope): Remove.
8058         (TRY): Don't use exception_try_scope.
8059         (struct gdb_exception): Add constructor, operator=.
8060         <what>: New method.
8061         (struct gdb_exception_RETURN_MASK_ALL)
8062         (struct gdb_exception_RETURN_MASK_ERROR)
8063         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8064         (struct gdb_quit_bad_alloc): Update.
8065         * common/common-exceptions.c (exception_none): Change
8066         initializer.
8067         (struct catcher) <state, exception>: Initialize inline.
8068         <prev>: Remove member.
8069         (current_catcher): Remove.
8070         (catchers): New global.
8071         (exceptions_state_mc_init): Simplify.
8072         (catcher_pop): Remove.
8073         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8074         (try_scope_depth, exception_try_scope_entry)
8075         (exception_try_scope_exit): Remove.
8076         (throw_exception_sjlj): Update.
8077         (exception_messages, exception_messages_size): Remove.
8078         (throw_it): Simplify.
8079         (gdb_exception_sliced_copy): Remove.
8080         (throw_exception_cxx): Update.
8081         * cli/cli-script.c (script_from_file): Update.
8082         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8083         Update.
8084         * ada-valprint.c (ada_val_print): Update.
8085         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8086         (create_excep_cond_exprs): Update.
8087
8088 2019-04-08  Tom Tromey  <tom@tromey.com>
8089
8090         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8091         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8092         (TRY, CATCH, END_CATCH): Remove some definitions.
8093         * common/common-exceptions.c: Don't use GDB_XCPT.
8094         (catcher_list_size): Remove.
8095         (throw_exception, throw_it): Simplify.
8096
8097 2019-04-05  Tom Tromey  <tom@tromey.com>
8098
8099         Revert the header-sorting patch.
8100         * ft32-tdep.c: Revert.
8101         * frv-tdep.c: Revert.
8102         * frv-linux-tdep.c: Revert.
8103         * frame.c: Revert.
8104         * frame-unwind.c: Revert.
8105         * frame-base.c: Revert.
8106         * fork-child.c: Revert.
8107         * findvar.c: Revert.
8108         * findcmd.c: Revert.
8109         * filesystem.c: Revert.
8110         * filename-seen-cache.h: Revert.
8111         * filename-seen-cache.c: Revert.
8112         * fbsd-tdep.c: Revert.
8113         * fbsd-nat.h: Revert.
8114         * fbsd-nat.c: Revert.
8115         * f-valprint.c: Revert.
8116         * f-typeprint.c: Revert.
8117         * f-lang.c: Revert.
8118         * extension.h: Revert.
8119         * extension.c: Revert.
8120         * extension-priv.h: Revert.
8121         * expprint.c: Revert.
8122         * exec.h: Revert.
8123         * exec.c: Revert.
8124         * exceptions.c: Revert.
8125         * event-top.c: Revert.
8126         * event-loop.c: Revert.
8127         * eval.c: Revert.
8128         * elfread.c: Revert.
8129         * dwarf2read.h: Revert.
8130         * dwarf2read.c: Revert.
8131         * dwarf2loc.c: Revert.
8132         * dwarf2expr.h: Revert.
8133         * dwarf2expr.c: Revert.
8134         * dwarf2-frame.c: Revert.
8135         * dwarf2-frame-tailcall.c: Revert.
8136         * dwarf-index-write.h: Revert.
8137         * dwarf-index-write.c: Revert.
8138         * dwarf-index-common.c: Revert.
8139         * dwarf-index-cache.h: Revert.
8140         * dwarf-index-cache.c: Revert.
8141         * dummy-frame.c: Revert.
8142         * dtrace-probe.c: Revert.
8143         * disasm.h: Revert.
8144         * disasm.c: Revert.
8145         * disasm-selftests.c: Revert.
8146         * dictionary.c: Revert.
8147         * dicos-tdep.c: Revert.
8148         * demangle.c: Revert.
8149         * dcache.h: Revert.
8150         * dcache.c: Revert.
8151         * darwin-nat.h: Revert.
8152         * darwin-nat.c: Revert.
8153         * darwin-nat-info.c: Revert.
8154         * d-valprint.c: Revert.
8155         * d-namespace.c: Revert.
8156         * d-lang.c: Revert.
8157         * ctf.c: Revert.
8158         * csky-tdep.c: Revert.
8159         * csky-linux-tdep.c: Revert.
8160         * cris-tdep.c: Revert.
8161         * cris-linux-tdep.c: Revert.
8162         * cp-valprint.c: Revert.
8163         * cp-support.c: Revert.
8164         * cp-namespace.c: Revert.
8165         * cp-abi.c: Revert.
8166         * corelow.c: Revert.
8167         * corefile.c: Revert.
8168         * continuations.c: Revert.
8169         * completer.h: Revert.
8170         * completer.c: Revert.
8171         * complaints.c: Revert.
8172         * coffread.c: Revert.
8173         * coff-pe-read.c: Revert.
8174         * cli-out.h: Revert.
8175         * cli-out.c: Revert.
8176         * charset.c: Revert.
8177         * c-varobj.c: Revert.
8178         * c-valprint.c: Revert.
8179         * c-typeprint.c: Revert.
8180         * c-lang.c: Revert.
8181         * buildsym.c: Revert.
8182         * buildsym-legacy.c: Revert.
8183         * build-id.h: Revert.
8184         * build-id.c: Revert.
8185         * btrace.c: Revert.
8186         * bsd-uthread.c: Revert.
8187         * breakpoint.h: Revert.
8188         * breakpoint.c: Revert.
8189         * break-catch-throw.c: Revert.
8190         * break-catch-syscall.c: Revert.
8191         * break-catch-sig.c: Revert.
8192         * blockframe.c: Revert.
8193         * block.c: Revert.
8194         * bfin-tdep.c: Revert.
8195         * bfin-linux-tdep.c: Revert.
8196         * bfd-target.c: Revert.
8197         * bcache.c: Revert.
8198         * ax-general.c: Revert.
8199         * ax-gdb.h: Revert.
8200         * ax-gdb.c: Revert.
8201         * avr-tdep.c: Revert.
8202         * auxv.c: Revert.
8203         * auto-load.c: Revert.
8204         * arm-wince-tdep.c: Revert.
8205         * arm-tdep.c: Revert.
8206         * arm-symbian-tdep.c: Revert.
8207         * arm-pikeos-tdep.c: Revert.
8208         * arm-obsd-tdep.c: Revert.
8209         * arm-nbsd-tdep.c: Revert.
8210         * arm-nbsd-nat.c: Revert.
8211         * arm-linux-tdep.c: Revert.
8212         * arm-linux-nat.c: Revert.
8213         * arm-fbsd-tdep.c: Revert.
8214         * arm-fbsd-nat.c: Revert.
8215         * arm-bsd-tdep.c: Revert.
8216         * arch-utils.c: Revert.
8217         * arc-tdep.c: Revert.
8218         * arc-newlib-tdep.c: Revert.
8219         * annotate.h: Revert.
8220         * annotate.c: Revert.
8221         * amd64-windows-tdep.c: Revert.
8222         * amd64-windows-nat.c: Revert.
8223         * amd64-tdep.c: Revert.
8224         * amd64-sol2-tdep.c: Revert.
8225         * amd64-obsd-tdep.c: Revert.
8226         * amd64-obsd-nat.c: Revert.
8227         * amd64-nbsd-tdep.c: Revert.
8228         * amd64-nbsd-nat.c: Revert.
8229         * amd64-nat.c: Revert.
8230         * amd64-linux-tdep.c: Revert.
8231         * amd64-linux-nat.c: Revert.
8232         * amd64-fbsd-tdep.c: Revert.
8233         * amd64-fbsd-nat.c: Revert.
8234         * amd64-dicos-tdep.c: Revert.
8235         * amd64-darwin-tdep.c: Revert.
8236         * amd64-bsd-nat.c: Revert.
8237         * alpha-tdep.c: Revert.
8238         * alpha-obsd-tdep.c: Revert.
8239         * alpha-nbsd-tdep.c: Revert.
8240         * alpha-mdebug-tdep.c: Revert.
8241         * alpha-linux-tdep.c: Revert.
8242         * alpha-linux-nat.c: Revert.
8243         * alpha-bsd-tdep.c: Revert.
8244         * alpha-bsd-nat.c: Revert.
8245         * aix-thread.c: Revert.
8246         * agent.c: Revert.
8247         * addrmap.c: Revert.
8248         * ada-varobj.c: Revert.
8249         * ada-valprint.c: Revert.
8250         * ada-typeprint.c: Revert.
8251         * ada-tasks.c: Revert.
8252         * ada-lang.c: Revert.
8253         * aarch64-tdep.c: Revert.
8254         * aarch64-ravenscar-thread.c: Revert.
8255         * aarch64-newlib-tdep.c: Revert.
8256         * aarch64-linux-tdep.c: Revert.
8257         * aarch64-linux-nat.c: Revert.
8258         * aarch64-fbsd-tdep.c: Revert.
8259         * aarch64-fbsd-nat.c: Revert.
8260         * aarch32-linux-nat.c: Revert.
8261
8262 2019-04-05  Tom Tromey  <tom@tromey.com>
8263
8264         * ft32-tdep.c: Sort headers.
8265         * frv-tdep.c: Sort headers.
8266         * frv-linux-tdep.c: Sort headers.
8267         * frame.c: Sort headers.
8268         * frame-unwind.c: Sort headers.
8269         * frame-base.c: Sort headers.
8270         * fork-child.c: Sort headers.
8271         * findvar.c: Sort headers.
8272         * findcmd.c: Sort headers.
8273         * filesystem.c: Sort headers.
8274         * filename-seen-cache.h: Sort headers.
8275         * filename-seen-cache.c: Sort headers.
8276         * fbsd-tdep.c: Sort headers.
8277         * fbsd-nat.h: Sort headers.
8278         * fbsd-nat.c: Sort headers.
8279         * f-valprint.c: Sort headers.
8280         * f-typeprint.c: Sort headers.
8281         * f-lang.c: Sort headers.
8282         * extension.h: Sort headers.
8283         * extension.c: Sort headers.
8284         * extension-priv.h: Sort headers.
8285         * expprint.c: Sort headers.
8286         * exec.h: Sort headers.
8287         * exec.c: Sort headers.
8288         * exceptions.c: Sort headers.
8289         * event-top.c: Sort headers.
8290         * event-loop.c: Sort headers.
8291         * eval.c: Sort headers.
8292         * elfread.c: Sort headers.
8293         * dwarf2read.h: Sort headers.
8294         * dwarf2read.c: Sort headers.
8295         * dwarf2loc.c: Sort headers.
8296         * dwarf2expr.h: Sort headers.
8297         * dwarf2expr.c: Sort headers.
8298         * dwarf2-frame.c: Sort headers.
8299         * dwarf2-frame-tailcall.c: Sort headers.
8300         * dwarf-index-write.h: Sort headers.
8301         * dwarf-index-write.c: Sort headers.
8302         * dwarf-index-common.c: Sort headers.
8303         * dwarf-index-cache.h: Sort headers.
8304         * dwarf-index-cache.c: Sort headers.
8305         * dummy-frame.c: Sort headers.
8306         * dtrace-probe.c: Sort headers.
8307         * disasm.h: Sort headers.
8308         * disasm.c: Sort headers.
8309         * disasm-selftests.c: Sort headers.
8310         * dictionary.c: Sort headers.
8311         * dicos-tdep.c: Sort headers.
8312         * demangle.c: Sort headers.
8313         * dcache.h: Sort headers.
8314         * dcache.c: Sort headers.
8315         * darwin-nat.h: Sort headers.
8316         * darwin-nat.c: Sort headers.
8317         * darwin-nat-info.c: Sort headers.
8318         * d-valprint.c: Sort headers.
8319         * d-namespace.c: Sort headers.
8320         * d-lang.c: Sort headers.
8321         * ctf.c: Sort headers.
8322         * csky-tdep.c: Sort headers.
8323         * csky-linux-tdep.c: Sort headers.
8324         * cris-tdep.c: Sort headers.
8325         * cris-linux-tdep.c: Sort headers.
8326         * cp-valprint.c: Sort headers.
8327         * cp-support.c: Sort headers.
8328         * cp-namespace.c: Sort headers.
8329         * cp-abi.c: Sort headers.
8330         * corelow.c: Sort headers.
8331         * corefile.c: Sort headers.
8332         * continuations.c: Sort headers.
8333         * completer.h: Sort headers.
8334         * completer.c: Sort headers.
8335         * complaints.c: Sort headers.
8336         * coffread.c: Sort headers.
8337         * coff-pe-read.c: Sort headers.
8338         * cli-out.h: Sort headers.
8339         * cli-out.c: Sort headers.
8340         * charset.c: Sort headers.
8341         * c-varobj.c: Sort headers.
8342         * c-valprint.c: Sort headers.
8343         * c-typeprint.c: Sort headers.
8344         * c-lang.c: Sort headers.
8345         * buildsym.c: Sort headers.
8346         * buildsym-legacy.c: Sort headers.
8347         * build-id.h: Sort headers.
8348         * build-id.c: Sort headers.
8349         * btrace.c: Sort headers.
8350         * bsd-uthread.c: Sort headers.
8351         * breakpoint.h: Sort headers.
8352         * breakpoint.c: Sort headers.
8353         * break-catch-throw.c: Sort headers.
8354         * break-catch-syscall.c: Sort headers.
8355         * break-catch-sig.c: Sort headers.
8356         * blockframe.c: Sort headers.
8357         * block.c: Sort headers.
8358         * bfin-tdep.c: Sort headers.
8359         * bfin-linux-tdep.c: Sort headers.
8360         * bfd-target.c: Sort headers.
8361         * bcache.c: Sort headers.
8362         * ax-general.c: Sort headers.
8363         * ax-gdb.h: Sort headers.
8364         * ax-gdb.c: Sort headers.
8365         * avr-tdep.c: Sort headers.
8366         * auxv.c: Sort headers.
8367         * auto-load.c: Sort headers.
8368         * arm-wince-tdep.c: Sort headers.
8369         * arm-tdep.c: Sort headers.
8370         * arm-symbian-tdep.c: Sort headers.
8371         * arm-pikeos-tdep.c: Sort headers.
8372         * arm-obsd-tdep.c: Sort headers.
8373         * arm-nbsd-tdep.c: Sort headers.
8374         * arm-nbsd-nat.c: Sort headers.
8375         * arm-linux-tdep.c: Sort headers.
8376         * arm-linux-nat.c: Sort headers.
8377         * arm-fbsd-tdep.c: Sort headers.
8378         * arm-fbsd-nat.c: Sort headers.
8379         * arm-bsd-tdep.c: Sort headers.
8380         * arch-utils.c: Sort headers.
8381         * arc-tdep.c: Sort headers.
8382         * arc-newlib-tdep.c: Sort headers.
8383         * annotate.h: Sort headers.
8384         * annotate.c: Sort headers.
8385         * amd64-windows-tdep.c: Sort headers.
8386         * amd64-windows-nat.c: Sort headers.
8387         * amd64-tdep.c: Sort headers.
8388         * amd64-sol2-tdep.c: Sort headers.
8389         * amd64-obsd-tdep.c: Sort headers.
8390         * amd64-obsd-nat.c: Sort headers.
8391         * amd64-nbsd-tdep.c: Sort headers.
8392         * amd64-nbsd-nat.c: Sort headers.
8393         * amd64-nat.c: Sort headers.
8394         * amd64-linux-tdep.c: Sort headers.
8395         * amd64-linux-nat.c: Sort headers.
8396         * amd64-fbsd-tdep.c: Sort headers.
8397         * amd64-fbsd-nat.c: Sort headers.
8398         * amd64-dicos-tdep.c: Sort headers.
8399         * amd64-darwin-tdep.c: Sort headers.
8400         * amd64-bsd-nat.c: Sort headers.
8401         * alpha-tdep.c: Sort headers.
8402         * alpha-obsd-tdep.c: Sort headers.
8403         * alpha-nbsd-tdep.c: Sort headers.
8404         * alpha-mdebug-tdep.c: Sort headers.
8405         * alpha-linux-tdep.c: Sort headers.
8406         * alpha-linux-nat.c: Sort headers.
8407         * alpha-bsd-tdep.c: Sort headers.
8408         * alpha-bsd-nat.c: Sort headers.
8409         * aix-thread.c: Sort headers.
8410         * agent.c: Sort headers.
8411         * addrmap.c: Sort headers.
8412         * ada-varobj.c: Sort headers.
8413         * ada-valprint.c: Sort headers.
8414         * ada-typeprint.c: Sort headers.
8415         * ada-tasks.c: Sort headers.
8416         * ada-lang.c: Sort headers.
8417         * aarch64-tdep.c: Sort headers.
8418         * aarch64-ravenscar-thread.c: Sort headers.
8419         * aarch64-newlib-tdep.c: Sort headers.
8420         * aarch64-linux-tdep.c: Sort headers.
8421         * aarch64-linux-nat.c: Sort headers.
8422         * aarch64-fbsd-tdep.c: Sort headers.
8423         * aarch64-fbsd-nat.c: Sort headers.
8424         * aarch32-linux-nat.c: Sort headers.
8425
8426 2019-04-04  Tom Tromey  <tom@tromey.com>
8427
8428         * varobj.c (varobj_create): Update.
8429         * rust-exp.y (struct rust_parser) <update_innermost_block,
8430         lookup_symbol>: New methods.
8431         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8432         Rename.
8433         (rust_parser::rust_lookup_type)
8434         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8435         * printcmd.c (display_command, do_one_display): Update.
8436         * parser-defs.h (struct parser_state) <parser_state>: Add
8437         "tracker" parameter.
8438         (block_tracker): New member.
8439         (class innermost_block_tracker) <innermost_block_tracker>: Add
8440         "types" parameter.
8441         <reset>: Remove method.
8442         (innermost_block): Don't declare.
8443         (null_post_parser): Update.
8444         * parse.c (innermost_block): Remove global.
8445         (write_dollar_variable): Update.
8446         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8447         Remove "tracker_types" parameter.
8448         (parse_expression): Add "tracker" parameter.
8449         (parse_expression_for_completion): Update.
8450         (null_post_parser): Add "tracker" parameter.
8451         * p-exp.y: Update rules.
8452         * m2-exp.y: Update rules.
8453         * language.h (struct language_defn) <la_post_parser>: Add
8454         "tracker" parameter.
8455         * go-exp.y: Update rules.
8456         * f-exp.y: Update rules.
8457         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8458         parameter.
8459         * d-exp.y: Update rules.
8460         * c-exp.y: Update rules.
8461         * breakpoint.c (set_breakpoint_condition): Create an
8462         innermost_block_tracker.
8463         (watch_command_1): Likewise.
8464         * ada-lang.c (resolve): Add "tracker" parameter.
8465         (resolve_subexp): Likewise.
8466         * ada-exp.y (write_var_from_sym): Update.
8467
8468 2019-04-04  Tom Tromey  <tom@tromey.com>
8469
8470         * type-stack.h: New file.
8471         * type-stack.c: New file.
8472         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8473         type-stack.h.
8474         (insert_into_type_stack, insert_type, push_type, push_type_int)
8475         (insert_type_address_space, pop_type, pop_type_int)
8476         (pop_typelist, pop_type_stack, append_type_stack)
8477         (push_type_stack, get_type_stack, push_typelist)
8478         (follow_type_instance_flags, follow_types): Don't declare.
8479         * parse.c (type_stack): Remove global.
8480         (parse_exp_in_context): Update.
8481         (insert_into_type_stack, insert_type, push_type, push_type_int)
8482         (insert_type_address_space, pop_type, pop_type_int)
8483         (pop_typelist, pop_type_stack, append_type_stack)
8484         (push_type_stack, get_type_stack, push_typelist)
8485         (follow_type_instance_flags, follow_types): Remove (moved to
8486         type-stack.c).
8487         * f-exp.y (type_stack): New global.
8488         Update rules.
8489         (push_kind_type, f_parse): Update.
8490         * d-exp.y (type_stack): New global.
8491         Update rules.
8492         (d_parse): Update.
8493         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8494         Update rules.
8495         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8496         (HFILES_NO_SRCDIR): Add type-stack.h.
8497
8498 2019-04-04  Tom Tromey  <tom@tromey.com>
8499
8500         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8501         (rust_parser::convert_ast_to_expression, rust_parse)
8502         (rust_lex_test_completion, rust_lex_tests): Update.
8503         * parser-defs.h (struct expr_completion_state): New.
8504         (struct parser_state) <parser_state>: Add completion parameter.
8505         <mark_struct_expression, mark_completion_tag>: New methods.
8506         <parse_completion, m_completion_state>: New members.
8507         (prefixify_expression, null_post_parser): Update.
8508         (mark_struct_expression, mark_completion_tag): Don't declare.
8509         * parse.c (parse_completion, expout_last_struct)
8510         (expout_tag_completion_type, expout_completion_name): Remove
8511         globals.
8512         (parser_state::mark_struct_expression)
8513         (parser_state::mark_completion_tag): Now methods.
8514         (prefixify_expression): Add last_struct parameter.
8515         (prefixify_subexp): Likewise.
8516         (parse_exp_1): Update.
8517         (parse_exp_in_context): Add cstate parameter.  Update.
8518         (parse_expression_for_completion): Create an
8519         expr_completion_state.
8520         (null_post_parser): Add "completion" parameter.
8521         * p-exp.y: Update rules.
8522         (yylex): Update.
8523         * language.h (struct language_defn) <la_post_parser>: Add
8524         "completing" parameter.
8525         * go-exp.y: Update rules.
8526         (lex_one_token): Update.
8527         * expression.h (parse_completion): Don't declare.
8528         * d-exp.y: Update rules.
8529         (lex_one_token): Update rules.
8530         * c-exp.y: Update rules.
8531         (lex_one_token): Update.
8532         * ada-lang.c (resolve): Add "parse_completion" parameter.
8533         (resolve_subexp): Likewise.
8534         (ada_resolve_function): Likewise.
8535
8536 2019-04-04  Tom Tromey  <tom@tromey.com>
8537
8538         * parser-defs.h (struct parser_state) <start_arglist,
8539         end_arglist>: New methods.
8540         <arglist_len, m_funcall_chain>: New members.
8541         (arglist_len, start_arglist, end_arglist): Don't declare.
8542         * parse.c (arglist_len, funcall_chain): Remove global.
8543         (start_arglist, end_arglist): Remove functions.
8544         (parse_exp_in_context): Update.
8545         * p-exp.y: Update rules.
8546         * m2-exp.y: Update rules.
8547         * go-exp.y: Update rules.
8548         * f-exp.y: Update rules.
8549         * d-exp.y: Update rules.
8550         * c-exp.y: Update rules.
8551
8552 2019-04-04  Tom Tromey  <tom@tromey.com>
8553
8554         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8555         lex_operator, push_back>: New methods.
8556         Update all rules.
8557         (rust_parser::lex_hex, lex_escape): Rename and update.
8558         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8559         (rust_parser::lex_operator): Rename and update.
8560         (rust_parser::lex_number, rustyylex, rustyyerror)
8561         (rust_lex_test_init, rust_lex_test_sequence)
8562         (rust_lex_test_push_back, rust_lex_tests): Update.
8563         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8564         parameter.
8565         <lexptr, prev_lexptr>: New members.
8566         (lexptr, prev_lexptr): Don't declare.
8567         * parse.c (lexptr, prev_lexptr): Remove globals.
8568         (parse_exp_in_context): Update.
8569         * p-exp.y (yylex, yyerror): Update.
8570         * m2-exp.y (parse_number, yylex, yyerror): Update.
8571         * go-exp.y (lex_one_token, yyerror): Update.
8572         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8573         * d-exp.y (lex_one_token, yyerror): Update.
8574         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8575         (lex_one_token, yyerror): Update.
8576         * ada-lex.l (YY_INPUT): Update.
8577         (rewind_to_char): Update.
8578         * ada-exp.y (yyerror): Update.
8579
8580 2019-04-04  Tom Tromey  <tom@tromey.com>
8581
8582         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8583         * parser-defs.h (struct parser_state) <parser_state>: Add new
8584         parameter.
8585         <comma_terminates>: New member.
8586         (comma_terminates): Don't declare global.
8587         * parse.c (comma_terminates): Remove global.
8588         (parse_exp_in_context): Update.
8589         * p-exp.y (yylex): Update.
8590         * m2-exp.y (yylex): Update.
8591         * go-exp.y (lex_one_token): Update.
8592         * f-exp.y (yylex): Update.
8593         * d-exp.y (lex_one_token): Update.
8594         * c-exp.y (lex_one_token): Update.
8595         * ada-lex.l: Update.
8596
8597 2019-04-04  Tom Tromey  <tom@tromey.com>
8598
8599         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8600         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8601         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8602         * parser-defs.h (paren_depth): Don't declare.
8603         * parse.c (paren_depth): Remove global.
8604         (parse_exp_in_context): Update.
8605         * p-exp.y (paren_depth): New global.
8606         (pascal_parse): Initialize it.
8607         * m2-exp.y (paren_depth): New global.
8608         (m2_parse): Initialize it.
8609         * go-exp.y (paren_depth): New global.
8610         (go_parse): Initialize it.
8611         * f-exp.y (paren_depth): New global.
8612         (f_parse): Initialize it.
8613         * d-exp.y (paren_depth): New global.
8614         (d_parse): Initialize it.
8615         * c-exp.y (paren_depth): New global.
8616         (c_parse): Initialize it.
8617         * ada-lex.l (paren_depth): New global.
8618         (lexer_init): Initialize it.
8619
8620 2019-04-04  Tom Tromey  <tom@tromey.com>
8621
8622         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8623         (rust_parser::convert_ast_to_type)
8624         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8625         * parser-defs.h (struct parser_state) <parser_state>: Add
8626         parameters.  Initialize new members.
8627         <expression_context_block, expression_context_pc>: New members.
8628         * parse.c (expression_context_block, expression_context_pc):
8629         Remove globals.
8630         (parse_exp_in_context): Update.
8631         * p-exp.y: Update all rules.
8632         (yylex): Update.
8633         * m2-exp.y: Update all rules.
8634         (yylex): Update.
8635         * go-exp.y (yylex): Update.
8636         * f-exp.y (yylex): Update.
8637         * d-exp.y: Update all rules.
8638         (yylex): Update.
8639         * c-exp.y: Update all rules.
8640         (lex_one_token, classify_name, yylex, c_parse): Update.
8641         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8642
8643 2019-04-04  Tom Tromey  <tom@tromey.com>
8644
8645         * gdbarch.h, gdbarch.c: Rebuild.
8646         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8647         * stap-probe.h:
8648         (struct stap_parse_info): Replace "parser_state" with
8649         "expr_builder".
8650         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8651         (parser_state): New class.
8652         * parse.c (expr_builder): Rename.
8653         (expr_builder::release): Rename.
8654         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8655         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8656         (write_exp_elt_longcst, write_exp_elt_floatcst)
8657         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8658         (write_exp_string_vector, write_exp_bitstring)
8659         (write_exp_msymbol, mark_struct_expression)
8660         (write_dollar_variable)
8661         (insert_type_address_space, increase_expout_size): Replace
8662         "parser_state" with "expr_builder".
8663         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8664         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8665         "parser_state" with "expr_builder".
8666
8667 2019-04-04  Tom Tromey  <tom@tromey.com>
8668
8669         * rust-exp.y: Replace "parse_language" with method call.
8670         * p-exp.y:
8671         (yylex): Replace "parse_language" with method call.
8672         * m2-exp.y:
8673         (yylex): Replace "parse_language" with method call.
8674         * go-exp.y (classify_name): Replace "parse_language" with method
8675         call.
8676         * f-exp.y (yylex): Replace "parse_language" with method call.
8677         * d-exp.y (lex_one_token): Replace "parse_language" with method
8678         call.
8679         * c-exp.y:
8680         (lex_one_token, classify_name, yylex): Replace "parse_language"
8681         with method call.
8682         * ada-exp.y (find_primitive_type, type_char)
8683         (type_system_address): Replace "parse_language" with method call.
8684
8685 2019-04-04  Tom Tromey  <tom@tromey.com>
8686
8687         * rust-exp.y: Replace "parse_gdbarch" with method call.
8688         * parse.c (write_dollar_variable, insert_type_address_space):
8689         Replace "parse_gdbarch" with method call.
8690         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8691         call.
8692         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8693         call.
8694         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8695         "parse_gdbarch" with method call.
8696         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8697         with method call.
8698         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8699         "parse_gdbarch" with method call.
8700         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8701         "parse_gdbarch" with method call.
8702         * c-exp.y (parse_type, parse_number, classify_name): Replace
8703         "parse_gdbarch" with method call.
8704         * ada-lex.l: Replace "parse_gdbarch" with method call.
8705         * ada-exp.y (parse_type, find_primitive_type, type_char)
8706         (type_system_address): Replace "parse_gdbarch" with method call.
8707
8708 2019-04-04  Tom Tromey  <tom@tromey.com>
8709
8710         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8711         * stap-probe.c (stap_parse_argument): Update.
8712         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8713         initial_size parameter.
8714         * rust-exp.y (rust_lex_tests): Update.
8715         * parse.c (parser_state): Update.
8716         (parse_exp_in_context): Update.
8717         * parser-defs.h (struct parser_state) <parser_state>: Remove
8718         "initial_size" parameter.
8719
8720 2019-04-04  Tom Tromey  <tom@tromey.com>
8721
8722         * parser-defs.h (increase_expout_size): Don't declare.
8723         * parse.c (increase_expout_size): Now static.
8724
8725 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8726
8727         * gnu-nat.c (gnu_nat_target::wait): Fix
8728         target_waitstatus_to_string call.
8729
8730 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8731
8732         * eval.c (evaluate_subexp_standard): Handle internal functions
8733         during Fortran function call handling.
8734
8735 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8736
8737         * NEWS: Mention new internal functions.
8738         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8739         (read_base_type): Use dwarf2_init_complex_target_type.
8740         * value.c (creal_internal_fn): New function.
8741         (cimag_internal_fn): New function.
8742         (_initialize_values): Register new internal functions.
8743
8744 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8745
8746         * infrun.c (stop_all_threads): If debug_infrun, always
8747         trace the wait status after wait_one, using
8748         target_waitstatus_to_string and target_pid_to_str.
8749         (handle_inferior_event): Replace various trace of
8750         wait status kind by a single trace.
8751         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8752         wait status kind image by target_waitstatus_to_string.
8753         * target/waitstatus.c (target_waitstatus_to_string): Fix
8754         obsolete comment.
8755
8756 2019-04-01  Tom Tromey  <tromey@adacore.com>
8757
8758         PR symtab/23331:
8759         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8760
8761 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8762             Pedro Alves  <palves@redhat.com>
8763
8764         * top.c (quit_force): Call 'finalize_values'.
8765         * value.c (finalize_values): New function.
8766         * value.h (finalize_values): Declare.
8767
8768 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8769
8770         * NEWS: Announce $_gdb_major and $_gdb_minor.
8771
8772         * top.c (init_gdb_version_vars): New function.
8773         (gdb_init): Call init_gdb_version_vars.
8774
8775 2019-03-29  Tom Tromey  <tromey@adacore.com>
8776
8777         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8778         help text.  Remove dead code.
8779
8780 2019-03-29  Keith Seitz  <keiths@redhat.com>
8781
8782         From Siddhesh Poyarekar:
8783         * f-lang.h (f77_get_upperbound): Return LONGEST.
8784         (f77_get_lowerbound): Likewise.
8785         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8786         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8787         print them.
8788         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8789         plongest to format print it.
8790         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8791         (f77_get_upperbound): Likewise.
8792         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8793         LOWER_BOUND to LONGEST.
8794         (f77_create_arrayprint_offset_tbl): Likewise.
8795
8796 2019-03-29  Keith Seitz  <keiths@redhat.com>
8797
8798         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8799         %s/pulongest for TYPE_LENGTH instead of %d in format
8800         strings.
8801         * ada-typerint.c (ada_print_type): Likewise.
8802         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8803         * compile/compile-c-support.c (generate_register_struct): Likewise.
8804         * gdbtypes.c (recursive_dump_type): Likewise.
8805         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8806         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8807         instead of %d in format strings.
8808         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8809         to std::min to ULONGEST.
8810         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8811         instead of %d in format strings.
8812         * tracepoint.c (info_scope_command): Likewise.
8813         * typeprint.c (print_offset_data::update)
8814         (print_offset_data::finish): Likewise.
8815         * xtensa-tdep.c (xtensa_store_return_value)
8816         (xtensa_push_dummy_call): Likewise.
8817
8818 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8819
8820         * windows-nat.c (display_selector): Fixed format specifications
8821         for 64-bit Cygwin.
8822
8823 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8824
8825         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8826
8827 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8828
8829         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8830         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8831         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8832         (nios2_linux_init_abi): Install it.
8833
8834 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8835
8836         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8837
8838 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8839
8840         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8841
8842 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8843             Tom Tromey  <tromey@adacore.com>
8844
8845         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8846
8847 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8848
8849         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8850         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8851         method to compute the bounds of range types. Also print "[evaluated]"
8852         if the bounds' values come from a dynamic evaluation.
8853
8854 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8855
8856         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8857         whitespace when pretty printing is on.
8858
8859 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8860
8861         * ppc-linux-nat.c: Add include.
8862
8863 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8864
8865         * NEWS: Mention AArch64 Pointer Authentication.
8866
8867 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8868
8869         * arm-linux-nat.c: Add include.
8870
8871 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8872
8873         * source-cache.c (source_cache::get_source_lines): Re-read
8874         fullname after calling open_source_file.
8875
8876 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8877
8878         * NEWS: Mention TLS support for FreeBSD.
8879
8880 2019-03-25  Tom Tromey  <tromey@adacore.com>
8881
8882         * minsyms.c (BUNCH_SIZE): Update comment.
8883         (~minimal_symbol_reader): Remove old comment.
8884         (compact_minimal_symbols): Update comment.
8885         (minimal_symbol_reader::install): Remove old comment.  Update
8886         other comments.
8887
8888 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8889
8890         * s390-linux-nat.c: Add include.
8891
8892 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8893
8894         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8895         Call linux_get_hwcap.
8896         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8897         Likewise.
8898         (aarch64_linux_get_hwcap): Remove function.
8899         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8900         declaration.
8901         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8902         linux_get_hwcap.
8903         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8904         * linux-tdep.c (linux_get_hwcap): Add function.
8905         (linux_get_hwcap2): Likewise.
8906         * linux-tdep.h (linux_get_hwcap): Add declaration.
8907         (linux_get_hwcap2): Likewise.
8908         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8909         (ppc_linux_get_hwcap2): Likewise.
8910         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8911         linux_get_hwcap.
8912         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8913         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8914         (ppc_linux_nat_target::read_description): Likewise.
8915         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8916         * s390-linux-nat.c: Likewise.
8917         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8918
8919 2019-03-24  Tom Tromey  <tom@tromey.com>
8920
8921         * ada-lang.c (standard_lookup): Simplify initialization.
8922         (ada_lookup_symbol_nonlocal): Simplify return.
8923         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8924         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8925         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8926         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8927         initialization.
8928         * solib.c (solib_global_lookup): Simplify.
8929         * symtab.c (null_block_symbol): Remove.
8930         (symbol_cache_lookup): Simplify returns.
8931         (lookup_language_this): Simplify returns.
8932         (lookup_symbol_aux): Simplify return.
8933         (lookup_local_symbol): Simplify returns.
8934         (lookup_global_symbol_from_objfile): Simplify return.
8935         (lookup_symbol_in_objfile_symtabs)
8936         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8937         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8938         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8939         * cp-namespace.c (cp_lookup_bare_symbol)
8940         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8941         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8942         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8943         (cp_lookup_symbol_via_imports): Simplify initialization.
8944         (find_symbol_in_baseclass): Likewise.
8945         * symtab.h (null_block_symbol): Remove.
8946         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8947         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8948         (d_lookup_symbol_module): Likewise.
8949         (find_symbol_in_baseclass): Simplify initialization.
8950
8951 2019-03-24  Tom Tromey  <tom@tromey.com>
8952
8953         * expression.h: Don't include symtab.h.
8954         (struct block): Forward declare.
8955
8956 2019-03-24  Tom Tromey  <tom@tromey.com>
8957
8958         * c-exp.y (typebase): Remove casts.
8959         * gdbtypes.c (lookup_unsigned_typename, )
8960         (lookup_signed_typename): Remove cast.
8961         * eval.c (parse_to_comma_and_eval): Remove cast.
8962         * parse.c (write_dollar_variable): Remove cast.
8963         * block.h (struct block) <superblock>: Now const.
8964         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8965         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8966         (map_block): Make "block" const.
8967         * symfile.h (struct quick_symbol_functions)
8968         <map_matching_symbols>: Constify block argument to "callback".
8969         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8970         const.
8971         (find_pc_sect_compunit_symtab): Make "b" const.
8972         (find_symbol_at_address): Likewise.
8973         (search_symbols): Likewise.
8974         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8975         (dw2_debug_names_lookup_symbol): Likewise.
8976         (dw2_map_matching_symbols): Update.
8977         * p-valprint.c (pascal_val_print): Remove "block".
8978         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8979         (aux_add_nonlocal_symbols): Make "block" const.
8980         (resolve_subexp): Remove cast.
8981         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8982         const.
8983         (iterate_over_file_blocks): Likewise.
8984         * f-exp.y (%union) <bval>: Remove.
8985         * coffread.c (patch_opaque_types): Make "b" const.
8986         * spu-tdep.c (spu_catch_start): Make "block" const.
8987         * c-valprint.c (print_unpacked_pointer): Remove "block".
8988         * symmisc.c (dump_symtab_1): Make "b" const.
8989         (block_depth): Make "block" const.
8990         * d-exp.y (%union) <bval>: Remove.
8991         * cp-support.h (cp_lookup_rtti_type): Update.
8992         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8993         * psymtab.c (psym_lookup_symbol): Make "block" const.
8994         (maintenance_check_psymtabs): Make "b" const.
8995         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8996         (enumerate_locals, enumerate_args): Update.
8997         * python/py-symtab.c (stpy_global_block): Make "block" const.
8998         (stpy_static_block): Likewise.
8999         * inline-frame.c (block_starting_point_at): Make "new_block"
9000         const.
9001         * block.c (find_block_in_blockvector): Make return type const.
9002         (blockvector_for_pc_sect): Make "b" const.
9003         (find_block_in_blockvector): Make "b" const.
9004
9005 2019-03-23  Tom Tromey  <tom@tromey.com>
9006
9007         * varobj.c (varobj_create): Update.
9008         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9009         * printcmd.c (display_command, do_one_display): Don't reset
9010         innermost_block.
9011         * parser-defs.h (enum innermost_block_tracker_type): Move to
9012         expression.h.
9013         (innermost_block): Update comment.
9014         * parse.c (parse_exp_1): Add tracker_types parameter.
9015         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9016         tracker_types parameter.  Reset innermost_block.
9017         (parse_exp_in_context): Remove.
9018         (parse_expression_for_completion): Update.
9019         * objfiles.c (~objfile): Don't reset expression_context_block or
9020         innermost_block.
9021         * expression.h (enum innermost_block_tracker_type): Move from
9022         parser-defs.h.
9023         (parse_exp_1): Add tracker_types parameter.
9024         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9025         reset innermost_block.
9026
9027 2019-03-23  Tom Tromey  <tom@tromey.com>
9028
9029         * objfiles.h: Include bcache.h.
9030
9031 2019-03-23  Tom Tromey  <tom@tromey.com>
9032
9033         * linespec.c (get_current_search_block): Use
9034         scoped_restore_current_language.
9035         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9036
9037 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9038             Jiong Wang  <jiong.wang@arm.com>
9039
9040         * aarch64-linux-tdep.c
9041         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9042         section.
9043         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9044
9045 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9046             Jiong Wang  <jiong.wang@arm.com>
9047
9048         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9049         instructions.
9050         (aarch64_analyze_prologue_test): Add PACIASP test.
9051         (aarch64_prologue_prev_register): Unmask PC value.
9052
9053 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9054             Jiong Wang  <jiong.wang@arm.com>
9055
9056         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9057         (aarch64_dwarf2_prev_register): Unmask PC value.
9058         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9059         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9060         DW_CFA_AARCH64_negate_ra_state.
9061         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9062
9063 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9064             Jiong Wang  <jiong.wang@arm.com>
9065
9066         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9067         registers.
9068         (aarch64_pseudo_register_name): Likewise.
9069         (aarch64_pseudo_register_type): Likewise.
9070         (aarch64_pseudo_register_reggroup_p): Likewise.
9071         (aarch64_gdbarch_init): Add pauth registers.
9072         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9073         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9074         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9075         (struct gdbarch_tdep): Add regnum for ra_state.
9076
9077 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9078             Jiong Wang  <jiong.wang@arm.com>
9079
9080         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9081
9082 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9083             Jiong Wang  <jiong.wang@arm.com>
9084
9085         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9086         function.
9087         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9088         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9089         (aarch64_gdbarch_init): Add puth registers.
9090         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9091         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9092         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9093
9094 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9095             Jiong Wang  <jiong.wang@arm.com>
9096
9097         * aarch64-linux-nat.c
9098         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9099         * aarch64-linux-tdep.c
9100         (aarch64_linux_core_read_description): Likewise.
9101         (aarch64_linux_get_hwcap): New function.
9102         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9103         (aarch64_linux_get_hwcap): New declaration.
9104
9105 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9106             Jiong Wang  <jiong.wang@arm.com>
9107
9108         * aarch64-linux-nat.c
9109         (aarch64_linux_nat_target::read_description): Add pauth param.
9110         * aarch64-linux-tdep.c
9111         (aarch64_linux_core_read_description): Likewise.
9112         * aarch64-tdep.c (struct target_desc): Add in pauth.
9113         (aarch64_read_description): Add pauth param.
9114         (aarch64_gdbarch_init): Likewise.
9115         * aarch64-tdep.h (aarch64_read_description): Likewise.
9116         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9117         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9118         * features/Makefile: Add new files.
9119         * features/aarch64-pauth.c: New file.
9120         * features/aarch64-pauth.xml: New file.
9121
9122 2019-03-20  Tom Tromey  <tromey@adacore.com>
9123
9124         * infrun.c (handle_inferior_event): Rename from
9125         handle_inferior_event_1.  Create a scoped_value_mark.
9126         (handle_inferior_event): Remove.
9127
9128 2019-03-19  Tom Tromey  <tromey@adacore.com>
9129
9130         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9131         * infrun.h (print_stop_event): Add "displays" parameter.
9132         * infrun.c (print_stop_event): Add "displays" parameter.
9133
9134 2019-03-19  Pedro Alves  <palves@redhat.com>
9135
9136         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9137         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9138         to -1.  Fix TABs vs spaces.
9139         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9140         * tui/tui-out.h (tui_ui_out) Add intro comments.
9141         <m_line, m_start_of_line>: In-class initialize, and add describing
9142         comment.
9143
9144 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9145
9146         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9147         variable names.
9148         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9149
9150 2019-03-18  Pedro Alves  <palves@redhat.com>
9151             Eli Zaretskii <eliz@gnu.org>
9152
9153         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9154         m_line and m_start_of_line.
9155
9156 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9157
9158         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9159         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9160         it returns a newline.  This fixes a regression in TU mode, whereby
9161         the next line is output on the same screen line as the user input.
9162
9163 2019-03-18  Tom Tromey  <tromey@adacore.com>
9164
9165         * minsyms.c (minimal_symbol_reader::install): Remove call to
9166         obstack_blank.
9167
9168 2019-03-18  Pedro Alves  <palves@redhat.com>
9169
9170         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9171         New globals.
9172         (apply_style): New, factored out from ...
9173         (apply_ansi_escape): ... this.  Handle reverse video mode.
9174         (tui_set_reverse_mode): New function.
9175         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9176         * tui/tui-winsource.c (tui_show_source_line): Use
9177         tui_set_reverse_mode instead of setting A_STANDOUT.
9178         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9179         New setter methods.
9180
9181 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9182
9183         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9184         Handle tabs.
9185
9186 2019-03-18  Tom Tromey  <tromey@adacore.com>
9187
9188         * ada-lang.c (empty_array): Add "high" parameter.
9189         (ada_evaluate_subexp): Update.
9190
9191 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9192
9193         * unittests/string_view-selftests.c: Define
9194         _initialize_string_view_selftests unconditionally.
9195
9196 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9197
9198         PR gdb/24350
9199         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9200
9201 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9202
9203         PR gdb/24351
9204         * windows-nat.c (display_selector): Fix format specifiers.
9205
9206 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9207
9208         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9209         tui_refill_source_window instead of tui_refresh_win, to update the
9210         current execution line.  This fixes redisplay of the current line
9211         when stepping through the code with "next" or "step".
9212
9213 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9214
9215         * source-cache.c (source_cache::get_source_lines): Call
9216         find_source_lines to initialize s->nlines.  This fixes vertical
9217         scrolling of TUI source window when the DOWN arrow is pressed.
9218
9219 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9220
9221         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9222         linux-thread-db.c (_initialize_thread_db): Likewise.
9223
9224 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9225
9226         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9227         wclrtoeol in tui_show_source_line".  This reverts changes made in
9228         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9229
9230 2019-03-15  Tom Tromey  <tom@tromey.com>
9231
9232         * symtab.h (struct minimal_symbol): Derive from
9233         general_symbol_info.
9234         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9235         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9236         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9237         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9238         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9239         (MSYMBOL_SEARCH_NAME): Update.
9240         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9241         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9242         * minsyms.c (minimal_symbol_reader::record_full): Update.
9243
9244 2019-03-15  Tom Tromey  <tom@tromey.com>
9245
9246         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9247
9248 2019-03-15  Tom Tromey  <tom@tromey.com>
9249
9250         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9251         unique_xmalloc_ptr.
9252         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9253         Update.
9254         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9255         (build_minimal_symbol_hash_tables)
9256         (minimal_symbol_reader::install): Update.
9257
9258 2019-03-15  Tom Tromey  <tom@tromey.com>
9259
9260         * symtab.c (create_demangled_names_hash): Update.
9261         (symbol_set_names): Update.
9262         * objfiles.h (struct objfile_per_bfd_storage)
9263         <demangled_names_hash>: Now an htab_up.
9264         * objfiles.c (objfile_per_bfd_storage): Simplify.
9265
9266 2019-03-15  Tom Tromey  <tom@tromey.com>
9267
9268         * objfiles.h (struct objfile_per_bfd_storage): Declare
9269         destructor.
9270         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9271         New.
9272         (get_objfile_bfd_data): Use new.  Don't initialize
9273         language_of_main.
9274         (free_objfile_per_bfd_storage): Remove.
9275         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9276
9277 2019-03-15  Tom Tromey  <tom@tromey.com>
9278
9279         * symfile.c (reread_symbols): Update.
9280         * objfiles.c (objfile::objfile): Update.
9281         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9282         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9283         comment.
9284         (minimal_symbol_reader::install): Update.
9285         (terminate_minimal_symbol_table): Remove.
9286         * jit.c (jit_object_close_impl): Update.
9287
9288 2019-03-15  Tom Tromey  <tom@tromey.com>
9289
9290         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9291         initializations.
9292
9293 2019-03-15  Tom Tromey  <tom@tromey.com>
9294
9295         * objfiles.h (struct objfile_per_bfd_storage)
9296         <demangled_hash_languages>: Now a bitset.
9297         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9298         (lookup_minimal_symbol): Update.
9299
9300 2019-03-15  Tom Tromey  <tom@tromey.com>
9301
9302         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9303         Don't return the symbol.
9304         * coffread.c (record_minimal_symbol): Use record_full.
9305
9306 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9307
9308         The MS-Windows port of ncurses fails to switch to a color pair if
9309         one or both of the colors are the implicit default colors.  This
9310         change records the default colors when TUI is initialized, and
9311         then specifies them explicitly when a color pair uses the default
9312         colors.  This allows color styling in TUI mode on MS-Windows.
9313
9314         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9315         ncurses_norm_attr.
9316         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9317         colors in ncurses_norm_attr.
9318         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9319         "none", replace it with the default color recorded in
9320         ncurses_norm_attr.
9321
9322 2019-03-14  Tom Tromey  <tromey@adacore.com>
9323
9324         * source-cache.h (class source_cache) <get_source_lines>: Return
9325         std::string.
9326         * source-cache.c (source_cache::extract_lines): Handle case where
9327         first_pos==npos.  Return std::string.
9328         (source_cache::get_source_lines): Update.
9329
9330 2019-03-14  Tom Tromey  <tromey@adacore.com>
9331
9332         * NEWS: Add item for "style sources" commands.
9333         * source-cache.c (source_cache::get_source_lines): Check
9334         source_styling.
9335         * cli/cli-style.c (source_styling): New global.
9336         (_initialize_cli_style): Add "style sources" commands.
9337         (show_style_sources): New function.
9338         * cli/cli-style.h (source_styling): Declare.
9339
9340 2019-03-14  Pedro Alves  <palves@redhat.com>
9341             Tom Tromey  <tromey@adacore.com>
9342
9343         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9344         * tui/tui-winsource.c (tui_refill_source_window): New function,
9345         from...
9346         (tui_horizontal_source_scroll): ... here.  Move some logic.
9347         * cli/cli-style.c (set_style_enabled): Notify new observable.
9348         * tui/tui-hooks.c (tui_redisplay_source): New function.
9349         (tui_attach_detach_observers): Attach or detach
9350         tui_redisplay_source.
9351         * observable.h (source_styling_changed): New observable.
9352         * observable.c: Define source_styling_changed observable.
9353
9354 2019-03-13  Tom Tromey  <tromey@adacore.com>
9355
9356         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9357         (i386_gnu_nat_target::store_registers): Update.
9358         * target-debug.h (target_debug_print_std_string): New macro.
9359         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9360         * windows-tdep.c (display_one_tib): Update.
9361         * tui/tui-stack.c (tui_make_status_line): Update.
9362         * top.c (print_inferior_quit_action): Update.
9363         * thread.c (thr_try_catch_cmd): Update.
9364         (add_thread_with_info): Update.
9365         (thread_target_id_str): Update.
9366         (thr_try_catch_cmd): Update.
9367         (thread_command): Update.
9368         (thread_find_command): Update.
9369         * record-btrace.c (record_btrace_target::info_record)
9370         (record_btrace_resume_thread, record_btrace_target::resume)
9371         (record_btrace_cancel_resume, record_btrace_step_thread)
9372         (record_btrace_target::wait, record_btrace_target::wait)
9373         (record_btrace_target::wait, record_btrace_target::stop): Update.
9374         * progspace.c (print_program_space): Update.
9375         * process-stratum-target.c
9376         (process_stratum_target::thread_address_space): Update.
9377         * linux-fork.c (linux_fork_mourn_inferior)
9378         (detach_checkpoint_command, info_checkpoints_command)
9379         (linux_fork_context): Update.
9380         (linux_fork_detach): Update.
9381         (class scoped_switch_fork_info): Update.
9382         (delete_checkpoint_command): Update.
9383         * infrun.c (follow_fork_inferior): Update.
9384         (follow_fork_inferior): Update.
9385         (proceed_after_vfork_done): Update.
9386         (handle_vfork_child_exec_or_exit): Update.
9387         (follow_exec): Update.
9388         (displaced_step_prepare_throw): Update.
9389         (displaced_step_restore): Update.
9390         (start_step_over): Update.
9391         (resume_1): Update.
9392         (clear_proceed_status_thread): Update.
9393         (proceed): Update.
9394         (print_target_wait_results): Update.
9395         (do_target_wait): Update.
9396         (context_switch): Update.
9397         (stop_all_threads): Update.
9398         (restart_threads): Update.
9399         (finish_step_over): Update.
9400         (handle_signal_stop): Update.
9401         (switch_back_to_stepped_thread): Update.
9402         (keep_going_pass_signal): Update.
9403         (print_exited_reason): Update.
9404         (normal_stop): Update.
9405         * inferior.c (inferior_pid_to_str): Change return type.
9406         (print_selected_inferior): Update.
9407         (add_inferior): Update.
9408         (detach_inferior): Update.
9409         * dummy-frame.c (fprint_dummy_frames): Update.
9410         * dcache.c (dcache_info_1): Update.
9411         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9412         (btrace_fetch, btrace_clear): Update.
9413         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9414         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9415         type.
9416         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9417         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9418         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9419         * gdbarch.c, gdbarch.h: Rebuild.
9420         * gdbarch.sh (core_pid_to_str): Change return type.
9421         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9422         return type.
9423         (windows_nat_target::pid_to_str): Change return type.
9424         (windows_delete_thread): Update.
9425         (windows_nat_target::attach): Update.
9426         (windows_nat_target::files_info): Update.
9427         * target-delegates.c: Rebuild.
9428         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9429         return type.
9430         (sol_thread_target::pid_to_str): Change return type.
9431         * remote.c (class remote_target) <pid_to_str>: Change return
9432         type.
9433         (remote_target::pid_to_str): Change return type.
9434         (extended_remote_target::attach, remote_target::remote_stop_ns)
9435         (remote_target::remote_notif_remove_queued_reply)
9436         (remote_target::push_stop_reply, remote_target::disable_btrace):
9437         Update.
9438         (extended_remote_target::attach): Update.
9439         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9440         type.
9441         (gdbsim_target::pid_to_str): Change return type.
9442         * ravenscar-thread.c (struct ravenscar_thread_target)
9443         <pid_to_str>: Change return type.
9444         (ravenscar_thread_target::pid_to_str): Change return type.
9445         * procfs.c (class procfs_target) <pid_to_str>: Change return
9446         type.
9447         (procfs_target::pid_to_str): Change return type.
9448         (procfs_target::attach): Update.
9449         (procfs_target::detach): Update.
9450         (procfs_target::fetch_registers): Update.
9451         (procfs_target::store_registers): Update.
9452         (procfs_target::wait): Update.
9453         (procfs_target::files_info): Update.
9454         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9455         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9456         return type.
9457         (nto_procfs_target::pid_to_str): Change return type.
9458         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9459         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9460         return type.
9461         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9462         (exit_lwp): Update.
9463         (attach_proc_task_lwp_callback, get_detach_signal)
9464         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9465         (linux_nat_target::resume, wait_lwp, stop_callback)
9466         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9467         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9468         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9469         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9470         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9471         type.
9472         (inf_ptrace_target::attach): Update.
9473         (inf_ptrace_target::files_info): Update.
9474         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9475         type.
9476         (go32_nat_target::pid_to_str): Change return type.
9477         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9478         (gnu_nat_target::wait): Update.
9479         (gnu_nat_target::wait): Update.
9480         (gnu_nat_target::resume): Update.
9481         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9482         (fbsd_nat_target::wait): Update.
9483         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9484         type.
9485         (darwin_nat_target::attach): Update.
9486         * corelow.c (class core_target) <pid_to_str>: Change return type.
9487         (core_target::pid_to_str): Change return type.
9488         * target.c (normal_pid_to_str): Change return type.
9489         (default_pid_to_str): Likewise.
9490         (target_pid_to_str): Change return type.
9491         (target_translate_tls_address): Update.
9492         (target_announce_detach): Update.
9493         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9494         return type.
9495         (bsd_uthread_target::pid_to_str): Change return type.
9496         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9497         type.
9498         (bsd_kvm_target::pid_to_str): Change return type.
9499         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9500         return type.
9501         (aix_thread_target::pid_to_str): Change return type.
9502         * target.h (struct target_ops) <pid_to_str>: Change return type.
9503         (target_pid_to_str, normal_pid_to_str): Likewise.
9504         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9505         type.
9506         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9507         type.
9508         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9509         return type.
9510         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9511         type.
9512         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9513         type.
9514         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9515         return type.
9516
9517 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9518
9519         * NEWS: Mention that the new default MI version is 3.  Mention
9520         changes to the output of commands and events that deal with
9521         multi-location breakpoints.
9522         * breakpoint.c: Include "mi/mi-out.h".
9523         (print_one_breakpoint): Change output syntax if using MI version
9524         >= 3.
9525         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9526         New.
9527         (mi_multi_location_breakpoint_output_fixed): New.
9528         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9529         (mi_cmd_fix_multi_location_breakpoint_output): New.
9530         (mi_multi_location_breakpoint_output_fixed): New.
9531         * mi/mi-cmds.c (mi_cmds): Register command
9532         -fix-multi-location-breakpoint-output.
9533         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9534         interpreter "mi".
9535
9536 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9537
9538         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9539         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9540         instantiate mi_ui_out based on interpreter name.
9541         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9542         * mi/mi-main.c (mi_load_progress): Likewise.
9543
9544 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9545
9546         * NEWS: Combine separate "New targets" sections for 8.3.
9547
9548 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9549
9550         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9551         (ppcfbsd_init_abi): Install gdbarch
9552         "fetch_tls_load_module_address" and "get_thread_local_address"
9553         methods.
9554
9555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9556
9557         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9558         (riscv_fbsd_init_abi): Install gdbarch
9559         "fetch_tls_load_module_address" and "get_thread_local_address"
9560         methods.
9561
9562 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9563
9564         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9565         (i386fbsd_init_abi): Install gdbarch
9566         "fetch_tls_load_module_address" and "get_thread_local_address"
9567         methods.
9568
9569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9570
9571         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9572         (amd64fbsd_init_abi): Install gdbarch
9573         "fetch_tls_load_module_address" and "get_thread_local_address"
9574         methods.
9575
9576 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9577
9578         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9579         (struct fbsd_pspace_data): New type.
9580         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9581         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9582         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9583         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9584         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9585
9586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9587
9588         * gdbtypes.c (lookup_struct_elt): New function.
9589         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9590         * gdbtypes.h (struct struct_elt): New type.
9591         (lookup_struct_elt): New prototype.
9592
9593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9594
9595         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9596         remove disabled code block.
9597
9598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9599
9600         * gdbarch.sh (get_thread_local_address): New method.
9601         * gdbarch.h, gdbarch.c: Regenerate.
9602         * target.c (target_translate_tls_address): Use
9603         gdbarch_get_thread_local_address if present instead of
9604         target::get_thread_local_address.
9605
9606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9607
9608         * target.h (target::get_thread_local_address): Update comment.
9609
9610 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9611
9612         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9613         objfile->separate_debug_objfile_backlink if not NULL.
9614
9615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9616
9617         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9618         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9619         (amd64bsd_store_inferior_registers): Likewise.
9620         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9621         Enable segment base registers.
9622         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9623         PT_GETFSBASE and PT_GETGSBASE.
9624         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9625         PT_SETGSBASE.
9626         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9627         segment base registers.
9628         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9629
9630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9631
9632         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9633         Update calls to i386_target_description to add 'segments'
9634         parameter.
9635         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9636         add segment base registers.
9637         * arch/i386.c (i386_create_target_description): Add 'segments'
9638         parameter to enable segment base registers.
9639         * arch/i386.h (i386_create_target_description): Likewise.
9640         * features/i386/32bit-segments.xml: New file.
9641         * features/i386/32bit-segments.c: Generate.
9642         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9643         call to i386_target_description to add 'segments' parameter.
9644         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9645         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9646         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9647         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9648         if feature is present.
9649         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9650         Add 'segments' parameter to call to i386_target_description.
9651         (i386_target_description): Add 'segments' parameter to enable
9652         segment base registers.
9653         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9654         to call to i386_target_description.
9655         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9656         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9657         Define I386_NUM_REGS.
9658         (i386_target_description): Add 'segments' parameter to enable
9659         segment base registers.
9660
9661 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9662
9663         PR/24325
9664         * source-cache.c: #undef open and close, to avoid unresolved
9665         externals during linking.
9666
9667 2019-03-12  Tom Tromey  <tromey@adacore.com>
9668
9669         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9670         const.  Add initializers.
9671         (_initialize_remote): Don't initialize ptid globals.
9672
9673 2019-03-12  Pedro Alves  <palves@redhat.com>
9674
9675         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9676
9677 2019-03-12  Pedro Alves  <palves@redhat.com>
9678
9679         * cp-name-parser.y (main): Remove unused 'len' variable.
9680
9681 2019-03-12  Tom Tromey  <tromey@adacore.com>
9682
9683         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9684         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9685
9686 2019-03-12  Tom Tromey  <tromey@adacore.com>
9687
9688         * linux-nat.c (iterate_over_lwps): Update.
9689         (stop_callback): Remove parameter.
9690         (stop_wait_callback, detach_callback, resume_set_callback)
9691         (select_singlestep_lwp_callback, set_ignore_sigint)
9692         (status_callback, resumed_callback, resume_clear_callback)
9693         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9694         data parameter.
9695         (linux_nat_target::detach, linux_nat_target::resume)
9696         (linux_stop_and_wait_all_lwps, select_event_lwp)
9697         (linux_nat_filter_event, linux_nat_wait_1)
9698         (linux_nat_target::kill, linux_nat_target::stop)
9699         (linux_nat_target::stop): Update.
9700         (linux_nat_resume_callback): Change type.
9701         (resume_stopped_resumed_lwps, count_events_callback)
9702         (select_event_lwp_callback): Likewise.
9703         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9704         * arm-linux-nat.c (struct update_registers_data): Remove.
9705         (update_registers_callback): Change type.
9706         (arm_linux_insert_hw_breakpoint1): Update.
9707         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9708         parameter.
9709         (x86_linux_dr_set_addr): Update.
9710         (x86_linux_dr_set_control): Update.
9711         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9712         (iterate_over_lwps): Use gdb::function_view.
9713         * nat/aarch64-linux-hw-point.c (struct
9714         aarch64_dr_update_callback_param): Remove.
9715         (debug_reg_change_callback): Change type.
9716         (aarch64_notify_debug_reg_change): Update.
9717         * s390-linux-nat.c (s390_refresh_per_info): Update.
9718
9719 2019-03-11  Tom Tromey  <tromey@adacore.com>
9720
9721         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9722         redundant assignment to "this_cu".
9723
9724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9725
9726         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9727
9728 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9729
9730         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9731         from...
9732         (rank_one_type): ... this.
9733
9734 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9735
9736         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9737         from...
9738         (rank_one_type): ... this.
9739
9740 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9741
9742         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9743         from...
9744         (rank_one_type): ... this.
9745
9746 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9747
9748         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9749         from...
9750         (rank_one_type): ... this.
9751
9752 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9753
9754         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9755         from...
9756         (rank_one_type): ... this.
9757
9758 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9759
9760         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9761         from...
9762         (rank_one_type): ... this.
9763
9764 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9765
9766         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9767         from...
9768         (rank_one_type): ... this.
9769
9770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9771
9772         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9773         from...
9774         (rank_one_type): ... this.
9775
9776 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9777
9778         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9779         from...
9780         (rank_one_type): ... this.
9781
9782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9783
9784         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9785         from...
9786         (rank_one_type): ... this.
9787
9788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9789
9790         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9791         from...
9792         (rank_one_type): ... this.
9793
9794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9795
9796         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9797         from...
9798         (rank_one_type): ... this.
9799
9800 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9801
9802         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9803         inferior-events' shows the example events.
9804
9805 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9806
9807         Support styling on native MS-Windows console
9808
9809         PR/24315
9810         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9811         on MS-Windows if $TERM is not defined.
9812
9813         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9814
9815         * posix-hdep.c (gdb_console_fputs):
9816         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9817         functions.
9818         * ui-file.h (gdb_console_fputs): Add prototype.
9819
9820         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9821         back to fputs only if the former returns zero.
9822
9823 2019-03-07  Tom Tromey  <tom@tromey.com>
9824
9825         * symmisc.c (print_symbol_bcache_statistics): Update.
9826         (print_objfile_statistics): Update.
9827         * symfile.c (allocate_symtab): Update.
9828         * stabsread.c: Don't include bcache.h.
9829         * psymtab.h (struct psymbol_bcache): Don't declare.
9830         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9831         (psymbol_bcache_init, psymbol_bcache_free)
9832         (psymbol_bcache_get_bcache): Don't declare.
9833         * psymtab.c (struct psymbol_bcache): Remove.
9834         (psymtab_storage::psymtab_storage): Update.
9835         (psymtab_storage::~psymtab_storage): Update.
9836         (psymbol_bcache_init, psymbol_bcache_free)
9837         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9838         (add_psymbol_to_bcache): Update.
9839         (allocate_psymtab): Update.
9840         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9841         macro_cache>: No longer pointers.
9842         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9843         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9844         * macrotab.c (macro_bcache): Update.
9845         * macroexp.c: Don't include bcache.h.
9846         * gdbtypes.c (check_types_worklist): Update.
9847         (types_deeply_equal): Remove TRY/CATCH.  Update.
9848         * elfread.c (elf_symtab_read): Update.
9849         * dwarf2read.c: Don't include bcache.h.
9850         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9851         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9852         (print_bcache_statistics, bcache_memory_used): Don't declare.
9853         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9854         methods.  Rename all data members.
9855         * bcache.c (struct bcache): Move to bcache.h.
9856         (bcache::expand_hash_table): Rename from expand_hash_table.
9857         (bcache): Remove.
9858         (bcache::insert): Rename from bcache_full.
9859         (bcache::compare): Rename from bcache_compare.
9860         (bcache_xmalloc): Remove.
9861         (bcache::~bcache): Rename from bcache_xfree.
9862         (bcache::print_statistics): Rename from print_bcache_statistics.
9863         (bcache::memory_used): Rename from bcache_memory_used.
9864
9865 2019-03-07  Pedro Alves  <palves@redhat.com>
9866
9867         * infrun.c (normal_stop): Also check for
9868         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9869
9870 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9871
9872         * f-lang.c (value_from_host_double): Moved to...
9873         * value.c (value_from_host_double): ...here.
9874         * value.h (value_from_host_double): Declare.
9875         * guile/scm-math.c (vlscm_convert_typed_number): Use
9876         value_from_host_double.
9877         (vlscm_convert_number): Likewise.
9878         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9879         * python/py-value.c (convert_value_from_python): Likewise.
9880
9881 2019-03-06  Tom Tromey  <tom@tromey.com>
9882
9883         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9884
9885 2019-03-06  Tom Tromey  <tom@tromey.com>
9886
9887         * utils.h (free_current_contents): Don't declare.
9888         * utils.c (free_current_contents): Remove.
9889
9890 2019-03-06  Tom Tromey  <tom@tromey.com>
9891
9892         * top.c (quit_force): Update.
9893         * main.c (captured_command_loop): Update.
9894         * common/new-op.c (operator new): Update.
9895         * common/common-exceptions.c (struct catcher)
9896         <save_cleanup_chain>: Remove member.
9897         (exceptions_state_mc_init): Update.
9898         (exception_try_scope_entry): Return nullptr.
9899         (exception_try_scope_exit, exception_rethrow)
9900         (throw_exception_sjlj, throw_exception_cxx): Update.
9901         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9902         (all_cleanups, do_cleanups, discard_cleanups)
9903         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9904         (restore_cleanups, restore_final_cleanups): Don't declare.
9905         (do_final_cleanups): Remove parameter.
9906         * common/cleanups.c (cleanup_chain, make_cleanup)
9907         (make_cleanup_dtor, all_cleanups, do_cleanups)
9908         (discard_my_cleanups, discard_cleanups)
9909         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9910         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9911         (null_cleanup): Remove.
9912         (do_final_cleanups): Remove parameter.
9913
9914 2019-03-06  Tom Tromey  <tom@tromey.com>
9915
9916         * remote.c (remote_target::remote_parse_stop_reply): Use
9917         unique_xmalloc_ptr.
9918
9919 2019-03-06  Tom Tromey  <tom@tromey.com>
9920
9921         * stabsread.c (struct stabs_field_info): Rename from field_info.
9922         <list, fnlist>: Add initializers.
9923         <obstack>: New member.
9924         (read_member_functions, read_struct_fields, read_baseclasses):
9925         Allocate on obstack.  Don't use cleanups.
9926         (read_one_struct_field, read_member_functions, read_struct_fields)
9927         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9928         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9929         (read_struct_type): Update.
9930
9931 2019-03-06  Tom Tromey  <tom@tromey.com>
9932
9933         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9934         * common/filestuff.h (make_cleanup_close): Don't declare.
9935         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9936         Remove.
9937
9938 2019-03-06  Tom Tromey  <tom@tromey.com>
9939
9940         * solib-aix.c: Use make_scope_exit.
9941
9942 2019-03-06  Tom Tromey  <tom@tromey.com>
9943
9944         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9945         Use make_scope_exit.
9946
9947 2019-03-06  Tom Tromey  <tom@tromey.com>
9948
9949         * solib-svr4.c (disable_probes_interface): Remove parameter.
9950         (svr4_handle_solib_event): Use make_scope_exit.
9951
9952 2019-03-06  Tom Tromey  <tom@tromey.com>
9953
9954         * remote.c (struct stop_reply_deleter): Remove.
9955         (stop_reply_up): Update.
9956         (struct stop_reply): Derive from notif_event.  Don't typedef.
9957         <regcache>: Now a std::vector.
9958         (stop_reply_xfree): Remove.
9959         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9960         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9961         (remote_target::discard_pending_stop_replies): Use delete.
9962         (remote_target::remote_parse_stop_reply): Update.
9963         (remote_target::process_stop_reply): Update.
9964         * remote-notif.h (struct notif_event): Add virtual destructor.
9965         Remove "dtr" member.
9966         (struct notif_client) <alloc_event>: Return a unique_ptr.
9967         (notif_event_xfree): Don't declare.
9968         (notif_event_up): New typedef.
9969         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9970         (notif_event_xfree, do_notif_event_xfree): Remove.
9971         (remote_notif_state_xfree): Update.
9972
9973 2019-03-06  Tom Tromey  <tom@tromey.com>
9974
9975         * infrun.c (displaced_step_clear_cleanup): Now a
9976         forward_scope_exit type.
9977         (displaced_step_prepare_throw): Update.
9978         (displaced_step_fixup): Update.
9979
9980 2019-03-06  Tom Tromey  <tom@tromey.com>
9981
9982         * inferior.h (class inferior): Update comment.
9983         * gdbthread.h (class thread_info): Update comment.
9984
9985 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9986             Tom Tromey  <tom@tromey.com>
9987
9988         * stabsread.h (struct stab_section_list): Remove.
9989         (coffstab_build_psymtabs): Update.
9990         * dbxread.c (symbuf_sections): Now a std::vector.
9991         (sect_idx): New global.
9992         (fill_symbuf): Update.
9993         (coffstab_build_psymtabs): Change type of stabsects parameter.
9994         Update.
9995         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9996         std::vector.
9997         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9998         (coff_locate_sections): Update.
9999         (coff_symfile_read): Remove cleanups.  Update.
10000         (init_stringtab): Add storage parameter.
10001         (free_stringtab, free_stringtab_cleanup): Remove.
10002         (init_lineno): Add storage parameter.
10003         (free_linetab, free_linetab_cleanup): Remove.
10004
10005 2019-03-06  Pedro Alves  <palves@redhat.com>
10006
10007         * linux-fork.c (fork_info::clobber_regs): Delete.
10008         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10009         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10010         comment.  Adjust.
10011         (scoped_switch_fork_info::scoped_switch_fork_info)
10012         (checkpoint_command, linux_fork_context): Adjust
10013         fork_save_infrun_state calls.
10014
10015 2019-03-06  Pedro Alves  <palves@redhat.com>
10016
10017         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10018         (inf_has_multiple_threads): Return 'bool' and rewrite using
10019         inferior_info::threads().
10020
10021 2019-03-06  Pedro Alves  <palves@redhat.com>
10022
10023         * linux-fork.c: Include <list>.
10024         (fork_list): Now a std::list instance.
10025         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10026         (forks_exist_p, find_last_fork): Adjust.
10027         (new_fork): Delete.
10028         (one_fork_p): New.
10029         (add_fork): Adjust.
10030         (free_fork): Delete, folded into fork_info::~fork_info().
10031         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10032         Adjust.
10033         (init_fork_list): Delete.
10034         (linux_fork_killall, linux_fork_mourn_inferior)
10035         (linux_fork_detach, info_checkpoints_command): Adjust.
10036         (_initialize_linux_fork): No longer call init_fork_list.
10037
10038 2019-03-06  Pedro Alves  <palves@redhat.com>
10039
10040         * linux-fork.c (new_fork): New, split out of ...
10041         (add_fork): ... this.  Return void.  Move "first fork" special
10042         case from here, to ...
10043         (checkpoint_command): ... here.
10044         * linux-linux.h (add_fork): Return void.
10045
10046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10047
10048         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10049
10050 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10051             Chris January  <chris.january@arm.com>
10052             David Lecomber  <david.lecomber@arm.com>
10053
10054         * f-exp.y: New token, UNOP_INTRINSIC.
10055         (exp): New pattern using UNOP_INTRINSIC token.
10056         (f77_keywords): Add 'abs' keyword.
10057         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10058         (value_from_host_double): New function.
10059         (evaluate_subexp_f): Support UNOP_ABS.
10060
10061 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10062
10063         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10064         types.
10065
10066 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10067
10068         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10069         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10070         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10071
10072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10073
10074         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10075
10076 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10077             Chris January  <chris.january@arm.com>
10078
10079         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10080         * f-exp.y: Define 'KIND' token.
10081         (exp): New pattern for KIND expressions.
10082         (ptype): Handle types with a kind extension.
10083         (direct_abs_decl): Extend to spot kind extensions.
10084         (f77_keywords): Add 'kind' to the list.
10085         (push_kind_type): New function.
10086         (convert_to_kind_type): New function.
10087         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10088         * parse.c (operator_length_standard): Likewise.
10089         * parser-defs.h (enum type_pieces): Add tp_kind.
10090         * std-operator.def: Add UNOP_KIND.
10091
10092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10093
10094         * f-exp.y (f_parse): Set yydebug.
10095
10096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10097
10098         * f-lang.c (evaluate_subexp_f): New function.
10099         (exp_descriptor_f): New global.
10100         (f_language_defn): Use exp_descriptor_f instead of
10101         exp_descriptor_standard.
10102
10103 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10104
10105         * f-exp.y (struct token): Add comments.
10106         (dot_ops): Remove uppercase versions and the end marker.
10107         (f77_keywords): Likewise.
10108         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10109         entries in the dot_ops array are case insensitive, and use
10110         strncasecmp to compare strings.  Also some whitespace cleanup in
10111         this area.  Similar for the f77_keywords array, except entries in
10112         this list might be case sensitive.
10113
10114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10115
10116         * f-exp.y (struct f77_boolean_val): Add comments.
10117         (boolean_values): Remove uppercase versions, and end marker.
10118         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10119         and use strncasecmp to achieve case insensitivity.  Additionally,
10120         perform whitespace cleanup around this code.
10121
10122 2019-03-06  Tom Tromey  <tromey@adacore.com>
10123
10124         * remote-sim.c (gdbsim_target_open): Use result of
10125         gdb_argv::release.
10126
10127 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10128         Dirk Schubert  <dirk.schubert@arm.com>
10129         Chris January  <chris.january@arm.com>
10130
10131         * eval.c (evaluate_subexp_standard): Call Fortran argument
10132         wrapping logic.
10133         * f-lang.c (struct value): A value which can be passed into a
10134         Fortran function call.
10135         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10136         where appropriate.
10137         (struct type): Value ready for a Fortran function call.
10138         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10139         is needed.
10140         * f-lang.h (fortran_argument_convert): Declaration.
10141         (fortran_preserve_arg_pointer): Declaration.
10142         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10143
10144 2019-03-05  Tom Tromey  <tromey@adacore.com>
10145
10146         * python/py-prettyprint.c (print_string_repr): Remove #if.
10147         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10148
10149 2019-03-05  Tom Tromey  <tromey@adacore.com>
10150
10151         * target.c (the_dummy_target): Move later.  Change type to
10152         "dummy_target".
10153         (initialize_targets): Don't initialize the_dummy_target.
10154
10155 2019-03-05  Tom Tromey  <tromey@adacore.com>
10156
10157         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10158         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10159
10160 2019-03-05  Tom Tromey  <tromey@adacore.com>
10161
10162         * windows-nat.c (windows_nat_target::attach)
10163         (windows_nat_target::detach): Don't call gdb_flush.
10164         * valprint.c (generic_val_print, val_print, val_print_string):
10165         Don't call gdb_flush.
10166         * utils.c (defaulted_query): Don't call gdb_flush.
10167         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10168         * target.c (target_announce_detach): Don't call gdb_flush.
10169         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10170         * remote.c (extended_remote_target::attach): Don't call
10171         gdb_flush.
10172         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10173         * printcmd.c (do_examine): Don't call gdb_flush.
10174         (info_display_command): Don't call gdb_flush.
10175         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10176         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10177         * memattr.c (info_mem_command): Don't call gdb_flush.
10178         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10179         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10180         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10181         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10182         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10183         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10184         (gnu_nat_target::detach): Don't call gdb_flush.
10185         * f-valprint.c (f_val_print): Don't call gdb_flush.
10186         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10187         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10188         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10189         gdb_flush.
10190         * c-valprint.c (c_val_print): Don't call gdb_flush.
10191         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10192
10193 2019-03-05  Tom Tromey  <tromey@adacore.com>
10194
10195         * varobj.c (update_dynamic_varobj_children): Update.
10196         (install_default_visualizer): Use reset, not release.
10197         * value.c (set_internalvar): Update.
10198         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10199         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10200         ATTRIBUTE_UNUSED_RESULT.
10201
10202 2019-03-05  Tom Tromey  <tromey@adacore.com>
10203
10204         * remote.c (class scoped_remote_fd) <release>: Add
10205         ATTRIBUTE_UNUSED_RESULT.
10206
10207 2019-03-05  Tom Tromey  <tromey@adacore.com>
10208
10209         * macroexp.c (struct macro_buffer) <release>: Add
10210         ATTRIBUTE_UNUSED_RESULT.
10211
10212 2019-03-05  Tom Tromey  <tromey@adacore.com>
10213
10214         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10215         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10216         ATTRIBUTE_UNUSED_RESULT.
10217
10218 2019-03-05  Tom Tromey  <tromey@adacore.com>
10219
10220         * common/scoped_fd.h (class scoped_fd) <release>: Add
10221         ATTRIBUTE_UNUSED_RESULT.
10222
10223 2019-03-05  Tom Tromey  <tromey@adacore.com>
10224
10225         * parser-defs.h (struct parser_state) <release>: Add
10226         ATTRIBUTE_UNUSED_RESULT.
10227
10228 2019-03-05  Tom Tromey  <tromey@adacore.com>
10229
10230         * utils.h (class gdb_argv) <release>: Add
10231         ATTRIBUTE_UNUSED_RESULT.
10232         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10233
10234 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10235
10236         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10237         for-loop range, to avoid compiler warnings.
10238
10239         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10240         avoid compiler warnings about unused variables.
10241
10242         * NEWS: Mention end of support for native debugging on MS-Windows
10243         before XP.
10244
10245         PR gdb/24292
10246         * common/netstuff.c:
10247         * gdbserver/gdbreplay.c
10248         * gdbserver/remote-utils.c:
10249         * ser-tcp.c:
10250         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10251         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10252         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10253         'getaddrinfo' and 'freeaddrinfo' were not available before
10254         Windows XP, and mingw.org's MinGW headers by default define
10255         _WIN32_WINNT to 0x500.
10256
10257 2019-03-01  Gary Benson <gbenson@redhat.com>
10258
10259         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10260
10261 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10262             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10263
10264         PR gdb/8527
10265         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10266         set_sigint_trap, clear_sigint_trap.
10267
10268 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10269
10270         * target.c (target_detach): Clear the regcache and the
10271         frame cache.
10272
10273 2019-02-27  Pedro Alves  <palves@redhat.com>
10274
10275         * utils.c (set_screen_size): When we cap the height/width sizes,
10276         tweak the corresponding command variable to show "unlimited":
10277
10278 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10279             Pedro Alves  <palves@redhat.com>
10280
10281         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10282         before calling rl_set_screen_size.
10283
10284 2019-02-27  Tom Tromey  <tromey@adacore.com>
10285
10286         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10287         define.
10288         * python/py-value.c: Remove Python 2.4 workaround.
10289         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10290         workaround.
10291         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10292         Python 2.4 workaround.
10293         * python/python-internal.h: Remove Python 2.4 comment.
10294         (Py_ssize_t): Don't define.
10295         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10296         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10297         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10298         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10299         * python/python.c (do_start_initialization): Remove Python 2.4
10300         workaround.
10301         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10302         (print_children): Remove Python 2.4 workaround.
10303         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10304         workaround.
10305         (CHARBUFFERPROC_NAME): Remove.
10306         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10307         Python 2.4 workaround.
10308
10309 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10310
10311         * NEWS: Note minimum Python version.
10312
10313 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10314
10315         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10316         code from these functions.  Remove corresponding ifdefs.  Use
10317         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10318         Remove gotos and target of gotos.
10319         (infpy_search_memory): Likewise.
10320
10321 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10322
10323         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10324         (hppa_gdbarch_init): Don't register deleted functions with
10325         gdbarch.
10326
10327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10328
10329         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10330         (h8300_unwind_sp): Delete.
10331         (h8300_dummy_id): Delete.
10332         (h8300_gdbarch_init): Don't register deleted functions with
10333         gdbarch.
10334
10335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10336
10337         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10338         (ft32_unwind_pc): Delete.
10339         (ft32_unwind_sp): Delete.
10340         (ft32_gdbarch_init): Don't register deleted functions with
10341         gdbarch.
10342
10343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10344
10345         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10346         (frv_unwind_pc): Delete.
10347         (frv_unwind_sp): Delete.
10348         (frv_gdbarch_init): Don't register deleted functions with
10349         gdbarch.
10350
10351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10352
10353         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10354         (riscv_unwind_pc): Delete.
10355         (riscv_unwind_sp): Delete.
10356         (riscv_gdbarch_init): Don't register deleted functions with
10357         gdbarch.
10358
10359 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10360
10361         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10362         (csky_unwind_pc): Delete.
10363         (csky_unwind_sp): Delete.
10364         (csky_gdbarch_init): Don't register deleted functions with
10365         gdbarch.
10366
10367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10368
10369         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10370         (cris_unwind_pc): Delete.
10371         (cris_unwind_sp): Delete.
10372         (cris_gdbarch_init): Don't register deleted functions with
10373         gdbarch.
10374
10375 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10376
10377         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10378         (bfin_unwind_pc): Delete.
10379         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10380
10381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10382
10383         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10384         (arm_unwind_pc): Delete.
10385         (arm_unwind_sp): Delete.
10386         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10387
10388 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10389
10390         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10391         (arc_unwind_pc): Delete.
10392         (arc_unwind_sp): Delete.
10393         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10394
10395 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10396
10397         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10398         (alpha_unwind_pc): Delete.
10399         (alpha_gdbarch_init): Don't register deleted functions with
10400         gdbarch.
10401
10402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10403
10404         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10405         (aarch64_unwind_pc): Delete.
10406         (aarch64_unwind_sp): Delete.
10407         (aarch64_gdbarch_init): Don't register deleted functions with
10408         gdbarch.
10409
10410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10411
10412         * gdbtypes.c (type_align): Don't consider static members when
10413         computing structure alignment.
10414
10415 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10416
10417         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10418         return 0 for other types.
10419         * arch-utils.c (default_type_align): Always return 0.
10420         * gdbarch.h: Regenerate.
10421         * gdbarch.sh (type_align): Extend comment.
10422         * gdbtypes.c (type_align): Add additional comments, always call
10423         gdbarch_type_align before applying the default rules.
10424         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10425         generic code will then apply a suitable default.
10426         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10427         types, return 0 for other types.
10428
10429 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10430
10431         * NEWS: Create a new section for the next release branch.
10432         Rename the section of the current branch, now that it has
10433         been cut.
10434
10435 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10436
10437         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10438         * version.in: Bump version to 8.3.50.DATE-git.
10439
10440 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10441
10442         * aix-thread.c (ptid_cmp): Remove unused variable.
10443         (get_signaled_thread): Likewise.
10444         (store_regs_user_thread): Likewise.
10445         (store_regs_kernel_thread): Likewise.
10446         (fetch_regs_kernel_thread): Remove shadowed variable.
10447
10448 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10449
10450         * features/riscv/32bit-cpu.xml: Add register numbers.
10451         * features/riscv/32bit-fpu.c: Regenerate.
10452         * features/riscv/32bit-fpu.xml: Add register numbers.
10453         * features/riscv/64bit-cpu.xml: Add register numbers.
10454         * features/riscv/64bit-fpu.c: Regenerate.
10455         * features/riscv/64bit-fpu.xml: Add register numbers.
10456
10457 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10458
10459         * NEWS: Mention two argument form of gdb.Value constructor.
10460         * python/py-value.c (convert_buffer_and_type_to_value): New
10461         function.
10462         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10463         Add support for handling an optional second argument.  Call
10464         convert_buffer_and_type_to_value as appropriate.
10465         * python/python-internal.h (Py_buffer_deleter): New struct.
10466         (Py_buffer_up): New typedef.
10467
10468 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10469
10470         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10471         instead of releasing ownership.
10472
10473 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10474
10475         * dwarf2read.c (open_and_init_dwp_file): Call
10476         elf_numsections instead of bfd_count_sections to initialize
10477         dwp_file->num_sections.
10478
10479 2019-02-25  Tom Tromey  <tromey@adacore.com>
10480
10481         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10482
10483 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10484
10485         * gcore.in: Add '--readnever' option when invoking GDB.
10486
10487 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10488
10489         * MAINTAINERS: Update my email address.
10490
10491 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10492
10493         * build-id.c (build_id_to_debug_bfd_1): New function.
10494         (build_id_to_debug_bfd): Look for separate debug file in
10495         sysroot.
10496
10497 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10498
10499         * gdbarch.sh: Update the copyright year range that is placed into
10500         generated files.
10501
10502 2019-02-22  Keith Seitz  <keiths@redhat.com>
10503
10504         PR symtab/23853
10505         * linespec.c (create_sals_line_offset): Search for the default
10506         symtab's filename instead of its fullname.
10507
10508 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10509
10510         * NEWS: Update style defaults.
10511
10512 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10513
10514         * main.c (captured_main_1): Disable styling in batch mode.
10515
10516 2019-02-20  Tom Tromey  <tom@tromey.com>
10517
10518         * symtab.c (symtab_symbol_info): Fix typos.
10519
10520 2019-02-20  Tom Tromey  <tromey@adacore.com>
10521
10522         * findcmd.c (_initialize_mem_search): Use upper case for
10523         metasyntactic variables.
10524
10525 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10526
10527         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10528         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10529
10530 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10531
10532         * top.h (source_file_name): Change to std::string.
10533         * top.c (source_file_name): Likewise.
10534         (command_line_input): Adjust.
10535         * cli/cli-script.c (script_from_file): Adjust.
10536
10537 2019-02-19  Tom Tromey  <tromey@adacore.com>
10538
10539         * ravenscar-thread.c
10540         (ravenscar_thread_target::update_thread_list): Don't call
10541         ada_build_task_list.
10542         * ada-lang.h (ada_build_task_list): Don't declare.
10543         * ada-tasks.c (struct ada_tasks_inferior_data)
10544         <task_list_valid_p>: Now bool.
10545         (read_known_tasks, ada_task_list_changed)
10546         (ada_tasks_invalidate_inferior_data): Update.
10547         (read_known_tasks_array): Return bool.
10548         (read_known_tasks_list): Likewise.
10549         (read_known_tasks): Return void.
10550         (ada_build_task_list): Now static.
10551
10552 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10553
10554         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10555         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10556
10557 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10558
10559         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10560         variant for ada_tasks_pspace_data_handle and
10561         ada_tasks_inferior_data_handle.
10562         (ada_tasks_pspace_data_cleanup): New function.
10563         (ada_tasks_inferior_data_cleanup): New function.
10564
10565 2019-02-17  Tom Tromey  <tom@tromey.com>
10566
10567         * macrotab.h (macro_source_fullname): Return a std::string.
10568         * macrotab.c (macro_include, check_for_redefinition)
10569         (macro_undef, macro_lookup_definition, foreach_macro)
10570         (foreach_macro_in_scope): Update.
10571         (macro_source_fullname): Return a std::string.
10572         * macrocmd.c (show_pp_source_pos): Update.
10573
10574 2019-02-17  Tom Tromey  <tom@tromey.com>
10575
10576         * macrocmd.c (show_pp_source_pos): Style the file names.
10577
10578 2019-02-17  Tom Tromey  <tom@tromey.com>
10579
10580         PR tui/24197:
10581         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10582
10583 2019-02-17  Tom Tromey  <tom@tromey.com>
10584
10585         * ada-lang.c (user_select_syms): Use filtered printing.
10586         * utils.c (wrap_style): New global.
10587         (desired_style): Remove.
10588         (emit_style_escape): Add stream parameter.
10589         (set_output_style, reset_terminal_style, prompt_for_continue):
10590         Update.
10591         (flush_wrap_buffer): Only flush gdb_stdout.
10592         (wrap_here): Set wrap_style.
10593         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10594         treat escape sequences as a character.  Change when wrap buffer is
10595         flushed.
10596         (fputs_styled): Do not set the output style when the default is
10597         requested.
10598         * ui-style.h (struct ui_file_style) <is_default>: New method.
10599         * source.c (print_source_lines_base): Emit escape sequences in one
10600         piece.
10601
10602 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10603
10604         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10605         integers and enumeration types.
10606
10607 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10608
10609         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10610         instead of lookup_symbol_in_language
10611         (do_exact_match): New function.
10612         (ada_get_symbol_name_matcher): Return do_exact_match when
10613         doing a verbatim match.
10614
10615 2019-02-15  Tom Tromey  <tromey@adacore.com>
10616
10617         * ravenscar-thread.c (ravenscar_thread_target::resume)
10618         (ravenscar_thread_target::wait): Special case wildcard requests.
10619
10620 2019-02-15  Tom Tromey  <tromey@adacore.com>
10621
10622         * ravenscar-thread.c (base_ptid): Remove.
10623         (struct ravenscar_thread_target) <close>: New method.
10624         <m_base_ptid>: New member.
10625         <update_inferior_ptid, active_task, task_is_currently_active,
10626         runtime_initialized>: Declare methods.
10627         <ravenscar_thread_target>: Add constructor.
10628         (ravenscar_thread_target::task_is_currently_active)
10629         (ravenscar_thread_target::update_inferior_ptid)
10630         (ravenscar_runtime_initialized): Rename.  Now methods.
10631         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10632         (ravenscar_thread_target::update_thread_list): Update.
10633         (ravenscar_thread_target::active_task): Now method.
10634         (ravenscar_thread_target::store_registers)
10635         (ravenscar_thread_target::prepare_to_store)
10636         (ravenscar_thread_target::prepare_to_store)
10637         (ravenscar_thread_target::mourn_inferior): Update.
10638         (ravenscar_inferior_created): Use "new" to create target.
10639         (ravenscar_thread_target::get_ada_task_ptid): Update.
10640         (_initialize_ravenscar): Don't initialize base_ptid.
10641         (ravenscar_ops): Remove global.
10642
10643 2019-02-15  Tom Tromey  <tromey@adacore.com>
10644
10645         * target.h (push_target): Declare new overload.
10646         * target.c (push_target): New overload, taking an rvalue reference.
10647         * remote.c (remote_target::open_1): Use push_target overload.
10648         * corelow.c (core_target_open): Use push_target overload.
10649
10650 2019-02-15  Tom Tromey  <tromey@adacore.com>
10651
10652         * ravenscar-thread.c (is_ravenscar_task)
10653         (ravenscar_task_is_currently_active): Return bool.
10654         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10655         (_initialize_ravenscar): Remove "(void)".
10656         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10657         Return bool.
10658
10659 2019-02-15  Tom Tromey  <tromey@adacore.com>
10660
10661         * ravenscar-thread.c (ravenscar_runtime_initializer)
10662         (has_ravenscar_runtime, get_running_thread_id)
10663         (ravenscar_thread_target::resume): Fix indentation.
10664
10665 2019-02-15  Tom Tromey  <tromey@adacore.com>
10666
10667         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10668         from ravenscar_arch_ops.
10669         (sparc_ravenscar_ops::fetch_registers)
10670         (sparc_ravenscar_ops::store_registers): Now methods.
10671         (sparc_ravenscar_prepare_to_store): Remove.
10672         (sparc_ravenscar_ops): Redefine.
10673         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10674         methods and destructor.  Remove members.
10675         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10676         (ravenscar_thread_target::store_registers)
10677         (ravenscar_thread_target::prepare_to_store): Update.
10678         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10679         Remove.
10680         (struct ppc_ravenscar_powerpc_ops): Derive from
10681         ravenscar_arch_ops.
10682         (ppc_ravenscar_powerpc_ops::fetch_registers)
10683         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10684         (ppc_ravenscar_powerpc_ops): Redefine.
10685         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10686         (ppc_ravenscar_e500_ops::fetch_registers)
10687         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10688         (ppc_ravenscar_e500_ops): Redefine.
10689         * aarch64-ravenscar-thread.c
10690         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10691         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10692         (aarch64_ravenscar_fetch_registers)
10693         (aarch64_ravenscar_store_registers): Now methods.
10694         (aarch64_ravenscar_ops): Redefine.
10695
10696 2019-02-15  Tom Tromey  <tromey@adacore.com>
10697
10698         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10699         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10700         (ravenscar_thread_target::stopped_by_watchpoint)
10701         (ravenscar_thread_target::stopped_data_address)
10702         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10703
10704 2019-02-15  Tom Tromey  <tromey@adacore.com>
10705
10706         * ravenscar-thread.c: Fix some typos.
10707
10708 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10709             Tom Tromey  <tromey@adacore.com>
10710
10711         * ada-lang.c (ada_exception_sal): Change addr_string to a
10712         std::string.
10713         (create_ada_exception_catchpoint): Update.
10714
10715 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10716             Tom Tromey  <tromey@adacore.com>
10717
10718         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10719         (bp_location_ops): Remove.
10720         (base_breakpoint_allocate_location): Update.
10721         (free_bp_location): Update.
10722         * ada-lang.c (class ada_catchpoint_location)
10723         <ada_catchpoint_location>: Remove ops parameter.
10724         (ada_catchpoint_location_dtor): Remove.
10725         (ada_catchpoint_location_ops): Remove.
10726         (allocate_location_exception): Update.
10727         * breakpoint.h (struct bp_location_ops): Remove.
10728         (class bp_location) <bp_location>: Remove bp_location_ops
10729         parameter.
10730         <~bp_location>: Add destructor.
10731         <ops>: Remove.
10732
10733 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10734             Pedro Alves  <palves@redhat.com>
10735
10736         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10737         'PATH_MAX'.
10738
10739 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10740             Samuel Thibault  <samuel.thibault@gnu.org>
10741             Thomas Schwinge  <thomas@codesourcery.com>
10742
10743         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10744         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10745
10746 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10747
10748         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10749         (check_empty): Use "const char *".
10750
10751         * gnu-nat.c (gnu_nat_target::detach): Instead of
10752         'detach_inferior (pid)' call
10753         'detach_inferior (find_inferior_pid (pid))'.
10754
10755         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10756         'nat/fork-inferior.o'.
10757         * gnu-nat.c: #include "nat/fork-inferior.h".
10758
10759         * gnu-nat.c (gnu_nat_target::detach): Instead of
10760         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10761         * gnu-nat.h: #include "inf-child.h".
10762         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10763         'i386_gnu_nat_target::fetch_registers'.
10764         (gnu_store_registers): Rename/move to
10765         'i386_gnu_nat_target::store_registers'.
10766
10767         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10768         * gnu-nat.h (mach_thread_info): New function.
10769         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10770
10771         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10772
10773 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10774
10775         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10776
10777 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10778
10779         * windows-nat.c (windows_add_thread): Add new parameter
10780         "main_thread_p" with default value set to false.  Update
10781         function documentation as well as all callers.
10782         (windows_delete_thread): Likewise.
10783         (fake_create_process): Update call to windows_add_thread.
10784         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10785         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10786         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10787         call to windows_delete_thread.
10788
10789 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10790
10791         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10792
10793 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10794
10795         * symfile.c (find_separate_debug_file): Use canonical path of
10796         sysroot with child_path instead of gdb_sysroot if it is valid.
10797
10798 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10799
10800         * symfile.c (find_separate_debug_file): Use child_path to
10801         determine if an object file is under a sysroot.
10802
10803 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10804
10805         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10806         unittests/child-path-selftests.c.
10807         * common/pathstuff.c (child_path): New function.
10808         * common/pathstuff.h (child_path): New prototype.
10809         * unittests/child-path-selftests.c: New file.
10810
10811 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10812
10813         * symfile.c (find_separate_debug_file): Look for separate debug
10814         files in debug directories under the sysroot.
10815
10816 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10817
10818         * symtab.h (struct minimal_symbol data_p): New const method.
10819         (struct minimal_symbol text_p): Likewise.
10820         * symtab.c (output_source_filename): Use file name style
10821         to print file name.
10822         (print_symbol_info): Likewise.
10823         (print_msymbol_info): Use address style to print addresses.
10824         Use function name style to print executable text symbols.
10825         (expand_symtab_containing_pc): Use data_p.
10826         (find_pc_sect_compunit_symtab): Likewise.
10827
10828 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10829
10830         * breakpoint.c (describe_other_breakpoints): Use address style
10831         to print addresses.
10832         (say_where): Likewise.
10833
10834 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10835
10836         * ada-typeprint.c (print_func_type): Print function name
10837         style to print function name.
10838         * c-typeprint.c (c_print_type_1): Likewise.
10839
10840 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10841
10842         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10843         for execve.
10844
10845 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10846
10847         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10848         type_stack.
10849
10850 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10851
10852         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10853         TYPE_CODE_REF types.
10854
10855 2019-02-08  Jim Wilson  <jimw@sifive.com>
10856
10857         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10858         (riscv_linux_fregset): New.
10859         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10860
10861 2019-02-07  Tom Tromey  <tom@tromey.com>
10862
10863         * thread.c (thread_cancel_execution_command): Update.
10864         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10865         methods.
10866         (struct thread_fsm_ops): Remove.
10867         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10868         (thread_fsm_should_stop, thread_fsm_return_value)
10869         (thread_fsm_set_finished, thread_fsm_finished_p)
10870         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10871         Don't declare.
10872         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10873         * infrun.c (clear_proceed_status_thread)
10874         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10875         (print_stop_event): Update.
10876         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10877         Add constructor.
10878         (step_command_fsm_ops): Remove.
10879         (new_step_command_fsm): Remove.
10880         (step_1): Update.
10881         (step_command_fsm::should_stop): Rename from
10882         step_command_fsm_should_stop.
10883         (step_command_fsm::clean_up): Rename from
10884         step_command_fsm_clean_up.
10885         (step_command_fsm::do_async_reply_reason): Rename from
10886         step_command_fsm_async_reply_reason.
10887         (struct until_next_fsm): Inherit from thread_fsm.  Add
10888         constructor.
10889         (until_next_fsm_ops): Remove.
10890         (new_until_next_fsm): Remove.
10891         (until_next_fsm::should_stop): Rename from
10892         until_next_fsm_should_stop.
10893         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10894         (until_next_fsm::do_async_reply_reason): Rename from
10895         until_next_fsm_async_reply_reason.
10896         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10897         constructor.  Change type of breakpoint.
10898         (finish_command_fsm_ops): Remove.
10899         (new_finish_command_fsm): Remove.
10900         (finish_command_fsm::should_stop): Rename from
10901         finish_command_fsm_should_stop.
10902         (finish_command_fsm::clean_up): Rename from
10903         finish_command_fsm_clean_up.
10904         (finish_command_fsm::return_value): Rename from
10905         finish_command_fsm_return_value.
10906         (finish_command_fsm::do_async_reply_reason): Rename from
10907         finish_command_fsm_async_reply_reason.
10908         (finish_command): Update.
10909         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10910         Add constructor.
10911         (call_thread_fsm_ops): Remove.
10912         (call_thread_fsm::call_thread_fsm): Rename from
10913         new_call_thread_fsm.
10914         (call_thread_fsm::should_stop): Rename from
10915         call_thread_fsm_should_stop.
10916         (call_thread_fsm::should_notify_stop): Rename from
10917         call_thread_fsm_should_notify_stop.
10918         (run_inferior_call, call_function_by_hand_dummy): Update.
10919         * cli/cli-interp.c (should_print_stop_to_console): Update.
10920         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10921         Add constructor.  Change type of location_breakpoint,
10922         caller_breakpoint.
10923         (until_break_fsm_ops): Remove.
10924         (new_until_break_fsm): Remove.
10925         (until_break_fsm::should_stop): Rename from
10926         until_break_fsm_should_stop.
10927         (until_break_fsm::clean_up): Rename from
10928         until_break_fsm_clean_up.
10929         (until_break_fsm::do_async_reply_reason): Rename from
10930         until_break_fsm_async_reply_reason.
10931         (until_break_command): Update.
10932         * thread-fsm.c: Remove.
10933         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10934
10935 2019-02-07  Tom Tromey  <tom@tromey.com>
10936
10937         * yy-remap.h: Add include guard.
10938         * xtensa-tdep.h: Add include guard.
10939         * xcoffread.h: Rename include guard.
10940         * varobj-iter.h: Add include guard.
10941         * tui/tui.h: Rename include guard.
10942         * tui/tui-winsource.h: Rename include guard.
10943         * tui/tui-wingeneral.h: Rename include guard.
10944         * tui/tui-windata.h: Rename include guard.
10945         * tui/tui-win.h: Rename include guard.
10946         * tui/tui-stack.h: Rename include guard.
10947         * tui/tui-source.h: Rename include guard.
10948         * tui/tui-regs.h: Rename include guard.
10949         * tui/tui-out.h: Rename include guard.
10950         * tui/tui-layout.h: Rename include guard.
10951         * tui/tui-io.h: Rename include guard.
10952         * tui/tui-hooks.h: Rename include guard.
10953         * tui/tui-file.h: Rename include guard.
10954         * tui/tui-disasm.h: Rename include guard.
10955         * tui/tui-data.h: Rename include guard.
10956         * tui/tui-command.h: Rename include guard.
10957         * tic6x-tdep.h: Add include guard.
10958         * target/waitstatus.h: Rename include guard.
10959         * target/wait.h: Rename include guard.
10960         * target/target.h: Rename include guard.
10961         * target/resume.h: Rename include guard.
10962         * target-float.h: Rename include guard.
10963         * stabsread.h: Add include guard.
10964         * rs6000-tdep.h: Add include guard.
10965         * riscv-fbsd-tdep.h: Add include guard.
10966         * regformats/regdef.h: Rename include guard.
10967         * record.h: Rename include guard.
10968         * python/python.h: Rename include guard.
10969         * python/python-internal.h: Rename include guard.
10970         * python/py-stopevent.h: Rename include guard.
10971         * python/py-ref.h: Rename include guard.
10972         * python/py-record.h: Rename include guard.
10973         * python/py-record-full.h: Rename include guard.
10974         * python/py-record-btrace.h: Rename include guard.
10975         * python/py-instruction.h: Rename include guard.
10976         * python/py-events.h: Rename include guard.
10977         * python/py-event.h: Rename include guard.
10978         * procfs.h: Add include guard.
10979         * proc-utils.h: Add include guard.
10980         * p-lang.h: Add include guard.
10981         * or1k-tdep.h: Rename include guard.
10982         * observable.h: Rename include guard.
10983         * nto-tdep.h: Rename include guard.
10984         * nat/x86-linux.h: Rename include guard.
10985         * nat/x86-linux-dregs.h: Rename include guard.
10986         * nat/x86-gcc-cpuid.h: Add include guard.
10987         * nat/x86-dregs.h: Rename include guard.
10988         * nat/x86-cpuid.h: Rename include guard.
10989         * nat/ppc-linux.h: Rename include guard.
10990         * nat/mips-linux-watch.h: Rename include guard.
10991         * nat/linux-waitpid.h: Rename include guard.
10992         * nat/linux-ptrace.h: Rename include guard.
10993         * nat/linux-procfs.h: Rename include guard.
10994         * nat/linux-osdata.h: Rename include guard.
10995         * nat/linux-nat.h: Rename include guard.
10996         * nat/linux-namespaces.h: Rename include guard.
10997         * nat/linux-btrace.h: Rename include guard.
10998         * nat/glibc_thread_db.h: Rename include guard.
10999         * nat/gdb_thread_db.h: Rename include guard.
11000         * nat/gdb_ptrace.h: Rename include guard.
11001         * nat/fork-inferior.h: Rename include guard.
11002         * nat/amd64-linux-siginfo.h: Rename include guard.
11003         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11004         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11005         * nat/aarch64-linux.h: Rename include guard.
11006         * nat/aarch64-linux-hw-point.h: Rename include guard.
11007         * mn10300-tdep.h: Add include guard.
11008         * mips-linux-tdep.h: Add include guard.
11009         * mi/mi-parse.h: Rename include guard.
11010         * mi/mi-out.h: Rename include guard.
11011         * mi/mi-main.h: Rename include guard.
11012         * mi/mi-interp.h: Rename include guard.
11013         * mi/mi-getopt.h: Rename include guard.
11014         * mi/mi-console.h: Rename include guard.
11015         * mi/mi-common.h: Rename include guard.
11016         * mi/mi-cmds.h: Rename include guard.
11017         * mi/mi-cmd-break.h: Rename include guard.
11018         * m2-lang.h: Add include guard.
11019         * location.h: Rename include guard.
11020         * linux-record.h: Rename include guard.
11021         * linux-nat.h: Add include guard.
11022         * linux-fork.h: Add include guard.
11023         * i386-darwin-tdep.h: Rename include guard.
11024         * hppa-linux-offsets.h: Add include guard.
11025         * guile/guile.h: Rename include guard.
11026         * guile/guile-internal.h: Rename include guard.
11027         * gnu-nat.h: Rename include guard.
11028         * gdb-stabs.h: Rename include guard.
11029         * frv-tdep.h: Add include guard.
11030         * f-lang.h: Add include guard.
11031         * event-loop.h: Add include guard.
11032         * darwin-nat.h: Rename include guard.
11033         * cp-abi.h: Rename include guard.
11034         * config/sparc/nm-sol2.h: Rename include guard.
11035         * config/nm-nto.h: Rename include guard.
11036         * config/nm-linux.h: Add include guard.
11037         * config/i386/nm-i386gnu.h: Rename include guard.
11038         * config/djgpp/nl_types.h: Rename include guard.
11039         * config/djgpp/langinfo.h: Rename include guard.
11040         * compile/gcc-cp-plugin.h: Add include guard.
11041         * compile/gcc-c-plugin.h: Add include guard.
11042         * compile/compile.h: Rename include guard.
11043         * compile/compile-object-run.h: Rename include guard.
11044         * compile/compile-object-load.h: Rename include guard.
11045         * compile/compile-internal.h: Rename include guard.
11046         * compile/compile-cplus.h: Rename include guard.
11047         * compile/compile-c.h: Rename include guard.
11048         * common/xml-utils.h: Rename include guard.
11049         * common/x86-xstate.h: Rename include guard.
11050         * common/version.h: Rename include guard.
11051         * common/vec.h: Rename include guard.
11052         * common/tdesc.h: Rename include guard.
11053         * common/selftest.h: Rename include guard.
11054         * common/scoped_restore.h: Rename include guard.
11055         * common/scoped_mmap.h: Rename include guard.
11056         * common/scoped_fd.h: Rename include guard.
11057         * common/safe-iterator.h: Rename include guard.
11058         * common/run-time-clock.h: Rename include guard.
11059         * common/refcounted-object.h: Rename include guard.
11060         * common/queue.h: Rename include guard.
11061         * common/ptid.h: Rename include guard.
11062         * common/print-utils.h: Rename include guard.
11063         * common/preprocessor.h: Rename include guard.
11064         * common/pathstuff.h: Rename include guard.
11065         * common/observable.h: Rename include guard.
11066         * common/netstuff.h: Rename include guard.
11067         * common/job-control.h: Rename include guard.
11068         * common/host-defs.h: Rename include guard.
11069         * common/gdb_wait.h: Rename include guard.
11070         * common/gdb_vecs.h: Rename include guard.
11071         * common/gdb_unlinker.h: Rename include guard.
11072         * common/gdb_unique_ptr.h: Rename include guard.
11073         * common/gdb_tilde_expand.h: Rename include guard.
11074         * common/gdb_sys_time.h: Rename include guard.
11075         * common/gdb_string_view.h: Rename include guard.
11076         * common/gdb_splay_tree.h: Rename include guard.
11077         * common/gdb_setjmp.h: Rename include guard.
11078         * common/gdb_ref_ptr.h: Rename include guard.
11079         * common/gdb_optional.h: Rename include guard.
11080         * common/gdb_locale.h: Rename include guard.
11081         * common/gdb_assert.h: Rename include guard.
11082         * common/filtered-iterator.h: Rename include guard.
11083         * common/filestuff.h: Rename include guard.
11084         * common/fileio.h: Rename include guard.
11085         * common/environ.h: Rename include guard.
11086         * common/common-utils.h: Rename include guard.
11087         * common/common-types.h: Rename include guard.
11088         * common/common-regcache.h: Rename include guard.
11089         * common/common-inferior.h: Rename include guard.
11090         * common/common-gdbthread.h: Rename include guard.
11091         * common/common-exceptions.h: Rename include guard.
11092         * common/common-defs.h: Rename include guard.
11093         * common/common-debug.h: Rename include guard.
11094         * common/cleanups.h: Rename include guard.
11095         * common/buffer.h: Rename include guard.
11096         * common/btrace-common.h: Rename include guard.
11097         * common/break-common.h: Rename include guard.
11098         * cli/cli-utils.h: Rename include guard.
11099         * cli/cli-style.h: Rename include guard.
11100         * cli/cli-setshow.h: Rename include guard.
11101         * cli/cli-script.h: Rename include guard.
11102         * cli/cli-interp.h: Rename include guard.
11103         * cli/cli-decode.h: Rename include guard.
11104         * cli/cli-cmds.h: Rename include guard.
11105         * charset-list.h: Add include guard.
11106         * buildsym-legacy.h: Rename include guard.
11107         * bfin-tdep.h: Add include guard.
11108         * ax.h: Rename include guard.
11109         * arm-linux-tdep.h: Add include guard.
11110         * arm-fbsd-tdep.h: Add include guard.
11111         * arch/xtensa.h: Rename include guard.
11112         * arch/tic6x.h: Add include guard.
11113         * arch/i386.h: Add include guard.
11114         * arch/arm.h: Rename include guard.
11115         * arch/arm-linux.h: Rename include guard.
11116         * arch/arm-get-next-pcs.h: Rename include guard.
11117         * arch/amd64.h: Add include guard.
11118         * arch/aarch64-insn.h: Rename include guard.
11119         * arch-utils.h: Rename include guard.
11120         * annotate.h: Add include guard.
11121         * amd64-darwin-tdep.h: Rename include guard.
11122         * aarch64-linux-tdep.h: Add include guard.
11123         * aarch64-fbsd-tdep.h: Add include guard.
11124         * aarch32-linux-nat.h: Add include guard.
11125
11126 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11127
11128         * macrotab.c (macro_define_internal): New function that
11129         factorizes macro_define_object_internal and macro_define_function
11130         code.
11131         (macro_define_object_internal): Use macro_define_internal.
11132         (macro_define_function): Likewise.
11133
11134 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11135
11136         * macrocmd.c (extract_identifier): Return
11137         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11138         callers.
11139
11140 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11141
11142         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11143
11144 2019-02-05  Tom Tromey  <tom@tromey.com>
11145
11146         * target.c (target_stack::unpush): Move assertion earlier.
11147
11148 2019-01-30  Tom Tromey  <tom@tromey.com>
11149
11150         PR python/23615:
11151         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11152         (gdbpy_parse_and_eval): Likewise.
11153         * python/python-internal.h (gdbpy_allow_threads): New class.
11154
11155 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11156
11157         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11158         (aarch64_fbsd_fpregmap): Move earlier.
11159         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11160         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11161         instead of individual calls to trad_frame_set_reg_addr.
11162         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11163         earlier.
11164         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11165         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11166         instead of individual calls to trad_frame_set_reg_addr.
11167
11168 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11169
11170         * CONTRIBUTE: Replace contribution list with wiki link.
11171
11172 2019-01-25  Tom Tromey  <tom@tromey.com>
11173
11174         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11175
11176 2019-01-25  Tom Tromey  <tom@tromey.com>
11177
11178         * xtensa-linux-nat.c: Fix common/ includes.
11179         * xml-support.h: Fix common/ includes.
11180         * xml-support.c: Fix common/ includes.
11181         * x86-linux-nat.c: Fix common/ includes.
11182         * windows-nat.c: Fix common/ includes.
11183         * varobj.h: Fix common/ includes.
11184         * varobj.c: Fix common/ includes.
11185         * value.c: Fix common/ includes.
11186         * valops.c: Fix common/ includes.
11187         * utils.c: Fix common/ includes.
11188         * unittests/xml-utils-selftests.c: Fix common/ includes.
11189         * unittests/utils-selftests.c: Fix common/ includes.
11190         * unittests/unpack-selftests.c: Fix common/ includes.
11191         * unittests/tracepoint-selftests.c: Fix common/ includes.
11192         * unittests/style-selftests.c: Fix common/ includes.
11193         * unittests/string_view-selftests.c: Fix common/ includes.
11194         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11195         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11196         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11197         * unittests/rsp-low-selftests.c: Fix common/ includes.
11198         * unittests/parse-connection-spec-selftests.c: Fix common/
11199         includes.
11200         * unittests/optional-selftests.c: Fix common/ includes.
11201         * unittests/offset-type-selftests.c: Fix common/ includes.
11202         * unittests/observable-selftests.c: Fix common/ includes.
11203         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11204         * unittests/memrange-selftests.c: Fix common/ includes.
11205         * unittests/memory-map-selftests.c: Fix common/ includes.
11206         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11207         * unittests/function-view-selftests.c: Fix common/ includes.
11208         * unittests/environ-selftests.c: Fix common/ includes.
11209         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11210         * unittests/common-utils-selftests.c: Fix common/ includes.
11211         * unittests/cli-utils-selftests.c: Fix common/ includes.
11212         * unittests/array-view-selftests.c: Fix common/ includes.
11213         * ui-file.c: Fix common/ includes.
11214         * tui/tui-io.c: Fix common/ includes.
11215         * tracepoint.h: Fix common/ includes.
11216         * tracepoint.c: Fix common/ includes.
11217         * tracefile-tfile.c: Fix common/ includes.
11218         * top.h: Fix common/ includes.
11219         * top.c: Fix common/ includes.
11220         * thread.c: Fix common/ includes.
11221         * target/waitstatus.h: Fix common/ includes.
11222         * target/waitstatus.c: Fix common/ includes.
11223         * target.h: Fix common/ includes.
11224         * target.c: Fix common/ includes.
11225         * target-memory.c: Fix common/ includes.
11226         * target-descriptions.c: Fix common/ includes.
11227         * symtab.h: Fix common/ includes.
11228         * symfile.c: Fix common/ includes.
11229         * stap-probe.c: Fix common/ includes.
11230         * spu-linux-nat.c: Fix common/ includes.
11231         * sparc-nat.c: Fix common/ includes.
11232         * source.c: Fix common/ includes.
11233         * solib.c: Fix common/ includes.
11234         * solib-target.c: Fix common/ includes.
11235         * ser-unix.c: Fix common/ includes.
11236         * ser-tcp.c: Fix common/ includes.
11237         * ser-pipe.c: Fix common/ includes.
11238         * ser-base.c: Fix common/ includes.
11239         * selftest-arch.c: Fix common/ includes.
11240         * s12z-tdep.c: Fix common/ includes.
11241         * rust-exp.y: Fix common/ includes.
11242         * rs6000-aix-tdep.c: Fix common/ includes.
11243         * riscv-tdep.c: Fix common/ includes.
11244         * remote.c: Fix common/ includes.
11245         * remote-notif.h: Fix common/ includes.
11246         * remote-fileio.h: Fix common/ includes.
11247         * remote-fileio.c: Fix common/ includes.
11248         * regcache.h: Fix common/ includes.
11249         * regcache.c: Fix common/ includes.
11250         * record-btrace.c: Fix common/ includes.
11251         * python/python.c: Fix common/ includes.
11252         * python/py-type.c: Fix common/ includes.
11253         * python/py-inferior.c: Fix common/ includes.
11254         * progspace.h: Fix common/ includes.
11255         * producer.c: Fix common/ includes.
11256         * procfs.c: Fix common/ includes.
11257         * proc-api.c: Fix common/ includes.
11258         * printcmd.c: Fix common/ includes.
11259         * ppc-linux-nat.c: Fix common/ includes.
11260         * parser-defs.h: Fix common/ includes.
11261         * osdata.c: Fix common/ includes.
11262         * obsd-nat.c: Fix common/ includes.
11263         * nat/x86-linux.c: Fix common/ includes.
11264         * nat/x86-linux-dregs.c: Fix common/ includes.
11265         * nat/x86-dregs.h: Fix common/ includes.
11266         * nat/x86-dregs.c: Fix common/ includes.
11267         * nat/ppc-linux.c: Fix common/ includes.
11268         * nat/mips-linux-watch.h: Fix common/ includes.
11269         * nat/mips-linux-watch.c: Fix common/ includes.
11270         * nat/linux-waitpid.c: Fix common/ includes.
11271         * nat/linux-ptrace.h: Fix common/ includes.
11272         * nat/linux-ptrace.c: Fix common/ includes.
11273         * nat/linux-procfs.c: Fix common/ includes.
11274         * nat/linux-personality.c: Fix common/ includes.
11275         * nat/linux-osdata.c: Fix common/ includes.
11276         * nat/linux-namespaces.c: Fix common/ includes.
11277         * nat/linux-btrace.h: Fix common/ includes.
11278         * nat/linux-btrace.c: Fix common/ includes.
11279         * nat/fork-inferior.c: Fix common/ includes.
11280         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11281         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11282         * nat/aarch64-linux.c: Fix common/ includes.
11283         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11284         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11285         * namespace.h: Fix common/ includes.
11286         * mips-linux-tdep.c: Fix common/ includes.
11287         * minsyms.c: Fix common/ includes.
11288         * mi/mi-parse.h: Fix common/ includes.
11289         * mi/mi-main.c: Fix common/ includes.
11290         * mi/mi-cmd-env.c: Fix common/ includes.
11291         * memrange.h: Fix common/ includes.
11292         * memattr.c: Fix common/ includes.
11293         * maint.h: Fix common/ includes.
11294         * maint.c: Fix common/ includes.
11295         * main.c: Fix common/ includes.
11296         * machoread.c: Fix common/ includes.
11297         * location.c: Fix common/ includes.
11298         * linux-thread-db.c: Fix common/ includes.
11299         * linux-nat.c: Fix common/ includes.
11300         * linux-fork.c: Fix common/ includes.
11301         * inline-frame.c: Fix common/ includes.
11302         * infrun.c: Fix common/ includes.
11303         * inflow.c: Fix common/ includes.
11304         * inferior.h: Fix common/ includes.
11305         * inferior.c: Fix common/ includes.
11306         * infcmd.c: Fix common/ includes.
11307         * inf-ptrace.c: Fix common/ includes.
11308         * inf-child.c: Fix common/ includes.
11309         * ia64-linux-nat.c: Fix common/ includes.
11310         * i387-tdep.c: Fix common/ includes.
11311         * i386-tdep.c: Fix common/ includes.
11312         * i386-linux-tdep.c: Fix common/ includes.
11313         * i386-linux-nat.c: Fix common/ includes.
11314         * i386-go32-tdep.c: Fix common/ includes.
11315         * i386-fbsd-tdep.c: Fix common/ includes.
11316         * i386-fbsd-nat.c: Fix common/ includes.
11317         * guile/scm-type.c: Fix common/ includes.
11318         * guile/guile.c: Fix common/ includes.
11319         * go32-nat.c: Fix common/ includes.
11320         * gnu-nat.c: Fix common/ includes.
11321         * gdbthread.h: Fix common/ includes.
11322         * gdbarch-selftests.c: Fix common/ includes.
11323         * gdb_usleep.c: Fix common/ includes.
11324         * gdb_select.h: Fix common/ includes.
11325         * gdb_bfd.c: Fix common/ includes.
11326         * gcore.c: Fix common/ includes.
11327         * fork-child.c: Fix common/ includes.
11328         * findvar.c: Fix common/ includes.
11329         * fbsd-nat.c: Fix common/ includes.
11330         * event-top.c: Fix common/ includes.
11331         * event-loop.c: Fix common/ includes.
11332         * dwarf2read.c: Fix common/ includes.
11333         * dwarf2loc.c: Fix common/ includes.
11334         * dwarf2-frame.c: Fix common/ includes.
11335         * dwarf-index-cache.c: Fix common/ includes.
11336         * dtrace-probe.c: Fix common/ includes.
11337         * disasm-selftests.c: Fix common/ includes.
11338         * defs.h: Fix common/ includes.
11339         * csky-tdep.c: Fix common/ includes.
11340         * cp-valprint.c: Fix common/ includes.
11341         * cp-support.h: Fix common/ includes.
11342         * cp-support.c: Fix common/ includes.
11343         * corelow.c: Fix common/ includes.
11344         * completer.h: Fix common/ includes.
11345         * completer.c: Fix common/ includes.
11346         * compile/compile.c: Fix common/ includes.
11347         * compile/compile-loc2c.c: Fix common/ includes.
11348         * compile/compile-cplus-types.c: Fix common/ includes.
11349         * compile/compile-cplus-symbols.c: Fix common/ includes.
11350         * command.h: Fix common/ includes.
11351         * cli/cli-dump.c: Fix common/ includes.
11352         * cli/cli-cmds.c: Fix common/ includes.
11353         * charset.c: Fix common/ includes.
11354         * build-id.c: Fix common/ includes.
11355         * btrace.h: Fix common/ includes.
11356         * btrace.c: Fix common/ includes.
11357         * breakpoint.h: Fix common/ includes.
11358         * breakpoint.c: Fix common/ includes.
11359         * ax.h:
11360         (enum agent_op): Fix common/ includes.
11361         * ax-general.c (struct aop_map): Fix common/ includes.
11362         * ax-gdb.c: Fix common/ includes.
11363         * auxv.c: Fix common/ includes.
11364         * auto-load.c: Fix common/ includes.
11365         * arm-tdep.c: Fix common/ includes.
11366         * arch/riscv.c: Fix common/ includes.
11367         * arch/ppc-linux-common.c: Fix common/ includes.
11368         * arch/i386.c: Fix common/ includes.
11369         * arch/arm.c: Fix common/ includes.
11370         * arch/arm-linux.c: Fix common/ includes.
11371         * arch/arm-get-next-pcs.c: Fix common/ includes.
11372         * arch/amd64.c: Fix common/ includes.
11373         * arch/aarch64.c: Fix common/ includes.
11374         * arch/aarch64-insn.c: Fix common/ includes.
11375         * arch-utils.c: Fix common/ includes.
11376         * amd64-windows-tdep.c: Fix common/ includes.
11377         * amd64-tdep.c: Fix common/ includes.
11378         * amd64-sol2-tdep.c: Fix common/ includes.
11379         * amd64-obsd-tdep.c: Fix common/ includes.
11380         * amd64-nbsd-tdep.c: Fix common/ includes.
11381         * amd64-linux-tdep.c: Fix common/ includes.
11382         * amd64-linux-nat.c: Fix common/ includes.
11383         * amd64-fbsd-tdep.c: Fix common/ includes.
11384         * amd64-fbsd-nat.c: Fix common/ includes.
11385         * amd64-dicos-tdep.c: Fix common/ includes.
11386         * amd64-darwin-tdep.c: Fix common/ includes.
11387         * agent.c: Fix common/ includes.
11388         * ada-lang.h: Fix common/ includes.
11389         * ada-lang.c: Fix common/ includes.
11390         * aarch64-tdep.c: Fix common/ includes.
11391
11392 2019-01-25  Tom Tromey  <tom@tromey.com>
11393
11394         * common/create-version.sh: Use common/version.h.
11395
11396 2019-01-24  Pedro Alves  <palves@redhat.com>
11397
11398         * infrun.c (signal_stop, signal_print, signal_program)
11399         (signal_catch, signal_pass): Now arrays instead of pointers.
11400         (update_signals_program_target, do_target_resume)
11401         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11402         * linux-nat.c (linux_nat_target::pass_signals)
11403         (linux_nat_target::create_inferior, linux_nat_target::attach):
11404         Adjust.
11405         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11406         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11407         * procfs.c (procfs_target::pass_signals): Adjust.
11408         * record-full.c (record_full_target::resume): Adjust.
11409         * remote.c (remote_target::pass_signals)
11410         (remote_target::program_signals): Adjust.
11411         * target-debug.h (target_debug_print_signals): Now takes a
11412         gdb::array_view as parameter.  Adjust.
11413         * target.h (target_ops) <pass_signals, program_signals>: Replace
11414         pointer and length parameters with gdb::array_view.
11415         (target_pass_signals, target_program_signals): Likewise.
11416         * target-delegates.c: Regenerate.
11417
11418 2019-01-24  Pedro Alves  <palves@redhat.com>
11419
11420         * common/forward-scope-exit.h
11421         (forward_scope_exit::forward_scope_exit): Pass arguments to
11422         m_bind_function directly, instead of creating a std::bind and
11423         copying that.
11424
11425 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11426
11427         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11428         for static members.
11429         (pass_in_v_vfp_candidate): Likewise.
11430
11431 2019-01-23  Tom Tromey  <tom@tromey.com>
11432             Pedro Alves  <palves@redhat.com>
11433
11434         * regcache.c (class regcache_invalidator): Remove.
11435         (regcache::raw_write): Use make_scope_exit.
11436
11437 2019-01-23  Tom Tromey  <tom@tromey.com>
11438
11439         * ui-out.h (class ui_out_emit_type): Update comment.
11440
11441 2019-01-23  Tom Tromey  <tom@tromey.com>
11442
11443         * infrun.c (fetch_inferior_event): Update comment.
11444
11445 2019-01-23  Tom Tromey  <tom@tromey.com>
11446             Pedro Alves  <palves@redhat.com>
11447
11448         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11449         parameter.
11450         (fetch_inferior_event): Use SCOPE_EXIT.
11451
11452
11453 2019-01-23  Tom Tromey  <tom@tromey.com>
11454             Pedro Alves  <palves@redhat.com>
11455
11456         * infrun.c (disable_thread_events): Delete.
11457         (stop_all_threads): Use SCOPE_EXIT.
11458
11459 2019-01-23  Tom Tromey  <tom@tromey.com>
11460             Pedro Alves  <palves@redhat.com>
11461
11462         * symfile.c: Include forward-scope-exit.h.
11463         (clear_symtab_users_cleanup): Replace forward declaration with
11464         a FORWARD_SCOPE_EXIT.
11465         (syms_from_objfile_1): Use the forward_scope_exit and
11466         gdb::optional instead of cleanup_function.
11467         (reread_symbols): Use the forward_scope_exit instead of
11468         cleanup_function.
11469         (clear_symtab_users_cleanup): Remove function.
11470
11471 2019-01-23  Tom Tromey  <tom@tromey.com>
11472             Pedro Alves  <palves@redhat.com>
11473
11474         * linux-nat.c: Include scope-exit.h.
11475         (cleanup_target_stop): Remove.
11476         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11477         SCOPE_EXIT.
11478
11479 2019-01-23  Tom Tromey  <tom@tromey.com>
11480             Pedro Alves  <palves@redhat.com>
11481
11482         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11483         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11484
11485 2019-01-23  Tom Tromey  <tom@tromey.com>
11486             Andrew Burgess  <andrew.burgess@embecosm.com>
11487             Pedro Alves  <palves@redhat.com>
11488
11489         * infrun.c (fetch_inferior_event): Use scope_exit.
11490         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11491         * top.c (execute_command): Use scope_exit.
11492         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11493         * utils.c (do_bpstat_clear_actions_cleanup)
11494         (make_bpstat_clear_actions_cleanup): Remove.
11495
11496 2019-01-23  Tom Tromey  <tom@tromey.com>
11497             Pedro Alves  <palves@redhat.com>
11498
11499         * infrun.c: Include "common/scope-exit.h"
11500         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11501         (wait_for_inferior): Use SCOPE_EXIT.
11502         (fetch_inferior_event): Use scope_exit.
11503
11504 2019-01-23  Tom Tromey  <tom@tromey.com>
11505             Pedro Alves  <palves@redhat.com>
11506
11507         * breakpoint.c (create_breakpoint): Remove cleanup.
11508
11509 2019-01-23  Tom Tromey  <tom@tromey.com>
11510             Andrew Burgess  <andrew.burgess@embecosm.com>
11511             Pedro Alves  <palves@redhat.com>
11512
11513 2019-01-23  Pedro Alves  <palves@redhat.com>
11514
11515         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11516
11517 2019-01-23  Pedro Alves  <palves@redhat.com>
11518             Andrew Burgess  <andrew.burgess@embecosm.com>
11519
11520         * gdbthread.h: Include "common/forward-scope-exit.h".
11521         (scoped_finish_thread_state): Redefine custom class in terms of
11522         forward_scope_exit.
11523
11524 2019-01-23  Pedro Alves  <palves@redhat.com>
11525             Andrew Burgess  <andrew.burgess@embecosm.com>
11526
11527         * common/forward-scope-exit.h: New file.
11528
11529 2019-01-23  Pedro Alves  <palves@redhat.com>
11530             Andrew Burgess  <andrew.burgess@embecosm.com>
11531             Tom Tromey  <tom@tromey.com>
11532
11533         * common/scope-exit.h: New file.
11534
11535 2019-01-23  Pedro Alves  <palves@redhat.com>
11536
11537         * common/preprocessor.h (ESC): Rename to ...
11538         (ESC_PARENS): ... this.
11539         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11540         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11541
11542 2019-01-23  Tom Tromey  <tom@tromey.com>
11543
11544         * language.h (class scoped_switch_to_sym_language_if_auto):
11545         Initialize m_lang in both cases.
11546
11547 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11548
11549         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11550         with XCNEW.
11551
11552 2019-01-22  Tom Tromey  <tom@tromey.com>
11553
11554         * corelow.c: Do not include sys/file.h.
11555
11556 2019-01-22  Tom Tromey  <tom@tromey.com>
11557
11558         * tui/tui-wingeneral.h: Include gdb_curses.h.
11559
11560 2019-01-22  Tom Tromey  <tom@tromey.com>
11561
11562         * source-cache.h (class source_cache) <get_source_lines,
11563         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11564
11565 2019-01-22  Tom Tromey  <tom@tromey.com>
11566
11567         * remote-fileio.h (struct remote_target): Declare.
11568
11569 2019-01-22  Tom Tromey  <tom@tromey.com>
11570
11571         * python/py-arch.c: Do not include py-ref.h.
11572         * python/py-bpevent.c: Do not include py-ref.h.
11573         * python/py-cmd.c: Do not include py-ref.h.
11574         * python/py-continueevent.c: Do not include py-ref.h.
11575         * python/py-event.h: Do not include py-ref.h.
11576         * python/py-evtregistry.c: Do not include py-ref.h.
11577         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11578         * python/py-frame.c: Do not include py-ref.h.
11579         * python/py-framefilter.c: Do not include py-ref.h.
11580         * python/py-function.c: Do not include py-ref.h.
11581         * python/py-infevents.c: Do not include py-ref.h.
11582         * python/py-linetable.c: Do not include py-ref.h.
11583         * python/py-objfile.c: Do not include py-ref.h.
11584         * python/py-param.c: Do not include py-ref.h.
11585         * python/py-prettyprint.c: Do not include py-ref.h.
11586         * python/py-progspace.c: Do not include py-ref.h.
11587         * python/py-symbol.c: Do not include py-ref.h.
11588         * python/py-symtab.c: Do not include py-ref.h.
11589         * python/py-type.c: Do not include py-ref.h.
11590         * python/py-unwind.c: Do not include py-ref.h.
11591         * python/py-utils.c: Do not include py-ref.h.
11592         * python/py-value.c: Do not include py-ref.h.
11593         * python/py-varobj.c: Do not include py-ref.h.
11594         * python/py-xmethods.c: Do not include py-ref.h.
11595         * python/python.c: Do not include py-ref.h.
11596         * varobj.c: Do not include py-ref.h.
11597
11598 2019-01-22  Tom Tromey  <tom@tromey.com>
11599
11600         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11601         keyword for bcache.
11602
11603 2019-01-22  Tom Tromey  <tom@tromey.com>
11604
11605         * compile/compile-cplus-types.c: Remove a comment by #include.
11606
11607 2019-01-22  Tom Tromey  <tom@tromey.com>
11608
11609         * compile/gcc-c-plugin.h: Include compile-internal.h.
11610
11611 2019-01-22  Tom Tromey  <tom@tromey.com>
11612
11613         * stabsread.c (EXTERN): Do not define.
11614         (symnum, next_symbol_text_func, processing_gcc_compilation)
11615         (within_function, global_sym_chain, global_stabs)
11616         (previous_stab_code, this_object_header_files)
11617         (n_this_object_header_files)
11618         (n_allocated_this_object_header_files): Define.
11619         * stabsread.h (EXTERN): Never define.  Use "extern".
11620
11621 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11622
11623         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11624         history_value.
11625
11626 2019-01-21  Tom Tromey  <tom@tromey.com>
11627
11628         * ui-out.c: Fix includes.
11629         * tui/tui-source.c: Fix includes.
11630         * target.c: Fix includes.
11631         * remote.c: Fix includes.
11632         * regcache.c: Fix includes.
11633         * python/py-block.c: Fix includes.
11634         * printcmd.c: Fix includes.
11635         * or1k-tdep.c: Fix includes.
11636         * mi/mi-main.c: Fix includes.
11637         * m32r-tdep.c: Fix includes.
11638         * csky-tdep.c: Fix includes.
11639         * compile/compile-cplus-types.c: Fix includes.
11640         * cli/cli-interp.c: Fix includes.
11641
11642 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11643
11644         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11645         for padding.
11646
11647 2019-01-16  Tom Tromey  <tom@tromey.com>
11648
11649         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11650         earlier.
11651         (struct objfile) <msymbols_range>: Move from top level.
11652         <msymbols>: New method.
11653         (class objfile_msymbols): Remove.
11654         * symtab.c (default_collect_symbol_completion_matches_break_on):
11655         Update.
11656         * symmisc.c (dump_msymbols): Update.
11657         * stabsread.c (scan_file_globals): Update.
11658         * objc-lang.c (info_selectors_command, info_classes_command)
11659         (find_methods): Update.
11660         * minsyms.c (find_solib_trampoline_target): Update.
11661         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11662         * coffread.c (coff_symfile_read): Update.
11663         * ada-lang.c (ada_lookup_simple_minsym)
11664         (ada_collect_symbol_completion_matches): Update.
11665
11666 2019-01-16  Tom Tromey  <tom@tromey.com>
11667
11668         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11669         type.  Remove no-argument constructor.
11670         <iterator::operator++>: Simplify.
11671         <begin>: Update.
11672         <end>: Use minimal_symbol_count.
11673
11674 2019-01-16  Tom Tromey  <tom@tromey.com>
11675
11676         * objfiles.h (struct objfile) <psymtabs>: New method.
11677         (class objfile_psymtabs): Remove.
11678         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11679         typedef.
11680         <range>: New method.
11681         (require_partial_symbols): Change return type.
11682         * psymtab.c (require_partial_symbols)
11683         (psym_expand_symtabs_matching): Update.
11684         * mdebugread.c (parse_partial_symbols): Update.
11685         * dbxread.c (dbx_end_psymtab): Update.
11686
11687 2019-01-15  Tom Tromey  <tom@tromey.com>
11688
11689         * symtab.c (lookup_objfile_from_block)
11690         (lookup_symbol_in_objfile_symtabs)
11691         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11692         (find_line_symtab, info_sources_command)
11693         (default_collect_symbol_completion_matches_break_on)
11694         (make_source_files_completion_list): Update.
11695         * symmisc.c (print_objfile_statistics, dump_objfile)
11696         (maintenance_print_symbols, maintenance_info_symtabs)
11697         (maintenance_check_symtabs, maintenance_info_line_tables):
11698         Update.
11699         * source.c (select_source_symtab)
11700         (forget_cached_source_info_for_objfile): Update.
11701         * objfiles.h (class objfile_compunits): Remove.
11702         (struct objfile) <compunits_range>: New typedef.
11703         (compunits): New method.
11704         * objfiles.c (objfile_relocate1): Update.
11705         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11706         * maint.c (count_symtabs_and_blocks): Update.
11707         * linespec.c (iterate_over_all_matching_symtabs): Update.
11708         * cp-support.c (add_symbol_overload_list_qualified): Update.
11709         * coffread.c (coff_symtab_read): Update.
11710         * ada-lang.c (add_nonlocal_symbols)
11711         (ada_collect_symbol_completion_matches)
11712         (ada_add_global_exceptions): Update.
11713
11714 2019-01-15  Tom Tromey  <tom@tromey.com>
11715
11716         * progspace.h (program_space) <objfiles_safe_range>: New
11717         typedef.
11718         <objfiles_safe>: New method.
11719         * objfiles.h (class all_objfiles_safe): Remove.
11720         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11721         * jit.c (jit_inferior_exit_hook): Update.
11722
11723 2019-01-17  Tom Tromey  <tom@tromey.com>
11724
11725         * progspace.h (program_space) <objfiles_range>: New typedef.
11726         <objfiles>: New method.
11727         <objfiles_head>: Rename from objfiles.
11728         (object_files): Update.
11729         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11730         * guile/scm-pretty-print.c
11731         (ppscm_find_pretty_printer_from_objfiles): Update.
11732         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11733         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11734         Update.
11735         * python/py-progspace.c (pspy_get_objfiles): Update.
11736         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11737         Update.
11738         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11739         (objfpy_lookup_objfile_by_build_id): Update.
11740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11741         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11742         Update.
11743         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11744         (expand_symtab_containing_pc, lookup_objfile_from_block)
11745         (lookup_static_symbol, basic_lookup_transparent_type)
11746         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11747         (find_line_symtab, info_sources_command)
11748         (default_collect_symbol_completion_matches_break_on)
11749         (make_source_files_completion_list, find_main_name): Update.
11750         * symmisc.c (print_symbol_bcache_statistics)
11751         (print_objfile_statistics, maintenance_print_symbols)
11752         (maintenance_print_msymbols, maintenance_print_objfiles)
11753         (maintenance_info_symtabs, maintenance_check_symtabs)
11754         (maintenance_expand_symtabs, maintenance_info_line_tables):
11755         Update.
11756         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11757         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11758         (map_overlay_command, unmap_overlay_command)
11759         (simple_overlay_update, expand_symtabs_matching)
11760         (map_symbol_filenames): Update.
11761         * symfile-debug.c (set_debug_symfile): Update.
11762         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11763         Update.
11764         * source.c (select_source_symtab, forget_cached_source_info):
11765         Update.
11766         * solib.c (solib_read_symbols): Update.
11767         * solib-spu.c (append_ocl_sos): Update.
11768         * psymtab.c (maintenance_print_psymbols)
11769         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11770         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11771         * printcmd.c (info_symbol_command): Update.
11772         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11773         Update.
11774         * objfiles.h (class all_objfiles): Remove.
11775         * objfiles.c (have_partial_symbols, have_full_symbols)
11776         (have_minimal_symbols, qsort_cmp, update_section_map)
11777         (shared_objfile_contains_address_p)
11778         (default_iterate_over_objfiles_in_search_order): Update.
11779         * objc-lang.c (info_selectors_command, info_classes_command)
11780         (find_methods): Update.
11781         * minsyms.c (find_solib_trampoline_target): Update.
11782         * maint.c (maintenance_info_sections)
11783         (maintenance_translate_address, count_symtabs_and_blocks):
11784         Update.
11785         * main.c (captured_main_1): Update.
11786         * linux-thread-db.c (try_thread_db_load_from_pdir)
11787         (has_libpthread): Update.
11788         * linespec.c (iterate_over_all_matching_symtabs)
11789         (search_minsyms_for_name): Update.
11790         * jit.c (jit_find_objf_with_entry_addr): Update.
11791         * hppa-tdep.c (find_unwind_entry)
11792         (hppa_lookup_stub_minimal_symbol): Update.
11793         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11794         Update.
11795         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11796         (elf_gnu_ifunc_resolve_by_got): Update.
11797         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11798         * dwarf-index-write.c (save_gdb_index_command): Update.
11799         * cp-support.c (add_symbol_overload_list_qualified): Update.
11800         * breakpoint.c (create_overlay_event_breakpoint)
11801         (create_longjmp_master_breakpoint)
11802         (create_std_terminate_master_breakpoint)
11803         (create_exception_master_breakpoint): Update.
11804         * blockframe.c (find_pc_partial_function): Update.
11805         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11806         (ada_collect_symbol_completion_matches)
11807         (ada_add_global_exceptions): Update.
11808
11809 2019-01-17  Tom Tromey  <tom@tromey.com>
11810
11811         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11812         declare VEC.
11813         (solib_target_parse_libraries): Change return type.
11814         (library_list_start_segment, library_list_start_section)
11815         (library_list_end_library, library_list_start_library); Update.
11816         (solib_target_free_library_list): Remove.
11817         (solib_target_parse_libraries): Remove cleanup.  Change return
11818         type.
11819         (solib_target_current_sos): Update.
11820
11821 2019-01-17  Tom Tromey  <tromey@bapiya>
11822
11823         * valprint.c: Replace "the the" with "the".
11824         * symtab.c: Replace "the the" with "the".
11825         * solib.c: Replace "the the" with "the".
11826         * solib-dsbt.c: Replace "the the" with "the".
11827         * linespec.c: Replace "the the" with "the".
11828         * dwarf2loc.h: Replace "the the" with "the".
11829         * amd64-windows-tdep.c: Replace "the the" with "the".
11830         * aarch64-tdep.c: Replace "the the" with "the".
11831
11832 2019-01-16  Keith Seitz  <keiths@redhat.com>
11833
11834         PR gdb/23773
11835         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11836         <builder>: Rename to ..
11837         <m_builder>: ... this and make private.
11838         (dwarf2_cu::get_builder): New method.  Change all users of
11839         `builder' to use this method.
11840         (dwarf2_start_symtab): Move to ...
11841         (dwarf2_cu::start_symtab): ... here.  Update all callers
11842         (setup_type_unit_groups): Move to ...
11843         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11844         callers.
11845         (dwarf2_cu::reset_builder): New method.
11846         (process_full_compunit, process_full_type_unit): Use
11847         dwarf2_cu::reset_builder.
11848         (follow_die_offset): Record the ancestor CU if it is different
11849         from the followed DIE's CU.
11850         (follow_die_sig_1): Likewise.
11851
11852 2019-01-15  Tom Tromey  <tom@tromey.com>
11853
11854         * remote.c (class remote_state) <buf>: Now a char_vector.
11855         <buf_size>: Remove.
11856         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11857         parameter.
11858         (remote_target::getpkt_or_notif_sane_1)
11859         (remote_target::getpkt_sane)
11860         (remote_target::getpkt_or_notif_sane): Likewise.
11861         (class remote_target) <putpkt>: New overload.
11862         (remote_target::read_frame): Change type of "buf_p".  Remove
11863         sizeof_p parameter.
11864         (packet_ok): New overload.
11865         (packet_check_result): New overload.
11866         Update all uses.
11867
11868 2019-01-14  Tom Tromey  <tom@tromey.com>
11869
11870         * remote-notif.c (handle_notification, remote_notif_ack)
11871         (remote_notif_parse): Make "buf" const.
11872         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11873         const.
11874         (remote_notif_parse, remote_notif_ack, handle_notification):
11875         Likewise.
11876         * remote.c (remote_notif_stop_parse): Make "buf" const.
11877         (remote_target::remote_parse_stop_reply): Make "buf" const.
11878         (remote_notif_stop_ack): Make "buf" const.
11879
11880 2019-01-14  Tom Tromey  <tom@tromey.com>
11881
11882         * remote.c (remote_console_output): Make parameter const.
11883
11884 2019-01-14  Tom Tromey  <tom@tromey.com>
11885
11886         * target-debug.h (target_debug_print_signals): Constify.
11887         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11888         * procfs.c (procfs_target::pass_signals): Update.
11889         * linux-nat.c (linux_nat_target::pass_signals): Update.
11890         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11891         * target-delegates.c: Rebuild.
11892         * remote.c (remote_target::program_signals): Update.
11893         (remote_target::pass_signals): Update.
11894         * target.c (target_pass_signals): Constify argument.
11895         (target_program_signals): Likewise.
11896         * target.h (struct target_ops) <pass_signals, program_signals>:
11897         Constify argument.
11898         (target_pass_signals, target_program_signals): Constify argument.
11899
11900 2019-01-14  Tom Tromey  <tom@tromey.com>
11901
11902         PR tui/28819:
11903         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11904
11905 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11906
11907         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11908         field.
11909         * rs6000-tdep.c: Include reggroups.h.
11910         (IS_V_ALIAS_PSEUDOREG): Define.
11911         (rs6000_register_name): Return names for the "vX" aliases.
11912         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11913         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11914         aliases.  Call default_register_reggroup_p for all other
11915         pseudo-registers.
11916         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11917         New functions.
11918         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11919         Handle "vX" aliases.
11920         (v_alias_pseudo_register_collect): New function.
11921         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11922         (rs6000_gdbarch_init): Initialize "vX" aliases as
11923         pseudo-registers.  Restore registration of
11924         rs6000_pseudo_register_reggroup_p with
11925         set_tdesc_pseudo_register_reggroup_p.
11926
11927 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11928
11929         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11930         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11931         set_gdbarch_num_pseudo_regs.
11932
11933 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11934
11935         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11936         Remove arg prefixname, add do_set and do_show.
11937         Add member functions set_list and show_list.
11938         * cli/cli-style.c (class cli_style_option): Update accordingly.
11939         (style_set_list): Move to file scope.
11940         (style_show_list): Likewise.
11941         (set_style): Call help_list.
11942         (show_style): Call cmd_show_list.
11943         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11944         Update to use the new macro.
11945
11946 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11947
11948         * ada-lang.c (_initialize_ada_language): Expand the help text
11949         for the "catch exception" command.
11950
11951 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11952
11953         * symtab.c (matching_obj_sections): Initialize obj,
11954         declare it closer to its usage.
11955
11956 2019-01-10  Tom Tromey  <tom@tromey.com>
11957
11958         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11959         (basic_inf_threads_range): Remove.
11960         (inf_threads_range, inf_non_exited_threads_range)
11961         (safe_inf_threads_range): Use next_adapter.
11962
11963 2019-01-10  Keith Seitz  <keiths@redhat.com>
11964
11965         PR gdb/23712
11966         PR symtab/23010
11967         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11968         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11969
11970 2019-01-10  Keith Seitz  <keiths@redhat.com>
11971
11972         PR gdb/23712
11973         PR symtab/23010
11974         * dictionary.c (pending_to_vector): Remove.
11975         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11976         Remove _1 suffix, replacing functions of the same name.  Update
11977         all callers.
11978         (dict_create_hashed, dict_create_hashed_expandable)
11979         (dict_create_linear, dict_create_linear_expandable, dict_free)
11980         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11981         Make functions static.
11982
11983 2019-01-10  Keith Seitz  <keiths@redhat.com>
11984
11985         PR gdb/23712
11986         PR symtab/23010
11987         * dictionary.h (struct dictionary): Replace declaration with
11988         multidictionary.
11989         (dict_create_hashed, dict_create_hashed_expandable)
11990         (dict_create_linear, dict_create_linear_expandable)
11991         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11992         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11993         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11994         taking multidictionary argument.
11995         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11996         * block.h (struct block) <dict>: Change to multidictionary
11997         and rename `multidict'.
11998         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11999         symmisc.c: Update all dictionary references to multidictionary.
12000
12001 2019-01-10  Keith Seitz  <keiths@redhat.com>
12002
12003         PR gdb/23712
12004         PR symtab/23010
12005         * dictionary.c: Include unordered_map.
12006         (pending_to_vector): New function.
12007         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12008         Rewrite the non-"_1" functions to take vector instead
12009         of linked list.
12010         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12011         "new" _1 versions of the same name.
12012         (multidictionary): Define.
12013         (std::hash<enum language): New definition.
12014         (collate_pending_symbols_by_language, mdict_create_hashed)
12015         (mdict_create_hashed_expandable, mdict_create_linear)
12016         (mdict_create_linear_expandable, mdict_free)
12017         (find_language_dictionary, create_new_language_dictionary)
12018         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12019         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12020         (mdict_size, mdict_empty): New functions.
12021         * dictionary.h (mdict_iterator): Define.
12022
12023 2019-01-10  Pedro Alves  <palves@redhat.com>
12024
12025         * breakpoint.c (read_uploaded_action)
12026         (create_tracepoint_from_upload): Adjust to use
12027         gdb::unique_xmalloc_ptr.
12028         * ctf.c (ctf_write_uploaded_tp):
12029         (SET_ARRAY_FIELD): Use emplace_back.
12030         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12031         * tracefile-tfile.c (tfile_write_uploaded_tp):
12032         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12033         gdb::unique_xmalloc_ptr.
12034         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12035         at_string, cond_string, cmd_strings>: Replace char pointers
12036         with gdb::unique_xmalloc_ptr.
12037
12038 2019-01-10  Pedro Alves  <palves@redhat.com>
12039
12040         * solib-target.c (library_list_start_library): Don't xstrdup name.
12041
12042 2019-01-10  Pedro Alves  <palves@redhat.com>
12043
12044         * mdebugread.c (parse_partial_symbols): Use
12045         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12046
12047 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12048
12049         * linux-fork.c (scoped_switch_fork_info)
12050         <~scoped_switch_fork_info>: Fix incorrect variable name.
12051
12052 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12053
12054         * linux-fork.c (scoped_switch_fork_info)
12055         <scoped_switch_fork_info>: Make explicit.
12056         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12057
12058 2019-01-10  Tom Tromey  <tom@tromey.com>
12059
12060         * objfiles.h (objfile::reset_psymtabs): Update.
12061         * objfiles.c (objfile::objfile): Update.
12062         * psymtab.h (psymtab_storage::obstack): Update.
12063         (psymtab_storage::m_obstack): Use gdb::optional.
12064         (class psymtab_storage): Update comment.  Remove objfile
12065         parameter.
12066         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12067
12068 2019-01-10  Tom Tromey  <tom@tromey.com>
12069
12070         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12071         <free_psymtabs>: Now private.
12072         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12073         (allocate_psymtab): Use new method.
12074
12075 2019-01-10  Tom Tromey  <tom@tromey.com>
12076
12077         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12078         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12079         * mdebugread.c (parse_partial_symbols): Use
12080         allocate_dependencies.
12081         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12082         allocate_dependencies.
12083         (process_psymtab_comp_unit_reader)
12084         (build_type_psymtab_dependencies): Likewise.
12085         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12086
12087 2019-01-10  Tom Tromey  <tom@tromey.com>
12088
12089         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12090         PSYMBOL_SET_LANGUAGE.
12091         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12092
12093 2019-01-10  Tom Tromey  <tom@tromey.com>
12094
12095         * psymtab.h (psymtab_storage::obstack): New method.
12096         <m_obstack>: Rename from obstack; now private.
12097         * psymtab.c (psymtab_storage): Update.
12098         * dwarf2read.c (create_addrmap_from_index)
12099         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12100         Update.
12101
12102 2019-01-10  Tom Tromey  <tom@tromey.com>
12103
12104         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12105         * objfiles.h (objfile::reset_psymtabs): New method.
12106
12107 2019-01-10  Tom Tromey  <tom@tromey.com>
12108
12109         * symmisc.c (print_symbol_bcache_statistics): Update.
12110         (print_objfile_statistics): Update.
12111         * symfile.c (reread_symbols): Update.
12112         * psymtab.h (class psymtab_storage): New.
12113         * psymtab.c (psymtab_storage): New constructor.
12114         (~psymtab_storage): New destructor.
12115         (require_partial_symbols): Update.
12116         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12117         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12118         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12119         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12120         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12121         (start_psymtab_common, end_psymtab_common)
12122         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12123         (allocate_psymtab): Update.
12124         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12125         Update.
12126         (dump_psymtab_addrmap, maintenance_print_psymbols)
12127         (maintenance_check_psymtabs): Update.
12128         (class objfile_psymtabs): Move to objfiles.h.
12129         * psympriv.h (discard_psymtab): Now inline.
12130         (psymtab_discarder::psymtab_discarder): Update.
12131         (psymtab_discarder::~psymtab_discarder): Update.
12132         (ALL_OBJFILE_PSYMTABS): Rewrite.
12133         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12134         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12135         Remove fields.
12136         <partial_symtabs>: New field.
12137         (class objfile_psymtabs): Move from psymtab.h.  Update.
12138         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12139         psymbol_cache.
12140         (objfile::~objfile): Don't destroy psymbol_cache.
12141         * mdebugread.c (parse_partial_symbols): Update.
12142         * dwarf2read.c (create_addrmap_from_index)
12143         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12144         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12145         (add_partial_subprogram, dwarf2_ranges_read): Update.
12146         * dwarf-index-write.c (write_address_map)
12147         (write_one_signatured_type, recursively_write_psymbols)
12148         (class debug_names, class debug_names, write_psymtabs_to_index):
12149         Update.
12150
12151 2019-01-10  Tom Tromey  <tom@tromey.com>
12152
12153         * symtab.h (SYMBOL_SET_NAMES): Update.
12154         (symbol_set_names): Update.
12155         (MSYMBOL_SET_NAMES): Update.
12156         * symtab.c (symbol_set_names): Change argument to be an
12157         objfile_per_bfd_storage.
12158         * psymtab.c (add_psymbol_to_bcache): Update.
12159         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12160
12161 2019-01-10  Tom Tromey  <tom@tromey.com>
12162
12163         * symtab.c (create_demangled_names_hash): Change argument to be an
12164         objfile_per_bfd_storage.
12165         (symbol_set_names): Update.
12166
12167 2019-01-10  Tom Tromey  <tom@tromey.com>
12168
12169         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12170         init_psymbol_list.
12171         * psymtab.c (init_psymbol_list): Do nothing if already called.
12172         * psympriv.h (init_psymbol_list): Add comment.
12173         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12174         init_psymbol_list.
12175         * dbxread.c (dbx_symfile_read): Unconditionally call
12176         init_psymbol_list.
12177
12178 2019-01-10  Tom Tromey  <tom@tromey.com>
12179
12180         * xcoffread.c (scan_xcoff_symtab): Update.
12181         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12182         "where".
12183         * mdebugread.c (parse_partial_symbols)
12184         (handle_psymbol_enumerators): Update.
12185         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12186         * dbxread.c (read_dbx_symtab): Update.
12187         * psympriv.h (psymbol_placement): New enum.
12188         (add_psymbol_to_list): Update.
12189
12190 2019-01-10  Tom Tromey  <tom@tromey.com>
12191
12192         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12193         static_psymbols parameters.
12194         (scan_xcoff_symtab): Update.
12195         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12196         static_psymbols parameters.
12197         * psympriv.h (start_psymtab_common): Update.
12198         * mdebugread.c (parse_partial_symbols): Update.
12199         * dwarf2read.c (create_partial_symtab): Update.
12200         * dbxread.c (read_dbx_symtab): Update.
12201         (start_psymtab): Remove global_psymbols and static_psymbols
12202         parameters.
12203
12204 2019-01-10  Tom Tromey  <tom@tromey.com>
12205
12206         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12207         * psymtab.c (allocate_psymtab): Add comment.
12208         * psympriv.h (allocate_psymtab): Add comment.
12209         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12210         initializations.
12211         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12212
12213 2019-01-10  Tom Tromey  <tom@tromey.com>
12214
12215         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12216         Don't declare.
12217         * mipsread.c: Include mdebugread.h.
12218         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12219         Declare.
12220         * elfread.c: Include mdebugread.h.
12221
12222 2019-01-09  Tom Tromey  <tom@tromey.com>
12223
12224         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12225         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12226         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12227         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12228         (psym_lookup_symbol, psym_find_last_source_symtab)
12229         (psym_forget_cached_source_info, psym_print_stats)
12230         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12231         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12232         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12233         (psym_find_compunit_symtab_by_address)
12234         (maintenance_print_psymbols, maintenance_info_psymtabs)
12235         (maintenance_check_psymtabs): Use ranged for.
12236         * psymtab.h (class objfile_psymtabs): New.
12237         (require_partial_symbols): Return objfile_psymtabs.
12238         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12239
12240 2019-01-09  Tom Tromey  <tom@tromey.com>
12241
12242         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12243         (find_pc_mapped_section, list_overlays_command)
12244         (map_overlay_command, unmap_overlay_command)
12245         (simple_overlay_update): Use all_objfiles.
12246         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12247         * printcmd.c (info_symbol_command): Use all_objfiles.
12248         * objfiles.h (ALL_OBJSECTIONS): Remove.
12249         * maint.c (maintenance_translate_address): Use all_objfiles.
12250         * gcore.c (gcore_create_callback): Use all_objfiles.
12251         (objfile_find_memory_regions): Likewise.
12252
12253 2019-01-09  Tom Tromey  <tom@tromey.com>
12254
12255         * symtab.c (find_line_symtab, info_sources_command)
12256         (make_source_files_completion_list): Use objfile_compunits.
12257         * source.c (select_source_symtab): Use objfile_compunits.
12258         * objfiles.h (struct objfile): Update comment.
12259         (ALL_OBJFILES): Remove.
12260         (ALL_FILETABS): Remove.
12261         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12262         objfile_compunits.
12263
12264 2019-01-09  Tom Tromey  <tom@tromey.com>
12265
12266         * symmisc.c (print_objfile_statistics, dump_objfile)
12267         (maintenance_print_symbols): Use compunit_filetabs.
12268         * source.c (forget_cached_source_info_for_objfile): Use
12269         compunit_filetabs.
12270         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12271         (ALL_FILETABS): Use compunit_filetabs.
12272         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12273         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12274
12275 2019-01-09  Tom Tromey  <tom@tromey.com>
12276
12277         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12278         (compunit_filetabs): New.
12279         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12280         compunit_filetabs.
12281         (info_sources_command, make_source_files_completion_list): Remove
12282         declaration.
12283         * symmisc.c (print_objfile_statistics, dump_objfile)
12284         (maintenance_print_symbols): Remove declaration.
12285         (maintenance_info_symtabs): Use compunit_filetabs.
12286         (maintenance_info_line_tables): Likewise.
12287         * source.c (select_source_symtab): Change local variable name.
12288         (forget_cached_source_info_for_objfile): Remove declaration.
12289         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12290         * objfiles.c (objfile_relocate1): Remove declaration.
12291         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12292         declaration.
12293         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12294         * coffread.c (coff_symtab_read): Remove declaration.
12295         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12296         compunit_filetabs.
12297
12298 2019-01-09  Tom Tromey  <tom@tromey.com>
12299
12300         * symtab.c (lookup_objfile_from_block)
12301         (find_pc_sect_compunit_symtab, search_symbols)
12302         (default_collect_symbol_completion_matches_break_on): Use
12303         objfile_compunits.
12304         * objfiles.h (ALL_COMPUNITS): Remove.
12305         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12306         * cp-support.c (add_symbol_overload_list_qualified): Use
12307         objfile_compunits.
12308         * ada-lang.c (ada_collect_symbol_completion_matches)
12309         (ada_add_global_exceptions): Use objfile_compunits.
12310
12311 2019-01-09  Tom Tromey  <tom@tromey.com>
12312
12313         * source.c (select_source_symtab)
12314         (forget_cached_source_info_for_objfile): Remove declaration.
12315         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12316         declaration.
12317         * maint.c (count_symtabs_and_blocks): Remove declaration.
12318         * cp-support.c (add_symbol_overload_list_qualified): Remove
12319         declaration.
12320         * coffread.c (coff_symtab_read): Remove declaration.
12321         * symtab.c (lookup_symbol_in_objfile_symtabs)
12322         (basic_lookup_transparent_type_1): Use objfile_compunits.
12323         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12324         (info_sources_command, search_symbols)
12325         (default_collect_symbol_completion_matches_break_on)
12326         (make_source_files_completion_list): Remove declaration.
12327         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12328         (ada_collect_symbol_completion_matches)
12329         (ada_add_global_exceptions): Remove declaration.
12330         * linespec.c (iterate_over_all_matching_symtabs): Use
12331         objfile_compunits.
12332         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12333         (class objfile_compunits): New.
12334         (ALL_COMPUNITS): Use objfile_compunits.
12335         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12336         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12337         objfile_compunits.
12338         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12339
12340 2019-01-09  Tom Tromey  <tom@tromey.com>
12341
12342         * symtab.c (search_symbols)
12343         (default_collect_symbol_completion_matches_break_on): Use
12344         objfile_msymbols.
12345         * ada-lang.c (ada_lookup_simple_minsym)
12346         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12347         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12348         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12349         objfile_msymbols.
12350         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12351         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12352         * objc-lang.c (find_methods): Use objfile_msymbols.
12353         (info_selectors_command, info_classes_command): Likewise.
12354         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12355         * objfiles.h (class objfile_msymbols): New.
12356         (ALL_OBJFILE_MSYMBOLS): Remove.
12357         (ALL_MSYMBOLS): Remove.
12358
12359 2019-01-09  Tom Tromey  <tom@tromey.com>
12360
12361         * common/next-iterator.h (next_adapter): Add Iterator template
12362         parameter.
12363         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12364         (class all_objfiles_safe): New.
12365         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12366         * objfiles.c (put_objfile_before): Update comment.
12367         (add_separate_debug_objfile): Likewise.
12368         (free_all_objfiles): Use all_objfiles_safe.
12369         (objfile_purge_solibs): Likewise.
12370
12371 2019-01-09  Tom Tromey  <tom@tromey.com>
12372
12373         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12374         (expand_symtab_containing_pc, lookup_static_symbol)
12375         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12376         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12377         all_objfiles.
12378         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12379         * breakpoint.c (create_overlay_event_breakpoint)
12380         (create_longjmp_master_breakpoint)
12381         (create_std_terminate_master_breakpoint)
12382         (create_exception_master_breakpoint): Use all_objfiles.
12383         * linux-thread-db.c (try_thread_db_load_from_pdir)
12384         (has_libpthread): Use all_objfiles.
12385         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12386         * linespec.c (iterate_over_all_matching_symtabs)
12387         (search_minsyms_for_name): Use all_objfiles.
12388         * maint.c (maintenance_info_sections): Use all_objfiles.
12389         * main.c (captured_main_1): Use all_objfiles.
12390         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12391         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12392         * guile/scm-pretty-print.c
12393         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12394         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12395         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12396         (maintenance_print_msymbols): Use all_objfiles.
12397         * source.c (select_source_symtab): Use all_objfiles.
12398         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12399         * symfile.c (remove_symbol_file_command)
12400         (expand_symtabs_matching, map_symbol_filenames): Use
12401         all_objfiles.
12402         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12403         all_objfiles.
12404         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12405         * objc-lang.c (find_methods): Use all_objfiles.
12406         * objfiles.c (have_partial_symbols, have_full_symbols)
12407         (have_minimal_symbols, qsort_cmp)
12408         (default_iterate_over_objfiles_in_search_order): Use
12409         all_objfiles.
12410         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12411         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12412         (maintenance_check_psymtabs): Use all_objfiles.
12413         (ALL_PSYMTABS): Remove.
12414         * compile/compile-object-run.c (do_module_cleanup): Use
12415         all_objfiles.
12416         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12417         * cp-support.c (add_symbol_overload_list_qualified): Use
12418         all_objfiles.
12419         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12420         Use all_objfiles.
12421         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12422         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12423         all_objfiles.
12424         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12425         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12426         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12427         Uses all_objfiles.
12428         * solib.c (solib_read_symbols): Use all_objfiles
12429
12430 2019-01-09  Tom Tromey  <tom@tromey.com>
12431
12432         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12433         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12434         all_objfiles.
12435         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12436         * symmisc.c (print_symbol_bcache_statistics)
12437         (print_objfile_statistics, maintenance_print_objfiles)
12438         (maintenance_info_symtabs, maintenance_check_symtabs)
12439         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12440         all_objfiles.
12441         * source.c (forget_cached_source_info): Use all_objfiles.
12442         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12443         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12444         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12445         * objfiles.c (update_section_map): Use all_objfiles.
12446         (shared_objfile_contains_address_p): Likewise.
12447         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12448         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12449
12450 2019-01-09  Tom Tromey  <tom@tromey.com>
12451
12452         * common/next-iterator.h: New file.
12453         * objfiles.h (class all_objfiles): New.
12454         (struct objfile_iterator): New.
12455
12456 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12457
12458         * NEWS: Move the description of the changed "frame", "select-frame",
12459          and "info frame" commands to the Changed commands section.
12460
12461 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12462
12463         * gdbtypes.c (check_stub_method_group): Remove handling of old
12464         mangling schemes.
12465         * linespec.c (find_methods): Likewise.
12466         * stabsread.c (read_member_functions): Likewise.
12467         * valops.c (search_struct_method): Likewise.
12468         (value_struct_elt_for_reference): Likewise.
12469         * NEWS: Mention this change.
12470
12471 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12472
12473         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12474         print_source_lines.
12475         * source.c (print_source_lines_base): Update line number check.
12476         (print_source_lines): New function.
12477         (source_lines_range::source_lines_range): New function.
12478         * source.h (class source_lines_range): New class.
12479         (print_source_lines): New declaration.
12480
12481 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12482
12483         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12484
12485 2019-01-08  Tom Tromey  <tom@tromey.com>
12486             Simon Marchi  <simon.marchi@ericsson.com>
12487
12488         PR gdb/24060
12489         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12490         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12491         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12492         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12493         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12494         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12495
12496 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12497
12498         * source.c (select_source_symtab): Move header comment to
12499         declaration in source.h.
12500         (forget_cached_source_info_for_objfile): Likewise.
12501         (forget_cached_source_info): Likewise.
12502         (identify_source_line): Likewise.
12503         * source.h (identify_source_line): Move declaration from symtab.h
12504         and add comment from source.c
12505         (print_source_lines): Likewise.
12506         (forget_cached_source_info_for_objfile): Likewise.
12507         (forget_cached_source_info): Likewise.
12508         (select_source_symtab): Likewise.
12509         (enum print_source_lines_flag): Move definition from symtab.h.
12510         * symtab.h (identify_source_line): Move declaration to source.h.
12511         (print_source_lines): Likewise.
12512         (forget_cached_source_info_for_objfile): Likewise.
12513         (forget_cached_source_info): Likewise.
12514         (select_source_symtab): Likewise.
12515         (enum print_source_lines_flag): Move definition to source.h.
12516         * tui/tui-hooks.c: Add 'source.h' include.
12517
12518 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12519
12520         * source.c (print_source_lines_base): Handle requests to print
12521         reverse line number sequences, and guard against empty lines
12522         string.
12523
12524 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12525
12526         * source.c (print_source_lines_base): Fix skip of '\r' if next
12527         character is '\n'.
12528
12529 2019-01-06  Tom Tromey  <tom@tromey.com>
12530
12531         * c-exp.y (struct c_parse_state) <macro_original_text,
12532         expansion_obstack>: New member.
12533         (macro_original_text, expansion_obstack): Remove globals.
12534         (scan_macro_expansion, scanning_macro_expansion)
12535         (finished_macro_expansion): Update.
12536         (scan_macro_cleanup): Remove.
12537         (yylex, c_parse): Update.
12538
12539 2019-01-06  Tom Tromey  <tom@tromey.com>
12540
12541         * c-exp.y (struct c_parse_state) <strings>: New member.
12542         (operator_stoken): Update.
12543
12544 2019-01-06  Tom Tromey  <tom@tromey.com>
12545
12546         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12547         (union type_stack_elt) <typelist_val>: Now a pointer to
12548         std::vector.
12549         (type_stack_cleanup): Don't declare.
12550         (push_typelist): Update.
12551         * parse.c (pop_typelist): Return a std::vector.
12552         (push_typelist): Take a std::vector.
12553         (follow_types): Update.  Do not free args.
12554         (type_stack_cleanup): Remove.
12555         * c-exp.y (struct c_parse_state): New.
12556         (cpstate): New global.
12557         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12558         (nonempty_typelist): Update.
12559         (func_mod): Create a new vector.
12560         (c_parse): Create a c_parse_state.
12561         (check_parameter_typelist): Do not delete params.
12562         (function_method): Update.  Do not delete type_list.
12563
12564 2019-01-06  Tom Tromey  <tom@tromey.com>
12565
12566         PR gdb/28155:
12567         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12568         check_typedef.
12569         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12570         (print_return_value): Likewise.
12571
12572 2019-01-05  Tom Tromey  <tom@tromey.com>
12573
12574         * contrib/cleanup_check.py: Remove.
12575         * contrib/gcc-with-excheck: Remove.
12576         * contrib/exsummary.py: Remove.
12577         * contrib/excheck.py: Remove.
12578
12579 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12580
12581         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12582         NULL. Initialize tpprev to NULL instead of assigning it
12583         to NULL on the next statement.
12584         * windows-nat.c (windows_delete_thread): Remove check for
12585         main_thread_id before printing thread exit notifications.
12586         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12587         Remove thread ID check against main_thread_id.
12588         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12589         windows_delete_thread.
12590         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12591
12592 2019-01-04  Tom Tromey  <tom@tromey.com>
12593
12594         * compile/compile.c (_initialize_compile): Use upper case for
12595         metasyntactic variables.
12596         * symmisc.c (_initialize_symmisc): Use upper case for
12597         metasyntactic variables.
12598         * psymtab.c (_initialize_psymtab): Use upper case for
12599         metasyntactic variables.
12600         * demangle.c (demangle_command): Use upper case for metasyntactic
12601         variables.
12602         (_initialize_demangler): Likewise.
12603         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12604         variables.
12605
12606 2019-01-03  Tom Tromey  <tom@tromey.com>
12607
12608         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12609
12610 2019-01-03  Tom Tromey  <tom@tromey.com>
12611
12612         * python/py-symtab.c (salpy_str): Update.
12613         (struct salpy_sal_object) <symtab>: Now a PyObject.
12614         (salpy_dealloc): Update.
12615         (del_objfile_sal): Use gdbpy_ref.
12616
12617 2019-01-03  Tom Tromey  <tom@tromey.com>
12618
12619         * python/py-type.c (convert_field): Use new_reference.  Return
12620         gdbpy_ref.
12621         (make_fielditem): Return gdbpy_ref.
12622         (typy_fields): Update.
12623         (typy_getitem): Update.
12624         (field_name): Return gdbpy_ref.  Use new_reference.
12625         (typy_iterator_iternext): Update.
12626
12627 2019-01-03  Tom Tromey  <tom@tromey.com>
12628
12629         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12630
12631 2019-01-03  Tom Tromey  <tom@tromey.com>
12632
12633         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12634         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12635         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12636         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12637         (pspy_set_type_printers): Likewise.
12638         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12639         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12640         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12641         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12642         (objfpy_set_type_printers): Likewise.
12643
12644 2019-01-03  Tom Tromey  <tom@tromey.com>
12645
12646         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12647         (gdbpy_print_stack): Use gdbpy_err_fetch.
12648         * python/python-internal.h (class gdbpy_err_fetch): New class.
12649         (class gdbpy_enter) <m_error_type, m_error_value,
12650         m_error_traceback>: Remove.
12651         <m_error>: New member.
12652         (gdbpy_exception_to_string): Don't declare.
12653         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12654         * python/py-value.c (convert_value_from_python): Use
12655         gdbpy_err_fetch.
12656         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12657         gdbpy_exception_to_string.
12658         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12659         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12660         gdbpy_err_fetch.
12661
12662 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12663
12664         * linux-nat.c (delete_lwp_cleanup): Delete.
12665         (struct lwp_deleter): New struct.
12666         (lwp_info_up): New typedef.
12667         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12668         lwp_info_up.
12669
12670 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12671
12672         * linux-fork.c (class scoped_switch_fork_info): New class.
12673         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12674
12675 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12676
12677         * valops.c (find_overload_match): Remove use of null_cleanup, and
12678         calls to do_cleanups.
12679
12680 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12681
12682         * compile/compile-cplus-types.c
12683         (compile_cplus_instance::decl_name): Handle changes to
12684         cp_func_name.
12685         * cp-support.c (cp_func_name): Update header comment, update
12686         return type.
12687         * cp-support.h (cp_func_name): Update return type in declaration.
12688         * valops.c (find_overload_match): Move temp_func local to top
12689         level of function and change its type.  Use temp_func to hold and
12690         delete temporary string obtained from cp_func_name.
12691
12692 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12693
12694         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12695         gdb::char_vector, remove cleanup, and update uses of `msg`.
12696
12697 2019-01-03  Jim Wilson  <jimw@sifive.com>
12698
12699         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12700
12701 2019-01-02  Tom Tromey  <tom@tromey.com>
12702
12703         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12704         (tdesc_parse_xml): Remove cleanups.
12705         * target-descriptions.h (make_cleanup_free_target_description):
12706         Don't declare.
12707         (target_desc_deleter): New struct.
12708         (target_desc_up): New typedef.
12709         * target-descriptions.c (target_desc_deleter::operator()): Rename
12710         from free_target_description.
12711         (make_cleanup_free_target_description): Remove.
12712
12713 2019-01-02  Tom Tromey  <tom@tromey.com>
12714
12715         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12716         constructor, destructor.
12717         (linespec_parser): Remove typedef.
12718         (~linespec_parser): Rename from linespec_parser_delete.
12719         (linespec_lex_to_end, linespec_complete_label)
12720         (linespec_complete): Update.
12721         (decode_line_full): Remove cleanups.
12722         (decode_line_1): Update.
12723
12724 2019-01-02  Tom Tromey  <tom@tromey.com>
12725
12726         * python/python-internal.h (inferior_to_inferior_object): Change
12727         return type.
12728         * python/py-exitedevent.c (create_exited_event_object): Update.
12729         * python/py-inferior.c (inferior_to_inferior_object): Return
12730         gdbpy_ref.
12731         (python_new_inferior, python_inferior_deleted)
12732         (thread_to_thread_object, delete_thread_object)
12733         (build_inferior_list, gdbpy_selected_inferior): Update.
12734         * python/py-infthread.c (create_thread_object): Update.  Also fail
12735         if inferior_to_inferior_object fails.
12736
12737 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12738
12739         * inferior.h (class inferior) <displaced_step_state>: New field.
12740         * infrun.h (struct displaced_step_state): Move here from
12741         infrun.c.  Initialize fields, add constructor.
12742         <inf>: Remove field.
12743         <reset>: New method.
12744         * infrun.c (struct displaced_step_inferior_state): Move to
12745         infrun.h.
12746         (displaced_step_inferior_states): Remove.
12747         (get_displaced_stepping_state): Adust.
12748         (displaced_step_in_progress_any_inferior): Adjust.
12749         (displaced_step_in_progress_thread): Adjust.
12750         (displaced_step_in_progress): Adjust.
12751         (add_displaced_stepping_state): Remove.
12752         (get_displaced_step_closure_by_addr): Adjust.
12753         (remove_displaced_stepping_state): Remove.
12754         (infrun_inferior_exit): Call displaced_step_state.reset.
12755         (use_displaced_stepping): Don't check for NULL.
12756         (displaced_step_prepare_throw): Call
12757         get_displaced_stepping_state.
12758         (displaced_step_fixup): Don't check for NULL.
12759         (prepare_for_detach): Don't check for NULL.
12760
12761 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12762
12763         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12764          in case of call that did not complete.
12765
12766 2019-01-02  Andrey Utkin  <autkin@undo.io>
12767
12768         * symfile.c (find_separate_debug_file): Fix search of debug files for
12769         remote debuggee.
12770
12771 2019-01-02  Tom Tromey  <tom@tromey.com>
12772
12773         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12774         indentation.
12775         * python/py-frame.c (frapy_older): Remove cast.
12776         (frapy_newer): Likewise.
12777         * python/py-breakpoint.c (local_setattro): Remove cast.
12778         * python/py-arch.c (archpy_name): Remove local variable.
12779         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12780
12781 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12782
12783         * unittests/basic_string_view/element_access/char/empty.cc:
12784         Fix year range in copyright header.
12785
12786 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12787
12788         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12789         Delete.
12790         <operator==>: Update with for removed field.
12791         <hash>: Likewise.
12792         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12793         <isa_features>: ...this.
12794         <abi_features>: New field.
12795         (riscv_isa_flen): Update comment.
12796         (riscv_abi_xlen): New declaration.
12797         (riscv_abi_flen): New declaration.
12798         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12799         isa_features.
12800         (riscv_abi_xlen): New function.
12801         (riscv_isa_flen): Update to get answer from isa_features.
12802         (riscv_abi_flen): New function.
12803         (riscv_has_fp_abi): Update to get answer from abi_features.
12804         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12805         xlen and flen.
12806         (riscv_call_info) <xlen, flen>: Update comment.
12807         (riscv_call_arg_struct): Remove invalid assertions
12808         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12809         is removed.
12810         (riscv_gdbarch_init): Gather isa features and abi features
12811         separately, ensure both match on the gdbarch when reusing an old
12812         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12813         a target with 64-bit float hardware.
12814
12815 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12816
12817         * source.c (search_command_helper): Stop reverse search
12818         when line 1 has been searched.
12819
12820 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12821
12822         * record-full.c (record_full_base_target::close): Rewrite
12823         record_full_core_buf_list free logic.
12824
12825 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12826
12827         * break-catch-syscall.c (print_one_catch_syscall): xfree
12828         the last text.
12829
12830 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12831
12832         * top.c (print_gdb_version): Update Copyright year in version
12833         message.
12834
12835 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12836
12837         Update copyright year range in all GDB files.
12838
12839 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12840
12841         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12842
12843 For older changes see ChangeLog-2018.
12844 \f
12845 Local Variables:
12846 mode: change-log
12847 left-margin: 8
12848 fill-column: 74
12849 version-control: never
12850 coding: utf-8
12851 End:
12852