gdb/ChangeLog

   1 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
   4         probe arguments.
   5
   6 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
   9         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
  10         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
  11         (compile_probe_arg): Likewise.
  12         * probe.h (get_argument_count): Likewise.
  13         * solib-svr4.c (solib_event_probe_action): Likewise.
  14         * stap-probe.c (stap_probe::get_argument_count): Likewise.
  15
  16 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  17
  18         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
  19         code to here...
  20         (svr4_create_solib_event_breakpoints): ...from here.
  21
  22 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
  23
  24         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  25         suffix from warning message.
  26
  27 2019-08-30  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-winsource.h (struct tui_source_window_base)
  30         <refresh_all>: Don't declare.
  31         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  32         Remove.
  33         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  34         tui_show_locator_content.
  35         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  36         declare.
  37         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  38         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  39         declare.
  40
  41 2019-08-30  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
  44
  45 2019-08-30  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-stack.c (_initialize_tui_stack): Move later.
  48         Remove unnecessary forward declarations.
  49
  50 2019-08-30  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
  53         rerender.
  54         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  55         tui_show_locator_content.
  56
  57 2019-08-30  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  60         (tui_locator_window::rerender): Rewrite using body of previous
  61         tui_show_locator_content.
  62
  63 2019-08-30  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  66         set_locator_fullname>: New methods.
  67         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  68         Rename from tui_set_locator_fullname.
  69         (tui_locator_window::set_locator_info): Rename from
  70         tui_set_locator_info.  Return bool.
  71         (tui_update_locator_fullname, tui_show_frame_info): Update.
  72
  73 2019-08-30  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  76
  77 2019-08-30  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  80         call touchwin.
  81
  82 2019-08-30  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-wingeneral.c (box_win): Assume win_info and
  85         win_info->handle cannot be NULL.
  86
  87 2019-08-30  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  90         refresh_window>: Declare.
  91         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  92         resize.
  93         (tui_data_item_window::rerender): Rename from
  94         tui_display_register.
  95         (tui_data_item_window::refresh_window): New method.
  96         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  97         no-op.
  98
  99 2019-08-30  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 102         regs_column_count, current_group>: Move later.  Now private.
 103         <get_current_group>: New method.
 104         * tui/tui-regs.c (tui_reg_command): Update.
 105         * tui/tui-layout.c (tui_set_layout): Update.
 106
 107 2019-08-30  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 110         (tui_data_window::rerender): Don't call
 111         check_and_display_highlight_if_needed.
 112         (tui_data_window::refresh_all): Remove call to
 113         erase_data_content.
 114
 115 2019-08-30  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 118         (tui_data_window::display_registers_from)
 119         (tui_data_window::display_reg_element_at_line)
 120         (tui_data_window::display_registers_from_line): Remove checks of
 121         "empty".
 122
 123 2019-08-30  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 126         Don't declare.
 127         * tui/tui-regs.c (tui_data_window::show_registers): Call
 128         rerender.
 129         (tui_data_window::rerender): Rename from display_all_data.
 130         (tui_data_window::rerender): Remove old implementation.
 131
 132 2019-08-30  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 135         text.
 136         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 137
 138 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 139             Sergio Durigan Junior  <sergiodj@redhat.com>
 140
 141         PR win32/24284
 142         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 143
 144 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 147         when searching for types.
 148
 149 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * f-lang.c (f_language_defn): Use f_print_typedef.
 152         * f-lang.h (f_print_typedef): Declare.
 153         * f-typeprint.c (f_print_typedef): Define.
 154
 155 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 156
 157         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 158
 159 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 160
 161         * cli/cli-utils.c (info_print_options_defs): Delete.
 162         (make_info_print_options_def_group): Delete.
 163         (extract_info_print_options): Delete.
 164         (info_print_command_completer): Delete.
 165         (info_print_args_help): Add extra parameter, and optionally
 166         include text about -n flag.
 167         * cli/cli-utils.h (struct info_print_options): Delete.
 168         (extract_info_print_options): Delete declaration.
 169         (info_print_command_completer): Delete declaration.
 170         (info_print_args_help): Add extra parameter, extend header
 171         comment.
 172         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 173         search_symbols.
 174         * stack.c (struct info_print_options): New type.
 175         (info_print_options_defs): New file scoped variable.
 176         (make_info_print_options_def_group): New static function.
 177         (info_print_command_completer): New static function.
 178         (info_locals_command): Update to use new local functions.
 179         (info_args_command): Likewise.
 180         (_initialize_stack): Add extra parameter to calls to
 181         info_print_args_help.
 182         * symtab.c (search_symbols): Add extra parameter, use this to
 183         possibly excluse non-debug symbols.
 184         (symtab_symbol_info): Add extra parameter, which is passed on to
 185         search_symbols.
 186         (struct info_print_options): New type.
 187         (info_print_options_defs): New file scoped variable.
 188         (make_info_print_options_def_group): New static function.
 189         (info_print_command_completer): New static function.
 190         (info_variables_command): Update to use local functions, and pass
 191         extra parameter through to symtab_symbol_info.
 192         (info_functions_command): Likewise.
 193         (info_types_command): Pass additional argument through to
 194         symtab_symbol_info.
 195         (rbreak_command): Pass extra argument to search_symbols.
 196         (_initialize_symtab): Add extra arguments for calls to
 197         info_print_args_help, and update help text for 'info variables',
 198         'whereis', and 'info functions' commands.
 199         * symtab.h (search_symbols): Add extra argument to declaration.
 200         * NEWS: Mention new flags.
 201
 202 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 203
 204         * symtab.c (lookup_static_symbol): Call the new function (and move
 205         it down to be next to lookup_global_symbol).
 206         (struct global_sym_lookup_data): Add block_enum member and rename to...
 207         (struct global_or_static_sym_lookup_data): ...this.
 208         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 209         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 210         (lookup_symbol_global_or_static_iterator_cb): ...this.
 211         (lookup_global_or_static_symbol): New function.
 212         (lookup_global_symbol): Call new function.
 213
 214 2019-08-26  Tom de Vries  <tdevries@suse.de>
 215
 216         PR c++/24852
 217         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 218         when pc_probe.prob == NULL.
 219
 220 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 221
 222         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 223         variable symbol_linkage to symbol_linkage_.
 224
 225 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 226
 227         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 228         represent whether the symbol is static, dynamic, or we don't
 229         know.
 230
 231 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 232
 233         * gdb/rx-tdep.c (rx_register_names): New.
 234         (rx_register_name): Delete.
 235         (rx_psw_type): Delete.
 236         (rx_fpsw_type): Delete.
 237         (rx_register_type): Delete.
 238         (rx_gdbarch_init): Convert target-descriptions.
 239         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 240         * gdb/features/Makefile: Add rx.xml.
 241         * gdb/features/rx.xml: New.
 242         * gdb/features/rx.c: Generated.
 243         * gdb/NEWS: Mention target description support.
 244
 245 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 246
 247         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 248         *slot_ptr.
 249
 250 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 251
 252         * configure.ac: Don't check for 'dlfcn.h' (moved to
 253         gdbsupport/common.m4).
 254         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 255         'gdbsupport/'.
 256         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 257         * compile/compile-c-support.c: Include
 258         'gdbsupport/gdb-dlfcn.h'.
 259         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 260         * gdb-dlfcn.c: Move to...
 261         * gdbsupport/gdb-dlfcn.c: ... here.
 262         * gdb-dlfcn.h: Move to...
 263         * gdbsupport/gdb-dlfcn.h: ... here.
 264
 265 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 266
 267         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 268         the offset field signed.
 269
 270 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 271
 272         * python/lib/gdb/__init__.py (_execute_file): New function.
 273         * python/python.c (python_run_simple_file): Call gdb._execute_file
 274         on Windows.
 275
 276 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 279         all uses as this was never set to anything but a zero value.
 280
 281 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 282
 283         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 284
 285 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 286
 287         * tui/tui-data.h (tui_gen_win_info): Add an =default
 288         move constructor, required by some GCC versions.
 289
 290 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 291
 292         * go32-nat.c (go32_sysinfo): Add hygon_p.
 293
 294 2019-08-20  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 297         line_from_reg_element_no, first_reg_element_no_inline,
 298         display_all_data, delete_data_content_windows,
 299         erase_data_content>: Now private.
 300
 301 2019-08-20  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 304         (tui_unhighlight_win, tui_highlight_win)
 305         (tui_win_info::make_window): Update.
 306         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 307
 308 2019-08-20  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 311         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 312         (MAX_PID_WIDTH): Move to tui-stack.c.
 313         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 314         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 315         (MAX_PID_WIDTH): Move from tui-data.h.
 316
 317 2019-08-20  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 320         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 321         (box_win): Update.
 322         (tui_gen_win_info::make_window): Rename from tui_make_window.
 323         (tui_win_info::make_window): New method.
 324         (tui_gen_win_info::make_visible): Update.
 325         * tui/tui-source.c (tui_source_window::set_contents): Update.
 326         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 327         (tui_data_window::display_registers_from): Update.
 328         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 329         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 330         Declare.
 331         <can_box>: Remove.
 332         <title>: Remove.
 333         (struct tui_win_info) <make_window>: Declare.
 334         <can_box>: Now virtual.
 335         <title>: New member.
 336         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 337         * tui/tui-command.c (tui_cmd_window::resize): Update.
 338
 339 2019-08-20  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 342         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 343         (tui_data_window::check_register_values): Update.
 344
 345 2019-08-20  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-regs.h (struct tui_data_window): Use
 348         DISABLE_COPY_AND_ASSIGN.
 349         <regs_content>: Change type, removing unique_ptr.
 350         <tui_data_window>: Add move constructor.
 351         * tui/tui-regs.c (tui_data_window::show_registers)
 352         (tui_data_window::show_register_group)
 353         (tui_data_window::display_registers_from)
 354         (tui_data_window::display_registers_from)
 355         (tui_data_window::first_data_item_displayed)
 356         (tui_data_window::delete_data_content_windows)
 357         (tui_data_window::rerender, tui_data_window::refresh_window)
 358         (tui_data_window::check_register_values): Update.
 359
 360 2019-08-20  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 363         show_register_group>: Declare.
 364         (tui_show_register_group): Don't declare.
 365         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 366         tui_show_registers.
 367         (tui_data_window::show_register_group): Rename from
 368         tui_show_register_group.
 369         (tui_data_window::check_register_values, tui_reg_command):
 370         Update.
 371         * tui/tui-layout.c (tui_set_layout): Update.
 372
 373 2019-08-20  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 376         Declare.
 377         (tui_check_register_values): Don't declare.
 378         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 379         from tui_check_register_values.
 380         * tui/tui-hooks.c (tui_register_changed): Update.
 381
 382 2019-08-20  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-regs.c (tui_reg_layout): Move later.
 385         (tui_show_registers): Don't enable TUI mode or change layout.
 386
 387 2019-08-20  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-regs.h (struct tui_data_item_window)
 390         <~tui_data_item_window>: Remove.
 391         <content>: Now a unique_xmalloc_ptr.
 392         * tui/tui-regs.c (tui_register_format): Return a
 393         unique_xmalloc_ptr.
 394         (tui_get_register): Update.
 395         (~tui_data_item_window): Remove.
 396         (tui_data_window::display_registers_from, tui_display_register):
 397         Update.
 398         * tui/tui-io.h (tui_expand_tabs): Update.
 399         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 400         Remove "col" parameter.
 401
 402 2019-08-20  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 405         field.
 406         * tui/tui-regs.c (~tui_data_item_window): Update.
 407
 408 2019-08-20  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 411         earlier.
 412
 413 2019-08-20  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 416
 417 2019-08-20  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-source.h (struct tui_source_window): Update.
 420         * tui/tui-regs.c (tui_show_registers): Update.
 421         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 422         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 423         (NO_REGS_STRING): Remove defines.
 424
 425 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 426
 427         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 428         unnecessary thread walk if remote doesn't support the packet.
 429
 430 2019-08-19  Tom Tromey  <tromey@adacore.com>
 431
 432         * python/py-value.c (value_has_field): Fix indentation.
 433
 434 2019-08-19  Tom Tromey  <tromey@adacore.com>
 435
 436         * printcmd.c (do_one_display, info_display_command): Update.
 437         * block.h (contained_in): Return bool.  Add allow_nested
 438         parameter.
 439         * block.c (contained_in): Return bool.  Add allow_nested
 440         parameter.
 441
 442 2019-08-19  Tom Tromey  <tom@tromey.com>
 443
 444         * configure: Rebuild.
 445         * configure.ac: Disallow the combination of -static-libstdc++ and
 446         source highlight.
 447         * source-cache.c (get_language_name): Handle rust.
 448         (source_cache::get_source_lines): Ignore highlighting exceptions.
 449
 450 2019-08-16  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 453         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 454         (struct tui_source_window_base) <make_visible, refresh_window,
 455         resize>: Remove methods.
 456         <execution_info>: Remove field.
 457         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 458         (tui_show_source_line, tui_source_window_base)
 459         (~tui_source_window_base): Update.
 460         (tui_source_window_base::resize)
 461         (tui_source_window_base::make_visible)
 462         (tui_source_window_base::refresh_window): Remove.
 463         (tui_source_window_base::update_exec_info): Update.
 464         * tui/tui-source.c (tui_source_window::set_contents): Update.
 465         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 466
 467 2019-08-16  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 470         deprecated_query_hook.
 471
 472 2019-08-16  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 475         (tui_update_source_windows_with_line): Update.
 476         * tui/tui-source.h (struct tui_source_window)
 477         <show_symtab_source>: Declare.
 478         (tui_show_symtab_source): Don't declare.
 479         * tui/tui-source.c (tui_show_symtab_source): Rename from
 480         tui_show_symtab_source.
 481
 482 2019-08-16  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-winsource.h (struct tui_source_window_base)
 485         <set_contents>: Declare.
 486         * tui/tui-winsource.c
 487         (tui_source_window_base::update_source_window_as_is): Update.
 488         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 489         Declare.
 490         (tui_set_source_content): Don't declare.
 491         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 492         tui_set_source_content.
 493         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 494         Declare.
 495         (tui_set_disassem_content): Don't declare.
 496         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 497         tui_set_disassem_content.
 498
 499 2019-08-16  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-winsource.h (struct tui_source_window_base)
 502         <update_breakpoint_info>: Declare.
 503         (tui_update_breakpoint_info): Don't declare.
 504         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 505         (tui_update_all_breakpoint_info): Update.
 506         (tui_source_window_base::update_breakpoint_info): Rename from
 507         tui_update_breakpoint_info.
 508         (tui_source_window_base::update_exec_info): Update.
 509
 510 2019-08-16  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-winsource.h (struct tui_source_window_base)
 513         <update_source_window>: Declare.
 514         (tui_update_source_window): Don't declare.
 515         * tui/tui-winsource.c
 516         (tui_source_window_base::update_source_window): Rename from
 517         tui_update_source_window.
 518         (tui_source_window_base::rerender): Update.
 519         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 520         * tui/tui-disasm.c (tui_show_disassem)
 521         (tui_show_disassem_and_update_source)
 522         (tui_disasm_window::maybe_update): Update.
 523
 524 2019-08-16  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-winsource.h (struct tui_source_window_base)
 527         <update_source_window_as_is>: Declare.
 528         (tui_update_source_window_as_is): Don't declare.
 529         * tui/tui-winsource.c (tui_update_source_window): Update
 530         (tui_source_window_base::update_source_window_as_is): Rename from
 531         tui_update_source_window_as_is.
 532         (tui_source_window_base::refill): Update.
 533         * tui/tui-source.c (tui_show_symtab_source): Update.
 534         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 535         Update.
 536
 537 2019-08-16  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-winsource.h (tui_update_source_window)
 540         (tui_update_source_window_as_is): Remove "noerror" parameter.
 541         * tui/tui-winsource.c (tui_update_source_window)
 542         (tui_update_source_window_as_is): Remove "noerror" parameter.
 543         (tui_update_source_windows_with_addr)
 544         (tui_update_source_windows_with_line)
 545         (tui_source_window_base::rerender)
 546         (tui_source_window_base::refill): Update.
 547         * tui/tui-source.h (tui_set_source_content)
 548         (tui_show_symtab_source): Remove "noerror" parameter.
 549         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 550         parameter.
 551         (tui_show_symtab_source): Likewise.
 552         (tui_source_window::maybe_update): Update.
 553         * tui/tui-disasm.c (tui_show_disassem)
 554         (tui_show_disassem_and_update_source)
 555         (tui_disasm_window::do_scroll_vertical)
 556         (tui_disasm_window::maybe_update): Update.
 557
 558 2019-08-16  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui.c (tui_is_window_visible): Update.
 561         * tui/tui-wingeneral.c (tui_make_window)
 562         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 563         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 564         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 565         (tui_set_win_height_command, parse_scrolling_args): Update.
 566         * tui/tui-source.c (tui_source_window::style_changed): Update.
 567         * tui/tui-regs.c (tui_show_registers)
 568         (tui_data_window::first_data_item_displayed)
 569         (tui_data_window::delete_data_content_windows)
 570         (tui_check_register_values, tui_reg_command): Update.
 571         * tui/tui-disasm.c (tui_show_disassem): Update.
 572         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 573         method.
 574         <is_visible>: Remove field.
 575         * tui/tui-data.c (tui_next_win, tui_prev_win)
 576         (tui_delete_invisible_windows): Update.
 577
 578 2019-08-16  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-winsource.h (struct tui_source_window_base)
 581         <m_has_locator>: Remove.
 582         * tui/tui-layout.c (show_source_disasm_command, show_data)
 583         (show_source_or_disasm_and_command): Update.
 584
 585 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 586
 587         * NEWS (Other MI changes): New subsection.
 588         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 589         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 590         * arch-utils.c (default_get_pc_address_flags): New function.
 591         * arch-utils.h (default_get_pc_address_flags): New declaration.
 592         * gdbarch.sh: Add get_pc_address_flags.
 593         * gdbarch.c: Regenerate.
 594         * gdbarch.h: Likewise.
 595         * stack.c (print_pc): New function.
 596         (print_frame_info) (print_frame): Call print_pc.
 597
 598 2019-08-16  Tom de Vries  <tdevries@suse.de>
 599
 600         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 601         print_objfile_section_info.
 602
 603 2019-08-15  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 606         calling update_cmdwin_start_line.
 607         * tui/tui-winsource.h (struct tui_source_window_base)
 608         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 609         <rerender>: Declare.
 610         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 611         Call rerender.
 612         (tui_source_window_base::set_new_height): Remove.
 613         (tui_source_window_base::rerender): Rename from
 614         do_make_visible_with_new_height.
 615         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 616         resize method.
 617         (tui_win_info::make_invisible_and_set_new_height)
 618         (tui_win_info::make_visible_with_new_height): Remove.
 619         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 620         Declare.
 621         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 622         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 623         do_make_visible_with_new_height>: Don't declare.
 624         <rerender>: Declare.
 625         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 626         set_new_height.
 627         (tui_data_window::do_make_visible_with_new_height): Remove.
 628         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 629         call tui_show_locator_content.
 630         (tui_gen_win_info::resize): Call rerender.
 631         (show_source_or_disasm_and_command): Don't call
 632         tui_show_locator_content.
 633         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 634         method.
 635         (struct tui_win_info) <rerender>: Declare.
 636         <set_new_height, make_invisible_and_set_new_height,
 637         make_visible_with_new_height>: Don't declare.
 638         * tui/tui-data.c (tui_win_list::rerender): New method.
 639         * tui/tui-command.h (struct tui_cmd_window)
 640         <do_make_visible_with_new_height>: Don't declare.
 641         * tui/tui-command.c
 642         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 643
 644 2019-08-15  Tom Tromey  <tromey@adacore.com>
 645
 646         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 647         * ada-lang.c (ada_enum_name): Likewise.
 648
 649 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 650
 651         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 652         leading underscore.
 653         (GdbOutputErrorFile): Likewise.
 654         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 655         accordingly.
 656         (execute_unwinders): Rename to have a leading underscore.
 657         (auto_load_packages): Likewise.
 658         (global scope): Adjust call to auto_load_packages accordingly.
 659         (GdbSetPythonDirectory): Likewise.
 660         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 661         instead of execute_unwinders.
 662
 663 2019-08-15  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 666         (show_data): Don't change window visibility.
 667         (tui_gen_win_info::resize): Remove special case for command
 668         window.  Use wresize, when available.
 669         (show_source_or_disasm_and_command): Don't change window
 670         visibility.
 671         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 672         <make_visible>: New method.
 673         * tui/tui-command.c (tui_cmd_window::resize): New method.
 674
 675 2019-08-15  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 678         (struct tui_source_windows): New.
 679         * tui/tui-winsource.c (tui_display_main): Update.
 680         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 681         (new_height_ok, parse_scrolling_args): Update.
 682         * tui/tui-layout.c (show_layout, show_data): Update.
 683         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 684         (tui_add_to_source_windows): Don't declare.
 685         * tui/tui-data.c (source_windows, tui_source_windows)
 686         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 687
 688 2019-08-15  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 691         Rename from reset.
 692         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 693         * tui/tui-layout.c (show_source_disasm_command, show_data):
 694         Update.
 695         (tui_gen_win_info::resize): Rename.
 696         (show_source_or_disasm_and_command): Update.
 697         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 698         reset.
 699
 700 2019-08-15  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 703         * tui/tui-interp.c (tui_interp::init): Don't call
 704         tui_initialize_static_data.
 705         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 706
 707 2019-08-15  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 710         examine tui_win_list.
 711
 712 2019-08-15  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 715         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 716         tui_clear_source_content.
 717         (tui_clear_source_content): Remove.
 718         (tui_source_window_base::do_erase_source_content): Hoist call to
 719         content.clear().
 720         * tui/tui-stack.c (tui_show_frame_info): Don't call
 721         tui_clear_source_content.
 722
 723 2019-08-15  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-winsource.h (struct tui_source_window_base)
 726         <do_erase_source_content>: New method.
 727         <erase_source_content>: New method.
 728         (tui_erase_source_content): Don't declare.
 729         * tui/tui-winsource.c (tui_clear_source_content): Update.
 730         (tui_source_window_base::do_erase_source_content): Rename from
 731         tui_erase_source_content.
 732         (tui_source_window_base::show_source_content): Update.
 733         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 734         * tui/tui-source.h (struct tui_source_window)
 735         <erase_source_content>: New method.
 736         * tui/tui-disasm.h (struct tui_disasm_window)
 737         <erase_source_content>: New method.
 738
 739 2019-08-15  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 742         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 743         constructor.
 744         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 745         * tui/tui-source.c (tui_set_source_content): Update.
 746         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 747
 748 2019-08-15  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 751         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 752         tui-source.c.
 753         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 754         Declare.
 755         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 756         method.
 757         (tui_source_window::maybe_update): Update.
 758
 759 2019-08-15  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 762         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 763         tui-disasm.c.
 764         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 765         Declare.
 766         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 767         method.
 768         (tui_disasm_window::maybe_update): Update.
 769
 770 2019-08-15  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-winsource.h (struct tui_source_window_base)
 773         <maybe_update>: Declare.
 774         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 775         method.
 776         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 777         Declare.
 778         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 779         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 780         Declare.
 781         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 782
 783 2019-08-15  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 786
 787 2019-08-15  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-wingeneral.c: Include tui-stack.h.
 790         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 791         (struct tui_locator_window): Move from tui-data.h.
 792         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 793         (tui_initialize_static_data): Move from tui-data.c.
 794         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 795         (struct tui_locator_window): Move to tui-stack.c.
 796         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 797         (tui_initialize_static_data): Move to tui-stack.c.
 798
 799 2019-08-15  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-layout.c (show_source_disasm_command)
 802         (show_source_or_disasm_and_command): Use make_visible method, not
 803         tui_make_window.
 804         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 805         Remove.
 806
 807 2019-08-15  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-wingeneral.h (tui_make_window): Update.
 810         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 811         parameter.
 812         (tui_gen_win_info::make_visible): Update.
 813         * tui/tui-regs.c (tui_data_window::display_registers_from):
 814         Update.
 815         * tui/tui-layout.c (show_source_disasm_command)
 816         (show_source_or_disasm_and_command): Update.
 817         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 818         (enum tui_box): Remove.
 819         (struct tui_win_info) <can_box>: New method.
 820         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 821         method.
 822
 823 2019-08-15  Tom de Vries  <tdevries@suse.de>
 824
 825         * linux-nat-trad.c: Include gdbarch.h.
 826
 827 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 828
 829         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 830         register sizes.
 831
 832 2019-08-14  Tom Tromey  <tromey@adacore.com>
 833
 834         * darwin-nat.c: Include gdbarch.h.
 835         * darwin-nat-info.c: Include gdbarch.h.
 836
 837 2019-08-13  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 840         Remove.
 841         * tui/tui-data.c (tui_initialize_static_data): Update.
 842
 843 2019-08-13  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-winsource.h (struct tui_exec_info_window)
 846         <~tui_exec_info_window, maybe_allocate_content, get_content,
 847         m_content>: Remove.
 848         (struct tui_source_window_base) <set_exec_info_content,
 849         show_exec_info_content>: Don't declare.
 850         * tui/tui-winsource.c
 851         (tui_exec_info_window::maybe_allocate_content): Remove.
 852         (tui_source_window_base::update_exec_info): Rename from
 853         set_exec_info_content.
 854         (tui_source_window_base::show_exec_info_content)
 855         (tui_source_window_base::update_exec_info): Remove.
 856
 857 2019-08-13  Tom Tromey  <tom@tromey.com>
 858
 859         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 860         declare.
 861         * tui/tui-winsource.c (tui_update_source_window_as_is)
 862         (tui_update_source_windows_with_addr, tui_erase_source_content):
 863         Update.
 864         (tui_clear_exec_info_content): Remove.
 865
 866 2019-08-13  Tom Tromey  <tom@tromey.com>
 867
 868         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 869         declare.
 870         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 871         call tui_erase_exec_info_content.
 872         (tui_clear_exec_info_content): Rename from
 873         tui_erase_exec_info_content.
 874         (tui_clear_exec_info_content): Delete.
 875
 876 2019-08-13  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-winsource.h (struct tui_source_window_base)
 879         <show_exec_info_content>: Declare.
 880         (tui_show_exec_info_content): Don't declare.
 881         * tui/tui-winsource.c
 882         (tui_source_window_base::show_exec_info_content): Rename from
 883         tui_show_exec_info_content.
 884         (tui_source_window_base::update_exec_info): Update.
 885
 886 2019-08-13  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 889         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 890         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 891         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 892         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 893         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 894         ... here.
 895
 896 2019-08-13  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-winsource.h (struct tui_source_window_base)
 899         <update_exec_info>: Declare.
 900         (tui_update_exec_info): Don't declare.
 901         * tui/tui-winsource.c (tui_update_source_window_as_is)
 902         (tui_source_window_base::refresh_all)
 903         (tui_update_all_breakpoint_info): Update.
 904         (tui_source_window_base::update_exec_info): Rename from
 905         tui_update_exec_info.
 906         * tui/tui-stack.c (tui_show_frame_info): Update.
 907
 908 2019-08-13  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-winsource.h (struct tui_source_window_base)
 911         <set_exec_info_content>: Declare.
 912         (tui_set_exec_info_content): Don't declare.
 913         * tui/tui-winsource.c
 914         (tui_source_window_base::set_exec_info_content): Rename from
 915         tui_set_exec_info_content.
 916         (tui_update_exec_info): Update.
 917
 918 2019-08-13  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-winsource.h (struct tui_source_window_base)
 921         <show_source_content>: Declare.
 922         (tui_show_source_content): Don't declare.
 923         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 924         (tui_source_window_base::show_source_content): Rename from
 925         tui_show_source_content.
 926         (tui_source_window_base::refresh_all): Update.
 927         * tui/tui-layout.c (show_source_disasm_command)
 928         (show_source_or_disasm_and_command): Update.
 929
 930 2019-08-13  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-winsource.c (tui_erase_source_content)
 933         (tui_show_source_content, tui_source_window_base::refresh_all):
 934         Update.
 935         * tui/tui-wingeneral.h
 936         (tui_check_and_display_highlight_if_needed): Don't declare.
 937         * tui/tui-wingeneral.c
 938         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 939         check_and_display_highlight_if_needed.
 940         * tui/tui-win.c (tui_rehighlight_all)
 941         (tui_win_info::make_visible_with_new_height): Update.
 942         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 943         (tui_data_window::erase_data_content)
 944         (tui_data_window::display_all_data): Update.
 945         * tui/tui-data.h (struct tui_win_info)
 946         <check_and_display_highlight_if_needed>: Declare.
 947
 948 2019-08-13  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-win.c (tui_resize_all): Call
 951         tui_delete_invisible_windows.
 952         * tui/tui-layout.c (show_layout): Call
 953         tui_delete_invisible_windows.
 954         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 955         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 956
 957 2019-08-13  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 960         tui_add_win_to_layout.
 961
 962 2019-08-13  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 965         * tui/tui-layout.c (tui_default_win_height): Now static.
 966
 967 2019-08-13  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 970         single switch.
 971         (show_source_disasm_command, show_source_or_disasm_and_command):
 972         Don't check current layout.
 973
 974 2019-08-13  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-wingeneral.c (make_all_visible): Remove.
 977         (tui_make_all_invisible): Simplify.
 978         * tui/tui-layout.c (tui_make_all_invisible): Move from
 979         tui-wingeneral.c; simplify.
 980         (show_layout): Hoist call to tui_make_all_invisible.
 981         (show_data): Don't call tui_make_all_invisible.
 982
 983 2019-08-13  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 986         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 987
 988 2019-08-13  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 991         tui-data.c.
 992         (show_source_disasm_command, show_data)
 993         (show_source_or_disasm_and_command): Don't use
 994         tui_set_current_layout_to.
 995         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 996         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 997         tui-layout.c.
 998         (tui_set_current_layout_to): Remove.
 999
1000 2019-08-13  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-layout.c (tui_set_layout): Update.
1003         * tui/tui-data.h (struct tui_layout_def): Remove.
1004         (tui_layout_def): Don't declare.
1005         * tui/tui-data.c (layout_def): Remove.
1006         (tui_layout_def): Remove.
1007
1008 2019-08-13  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-winsource.h (struct tui_source_window_base)
1011         <clear_detail>: No longer "override".
1012         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1013         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1014         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1015         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1016         Remove.
1017         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1018
1019 2019-08-13  Tom Tromey  <tromey@adacore.com>
1020
1021         * tracepoint.c: Don't include readline.h or history.h.
1022
1023 2019-08-12  Tom Tromey  <tom@tromey.com>
1024
1025         * configure: Rebuild.
1026         * configure.ac: Check for readline 7.
1027         * NEWS: Mention readline 7 requirement.
1028         * README: Update.
1029
1030 2019-08-12  Tom Tromey  <tom@tromey.com>
1031
1032         * mingw-hdep.c (gdb_select): Remove readline hack.
1033
1034 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1035
1036         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1037         when the function fails.
1038
1039 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1040
1041         * s390-tdep.c (s390_type_align): New function.
1042         (s390_gdbarch_init): Set it as type_align gdbarch method.
1043
1044 2019-08-09  Tom de Vries  <tdevries@suse.de>
1045
1046         PR gdb/24591
1047         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1048         pc_low with relocation offset.
1049
1050 2019-08-07  Tom Tromey  <tromey@adacore.com>
1051
1052         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1053         (print_frame_args): Update.
1054         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1055         Update.
1056         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1057         * frame.h (struct frame_arg): Add initializers.
1058         <error>: Now a unique_xmalloc_ptr.
1059
1060 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1061
1062         * NEWS: Expand the Pointer Authentication entry.
1063         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1064         (aarch64_frame_unmask_lr): ... to this.
1065         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1066         Call aarch64_frame_unmask_lr.
1067         * frame.c (struct frame_info): Add "masked" variable.
1068         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1069         (fprint_frame): Check for masked pc.
1070         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1071         declarations.
1072         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1073         * stack.c (print_frame): Check for masked pc.
1074
1075 2019-08-06  Tom Tromey  <tom@tromey.com>
1076
1077         * stabsread.c (patch_block_stabs, read_one_struct_field)
1078         (read_enum_type): Use obstack_strndup.
1079         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1080         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1081         * dwarf2read.c (guess_full_die_structure_name)
1082         (anonymous_struct_prefix): Use obstack_strndup.
1083         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1084         * c-exp.y (yylex): Use obstack_strndup.
1085         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1086         (write_var_or_type): Use obstack_strndup.
1087
1088 2019-08-06  Tom Tromey  <tom@tromey.com>
1089
1090         * symfile.c (reread_symbols): Use obstack_strdup.
1091         * stabsread.c (read_type): Use obstack_strdup.
1092         * gdb_obstack.h (obstack_strdup): New overload.
1093         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1094         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1095         (dwarf2_canonicalize_name): Use obstack_strdup.
1096         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1097         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1098         Use obstack_strdup.
1099
1100 2019-08-06  Tom Tromey  <tom@tromey.com>
1101
1102         * gdb_obstack.h (obstack_strdup): Define.
1103         * gdb_obstack.c (obstack_strdup): Don't define.
1104
1105 2019-08-06  Tom Tromey  <tom@tromey.com>
1106
1107         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1108         obstack_strdup.
1109         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1110         obstack_strdup.
1111         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1112         * stabsread.c (common_block_start): Use obstack_strdup.
1113         * objfiles.c (set_objfile_main_name, objfile): Use
1114         obstack_strdup.
1115         * namespace.c (add_using_directive): Use obstack_strdup.
1116         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1117         * jit.c (finalize_symtab): Use obstack_strdup.
1118         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1119         (guess_partial_die_structure_name, partial_die_info::fixup)
1120         (dwarf2_name): Use obstack_strdup.
1121         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1122         obstack_strdup.
1123         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1124         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1125         obstack_strdup.
1126         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1127
1128 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1129
1130         * unittests/help-doc-selftests.c: New file.
1131         * Makefile.in: Add the new file.
1132
1133 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1134
1135         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1136         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1137         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1138         the trailing '.' is not output, and the first character is uppercased.
1139         (print_help_for_command): Update call to print_doc_line.
1140         (print_doc_of_command): Likewise.
1141         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1142         * cli/cli-option.c (append_indented_doc): Do not append newline.
1143         (build_help_option): Append newline after first appended_indented_doc
1144         only if a second call is done.
1145         (build_help): Append 2 new lines before each option, except the first
1146         one.
1147         * compile/compile.c (_initialize_compile): Add new lines after
1148         %OPTIONS%, when not at the end of the help.
1149         Change help doc or code
1150         producing the help doc to respect the invariants.
1151         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1152         Also removed the new line after 'Options:', as all other commands
1153         do not put an empty line between 'Options:' and the first option.
1154         * printcmd.c (_initialize_printcmd): Likewise.
1155         * stack.c (_initialize_stack): Likewise.
1156         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1157         incorrectly telling COMMAND is optional.
1158         * ada-lang.c (_initialize_ada_language): Change help doc or code
1159         producing the help doc to respect the invariants.
1160         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1161         * breakpoint.c (_initialize_breakpoint): Likewise.
1162         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1163         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1164         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1165         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1166         _initialize_cli_style): Likewise.
1167         * corelow.c (core_target_info): Likewise.
1168         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1169         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1170         * filesystem.c (_initialize_filesystem): Likewise.
1171         * frame.c (_initialize_frame): Likewise.
1172         * gnu-nat.c (add_task_commands): Likewise.
1173         * infcall.c (_initialize_infcall): Likewise.
1174         * infcmd.c (_initialize_infcmd): Likewise.
1175         * interps.c (_initialize_interpreter): Likewise.
1176         * language.c (_initialize_language): Likewise.
1177         * linux-fork.c (_initialize_linux_fork): Likewise.
1178         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1179         * maint.c (_initialize_maint_cmds): Likewise.
1180         * memattr.c (_initialize_mem): Likewise.
1181         * printcmd.c (_initialize_printcmd): Likewise.
1182         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1183         _RegEx): Likewise.
1184         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1185         * record-btrace.c (_initialize_record_btrace): Likewise.
1186         * record-full.c (_initialize_record_full): Likewise.
1187         * record.c (_initialize_record): Likewise.
1188         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1189         * regcache.c (_initialize_regcache): Likewise.
1190         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1191         _initialize_remote): Likewise.
1192         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1193         * serial.c (_initialize_serial): Likewise.
1194         * skip.c (_initialize_step_skip): Likewise.
1195         * source.c (_initialize_source): Likewise.
1196         * stack.c (_initialize_stack): Likewise.
1197         * symfile.c (_initialize_symfile): Likewise.
1198         * symtab.c (_initialize_symtab): Likewise.
1199         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1200         * top.c (init_main): Likewise.
1201         * tracefile-tfile.c (tfile_target_info): Likewise.
1202         * tracepoint.c (_initialize_tracepoint): Likewise.
1203         * tui/tui-win.c (_initialize_tui_win): Likewise.
1204         * utils.c (add_internal_problem_command): Likewise.
1205         * valprint.c (value_print_option_defs): Likewise.
1206
1207 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1208
1209         PR build/24886
1210         * configure.ac: Drop enable-libmcheck support.
1211         * configure, config.in: Rebuild.
1212         * libmcheck.m4: Remove.
1213         * acinclude.m4: Don't include it.
1214         * Makefile.in: Don't distribute it.
1215         * top.c (print_gdb_configuration): Don't mention it.
1216
1217 2019-08-06  Tom Tromey  <tom@tromey.com>
1218
1219         * utils.c (set_output_style): Sometimes pass stream to
1220         emit_style_escape.
1221         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1222         * record-btrace.c (btrace_insn_history): Update.
1223         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1224         method.
1225         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1226         Update initializers.
1227         <m_uiout>: New field.
1228         <m_di>: Move lower.
1229         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1230         Remove "uiout" parameter.
1231         (dump_insns): Update.
1232         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1233         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1234
1235 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1236
1237         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1238         (error_in_psymtab_expansion): Likewise.
1239         (lookup_symbol_via_quick_fns): Likewise.
1240         (basic_lookup_transparent_type_quick): Likewise.
1241         (basic_lookup_transparent_type_1): Likewise.
1242
1243 2019-08-06  Tom Tromey  <tromey@adacore.com>
1244
1245         * source.c (last_source_error): Now bool.
1246         (print_source_lines_base): Make "noprint" bool.  Only open
1247         source file when last_source_visited changes.
1248
1249 2019-08-06  Tom Tromey  <tromey@adacore.com>
1250
1251         * annotate.c (annotate_source_line): Use g_source_cache.
1252         * source-cache.c (source_cache::get_plain_source_lines): Change
1253         parameters.  Populate m_offset_cache.
1254         (source_cache::ensure): New method.
1255         (source_cache::get_line_charpos): New method.
1256         (extract_lines): Move lower.  Change parameters.
1257         (source_cache::get_source_lines): Move lower.
1258         * source-cache.h (class source_cache): Update comment.
1259         <get_line_charpos>: New method.
1260         <get_source_lines>: Update comment.
1261         <clear>: Clear m_offset_cache.
1262         <get_plain_source_lines>: Change parameters.
1263         <ensure>: New method
1264         <m_offset_cache>: New member.
1265         * source.c (forget_cached_source_info_for_objfile): Update.
1266         (info_source_command): Use g_source_cache.
1267         (find_source_lines, open_source_file_with_line_charpos): Remove.
1268         (print_source_lines_base, search_command_helper): Use g_source_cache.
1269         * source.h (open_source_file_with_line_charpos): Don't declare.
1270         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1271         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1272         Use g_source_cache.
1273
1274 2019-08-06  Tom Tromey  <tromey@adacore.com>
1275
1276         * source-cache.c (source_cache::get_plain_source_lines):
1277         Remove "first_line" and "last_line" parameters.
1278         (source_cache::get_source_lines): Cache plain text.
1279         * source-cache.h (class source_cache)
1280         <get_plain_source_lines>: Update.
1281
1282 2019-08-06  Tom Tromey  <tromey@adacore.com>
1283
1284         * source-cache.c (extract_lines): No longer a method.
1285         Changed type of parameter.  Include final newline.
1286         (selftests::extract_lines_test): New function.
1287         (_initialize_source_cache): Likewise.
1288         * source-cache.h (class source_cache)
1289         <extract_lines>: Don't declare.
1290
1291 2019-08-06  Tom Tromey  <tromey@adacore.com>
1292
1293         * breakpoint.c (init_breakpoint_sal): Update.
1294         (breakpoint): Update.
1295         * breakpoint.h (struct breakpoint) <filter>: Now a
1296         unique_xmalloc_ptr.
1297
1298 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1299
1300         * NEWS: Mention dictionary access on blocks.
1301         * python/py-block.c (blpy_getitem): New function.
1302         (block_object_as_mapping): New struct.
1303         (block_object_type): Use new struct for tp_as_mapping field.
1304
1305 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1306
1307         * objfiles.h (objfile): Add a comment describing partial symbols.
1308
1309 2019-08-05  Tom Tromey  <tromey@adacore.com>
1310
1311         * compile/compile.c (_initialize_compile): Use _(), not N_().
1312         * thread.c (_initialize_thread): Use _(), not N_().
1313         * stack.c (_initialize_stack): Use _(), not N_().
1314         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1315
1316 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1317
1318         * dwarf2read.c (struct dw2_symtab_iterator):
1319         <want_specific_block>: Remove.
1320         <block_index>: Change type to gdb::optional.
1321         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1322         change type of BLOCK_INDEX parameter to gdb::optional.
1323         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1324         (dw2_lookup_symbol): Don't pass argument for
1325         WANT_SPECIFIC_BLOCK.
1326         (dw2_expand_symtabs_for_function): Don't pass argument for
1327         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1328         (class dw2_debug_names_iterator)
1329         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1330         parameter, change BLOCK_INDEX type to gdb::optional.
1331         <m_want_specific_block>: Remove.
1332         <m_block_index>: Change type to gdb::optional.
1333         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1334         gdb::optional.  Re-write in function of gdb::optional.
1335         (dw2_debug_names_lookup_symbol): Don't pass argument for
1336         WANT_SPECIFIC_BLOCK.
1337         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1338         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1339         BLOCK_INDEX.
1340
1341 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1342
1343         * NEWS: Mention changes to "info sources" command.
1344
1345 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1346
1347         * symtab.c (filename_partial_match_opts): New struct type.
1348         (struct output_source_filename_data): New members
1349         regexp, c_regexp, partial_match.
1350         (output_source_filename): Use new members to decide to print file.
1351         (info_sources_option_defs): New variable.
1352         (make_info_sources_options_def_group, print_info_sources_header,
1353         info_sources_command_completer):
1354         New functions.
1355         (info_sources_command): Read new optional arguments.
1356         (_initialize_symtab): Update info sources help.
1357
1358 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1359
1360         * ada-lang.c (exception_support_info_v0): Renamed from...
1361         (default_exception_support_info): ... this.  Create new
1362         definition for v1.
1363         (ada_has_this_exception_support): Look up catch_handlers_sym.
1364         (ada_exception_support_info_sniffer): Try v0 after default.
1365
1366 2019-08-01  Tom Tromey  <tromey@adacore.com>
1367
1368         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1369         gdbarch.h.
1370
1371 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1372
1373         * s12z-tdep.c: Fix include path for s12z-opc.h.
1374
1375 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1376
1377         * NEWS: Require GNU make 3.82.
1378
1379 2019-07-16  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1382         declare.
1383
1384 2019-07-30  Tom Tromey  <tromey@adacore.com>
1385
1386         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1387
1388 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1389
1390         * printcmd.c (print_address_symbolic): Print negative offsets.
1391         (build_address_symbolic): Force signed arithmetic when computing
1392         offset.
1393
1394 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1395
1396         PR/24474: Add a function to lookup static variables.
1397         * NEWS: Mention this new function.
1398         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1399         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1400         * python/python.c (python_GdbMethods): Add new function.
1401
1402 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1403
1404         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1405         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1406         (objfpy_lookup_static_symbol): New function.
1407         (objfile_object_methods): Add new functions.
1408
1409 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1410
1411         * NEWS: Mention 'set|show print frame-info'.  Mention new
1412         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1413         backtrace argument.  Mention that python frame filtering code
1414         is now consistent with what 'backtrace' command prints.
1415
1416 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1417
1418         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1419         comments.
1420         (print_frame_info_auto, print_frame_info_source_line,
1421         print_frame_info_location, print_frame_info_source_and_location,
1422         print_frame_info_location_and_address, print_frame_info_short_location):
1423         New declarations.
1424         (struct frame_print_options): New member print_frame_info.
1425         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1426         * stack.h (get_user_print_what_frame_info): New declaration.
1427         (frame_show_address): New declaration.
1428         * stack.c (print_frame_arguments_choices): New value 'presence'.
1429         (print_frame_info_auto, print_frame_info_source_line,
1430         print_frame_info_location, print_frame_info_source_and_location,
1431         print_frame_info_location_and_address, print_frame_info_short_location,
1432         print_frame_info_choices, print_frame_info_print_what): New definitions.
1433         (print_frame_args): Only print dots for args if print frame-arguments
1434         is 'presence'.
1435         (frame_print_option_defs): New element for "frame-info".
1436         (get_user_print_what_frame_info): New function.
1437         (frame_show_address): Make non static.  Move comment to stack.h.
1438         (print_frame_info_to_print_what): New function.
1439         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1440         to decide what to print.
1441         (backtrace_command_1): Handle the new print_frame_arguments_presence
1442         value.
1443         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1444         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1445         (py_print_frame): In non-mi mode, use LOCATION as default for
1446         print_what, similarly to frame information printed directly by
1447         backtrace command. Handle frame-info user option in non MI mode.
1448
1449 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1450
1451         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1452         Add case for debugging 32-bit target on 64-bit host.  Revise
1453         comment.
1454
1455 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1456
1457         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1458         instead of find_function_entry_range_from_pc.
1459
1460 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1461
1462         * stack.c (find_frame_funname): Remove code which preferred
1463         minsym over symtab sym in "certain pathological cases".
1464
1465         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1466         parameter.  Change type of "do_demangle" to bool.
1467         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1468         Pass suitable "prefer_sym_over_minsym" flag to
1469         build_address_symbolic().  Don't output "+" for negative offsets.
1470         * printcmd.c (print_address_symbolic): Update invocation of
1471         build_address_symbolic to include a "prefer_sym_over_minsym"
1472         flag.
1473         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1474         Restrict cases in which use of minimal symbol is preferred to that
1475         of a found symbol.  Update comments.
1476
1477         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1478         for entry pc when entry pc is out of range for that FDE.
1479
1480 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1481
1482         PR gdb/24839:
1483         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1484         type.
1485
1486 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1487
1488         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1489         this function's Python signature.
1490
1491
1492 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1493
1494         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1495         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1496         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1497         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1498         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1499
1500
1501 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1502
1503         * h8300-tdep.c (h8300_register_name_common): New.
1504         h8300_register_name): Use h8300_register_name_common.
1505         (h8300s_register_name): Likewise.
1506         (h8300sx_register_name): Likewise.
1507         (h8300h_register_nam): New.
1508         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1509
1510
1511 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1512
1513         * arm-tdep.c (arm_skip_cmse_entry): New function.
1514         (arm_is_sgstubs_section): New function.
1515         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1516
1517 2019-07-22  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1520         Don't self-assign.
1521
1522 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1525         type_print.
1526
1527 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1530         so that GDB doesn't match any msymbols when searching in the
1531         TYPES_DOMAIN.
1532         (print_symbol_info): Print using typedef_print or type_print based
1533         on the type of the symbol.  Add updated FIXME comment moved from...
1534         (_initialize_symtab): ... move and update FIXME comment to above.
1535
1536 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * NEWS: Mention adding -q option to "info types".
1539         * symtab.c (struct info_types_options): New struct.
1540         (info_types_options_defs): New variable.
1541         (make_info_types_options_def_group): New function.
1542         (info_types_command): Use gdb::option framework to parse options.
1543         (info_types_command_completer): New function.
1544         (_initialize_symtab): Extend the help text on "info types" and
1545         register command completer.
1546
1547 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1548
1549         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1550         (lookup_symbol_in_objfile): Change int to block_enum and add a
1551         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1552
1553 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1554
1555         * MAINTAINERS (Write After Approval): Add self.
1556
1557 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1560         instruction to the dummy code region.
1561
1562 2019-07-19  Tom Tromey  <tromey@adacore.com>
1563
1564         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1565         (ARGSUSED, PARAMS, __func__): Remove rules.
1566
1567 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1568
1569         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1570         * features/arm/arm-with-iwmmxt.c: Remove.
1571         * features/arm/arm-with-iwmmxt.xml: Remove.
1572         * features/arm/arm-with-m-fpa-layout.c: Remove.
1573         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1574         * features/arm/arm-with-m-vfp-d16.c: Remove.
1575         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1576         * features/arm/arm-with-m.c: Remove.
1577         * features/arm/arm-with-m.xml: Remove.
1578         * features/arm/arm-with-neon.c: Remove.
1579         * features/arm/arm-with-neon.xml: Remove.
1580         * features/arm/arm-with-vfpv2.c: Remove.
1581         * features/arm/arm-with-vfpv2.xml: Remove.
1582         * features/arm/arm-with-vfpv3.c: Remove.
1583         * features/arm/arm-with-vfpv3.xml: Remove.
1584
1585 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1586
1587         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1588
1589 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1590
1591         * arch/aarch32.c (aarch32_create_target_description): Create
1592         target descriptions using features.
1593         * arch/arm.c (arm_create_target_description)
1594         (arm_create_mprofile_target_description): Likewise.
1595         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1596
1597 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1598
1599         * Makefile.in: Add new files.
1600         * aarch32-tdep.c: New file.
1601         * aarch32-tdep.h: New file.
1602         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1603         Call aarch32_read_description.
1604         * arch/aarch32.c: New file.
1605         * arch/aarch32.h: New file.
1606         * arch/arm.c (arm_create_target_description)
1607         (arm_create_mprofile_target_description): New function.
1608         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1609         (arm_create_target_description)
1610         (arm_create_mprofile_target_description): New declaration.
1611         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1612         read_description functions.
1613         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1614         Likewise.
1615         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1616         * arm-tdep.c (tdesc_arm_list): New variable.
1617         (arm_register_g_packet_guesses): Call create description functions.
1618         (arm_read_description) (arm_read_mprofile_description): New
1619         function.
1620         * arm-tdep.h (arm_read_description)
1621         (arm_read_mprofile_description): Add declaration.
1622         * configure.tgt: Add new files.
1623
1624 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1625
1626         * top.c (new_ui_command): Open specified terminal just once.
1627
1628 2019-07-18  Tom Tromey  <tromey@adacore.com>
1629
1630         * symtab.c (main_name): Constify return type.
1631         * symfile.c (set_initial_language): Update.
1632         * symtab.h (main_name): Constify return type.
1633
1634 2019-07-17  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-winsource.c (tui_update_source_window)
1637         (tui_update_source_window_as_is)
1638         (tui_update_source_windows_with_line): Remove return.
1639         * tui/tui-disasm.c (tui_show_disassem)
1640         (tui_show_disassem_and_update_source): Remove return.
1641         * tui/tui.c (tui_reset): Remove return.
1642         * tui/tui-wingeneral.c
1643         (tui_check_and_display_highlight_if_needed): Remove return.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1648
1649 2019-07-17  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-winsource.h (struct tui_exec_info_window)
1652         (struct tui_source_window_base): Move from tui-data.h.
1653         * tui/tui-winsource.c: Move many method definitions from
1654         elsewhere.  Remove "structuring" comments.
1655         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1656         (tui_source_window_base::refresh_window): Move to
1657         tui-winsource.c.
1658         * tui/tui-win.c (tui_source_window_base::refresh_all)
1659         (tui_source_window_base::update_tab_width)
1660         (tui_source_window_base::set_new_height)
1661         (tui_source_window_base::do_make_visible_with_new_height): Move to
1662         tui-winsource.c.
1663         * tui/tui-source.h: Update.
1664         * tui/tui-source.c (tui_source_window_base::reset): Move to
1665         tui-winsource.c.
1666         * tui/tui-disasm.h: Update.
1667         * tui/tui-data.h (struct tui_exec_info_window): Move to
1668         tui-winsource.h.
1669         (struct tui_source_window_base): Likewise.
1670         * tui/tui-data.c (tui_source_window_base::clear_detail)
1671         (tui_source_window_base, ~tui_source_window_base): Move to
1672         tui-winsource.c.
1673
1674 2019-07-17  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-win.c (tui_resize_all)
1677         (tui_source_window_base::update_tab_width)
1678         (tui_adjust_win_heights): Update.
1679         (tui_win_info::make_invisible_and_set_new_height): Rename from
1680         make_invisible_and_set_new_height.
1681         * tui/tui-data.h (struct tui_win_info)
1682         <make_invisible_and_set_new_height>: New method.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui.c: Update.
1687         * tui/tui-source.h (struct tui_source_window): Move from
1688         tui-data.h.
1689         * tui/tui-layout.c: Update.
1690         * tui/tui-disasm.c: Update.
1691         * tui/tui-data.h (struct tui_source_window): Move to
1692         tui-source.h.
1693
1694 2019-07-17  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1697         tui-data.h.
1698         * tui/tui-data.h (struct tui_disasm_window): Move to
1699         tui-disasm.h.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-regs.h (struct tui_data_item_window): Move from
1704         tui-data.h.
1705         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1706         * tui/tui-data.h (struct tui_data_item_window): Move to
1707         tui-regs.h.
1708         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1709
1710 2019-07-17  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui.c: Update.
1713         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1714         (tui_cmd_window::max_height): Move to tui-command.c.
1715         * tui/tui-layout.c: Update.
1716         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1717         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1718         tui-command.c.
1719         * tui/tui-command.h (struct tui_cmd_window): Move from
1720         tui-data.h.
1721         * tui/tui-command.c: Remove "structuring" comments.
1722         (tui_cmd_window::clear_detail)
1723         (tui_cmd_window::do_make_visible_with_new_height)
1724         (tui_cmd_window::max_height): Move from elsewhere.
1725
1726 2019-07-17  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1729         Now static.
1730         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1731         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1732
1733 2019-07-17  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui.c: Update.
1736         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1737         tui-regs.c.
1738         * tui/tui-windata.h: Remove file.
1739         * tui/tui-windata.c: Remove file.
1740         * tui/tui-win.c (tui_data_window::set_new_height)
1741         (tui_data_window::do_make_visible_with_new_height): Move to
1742         tui-regs.c.
1743         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1744         * tui/tui-regs.c: Remove "structuring" comments.
1745         (tui_data_window::first_data_item_displayed)
1746         (tui_data_window::delete_data_content_windows)
1747         (tui_data_window::erase_data_content)
1748         (tui_data_window::display_all_data)
1749         (tui_data_window::refresh_all)
1750         (tui_data_window::do_scroll_vertical)
1751         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1752         (tui_data_window::do_make_visible_with_new_height)
1753         (tui_data_window::refresh_window): Move from elsewhere.
1754         (_initialize_tui_regs): Move to end of file.
1755         * tui/tui-layout.c: Update.
1756         * tui/tui-hooks.c: Update.
1757         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1758         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1759         tui-regs.c.
1760         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1761
1762 2019-07-17  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1765         seen.
1766
1767 2019-07-17  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-win.c (tui_source_window_base::set_new_height)
1770         (tui_source_window_base::do_make_visible_with_new_height): Use
1771         m_has_locator field directly.
1772         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1773         method.
1774         (struct tui_source_window_base) <has_locator>: Likewise.
1775
1776 2019-07-17  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1779         Don't declare.
1780         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1781         Remove.
1782         * tui/tui-win.c (tui_source_window_base::set_new_height)
1783         (tui_source_window_base::set_new_height)
1784         (make_invisible_and_set_new_height)
1785         (tui_source_window_base::do_make_visible_with_new_height)
1786         (tui_source_window_base::do_make_visible_with_new_height):
1787         Update.
1788         * tui/tui-layout.c (show_source_disasm_command, show_data)
1789         (show_source_or_disasm_and_command): Update.
1790         * tui/tui-layout.c (show_layout): Update.
1791
1792 2019-07-17  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-layout.c (make_data_window): Remove.
1795         (show_data): Unify creation and re-initialization cases.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-layout.c (make_source_window, make_disasm_window):
1800         Remove.
1801         (show_data): Unify creation and re-initialization cases.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-layout.c (make_command_window): Remove.
1806         (show_source_disasm_command, show_source_or_disasm_and_command):
1807         Unify creation and re-initialization cases.
1808
1809 2019-07-17  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1812         creation and re-initialization cases.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-regs.c (tui_get_register): Return void.
1817
1818 2019-07-17  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1821         Simplify.
1822
1823 2019-07-17  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1826         resetting.
1827
1828 2019-07-17  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1831         * tui/tui-regs.c (tui_reg_layout): New function.
1832         (tui_show_registers, tui_reg_command): Use it.
1833         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1834         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1835         parameters.
1836         (tui_layout_command): Remove.
1837
1838 2019-07-17  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-layout.h (tui/tui-layout): Return void.
1841         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1842
1843 2019-07-17  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-layout.c (show_source_disasm_command, show_data):
1846         Update.
1847         (reset_locator): Remove.
1848         (show_source_or_disasm_and_command): Update.
1849
1850 2019-07-17  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-source.c (tui_source_window_base::reset): Remove
1853         win_type parameter.
1854         * tui/tui-layout.c (make_command_window, make_source_window)
1855         (make_disasm_window, make_data_window)
1856         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1857         (reset_locator, show_source_or_disasm_and_command): Update.
1858         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1859         win_type parameter.
1860         (struct tui_source_window_base) <reset>: Likewise.
1861
1862 2019-07-17  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-layout.c (show_source_disasm_command): Use
1865         reset_locator.
1866         (reset_locator): New function.
1867         (init_and_make_win): Remove.
1868         (show_source_or_disasm_and_command): Use reset_locator.
1869
1870 2019-07-17  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1873         condition.
1874         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1875         Remove condition.
1876         * tui/tui-source.c (tui_source_window_base::reset): New method.
1877         * tui/tui-layout.c (make_command_window): Don't call
1878         init_and_make_win.
1879         (make_source_window, make_disasm_window): Don't call
1880         make_source_or_disasm_window.
1881         (make_data_window): Don't call init_and_make_win.  Change calling
1882         convention.
1883         (show_source_disasm_command, show_data): Simplify.
1884         (make_source_or_disasm_window): Remove.
1885         (show_source_or_disasm_and_command): Simplify.
1886         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1887         (struct tui_source_window_base) <reset>: Likewise.
1888         <execution_info>: Remove initializer.
1889         * tui/tui-data.c (tui_source_window_base): Initialize
1890         execution_info.
1891
1892 2019-07-17  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1895         variable.
1896
1897 2019-07-17  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui.c (tui_rl_other_window): Update.
1900         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1901         superclass method first.  Always iterate over regs_content.
1902         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1903         method.
1904         * tui/tui-win.c (tui_set_focus_command): Update.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-win.c (tui_set_focus_command): Rename from
1909         tui_set_focus.  Call tui_enable.
1910         (tui_set_focus_command): Remove.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1915         refresh_window.
1916         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1917         touchwin.
1918         (tui_data_window::refresh_window): Call refresh_window on data
1919         items.  Always call superclass refresh_window.
1920         (tui_win_info::refresh): Remove.
1921         (tui_source_window_base::refresh_window): Update.
1922         (tui_refresh_all): Update.
1923         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1924         refresh_window.
1925         (show_source_or_disasm_and_command): Likewise.
1926         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1927         (struct tui_source_window_base) <refresh>: Likewise.
1928
1929 2019-07-17  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-winsource.c (tui_clear_source_content)
1932         (tui_show_source_content): Update.
1933         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1934         whether content is empty.
1935         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1936         Remove.
1937
1938 2019-07-17  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1941         window's contents.
1942         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1943         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1944
1945 2019-07-17  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1948         (struct tui_data_item_window): Update.
1949
1950 2019-07-17  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1953         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1954         defines.
1955
1956 2019-07-17  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-winsource.h (tui_erase_source_content)
1959         (tui_clear_source_content): Remove "display_prompt" parameter.
1960         * tui/tui-winsource.c (tui_update_source_window_as_is)
1961         (tui_update_source_windows_with_addr): Update.
1962         (tui_clear_source_content): Remove "display_prompt" parameter.
1963         (tui_erase_source_content): Likewise.  Simplify.
1964         (tui_show_source_content): Update.
1965         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1966         * tui/tui-stack.c (tui_show_frame_info): Update.
1967         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1968         Remove defines.
1969
1970 2019-07-17  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1973         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1974         parameter.
1975         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1976         parameter.
1977
1978 2019-07-17  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-winsource.c (tui_clear_source_content)
1981         (tui_show_source_content, tui_show_exec_info_content)
1982         (tui_clear_exec_info_content): Update.
1983         * tui/tui-stack.c (tui_show_locator_content): Update.
1984         (tui_show_frame_info): Update.
1985         * tui/tui-source.h (tui_source_window): Don't declare.
1986         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1987         from tui_source_is_displayed.
1988         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1989         Remove field.
1990         (struct tui_source_window_base) <content_in_use>: New field.  Now
1991         bool.
1992         (struct tui_source_window) <showing_source_p>: New method.
1993         (TUI_SRC_WIN): Change cast.
1994         * tui/tui-data.c (tui_initialize_static_data): Update.
1995
1996 2019-07-17  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1999         location_matches_p.
2000         * tui/tui-source.c (tui_source_window::location_matches_p): New
2001         method.
2002         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2003         method.
2004         * tui/tui-data.h (struct tui_source_window_base)
2005         <location_matches_p>: New method.
2006         (struct tui_source_window, struct tui_disasm_window)
2007         <location_matches_p>: Likewise.
2008
2009 2019-07-17  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-win.c (tui_set_win_height_command): Rename from
2012         tui_set_win_height.
2013         (tui_set_win_height_command): Remove.
2014
2015 2019-07-17  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-source.c (tui_source_window): New constructor.  Add
2018         observer.
2019         (~tui_source_window): New destructor.
2020         (tui_source_window::style_changed): New method.
2021         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2022         (tui_attach_detach_observers): Update.
2023         * tui/tui-data.h (struct tui_source_window): Make constructor not
2024         inline.  Add destructor.
2025         (struct tui_source_window) <style_changed>: New method.
2026         <m_observable>: New member.
2027
2028 2019-07-17  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2031         * tui/tui-win.c (tui_resize_all): Fix typo.
2032
2033 2019-07-17  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2036         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2037         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2038         * tui/tui-win.c (window_name_completer): Use foreach.
2039         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2040         (update_tab_width): Likewise.
2041         * tui/tui-layout.c (show_layout): Update.
2042         * tui/tui-data.h (class tui_window_iterator): New.
2043         (struct all_tui_windows): New.
2044         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2045
2046 2019-07-17  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2049         parameter.  Don't reference globals.
2050         (tui_reg_command): Update.
2051
2052 2019-07-17  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-regs.c (tui_show_registers): Simplify.
2055
2056 2019-07-17  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-regs.c (tui_show_registers): Update.
2059         (tui_show_register_group): Add win_info parameter.
2060
2061 2019-07-17  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2064         Rename from tui_display_reg_element_at_line.
2065         (tui_data_window::display_registers_from_line): Update.
2066         * tui/tui-data.h (struct tui_data_window)
2067         <display_reg_element_at_line>: New method.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-regs.h (tui_display_registers_from)
2072         (tui_display_registers_from_line): Don't declare.
2073         * tui/tui-windata.c (tui_data_window::display_all_data)
2074         (tui_data_window::refresh_all)
2075         (tui_data_window::do_scroll_vertical): Update.
2076         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2077         from tui_display_registers_from.
2078         (tui_display_reg_element_at_line): Update.
2079         (tui_data_window::display_registers_from_line): Rename from
2080         tui_display_registers_from_line.
2081         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2082         display_registers_from_line>: New methods.
2083
2084 2019-07-17  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2087         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2088         from tui_erase_data_content.
2089         (tui_data_window::display_all_data)
2090         (tui_data_window::refresh_all)
2091         (tui_data_window::do_scroll_vertical): Update.
2092         * tui/tui-regs.c (tui_show_registers): Update.
2093         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2094         New method.
2095
2096 2019-07-17  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2099         declare.
2100         * tui/tui-windata.c
2101         (tui_data_window::delete_data_content_windows): Rename from
2102         tui_delete_data_content_windows.
2103         (tui_data_window::display_all_data)
2104         (tui_data_window::do_scroll_vertical): Update.
2105         * tui/tui-data.h (struct tui_data_window)
2106         <delete_data_content_windows>: New method.
2107
2108 2019-07-17  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2111         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2112
2113 2019-07-17  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2116         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2117         from tui_display_all_data.
2118         * tui/tui-win.c
2119         (tui_data_window::do_make_visible_with_new_height): Update.
2120         * tui/tui-regs.c (tui_show_registers): Update.
2121         * tui/tui-layout.c (tui_set_layout): Update.
2122         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2123         method.
2124
2125 2019-07-17  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2128         * tui/tui-windata.c (tui_display_data_from): Remove.
2129         (tui_data_window::refresh_all): Update.
2130
2131 2019-07-17  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2134         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2135         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2136         tui_display_registers_from_line.
2137         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2138         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2139         "force_display" parameter.
2140
2141 2019-07-17  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2144         declare.
2145         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2146         Rename from tui_first_reg_element_no_inline.
2147         (tui_display_reg_element_at_line)
2148         (tui_display_registers_from_line): Update.
2149         * tui/tui-data.h (struct tui_data_window)
2150         <first_reg_element_no_inline>: New method.
2151
2152 2019-07-17  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-windata.c (tui_display_data_from)
2155         (tui_data_window::do_scroll_vertical): Update.
2156         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2157         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2158         Rename from tui_line_from_reg_element_no.
2159         (tui_display_registers_from_line): Update.
2160         * tui/tui-data.h (struct tui_data_window)
2161         <line_from_reg_element_no>: New method.
2162
2163 2019-07-17  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2166         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2167         tui_last_regs_line_no.
2168         (tui_display_reg_element_at_line)
2169         (tui_display_registers_from_line): Update.
2170         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2171         method.
2172
2173 2019-07-17  Tom Tromey  <tom@tromey.com>
2174
2175         PR tui/24722:
2176         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2177         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2178         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2179         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2180         (tui_update_breakpoint_info): Likewise.
2181         * tui/tui-hooks.c (tui_event_create_breakpoint)
2182         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2183         Update.
2184
2185 2019-07-17  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2188
2189 2019-07-17  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-winsource.c (tui_update_source_window_as_is)
2192         (tui_update_source_windows_with_addr): Update.
2193         * tui/tui-source.h (tui_set_source_content)
2194         (tui_show_symtab_source): Add "win_info" parameter.
2195         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2196         parameter.
2197         (tui_show_symtab_source): Likewise.
2198
2199 2019-07-17  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-wingeneral.c
2202         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2203
2204 2019-07-17  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2207         (struct tui_cmd_window) <can_scroll>: New method.
2208         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2209         method.
2210
2211 2019-07-17  Tom Tromey  <tromey@adacore.com>
2212
2213         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2214         do_field_signed>: Rename.  Change type of "value".
2215         * ui-out.c (ui_out::field_signed): Rename from field_int.
2216         Change type of "value".
2217         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2218         type of "value".
2219         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2220         do_field_int.  Change type of "value".
2221         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2222         do_field_int.  Change type of "value".
2223         * tracepoint.c (trace_status_mi, tfind_1)
2224         (print_one_static_tracepoint_marker): Update.
2225         * thread.c (print_thread_info_1, print_selected_thread_frame):
2226         Update.
2227         * stack.c (print_frame, print_frame_info): Update.
2228         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2229         Update.
2230         * source.c (print_source_lines_base): Update.
2231         * skip.c (info_skip_command): Update.
2232         * record-btrace.c (btrace_ui_out_decode_error)
2233         (btrace_call_history_src_line): Update.
2234         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2235         Update.
2236         * progspace.c (print_program_space): Update.
2237         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2238         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2239         do_field_int.  Change type of "value".
2240         * mi/mi-out.c (mi_ui_out::do_table_begin)
2241         (mi_ui_out::do_table_header): Update.
2242         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2243         type of "value".
2244         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2245         (mi_cmd_data_list_changed_registers, output_register)
2246         (mi_cmd_data_read_memory, mi_load_progress)
2247         (mi_cmd_trace_frame_collected): Update.
2248         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2249         Update.
2250         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2251         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2252         (mi_cmd_var_list_children, varobj_update_one): Update.
2253         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2254         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2255         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2256         * inferior.c (print_inferior): Update.
2257         * gdb_bfd.c (print_one_bfd): Update.
2258         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2259         Update.
2260         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2261         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2262         do_field_int.  Change type of "value".
2263         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2264         do_field_int.  Change type of "value".
2265         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2266         (print_one_breakpoint_location, print_it_catch_fork)
2267         (print_one_catch_fork, print_it_catch_vfork)
2268         (print_one_catch_vfork, print_it_catch_solib)
2269         (print_it_catch_exec, print_it_ranged_breakpoint)
2270         (print_mention_watchpoint, print_mention_masked_watchpoint)
2271         (bkpt_print_it, update_static_tracepoint): Update.
2272         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2273         * break-catch-syscall.c (print_it_catch_syscall): Update.
2274         * ada-tasks.c (print_ada_task_info): Update.
2275         * ada-lang.c (print_it_exception, print_mention_exception):
2276         Update.
2277
2278 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         PR breakpoints/24541
2281         * gdbarch.c: Regenerate.
2282         * gdbarch.h: Regenerate.
2283         * gdbarch.sh: Adjust return type and parameter types for
2284         'stap_adjust_register'.
2285         (i386_stap_adjust_register): Adjust signature and return new
2286         register name.
2287         * stap-probe.c (stap_parse_register_operand): Adjust use of
2288         'gdbarch_stap_adjust_register'.
2289
2290 2019-07-17  Tom Tromey  <tromey@adacore.com>
2291
2292         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2293         declare VEC.
2294         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2295         std::vector.
2296         (struct s390_process_info): Add initializers.
2297         (s390_add_process): Use new.
2298         (s390_linux_nat_target::low_forget_process): Use delete.
2299         (s390_linux_nat_target::low_new_fork)
2300         (s390_linux_nat_target::stopped_by_watchpoint)
2301         (s390_linux_nat_target::low_prepare_to_resume)
2302         (s390_linux_nat_target::insert_watchpoint)
2303         (s390_linux_nat_target::insert_hw_breakpoint)
2304         (s390_linux_nat_target::remove_watchpoint)
2305         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2306
2307 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2308
2309         * aarch64-fbsd-nat.c: Include regcache.h.
2310         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2311         argument.
2312         (aarch64_fbsd_nat_target::fetch_registers)
2313         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2314         variable.
2315         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2316
2317 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2318
2319         * fbsd-nat.c: Include gdbarch.h.
2320
2321 2019-07-15  Tom Tromey  <tromey@adacore.com>
2322
2323         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2324
2325 2019-07-15  Tom Tromey  <tromey@adacore.com>
2326
2327         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2328         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2329         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2330         * cli-out.c (cli_ui_out::do_field_int): New method.
2331         * ui-out.c (ui_out::field_unsigned): New method.
2332         * symfile.c (generic_load): Use field_unsigned.
2333         (print_transfer_performance): Likewise.
2334         * record-btrace.c (ui_out_field_uint): Remove.
2335         (btrace_call_history_insn_range, btrace_call_history): Use
2336         field_unsigned.
2337         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2338         field_unsigned.
2339         * ui-out.h (class ui_out) <field_unsigned>: New method.
2340         <do_field_unsigned>: Likewise.
2341
2342 2019-07-15  Tom Tromey  <tromey@adacore.com>
2343
2344         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2345         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2346         * target.c (flash_erase_command): Use field_string.
2347         * infrun.c (print_signal_received_reason): Use field_string.
2348         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2349         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2350         field_string.
2351         * ada-tasks.c (print_ada_task_info): Use field_string.
2352
2353 2019-07-15  Tom Tromey  <tromey@adacore.com>
2354
2355         * target.c (flash_erase_command): Use field_core_addr.
2356         * symfile.c (generic_load): Use field_core_addr.
2357         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2358         Use field_core_addr.
2359         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2360         field_core_addr.
2361
2362 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2365         value if its desired type is smaller than a CORE_ADDR and signed.
2366
2367 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2370         of changes to field names, and use new is_reference field to
2371         decide if a property is a reference or not.
2372         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2373         field.
2374         (struct dwarf2_property_baton): Update header comment, rename
2375         'referenced_type' to 'property_type' and update comments.
2376         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2377         default property type, store in property baton, update to take
2378         accound of renamed field.
2379         (read_func_scope): Update call to attr_to_dynamic_prop.
2380         (read_array_type): Likewise.
2381         (dwarf2_per_cu_addr_sized_int_type): New function.
2382         (read_subrange_index_type): Move type finding code to
2383         dwarf2_per_cu_addr_sized_int_type.
2384         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2385         (dwarf2_per_cu_addr_type): New function.
2386         (set_die_type): Update calls to attr_to_dynamic_prop.
2387
2388 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * dwarf2read.c (read_subrange_index_type): New function.
2391         (read_subrange_type): Move code into new function and call it.
2392         * gdbtypes.c (create_range_type): Add some asserts.
2393
2394 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2397         update return statements.
2398         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2399         declaration, and update comment to match.
2400         * gdbtypes.c (resolve_dynamic_array): Update call to
2401         dwarf2_evaluate_property to match new return type.
2402
2403 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * valarith.c (value_subscripted_rvalue): Change lowerbound
2406         parameter type from int to LONGEST.
2407         * value.h (value_subscripted_rvalue): Likewise in declaration.
2408
2409 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2410
2411         * cli/cli-utils.c (info_print_command_completer): New function.
2412         * cli/cli-utils.h: Add 'completer.h' include, and forward
2413         declaration for 'struct cmd_list_element'.
2414         (info_print_command_completer): Declare.
2415         * stack.c (_initialize_stack): Add completer for 'info locals' and
2416         'info args'.
2417         * symtab.c (_initialize_symtab): Add completer for 'info
2418         variables' and 'info functions'.
2419         * NEWS: Mention completion for additional info commands.
2420
2421 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * cli/cli-utils.c (extract_info_print_args): Delete.
2424         (extract_arg_maybe_quoted): Delete.
2425         (info_print_options_defs): New variable.
2426         (make_info_print_options_def_group): New function.
2427         (extract_info_print_options): Define new function.
2428         * cli/cli-utils.h (extract_info_print_args): Delete.
2429         (struct info_print_options): New structure.
2430         (extract_info_print_options): Declare new function.
2431         * stack.c (info_locals_command): Update to use new
2432         extract_info_print_options, also add a header comment.
2433         (info_args_command): Likewise.
2434         * symtab.c (info_variables_command): Likewise.
2435         (info_functions_command): Likewise.
2436
2437 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2440         to extract string arguments.
2441         * common/common-utils.c (extract_string_maybe_quoted): New function.
2442         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2443
2444 2019-07-11  Tom Tromey  <tromey@adacore.com>
2445
2446         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2447         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2448         * top.h (gdbinit): Don't declare.
2449         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2450         into...
2451         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2452         * top.c (gdb_init): Don't call init_cli_cmds.
2453         (gdbinit): Remove.
2454         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2455
2456 2019-07-11  Tom Tromey  <tromey@adacore.com>
2457
2458         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2459         after it has been moved.
2460
2461 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2462
2463         * valops.c (value_must_coerce_to_target): Change return type to
2464         bool.
2465         * value.h (value_must_coerce_to_target): Likewise.
2466
2467 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2468
2469         * breakpoint.c (is_hardware_watchpoint): Remove
2470         forward-declaration.
2471         (is_masked_watchpoint): Change return type to bool.
2472         (is_tracepoint): Likewise.
2473         (is_breakpoint): Likewise.
2474         (is_hardware_watchpoint): Likewise.
2475         (is_watchpoint): Likewise.
2476         (is_no_memory_software_watchpoint): Likewise.
2477         (is_catchpoint): Likewise.
2478         (breakpoint_1): Make FILTER parameter's return type bool.
2479         is_masked_watchpoint): Change return type to bool.
2480         (save_breakpoints): Make FILTER parameter's return type bool.
2481         * breakpoint.h (is_breakpoint): Change return type to bool.
2482         (is_watchpoint): Likewise.
2483         (is_catchpoint): Likewise.
2484         (is_tracepoint): Likewise.
2485
2486 2019-07-10  Tom Tromey  <tom@tromey.com>
2487
2488         * defs.h: Don't include gdbarch.h.
2489         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2490         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2491         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2492         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2493         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2494         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2495         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2496         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2497         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2498         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2499         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2500         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2501         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2502         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2503         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2504         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2505         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2506         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2507         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2508         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2509         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2510         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2511         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2512         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2513         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2514         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2515         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2516
2517 2019-07-10  Tom Tromey  <tromey@adacore.com>
2518
2519         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2520         * breakpoint.c (init_ada_exception_breakpoint): Register as
2521         bp_catchpoint.
2522         (print_one_breakpoint_location, print_one_breakpoint): Use
2523         is_ada_exception_catchpoint.
2524         * ada-lang.c (class ada_catchpoint_location): Pass
2525         bp_loc_software_breakpoint to bp_location constructor.
2526         (is_ada_exception_catchpoint): New function.
2527
2528 2019-07-10  Tom Tromey  <tromey@adacore.com>
2529
2530         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2531         VEC.
2532         (struct arm_exidx_entry): New method operator<.
2533         (struct arm_exidx_data) <section_maps>: Change type.
2534         (arm_exidx_data_free): Remove.
2535         (arm_exidx_data_key): Change type.  Move lower.
2536         (arm_exidx_new_objfile): Update.
2537         (arm_compare_exidx_entries): Remove.
2538         (arm_find_exidx_entry, _initialize_arm_tdep)
2539
2540 2019-07-10  Tom Tromey  <tromey@adacore.com>
2541
2542         * solib-spu.c (ocl_program_data_key): Change type.
2543         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2544         Update.
2545
2546 2019-07-10  Tom Tromey  <tromey@adacore.com>
2547
2548         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2549         (struct solib_aix_inferior_data) <library_list>: Change type.
2550         (solib_aix_inferior_data_handle): Change type.
2551         (get_solib_aix_inferior_data): Update.
2552         (solib_aix_free_library_list): Remove.
2553         (library_list_start_library): Update.
2554         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2555         return type.
2556         (solib_aix_get_library_list)
2557         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2558         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2559
2560 2019-07-10  Tom Tromey  <tromey@adacore.com>
2561
2562         * solib-dsbt.c (struct dsbt_info): Add initializers.
2563         (solib_dsbt_pspace_data): Change type.
2564         (dsbt_pspace_data_cleanup): Remove.
2565         (get_dsbt_info, _initialize_dsbt_solib): Update.
2566
2567 2019-07-10  Tom Tromey  <tromey@adacore.com>
2568
2569         * spu-tdep.c (spu_overlay_data): Change type.
2570         (spu_get_overlay_table, spu_overlay_new_objfile)
2571         (_initialize_spu_tdep): Update.
2572
2573 2019-07-10  Tom Tromey  <tromey@adacore.com>
2574
2575         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2576         destructor.
2577         (dbx_objfile_data_key): Change type and declare later.
2578         (DBX_SYMFILE_INFO): Rewrite.
2579         * dbxread.c (dbx_objfile_data_key): Change type.
2580         (dbx_symfile_init): Update.
2581         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2582         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2583         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2584
2585 2019-07-10  Tom Tromey  <tromey@adacore.com>
2586
2587         * jit.c (jit_program_space_key): Change type.  Move lower.
2588         (get_jit_program_space_data): Update.
2589         (jit_program_space_data_cleanup): Remove.
2590         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2591         Update.
2592         (struct jit_program_space_data): Add initializers.
2593
2594 2019-07-10  Tom Tromey  <tromey@adacore.com>
2595
2596         * solib-darwin.c (struct darwin_info): Add initializers.
2597         (solib_darwin_pspace_data): Change type.
2598         (darwin_pspace_data_cleanup): Remove.
2599         (get_darwin_info, _initialize_darwin_solib): Update.
2600
2601 2019-07-10  Tom Tromey  <tromey@adacore.com>
2602
2603         * remote-sim.c (struct sim_inferior_data): Add initializers,
2604         constructor, and destructor.
2605         (sim_inferior_data_key): Change type.  Move lower.
2606         (check_for_duplicate_sim_descriptor): Update.
2607         (get_sim_inferior_data): Use new.  Update.
2608         (~sim_inferior_data_cleanup): Rename from
2609         sim_inferior_data_cleanup.  Simplify.
2610         (gdbsim_close_inferior, simulator_command)
2611         (sim_command_completer, _initialize_remote_sim): Update.
2612         (next_pid, INITIAL_PID): Move earlier.
2613
2614 2019-07-10  Tom Tromey  <tromey@adacore.com>
2615
2616         * python/python-internal.h (create_thread_object): Return
2617         gdbpy_ref.
2618         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2619         * python/py-inferior.c (struct threadlist_entry): Add
2620         constructor.
2621         <thread_obj>: Now a gdbpy_ref.
2622         (thread_to_thread_object): Update.
2623         (add_thread_object): Use new.
2624         (delete_thread_object): Use delete.
2625         (infpy_threads): Update.
2626         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2627         GIL.
2628
2629 2019-07-10  Tom Tromey  <tromey@adacore.com>
2630
2631         * valops.c (value_cast): Specialize error message for Ada.
2632
2633 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2634
2635         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2636
2637 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2638
2639         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2640         bpstat_should_step): Return bool, adjust comments.
2641         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2642         bpstat_should_step): Likewise.
2643
2644 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2645
2646         * features/Makefile: Use feature target descriptions for Arm.
2647         * features/arm/arm-core.c: Generate new file.
2648         * features/arm/arm-fpa.c: Likewise.
2649         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2650         * features/arm/arm-m-profile.c: Likewise.
2651         * features/arm/arm-vfpv2.c: Likewise.
2652         * features/arm/arm-vfpv3.c: Likewise.
2653         * features/arm/xscale-iwmmxt.c: Likewise.
2654         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2655
2656 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2659         ptrace earlier.
2660
2661 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2662
2663         * features/aarch64-pauth.c: Regenerate.
2664
2665 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2666
2667         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2668         bool.
2669         (bpstat_what): Use false instead of 0.
2670
2671 2019-07-09  Pedro Alves  <palves@redhat.com>
2672
2673         * break-catch-throw.c (is_exception_catchpoint): New.
2674         * breakpoint.c (print_one_breakpoint_location): New parameter
2675         'raw_loc'.  Handle it.  Use
2676         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2677         looking at the breakpoint's type.
2678         (print_one_breakpoint): If handling "maint info breakpoints", also
2679         print locations of exception catchpoints.
2680         * breakpoint.h (is_exception_catchpoint): Declare.
2681
2682 2019-07-09  Pedro Alves  <palves@redhat.com>
2683
2684         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2685         "addr" field.
2686         (allocate_location_exception_catchpoint): New.
2687         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2688         (initialize_throw_catchpoint_ops): Install
2689         allocate_location_exception_catchpoint as allocate_location
2690         method.
2691         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2692         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2693         bp_loc_other.
2694         (breakpoint_address_is_meaningful): Delete.
2695         (bl_address_is_meaningful): New.
2696         (breakpoint_locations_match): Adjust comment.
2697         (bp_location_from_bp_type): New, factored out of...
2698         (bp_location::bp_location(breakpoint *)): ... this.
2699         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2700         factored out of...
2701         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2702         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2703         breakpoint_address_is_meaningful.
2704         (bp_locations_compare): Adjust comment.
2705         (update_global_location_list): Use bl_address_is_meaningful
2706         instead of breakpoint_address_is_meaningful.
2707         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2708         explicit.
2709         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2710         * python/py-breakpoint.c (bppy_get_location): No longer check
2711         whether location is null.
2712
2713 2019-07-09  Pedro Alves  <palves@redhat.com>
2714
2715         PR c++/15468
2716         * breakpoint.c (print_one_breakpoint_location): Remove
2717         single-location assert.
2718
2719 2019-07-09  Tom Tromey  <tom@tromey.com>
2720
2721         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2722         * configure: Rebuild.
2723         * configure.ac: Change common to gdbsupport.
2724         * gdbsupport: Rename from common.
2725         * acinclude.m4: Change common to gdbsupport.
2726         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2727         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2728         gdbsupport.
2729         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2730         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2731         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2732         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2733         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2734         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2735         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2736         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2737         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2738         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2739         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2740         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2741         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2742         coff-pe-read.c, command.h, compile/compile-c-support.c,
2743         compile/compile-c.h, compile/compile-cplus-symbols.c,
2744         compile/compile-cplus-types.c, compile/compile-cplus.h,
2745         compile/compile-loc2c.c, compile/compile.c, completer.c,
2746         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2747         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2748         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2749         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2750         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2751         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2752         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2753         features/aarch64-core.c, features/aarch64-fpu.c,
2754         features/aarch64-pauth.c, features/aarch64-sve.c,
2755         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2756         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2757         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2758         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2759         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2760         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2761         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2762         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2763         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2764         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2765         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2766         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2767         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2768         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2769         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2770         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2771         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2772         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2773         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2774         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2775         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2776         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2777         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2778         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2779         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2780         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2781         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2782         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2783         minsyms.c, mips-linux-tdep.c, namespace.h,
2784         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2785         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2786         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2787         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2788         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2789         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2790         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2791         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2792         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2793         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2794         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2795         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2796         procfs.c, producer.c, progspace.h, psymtab.h,
2797         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2798         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2799         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2800         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2801         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2802         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2803         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2804         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2805         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2806         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2807         target-memory.c, target.c, target.h, target/waitstatus.c,
2808         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2809         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2810         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2811         unittests/array-view-selftests.c,
2812         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2813         unittests/common-utils-selftests.c,
2814         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2815         unittests/format_pieces-selftests.c,
2816         unittests/function-view-selftests.c,
2817         unittests/lookup_name_info-selftests.c,
2818         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2819         unittests/mkdir-recursive-selftests.c,
2820         unittests/observable-selftests.c,
2821         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2822         unittests/parse-connection-spec-selftests.c,
2823         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2824         unittests/scoped_fd-selftests.c,
2825         unittests/scoped_mmap-selftests.c,
2826         unittests/scoped_restore-selftests.c,
2827         unittests/string_view-selftests.c, unittests/style-selftests.c,
2828         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2829         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2830         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2831         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2832         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2833         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2834
2835 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2838         bool value.
2839         (decode_digits_ordinary): Set explicit_line field in sal.
2840         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2841         symtab_and_line that was set on an explicit line number in
2842         assembler code.  Do always update the recorded symtab and line if
2843         we do skip the prologue.
2844
2845 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2846
2847         * breakpoint.c (set_breakpoint_location_function): Remove
2848         explicit_loc parameter.
2849         (momentary_breakpoint_from_master): Update call to
2850         set_breakpoint_location_function.
2851         (add_location_to_breakpoint): Likewise.
2852
2853 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2854
2855         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2856         required features based on default bfd type when no specific bfd
2857         is present.
2858
2859 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2860
2861         * NEWS: Mention that GDB printf and eval commands can now print
2862         C-style and Ada-style convenience var strings without
2863         calling the inferior.
2864         * printcmd.c (printf_c_string): Locally print GDB internal var
2865         instead of transiting via the inferior.
2866         (printf_wide_c_string): Likewise.
2867
2868 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2869
2870         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2871
2872 2019-07-04  Tom Tromey  <tom@tromey.com>
2873
2874         PR tui/24724:
2875         * tui/tui-winsource.c (tui_clear_source_content): Update.
2876         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2877         (tui_update_breakpoint_info): Update.
2878         (tui_set_exec_info_content): Update.
2879         * tui/tui-source.c (tui_set_source_content_nil): Update.
2880         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2881         has_break.
2882         * tui/tui-data.h (enum tui_bp_flag): New.
2883         (tui_bp_flags): New enum flags type.
2884         (struct tui_source_element) <break_mode>: Change type.  Rename
2885         from has_break.
2886         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2887         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2888         constants.
2889         * tui/tui-winsource.h: Fix comment.
2890
2891 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2892
2893         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2894         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2895         (store_fpregs_to_thread)
2896         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2897         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2898         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2899         (IWMMXT_REGS_SIZE): Add define.
2900         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2901         (fetch_vfp_regs, store_vfp_regs)
2902         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2903         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2904
2905 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2906
2907         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2908         defines.
2909         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2910         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2911         (ARM_INT_REGISTER_SIZE): ...to this.
2912         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2913         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2914         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2915         (arm_linux_collect_gregset, supply_nwfpe_register)
2916         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2917         defines.
2918         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2919         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2920         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2921         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2922         (arm_return_in_memory, arm_store_return_value)
2923         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2924         (arm_record_ld_st_multiple): Likewise.
2925         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2926         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2927
2928 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2929
2930         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2931         AARCH64_DISPLACED_MODIFIED_INSNS.
2932         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2933         (aarch64_displaced_step_copy_insn): Likewise.
2934         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2935         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2936         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2937         ARM_DISPLACED_MODIFIED_INSNS.
2938         * arm-tdep.c (arm_gdbarch_init): Likewise.
2939         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2940         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2941         (struct arm_displaced_step_closure): Use
2942         ARM_DISPLACED_MODIFIED_INSNS.
2943
2944 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2945
2946         * features/Makefile: Remove unused xml files.
2947         * features/aarch64.xml: Remove.
2948         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2949         * features/i386/amd64-avx-avx512.xml: Remove.
2950         * features/i386/amd64-avx-linux.xml: Remove.
2951         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2952         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2953         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2954         * features/i386/amd64-avx-mpx.xml: Remove.
2955         * features/i386/amd64-avx.xml: Remove.
2956         * features/i386/amd64-linux.xml: Remove.
2957         * features/i386/amd64-mpx-linux.xml: Remove.
2958         * features/i386/amd64-mpx.xml: Remove.
2959         * features/i386/amd64.xml: Remove.
2960         * features/i386/i386-avx-avx512-linux.xml: Remove.
2961         * features/i386/i386-avx-avx512.xml: Remove.
2962         * features/i386/i386-avx-linux.xml: Remove.
2963         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2964         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2965         * features/i386/i386-avx-mpx-linux.xml: Remove.
2966         * features/i386/i386-avx-mpx.xml: Remove.
2967         * features/i386/i386-avx.xml: Remove.
2968         * features/i386/i386-linux.xml: Remove.
2969         * features/i386/i386-mmx-linux.xml: Remove.
2970         * features/i386/i386-mmx.xml: Remove.
2971         * features/i386/i386-mpx-linux.xml: Remove.
2972         * features/i386/i386-mpx.xml: Remove.
2973         * features/i386/i386.xml: Remove.
2974         * features/i386/x32-avx-avx512-linux.xml: Remove.
2975         * features/i386/x32-avx-linux.xml: Remove.
2976         * features/i386/x32-linux.xml: Remove.
2977
2978 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2979
2980         * regformats/aarch64.dat: Remove.
2981         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2982         * regformats/i386/amd64-avx-linux.dat: Remove.
2983         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2984         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2985         * regformats/i386/amd64-linux.dat: Remove.
2986         * regformats/i386/amd64-mpx-linux.dat: Remove.
2987         * regformats/i386/amd64.dat: Remove.
2988         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2989         * regformats/i386/i386-avx-linux.dat: Remove.
2990         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2991         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2992         * regformats/i386/i386-linux.dat: Remove.
2993         * regformats/i386/i386-mmx-linux.dat: Remove.
2994         * regformats/i386/i386-mpx-linux.dat: Remove.
2995         * regformats/i386/i386.dat: Remove.
2996         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2997         * regformats/i386/x32-avx-linux.dat: Remove.
2998         * regformats/i386/x32-linux.dat: Remove.
2999
3000 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3001
3002         * aarch64-tdep.c: Remove xml self tests.
3003         * amd64-linux-tdep.c: Likewise.
3004         * amd64-tdep.c: Likewise.
3005         * i386-linux-tdep.c: Likewise.
3006         * i386-tdep.c: Likewise.
3007
3008 2019-07-03  Pedro Alves  <palves@redhat.com>
3009
3010         PR cli/24732
3011         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3012         (pipe_cmd_option_defs): New.
3013         (make_pipe_cmd_options_def_group): New.
3014         (pipe_command): Use gdb::option::process_options.
3015         (pipe_command_completer): New function.
3016         (_initialize_cli_cmds): Install completer for "pipe" command.
3017
3018 2019-07-03  Pedro Alves  <palves@redhat.com>
3019
3020         * cli/cli-option.c (union option_value) <string>: New field.
3021         (struct option_def_and_value): Add ctor, move ctor, dtor and
3022         use DISABLE_COPY_AND_ASSIGN.
3023         (option_def_and_value::clear_value): New.
3024         (parse_option, save_option_value_in_ctx, get_val_type_str)
3025         (add_setshow_cmds_for_options): Handle var_string.
3026         * cli-option.h (union option_def::var_address) <string>: New
3027         field.
3028         (struct string_option_def): New.
3029         * maint-test-options.c (struct test_options_opts): Add default
3030         ctor and use DISABLE_COPY_AND_ASSIGN.
3031         <string_opt>: New field.
3032         (test_options_opts::~test_options_opts): New.
3033         (test_options_opts::dump): Also dump "-string".
3034         (test_options_option_defs): Install "string.
3035
3036 2019-07-03  Pedro Alves  <palves@redhat.com>
3037
3038         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3039         option_value with a null enumeration.
3040         (complete_options): Save the option values in the context.
3041         (save_option_value_in_ctx): New, factored out from ...
3042         (process_options): ... here.
3043         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3044         of the function.
3045         * maint-test-options.c (test_options_opts::dump): New, factored
3046         out from ...
3047         (maintenance_test_options_command_mode): ... here.
3048         (maintenance_test_options_command_completion_result): Delete.
3049         (maintenance_test_options_command_completion_text): Update
3050         comment.
3051         (maintenance_show_test_options_completion_result): Change
3052         prototype.  Just print
3053         maintenance_test_options_command_completion_text.
3054         (save_completion_result): New.
3055         (maintenance_test_options_completer_mode): Pass options context to
3056         complete_options, and then save a dump.
3057         (_initialize_maint_test_options): Use add_cmd to install "maint
3058         show test-options-completion-result".
3059
3060 2019-07-03  Pedro Alves  <palves@redhat.com>
3061
3062         * NEWS (New commands): Mention "with" and "maint with".
3063         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3064         (with_command, with_command_completer): New.
3065         (pipe_command): Adjust to new repeat_previous
3066         interface.
3067         (_initialize_cli_cmds): Install the "with" command and its "w"
3068         alias.
3069         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3070         declarations.
3071         * cli/cli-setshow.c (parse_cli_var_uinteger)
3072         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3073         argument strings for all var_types.
3074         (get_setshow_command_value_string): New, factored out from ...
3075         (do_show_command): ... this.
3076         * cli/cli-setshow.h: Include <string>.
3077         (get_setshow_command_value_string): Declare.
3078         * command.h (repeat_previous): Now returns const char *.  Adjust
3079         comment.
3080         * maint.c: Include "cli/cli-cmds.h".
3081         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3082         (_initialize_maint_cmds): Register the "maintenance with" command.
3083         * top.c (repeat_previous): Move bits from pipe_command here:
3084         Return the saved command line, if any; error out if there's no
3085         command to relaunch.
3086
3087 2019-07-03  Pedro Alves  <palves@redhat.com>
3088
3089         * NEWS (New commands): Mention "maint set/show test-settings"
3090         instead of "maint test-settings".
3091         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3092         (maintenance_test_settings_set_list): Rename to ...
3093         (maintenance_set_test_settings_list): ... this.
3094         (maintenance_test_settings_show_list): Rename to  ...
3095         (maintenance_show_test_settings_list): ... this.
3096         (maintenance_test_settings_cmd): Delete.
3097         (maintenance_test_settings_set_cmd): ...
3098         (maintenance_set_test_settings_cmd): ... this.
3099         (maintenance_test_settings_show_cmd): ...
3100         (maintenance_show_test_settings_cmd): ... this.
3101         (maintenance_test_settings_show_value_cmd):
3102         (maintenance_show_test_settings_value_cmd): ... this.
3103         (_initialize_maint_test_settings): No longer install the "maint
3104         test-settings" prefix command.  Rename "maint test-settings set"
3105         to "maint set test-settings", and "maint test-settings show" to
3106         "maint show test-settings".  Adjust all subcommands.
3107
3108 2019-07-03  Pedro Alves  <palves@redhat.com>
3109
3110         * maint-test-settings.c: Fix file's intro comment.  Replace all
3111         references to "test-options" with references to "test-settings",
3112         in comments.
3113
3114 2019-07-03  Pedro Alves  <palves@redhat.com>
3115
3116         * maint-test-settings.c (maintenance_test_settings_xxx)
3117         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3118         New.
3119         (maintenance_test_settings_enums): Use them.
3120         (maintenance_test_settings_enum): Default to
3121         maintenance_test_settings_xxx.
3122         (_initialize_maint_test_settings): Initialize
3123         MAINTENANCE_TEST_SETTINGS_FILENAME.
3124
3125 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3126
3127         * breakpoint.h (remove_breakpoints_inf): Change return type to
3128         void, move function documentation here.
3129         * breakpoint.c (remove_breakpoints_inf): Change return type to
3130         void, move function documentation to header.
3131
3132 2019-07-02  Pedro Alves  <palves@redhat.com>
3133
3134         * NEWS (Completion improvements): Mention "info threads".
3135         * thread.c (struct info_threads_opts, info_threads_option_defs)
3136         (make_info_threads_options_def_group): New.
3137         (info_threads_command): Use gdb::option::process_options.
3138         (info_threads_command_completer): New.
3139         (_initialize_thread): Use gdb::option::build_help to build the
3140         help text for "info threads".
3141
3142 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3143
3144         * defs.h (generic_load): Move from here...
3145         * symfile.h (generic_load): ... to here.  Rename name parameter
3146         to args.
3147         * symfile.c (generic_load): Add comment.
3148
3149 2019-07-01  Tom Tromey  <tromey@adacore.com>
3150
3151         * dwarf2read.c
3152         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3153         declaration of without_params.  Fix formatting.
3154
3155 2019-07-01  Tom Tromey  <tromey@adacore.com>
3156
3157         * ada-exp.y (find_primitive_type): Update.
3158         * ada-lang.h (ada_lookup_symbol): Update.
3159         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3160         parameter.
3161         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3162
3163 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3164
3165         PR breakpoints/24541
3166         * gdbarch.c: Regenerate.
3167         * gdbarch.h: Regenerate.
3168         * gdbarch.sh: Add 'stap_adjust_register'.
3169         * i386-tdep.c: Include '<unordered_set>'.
3170         (i386_stap_adjust_register): New function.
3171         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3172         * stap-probe.c (stap_parse_register_operand): Call
3173         'gdbarch_stap_adjust_register'.
3174
3175 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3176
3177         PR python/24742
3178         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3179         * python/python.c (do_start_initialization): Use 'xmalloc'
3180         instead of 'PyMem_Malloc'.
3181
3182 2019-06-28  Tom Tromey  <tromey@adacore.com>
3183
3184         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3185         for Ada.
3186
3187 2019-06-27  Tom Tromey  <tromey@adacore.com>
3188
3189         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3190         objfile_key.
3191         (arm_find_mapping_symbol, arm_record_special_symbol)
3192         (_initialize_arm_tdep): Update.
3193         (arm_objfile_data_free): Remove.
3194
3195 2019-06-27  Tom Tromey  <tromey@adacore.com>
3196
3197         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3198         to cp_print_static_field.
3199
3200 2019-06-26  Tom Tromey  <tromey@adacore.com>
3201
3202         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3203         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3204         declare.
3205
3206 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3207
3208         * features/aarch64-core.c (create_feature_aarch64_core):
3209         Regenerate.
3210         * features/aarch64-core.xml: Add cpsr flags.
3211
3212 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3213
3214         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3215         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3216
3217 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3218
3219         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3220         field.
3221         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3222         use.
3223         (arm_record_special_symbol): Don't insert new symbol in sorted
3224         position, push it at the end.
3225
3226 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3227
3228         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3229         (arm_mapping_symbol_s): Remove.
3230         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3231         (arm_mapping_symbol_vec): New typedef.
3232         (struct arm_per_objfile): Add constructor.
3233         <section_maps>: Change type to
3234         std::unique_ptr<arm_mapping_symbol_vec[]>.
3235         (arm_compare_mapping_symbols): Remove.
3236         (arm_find_mapping_symbol): Adjust to section_maps type change.
3237         (arm_objfile_data_free): Call delete on arm_per_objfile.
3238         (arm_record_special_symbol): Adjust to section_maps type change.
3239         Allocate arm_per_objfile with new.
3240
3241 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3242
3243         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3244         with the command prefix.
3245
3246 2019-06-25  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3249         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3250
3251 2019-06-25  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3254         type.
3255         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3256         protected.
3257
3258 2019-06-25  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-winsource.c
3261         (tui_source_window_base::set_is_exec_point_at): Add check against
3262         LOA_ADDRESS.
3263
3264 2019-06-25  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-source.c (tui_set_source_content): Don't check before
3267         xfree.
3268         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3269
3270 2019-06-25  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-winsource.h (tui_update_source_window_as_is)
3273         (tui_alloc_source_buffer, tui_line_is_displayed)
3274         (tui_addr_is_displayed): Change type of win_info.
3275         * tui/tui-winsource.c (tui_update_source_window_as_is)
3276         (tui_clear_source_content, tui_show_source_line)
3277         (tui_show_source_content, tui_source_window_base::refill)
3278         (tui_source_window_base::set_is_exec_point_at)
3279         (tui_source_window_base::set_is_exec_point_at)
3280         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3281         (tui_alloc_source_buffer, tui_line_is_displayed)
3282         (tui_addr_is_displayed): Change type of win_info.  Update.
3283         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3284         (tui_source_window_base::do_make_visible_with_new_height):
3285         Update.
3286         * tui/tui-source.c (tui_set_source_content)
3287         (tui_set_source_content_nil)
3288         (tui_source_window::do_scroll_vertical): Update.
3289         * tui/tui-layout.c (show_layout): Update.
3290         * tui/tui-disasm.c (tui_set_disassem_content)
3291         (tui_disasm_window::do_scroll_vertical): Update.
3292         * tui/tui-data.h (tui_win_content): Remove.
3293         (struct tui_gen_win_info) <content, content_size>: Remove.
3294         (struct tui_source_element): Add initializers and destructor.
3295         (union tui_which_element, struct tui_win_element): Remove.
3296         (struct tui_source_window_base) <content>: New field.
3297         (struct tui_data_window): Remove destructor.
3298         (tui_alloc_content, tui_free_win_content)
3299         (tui_free_all_source_wins_content): Don't declare.
3300         * tui/tui-data.c (tui_initialize_static_data): Update.
3301         (init_content_element, tui_alloc_content): Remove.
3302         (~tui_gen_win_info): Update.
3303         (~tui_data_window, tui_free_all_source_wins_content)
3304         (tui_free_win_content, free_content, free_content_elements):
3305         Remove.
3306
3307 2019-06-25  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-winsource.h (tui_clear_source_content)
3310         (tui_erase_source_content, tui_show_source_content): Change type
3311         of win_info.
3312         * tui/tui-winsource.c (tui_clear_source_content)
3313         (tui_erase_source_content, tui_show_source_content): Change type
3314         of win_info.
3315         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3316         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3317         win_info.
3318         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3319         win_info.
3320         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3321
3322 2019-06-25  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.c (tui_clear_source_content)
3325         (tui_source_window_base::set_is_exec_point_at): Update.
3326         * tui/tui-source.c (tui_set_source_content_nil): Update.
3327         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3328         a bool.
3329         * tui/tui-data.c (init_content_element): Update.
3330
3331 2019-06-25  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3334         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3335         * tui/tui-layout.c (init_and_make_win): Update.
3336         * tui/tui.h (enum tui_win_type): Update.
3337         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3338         tui_win_is_auxillary.
3339         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3340         tui_win_is_auxillary.
3341
3342 2019-06-25  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3345         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3346         (tui_delete_data_content_windows, tui_display_all_data)
3347         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3348         Update.
3349         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3350         * tui/tui-regs.c (tui_last_regs_line_no)
3351         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3352         (tui_show_registers): Update.
3353         (tui_show_register_group): Return void.  Update.
3354         (tui_display_registers_from, tui_display_reg_element_at_line)
3355         (tui_display_registers_from_line, tui_check_register_values):
3356         Update.
3357         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3358         member.
3359         (struct tui_data_window) <regs_content>: Now a std::vector.
3360         <regs_content_count>: Remove.
3361         (tui_add_content_elements, tui_free_data_content): Don't declare.
3362         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3363         (init_content_element): Remove DATA_WIN case.  Add assert.
3364         (tui_add_content_elements): Remove.
3365         (tui_data_window): Update.
3366         (tui_free_data_content): Remove.
3367         (free_content_elements): Remove DATA_WIN case.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-data.c (tui_data_item_window): Update.
3372         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3373         * tui/tui-windata.c (tui_display_all_data)
3374         (tui_display_data_from_line): Update.
3375         (tui_check_data_values): Remove.
3376         * tui/tui-regs.c (tui_show_register_group)
3377         (tui_display_reg_element_at_line): Update.
3378         * tui/tui-hooks.c (tui_register_changed)
3379         (tui_refresh_frame_and_register_information): Call
3380         tui_check_register_values.
3381         * tui/tui-data.h (struct tui_data_window) <data_content,
3382         data_content_count, data_type>: Remove.
3383         (enum tui_data_type): Remove.
3384
3385         * tui/tui-data.c (tui_data_window::clear_detail)
3386         (~tui_data_window): Update.
3387
3388 2019-06-25  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3391         declare.
3392         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3393         Rename from tui_first_data_item_displayed.  Update.
3394         (tui_data_window::refresh_all)
3395         (tui_data_window::do_scroll_vertical): Update.
3396         * tui/tui-data.h (struct tui_data_window)
3397         <first_data_item_displayed>: Declare new method.
3398
3399 2019-06-25  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3402         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3403         contents...
3404         (tui_initialize_static_data): ...here.
3405
3406 2019-06-25  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3409         (tui_display_registers_from, tui_check_register_values): Update.
3410         (tui_display_register): Remove win_info parameter; update.
3411         (tui_get_register): Change type of parameters.
3412         * tui/tui-data.h (struct tui_data_element): Remove.
3413         (union tui_which_element) <data>: Remove.
3414         <data_window>: Change type.
3415         (struct tui_data_item_window): New.
3416         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3417         case.  Add assert.
3418         (~tui_data_item_window): New destructor.
3419         (free_content_elements): Remove DATA_ITEM_WIN case.
3420
3421 2019-06-25  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3424         Remove.
3425
3426 2019-06-25  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-data.h (struct tui_command_element): Remove.
3429         (union tui_which_element) <command>: Remove.
3430         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3431         assert.
3432         (free_content_elements): Remove CMD_WIN case.
3433
3434 2019-06-25  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-layout.c (tui_set_layout): Update.
3437         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3438         * tui/tui-data.c (layout_def): Update.
3439
3440 2019-06-25  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3443         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3444         (tui_source_window_base::set_new_height): Update.
3445         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3446         Update.
3447         (tui_set_locator_fullname, tui_set_locator_info)
3448         (tui_show_frame_info): Update.
3449         * tui/tui-source.c (tui_set_source_content)
3450         (tui_source_is_displayed): Update.
3451         * tui/tui-layout.c (show_source_disasm_command, show_data)
3452         (show_source_or_disasm_and_command): Update.
3453         * tui/tui-disasm.c (tui_set_disassem_content)
3454         (tui_get_begin_asm_address): Update.
3455         * tui/tui-data.h (struct tui_locator_element): Remove.
3456         (union tui_which_element) <locator>: Remove.
3457         (struct tui_locator_window): New.
3458         (tui_locator_win_info_ptr): Change return type.
3459         * tui/tui-data.c (_locator): Change type.
3460         (tui_locator_win_info_ptr): Change return type.
3461         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3462         (tui_alloc_content): Add assert.
3463
3464 2019-06-25  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-winsource.c
3467         (tui_exec_info_window::maybe_allocate_content): New method.
3468         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3469         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3470         (make_source_or_disasm_window): Add cast.
3471         * tui/tui-data.h (union tui_which_element) <simple_string>:
3472         Remove.
3473         (struct tui_source_info): New.
3474         (struct tui_source_window_base) <execution_info>: Change type.
3475         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3476         case, and add assert.
3477         (tui_alloc_content): Add assert.
3478
3479 2019-06-25  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3482         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3483         * tui/tui-data.c (tui_alloc_win_info): Remove.
3484
3485 2019-06-25  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3488         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3489         can_highlight.
3490
3491 2019-06-25  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3494         make_visible_with_new_height method.
3495         (tui_win_info::make_visible_with_new_height): New method.
3496         (tui_source_window_base::do_make_visible_with_new_height)
3497         (tui_data_window::do_make_visible_with_new_height)
3498         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3499         (make_visible_with_new_height): Remove.
3500         (tui_resize_all, tui_adjust_win_heights): Use
3501         make_visible_with_new_height method.
3502         * tui/tui-data.h (struct tui_win_info)
3503         <do_make_visible_with_new_height, make_visible_with_new_height>:
3504         New methods.
3505         (struct tui_source_window_base, struct tui_data_window)
3506         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3507         methods.
3508
3509 2019-06-25  Tom Tromey  <tom@tromey.com>
3510
3511         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3512         method.
3513         (update_tab_width): Call update_tab_width method.
3514         * tui/tui-data.h (struct tui_win_info)
3515         (struct tui_source_window_base) <update_tab_width>: New methods.
3516
3517 2019-06-25  Tom Tromey  <tom@tromey.com>
3518
3519         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3520         parameter.
3521         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3522         parameter.
3523         (tui_gen_win_info::make_visible): Update.
3524         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3525         parameter.
3526         * tui/tui-data.h (enum tui_box): New enum.
3527         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3528
3529 2019-06-25  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3532         init_and_make_win for EXEC_INFO_WIN.
3533         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3534         longer inline.
3535         (struct tui_win_info) <~tui_win_info>: Inline.
3536         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3537         Don't declare.
3538         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3539         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3540         Remove.
3541         (tui_initialize_static_data): Update.
3542         (~tui_gen_win_info): Handle more cleanup here.
3543         (~tui_source_window_base): Delete "execution_info".
3544         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-layout.c (make_command_window): Don't set
3549         can_highlight.
3550         (show_source_disasm_command): Call the reset method.
3551         (show_data): Don't set can_highlight.  Call the reset method.
3552         (tui_gen_win_info::reset): Rename from init_gen_win_info
3553         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3554         (show_source_or_disasm_and_command): Call the reset method.
3555         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3556         (struct tui_cmd_window): Set can_highlight.
3557
3558 2019-06-25  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3561         from make_visible.
3562         (tui_make_visible, tui_make_invisible): Rewrite.
3563         (tui_win_info::make_visible): Remove.
3564         (tui_source_window_base::make_visible): Update.
3565         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3566         method.  Moved from...
3567         (struct tui_win_info) <make_visible>: ...here.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-winsource.c
3572         (tui_source_window_base::do_scroll_horizontal): Remove direction
3573         parameter.
3574         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3575         direction parameter.
3576         * tui/tui-win.c (tui_win_info::forward_scroll)
3577         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3578         (tui_win_info::right_scroll): Update.
3579         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3580         direction parameter.
3581         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3582         direction parameter.
3583         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3584         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3585         Remove direction parameter.
3586         (struct tui_source_window_base, struct tui_source_window)
3587         (struct tui_disasm_window, struct tui_data_window)
3588         (struct tui_cmd_window): Update.
3589
3590 2019-06-25  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-winsource.h (tui_set_exec_info_content)
3593         (tui_show_exec_info_content, tui_erase_exec_info_content)
3594         (tui_clear_exec_info_content, tui_update_exec_info): Change
3595         argument to tui_source_window_base.
3596         * tui/tui-winsource.c (tui_set_exec_info_content)
3597         (tui_show_exec_info_content, tui_erase_exec_info_content)
3598         (tui_clear_exec_info_content, tui_update_exec_info): Change
3599         argument to tui_source_window_base.
3600
3601 2019-06-25  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3604         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3605
3606 2019-06-25  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3609         check.
3610
3611 2019-06-25  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3614         type to void.
3615         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3616         type to void.
3617         * tui/tui-source.c (tui_set_source_content): Update.
3618         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3619
3620 2019-06-25  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-win.c (window_name_completer, tui_set_focus)
3623         (tui_all_windows_info): Use name method.
3624         * tui/tui-data.h (struct tui_gen_win_info)
3625         (struct tui_source_window, struct tui_disasm_window)
3626         (struct tui_data_window, struct tui_cmd_window) <name>: New
3627         method.
3628         (tui_win_name): Don't declare.
3629         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3630         (tui_win_name): Remove.
3631
3632 2019-06-25  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-winsource.h (tui_update_source_window)
3635         (tui_update_source_window_as_is): Change parameter type.
3636         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3637         to be a tui_source_window_base.
3638         (tui_update_source_window_as_is): Likewise.
3639         * tui/tui-win.c (make_visible_with_new_height): Update.
3640
3641 2019-06-25  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-winsource.c (tui_erase_source_content)
3644         (tui_show_source_content, tui_show_exec_info_content)
3645         (tui_erase_exec_info_content): Use refresh_window method.
3646         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3647         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3648         from tui_refresh_win.
3649         (tui_data_window::refresh_window): New method.
3650         (tui_win_info::refresh, tui_source_window_base::refresh)
3651         (tui_refresh_all): Use refresh_window method.
3652         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3653         method.
3654         * tui/tui-regs.c (tui_display_register): Call refresh_window
3655         method.
3656         * tui/tui-layout.c (show_source_disasm_command)
3657         (show_source_or_disasm_and_command): Call refresh_window method.
3658         * tui/tui-data.h (struct tui_gen_win_info)
3659         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3660         New method.
3661
3662 2019-06-25  Tom Tromey  <tom@tromey.com>
3663
3664         * tui/tui.c (tui_rl_other_window, tui_enable)
3665         (tui_is_window_visible, tui_get_command_dimension): Update.
3666         * tui/tui-winsource.c (tui_update_source_window_as_is)
3667         (tui_clear_source_content, tui_erase_source_content)
3668         (tui_show_source_line, tui_source_window_base::refill)
3669         (tui_source_window_base::do_scroll_horizontal)
3670         (tui_source_window_base::set_is_exec_point_at)
3671         (tui_update_breakpoint_info, tui_set_exec_info_content)
3672         (tui_alloc_source_buffer, tui_line_is_displayed)
3673         (tui_addr_is_displayed): Update.
3674         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3675         (tui_check_and_display_highlight_if_needed)
3676         (tui_win_info::make_visible, tui_win_info::refresh)
3677         (tui_refresh_all): Update.
3678         * tui/tui-windata.c (tui_first_data_item_displayed)
3679         (tui_delete_data_content_windows, tui_erase_data_content)
3680         (tui_display_all_data, tui_data_window::refresh_all)
3681         (tui_check_data_values): Update.
3682         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3683         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3684         (tui_win_info::backward_scroll, tui_refresh_all_win)
3685         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3686         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3687         (tui_source_window_base::set_new_height)
3688         (tui_data_window::set_new_height)
3689         (make_invisible_and_set_new_height)
3690         (make_visible_with_new_height, new_height_ok)
3691         (parse_scrolling_args): Update.
3692         * tui/tui-stack.c (tui_show_frame_info): Update.
3693         * tui/tui-source.c (tui_set_source_content)
3694         (tui_set_source_content_nil, tui_source_is_displayed)
3695         (tui_source_window::do_scroll_vertical): Update.
3696         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3697         (tui_display_registers_from, tui_display_reg_element_at_line)
3698         (tui_check_register_values, tui_reg_command): Update.
3699         * tui/tui-layout.c (tui_default_win_height)
3700         (show_source_disasm_command, show_data, init_and_make_win)
3701         (show_source_or_disasm_and_command): Update.
3702         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3703         (tui_redisplay_readline, tui_mld_flush)
3704         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3705         (tui_getc): Update.
3706         * tui/tui-disasm.c (tui_set_disassem_content)
3707         (tui_disasm_window::do_scroll_vertical): Update.
3708         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3709         Now virtual.
3710         (struct tui_win_info): Derive from tui_gen_win_info.
3711         <~tui_win_info>: Mark as override.
3712         <generic>: Remove member.
3713         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3714         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3715         (~tui_data_window, ~tui_win_info)
3716         (tui_free_all_source_wins_content): Update.
3717         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3718
3719 2019-06-25  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-layout.c (init_and_make_win): Use new.
3722         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3723         destructor, initializers.
3724         (tui_alloc_generic_win_info): Don't declare.
3725         * tui/tui-data.c (_locator): Add argument to constructor.
3726         (source_win, disasm_win): New globals.
3727         (exec_info): Remove.
3728         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3729         Update.
3730         (tui_alloc_generic_win_info): Remove.
3731         (init_content_element): Use new.
3732         (tui_win_info::tui_win_info): Update.
3733         (free_content_elements) <case DATA_WIN>: Use delete.
3734
3735 2019-06-25  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3738         * tui/tui-windata.c (tui_first_data_item_displayed)
3739         (tui_delete_data_content_windows): Update.
3740         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3741         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3742         (tui_display_registers_from, tui_check_register_values): Update.
3743         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3744         pointer.
3745         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3746         window.
3747         (tui_free_data_content): Update.
3748         (free_content_elements) <case DATA_WIN>: Free the window.
3749
3750 2019-06-25  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3753         Update.
3754         * tui/tui-layout.c (make_command_window)
3755         (show_source_disasm_command, show_data, init_and_make_win)
3756         (show_source_or_disasm_and_command): Update.
3757         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3758         method.
3759         <can_highight, is_highlighted>: Now bool.
3760         (tui_set_win_highlight): Don't declare.
3761         * tui/tui-data.c (tui_set_win_highlight): Remove.
3762
3763 2019-06-25  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-wingeneral.c (make_visible): Remove check of window
3766         type.
3767
3768 2019-06-25  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui-win.c (tui_win_info::max_height)
3771         (tui_cmd_window::max_height): New methods.
3772         (new_height_ok): Call max_height.
3773         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3774         <max_height>: New method.
3775
3776 2019-06-25  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-win.c (tui_source_window_base::set_new_height)
3779         (tui_data_window::set_new_height): New methods.
3780         (make_invisible_and_set_new_height): Call set_new_height method.
3781         * tui/tui-data.h (struct tui_win_info)
3782         (struct tui_source_window_base, struct tui_data_window)
3783         <set_new_height>: New method.
3784
3785 2019-06-25  Tom Tromey  <tom@tromey.com>
3786
3787         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3788         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3789         tui_refresh_data_win.
3790         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3791         method.
3792         (tui_refresh_all_win): Call the refresh_all method.
3793         (tui_set_focus): Likewise.
3794         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3795         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3796         Likewise.
3797
3798 2019-06-25  Tom Tromey  <tom@tromey.com>
3799
3800         * tui/tui-winsource.h (tui_refill_source_window)
3801         (tui_set_is_exec_point_at): Don't declare.
3802         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3803         (tui_source_window_base::refill): Rename from
3804         tui_refill_source_window.
3805         (tui_source_window_base::do_scroll_horizontal): Update.
3806         (tui_source_window_base::set_is_exec_point_at): Rename from
3807         tui_set_is_exec_point_at.
3808         (tui_update_all_breakpoint_info): Update.
3809         * tui/tui-stack.c (tui_show_frame_info): Update.
3810         * tui/tui-layout.c (show_data): Add cast.
3811         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3812         * tui/tui-data.h (struct tui_source_window_base) <refill,
3813         set_is_exec_point_at>: New methods.
3814         (tui_source_windows, tui_add_to_source_windows): Update types.
3815         (tui_add_to_source_windows): Remove redundant declaration.
3816         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3817         (tui_source_windows): Change return type.
3818         (tui_clear_source_windows_detail): Update.
3819         (tui_add_to_source_windows): Change type of parameter.
3820         (tui_free_all_source_wins_content): Update.
3821
3822 2019-06-25  Tom Tromey  <tom@tromey.com>
3823
3824         * tui/tui-wingeneral.c (tui_win_info::refresh)
3825         (tui_source_window_base::refresh): New methods.
3826         (tui_refresh_all): Call the refresh method.
3827         * tui/tui-data.h (struct tui_win_info)
3828         (struct tui_source_window_base) <refresh>: New method.
3829
3830 2019-06-25  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui.h (tui_is_window_visible): Return bool.
3833         * tui/tui.c (tui_is_window_visible): Return bool.
3834         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3835         (tui_make_visible, tui_make_invisible)
3836         (tui_win_info::make_visible)
3837         (tui_source_window_base::make_visible, make_all_visible)
3838         (tui_make_all_visible, tui_make_all_invisible): Update.
3839         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3840         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3841         bool.
3842         (struct tui_win_info, struct tui_source_window_base)
3843         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3844         * tui/tui-data.c (tui_init_generic_part): Update.
3845
3846 2019-06-25  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3849         (tui_source_window_base::make_visible): New methods.
3850         (make_all_visible): Make method call.
3851         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3852         (struct tui_source_window_base, struct tui_cmd_window): Override
3853         make_visible.
3854         (tui_win_is_source_type): Don't declare.
3855         * tui/tui-data.c (tui_win_is_source_type): Remove.
3856
3857 2019-06-25  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3860         NULL check.
3861
3862 2019-06-25  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3865         Inline constructor.  Add initializers for members.
3866         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3867         constructors; now inline in class.
3868
3869 2019-06-25  Tom Tromey  <tom@tromey.com>
3870
3871         * tui/tui-regs.c (tui_show_registers): Update.
3872         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3873         bool.
3874         * tui/tui-data.c (tui_data_window::clear_detail)
3875         (tui_data_window): Update.
3876
3877 2019-06-25  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-windata.c (tui_display_all_data)
3880         (tui_display_data_from_line, tui_display_data_from)
3881         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3882         Update.
3883         * tui/tui-regs.c (tui_last_regs_line_no)
3884         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3885         (tui_show_registers, tui_show_register_group)
3886         (tui_display_registers_from, tui_display_reg_element_at_line)
3887         (tui_display_registers_from_line, tui_check_register_values)
3888         (tui_reg_next, tui_reg_prev): Update.
3889         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3890         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3891         tui_data_window.
3892         (struct tui_win_info) <detail>: Remove.  Add new fields from
3893         tui_data_info.
3894         (TUI_DATA_WIN): Add cast.
3895         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3896         (~tui_data_window): Simplify.
3897
3898 2019-06-25  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-layout.c (show_source_disasm_command)
3901         (show_source_or_disasm_and_command): Update.
3902         * tui/tui-io.c (update_cmdwin_start_line)
3903         (tui_redisplay_readline): Update.
3904         * tui/tui-data.h (struct tui_command_info): Remove.
3905         (struct tui_win_info) <detail>: Remove command_info member.
3906         (struct tui_data_window) <start_line>: New member, from
3907         tui_command_info.
3908         (TUI_CMD_WIN): Add casts.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-winsource.c (tui_update_source_window)
3913         (tui_refill_source_window)
3914         (tui_source_window_base::do_scroll_horizontal)
3915         (tui_update_breakpoint_info, tui_set_exec_info_content)
3916         (tui_show_exec_info_content, tui_erase_exec_info_content)
3917         (tui_clear_exec_info_content): Update.
3918         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3919         Update.
3920         * tui/tui-win.c (make_invisible_and_set_new_height)
3921         (make_visible_with_new_height): Update.
3922         * tui/tui-source.c (tui_set_source_content)
3923         (tui_show_symtab_source): Update.
3924         * tui/tui-layout.c (extract_display_start_addr)
3925         (show_source_disasm_command, show_data)
3926         (make_source_or_disasm_window)
3927         (show_source_or_disasm_and_command): Update.
3928         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3929         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3930         "gdbarch".
3931         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3932         to tui_source_window_base.
3933         (struct tui_win_info) <detail>: Remove source_info member.
3934         (struct tui_source_window_base) <has_locator>: Inline.
3935         Move contents from tui_source_info; rename has_locator member to
3936         m_has_locator.
3937         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3938         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3939         header file.
3940         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3941         Simplify.
3942         (tui_free_all_source_wins_content): Cast to
3943         tui_source_window_base.
3944
3945 2019-06-25  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-win.c (make_invisible_and_set_new_height)
3948         (make_visible_with_new_height): Call has_locator method.
3949         * tui/tui-layout.c (show_source_disasm_command, show_data)
3950         (show_source_or_disasm_and_command): Update for bool change.
3951         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3952         (tui_win_info) <has_locator>: New method.
3953         (struct tui_source_window_base) <has_locator>: New method.
3954         (tui_win_has_locator): Don't declare.
3955         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3956         from tui_win_has_locator.
3957         (tui_source_window_base): Use false, not FALSE.
3958
3959 2019-06-25  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3962         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3963         clear_detail method directly.
3964         (tui_clear_win_detail): Remove.
3965
3966 2019-06-25  Tom Tromey  <tom@tromey.com>
3967
3968         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3969         "this", not TUI_DISASM_WIN.
3970
3971 2019-06-25  Tom Tromey  <tom@tromey.com>
3972
3973         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3974         declare.
3975         * tui/tui-winsource.c
3976         (tui_source_window_base::do_scroll_horizontal): Rename from
3977         tui_horizontal_source_scroll.
3978         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3979         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3980         from tui_vertical_data_scroll.
3981         * tui/tui-win.h (tui_scroll): Don't declare.
3982         * tui/tui-win.c (tui_win_info::forward_scroll)
3983         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3984         (tui_win_info::right_scroll): Rename and update.
3985         (tui_scroll_forward_command, tui_scroll_backward_command)
3986         (tui_scroll_left_command, tui_scroll_right_command): Update.
3987         (tui_scroll): Remove.
3988         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3989         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3990         from tui_vertical_source_scroll.
3991         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3992         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3993         from tui_vertical_disassem_scroll.
3994         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3995         do_scroll_horizontal>: New methods.
3996         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3997         Likewise.
3998         (struct tui_source_window_base): Add do_scroll_horizontal.
3999         (struct tui_source_window, struct tui_disasm_window): Add
4000         do_scroll_vertical.
4001         (struct tui_data_window, struct tui_cmd_window): Add
4002         do_scroll_horizontal and do_scroll_vertical.
4003         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4004
4005 2019-06-25  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-data.h (struct tui_source_window_base): New struct.
4008         (struct tui_source_window): Derive from tui_source_window_base.
4009         (struct tui_disasm_window): New struct.
4010         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4011         from tui_source_window::clear_detail.
4012         (tui_source_window_base): Rename from tui_source_window.
4013         (~tui_source_window_base): Rename from ~tui_source_window.
4014         (tui_alloc_win_info): Create a tui_disasm_window.
4015
4016 2019-06-25  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-data.h (struct tui_source_window)
4019         (struct tui_data_window): Declare destructors.
4020         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4021         destructors.
4022         (tui_win_info): Simplify.
4023
4024 2019-06-25  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-winsource.c (tui_display_main)
4027         (tui_update_source_windows_with_addr)
4028         (tui_update_all_breakpoint_info): Update.
4029         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4030         (new_height_ok, parse_scrolling_args): Update.
4031         * tui/tui-stack.c (tui_show_frame_info): Update.
4032         * tui/tui-data.h (struct tui_list): Remove.
4033         (tui_source_windows): Return a reference to a std::vector.
4034         * tui/tui-data.c (source_windows): Now a std::vector.
4035         (tui_source_windows): Change return type.
4036         (tui_clear_source_windows): Rewrite.
4037         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4038         (tui_free_all_source_wins_content): Rewrite.
4039
4040 2019-06-25  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4043         (struct tui_data_window, struct tui_cmd_window): Declare
4044         clear_detail method.
4045         * tui/tui-data.c (tui_source_window::clear_detail)
4046         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4047         methods.
4048         (tui_clear_win_detail): Simplify.
4049
4050 2019-06-25  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-layout.c (make_source_window, make_disasm_window)
4053         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4054         Return the new window.
4055         (show_source_disasm_command, show_data)
4056         (show_source_or_disasm_and_command): Update.
4057
4058 2019-06-25  Tom Tromey  <tom@tromey.com>
4059
4060         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4061         parameter.  Return the new window.
4062         (show_source_disasm_command): Update and remove NULL check.
4063         (show_source_or_disasm_and_command): Update.
4064
4065 2019-06-25  Tom Tromey  <tom@tromey.com>
4066
4067         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4068
4069 2019-06-25  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-data.h (struct tui_win_info): Make constructor
4072         protected.  Make destructor virtual.  Add initializers.
4073         (tui_source_window, tui_data_window, tui_cmd_window): New
4074         classes.
4075         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4076         constructor.  Add "type" parameter.
4077         (tui_source_window, tui_data_window, tui_cmd_window): New
4078         constructors.
4079         (tui_alloc_win_info): Instantiate the appropriate subclass.
4080
4081 2019-06-25  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-win.c (tui_resize_all): Use delete.
4084         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4085         destructor.
4086         (tui_free_window): Don't declare.
4087         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4088         Update.
4089
4090 2019-06-25  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-data.h (struct tui_win_info): Add constructor.
4093         * tui/tui-data.c (tui_alloc_win_info): Use new.
4094         (tui_free_window): Use delete.
4095
4096 2019-06-22  Tom Tromey  <tom@tromey.com>
4097
4098         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4099         declare.
4100         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4101
4102 2019-06-22  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4105         declare.
4106         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4107
4108 2019-06-22  Tom de Vries  <tdevries@suse.de>
4109
4110         * dwarf2read.c (create_addrmap_from_aranges)
4111         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4112         instead of '%zu'.
4113
4114 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4115
4116         * dwarf2read.h (dwarf2_section_info_def): Remove.
4117         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4118         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4119         std::vector<dwarf2_section_info>.
4120         (struct dwo_file) <~dwo_file>: Remove.
4121         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4122         types field.
4123         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4124         (dwarf2_read_debug_names): Likewise.
4125         (create_debug_types_hash_table): Change parameter type to
4126         array_view, adjust code accordingly.
4127         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4128         (partial_die_info::fixup): Likewise.
4129         (determine_prefix): Likewise.
4130         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4131
4132 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4133
4134         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4135         gdb_bfd_ref_ptr.
4136         <~dwo_file>: Remove call to gdb_bfd_unref.
4137         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4138         gdb_bfd_ref_ptr::get.
4139
4140 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4141
4142         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4143         type to htab_up.
4144         * dwarf2read.c (struct dwo_file): Initialize fields.
4145         <~dwo_file>: New.
4146         (free_dwo_file): Remove, move content to ~dwo_file.
4147         (struct dwo_file_deleter): Remove.
4148         (dwo_file_up>: Remove custom deleter.
4149         (free_dwo_files): Remove.
4150         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4151         dwo_files.
4152         (process_skeletonless_type_units): Call unique_ptr::get.
4153         (allocate_dwo_file_hash_table): Add deleter to created hash
4154         table.  Change return type to htab_up.
4155         (lookup_dwo_file_slot): Don't memset dwo_file, call
4156         unique_ptr::get.
4157         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4158         (create_dwo_unit_in_dwp_v2): Likewise.
4159         (open_and_init_dwo_file): Likewise.
4160         (free_dwo_file_from_slot): Remove.
4161
4162 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4163
4164         * dwarf2read.h (struct dwarf2_section_info) <readin,
4165         is_virtual>: Change type to bool.
4166         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4167         true instead of 1.
4168
4169 2019-06-19  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-data.h (tui_init_content_element): Don't declare.
4172
4173 2019-06-19  Tom Tromey  <tom@tromey.com>
4174
4175         * tui/tui-data.h (tui_init_win_info): Don't declare.
4176
4177 2019-06-19  Tom de Vries  <tdevries@suse.de>
4178
4179         * dwarf2read.h (abstract_to_concrete): Change type to
4180         std::unordered_map<sect_offset, std::vector<sect_offset>,
4181         gdb::hash_enum<sect_offset>>.
4182
4183 2019-06-19  Tom Tromey  <tromey@adacore.com>
4184
4185         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4186         EVAL_AVOID_SIDE_EFFECTS specially.
4187
4188 2019-06-19  Tom Tromey  <tromey@adacore.com>
4189
4190         * source-cache.c (highlighter): New global.
4191         (source_cache::get_source_lines): Create a highlighter on demand.
4192
4193 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * defs.h (deprecated_interactive_hook): Delete declaration.
4196         * interps.c (clear_interpreter_hooks): Remove use of
4197         deprecated_interactive_hook.
4198         * top.c (deprecated_interactive_hook): Delete definition.
4199         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4200
4201 2019-06-18  Tom de Vries  <tdevries@suse.de>
4202
4203         PR gdb/24515
4204         * dwarf2read.h (abstract_to_concrete): Change type from
4205         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4206         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4207         * dwarf2read.c (read_variable): Update.
4208         (dwarf2_fetch_die_loc_sect_off): Update.
4209
4210 2019-06-17  Tom de Vries  <tdevries@suse.de>
4211
4212         PR gdb/24617
4213         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4214         accessing parent[parent_len - 1].
4215
4216 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4217
4218         PR gdb/24364
4219         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4220         call dtrace_process_dof with NULL dof.
4221
4222 2019-06-16  Tom de Vries  <tdevries@suse.de>
4223
4224         PR gdb/24445
4225         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4226
4227 2019-06-16  Tom Tromey  <tom@tromey.com>
4228
4229         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4230         (make_all_visible): Use address of member.
4231
4232 2019-06-16  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4235         (tui_free_window, free_content, free_content_elements): Remove
4236         unnecessary cast.
4237         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4238         cast.
4239         * tui/tui-regs.c (tui_show_register_group)
4240         (tui_display_registers_from, tui_display_reg_element_at_line):
4241         Remove unnecessary cast.
4242
4243 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * linux-nat.c (normal_mask): Delete.
4246         (_initialize_linux_nat): Don't initialise normal_mask.
4247
4248 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4249
4250         PR gdb/24445
4251         * dwarf-index-write.h (write_psymtabs_to_index): Add
4252         dwz_basename parameter.
4253         * dwarf-index-write.c (write_gdbindex): Move file writing to
4254         write_gdbindex_1.  Change return type void.
4255         (assert_file_size): Move up, remove filename parameter.
4256         (write_gdbindex_1): New function.
4257         (write_debug_names): Change return type to void, call
4258         assert_file_size.
4259         (struct index_wip_file): New struct.
4260         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4261         file logic to index_wip_file.  Write index for dwz file if
4262         needed.
4263         (save_gdb_index_command): Pass basename of dwz file, if present.
4264         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4265         build-id of dwz file, if present.
4266         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4267         (dwarf2_get_dwz_file): Likewise.
4268         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4269         (dwarf2_get_dwz_file): Likewise.
4270
4271 2019-06-16  Tom Tromey  <tom@tromey.com>
4272
4273         * coffread.c (process_coff_symbol): Use xstrdup.
4274         * value.c (create_internalvar): Use xstrdup.
4275
4276 2019-06-16  Tom Tromey  <tom@tromey.com>
4277
4278         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4279         * breakpoint.c (stopin_command, stopat_command)
4280         (until_break_command, decode_location_default): Remove unnecessary
4281         cast.
4282         * utils.c (subset_compare): Remove unnecessary cast.
4283         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4284         cast.
4285         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4286         cast.
4287         * infcmd.c (path_command): Remove unnecessary cast.
4288         * coffread.c (decode_type): Remove unnecessary cast.
4289         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4290         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4291         * tui/tui-stack.c (tui_show_locator_content)
4292         (tui_show_frame_info): Remove unnecessary cast.
4293         * tui/tui-win.c (tui_scroll_forward_command)
4294         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4295         (parse_scrolling_args): Remove unnecessary cast.
4296         * tui/tui-data.c (init_win_info, tui_del_window)
4297         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4298         (free_content_elements): Remove unnecessary cast.
4299         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4300         unnecessary cast.
4301         * tui/tui-source.c (tui_set_source_content)
4302         (tui_vertical_source_scroll): Remove unnecessary cast.
4303         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4304         cast.
4305         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4306         * tui/tui-regs.c (tui_display_registers_from)
4307         (tui_display_register): Remove unnecessary cast.
4308         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4309         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4310         (make_visible): Remove unnecessary cast.
4311         * tui/tui-winsource.c (tui_erase_source_content)
4312         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4313         unnecessary cast.
4314         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4315         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4316         * stabsread.c (read_type, read_array_type, read_range_type):
4317         Remove unnecessary cast.
4318         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4319         (parse_symbol, parse_type, upgrade_type, parse_external)
4320         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4321         unnecessary cast.
4322         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4323
4324 2019-06-16  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-data.c (tui_alloc_generic_win_info)
4327         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4328         checks.
4329
4330 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4331             Andrew Burgess  <andrew.burgess@embecosm.com>
4332
4333         * f-typeprint.c (f_print_type): Don't return early for not
4334         associated or not allocated types.
4335         (f_type_print_varspec_suffix): Add print_rank parameter and print
4336         ranks of array types in case they dangling.
4337         (f_type_print_base): Add print_rank parameter.
4338
4339 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4340
4341         * NEWS: Mention new MI commands.
4342         * break-catch-throw.c (enum exception_event_kind): Move to
4343         breakpoint.h.
4344         (print_mention_exception_catchpoint): Output text as a single
4345         message.
4346         (catch_exception_command_1): Rename to...
4347         (catch_exception_event): ...this, make non-static, update header
4348         command, and change some parameter types.
4349         (catch_catch_command): Update for changes to
4350         catch_exception_command_1.
4351         (catch_throw_command): Likewise.
4352         (catch_rethrow_command): Likewise.
4353         * breakpoint.c (enum exception_event_kind): Delete.
4354         * breakpoint.h (enum exception_event_kind): Moved here from
4355         break-catch-throw.c.
4356         (catch_exception_event): Declare.
4357         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4358         (mi_cmd_catch_throw): New function.
4359         (mi_cmd_catch_rethrow): New function.
4360         (mi_cmd_catch_catch): New function.
4361         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4362         'catch-catch' entries.
4363         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4364         (mi_cmd_catch_rethrow): Declare.
4365         (mi_cmd_catch_catch): Declare.
4366
4367 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * annotate.c (annotate_source_line): Change return type to void,
4370         update implementation to match.
4371         * annotate.h (annotate_source_line): Change return type to void,
4372         update header comment.
4373         * stack.c (print_frame_info): Don't change what frame information
4374         is printed based on whether annotations are on or not.
4375
4376 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4379         (annotate_source): Make static.
4380         (annotate_source_line): Moved from source.c and renamed from
4381         identify_source_line.  Update the return type.
4382         * annotate.h (annotate_source): Delete declaration.
4383         (annotate_source_line): Declaration moved from source.h, and
4384         renamed from identify_source_line.  Return type updated.
4385         * source.c (identify_source_line): Moved to annotate.c and renamed
4386         to annotate_source_line.
4387         (info_line_command): Remove check of annotation_level.
4388         * source.h (identify_source_line): Move declaration to annotate.h
4389         and rename to annotate_source_line.
4390         * stack.c: Add 'annotate.h' include.
4391         (print_frame_info): Remove check of annotation_level before
4392         calling annotate_source_line.
4393
4394 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * source-cache.c (source_cache::get_plain_source_lines): Use
4397         open_source_file_with_line_charpos instead of just
4398         open_source_file, remove call to find_source_lines.
4399         (source_cache::get_source_lines): Likewise.
4400         * source.c (find_source_lines): Make static.
4401         (get_filename_and_charpos): Renamed into...
4402         (open_source_file_with_line_charpos): ..this along with changes to
4403         return a scoped_fd, and some other minor clean ups.
4404         (identify_source_line): Use open_source_file_with_line_charpos.
4405         (search_command_helper): Use open_source_file_with_line_charpos
4406         instead of just open_source_file, remove call to
4407         find_source_lines.
4408         * source.h (open_source_file_with_line_charpos): Declare new
4409         function.
4410         (find_source_lines): Delete declaration.
4411
4412 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4413
4414         * source.c (get_filename_and_charpos): Remove fullname
4415         parameter.
4416         (identify_source_line): Update call to get_filename_and_charpos.
4417
4418 2019-06-14  Tom Tromey  <tromey@adacore.com>
4419
4420         PR gdb/24502:
4421         * ui-style.h (skip_ansi_escape): Update comment.
4422         * ui-file.h (class no_terminal_escape_file): New class.
4423         * ui-file.c (no_terminal_escape_file::write)
4424         (no_terminal_escape_file::puts): New methods.
4425         * cli/cli-logging.c (handle_redirections): Use
4426         no_terminal_escape_file.
4427
4428 2019-06-14  Tom Tromey  <tromey@adacore.com>
4429
4430         * NEWS: Move convenience variable news above Python news.
4431
4432 2019-06-14  Tom Tromey  <tom@tromey.com>
4433
4434         * gnulib: Move directory to top-level.
4435         * configure.ac: Don't configure gnulib.
4436         * configure: Rebuild.
4437         * common/common-defs.h: Use new path to gnulib.
4438         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4439         (GNULIB_H): Remove.
4440         (INCGNU): Look in new gnulib location.
4441         (HFILES_NO_SRCDIR): Remove gnulib files.
4442         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4443         (generated_files): Remove GNULIB_H.
4444         ($(LIBGNU), all-lib): Remove targets.
4445         (distclean): Don't mention GNULIB_BUILDDIR.
4446         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4447
4448 2019-06-14  Tom Tromey  <tromey@adacore.com>
4449
4450         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4451         Warn if symbol file does not provide any symbols.
4452
4453 2019-06-14  Tom Tromey  <tromey@adacore.com>
4454
4455         * source.c (find_and_open_source): Respect basenames_may_differ.
4456
4457 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4458
4459         * annotate.c (annotate_breakpoints_invalid): Make use of
4460         scoped_restore_terminal_state.
4461         (annotate_frames_invalid): Likewise.
4462
4463 2019-06-14  Tom Tromey  <tromey@adacore.com>
4464
4465         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4466         allow assignment to an internalvar.
4467
4468 2019-06-14  Tom Tromey  <tromey@adacore.com>
4469
4470         * ada-lex.l: Allow "_" in attribute names.
4471
4472 2019-06-14  Tom Tromey  <tromey@adacore.com>
4473
4474         PR gdb/24653:
4475         * regcache.c (registers_changed): Don't call alloca.
4476         * top.c (execute_command): Don't call alloca.
4477
4478 2019-06-13  Pedro Alves  <palves@redhat.com>
4479
4480         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4481         'expression'.  When parsing an expression, error out if there's
4482         junk after "unlimited".
4483         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4484         (do_set_command): Adjust calls to is_unlimited_literal.
4485
4486 2019-06-13  Pedro Alves  <palves@redhat.com>
4487
4488         * compile/compile.c (make_compile_options_def_group): Add braces
4489         around array_view initializer.
4490         * thread.c (make_thread_apply_all_options_def_group)
4491         (make_thread_apply_all_options_def_group): Likewise.
4492
4493 2019-06-13  Pedro Alves  <palves@redhat.com>
4494
4495         * NEWS (New commands): Mention "maint test-options
4496         require-delimiter", "maint test-options unknown-is-error", "maint
4497         test-options unknown-is-operand" and "maint show
4498         test-options-completion-result".
4499         (New command options, command completion): New section.
4500         (Completion improvements): New section.
4501         Mention that you can abbreviate "unlimited".
4502
4503 2019-06-13  Pedro Alves  <palves@redhat.com>
4504
4505         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4506         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4507         * unittests/cli-utils-selftests.c (test_parse_flags)
4508         (test_parse_flags_qcs): Delete.
4509         (test_cli_utils): Don't call deleted functions.
4510
4511 2019-06-13  Pedro Alves  <palves@redhat.com>
4512
4513         * thread.c: Include "cli/cli-option.h".
4514         (tp_array_compar_ascending): Global.
4515         (tp_array_compar): Delete function.
4516         (tp_array_compar_ascending, tp_array_compar_descending): New
4517         functions.
4518         (ascending_option_def, qcs_flag_option_def)
4519         (thr_qcs_flags_option_defs)
4520         (make_thread_apply_all_options_def_group)
4521         (make_thread_apply_options_def_group): New.
4522         (thread_apply_all_command): Use gdb::option::process_options.
4523         (thread_apply_command_completer)
4524         (thread_apply_all_command_completer): New.
4525         (thread_apply_command): Use gdb::option::process_options.
4526         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4527         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4528         to generate help text of "thread apply".  Adjust "taas"'s help.
4529         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4530         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4531
4532 2019-06-13  Pedro Alves  <palves@redhat.com>
4533
4534         * thread.c (thread_apply_command): Check for invalid TID with
4535         isdigit instead of !isalpha.
4536
4537 2019-06-13  Pedro Alves  <palves@redhat.com>
4538
4539         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4540         (validate_flags_qcs): New.
4541         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4542         (validate_flags_qcs): Declare.
4543         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4544         (make_frame_apply_options_def_group): New.
4545         (frame_apply_command_count): Process options with
4546         gdb::option::process_options.
4547         (frame_apply_completer): New.
4548         (frame_apply_level_completer, frame_apply_all_completer)
4549         (frame_apply_completer): New.
4550         (_initialize_stack): Update help of "frame apply", "frame apply
4551         level", "frame apply all" and "faas" to mention supported options
4552         and install command completers.
4553         * stack.h (frame_apply_all_completer): Declare.
4554         * thread.c: Include "stack.h".
4555         (tfaas_command): Add "--".
4556         (_initialize_thread): Update help "tfaas" to mention supported
4557         options and install command completer.
4558
4559 2019-06-13  Pedro Alves  <palves@redhat.com>
4560
4561         * completer.c (complete_nested_command_line): New.
4562         (gdb_completion_word_break_characters_throw): Add assertion.
4563         * completer.h (complete_nested_command_line): Declare.
4564
4565 2019-06-13  Pedro Alves  <palves@redhat.com>
4566
4567         * stack.c (parse_backtrace_qualifiers): New.
4568         (backtrace_command): Use it.
4569         (backtrace_command_completer): Complete on qualifiers.
4570
4571 2019-06-13  Pedro Alves  <palves@redhat.com>
4572
4573         * frame.c: Include "cli/cli-option.h.
4574         (user_set_backtrace_options): New.
4575         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4576         Delete.
4577         (get_prev_frame): Adjust.
4578         (boolean_option_def, uinteger_option_def)
4579         (set_backtrace_option_defs): New.
4580         (_initialize_frame): Adjust and use
4581         gdb::option::add_setshow_cmds_for_options to install "set
4582         backtrace past-main" and "set backtrace past-entry".
4583         * frame.h: Include "cli/cli-option.h".
4584         (struct frame_print_options): Forward declare.
4585         (print_frame_arguments_all, print_frame_arguments_scalars)
4586         (print_frame_arguments_none): Declare.
4587         (print_entry_values): Delete declaration.
4588         (struct frame_print_options, user_frame_print_options): New.
4589         (struct set_backtrace_options): New.
4590         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4591         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4592         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4593         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4594         (list_args_or_locals): Add frame_print_options parameter.
4595         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4596         * python/py-framefilter.c (enumerate_args): Pass down
4597         USER_FRAME_PRINT_OPTIONS.
4598         * stack.c: Include "cli/cli-option.h".
4599         (print_frame_arguments_all, print_frame_arguments_scalars)
4600         (print_frame_arguments_none): Declare.
4601         (print_raw_frame_arguments, print_entry_values): Delete.
4602         (user_frame_print_options): New.
4603         (boolean_option_def, enum_option_def, frame_print_option_defs):
4604         New.
4605         (struct backtrace_cmd_options): New.
4606         (bt_flag_option_def): New.
4607         (backtrace_command_option_defs): New.
4608         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4609         (print_frame_arg, read_frame_arg, print_frame_args)
4610         (print_frame_info, print_frame): Add frame_print_options parameter
4611         and use it.
4612         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4613         (backtrace_command_1): Add frame_print_options and
4614         backtrace_cmd_options parameters and use them.
4615         (make_backtrace_options_def_group): New.
4616         (backtrace_command): Process command options with
4617         gdb::option::process_options.
4618         (backtrace_command_completer): New.
4619         (_initialize_stack): Extend "backtrace"'s help to mention
4620         supported options.  Install completer for "backtrace".
4621         Install some settings commands with add_setshow_cmds_for_options.
4622
4623 2019-06-13  Pedro Alves  <palves@redhat.com>
4624
4625         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4626         and that "set/show print raw frame-arguments" are now deprecated.
4627
4628         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4629         command.
4630         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4631         * stack.c (_initialize_stack): Install "set/show print
4632         raw-frame-arguments", and deprecate "set/show print raw
4633         frame-arguments".
4634         * valprint.c (_initialize_valprint): Deprecate "set/show print
4635         raw".
4636
4637 2019-06-13  Pedro Alves  <palves@redhat.com>
4638
4639         * compile/compile.c (struct compile_options): New.
4640         (compile_flag_option_def, compile_command_option_defs)
4641         (make_compile_options_def_group): New.
4642         (compile_file_command): Handle options with
4643         gdb::option::process_options.
4644         (compile_file_command_completer): New function.
4645         (compile_code_command): Handle options with
4646         gdb::option::process_options.
4647         (compile_code_command_completer): New function.
4648         (_initialize_compiler): Install completers for "compile code" and
4649         "compile file".  Mention available options in "compile code" and
4650         "compile code"'s help.
4651         * completer.c (advance_to_completion_word): New, factored out from
4652         ...
4653         (advance_to_expression_complete_word_point): ... this.
4654         (advance_to_filename_complete_word_point): New.
4655         * completer.h (advance_to_filename_complete_word_point): New
4656         declaration.
4657
4658 2019-06-13  Pedro Alves  <palves@redhat.com>
4659
4660         * compile/compile.c: Include "cli/cli-option.h".
4661         (compile_print_value): Scope data pointer is now a
4662         value_print_options pointer; adjust.
4663         (compile_print_command): Process options.  Scope data pointer is
4664         now a value_print_options pointer; adjust.
4665         (_initialize_compile): Update "compile print"'s help to include
4666         supported options.  Install a completer for "compile print".
4667         * cp-valprint.c (show_vtblprint, show_objectprint)
4668         (show_static_field_print): Delete.
4669         (_initialize_cp_valprint): Don't install "set print
4670         static-members", "set print vtbl", "set print object" here.
4671         * printcmd.c: Include "cli/cli-option.h" and
4672         "common/gdb_optional.h".
4673         (print_command_parse_format): Rework to fill in a
4674         value_print_options instead of a format_data.
4675         (print_value): Change parameter type from format_data pointer to
4676         value_print_options reference.  Adjust.
4677         (print_command_1): Process options.  Adjust to pass down a
4678         value_print_options.
4679         (print_command_completer): New.
4680         (_initialize_printcmd): Install print_command_completer as
4681         handle_brkchars completer for the "print" command.  Update
4682         "print"'s help to include supported options.
4683         * valprint.c: Include "cli/cli-option.h".
4684         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4685         here from cp-valprint.c.
4686         (boolean_option_def, uinteger_option_def)
4687         (value_print_option_defs, make_value_print_options_def_group):
4688         New.  Use gdb::option::add_setshow_cmds_for_options to install
4689         "set print elements", "set print null-stop", "set print repeats",
4690         "set print pretty", "set print union", "set print array", "set
4691         print address", "set print symbol", "set print array-indexes".
4692         * valprint.h: Include <string> and "cli/cli-option.h".
4693         (make_value_print_options_def_group): Declare.
4694         (print_value): Change parameter type from format_data pointer to
4695         value_print_options reference.
4696         (print_command_completer): Declare.
4697
4698 2019-06-13  Pedro Alves  <palves@redhat.com>
4699
4700         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4701         (COMMON_SFILES): Add maint-test-settings.c.
4702         * cli/cli-decode.c (boolean_enums): New global, factored out from
4703         ...
4704         (add_setshow_boolean_cmd): ... here.
4705         * cli/cli-decode.h (boolean_enums): Declare.
4706         * cli/cli-option.c: New file.
4707         * cli/cli-option.h: New file.
4708         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4709         factored out from ...
4710         (parse_cli_boolean_value(const char *)): ... this.
4711         (is_unlimited_literal): Change parameter type to pointer to
4712         pointer.  Adjust and advance ARG pointer.
4713         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4714         (parse_cli_var_enum): New, factored out from ...
4715         (do_set_command): ... this.  Adjust.
4716         * cli/cli-setshow.h (parse_cli_boolean_value)
4717         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4718         (parse_cli_var_enum): Declare.
4719         * cli/cli-utils.c: Include "cli/cli-option.h".
4720         (get_ulongest): New.
4721         * cli/cli-utils.h (get_ulongest): Declare.
4722         (check_for_argument): New overloads.
4723         * maint-test-options.c: New file.
4724
4725 2019-06-13  Pedro Alves  <palves@redhat.com>
4726
4727         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4728         parse a range if "-" is at the end of the string.
4729
4730 2019-06-13  Pedro Alves  <palves@redhat.com>
4731
4732         * cli/cli-setshow.c (parse_auto_binary_operation)
4733         (parse_cli_boolean_value): Don't allow "o".
4734
4735 2019-06-13  Pedro Alves  <palves@redhat.com>
4736
4737         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4738         * NEWS: Mention maint test-settings KIND.
4739         * maint-test-settings.c: New file.
4740
4741 2019-06-13  Pedro Alves  <palves@redhat.com>
4742
4743         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4744         completer.
4745         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4746         "set" completers.
4747
4748 2019-06-13  Pedro Alves  <palves@redhat.com>
4749
4750         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4751         after item.
4752
4753 2019-06-13  Pedro Alves  <palves@redhat.com>
4754
4755         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4756
4757 2019-06-13  Pedro Alves <palves@redhat.com>
4758
4759         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4760         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4761         call.
4762         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4763         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4764         calls.
4765         (check_for_argument): Skip spaces after argument.
4766
4767 2019-06-13  Pedro Alves  <palves@redhat.com>
4768
4769         * thread.c (thread_apply_command): Adjust TID parsing.
4770         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4771         detected before end of string.
4772         (tid_is_in_list): Error out if LIST is invalid.
4773
4774 2019-06-13  Pedro Alves  <palves@redhat.com>
4775
4776         * completer.c (complete_line_internal_1): Rewind completion word
4777         point.
4778         (completion_tracker::advance_custom_word_point_by): Change
4779         parameter type to int.
4780         * completer.h (completion_tracker::advance_custom_word_point_by):
4781         Likewise.
4782
4783 2019-06-13  Pedro Alves  <palves@redhat.com>
4784
4785         * completer.c (advance_to_completion_word): Handle delimiters.
4786
4787 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4788
4789         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4790
4791 2019-06-11  Tom Tromey  <tom@tromey.com>
4792
4793         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4794         (xmalloc_failed): Move to alloc.c.
4795         * alloc.c: New file.
4796         * Makefile.in (COMMON_SFILES): Add alloc.c.
4797
4798 2019-06-11  Tom Tromey  <tom@tromey.com>
4799
4800         * nat/linux-waitpid.c: Don't include server.h.
4801         (linux_debug): Remove.
4802         (my_waitpid): Update.
4803
4804 2019-06-11  Tom Tromey  <tromey@adacore.com>
4805
4806         * infcall.c (_initialize_infcall): Remove trailing newline from
4807         help.
4808         * user-regs.c (_initialize_user_regs): Remove trailing newline
4809         from help.
4810         * typeprint.c (_initialize_typeprint): Remove trailing newline
4811         from help.
4812         * reverse.c (_initialize_reverse): Remove trailing newlines from
4813         help.
4814         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4815         from help.
4816         * language.c (add_set_language_command): Remove trailing newline
4817         from help.
4818         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4819         help.
4820         * disasm.c (_initialize_disasm): Remove trailing newline from
4821         help.
4822         * top.c (init_main): Remove trailing newline from help.
4823         * interps.c (_initialize_interpreter): Remove trailing newline
4824         from help.
4825         * btrace.c (_initialize_btrace): Remove trailing newlines from
4826         help.
4827         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4828         from help.
4829         * python/python.c (_initialize_python): Remove trailing newline
4830         from help.
4831         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4832         help.
4833         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4834         from help.  Reformat some text.
4835         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4836         from help.
4837         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4838         newline from help.
4839
4840 2019-06-11  Tom Tromey  <tromey@adacore.com>
4841
4842         * darwin-nat.c (darwin_decode_exception_message)
4843         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4844
4845 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * valops.c (value_slice): Check for not allocated or not
4848         associated values.
4849
4850 2019-06-10  Tom de Vries  <tdevries@suse.de>
4851
4852         PR gdb/24618
4853         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4854         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4855         invalid.
4856
4857 2019-06-10  Tom de Vries  <tdevries@suse.de>
4858
4859         PR gdb/24611
4860         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4861         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4862
4863 2019-06-10  Tom de Vries  <tdevries@suse.de>
4864
4865         PR symtab/24545
4866         * symtab.c (struct demangled_name_entry): Add language field.
4867         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4868         static minimal symbol".  Set and use language field.
4869
4870 2019-06-10  Tom Tromey  <tromey@adacore.com>
4871
4872         * ada-lang.c (_initialize_ada_language): Update help text.
4873
4874 2019-06-10  Tom Tromey  <tromey@adacore.com>
4875
4876         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4877         with a newline.
4878         * guile/guile.c (handle_boot_error): Don't end warning with a
4879         newline.
4880         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4881         warning with a newline.
4882         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4883         newline.
4884         (s12z_frame_cache): Likewise.
4885         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4886         a newline.
4887         * solib-svr4.c (disable_probes_interface): Don't end warning with
4888         a newline.
4889         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4890         newline.
4891         * python/python.c (do_finish_initialization): Don't end warning
4892         with a newline.
4893
4894 2019-06-10  Tom Tromey  <tom@tromey.com>
4895
4896         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4897         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4898         gdbpy_enter.
4899
4900 2019-06-10  Tom Tromey  <tromey@adacore.com>
4901
4902         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4903         data.
4904         (elf_new_init): Don't call stabsread_new_init.
4905         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4906         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4907         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4908
4909 2019-06-10  Tom de Vries  <tdevries@suse.de>
4910
4911         PR symtab/16264
4912         PR symtab/24517
4913         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4914
4915 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4916
4917         * source.c (find_and_open_source): Also rewrite relative file
4918         names.
4919
4920 2019-04-26  Amos Bird  <amosbird@gmail.com>
4921
4922         * annotate.c (annotate_thread_exited): Add "thread-exited"
4923         annotation.
4924
4925 2019-06-06  Tom Tromey  <tromey@adacore.com>
4926
4927         * maint.h (class scoped_command_stats): Use
4928         DISABLE_COPY_AND_ASSIGN.
4929         <print_time>: New method.
4930         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4931         print_time.
4932         (scoped_command_stats::print_time): New method.
4933
4934 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4937         instructions of lengths 6 or 8 bytes.
4938
4939 2019-06-04  Pedro Alves  <palves@redhat.com>
4940
4941         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4942
4943         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4944         * breakpoint.c (condition_completer): Likewise.
4945         * cli/cli-dump.c (scan_expression): Likewise.
4946         * common/filestuff.c (mkdir_recursive): Likewise.
4947         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4948         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4949         (gdb_abspath): Likewise.
4950         * compile/compile-cplus-types.c
4951         (compile_cplus_instance::decl_name): Likewise.
4952         * completer.c (complete_explicit_location):
4953         (signal_completer, reg_or_group_completer_1): Likewise.
4954         * cp-support.c (cp_remove_params_if_any): Likewise.
4955         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4956         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4957         * infcmd.c (strip_bg_char): Likewise.
4958         * linespec.c (copy_token_string): Likewise.
4959         * mi/mi-main.c (output_cores): Likewise.
4960         * psymtab.c (psymtab_search_name):
4961         * symfile.c (test_set_ext_lang_command): Likewise.
4962         * target.c (target_fileio_read_stralloc): Likewise.
4963         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4964         * value.c (complete_internalvar): Likewise.
4965
4966 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4967
4968         Add objfile property to gdb.Type.
4969         * NEWS: Mention Python API addition.
4970         * python/py-type.c (typy_get_objfile): New method.
4971
4972 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4973
4974         * NEWS: Mention the new set|show style [title|highlight].
4975         Mention changes to "show style", "help" and "apropos".
4976
4977 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4978
4979         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4980         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4981         instead of print_help_for_command.
4982         (print_doc_of_command): New function.
4983         (help_list): Add 'apropos -v word' suggestion.
4984         (print_help_for_command): Style the command name using title style.
4985         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4986         (_initialize_cli_cmds): Describe -v in apropos_command help.
4987
4988 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4989
4990         * cli/cli-style.h (cli_style_option): Add name in constructor,
4991         add m_name class member, add constructor with intensity,
4992         add name class function.
4993         (cli_style_option::add_setshow_commands): Remove name argument.
4994         (highlight_style, title_style): New styles.
4995         * cli/cli-style.c (do_show): New function that shows a style
4996         characteristic styling the style name with itself.
4997         (set_style_name): New function.
4998         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4999         Update all callers according to the changes in cli/cli-style.h.
5000         * utils.h (fputs_highlighted): New function.
5001         * utils.c (fputs_highlighted): Likewise.
5002
5003 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5004
5005         * NEWS: Mention new pipe command and new convenience variables.
5006
5007 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5008
5009         * cli/cli-cmds.c (pipe_command): New function.
5010         (_initialize_cli_cmds): Call add_com for pipe_command.
5011         Define | as an alias for pipe.
5012         (exit_status_set_internal_vars): New function.
5013         (shell_escape): Call exit_status_set_internal_vars.
5014         cli/cli-decode.c (find_command_name_length): Recognize | as
5015         a single character command.
5016
5017 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5018
5019         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5020         top.c (execute_command_to_ui_file): New function, mostly a copy
5021         of execute_command_to_string.
5022         (execute_command_to_string): Implement by calling
5023         execute_command_to_ui_file.
5024
5025 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5026
5027         * top.h (saved_command_line): Remove declaration.
5028         * top.c (previous_saved_command_line, previous_repeat_arguments):
5029         New variables.
5030         (saved_command_line): Make static, define together with other
5031         'repeat variables'.
5032         (dont_repeat): Clear repeat_arguments.
5033         (repeat_previous, get_saved_command_line, save_command_line):
5034         New functions.
5035         (gdb_init): Initialize saved_command_line
5036         and previous_saved_command_line.
5037         * main.c (captured_main_1): Remove saved_command_line initialization.
5038         * event-top.c (handle_line_of_input): Update to use
5039         the new 'repeat' related functions instead of direct access to
5040         saved_command_line.
5041         * command.h (repeat_previous, get_saved_command_line,
5042         save_command_line): New declarations.
5043         (dont_repeat): Add comment.
5044
5045 2019-05-30  Tom Tromey  <tromey@adacore.com>
5046
5047         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5048         Fix comment.
5049         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5050
5051 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5052
5053         PR cli/24587
5054         * completer.c (complete): Initialize variable word.
5055
5056 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5057
5058         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5059         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5060         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5061         'body' is NULL to the outter 'if', protecting the '!is_define'
5062         situation as well.
5063
5064 2019-05-29  Tom Tromey  <tromey@adacore.com>
5065
5066         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5067         (dwarf_unknown): New function.
5068         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5069         (dwarf_type_encoding_name): Use dwarf_unknown.
5070
5071 2019-05-29  Tom Tromey  <tromey@adacore.com>
5072
5073         PR c++/20020:
5074         * cp-valprint.c (cp_print_value_fields): Call
5075         cp_print_static_field inside "try".
5076
5077 2019-05-29  Tom Tromey  <tromey@adacore.com>
5078
5079         * inflow.c (struct terminal_info): Add default operator=.
5080         * configure: Rebuild.
5081         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5082         -Wdeprecated-copy-dtor, -Wredundant-move.
5083
5084 2019-05-29  Tom Tromey  <tromey@adacore.com>
5085
5086         * NEWS: Add entry.
5087         * infcmd.c (print_return_value_1): Handle finish_print
5088         option.
5089         (show_print_finish): New function.
5090         (_initialize_infcmd): Add "set/show print finish" commands.
5091         * valprint.c (user_print_options): Initialize new member.
5092         * valprint.h (struct value_print_options) <finish_print>: New
5093         member.
5094
5095 2019-05-28  Tom Tromey  <tromey@adacore.com>
5096
5097         * ada-lang.c (ada_remove_Xbn_suffix)
5098         (find_old_style_renaming_symbol)
5099         (parse_old_style_renaming): Remove.
5100         (ada_find_renaming_symbol): Don't call
5101         find_old_style_renaming_symbol.
5102         (ada_is_renaming_symbol): Rename from
5103         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5104         bool.  Now static.
5105         (ada_read_var_value): Update and simplify.
5106         * ada-exp.y (write_var_or_type): Remove old code.
5107
5108 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5109
5110         * event-top.c: Remove include comment.
5111         * inflow.c (class scoped_ignore_sigttou): Move from here...
5112         * inflow.h (class scoped_ignore_sigttou): ...to here.
5113         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5114         * top.c:  Remove include comment.
5115
5116 2019-05-27  Tom Tromey  <tom@tromey.com>
5117
5118         * NEWS: Fix typo.
5119
5120 2019-05-22  Tom Tromey  <tromey@adacore.com>
5121
5122         * target.c (target_follow_exec): Constify parameter.
5123         * target-delegates.c: Rebuild.
5124         * remote.c (remote_target::follow_exec): Constify parameter.
5125         * infrun.c (follow_exec): Constify parameter.
5126         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5127         (target_follow_exec): Likewise.
5128
5129 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5130
5131         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5132         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5133
5134 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5135
5136         * NEWS: Add debugredirect and testsuite sections.
5137
5138 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5139
5140         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5141         target descriptions using exclusively floating point register name
5142         aliases.
5143
5144 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         PR gdb/18644:
5147         * f-lang.c (build_fortran_types): Handle the case where
5148         gdbarch_floatformat_for_type returns a nullptr.
5149
5150 2019-05-21  Tom de Vries  <tdevries@suse.de>
5151
5152         PR cli/24587
5153         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5154
5155 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         PR gdb/18644:
5158         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5159         16-byte floats.
5160         * i386-tdep.c (i386_floatformat_for_type): Use
5161         floatformats_ia64_quad for the 16-byte floating point component
5162         within a fortran 32-byte complex number.
5163
5164 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5167         delete default constructor.
5168         (find_partial_die): Update to return const struct.
5169         (partial_die_parent_scope): Move variable declaration into scope
5170         of its use and change its type to auto.
5171         (guess_partial_die_structure_name): Likewise.
5172         (partial_die_info::fixup): Likewise.
5173
5174 2019-05-17  Tom Tromey  <tromey@adacore.com>
5175
5176         * source.c (find_and_open_source): Remove cast.
5177
5178 2019-05-17  Tom Tromey  <tromey@adacore.com>
5179
5180         * annotate.c (annotate_source): Make "filename" const.
5181         * annotate.h (annotate_source): Use const.
5182
5183 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5184
5185         * disasm.c (set_disassembler_options): Send errors to stderr.
5186
5187 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5188
5189         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5190         (cli_interp_base::set_logging): Check debug_redirect.
5191         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5192         * cli/cli-logging.c (debug_redirect): Add static variable.
5193         (pop_output_files): Add default param.
5194         (handle_redirections): Print debug setting.
5195         (show_logging_command): Likewise.
5196         (_initialize_cli_logging): Add debugredirect command.
5197         * interps.c (current_interp_set_logging): Add debug_redirect
5198         parameter.
5199         * interps.h (set_logging): Add debug_redirect parameter.
5200         (current_interp_set_logging): Likewise.
5201         * mi/mi-common.h: Likewise.
5202         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5203
5204 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5205             Tom Tromey  <tromey@adacore.com>
5206
5207         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5208         directly.
5209         * cli/cli-interp.h (make_logging_output): Remove declaration.
5210         * cli/cli-logging.c (make_logging_output): Remove function.
5211         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5212         directly.
5213         * ui-file.c (tee_file::tee_file): Remove bools.
5214         (tee_file::~tee_file): Remove deletes.
5215         * ui-file.h (tee_file): Remove bools.
5216
5217 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5218
5219         * mi/mi-cmds.h (mi_cmd_complete): New function.
5220         * mi/mi-main.c (mi_cmd_complete): Likewise.
5221         * mi/mi-cmds.c: Define new MI command -complete.
5222         * NEWS: Mention new -complete command.
5223
5224 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5225
5226         * completer.h (complete): New function.
5227         * completer.c (complete): Likewise.
5228         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5229         function defined in completer.h.
5230
5231 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5232
5233         * MAINTAINERS (Write After Approval): Add myself.
5234
5235 2019-05-17  Tom de Vries  <tdevries@suse.de>
5236
5237         PR gdb/24094
5238         * dwarf2read.c (struct cu_partial_die_info): New struct.
5239         (find_partial_die): Return cu_partial_die_info.
5240         (partial_die_parent_scope, guess_partial_die_structure_name)
5241         (partial_die_info::fixup): Handle new return type of find_partial_die.
5242
5243 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5244
5245         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5246         "std::string", simplifying the algorithm.
5247
5248 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5249
5250         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5251         (stap_static_probe_ops::get_probes): Likewise.
5252
5253 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5254
5255         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5256         '-')" and "else if".
5257         (stap_parse_single_operand): Join checks for
5258         "gdbarch_stap_parse_special_token_p" and
5259         "gdbarch_stap_parse_special_token" in the same "if" statement.
5260         Invert check when verifying for operation on register
5261         displacement.
5262
5263 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5264
5265         * stap-probe.c (stap_get_opcode): Update comment.
5266         (stap_get_expected_argument_type): Likewise.
5267         (handle_stap_probe): Likewise.
5268
5269 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5270
5271         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5272         return type to 'bool'.  Adjust comment.  Use 'bool' when
5273         appropriate.
5274         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5275         * stap-probe.c (stap_parse_argument_1): Likewise.
5276         (stap_is_operator): Likewise.
5277         (stap_is_generic_prefix): Likewise.
5278         (stap_is_register_prefix): Likewise.
5279         (stap_is_register_indirection_prefix): Likewise.
5280         (stap_is_integer_prefix): Likewise.
5281         (stap_generic_check_suffix): Likewise.
5282         (stap_check_integer_suffix): Likewise.
5283         (stap_check_register_suffix): Likewise.
5284         (stap_check_register_indirection_suffix): Likewise.
5285         (stap_parse_register_operand): Likewise.
5286         (stap_parse_single_operand): Likewise.
5287         (stap_parse_argument_1): Likewise.
5288         (stap_probe::get_argument_count): Likewise.
5289         (stap_is_operator): Likewise.
5290
5291 2019-05-16  Tom Tromey  <tromey@adacore.com>
5292
5293         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5294         keyword to foreach.
5295
5296 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5297
5298         * linux-thread-db.c (try_thread_db_load_1): Change return type
5299         to bool.
5300         (try_thread_db_load): Likewise.
5301         (try_thread_db_load_from_pdir_1): Likewise.
5302         (try_thread_db_load_from_pdir): Likewise.
5303         (try_thread_db_load_from_sdir): Likewise.
5304         (try_thread_db_load_from_dir): Likewise.
5305         (thread_db_load_search): Likewise.
5306         (has_libpthread): Likewise.
5307         (thread_db_load): Likewise.
5308
5309 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5310
5311         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5312         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5313         NULL, and complain/return if that's the case.
5314
5315 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5316
5317         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5318         (advance, posn, abstract_read_memory): New functions.
5319         [struct mem_read_abstraction]: New struct.
5320         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5321
5322 2019-05-14  Tom Tromey  <tromey@adacore.com>
5323
5324         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5325         value is not lval_memory.
5326
5327 2019-05-14  Tom Tromey  <tromey@adacore.com>
5328
5329         * solib.c (info_sharedlibrary_command): Style the file name.
5330
5331 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5332
5333         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5334         (aarch64_vnv_type): Likewise.
5335         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5336         * common/tdesc.c: Likewise.
5337         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5338         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5339         * features/aarch64-fpu.xml: Add ieee half view.
5340         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5341         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5342         * gdbtypes.h (struct builtin_type): Likewise.
5343         (struct objfile_type): Likewise.
5344
5345 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5346
5347         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5348         typo.
5349         * location.h (string_to_event_location): Likewise.
5350
5351 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5352
5353         GDB 8.3 released.
5354
5355 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5356
5357         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5358         New variable declaration.
5359         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5360         New variable.
5361         (print_one_breakpoint): Use ui_out::test_flags and new global
5362         variable to compute use_fixed_output.
5363         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5364         Remove.
5365         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5366         (mi_multi_location_breakpoint_output_fixed): Remove.
5367         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5368         new variable.
5369         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5370         fix_multi_location_breakpoint_output flag if version >= 3.
5371         * ui-out.h (enum ui_out_flag)
5372         <fix_multi_location_breakpoint_output>: New enumerator.
5373
5374 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5375
5376         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5377
5378 2019-05-10  Tom Tromey  <tromey@adacore.com>
5379
5380         * ada-lang.c (catch_ada_completer): New function.
5381         (_initialize_ada_language): Use it.
5382
5383 2019-05-10  Tom Tromey  <tromey@adacore.com>
5384
5385         * thread.c (print_thread_info): Make "requested_threads" const.
5386         * gdbthread.h (print_thread_info): Make "requested_threads"
5387         const.
5388         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5389         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5390
5391 2019-05-08  Tom Tromey  <tom@tromey.com>
5392
5393         * gdbtypes.c (objfile_type_data): Change type.
5394         (objfile_type, _initialize_gdbtypes): Update.
5395
5396 2019-05-08  Tom Tromey  <tom@tromey.com>
5397
5398         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5399         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5400         (_initialize_dwarf2_frame): Update.
5401
5402 2019-05-08  Tom Tromey  <tom@tromey.com>
5403
5404         * objc-lang.c (objc_objfile_data): Change type.
5405         (find_methods): Update.
5406         (_initialize_objc_lang): Remove.
5407
5408 2019-05-08  Tom Tromey  <tom@tromey.com>
5409
5410         * stabsread.c (rs6000_builtin_type_data): Change type.
5411         (rs6000_builtin_type, _initialize_stabsread): Update.
5412
5413 2019-05-08  Tom Tromey  <tom@tromey.com>
5414
5415         * mips-tdep.c (mips_pdr_data): Remove.
5416         (_initialize_mips_tdep): Update.
5417
5418 2019-05-08  Tom Tromey  <tom@tromey.com>
5419
5420         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5421         (hppa_init_objfile_priv_data, read_unwind_info)
5422         (find_unwind_entry, _initialize_hppa_tdep): Update.
5423
5424 2019-05-08  Tom Tromey  <tom@tromey.com>
5425
5426         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5427         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5428         on obstack.
5429         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5430
5431 2019-05-08  Tom Tromey  <tom@tromey.com>
5432
5433         * mdebugread.c (basic_type_data): Change type.
5434         (basic_type, _initialize_mdebugread): Update.
5435
5436 2019-05-08  Tom Tromey  <tom@tromey.com>
5437
5438         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5439
5440 2019-05-08  Tom Tromey  <tom@tromey.com>
5441
5442         * nto-tdep.c (nto_inferior_data_reg): Change type.
5443         (nto_inferior_data): Update.
5444         (nto_inferior_data_cleanup, nto_new_inferior_data)
5445         (_initialize_nto_tdep): Remove.
5446         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5447
5448 2019-05-08  Tom Tromey  <tom@tromey.com>
5449
5450         * ada-lang.c (struct ada_inferior_data): Add initializers.
5451         (ada_inferior_data): Change type.
5452         (ada_inferior_data_cleanup): Remove.
5453         (get_ada_inferior_data, ada_inferior_exit)
5454         (struct ada_pspace_data): Add initializers, destructor.
5455         (ada_pspace_data_handle): Change type.
5456         (get_ada_pspace_data): Update.
5457         (ada_pspace_data_cleanup): Remove.
5458
5459 2019-05-08  Tom Tromey  <tom@tromey.com>
5460
5461         * coffread.c (struct coff_symfile_info): Add initializers.
5462         (coff_objfile_data_key): Move lower.  Change type.
5463         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5464         Update.
5465         (coff_free_info): Remove.
5466
5467 2019-05-08  Tom Tromey  <tom@tromey.com>
5468
5469         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5470         (fbsd_pspace_data_handle): Move lower.  Change type.
5471         (get_fbsd_pspace_data): Update.
5472         (fbsd_pspace_data_cleanup): Remove.
5473         (_initialize_fbsd_tdep): Update.
5474
5475 2019-05-08  Tom Tromey  <tom@tromey.com>
5476
5477         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5478         (get_ada_tasks_pspace_data): Update.
5479         (ada_tasks_pspace_data_cleanup): Remove.
5480         (_initialize_tasks): Update.
5481         (ada_tasks_inferior_data_handle): Change type.
5482         (get_ada_tasks_inferior_data): Update.
5483         (ada_tasks_inferior_data_cleanup): Remove.
5484         (struct ada_tasks_pspace_data): Add initializers.
5485
5486 2019-05-08  Tom Tromey  <tom@tromey.com>
5487
5488         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5489         * symfile-debug.c (debug_sym_get_probes): Change type.
5490         * stap-probe.c (handle_stap_probe):
5491         (stap_static_probe_ops::get_probes): Change type.
5492         * probe.h (class static_probe_ops) <get_probes>: Change type.
5493         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5494         (parse_probes_in_pspace): Update.
5495         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5496         Update.
5497         (any_static_probe_ops::get_probes): Change type.
5498         * elfread.c (elfread_data): New typedef.
5499         (probe_key): Change type.
5500         (elf_get_probes): Likewise.  Update.
5501         (probe_key_free): Remove.
5502         (_initialize_elfread): Update.
5503         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5504         Change type.
5505         (dtrace_process_dof_probe, dtrace_process_dof)
5506         (dtrace_static_probe_ops::get_probe): Change type.
5507
5508 2019-05-08  Tom Tromey  <tom@tromey.com>
5509
5510         * xcoffread.c (struct xcoff_symfile_info): Rename from
5511         coff_symfile_info.  Add initializers.
5512         (xcoff_objfile_data_key): Move lower.  Change type.
5513         (XCOFF_DATA): Rewrite.
5514         (xcoff_free_info): Remove.
5515         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5516         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5517         (xcoff_initial_scan): Update.
5518
5519 2019-05-08  Tom Tromey  <tom@tromey.com>
5520
5521         * solib-svr4.c (struct svr4_info): Add initializers and
5522         destructor.
5523         <probes_table>: Now an htab_up.
5524         (solib_svr4_pspace_data): Change type.
5525         (free_probes_table): Simplify.
5526         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5527         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5528         (probes_table_remove_objfile_probes, register_solib_event_probe)
5529         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5530         (_initialize_svr4_solib): Update.
5531
5532 2019-05-08  Tom Tromey  <tom@tromey.com>
5533
5534         * remote.c (remote_pspace_data): Change type.
5535         (remote_pspace_data_cleanup): Remove.
5536         (get_remote_exec_file, set_pspace_remote_exec_file)
5537         (_initialize_remote): Update.
5538
5539 2019-05-08  Tom Tromey  <tom@tromey.com>
5540
5541         * breakpoint.c (breakpoint_objfile_key): Change type.
5542         (get_breakpoint_objfile_data): Update.
5543         (free_breakpoint_objfile_data): Remove.
5544         (_initialize_breakpoint): Update.
5545
5546 2019-05-08  Tom Tromey  <tom@tromey.com>
5547
5548         * linux-tdep.c (struct linux_info): Add initializers.
5549         (linux_inferior_data): Move.  Change type.
5550         (invalidate_linux_cache_inf): Update.
5551         (linux_inferior_data_cleanup): Remove.
5552         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5553
5554 2019-05-08  Tom Tromey  <tom@tromey.com>
5555
5556         * auxv.c (auxv_inferior_data): Move.  Change type.
5557         (auxv_inferior_data_cleanup): Remove.
5558         (invalidate_auxv_cache_inf): Rewrite.
5559         (get_auxv_inferior_data, _initialize_auxv): Update.
5560
5561 2019-05-08  Tom Tromey  <tom@tromey.com>
5562
5563         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5564         (symfile_debug_objfile_data_key): Change type.
5565         (symfile_debug_installed, debug_qf_has_symbols)
5566         (debug_qf_find_last_source_symtab)
5567         (debug_qf_forget_cached_source_info)
5568         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5569         (debug_qf_print_stats, debug_qf_dump)
5570         (debug_qf_expand_symtabs_for_function)
5571         (debug_qf_expand_all_symtabs)
5572         (debug_qf_expand_symtabs_with_fullname)
5573         (debug_qf_map_matching_symbols)
5574         (debug_qf_expand_symtabs_matching)
5575         (debug_qf_find_pc_sect_compunit_symtab)
5576         (debug_qf_map_symbol_filenames)
5577         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5578         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5579         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5580         (debug_sym_read_linetable, debug_sym_relocate): Update.
5581         (symfile_debug_free_objfile): Remove.
5582         (install_symfile_debug_logging, _initialize_symfile_debug):
5583         Update.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5588         allocate_on_obstack.
5589         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5590         (get_dwarf2_per_objfile): Update.
5591         (set_dwarf2_per_objfile): Remove.
5592         (dwarf2_has_info, dwarf2_get_section_info): Update.
5593         (dwarf2_free_objfile): Remove.
5594         (_initialize_dwarf2_read): Update.
5595
5596 2019-05-08  Tom Tromey  <tom@tromey.com>
5597
5598         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5599         initializers.
5600         <unsupported_script_warning_printed,
5601         script_not_found_warning_printed>: Now bool.
5602         (auto_load_pspace_data): Change type.
5603         (~auto_load_pspace_info): Rename from
5604         auto_load_pspace_data_cleanup.
5605         (get_auto_load_pspace_data, init_loaded_scripts_info)
5606         (clear_section_scripts, maybe_print_unsupported_script_warning)
5607         (maybe_print_script_not_found_warning, _initialize_auto_load):
5608         Update.
5609
5610 2019-05-08  Tom Tromey  <tom@tromey.com>
5611
5612         * objfiles.c (objfile_pspace_info): Add destructor and
5613         initializers.
5614         (objfiles_pspace_data): Change type.
5615         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5616         (get_objfile_pspace_data): Update.
5617         (objfiles_bfd_data): Change type.
5618         (get_objfile_bfd_data): Update.
5619         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5620
5621 2019-05-08  Tom Tromey  <tom@tromey.com>
5622
5623         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5624         Change type.
5625         (get_catch_syscall_inferior_data): Update.
5626         (catch_syscall_inferior_data_cleanup): Remove.
5627         (_initialize_break_catch_syscall): Update.
5628
5629 2019-05-08  Tom Tromey  <tom@tromey.com>
5630
5631         * inflow.c (struct terminal_info): Add destructor and
5632         initializers.
5633         (inflow_inferior_data): Change type.
5634         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5635         (get_inflow_inferior_data, inflow_inferior_exit)
5636         (swap_terminal_info, _initialize_inflow): Update.
5637
5638 2019-05-08  Tom Tromey  <tom@tromey.com>
5639
5640         * target-dcache.c (target_dcache_cleanup): Remove.
5641         (target_dcache_aspace_key): Change type.
5642         (target_dcache_init_p, target_dcache_invalidate)
5643         (target_dcache_get, target_dcache_get_or_init)
5644         (_initialize_target_dcache): Update.
5645         * dcache.h (struct dcache_deleter): New.
5646
5647 2019-05-08  Tom Tromey  <tom@tromey.com>
5648
5649         * symtab.c (struct symbol_cache): Add destructor and
5650         initializers.
5651         (symbol_cache_key): Move.  Change type.
5652         (make_symbol_cache, free_symbol_cache): Remove.
5653         (get_symbol_cache): Update.
5654         (symbol_cache_cleanup): Remove.
5655         (ALL_PSPACES, symbol_cache_flush)
5656         (maintenance_print_symbol_cache)
5657         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5658         Update.
5659
5660 2019-05-08  Tom Tromey  <tom@tromey.com>
5661
5662         * symtab.c (struct main_info): Add destructor and initializers.
5663         (main_progspace_key): Move.  Change type.
5664         (get_main_info): Update.
5665         (main_info_cleanup): Remove.
5666         (_initialize_symtab): Update.
5667
5668 2019-05-08  Tom Tromey  <tom@tromey.com>
5669
5670         * registry.h (DECLARE_REGISTRY): Define the _key class.
5671
5672 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5673
5674         * NEWS: Merge two 'New commands' sections.
5675
5676 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5677
5678         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5679         parameter and use Ada language definition instead.
5680         (ada_val_print_ptr): Remove unused language parameter.
5681         (ada_val_print_num): Remove language parameter and use Ada language
5682         definition instead.
5683         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5684         parameter.
5685         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5686         parameter and use Ada language definition instead.
5687         (ada_val_print_1): Update all ada_val_print_xxx calls.
5688         Remove language parameter.
5689         (ada_val_print): Update ada_val_print_1 call.
5690
5691 2019-05-08  Tom Tromey  <tromey@adacore.com>
5692
5693         * remote.c (remote_hw_watchpoint_limit)
5694         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5695         Now static.
5696
5697 2019-05-08  Tom Tromey  <tromey@adacore.com>
5698
5699         * maint.c (_initialize_maint_cmds): Move initialization code to
5700         remote.c.
5701         (watchdog, show_watchdog): Move to remote.c.
5702         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5703         "watchdog" static.
5704         (_initialize_remote): Move initialization code from maint.c.
5705         * defs.h (watchdog): Don't declare.
5706
5707 2019-05-08  Tom Tromey  <tromey@adacore.com>
5708
5709         * tui/tui-interp.c: Include main.h.
5710         * interps.c: Include main.h.
5711         * main.h (interpreter_p): Declare.
5712         * defs.h (interpreter_p): Don't declare.
5713
5714 2019-05-08  Tom Tromey  <tromey@adacore.com>
5715
5716         * dwarf2loc.c: Include dwarf2read.h.
5717         * defs.h (read_unsigned_leb128): Don't declare.
5718         * dwarf2read.h (read_unsigned_leb128): Declare.
5719
5720 2019-05-08  Tom Tromey  <tromey@adacore.com>
5721
5722         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5723         method.
5724
5725 2019-05-08  Tom Tromey  <tromey@adacore.com>
5726
5727         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5728         when no wrap column is set.
5729
5730 2019-05-08  Tom Tromey  <tromey@adacore.com>
5731
5732         * c-lang.c (c_get_string): Handle non-C-style arrays.
5733
5734 2019-05-08  Tom Tromey  <tromey@adacore.com>
5735
5736         * typeprint.c (print_offset_data::update): Print the bit offset,
5737         not the number of bits remaining.
5738
5739 2019-05-08  Tom Tromey  <tromey@adacore.com>
5740
5741         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5742         padding at end of comment.
5743
5744 2019-05-08  Tom Tromey  <tromey@adacore.com>
5745
5746         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5747         Compare main types.
5748
5749 2019-05-06  Tom Tromey  <tom@tromey.com>
5750
5751         * common/scoped_mmap.c: Include common-defs.h.
5752         * common/scoped_mmap.h: Don't include config.h.
5753
5754 2019-05-04  Tom Tromey  <tom@tromey.com>
5755
5756         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5757         (struct aarch64_call_info): Add initializers.
5758         <si>: Now a std::vector.
5759         (pass_on_stack, aarch64_push_dummy_call): Update.
5760
5761 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5762             Tom Tromey  <tom@tromey.com>
5763
5764         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5765         (ppc_threads): Now a std::vector.  Now static.
5766         (hwdebug_find_thread_points_by_tid)
5767         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5768         Update.
5769
5770 2019-05-04  Tom Tromey  <tom@tromey.com>
5771
5772         * arc-tdep.c (arc_tdesc_init): Return bool.
5773
5774 2019-05-04  Tom Tromey  <tom@tromey.com>
5775
5776         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5777         Use gdb_assert_not_reached.
5778
5779 2019-05-04  Tom Tromey  <tom@tromey.com>
5780
5781         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5782         "false".
5783
5784 2019-05-04  Tom Tromey  <tom@tromey.com>
5785
5786         * arc-tdep.c (arc_tdesc_init): Use bool.
5787
5788 2019-05-04  Tom Tromey  <tom@tromey.com>
5789
5790         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5791
5792 2019-05-04  Tom Tromey  <tom@tromey.com>
5793
5794         * cli/cli-cmds.c (valid_command_p): Return bool.
5795
5796 2019-05-04  Tom Tromey  <tom@tromey.com>
5797
5798         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5799         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5800
5801 2019-05-04  Raul Tambre  <raul@tambre.ee>
5802
5803         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5804         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5805         operator for comparison.
5806
5807 2019-05-04  Tom Tromey  <tom@tromey.com>
5808
5809         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5810         (lookup_partial_symbol, print_partial_symbols)
5811         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5812         (psymbol_compare): Update.
5813         (add_psymbol_to_bcache): Clear the entire psymbol.
5814         (maintenance_check_psymtabs): Update.
5815         * psympriv.h (struct partial_symbol): Don't derive from
5816         general_symbol_info.
5817         <obj_section, unrelocated_address, address,
5818         set_unrelocated_address>: Update.
5819         <ginfo>: New member.
5820         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5821         (debug_names::write_psymbols): Update.
5822
5823 2019-05-04  Tom de Vries  <tdevries@suse.de>
5824
5825         * contrib/cc-with-tweaks.sh: Support -n arg.
5826
5827 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5828
5829         * corelow.c (core_target::detach): Ensure frame cache and
5830         register caches are cleared.
5831         inferior.c (exit_inferior_1): Likewise.
5832
5833 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5834             Tom Tromey  <tom@tromey.com>
5835
5836         * dictionary.c (collate_pending_symbols_by_language): Remove
5837         "struct" from foreach.
5838         * symtab.c (lookup_global_symbol_from_objfile)
5839         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5840         foreach.
5841         * ser-tcp.c (net_open): Remove "struct" from foreach.
5842         * objfiles.c (objfile_relocate, objfile_rebase)
5843         (objfile_has_symbols): Remove "struct" from foreach.
5844         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5845         from foreach.
5846         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5847         foreach.
5848         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5849         "struct" from foreach.
5850         * ada-lang.c (create_excep_cond_exprs)
5851         (ada_exception_catchpoint_cond_string): Remove "struct" from
5852         foreach.
5853
5854 2019-05-03  Tom Tromey  <tromey@adacore.com>
5855
5856         * ada-exp.y (convert_char_literal): Check suffix of each
5857         enumerator.
5858
5859 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5860
5861         PR ada/21406:
5862         * ada-exp.y (yywrap): Don't define.
5863         * ada-lex.l (%option): Add noyywrap
5864         (yywrap): Remove.
5865
5866 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5867
5868         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5869         _WIN32_WINNT to the XP level, unless already defined to a higher
5870         level.
5871
5872         * unittests/parse-connection-spec-selftests.c:
5873         * ser-tcp.c:
5874         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5875         override.
5876
5877         * symfile.c (find_separate_debug_file): Remove colon from the
5878         drive spec of DOS/Windows file names of the target, so that the
5879         file name produced from DEBUGDIR and the target's directory will
5880         be valid on DOS/Windows systems.
5881
5882 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * rust-lang.c (val_print_struct): Handle printing structures
5885         containing strings.
5886
5887 2019-05-02  Tom Tromey  <tromey@adacore.com>
5888
5889         * valarith.c (_initialize_valarith): Remove.
5890
5891 2019-05-01  Tom Tromey  <tromey@adacore.com>
5892
5893         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5894         bitfields.
5895
5896 2019-05-01  Tom Tromey  <tromey@adacore.com>
5897
5898         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5899         for big-endian copies.
5900
5901 2019-04-30  Ali Tamur  <tamur@google.com>
5902         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5903         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5904         (read_3_bytes): New function.
5905
5906 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5907
5908         * windows-nat.c (main_thread_id): Delete.
5909         (handle_output_debug_string): Replace main_thread_id by
5910         current_event.dwThreadId.
5911         (fake_create_process): Likewise.
5912         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5913         Do not set main_thread_id.
5914         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5915         current_event.dwThreadId.
5916         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5917
5918 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5919
5920         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5921         Use current_event.dwThreadId instead of main_thread_id.
5922
5923 2019-04-30  Tom Tromey  <tromey@adacore.com>
5924
5925         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5926         (create_excep_cond_exprs): Iterate over program spaces.
5927         (ada_exception_catchpoint_cond_string): Examine all minimal
5928         symbols for exception types.
5929
5930 2019-04-30  Tom Tromey  <tromey@adacore.com>
5931
5932         PR c++/24470:
5933         * dwarf2read.c (process_structure_scope): Handle case where type
5934         has template parameters but no symbol was created.
5935
5936 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5937             Chris January  <chris.january@arm.com>
5938
5939         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5940         qualifier.
5941         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5942
5943 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5944
5945         * f-typeprint.c (f_print_type): Update rules for printing
5946         whitespace.
5947         (f_type_print_varspec_suffix): Likewise.
5948
5949 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5950             Chris January  <chris.january@arm.com>
5951
5952         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5953         function arguments.
5954
5955 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5956
5957         * f-lang.c (build_fortran_types): Change name of void type to
5958         lower case.
5959         * f-typeprint.c (f_type_print_base): Print the name of the void
5960         type, rather than a fixed string.
5961         * f-valprint.c (f_decorations): Use lower case void string.
5962
5963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5964             Chris January  <chris.january@arm.com>
5965
5966         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5967         types for Fortran.
5968
5969 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5970             Chris January  <chris.january@arm.com>
5971             David Lecomber  <david.lecomber@arm.com>
5972
5973         * f-exp.y (BINOP_INTRINSIC): New token.
5974         (exp): New parser rule handling BINOP_INTRINSIC.
5975         (f77_keywords): Add new builtin procedures.
5976         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5977         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5978         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5979         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5980         (print_unop_subexp_f): New function.
5981         (print_binop_subexp_f): New function.
5982         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5983         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5984         (dump_subexp_body_f): Likewise.
5985         (operator_check_f): Likewise.
5986         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5987         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5988
5989 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5990
5991         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5992         UNOP_KIND.
5993         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5994         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5995         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5996         (operator_length_f): New fuction.
5997         (print_subexp_f): New function.
5998         (op_name_f): New function.
5999         (dump_subexp_body_f): New function.
6000         (operator_check_f): New function.
6001         (exp_descriptor_f): Replace standard expression handling functions
6002         with new functions.
6003         * gdb/fortran-operator.def: New file.
6004         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6005         * gdb/std-operator.def: Remove UNOP_KIND.
6006
6007 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * std-operator.def: Remove unbalanced, stray double quote
6010         character.
6011
6012 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6013             Chris January  <chris.january@arm.com>
6014             Daniel Everett  <daniel.everett@arm.com>
6015             Nick Forrington  <nick.forrington@arm.com>
6016             Richard Bunt  <richard.bunt@arm.com>
6017
6018         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6019         of depth when printing anonymous structs or unions.
6020         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6021         Don't print either the top-level value, or the children if the
6022         max-depth is exceeded.
6023         (ppscm_print_children): When printing the key of a map, allow one
6024         extra level of depth.
6025         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6026         print either the top-level value, or the children if the max-depth
6027         is exceeded.
6028         (print_children): When printing the key of a map, allow one extra
6029         level of depth.
6030         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6031         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6032         (user_print_options): Initialise max_depth field.
6033         (val_print_scalar_or_string_type_p): New function.
6034         (val_print): Check to see if the max depth has been reached.
6035         (val_print_check_max_depth): Define new function.
6036         (show_print_max_depth): New function.
6037         (_initialize_valprint): Add 'print max-depth' option.
6038         * valprint.h (struct value_print_options) <max_depth>: New field.
6039         (val_print_check_max_depth): Declare new function.
6040         * NEWS: Document new feature.
6041
6042 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6043
6044         * ada-lang.c (ada_language_defn): Initialise new field.
6045         * c-lang.c (c_is_string_type_p): New function.
6046         (c_language_defn): Initialise new field.
6047         (cplus_language_defn): Initialise new field.
6048         (asm_language_defn): Initialise new field.
6049         (minimal_language_defn): Initialise new field.
6050         * c-lang.h (c_is_string_type_p): Declare new function.
6051         * d-lang.c (d_language_defn): Initialise new field.
6052         * f-lang.c (f_is_string_type_p): New function.
6053         (f_language_defn): Initialise new field.
6054         * go-lang.c (go_is_string_type_p): New function.
6055         (go_language_defn): Initialise new field.
6056         * language.c (default_is_string_type_p): New function.
6057         (unknown_language_defn): Initialise new field.
6058         (auto_language_defn): Initialise new field.
6059         * language.h (struct language_defn) <la_is_string_type_p>: New
6060         member variable.
6061         (default_is_string_type_p): Declare new function.
6062         * m2-lang.c (m2_language_defn): Initialise new field.
6063         * objc-lang.c (objc_language_defn): Initialise new field.
6064         * opencl-lang.c (opencl_language_defn): Initialise new field.
6065         * p-lang.c (pascal_is_string_type_p): New function.
6066         (pascal_language_defn): Initialise new field.
6067         * rust-lang.c (rust_is_string_type_p): New function.
6068         (rust_language_defn): Initialise new field.
6069
6070 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6073         New field.
6074         * ada-lang.c (ada_language_defn): Initialise new field.
6075         * c-lang.c (c_language_defn): Likewise.
6076         (cplus_language_defn): Likewise.
6077         (asm_language_defn): Likewise.
6078         (minimal_language_defn): Likewise.
6079         * d-lang.c (d_language_defn): Likewise.
6080         * f-lang.c (f_language_defn): Likewise.
6081         * go-lang.c (go_language_defn): Likewise.
6082         * language.c (unknown_language_defn): Likewise.
6083         (auto_language_defn): Likewise.
6084         * m2-lang.c (m2_language_defn): Likewise.
6085         * objc-lang.c (objc_language_defn): Likewise.
6086         * opencl-lang.c (opencl_language_defn): Likewise.
6087         * p-lang.c (pascal_language_defn): Likewise.
6088         * rust-lang.c (rust_language_defn): Likewise.
6089
6090 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * ada-lang.c (ada_is_character_type): Change return type to bool.
6093         (ada_is_string_type): Likewise.
6094         * ada-lang.h (ada_is_character_type): Update declaration
6095         (ada_is_string_type): Likewise.
6096
6097 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6098
6099         Support style in 'frame|thread apply'
6100
6101         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6102         * record.c (record_start, record_stop): Update callers of
6103         execute_command_to_string with false.
6104         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6105         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6106         methods.
6107         (class string_file): New constructor with term_out parameter.
6108         Override methods term_out and can_emit_style_escape.  New member
6109         term_out.
6110         (class stdio_file): Override can_emit_style_escape.
6111         (class tee_file): Override term_out and can_emit_style_escape.
6112         * utils.h (can_emit_style_escape): Remove.
6113         * utils.c (can_emit_style_escape): Likewise.
6114         Update all callers of can_emit_style_escape (SOMESTREAM) to
6115         SOMESTREAM->can_emit_style_escape.
6116         * source-cache.c (source_cache::get_source_lines): Likewise.
6117         * stack.c (frame_apply_command_count): Call execute_command_to_string
6118         passing the term_out characteristic of the current gdb_stdout.
6119         * thread.c (thr_try_catch_cmd): Likewise.
6120         * top.c (execute_command_to_string): pass term_out parameter
6121         to construct the string_file for the command output.
6122         * ui-file.c (term_cli_styling): New function (most code moved
6123         from utils.c can_emit_style_escape).
6124         (string_file::string_file, string_file::can_emit_style_escape,
6125         stdio_file::can_emit_style_escape, tee_file::term_out,
6126         tee_file::can_emit_style_escape): New functions.
6127
6128 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6129
6130         * NEWS: Mention the new set|show may-call-functions.
6131         * infcall.c (may_call_functions_p): New variable.
6132         (show_may_call_functions_p): New function.
6133         (call_function_by_hand_dummy): Throws an error if not
6134         may-call-functions.
6135         (_initialize_infcall): Call add_setshow_boolean_cmd for
6136         may-call-functions.
6137
6138 2019-04-25  Keith Seitz  <keiths@redhat.com>
6139
6140         PR c++/24367
6141         * cp-support.c (inspect_type): Don't attempt substitutions
6142         of symbol with the same name.
6143
6144 2019-04-25  Tom Tromey  <tromey@adacore.com>
6145
6146         PR gdb/24475:
6147         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6148         static.
6149
6150 2019-04-25  Tom Tromey  <tromey@adacore.com>
6151
6152         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6153         rvalue reference.
6154         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6155         (gdb_xml_parser::parse): Use std::move.
6156         * python/python-internal.h (gdbpy_convert_exception): Take a const
6157         reference.
6158         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6159         std::move.
6160         * python/py-utils.c (gdbpy_convert_exception): Take a const
6161         reference.
6162         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6163         Use std::move.
6164         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6165         Use std::move.
6166         * mi/mi-main.c (mi_print_exception): Take a const reference.
6167         * main.c (handle_command_errors): Take a const reference.
6168         * linespec.c (parse_linespec): Use std::move.
6169         * infcall.c (run_inferior_call): Use std::move.
6170         (call_function_by_hand_dummy): Use std::move.
6171         * exec.c (try_open_exec_file): Use std::move.
6172         * exceptions.h (exception_print, exception_fprintf)
6173         (exception_print_same): Update.
6174         * exceptions.c (print_exception, exception_print)
6175         (exception_fprintf, exception_print_same): Change parameters to
6176         const reference.
6177         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6178         * common/new-op.c: Use std::move.
6179         * common/common-exceptions.h (struct gdb_exception): Add move
6180         constructor.
6181         (struct gdb_exception_error, struct gdb_exception_quit, struct
6182         gdb_quit_bad_alloc): Change constructor to move constructor.
6183         (throw_exception): Change parameter to rvalue reference.
6184         * common/common-exceptions.c (throw_exception): Take rvalue
6185         reference.
6186         * cli/cli-interp.c (safe_execute_command): Use std::move.
6187         * breakpoint.c (insert_bp_location, location_to_sals): Use
6188         std::move.
6189
6190 2019-04-25  Tom Tromey  <tromey@adacore.com>
6191
6192         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6193         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6194         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6195         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6196         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6197         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6198         guile/scm-value.c: Use unpack.
6199         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6200         gdbscm_gdb_exception.
6201         (gdbscm_throw_gdb_exception): Likewise.
6202         (struct gdbscm_gdb_exception): New.
6203         (unpack): New function.
6204         (gdbscm_wrap): Use unpack.
6205
6206 2019-04-25  Tom Tromey  <tromey@adacore.com>
6207
6208         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6209         (gdb_rl_callback_handler): Use std::move.
6210         * common/common-exceptions.h (struct gdb_exception): Add move
6211         assignment operator.
6212         (throw_exception_sjlj): Change "exception" to const reference.
6213         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6214         (throw_exception_sjlj): Change "exception" to const reference.
6215
6216 2019-04-25  Tom Tromey  <tromey@adacore.com>
6217
6218         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6219         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6220         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6221         Update.
6222         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6223         Update.
6224         * mi/mi-interp.c (mi_interp::exec): Update.
6225         * linespec.c (parse_linespec): Update.
6226         * infcall.c (run_inferior_call): Update.
6227         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6228         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6229         (gdbscm_lookup_global_symbol): Update.
6230         * guile/scm-param.c (gdbscm_parameter_value): Update.
6231         * guile/scm-frame.c (gdbscm_frame_read_register)
6232         (gdbscm_frame_read_var): Update.
6233         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6234         * exec.c (try_open_exec_file): Update.
6235         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6236         (gdb_rl_callback_handler): Update.
6237         * common/common-exceptions.h (exception_none): Don't declare.
6238         * common/common-exceptions.c (exception_none): Don't define.
6239         (struct catcher) <exception>: Update.
6240         * cli/cli-interp.c (safe_execute_command): Update.
6241         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6242
6243 2019-04-25  Ali Tamur  <tamur@google.com>
6244
6245         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6246         (read_attribute_value): Likewise.
6247         (dwarf2_read_addr_index): Update comment.
6248         (read_str_index): Add DW_FORM_strx.
6249         (dwarf2_string_attr): Likewise.
6250         (dwarf2_const_value_attr): Likewise.
6251         (dump_die_shallow): Likewise.
6252         (dwarf2_fetch_constant_bytes): Likewise.
6253         (skip_form_bytes): Likewise.
6254         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6255
6256 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6257
6258         PR corefiles/11608
6259         PR corefiles/18187
6260         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6261         OFFSET.  Verify if current mapping contains an ELF header.
6262         (linux_find_memory_regions_full): Adjust call to
6263         dump_mapping_p.
6264
6265 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6266             Kang Li <kanglictf@gmail.com>
6267
6268         PR gdb/21600
6269
6270         * dwarf2-frame.c (read_initial_length): Be consistent about using
6271         unsigned representation of length.
6272         (decode_frame_entry_1): Likewise.  Check for wraparound of
6273         end pointer as well as buffer overflow.
6274
6275 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6276
6277         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6278         "vq".
6279
6280 2019-04-24  Tom Tromey  <tromey@adacore.com>
6281
6282         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6283
6284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * s12z-tdep.c (s12z_unwind_pc): Delete.
6287         (s12z_unwind_sp): Delete.
6288         (s12z_gdbarch_init): Don't register deleted functions with
6289         gdbarch.
6290
6291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6292
6293         * rl78-tdep.c (rl78_unwind_sp): Delete.
6294         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6295
6296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6299         (xstormy16_unwind_pc): Delete.
6300         (xstormy16_dummy_id): Delete.
6301         (xstormy16_gdbarch_init): Don't register deleted functions with
6302         gdbarch.
6303
6304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6305
6306         * vax-tdep.c (vax_unwind_pc): Delete.
6307         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6308
6309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * v850-tdep.c (v850_unwind_sp): Delete.
6312         (v850_unwind_pc): Delete.
6313         (v850_dummy_id): Delete.
6314         (v850_gdbarch_init): Don't register deleted functions with
6315         gdbarch.
6316
6317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6320         (tilegx_unwind_pc): Delete.
6321         (tilegx_unwind_dummy_id): Delete.
6322         (tilegx_gdbarch_init): Don't register deleted functions with
6323         gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6328         (tic6x_dummy_id): Delete.
6329         (tic6x_gdbarch_init): Don't register deleted functions with
6330         gdbarch.
6331
6332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * sparc-tdep.c (sparc_unwind_pc): Delete.
6335         (sparc32_gdbarch_init): Don't register deleted function with
6336         gdbarch.
6337
6338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6339
6340         * sh-tdep.c (sh_unwind_sp): Delete.
6341         (sh_unwind_pc): Delete.
6342         (sh_dummy_id): Delete.
6343         (sh_gdbarch_init): Don't register deleted functions with
6344         gdbarch.
6345
6346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6347
6348         * score-tdep.c (score_unwind_sp): Delete.
6349         (score_unwind_pc): Delete.
6350         (score_dummy_id): Delete.
6351         (score_gdbarch_init): Don't register deleted functions with
6352         gdbarch.
6353
6354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * rx-tdep.c (rx_unwind_pc): Delete.
6357         (rx_unwind_sp): Delete.
6358         (rx_dummy_id): Delete.
6359         (rx_gdbarch_init): Don't register deleted functions with
6360         gdbarch.  Update comment.
6361
6362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6365         (rs6000_dummy_id): Delete.
6366         (rs6000_gdbarch_init): Don't register deleted functions with
6367         gdbarch.
6368
6369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6370
6371         * or1k-tdep.c (or1k_dummy_id): Delete.
6372         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6373
6374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * nios2-tdep.c (nios2_dummy_id): Delete.
6377         (nios2_unwind_sp): Delete.
6378         (nios2_gdbarch_init): Don't register deleted functions with
6379         gdbarch.
6380
6381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6382
6383         * nds32-tdep.c (nds32_dummy_id): Delete.
6384         (nds32_unwind_pc): Delete.
6385         (nds32_unwind_sp): Delete.
6386         (nds32_gdbarch_init): Don't register deleted functions with
6387         gdbarch.
6388
6389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * msp430-tdep.c (msp430_unwind_pc): Delete.
6392         (msp430_unwind_sp): Delete.
6393         (msp430_dummy_id): Delete.
6394         (msp430_gdbarch_init): Don't register deleted functions with
6395         gdbarch.
6396
6397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6398
6399         * moxie-tdep.c (moxie_unwind_sp): Delete.
6400         (moxie_unwind_pc): Delete.
6401         (moxie_dummy_id): Delete.
6402         (moxie_gdbarch_init): Don't register deleted functions with
6403         gdbarch.
6404
6405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6406
6407         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6408         (mn10300_unwind_pc): Delete.
6409         (mn10300_unwind_sp): Delete.
6410         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6411         mn10300_unwind_sp.
6412         (mn10300_frame_unwind_init): Don't register deleted functions with
6413         gdbarch.
6414
6415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * mep-tdep.c (mep_unwind_pc): Delete.
6418         (mep_unwind_sp): Delete.
6419         (mep_dummy_id): Delete.
6420         (mep_gdbarch_init): Don't register deleted functions with
6421         gdbarch.
6422
6423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6426         (m68hc11_unwind_sp): Delete.
6427         (m68hc11_gdbarch_init): Don't register deleted functions with
6428         gdbarch.
6429
6430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6431
6432         * m32r-tdep.c (m32r_unwind_sp): Delete.
6433         (m32r_unwind_pc): Delete.
6434         (m32r_dummy_id): Delete.
6435         (m32r_gdbarch_init): Don't register deleted functions with
6436         gdbarch.
6437
6438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * m32c-tdep.c (m32c_unwind_pc): Delete.
6441         (m32c_unwind_sp): Delete.
6442         (m32c_dummy_id): Delete.
6443         (m32c_gdbarch_init): Don't register deleted functions with
6444         gdbarch.
6445
6446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6449         (lm32_unwind_pc): Delete.
6450         (lm32_dummy_id): Delete.
6451         (lm32_gdbarch_init): Don't register deleted functions with
6452         gdbarch.
6453
6454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6457         (iq2000_unwind_pc): Delete.
6458         (iq2000_dummy_id): Delete.
6459         (iq2000_gdbarch_init): Don't register deleted functions with
6460         gdbarch.
6461
6462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6463
6464         * nds32-tdep.c (nds32_type_align): Delete.
6465         (nds32_push_dummy_call): Use type_align instead.
6466
6467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * arm-tdep.c (arm_type_align): Only handle vector override case.
6470         (arm_push_dummy_call): Use type_align.
6471         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6472
6473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6476         case.
6477         (pass_on_stack): Use type_align.
6478         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6479         function.
6480
6481 2019-04-23  Tom Tromey  <tromey@adacore.com>
6482
6483         * dwarf2read.c (line_header::file_name_at): Remove unused
6484         overload.
6485
6486 2019-04-23  Tom de Vries  <tdevries@suse.de>
6487
6488         PR gdb/24438
6489         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6490         invocation.
6491
6492
6493 2019-03-27  Ali Tamur  <tamur@google.com>
6494
6495         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6496         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6497         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6498         (dwarf_expr_context::get_addr_index): Likewise
6499         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6500         (symbol_needs_eval_context::get_addr_index): Likewise
6501         (disassemble_dwarf_expression): Add DW_OP_addrx
6502         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6503         (read_cutu_die_from_dwo): Update comment
6504         (skip_one_die): Add DW_FORM_addrx
6505         (read_attribute_value): Likewise
6506         (var_decode_location): Add DW_OP_addrx
6507         (dwarf2_const_value_attr): Add DW_FORM_addrx
6508         (dump_die_shallow): Likewise
6509         (dwarf2_fetch_constant_bytes): Likewise
6510         (decode_locdesc): Add DW_OP_addrx
6511         (skip_form_bytes): Add DW_FORM_addrx
6512
6513 2019-04-22  Ali Tamur  <tamur@google.com>
6514
6515         * MAINTAINERS (Write After Approval): Add self.
6516
6517 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6518
6519         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6520         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6521         (open_symbol_file_object): Likewise.
6522         (svr4_default_sos): Add info parameter.
6523         (svr4_read_so_list): Likewise.
6524         (svr4_current_sos_direct): Adjust functions calls to pass down
6525         info.
6526         (svr4_current_sos_1): Add info parameter.
6527         (svr4_current_sos): Call get_svr4_info, pass info down to
6528         svr4_current_sos_1.
6529         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6530         get_svr4_info.
6531         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6532         get_svr4_info.
6533         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6534         to get_svr4_info.
6535         (probes_table_remove_objfile_probes): Likewise.
6536         (register_solib_event_probe): Add info parameter.
6537         (solist_update_incremental): Pass info parameter down to
6538         svr4_read_so_list.
6539         (disable_probes_interface): Add info parameter.
6540         (svr4_handle_solib_event): Pass current_program_space to
6541         get_svr4_info.  Adjust disable_probes_interface cleanup.
6542         (svr4_create_probe_breakpoints): Add info parameter, pass it
6543         down to register_solib_event_probe.
6544         (svr4_create_solib_event_breakpoints): Add info parameter,
6545         pass it down to svr4_create_probe_breakpoints.
6546         (enable_break): Pass info down to
6547         svr4_create_solib_event_breakpoints.
6548         (svr4_solib_create_inferior_hook): Pass current_program_space to
6549         get_svr4_info.
6550         (svr4_clear_solib): Likewise.
6551
6552 2019-04-22  Pedro Alves  <palves@redhat.com>
6553
6554         * solib-svr4.c (svr4_free_objfile_observer): New.
6555         (probe_and_action::objfile): New field.
6556         (probes_table_htab_remove_objfile_probes)
6557         (probes_table_remove_objfile_probes): New functions.
6558         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6559         in the new probe_and_action.  Don't store the probe in 'lookup'.
6560         (svr4_create_probe_breakpoints): Pass objfile to
6561         register_solib_event_probe.
6562         (_initialize_svr4_solib): Register a free_objfile observer.
6563
6564 2019-04-19  Tom Tromey  <tom@tromey.com>
6565
6566         * common/queue.h: Remove.
6567
6568 2019-04-19  Tom Tromey  <tom@tromey.com>
6569
6570         * event-loop.c: Don't include "common/queue.h".
6571
6572 2019-04-19  Tom Tromey  <tom@tromey.com>
6573
6574         * remote.c (remote_target): Use delete.
6575         * remote-notif.h: Include <list>, not "common/queue.h".
6576         (notif_client_p): Remove typedef.
6577         (remote_notif_state): Add constructor, destructor, initializer.
6578         <notif_queue>: Now a std::list.
6579         (remote_notif_state_xfree): Don't declare.
6580         * remote-notif.c (remote_notif_process, handle_notification)
6581         (remote_notif_state_allocate): Update.
6582         (~remote_notif_state): Rename from remote_notif_state_xfree.
6583
6584 2019-04-19  Tom Tromey  <tom@tromey.com>
6585
6586         * symfile.c (reread_symbols): Update.
6587         * objfiles.c (objfile_register_static_link)
6588         (objfile_lookup_static_link): Update
6589         (~objfile) Don't delete static_links.
6590         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6591
6592 2019-04-19  Tom Tromey  <tom@tromey.com>
6593
6594         * type-stack.h (struct type_stack) <insert>: Constify string.
6595         * type-stack.c (type_stack::insert): Constify string.
6596         * gdbtypes.h (lookup_template_type): Update.
6597         (address_space_name_to_int): Update.
6598         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6599         const.
6600         (lookup_template_type): Make name const.
6601         * c-exp.y: Update rules.
6602         (lex_one_token, classify_name, classify_inner_name)
6603         (c_print_token): Update.
6604         * p-exp.y: Update rules.
6605         (yylex): Update.
6606         * f-exp.y: Update rules.
6607         (yylex): Update.
6608         * d-exp.y: Update rules.
6609         (lex_one_token, classify_name, classify_inner_name): Update.
6610         * parse.c (write_dollar_variable, copy_name): Return std::string.
6611         * parser-defs.h (copy_name): Change return type.
6612         * m2-exp.y: Update rules.
6613         (yylex): Update.
6614         * go-exp.y (lex_one_token): Update.
6615         Update rules.
6616         (classify_unsafe_function, classify_packaged_name)
6617         (classify_name, yylex): Update.
6618
6619 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6620
6621         * configure.ac: add --enable-source-highlight switch.
6622         * configure: Regenerate.
6623         * top.c (print_gdb_version): plumb --enable-source-highlight
6624         status to "show configuration".
6625
6626 2019-04-19  Tom Tromey  <tromey@adacore.com>
6627
6628         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6629         Check ADA_TYPE_P.
6630         (empty_record, ada_template_to_fixed_record_type_1)
6631         (template_to_static_fixed_type)
6632         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6633         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6634         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6635         macros.
6636
6637 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6638
6639         PR symtab/24423:
6640         * source.c (print_source_lines_base): Advance "iter" when a
6641         control character is seen.
6642
6643 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6644
6645         * inferior.h (struct infcall_suspend_state_deleter):
6646         Catch exception in destructor to avoid crash.
6647
6648 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6649
6650         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6651         close to the add_com "shell".
6652
6653 2019-04-18  Tom Tromey  <tromey@adacore.com>
6654
6655         * process-stratum-target.h (class process_stratum_target)
6656         <stratum>: Add "final".
6657
6658 2019-04-17  Tom Tromey  <tromey@adacore.com>
6659
6660         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6661         against nullptr before use.
6662
6663 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6664
6665         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6666
6667 2019-04-17  Jim Wilson  <jimw@sifive.com>
6668             Andrew Burgess  <andrew.burgess@embecosm.com>
6669
6670         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6671         code read might fail, assume 4-byte breakpoint in that case.
6672
6673 2019-04-15  Leszek Swirski  <leszeks@google.com>
6674
6675         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6676         rather than a hand-rolled POD check when checking for forced MEMORY
6677         classification.
6678
6679 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6680
6681         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6682         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6683         function.
6684         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6685         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6686         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6687         declaration.
6688
6689 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6690
6691         * aarch64-linux-nat.c
6692         (aarch64_linux_nat_target::thread_architecture): Add override.
6693         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6694         each VQ.
6695
6696 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6697
6698         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6699
6700 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6701
6702         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6703         target types of size 96-bits, add some additional comments, and
6704         check that the builtin type we found was the correct size.
6705
6706 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6707
6708         * utils.c (prompt_for_continue): Don't restore the styling at the
6709         end, as applied_style has the wrong value.  This fixes styling in
6710         long lists of file names that are interrupted by the "Continue?"
6711         prompt.
6712
6713 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6714
6715         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6716         * c-lang.c (c_language_defn): Likewise.
6717         (cplus_language_defn): Likewise.
6718         (asm_language_defn): Likewise.
6719         (minimal_language_defn): Likewise.
6720         * d-lang.c (d_language_defn): Likewise.
6721         * f-lang.c (f_language_defn): Likewise.
6722         * go-lang.c (go_language_defn): Likewise.
6723         * language.c (unknown_language_defn): Likewise.
6724         (auto_language_defn): Likewise.
6725         * language.h (struct language_defn): Remove la_magic field.
6726         (LANG_MAGIC): Delete.
6727         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6728         * objc-lang.c (objc_language_defn): Likewise.
6729         * opencl-lang.c (opencl_language_defn): Likewise.
6730         * p-lang.c (pascal_language_defn): Likewise.
6731         * rust-lang.c (rust_language_defn): Likewise.
6732
6733 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6734
6735         * riscv-tdep.c (riscv_type_align): New function.
6736         (riscv_type_alignment): Delete.
6737         (riscv_arg_location): Use 'type_align'.
6738         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6739
6740 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6741
6742         * gdbtypes.c (type_align): A struct with no non-static fields also
6743         has alignment of 1.
6744
6745 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6746
6747         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6748         component to 0.
6749         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6750         member.
6751         (riscv_struct_info::analyse): New implementation using new
6752         analyse_inner member function.
6753         (riscv_struct_info::field_offset): New member function.
6754         (riscv_struct_info::m_offsets): New member variable.
6755         (riscv_struct_info::analyse_inner): New private member function,
6756         takes the old implementation of riscv_struct_info::analyse but
6757         extended to track field offsets.
6758         (riscv_call_arg_struct): Update the struct folding special cases
6759         to handle cases where empty C++ structs, which are non-zero
6760         length, are found.
6761         (riscv_arg_location): Initialise the length of each location, a
6762         non-zero length now indicates the location is in use.
6763         (riscv_push_dummy_call): Allow for the first location having a
6764         non-zero offset when setting up arguments.
6765         (riscv_return_value): Likewise, but for return values.
6766
6767 2019-04-11  Tom Tromey  <tromey@adacore.com>
6768
6769         * utils.c (internal_vproblem): Make "msg" const.
6770
6771 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6772
6773         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6774         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6775         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6776         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6777
6778 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6779
6780         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6781         function.
6782         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6783         of amd64_collect_native_gregset.
6784         (amd64_linux_nat_target::store_registers): Likewise.
6785
6786 2019-04-10  Tom Tromey  <tom@tromey.com>
6787
6788         * symtab.c (lookup_global_symbol_from_objfile)
6789         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6790         * objfiles.h (class separate_debug_iterator): New.
6791         (class separate_debug_range): New.
6792         (struct objfile) <separate_debug_objfiles>: New method.
6793         (objfile_separate_debug_iterate): Don't declare.
6794         * objfiles.c (separate_debug_iterator::operator++): Rename from
6795         objfile_separate_debug_iterate.
6796         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6797         iterator.
6798         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6799         iterator.
6800
6801 2019-04-10  Tom Tromey  <tom@tromey.com>
6802
6803         * symfile.c (reread_symbols): Remove old comment.
6804         * objfiles.c (free_all_objfiles): Fix a typo.
6805
6806 2019-04-10  Tom Tromey  <tom@tromey.com>
6807
6808         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6809         * minsyms.c (lookup_minimal_symbol): Use foreach.
6810         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6811         (lookup_minimal_symbol_solib_trampoline): Likewise.
6812         * symfile.c (reread_symbols): Use foreach.
6813
6814 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6815             Tom Tromey  <tromey@adacore.com>
6816
6817         PR rust/24414:
6818         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6819         (rust_lex_int_test): Change "value" to be LONGEST.
6820         (rust_lex_tests): Add test for long integer literal.
6821
6822 2019-04-09  Tom Tromey  <tromey@adacore.com>
6823
6824         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6825         to bool.
6826         (extended_remote_target::attach): Update.
6827         (remote_target::remote_notice_new_inferior): Update.
6828         (remote_target::add_current_inferior_and_thread): Update.
6829         * inferior.c (exit_inferior_1): Use "false".
6830         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6831
6832 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6833
6834         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6835         the "start" command.
6836
6837 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6838
6839         * python/py-inferior.c (infpy_thread_from_thread_handle):
6840         Adjust comments to reflect renaming of thread_from_thread_handle
6841         to thread_from_handle.  Adjust keywords.  Fix type error message.
6842         (inferior_object_methods): Add thread_from_handle.  Retain
6843         thread_from_thread_handle, but mark it as deprecated.
6844
6845 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6846
6847         * gdbthread.h (find_thread_by_handle): Revise declaration.
6848         * thread.c (find_thread_by_handle): Likewise.  Adjust
6849         implementation too.
6850         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6851         support for buffer objects as handles.
6852
6853 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6854
6855         * python/py-infthread.c (thpy_thread_handle): New function.
6856         (thread_object_methods): Register thpy_thread_handle.
6857
6858 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6859
6860         * gdbthread.h (thread_to_thread_handle): Declare.
6861         * thread.c (gdbtypes.h): Include.
6862         (thread_to_thread_handle): New function.
6863
6864         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6865         (target_thread_info_to_thread_handle): Declare.
6866         * target.c (target_thread_info_to_thread_handle): New function.
6867         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6868         * target-delegates.c: Regenerate.
6869
6870         * linux-thread-db.c (class thread_db_target): Add method
6871         thread_info_to_thread_handle.
6872         (thread_db_target::thread_info_to_thread_handle): Define.
6873         * remote.c (class remote_target): Add new method
6874         thread_info_to_thread_handle.
6875         (remote_target::thread_info_to_thread_handle): Define.
6876
6877 2019-04-08  Pedro Alves  <palves@redhat.com>
6878
6879         * common/common-exceptions.c (throw_exception): Don't create
6880         named object to throw; throw directly.
6881         (throw_it): Likewise.  Don't initialize gdb_exception::message
6882         here, with new; pass FMT and AP to the ctor instead.
6883         * common/common-exceptions.h: Include <string>.
6884         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6885         const char *, va_list)): New ctor.  Use std::make_shared.
6886         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6887         errors)): Delete.
6888         (gdb_exception_error::gdb_exception_error(enum errors, const char
6889         *, va_list)): New.
6890         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6891         Add assertion.
6892         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6893         errors)): Delete.
6894         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6895         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6896         Add assertion.
6897
6898 2019-04-08  Tom Tromey  <tom@tromey.com>
6899
6900         * valops.c (value_rtti_indirect_type): Replace throw_exception
6901         with throw.
6902         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6903         with throw.
6904         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6905         throw.
6906         * target.c (target_translate_tls_address): Replace throw_exception
6907         with throw.
6908         * stack.c (frame_apply_command_count): Replace throw_exception
6909         with throw.
6910         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6911         throw.
6912         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6913         with throw.
6914         * rs6000-tdep.c (rs6000_frame_cache)
6915         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6916         * remote.c: Replace throw_exception with throw.
6917         * record-full.c (record_full_message, record_full_wait_1)
6918         (record_full_restore): Replace throw_exception with throw.
6919         * record-btrace.c:
6920         (get_thread_current_frame_id, record_btrace_start_replaying)
6921         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6922         (cmd_record_btrace_start): Replace throw_exception with throw.
6923         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6924         throw.
6925         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6926         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6927         * linespec.c:
6928         (find_linespec_symbols): Replace throw_exception with throw.
6929         * infrun.c (displaced_step_prepare, resume): Replace
6930         throw_exception with throw.
6931         * infcmd.c (post_create_inferior): Replace throw_exception with
6932         throw.
6933         * inf-loop.c (inferior_event_handler): Replace throw_exception
6934         with throw.
6935         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6936         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6937         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6938         (get_prev_frame_always, get_frame_pc_if_available)
6939         (get_frame_address_in_block_if_available, get_frame_language):
6940         Replace throw_exception with throw.
6941         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6942         throw_exception with throw.
6943         * eval.c (fetch_subexp_value, evaluate_var_value)
6944         (evaluate_funcall, evaluate_subexp_standard): Replace
6945         throw_exception with throw.
6946         * dwarf2loc.c (call_site_find_chain)
6947         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6948         Replace throw_exception with throw.
6949         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6950         with throw.
6951         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6952         throw.
6953         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6954         * completer.c (complete_line_internal): Replace throw_exception
6955         with throw.
6956         * compile/compile-object-run.c (compile_object_run): Replace
6957         throw_exception with throw.
6958         * cli/cli-script.c (process_next_line): Replace throw_exception
6959         with throw.
6960         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6961         (btrace_enable, btrace_maint_update_pt_packets): Replace
6962         throw_exception with throw.
6963         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6964         throw_exception with throw.
6965         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6966         throw_exception with throw.
6967         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6968         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6969         * aarch64-tdep.c (aarch64_make_prologue_cache)
6970         (aarch64_make_stub_cache): Replace throw_exception with throw.
6971
6972 2019-04-08  Tom Tromey  <tom@tromey.com>
6973
6974         * common/common-exceptions.c (throw_exception): Rename from
6975         throw_exception_cxx.  Remove old copy.  Make argument const.
6976         (throw_it): Create and throw exception objects directly.
6977         * common/common-exceptions.h (throw_exception): Make argument
6978         const.
6979         (struct gdb_exception_error): Add constructor.
6980         (struct gdb_exception_quit): Add constructor.
6981
6982 2019-04-08  Tom Tromey  <tom@tromey.com>
6983
6984         * common/common-exceptions.h (exception_rethrow): Don't declare.
6985         (TRY_SJLJ): Update comment.
6986         (TRY, CATCH, END_CATCH): Remove.
6987         * common/common-exceptions.c (exception_rethrow): Remove.
6988
6989 2019-04-08  Tom Tromey  <tom@tromey.com>
6990
6991         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6992         Remove.
6993         (gdb_exception_error): Rename from
6994         gdb_exception_RETURN_MASK_ERROR.
6995         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6996         (gdb_quit_bad_alloc): Update.
6997         * aarch64-tdep.c: Update.
6998         * ada-lang.c: Update.
6999         * ada-typeprint.c: Update.
7000         * ada-valprint.c: Update.
7001         * amd64-tdep.c: Update.
7002         * arch-utils.c: Update.
7003         * break-catch-throw.c: Update.
7004         * breakpoint.c: Update.
7005         * btrace.c: Update.
7006         * c-varobj.c: Update.
7007         * cli/cli-cmds.c: Update.
7008         * cli/cli-interp.c: Update.
7009         * cli/cli-script.c: Update.
7010         * common/common-exceptions.c: Update.
7011         * common/new-op.c: Update.
7012         * common/selftest.c: Update.
7013         * compile/compile-c-symbols.c: Update.
7014         * compile/compile-cplus-symbols.c: Update.
7015         * compile/compile-object-load.c: Update.
7016         * compile/compile-object-run.c: Update.
7017         * completer.c: Update.
7018         * corelow.c: Update.
7019         * cp-abi.c: Update.
7020         * cp-support.c: Update.
7021         * cp-valprint.c: Update.
7022         * darwin-nat.c: Update.
7023         * disasm-selftests.c: Update.
7024         * dtrace-probe.c: Update.
7025         * dwarf-index-cache.c: Update.
7026         * dwarf-index-write.c: Update.
7027         * dwarf2-frame-tailcall.c: Update.
7028         * dwarf2-frame.c: Update.
7029         * dwarf2loc.c: Update.
7030         * dwarf2read.c: Update.
7031         * eval.c: Update.
7032         * event-loop.c: Update.
7033         * event-top.c: Update.
7034         * exec.c: Update.
7035         * f-valprint.c: Update.
7036         * fbsd-tdep.c: Update.
7037         * frame-unwind.c: Update.
7038         * frame.c: Update.
7039         * gdbtypes.c: Update.
7040         * gnu-v3-abi.c: Update.
7041         * guile/guile-internal.h: Update.
7042         * guile/scm-block.c: Update.
7043         * guile/scm-breakpoint.c: Update.
7044         * guile/scm-cmd.c: Update.
7045         * guile/scm-disasm.c: Update.
7046         * guile/scm-frame.c: Update.
7047         * guile/scm-lazy-string.c: Update.
7048         * guile/scm-math.c: Update.
7049         * guile/scm-param.c: Update.
7050         * guile/scm-ports.c: Update.
7051         * guile/scm-pretty-print.c: Update.
7052         * guile/scm-symbol.c: Update.
7053         * guile/scm-symtab.c: Update.
7054         * guile/scm-type.c: Update.
7055         * guile/scm-value.c: Update.
7056         * i386-linux-tdep.c: Update.
7057         * i386-tdep.c: Update.
7058         * inf-loop.c: Update.
7059         * infcall.c: Update.
7060         * infcmd.c: Update.
7061         * infrun.c: Update.
7062         * jit.c: Update.
7063         * language.c: Update.
7064         * linespec.c: Update.
7065         * linux-fork.c: Update.
7066         * linux-nat.c: Update.
7067         * linux-tdep.c: Update.
7068         * linux-thread-db.c: Update.
7069         * main.c: Update.
7070         * mi/mi-cmd-break.c: Update.
7071         * mi/mi-cmd-stack.c: Update.
7072         * mi/mi-interp.c: Update.
7073         * mi/mi-main.c: Update.
7074         * objc-lang.c: Update.
7075         * p-valprint.c: Update.
7076         * parse.c: Update.
7077         * ppc-linux-tdep.c: Update.
7078         * printcmd.c: Update.
7079         * python/py-arch.c: Update.
7080         * python/py-breakpoint.c: Update.
7081         * python/py-cmd.c: Update.
7082         * python/py-finishbreakpoint.c: Update.
7083         * python/py-frame.c: Update.
7084         * python/py-framefilter.c: Update.
7085         * python/py-gdb-readline.c: Update.
7086         * python/py-inferior.c: Update.
7087         * python/py-infthread.c: Update.
7088         * python/py-lazy-string.c: Update.
7089         * python/py-linetable.c: Update.
7090         * python/py-objfile.c: Update.
7091         * python/py-param.c: Update.
7092         * python/py-prettyprint.c: Update.
7093         * python/py-progspace.c: Update.
7094         * python/py-record-btrace.c: Update.
7095         * python/py-record.c: Update.
7096         * python/py-symbol.c: Update.
7097         * python/py-type.c: Update.
7098         * python/py-unwind.c: Update.
7099         * python/py-utils.c: Update.
7100         * python/py-value.c: Update.
7101         * python/python.c: Update.
7102         * record-btrace.c: Update.
7103         * record-full.c: Update.
7104         * remote-fileio.c: Update.
7105         * remote.c: Update.
7106         * riscv-tdep.c: Update.
7107         * rs6000-aix-tdep.c: Update.
7108         * rs6000-tdep.c: Update.
7109         * rust-exp.y: Update.
7110         * rust-lang.c: Update.
7111         * s390-tdep.c: Update.
7112         * selftest-arch.c: Update.
7113         * solib-dsbt.c: Update.
7114         * solib-frv.c: Update.
7115         * solib-spu.c: Update.
7116         * solib-svr4.c: Update.
7117         * solib.c: Update.
7118         * sparc64-linux-tdep.c: Update.
7119         * stack.c: Update.
7120         * symfile-mem.c: Update.
7121         * symmisc.c: Update.
7122         * target.c: Update.
7123         * thread.c: Update.
7124         * top.c: Update.
7125         * tracefile-tfile.c: Update.
7126         * tui/tui.c: Update.
7127         * typeprint.c: Update.
7128         * unittests/cli-utils-selftests.c: Update.
7129         * unittests/parse-connection-spec-selftests.c: Update.
7130         * valops.c: Update.
7131         * valprint.c: Update.
7132         * value.c: Update.
7133         * varobj.c: Update.
7134         * windows-nat.c: Update.
7135         * x86-linux-nat.c: Update.
7136         * xml-support.c: Update.
7137
7138 2019-04-08  Tom Tromey  <tom@tromey.com>
7139
7140         * xml-support.c: Use C++ exception handling.
7141         * x86-linux-nat.c: Use C++ exception handling.
7142         * windows-nat.c: Use C++ exception handling.
7143         * varobj.c: Use C++ exception handling.
7144         * value.c: Use C++ exception handling.
7145         * valprint.c: Use C++ exception handling.
7146         * valops.c: Use C++ exception handling.
7147         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7148         handling.
7149         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7150         * typeprint.c: Use C++ exception handling.
7151         * tui/tui.c: Use C++ exception handling.
7152         * tracefile-tfile.c: Use C++ exception handling.
7153         * top.c: Use C++ exception handling.
7154         * thread.c: Use C++ exception handling.
7155         * target.c: Use C++ exception handling.
7156         * symmisc.c: Use C++ exception handling.
7157         * symfile-mem.c: Use C++ exception handling.
7158         * stack.c: Use C++ exception handling.
7159         * sparc64-linux-tdep.c: Use C++ exception handling.
7160         * solib.c: Use C++ exception handling.
7161         * solib-svr4.c: Use C++ exception handling.
7162         * solib-spu.c: Use C++ exception handling.
7163         * solib-frv.c: Use C++ exception handling.
7164         * solib-dsbt.c: Use C++ exception handling.
7165         * selftest-arch.c: Use C++ exception handling.
7166         * s390-tdep.c: Use C++ exception handling.
7167         * rust-lang.c: Use C++ exception handling.
7168         * rust-exp.y: Use C++ exception handling.
7169         * rs6000-tdep.c: Use C++ exception handling.
7170         * rs6000-aix-tdep.c: Use C++ exception handling.
7171         * riscv-tdep.c: Use C++ exception handling.
7172         * remote.c: Use C++ exception handling.
7173         * remote-fileio.c: Use C++ exception handling.
7174         * record-full.c: Use C++ exception handling.
7175         * record-btrace.c: Use C++ exception handling.
7176         * python/python.c: Use C++ exception handling.
7177         * python/py-value.c: Use C++ exception handling.
7178         * python/py-utils.c: Use C++ exception handling.
7179         * python/py-unwind.c: Use C++ exception handling.
7180         * python/py-type.c: Use C++ exception handling.
7181         * python/py-symbol.c: Use C++ exception handling.
7182         * python/py-record.c: Use C++ exception handling.
7183         * python/py-record-btrace.c: Use C++ exception handling.
7184         * python/py-progspace.c: Use C++ exception handling.
7185         * python/py-prettyprint.c: Use C++ exception handling.
7186         * python/py-param.c: Use C++ exception handling.
7187         * python/py-objfile.c: Use C++ exception handling.
7188         * python/py-linetable.c: Use C++ exception handling.
7189         * python/py-lazy-string.c: Use C++ exception handling.
7190         * python/py-infthread.c: Use C++ exception handling.
7191         * python/py-inferior.c: Use C++ exception handling.
7192         * python/py-gdb-readline.c: Use C++ exception handling.
7193         * python/py-framefilter.c: Use C++ exception handling.
7194         * python/py-frame.c: Use C++ exception handling.
7195         * python/py-finishbreakpoint.c: Use C++ exception handling.
7196         * python/py-cmd.c: Use C++ exception handling.
7197         * python/py-breakpoint.c: Use C++ exception handling.
7198         * python/py-arch.c: Use C++ exception handling.
7199         * printcmd.c: Use C++ exception handling.
7200         * ppc-linux-tdep.c: Use C++ exception handling.
7201         * parse.c: Use C++ exception handling.
7202         * p-valprint.c: Use C++ exception handling.
7203         * objc-lang.c: Use C++ exception handling.
7204         * mi/mi-main.c: Use C++ exception handling.
7205         * mi/mi-interp.c: Use C++ exception handling.
7206         * mi/mi-cmd-stack.c: Use C++ exception handling.
7207         * mi/mi-cmd-break.c: Use C++ exception handling.
7208         * main.c: Use C++ exception handling.
7209         * linux-thread-db.c: Use C++ exception handling.
7210         * linux-tdep.c: Use C++ exception handling.
7211         * linux-nat.c: Use C++ exception handling.
7212         * linux-fork.c: Use C++ exception handling.
7213         * linespec.c: Use C++ exception handling.
7214         * language.c: Use C++ exception handling.
7215         * jit.c: Use C++ exception handling.
7216         * infrun.c: Use C++ exception handling.
7217         * infcmd.c: Use C++ exception handling.
7218         * infcall.c: Use C++ exception handling.
7219         * inf-loop.c: Use C++ exception handling.
7220         * i386-tdep.c: Use C++ exception handling.
7221         * i386-linux-tdep.c: Use C++ exception handling.
7222         * guile/scm-value.c: Use C++ exception handling.
7223         * guile/scm-type.c: Use C++ exception handling.
7224         * guile/scm-symtab.c: Use C++ exception handling.
7225         * guile/scm-symbol.c: Use C++ exception handling.
7226         * guile/scm-pretty-print.c: Use C++ exception handling.
7227         * guile/scm-ports.c: Use C++ exception handling.
7228         * guile/scm-param.c: Use C++ exception handling.
7229         * guile/scm-math.c: Use C++ exception handling.
7230         * guile/scm-lazy-string.c: Use C++ exception handling.
7231         * guile/scm-frame.c: Use C++ exception handling.
7232         * guile/scm-disasm.c: Use C++ exception handling.
7233         * guile/scm-cmd.c: Use C++ exception handling.
7234         * guile/scm-breakpoint.c: Use C++ exception handling.
7235         * guile/scm-block.c: Use C++ exception handling.
7236         * guile/guile-internal.h: Use C++ exception handling.
7237         * gnu-v3-abi.c: Use C++ exception handling.
7238         * gdbtypes.c: Use C++ exception handling.
7239         * frame.c: Use C++ exception handling.
7240         * frame-unwind.c: Use C++ exception handling.
7241         * fbsd-tdep.c: Use C++ exception handling.
7242         * f-valprint.c: Use C++ exception handling.
7243         * exec.c: Use C++ exception handling.
7244         * event-top.c: Use C++ exception handling.
7245         * event-loop.c: Use C++ exception handling.
7246         * eval.c: Use C++ exception handling.
7247         * dwarf2read.c: Use C++ exception handling.
7248         * dwarf2loc.c: Use C++ exception handling.
7249         * dwarf2-frame.c: Use C++ exception handling.
7250         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7251         * dwarf-index-write.c: Use C++ exception handling.
7252         * dwarf-index-cache.c: Use C++ exception handling.
7253         * dtrace-probe.c: Use C++ exception handling.
7254         * disasm-selftests.c: Use C++ exception handling.
7255         * darwin-nat.c: Use C++ exception handling.
7256         * cp-valprint.c: Use C++ exception handling.
7257         * cp-support.c: Use C++ exception handling.
7258         * cp-abi.c: Use C++ exception handling.
7259         * corelow.c: Use C++ exception handling.
7260         * completer.c: Use C++ exception handling.
7261         * compile/compile-object-run.c: Use C++ exception handling.
7262         * compile/compile-object-load.c: Use C++ exception handling.
7263         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7264         * compile/compile-c-symbols.c: Use C++ exception handling.
7265         * common/selftest.c: Use C++ exception handling.
7266         * common/new-op.c: Use C++ exception handling.
7267         * cli/cli-script.c: Use C++ exception handling.
7268         * cli/cli-interp.c: Use C++ exception handling.
7269         * cli/cli-cmds.c: Use C++ exception handling.
7270         * c-varobj.c: Use C++ exception handling.
7271         * btrace.c: Use C++ exception handling.
7272         * breakpoint.c: Use C++ exception handling.
7273         * break-catch-throw.c: Use C++ exception handling.
7274         * arch-utils.c: Use C++ exception handling.
7275         * amd64-tdep.c: Use C++ exception handling.
7276         * ada-valprint.c: Use C++ exception handling.
7277         * ada-typeprint.c: Use C++ exception handling.
7278         * ada-lang.c: Use C++ exception handling.
7279         * aarch64-tdep.c: Use C++ exception handling.
7280
7281 2019-04-08  Tom Tromey  <tom@tromey.com>
7282
7283         * xml-support.c (gdb_xml_parser::parse): Update.
7284         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7285         * value.c (show_convenience): Update.
7286         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7287         (test_parse_flags_qcs): Update.
7288         * thread.c (thr_try_catch_cmd): Update.
7289         * target.c (target_translate_tls_address): Update.
7290         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7291         (info_frame_command_core, frame_apply_command_count): Update.
7292         * rust-exp.y (rust_lex_exception_test): Update.
7293         * riscv-tdep.c (riscv_print_one_register_info): Update.
7294         * remote.c (remote_target::enable_btrace): Update.
7295         * record-btrace.c (record_btrace_enable_warn): Update.
7296         * python/py-utils.c (gdbpy_convert_exception): Update.
7297         * printcmd.c (do_one_display, print_variable_and_value): Update.
7298         * mi/mi-main.c (mi_print_exception): Update.
7299         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7300         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7301         * linux-nat.c (linux_nat_target::attach): Update.
7302         * linux-fork.c (class scoped_switch_fork_info): Update.
7303         * infrun.c (displaced_step_prepare): Update.
7304         * infcall.c (call_function_by_hand_dummy): Update.
7305         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7306         * gnu-v3-abi.c (print_one_vtable): Update.
7307         * frame.c (get_prev_frame_always): Update.
7308         * f-valprint.c (info_common_command_for_block): Update.
7309         * exec.c (try_open_exec_file): Update.
7310         * exceptions.c (print_exception, exception_print)
7311         (exception_fprintf, exception_print_same): Update.
7312         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7313         * dwarf-index-cache.c (index_cache::store)
7314         (index_cache::lookup_gdb_index): Update.
7315         * darwin-nat.c (maybe_cache_shell): Update.
7316         * cp-valprint.c (cp_print_value_fields): Update.
7317         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7318         (gcc_cplus_symbol_address): Update.
7319         * compile/compile-c-symbols.c (gcc_convert_symbol)
7320         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7321         * common/selftest.c: Update.
7322         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7323         a std::string.
7324         (exception_try_scope_entry, exception_try_scope_exit): Don't
7325         declare.
7326         (struct exception_try_scope): Remove.
7327         (TRY): Don't use exception_try_scope.
7328         (struct gdb_exception): Add constructor, operator=.
7329         <what>: New method.
7330         (struct gdb_exception_RETURN_MASK_ALL)
7331         (struct gdb_exception_RETURN_MASK_ERROR)
7332         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7333         (struct gdb_quit_bad_alloc): Update.
7334         * common/common-exceptions.c (exception_none): Change
7335         initializer.
7336         (struct catcher) <state, exception>: Initialize inline.
7337         <prev>: Remove member.
7338         (current_catcher): Remove.
7339         (catchers): New global.
7340         (exceptions_state_mc_init): Simplify.
7341         (catcher_pop): Remove.
7342         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7343         (try_scope_depth, exception_try_scope_entry)
7344         (exception_try_scope_exit): Remove.
7345         (throw_exception_sjlj): Update.
7346         (exception_messages, exception_messages_size): Remove.
7347         (throw_it): Simplify.
7348         (gdb_exception_sliced_copy): Remove.
7349         (throw_exception_cxx): Update.
7350         * cli/cli-script.c (script_from_file): Update.
7351         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7352         Update.
7353         * ada-valprint.c (ada_val_print): Update.
7354         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7355         (create_excep_cond_exprs): Update.
7356
7357 2019-04-08  Tom Tromey  <tom@tromey.com>
7358
7359         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7360         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7361         (TRY, CATCH, END_CATCH): Remove some definitions.
7362         * common/common-exceptions.c: Don't use GDB_XCPT.
7363         (catcher_list_size): Remove.
7364         (throw_exception, throw_it): Simplify.
7365
7366 2019-04-05  Tom Tromey  <tom@tromey.com>
7367
7368         Revert the header-sorting patch.
7369         * ft32-tdep.c: Revert.
7370         * frv-tdep.c: Revert.
7371         * frv-linux-tdep.c: Revert.
7372         * frame.c: Revert.
7373         * frame-unwind.c: Revert.
7374         * frame-base.c: Revert.
7375         * fork-child.c: Revert.
7376         * findvar.c: Revert.
7377         * findcmd.c: Revert.
7378         * filesystem.c: Revert.
7379         * filename-seen-cache.h: Revert.
7380         * filename-seen-cache.c: Revert.
7381         * fbsd-tdep.c: Revert.
7382         * fbsd-nat.h: Revert.
7383         * fbsd-nat.c: Revert.
7384         * f-valprint.c: Revert.
7385         * f-typeprint.c: Revert.
7386         * f-lang.c: Revert.
7387         * extension.h: Revert.
7388         * extension.c: Revert.
7389         * extension-priv.h: Revert.
7390         * expprint.c: Revert.
7391         * exec.h: Revert.
7392         * exec.c: Revert.
7393         * exceptions.c: Revert.
7394         * event-top.c: Revert.
7395         * event-loop.c: Revert.
7396         * eval.c: Revert.
7397         * elfread.c: Revert.
7398         * dwarf2read.h: Revert.
7399         * dwarf2read.c: Revert.
7400         * dwarf2loc.c: Revert.
7401         * dwarf2expr.h: Revert.
7402         * dwarf2expr.c: Revert.
7403         * dwarf2-frame.c: Revert.
7404         * dwarf2-frame-tailcall.c: Revert.
7405         * dwarf-index-write.h: Revert.
7406         * dwarf-index-write.c: Revert.
7407         * dwarf-index-common.c: Revert.
7408         * dwarf-index-cache.h: Revert.
7409         * dwarf-index-cache.c: Revert.
7410         * dummy-frame.c: Revert.
7411         * dtrace-probe.c: Revert.
7412         * disasm.h: Revert.
7413         * disasm.c: Revert.
7414         * disasm-selftests.c: Revert.
7415         * dictionary.c: Revert.
7416         * dicos-tdep.c: Revert.
7417         * demangle.c: Revert.
7418         * dcache.h: Revert.
7419         * dcache.c: Revert.
7420         * darwin-nat.h: Revert.
7421         * darwin-nat.c: Revert.
7422         * darwin-nat-info.c: Revert.
7423         * d-valprint.c: Revert.
7424         * d-namespace.c: Revert.
7425         * d-lang.c: Revert.
7426         * ctf.c: Revert.
7427         * csky-tdep.c: Revert.
7428         * csky-linux-tdep.c: Revert.
7429         * cris-tdep.c: Revert.
7430         * cris-linux-tdep.c: Revert.
7431         * cp-valprint.c: Revert.
7432         * cp-support.c: Revert.
7433         * cp-namespace.c: Revert.
7434         * cp-abi.c: Revert.
7435         * corelow.c: Revert.
7436         * corefile.c: Revert.
7437         * continuations.c: Revert.
7438         * completer.h: Revert.
7439         * completer.c: Revert.
7440         * complaints.c: Revert.
7441         * coffread.c: Revert.
7442         * coff-pe-read.c: Revert.
7443         * cli-out.h: Revert.
7444         * cli-out.c: Revert.
7445         * charset.c: Revert.
7446         * c-varobj.c: Revert.
7447         * c-valprint.c: Revert.
7448         * c-typeprint.c: Revert.
7449         * c-lang.c: Revert.
7450         * buildsym.c: Revert.
7451         * buildsym-legacy.c: Revert.
7452         * build-id.h: Revert.
7453         * build-id.c: Revert.
7454         * btrace.c: Revert.
7455         * bsd-uthread.c: Revert.
7456         * breakpoint.h: Revert.
7457         * breakpoint.c: Revert.
7458         * break-catch-throw.c: Revert.
7459         * break-catch-syscall.c: Revert.
7460         * break-catch-sig.c: Revert.
7461         * blockframe.c: Revert.
7462         * block.c: Revert.
7463         * bfin-tdep.c: Revert.
7464         * bfin-linux-tdep.c: Revert.
7465         * bfd-target.c: Revert.
7466         * bcache.c: Revert.
7467         * ax-general.c: Revert.
7468         * ax-gdb.h: Revert.
7469         * ax-gdb.c: Revert.
7470         * avr-tdep.c: Revert.
7471         * auxv.c: Revert.
7472         * auto-load.c: Revert.
7473         * arm-wince-tdep.c: Revert.
7474         * arm-tdep.c: Revert.
7475         * arm-symbian-tdep.c: Revert.
7476         * arm-pikeos-tdep.c: Revert.
7477         * arm-obsd-tdep.c: Revert.
7478         * arm-nbsd-tdep.c: Revert.
7479         * arm-nbsd-nat.c: Revert.
7480         * arm-linux-tdep.c: Revert.
7481         * arm-linux-nat.c: Revert.
7482         * arm-fbsd-tdep.c: Revert.
7483         * arm-fbsd-nat.c: Revert.
7484         * arm-bsd-tdep.c: Revert.
7485         * arch-utils.c: Revert.
7486         * arc-tdep.c: Revert.
7487         * arc-newlib-tdep.c: Revert.
7488         * annotate.h: Revert.
7489         * annotate.c: Revert.
7490         * amd64-windows-tdep.c: Revert.
7491         * amd64-windows-nat.c: Revert.
7492         * amd64-tdep.c: Revert.
7493         * amd64-sol2-tdep.c: Revert.
7494         * amd64-obsd-tdep.c: Revert.
7495         * amd64-obsd-nat.c: Revert.
7496         * amd64-nbsd-tdep.c: Revert.
7497         * amd64-nbsd-nat.c: Revert.
7498         * amd64-nat.c: Revert.
7499         * amd64-linux-tdep.c: Revert.
7500         * amd64-linux-nat.c: Revert.
7501         * amd64-fbsd-tdep.c: Revert.
7502         * amd64-fbsd-nat.c: Revert.
7503         * amd64-dicos-tdep.c: Revert.
7504         * amd64-darwin-tdep.c: Revert.
7505         * amd64-bsd-nat.c: Revert.
7506         * alpha-tdep.c: Revert.
7507         * alpha-obsd-tdep.c: Revert.
7508         * alpha-nbsd-tdep.c: Revert.
7509         * alpha-mdebug-tdep.c: Revert.
7510         * alpha-linux-tdep.c: Revert.
7511         * alpha-linux-nat.c: Revert.
7512         * alpha-bsd-tdep.c: Revert.
7513         * alpha-bsd-nat.c: Revert.
7514         * aix-thread.c: Revert.
7515         * agent.c: Revert.
7516         * addrmap.c: Revert.
7517         * ada-varobj.c: Revert.
7518         * ada-valprint.c: Revert.
7519         * ada-typeprint.c: Revert.
7520         * ada-tasks.c: Revert.
7521         * ada-lang.c: Revert.
7522         * aarch64-tdep.c: Revert.
7523         * aarch64-ravenscar-thread.c: Revert.
7524         * aarch64-newlib-tdep.c: Revert.
7525         * aarch64-linux-tdep.c: Revert.
7526         * aarch64-linux-nat.c: Revert.
7527         * aarch64-fbsd-tdep.c: Revert.
7528         * aarch64-fbsd-nat.c: Revert.
7529         * aarch32-linux-nat.c: Revert.
7530
7531 2019-04-05  Tom Tromey  <tom@tromey.com>
7532
7533         * ft32-tdep.c: Sort headers.
7534         * frv-tdep.c: Sort headers.
7535         * frv-linux-tdep.c: Sort headers.
7536         * frame.c: Sort headers.
7537         * frame-unwind.c: Sort headers.
7538         * frame-base.c: Sort headers.
7539         * fork-child.c: Sort headers.
7540         * findvar.c: Sort headers.
7541         * findcmd.c: Sort headers.
7542         * filesystem.c: Sort headers.
7543         * filename-seen-cache.h: Sort headers.
7544         * filename-seen-cache.c: Sort headers.
7545         * fbsd-tdep.c: Sort headers.
7546         * fbsd-nat.h: Sort headers.
7547         * fbsd-nat.c: Sort headers.
7548         * f-valprint.c: Sort headers.
7549         * f-typeprint.c: Sort headers.
7550         * f-lang.c: Sort headers.
7551         * extension.h: Sort headers.
7552         * extension.c: Sort headers.
7553         * extension-priv.h: Sort headers.
7554         * expprint.c: Sort headers.
7555         * exec.h: Sort headers.
7556         * exec.c: Sort headers.
7557         * exceptions.c: Sort headers.
7558         * event-top.c: Sort headers.
7559         * event-loop.c: Sort headers.
7560         * eval.c: Sort headers.
7561         * elfread.c: Sort headers.
7562         * dwarf2read.h: Sort headers.
7563         * dwarf2read.c: Sort headers.
7564         * dwarf2loc.c: Sort headers.
7565         * dwarf2expr.h: Sort headers.
7566         * dwarf2expr.c: Sort headers.
7567         * dwarf2-frame.c: Sort headers.
7568         * dwarf2-frame-tailcall.c: Sort headers.
7569         * dwarf-index-write.h: Sort headers.
7570         * dwarf-index-write.c: Sort headers.
7571         * dwarf-index-common.c: Sort headers.
7572         * dwarf-index-cache.h: Sort headers.
7573         * dwarf-index-cache.c: Sort headers.
7574         * dummy-frame.c: Sort headers.
7575         * dtrace-probe.c: Sort headers.
7576         * disasm.h: Sort headers.
7577         * disasm.c: Sort headers.
7578         * disasm-selftests.c: Sort headers.
7579         * dictionary.c: Sort headers.
7580         * dicos-tdep.c: Sort headers.
7581         * demangle.c: Sort headers.
7582         * dcache.h: Sort headers.
7583         * dcache.c: Sort headers.
7584         * darwin-nat.h: Sort headers.
7585         * darwin-nat.c: Sort headers.
7586         * darwin-nat-info.c: Sort headers.
7587         * d-valprint.c: Sort headers.
7588         * d-namespace.c: Sort headers.
7589         * d-lang.c: Sort headers.
7590         * ctf.c: Sort headers.
7591         * csky-tdep.c: Sort headers.
7592         * csky-linux-tdep.c: Sort headers.
7593         * cris-tdep.c: Sort headers.
7594         * cris-linux-tdep.c: Sort headers.
7595         * cp-valprint.c: Sort headers.
7596         * cp-support.c: Sort headers.
7597         * cp-namespace.c: Sort headers.
7598         * cp-abi.c: Sort headers.
7599         * corelow.c: Sort headers.
7600         * corefile.c: Sort headers.
7601         * continuations.c: Sort headers.
7602         * completer.h: Sort headers.
7603         * completer.c: Sort headers.
7604         * complaints.c: Sort headers.
7605         * coffread.c: Sort headers.
7606         * coff-pe-read.c: Sort headers.
7607         * cli-out.h: Sort headers.
7608         * cli-out.c: Sort headers.
7609         * charset.c: Sort headers.
7610         * c-varobj.c: Sort headers.
7611         * c-valprint.c: Sort headers.
7612         * c-typeprint.c: Sort headers.
7613         * c-lang.c: Sort headers.
7614         * buildsym.c: Sort headers.
7615         * buildsym-legacy.c: Sort headers.
7616         * build-id.h: Sort headers.
7617         * build-id.c: Sort headers.
7618         * btrace.c: Sort headers.
7619         * bsd-uthread.c: Sort headers.
7620         * breakpoint.h: Sort headers.
7621         * breakpoint.c: Sort headers.
7622         * break-catch-throw.c: Sort headers.
7623         * break-catch-syscall.c: Sort headers.
7624         * break-catch-sig.c: Sort headers.
7625         * blockframe.c: Sort headers.
7626         * block.c: Sort headers.
7627         * bfin-tdep.c: Sort headers.
7628         * bfin-linux-tdep.c: Sort headers.
7629         * bfd-target.c: Sort headers.
7630         * bcache.c: Sort headers.
7631         * ax-general.c: Sort headers.
7632         * ax-gdb.h: Sort headers.
7633         * ax-gdb.c: Sort headers.
7634         * avr-tdep.c: Sort headers.
7635         * auxv.c: Sort headers.
7636         * auto-load.c: Sort headers.
7637         * arm-wince-tdep.c: Sort headers.
7638         * arm-tdep.c: Sort headers.
7639         * arm-symbian-tdep.c: Sort headers.
7640         * arm-pikeos-tdep.c: Sort headers.
7641         * arm-obsd-tdep.c: Sort headers.
7642         * arm-nbsd-tdep.c: Sort headers.
7643         * arm-nbsd-nat.c: Sort headers.
7644         * arm-linux-tdep.c: Sort headers.
7645         * arm-linux-nat.c: Sort headers.
7646         * arm-fbsd-tdep.c: Sort headers.
7647         * arm-fbsd-nat.c: Sort headers.
7648         * arm-bsd-tdep.c: Sort headers.
7649         * arch-utils.c: Sort headers.
7650         * arc-tdep.c: Sort headers.
7651         * arc-newlib-tdep.c: Sort headers.
7652         * annotate.h: Sort headers.
7653         * annotate.c: Sort headers.
7654         * amd64-windows-tdep.c: Sort headers.
7655         * amd64-windows-nat.c: Sort headers.
7656         * amd64-tdep.c: Sort headers.
7657         * amd64-sol2-tdep.c: Sort headers.
7658         * amd64-obsd-tdep.c: Sort headers.
7659         * amd64-obsd-nat.c: Sort headers.
7660         * amd64-nbsd-tdep.c: Sort headers.
7661         * amd64-nbsd-nat.c: Sort headers.
7662         * amd64-nat.c: Sort headers.
7663         * amd64-linux-tdep.c: Sort headers.
7664         * amd64-linux-nat.c: Sort headers.
7665         * amd64-fbsd-tdep.c: Sort headers.
7666         * amd64-fbsd-nat.c: Sort headers.
7667         * amd64-dicos-tdep.c: Sort headers.
7668         * amd64-darwin-tdep.c: Sort headers.
7669         * amd64-bsd-nat.c: Sort headers.
7670         * alpha-tdep.c: Sort headers.
7671         * alpha-obsd-tdep.c: Sort headers.
7672         * alpha-nbsd-tdep.c: Sort headers.
7673         * alpha-mdebug-tdep.c: Sort headers.
7674         * alpha-linux-tdep.c: Sort headers.
7675         * alpha-linux-nat.c: Sort headers.
7676         * alpha-bsd-tdep.c: Sort headers.
7677         * alpha-bsd-nat.c: Sort headers.
7678         * aix-thread.c: Sort headers.
7679         * agent.c: Sort headers.
7680         * addrmap.c: Sort headers.
7681         * ada-varobj.c: Sort headers.
7682         * ada-valprint.c: Sort headers.
7683         * ada-typeprint.c: Sort headers.
7684         * ada-tasks.c: Sort headers.
7685         * ada-lang.c: Sort headers.
7686         * aarch64-tdep.c: Sort headers.
7687         * aarch64-ravenscar-thread.c: Sort headers.
7688         * aarch64-newlib-tdep.c: Sort headers.
7689         * aarch64-linux-tdep.c: Sort headers.
7690         * aarch64-linux-nat.c: Sort headers.
7691         * aarch64-fbsd-tdep.c: Sort headers.
7692         * aarch64-fbsd-nat.c: Sort headers.
7693         * aarch32-linux-nat.c: Sort headers.
7694
7695 2019-04-04  Tom Tromey  <tom@tromey.com>
7696
7697         * varobj.c (varobj_create): Update.
7698         * rust-exp.y (struct rust_parser) <update_innermost_block,
7699         lookup_symbol>: New methods.
7700         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7701         Rename.
7702         (rust_parser::rust_lookup_type)
7703         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7704         * printcmd.c (display_command, do_one_display): Update.
7705         * parser-defs.h (struct parser_state) <parser_state>: Add
7706         "tracker" parameter.
7707         (block_tracker): New member.
7708         (class innermost_block_tracker) <innermost_block_tracker>: Add
7709         "types" parameter.
7710         <reset>: Remove method.
7711         (innermost_block): Don't declare.
7712         (null_post_parser): Update.
7713         * parse.c (innermost_block): Remove global.
7714         (write_dollar_variable): Update.
7715         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7716         Remove "tracker_types" parameter.
7717         (parse_expression): Add "tracker" parameter.
7718         (parse_expression_for_completion): Update.
7719         (null_post_parser): Add "tracker" parameter.
7720         * p-exp.y: Update rules.
7721         * m2-exp.y: Update rules.
7722         * language.h (struct language_defn) <la_post_parser>: Add
7723         "tracker" parameter.
7724         * go-exp.y: Update rules.
7725         * f-exp.y: Update rules.
7726         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7727         parameter.
7728         * d-exp.y: Update rules.
7729         * c-exp.y: Update rules.
7730         * breakpoint.c (set_breakpoint_condition): Create an
7731         innermost_block_tracker.
7732         (watch_command_1): Likewise.
7733         * ada-lang.c (resolve): Add "tracker" parameter.
7734         (resolve_subexp): Likewise.
7735         * ada-exp.y (write_var_from_sym): Update.
7736
7737 2019-04-04  Tom Tromey  <tom@tromey.com>
7738
7739         * type-stack.h: New file.
7740         * type-stack.c: New file.
7741         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7742         type-stack.h.
7743         (insert_into_type_stack, insert_type, push_type, push_type_int)
7744         (insert_type_address_space, pop_type, pop_type_int)
7745         (pop_typelist, pop_type_stack, append_type_stack)
7746         (push_type_stack, get_type_stack, push_typelist)
7747         (follow_type_instance_flags, follow_types): Don't declare.
7748         * parse.c (type_stack): Remove global.
7749         (parse_exp_in_context): Update.
7750         (insert_into_type_stack, insert_type, push_type, push_type_int)
7751         (insert_type_address_space, pop_type, pop_type_int)
7752         (pop_typelist, pop_type_stack, append_type_stack)
7753         (push_type_stack, get_type_stack, push_typelist)
7754         (follow_type_instance_flags, follow_types): Remove (moved to
7755         type-stack.c).
7756         * f-exp.y (type_stack): New global.
7757         Update rules.
7758         (push_kind_type, f_parse): Update.
7759         * d-exp.y (type_stack): New global.
7760         Update rules.
7761         (d_parse): Update.
7762         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7763         Update rules.
7764         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7765         (HFILES_NO_SRCDIR): Add type-stack.h.
7766
7767 2019-04-04  Tom Tromey  <tom@tromey.com>
7768
7769         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7770         (rust_parser::convert_ast_to_expression, rust_parse)
7771         (rust_lex_test_completion, rust_lex_tests): Update.
7772         * parser-defs.h (struct expr_completion_state): New.
7773         (struct parser_state) <parser_state>: Add completion parameter.
7774         <mark_struct_expression, mark_completion_tag>: New methods.
7775         <parse_completion, m_completion_state>: New members.
7776         (prefixify_expression, null_post_parser): Update.
7777         (mark_struct_expression, mark_completion_tag): Don't declare.
7778         * parse.c (parse_completion, expout_last_struct)
7779         (expout_tag_completion_type, expout_completion_name): Remove
7780         globals.
7781         (parser_state::mark_struct_expression)
7782         (parser_state::mark_completion_tag): Now methods.
7783         (prefixify_expression): Add last_struct parameter.
7784         (prefixify_subexp): Likewise.
7785         (parse_exp_1): Update.
7786         (parse_exp_in_context): Add cstate parameter.  Update.
7787         (parse_expression_for_completion): Create an
7788         expr_completion_state.
7789         (null_post_parser): Add "completion" parameter.
7790         * p-exp.y: Update rules.
7791         (yylex): Update.
7792         * language.h (struct language_defn) <la_post_parser>: Add
7793         "completing" parameter.
7794         * go-exp.y: Update rules.
7795         (lex_one_token): Update.
7796         * expression.h (parse_completion): Don't declare.
7797         * d-exp.y: Update rules.
7798         (lex_one_token): Update rules.
7799         * c-exp.y: Update rules.
7800         (lex_one_token): Update.
7801         * ada-lang.c (resolve): Add "parse_completion" parameter.
7802         (resolve_subexp): Likewise.
7803         (ada_resolve_function): Likewise.
7804
7805 2019-04-04  Tom Tromey  <tom@tromey.com>
7806
7807         * parser-defs.h (struct parser_state) <start_arglist,
7808         end_arglist>: New methods.
7809         <arglist_len, m_funcall_chain>: New members.
7810         (arglist_len, start_arglist, end_arglist): Don't declare.
7811         * parse.c (arglist_len, funcall_chain): Remove global.
7812         (start_arglist, end_arglist): Remove functions.
7813         (parse_exp_in_context): Update.
7814         * p-exp.y: Update rules.
7815         * m2-exp.y: Update rules.
7816         * go-exp.y: Update rules.
7817         * f-exp.y: Update rules.
7818         * d-exp.y: Update rules.
7819         * c-exp.y: Update rules.
7820
7821 2019-04-04  Tom Tromey  <tom@tromey.com>
7822
7823         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7824         lex_operator, push_back>: New methods.
7825         Update all rules.
7826         (rust_parser::lex_hex, lex_escape): Rename and update.
7827         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7828         (rust_parser::lex_operator): Rename and update.
7829         (rust_parser::lex_number, rustyylex, rustyyerror)
7830         (rust_lex_test_init, rust_lex_test_sequence)
7831         (rust_lex_test_push_back, rust_lex_tests): Update.
7832         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7833         parameter.
7834         <lexptr, prev_lexptr>: New members.
7835         (lexptr, prev_lexptr): Don't declare.
7836         * parse.c (lexptr, prev_lexptr): Remove globals.
7837         (parse_exp_in_context): Update.
7838         * p-exp.y (yylex, yyerror): Update.
7839         * m2-exp.y (parse_number, yylex, yyerror): Update.
7840         * go-exp.y (lex_one_token, yyerror): Update.
7841         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7842         * d-exp.y (lex_one_token, yyerror): Update.
7843         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7844         (lex_one_token, yyerror): Update.
7845         * ada-lex.l (YY_INPUT): Update.
7846         (rewind_to_char): Update.
7847         * ada-exp.y (yyerror): Update.
7848
7849 2019-04-04  Tom Tromey  <tom@tromey.com>
7850
7851         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7852         * parser-defs.h (struct parser_state) <parser_state>: Add new
7853         parameter.
7854         <comma_terminates>: New member.
7855         (comma_terminates): Don't declare global.
7856         * parse.c (comma_terminates): Remove global.
7857         (parse_exp_in_context): Update.
7858         * p-exp.y (yylex): Update.
7859         * m2-exp.y (yylex): Update.
7860         * go-exp.y (lex_one_token): Update.
7861         * f-exp.y (yylex): Update.
7862         * d-exp.y (lex_one_token): Update.
7863         * c-exp.y (lex_one_token): Update.
7864         * ada-lex.l: Update.
7865
7866 2019-04-04  Tom Tromey  <tom@tromey.com>
7867
7868         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7869         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7870         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7871         * parser-defs.h (paren_depth): Don't declare.
7872         * parse.c (paren_depth): Remove global.
7873         (parse_exp_in_context): Update.
7874         * p-exp.y (paren_depth): New global.
7875         (pascal_parse): Initialize it.
7876         * m2-exp.y (paren_depth): New global.
7877         (m2_parse): Initialize it.
7878         * go-exp.y (paren_depth): New global.
7879         (go_parse): Initialize it.
7880         * f-exp.y (paren_depth): New global.
7881         (f_parse): Initialize it.
7882         * d-exp.y (paren_depth): New global.
7883         (d_parse): Initialize it.
7884         * c-exp.y (paren_depth): New global.
7885         (c_parse): Initialize it.
7886         * ada-lex.l (paren_depth): New global.
7887         (lexer_init): Initialize it.
7888
7889 2019-04-04  Tom Tromey  <tom@tromey.com>
7890
7891         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7892         (rust_parser::convert_ast_to_type)
7893         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7894         * parser-defs.h (struct parser_state) <parser_state>: Add
7895         parameters.  Initialize new members.
7896         <expression_context_block, expression_context_pc>: New members.
7897         * parse.c (expression_context_block, expression_context_pc):
7898         Remove globals.
7899         (parse_exp_in_context): Update.
7900         * p-exp.y: Update all rules.
7901         (yylex): Update.
7902         * m2-exp.y: Update all rules.
7903         (yylex): Update.
7904         * go-exp.y (yylex): Update.
7905         * f-exp.y (yylex): Update.
7906         * d-exp.y: Update all rules.
7907         (yylex): Update.
7908         * c-exp.y: Update all rules.
7909         (lex_one_token, classify_name, yylex, c_parse): Update.
7910         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7911
7912 2019-04-04  Tom Tromey  <tom@tromey.com>
7913
7914         * gdbarch.h, gdbarch.c: Rebuild.
7915         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7916         * stap-probe.h:
7917         (struct stap_parse_info): Replace "parser_state" with
7918         "expr_builder".
7919         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7920         (parser_state): New class.
7921         * parse.c (expr_builder): Rename.
7922         (expr_builder::release): Rename.
7923         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7924         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7925         (write_exp_elt_longcst, write_exp_elt_floatcst)
7926         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7927         (write_exp_string_vector, write_exp_bitstring)
7928         (write_exp_msymbol, mark_struct_expression)
7929         (write_dollar_variable)
7930         (insert_type_address_space, increase_expout_size): Replace
7931         "parser_state" with "expr_builder".
7932         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7933         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7934         "parser_state" with "expr_builder".
7935
7936 2019-04-04  Tom Tromey  <tom@tromey.com>
7937
7938         * rust-exp.y: Replace "parse_language" with method call.
7939         * p-exp.y:
7940         (yylex): Replace "parse_language" with method call.
7941         * m2-exp.y:
7942         (yylex): Replace "parse_language" with method call.
7943         * go-exp.y (classify_name): Replace "parse_language" with method
7944         call.
7945         * f-exp.y (yylex): Replace "parse_language" with method call.
7946         * d-exp.y (lex_one_token): Replace "parse_language" with method
7947         call.
7948         * c-exp.y:
7949         (lex_one_token, classify_name, yylex): Replace "parse_language"
7950         with method call.
7951         * ada-exp.y (find_primitive_type, type_char)
7952         (type_system_address): Replace "parse_language" with method call.
7953
7954 2019-04-04  Tom Tromey  <tom@tromey.com>
7955
7956         * rust-exp.y: Replace "parse_gdbarch" with method call.
7957         * parse.c (write_dollar_variable, insert_type_address_space):
7958         Replace "parse_gdbarch" with method call.
7959         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7960         call.
7961         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7962         call.
7963         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7964         "parse_gdbarch" with method call.
7965         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7966         with method call.
7967         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7968         "parse_gdbarch" with method call.
7969         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7970         "parse_gdbarch" with method call.
7971         * c-exp.y (parse_type, parse_number, classify_name): Replace
7972         "parse_gdbarch" with method call.
7973         * ada-lex.l: Replace "parse_gdbarch" with method call.
7974         * ada-exp.y (parse_type, find_primitive_type, type_char)
7975         (type_system_address): Replace "parse_gdbarch" with method call.
7976
7977 2019-04-04  Tom Tromey  <tom@tromey.com>
7978
7979         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7980         * stap-probe.c (stap_parse_argument): Update.
7981         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7982         initial_size parameter.
7983         * rust-exp.y (rust_lex_tests): Update.
7984         * parse.c (parser_state): Update.
7985         (parse_exp_in_context): Update.
7986         * parser-defs.h (struct parser_state) <parser_state>: Remove
7987         "initial_size" parameter.
7988
7989 2019-04-04  Tom Tromey  <tom@tromey.com>
7990
7991         * parser-defs.h (increase_expout_size): Don't declare.
7992         * parse.c (increase_expout_size): Now static.
7993
7994 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7995
7996         * gnu-nat.c (gnu_nat_target::wait): Fix
7997         target_waitstatus_to_string call.
7998
7999 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8000
8001         * eval.c (evaluate_subexp_standard): Handle internal functions
8002         during Fortran function call handling.
8003
8004 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8005
8006         * NEWS: Mention new internal functions.
8007         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8008         (read_base_type): Use dwarf2_init_complex_target_type.
8009         * value.c (creal_internal_fn): New function.
8010         (cimag_internal_fn): New function.
8011         (_initialize_values): Register new internal functions.
8012
8013 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8014
8015         * infrun.c (stop_all_threads): If debug_infrun, always
8016         trace the wait status after wait_one, using
8017         target_waitstatus_to_string and target_pid_to_str.
8018         (handle_inferior_event): Replace various trace of
8019         wait status kind by a single trace.
8020         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8021         wait status kind image by target_waitstatus_to_string.
8022         * target/waitstatus.c (target_waitstatus_to_string): Fix
8023         obsolete comment.
8024
8025 2019-04-01  Tom Tromey  <tromey@adacore.com>
8026
8027         PR symtab/23331:
8028         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8029
8030 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8031             Pedro Alves  <palves@redhat.com>
8032
8033         * top.c (quit_force): Call 'finalize_values'.
8034         * value.c (finalize_values): New function.
8035         * value.h (finalize_values): Declare.
8036
8037 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8038
8039         * NEWS: Announce $_gdb_major and $_gdb_minor.
8040
8041         * top.c (init_gdb_version_vars): New function.
8042         (gdb_init): Call init_gdb_version_vars.
8043
8044 2019-03-29  Tom Tromey  <tromey@adacore.com>
8045
8046         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8047         help text.  Remove dead code.
8048
8049 2019-03-29  Keith Seitz  <keiths@redhat.com>
8050
8051         From Siddhesh Poyarekar:
8052         * f-lang.h (f77_get_upperbound): Return LONGEST.
8053         (f77_get_lowerbound): Likewise.
8054         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8055         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8056         print them.
8057         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8058         plongest to format print it.
8059         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8060         (f77_get_upperbound): Likewise.
8061         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8062         LOWER_BOUND to LONGEST.
8063         (f77_create_arrayprint_offset_tbl): Likewise.
8064
8065 2019-03-29  Keith Seitz  <keiths@redhat.com>
8066
8067         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8068         %s/pulongest for TYPE_LENGTH instead of %d in format
8069         strings.
8070         * ada-typerint.c (ada_print_type): Likewise.
8071         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8072         * compile/compile-c-support.c (generate_register_struct): Likewise.
8073         * gdbtypes.c (recursive_dump_type): Likewise.
8074         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8075         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8076         instead of %d in format strings.
8077         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8078         to std::min to ULONGEST.
8079         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8080         instead of %d in format strings.
8081         * tracepoint.c (info_scope_command): Likewise.
8082         * typeprint.c (print_offset_data::update)
8083         (print_offset_data::finish): Likewise.
8084         * xtensa-tdep.c (xtensa_store_return_value)
8085         (xtensa_push_dummy_call): Likewise.
8086
8087 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8088
8089         * windows-nat.c (display_selector): Fixed format specifications
8090         for 64-bit Cygwin.
8091
8092 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8093
8094         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8095
8096 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8097
8098         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8099         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8100         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8101         (nios2_linux_init_abi): Install it.
8102
8103 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8104
8105         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8106
8107 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8108
8109         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8110
8111 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8112             Tom Tromey  <tromey@adacore.com>
8113
8114         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8115
8116 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8117
8118         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8119         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8120         method to compute the bounds of range types. Also print "[evaluated]"
8121         if the bounds' values come from a dynamic evaluation.
8122
8123 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8124
8125         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8126         whitespace when pretty printing is on.
8127
8128 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8129
8130         * ppc-linux-nat.c: Add include.
8131
8132 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8133
8134         * NEWS: Mention AArch64 Pointer Authentication.
8135
8136 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8137
8138         * arm-linux-nat.c: Add include.
8139
8140 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8141
8142         * source-cache.c (source_cache::get_source_lines): Re-read
8143         fullname after calling open_source_file.
8144
8145 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8146
8147         * NEWS: Mention TLS support for FreeBSD.
8148
8149 2019-03-25  Tom Tromey  <tromey@adacore.com>
8150
8151         * minsyms.c (BUNCH_SIZE): Update comment.
8152         (~minimal_symbol_reader): Remove old comment.
8153         (compact_minimal_symbols): Update comment.
8154         (minimal_symbol_reader::install): Remove old comment.  Update
8155         other comments.
8156
8157 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8158
8159         * s390-linux-nat.c: Add include.
8160
8161 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8162
8163         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8164         Call linux_get_hwcap.
8165         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8166         Likewise.
8167         (aarch64_linux_get_hwcap): Remove function.
8168         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8169         declaration.
8170         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8171         linux_get_hwcap.
8172         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8173         * linux-tdep.c (linux_get_hwcap): Add function.
8174         (linux_get_hwcap2): Likewise.
8175         * linux-tdep.h (linux_get_hwcap): Add declaration.
8176         (linux_get_hwcap2): Likewise.
8177         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8178         (ppc_linux_get_hwcap2): Likewise.
8179         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8180         linux_get_hwcap.
8181         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8182         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8183         (ppc_linux_nat_target::read_description): Likewise.
8184         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8185         * s390-linux-nat.c: Likewise.
8186         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8187
8188 2019-03-24  Tom Tromey  <tom@tromey.com>
8189
8190         * ada-lang.c (standard_lookup): Simplify initialization.
8191         (ada_lookup_symbol_nonlocal): Simplify return.
8192         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8193         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8194         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8195         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8196         initialization.
8197         * solib.c (solib_global_lookup): Simplify.
8198         * symtab.c (null_block_symbol): Remove.
8199         (symbol_cache_lookup): Simplify returns.
8200         (lookup_language_this): Simplify returns.
8201         (lookup_symbol_aux): Simplify return.
8202         (lookup_local_symbol): Simplify returns.
8203         (lookup_global_symbol_from_objfile): Simplify return.
8204         (lookup_symbol_in_objfile_symtabs)
8205         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8206         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8207         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8208         * cp-namespace.c (cp_lookup_bare_symbol)
8209         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8210         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8211         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8212         (cp_lookup_symbol_via_imports): Simplify initialization.
8213         (find_symbol_in_baseclass): Likewise.
8214         * symtab.h (null_block_symbol): Remove.
8215         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8216         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8217         (d_lookup_symbol_module): Likewise.
8218         (find_symbol_in_baseclass): Simplify initialization.
8219
8220 2019-03-24  Tom Tromey  <tom@tromey.com>
8221
8222         * expression.h: Don't include symtab.h.
8223         (struct block): Forward declare.
8224
8225 2019-03-24  Tom Tromey  <tom@tromey.com>
8226
8227         * c-exp.y (typebase): Remove casts.
8228         * gdbtypes.c (lookup_unsigned_typename, )
8229         (lookup_signed_typename): Remove cast.
8230         * eval.c (parse_to_comma_and_eval): Remove cast.
8231         * parse.c (write_dollar_variable): Remove cast.
8232         * block.h (struct block) <superblock>: Now const.
8233         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8234         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8235         (map_block): Make "block" const.
8236         * symfile.h (struct quick_symbol_functions)
8237         <map_matching_symbols>: Constify block argument to "callback".
8238         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8239         const.
8240         (find_pc_sect_compunit_symtab): Make "b" const.
8241         (find_symbol_at_address): Likewise.
8242         (search_symbols): Likewise.
8243         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8244         (dw2_debug_names_lookup_symbol): Likewise.
8245         (dw2_map_matching_symbols): Update.
8246         * p-valprint.c (pascal_val_print): Remove "block".
8247         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8248         (aux_add_nonlocal_symbols): Make "block" const.
8249         (resolve_subexp): Remove cast.
8250         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8251         const.
8252         (iterate_over_file_blocks): Likewise.
8253         * f-exp.y (%union) <bval>: Remove.
8254         * coffread.c (patch_opaque_types): Make "b" const.
8255         * spu-tdep.c (spu_catch_start): Make "block" const.
8256         * c-valprint.c (print_unpacked_pointer): Remove "block".
8257         * symmisc.c (dump_symtab_1): Make "b" const.
8258         (block_depth): Make "block" const.
8259         * d-exp.y (%union) <bval>: Remove.
8260         * cp-support.h (cp_lookup_rtti_type): Update.
8261         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8262         * psymtab.c (psym_lookup_symbol): Make "block" const.
8263         (maintenance_check_psymtabs): Make "b" const.
8264         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8265         (enumerate_locals, enumerate_args): Update.
8266         * python/py-symtab.c (stpy_global_block): Make "block" const.
8267         (stpy_static_block): Likewise.
8268         * inline-frame.c (block_starting_point_at): Make "new_block"
8269         const.
8270         * block.c (find_block_in_blockvector): Make return type const.
8271         (blockvector_for_pc_sect): Make "b" const.
8272         (find_block_in_blockvector): Make "b" const.
8273
8274 2019-03-23  Tom Tromey  <tom@tromey.com>
8275
8276         * varobj.c (varobj_create): Update.
8277         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8278         * printcmd.c (display_command, do_one_display): Don't reset
8279         innermost_block.
8280         * parser-defs.h (enum innermost_block_tracker_type): Move to
8281         expression.h.
8282         (innermost_block): Update comment.
8283         * parse.c (parse_exp_1): Add tracker_types parameter.
8284         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8285         tracker_types parameter.  Reset innermost_block.
8286         (parse_exp_in_context): Remove.
8287         (parse_expression_for_completion): Update.
8288         * objfiles.c (~objfile): Don't reset expression_context_block or
8289         innermost_block.
8290         * expression.h (enum innermost_block_tracker_type): Move from
8291         parser-defs.h.
8292         (parse_exp_1): Add tracker_types parameter.
8293         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8294         reset innermost_block.
8295
8296 2019-03-23  Tom Tromey  <tom@tromey.com>
8297
8298         * objfiles.h: Include bcache.h.
8299
8300 2019-03-23  Tom Tromey  <tom@tromey.com>
8301
8302         * linespec.c (get_current_search_block): Use
8303         scoped_restore_current_language.
8304         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8305
8306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8307             Jiong Wang  <jiong.wang@arm.com>
8308
8309         * aarch64-linux-tdep.c
8310         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8311         section.
8312         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8313
8314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8315             Jiong Wang  <jiong.wang@arm.com>
8316
8317         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8318         instructions.
8319         (aarch64_analyze_prologue_test): Add PACIASP test.
8320         (aarch64_prologue_prev_register): Unmask PC value.
8321
8322 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8323             Jiong Wang  <jiong.wang@arm.com>
8324
8325         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8326         (aarch64_dwarf2_prev_register): Unmask PC value.
8327         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8328         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8329         DW_CFA_AARCH64_negate_ra_state.
8330         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8331
8332 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8333             Jiong Wang  <jiong.wang@arm.com>
8334
8335         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8336         registers.
8337         (aarch64_pseudo_register_name): Likewise.
8338         (aarch64_pseudo_register_type): Likewise.
8339         (aarch64_pseudo_register_reggroup_p): Likewise.
8340         (aarch64_gdbarch_init): Add pauth registers.
8341         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8342         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8343         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8344         (struct gdbarch_tdep): Add regnum for ra_state.
8345
8346 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8347             Jiong Wang  <jiong.wang@arm.com>
8348
8349         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8350
8351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8352             Jiong Wang  <jiong.wang@arm.com>
8353
8354         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8355         function.
8356         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8357         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8358         (aarch64_gdbarch_init): Add puth registers.
8359         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8360         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8361         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8362
8363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8364             Jiong Wang  <jiong.wang@arm.com>
8365
8366         * aarch64-linux-nat.c
8367         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8368         * aarch64-linux-tdep.c
8369         (aarch64_linux_core_read_description): Likewise.
8370         (aarch64_linux_get_hwcap): New function.
8371         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8372         (aarch64_linux_get_hwcap): New declaration.
8373
8374 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8375             Jiong Wang  <jiong.wang@arm.com>
8376
8377         * aarch64-linux-nat.c
8378         (aarch64_linux_nat_target::read_description): Add pauth param.
8379         * aarch64-linux-tdep.c
8380         (aarch64_linux_core_read_description): Likewise.
8381         * aarch64-tdep.c (struct target_desc): Add in pauth.
8382         (aarch64_read_description): Add pauth param.
8383         (aarch64_gdbarch_init): Likewise.
8384         * aarch64-tdep.h (aarch64_read_description): Likewise.
8385         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8386         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8387         * features/Makefile: Add new files.
8388         * features/aarch64-pauth.c: New file.
8389         * features/aarch64-pauth.xml: New file.
8390
8391 2019-03-20  Tom Tromey  <tromey@adacore.com>
8392
8393         * infrun.c (handle_inferior_event): Rename from
8394         handle_inferior_event_1.  Create a scoped_value_mark.
8395         (handle_inferior_event): Remove.
8396
8397 2019-03-19  Tom Tromey  <tromey@adacore.com>
8398
8399         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8400         * infrun.h (print_stop_event): Add "displays" parameter.
8401         * infrun.c (print_stop_event): Add "displays" parameter.
8402
8403 2019-03-19  Pedro Alves  <palves@redhat.com>
8404
8405         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8406         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8407         to -1.  Fix TABs vs spaces.
8408         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8409         * tui/tui-out.h (tui_ui_out) Add intro comments.
8410         <m_line, m_start_of_line>: In-class initialize, and add describing
8411         comment.
8412
8413 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8414
8415         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8416         variable names.
8417         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8418
8419 2019-03-18  Pedro Alves  <palves@redhat.com>
8420             Eli Zaretskii <eliz@gnu.org>
8421
8422         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8423         m_line and m_start_of_line.
8424
8425 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8426
8427         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8428         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8429         it returns a newline.  This fixes a regression in TU mode, whereby
8430         the next line is output on the same screen line as the user input.
8431
8432 2019-03-18  Tom Tromey  <tromey@adacore.com>
8433
8434         * minsyms.c (minimal_symbol_reader::install): Remove call to
8435         obstack_blank.
8436
8437 2019-03-18  Pedro Alves  <palves@redhat.com>
8438
8439         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8440         New globals.
8441         (apply_style): New, factored out from ...
8442         (apply_ansi_escape): ... this.  Handle reverse video mode.
8443         (tui_set_reverse_mode): New function.
8444         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8445         * tui/tui-winsource.c (tui_show_source_line): Use
8446         tui_set_reverse_mode instead of setting A_STANDOUT.
8447         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8448         New setter methods.
8449
8450 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8451
8452         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8453         Handle tabs.
8454
8455 2019-03-18  Tom Tromey  <tromey@adacore.com>
8456
8457         * ada-lang.c (empty_array): Add "high" parameter.
8458         (ada_evaluate_subexp): Update.
8459
8460 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8461
8462         * unittests/string_view-selftests.c: Define
8463         _initialize_string_view_selftests unconditionally.
8464
8465 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8466
8467         PR gdb/24350
8468         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8469
8470 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8471
8472         PR gdb/24351
8473         * windows-nat.c (display_selector): Fix format specifiers.
8474
8475 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8476
8477         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8478         tui_refill_source_window instead of tui_refresh_win, to update the
8479         current execution line.  This fixes redisplay of the current line
8480         when stepping through the code with "next" or "step".
8481
8482 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8483
8484         * source-cache.c (source_cache::get_source_lines): Call
8485         find_source_lines to initialize s->nlines.  This fixes vertical
8486         scrolling of TUI source window when the DOWN arrow is pressed.
8487
8488 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8489
8490         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8491         linux-thread-db.c (_initialize_thread_db): Likewise.
8492
8493 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8494
8495         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8496         wclrtoeol in tui_show_source_line".  This reverts changes made in
8497         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8498
8499 2019-03-15  Tom Tromey  <tom@tromey.com>
8500
8501         * symtab.h (struct minimal_symbol): Derive from
8502         general_symbol_info.
8503         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8504         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8505         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8506         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8507         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8508         (MSYMBOL_SEARCH_NAME): Update.
8509         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8510         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8511         * minsyms.c (minimal_symbol_reader::record_full): Update.
8512
8513 2019-03-15  Tom Tromey  <tom@tromey.com>
8514
8515         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8516
8517 2019-03-15  Tom Tromey  <tom@tromey.com>
8518
8519         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8520         unique_xmalloc_ptr.
8521         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8522         Update.
8523         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8524         (build_minimal_symbol_hash_tables)
8525         (minimal_symbol_reader::install): Update.
8526
8527 2019-03-15  Tom Tromey  <tom@tromey.com>
8528
8529         * symtab.c (create_demangled_names_hash): Update.
8530         (symbol_set_names): Update.
8531         * objfiles.h (struct objfile_per_bfd_storage)
8532         <demangled_names_hash>: Now an htab_up.
8533         * objfiles.c (objfile_per_bfd_storage): Simplify.
8534
8535 2019-03-15  Tom Tromey  <tom@tromey.com>
8536
8537         * objfiles.h (struct objfile_per_bfd_storage): Declare
8538         destructor.
8539         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8540         New.
8541         (get_objfile_bfd_data): Use new.  Don't initialize
8542         language_of_main.
8543         (free_objfile_per_bfd_storage): Remove.
8544         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8545
8546 2019-03-15  Tom Tromey  <tom@tromey.com>
8547
8548         * symfile.c (reread_symbols): Update.
8549         * objfiles.c (objfile::objfile): Update.
8550         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8551         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8552         comment.
8553         (minimal_symbol_reader::install): Update.
8554         (terminate_minimal_symbol_table): Remove.
8555         * jit.c (jit_object_close_impl): Update.
8556
8557 2019-03-15  Tom Tromey  <tom@tromey.com>
8558
8559         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8560         initializations.
8561
8562 2019-03-15  Tom Tromey  <tom@tromey.com>
8563
8564         * objfiles.h (struct objfile_per_bfd_storage)
8565         <demangled_hash_languages>: Now a bitset.
8566         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8567         (lookup_minimal_symbol): Update.
8568
8569 2019-03-15  Tom Tromey  <tom@tromey.com>
8570
8571         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8572         Don't return the symbol.
8573         * coffread.c (record_minimal_symbol): Use record_full.
8574
8575 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8576
8577         The MS-Windows port of ncurses fails to switch to a color pair if
8578         one or both of the colors are the implicit default colors.  This
8579         change records the default colors when TUI is initialized, and
8580         then specifies them explicitly when a color pair uses the default
8581         colors.  This allows color styling in TUI mode on MS-Windows.
8582
8583         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8584         ncurses_norm_attr.
8585         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8586         colors in ncurses_norm_attr.
8587         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8588         "none", replace it with the default color recorded in
8589         ncurses_norm_attr.
8590
8591 2019-03-14  Tom Tromey  <tromey@adacore.com>
8592
8593         * source-cache.h (class source_cache) <get_source_lines>: Return
8594         std::string.
8595         * source-cache.c (source_cache::extract_lines): Handle case where
8596         first_pos==npos.  Return std::string.
8597         (source_cache::get_source_lines): Update.
8598
8599 2019-03-14  Tom Tromey  <tromey@adacore.com>
8600
8601         * NEWS: Add item for "style sources" commands.
8602         * source-cache.c (source_cache::get_source_lines): Check
8603         source_styling.
8604         * cli/cli-style.c (source_styling): New global.
8605         (_initialize_cli_style): Add "style sources" commands.
8606         (show_style_sources): New function.
8607         * cli/cli-style.h (source_styling): Declare.
8608
8609 2019-03-14  Pedro Alves  <palves@redhat.com>
8610             Tom Tromey  <tromey@adacore.com>
8611
8612         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8613         * tui/tui-winsource.c (tui_refill_source_window): New function,
8614         from...
8615         (tui_horizontal_source_scroll): ... here.  Move some logic.
8616         * cli/cli-style.c (set_style_enabled): Notify new observable.
8617         * tui/tui-hooks.c (tui_redisplay_source): New function.
8618         (tui_attach_detach_observers): Attach or detach
8619         tui_redisplay_source.
8620         * observable.h (source_styling_changed): New observable.
8621         * observable.c: Define source_styling_changed observable.
8622
8623 2019-03-13  Tom Tromey  <tromey@adacore.com>
8624
8625         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8626         (i386_gnu_nat_target::store_registers): Update.
8627         * target-debug.h (target_debug_print_std_string): New macro.
8628         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8629         * windows-tdep.c (display_one_tib): Update.
8630         * tui/tui-stack.c (tui_make_status_line): Update.
8631         * top.c (print_inferior_quit_action): Update.
8632         * thread.c (thr_try_catch_cmd): Update.
8633         (add_thread_with_info): Update.
8634         (thread_target_id_str): Update.
8635         (thr_try_catch_cmd): Update.
8636         (thread_command): Update.
8637         (thread_find_command): Update.
8638         * record-btrace.c (record_btrace_target::info_record)
8639         (record_btrace_resume_thread, record_btrace_target::resume)
8640         (record_btrace_cancel_resume, record_btrace_step_thread)
8641         (record_btrace_target::wait, record_btrace_target::wait)
8642         (record_btrace_target::wait, record_btrace_target::stop): Update.
8643         * progspace.c (print_program_space): Update.
8644         * process-stratum-target.c
8645         (process_stratum_target::thread_address_space): Update.
8646         * linux-fork.c (linux_fork_mourn_inferior)
8647         (detach_checkpoint_command, info_checkpoints_command)
8648         (linux_fork_context): Update.
8649         (linux_fork_detach): Update.
8650         (class scoped_switch_fork_info): Update.
8651         (delete_checkpoint_command): Update.
8652         * infrun.c (follow_fork_inferior): Update.
8653         (follow_fork_inferior): Update.
8654         (proceed_after_vfork_done): Update.
8655         (handle_vfork_child_exec_or_exit): Update.
8656         (follow_exec): Update.
8657         (displaced_step_prepare_throw): Update.
8658         (displaced_step_restore): Update.
8659         (start_step_over): Update.
8660         (resume_1): Update.
8661         (clear_proceed_status_thread): Update.
8662         (proceed): Update.
8663         (print_target_wait_results): Update.
8664         (do_target_wait): Update.
8665         (context_switch): Update.
8666         (stop_all_threads): Update.
8667         (restart_threads): Update.
8668         (finish_step_over): Update.
8669         (handle_signal_stop): Update.
8670         (switch_back_to_stepped_thread): Update.
8671         (keep_going_pass_signal): Update.
8672         (print_exited_reason): Update.
8673         (normal_stop): Update.
8674         * inferior.c (inferior_pid_to_str): Change return type.
8675         (print_selected_inferior): Update.
8676         (add_inferior): Update.
8677         (detach_inferior): Update.
8678         * dummy-frame.c (fprint_dummy_frames): Update.
8679         * dcache.c (dcache_info_1): Update.
8680         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8681         (btrace_fetch, btrace_clear): Update.
8682         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8683         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8684         type.
8685         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8686         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8687         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8688         * gdbarch.c, gdbarch.h: Rebuild.
8689         * gdbarch.sh (core_pid_to_str): Change return type.
8690         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8691         return type.
8692         (windows_nat_target::pid_to_str): Change return type.
8693         (windows_delete_thread): Update.
8694         (windows_nat_target::attach): Update.
8695         (windows_nat_target::files_info): Update.
8696         * target-delegates.c: Rebuild.
8697         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8698         return type.
8699         (sol_thread_target::pid_to_str): Change return type.
8700         * remote.c (class remote_target) <pid_to_str>: Change return
8701         type.
8702         (remote_target::pid_to_str): Change return type.
8703         (extended_remote_target::attach, remote_target::remote_stop_ns)
8704         (remote_target::remote_notif_remove_queued_reply)
8705         (remote_target::push_stop_reply, remote_target::disable_btrace):
8706         Update.
8707         (extended_remote_target::attach): Update.
8708         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8709         type.
8710         (gdbsim_target::pid_to_str): Change return type.
8711         * ravenscar-thread.c (struct ravenscar_thread_target)
8712         <pid_to_str>: Change return type.
8713         (ravenscar_thread_target::pid_to_str): Change return type.
8714         * procfs.c (class procfs_target) <pid_to_str>: Change return
8715         type.
8716         (procfs_target::pid_to_str): Change return type.
8717         (procfs_target::attach): Update.
8718         (procfs_target::detach): Update.
8719         (procfs_target::fetch_registers): Update.
8720         (procfs_target::store_registers): Update.
8721         (procfs_target::wait): Update.
8722         (procfs_target::files_info): Update.
8723         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8724         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8725         return type.
8726         (nto_procfs_target::pid_to_str): Change return type.
8727         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8728         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8729         return type.
8730         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8731         (exit_lwp): Update.
8732         (attach_proc_task_lwp_callback, get_detach_signal)
8733         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8734         (linux_nat_target::resume, wait_lwp, stop_callback)
8735         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8736         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8737         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8738         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8739         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8740         type.
8741         (inf_ptrace_target::attach): Update.
8742         (inf_ptrace_target::files_info): Update.
8743         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8744         type.
8745         (go32_nat_target::pid_to_str): Change return type.
8746         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8747         (gnu_nat_target::wait): Update.
8748         (gnu_nat_target::wait): Update.
8749         (gnu_nat_target::resume): Update.
8750         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8751         (fbsd_nat_target::wait): Update.
8752         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8753         type.
8754         (darwin_nat_target::attach): Update.
8755         * corelow.c (class core_target) <pid_to_str>: Change return type.
8756         (core_target::pid_to_str): Change return type.
8757         * target.c (normal_pid_to_str): Change return type.
8758         (default_pid_to_str): Likewise.
8759         (target_pid_to_str): Change return type.
8760         (target_translate_tls_address): Update.
8761         (target_announce_detach): Update.
8762         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8763         return type.
8764         (bsd_uthread_target::pid_to_str): Change return type.
8765         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8766         type.
8767         (bsd_kvm_target::pid_to_str): Change return type.
8768         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8769         return type.
8770         (aix_thread_target::pid_to_str): Change return type.
8771         * target.h (struct target_ops) <pid_to_str>: Change return type.
8772         (target_pid_to_str, normal_pid_to_str): Likewise.
8773         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8774         type.
8775         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8776         type.
8777         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8778         return type.
8779         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8780         type.
8781         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8782         type.
8783         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8784         return type.
8785
8786 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8787
8788         * NEWS: Mention that the new default MI version is 3.  Mention
8789         changes to the output of commands and events that deal with
8790         multi-location breakpoints.
8791         * breakpoint.c: Include "mi/mi-out.h".
8792         (print_one_breakpoint): Change output syntax if using MI version
8793         >= 3.
8794         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8795         New.
8796         (mi_multi_location_breakpoint_output_fixed): New.
8797         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8798         (mi_cmd_fix_multi_location_breakpoint_output): New.
8799         (mi_multi_location_breakpoint_output_fixed): New.
8800         * mi/mi-cmds.c (mi_cmds): Register command
8801         -fix-multi-location-breakpoint-output.
8802         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8803         interpreter "mi".
8804
8805 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8806
8807         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8808         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8809         instantiate mi_ui_out based on interpreter name.
8810         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8811         * mi/mi-main.c (mi_load_progress): Likewise.
8812
8813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8814
8815         * NEWS: Combine separate "New targets" sections for 8.3.
8816
8817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8818
8819         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8820         (ppcfbsd_init_abi): Install gdbarch
8821         "fetch_tls_load_module_address" and "get_thread_local_address"
8822         methods.
8823
8824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8825
8826         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8827         (riscv_fbsd_init_abi): Install gdbarch
8828         "fetch_tls_load_module_address" and "get_thread_local_address"
8829         methods.
8830
8831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8832
8833         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8834         (i386fbsd_init_abi): Install gdbarch
8835         "fetch_tls_load_module_address" and "get_thread_local_address"
8836         methods.
8837
8838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8839
8840         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8841         (amd64fbsd_init_abi): Install gdbarch
8842         "fetch_tls_load_module_address" and "get_thread_local_address"
8843         methods.
8844
8845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8846
8847         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8848         (struct fbsd_pspace_data): New type.
8849         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8850         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8851         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8852         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8853         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8854
8855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8856
8857         * gdbtypes.c (lookup_struct_elt): New function.
8858         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8859         * gdbtypes.h (struct struct_elt): New type.
8860         (lookup_struct_elt): New prototype.
8861
8862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8863
8864         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8865         remove disabled code block.
8866
8867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8868
8869         * gdbarch.sh (get_thread_local_address): New method.
8870         * gdbarch.h, gdbarch.c: Regenerate.
8871         * target.c (target_translate_tls_address): Use
8872         gdbarch_get_thread_local_address if present instead of
8873         target::get_thread_local_address.
8874
8875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8876
8877         * target.h (target::get_thread_local_address): Update comment.
8878
8879 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8880
8881         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8882         objfile->separate_debug_objfile_backlink if not NULL.
8883
8884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8885
8886         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8887         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8888         (amd64bsd_store_inferior_registers): Likewise.
8889         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8890         Enable segment base registers.
8891         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8892         PT_GETFSBASE and PT_GETGSBASE.
8893         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8894         PT_SETGSBASE.
8895         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8896         segment base registers.
8897         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8898
8899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8900
8901         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8902         Update calls to i386_target_description to add 'segments'
8903         parameter.
8904         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8905         add segment base registers.
8906         * arch/i386.c (i386_create_target_description): Add 'segments'
8907         parameter to enable segment base registers.
8908         * arch/i386.h (i386_create_target_description): Likewise.
8909         * features/i386/32bit-segments.xml: New file.
8910         * features/i386/32bit-segments.c: Generate.
8911         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8912         call to i386_target_description to add 'segments' parameter.
8913         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8914         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8915         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8916         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8917         if feature is present.
8918         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8919         Add 'segments' parameter to call to i386_target_description.
8920         (i386_target_description): Add 'segments' parameter to enable
8921         segment base registers.
8922         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8923         to call to i386_target_description.
8924         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8925         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8926         Define I386_NUM_REGS.
8927         (i386_target_description): Add 'segments' parameter to enable
8928         segment base registers.
8929
8930 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8931
8932         PR/24325
8933         * source-cache.c: #undef open and close, to avoid unresolved
8934         externals during linking.
8935
8936 2019-03-12  Tom Tromey  <tromey@adacore.com>
8937
8938         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8939         const.  Add initializers.
8940         (_initialize_remote): Don't initialize ptid globals.
8941
8942 2019-03-12  Pedro Alves  <palves@redhat.com>
8943
8944         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8945
8946 2019-03-12  Pedro Alves  <palves@redhat.com>
8947
8948         * cp-name-parser.y (main): Remove unused 'len' variable.
8949
8950 2019-03-12  Tom Tromey  <tromey@adacore.com>
8951
8952         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8953         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8954
8955 2019-03-12  Tom Tromey  <tromey@adacore.com>
8956
8957         * linux-nat.c (iterate_over_lwps): Update.
8958         (stop_callback): Remove parameter.
8959         (stop_wait_callback, detach_callback, resume_set_callback)
8960         (select_singlestep_lwp_callback, set_ignore_sigint)
8961         (status_callback, resumed_callback, resume_clear_callback)
8962         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8963         data parameter.
8964         (linux_nat_target::detach, linux_nat_target::resume)
8965         (linux_stop_and_wait_all_lwps, select_event_lwp)
8966         (linux_nat_filter_event, linux_nat_wait_1)
8967         (linux_nat_target::kill, linux_nat_target::stop)
8968         (linux_nat_target::stop): Update.
8969         (linux_nat_resume_callback): Change type.
8970         (resume_stopped_resumed_lwps, count_events_callback)
8971         (select_event_lwp_callback): Likewise.
8972         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8973         * arm-linux-nat.c (struct update_registers_data): Remove.
8974         (update_registers_callback): Change type.
8975         (arm_linux_insert_hw_breakpoint1): Update.
8976         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8977         parameter.
8978         (x86_linux_dr_set_addr): Update.
8979         (x86_linux_dr_set_control): Update.
8980         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8981         (iterate_over_lwps): Use gdb::function_view.
8982         * nat/aarch64-linux-hw-point.c (struct
8983         aarch64_dr_update_callback_param): Remove.
8984         (debug_reg_change_callback): Change type.
8985         (aarch64_notify_debug_reg_change): Update.
8986         * s390-linux-nat.c (s390_refresh_per_info): Update.
8987
8988 2019-03-11  Tom Tromey  <tromey@adacore.com>
8989
8990         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8991         redundant assignment to "this_cu".
8992
8993 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8994
8995         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8996
8997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8998
8999         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9000         from...
9001         (rank_one_type): ... this.
9002
9003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9004
9005         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9006         from...
9007         (rank_one_type): ... this.
9008
9009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9010
9011         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9012         from...
9013         (rank_one_type): ... this.
9014
9015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9016
9017         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9018         from...
9019         (rank_one_type): ... this.
9020
9021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9022
9023         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9024         from...
9025         (rank_one_type): ... this.
9026
9027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9028
9029         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9030         from...
9031         (rank_one_type): ... this.
9032
9033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9034
9035         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9036         from...
9037         (rank_one_type): ... this.
9038
9039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9040
9041         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9042         from...
9043         (rank_one_type): ... this.
9044
9045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9046
9047         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9048         from...
9049         (rank_one_type): ... this.
9050
9051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9052
9053         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9054         from...
9055         (rank_one_type): ... this.
9056
9057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9058
9059         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9060         from...
9061         (rank_one_type): ... this.
9062
9063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9064
9065         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9066         from...
9067         (rank_one_type): ... this.
9068
9069 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9070
9071         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9072         inferior-events' shows the example events.
9073
9074 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9075
9076         Support styling on native MS-Windows console
9077
9078         PR/24315
9079         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9080         on MS-Windows if $TERM is not defined.
9081
9082         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9083
9084         * posix-hdep.c (gdb_console_fputs):
9085         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9086         functions.
9087         * ui-file.h (gdb_console_fputs): Add prototype.
9088
9089         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9090         back to fputs only if the former returns zero.
9091
9092 2019-03-07  Tom Tromey  <tom@tromey.com>
9093
9094         * symmisc.c (print_symbol_bcache_statistics): Update.
9095         (print_objfile_statistics): Update.
9096         * symfile.c (allocate_symtab): Update.
9097         * stabsread.c: Don't include bcache.h.
9098         * psymtab.h (struct psymbol_bcache): Don't declare.
9099         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9100         (psymbol_bcache_init, psymbol_bcache_free)
9101         (psymbol_bcache_get_bcache): Don't declare.
9102         * psymtab.c (struct psymbol_bcache): Remove.
9103         (psymtab_storage::psymtab_storage): Update.
9104         (psymtab_storage::~psymtab_storage): Update.
9105         (psymbol_bcache_init, psymbol_bcache_free)
9106         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9107         (add_psymbol_to_bcache): Update.
9108         (allocate_psymtab): Update.
9109         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9110         macro_cache>: No longer pointers.
9111         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9112         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9113         * macrotab.c (macro_bcache): Update.
9114         * macroexp.c: Don't include bcache.h.
9115         * gdbtypes.c (check_types_worklist): Update.
9116         (types_deeply_equal): Remove TRY/CATCH.  Update.
9117         * elfread.c (elf_symtab_read): Update.
9118         * dwarf2read.c: Don't include bcache.h.
9119         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9120         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9121         (print_bcache_statistics, bcache_memory_used): Don't declare.
9122         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9123         methods.  Rename all data members.
9124         * bcache.c (struct bcache): Move to bcache.h.
9125         (bcache::expand_hash_table): Rename from expand_hash_table.
9126         (bcache): Remove.
9127         (bcache::insert): Rename from bcache_full.
9128         (bcache::compare): Rename from bcache_compare.
9129         (bcache_xmalloc): Remove.
9130         (bcache::~bcache): Rename from bcache_xfree.
9131         (bcache::print_statistics): Rename from print_bcache_statistics.
9132         (bcache::memory_used): Rename from bcache_memory_used.
9133
9134 2019-03-07  Pedro Alves  <palves@redhat.com>
9135
9136         * infrun.c (normal_stop): Also check for
9137         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9138
9139 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9140
9141         * f-lang.c (value_from_host_double): Moved to...
9142         * value.c (value_from_host_double): ...here.
9143         * value.h (value_from_host_double): Declare.
9144         * guile/scm-math.c (vlscm_convert_typed_number): Use
9145         value_from_host_double.
9146         (vlscm_convert_number): Likewise.
9147         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9148         * python/py-value.c (convert_value_from_python): Likewise.
9149
9150 2019-03-06  Tom Tromey  <tom@tromey.com>
9151
9152         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9153
9154 2019-03-06  Tom Tromey  <tom@tromey.com>
9155
9156         * utils.h (free_current_contents): Don't declare.
9157         * utils.c (free_current_contents): Remove.
9158
9159 2019-03-06  Tom Tromey  <tom@tromey.com>
9160
9161         * top.c (quit_force): Update.
9162         * main.c (captured_command_loop): Update.
9163         * common/new-op.c (operator new): Update.
9164         * common/common-exceptions.c (struct catcher)
9165         <save_cleanup_chain>: Remove member.
9166         (exceptions_state_mc_init): Update.
9167         (exception_try_scope_entry): Return nullptr.
9168         (exception_try_scope_exit, exception_rethrow)
9169         (throw_exception_sjlj, throw_exception_cxx): Update.
9170         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9171         (all_cleanups, do_cleanups, discard_cleanups)
9172         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9173         (restore_cleanups, restore_final_cleanups): Don't declare.
9174         (do_final_cleanups): Remove parameter.
9175         * common/cleanups.c (cleanup_chain, make_cleanup)
9176         (make_cleanup_dtor, all_cleanups, do_cleanups)
9177         (discard_my_cleanups, discard_cleanups)
9178         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9179         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9180         (null_cleanup): Remove.
9181         (do_final_cleanups): Remove parameter.
9182
9183 2019-03-06  Tom Tromey  <tom@tromey.com>
9184
9185         * remote.c (remote_target::remote_parse_stop_reply): Use
9186         unique_xmalloc_ptr.
9187
9188 2019-03-06  Tom Tromey  <tom@tromey.com>
9189
9190         * stabsread.c (struct stabs_field_info): Rename from field_info.
9191         <list, fnlist>: Add initializers.
9192         <obstack>: New member.
9193         (read_member_functions, read_struct_fields, read_baseclasses):
9194         Allocate on obstack.  Don't use cleanups.
9195         (read_one_struct_field, read_member_functions, read_struct_fields)
9196         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9197         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9198         (read_struct_type): Update.
9199
9200 2019-03-06  Tom Tromey  <tom@tromey.com>
9201
9202         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9203         * common/filestuff.h (make_cleanup_close): Don't declare.
9204         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9205         Remove.
9206
9207 2019-03-06  Tom Tromey  <tom@tromey.com>
9208
9209         * solib-aix.c: Use make_scope_exit.
9210
9211 2019-03-06  Tom Tromey  <tom@tromey.com>
9212
9213         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9214         Use make_scope_exit.
9215
9216 2019-03-06  Tom Tromey  <tom@tromey.com>
9217
9218         * solib-svr4.c (disable_probes_interface): Remove parameter.
9219         (svr4_handle_solib_event): Use make_scope_exit.
9220
9221 2019-03-06  Tom Tromey  <tom@tromey.com>
9222
9223         * remote.c (struct stop_reply_deleter): Remove.
9224         (stop_reply_up): Update.
9225         (struct stop_reply): Derive from notif_event.  Don't typedef.
9226         <regcache>: Now a std::vector.
9227         (stop_reply_xfree): Remove.
9228         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9229         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9230         (remote_target::discard_pending_stop_replies): Use delete.
9231         (remote_target::remote_parse_stop_reply): Update.
9232         (remote_target::process_stop_reply): Update.
9233         * remote-notif.h (struct notif_event): Add virtual destructor.
9234         Remove "dtr" member.
9235         (struct notif_client) <alloc_event>: Return a unique_ptr.
9236         (notif_event_xfree): Don't declare.
9237         (notif_event_up): New typedef.
9238         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9239         (notif_event_xfree, do_notif_event_xfree): Remove.
9240         (remote_notif_state_xfree): Update.
9241
9242 2019-03-06  Tom Tromey  <tom@tromey.com>
9243
9244         * infrun.c (displaced_step_clear_cleanup): Now a
9245         forward_scope_exit type.
9246         (displaced_step_prepare_throw): Update.
9247         (displaced_step_fixup): Update.
9248
9249 2019-03-06  Tom Tromey  <tom@tromey.com>
9250
9251         * inferior.h (class inferior): Update comment.
9252         * gdbthread.h (class thread_info): Update comment.
9253
9254 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9255             Tom Tromey  <tom@tromey.com>
9256
9257         * stabsread.h (struct stab_section_list): Remove.
9258         (coffstab_build_psymtabs): Update.
9259         * dbxread.c (symbuf_sections): Now a std::vector.
9260         (sect_idx): New global.
9261         (fill_symbuf): Update.
9262         (coffstab_build_psymtabs): Change type of stabsects parameter.
9263         Update.
9264         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9265         std::vector.
9266         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9267         (coff_locate_sections): Update.
9268         (coff_symfile_read): Remove cleanups.  Update.
9269         (init_stringtab): Add storage parameter.
9270         (free_stringtab, free_stringtab_cleanup): Remove.
9271         (init_lineno): Add storage parameter.
9272         (free_linetab, free_linetab_cleanup): Remove.
9273
9274 2019-03-06  Pedro Alves  <palves@redhat.com>
9275
9276         * linux-fork.c (fork_info::clobber_regs): Delete.
9277         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9278         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9279         comment.  Adjust.
9280         (scoped_switch_fork_info::scoped_switch_fork_info)
9281         (checkpoint_command, linux_fork_context): Adjust
9282         fork_save_infrun_state calls.
9283
9284 2019-03-06  Pedro Alves  <palves@redhat.com>
9285
9286         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9287         (inf_has_multiple_threads): Return 'bool' and rewrite using
9288         inferior_info::threads().
9289
9290 2019-03-06  Pedro Alves  <palves@redhat.com>
9291
9292         * linux-fork.c: Include <list>.
9293         (fork_list): Now a std::list instance.
9294         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9295         (forks_exist_p, find_last_fork): Adjust.
9296         (new_fork): Delete.
9297         (one_fork_p): New.
9298         (add_fork): Adjust.
9299         (free_fork): Delete, folded into fork_info::~fork_info().
9300         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9301         Adjust.
9302         (init_fork_list): Delete.
9303         (linux_fork_killall, linux_fork_mourn_inferior)
9304         (linux_fork_detach, info_checkpoints_command): Adjust.
9305         (_initialize_linux_fork): No longer call init_fork_list.
9306
9307 2019-03-06  Pedro Alves  <palves@redhat.com>
9308
9309         * linux-fork.c (new_fork): New, split out of ...
9310         (add_fork): ... this.  Return void.  Move "first fork" special
9311         case from here, to ...
9312         (checkpoint_command): ... here.
9313         * linux-linux.h (add_fork): Return void.
9314
9315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9316
9317         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9318
9319 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9320             Chris January  <chris.january@arm.com>
9321             David Lecomber  <david.lecomber@arm.com>
9322
9323         * f-exp.y: New token, UNOP_INTRINSIC.
9324         (exp): New pattern using UNOP_INTRINSIC token.
9325         (f77_keywords): Add 'abs' keyword.
9326         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9327         (value_from_host_double): New function.
9328         (evaluate_subexp_f): Support UNOP_ABS.
9329
9330 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9331
9332         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9333         types.
9334
9335 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9336
9337         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9338         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9339         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9340
9341 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9342
9343         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9344
9345 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9346             Chris January  <chris.january@arm.com>
9347
9348         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9349         * f-exp.y: Define 'KIND' token.
9350         (exp): New pattern for KIND expressions.
9351         (ptype): Handle types with a kind extension.
9352         (direct_abs_decl): Extend to spot kind extensions.
9353         (f77_keywords): Add 'kind' to the list.
9354         (push_kind_type): New function.
9355         (convert_to_kind_type): New function.
9356         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9357         * parse.c (operator_length_standard): Likewise.
9358         * parser-defs.h (enum type_pieces): Add tp_kind.
9359         * std-operator.def: Add UNOP_KIND.
9360
9361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9362
9363         * f-exp.y (f_parse): Set yydebug.
9364
9365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9366
9367         * f-lang.c (evaluate_subexp_f): New function.
9368         (exp_descriptor_f): New global.
9369         (f_language_defn): Use exp_descriptor_f instead of
9370         exp_descriptor_standard.
9371
9372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * f-exp.y (struct token): Add comments.
9375         (dot_ops): Remove uppercase versions and the end marker.
9376         (f77_keywords): Likewise.
9377         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9378         entries in the dot_ops array are case insensitive, and use
9379         strncasecmp to compare strings.  Also some whitespace cleanup in
9380         this area.  Similar for the f77_keywords array, except entries in
9381         this list might be case sensitive.
9382
9383 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9384
9385         * f-exp.y (struct f77_boolean_val): Add comments.
9386         (boolean_values): Remove uppercase versions, and end marker.
9387         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9388         and use strncasecmp to achieve case insensitivity.  Additionally,
9389         perform whitespace cleanup around this code.
9390
9391 2019-03-06  Tom Tromey  <tromey@adacore.com>
9392
9393         * remote-sim.c (gdbsim_target_open): Use result of
9394         gdb_argv::release.
9395
9396 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9397         Dirk Schubert  <dirk.schubert@arm.com>
9398         Chris January  <chris.january@arm.com>
9399
9400         * eval.c (evaluate_subexp_standard): Call Fortran argument
9401         wrapping logic.
9402         * f-lang.c (struct value): A value which can be passed into a
9403         Fortran function call.
9404         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9405         where appropriate.
9406         (struct type): Value ready for a Fortran function call.
9407         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9408         is needed.
9409         * f-lang.h (fortran_argument_convert): Declaration.
9410         (fortran_preserve_arg_pointer): Declaration.
9411         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9412
9413 2019-03-05  Tom Tromey  <tromey@adacore.com>
9414
9415         * python/py-prettyprint.c (print_string_repr): Remove #if.
9416         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9417
9418 2019-03-05  Tom Tromey  <tromey@adacore.com>
9419
9420         * target.c (the_dummy_target): Move later.  Change type to
9421         "dummy_target".
9422         (initialize_targets): Don't initialize the_dummy_target.
9423
9424 2019-03-05  Tom Tromey  <tromey@adacore.com>
9425
9426         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9427         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9428
9429 2019-03-05  Tom Tromey  <tromey@adacore.com>
9430
9431         * windows-nat.c (windows_nat_target::attach)
9432         (windows_nat_target::detach): Don't call gdb_flush.
9433         * valprint.c (generic_val_print, val_print, val_print_string):
9434         Don't call gdb_flush.
9435         * utils.c (defaulted_query): Don't call gdb_flush.
9436         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9437         * target.c (target_announce_detach): Don't call gdb_flush.
9438         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9439         * remote.c (extended_remote_target::attach): Don't call
9440         gdb_flush.
9441         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9442         * printcmd.c (do_examine): Don't call gdb_flush.
9443         (info_display_command): Don't call gdb_flush.
9444         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9445         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9446         * memattr.c (info_mem_command): Don't call gdb_flush.
9447         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9448         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9449         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9450         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9451         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9452         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9453         (gnu_nat_target::detach): Don't call gdb_flush.
9454         * f-valprint.c (f_val_print): Don't call gdb_flush.
9455         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9456         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9457         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9458         gdb_flush.
9459         * c-valprint.c (c_val_print): Don't call gdb_flush.
9460         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9461
9462 2019-03-05  Tom Tromey  <tromey@adacore.com>
9463
9464         * varobj.c (update_dynamic_varobj_children): Update.
9465         (install_default_visualizer): Use reset, not release.
9466         * value.c (set_internalvar): Update.
9467         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9468         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9469         ATTRIBUTE_UNUSED_RESULT.
9470
9471 2019-03-05  Tom Tromey  <tromey@adacore.com>
9472
9473         * remote.c (class scoped_remote_fd) <release>: Add
9474         ATTRIBUTE_UNUSED_RESULT.
9475
9476 2019-03-05  Tom Tromey  <tromey@adacore.com>
9477
9478         * macroexp.c (struct macro_buffer) <release>: Add
9479         ATTRIBUTE_UNUSED_RESULT.
9480
9481 2019-03-05  Tom Tromey  <tromey@adacore.com>
9482
9483         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9484         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9485         ATTRIBUTE_UNUSED_RESULT.
9486
9487 2019-03-05  Tom Tromey  <tromey@adacore.com>
9488
9489         * common/scoped_fd.h (class scoped_fd) <release>: Add
9490         ATTRIBUTE_UNUSED_RESULT.
9491
9492 2019-03-05  Tom Tromey  <tromey@adacore.com>
9493
9494         * parser-defs.h (struct parser_state) <release>: Add
9495         ATTRIBUTE_UNUSED_RESULT.
9496
9497 2019-03-05  Tom Tromey  <tromey@adacore.com>
9498
9499         * utils.h (class gdb_argv) <release>: Add
9500         ATTRIBUTE_UNUSED_RESULT.
9501         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9502
9503 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9504
9505         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9506         for-loop range, to avoid compiler warnings.
9507
9508         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9509         avoid compiler warnings about unused variables.
9510
9511         * NEWS: Mention end of support for native debugging on MS-Windows
9512         before XP.
9513
9514         PR gdb/24292
9515         * common/netstuff.c:
9516         * gdbserver/gdbreplay.c
9517         * gdbserver/remote-utils.c:
9518         * ser-tcp.c:
9519         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9520         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9521         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9522         'getaddrinfo' and 'freeaddrinfo' were not available before
9523         Windows XP, and mingw.org's MinGW headers by default define
9524         _WIN32_WINNT to 0x500.
9525
9526 2019-03-01  Gary Benson <gbenson@redhat.com>
9527
9528         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9529
9530 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9531             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9532
9533         PR gdb/8527
9534         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9535         set_sigint_trap, clear_sigint_trap.
9536
9537 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9538
9539         * target.c (target_detach): Clear the regcache and the
9540         frame cache.
9541
9542 2019-02-27  Pedro Alves  <palves@redhat.com>
9543
9544         * utils.c (set_screen_size): When we cap the height/width sizes,
9545         tweak the corresponding command variable to show "unlimited":
9546
9547 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9548             Pedro Alves  <palves@redhat.com>
9549
9550         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9551         before calling rl_set_screen_size.
9552
9553 2019-02-27  Tom Tromey  <tromey@adacore.com>
9554
9555         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9556         define.
9557         * python/py-value.c: Remove Python 2.4 workaround.
9558         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9559         workaround.
9560         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9561         Python 2.4 workaround.
9562         * python/python-internal.h: Remove Python 2.4 comment.
9563         (Py_ssize_t): Don't define.
9564         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9565         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9566         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9567         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9568         * python/python.c (do_start_initialization): Remove Python 2.4
9569         workaround.
9570         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9571         (print_children): Remove Python 2.4 workaround.
9572         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9573         workaround.
9574         (CHARBUFFERPROC_NAME): Remove.
9575         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9576         Python 2.4 workaround.
9577
9578 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9579
9580         * NEWS: Note minimum Python version.
9581
9582 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9583
9584         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9585         code from these functions.  Remove corresponding ifdefs.  Use
9586         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9587         Remove gotos and target of gotos.
9588         (infpy_search_memory): Likewise.
9589
9590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9591
9592         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9593         (hppa_gdbarch_init): Don't register deleted functions with
9594         gdbarch.
9595
9596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9597
9598         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9599         (h8300_unwind_sp): Delete.
9600         (h8300_dummy_id): Delete.
9601         (h8300_gdbarch_init): Don't register deleted functions with
9602         gdbarch.
9603
9604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9605
9606         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9607         (ft32_unwind_pc): Delete.
9608         (ft32_unwind_sp): Delete.
9609         (ft32_gdbarch_init): Don't register deleted functions with
9610         gdbarch.
9611
9612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9613
9614         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9615         (frv_unwind_pc): Delete.
9616         (frv_unwind_sp): Delete.
9617         (frv_gdbarch_init): Don't register deleted functions with
9618         gdbarch.
9619
9620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9621
9622         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9623         (riscv_unwind_pc): Delete.
9624         (riscv_unwind_sp): Delete.
9625         (riscv_gdbarch_init): Don't register deleted functions with
9626         gdbarch.
9627
9628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9629
9630         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9631         (csky_unwind_pc): Delete.
9632         (csky_unwind_sp): Delete.
9633         (csky_gdbarch_init): Don't register deleted functions with
9634         gdbarch.
9635
9636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9637
9638         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9639         (cris_unwind_pc): Delete.
9640         (cris_unwind_sp): Delete.
9641         (cris_gdbarch_init): Don't register deleted functions with
9642         gdbarch.
9643
9644 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9645
9646         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9647         (bfin_unwind_pc): Delete.
9648         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9649
9650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9651
9652         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9653         (arm_unwind_pc): Delete.
9654         (arm_unwind_sp): Delete.
9655         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9656
9657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9658
9659         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9660         (arc_unwind_pc): Delete.
9661         (arc_unwind_sp): Delete.
9662         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9663
9664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9665
9666         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9667         (alpha_unwind_pc): Delete.
9668         (alpha_gdbarch_init): Don't register deleted functions with
9669         gdbarch.
9670
9671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9672
9673         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9674         (aarch64_unwind_pc): Delete.
9675         (aarch64_unwind_sp): Delete.
9676         (aarch64_gdbarch_init): Don't register deleted functions with
9677         gdbarch.
9678
9679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9680
9681         * gdbtypes.c (type_align): Don't consider static members when
9682         computing structure alignment.
9683
9684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9685
9686         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9687         return 0 for other types.
9688         * arch-utils.c (default_type_align): Always return 0.
9689         * gdbarch.h: Regenerate.
9690         * gdbarch.sh (type_align): Extend comment.
9691         * gdbtypes.c (type_align): Add additional comments, always call
9692         gdbarch_type_align before applying the default rules.
9693         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9694         generic code will then apply a suitable default.
9695         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9696         types, return 0 for other types.
9697
9698 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9699
9700         * NEWS: Create a new section for the next release branch.
9701         Rename the section of the current branch, now that it has
9702         been cut.
9703
9704 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9705
9706         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9707         * version.in: Bump version to 8.3.50.DATE-git.
9708
9709 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9710
9711         * aix-thread.c (ptid_cmp): Remove unused variable.
9712         (get_signaled_thread): Likewise.
9713         (store_regs_user_thread): Likewise.
9714         (store_regs_kernel_thread): Likewise.
9715         (fetch_regs_kernel_thread): Remove shadowed variable.
9716
9717 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9718
9719         * features/riscv/32bit-cpu.xml: Add register numbers.
9720         * features/riscv/32bit-fpu.c: Regenerate.
9721         * features/riscv/32bit-fpu.xml: Add register numbers.
9722         * features/riscv/64bit-cpu.xml: Add register numbers.
9723         * features/riscv/64bit-fpu.c: Regenerate.
9724         * features/riscv/64bit-fpu.xml: Add register numbers.
9725
9726 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9727
9728         * NEWS: Mention two argument form of gdb.Value constructor.
9729         * python/py-value.c (convert_buffer_and_type_to_value): New
9730         function.
9731         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9732         Add support for handling an optional second argument.  Call
9733         convert_buffer_and_type_to_value as appropriate.
9734         * python/python-internal.h (Py_buffer_deleter): New struct.
9735         (Py_buffer_up): New typedef.
9736
9737 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9738
9739         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9740         instead of releasing ownership.
9741
9742 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9743
9744         * dwarf2read.c (open_and_init_dwp_file): Call
9745         elf_numsections instead of bfd_count_sections to initialize
9746         dwp_file->num_sections.
9747
9748 2019-02-25  Tom Tromey  <tromey@adacore.com>
9749
9750         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9751
9752 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9753
9754         * gcore.in: Add '--readnever' option when invoking GDB.
9755
9756 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9757
9758         * MAINTAINERS: Update my email address.
9759
9760 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9761
9762         * build-id.c (build_id_to_debug_bfd_1): New function.
9763         (build_id_to_debug_bfd): Look for separate debug file in
9764         sysroot.
9765
9766 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9767
9768         * gdbarch.sh: Update the copyright year range that is placed into
9769         generated files.
9770
9771 2019-02-22  Keith Seitz  <keiths@redhat.com>
9772
9773         PR symtab/23853
9774         * linespec.c (create_sals_line_offset): Search for the default
9775         symtab's filename instead of its fullname.
9776
9777 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9778
9779         * NEWS: Update style defaults.
9780
9781 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9782
9783         * main.c (captured_main_1): Disable styling in batch mode.
9784
9785 2019-02-20  Tom Tromey  <tom@tromey.com>
9786
9787         * symtab.c (symtab_symbol_info): Fix typos.
9788
9789 2019-02-20  Tom Tromey  <tromey@adacore.com>
9790
9791         * findcmd.c (_initialize_mem_search): Use upper case for
9792         metasyntactic variables.
9793
9794 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9795
9796         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9797         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9798
9799 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9800
9801         * top.h (source_file_name): Change to std::string.
9802         * top.c (source_file_name): Likewise.
9803         (command_line_input): Adjust.
9804         * cli/cli-script.c (script_from_file): Adjust.
9805
9806 2019-02-19  Tom Tromey  <tromey@adacore.com>
9807
9808         * ravenscar-thread.c
9809         (ravenscar_thread_target::update_thread_list): Don't call
9810         ada_build_task_list.
9811         * ada-lang.h (ada_build_task_list): Don't declare.
9812         * ada-tasks.c (struct ada_tasks_inferior_data)
9813         <task_list_valid_p>: Now bool.
9814         (read_known_tasks, ada_task_list_changed)
9815         (ada_tasks_invalidate_inferior_data): Update.
9816         (read_known_tasks_array): Return bool.
9817         (read_known_tasks_list): Likewise.
9818         (read_known_tasks): Return void.
9819         (ada_build_task_list): Now static.
9820
9821 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9824         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9825
9826 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9827
9828         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9829         variant for ada_tasks_pspace_data_handle and
9830         ada_tasks_inferior_data_handle.
9831         (ada_tasks_pspace_data_cleanup): New function.
9832         (ada_tasks_inferior_data_cleanup): New function.
9833
9834 2019-02-17  Tom Tromey  <tom@tromey.com>
9835
9836         * macrotab.h (macro_source_fullname): Return a std::string.
9837         * macrotab.c (macro_include, check_for_redefinition)
9838         (macro_undef, macro_lookup_definition, foreach_macro)
9839         (foreach_macro_in_scope): Update.
9840         (macro_source_fullname): Return a std::string.
9841         * macrocmd.c (show_pp_source_pos): Update.
9842
9843 2019-02-17  Tom Tromey  <tom@tromey.com>
9844
9845         * macrocmd.c (show_pp_source_pos): Style the file names.
9846
9847 2019-02-17  Tom Tromey  <tom@tromey.com>
9848
9849         PR tui/24197:
9850         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9851
9852 2019-02-17  Tom Tromey  <tom@tromey.com>
9853
9854         * ada-lang.c (user_select_syms): Use filtered printing.
9855         * utils.c (wrap_style): New global.
9856         (desired_style): Remove.
9857         (emit_style_escape): Add stream parameter.
9858         (set_output_style, reset_terminal_style, prompt_for_continue):
9859         Update.
9860         (flush_wrap_buffer): Only flush gdb_stdout.
9861         (wrap_here): Set wrap_style.
9862         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9863         treat escape sequences as a character.  Change when wrap buffer is
9864         flushed.
9865         (fputs_styled): Do not set the output style when the default is
9866         requested.
9867         * ui-style.h (struct ui_file_style) <is_default>: New method.
9868         * source.c (print_source_lines_base): Emit escape sequences in one
9869         piece.
9870
9871 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9872
9873         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9874         integers and enumeration types.
9875
9876 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9877
9878         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9879         instead of lookup_symbol_in_language
9880         (do_exact_match): New function.
9881         (ada_get_symbol_name_matcher): Return do_exact_match when
9882         doing a verbatim match.
9883
9884 2019-02-15  Tom Tromey  <tromey@adacore.com>
9885
9886         * ravenscar-thread.c (ravenscar_thread_target::resume)
9887         (ravenscar_thread_target::wait): Special case wildcard requests.
9888
9889 2019-02-15  Tom Tromey  <tromey@adacore.com>
9890
9891         * ravenscar-thread.c (base_ptid): Remove.
9892         (struct ravenscar_thread_target) <close>: New method.
9893         <m_base_ptid>: New member.
9894         <update_inferior_ptid, active_task, task_is_currently_active,
9895         runtime_initialized>: Declare methods.
9896         <ravenscar_thread_target>: Add constructor.
9897         (ravenscar_thread_target::task_is_currently_active)
9898         (ravenscar_thread_target::update_inferior_ptid)
9899         (ravenscar_runtime_initialized): Rename.  Now methods.
9900         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9901         (ravenscar_thread_target::update_thread_list): Update.
9902         (ravenscar_thread_target::active_task): Now method.
9903         (ravenscar_thread_target::store_registers)
9904         (ravenscar_thread_target::prepare_to_store)
9905         (ravenscar_thread_target::prepare_to_store)
9906         (ravenscar_thread_target::mourn_inferior): Update.
9907         (ravenscar_inferior_created): Use "new" to create target.
9908         (ravenscar_thread_target::get_ada_task_ptid): Update.
9909         (_initialize_ravenscar): Don't initialize base_ptid.
9910         (ravenscar_ops): Remove global.
9911
9912 2019-02-15  Tom Tromey  <tromey@adacore.com>
9913
9914         * target.h (push_target): Declare new overload.
9915         * target.c (push_target): New overload, taking an rvalue reference.
9916         * remote.c (remote_target::open_1): Use push_target overload.
9917         * corelow.c (core_target_open): Use push_target overload.
9918
9919 2019-02-15  Tom Tromey  <tromey@adacore.com>
9920
9921         * ravenscar-thread.c (is_ravenscar_task)
9922         (ravenscar_task_is_currently_active): Return bool.
9923         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9924         (_initialize_ravenscar): Remove "(void)".
9925         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9926         Return bool.
9927
9928 2019-02-15  Tom Tromey  <tromey@adacore.com>
9929
9930         * ravenscar-thread.c (ravenscar_runtime_initializer)
9931         (has_ravenscar_runtime, get_running_thread_id)
9932         (ravenscar_thread_target::resume): Fix indentation.
9933
9934 2019-02-15  Tom Tromey  <tromey@adacore.com>
9935
9936         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9937         from ravenscar_arch_ops.
9938         (sparc_ravenscar_ops::fetch_registers)
9939         (sparc_ravenscar_ops::store_registers): Now methods.
9940         (sparc_ravenscar_prepare_to_store): Remove.
9941         (sparc_ravenscar_ops): Redefine.
9942         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9943         methods and destructor.  Remove members.
9944         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9945         (ravenscar_thread_target::store_registers)
9946         (ravenscar_thread_target::prepare_to_store): Update.
9947         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9948         Remove.
9949         (struct ppc_ravenscar_powerpc_ops): Derive from
9950         ravenscar_arch_ops.
9951         (ppc_ravenscar_powerpc_ops::fetch_registers)
9952         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9953         (ppc_ravenscar_powerpc_ops): Redefine.
9954         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9955         (ppc_ravenscar_e500_ops::fetch_registers)
9956         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9957         (ppc_ravenscar_e500_ops): Redefine.
9958         * aarch64-ravenscar-thread.c
9959         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9960         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9961         (aarch64_ravenscar_fetch_registers)
9962         (aarch64_ravenscar_store_registers): Now methods.
9963         (aarch64_ravenscar_ops): Redefine.
9964
9965 2019-02-15  Tom Tromey  <tromey@adacore.com>
9966
9967         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9968         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9969         (ravenscar_thread_target::stopped_by_watchpoint)
9970         (ravenscar_thread_target::stopped_data_address)
9971         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9972
9973 2019-02-15  Tom Tromey  <tromey@adacore.com>
9974
9975         * ravenscar-thread.c: Fix some typos.
9976
9977 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9978             Tom Tromey  <tromey@adacore.com>
9979
9980         * ada-lang.c (ada_exception_sal): Change addr_string to a
9981         std::string.
9982         (create_ada_exception_catchpoint): Update.
9983
9984 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9985             Tom Tromey  <tromey@adacore.com>
9986
9987         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9988         (bp_location_ops): Remove.
9989         (base_breakpoint_allocate_location): Update.
9990         (free_bp_location): Update.
9991         * ada-lang.c (class ada_catchpoint_location)
9992         <ada_catchpoint_location>: Remove ops parameter.
9993         (ada_catchpoint_location_dtor): Remove.
9994         (ada_catchpoint_location_ops): Remove.
9995         (allocate_location_exception): Update.
9996         * breakpoint.h (struct bp_location_ops): Remove.
9997         (class bp_location) <bp_location>: Remove bp_location_ops
9998         parameter.
9999         <~bp_location>: Add destructor.
10000         <ops>: Remove.
10001
10002 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10003             Pedro Alves  <palves@redhat.com>
10004
10005         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10006         'PATH_MAX'.
10007
10008 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10009             Samuel Thibault  <samuel.thibault@gnu.org>
10010             Thomas Schwinge  <thomas@codesourcery.com>
10011
10012         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10013         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10014
10015 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10016
10017         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10018         (check_empty): Use "const char *".
10019
10020         * gnu-nat.c (gnu_nat_target::detach): Instead of
10021         'detach_inferior (pid)' call
10022         'detach_inferior (find_inferior_pid (pid))'.
10023
10024         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10025         'nat/fork-inferior.o'.
10026         * gnu-nat.c: #include "nat/fork-inferior.h".
10027
10028         * gnu-nat.c (gnu_nat_target::detach): Instead of
10029         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10030         * gnu-nat.h: #include "inf-child.h".
10031         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10032         'i386_gnu_nat_target::fetch_registers'.
10033         (gnu_store_registers): Rename/move to
10034         'i386_gnu_nat_target::store_registers'.
10035
10036         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10037         * gnu-nat.h (mach_thread_info): New function.
10038         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10039
10040         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10041
10042 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10043
10044         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10045
10046 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10047
10048         * windows-nat.c (windows_add_thread): Add new parameter
10049         "main_thread_p" with default value set to false.  Update
10050         function documentation as well as all callers.
10051         (windows_delete_thread): Likewise.
10052         (fake_create_process): Update call to windows_add_thread.
10053         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10054         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10055         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10056         call to windows_delete_thread.
10057
10058 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10059
10060         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10061
10062 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10063
10064         * symfile.c (find_separate_debug_file): Use canonical path of
10065         sysroot with child_path instead of gdb_sysroot if it is valid.
10066
10067 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10068
10069         * symfile.c (find_separate_debug_file): Use child_path to
10070         determine if an object file is under a sysroot.
10071
10072 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10073
10074         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10075         unittests/child-path-selftests.c.
10076         * common/pathstuff.c (child_path): New function.
10077         * common/pathstuff.h (child_path): New prototype.
10078         * unittests/child-path-selftests.c: New file.
10079
10080 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10081
10082         * symfile.c (find_separate_debug_file): Look for separate debug
10083         files in debug directories under the sysroot.
10084
10085 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10086
10087         * symtab.h (struct minimal_symbol data_p): New const method.
10088         (struct minimal_symbol text_p): Likewise.
10089         * symtab.c (output_source_filename): Use file name style
10090         to print file name.
10091         (print_symbol_info): Likewise.
10092         (print_msymbol_info): Use address style to print addresses.
10093         Use function name style to print executable text symbols.
10094         (expand_symtab_containing_pc): Use data_p.
10095         (find_pc_sect_compunit_symtab): Likewise.
10096
10097 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10098
10099         * breakpoint.c (describe_other_breakpoints): Use address style
10100         to print addresses.
10101         (say_where): Likewise.
10102
10103 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10104
10105         * ada-typeprint.c (print_func_type): Print function name
10106         style to print function name.
10107         * c-typeprint.c (c_print_type_1): Likewise.
10108
10109 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10110
10111         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10112         for execve.
10113
10114 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10115
10116         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10117         type_stack.
10118
10119 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10120
10121         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10122         TYPE_CODE_REF types.
10123
10124 2019-02-08  Jim Wilson  <jimw@sifive.com>
10125
10126         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10127         (riscv_linux_fregset): New.
10128         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10129
10130 2019-02-07  Tom Tromey  <tom@tromey.com>
10131
10132         * thread.c (thread_cancel_execution_command): Update.
10133         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10134         methods.
10135         (struct thread_fsm_ops): Remove.
10136         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10137         (thread_fsm_should_stop, thread_fsm_return_value)
10138         (thread_fsm_set_finished, thread_fsm_finished_p)
10139         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10140         Don't declare.
10141         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10142         * infrun.c (clear_proceed_status_thread)
10143         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10144         (print_stop_event): Update.
10145         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10146         Add constructor.
10147         (step_command_fsm_ops): Remove.
10148         (new_step_command_fsm): Remove.
10149         (step_1): Update.
10150         (step_command_fsm::should_stop): Rename from
10151         step_command_fsm_should_stop.
10152         (step_command_fsm::clean_up): Rename from
10153         step_command_fsm_clean_up.
10154         (step_command_fsm::do_async_reply_reason): Rename from
10155         step_command_fsm_async_reply_reason.
10156         (struct until_next_fsm): Inherit from thread_fsm.  Add
10157         constructor.
10158         (until_next_fsm_ops): Remove.
10159         (new_until_next_fsm): Remove.
10160         (until_next_fsm::should_stop): Rename from
10161         until_next_fsm_should_stop.
10162         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10163         (until_next_fsm::do_async_reply_reason): Rename from
10164         until_next_fsm_async_reply_reason.
10165         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10166         constructor.  Change type of breakpoint.
10167         (finish_command_fsm_ops): Remove.
10168         (new_finish_command_fsm): Remove.
10169         (finish_command_fsm::should_stop): Rename from
10170         finish_command_fsm_should_stop.
10171         (finish_command_fsm::clean_up): Rename from
10172         finish_command_fsm_clean_up.
10173         (finish_command_fsm::return_value): Rename from
10174         finish_command_fsm_return_value.
10175         (finish_command_fsm::do_async_reply_reason): Rename from
10176         finish_command_fsm_async_reply_reason.
10177         (finish_command): Update.
10178         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10179         Add constructor.
10180         (call_thread_fsm_ops): Remove.
10181         (call_thread_fsm::call_thread_fsm): Rename from
10182         new_call_thread_fsm.
10183         (call_thread_fsm::should_stop): Rename from
10184         call_thread_fsm_should_stop.
10185         (call_thread_fsm::should_notify_stop): Rename from
10186         call_thread_fsm_should_notify_stop.
10187         (run_inferior_call, call_function_by_hand_dummy): Update.
10188         * cli/cli-interp.c (should_print_stop_to_console): Update.
10189         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10190         Add constructor.  Change type of location_breakpoint,
10191         caller_breakpoint.
10192         (until_break_fsm_ops): Remove.
10193         (new_until_break_fsm): Remove.
10194         (until_break_fsm::should_stop): Rename from
10195         until_break_fsm_should_stop.
10196         (until_break_fsm::clean_up): Rename from
10197         until_break_fsm_clean_up.
10198         (until_break_fsm::do_async_reply_reason): Rename from
10199         until_break_fsm_async_reply_reason.
10200         (until_break_command): Update.
10201         * thread-fsm.c: Remove.
10202         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10203
10204 2019-02-07  Tom Tromey  <tom@tromey.com>
10205
10206         * yy-remap.h: Add include guard.
10207         * xtensa-tdep.h: Add include guard.
10208         * xcoffread.h: Rename include guard.
10209         * varobj-iter.h: Add include guard.
10210         * tui/tui.h: Rename include guard.
10211         * tui/tui-winsource.h: Rename include guard.
10212         * tui/tui-wingeneral.h: Rename include guard.
10213         * tui/tui-windata.h: Rename include guard.
10214         * tui/tui-win.h: Rename include guard.
10215         * tui/tui-stack.h: Rename include guard.
10216         * tui/tui-source.h: Rename include guard.
10217         * tui/tui-regs.h: Rename include guard.
10218         * tui/tui-out.h: Rename include guard.
10219         * tui/tui-layout.h: Rename include guard.
10220         * tui/tui-io.h: Rename include guard.
10221         * tui/tui-hooks.h: Rename include guard.
10222         * tui/tui-file.h: Rename include guard.
10223         * tui/tui-disasm.h: Rename include guard.
10224         * tui/tui-data.h: Rename include guard.
10225         * tui/tui-command.h: Rename include guard.
10226         * tic6x-tdep.h: Add include guard.
10227         * target/waitstatus.h: Rename include guard.
10228         * target/wait.h: Rename include guard.
10229         * target/target.h: Rename include guard.
10230         * target/resume.h: Rename include guard.
10231         * target-float.h: Rename include guard.
10232         * stabsread.h: Add include guard.
10233         * rs6000-tdep.h: Add include guard.
10234         * riscv-fbsd-tdep.h: Add include guard.
10235         * regformats/regdef.h: Rename include guard.
10236         * record.h: Rename include guard.
10237         * python/python.h: Rename include guard.
10238         * python/python-internal.h: Rename include guard.
10239         * python/py-stopevent.h: Rename include guard.
10240         * python/py-ref.h: Rename include guard.
10241         * python/py-record.h: Rename include guard.
10242         * python/py-record-full.h: Rename include guard.
10243         * python/py-record-btrace.h: Rename include guard.
10244         * python/py-instruction.h: Rename include guard.
10245         * python/py-events.h: Rename include guard.
10246         * python/py-event.h: Rename include guard.
10247         * procfs.h: Add include guard.
10248         * proc-utils.h: Add include guard.
10249         * p-lang.h: Add include guard.
10250         * or1k-tdep.h: Rename include guard.
10251         * observable.h: Rename include guard.
10252         * nto-tdep.h: Rename include guard.
10253         * nat/x86-linux.h: Rename include guard.
10254         * nat/x86-linux-dregs.h: Rename include guard.
10255         * nat/x86-gcc-cpuid.h: Add include guard.
10256         * nat/x86-dregs.h: Rename include guard.
10257         * nat/x86-cpuid.h: Rename include guard.
10258         * nat/ppc-linux.h: Rename include guard.
10259         * nat/mips-linux-watch.h: Rename include guard.
10260         * nat/linux-waitpid.h: Rename include guard.
10261         * nat/linux-ptrace.h: Rename include guard.
10262         * nat/linux-procfs.h: Rename include guard.
10263         * nat/linux-osdata.h: Rename include guard.
10264         * nat/linux-nat.h: Rename include guard.
10265         * nat/linux-namespaces.h: Rename include guard.
10266         * nat/linux-btrace.h: Rename include guard.
10267         * nat/glibc_thread_db.h: Rename include guard.
10268         * nat/gdb_thread_db.h: Rename include guard.
10269         * nat/gdb_ptrace.h: Rename include guard.
10270         * nat/fork-inferior.h: Rename include guard.
10271         * nat/amd64-linux-siginfo.h: Rename include guard.
10272         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10273         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10274         * nat/aarch64-linux.h: Rename include guard.
10275         * nat/aarch64-linux-hw-point.h: Rename include guard.
10276         * mn10300-tdep.h: Add include guard.
10277         * mips-linux-tdep.h: Add include guard.
10278         * mi/mi-parse.h: Rename include guard.
10279         * mi/mi-out.h: Rename include guard.
10280         * mi/mi-main.h: Rename include guard.
10281         * mi/mi-interp.h: Rename include guard.
10282         * mi/mi-getopt.h: Rename include guard.
10283         * mi/mi-console.h: Rename include guard.
10284         * mi/mi-common.h: Rename include guard.
10285         * mi/mi-cmds.h: Rename include guard.
10286         * mi/mi-cmd-break.h: Rename include guard.
10287         * m2-lang.h: Add include guard.
10288         * location.h: Rename include guard.
10289         * linux-record.h: Rename include guard.
10290         * linux-nat.h: Add include guard.
10291         * linux-fork.h: Add include guard.
10292         * i386-darwin-tdep.h: Rename include guard.
10293         * hppa-linux-offsets.h: Add include guard.
10294         * guile/guile.h: Rename include guard.
10295         * guile/guile-internal.h: Rename include guard.
10296         * gnu-nat.h: Rename include guard.
10297         * gdb-stabs.h: Rename include guard.
10298         * frv-tdep.h: Add include guard.
10299         * f-lang.h: Add include guard.
10300         * event-loop.h: Add include guard.
10301         * darwin-nat.h: Rename include guard.
10302         * cp-abi.h: Rename include guard.
10303         * config/sparc/nm-sol2.h: Rename include guard.
10304         * config/nm-nto.h: Rename include guard.
10305         * config/nm-linux.h: Add include guard.
10306         * config/i386/nm-i386gnu.h: Rename include guard.
10307         * config/djgpp/nl_types.h: Rename include guard.
10308         * config/djgpp/langinfo.h: Rename include guard.
10309         * compile/gcc-cp-plugin.h: Add include guard.
10310         * compile/gcc-c-plugin.h: Add include guard.
10311         * compile/compile.h: Rename include guard.
10312         * compile/compile-object-run.h: Rename include guard.
10313         * compile/compile-object-load.h: Rename include guard.
10314         * compile/compile-internal.h: Rename include guard.
10315         * compile/compile-cplus.h: Rename include guard.
10316         * compile/compile-c.h: Rename include guard.
10317         * common/xml-utils.h: Rename include guard.
10318         * common/x86-xstate.h: Rename include guard.
10319         * common/version.h: Rename include guard.
10320         * common/vec.h: Rename include guard.
10321         * common/tdesc.h: Rename include guard.
10322         * common/selftest.h: Rename include guard.
10323         * common/scoped_restore.h: Rename include guard.
10324         * common/scoped_mmap.h: Rename include guard.
10325         * common/scoped_fd.h: Rename include guard.
10326         * common/safe-iterator.h: Rename include guard.
10327         * common/run-time-clock.h: Rename include guard.
10328         * common/refcounted-object.h: Rename include guard.
10329         * common/queue.h: Rename include guard.
10330         * common/ptid.h: Rename include guard.
10331         * common/print-utils.h: Rename include guard.
10332         * common/preprocessor.h: Rename include guard.
10333         * common/pathstuff.h: Rename include guard.
10334         * common/observable.h: Rename include guard.
10335         * common/netstuff.h: Rename include guard.
10336         * common/job-control.h: Rename include guard.
10337         * common/host-defs.h: Rename include guard.
10338         * common/gdb_wait.h: Rename include guard.
10339         * common/gdb_vecs.h: Rename include guard.
10340         * common/gdb_unlinker.h: Rename include guard.
10341         * common/gdb_unique_ptr.h: Rename include guard.
10342         * common/gdb_tilde_expand.h: Rename include guard.
10343         * common/gdb_sys_time.h: Rename include guard.
10344         * common/gdb_string_view.h: Rename include guard.
10345         * common/gdb_splay_tree.h: Rename include guard.
10346         * common/gdb_setjmp.h: Rename include guard.
10347         * common/gdb_ref_ptr.h: Rename include guard.
10348         * common/gdb_optional.h: Rename include guard.
10349         * common/gdb_locale.h: Rename include guard.
10350         * common/gdb_assert.h: Rename include guard.
10351         * common/filtered-iterator.h: Rename include guard.
10352         * common/filestuff.h: Rename include guard.
10353         * common/fileio.h: Rename include guard.
10354         * common/environ.h: Rename include guard.
10355         * common/common-utils.h: Rename include guard.
10356         * common/common-types.h: Rename include guard.
10357         * common/common-regcache.h: Rename include guard.
10358         * common/common-inferior.h: Rename include guard.
10359         * common/common-gdbthread.h: Rename include guard.
10360         * common/common-exceptions.h: Rename include guard.
10361         * common/common-defs.h: Rename include guard.
10362         * common/common-debug.h: Rename include guard.
10363         * common/cleanups.h: Rename include guard.
10364         * common/buffer.h: Rename include guard.
10365         * common/btrace-common.h: Rename include guard.
10366         * common/break-common.h: Rename include guard.
10367         * cli/cli-utils.h: Rename include guard.
10368         * cli/cli-style.h: Rename include guard.
10369         * cli/cli-setshow.h: Rename include guard.
10370         * cli/cli-script.h: Rename include guard.
10371         * cli/cli-interp.h: Rename include guard.
10372         * cli/cli-decode.h: Rename include guard.
10373         * cli/cli-cmds.h: Rename include guard.
10374         * charset-list.h: Add include guard.
10375         * buildsym-legacy.h: Rename include guard.
10376         * bfin-tdep.h: Add include guard.
10377         * ax.h: Rename include guard.
10378         * arm-linux-tdep.h: Add include guard.
10379         * arm-fbsd-tdep.h: Add include guard.
10380         * arch/xtensa.h: Rename include guard.
10381         * arch/tic6x.h: Add include guard.
10382         * arch/i386.h: Add include guard.
10383         * arch/arm.h: Rename include guard.
10384         * arch/arm-linux.h: Rename include guard.
10385         * arch/arm-get-next-pcs.h: Rename include guard.
10386         * arch/amd64.h: Add include guard.
10387         * arch/aarch64-insn.h: Rename include guard.
10388         * arch-utils.h: Rename include guard.
10389         * annotate.h: Add include guard.
10390         * amd64-darwin-tdep.h: Rename include guard.
10391         * aarch64-linux-tdep.h: Add include guard.
10392         * aarch64-fbsd-tdep.h: Add include guard.
10393         * aarch32-linux-nat.h: Add include guard.
10394
10395 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10396
10397         * macrotab.c (macro_define_internal): New function that
10398         factorizes macro_define_object_internal and macro_define_function
10399         code.
10400         (macro_define_object_internal): Use macro_define_internal.
10401         (macro_define_function): Likewise.
10402
10403 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10404
10405         * macrocmd.c (extract_identifier): Return
10406         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10407         callers.
10408
10409 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10410
10411         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10412
10413 2019-02-05  Tom Tromey  <tom@tromey.com>
10414
10415         * target.c (target_stack::unpush): Move assertion earlier.
10416
10417 2019-01-30  Tom Tromey  <tom@tromey.com>
10418
10419         PR python/23615:
10420         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10421         (gdbpy_parse_and_eval): Likewise.
10422         * python/python-internal.h (gdbpy_allow_threads): New class.
10423
10424 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10425
10426         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10427         (aarch64_fbsd_fpregmap): Move earlier.
10428         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10429         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10430         instead of individual calls to trad_frame_set_reg_addr.
10431         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10432         earlier.
10433         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10434         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10435         instead of individual calls to trad_frame_set_reg_addr.
10436
10437 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10438
10439         * CONTRIBUTE: Replace contribution list with wiki link.
10440
10441 2019-01-25  Tom Tromey  <tom@tromey.com>
10442
10443         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10444
10445 2019-01-25  Tom Tromey  <tom@tromey.com>
10446
10447         * xtensa-linux-nat.c: Fix common/ includes.
10448         * xml-support.h: Fix common/ includes.
10449         * xml-support.c: Fix common/ includes.
10450         * x86-linux-nat.c: Fix common/ includes.
10451         * windows-nat.c: Fix common/ includes.
10452         * varobj.h: Fix common/ includes.
10453         * varobj.c: Fix common/ includes.
10454         * value.c: Fix common/ includes.
10455         * valops.c: Fix common/ includes.
10456         * utils.c: Fix common/ includes.
10457         * unittests/xml-utils-selftests.c: Fix common/ includes.
10458         * unittests/utils-selftests.c: Fix common/ includes.
10459         * unittests/unpack-selftests.c: Fix common/ includes.
10460         * unittests/tracepoint-selftests.c: Fix common/ includes.
10461         * unittests/style-selftests.c: Fix common/ includes.
10462         * unittests/string_view-selftests.c: Fix common/ includes.
10463         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10464         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10465         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10466         * unittests/rsp-low-selftests.c: Fix common/ includes.
10467         * unittests/parse-connection-spec-selftests.c: Fix common/
10468         includes.
10469         * unittests/optional-selftests.c: Fix common/ includes.
10470         * unittests/offset-type-selftests.c: Fix common/ includes.
10471         * unittests/observable-selftests.c: Fix common/ includes.
10472         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10473         * unittests/memrange-selftests.c: Fix common/ includes.
10474         * unittests/memory-map-selftests.c: Fix common/ includes.
10475         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10476         * unittests/function-view-selftests.c: Fix common/ includes.
10477         * unittests/environ-selftests.c: Fix common/ includes.
10478         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10479         * unittests/common-utils-selftests.c: Fix common/ includes.
10480         * unittests/cli-utils-selftests.c: Fix common/ includes.
10481         * unittests/array-view-selftests.c: Fix common/ includes.
10482         * ui-file.c: Fix common/ includes.
10483         * tui/tui-io.c: Fix common/ includes.
10484         * tracepoint.h: Fix common/ includes.
10485         * tracepoint.c: Fix common/ includes.
10486         * tracefile-tfile.c: Fix common/ includes.
10487         * top.h: Fix common/ includes.
10488         * top.c: Fix common/ includes.
10489         * thread.c: Fix common/ includes.
10490         * target/waitstatus.h: Fix common/ includes.
10491         * target/waitstatus.c: Fix common/ includes.
10492         * target.h: Fix common/ includes.
10493         * target.c: Fix common/ includes.
10494         * target-memory.c: Fix common/ includes.
10495         * target-descriptions.c: Fix common/ includes.
10496         * symtab.h: Fix common/ includes.
10497         * symfile.c: Fix common/ includes.
10498         * stap-probe.c: Fix common/ includes.
10499         * spu-linux-nat.c: Fix common/ includes.
10500         * sparc-nat.c: Fix common/ includes.
10501         * source.c: Fix common/ includes.
10502         * solib.c: Fix common/ includes.
10503         * solib-target.c: Fix common/ includes.
10504         * ser-unix.c: Fix common/ includes.
10505         * ser-tcp.c: Fix common/ includes.
10506         * ser-pipe.c: Fix common/ includes.
10507         * ser-base.c: Fix common/ includes.
10508         * selftest-arch.c: Fix common/ includes.
10509         * s12z-tdep.c: Fix common/ includes.
10510         * rust-exp.y: Fix common/ includes.
10511         * rs6000-aix-tdep.c: Fix common/ includes.
10512         * riscv-tdep.c: Fix common/ includes.
10513         * remote.c: Fix common/ includes.
10514         * remote-notif.h: Fix common/ includes.
10515         * remote-fileio.h: Fix common/ includes.
10516         * remote-fileio.c: Fix common/ includes.
10517         * regcache.h: Fix common/ includes.
10518         * regcache.c: Fix common/ includes.
10519         * record-btrace.c: Fix common/ includes.
10520         * python/python.c: Fix common/ includes.
10521         * python/py-type.c: Fix common/ includes.
10522         * python/py-inferior.c: Fix common/ includes.
10523         * progspace.h: Fix common/ includes.
10524         * producer.c: Fix common/ includes.
10525         * procfs.c: Fix common/ includes.
10526         * proc-api.c: Fix common/ includes.
10527         * printcmd.c: Fix common/ includes.
10528         * ppc-linux-nat.c: Fix common/ includes.
10529         * parser-defs.h: Fix common/ includes.
10530         * osdata.c: Fix common/ includes.
10531         * obsd-nat.c: Fix common/ includes.
10532         * nat/x86-linux.c: Fix common/ includes.
10533         * nat/x86-linux-dregs.c: Fix common/ includes.
10534         * nat/x86-dregs.h: Fix common/ includes.
10535         * nat/x86-dregs.c: Fix common/ includes.
10536         * nat/ppc-linux.c: Fix common/ includes.
10537         * nat/mips-linux-watch.h: Fix common/ includes.
10538         * nat/mips-linux-watch.c: Fix common/ includes.
10539         * nat/linux-waitpid.c: Fix common/ includes.
10540         * nat/linux-ptrace.h: Fix common/ includes.
10541         * nat/linux-ptrace.c: Fix common/ includes.
10542         * nat/linux-procfs.c: Fix common/ includes.
10543         * nat/linux-personality.c: Fix common/ includes.
10544         * nat/linux-osdata.c: Fix common/ includes.
10545         * nat/linux-namespaces.c: Fix common/ includes.
10546         * nat/linux-btrace.h: Fix common/ includes.
10547         * nat/linux-btrace.c: Fix common/ includes.
10548         * nat/fork-inferior.c: Fix common/ includes.
10549         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10550         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10551         * nat/aarch64-linux.c: Fix common/ includes.
10552         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10553         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10554         * namespace.h: Fix common/ includes.
10555         * mips-linux-tdep.c: Fix common/ includes.
10556         * minsyms.c: Fix common/ includes.
10557         * mi/mi-parse.h: Fix common/ includes.
10558         * mi/mi-main.c: Fix common/ includes.
10559         * mi/mi-cmd-env.c: Fix common/ includes.
10560         * memrange.h: Fix common/ includes.
10561         * memattr.c: Fix common/ includes.
10562         * maint.h: Fix common/ includes.
10563         * maint.c: Fix common/ includes.
10564         * main.c: Fix common/ includes.
10565         * machoread.c: Fix common/ includes.
10566         * location.c: Fix common/ includes.
10567         * linux-thread-db.c: Fix common/ includes.
10568         * linux-nat.c: Fix common/ includes.
10569         * linux-fork.c: Fix common/ includes.
10570         * inline-frame.c: Fix common/ includes.
10571         * infrun.c: Fix common/ includes.
10572         * inflow.c: Fix common/ includes.
10573         * inferior.h: Fix common/ includes.
10574         * inferior.c: Fix common/ includes.
10575         * infcmd.c: Fix common/ includes.
10576         * inf-ptrace.c: Fix common/ includes.
10577         * inf-child.c: Fix common/ includes.
10578         * ia64-linux-nat.c: Fix common/ includes.
10579         * i387-tdep.c: Fix common/ includes.
10580         * i386-tdep.c: Fix common/ includes.
10581         * i386-linux-tdep.c: Fix common/ includes.
10582         * i386-linux-nat.c: Fix common/ includes.
10583         * i386-go32-tdep.c: Fix common/ includes.
10584         * i386-fbsd-tdep.c: Fix common/ includes.
10585         * i386-fbsd-nat.c: Fix common/ includes.
10586         * guile/scm-type.c: Fix common/ includes.
10587         * guile/guile.c: Fix common/ includes.
10588         * go32-nat.c: Fix common/ includes.
10589         * gnu-nat.c: Fix common/ includes.
10590         * gdbthread.h: Fix common/ includes.
10591         * gdbarch-selftests.c: Fix common/ includes.
10592         * gdb_usleep.c: Fix common/ includes.
10593         * gdb_select.h: Fix common/ includes.
10594         * gdb_bfd.c: Fix common/ includes.
10595         * gcore.c: Fix common/ includes.
10596         * fork-child.c: Fix common/ includes.
10597         * findvar.c: Fix common/ includes.
10598         * fbsd-nat.c: Fix common/ includes.
10599         * event-top.c: Fix common/ includes.
10600         * event-loop.c: Fix common/ includes.
10601         * dwarf2read.c: Fix common/ includes.
10602         * dwarf2loc.c: Fix common/ includes.
10603         * dwarf2-frame.c: Fix common/ includes.
10604         * dwarf-index-cache.c: Fix common/ includes.
10605         * dtrace-probe.c: Fix common/ includes.
10606         * disasm-selftests.c: Fix common/ includes.
10607         * defs.h: Fix common/ includes.
10608         * csky-tdep.c: Fix common/ includes.
10609         * cp-valprint.c: Fix common/ includes.
10610         * cp-support.h: Fix common/ includes.
10611         * cp-support.c: Fix common/ includes.
10612         * corelow.c: Fix common/ includes.
10613         * completer.h: Fix common/ includes.
10614         * completer.c: Fix common/ includes.
10615         * compile/compile.c: Fix common/ includes.
10616         * compile/compile-loc2c.c: Fix common/ includes.
10617         * compile/compile-cplus-types.c: Fix common/ includes.
10618         * compile/compile-cplus-symbols.c: Fix common/ includes.
10619         * command.h: Fix common/ includes.
10620         * cli/cli-dump.c: Fix common/ includes.
10621         * cli/cli-cmds.c: Fix common/ includes.
10622         * charset.c: Fix common/ includes.
10623         * build-id.c: Fix common/ includes.
10624         * btrace.h: Fix common/ includes.
10625         * btrace.c: Fix common/ includes.
10626         * breakpoint.h: Fix common/ includes.
10627         * breakpoint.c: Fix common/ includes.
10628         * ax.h:
10629         (enum agent_op): Fix common/ includes.
10630         * ax-general.c (struct aop_map): Fix common/ includes.
10631         * ax-gdb.c: Fix common/ includes.
10632         * auxv.c: Fix common/ includes.
10633         * auto-load.c: Fix common/ includes.
10634         * arm-tdep.c: Fix common/ includes.
10635         * arch/riscv.c: Fix common/ includes.
10636         * arch/ppc-linux-common.c: Fix common/ includes.
10637         * arch/i386.c: Fix common/ includes.
10638         * arch/arm.c: Fix common/ includes.
10639         * arch/arm-linux.c: Fix common/ includes.
10640         * arch/arm-get-next-pcs.c: Fix common/ includes.
10641         * arch/amd64.c: Fix common/ includes.
10642         * arch/aarch64.c: Fix common/ includes.
10643         * arch/aarch64-insn.c: Fix common/ includes.
10644         * arch-utils.c: Fix common/ includes.
10645         * amd64-windows-tdep.c: Fix common/ includes.
10646         * amd64-tdep.c: Fix common/ includes.
10647         * amd64-sol2-tdep.c: Fix common/ includes.
10648         * amd64-obsd-tdep.c: Fix common/ includes.
10649         * amd64-nbsd-tdep.c: Fix common/ includes.
10650         * amd64-linux-tdep.c: Fix common/ includes.
10651         * amd64-linux-nat.c: Fix common/ includes.
10652         * amd64-fbsd-tdep.c: Fix common/ includes.
10653         * amd64-fbsd-nat.c: Fix common/ includes.
10654         * amd64-dicos-tdep.c: Fix common/ includes.
10655         * amd64-darwin-tdep.c: Fix common/ includes.
10656         * agent.c: Fix common/ includes.
10657         * ada-lang.h: Fix common/ includes.
10658         * ada-lang.c: Fix common/ includes.
10659         * aarch64-tdep.c: Fix common/ includes.
10660
10661 2019-01-25  Tom Tromey  <tom@tromey.com>
10662
10663         * common/create-version.sh: Use common/version.h.
10664
10665 2019-01-24  Pedro Alves  <palves@redhat.com>
10666
10667         * infrun.c (signal_stop, signal_print, signal_program)
10668         (signal_catch, signal_pass): Now arrays instead of pointers.
10669         (update_signals_program_target, do_target_resume)
10670         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10671         * linux-nat.c (linux_nat_target::pass_signals)
10672         (linux_nat_target::create_inferior, linux_nat_target::attach):
10673         Adjust.
10674         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10675         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10676         * procfs.c (procfs_target::pass_signals): Adjust.
10677         * record-full.c (record_full_target::resume): Adjust.
10678         * remote.c (remote_target::pass_signals)
10679         (remote_target::program_signals): Adjust.
10680         * target-debug.h (target_debug_print_signals): Now takes a
10681         gdb::array_view as parameter.  Adjust.
10682         * target.h (target_ops) <pass_signals, program_signals>: Replace
10683         pointer and length parameters with gdb::array_view.
10684         (target_pass_signals, target_program_signals): Likewise.
10685         * target-delegates.c: Regenerate.
10686
10687 2019-01-24  Pedro Alves  <palves@redhat.com>
10688
10689         * common/forward-scope-exit.h
10690         (forward_scope_exit::forward_scope_exit): Pass arguments to
10691         m_bind_function directly, instead of creating a std::bind and
10692         copying that.
10693
10694 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10695
10696         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10697         for static members.
10698         (pass_in_v_vfp_candidate): Likewise.
10699
10700 2019-01-23  Tom Tromey  <tom@tromey.com>
10701             Pedro Alves  <palves@redhat.com>
10702
10703         * regcache.c (class regcache_invalidator): Remove.
10704         (regcache::raw_write): Use make_scope_exit.
10705
10706 2019-01-23  Tom Tromey  <tom@tromey.com>
10707
10708         * ui-out.h (class ui_out_emit_type): Update comment.
10709
10710 2019-01-23  Tom Tromey  <tom@tromey.com>
10711
10712         * infrun.c (fetch_inferior_event): Update comment.
10713
10714 2019-01-23  Tom Tromey  <tom@tromey.com>
10715             Pedro Alves  <palves@redhat.com>
10716
10717         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10718         parameter.
10719         (fetch_inferior_event): Use SCOPE_EXIT.
10720
10721
10722 2019-01-23  Tom Tromey  <tom@tromey.com>
10723             Pedro Alves  <palves@redhat.com>
10724
10725         * infrun.c (disable_thread_events): Delete.
10726         (stop_all_threads): Use SCOPE_EXIT.
10727
10728 2019-01-23  Tom Tromey  <tom@tromey.com>
10729             Pedro Alves  <palves@redhat.com>
10730
10731         * symfile.c: Include forward-scope-exit.h.
10732         (clear_symtab_users_cleanup): Replace forward declaration with
10733         a FORWARD_SCOPE_EXIT.
10734         (syms_from_objfile_1): Use the forward_scope_exit and
10735         gdb::optional instead of cleanup_function.
10736         (reread_symbols): Use the forward_scope_exit instead of
10737         cleanup_function.
10738         (clear_symtab_users_cleanup): Remove function.
10739
10740 2019-01-23  Tom Tromey  <tom@tromey.com>
10741             Pedro Alves  <palves@redhat.com>
10742
10743         * linux-nat.c: Include scope-exit.h.
10744         (cleanup_target_stop): Remove.
10745         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10746         SCOPE_EXIT.
10747
10748 2019-01-23  Tom Tromey  <tom@tromey.com>
10749             Pedro Alves  <palves@redhat.com>
10750
10751         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10752         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10753
10754 2019-01-23  Tom Tromey  <tom@tromey.com>
10755             Andrew Burgess  <andrew.burgess@embecosm.com>
10756             Pedro Alves  <palves@redhat.com>
10757
10758         * infrun.c (fetch_inferior_event): Use scope_exit.
10759         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10760         * top.c (execute_command): Use scope_exit.
10761         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10762         * utils.c (do_bpstat_clear_actions_cleanup)
10763         (make_bpstat_clear_actions_cleanup): Remove.
10764
10765 2019-01-23  Tom Tromey  <tom@tromey.com>
10766             Pedro Alves  <palves@redhat.com>
10767
10768         * infrun.c: Include "common/scope-exit.h"
10769         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10770         (wait_for_inferior): Use SCOPE_EXIT.
10771         (fetch_inferior_event): Use scope_exit.
10772
10773 2019-01-23  Tom Tromey  <tom@tromey.com>
10774             Pedro Alves  <palves@redhat.com>
10775
10776         * breakpoint.c (create_breakpoint): Remove cleanup.
10777
10778 2019-01-23  Tom Tromey  <tom@tromey.com>
10779             Andrew Burgess  <andrew.burgess@embecosm.com>
10780             Pedro Alves  <palves@redhat.com>
10781
10782 2019-01-23  Pedro Alves  <palves@redhat.com>
10783
10784         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10785
10786 2019-01-23  Pedro Alves  <palves@redhat.com>
10787             Andrew Burgess  <andrew.burgess@embecosm.com>
10788
10789         * gdbthread.h: Include "common/forward-scope-exit.h".
10790         (scoped_finish_thread_state): Redefine custom class in terms of
10791         forward_scope_exit.
10792
10793 2019-01-23  Pedro Alves  <palves@redhat.com>
10794             Andrew Burgess  <andrew.burgess@embecosm.com>
10795
10796         * common/forward-scope-exit.h: New file.
10797
10798 2019-01-23  Pedro Alves  <palves@redhat.com>
10799             Andrew Burgess  <andrew.burgess@embecosm.com>
10800             Tom Tromey  <tom@tromey.com>
10801
10802         * common/scope-exit.h: New file.
10803
10804 2019-01-23  Pedro Alves  <palves@redhat.com>
10805
10806         * common/preprocessor.h (ESC): Rename to ...
10807         (ESC_PARENS): ... this.
10808         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10809         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10810
10811 2019-01-23  Tom Tromey  <tom@tromey.com>
10812
10813         * language.h (class scoped_switch_to_sym_language_if_auto):
10814         Initialize m_lang in both cases.
10815
10816 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10817
10818         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10819         with XCNEW.
10820
10821 2019-01-22  Tom Tromey  <tom@tromey.com>
10822
10823         * corelow.c: Do not include sys/file.h.
10824
10825 2019-01-22  Tom Tromey  <tom@tromey.com>
10826
10827         * tui/tui-wingeneral.h: Include gdb_curses.h.
10828
10829 2019-01-22  Tom Tromey  <tom@tromey.com>
10830
10831         * source-cache.h (class source_cache) <get_source_lines,
10832         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10833
10834 2019-01-22  Tom Tromey  <tom@tromey.com>
10835
10836         * remote-fileio.h (struct remote_target): Declare.
10837
10838 2019-01-22  Tom Tromey  <tom@tromey.com>
10839
10840         * python/py-arch.c: Do not include py-ref.h.
10841         * python/py-bpevent.c: Do not include py-ref.h.
10842         * python/py-cmd.c: Do not include py-ref.h.
10843         * python/py-continueevent.c: Do not include py-ref.h.
10844         * python/py-event.h: Do not include py-ref.h.
10845         * python/py-evtregistry.c: Do not include py-ref.h.
10846         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10847         * python/py-frame.c: Do not include py-ref.h.
10848         * python/py-framefilter.c: Do not include py-ref.h.
10849         * python/py-function.c: Do not include py-ref.h.
10850         * python/py-infevents.c: Do not include py-ref.h.
10851         * python/py-linetable.c: Do not include py-ref.h.
10852         * python/py-objfile.c: Do not include py-ref.h.
10853         * python/py-param.c: Do not include py-ref.h.
10854         * python/py-prettyprint.c: Do not include py-ref.h.
10855         * python/py-progspace.c: Do not include py-ref.h.
10856         * python/py-symbol.c: Do not include py-ref.h.
10857         * python/py-symtab.c: Do not include py-ref.h.
10858         * python/py-type.c: Do not include py-ref.h.
10859         * python/py-unwind.c: Do not include py-ref.h.
10860         * python/py-utils.c: Do not include py-ref.h.
10861         * python/py-value.c: Do not include py-ref.h.
10862         * python/py-varobj.c: Do not include py-ref.h.
10863         * python/py-xmethods.c: Do not include py-ref.h.
10864         * python/python.c: Do not include py-ref.h.
10865         * varobj.c: Do not include py-ref.h.
10866
10867 2019-01-22  Tom Tromey  <tom@tromey.com>
10868
10869         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10870         keyword for bcache.
10871
10872 2019-01-22  Tom Tromey  <tom@tromey.com>
10873
10874         * compile/compile-cplus-types.c: Remove a comment by #include.
10875
10876 2019-01-22  Tom Tromey  <tom@tromey.com>
10877
10878         * compile/gcc-c-plugin.h: Include compile-internal.h.
10879
10880 2019-01-22  Tom Tromey  <tom@tromey.com>
10881
10882         * stabsread.c (EXTERN): Do not define.
10883         (symnum, next_symbol_text_func, processing_gcc_compilation)
10884         (within_function, global_sym_chain, global_stabs)
10885         (previous_stab_code, this_object_header_files)
10886         (n_this_object_header_files)
10887         (n_allocated_this_object_header_files): Define.
10888         * stabsread.h (EXTERN): Never define.  Use "extern".
10889
10890 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10891
10892         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10893         history_value.
10894
10895 2019-01-21  Tom Tromey  <tom@tromey.com>
10896
10897         * ui-out.c: Fix includes.
10898         * tui/tui-source.c: Fix includes.
10899         * target.c: Fix includes.
10900         * remote.c: Fix includes.
10901         * regcache.c: Fix includes.
10902         * python/py-block.c: Fix includes.
10903         * printcmd.c: Fix includes.
10904         * or1k-tdep.c: Fix includes.
10905         * mi/mi-main.c: Fix includes.
10906         * m32r-tdep.c: Fix includes.
10907         * csky-tdep.c: Fix includes.
10908         * compile/compile-cplus-types.c: Fix includes.
10909         * cli/cli-interp.c: Fix includes.
10910
10911 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10912
10913         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10914         for padding.
10915
10916 2019-01-16  Tom Tromey  <tom@tromey.com>
10917
10918         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10919         earlier.
10920         (struct objfile) <msymbols_range>: Move from top level.
10921         <msymbols>: New method.
10922         (class objfile_msymbols): Remove.
10923         * symtab.c (default_collect_symbol_completion_matches_break_on):
10924         Update.
10925         * symmisc.c (dump_msymbols): Update.
10926         * stabsread.c (scan_file_globals): Update.
10927         * objc-lang.c (info_selectors_command, info_classes_command)
10928         (find_methods): Update.
10929         * minsyms.c (find_solib_trampoline_target): Update.
10930         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10931         * coffread.c (coff_symfile_read): Update.
10932         * ada-lang.c (ada_lookup_simple_minsym)
10933         (ada_collect_symbol_completion_matches): Update.
10934
10935 2019-01-16  Tom Tromey  <tom@tromey.com>
10936
10937         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10938         type.  Remove no-argument constructor.
10939         <iterator::operator++>: Simplify.
10940         <begin>: Update.
10941         <end>: Use minimal_symbol_count.
10942
10943 2019-01-16  Tom Tromey  <tom@tromey.com>
10944
10945         * objfiles.h (struct objfile) <psymtabs>: New method.
10946         (class objfile_psymtabs): Remove.
10947         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10948         typedef.
10949         <range>: New method.
10950         (require_partial_symbols): Change return type.
10951         * psymtab.c (require_partial_symbols)
10952         (psym_expand_symtabs_matching): Update.
10953         * mdebugread.c (parse_partial_symbols): Update.
10954         * dbxread.c (dbx_end_psymtab): Update.
10955
10956 2019-01-15  Tom Tromey  <tom@tromey.com>
10957
10958         * symtab.c (lookup_objfile_from_block)
10959         (lookup_symbol_in_objfile_symtabs)
10960         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10961         (find_line_symtab, info_sources_command)
10962         (default_collect_symbol_completion_matches_break_on)
10963         (make_source_files_completion_list): Update.
10964         * symmisc.c (print_objfile_statistics, dump_objfile)
10965         (maintenance_print_symbols, maintenance_info_symtabs)
10966         (maintenance_check_symtabs, maintenance_info_line_tables):
10967         Update.
10968         * source.c (select_source_symtab)
10969         (forget_cached_source_info_for_objfile): Update.
10970         * objfiles.h (class objfile_compunits): Remove.
10971         (struct objfile) <compunits_range>: New typedef.
10972         (compunits): New method.
10973         * objfiles.c (objfile_relocate1): Update.
10974         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10975         * maint.c (count_symtabs_and_blocks): Update.
10976         * linespec.c (iterate_over_all_matching_symtabs): Update.
10977         * cp-support.c (add_symbol_overload_list_qualified): Update.
10978         * coffread.c (coff_symtab_read): Update.
10979         * ada-lang.c (add_nonlocal_symbols)
10980         (ada_collect_symbol_completion_matches)
10981         (ada_add_global_exceptions): Update.
10982
10983 2019-01-15  Tom Tromey  <tom@tromey.com>
10984
10985         * progspace.h (program_space) <objfiles_safe_range>: New
10986         typedef.
10987         <objfiles_safe>: New method.
10988         * objfiles.h (class all_objfiles_safe): Remove.
10989         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10990         * jit.c (jit_inferior_exit_hook): Update.
10991
10992 2019-01-17  Tom Tromey  <tom@tromey.com>
10993
10994         * progspace.h (program_space) <objfiles_range>: New typedef.
10995         <objfiles>: New method.
10996         <objfiles_head>: Rename from objfiles.
10997         (object_files): Update.
10998         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10999         * guile/scm-pretty-print.c
11000         (ppscm_find_pretty_printer_from_objfiles): Update.
11001         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11002         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11003         Update.
11004         * python/py-progspace.c (pspy_get_objfiles): Update.
11005         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11006         Update.
11007         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11008         (objfpy_lookup_objfile_by_build_id): Update.
11009         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11010         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11011         Update.
11012         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11013         (expand_symtab_containing_pc, lookup_objfile_from_block)
11014         (lookup_static_symbol, basic_lookup_transparent_type)
11015         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11016         (find_line_symtab, info_sources_command)
11017         (default_collect_symbol_completion_matches_break_on)
11018         (make_source_files_completion_list, find_main_name): Update.
11019         * symmisc.c (print_symbol_bcache_statistics)
11020         (print_objfile_statistics, maintenance_print_symbols)
11021         (maintenance_print_msymbols, maintenance_print_objfiles)
11022         (maintenance_info_symtabs, maintenance_check_symtabs)
11023         (maintenance_expand_symtabs, maintenance_info_line_tables):
11024         Update.
11025         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11026         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11027         (map_overlay_command, unmap_overlay_command)
11028         (simple_overlay_update, expand_symtabs_matching)
11029         (map_symbol_filenames): Update.
11030         * symfile-debug.c (set_debug_symfile): Update.
11031         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11032         Update.
11033         * source.c (select_source_symtab, forget_cached_source_info):
11034         Update.
11035         * solib.c (solib_read_symbols): Update.
11036         * solib-spu.c (append_ocl_sos): Update.
11037         * psymtab.c (maintenance_print_psymbols)
11038         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11039         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11040         * printcmd.c (info_symbol_command): Update.
11041         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11042         Update.
11043         * objfiles.h (class all_objfiles): Remove.
11044         * objfiles.c (have_partial_symbols, have_full_symbols)
11045         (have_minimal_symbols, qsort_cmp, update_section_map)
11046         (shared_objfile_contains_address_p)
11047         (default_iterate_over_objfiles_in_search_order): Update.
11048         * objc-lang.c (info_selectors_command, info_classes_command)
11049         (find_methods): Update.
11050         * minsyms.c (find_solib_trampoline_target): Update.
11051         * maint.c (maintenance_info_sections)
11052         (maintenance_translate_address, count_symtabs_and_blocks):
11053         Update.
11054         * main.c (captured_main_1): Update.
11055         * linux-thread-db.c (try_thread_db_load_from_pdir)
11056         (has_libpthread): Update.
11057         * linespec.c (iterate_over_all_matching_symtabs)
11058         (search_minsyms_for_name): Update.
11059         * jit.c (jit_find_objf_with_entry_addr): Update.
11060         * hppa-tdep.c (find_unwind_entry)
11061         (hppa_lookup_stub_minimal_symbol): Update.
11062         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11063         Update.
11064         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11065         (elf_gnu_ifunc_resolve_by_got): Update.
11066         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11067         * dwarf-index-write.c (save_gdb_index_command): Update.
11068         * cp-support.c (add_symbol_overload_list_qualified): Update.
11069         * breakpoint.c (create_overlay_event_breakpoint)
11070         (create_longjmp_master_breakpoint)
11071         (create_std_terminate_master_breakpoint)
11072         (create_exception_master_breakpoint): Update.
11073         * blockframe.c (find_pc_partial_function): Update.
11074         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11075         (ada_collect_symbol_completion_matches)
11076         (ada_add_global_exceptions): Update.
11077
11078 2019-01-17  Tom Tromey  <tom@tromey.com>
11079
11080         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11081         declare VEC.
11082         (solib_target_parse_libraries): Change return type.
11083         (library_list_start_segment, library_list_start_section)
11084         (library_list_end_library, library_list_start_library); Update.
11085         (solib_target_free_library_list): Remove.
11086         (solib_target_parse_libraries): Remove cleanup.  Change return
11087         type.
11088         (solib_target_current_sos): Update.
11089
11090 2019-01-17  Tom Tromey  <tromey@bapiya>
11091
11092         * valprint.c: Replace "the the" with "the".
11093         * symtab.c: Replace "the the" with "the".
11094         * solib.c: Replace "the the" with "the".
11095         * solib-dsbt.c: Replace "the the" with "the".
11096         * linespec.c: Replace "the the" with "the".
11097         * dwarf2loc.h: Replace "the the" with "the".
11098         * amd64-windows-tdep.c: Replace "the the" with "the".
11099         * aarch64-tdep.c: Replace "the the" with "the".
11100
11101 2019-01-16  Keith Seitz  <keiths@redhat.com>
11102
11103         PR gdb/23773
11104         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11105         <builder>: Rename to ..
11106         <m_builder>: ... this and make private.
11107         (dwarf2_cu::get_builder): New method.  Change all users of
11108         `builder' to use this method.
11109         (dwarf2_start_symtab): Move to ...
11110         (dwarf2_cu::start_symtab): ... here.  Update all callers
11111         (setup_type_unit_groups): Move to ...
11112         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11113         callers.
11114         (dwarf2_cu::reset_builder): New method.
11115         (process_full_compunit, process_full_type_unit): Use
11116         dwarf2_cu::reset_builder.
11117         (follow_die_offset): Record the ancestor CU if it is different
11118         from the followed DIE's CU.
11119         (follow_die_sig_1): Likewise.
11120
11121 2019-01-15  Tom Tromey  <tom@tromey.com>
11122
11123         * remote.c (class remote_state) <buf>: Now a char_vector.
11124         <buf_size>: Remove.
11125         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11126         parameter.
11127         (remote_target::getpkt_or_notif_sane_1)
11128         (remote_target::getpkt_sane)
11129         (remote_target::getpkt_or_notif_sane): Likewise.
11130         (class remote_target) <putpkt>: New overload.
11131         (remote_target::read_frame): Change type of "buf_p".  Remove
11132         sizeof_p parameter.
11133         (packet_ok): New overload.
11134         (packet_check_result): New overload.
11135         Update all uses.
11136
11137 2019-01-14  Tom Tromey  <tom@tromey.com>
11138
11139         * remote-notif.c (handle_notification, remote_notif_ack)
11140         (remote_notif_parse): Make "buf" const.
11141         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11142         const.
11143         (remote_notif_parse, remote_notif_ack, handle_notification):
11144         Likewise.
11145         * remote.c (remote_notif_stop_parse): Make "buf" const.
11146         (remote_target::remote_parse_stop_reply): Make "buf" const.
11147         (remote_notif_stop_ack): Make "buf" const.
11148
11149 2019-01-14  Tom Tromey  <tom@tromey.com>
11150
11151         * remote.c (remote_console_output): Make parameter const.
11152
11153 2019-01-14  Tom Tromey  <tom@tromey.com>
11154
11155         * target-debug.h (target_debug_print_signals): Constify.
11156         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11157         * procfs.c (procfs_target::pass_signals): Update.
11158         * linux-nat.c (linux_nat_target::pass_signals): Update.
11159         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11160         * target-delegates.c: Rebuild.
11161         * remote.c (remote_target::program_signals): Update.
11162         (remote_target::pass_signals): Update.
11163         * target.c (target_pass_signals): Constify argument.
11164         (target_program_signals): Likewise.
11165         * target.h (struct target_ops) <pass_signals, program_signals>:
11166         Constify argument.
11167         (target_pass_signals, target_program_signals): Constify argument.
11168
11169 2019-01-14  Tom Tromey  <tom@tromey.com>
11170
11171         PR tui/28819:
11172         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11173
11174 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11175
11176         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11177         field.
11178         * rs6000-tdep.c: Include reggroups.h.
11179         (IS_V_ALIAS_PSEUDOREG): Define.
11180         (rs6000_register_name): Return names for the "vX" aliases.
11181         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11182         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11183         aliases.  Call default_register_reggroup_p for all other
11184         pseudo-registers.
11185         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11186         New functions.
11187         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11188         Handle "vX" aliases.
11189         (v_alias_pseudo_register_collect): New function.
11190         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11191         (rs6000_gdbarch_init): Initialize "vX" aliases as
11192         pseudo-registers.  Restore registration of
11193         rs6000_pseudo_register_reggroup_p with
11194         set_tdesc_pseudo_register_reggroup_p.
11195
11196 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11197
11198         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11199         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11200         set_gdbarch_num_pseudo_regs.
11201
11202 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11203
11204         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11205         Remove arg prefixname, add do_set and do_show.
11206         Add member functions set_list and show_list.
11207         * cli/cli-style.c (class cli_style_option): Update accordingly.
11208         (style_set_list): Move to file scope.
11209         (style_show_list): Likewise.
11210         (set_style): Call help_list.
11211         (show_style): Call cmd_show_list.
11212         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11213         Update to use the new macro.
11214
11215 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11216
11217         * ada-lang.c (_initialize_ada_language): Expand the help text
11218         for the "catch exception" command.
11219
11220 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11221
11222         * symtab.c (matching_obj_sections): Initialize obj,
11223         declare it closer to its usage.
11224
11225 2019-01-10  Tom Tromey  <tom@tromey.com>
11226
11227         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11228         (basic_inf_threads_range): Remove.
11229         (inf_threads_range, inf_non_exited_threads_range)
11230         (safe_inf_threads_range): Use next_adapter.
11231
11232 2019-01-10  Keith Seitz  <keiths@redhat.com>
11233
11234         PR gdb/23712
11235         PR symtab/23010
11236         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11237         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11238
11239 2019-01-10  Keith Seitz  <keiths@redhat.com>
11240
11241         PR gdb/23712
11242         PR symtab/23010
11243         * dictionary.c (pending_to_vector): Remove.
11244         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11245         Remove _1 suffix, replacing functions of the same name.  Update
11246         all callers.
11247         (dict_create_hashed, dict_create_hashed_expandable)
11248         (dict_create_linear, dict_create_linear_expandable, dict_free)
11249         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11250         Make functions static.
11251
11252 2019-01-10  Keith Seitz  <keiths@redhat.com>
11253
11254         PR gdb/23712
11255         PR symtab/23010
11256         * dictionary.h (struct dictionary): Replace declaration with
11257         multidictionary.
11258         (dict_create_hashed, dict_create_hashed_expandable)
11259         (dict_create_linear, dict_create_linear_expandable)
11260         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11261         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11262         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11263         taking multidictionary argument.
11264         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11265         * block.h (struct block) <dict>: Change to multidictionary
11266         and rename `multidict'.
11267         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11268         symmisc.c: Update all dictionary references to multidictionary.
11269
11270 2019-01-10  Keith Seitz  <keiths@redhat.com>
11271
11272         PR gdb/23712
11273         PR symtab/23010
11274         * dictionary.c: Include unordered_map.
11275         (pending_to_vector): New function.
11276         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11277         Rewrite the non-"_1" functions to take vector instead
11278         of linked list.
11279         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11280         "new" _1 versions of the same name.
11281         (multidictionary): Define.
11282         (std::hash<enum language): New definition.
11283         (collate_pending_symbols_by_language, mdict_create_hashed)
11284         (mdict_create_hashed_expandable, mdict_create_linear)
11285         (mdict_create_linear_expandable, mdict_free)
11286         (find_language_dictionary, create_new_language_dictionary)
11287         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11288         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11289         (mdict_size, mdict_empty): New functions.
11290         * dictionary.h (mdict_iterator): Define.
11291
11292 2019-01-10  Pedro Alves  <palves@redhat.com>
11293
11294         * breakpoint.c (read_uploaded_action)
11295         (create_tracepoint_from_upload): Adjust to use
11296         gdb::unique_xmalloc_ptr.
11297         * ctf.c (ctf_write_uploaded_tp):
11298         (SET_ARRAY_FIELD): Use emplace_back.
11299         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11300         * tracefile-tfile.c (tfile_write_uploaded_tp):
11301         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11302         gdb::unique_xmalloc_ptr.
11303         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11304         at_string, cond_string, cmd_strings>: Replace char pointers
11305         with gdb::unique_xmalloc_ptr.
11306
11307 2019-01-10  Pedro Alves  <palves@redhat.com>
11308
11309         * solib-target.c (library_list_start_library): Don't xstrdup name.
11310
11311 2019-01-10  Pedro Alves  <palves@redhat.com>
11312
11313         * mdebugread.c (parse_partial_symbols): Use
11314         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11315
11316 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11317
11318         * linux-fork.c (scoped_switch_fork_info)
11319         <~scoped_switch_fork_info>: Fix incorrect variable name.
11320
11321 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11322
11323         * linux-fork.c (scoped_switch_fork_info)
11324         <scoped_switch_fork_info>: Make explicit.
11325         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11326
11327 2019-01-10  Tom Tromey  <tom@tromey.com>
11328
11329         * objfiles.h (objfile::reset_psymtabs): Update.
11330         * objfiles.c (objfile::objfile): Update.
11331         * psymtab.h (psymtab_storage::obstack): Update.
11332         (psymtab_storage::m_obstack): Use gdb::optional.
11333         (class psymtab_storage): Update comment.  Remove objfile
11334         parameter.
11335         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11336
11337 2019-01-10  Tom Tromey  <tom@tromey.com>
11338
11339         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11340         <free_psymtabs>: Now private.
11341         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11342         (allocate_psymtab): Use new method.
11343
11344 2019-01-10  Tom Tromey  <tom@tromey.com>
11345
11346         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11347         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11348         * mdebugread.c (parse_partial_symbols): Use
11349         allocate_dependencies.
11350         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11351         allocate_dependencies.
11352         (process_psymtab_comp_unit_reader)
11353         (build_type_psymtab_dependencies): Likewise.
11354         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11355
11356 2019-01-10  Tom Tromey  <tom@tromey.com>
11357
11358         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11359         PSYMBOL_SET_LANGUAGE.
11360         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11361
11362 2019-01-10  Tom Tromey  <tom@tromey.com>
11363
11364         * psymtab.h (psymtab_storage::obstack): New method.
11365         <m_obstack>: Rename from obstack; now private.
11366         * psymtab.c (psymtab_storage): Update.
11367         * dwarf2read.c (create_addrmap_from_index)
11368         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11369         Update.
11370
11371 2019-01-10  Tom Tromey  <tom@tromey.com>
11372
11373         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11374         * objfiles.h (objfile::reset_psymtabs): New method.
11375
11376 2019-01-10  Tom Tromey  <tom@tromey.com>
11377
11378         * symmisc.c (print_symbol_bcache_statistics): Update.
11379         (print_objfile_statistics): Update.
11380         * symfile.c (reread_symbols): Update.
11381         * psymtab.h (class psymtab_storage): New.
11382         * psymtab.c (psymtab_storage): New constructor.
11383         (~psymtab_storage): New destructor.
11384         (require_partial_symbols): Update.
11385         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11386         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11387         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11388         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11389         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11390         (start_psymtab_common, end_psymtab_common)
11391         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11392         (allocate_psymtab): Update.
11393         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11394         Update.
11395         (dump_psymtab_addrmap, maintenance_print_psymbols)
11396         (maintenance_check_psymtabs): Update.
11397         (class objfile_psymtabs): Move to objfiles.h.
11398         * psympriv.h (discard_psymtab): Now inline.
11399         (psymtab_discarder::psymtab_discarder): Update.
11400         (psymtab_discarder::~psymtab_discarder): Update.
11401         (ALL_OBJFILE_PSYMTABS): Rewrite.
11402         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11403         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11404         Remove fields.
11405         <partial_symtabs>: New field.
11406         (class objfile_psymtabs): Move from psymtab.h.  Update.
11407         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11408         psymbol_cache.
11409         (objfile::~objfile): Don't destroy psymbol_cache.
11410         * mdebugread.c (parse_partial_symbols): Update.
11411         * dwarf2read.c (create_addrmap_from_index)
11412         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11413         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11414         (add_partial_subprogram, dwarf2_ranges_read): Update.
11415         * dwarf-index-write.c (write_address_map)
11416         (write_one_signatured_type, recursively_write_psymbols)
11417         (class debug_names, class debug_names, write_psymtabs_to_index):
11418         Update.
11419
11420 2019-01-10  Tom Tromey  <tom@tromey.com>
11421
11422         * symtab.h (SYMBOL_SET_NAMES): Update.
11423         (symbol_set_names): Update.
11424         (MSYMBOL_SET_NAMES): Update.
11425         * symtab.c (symbol_set_names): Change argument to be an
11426         objfile_per_bfd_storage.
11427         * psymtab.c (add_psymbol_to_bcache): Update.
11428         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11429
11430 2019-01-10  Tom Tromey  <tom@tromey.com>
11431
11432         * symtab.c (create_demangled_names_hash): Change argument to be an
11433         objfile_per_bfd_storage.
11434         (symbol_set_names): Update.
11435
11436 2019-01-10  Tom Tromey  <tom@tromey.com>
11437
11438         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11439         init_psymbol_list.
11440         * psymtab.c (init_psymbol_list): Do nothing if already called.
11441         * psympriv.h (init_psymbol_list): Add comment.
11442         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11443         init_psymbol_list.
11444         * dbxread.c (dbx_symfile_read): Unconditionally call
11445         init_psymbol_list.
11446
11447 2019-01-10  Tom Tromey  <tom@tromey.com>
11448
11449         * xcoffread.c (scan_xcoff_symtab): Update.
11450         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11451         "where".
11452         * mdebugread.c (parse_partial_symbols)
11453         (handle_psymbol_enumerators): Update.
11454         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11455         * dbxread.c (read_dbx_symtab): Update.
11456         * psympriv.h (psymbol_placement): New enum.
11457         (add_psymbol_to_list): Update.
11458
11459 2019-01-10  Tom Tromey  <tom@tromey.com>
11460
11461         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11462         static_psymbols parameters.
11463         (scan_xcoff_symtab): Update.
11464         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11465         static_psymbols parameters.
11466         * psympriv.h (start_psymtab_common): Update.
11467         * mdebugread.c (parse_partial_symbols): Update.
11468         * dwarf2read.c (create_partial_symtab): Update.
11469         * dbxread.c (read_dbx_symtab): Update.
11470         (start_psymtab): Remove global_psymbols and static_psymbols
11471         parameters.
11472
11473 2019-01-10  Tom Tromey  <tom@tromey.com>
11474
11475         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11476         * psymtab.c (allocate_psymtab): Add comment.
11477         * psympriv.h (allocate_psymtab): Add comment.
11478         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11479         initializations.
11480         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11481
11482 2019-01-10  Tom Tromey  <tom@tromey.com>
11483
11484         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11485         Don't declare.
11486         * mipsread.c: Include mdebugread.h.
11487         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11488         Declare.
11489         * elfread.c: Include mdebugread.h.
11490
11491 2019-01-09  Tom Tromey  <tom@tromey.com>
11492
11493         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11494         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11495         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11496         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11497         (psym_lookup_symbol, psym_find_last_source_symtab)
11498         (psym_forget_cached_source_info, psym_print_stats)
11499         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11500         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11501         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11502         (psym_find_compunit_symtab_by_address)
11503         (maintenance_print_psymbols, maintenance_info_psymtabs)
11504         (maintenance_check_psymtabs): Use ranged for.
11505         * psymtab.h (class objfile_psymtabs): New.
11506         (require_partial_symbols): Return objfile_psymtabs.
11507         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11508
11509 2019-01-09  Tom Tromey  <tom@tromey.com>
11510
11511         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11512         (find_pc_mapped_section, list_overlays_command)
11513         (map_overlay_command, unmap_overlay_command)
11514         (simple_overlay_update): Use all_objfiles.
11515         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11516         * printcmd.c (info_symbol_command): Use all_objfiles.
11517         * objfiles.h (ALL_OBJSECTIONS): Remove.
11518         * maint.c (maintenance_translate_address): Use all_objfiles.
11519         * gcore.c (gcore_create_callback): Use all_objfiles.
11520         (objfile_find_memory_regions): Likewise.
11521
11522 2019-01-09  Tom Tromey  <tom@tromey.com>
11523
11524         * symtab.c (find_line_symtab, info_sources_command)
11525         (make_source_files_completion_list): Use objfile_compunits.
11526         * source.c (select_source_symtab): Use objfile_compunits.
11527         * objfiles.h (struct objfile): Update comment.
11528         (ALL_OBJFILES): Remove.
11529         (ALL_FILETABS): Remove.
11530         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11531         objfile_compunits.
11532
11533 2019-01-09  Tom Tromey  <tom@tromey.com>
11534
11535         * symmisc.c (print_objfile_statistics, dump_objfile)
11536         (maintenance_print_symbols): Use compunit_filetabs.
11537         * source.c (forget_cached_source_info_for_objfile): Use
11538         compunit_filetabs.
11539         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11540         (ALL_FILETABS): Use compunit_filetabs.
11541         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11542         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11543
11544 2019-01-09  Tom Tromey  <tom@tromey.com>
11545
11546         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11547         (compunit_filetabs): New.
11548         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11549         compunit_filetabs.
11550         (info_sources_command, make_source_files_completion_list): Remove
11551         declaration.
11552         * symmisc.c (print_objfile_statistics, dump_objfile)
11553         (maintenance_print_symbols): Remove declaration.
11554         (maintenance_info_symtabs): Use compunit_filetabs.
11555         (maintenance_info_line_tables): Likewise.
11556         * source.c (select_source_symtab): Change local variable name.
11557         (forget_cached_source_info_for_objfile): Remove declaration.
11558         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11559         * objfiles.c (objfile_relocate1): Remove declaration.
11560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11561         declaration.
11562         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11563         * coffread.c (coff_symtab_read): Remove declaration.
11564         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11565         compunit_filetabs.
11566
11567 2019-01-09  Tom Tromey  <tom@tromey.com>
11568
11569         * symtab.c (lookup_objfile_from_block)
11570         (find_pc_sect_compunit_symtab, search_symbols)
11571         (default_collect_symbol_completion_matches_break_on): Use
11572         objfile_compunits.
11573         * objfiles.h (ALL_COMPUNITS): Remove.
11574         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11575         * cp-support.c (add_symbol_overload_list_qualified): Use
11576         objfile_compunits.
11577         * ada-lang.c (ada_collect_symbol_completion_matches)
11578         (ada_add_global_exceptions): Use objfile_compunits.
11579
11580 2019-01-09  Tom Tromey  <tom@tromey.com>
11581
11582         * source.c (select_source_symtab)
11583         (forget_cached_source_info_for_objfile): Remove declaration.
11584         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11585         declaration.
11586         * maint.c (count_symtabs_and_blocks): Remove declaration.
11587         * cp-support.c (add_symbol_overload_list_qualified): Remove
11588         declaration.
11589         * coffread.c (coff_symtab_read): Remove declaration.
11590         * symtab.c (lookup_symbol_in_objfile_symtabs)
11591         (basic_lookup_transparent_type_1): Use objfile_compunits.
11592         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11593         (info_sources_command, search_symbols)
11594         (default_collect_symbol_completion_matches_break_on)
11595         (make_source_files_completion_list): Remove declaration.
11596         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11597         (ada_collect_symbol_completion_matches)
11598         (ada_add_global_exceptions): Remove declaration.
11599         * linespec.c (iterate_over_all_matching_symtabs): Use
11600         objfile_compunits.
11601         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11602         (class objfile_compunits): New.
11603         (ALL_COMPUNITS): Use objfile_compunits.
11604         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11605         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11606         objfile_compunits.
11607         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11608
11609 2019-01-09  Tom Tromey  <tom@tromey.com>
11610
11611         * symtab.c (search_symbols)
11612         (default_collect_symbol_completion_matches_break_on): Use
11613         objfile_msymbols.
11614         * ada-lang.c (ada_lookup_simple_minsym)
11615         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11616         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11617         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11618         objfile_msymbols.
11619         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11620         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11621         * objc-lang.c (find_methods): Use objfile_msymbols.
11622         (info_selectors_command, info_classes_command): Likewise.
11623         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11624         * objfiles.h (class objfile_msymbols): New.
11625         (ALL_OBJFILE_MSYMBOLS): Remove.
11626         (ALL_MSYMBOLS): Remove.
11627
11628 2019-01-09  Tom Tromey  <tom@tromey.com>
11629
11630         * common/next-iterator.h (next_adapter): Add Iterator template
11631         parameter.
11632         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11633         (class all_objfiles_safe): New.
11634         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11635         * objfiles.c (put_objfile_before): Update comment.
11636         (add_separate_debug_objfile): Likewise.
11637         (free_all_objfiles): Use all_objfiles_safe.
11638         (objfile_purge_solibs): Likewise.
11639
11640 2019-01-09  Tom Tromey  <tom@tromey.com>
11641
11642         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11643         (expand_symtab_containing_pc, lookup_static_symbol)
11644         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11645         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11646         all_objfiles.
11647         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11648         * breakpoint.c (create_overlay_event_breakpoint)
11649         (create_longjmp_master_breakpoint)
11650         (create_std_terminate_master_breakpoint)
11651         (create_exception_master_breakpoint): Use all_objfiles.
11652         * linux-thread-db.c (try_thread_db_load_from_pdir)
11653         (has_libpthread): Use all_objfiles.
11654         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11655         * linespec.c (iterate_over_all_matching_symtabs)
11656         (search_minsyms_for_name): Use all_objfiles.
11657         * maint.c (maintenance_info_sections): Use all_objfiles.
11658         * main.c (captured_main_1): Use all_objfiles.
11659         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11660         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11661         * guile/scm-pretty-print.c
11662         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11663         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11664         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11665         (maintenance_print_msymbols): Use all_objfiles.
11666         * source.c (select_source_symtab): Use all_objfiles.
11667         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11668         * symfile.c (remove_symbol_file_command)
11669         (expand_symtabs_matching, map_symbol_filenames): Use
11670         all_objfiles.
11671         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11672         all_objfiles.
11673         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11674         * objc-lang.c (find_methods): Use all_objfiles.
11675         * objfiles.c (have_partial_symbols, have_full_symbols)
11676         (have_minimal_symbols, qsort_cmp)
11677         (default_iterate_over_objfiles_in_search_order): Use
11678         all_objfiles.
11679         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11680         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11681         (maintenance_check_psymtabs): Use all_objfiles.
11682         (ALL_PSYMTABS): Remove.
11683         * compile/compile-object-run.c (do_module_cleanup): Use
11684         all_objfiles.
11685         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11686         * cp-support.c (add_symbol_overload_list_qualified): Use
11687         all_objfiles.
11688         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11689         Use all_objfiles.
11690         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11691         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11692         all_objfiles.
11693         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11694         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11695         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11696         Uses all_objfiles.
11697         * solib.c (solib_read_symbols): Use all_objfiles
11698
11699 2019-01-09  Tom Tromey  <tom@tromey.com>
11700
11701         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11702         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11703         all_objfiles.
11704         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11705         * symmisc.c (print_symbol_bcache_statistics)
11706         (print_objfile_statistics, maintenance_print_objfiles)
11707         (maintenance_info_symtabs, maintenance_check_symtabs)
11708         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11709         all_objfiles.
11710         * source.c (forget_cached_source_info): Use all_objfiles.
11711         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11712         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11713         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11714         * objfiles.c (update_section_map): Use all_objfiles.
11715         (shared_objfile_contains_address_p): Likewise.
11716         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11717         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11718
11719 2019-01-09  Tom Tromey  <tom@tromey.com>
11720
11721         * common/next-iterator.h: New file.
11722         * objfiles.h (class all_objfiles): New.
11723         (struct objfile_iterator): New.
11724
11725 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11726
11727         * NEWS: Move the description of the changed "frame", "select-frame",
11728          and "info frame" commands to the Changed commands section.
11729
11730 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11731
11732         * gdbtypes.c (check_stub_method_group): Remove handling of old
11733         mangling schemes.
11734         * linespec.c (find_methods): Likewise.
11735         * stabsread.c (read_member_functions): Likewise.
11736         * valops.c (search_struct_method): Likewise.
11737         (value_struct_elt_for_reference): Likewise.
11738         * NEWS: Mention this change.
11739
11740 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11741
11742         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11743         print_source_lines.
11744         * source.c (print_source_lines_base): Update line number check.
11745         (print_source_lines): New function.
11746         (source_lines_range::source_lines_range): New function.
11747         * source.h (class source_lines_range): New class.
11748         (print_source_lines): New declaration.
11749
11750 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11751
11752         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11753
11754 2019-01-08  Tom Tromey  <tom@tromey.com>
11755             Simon Marchi  <simon.marchi@ericsson.com>
11756
11757         PR gdb/24060
11758         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11759         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11760         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11761         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11762         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11763         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11764
11765 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11766
11767         * source.c (select_source_symtab): Move header comment to
11768         declaration in source.h.
11769         (forget_cached_source_info_for_objfile): Likewise.
11770         (forget_cached_source_info): Likewise.
11771         (identify_source_line): Likewise.
11772         * source.h (identify_source_line): Move declaration from symtab.h
11773         and add comment from source.c
11774         (print_source_lines): Likewise.
11775         (forget_cached_source_info_for_objfile): Likewise.
11776         (forget_cached_source_info): Likewise.
11777         (select_source_symtab): Likewise.
11778         (enum print_source_lines_flag): Move definition from symtab.h.
11779         * symtab.h (identify_source_line): Move declaration to source.h.
11780         (print_source_lines): Likewise.
11781         (forget_cached_source_info_for_objfile): Likewise.
11782         (forget_cached_source_info): Likewise.
11783         (select_source_symtab): Likewise.
11784         (enum print_source_lines_flag): Move definition to source.h.
11785         * tui/tui-hooks.c: Add 'source.h' include.
11786
11787 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11788
11789         * source.c (print_source_lines_base): Handle requests to print
11790         reverse line number sequences, and guard against empty lines
11791         string.
11792
11793 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11794
11795         * source.c (print_source_lines_base): Fix skip of '\r' if next
11796         character is '\n'.
11797
11798 2019-01-06  Tom Tromey  <tom@tromey.com>
11799
11800         * c-exp.y (struct c_parse_state) <macro_original_text,
11801         expansion_obstack>: New member.
11802         (macro_original_text, expansion_obstack): Remove globals.
11803         (scan_macro_expansion, scanning_macro_expansion)
11804         (finished_macro_expansion): Update.
11805         (scan_macro_cleanup): Remove.
11806         (yylex, c_parse): Update.
11807
11808 2019-01-06  Tom Tromey  <tom@tromey.com>
11809
11810         * c-exp.y (struct c_parse_state) <strings>: New member.
11811         (operator_stoken): Update.
11812
11813 2019-01-06  Tom Tromey  <tom@tromey.com>
11814
11815         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11816         (union type_stack_elt) <typelist_val>: Now a pointer to
11817         std::vector.
11818         (type_stack_cleanup): Don't declare.
11819         (push_typelist): Update.
11820         * parse.c (pop_typelist): Return a std::vector.
11821         (push_typelist): Take a std::vector.
11822         (follow_types): Update.  Do not free args.
11823         (type_stack_cleanup): Remove.
11824         * c-exp.y (struct c_parse_state): New.
11825         (cpstate): New global.
11826         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11827         (nonempty_typelist): Update.
11828         (func_mod): Create a new vector.
11829         (c_parse): Create a c_parse_state.
11830         (check_parameter_typelist): Do not delete params.
11831         (function_method): Update.  Do not delete type_list.
11832
11833 2019-01-06  Tom Tromey  <tom@tromey.com>
11834
11835         PR gdb/28155:
11836         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11837         check_typedef.
11838         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11839         (print_return_value): Likewise.
11840
11841 2019-01-05  Tom Tromey  <tom@tromey.com>
11842
11843         * contrib/cleanup_check.py: Remove.
11844         * contrib/gcc-with-excheck: Remove.
11845         * contrib/exsummary.py: Remove.
11846         * contrib/excheck.py: Remove.
11847
11848 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11849
11850         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11851         NULL. Initialize tpprev to NULL instead of assigning it
11852         to NULL on the next statement.
11853         * windows-nat.c (windows_delete_thread): Remove check for
11854         main_thread_id before printing thread exit notifications.
11855         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11856         Remove thread ID check against main_thread_id.
11857         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11858         windows_delete_thread.
11859         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11860
11861 2019-01-04  Tom Tromey  <tom@tromey.com>
11862
11863         * compile/compile.c (_initialize_compile): Use upper case for
11864         metasyntactic variables.
11865         * symmisc.c (_initialize_symmisc): Use upper case for
11866         metasyntactic variables.
11867         * psymtab.c (_initialize_psymtab): Use upper case for
11868         metasyntactic variables.
11869         * demangle.c (demangle_command): Use upper case for metasyntactic
11870         variables.
11871         (_initialize_demangler): Likewise.
11872         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11873         variables.
11874
11875 2019-01-03  Tom Tromey  <tom@tromey.com>
11876
11877         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11878
11879 2019-01-03  Tom Tromey  <tom@tromey.com>
11880
11881         * python/py-symtab.c (salpy_str): Update.
11882         (struct salpy_sal_object) <symtab>: Now a PyObject.
11883         (salpy_dealloc): Update.
11884         (del_objfile_sal): Use gdbpy_ref.
11885
11886 2019-01-03  Tom Tromey  <tom@tromey.com>
11887
11888         * python/py-type.c (convert_field): Use new_reference.  Return
11889         gdbpy_ref.
11890         (make_fielditem): Return gdbpy_ref.
11891         (typy_fields): Update.
11892         (typy_getitem): Update.
11893         (field_name): Return gdbpy_ref.  Use new_reference.
11894         (typy_iterator_iternext): Update.
11895
11896 2019-01-03  Tom Tromey  <tom@tromey.com>
11897
11898         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11899
11900 2019-01-03  Tom Tromey  <tom@tromey.com>
11901
11902         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11903         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11904         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11905         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11906         (pspy_set_type_printers): Likewise.
11907         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11908         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11909         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11910         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11911         (objfpy_set_type_printers): Likewise.
11912
11913 2019-01-03  Tom Tromey  <tom@tromey.com>
11914
11915         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11916         (gdbpy_print_stack): Use gdbpy_err_fetch.
11917         * python/python-internal.h (class gdbpy_err_fetch): New class.
11918         (class gdbpy_enter) <m_error_type, m_error_value,
11919         m_error_traceback>: Remove.
11920         <m_error>: New member.
11921         (gdbpy_exception_to_string): Don't declare.
11922         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11923         * python/py-value.c (convert_value_from_python): Use
11924         gdbpy_err_fetch.
11925         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11926         gdbpy_exception_to_string.
11927         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11928         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11929         gdbpy_err_fetch.
11930
11931 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11932
11933         * linux-nat.c (delete_lwp_cleanup): Delete.
11934         (struct lwp_deleter): New struct.
11935         (lwp_info_up): New typedef.
11936         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11937         lwp_info_up.
11938
11939 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11940
11941         * linux-fork.c (class scoped_switch_fork_info): New class.
11942         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11943
11944 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11945
11946         * valops.c (find_overload_match): Remove use of null_cleanup, and
11947         calls to do_cleanups.
11948
11949 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11950
11951         * compile/compile-cplus-types.c
11952         (compile_cplus_instance::decl_name): Handle changes to
11953         cp_func_name.
11954         * cp-support.c (cp_func_name): Update header comment, update
11955         return type.
11956         * cp-support.h (cp_func_name): Update return type in declaration.
11957         * valops.c (find_overload_match): Move temp_func local to top
11958         level of function and change its type.  Use temp_func to hold and
11959         delete temporary string obtained from cp_func_name.
11960
11961 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11962
11963         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11964         gdb::char_vector, remove cleanup, and update uses of `msg`.
11965
11966 2019-01-03  Jim Wilson  <jimw@sifive.com>
11967
11968         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11969
11970 2019-01-02  Tom Tromey  <tom@tromey.com>
11971
11972         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11973         (tdesc_parse_xml): Remove cleanups.
11974         * target-descriptions.h (make_cleanup_free_target_description):
11975         Don't declare.
11976         (target_desc_deleter): New struct.
11977         (target_desc_up): New typedef.
11978         * target-descriptions.c (target_desc_deleter::operator()): Rename
11979         from free_target_description.
11980         (make_cleanup_free_target_description): Remove.
11981
11982 2019-01-02  Tom Tromey  <tom@tromey.com>
11983
11984         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11985         constructor, destructor.
11986         (linespec_parser): Remove typedef.
11987         (~linespec_parser): Rename from linespec_parser_delete.
11988         (linespec_lex_to_end, linespec_complete_label)
11989         (linespec_complete): Update.
11990         (decode_line_full): Remove cleanups.
11991         (decode_line_1): Update.
11992
11993 2019-01-02  Tom Tromey  <tom@tromey.com>
11994
11995         * python/python-internal.h (inferior_to_inferior_object): Change
11996         return type.
11997         * python/py-exitedevent.c (create_exited_event_object): Update.
11998         * python/py-inferior.c (inferior_to_inferior_object): Return
11999         gdbpy_ref.
12000         (python_new_inferior, python_inferior_deleted)
12001         (thread_to_thread_object, delete_thread_object)
12002         (build_inferior_list, gdbpy_selected_inferior): Update.
12003         * python/py-infthread.c (create_thread_object): Update.  Also fail
12004         if inferior_to_inferior_object fails.
12005
12006 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12007
12008         * inferior.h (class inferior) <displaced_step_state>: New field.
12009         * infrun.h (struct displaced_step_state): Move here from
12010         infrun.c.  Initialize fields, add constructor.
12011         <inf>: Remove field.
12012         <reset>: New method.
12013         * infrun.c (struct displaced_step_inferior_state): Move to
12014         infrun.h.
12015         (displaced_step_inferior_states): Remove.
12016         (get_displaced_stepping_state): Adust.
12017         (displaced_step_in_progress_any_inferior): Adjust.
12018         (displaced_step_in_progress_thread): Adjust.
12019         (displaced_step_in_progress): Adjust.
12020         (add_displaced_stepping_state): Remove.
12021         (get_displaced_step_closure_by_addr): Adjust.
12022         (remove_displaced_stepping_state): Remove.
12023         (infrun_inferior_exit): Call displaced_step_state.reset.
12024         (use_displaced_stepping): Don't check for NULL.
12025         (displaced_step_prepare_throw): Call
12026         get_displaced_stepping_state.
12027         (displaced_step_fixup): Don't check for NULL.
12028         (prepare_for_detach): Don't check for NULL.
12029
12030 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12031
12032         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12033          in case of call that did not complete.
12034
12035 2019-01-02  Andrey Utkin  <autkin@undo.io>
12036
12037         * symfile.c (find_separate_debug_file): Fix search of debug files for
12038         remote debuggee.
12039
12040 2019-01-02  Tom Tromey  <tom@tromey.com>
12041
12042         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12043         indentation.
12044         * python/py-frame.c (frapy_older): Remove cast.
12045         (frapy_newer): Likewise.
12046         * python/py-breakpoint.c (local_setattro): Remove cast.
12047         * python/py-arch.c (archpy_name): Remove local variable.
12048         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12049
12050 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12051
12052         * unittests/basic_string_view/element_access/char/empty.cc:
12053         Fix year range in copyright header.
12054
12055 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12056
12057         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12058         Delete.
12059         <operator==>: Update with for removed field.
12060         <hash>: Likewise.
12061         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12062         <isa_features>: ...this.
12063         <abi_features>: New field.
12064         (riscv_isa_flen): Update comment.
12065         (riscv_abi_xlen): New declaration.
12066         (riscv_abi_flen): New declaration.
12067         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12068         isa_features.
12069         (riscv_abi_xlen): New function.
12070         (riscv_isa_flen): Update to get answer from isa_features.
12071         (riscv_abi_flen): New function.
12072         (riscv_has_fp_abi): Update to get answer from abi_features.
12073         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12074         xlen and flen.
12075         (riscv_call_info) <xlen, flen>: Update comment.
12076         (riscv_call_arg_struct): Remove invalid assertions
12077         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12078         is removed.
12079         (riscv_gdbarch_init): Gather isa features and abi features
12080         separately, ensure both match on the gdbarch when reusing an old
12081         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12082         a target with 64-bit float hardware.
12083
12084 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12085
12086         * source.c (search_command_helper): Stop reverse search
12087         when line 1 has been searched.
12088
12089 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12090
12091         * record-full.c (record_full_base_target::close): Rewrite
12092         record_full_core_buf_list free logic.
12093
12094 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12095
12096         * break-catch-syscall.c (print_one_catch_syscall): xfree
12097         the last text.
12098
12099 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12100
12101         * top.c (print_gdb_version): Update Copyright year in version
12102         message.
12103
12104 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12105
12106         Update copyright year range in all GDB files.
12107
12108 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12109
12110         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12111
12112 For older changes see ChangeLog-2018.
12113 \f
12114 Local Variables:
12115 mode: change-log
12116 left-margin: 8
12117 fill-column: 74
12118 version-control: never
12119 coding: utf-8
12120 End:
12121