gdb/ChangeLog

   1 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
   4         code to here...
   5         (svr4_create_solib_event_breakpoints): ...from here.
   6
   7 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
   8
   9         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  10         suffix from warning message.
  11
  12 2019-08-30  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-winsource.h (struct tui_source_window_base)
  15         <refresh_all>: Don't declare.
  16         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  17         Remove.
  18         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  19         tui_show_locator_content.
  20         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  21         declare.
  22         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  23         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  24         declare.
  25
  26 2019-08-30  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
  29
  30 2019-08-30  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-stack.c (_initialize_tui_stack): Move later.
  33         Remove unnecessary forward declarations.
  34
  35 2019-08-30  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
  38         rerender.
  39         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  40         tui_show_locator_content.
  41
  42 2019-08-30  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  45         (tui_locator_window::rerender): Rewrite using body of previous
  46         tui_show_locator_content.
  47
  48 2019-08-30  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  51         set_locator_fullname>: New methods.
  52         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  53         Rename from tui_set_locator_fullname.
  54         (tui_locator_window::set_locator_info): Rename from
  55         tui_set_locator_info.  Return bool.
  56         (tui_update_locator_fullname, tui_show_frame_info): Update.
  57
  58 2019-08-30  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  61
  62 2019-08-30  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  65         call touchwin.
  66
  67 2019-08-30  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-wingeneral.c (box_win): Assume win_info and
  70         win_info->handle cannot be NULL.
  71
  72 2019-08-30  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  75         refresh_window>: Declare.
  76         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  77         resize.
  78         (tui_data_item_window::rerender): Rename from
  79         tui_display_register.
  80         (tui_data_item_window::refresh_window): New method.
  81         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  82         no-op.
  83
  84 2019-08-30  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  87         regs_column_count, current_group>: Move later.  Now private.
  88         <get_current_group>: New method.
  89         * tui/tui-regs.c (tui_reg_command): Update.
  90         * tui/tui-layout.c (tui_set_layout): Update.
  91
  92 2019-08-30  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  95         (tui_data_window::rerender): Don't call
  96         check_and_display_highlight_if_needed.
  97         (tui_data_window::refresh_all): Remove call to
  98         erase_data_content.
  99
 100 2019-08-30  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 103         (tui_data_window::display_registers_from)
 104         (tui_data_window::display_reg_element_at_line)
 105         (tui_data_window::display_registers_from_line): Remove checks of
 106         "empty".
 107
 108 2019-08-30  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 111         Don't declare.
 112         * tui/tui-regs.c (tui_data_window::show_registers): Call
 113         rerender.
 114         (tui_data_window::rerender): Rename from display_all_data.
 115         (tui_data_window::rerender): Remove old implementation.
 116
 117 2019-08-30  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 120         text.
 121         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 122
 123 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 124             Sergio Durigan Junior  <sergiodj@redhat.com>
 125
 126         PR win32/24284
 127         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 128
 129 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 130
 131         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 132         when searching for types.
 133
 134 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 135
 136         * f-lang.c (f_language_defn): Use f_print_typedef.
 137         * f-lang.h (f_print_typedef): Declare.
 138         * f-typeprint.c (f_print_typedef): Define.
 139
 140 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 141
 142         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 143
 144 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * cli/cli-utils.c (info_print_options_defs): Delete.
 147         (make_info_print_options_def_group): Delete.
 148         (extract_info_print_options): Delete.
 149         (info_print_command_completer): Delete.
 150         (info_print_args_help): Add extra parameter, and optionally
 151         include text about -n flag.
 152         * cli/cli-utils.h (struct info_print_options): Delete.
 153         (extract_info_print_options): Delete declaration.
 154         (info_print_command_completer): Delete declaration.
 155         (info_print_args_help): Add extra parameter, extend header
 156         comment.
 157         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 158         search_symbols.
 159         * stack.c (struct info_print_options): New type.
 160         (info_print_options_defs): New file scoped variable.
 161         (make_info_print_options_def_group): New static function.
 162         (info_print_command_completer): New static function.
 163         (info_locals_command): Update to use new local functions.
 164         (info_args_command): Likewise.
 165         (_initialize_stack): Add extra parameter to calls to
 166         info_print_args_help.
 167         * symtab.c (search_symbols): Add extra parameter, use this to
 168         possibly excluse non-debug symbols.
 169         (symtab_symbol_info): Add extra parameter, which is passed on to
 170         search_symbols.
 171         (struct info_print_options): New type.
 172         (info_print_options_defs): New file scoped variable.
 173         (make_info_print_options_def_group): New static function.
 174         (info_print_command_completer): New static function.
 175         (info_variables_command): Update to use local functions, and pass
 176         extra parameter through to symtab_symbol_info.
 177         (info_functions_command): Likewise.
 178         (info_types_command): Pass additional argument through to
 179         symtab_symbol_info.
 180         (rbreak_command): Pass extra argument to search_symbols.
 181         (_initialize_symtab): Add extra arguments for calls to
 182         info_print_args_help, and update help text for 'info variables',
 183         'whereis', and 'info functions' commands.
 184         * symtab.h (search_symbols): Add extra argument to declaration.
 185         * NEWS: Mention new flags.
 186
 187 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 188
 189         * symtab.c (lookup_static_symbol): Call the new function (and move
 190         it down to be next to lookup_global_symbol).
 191         (struct global_sym_lookup_data): Add block_enum member and rename to...
 192         (struct global_or_static_sym_lookup_data): ...this.
 193         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 194         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 195         (lookup_symbol_global_or_static_iterator_cb): ...this.
 196         (lookup_global_or_static_symbol): New function.
 197         (lookup_global_symbol): Call new function.
 198
 199 2019-08-26  Tom de Vries  <tdevries@suse.de>
 200
 201         PR c++/24852
 202         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 203         when pc_probe.prob == NULL.
 204
 205 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 206
 207         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 208         variable symbol_linkage to symbol_linkage_.
 209
 210 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 211
 212         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 213         represent whether the symbol is static, dynamic, or we don't
 214         know.
 215
 216 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 217
 218         * gdb/rx-tdep.c (rx_register_names): New.
 219         (rx_register_name): Delete.
 220         (rx_psw_type): Delete.
 221         (rx_fpsw_type): Delete.
 222         (rx_register_type): Delete.
 223         (rx_gdbarch_init): Convert target-descriptions.
 224         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 225         * gdb/features/Makefile: Add rx.xml.
 226         * gdb/features/rx.xml: New.
 227         * gdb/features/rx.c: Generated.
 228         * gdb/NEWS: Mention target description support.
 229
 230 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 231
 232         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 233         *slot_ptr.
 234
 235 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 236
 237         * configure.ac: Don't check for 'dlfcn.h' (moved to
 238         gdbsupport/common.m4).
 239         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 240         'gdbsupport/'.
 241         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 242         * compile/compile-c-support.c: Include
 243         'gdbsupport/gdb-dlfcn.h'.
 244         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 245         * gdb-dlfcn.c: Move to...
 246         * gdbsupport/gdb-dlfcn.c: ... here.
 247         * gdb-dlfcn.h: Move to...
 248         * gdbsupport/gdb-dlfcn.h: ... here.
 249
 250 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 251
 252         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 253         the offset field signed.
 254
 255 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 256
 257         * python/lib/gdb/__init__.py (_execute_file): New function.
 258         * python/python.c (python_run_simple_file): Call gdb._execute_file
 259         on Windows.
 260
 261 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 262
 263         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 264         all uses as this was never set to anything but a zero value.
 265
 266 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 267
 268         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 269
 270 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 271
 272         * tui/tui-data.h (tui_gen_win_info): Add an =default
 273         move constructor, required by some GCC versions.
 274
 275 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 276
 277         * go32-nat.c (go32_sysinfo): Add hygon_p.
 278
 279 2019-08-20  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 282         line_from_reg_element_no, first_reg_element_no_inline,
 283         display_all_data, delete_data_content_windows,
 284         erase_data_content>: Now private.
 285
 286 2019-08-20  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 289         (tui_unhighlight_win, tui_highlight_win)
 290         (tui_win_info::make_window): Update.
 291         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 292
 293 2019-08-20  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 296         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 297         (MAX_PID_WIDTH): Move to tui-stack.c.
 298         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 299         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 300         (MAX_PID_WIDTH): Move from tui-data.h.
 301
 302 2019-08-20  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 305         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 306         (box_win): Update.
 307         (tui_gen_win_info::make_window): Rename from tui_make_window.
 308         (tui_win_info::make_window): New method.
 309         (tui_gen_win_info::make_visible): Update.
 310         * tui/tui-source.c (tui_source_window::set_contents): Update.
 311         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 312         (tui_data_window::display_registers_from): Update.
 313         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 314         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 315         Declare.
 316         <can_box>: Remove.
 317         <title>: Remove.
 318         (struct tui_win_info) <make_window>: Declare.
 319         <can_box>: Now virtual.
 320         <title>: New member.
 321         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 322         * tui/tui-command.c (tui_cmd_window::resize): Update.
 323
 324 2019-08-20  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 327         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 328         (tui_data_window::check_register_values): Update.
 329
 330 2019-08-20  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-regs.h (struct tui_data_window): Use
 333         DISABLE_COPY_AND_ASSIGN.
 334         <regs_content>: Change type, removing unique_ptr.
 335         <tui_data_window>: Add move constructor.
 336         * tui/tui-regs.c (tui_data_window::show_registers)
 337         (tui_data_window::show_register_group)
 338         (tui_data_window::display_registers_from)
 339         (tui_data_window::display_registers_from)
 340         (tui_data_window::first_data_item_displayed)
 341         (tui_data_window::delete_data_content_windows)
 342         (tui_data_window::rerender, tui_data_window::refresh_window)
 343         (tui_data_window::check_register_values): Update.
 344
 345 2019-08-20  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 348         show_register_group>: Declare.
 349         (tui_show_register_group): Don't declare.
 350         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 351         tui_show_registers.
 352         (tui_data_window::show_register_group): Rename from
 353         tui_show_register_group.
 354         (tui_data_window::check_register_values, tui_reg_command):
 355         Update.
 356         * tui/tui-layout.c (tui_set_layout): Update.
 357
 358 2019-08-20  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 361         Declare.
 362         (tui_check_register_values): Don't declare.
 363         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 364         from tui_check_register_values.
 365         * tui/tui-hooks.c (tui_register_changed): Update.
 366
 367 2019-08-20  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-regs.c (tui_reg_layout): Move later.
 370         (tui_show_registers): Don't enable TUI mode or change layout.
 371
 372 2019-08-20  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-regs.h (struct tui_data_item_window)
 375         <~tui_data_item_window>: Remove.
 376         <content>: Now a unique_xmalloc_ptr.
 377         * tui/tui-regs.c (tui_register_format): Return a
 378         unique_xmalloc_ptr.
 379         (tui_get_register): Update.
 380         (~tui_data_item_window): Remove.
 381         (tui_data_window::display_registers_from, tui_display_register):
 382         Update.
 383         * tui/tui-io.h (tui_expand_tabs): Update.
 384         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 385         Remove "col" parameter.
 386
 387 2019-08-20  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 390         field.
 391         * tui/tui-regs.c (~tui_data_item_window): Update.
 392
 393 2019-08-20  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 396         earlier.
 397
 398 2019-08-20  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 401
 402 2019-08-20  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-source.h (struct tui_source_window): Update.
 405         * tui/tui-regs.c (tui_show_registers): Update.
 406         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 407         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 408         (NO_REGS_STRING): Remove defines.
 409
 410 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 411
 412         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 413         unnecessary thread walk if remote doesn't support the packet.
 414
 415 2019-08-19  Tom Tromey  <tromey@adacore.com>
 416
 417         * python/py-value.c (value_has_field): Fix indentation.
 418
 419 2019-08-19  Tom Tromey  <tromey@adacore.com>
 420
 421         * printcmd.c (do_one_display, info_display_command): Update.
 422         * block.h (contained_in): Return bool.  Add allow_nested
 423         parameter.
 424         * block.c (contained_in): Return bool.  Add allow_nested
 425         parameter.
 426
 427 2019-08-19  Tom Tromey  <tom@tromey.com>
 428
 429         * configure: Rebuild.
 430         * configure.ac: Disallow the combination of -static-libstdc++ and
 431         source highlight.
 432         * source-cache.c (get_language_name): Handle rust.
 433         (source_cache::get_source_lines): Ignore highlighting exceptions.
 434
 435 2019-08-16  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 438         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 439         (struct tui_source_window_base) <make_visible, refresh_window,
 440         resize>: Remove methods.
 441         <execution_info>: Remove field.
 442         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 443         (tui_show_source_line, tui_source_window_base)
 444         (~tui_source_window_base): Update.
 445         (tui_source_window_base::resize)
 446         (tui_source_window_base::make_visible)
 447         (tui_source_window_base::refresh_window): Remove.
 448         (tui_source_window_base::update_exec_info): Update.
 449         * tui/tui-source.c (tui_source_window::set_contents): Update.
 450         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 451
 452 2019-08-16  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 455         deprecated_query_hook.
 456
 457 2019-08-16  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 460         (tui_update_source_windows_with_line): Update.
 461         * tui/tui-source.h (struct tui_source_window)
 462         <show_symtab_source>: Declare.
 463         (tui_show_symtab_source): Don't declare.
 464         * tui/tui-source.c (tui_show_symtab_source): Rename from
 465         tui_show_symtab_source.
 466
 467 2019-08-16  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-winsource.h (struct tui_source_window_base)
 470         <set_contents>: Declare.
 471         * tui/tui-winsource.c
 472         (tui_source_window_base::update_source_window_as_is): Update.
 473         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 474         Declare.
 475         (tui_set_source_content): Don't declare.
 476         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 477         tui_set_source_content.
 478         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 479         Declare.
 480         (tui_set_disassem_content): Don't declare.
 481         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 482         tui_set_disassem_content.
 483
 484 2019-08-16  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-winsource.h (struct tui_source_window_base)
 487         <update_breakpoint_info>: Declare.
 488         (tui_update_breakpoint_info): Don't declare.
 489         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 490         (tui_update_all_breakpoint_info): Update.
 491         (tui_source_window_base::update_breakpoint_info): Rename from
 492         tui_update_breakpoint_info.
 493         (tui_source_window_base::update_exec_info): Update.
 494
 495 2019-08-16  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-winsource.h (struct tui_source_window_base)
 498         <update_source_window>: Declare.
 499         (tui_update_source_window): Don't declare.
 500         * tui/tui-winsource.c
 501         (tui_source_window_base::update_source_window): Rename from
 502         tui_update_source_window.
 503         (tui_source_window_base::rerender): Update.
 504         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 505         * tui/tui-disasm.c (tui_show_disassem)
 506         (tui_show_disassem_and_update_source)
 507         (tui_disasm_window::maybe_update): Update.
 508
 509 2019-08-16  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-winsource.h (struct tui_source_window_base)
 512         <update_source_window_as_is>: Declare.
 513         (tui_update_source_window_as_is): Don't declare.
 514         * tui/tui-winsource.c (tui_update_source_window): Update
 515         (tui_source_window_base::update_source_window_as_is): Rename from
 516         tui_update_source_window_as_is.
 517         (tui_source_window_base::refill): Update.
 518         * tui/tui-source.c (tui_show_symtab_source): Update.
 519         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 520         Update.
 521
 522 2019-08-16  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-winsource.h (tui_update_source_window)
 525         (tui_update_source_window_as_is): Remove "noerror" parameter.
 526         * tui/tui-winsource.c (tui_update_source_window)
 527         (tui_update_source_window_as_is): Remove "noerror" parameter.
 528         (tui_update_source_windows_with_addr)
 529         (tui_update_source_windows_with_line)
 530         (tui_source_window_base::rerender)
 531         (tui_source_window_base::refill): Update.
 532         * tui/tui-source.h (tui_set_source_content)
 533         (tui_show_symtab_source): Remove "noerror" parameter.
 534         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 535         parameter.
 536         (tui_show_symtab_source): Likewise.
 537         (tui_source_window::maybe_update): Update.
 538         * tui/tui-disasm.c (tui_show_disassem)
 539         (tui_show_disassem_and_update_source)
 540         (tui_disasm_window::do_scroll_vertical)
 541         (tui_disasm_window::maybe_update): Update.
 542
 543 2019-08-16  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui.c (tui_is_window_visible): Update.
 546         * tui/tui-wingeneral.c (tui_make_window)
 547         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 548         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 549         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 550         (tui_set_win_height_command, parse_scrolling_args): Update.
 551         * tui/tui-source.c (tui_source_window::style_changed): Update.
 552         * tui/tui-regs.c (tui_show_registers)
 553         (tui_data_window::first_data_item_displayed)
 554         (tui_data_window::delete_data_content_windows)
 555         (tui_check_register_values, tui_reg_command): Update.
 556         * tui/tui-disasm.c (tui_show_disassem): Update.
 557         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 558         method.
 559         <is_visible>: Remove field.
 560         * tui/tui-data.c (tui_next_win, tui_prev_win)
 561         (tui_delete_invisible_windows): Update.
 562
 563 2019-08-16  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-winsource.h (struct tui_source_window_base)
 566         <m_has_locator>: Remove.
 567         * tui/tui-layout.c (show_source_disasm_command, show_data)
 568         (show_source_or_disasm_and_command): Update.
 569
 570 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 571
 572         * NEWS (Other MI changes): New subsection.
 573         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 574         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 575         * arch-utils.c (default_get_pc_address_flags): New function.
 576         * arch-utils.h (default_get_pc_address_flags): New declaration.
 577         * gdbarch.sh: Add get_pc_address_flags.
 578         * gdbarch.c: Regenerate.
 579         * gdbarch.h: Likewise.
 580         * stack.c (print_pc): New function.
 581         (print_frame_info) (print_frame): Call print_pc.
 582
 583 2019-08-16  Tom de Vries  <tdevries@suse.de>
 584
 585         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 586         print_objfile_section_info.
 587
 588 2019-08-15  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 591         calling update_cmdwin_start_line.
 592         * tui/tui-winsource.h (struct tui_source_window_base)
 593         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 594         <rerender>: Declare.
 595         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 596         Call rerender.
 597         (tui_source_window_base::set_new_height): Remove.
 598         (tui_source_window_base::rerender): Rename from
 599         do_make_visible_with_new_height.
 600         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 601         resize method.
 602         (tui_win_info::make_invisible_and_set_new_height)
 603         (tui_win_info::make_visible_with_new_height): Remove.
 604         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 605         Declare.
 606         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 607         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 608         do_make_visible_with_new_height>: Don't declare.
 609         <rerender>: Declare.
 610         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 611         set_new_height.
 612         (tui_data_window::do_make_visible_with_new_height): Remove.
 613         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 614         call tui_show_locator_content.
 615         (tui_gen_win_info::resize): Call rerender.
 616         (show_source_or_disasm_and_command): Don't call
 617         tui_show_locator_content.
 618         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 619         method.
 620         (struct tui_win_info) <rerender>: Declare.
 621         <set_new_height, make_invisible_and_set_new_height,
 622         make_visible_with_new_height>: Don't declare.
 623         * tui/tui-data.c (tui_win_list::rerender): New method.
 624         * tui/tui-command.h (struct tui_cmd_window)
 625         <do_make_visible_with_new_height>: Don't declare.
 626         * tui/tui-command.c
 627         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 628
 629 2019-08-15  Tom Tromey  <tromey@adacore.com>
 630
 631         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 632         * ada-lang.c (ada_enum_name): Likewise.
 633
 634 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 635
 636         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 637         leading underscore.
 638         (GdbOutputErrorFile): Likewise.
 639         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 640         accordingly.
 641         (execute_unwinders): Rename to have a leading underscore.
 642         (auto_load_packages): Likewise.
 643         (global scope): Adjust call to auto_load_packages accordingly.
 644         (GdbSetPythonDirectory): Likewise.
 645         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 646         instead of execute_unwinders.
 647
 648 2019-08-15  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 651         (show_data): Don't change window visibility.
 652         (tui_gen_win_info::resize): Remove special case for command
 653         window.  Use wresize, when available.
 654         (show_source_or_disasm_and_command): Don't change window
 655         visibility.
 656         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 657         <make_visible>: New method.
 658         * tui/tui-command.c (tui_cmd_window::resize): New method.
 659
 660 2019-08-15  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 663         (struct tui_source_windows): New.
 664         * tui/tui-winsource.c (tui_display_main): Update.
 665         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 666         (new_height_ok, parse_scrolling_args): Update.
 667         * tui/tui-layout.c (show_layout, show_data): Update.
 668         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 669         (tui_add_to_source_windows): Don't declare.
 670         * tui/tui-data.c (source_windows, tui_source_windows)
 671         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 672
 673 2019-08-15  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 676         Rename from reset.
 677         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 678         * tui/tui-layout.c (show_source_disasm_command, show_data):
 679         Update.
 680         (tui_gen_win_info::resize): Rename.
 681         (show_source_or_disasm_and_command): Update.
 682         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 683         reset.
 684
 685 2019-08-15  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 688         * tui/tui-interp.c (tui_interp::init): Don't call
 689         tui_initialize_static_data.
 690         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 691
 692 2019-08-15  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 695         examine tui_win_list.
 696
 697 2019-08-15  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 700         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 701         tui_clear_source_content.
 702         (tui_clear_source_content): Remove.
 703         (tui_source_window_base::do_erase_source_content): Hoist call to
 704         content.clear().
 705         * tui/tui-stack.c (tui_show_frame_info): Don't call
 706         tui_clear_source_content.
 707
 708 2019-08-15  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-winsource.h (struct tui_source_window_base)
 711         <do_erase_source_content>: New method.
 712         <erase_source_content>: New method.
 713         (tui_erase_source_content): Don't declare.
 714         * tui/tui-winsource.c (tui_clear_source_content): Update.
 715         (tui_source_window_base::do_erase_source_content): Rename from
 716         tui_erase_source_content.
 717         (tui_source_window_base::show_source_content): Update.
 718         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 719         * tui/tui-source.h (struct tui_source_window)
 720         <erase_source_content>: New method.
 721         * tui/tui-disasm.h (struct tui_disasm_window)
 722         <erase_source_content>: New method.
 723
 724 2019-08-15  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 727         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 728         constructor.
 729         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 730         * tui/tui-source.c (tui_set_source_content): Update.
 731         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 732
 733 2019-08-15  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 736         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 737         tui-source.c.
 738         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 739         Declare.
 740         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 741         method.
 742         (tui_source_window::maybe_update): Update.
 743
 744 2019-08-15  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 747         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 748         tui-disasm.c.
 749         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 750         Declare.
 751         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 752         method.
 753         (tui_disasm_window::maybe_update): Update.
 754
 755 2019-08-15  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-winsource.h (struct tui_source_window_base)
 758         <maybe_update>: Declare.
 759         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 760         method.
 761         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 762         Declare.
 763         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 764         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 765         Declare.
 766         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 767
 768 2019-08-15  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 771
 772 2019-08-15  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-wingeneral.c: Include tui-stack.h.
 775         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 776         (struct tui_locator_window): Move from tui-data.h.
 777         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 778         (tui_initialize_static_data): Move from tui-data.c.
 779         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 780         (struct tui_locator_window): Move to tui-stack.c.
 781         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 782         (tui_initialize_static_data): Move to tui-stack.c.
 783
 784 2019-08-15  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui-layout.c (show_source_disasm_command)
 787         (show_source_or_disasm_and_command): Use make_visible method, not
 788         tui_make_window.
 789         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 790         Remove.
 791
 792 2019-08-15  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-wingeneral.h (tui_make_window): Update.
 795         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 796         parameter.
 797         (tui_gen_win_info::make_visible): Update.
 798         * tui/tui-regs.c (tui_data_window::display_registers_from):
 799         Update.
 800         * tui/tui-layout.c (show_source_disasm_command)
 801         (show_source_or_disasm_and_command): Update.
 802         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 803         (enum tui_box): Remove.
 804         (struct tui_win_info) <can_box>: New method.
 805         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 806         method.
 807
 808 2019-08-15  Tom de Vries  <tdevries@suse.de>
 809
 810         * linux-nat-trad.c: Include gdbarch.h.
 811
 812 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 813
 814         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 815         register sizes.
 816
 817 2019-08-14  Tom Tromey  <tromey@adacore.com>
 818
 819         * darwin-nat.c: Include gdbarch.h.
 820         * darwin-nat-info.c: Include gdbarch.h.
 821
 822 2019-08-13  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 825         Remove.
 826         * tui/tui-data.c (tui_initialize_static_data): Update.
 827
 828 2019-08-13  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-winsource.h (struct tui_exec_info_window)
 831         <~tui_exec_info_window, maybe_allocate_content, get_content,
 832         m_content>: Remove.
 833         (struct tui_source_window_base) <set_exec_info_content,
 834         show_exec_info_content>: Don't declare.
 835         * tui/tui-winsource.c
 836         (tui_exec_info_window::maybe_allocate_content): Remove.
 837         (tui_source_window_base::update_exec_info): Rename from
 838         set_exec_info_content.
 839         (tui_source_window_base::show_exec_info_content)
 840         (tui_source_window_base::update_exec_info): Remove.
 841
 842 2019-08-13  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 845         declare.
 846         * tui/tui-winsource.c (tui_update_source_window_as_is)
 847         (tui_update_source_windows_with_addr, tui_erase_source_content):
 848         Update.
 849         (tui_clear_exec_info_content): Remove.
 850
 851 2019-08-13  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 854         declare.
 855         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 856         call tui_erase_exec_info_content.
 857         (tui_clear_exec_info_content): Rename from
 858         tui_erase_exec_info_content.
 859         (tui_clear_exec_info_content): Delete.
 860
 861 2019-08-13  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-winsource.h (struct tui_source_window_base)
 864         <show_exec_info_content>: Declare.
 865         (tui_show_exec_info_content): Don't declare.
 866         * tui/tui-winsource.c
 867         (tui_source_window_base::show_exec_info_content): Rename from
 868         tui_show_exec_info_content.
 869         (tui_source_window_base::update_exec_info): Update.
 870
 871 2019-08-13  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 874         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 875         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 876         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 877         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 878         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 879         ... here.
 880
 881 2019-08-13  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-winsource.h (struct tui_source_window_base)
 884         <update_exec_info>: Declare.
 885         (tui_update_exec_info): Don't declare.
 886         * tui/tui-winsource.c (tui_update_source_window_as_is)
 887         (tui_source_window_base::refresh_all)
 888         (tui_update_all_breakpoint_info): Update.
 889         (tui_source_window_base::update_exec_info): Rename from
 890         tui_update_exec_info.
 891         * tui/tui-stack.c (tui_show_frame_info): Update.
 892
 893 2019-08-13  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-winsource.h (struct tui_source_window_base)
 896         <set_exec_info_content>: Declare.
 897         (tui_set_exec_info_content): Don't declare.
 898         * tui/tui-winsource.c
 899         (tui_source_window_base::set_exec_info_content): Rename from
 900         tui_set_exec_info_content.
 901         (tui_update_exec_info): Update.
 902
 903 2019-08-13  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-winsource.h (struct tui_source_window_base)
 906         <show_source_content>: Declare.
 907         (tui_show_source_content): Don't declare.
 908         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 909         (tui_source_window_base::show_source_content): Rename from
 910         tui_show_source_content.
 911         (tui_source_window_base::refresh_all): Update.
 912         * tui/tui-layout.c (show_source_disasm_command)
 913         (show_source_or_disasm_and_command): Update.
 914
 915 2019-08-13  Tom Tromey  <tom@tromey.com>
 916
 917         * tui/tui-winsource.c (tui_erase_source_content)
 918         (tui_show_source_content, tui_source_window_base::refresh_all):
 919         Update.
 920         * tui/tui-wingeneral.h
 921         (tui_check_and_display_highlight_if_needed): Don't declare.
 922         * tui/tui-wingeneral.c
 923         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 924         check_and_display_highlight_if_needed.
 925         * tui/tui-win.c (tui_rehighlight_all)
 926         (tui_win_info::make_visible_with_new_height): Update.
 927         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 928         (tui_data_window::erase_data_content)
 929         (tui_data_window::display_all_data): Update.
 930         * tui/tui-data.h (struct tui_win_info)
 931         <check_and_display_highlight_if_needed>: Declare.
 932
 933 2019-08-13  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-win.c (tui_resize_all): Call
 936         tui_delete_invisible_windows.
 937         * tui/tui-layout.c (show_layout): Call
 938         tui_delete_invisible_windows.
 939         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 940         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 941
 942 2019-08-13  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 945         tui_add_win_to_layout.
 946
 947 2019-08-13  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 950         * tui/tui-layout.c (tui_default_win_height): Now static.
 951
 952 2019-08-13  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 955         single switch.
 956         (show_source_disasm_command, show_source_or_disasm_and_command):
 957         Don't check current layout.
 958
 959 2019-08-13  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-wingeneral.c (make_all_visible): Remove.
 962         (tui_make_all_invisible): Simplify.
 963         * tui/tui-layout.c (tui_make_all_invisible): Move from
 964         tui-wingeneral.c; simplify.
 965         (show_layout): Hoist call to tui_make_all_invisible.
 966         (show_data): Don't call tui_make_all_invisible.
 967
 968 2019-08-13  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 971         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 972
 973 2019-08-13  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 976         tui-data.c.
 977         (show_source_disasm_command, show_data)
 978         (show_source_or_disasm_and_command): Don't use
 979         tui_set_current_layout_to.
 980         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 981         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 982         tui-layout.c.
 983         (tui_set_current_layout_to): Remove.
 984
 985 2019-08-13  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui-layout.c (tui_set_layout): Update.
 988         * tui/tui-data.h (struct tui_layout_def): Remove.
 989         (tui_layout_def): Don't declare.
 990         * tui/tui-data.c (layout_def): Remove.
 991         (tui_layout_def): Remove.
 992
 993 2019-08-13  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-winsource.h (struct tui_source_window_base)
 996         <clear_detail>: No longer "override".
 997         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 998         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 999         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1000         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1001         Remove.
1002         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1003
1004 2019-08-13  Tom Tromey  <tromey@adacore.com>
1005
1006         * tracepoint.c: Don't include readline.h or history.h.
1007
1008 2019-08-12  Tom Tromey  <tom@tromey.com>
1009
1010         * configure: Rebuild.
1011         * configure.ac: Check for readline 7.
1012         * NEWS: Mention readline 7 requirement.
1013         * README: Update.
1014
1015 2019-08-12  Tom Tromey  <tom@tromey.com>
1016
1017         * mingw-hdep.c (gdb_select): Remove readline hack.
1018
1019 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1020
1021         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1022         when the function fails.
1023
1024 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1025
1026         * s390-tdep.c (s390_type_align): New function.
1027         (s390_gdbarch_init): Set it as type_align gdbarch method.
1028
1029 2019-08-09  Tom de Vries  <tdevries@suse.de>
1030
1031         PR gdb/24591
1032         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1033         pc_low with relocation offset.
1034
1035 2019-08-07  Tom Tromey  <tromey@adacore.com>
1036
1037         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1038         (print_frame_args): Update.
1039         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1040         Update.
1041         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1042         * frame.h (struct frame_arg): Add initializers.
1043         <error>: Now a unique_xmalloc_ptr.
1044
1045 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1046
1047         * NEWS: Expand the Pointer Authentication entry.
1048         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1049         (aarch64_frame_unmask_lr): ... to this.
1050         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1051         Call aarch64_frame_unmask_lr.
1052         * frame.c (struct frame_info): Add "masked" variable.
1053         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1054         (fprint_frame): Check for masked pc.
1055         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1056         declarations.
1057         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1058         * stack.c (print_frame): Check for masked pc.
1059
1060 2019-08-06  Tom Tromey  <tom@tromey.com>
1061
1062         * stabsread.c (patch_block_stabs, read_one_struct_field)
1063         (read_enum_type): Use obstack_strndup.
1064         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1065         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1066         * dwarf2read.c (guess_full_die_structure_name)
1067         (anonymous_struct_prefix): Use obstack_strndup.
1068         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1069         * c-exp.y (yylex): Use obstack_strndup.
1070         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1071         (write_var_or_type): Use obstack_strndup.
1072
1073 2019-08-06  Tom Tromey  <tom@tromey.com>
1074
1075         * symfile.c (reread_symbols): Use obstack_strdup.
1076         * stabsread.c (read_type): Use obstack_strdup.
1077         * gdb_obstack.h (obstack_strdup): New overload.
1078         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1079         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1080         (dwarf2_canonicalize_name): Use obstack_strdup.
1081         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1082         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1083         Use obstack_strdup.
1084
1085 2019-08-06  Tom Tromey  <tom@tromey.com>
1086
1087         * gdb_obstack.h (obstack_strdup): Define.
1088         * gdb_obstack.c (obstack_strdup): Don't define.
1089
1090 2019-08-06  Tom Tromey  <tom@tromey.com>
1091
1092         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1093         obstack_strdup.
1094         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1095         obstack_strdup.
1096         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1097         * stabsread.c (common_block_start): Use obstack_strdup.
1098         * objfiles.c (set_objfile_main_name, objfile): Use
1099         obstack_strdup.
1100         * namespace.c (add_using_directive): Use obstack_strdup.
1101         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1102         * jit.c (finalize_symtab): Use obstack_strdup.
1103         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1104         (guess_partial_die_structure_name, partial_die_info::fixup)
1105         (dwarf2_name): Use obstack_strdup.
1106         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1107         obstack_strdup.
1108         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1109         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1110         obstack_strdup.
1111         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1112
1113 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1114
1115         * unittests/help-doc-selftests.c: New file.
1116         * Makefile.in: Add the new file.
1117
1118 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1119
1120         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1121         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1122         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1123         the trailing '.' is not output, and the first character is uppercased.
1124         (print_help_for_command): Update call to print_doc_line.
1125         (print_doc_of_command): Likewise.
1126         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1127         * cli/cli-option.c (append_indented_doc): Do not append newline.
1128         (build_help_option): Append newline after first appended_indented_doc
1129         only if a second call is done.
1130         (build_help): Append 2 new lines before each option, except the first
1131         one.
1132         * compile/compile.c (_initialize_compile): Add new lines after
1133         %OPTIONS%, when not at the end of the help.
1134         Change help doc or code
1135         producing the help doc to respect the invariants.
1136         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1137         Also removed the new line after 'Options:', as all other commands
1138         do not put an empty line between 'Options:' and the first option.
1139         * printcmd.c (_initialize_printcmd): Likewise.
1140         * stack.c (_initialize_stack): Likewise.
1141         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1142         incorrectly telling COMMAND is optional.
1143         * ada-lang.c (_initialize_ada_language): Change help doc or code
1144         producing the help doc to respect the invariants.
1145         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1146         * breakpoint.c (_initialize_breakpoint): Likewise.
1147         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1148         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1149         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1150         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1151         _initialize_cli_style): Likewise.
1152         * corelow.c (core_target_info): Likewise.
1153         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1154         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1155         * filesystem.c (_initialize_filesystem): Likewise.
1156         * frame.c (_initialize_frame): Likewise.
1157         * gnu-nat.c (add_task_commands): Likewise.
1158         * infcall.c (_initialize_infcall): Likewise.
1159         * infcmd.c (_initialize_infcmd): Likewise.
1160         * interps.c (_initialize_interpreter): Likewise.
1161         * language.c (_initialize_language): Likewise.
1162         * linux-fork.c (_initialize_linux_fork): Likewise.
1163         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1164         * maint.c (_initialize_maint_cmds): Likewise.
1165         * memattr.c (_initialize_mem): Likewise.
1166         * printcmd.c (_initialize_printcmd): Likewise.
1167         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1168         _RegEx): Likewise.
1169         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1170         * record-btrace.c (_initialize_record_btrace): Likewise.
1171         * record-full.c (_initialize_record_full): Likewise.
1172         * record.c (_initialize_record): Likewise.
1173         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1174         * regcache.c (_initialize_regcache): Likewise.
1175         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1176         _initialize_remote): Likewise.
1177         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1178         * serial.c (_initialize_serial): Likewise.
1179         * skip.c (_initialize_step_skip): Likewise.
1180         * source.c (_initialize_source): Likewise.
1181         * stack.c (_initialize_stack): Likewise.
1182         * symfile.c (_initialize_symfile): Likewise.
1183         * symtab.c (_initialize_symtab): Likewise.
1184         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1185         * top.c (init_main): Likewise.
1186         * tracefile-tfile.c (tfile_target_info): Likewise.
1187         * tracepoint.c (_initialize_tracepoint): Likewise.
1188         * tui/tui-win.c (_initialize_tui_win): Likewise.
1189         * utils.c (add_internal_problem_command): Likewise.
1190         * valprint.c (value_print_option_defs): Likewise.
1191
1192 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1193
1194         PR build/24886
1195         * configure.ac: Drop enable-libmcheck support.
1196         * configure, config.in: Rebuild.
1197         * libmcheck.m4: Remove.
1198         * acinclude.m4: Don't include it.
1199         * Makefile.in: Don't distribute it.
1200         * top.c (print_gdb_configuration): Don't mention it.
1201
1202 2019-08-06  Tom Tromey  <tom@tromey.com>
1203
1204         * utils.c (set_output_style): Sometimes pass stream to
1205         emit_style_escape.
1206         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1207         * record-btrace.c (btrace_insn_history): Update.
1208         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1209         method.
1210         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1211         Update initializers.
1212         <m_uiout>: New field.
1213         <m_di>: Move lower.
1214         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1215         Remove "uiout" parameter.
1216         (dump_insns): Update.
1217         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1218         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1219
1220 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1221
1222         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1223         (error_in_psymtab_expansion): Likewise.
1224         (lookup_symbol_via_quick_fns): Likewise.
1225         (basic_lookup_transparent_type_quick): Likewise.
1226         (basic_lookup_transparent_type_1): Likewise.
1227
1228 2019-08-06  Tom Tromey  <tromey@adacore.com>
1229
1230         * source.c (last_source_error): Now bool.
1231         (print_source_lines_base): Make "noprint" bool.  Only open
1232         source file when last_source_visited changes.
1233
1234 2019-08-06  Tom Tromey  <tromey@adacore.com>
1235
1236         * annotate.c (annotate_source_line): Use g_source_cache.
1237         * source-cache.c (source_cache::get_plain_source_lines): Change
1238         parameters.  Populate m_offset_cache.
1239         (source_cache::ensure): New method.
1240         (source_cache::get_line_charpos): New method.
1241         (extract_lines): Move lower.  Change parameters.
1242         (source_cache::get_source_lines): Move lower.
1243         * source-cache.h (class source_cache): Update comment.
1244         <get_line_charpos>: New method.
1245         <get_source_lines>: Update comment.
1246         <clear>: Clear m_offset_cache.
1247         <get_plain_source_lines>: Change parameters.
1248         <ensure>: New method
1249         <m_offset_cache>: New member.
1250         * source.c (forget_cached_source_info_for_objfile): Update.
1251         (info_source_command): Use g_source_cache.
1252         (find_source_lines, open_source_file_with_line_charpos): Remove.
1253         (print_source_lines_base, search_command_helper): Use g_source_cache.
1254         * source.h (open_source_file_with_line_charpos): Don't declare.
1255         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1256         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1257         Use g_source_cache.
1258
1259 2019-08-06  Tom Tromey  <tromey@adacore.com>
1260
1261         * source-cache.c (source_cache::get_plain_source_lines):
1262         Remove "first_line" and "last_line" parameters.
1263         (source_cache::get_source_lines): Cache plain text.
1264         * source-cache.h (class source_cache)
1265         <get_plain_source_lines>: Update.
1266
1267 2019-08-06  Tom Tromey  <tromey@adacore.com>
1268
1269         * source-cache.c (extract_lines): No longer a method.
1270         Changed type of parameter.  Include final newline.
1271         (selftests::extract_lines_test): New function.
1272         (_initialize_source_cache): Likewise.
1273         * source-cache.h (class source_cache)
1274         <extract_lines>: Don't declare.
1275
1276 2019-08-06  Tom Tromey  <tromey@adacore.com>
1277
1278         * breakpoint.c (init_breakpoint_sal): Update.
1279         (breakpoint): Update.
1280         * breakpoint.h (struct breakpoint) <filter>: Now a
1281         unique_xmalloc_ptr.
1282
1283 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1284
1285         * NEWS: Mention dictionary access on blocks.
1286         * python/py-block.c (blpy_getitem): New function.
1287         (block_object_as_mapping): New struct.
1288         (block_object_type): Use new struct for tp_as_mapping field.
1289
1290 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1291
1292         * objfiles.h (objfile): Add a comment describing partial symbols.
1293
1294 2019-08-05  Tom Tromey  <tromey@adacore.com>
1295
1296         * compile/compile.c (_initialize_compile): Use _(), not N_().
1297         * thread.c (_initialize_thread): Use _(), not N_().
1298         * stack.c (_initialize_stack): Use _(), not N_().
1299         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1300
1301 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1302
1303         * dwarf2read.c (struct dw2_symtab_iterator):
1304         <want_specific_block>: Remove.
1305         <block_index>: Change type to gdb::optional.
1306         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1307         change type of BLOCK_INDEX parameter to gdb::optional.
1308         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1309         (dw2_lookup_symbol): Don't pass argument for
1310         WANT_SPECIFIC_BLOCK.
1311         (dw2_expand_symtabs_for_function): Don't pass argument for
1312         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1313         (class dw2_debug_names_iterator)
1314         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1315         parameter, change BLOCK_INDEX type to gdb::optional.
1316         <m_want_specific_block>: Remove.
1317         <m_block_index>: Change type to gdb::optional.
1318         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1319         gdb::optional.  Re-write in function of gdb::optional.
1320         (dw2_debug_names_lookup_symbol): Don't pass argument for
1321         WANT_SPECIFIC_BLOCK.
1322         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1323         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1324         BLOCK_INDEX.
1325
1326 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1327
1328         * NEWS: Mention changes to "info sources" command.
1329
1330 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1331
1332         * symtab.c (filename_partial_match_opts): New struct type.
1333         (struct output_source_filename_data): New members
1334         regexp, c_regexp, partial_match.
1335         (output_source_filename): Use new members to decide to print file.
1336         (info_sources_option_defs): New variable.
1337         (make_info_sources_options_def_group, print_info_sources_header,
1338         info_sources_command_completer):
1339         New functions.
1340         (info_sources_command): Read new optional arguments.
1341         (_initialize_symtab): Update info sources help.
1342
1343 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1344
1345         * ada-lang.c (exception_support_info_v0): Renamed from...
1346         (default_exception_support_info): ... this.  Create new
1347         definition for v1.
1348         (ada_has_this_exception_support): Look up catch_handlers_sym.
1349         (ada_exception_support_info_sniffer): Try v0 after default.
1350
1351 2019-08-01  Tom Tromey  <tromey@adacore.com>
1352
1353         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1354         gdbarch.h.
1355
1356 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1357
1358         * s12z-tdep.c: Fix include path for s12z-opc.h.
1359
1360 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1361
1362         * NEWS: Require GNU make 3.82.
1363
1364 2019-07-16  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1367         declare.
1368
1369 2019-07-30  Tom Tromey  <tromey@adacore.com>
1370
1371         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1372
1373 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1374
1375         * printcmd.c (print_address_symbolic): Print negative offsets.
1376         (build_address_symbolic): Force signed arithmetic when computing
1377         offset.
1378
1379 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1380
1381         PR/24474: Add a function to lookup static variables.
1382         * NEWS: Mention this new function.
1383         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1384         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1385         * python/python.c (python_GdbMethods): Add new function.
1386
1387 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1388
1389         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1390         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1391         (objfpy_lookup_static_symbol): New function.
1392         (objfile_object_methods): Add new functions.
1393
1394 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1395
1396         * NEWS: Mention 'set|show print frame-info'.  Mention new
1397         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1398         backtrace argument.  Mention that python frame filtering code
1399         is now consistent with what 'backtrace' command prints.
1400
1401 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1402
1403         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1404         comments.
1405         (print_frame_info_auto, print_frame_info_source_line,
1406         print_frame_info_location, print_frame_info_source_and_location,
1407         print_frame_info_location_and_address, print_frame_info_short_location):
1408         New declarations.
1409         (struct frame_print_options): New member print_frame_info.
1410         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1411         * stack.h (get_user_print_what_frame_info): New declaration.
1412         (frame_show_address): New declaration.
1413         * stack.c (print_frame_arguments_choices): New value 'presence'.
1414         (print_frame_info_auto, print_frame_info_source_line,
1415         print_frame_info_location, print_frame_info_source_and_location,
1416         print_frame_info_location_and_address, print_frame_info_short_location,
1417         print_frame_info_choices, print_frame_info_print_what): New definitions.
1418         (print_frame_args): Only print dots for args if print frame-arguments
1419         is 'presence'.
1420         (frame_print_option_defs): New element for "frame-info".
1421         (get_user_print_what_frame_info): New function.
1422         (frame_show_address): Make non static.  Move comment to stack.h.
1423         (print_frame_info_to_print_what): New function.
1424         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1425         to decide what to print.
1426         (backtrace_command_1): Handle the new print_frame_arguments_presence
1427         value.
1428         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1429         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1430         (py_print_frame): In non-mi mode, use LOCATION as default for
1431         print_what, similarly to frame information printed directly by
1432         backtrace command. Handle frame-info user option in non MI mode.
1433
1434 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1435
1436         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1437         Add case for debugging 32-bit target on 64-bit host.  Revise
1438         comment.
1439
1440 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1441
1442         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1443         instead of find_function_entry_range_from_pc.
1444
1445 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1446
1447         * stack.c (find_frame_funname): Remove code which preferred
1448         minsym over symtab sym in "certain pathological cases".
1449
1450         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1451         parameter.  Change type of "do_demangle" to bool.
1452         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1453         Pass suitable "prefer_sym_over_minsym" flag to
1454         build_address_symbolic().  Don't output "+" for negative offsets.
1455         * printcmd.c (print_address_symbolic): Update invocation of
1456         build_address_symbolic to include a "prefer_sym_over_minsym"
1457         flag.
1458         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1459         Restrict cases in which use of minimal symbol is preferred to that
1460         of a found symbol.  Update comments.
1461
1462         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1463         for entry pc when entry pc is out of range for that FDE.
1464
1465 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1466
1467         PR gdb/24839:
1468         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1469         type.
1470
1471 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1472
1473         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1474         this function's Python signature.
1475
1476
1477 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1478
1479         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1480         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1481         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1482         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1483         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1484
1485
1486 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1487
1488         * h8300-tdep.c (h8300_register_name_common): New.
1489         h8300_register_name): Use h8300_register_name_common.
1490         (h8300s_register_name): Likewise.
1491         (h8300sx_register_name): Likewise.
1492         (h8300h_register_nam): New.
1493         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1494
1495
1496 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1497
1498         * arm-tdep.c (arm_skip_cmse_entry): New function.
1499         (arm_is_sgstubs_section): New function.
1500         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1501
1502 2019-07-22  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1505         Don't self-assign.
1506
1507 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1508
1509         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1510         type_print.
1511
1512 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1513
1514         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1515         so that GDB doesn't match any msymbols when searching in the
1516         TYPES_DOMAIN.
1517         (print_symbol_info): Print using typedef_print or type_print based
1518         on the type of the symbol.  Add updated FIXME comment moved from...
1519         (_initialize_symtab): ... move and update FIXME comment to above.
1520
1521 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1522
1523         * NEWS: Mention adding -q option to "info types".
1524         * symtab.c (struct info_types_options): New struct.
1525         (info_types_options_defs): New variable.
1526         (make_info_types_options_def_group): New function.
1527         (info_types_command): Use gdb::option framework to parse options.
1528         (info_types_command_completer): New function.
1529         (_initialize_symtab): Extend the help text on "info types" and
1530         register command completer.
1531
1532 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1533
1534         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1535         (lookup_symbol_in_objfile): Change int to block_enum and add a
1536         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1537
1538 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1539
1540         * MAINTAINERS (Write After Approval): Add self.
1541
1542 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1545         instruction to the dummy code region.
1546
1547 2019-07-19  Tom Tromey  <tromey@adacore.com>
1548
1549         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1550         (ARGSUSED, PARAMS, __func__): Remove rules.
1551
1552 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1553
1554         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1555         * features/arm/arm-with-iwmmxt.c: Remove.
1556         * features/arm/arm-with-iwmmxt.xml: Remove.
1557         * features/arm/arm-with-m-fpa-layout.c: Remove.
1558         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1559         * features/arm/arm-with-m-vfp-d16.c: Remove.
1560         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1561         * features/arm/arm-with-m.c: Remove.
1562         * features/arm/arm-with-m.xml: Remove.
1563         * features/arm/arm-with-neon.c: Remove.
1564         * features/arm/arm-with-neon.xml: Remove.
1565         * features/arm/arm-with-vfpv2.c: Remove.
1566         * features/arm/arm-with-vfpv2.xml: Remove.
1567         * features/arm/arm-with-vfpv3.c: Remove.
1568         * features/arm/arm-with-vfpv3.xml: Remove.
1569
1570 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1571
1572         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1573
1574 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1575
1576         * arch/aarch32.c (aarch32_create_target_description): Create
1577         target descriptions using features.
1578         * arch/arm.c (arm_create_target_description)
1579         (arm_create_mprofile_target_description): Likewise.
1580         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1581
1582 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1583
1584         * Makefile.in: Add new files.
1585         * aarch32-tdep.c: New file.
1586         * aarch32-tdep.h: New file.
1587         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1588         Call aarch32_read_description.
1589         * arch/aarch32.c: New file.
1590         * arch/aarch32.h: New file.
1591         * arch/arm.c (arm_create_target_description)
1592         (arm_create_mprofile_target_description): New function.
1593         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1594         (arm_create_target_description)
1595         (arm_create_mprofile_target_description): New declaration.
1596         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1597         read_description functions.
1598         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1599         Likewise.
1600         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1601         * arm-tdep.c (tdesc_arm_list): New variable.
1602         (arm_register_g_packet_guesses): Call create description functions.
1603         (arm_read_description) (arm_read_mprofile_description): New
1604         function.
1605         * arm-tdep.h (arm_read_description)
1606         (arm_read_mprofile_description): Add declaration.
1607         * configure.tgt: Add new files.
1608
1609 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1610
1611         * top.c (new_ui_command): Open specified terminal just once.
1612
1613 2019-07-18  Tom Tromey  <tromey@adacore.com>
1614
1615         * symtab.c (main_name): Constify return type.
1616         * symfile.c (set_initial_language): Update.
1617         * symtab.h (main_name): Constify return type.
1618
1619 2019-07-17  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-winsource.c (tui_update_source_window)
1622         (tui_update_source_window_as_is)
1623         (tui_update_source_windows_with_line): Remove return.
1624         * tui/tui-disasm.c (tui_show_disassem)
1625         (tui_show_disassem_and_update_source): Remove return.
1626         * tui/tui.c (tui_reset): Remove return.
1627         * tui/tui-wingeneral.c
1628         (tui_check_and_display_highlight_if_needed): Remove return.
1629
1630 2019-07-17  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1633
1634 2019-07-17  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-winsource.h (struct tui_exec_info_window)
1637         (struct tui_source_window_base): Move from tui-data.h.
1638         * tui/tui-winsource.c: Move many method definitions from
1639         elsewhere.  Remove "structuring" comments.
1640         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1641         (tui_source_window_base::refresh_window): Move to
1642         tui-winsource.c.
1643         * tui/tui-win.c (tui_source_window_base::refresh_all)
1644         (tui_source_window_base::update_tab_width)
1645         (tui_source_window_base::set_new_height)
1646         (tui_source_window_base::do_make_visible_with_new_height): Move to
1647         tui-winsource.c.
1648         * tui/tui-source.h: Update.
1649         * tui/tui-source.c (tui_source_window_base::reset): Move to
1650         tui-winsource.c.
1651         * tui/tui-disasm.h: Update.
1652         * tui/tui-data.h (struct tui_exec_info_window): Move to
1653         tui-winsource.h.
1654         (struct tui_source_window_base): Likewise.
1655         * tui/tui-data.c (tui_source_window_base::clear_detail)
1656         (tui_source_window_base, ~tui_source_window_base): Move to
1657         tui-winsource.c.
1658
1659 2019-07-17  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-win.c (tui_resize_all)
1662         (tui_source_window_base::update_tab_width)
1663         (tui_adjust_win_heights): Update.
1664         (tui_win_info::make_invisible_and_set_new_height): Rename from
1665         make_invisible_and_set_new_height.
1666         * tui/tui-data.h (struct tui_win_info)
1667         <make_invisible_and_set_new_height>: New method.
1668
1669 2019-07-17  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui.c: Update.
1672         * tui/tui-source.h (struct tui_source_window): Move from
1673         tui-data.h.
1674         * tui/tui-layout.c: Update.
1675         * tui/tui-disasm.c: Update.
1676         * tui/tui-data.h (struct tui_source_window): Move to
1677         tui-source.h.
1678
1679 2019-07-17  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1682         tui-data.h.
1683         * tui/tui-data.h (struct tui_disasm_window): Move to
1684         tui-disasm.h.
1685
1686 2019-07-17  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-regs.h (struct tui_data_item_window): Move from
1689         tui-data.h.
1690         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1691         * tui/tui-data.h (struct tui_data_item_window): Move to
1692         tui-regs.h.
1693         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1694
1695 2019-07-17  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui.c: Update.
1698         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1699         (tui_cmd_window::max_height): Move to tui-command.c.
1700         * tui/tui-layout.c: Update.
1701         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1702         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1703         tui-command.c.
1704         * tui/tui-command.h (struct tui_cmd_window): Move from
1705         tui-data.h.
1706         * tui/tui-command.c: Remove "structuring" comments.
1707         (tui_cmd_window::clear_detail)
1708         (tui_cmd_window::do_make_visible_with_new_height)
1709         (tui_cmd_window::max_height): Move from elsewhere.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1714         Now static.
1715         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1716         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1717
1718 2019-07-17  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui.c: Update.
1721         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1722         tui-regs.c.
1723         * tui/tui-windata.h: Remove file.
1724         * tui/tui-windata.c: Remove file.
1725         * tui/tui-win.c (tui_data_window::set_new_height)
1726         (tui_data_window::do_make_visible_with_new_height): Move to
1727         tui-regs.c.
1728         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1729         * tui/tui-regs.c: Remove "structuring" comments.
1730         (tui_data_window::first_data_item_displayed)
1731         (tui_data_window::delete_data_content_windows)
1732         (tui_data_window::erase_data_content)
1733         (tui_data_window::display_all_data)
1734         (tui_data_window::refresh_all)
1735         (tui_data_window::do_scroll_vertical)
1736         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1737         (tui_data_window::do_make_visible_with_new_height)
1738         (tui_data_window::refresh_window): Move from elsewhere.
1739         (_initialize_tui_regs): Move to end of file.
1740         * tui/tui-layout.c: Update.
1741         * tui/tui-hooks.c: Update.
1742         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1743         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1744         tui-regs.c.
1745         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1746
1747 2019-07-17  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1750         seen.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-win.c (tui_source_window_base::set_new_height)
1755         (tui_source_window_base::do_make_visible_with_new_height): Use
1756         m_has_locator field directly.
1757         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1758         method.
1759         (struct tui_source_window_base) <has_locator>: Likewise.
1760
1761 2019-07-17  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1764         Don't declare.
1765         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1766         Remove.
1767         * tui/tui-win.c (tui_source_window_base::set_new_height)
1768         (tui_source_window_base::set_new_height)
1769         (make_invisible_and_set_new_height)
1770         (tui_source_window_base::do_make_visible_with_new_height)
1771         (tui_source_window_base::do_make_visible_with_new_height):
1772         Update.
1773         * tui/tui-layout.c (show_source_disasm_command, show_data)
1774         (show_source_or_disasm_and_command): Update.
1775         * tui/tui-layout.c (show_layout): Update.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-layout.c (make_data_window): Remove.
1780         (show_data): Unify creation and re-initialization cases.
1781
1782 2019-07-17  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-layout.c (make_source_window, make_disasm_window):
1785         Remove.
1786         (show_data): Unify creation and re-initialization cases.
1787
1788 2019-07-17  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-layout.c (make_command_window): Remove.
1791         (show_source_disasm_command, show_source_or_disasm_and_command):
1792         Unify creation and re-initialization cases.
1793
1794 2019-07-17  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1797         creation and re-initialization cases.
1798
1799 2019-07-17  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-regs.c (tui_get_register): Return void.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1806         Simplify.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1811         resetting.
1812
1813 2019-07-17  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1816         * tui/tui-regs.c (tui_reg_layout): New function.
1817         (tui_show_registers, tui_reg_command): Use it.
1818         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1819         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1820         parameters.
1821         (tui_layout_command): Remove.
1822
1823 2019-07-17  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-layout.h (tui/tui-layout): Return void.
1826         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1827
1828 2019-07-17  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-layout.c (show_source_disasm_command, show_data):
1831         Update.
1832         (reset_locator): Remove.
1833         (show_source_or_disasm_and_command): Update.
1834
1835 2019-07-17  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-source.c (tui_source_window_base::reset): Remove
1838         win_type parameter.
1839         * tui/tui-layout.c (make_command_window, make_source_window)
1840         (make_disasm_window, make_data_window)
1841         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1842         (reset_locator, show_source_or_disasm_and_command): Update.
1843         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1844         win_type parameter.
1845         (struct tui_source_window_base) <reset>: Likewise.
1846
1847 2019-07-17  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-layout.c (show_source_disasm_command): Use
1850         reset_locator.
1851         (reset_locator): New function.
1852         (init_and_make_win): Remove.
1853         (show_source_or_disasm_and_command): Use reset_locator.
1854
1855 2019-07-17  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1858         condition.
1859         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1860         Remove condition.
1861         * tui/tui-source.c (tui_source_window_base::reset): New method.
1862         * tui/tui-layout.c (make_command_window): Don't call
1863         init_and_make_win.
1864         (make_source_window, make_disasm_window): Don't call
1865         make_source_or_disasm_window.
1866         (make_data_window): Don't call init_and_make_win.  Change calling
1867         convention.
1868         (show_source_disasm_command, show_data): Simplify.
1869         (make_source_or_disasm_window): Remove.
1870         (show_source_or_disasm_and_command): Simplify.
1871         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1872         (struct tui_source_window_base) <reset>: Likewise.
1873         <execution_info>: Remove initializer.
1874         * tui/tui-data.c (tui_source_window_base): Initialize
1875         execution_info.
1876
1877 2019-07-17  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1880         variable.
1881
1882 2019-07-17  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui.c (tui_rl_other_window): Update.
1885         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1886         superclass method first.  Always iterate over regs_content.
1887         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1888         method.
1889         * tui/tui-win.c (tui_set_focus_command): Update.
1890
1891 2019-07-17  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-win.c (tui_set_focus_command): Rename from
1894         tui_set_focus.  Call tui_enable.
1895         (tui_set_focus_command): Remove.
1896
1897 2019-07-17  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1900         refresh_window.
1901         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1902         touchwin.
1903         (tui_data_window::refresh_window): Call refresh_window on data
1904         items.  Always call superclass refresh_window.
1905         (tui_win_info::refresh): Remove.
1906         (tui_source_window_base::refresh_window): Update.
1907         (tui_refresh_all): Update.
1908         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1909         refresh_window.
1910         (show_source_or_disasm_and_command): Likewise.
1911         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1912         (struct tui_source_window_base) <refresh>: Likewise.
1913
1914 2019-07-17  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-winsource.c (tui_clear_source_content)
1917         (tui_show_source_content): Update.
1918         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1919         whether content is empty.
1920         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1921         Remove.
1922
1923 2019-07-17  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1926         window's contents.
1927         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1928         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1933         (struct tui_data_item_window): Update.
1934
1935 2019-07-17  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1938         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1939         defines.
1940
1941 2019-07-17  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-winsource.h (tui_erase_source_content)
1944         (tui_clear_source_content): Remove "display_prompt" parameter.
1945         * tui/tui-winsource.c (tui_update_source_window_as_is)
1946         (tui_update_source_windows_with_addr): Update.
1947         (tui_clear_source_content): Remove "display_prompt" parameter.
1948         (tui_erase_source_content): Likewise.  Simplify.
1949         (tui_show_source_content): Update.
1950         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1951         * tui/tui-stack.c (tui_show_frame_info): Update.
1952         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1953         Remove defines.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1958         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1959         parameter.
1960         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1961         parameter.
1962
1963 2019-07-17  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-winsource.c (tui_clear_source_content)
1966         (tui_show_source_content, tui_show_exec_info_content)
1967         (tui_clear_exec_info_content): Update.
1968         * tui/tui-stack.c (tui_show_locator_content): Update.
1969         (tui_show_frame_info): Update.
1970         * tui/tui-source.h (tui_source_window): Don't declare.
1971         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1972         from tui_source_is_displayed.
1973         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1974         Remove field.
1975         (struct tui_source_window_base) <content_in_use>: New field.  Now
1976         bool.
1977         (struct tui_source_window) <showing_source_p>: New method.
1978         (TUI_SRC_WIN): Change cast.
1979         * tui/tui-data.c (tui_initialize_static_data): Update.
1980
1981 2019-07-17  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1984         location_matches_p.
1985         * tui/tui-source.c (tui_source_window::location_matches_p): New
1986         method.
1987         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1988         method.
1989         * tui/tui-data.h (struct tui_source_window_base)
1990         <location_matches_p>: New method.
1991         (struct tui_source_window, struct tui_disasm_window)
1992         <location_matches_p>: Likewise.
1993
1994 2019-07-17  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-win.c (tui_set_win_height_command): Rename from
1997         tui_set_win_height.
1998         (tui_set_win_height_command): Remove.
1999
2000 2019-07-17  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-source.c (tui_source_window): New constructor.  Add
2003         observer.
2004         (~tui_source_window): New destructor.
2005         (tui_source_window::style_changed): New method.
2006         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2007         (tui_attach_detach_observers): Update.
2008         * tui/tui-data.h (struct tui_source_window): Make constructor not
2009         inline.  Add destructor.
2010         (struct tui_source_window) <style_changed>: New method.
2011         <m_observable>: New member.
2012
2013 2019-07-17  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2016         * tui/tui-win.c (tui_resize_all): Fix typo.
2017
2018 2019-07-17  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2021         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2022         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2023         * tui/tui-win.c (window_name_completer): Use foreach.
2024         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2025         (update_tab_width): Likewise.
2026         * tui/tui-layout.c (show_layout): Update.
2027         * tui/tui-data.h (class tui_window_iterator): New.
2028         (struct all_tui_windows): New.
2029         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2030
2031 2019-07-17  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2034         parameter.  Don't reference globals.
2035         (tui_reg_command): Update.
2036
2037 2019-07-17  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-regs.c (tui_show_registers): Simplify.
2040
2041 2019-07-17  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-regs.c (tui_show_registers): Update.
2044         (tui_show_register_group): Add win_info parameter.
2045
2046 2019-07-17  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2049         Rename from tui_display_reg_element_at_line.
2050         (tui_data_window::display_registers_from_line): Update.
2051         * tui/tui-data.h (struct tui_data_window)
2052         <display_reg_element_at_line>: New method.
2053
2054 2019-07-17  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-regs.h (tui_display_registers_from)
2057         (tui_display_registers_from_line): Don't declare.
2058         * tui/tui-windata.c (tui_data_window::display_all_data)
2059         (tui_data_window::refresh_all)
2060         (tui_data_window::do_scroll_vertical): Update.
2061         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2062         from tui_display_registers_from.
2063         (tui_display_reg_element_at_line): Update.
2064         (tui_data_window::display_registers_from_line): Rename from
2065         tui_display_registers_from_line.
2066         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2067         display_registers_from_line>: New methods.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2072         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2073         from tui_erase_data_content.
2074         (tui_data_window::display_all_data)
2075         (tui_data_window::refresh_all)
2076         (tui_data_window::do_scroll_vertical): Update.
2077         * tui/tui-regs.c (tui_show_registers): Update.
2078         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2079         New method.
2080
2081 2019-07-17  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2084         declare.
2085         * tui/tui-windata.c
2086         (tui_data_window::delete_data_content_windows): Rename from
2087         tui_delete_data_content_windows.
2088         (tui_data_window::display_all_data)
2089         (tui_data_window::do_scroll_vertical): Update.
2090         * tui/tui-data.h (struct tui_data_window)
2091         <delete_data_content_windows>: New method.
2092
2093 2019-07-17  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2096         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2097
2098 2019-07-17  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2101         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2102         from tui_display_all_data.
2103         * tui/tui-win.c
2104         (tui_data_window::do_make_visible_with_new_height): Update.
2105         * tui/tui-regs.c (tui_show_registers): Update.
2106         * tui/tui-layout.c (tui_set_layout): Update.
2107         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2108         method.
2109
2110 2019-07-17  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2113         * tui/tui-windata.c (tui_display_data_from): Remove.
2114         (tui_data_window::refresh_all): Update.
2115
2116 2019-07-17  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2119         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2120         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2121         tui_display_registers_from_line.
2122         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2123         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2124         "force_display" parameter.
2125
2126 2019-07-17  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2129         declare.
2130         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2131         Rename from tui_first_reg_element_no_inline.
2132         (tui_display_reg_element_at_line)
2133         (tui_display_registers_from_line): Update.
2134         * tui/tui-data.h (struct tui_data_window)
2135         <first_reg_element_no_inline>: New method.
2136
2137 2019-07-17  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-windata.c (tui_display_data_from)
2140         (tui_data_window::do_scroll_vertical): Update.
2141         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2142         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2143         Rename from tui_line_from_reg_element_no.
2144         (tui_display_registers_from_line): Update.
2145         * tui/tui-data.h (struct tui_data_window)
2146         <line_from_reg_element_no>: New method.
2147
2148 2019-07-17  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2151         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2152         tui_last_regs_line_no.
2153         (tui_display_reg_element_at_line)
2154         (tui_display_registers_from_line): Update.
2155         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2156         method.
2157
2158 2019-07-17  Tom Tromey  <tom@tromey.com>
2159
2160         PR tui/24722:
2161         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2162         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2163         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2164         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2165         (tui_update_breakpoint_info): Likewise.
2166         * tui/tui-hooks.c (tui_event_create_breakpoint)
2167         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2168         Update.
2169
2170 2019-07-17  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2173
2174 2019-07-17  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-winsource.c (tui_update_source_window_as_is)
2177         (tui_update_source_windows_with_addr): Update.
2178         * tui/tui-source.h (tui_set_source_content)
2179         (tui_show_symtab_source): Add "win_info" parameter.
2180         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2181         parameter.
2182         (tui_show_symtab_source): Likewise.
2183
2184 2019-07-17  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-wingeneral.c
2187         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2188
2189 2019-07-17  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2192         (struct tui_cmd_window) <can_scroll>: New method.
2193         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2194         method.
2195
2196 2019-07-17  Tom Tromey  <tromey@adacore.com>
2197
2198         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2199         do_field_signed>: Rename.  Change type of "value".
2200         * ui-out.c (ui_out::field_signed): Rename from field_int.
2201         Change type of "value".
2202         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2203         type of "value".
2204         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2205         do_field_int.  Change type of "value".
2206         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2207         do_field_int.  Change type of "value".
2208         * tracepoint.c (trace_status_mi, tfind_1)
2209         (print_one_static_tracepoint_marker): Update.
2210         * thread.c (print_thread_info_1, print_selected_thread_frame):
2211         Update.
2212         * stack.c (print_frame, print_frame_info): Update.
2213         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2214         Update.
2215         * source.c (print_source_lines_base): Update.
2216         * skip.c (info_skip_command): Update.
2217         * record-btrace.c (btrace_ui_out_decode_error)
2218         (btrace_call_history_src_line): Update.
2219         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2220         Update.
2221         * progspace.c (print_program_space): Update.
2222         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2223         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2224         do_field_int.  Change type of "value".
2225         * mi/mi-out.c (mi_ui_out::do_table_begin)
2226         (mi_ui_out::do_table_header): Update.
2227         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2228         type of "value".
2229         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2230         (mi_cmd_data_list_changed_registers, output_register)
2231         (mi_cmd_data_read_memory, mi_load_progress)
2232         (mi_cmd_trace_frame_collected): Update.
2233         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2234         Update.
2235         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2236         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2237         (mi_cmd_var_list_children, varobj_update_one): Update.
2238         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2239         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2240         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2241         * inferior.c (print_inferior): Update.
2242         * gdb_bfd.c (print_one_bfd): Update.
2243         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2244         Update.
2245         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2246         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2247         do_field_int.  Change type of "value".
2248         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2249         do_field_int.  Change type of "value".
2250         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2251         (print_one_breakpoint_location, print_it_catch_fork)
2252         (print_one_catch_fork, print_it_catch_vfork)
2253         (print_one_catch_vfork, print_it_catch_solib)
2254         (print_it_catch_exec, print_it_ranged_breakpoint)
2255         (print_mention_watchpoint, print_mention_masked_watchpoint)
2256         (bkpt_print_it, update_static_tracepoint): Update.
2257         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2258         * break-catch-syscall.c (print_it_catch_syscall): Update.
2259         * ada-tasks.c (print_ada_task_info): Update.
2260         * ada-lang.c (print_it_exception, print_mention_exception):
2261         Update.
2262
2263 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2264
2265         PR breakpoints/24541
2266         * gdbarch.c: Regenerate.
2267         * gdbarch.h: Regenerate.
2268         * gdbarch.sh: Adjust return type and parameter types for
2269         'stap_adjust_register'.
2270         (i386_stap_adjust_register): Adjust signature and return new
2271         register name.
2272         * stap-probe.c (stap_parse_register_operand): Adjust use of
2273         'gdbarch_stap_adjust_register'.
2274
2275 2019-07-17  Tom Tromey  <tromey@adacore.com>
2276
2277         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2278         declare VEC.
2279         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2280         std::vector.
2281         (struct s390_process_info): Add initializers.
2282         (s390_add_process): Use new.
2283         (s390_linux_nat_target::low_forget_process): Use delete.
2284         (s390_linux_nat_target::low_new_fork)
2285         (s390_linux_nat_target::stopped_by_watchpoint)
2286         (s390_linux_nat_target::low_prepare_to_resume)
2287         (s390_linux_nat_target::insert_watchpoint)
2288         (s390_linux_nat_target::insert_hw_breakpoint)
2289         (s390_linux_nat_target::remove_watchpoint)
2290         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2291
2292 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2293
2294         * aarch64-fbsd-nat.c: Include regcache.h.
2295         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2296         argument.
2297         (aarch64_fbsd_nat_target::fetch_registers)
2298         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2299         variable.
2300         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2301
2302 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2303
2304         * fbsd-nat.c: Include gdbarch.h.
2305
2306 2019-07-15  Tom Tromey  <tromey@adacore.com>
2307
2308         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2309
2310 2019-07-15  Tom Tromey  <tromey@adacore.com>
2311
2312         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2313         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2314         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2315         * cli-out.c (cli_ui_out::do_field_int): New method.
2316         * ui-out.c (ui_out::field_unsigned): New method.
2317         * symfile.c (generic_load): Use field_unsigned.
2318         (print_transfer_performance): Likewise.
2319         * record-btrace.c (ui_out_field_uint): Remove.
2320         (btrace_call_history_insn_range, btrace_call_history): Use
2321         field_unsigned.
2322         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2323         field_unsigned.
2324         * ui-out.h (class ui_out) <field_unsigned>: New method.
2325         <do_field_unsigned>: Likewise.
2326
2327 2019-07-15  Tom Tromey  <tromey@adacore.com>
2328
2329         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2330         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2331         * target.c (flash_erase_command): Use field_string.
2332         * infrun.c (print_signal_received_reason): Use field_string.
2333         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2334         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2335         field_string.
2336         * ada-tasks.c (print_ada_task_info): Use field_string.
2337
2338 2019-07-15  Tom Tromey  <tromey@adacore.com>
2339
2340         * target.c (flash_erase_command): Use field_core_addr.
2341         * symfile.c (generic_load): Use field_core_addr.
2342         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2343         Use field_core_addr.
2344         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2345         field_core_addr.
2346
2347 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2350         value if its desired type is smaller than a CORE_ADDR and signed.
2351
2352 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2353
2354         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2355         of changes to field names, and use new is_reference field to
2356         decide if a property is a reference or not.
2357         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2358         field.
2359         (struct dwarf2_property_baton): Update header comment, rename
2360         'referenced_type' to 'property_type' and update comments.
2361         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2362         default property type, store in property baton, update to take
2363         accound of renamed field.
2364         (read_func_scope): Update call to attr_to_dynamic_prop.
2365         (read_array_type): Likewise.
2366         (dwarf2_per_cu_addr_sized_int_type): New function.
2367         (read_subrange_index_type): Move type finding code to
2368         dwarf2_per_cu_addr_sized_int_type.
2369         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2370         (dwarf2_per_cu_addr_type): New function.
2371         (set_die_type): Update calls to attr_to_dynamic_prop.
2372
2373 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2374
2375         * dwarf2read.c (read_subrange_index_type): New function.
2376         (read_subrange_type): Move code into new function and call it.
2377         * gdbtypes.c (create_range_type): Add some asserts.
2378
2379 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2380
2381         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2382         update return statements.
2383         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2384         declaration, and update comment to match.
2385         * gdbtypes.c (resolve_dynamic_array): Update call to
2386         dwarf2_evaluate_property to match new return type.
2387
2388 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * valarith.c (value_subscripted_rvalue): Change lowerbound
2391         parameter type from int to LONGEST.
2392         * value.h (value_subscripted_rvalue): Likewise in declaration.
2393
2394 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * cli/cli-utils.c (info_print_command_completer): New function.
2397         * cli/cli-utils.h: Add 'completer.h' include, and forward
2398         declaration for 'struct cmd_list_element'.
2399         (info_print_command_completer): Declare.
2400         * stack.c (_initialize_stack): Add completer for 'info locals' and
2401         'info args'.
2402         * symtab.c (_initialize_symtab): Add completer for 'info
2403         variables' and 'info functions'.
2404         * NEWS: Mention completion for additional info commands.
2405
2406 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * cli/cli-utils.c (extract_info_print_args): Delete.
2409         (extract_arg_maybe_quoted): Delete.
2410         (info_print_options_defs): New variable.
2411         (make_info_print_options_def_group): New function.
2412         (extract_info_print_options): Define new function.
2413         * cli/cli-utils.h (extract_info_print_args): Delete.
2414         (struct info_print_options): New structure.
2415         (extract_info_print_options): Declare new function.
2416         * stack.c (info_locals_command): Update to use new
2417         extract_info_print_options, also add a header comment.
2418         (info_args_command): Likewise.
2419         * symtab.c (info_variables_command): Likewise.
2420         (info_functions_command): Likewise.
2421
2422 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2423
2424         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2425         to extract string arguments.
2426         * common/common-utils.c (extract_string_maybe_quoted): New function.
2427         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2428
2429 2019-07-11  Tom Tromey  <tromey@adacore.com>
2430
2431         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2432         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2433         * top.h (gdbinit): Don't declare.
2434         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2435         into...
2436         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2437         * top.c (gdb_init): Don't call init_cli_cmds.
2438         (gdbinit): Remove.
2439         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2440
2441 2019-07-11  Tom Tromey  <tromey@adacore.com>
2442
2443         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2444         after it has been moved.
2445
2446 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2447
2448         * valops.c (value_must_coerce_to_target): Change return type to
2449         bool.
2450         * value.h (value_must_coerce_to_target): Likewise.
2451
2452 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2453
2454         * breakpoint.c (is_hardware_watchpoint): Remove
2455         forward-declaration.
2456         (is_masked_watchpoint): Change return type to bool.
2457         (is_tracepoint): Likewise.
2458         (is_breakpoint): Likewise.
2459         (is_hardware_watchpoint): Likewise.
2460         (is_watchpoint): Likewise.
2461         (is_no_memory_software_watchpoint): Likewise.
2462         (is_catchpoint): Likewise.
2463         (breakpoint_1): Make FILTER parameter's return type bool.
2464         is_masked_watchpoint): Change return type to bool.
2465         (save_breakpoints): Make FILTER parameter's return type bool.
2466         * breakpoint.h (is_breakpoint): Change return type to bool.
2467         (is_watchpoint): Likewise.
2468         (is_catchpoint): Likewise.
2469         (is_tracepoint): Likewise.
2470
2471 2019-07-10  Tom Tromey  <tom@tromey.com>
2472
2473         * defs.h: Don't include gdbarch.h.
2474         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2475         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2476         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2477         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2478         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2479         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2480         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2481         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2482         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2483         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2484         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2485         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2486         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2487         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2488         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2489         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2490         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2491         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2492         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2493         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2494         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2495         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2496         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2497         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2498         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2499         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2500         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2501
2502 2019-07-10  Tom Tromey  <tromey@adacore.com>
2503
2504         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2505         * breakpoint.c (init_ada_exception_breakpoint): Register as
2506         bp_catchpoint.
2507         (print_one_breakpoint_location, print_one_breakpoint): Use
2508         is_ada_exception_catchpoint.
2509         * ada-lang.c (class ada_catchpoint_location): Pass
2510         bp_loc_software_breakpoint to bp_location constructor.
2511         (is_ada_exception_catchpoint): New function.
2512
2513 2019-07-10  Tom Tromey  <tromey@adacore.com>
2514
2515         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2516         VEC.
2517         (struct arm_exidx_entry): New method operator<.
2518         (struct arm_exidx_data) <section_maps>: Change type.
2519         (arm_exidx_data_free): Remove.
2520         (arm_exidx_data_key): Change type.  Move lower.
2521         (arm_exidx_new_objfile): Update.
2522         (arm_compare_exidx_entries): Remove.
2523         (arm_find_exidx_entry, _initialize_arm_tdep)
2524
2525 2019-07-10  Tom Tromey  <tromey@adacore.com>
2526
2527         * solib-spu.c (ocl_program_data_key): Change type.
2528         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2529         Update.
2530
2531 2019-07-10  Tom Tromey  <tromey@adacore.com>
2532
2533         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2534         (struct solib_aix_inferior_data) <library_list>: Change type.
2535         (solib_aix_inferior_data_handle): Change type.
2536         (get_solib_aix_inferior_data): Update.
2537         (solib_aix_free_library_list): Remove.
2538         (library_list_start_library): Update.
2539         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2540         return type.
2541         (solib_aix_get_library_list)
2542         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2543         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2544
2545 2019-07-10  Tom Tromey  <tromey@adacore.com>
2546
2547         * solib-dsbt.c (struct dsbt_info): Add initializers.
2548         (solib_dsbt_pspace_data): Change type.
2549         (dsbt_pspace_data_cleanup): Remove.
2550         (get_dsbt_info, _initialize_dsbt_solib): Update.
2551
2552 2019-07-10  Tom Tromey  <tromey@adacore.com>
2553
2554         * spu-tdep.c (spu_overlay_data): Change type.
2555         (spu_get_overlay_table, spu_overlay_new_objfile)
2556         (_initialize_spu_tdep): Update.
2557
2558 2019-07-10  Tom Tromey  <tromey@adacore.com>
2559
2560         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2561         destructor.
2562         (dbx_objfile_data_key): Change type and declare later.
2563         (DBX_SYMFILE_INFO): Rewrite.
2564         * dbxread.c (dbx_objfile_data_key): Change type.
2565         (dbx_symfile_init): Update.
2566         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2567         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2568         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2569
2570 2019-07-10  Tom Tromey  <tromey@adacore.com>
2571
2572         * jit.c (jit_program_space_key): Change type.  Move lower.
2573         (get_jit_program_space_data): Update.
2574         (jit_program_space_data_cleanup): Remove.
2575         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2576         Update.
2577         (struct jit_program_space_data): Add initializers.
2578
2579 2019-07-10  Tom Tromey  <tromey@adacore.com>
2580
2581         * solib-darwin.c (struct darwin_info): Add initializers.
2582         (solib_darwin_pspace_data): Change type.
2583         (darwin_pspace_data_cleanup): Remove.
2584         (get_darwin_info, _initialize_darwin_solib): Update.
2585
2586 2019-07-10  Tom Tromey  <tromey@adacore.com>
2587
2588         * remote-sim.c (struct sim_inferior_data): Add initializers,
2589         constructor, and destructor.
2590         (sim_inferior_data_key): Change type.  Move lower.
2591         (check_for_duplicate_sim_descriptor): Update.
2592         (get_sim_inferior_data): Use new.  Update.
2593         (~sim_inferior_data_cleanup): Rename from
2594         sim_inferior_data_cleanup.  Simplify.
2595         (gdbsim_close_inferior, simulator_command)
2596         (sim_command_completer, _initialize_remote_sim): Update.
2597         (next_pid, INITIAL_PID): Move earlier.
2598
2599 2019-07-10  Tom Tromey  <tromey@adacore.com>
2600
2601         * python/python-internal.h (create_thread_object): Return
2602         gdbpy_ref.
2603         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2604         * python/py-inferior.c (struct threadlist_entry): Add
2605         constructor.
2606         <thread_obj>: Now a gdbpy_ref.
2607         (thread_to_thread_object): Update.
2608         (add_thread_object): Use new.
2609         (delete_thread_object): Use delete.
2610         (infpy_threads): Update.
2611         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2612         GIL.
2613
2614 2019-07-10  Tom Tromey  <tromey@adacore.com>
2615
2616         * valops.c (value_cast): Specialize error message for Ada.
2617
2618 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2619
2620         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2621
2622 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2623
2624         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2625         bpstat_should_step): Return bool, adjust comments.
2626         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2627         bpstat_should_step): Likewise.
2628
2629 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2630
2631         * features/Makefile: Use feature target descriptions for Arm.
2632         * features/arm/arm-core.c: Generate new file.
2633         * features/arm/arm-fpa.c: Likewise.
2634         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2635         * features/arm/arm-m-profile.c: Likewise.
2636         * features/arm/arm-vfpv2.c: Likewise.
2637         * features/arm/arm-vfpv3.c: Likewise.
2638         * features/arm/xscale-iwmmxt.c: Likewise.
2639         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2640
2641 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2642
2643         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2644         ptrace earlier.
2645
2646 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2647
2648         * features/aarch64-pauth.c: Regenerate.
2649
2650 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2651
2652         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2653         bool.
2654         (bpstat_what): Use false instead of 0.
2655
2656 2019-07-09  Pedro Alves  <palves@redhat.com>
2657
2658         * break-catch-throw.c (is_exception_catchpoint): New.
2659         * breakpoint.c (print_one_breakpoint_location): New parameter
2660         'raw_loc'.  Handle it.  Use
2661         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2662         looking at the breakpoint's type.
2663         (print_one_breakpoint): If handling "maint info breakpoints", also
2664         print locations of exception catchpoints.
2665         * breakpoint.h (is_exception_catchpoint): Declare.
2666
2667 2019-07-09  Pedro Alves  <palves@redhat.com>
2668
2669         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2670         "addr" field.
2671         (allocate_location_exception_catchpoint): New.
2672         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2673         (initialize_throw_catchpoint_ops): Install
2674         allocate_location_exception_catchpoint as allocate_location
2675         method.
2676         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2677         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2678         bp_loc_other.
2679         (breakpoint_address_is_meaningful): Delete.
2680         (bl_address_is_meaningful): New.
2681         (breakpoint_locations_match): Adjust comment.
2682         (bp_location_from_bp_type): New, factored out of...
2683         (bp_location::bp_location(breakpoint *)): ... this.
2684         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2685         factored out of...
2686         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2687         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2688         breakpoint_address_is_meaningful.
2689         (bp_locations_compare): Adjust comment.
2690         (update_global_location_list): Use bl_address_is_meaningful
2691         instead of breakpoint_address_is_meaningful.
2692         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2693         explicit.
2694         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2695         * python/py-breakpoint.c (bppy_get_location): No longer check
2696         whether location is null.
2697
2698 2019-07-09  Pedro Alves  <palves@redhat.com>
2699
2700         PR c++/15468
2701         * breakpoint.c (print_one_breakpoint_location): Remove
2702         single-location assert.
2703
2704 2019-07-09  Tom Tromey  <tom@tromey.com>
2705
2706         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2707         * configure: Rebuild.
2708         * configure.ac: Change common to gdbsupport.
2709         * gdbsupport: Rename from common.
2710         * acinclude.m4: Change common to gdbsupport.
2711         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2712         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2713         gdbsupport.
2714         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2715         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2716         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2717         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2718         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2719         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2720         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2721         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2722         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2723         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2724         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2725         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2726         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2727         coff-pe-read.c, command.h, compile/compile-c-support.c,
2728         compile/compile-c.h, compile/compile-cplus-symbols.c,
2729         compile/compile-cplus-types.c, compile/compile-cplus.h,
2730         compile/compile-loc2c.c, compile/compile.c, completer.c,
2731         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2732         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2733         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2734         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2735         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2736         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2737         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2738         features/aarch64-core.c, features/aarch64-fpu.c,
2739         features/aarch64-pauth.c, features/aarch64-sve.c,
2740         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2741         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2742         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2743         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2744         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2745         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2746         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2747         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2748         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2749         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2750         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2751         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2752         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2753         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2754         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2755         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2756         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2757         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2758         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2759         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2760         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2761         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2762         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2763         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2764         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2765         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2766         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2767         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2768         minsyms.c, mips-linux-tdep.c, namespace.h,
2769         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2770         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2771         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2772         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2773         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2774         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2775         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2776         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2777         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2778         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2779         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2780         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2781         procfs.c, producer.c, progspace.h, psymtab.h,
2782         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2783         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2784         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2785         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2786         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2787         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2788         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2789         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2790         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2791         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2792         target-memory.c, target.c, target.h, target/waitstatus.c,
2793         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2794         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2795         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2796         unittests/array-view-selftests.c,
2797         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2798         unittests/common-utils-selftests.c,
2799         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2800         unittests/format_pieces-selftests.c,
2801         unittests/function-view-selftests.c,
2802         unittests/lookup_name_info-selftests.c,
2803         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2804         unittests/mkdir-recursive-selftests.c,
2805         unittests/observable-selftests.c,
2806         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2807         unittests/parse-connection-spec-selftests.c,
2808         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2809         unittests/scoped_fd-selftests.c,
2810         unittests/scoped_mmap-selftests.c,
2811         unittests/scoped_restore-selftests.c,
2812         unittests/string_view-selftests.c, unittests/style-selftests.c,
2813         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2814         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2815         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2816         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2817         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2818         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2819
2820 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2823         bool value.
2824         (decode_digits_ordinary): Set explicit_line field in sal.
2825         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2826         symtab_and_line that was set on an explicit line number in
2827         assembler code.  Do always update the recorded symtab and line if
2828         we do skip the prologue.
2829
2830 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * breakpoint.c (set_breakpoint_location_function): Remove
2833         explicit_loc parameter.
2834         (momentary_breakpoint_from_master): Update call to
2835         set_breakpoint_location_function.
2836         (add_location_to_breakpoint): Likewise.
2837
2838 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2841         required features based on default bfd type when no specific bfd
2842         is present.
2843
2844 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2845
2846         * NEWS: Mention that GDB printf and eval commands can now print
2847         C-style and Ada-style convenience var strings without
2848         calling the inferior.
2849         * printcmd.c (printf_c_string): Locally print GDB internal var
2850         instead of transiting via the inferior.
2851         (printf_wide_c_string): Likewise.
2852
2853 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2854
2855         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2856
2857 2019-07-04  Tom Tromey  <tom@tromey.com>
2858
2859         PR tui/24724:
2860         * tui/tui-winsource.c (tui_clear_source_content): Update.
2861         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2862         (tui_update_breakpoint_info): Update.
2863         (tui_set_exec_info_content): Update.
2864         * tui/tui-source.c (tui_set_source_content_nil): Update.
2865         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2866         has_break.
2867         * tui/tui-data.h (enum tui_bp_flag): New.
2868         (tui_bp_flags): New enum flags type.
2869         (struct tui_source_element) <break_mode>: Change type.  Rename
2870         from has_break.
2871         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2872         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2873         constants.
2874         * tui/tui-winsource.h: Fix comment.
2875
2876 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2877
2878         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2879         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2880         (store_fpregs_to_thread)
2881         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2882         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2883         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2884         (IWMMXT_REGS_SIZE): Add define.
2885         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2886         (fetch_vfp_regs, store_vfp_regs)
2887         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2888         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2889
2890 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2891
2892         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2893         defines.
2894         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2895         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2896         (ARM_INT_REGISTER_SIZE): ...to this.
2897         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2898         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2899         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2900         (arm_linux_collect_gregset, supply_nwfpe_register)
2901         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2902         defines.
2903         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2904         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2905         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2906         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2907         (arm_return_in_memory, arm_store_return_value)
2908         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2909         (arm_record_ld_st_multiple): Likewise.
2910         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2911         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2912
2913 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2914
2915         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2916         AARCH64_DISPLACED_MODIFIED_INSNS.
2917         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2918         (aarch64_displaced_step_copy_insn): Likewise.
2919         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2920         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2921         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2922         ARM_DISPLACED_MODIFIED_INSNS.
2923         * arm-tdep.c (arm_gdbarch_init): Likewise.
2924         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2925         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2926         (struct arm_displaced_step_closure): Use
2927         ARM_DISPLACED_MODIFIED_INSNS.
2928
2929 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2930
2931         * features/Makefile: Remove unused xml files.
2932         * features/aarch64.xml: Remove.
2933         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2934         * features/i386/amd64-avx-avx512.xml: Remove.
2935         * features/i386/amd64-avx-linux.xml: Remove.
2936         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2937         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2938         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2939         * features/i386/amd64-avx-mpx.xml: Remove.
2940         * features/i386/amd64-avx.xml: Remove.
2941         * features/i386/amd64-linux.xml: Remove.
2942         * features/i386/amd64-mpx-linux.xml: Remove.
2943         * features/i386/amd64-mpx.xml: Remove.
2944         * features/i386/amd64.xml: Remove.
2945         * features/i386/i386-avx-avx512-linux.xml: Remove.
2946         * features/i386/i386-avx-avx512.xml: Remove.
2947         * features/i386/i386-avx-linux.xml: Remove.
2948         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2949         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2950         * features/i386/i386-avx-mpx-linux.xml: Remove.
2951         * features/i386/i386-avx-mpx.xml: Remove.
2952         * features/i386/i386-avx.xml: Remove.
2953         * features/i386/i386-linux.xml: Remove.
2954         * features/i386/i386-mmx-linux.xml: Remove.
2955         * features/i386/i386-mmx.xml: Remove.
2956         * features/i386/i386-mpx-linux.xml: Remove.
2957         * features/i386/i386-mpx.xml: Remove.
2958         * features/i386/i386.xml: Remove.
2959         * features/i386/x32-avx-avx512-linux.xml: Remove.
2960         * features/i386/x32-avx-linux.xml: Remove.
2961         * features/i386/x32-linux.xml: Remove.
2962
2963 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2964
2965         * regformats/aarch64.dat: Remove.
2966         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2967         * regformats/i386/amd64-avx-linux.dat: Remove.
2968         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2969         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2970         * regformats/i386/amd64-linux.dat: Remove.
2971         * regformats/i386/amd64-mpx-linux.dat: Remove.
2972         * regformats/i386/amd64.dat: Remove.
2973         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2974         * regformats/i386/i386-avx-linux.dat: Remove.
2975         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2976         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2977         * regformats/i386/i386-linux.dat: Remove.
2978         * regformats/i386/i386-mmx-linux.dat: Remove.
2979         * regformats/i386/i386-mpx-linux.dat: Remove.
2980         * regformats/i386/i386.dat: Remove.
2981         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2982         * regformats/i386/x32-avx-linux.dat: Remove.
2983         * regformats/i386/x32-linux.dat: Remove.
2984
2985 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2986
2987         * aarch64-tdep.c: Remove xml self tests.
2988         * amd64-linux-tdep.c: Likewise.
2989         * amd64-tdep.c: Likewise.
2990         * i386-linux-tdep.c: Likewise.
2991         * i386-tdep.c: Likewise.
2992
2993 2019-07-03  Pedro Alves  <palves@redhat.com>
2994
2995         PR cli/24732
2996         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2997         (pipe_cmd_option_defs): New.
2998         (make_pipe_cmd_options_def_group): New.
2999         (pipe_command): Use gdb::option::process_options.
3000         (pipe_command_completer): New function.
3001         (_initialize_cli_cmds): Install completer for "pipe" command.
3002
3003 2019-07-03  Pedro Alves  <palves@redhat.com>
3004
3005         * cli/cli-option.c (union option_value) <string>: New field.
3006         (struct option_def_and_value): Add ctor, move ctor, dtor and
3007         use DISABLE_COPY_AND_ASSIGN.
3008         (option_def_and_value::clear_value): New.
3009         (parse_option, save_option_value_in_ctx, get_val_type_str)
3010         (add_setshow_cmds_for_options): Handle var_string.
3011         * cli-option.h (union option_def::var_address) <string>: New
3012         field.
3013         (struct string_option_def): New.
3014         * maint-test-options.c (struct test_options_opts): Add default
3015         ctor and use DISABLE_COPY_AND_ASSIGN.
3016         <string_opt>: New field.
3017         (test_options_opts::~test_options_opts): New.
3018         (test_options_opts::dump): Also dump "-string".
3019         (test_options_option_defs): Install "string.
3020
3021 2019-07-03  Pedro Alves  <palves@redhat.com>
3022
3023         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3024         option_value with a null enumeration.
3025         (complete_options): Save the option values in the context.
3026         (save_option_value_in_ctx): New, factored out from ...
3027         (process_options): ... here.
3028         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3029         of the function.
3030         * maint-test-options.c (test_options_opts::dump): New, factored
3031         out from ...
3032         (maintenance_test_options_command_mode): ... here.
3033         (maintenance_test_options_command_completion_result): Delete.
3034         (maintenance_test_options_command_completion_text): Update
3035         comment.
3036         (maintenance_show_test_options_completion_result): Change
3037         prototype.  Just print
3038         maintenance_test_options_command_completion_text.
3039         (save_completion_result): New.
3040         (maintenance_test_options_completer_mode): Pass options context to
3041         complete_options, and then save a dump.
3042         (_initialize_maint_test_options): Use add_cmd to install "maint
3043         show test-options-completion-result".
3044
3045 2019-07-03  Pedro Alves  <palves@redhat.com>
3046
3047         * NEWS (New commands): Mention "with" and "maint with".
3048         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3049         (with_command, with_command_completer): New.
3050         (pipe_command): Adjust to new repeat_previous
3051         interface.
3052         (_initialize_cli_cmds): Install the "with" command and its "w"
3053         alias.
3054         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3055         declarations.
3056         * cli/cli-setshow.c (parse_cli_var_uinteger)
3057         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3058         argument strings for all var_types.
3059         (get_setshow_command_value_string): New, factored out from ...
3060         (do_show_command): ... this.
3061         * cli/cli-setshow.h: Include <string>.
3062         (get_setshow_command_value_string): Declare.
3063         * command.h (repeat_previous): Now returns const char *.  Adjust
3064         comment.
3065         * maint.c: Include "cli/cli-cmds.h".
3066         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3067         (_initialize_maint_cmds): Register the "maintenance with" command.
3068         * top.c (repeat_previous): Move bits from pipe_command here:
3069         Return the saved command line, if any; error out if there's no
3070         command to relaunch.
3071
3072 2019-07-03  Pedro Alves  <palves@redhat.com>
3073
3074         * NEWS (New commands): Mention "maint set/show test-settings"
3075         instead of "maint test-settings".
3076         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3077         (maintenance_test_settings_set_list): Rename to ...
3078         (maintenance_set_test_settings_list): ... this.
3079         (maintenance_test_settings_show_list): Rename to  ...
3080         (maintenance_show_test_settings_list): ... this.
3081         (maintenance_test_settings_cmd): Delete.
3082         (maintenance_test_settings_set_cmd): ...
3083         (maintenance_set_test_settings_cmd): ... this.
3084         (maintenance_test_settings_show_cmd): ...
3085         (maintenance_show_test_settings_cmd): ... this.
3086         (maintenance_test_settings_show_value_cmd):
3087         (maintenance_show_test_settings_value_cmd): ... this.
3088         (_initialize_maint_test_settings): No longer install the "maint
3089         test-settings" prefix command.  Rename "maint test-settings set"
3090         to "maint set test-settings", and "maint test-settings show" to
3091         "maint show test-settings".  Adjust all subcommands.
3092
3093 2019-07-03  Pedro Alves  <palves@redhat.com>
3094
3095         * maint-test-settings.c: Fix file's intro comment.  Replace all
3096         references to "test-options" with references to "test-settings",
3097         in comments.
3098
3099 2019-07-03  Pedro Alves  <palves@redhat.com>
3100
3101         * maint-test-settings.c (maintenance_test_settings_xxx)
3102         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3103         New.
3104         (maintenance_test_settings_enums): Use them.
3105         (maintenance_test_settings_enum): Default to
3106         maintenance_test_settings_xxx.
3107         (_initialize_maint_test_settings): Initialize
3108         MAINTENANCE_TEST_SETTINGS_FILENAME.
3109
3110 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3111
3112         * breakpoint.h (remove_breakpoints_inf): Change return type to
3113         void, move function documentation here.
3114         * breakpoint.c (remove_breakpoints_inf): Change return type to
3115         void, move function documentation to header.
3116
3117 2019-07-02  Pedro Alves  <palves@redhat.com>
3118
3119         * NEWS (Completion improvements): Mention "info threads".
3120         * thread.c (struct info_threads_opts, info_threads_option_defs)
3121         (make_info_threads_options_def_group): New.
3122         (info_threads_command): Use gdb::option::process_options.
3123         (info_threads_command_completer): New.
3124         (_initialize_thread): Use gdb::option::build_help to build the
3125         help text for "info threads".
3126
3127 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3128
3129         * defs.h (generic_load): Move from here...
3130         * symfile.h (generic_load): ... to here.  Rename name parameter
3131         to args.
3132         * symfile.c (generic_load): Add comment.
3133
3134 2019-07-01  Tom Tromey  <tromey@adacore.com>
3135
3136         * dwarf2read.c
3137         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3138         declaration of without_params.  Fix formatting.
3139
3140 2019-07-01  Tom Tromey  <tromey@adacore.com>
3141
3142         * ada-exp.y (find_primitive_type): Update.
3143         * ada-lang.h (ada_lookup_symbol): Update.
3144         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3145         parameter.
3146         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3147
3148 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3149
3150         PR breakpoints/24541
3151         * gdbarch.c: Regenerate.
3152         * gdbarch.h: Regenerate.
3153         * gdbarch.sh: Add 'stap_adjust_register'.
3154         * i386-tdep.c: Include '<unordered_set>'.
3155         (i386_stap_adjust_register): New function.
3156         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3157         * stap-probe.c (stap_parse_register_operand): Call
3158         'gdbarch_stap_adjust_register'.
3159
3160 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3161
3162         PR python/24742
3163         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3164         * python/python.c (do_start_initialization): Use 'xmalloc'
3165         instead of 'PyMem_Malloc'.
3166
3167 2019-06-28  Tom Tromey  <tromey@adacore.com>
3168
3169         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3170         for Ada.
3171
3172 2019-06-27  Tom Tromey  <tromey@adacore.com>
3173
3174         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3175         objfile_key.
3176         (arm_find_mapping_symbol, arm_record_special_symbol)
3177         (_initialize_arm_tdep): Update.
3178         (arm_objfile_data_free): Remove.
3179
3180 2019-06-27  Tom Tromey  <tromey@adacore.com>
3181
3182         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3183         to cp_print_static_field.
3184
3185 2019-06-26  Tom Tromey  <tromey@adacore.com>
3186
3187         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3188         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3189         declare.
3190
3191 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3192
3193         * features/aarch64-core.c (create_feature_aarch64_core):
3194         Regenerate.
3195         * features/aarch64-core.xml: Add cpsr flags.
3196
3197 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3198
3199         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3200         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3201
3202 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3203
3204         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3205         field.
3206         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3207         use.
3208         (arm_record_special_symbol): Don't insert new symbol in sorted
3209         position, push it at the end.
3210
3211 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3212
3213         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3214         (arm_mapping_symbol_s): Remove.
3215         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3216         (arm_mapping_symbol_vec): New typedef.
3217         (struct arm_per_objfile): Add constructor.
3218         <section_maps>: Change type to
3219         std::unique_ptr<arm_mapping_symbol_vec[]>.
3220         (arm_compare_mapping_symbols): Remove.
3221         (arm_find_mapping_symbol): Adjust to section_maps type change.
3222         (arm_objfile_data_free): Call delete on arm_per_objfile.
3223         (arm_record_special_symbol): Adjust to section_maps type change.
3224         Allocate arm_per_objfile with new.
3225
3226 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3227
3228         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3229         with the command prefix.
3230
3231 2019-06-25  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3234         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3235
3236 2019-06-25  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3239         type.
3240         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3241         protected.
3242
3243 2019-06-25  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-winsource.c
3246         (tui_source_window_base::set_is_exec_point_at): Add check against
3247         LOA_ADDRESS.
3248
3249 2019-06-25  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-source.c (tui_set_source_content): Don't check before
3252         xfree.
3253         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3254
3255 2019-06-25  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-winsource.h (tui_update_source_window_as_is)
3258         (tui_alloc_source_buffer, tui_line_is_displayed)
3259         (tui_addr_is_displayed): Change type of win_info.
3260         * tui/tui-winsource.c (tui_update_source_window_as_is)
3261         (tui_clear_source_content, tui_show_source_line)
3262         (tui_show_source_content, tui_source_window_base::refill)
3263         (tui_source_window_base::set_is_exec_point_at)
3264         (tui_source_window_base::set_is_exec_point_at)
3265         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3266         (tui_alloc_source_buffer, tui_line_is_displayed)
3267         (tui_addr_is_displayed): Change type of win_info.  Update.
3268         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3269         (tui_source_window_base::do_make_visible_with_new_height):
3270         Update.
3271         * tui/tui-source.c (tui_set_source_content)
3272         (tui_set_source_content_nil)
3273         (tui_source_window::do_scroll_vertical): Update.
3274         * tui/tui-layout.c (show_layout): Update.
3275         * tui/tui-disasm.c (tui_set_disassem_content)
3276         (tui_disasm_window::do_scroll_vertical): Update.
3277         * tui/tui-data.h (tui_win_content): Remove.
3278         (struct tui_gen_win_info) <content, content_size>: Remove.
3279         (struct tui_source_element): Add initializers and destructor.
3280         (union tui_which_element, struct tui_win_element): Remove.
3281         (struct tui_source_window_base) <content>: New field.
3282         (struct tui_data_window): Remove destructor.
3283         (tui_alloc_content, tui_free_win_content)
3284         (tui_free_all_source_wins_content): Don't declare.
3285         * tui/tui-data.c (tui_initialize_static_data): Update.
3286         (init_content_element, tui_alloc_content): Remove.
3287         (~tui_gen_win_info): Update.
3288         (~tui_data_window, tui_free_all_source_wins_content)
3289         (tui_free_win_content, free_content, free_content_elements):
3290         Remove.
3291
3292 2019-06-25  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-winsource.h (tui_clear_source_content)
3295         (tui_erase_source_content, tui_show_source_content): Change type
3296         of win_info.
3297         * tui/tui-winsource.c (tui_clear_source_content)
3298         (tui_erase_source_content, tui_show_source_content): Change type
3299         of win_info.
3300         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3301         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3302         win_info.
3303         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3304         win_info.
3305         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3306
3307 2019-06-25  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-winsource.c (tui_clear_source_content)
3310         (tui_source_window_base::set_is_exec_point_at): Update.
3311         * tui/tui-source.c (tui_set_source_content_nil): Update.
3312         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3313         a bool.
3314         * tui/tui-data.c (init_content_element): Update.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3319         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3320         * tui/tui-layout.c (init_and_make_win): Update.
3321         * tui/tui.h (enum tui_win_type): Update.
3322         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3323         tui_win_is_auxillary.
3324         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3325         tui_win_is_auxillary.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3330         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3331         (tui_delete_data_content_windows, tui_display_all_data)
3332         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3333         Update.
3334         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3335         * tui/tui-regs.c (tui_last_regs_line_no)
3336         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3337         (tui_show_registers): Update.
3338         (tui_show_register_group): Return void.  Update.
3339         (tui_display_registers_from, tui_display_reg_element_at_line)
3340         (tui_display_registers_from_line, tui_check_register_values):
3341         Update.
3342         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3343         member.
3344         (struct tui_data_window) <regs_content>: Now a std::vector.
3345         <regs_content_count>: Remove.
3346         (tui_add_content_elements, tui_free_data_content): Don't declare.
3347         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3348         (init_content_element): Remove DATA_WIN case.  Add assert.
3349         (tui_add_content_elements): Remove.
3350         (tui_data_window): Update.
3351         (tui_free_data_content): Remove.
3352         (free_content_elements): Remove DATA_WIN case.
3353
3354 2019-06-25  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-data.c (tui_data_item_window): Update.
3357         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3358         * tui/tui-windata.c (tui_display_all_data)
3359         (tui_display_data_from_line): Update.
3360         (tui_check_data_values): Remove.
3361         * tui/tui-regs.c (tui_show_register_group)
3362         (tui_display_reg_element_at_line): Update.
3363         * tui/tui-hooks.c (tui_register_changed)
3364         (tui_refresh_frame_and_register_information): Call
3365         tui_check_register_values.
3366         * tui/tui-data.h (struct tui_data_window) <data_content,
3367         data_content_count, data_type>: Remove.
3368         (enum tui_data_type): Remove.
3369
3370         * tui/tui-data.c (tui_data_window::clear_detail)
3371         (~tui_data_window): Update.
3372
3373 2019-06-25  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3376         declare.
3377         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3378         Rename from tui_first_data_item_displayed.  Update.
3379         (tui_data_window::refresh_all)
3380         (tui_data_window::do_scroll_vertical): Update.
3381         * tui/tui-data.h (struct tui_data_window)
3382         <first_data_item_displayed>: Declare new method.
3383
3384 2019-06-25  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3387         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3388         contents...
3389         (tui_initialize_static_data): ...here.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3394         (tui_display_registers_from, tui_check_register_values): Update.
3395         (tui_display_register): Remove win_info parameter; update.
3396         (tui_get_register): Change type of parameters.
3397         * tui/tui-data.h (struct tui_data_element): Remove.
3398         (union tui_which_element) <data>: Remove.
3399         <data_window>: Change type.
3400         (struct tui_data_item_window): New.
3401         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3402         case.  Add assert.
3403         (~tui_data_item_window): New destructor.
3404         (free_content_elements): Remove DATA_ITEM_WIN case.
3405
3406 2019-06-25  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3409         Remove.
3410
3411 2019-06-25  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-data.h (struct tui_command_element): Remove.
3414         (union tui_which_element) <command>: Remove.
3415         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3416         assert.
3417         (free_content_elements): Remove CMD_WIN case.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-layout.c (tui_set_layout): Update.
3422         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3423         * tui/tui-data.c (layout_def): Update.
3424
3425 2019-06-25  Tom Tromey  <tom@tromey.com>
3426
3427         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3428         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3429         (tui_source_window_base::set_new_height): Update.
3430         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3431         Update.
3432         (tui_set_locator_fullname, tui_set_locator_info)
3433         (tui_show_frame_info): Update.
3434         * tui/tui-source.c (tui_set_source_content)
3435         (tui_source_is_displayed): Update.
3436         * tui/tui-layout.c (show_source_disasm_command, show_data)
3437         (show_source_or_disasm_and_command): Update.
3438         * tui/tui-disasm.c (tui_set_disassem_content)
3439         (tui_get_begin_asm_address): Update.
3440         * tui/tui-data.h (struct tui_locator_element): Remove.
3441         (union tui_which_element) <locator>: Remove.
3442         (struct tui_locator_window): New.
3443         (tui_locator_win_info_ptr): Change return type.
3444         * tui/tui-data.c (_locator): Change type.
3445         (tui_locator_win_info_ptr): Change return type.
3446         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3447         (tui_alloc_content): Add assert.
3448
3449 2019-06-25  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-winsource.c
3452         (tui_exec_info_window::maybe_allocate_content): New method.
3453         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3454         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3455         (make_source_or_disasm_window): Add cast.
3456         * tui/tui-data.h (union tui_which_element) <simple_string>:
3457         Remove.
3458         (struct tui_source_info): New.
3459         (struct tui_source_window_base) <execution_info>: Change type.
3460         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3461         case, and add assert.
3462         (tui_alloc_content): Add assert.
3463
3464 2019-06-25  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3467         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3468         * tui/tui-data.c (tui_alloc_win_info): Remove.
3469
3470 2019-06-25  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3473         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3474         can_highlight.
3475
3476 2019-06-25  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3479         make_visible_with_new_height method.
3480         (tui_win_info::make_visible_with_new_height): New method.
3481         (tui_source_window_base::do_make_visible_with_new_height)
3482         (tui_data_window::do_make_visible_with_new_height)
3483         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3484         (make_visible_with_new_height): Remove.
3485         (tui_resize_all, tui_adjust_win_heights): Use
3486         make_visible_with_new_height method.
3487         * tui/tui-data.h (struct tui_win_info)
3488         <do_make_visible_with_new_height, make_visible_with_new_height>:
3489         New methods.
3490         (struct tui_source_window_base, struct tui_data_window)
3491         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3492         methods.
3493
3494 2019-06-25  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3497         method.
3498         (update_tab_width): Call update_tab_width method.
3499         * tui/tui-data.h (struct tui_win_info)
3500         (struct tui_source_window_base) <update_tab_width>: New methods.
3501
3502 2019-06-25  Tom Tromey  <tom@tromey.com>
3503
3504         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3505         parameter.
3506         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3507         parameter.
3508         (tui_gen_win_info::make_visible): Update.
3509         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3510         parameter.
3511         * tui/tui-data.h (enum tui_box): New enum.
3512         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3517         init_and_make_win for EXEC_INFO_WIN.
3518         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3519         longer inline.
3520         (struct tui_win_info) <~tui_win_info>: Inline.
3521         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3522         Don't declare.
3523         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3524         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3525         Remove.
3526         (tui_initialize_static_data): Update.
3527         (~tui_gen_win_info): Handle more cleanup here.
3528         (~tui_source_window_base): Delete "execution_info".
3529         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-layout.c (make_command_window): Don't set
3534         can_highlight.
3535         (show_source_disasm_command): Call the reset method.
3536         (show_data): Don't set can_highlight.  Call the reset method.
3537         (tui_gen_win_info::reset): Rename from init_gen_win_info
3538         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3539         (show_source_or_disasm_and_command): Call the reset method.
3540         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3541         (struct tui_cmd_window): Set can_highlight.
3542
3543 2019-06-25  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3546         from make_visible.
3547         (tui_make_visible, tui_make_invisible): Rewrite.
3548         (tui_win_info::make_visible): Remove.
3549         (tui_source_window_base::make_visible): Update.
3550         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3551         method.  Moved from...
3552         (struct tui_win_info) <make_visible>: ...here.
3553
3554 2019-06-25  Tom Tromey  <tom@tromey.com>
3555
3556         * tui/tui-winsource.c
3557         (tui_source_window_base::do_scroll_horizontal): Remove direction
3558         parameter.
3559         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3560         direction parameter.
3561         * tui/tui-win.c (tui_win_info::forward_scroll)
3562         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3563         (tui_win_info::right_scroll): Update.
3564         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3565         direction parameter.
3566         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3567         direction parameter.
3568         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3569         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3570         Remove direction parameter.
3571         (struct tui_source_window_base, struct tui_source_window)
3572         (struct tui_disasm_window, struct tui_data_window)
3573         (struct tui_cmd_window): Update.
3574
3575 2019-06-25  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-winsource.h (tui_set_exec_info_content)
3578         (tui_show_exec_info_content, tui_erase_exec_info_content)
3579         (tui_clear_exec_info_content, tui_update_exec_info): Change
3580         argument to tui_source_window_base.
3581         * tui/tui-winsource.c (tui_set_exec_info_content)
3582         (tui_show_exec_info_content, tui_erase_exec_info_content)
3583         (tui_clear_exec_info_content, tui_update_exec_info): Change
3584         argument to tui_source_window_base.
3585
3586 2019-06-25  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3589         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3590
3591 2019-06-25  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3594         check.
3595
3596 2019-06-25  Tom Tromey  <tom@tromey.com>
3597
3598         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3599         type to void.
3600         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3601         type to void.
3602         * tui/tui-source.c (tui_set_source_content): Update.
3603         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3604
3605 2019-06-25  Tom Tromey  <tom@tromey.com>
3606
3607         * tui/tui-win.c (window_name_completer, tui_set_focus)
3608         (tui_all_windows_info): Use name method.
3609         * tui/tui-data.h (struct tui_gen_win_info)
3610         (struct tui_source_window, struct tui_disasm_window)
3611         (struct tui_data_window, struct tui_cmd_window) <name>: New
3612         method.
3613         (tui_win_name): Don't declare.
3614         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3615         (tui_win_name): Remove.
3616
3617 2019-06-25  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-winsource.h (tui_update_source_window)
3620         (tui_update_source_window_as_is): Change parameter type.
3621         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3622         to be a tui_source_window_base.
3623         (tui_update_source_window_as_is): Likewise.
3624         * tui/tui-win.c (make_visible_with_new_height): Update.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-winsource.c (tui_erase_source_content)
3629         (tui_show_source_content, tui_show_exec_info_content)
3630         (tui_erase_exec_info_content): Use refresh_window method.
3631         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3632         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3633         from tui_refresh_win.
3634         (tui_data_window::refresh_window): New method.
3635         (tui_win_info::refresh, tui_source_window_base::refresh)
3636         (tui_refresh_all): Use refresh_window method.
3637         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3638         method.
3639         * tui/tui-regs.c (tui_display_register): Call refresh_window
3640         method.
3641         * tui/tui-layout.c (show_source_disasm_command)
3642         (show_source_or_disasm_and_command): Call refresh_window method.
3643         * tui/tui-data.h (struct tui_gen_win_info)
3644         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3645         New method.
3646
3647 2019-06-25  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui.c (tui_rl_other_window, tui_enable)
3650         (tui_is_window_visible, tui_get_command_dimension): Update.
3651         * tui/tui-winsource.c (tui_update_source_window_as_is)
3652         (tui_clear_source_content, tui_erase_source_content)
3653         (tui_show_source_line, tui_source_window_base::refill)
3654         (tui_source_window_base::do_scroll_horizontal)
3655         (tui_source_window_base::set_is_exec_point_at)
3656         (tui_update_breakpoint_info, tui_set_exec_info_content)
3657         (tui_alloc_source_buffer, tui_line_is_displayed)
3658         (tui_addr_is_displayed): Update.
3659         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3660         (tui_check_and_display_highlight_if_needed)
3661         (tui_win_info::make_visible, tui_win_info::refresh)
3662         (tui_refresh_all): Update.
3663         * tui/tui-windata.c (tui_first_data_item_displayed)
3664         (tui_delete_data_content_windows, tui_erase_data_content)
3665         (tui_display_all_data, tui_data_window::refresh_all)
3666         (tui_check_data_values): Update.
3667         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3668         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3669         (tui_win_info::backward_scroll, tui_refresh_all_win)
3670         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3671         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3672         (tui_source_window_base::set_new_height)
3673         (tui_data_window::set_new_height)
3674         (make_invisible_and_set_new_height)
3675         (make_visible_with_new_height, new_height_ok)
3676         (parse_scrolling_args): Update.
3677         * tui/tui-stack.c (tui_show_frame_info): Update.
3678         * tui/tui-source.c (tui_set_source_content)
3679         (tui_set_source_content_nil, tui_source_is_displayed)
3680         (tui_source_window::do_scroll_vertical): Update.
3681         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3682         (tui_display_registers_from, tui_display_reg_element_at_line)
3683         (tui_check_register_values, tui_reg_command): Update.
3684         * tui/tui-layout.c (tui_default_win_height)
3685         (show_source_disasm_command, show_data, init_and_make_win)
3686         (show_source_or_disasm_and_command): Update.
3687         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3688         (tui_redisplay_readline, tui_mld_flush)
3689         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3690         (tui_getc): Update.
3691         * tui/tui-disasm.c (tui_set_disassem_content)
3692         (tui_disasm_window::do_scroll_vertical): Update.
3693         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3694         Now virtual.
3695         (struct tui_win_info): Derive from tui_gen_win_info.
3696         <~tui_win_info>: Mark as override.
3697         <generic>: Remove member.
3698         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3699         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3700         (~tui_data_window, ~tui_win_info)
3701         (tui_free_all_source_wins_content): Update.
3702         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3703
3704 2019-06-25  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-layout.c (init_and_make_win): Use new.
3707         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3708         destructor, initializers.
3709         (tui_alloc_generic_win_info): Don't declare.
3710         * tui/tui-data.c (_locator): Add argument to constructor.
3711         (source_win, disasm_win): New globals.
3712         (exec_info): Remove.
3713         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3714         Update.
3715         (tui_alloc_generic_win_info): Remove.
3716         (init_content_element): Use new.
3717         (tui_win_info::tui_win_info): Update.
3718         (free_content_elements) <case DATA_WIN>: Use delete.
3719
3720 2019-06-25  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3723         * tui/tui-windata.c (tui_first_data_item_displayed)
3724         (tui_delete_data_content_windows): Update.
3725         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3726         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3727         (tui_display_registers_from, tui_check_register_values): Update.
3728         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3729         pointer.
3730         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3731         window.
3732         (tui_free_data_content): Update.
3733         (free_content_elements) <case DATA_WIN>: Free the window.
3734
3735 2019-06-25  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3738         Update.
3739         * tui/tui-layout.c (make_command_window)
3740         (show_source_disasm_command, show_data, init_and_make_win)
3741         (show_source_or_disasm_and_command): Update.
3742         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3743         method.
3744         <can_highight, is_highlighted>: Now bool.
3745         (tui_set_win_highlight): Don't declare.
3746         * tui/tui-data.c (tui_set_win_highlight): Remove.
3747
3748 2019-06-25  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui-wingeneral.c (make_visible): Remove check of window
3751         type.
3752
3753 2019-06-25  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-win.c (tui_win_info::max_height)
3756         (tui_cmd_window::max_height): New methods.
3757         (new_height_ok): Call max_height.
3758         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3759         <max_height>: New method.
3760
3761 2019-06-25  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui-win.c (tui_source_window_base::set_new_height)
3764         (tui_data_window::set_new_height): New methods.
3765         (make_invisible_and_set_new_height): Call set_new_height method.
3766         * tui/tui-data.h (struct tui_win_info)
3767         (struct tui_source_window_base, struct tui_data_window)
3768         <set_new_height>: New method.
3769
3770 2019-06-25  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3773         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3774         tui_refresh_data_win.
3775         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3776         method.
3777         (tui_refresh_all_win): Call the refresh_all method.
3778         (tui_set_focus): Likewise.
3779         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3780         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3781         Likewise.
3782
3783 2019-06-25  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-winsource.h (tui_refill_source_window)
3786         (tui_set_is_exec_point_at): Don't declare.
3787         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3788         (tui_source_window_base::refill): Rename from
3789         tui_refill_source_window.
3790         (tui_source_window_base::do_scroll_horizontal): Update.
3791         (tui_source_window_base::set_is_exec_point_at): Rename from
3792         tui_set_is_exec_point_at.
3793         (tui_update_all_breakpoint_info): Update.
3794         * tui/tui-stack.c (tui_show_frame_info): Update.
3795         * tui/tui-layout.c (show_data): Add cast.
3796         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3797         * tui/tui-data.h (struct tui_source_window_base) <refill,
3798         set_is_exec_point_at>: New methods.
3799         (tui_source_windows, tui_add_to_source_windows): Update types.
3800         (tui_add_to_source_windows): Remove redundant declaration.
3801         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3802         (tui_source_windows): Change return type.
3803         (tui_clear_source_windows_detail): Update.
3804         (tui_add_to_source_windows): Change type of parameter.
3805         (tui_free_all_source_wins_content): Update.
3806
3807 2019-06-25  Tom Tromey  <tom@tromey.com>
3808
3809         * tui/tui-wingeneral.c (tui_win_info::refresh)
3810         (tui_source_window_base::refresh): New methods.
3811         (tui_refresh_all): Call the refresh method.
3812         * tui/tui-data.h (struct tui_win_info)
3813         (struct tui_source_window_base) <refresh>: New method.
3814
3815 2019-06-25  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui.h (tui_is_window_visible): Return bool.
3818         * tui/tui.c (tui_is_window_visible): Return bool.
3819         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3820         (tui_make_visible, tui_make_invisible)
3821         (tui_win_info::make_visible)
3822         (tui_source_window_base::make_visible, make_all_visible)
3823         (tui_make_all_visible, tui_make_all_invisible): Update.
3824         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3825         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3826         bool.
3827         (struct tui_win_info, struct tui_source_window_base)
3828         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3829         * tui/tui-data.c (tui_init_generic_part): Update.
3830
3831 2019-06-25  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3834         (tui_source_window_base::make_visible): New methods.
3835         (make_all_visible): Make method call.
3836         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3837         (struct tui_source_window_base, struct tui_cmd_window): Override
3838         make_visible.
3839         (tui_win_is_source_type): Don't declare.
3840         * tui/tui-data.c (tui_win_is_source_type): Remove.
3841
3842 2019-06-25  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3845         NULL check.
3846
3847 2019-06-25  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3850         Inline constructor.  Add initializers for members.
3851         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3852         constructors; now inline in class.
3853
3854 2019-06-25  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-regs.c (tui_show_registers): Update.
3857         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3858         bool.
3859         * tui/tui-data.c (tui_data_window::clear_detail)
3860         (tui_data_window): Update.
3861
3862 2019-06-25  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui-windata.c (tui_display_all_data)
3865         (tui_display_data_from_line, tui_display_data_from)
3866         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3867         Update.
3868         * tui/tui-regs.c (tui_last_regs_line_no)
3869         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3870         (tui_show_registers, tui_show_register_group)
3871         (tui_display_registers_from, tui_display_reg_element_at_line)
3872         (tui_display_registers_from_line, tui_check_register_values)
3873         (tui_reg_next, tui_reg_prev): Update.
3874         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3875         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3876         tui_data_window.
3877         (struct tui_win_info) <detail>: Remove.  Add new fields from
3878         tui_data_info.
3879         (TUI_DATA_WIN): Add cast.
3880         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3881         (~tui_data_window): Simplify.
3882
3883 2019-06-25  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-layout.c (show_source_disasm_command)
3886         (show_source_or_disasm_and_command): Update.
3887         * tui/tui-io.c (update_cmdwin_start_line)
3888         (tui_redisplay_readline): Update.
3889         * tui/tui-data.h (struct tui_command_info): Remove.
3890         (struct tui_win_info) <detail>: Remove command_info member.
3891         (struct tui_data_window) <start_line>: New member, from
3892         tui_command_info.
3893         (TUI_CMD_WIN): Add casts.
3894
3895 2019-06-25  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-winsource.c (tui_update_source_window)
3898         (tui_refill_source_window)
3899         (tui_source_window_base::do_scroll_horizontal)
3900         (tui_update_breakpoint_info, tui_set_exec_info_content)
3901         (tui_show_exec_info_content, tui_erase_exec_info_content)
3902         (tui_clear_exec_info_content): Update.
3903         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3904         Update.
3905         * tui/tui-win.c (make_invisible_and_set_new_height)
3906         (make_visible_with_new_height): Update.
3907         * tui/tui-source.c (tui_set_source_content)
3908         (tui_show_symtab_source): Update.
3909         * tui/tui-layout.c (extract_display_start_addr)
3910         (show_source_disasm_command, show_data)
3911         (make_source_or_disasm_window)
3912         (show_source_or_disasm_and_command): Update.
3913         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3914         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3915         "gdbarch".
3916         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3917         to tui_source_window_base.
3918         (struct tui_win_info) <detail>: Remove source_info member.
3919         (struct tui_source_window_base) <has_locator>: Inline.
3920         Move contents from tui_source_info; rename has_locator member to
3921         m_has_locator.
3922         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3923         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3924         header file.
3925         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3926         Simplify.
3927         (tui_free_all_source_wins_content): Cast to
3928         tui_source_window_base.
3929
3930 2019-06-25  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-win.c (make_invisible_and_set_new_height)
3933         (make_visible_with_new_height): Call has_locator method.
3934         * tui/tui-layout.c (show_source_disasm_command, show_data)
3935         (show_source_or_disasm_and_command): Update for bool change.
3936         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3937         (tui_win_info) <has_locator>: New method.
3938         (struct tui_source_window_base) <has_locator>: New method.
3939         (tui_win_has_locator): Don't declare.
3940         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3941         from tui_win_has_locator.
3942         (tui_source_window_base): Use false, not FALSE.
3943
3944 2019-06-25  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3947         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3948         clear_detail method directly.
3949         (tui_clear_win_detail): Remove.
3950
3951 2019-06-25  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3954         "this", not TUI_DISASM_WIN.
3955
3956 2019-06-25  Tom Tromey  <tom@tromey.com>
3957
3958         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3959         declare.
3960         * tui/tui-winsource.c
3961         (tui_source_window_base::do_scroll_horizontal): Rename from
3962         tui_horizontal_source_scroll.
3963         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3964         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3965         from tui_vertical_data_scroll.
3966         * tui/tui-win.h (tui_scroll): Don't declare.
3967         * tui/tui-win.c (tui_win_info::forward_scroll)
3968         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3969         (tui_win_info::right_scroll): Rename and update.
3970         (tui_scroll_forward_command, tui_scroll_backward_command)
3971         (tui_scroll_left_command, tui_scroll_right_command): Update.
3972         (tui_scroll): Remove.
3973         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3974         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3975         from tui_vertical_source_scroll.
3976         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3977         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3978         from tui_vertical_disassem_scroll.
3979         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3980         do_scroll_horizontal>: New methods.
3981         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3982         Likewise.
3983         (struct tui_source_window_base): Add do_scroll_horizontal.
3984         (struct tui_source_window, struct tui_disasm_window): Add
3985         do_scroll_vertical.
3986         (struct tui_data_window, struct tui_cmd_window): Add
3987         do_scroll_horizontal and do_scroll_vertical.
3988         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3989
3990 2019-06-25  Tom Tromey  <tom@tromey.com>
3991
3992         * tui/tui-data.h (struct tui_source_window_base): New struct.
3993         (struct tui_source_window): Derive from tui_source_window_base.
3994         (struct tui_disasm_window): New struct.
3995         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3996         from tui_source_window::clear_detail.
3997         (tui_source_window_base): Rename from tui_source_window.
3998         (~tui_source_window_base): Rename from ~tui_source_window.
3999         (tui_alloc_win_info): Create a tui_disasm_window.
4000
4001 2019-06-25  Tom Tromey  <tom@tromey.com>
4002
4003         * tui/tui-data.h (struct tui_source_window)
4004         (struct tui_data_window): Declare destructors.
4005         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4006         destructors.
4007         (tui_win_info): Simplify.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-winsource.c (tui_display_main)
4012         (tui_update_source_windows_with_addr)
4013         (tui_update_all_breakpoint_info): Update.
4014         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4015         (new_height_ok, parse_scrolling_args): Update.
4016         * tui/tui-stack.c (tui_show_frame_info): Update.
4017         * tui/tui-data.h (struct tui_list): Remove.
4018         (tui_source_windows): Return a reference to a std::vector.
4019         * tui/tui-data.c (source_windows): Now a std::vector.
4020         (tui_source_windows): Change return type.
4021         (tui_clear_source_windows): Rewrite.
4022         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4023         (tui_free_all_source_wins_content): Rewrite.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4028         (struct tui_data_window, struct tui_cmd_window): Declare
4029         clear_detail method.
4030         * tui/tui-data.c (tui_source_window::clear_detail)
4031         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4032         methods.
4033         (tui_clear_win_detail): Simplify.
4034
4035 2019-06-25  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-layout.c (make_source_window, make_disasm_window)
4038         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4039         Return the new window.
4040         (show_source_disasm_command, show_data)
4041         (show_source_or_disasm_and_command): Update.
4042
4043 2019-06-25  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4046         parameter.  Return the new window.
4047         (show_source_disasm_command): Update and remove NULL check.
4048         (show_source_or_disasm_and_command): Update.
4049
4050 2019-06-25  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4053
4054 2019-06-25  Tom Tromey  <tom@tromey.com>
4055
4056         * tui/tui-data.h (struct tui_win_info): Make constructor
4057         protected.  Make destructor virtual.  Add initializers.
4058         (tui_source_window, tui_data_window, tui_cmd_window): New
4059         classes.
4060         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4061         constructor.  Add "type" parameter.
4062         (tui_source_window, tui_data_window, tui_cmd_window): New
4063         constructors.
4064         (tui_alloc_win_info): Instantiate the appropriate subclass.
4065
4066 2019-06-25  Tom Tromey  <tom@tromey.com>
4067
4068         * tui/tui-win.c (tui_resize_all): Use delete.
4069         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4070         destructor.
4071         (tui_free_window): Don't declare.
4072         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4073         Update.
4074
4075 2019-06-25  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-data.h (struct tui_win_info): Add constructor.
4078         * tui/tui-data.c (tui_alloc_win_info): Use new.
4079         (tui_free_window): Use delete.
4080
4081 2019-06-22  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4084         declare.
4085         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4086
4087 2019-06-22  Tom Tromey  <tom@tromey.com>
4088
4089         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4090         declare.
4091         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4092
4093 2019-06-22  Tom de Vries  <tdevries@suse.de>
4094
4095         * dwarf2read.c (create_addrmap_from_aranges)
4096         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4097         instead of '%zu'.
4098
4099 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4100
4101         * dwarf2read.h (dwarf2_section_info_def): Remove.
4102         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4103         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4104         std::vector<dwarf2_section_info>.
4105         (struct dwo_file) <~dwo_file>: Remove.
4106         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4107         types field.
4108         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4109         (dwarf2_read_debug_names): Likewise.
4110         (create_debug_types_hash_table): Change parameter type to
4111         array_view, adjust code accordingly.
4112         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4113         (partial_die_info::fixup): Likewise.
4114         (determine_prefix): Likewise.
4115         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4116
4117 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4118
4119         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4120         gdb_bfd_ref_ptr.
4121         <~dwo_file>: Remove call to gdb_bfd_unref.
4122         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4123         gdb_bfd_ref_ptr::get.
4124
4125 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4126
4127         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4128         type to htab_up.
4129         * dwarf2read.c (struct dwo_file): Initialize fields.
4130         <~dwo_file>: New.
4131         (free_dwo_file): Remove, move content to ~dwo_file.
4132         (struct dwo_file_deleter): Remove.
4133         (dwo_file_up>: Remove custom deleter.
4134         (free_dwo_files): Remove.
4135         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4136         dwo_files.
4137         (process_skeletonless_type_units): Call unique_ptr::get.
4138         (allocate_dwo_file_hash_table): Add deleter to created hash
4139         table.  Change return type to htab_up.
4140         (lookup_dwo_file_slot): Don't memset dwo_file, call
4141         unique_ptr::get.
4142         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4143         (create_dwo_unit_in_dwp_v2): Likewise.
4144         (open_and_init_dwo_file): Likewise.
4145         (free_dwo_file_from_slot): Remove.
4146
4147 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4148
4149         * dwarf2read.h (struct dwarf2_section_info) <readin,
4150         is_virtual>: Change type to bool.
4151         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4152         true instead of 1.
4153
4154 2019-06-19  Tom Tromey  <tom@tromey.com>
4155
4156         * tui/tui-data.h (tui_init_content_element): Don't declare.
4157
4158 2019-06-19  Tom Tromey  <tom@tromey.com>
4159
4160         * tui/tui-data.h (tui_init_win_info): Don't declare.
4161
4162 2019-06-19  Tom de Vries  <tdevries@suse.de>
4163
4164         * dwarf2read.h (abstract_to_concrete): Change type to
4165         std::unordered_map<sect_offset, std::vector<sect_offset>,
4166         gdb::hash_enum<sect_offset>>.
4167
4168 2019-06-19  Tom Tromey  <tromey@adacore.com>
4169
4170         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4171         EVAL_AVOID_SIDE_EFFECTS specially.
4172
4173 2019-06-19  Tom Tromey  <tromey@adacore.com>
4174
4175         * source-cache.c (highlighter): New global.
4176         (source_cache::get_source_lines): Create a highlighter on demand.
4177
4178 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * defs.h (deprecated_interactive_hook): Delete declaration.
4181         * interps.c (clear_interpreter_hooks): Remove use of
4182         deprecated_interactive_hook.
4183         * top.c (deprecated_interactive_hook): Delete definition.
4184         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4185
4186 2019-06-18  Tom de Vries  <tdevries@suse.de>
4187
4188         PR gdb/24515
4189         * dwarf2read.h (abstract_to_concrete): Change type from
4190         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4191         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4192         * dwarf2read.c (read_variable): Update.
4193         (dwarf2_fetch_die_loc_sect_off): Update.
4194
4195 2019-06-17  Tom de Vries  <tdevries@suse.de>
4196
4197         PR gdb/24617
4198         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4199         accessing parent[parent_len - 1].
4200
4201 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4202
4203         PR gdb/24364
4204         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4205         call dtrace_process_dof with NULL dof.
4206
4207 2019-06-16  Tom de Vries  <tdevries@suse.de>
4208
4209         PR gdb/24445
4210         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4211
4212 2019-06-16  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4215         (make_all_visible): Use address of member.
4216
4217 2019-06-16  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4220         (tui_free_window, free_content, free_content_elements): Remove
4221         unnecessary cast.
4222         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4223         cast.
4224         * tui/tui-regs.c (tui_show_register_group)
4225         (tui_display_registers_from, tui_display_reg_element_at_line):
4226         Remove unnecessary cast.
4227
4228 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * linux-nat.c (normal_mask): Delete.
4231         (_initialize_linux_nat): Don't initialise normal_mask.
4232
4233 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4234
4235         PR gdb/24445
4236         * dwarf-index-write.h (write_psymtabs_to_index): Add
4237         dwz_basename parameter.
4238         * dwarf-index-write.c (write_gdbindex): Move file writing to
4239         write_gdbindex_1.  Change return type void.
4240         (assert_file_size): Move up, remove filename parameter.
4241         (write_gdbindex_1): New function.
4242         (write_debug_names): Change return type to void, call
4243         assert_file_size.
4244         (struct index_wip_file): New struct.
4245         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4246         file logic to index_wip_file.  Write index for dwz file if
4247         needed.
4248         (save_gdb_index_command): Pass basename of dwz file, if present.
4249         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4250         build-id of dwz file, if present.
4251         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4252         (dwarf2_get_dwz_file): Likewise.
4253         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4254         (dwarf2_get_dwz_file): Likewise.
4255
4256 2019-06-16  Tom Tromey  <tom@tromey.com>
4257
4258         * coffread.c (process_coff_symbol): Use xstrdup.
4259         * value.c (create_internalvar): Use xstrdup.
4260
4261 2019-06-16  Tom Tromey  <tom@tromey.com>
4262
4263         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4264         * breakpoint.c (stopin_command, stopat_command)
4265         (until_break_command, decode_location_default): Remove unnecessary
4266         cast.
4267         * utils.c (subset_compare): Remove unnecessary cast.
4268         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4269         cast.
4270         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4271         cast.
4272         * infcmd.c (path_command): Remove unnecessary cast.
4273         * coffread.c (decode_type): Remove unnecessary cast.
4274         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4275         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4276         * tui/tui-stack.c (tui_show_locator_content)
4277         (tui_show_frame_info): Remove unnecessary cast.
4278         * tui/tui-win.c (tui_scroll_forward_command)
4279         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4280         (parse_scrolling_args): Remove unnecessary cast.
4281         * tui/tui-data.c (init_win_info, tui_del_window)
4282         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4283         (free_content_elements): Remove unnecessary cast.
4284         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4285         unnecessary cast.
4286         * tui/tui-source.c (tui_set_source_content)
4287         (tui_vertical_source_scroll): Remove unnecessary cast.
4288         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4289         cast.
4290         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4291         * tui/tui-regs.c (tui_display_registers_from)
4292         (tui_display_register): Remove unnecessary cast.
4293         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4294         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4295         (make_visible): Remove unnecessary cast.
4296         * tui/tui-winsource.c (tui_erase_source_content)
4297         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4298         unnecessary cast.
4299         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4300         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4301         * stabsread.c (read_type, read_array_type, read_range_type):
4302         Remove unnecessary cast.
4303         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4304         (parse_symbol, parse_type, upgrade_type, parse_external)
4305         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4306         unnecessary cast.
4307         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4308
4309 2019-06-16  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui-data.c (tui_alloc_generic_win_info)
4312         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4313         checks.
4314
4315 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4316             Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * f-typeprint.c (f_print_type): Don't return early for not
4319         associated or not allocated types.
4320         (f_type_print_varspec_suffix): Add print_rank parameter and print
4321         ranks of array types in case they dangling.
4322         (f_type_print_base): Add print_rank parameter.
4323
4324 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * NEWS: Mention new MI commands.
4327         * break-catch-throw.c (enum exception_event_kind): Move to
4328         breakpoint.h.
4329         (print_mention_exception_catchpoint): Output text as a single
4330         message.
4331         (catch_exception_command_1): Rename to...
4332         (catch_exception_event): ...this, make non-static, update header
4333         command, and change some parameter types.
4334         (catch_catch_command): Update for changes to
4335         catch_exception_command_1.
4336         (catch_throw_command): Likewise.
4337         (catch_rethrow_command): Likewise.
4338         * breakpoint.c (enum exception_event_kind): Delete.
4339         * breakpoint.h (enum exception_event_kind): Moved here from
4340         break-catch-throw.c.
4341         (catch_exception_event): Declare.
4342         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4343         (mi_cmd_catch_throw): New function.
4344         (mi_cmd_catch_rethrow): New function.
4345         (mi_cmd_catch_catch): New function.
4346         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4347         'catch-catch' entries.
4348         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4349         (mi_cmd_catch_rethrow): Declare.
4350         (mi_cmd_catch_catch): Declare.
4351
4352 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4353
4354         * annotate.c (annotate_source_line): Change return type to void,
4355         update implementation to match.
4356         * annotate.h (annotate_source_line): Change return type to void,
4357         update header comment.
4358         * stack.c (print_frame_info): Don't change what frame information
4359         is printed based on whether annotations are on or not.
4360
4361 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4364         (annotate_source): Make static.
4365         (annotate_source_line): Moved from source.c and renamed from
4366         identify_source_line.  Update the return type.
4367         * annotate.h (annotate_source): Delete declaration.
4368         (annotate_source_line): Declaration moved from source.h, and
4369         renamed from identify_source_line.  Return type updated.
4370         * source.c (identify_source_line): Moved to annotate.c and renamed
4371         to annotate_source_line.
4372         (info_line_command): Remove check of annotation_level.
4373         * source.h (identify_source_line): Move declaration to annotate.h
4374         and rename to annotate_source_line.
4375         * stack.c: Add 'annotate.h' include.
4376         (print_frame_info): Remove check of annotation_level before
4377         calling annotate_source_line.
4378
4379 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * source-cache.c (source_cache::get_plain_source_lines): Use
4382         open_source_file_with_line_charpos instead of just
4383         open_source_file, remove call to find_source_lines.
4384         (source_cache::get_source_lines): Likewise.
4385         * source.c (find_source_lines): Make static.
4386         (get_filename_and_charpos): Renamed into...
4387         (open_source_file_with_line_charpos): ..this along with changes to
4388         return a scoped_fd, and some other minor clean ups.
4389         (identify_source_line): Use open_source_file_with_line_charpos.
4390         (search_command_helper): Use open_source_file_with_line_charpos
4391         instead of just open_source_file, remove call to
4392         find_source_lines.
4393         * source.h (open_source_file_with_line_charpos): Declare new
4394         function.
4395         (find_source_lines): Delete declaration.
4396
4397 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * source.c (get_filename_and_charpos): Remove fullname
4400         parameter.
4401         (identify_source_line): Update call to get_filename_and_charpos.
4402
4403 2019-06-14  Tom Tromey  <tromey@adacore.com>
4404
4405         PR gdb/24502:
4406         * ui-style.h (skip_ansi_escape): Update comment.
4407         * ui-file.h (class no_terminal_escape_file): New class.
4408         * ui-file.c (no_terminal_escape_file::write)
4409         (no_terminal_escape_file::puts): New methods.
4410         * cli/cli-logging.c (handle_redirections): Use
4411         no_terminal_escape_file.
4412
4413 2019-06-14  Tom Tromey  <tromey@adacore.com>
4414
4415         * NEWS: Move convenience variable news above Python news.
4416
4417 2019-06-14  Tom Tromey  <tom@tromey.com>
4418
4419         * gnulib: Move directory to top-level.
4420         * configure.ac: Don't configure gnulib.
4421         * configure: Rebuild.
4422         * common/common-defs.h: Use new path to gnulib.
4423         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4424         (GNULIB_H): Remove.
4425         (INCGNU): Look in new gnulib location.
4426         (HFILES_NO_SRCDIR): Remove gnulib files.
4427         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4428         (generated_files): Remove GNULIB_H.
4429         ($(LIBGNU), all-lib): Remove targets.
4430         (distclean): Don't mention GNULIB_BUILDDIR.
4431         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4432
4433 2019-06-14  Tom Tromey  <tromey@adacore.com>
4434
4435         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4436         Warn if symbol file does not provide any symbols.
4437
4438 2019-06-14  Tom Tromey  <tromey@adacore.com>
4439
4440         * source.c (find_and_open_source): Respect basenames_may_differ.
4441
4442 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * annotate.c (annotate_breakpoints_invalid): Make use of
4445         scoped_restore_terminal_state.
4446         (annotate_frames_invalid): Likewise.
4447
4448 2019-06-14  Tom Tromey  <tromey@adacore.com>
4449
4450         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4451         allow assignment to an internalvar.
4452
4453 2019-06-14  Tom Tromey  <tromey@adacore.com>
4454
4455         * ada-lex.l: Allow "_" in attribute names.
4456
4457 2019-06-14  Tom Tromey  <tromey@adacore.com>
4458
4459         PR gdb/24653:
4460         * regcache.c (registers_changed): Don't call alloca.
4461         * top.c (execute_command): Don't call alloca.
4462
4463 2019-06-13  Pedro Alves  <palves@redhat.com>
4464
4465         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4466         'expression'.  When parsing an expression, error out if there's
4467         junk after "unlimited".
4468         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4469         (do_set_command): Adjust calls to is_unlimited_literal.
4470
4471 2019-06-13  Pedro Alves  <palves@redhat.com>
4472
4473         * compile/compile.c (make_compile_options_def_group): Add braces
4474         around array_view initializer.
4475         * thread.c (make_thread_apply_all_options_def_group)
4476         (make_thread_apply_all_options_def_group): Likewise.
4477
4478 2019-06-13  Pedro Alves  <palves@redhat.com>
4479
4480         * NEWS (New commands): Mention "maint test-options
4481         require-delimiter", "maint test-options unknown-is-error", "maint
4482         test-options unknown-is-operand" and "maint show
4483         test-options-completion-result".
4484         (New command options, command completion): New section.
4485         (Completion improvements): New section.
4486         Mention that you can abbreviate "unlimited".
4487
4488 2019-06-13  Pedro Alves  <palves@redhat.com>
4489
4490         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4491         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4492         * unittests/cli-utils-selftests.c (test_parse_flags)
4493         (test_parse_flags_qcs): Delete.
4494         (test_cli_utils): Don't call deleted functions.
4495
4496 2019-06-13  Pedro Alves  <palves@redhat.com>
4497
4498         * thread.c: Include "cli/cli-option.h".
4499         (tp_array_compar_ascending): Global.
4500         (tp_array_compar): Delete function.
4501         (tp_array_compar_ascending, tp_array_compar_descending): New
4502         functions.
4503         (ascending_option_def, qcs_flag_option_def)
4504         (thr_qcs_flags_option_defs)
4505         (make_thread_apply_all_options_def_group)
4506         (make_thread_apply_options_def_group): New.
4507         (thread_apply_all_command): Use gdb::option::process_options.
4508         (thread_apply_command_completer)
4509         (thread_apply_all_command_completer): New.
4510         (thread_apply_command): Use gdb::option::process_options.
4511         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4512         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4513         to generate help text of "thread apply".  Adjust "taas"'s help.
4514         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4515         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4516
4517 2019-06-13  Pedro Alves  <palves@redhat.com>
4518
4519         * thread.c (thread_apply_command): Check for invalid TID with
4520         isdigit instead of !isalpha.
4521
4522 2019-06-13  Pedro Alves  <palves@redhat.com>
4523
4524         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4525         (validate_flags_qcs): New.
4526         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4527         (validate_flags_qcs): Declare.
4528         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4529         (make_frame_apply_options_def_group): New.
4530         (frame_apply_command_count): Process options with
4531         gdb::option::process_options.
4532         (frame_apply_completer): New.
4533         (frame_apply_level_completer, frame_apply_all_completer)
4534         (frame_apply_completer): New.
4535         (_initialize_stack): Update help of "frame apply", "frame apply
4536         level", "frame apply all" and "faas" to mention supported options
4537         and install command completers.
4538         * stack.h (frame_apply_all_completer): Declare.
4539         * thread.c: Include "stack.h".
4540         (tfaas_command): Add "--".
4541         (_initialize_thread): Update help "tfaas" to mention supported
4542         options and install command completer.
4543
4544 2019-06-13  Pedro Alves  <palves@redhat.com>
4545
4546         * completer.c (complete_nested_command_line): New.
4547         (gdb_completion_word_break_characters_throw): Add assertion.
4548         * completer.h (complete_nested_command_line): Declare.
4549
4550 2019-06-13  Pedro Alves  <palves@redhat.com>
4551
4552         * stack.c (parse_backtrace_qualifiers): New.
4553         (backtrace_command): Use it.
4554         (backtrace_command_completer): Complete on qualifiers.
4555
4556 2019-06-13  Pedro Alves  <palves@redhat.com>
4557
4558         * frame.c: Include "cli/cli-option.h.
4559         (user_set_backtrace_options): New.
4560         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4561         Delete.
4562         (get_prev_frame): Adjust.
4563         (boolean_option_def, uinteger_option_def)
4564         (set_backtrace_option_defs): New.
4565         (_initialize_frame): Adjust and use
4566         gdb::option::add_setshow_cmds_for_options to install "set
4567         backtrace past-main" and "set backtrace past-entry".
4568         * frame.h: Include "cli/cli-option.h".
4569         (struct frame_print_options): Forward declare.
4570         (print_frame_arguments_all, print_frame_arguments_scalars)
4571         (print_frame_arguments_none): Declare.
4572         (print_entry_values): Delete declaration.
4573         (struct frame_print_options, user_frame_print_options): New.
4574         (struct set_backtrace_options): New.
4575         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4576         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4577         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4578         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4579         (list_args_or_locals): Add frame_print_options parameter.
4580         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4581         * python/py-framefilter.c (enumerate_args): Pass down
4582         USER_FRAME_PRINT_OPTIONS.
4583         * stack.c: Include "cli/cli-option.h".
4584         (print_frame_arguments_all, print_frame_arguments_scalars)
4585         (print_frame_arguments_none): Declare.
4586         (print_raw_frame_arguments, print_entry_values): Delete.
4587         (user_frame_print_options): New.
4588         (boolean_option_def, enum_option_def, frame_print_option_defs):
4589         New.
4590         (struct backtrace_cmd_options): New.
4591         (bt_flag_option_def): New.
4592         (backtrace_command_option_defs): New.
4593         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4594         (print_frame_arg, read_frame_arg, print_frame_args)
4595         (print_frame_info, print_frame): Add frame_print_options parameter
4596         and use it.
4597         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4598         (backtrace_command_1): Add frame_print_options and
4599         backtrace_cmd_options parameters and use them.
4600         (make_backtrace_options_def_group): New.
4601         (backtrace_command): Process command options with
4602         gdb::option::process_options.
4603         (backtrace_command_completer): New.
4604         (_initialize_stack): Extend "backtrace"'s help to mention
4605         supported options.  Install completer for "backtrace".
4606         Install some settings commands with add_setshow_cmds_for_options.
4607
4608 2019-06-13  Pedro Alves  <palves@redhat.com>
4609
4610         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4611         and that "set/show print raw frame-arguments" are now deprecated.
4612
4613         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4614         command.
4615         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4616         * stack.c (_initialize_stack): Install "set/show print
4617         raw-frame-arguments", and deprecate "set/show print raw
4618         frame-arguments".
4619         * valprint.c (_initialize_valprint): Deprecate "set/show print
4620         raw".
4621
4622 2019-06-13  Pedro Alves  <palves@redhat.com>
4623
4624         * compile/compile.c (struct compile_options): New.
4625         (compile_flag_option_def, compile_command_option_defs)
4626         (make_compile_options_def_group): New.
4627         (compile_file_command): Handle options with
4628         gdb::option::process_options.
4629         (compile_file_command_completer): New function.
4630         (compile_code_command): Handle options with
4631         gdb::option::process_options.
4632         (compile_code_command_completer): New function.
4633         (_initialize_compiler): Install completers for "compile code" and
4634         "compile file".  Mention available options in "compile code" and
4635         "compile code"'s help.
4636         * completer.c (advance_to_completion_word): New, factored out from
4637         ...
4638         (advance_to_expression_complete_word_point): ... this.
4639         (advance_to_filename_complete_word_point): New.
4640         * completer.h (advance_to_filename_complete_word_point): New
4641         declaration.
4642
4643 2019-06-13  Pedro Alves  <palves@redhat.com>
4644
4645         * compile/compile.c: Include "cli/cli-option.h".
4646         (compile_print_value): Scope data pointer is now a
4647         value_print_options pointer; adjust.
4648         (compile_print_command): Process options.  Scope data pointer is
4649         now a value_print_options pointer; adjust.
4650         (_initialize_compile): Update "compile print"'s help to include
4651         supported options.  Install a completer for "compile print".
4652         * cp-valprint.c (show_vtblprint, show_objectprint)
4653         (show_static_field_print): Delete.
4654         (_initialize_cp_valprint): Don't install "set print
4655         static-members", "set print vtbl", "set print object" here.
4656         * printcmd.c: Include "cli/cli-option.h" and
4657         "common/gdb_optional.h".
4658         (print_command_parse_format): Rework to fill in a
4659         value_print_options instead of a format_data.
4660         (print_value): Change parameter type from format_data pointer to
4661         value_print_options reference.  Adjust.
4662         (print_command_1): Process options.  Adjust to pass down a
4663         value_print_options.
4664         (print_command_completer): New.
4665         (_initialize_printcmd): Install print_command_completer as
4666         handle_brkchars completer for the "print" command.  Update
4667         "print"'s help to include supported options.
4668         * valprint.c: Include "cli/cli-option.h".
4669         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4670         here from cp-valprint.c.
4671         (boolean_option_def, uinteger_option_def)
4672         (value_print_option_defs, make_value_print_options_def_group):
4673         New.  Use gdb::option::add_setshow_cmds_for_options to install
4674         "set print elements", "set print null-stop", "set print repeats",
4675         "set print pretty", "set print union", "set print array", "set
4676         print address", "set print symbol", "set print array-indexes".
4677         * valprint.h: Include <string> and "cli/cli-option.h".
4678         (make_value_print_options_def_group): Declare.
4679         (print_value): Change parameter type from format_data pointer to
4680         value_print_options reference.
4681         (print_command_completer): Declare.
4682
4683 2019-06-13  Pedro Alves  <palves@redhat.com>
4684
4685         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4686         (COMMON_SFILES): Add maint-test-settings.c.
4687         * cli/cli-decode.c (boolean_enums): New global, factored out from
4688         ...
4689         (add_setshow_boolean_cmd): ... here.
4690         * cli/cli-decode.h (boolean_enums): Declare.
4691         * cli/cli-option.c: New file.
4692         * cli/cli-option.h: New file.
4693         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4694         factored out from ...
4695         (parse_cli_boolean_value(const char *)): ... this.
4696         (is_unlimited_literal): Change parameter type to pointer to
4697         pointer.  Adjust and advance ARG pointer.
4698         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4699         (parse_cli_var_enum): New, factored out from ...
4700         (do_set_command): ... this.  Adjust.
4701         * cli/cli-setshow.h (parse_cli_boolean_value)
4702         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4703         (parse_cli_var_enum): Declare.
4704         * cli/cli-utils.c: Include "cli/cli-option.h".
4705         (get_ulongest): New.
4706         * cli/cli-utils.h (get_ulongest): Declare.
4707         (check_for_argument): New overloads.
4708         * maint-test-options.c: New file.
4709
4710 2019-06-13  Pedro Alves  <palves@redhat.com>
4711
4712         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4713         parse a range if "-" is at the end of the string.
4714
4715 2019-06-13  Pedro Alves  <palves@redhat.com>
4716
4717         * cli/cli-setshow.c (parse_auto_binary_operation)
4718         (parse_cli_boolean_value): Don't allow "o".
4719
4720 2019-06-13  Pedro Alves  <palves@redhat.com>
4721
4722         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4723         * NEWS: Mention maint test-settings KIND.
4724         * maint-test-settings.c: New file.
4725
4726 2019-06-13  Pedro Alves  <palves@redhat.com>
4727
4728         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4729         completer.
4730         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4731         "set" completers.
4732
4733 2019-06-13  Pedro Alves  <palves@redhat.com>
4734
4735         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4736         after item.
4737
4738 2019-06-13  Pedro Alves  <palves@redhat.com>
4739
4740         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4741
4742 2019-06-13  Pedro Alves <palves@redhat.com>
4743
4744         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4745         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4746         call.
4747         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4748         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4749         calls.
4750         (check_for_argument): Skip spaces after argument.
4751
4752 2019-06-13  Pedro Alves  <palves@redhat.com>
4753
4754         * thread.c (thread_apply_command): Adjust TID parsing.
4755         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4756         detected before end of string.
4757         (tid_is_in_list): Error out if LIST is invalid.
4758
4759 2019-06-13  Pedro Alves  <palves@redhat.com>
4760
4761         * completer.c (complete_line_internal_1): Rewind completion word
4762         point.
4763         (completion_tracker::advance_custom_word_point_by): Change
4764         parameter type to int.
4765         * completer.h (completion_tracker::advance_custom_word_point_by):
4766         Likewise.
4767
4768 2019-06-13  Pedro Alves  <palves@redhat.com>
4769
4770         * completer.c (advance_to_completion_word): Handle delimiters.
4771
4772 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4773
4774         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4775
4776 2019-06-11  Tom Tromey  <tom@tromey.com>
4777
4778         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4779         (xmalloc_failed): Move to alloc.c.
4780         * alloc.c: New file.
4781         * Makefile.in (COMMON_SFILES): Add alloc.c.
4782
4783 2019-06-11  Tom Tromey  <tom@tromey.com>
4784
4785         * nat/linux-waitpid.c: Don't include server.h.
4786         (linux_debug): Remove.
4787         (my_waitpid): Update.
4788
4789 2019-06-11  Tom Tromey  <tromey@adacore.com>
4790
4791         * infcall.c (_initialize_infcall): Remove trailing newline from
4792         help.
4793         * user-regs.c (_initialize_user_regs): Remove trailing newline
4794         from help.
4795         * typeprint.c (_initialize_typeprint): Remove trailing newline
4796         from help.
4797         * reverse.c (_initialize_reverse): Remove trailing newlines from
4798         help.
4799         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4800         from help.
4801         * language.c (add_set_language_command): Remove trailing newline
4802         from help.
4803         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4804         help.
4805         * disasm.c (_initialize_disasm): Remove trailing newline from
4806         help.
4807         * top.c (init_main): Remove trailing newline from help.
4808         * interps.c (_initialize_interpreter): Remove trailing newline
4809         from help.
4810         * btrace.c (_initialize_btrace): Remove trailing newlines from
4811         help.
4812         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4813         from help.
4814         * python/python.c (_initialize_python): Remove trailing newline
4815         from help.
4816         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4817         help.
4818         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4819         from help.  Reformat some text.
4820         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4821         from help.
4822         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4823         newline from help.
4824
4825 2019-06-11  Tom Tromey  <tromey@adacore.com>
4826
4827         * darwin-nat.c (darwin_decode_exception_message)
4828         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4829
4830 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * valops.c (value_slice): Check for not allocated or not
4833         associated values.
4834
4835 2019-06-10  Tom de Vries  <tdevries@suse.de>
4836
4837         PR gdb/24618
4838         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4839         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4840         invalid.
4841
4842 2019-06-10  Tom de Vries  <tdevries@suse.de>
4843
4844         PR gdb/24611
4845         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4846         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4847
4848 2019-06-10  Tom de Vries  <tdevries@suse.de>
4849
4850         PR symtab/24545
4851         * symtab.c (struct demangled_name_entry): Add language field.
4852         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4853         static minimal symbol".  Set and use language field.
4854
4855 2019-06-10  Tom Tromey  <tromey@adacore.com>
4856
4857         * ada-lang.c (_initialize_ada_language): Update help text.
4858
4859 2019-06-10  Tom Tromey  <tromey@adacore.com>
4860
4861         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4862         with a newline.
4863         * guile/guile.c (handle_boot_error): Don't end warning with a
4864         newline.
4865         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4866         warning with a newline.
4867         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4868         newline.
4869         (s12z_frame_cache): Likewise.
4870         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4871         a newline.
4872         * solib-svr4.c (disable_probes_interface): Don't end warning with
4873         a newline.
4874         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4875         newline.
4876         * python/python.c (do_finish_initialization): Don't end warning
4877         with a newline.
4878
4879 2019-06-10  Tom Tromey  <tom@tromey.com>
4880
4881         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4882         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4883         gdbpy_enter.
4884
4885 2019-06-10  Tom Tromey  <tromey@adacore.com>
4886
4887         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4888         data.
4889         (elf_new_init): Don't call stabsread_new_init.
4890         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4891         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4892         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4893
4894 2019-06-10  Tom de Vries  <tdevries@suse.de>
4895
4896         PR symtab/16264
4897         PR symtab/24517
4898         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4899
4900 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4901
4902         * source.c (find_and_open_source): Also rewrite relative file
4903         names.
4904
4905 2019-04-26  Amos Bird  <amosbird@gmail.com>
4906
4907         * annotate.c (annotate_thread_exited): Add "thread-exited"
4908         annotation.
4909
4910 2019-06-06  Tom Tromey  <tromey@adacore.com>
4911
4912         * maint.h (class scoped_command_stats): Use
4913         DISABLE_COPY_AND_ASSIGN.
4914         <print_time>: New method.
4915         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4916         print_time.
4917         (scoped_command_stats::print_time): New method.
4918
4919 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4922         instructions of lengths 6 or 8 bytes.
4923
4924 2019-06-04  Pedro Alves  <palves@redhat.com>
4925
4926         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4927
4928         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4929         * breakpoint.c (condition_completer): Likewise.
4930         * cli/cli-dump.c (scan_expression): Likewise.
4931         * common/filestuff.c (mkdir_recursive): Likewise.
4932         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4933         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4934         (gdb_abspath): Likewise.
4935         * compile/compile-cplus-types.c
4936         (compile_cplus_instance::decl_name): Likewise.
4937         * completer.c (complete_explicit_location):
4938         (signal_completer, reg_or_group_completer_1): Likewise.
4939         * cp-support.c (cp_remove_params_if_any): Likewise.
4940         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4941         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4942         * infcmd.c (strip_bg_char): Likewise.
4943         * linespec.c (copy_token_string): Likewise.
4944         * mi/mi-main.c (output_cores): Likewise.
4945         * psymtab.c (psymtab_search_name):
4946         * symfile.c (test_set_ext_lang_command): Likewise.
4947         * target.c (target_fileio_read_stralloc): Likewise.
4948         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4949         * value.c (complete_internalvar): Likewise.
4950
4951 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4952
4953         Add objfile property to gdb.Type.
4954         * NEWS: Mention Python API addition.
4955         * python/py-type.c (typy_get_objfile): New method.
4956
4957 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4958
4959         * NEWS: Mention the new set|show style [title|highlight].
4960         Mention changes to "show style", "help" and "apropos".
4961
4962 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4963
4964         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4965         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4966         instead of print_help_for_command.
4967         (print_doc_of_command): New function.
4968         (help_list): Add 'apropos -v word' suggestion.
4969         (print_help_for_command): Style the command name using title style.
4970         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4971         (_initialize_cli_cmds): Describe -v in apropos_command help.
4972
4973 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4974
4975         * cli/cli-style.h (cli_style_option): Add name in constructor,
4976         add m_name class member, add constructor with intensity,
4977         add name class function.
4978         (cli_style_option::add_setshow_commands): Remove name argument.
4979         (highlight_style, title_style): New styles.
4980         * cli/cli-style.c (do_show): New function that shows a style
4981         characteristic styling the style name with itself.
4982         (set_style_name): New function.
4983         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4984         Update all callers according to the changes in cli/cli-style.h.
4985         * utils.h (fputs_highlighted): New function.
4986         * utils.c (fputs_highlighted): Likewise.
4987
4988 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4989
4990         * NEWS: Mention new pipe command and new convenience variables.
4991
4992 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4993
4994         * cli/cli-cmds.c (pipe_command): New function.
4995         (_initialize_cli_cmds): Call add_com for pipe_command.
4996         Define | as an alias for pipe.
4997         (exit_status_set_internal_vars): New function.
4998         (shell_escape): Call exit_status_set_internal_vars.
4999         cli/cli-decode.c (find_command_name_length): Recognize | as
5000         a single character command.
5001
5002 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5003
5004         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5005         top.c (execute_command_to_ui_file): New function, mostly a copy
5006         of execute_command_to_string.
5007         (execute_command_to_string): Implement by calling
5008         execute_command_to_ui_file.
5009
5010 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5011
5012         * top.h (saved_command_line): Remove declaration.
5013         * top.c (previous_saved_command_line, previous_repeat_arguments):
5014         New variables.
5015         (saved_command_line): Make static, define together with other
5016         'repeat variables'.
5017         (dont_repeat): Clear repeat_arguments.
5018         (repeat_previous, get_saved_command_line, save_command_line):
5019         New functions.
5020         (gdb_init): Initialize saved_command_line
5021         and previous_saved_command_line.
5022         * main.c (captured_main_1): Remove saved_command_line initialization.
5023         * event-top.c (handle_line_of_input): Update to use
5024         the new 'repeat' related functions instead of direct access to
5025         saved_command_line.
5026         * command.h (repeat_previous, get_saved_command_line,
5027         save_command_line): New declarations.
5028         (dont_repeat): Add comment.
5029
5030 2019-05-30  Tom Tromey  <tromey@adacore.com>
5031
5032         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5033         Fix comment.
5034         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5035
5036 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5037
5038         PR cli/24587
5039         * completer.c (complete): Initialize variable word.
5040
5041 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5042
5043         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5044         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5045         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5046         'body' is NULL to the outter 'if', protecting the '!is_define'
5047         situation as well.
5048
5049 2019-05-29  Tom Tromey  <tromey@adacore.com>
5050
5051         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5052         (dwarf_unknown): New function.
5053         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5054         (dwarf_type_encoding_name): Use dwarf_unknown.
5055
5056 2019-05-29  Tom Tromey  <tromey@adacore.com>
5057
5058         PR c++/20020:
5059         * cp-valprint.c (cp_print_value_fields): Call
5060         cp_print_static_field inside "try".
5061
5062 2019-05-29  Tom Tromey  <tromey@adacore.com>
5063
5064         * inflow.c (struct terminal_info): Add default operator=.
5065         * configure: Rebuild.
5066         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5067         -Wdeprecated-copy-dtor, -Wredundant-move.
5068
5069 2019-05-29  Tom Tromey  <tromey@adacore.com>
5070
5071         * NEWS: Add entry.
5072         * infcmd.c (print_return_value_1): Handle finish_print
5073         option.
5074         (show_print_finish): New function.
5075         (_initialize_infcmd): Add "set/show print finish" commands.
5076         * valprint.c (user_print_options): Initialize new member.
5077         * valprint.h (struct value_print_options) <finish_print>: New
5078         member.
5079
5080 2019-05-28  Tom Tromey  <tromey@adacore.com>
5081
5082         * ada-lang.c (ada_remove_Xbn_suffix)
5083         (find_old_style_renaming_symbol)
5084         (parse_old_style_renaming): Remove.
5085         (ada_find_renaming_symbol): Don't call
5086         find_old_style_renaming_symbol.
5087         (ada_is_renaming_symbol): Rename from
5088         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5089         bool.  Now static.
5090         (ada_read_var_value): Update and simplify.
5091         * ada-exp.y (write_var_or_type): Remove old code.
5092
5093 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5094
5095         * event-top.c: Remove include comment.
5096         * inflow.c (class scoped_ignore_sigttou): Move from here...
5097         * inflow.h (class scoped_ignore_sigttou): ...to here.
5098         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5099         * top.c:  Remove include comment.
5100
5101 2019-05-27  Tom Tromey  <tom@tromey.com>
5102
5103         * NEWS: Fix typo.
5104
5105 2019-05-22  Tom Tromey  <tromey@adacore.com>
5106
5107         * target.c (target_follow_exec): Constify parameter.
5108         * target-delegates.c: Rebuild.
5109         * remote.c (remote_target::follow_exec): Constify parameter.
5110         * infrun.c (follow_exec): Constify parameter.
5111         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5112         (target_follow_exec): Likewise.
5113
5114 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5115
5116         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5117         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5118
5119 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5120
5121         * NEWS: Add debugredirect and testsuite sections.
5122
5123 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5124
5125         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5126         target descriptions using exclusively floating point register name
5127         aliases.
5128
5129 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5130
5131         PR gdb/18644:
5132         * f-lang.c (build_fortran_types): Handle the case where
5133         gdbarch_floatformat_for_type returns a nullptr.
5134
5135 2019-05-21  Tom de Vries  <tdevries@suse.de>
5136
5137         PR cli/24587
5138         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5139
5140 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         PR gdb/18644:
5143         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5144         16-byte floats.
5145         * i386-tdep.c (i386_floatformat_for_type): Use
5146         floatformats_ia64_quad for the 16-byte floating point component
5147         within a fortran 32-byte complex number.
5148
5149 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5152         delete default constructor.
5153         (find_partial_die): Update to return const struct.
5154         (partial_die_parent_scope): Move variable declaration into scope
5155         of its use and change its type to auto.
5156         (guess_partial_die_structure_name): Likewise.
5157         (partial_die_info::fixup): Likewise.
5158
5159 2019-05-17  Tom Tromey  <tromey@adacore.com>
5160
5161         * source.c (find_and_open_source): Remove cast.
5162
5163 2019-05-17  Tom Tromey  <tromey@adacore.com>
5164
5165         * annotate.c (annotate_source): Make "filename" const.
5166         * annotate.h (annotate_source): Use const.
5167
5168 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5169
5170         * disasm.c (set_disassembler_options): Send errors to stderr.
5171
5172 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5173
5174         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5175         (cli_interp_base::set_logging): Check debug_redirect.
5176         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5177         * cli/cli-logging.c (debug_redirect): Add static variable.
5178         (pop_output_files): Add default param.
5179         (handle_redirections): Print debug setting.
5180         (show_logging_command): Likewise.
5181         (_initialize_cli_logging): Add debugredirect command.
5182         * interps.c (current_interp_set_logging): Add debug_redirect
5183         parameter.
5184         * interps.h (set_logging): Add debug_redirect parameter.
5185         (current_interp_set_logging): Likewise.
5186         * mi/mi-common.h: Likewise.
5187         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5188
5189 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5190             Tom Tromey  <tromey@adacore.com>
5191
5192         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5193         directly.
5194         * cli/cli-interp.h (make_logging_output): Remove declaration.
5195         * cli/cli-logging.c (make_logging_output): Remove function.
5196         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5197         directly.
5198         * ui-file.c (tee_file::tee_file): Remove bools.
5199         (tee_file::~tee_file): Remove deletes.
5200         * ui-file.h (tee_file): Remove bools.
5201
5202 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5203
5204         * mi/mi-cmds.h (mi_cmd_complete): New function.
5205         * mi/mi-main.c (mi_cmd_complete): Likewise.
5206         * mi/mi-cmds.c: Define new MI command -complete.
5207         * NEWS: Mention new -complete command.
5208
5209 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5210
5211         * completer.h (complete): New function.
5212         * completer.c (complete): Likewise.
5213         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5214         function defined in completer.h.
5215
5216 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5217
5218         * MAINTAINERS (Write After Approval): Add myself.
5219
5220 2019-05-17  Tom de Vries  <tdevries@suse.de>
5221
5222         PR gdb/24094
5223         * dwarf2read.c (struct cu_partial_die_info): New struct.
5224         (find_partial_die): Return cu_partial_die_info.
5225         (partial_die_parent_scope, guess_partial_die_structure_name)
5226         (partial_die_info::fixup): Handle new return type of find_partial_die.
5227
5228 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5229
5230         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5231         "std::string", simplifying the algorithm.
5232
5233 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5234
5235         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5236         (stap_static_probe_ops::get_probes): Likewise.
5237
5238 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5239
5240         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5241         '-')" and "else if".
5242         (stap_parse_single_operand): Join checks for
5243         "gdbarch_stap_parse_special_token_p" and
5244         "gdbarch_stap_parse_special_token" in the same "if" statement.
5245         Invert check when verifying for operation on register
5246         displacement.
5247
5248 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5249
5250         * stap-probe.c (stap_get_opcode): Update comment.
5251         (stap_get_expected_argument_type): Likewise.
5252         (handle_stap_probe): Likewise.
5253
5254 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5255
5256         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5257         return type to 'bool'.  Adjust comment.  Use 'bool' when
5258         appropriate.
5259         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5260         * stap-probe.c (stap_parse_argument_1): Likewise.
5261         (stap_is_operator): Likewise.
5262         (stap_is_generic_prefix): Likewise.
5263         (stap_is_register_prefix): Likewise.
5264         (stap_is_register_indirection_prefix): Likewise.
5265         (stap_is_integer_prefix): Likewise.
5266         (stap_generic_check_suffix): Likewise.
5267         (stap_check_integer_suffix): Likewise.
5268         (stap_check_register_suffix): Likewise.
5269         (stap_check_register_indirection_suffix): Likewise.
5270         (stap_parse_register_operand): Likewise.
5271         (stap_parse_single_operand): Likewise.
5272         (stap_parse_argument_1): Likewise.
5273         (stap_probe::get_argument_count): Likewise.
5274         (stap_is_operator): Likewise.
5275
5276 2019-05-16  Tom Tromey  <tromey@adacore.com>
5277
5278         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5279         keyword to foreach.
5280
5281 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5282
5283         * linux-thread-db.c (try_thread_db_load_1): Change return type
5284         to bool.
5285         (try_thread_db_load): Likewise.
5286         (try_thread_db_load_from_pdir_1): Likewise.
5287         (try_thread_db_load_from_pdir): Likewise.
5288         (try_thread_db_load_from_sdir): Likewise.
5289         (try_thread_db_load_from_dir): Likewise.
5290         (thread_db_load_search): Likewise.
5291         (has_libpthread): Likewise.
5292         (thread_db_load): Likewise.
5293
5294 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5295
5296         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5297         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5298         NULL, and complain/return if that's the case.
5299
5300 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5301
5302         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5303         (advance, posn, abstract_read_memory): New functions.
5304         [struct mem_read_abstraction]: New struct.
5305         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5306
5307 2019-05-14  Tom Tromey  <tromey@adacore.com>
5308
5309         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5310         value is not lval_memory.
5311
5312 2019-05-14  Tom Tromey  <tromey@adacore.com>
5313
5314         * solib.c (info_sharedlibrary_command): Style the file name.
5315
5316 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5317
5318         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5319         (aarch64_vnv_type): Likewise.
5320         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5321         * common/tdesc.c: Likewise.
5322         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5323         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5324         * features/aarch64-fpu.xml: Add ieee half view.
5325         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5326         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5327         * gdbtypes.h (struct builtin_type): Likewise.
5328         (struct objfile_type): Likewise.
5329
5330 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5331
5332         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5333         typo.
5334         * location.h (string_to_event_location): Likewise.
5335
5336 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5337
5338         GDB 8.3 released.
5339
5340 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5341
5342         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5343         New variable declaration.
5344         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5345         New variable.
5346         (print_one_breakpoint): Use ui_out::test_flags and new global
5347         variable to compute use_fixed_output.
5348         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5349         Remove.
5350         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5351         (mi_multi_location_breakpoint_output_fixed): Remove.
5352         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5353         new variable.
5354         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5355         fix_multi_location_breakpoint_output flag if version >= 3.
5356         * ui-out.h (enum ui_out_flag)
5357         <fix_multi_location_breakpoint_output>: New enumerator.
5358
5359 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5360
5361         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5362
5363 2019-05-10  Tom Tromey  <tromey@adacore.com>
5364
5365         * ada-lang.c (catch_ada_completer): New function.
5366         (_initialize_ada_language): Use it.
5367
5368 2019-05-10  Tom Tromey  <tromey@adacore.com>
5369
5370         * thread.c (print_thread_info): Make "requested_threads" const.
5371         * gdbthread.h (print_thread_info): Make "requested_threads"
5372         const.
5373         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5374         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5375
5376 2019-05-08  Tom Tromey  <tom@tromey.com>
5377
5378         * gdbtypes.c (objfile_type_data): Change type.
5379         (objfile_type, _initialize_gdbtypes): Update.
5380
5381 2019-05-08  Tom Tromey  <tom@tromey.com>
5382
5383         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5384         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5385         (_initialize_dwarf2_frame): Update.
5386
5387 2019-05-08  Tom Tromey  <tom@tromey.com>
5388
5389         * objc-lang.c (objc_objfile_data): Change type.
5390         (find_methods): Update.
5391         (_initialize_objc_lang): Remove.
5392
5393 2019-05-08  Tom Tromey  <tom@tromey.com>
5394
5395         * stabsread.c (rs6000_builtin_type_data): Change type.
5396         (rs6000_builtin_type, _initialize_stabsread): Update.
5397
5398 2019-05-08  Tom Tromey  <tom@tromey.com>
5399
5400         * mips-tdep.c (mips_pdr_data): Remove.
5401         (_initialize_mips_tdep): Update.
5402
5403 2019-05-08  Tom Tromey  <tom@tromey.com>
5404
5405         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5406         (hppa_init_objfile_priv_data, read_unwind_info)
5407         (find_unwind_entry, _initialize_hppa_tdep): Update.
5408
5409 2019-05-08  Tom Tromey  <tom@tromey.com>
5410
5411         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5412         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5413         on obstack.
5414         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5415
5416 2019-05-08  Tom Tromey  <tom@tromey.com>
5417
5418         * mdebugread.c (basic_type_data): Change type.
5419         (basic_type, _initialize_mdebugread): Update.
5420
5421 2019-05-08  Tom Tromey  <tom@tromey.com>
5422
5423         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5424
5425 2019-05-08  Tom Tromey  <tom@tromey.com>
5426
5427         * nto-tdep.c (nto_inferior_data_reg): Change type.
5428         (nto_inferior_data): Update.
5429         (nto_inferior_data_cleanup, nto_new_inferior_data)
5430         (_initialize_nto_tdep): Remove.
5431         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5432
5433 2019-05-08  Tom Tromey  <tom@tromey.com>
5434
5435         * ada-lang.c (struct ada_inferior_data): Add initializers.
5436         (ada_inferior_data): Change type.
5437         (ada_inferior_data_cleanup): Remove.
5438         (get_ada_inferior_data, ada_inferior_exit)
5439         (struct ada_pspace_data): Add initializers, destructor.
5440         (ada_pspace_data_handle): Change type.
5441         (get_ada_pspace_data): Update.
5442         (ada_pspace_data_cleanup): Remove.
5443
5444 2019-05-08  Tom Tromey  <tom@tromey.com>
5445
5446         * coffread.c (struct coff_symfile_info): Add initializers.
5447         (coff_objfile_data_key): Move lower.  Change type.
5448         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5449         Update.
5450         (coff_free_info): Remove.
5451
5452 2019-05-08  Tom Tromey  <tom@tromey.com>
5453
5454         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5455         (fbsd_pspace_data_handle): Move lower.  Change type.
5456         (get_fbsd_pspace_data): Update.
5457         (fbsd_pspace_data_cleanup): Remove.
5458         (_initialize_fbsd_tdep): Update.
5459
5460 2019-05-08  Tom Tromey  <tom@tromey.com>
5461
5462         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5463         (get_ada_tasks_pspace_data): Update.
5464         (ada_tasks_pspace_data_cleanup): Remove.
5465         (_initialize_tasks): Update.
5466         (ada_tasks_inferior_data_handle): Change type.
5467         (get_ada_tasks_inferior_data): Update.
5468         (ada_tasks_inferior_data_cleanup): Remove.
5469         (struct ada_tasks_pspace_data): Add initializers.
5470
5471 2019-05-08  Tom Tromey  <tom@tromey.com>
5472
5473         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5474         * symfile-debug.c (debug_sym_get_probes): Change type.
5475         * stap-probe.c (handle_stap_probe):
5476         (stap_static_probe_ops::get_probes): Change type.
5477         * probe.h (class static_probe_ops) <get_probes>: Change type.
5478         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5479         (parse_probes_in_pspace): Update.
5480         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5481         Update.
5482         (any_static_probe_ops::get_probes): Change type.
5483         * elfread.c (elfread_data): New typedef.
5484         (probe_key): Change type.
5485         (elf_get_probes): Likewise.  Update.
5486         (probe_key_free): Remove.
5487         (_initialize_elfread): Update.
5488         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5489         Change type.
5490         (dtrace_process_dof_probe, dtrace_process_dof)
5491         (dtrace_static_probe_ops::get_probe): Change type.
5492
5493 2019-05-08  Tom Tromey  <tom@tromey.com>
5494
5495         * xcoffread.c (struct xcoff_symfile_info): Rename from
5496         coff_symfile_info.  Add initializers.
5497         (xcoff_objfile_data_key): Move lower.  Change type.
5498         (XCOFF_DATA): Rewrite.
5499         (xcoff_free_info): Remove.
5500         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5501         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5502         (xcoff_initial_scan): Update.
5503
5504 2019-05-08  Tom Tromey  <tom@tromey.com>
5505
5506         * solib-svr4.c (struct svr4_info): Add initializers and
5507         destructor.
5508         <probes_table>: Now an htab_up.
5509         (solib_svr4_pspace_data): Change type.
5510         (free_probes_table): Simplify.
5511         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5512         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5513         (probes_table_remove_objfile_probes, register_solib_event_probe)
5514         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5515         (_initialize_svr4_solib): Update.
5516
5517 2019-05-08  Tom Tromey  <tom@tromey.com>
5518
5519         * remote.c (remote_pspace_data): Change type.
5520         (remote_pspace_data_cleanup): Remove.
5521         (get_remote_exec_file, set_pspace_remote_exec_file)
5522         (_initialize_remote): Update.
5523
5524 2019-05-08  Tom Tromey  <tom@tromey.com>
5525
5526         * breakpoint.c (breakpoint_objfile_key): Change type.
5527         (get_breakpoint_objfile_data): Update.
5528         (free_breakpoint_objfile_data): Remove.
5529         (_initialize_breakpoint): Update.
5530
5531 2019-05-08  Tom Tromey  <tom@tromey.com>
5532
5533         * linux-tdep.c (struct linux_info): Add initializers.
5534         (linux_inferior_data): Move.  Change type.
5535         (invalidate_linux_cache_inf): Update.
5536         (linux_inferior_data_cleanup): Remove.
5537         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5538
5539 2019-05-08  Tom Tromey  <tom@tromey.com>
5540
5541         * auxv.c (auxv_inferior_data): Move.  Change type.
5542         (auxv_inferior_data_cleanup): Remove.
5543         (invalidate_auxv_cache_inf): Rewrite.
5544         (get_auxv_inferior_data, _initialize_auxv): Update.
5545
5546 2019-05-08  Tom Tromey  <tom@tromey.com>
5547
5548         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5549         (symfile_debug_objfile_data_key): Change type.
5550         (symfile_debug_installed, debug_qf_has_symbols)
5551         (debug_qf_find_last_source_symtab)
5552         (debug_qf_forget_cached_source_info)
5553         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5554         (debug_qf_print_stats, debug_qf_dump)
5555         (debug_qf_expand_symtabs_for_function)
5556         (debug_qf_expand_all_symtabs)
5557         (debug_qf_expand_symtabs_with_fullname)
5558         (debug_qf_map_matching_symbols)
5559         (debug_qf_expand_symtabs_matching)
5560         (debug_qf_find_pc_sect_compunit_symtab)
5561         (debug_qf_map_symbol_filenames)
5562         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5563         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5564         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5565         (debug_sym_read_linetable, debug_sym_relocate): Update.
5566         (symfile_debug_free_objfile): Remove.
5567         (install_symfile_debug_logging, _initialize_symfile_debug):
5568         Update.
5569
5570 2019-05-08  Tom Tromey  <tom@tromey.com>
5571
5572         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5573         allocate_on_obstack.
5574         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5575         (get_dwarf2_per_objfile): Update.
5576         (set_dwarf2_per_objfile): Remove.
5577         (dwarf2_has_info, dwarf2_get_section_info): Update.
5578         (dwarf2_free_objfile): Remove.
5579         (_initialize_dwarf2_read): Update.
5580
5581 2019-05-08  Tom Tromey  <tom@tromey.com>
5582
5583         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5584         initializers.
5585         <unsupported_script_warning_printed,
5586         script_not_found_warning_printed>: Now bool.
5587         (auto_load_pspace_data): Change type.
5588         (~auto_load_pspace_info): Rename from
5589         auto_load_pspace_data_cleanup.
5590         (get_auto_load_pspace_data, init_loaded_scripts_info)
5591         (clear_section_scripts, maybe_print_unsupported_script_warning)
5592         (maybe_print_script_not_found_warning, _initialize_auto_load):
5593         Update.
5594
5595 2019-05-08  Tom Tromey  <tom@tromey.com>
5596
5597         * objfiles.c (objfile_pspace_info): Add destructor and
5598         initializers.
5599         (objfiles_pspace_data): Change type.
5600         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5601         (get_objfile_pspace_data): Update.
5602         (objfiles_bfd_data): Change type.
5603         (get_objfile_bfd_data): Update.
5604         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5605
5606 2019-05-08  Tom Tromey  <tom@tromey.com>
5607
5608         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5609         Change type.
5610         (get_catch_syscall_inferior_data): Update.
5611         (catch_syscall_inferior_data_cleanup): Remove.
5612         (_initialize_break_catch_syscall): Update.
5613
5614 2019-05-08  Tom Tromey  <tom@tromey.com>
5615
5616         * inflow.c (struct terminal_info): Add destructor and
5617         initializers.
5618         (inflow_inferior_data): Change type.
5619         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5620         (get_inflow_inferior_data, inflow_inferior_exit)
5621         (swap_terminal_info, _initialize_inflow): Update.
5622
5623 2019-05-08  Tom Tromey  <tom@tromey.com>
5624
5625         * target-dcache.c (target_dcache_cleanup): Remove.
5626         (target_dcache_aspace_key): Change type.
5627         (target_dcache_init_p, target_dcache_invalidate)
5628         (target_dcache_get, target_dcache_get_or_init)
5629         (_initialize_target_dcache): Update.
5630         * dcache.h (struct dcache_deleter): New.
5631
5632 2019-05-08  Tom Tromey  <tom@tromey.com>
5633
5634         * symtab.c (struct symbol_cache): Add destructor and
5635         initializers.
5636         (symbol_cache_key): Move.  Change type.
5637         (make_symbol_cache, free_symbol_cache): Remove.
5638         (get_symbol_cache): Update.
5639         (symbol_cache_cleanup): Remove.
5640         (ALL_PSPACES, symbol_cache_flush)
5641         (maintenance_print_symbol_cache)
5642         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5643         Update.
5644
5645 2019-05-08  Tom Tromey  <tom@tromey.com>
5646
5647         * symtab.c (struct main_info): Add destructor and initializers.
5648         (main_progspace_key): Move.  Change type.
5649         (get_main_info): Update.
5650         (main_info_cleanup): Remove.
5651         (_initialize_symtab): Update.
5652
5653 2019-05-08  Tom Tromey  <tom@tromey.com>
5654
5655         * registry.h (DECLARE_REGISTRY): Define the _key class.
5656
5657 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5658
5659         * NEWS: Merge two 'New commands' sections.
5660
5661 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5662
5663         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5664         parameter and use Ada language definition instead.
5665         (ada_val_print_ptr): Remove unused language parameter.
5666         (ada_val_print_num): Remove language parameter and use Ada language
5667         definition instead.
5668         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5669         parameter.
5670         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5671         parameter and use Ada language definition instead.
5672         (ada_val_print_1): Update all ada_val_print_xxx calls.
5673         Remove language parameter.
5674         (ada_val_print): Update ada_val_print_1 call.
5675
5676 2019-05-08  Tom Tromey  <tromey@adacore.com>
5677
5678         * remote.c (remote_hw_watchpoint_limit)
5679         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5680         Now static.
5681
5682 2019-05-08  Tom Tromey  <tromey@adacore.com>
5683
5684         * maint.c (_initialize_maint_cmds): Move initialization code to
5685         remote.c.
5686         (watchdog, show_watchdog): Move to remote.c.
5687         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5688         "watchdog" static.
5689         (_initialize_remote): Move initialization code from maint.c.
5690         * defs.h (watchdog): Don't declare.
5691
5692 2019-05-08  Tom Tromey  <tromey@adacore.com>
5693
5694         * tui/tui-interp.c: Include main.h.
5695         * interps.c: Include main.h.
5696         * main.h (interpreter_p): Declare.
5697         * defs.h (interpreter_p): Don't declare.
5698
5699 2019-05-08  Tom Tromey  <tromey@adacore.com>
5700
5701         * dwarf2loc.c: Include dwarf2read.h.
5702         * defs.h (read_unsigned_leb128): Don't declare.
5703         * dwarf2read.h (read_unsigned_leb128): Declare.
5704
5705 2019-05-08  Tom Tromey  <tromey@adacore.com>
5706
5707         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5708         method.
5709
5710 2019-05-08  Tom Tromey  <tromey@adacore.com>
5711
5712         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5713         when no wrap column is set.
5714
5715 2019-05-08  Tom Tromey  <tromey@adacore.com>
5716
5717         * c-lang.c (c_get_string): Handle non-C-style arrays.
5718
5719 2019-05-08  Tom Tromey  <tromey@adacore.com>
5720
5721         * typeprint.c (print_offset_data::update): Print the bit offset,
5722         not the number of bits remaining.
5723
5724 2019-05-08  Tom Tromey  <tromey@adacore.com>
5725
5726         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5727         padding at end of comment.
5728
5729 2019-05-08  Tom Tromey  <tromey@adacore.com>
5730
5731         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5732         Compare main types.
5733
5734 2019-05-06  Tom Tromey  <tom@tromey.com>
5735
5736         * common/scoped_mmap.c: Include common-defs.h.
5737         * common/scoped_mmap.h: Don't include config.h.
5738
5739 2019-05-04  Tom Tromey  <tom@tromey.com>
5740
5741         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5742         (struct aarch64_call_info): Add initializers.
5743         <si>: Now a std::vector.
5744         (pass_on_stack, aarch64_push_dummy_call): Update.
5745
5746 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5747             Tom Tromey  <tom@tromey.com>
5748
5749         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5750         (ppc_threads): Now a std::vector.  Now static.
5751         (hwdebug_find_thread_points_by_tid)
5752         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5753         Update.
5754
5755 2019-05-04  Tom Tromey  <tom@tromey.com>
5756
5757         * arc-tdep.c (arc_tdesc_init): Return bool.
5758
5759 2019-05-04  Tom Tromey  <tom@tromey.com>
5760
5761         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5762         Use gdb_assert_not_reached.
5763
5764 2019-05-04  Tom Tromey  <tom@tromey.com>
5765
5766         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5767         "false".
5768
5769 2019-05-04  Tom Tromey  <tom@tromey.com>
5770
5771         * arc-tdep.c (arc_tdesc_init): Use bool.
5772
5773 2019-05-04  Tom Tromey  <tom@tromey.com>
5774
5775         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5776
5777 2019-05-04  Tom Tromey  <tom@tromey.com>
5778
5779         * cli/cli-cmds.c (valid_command_p): Return bool.
5780
5781 2019-05-04  Tom Tromey  <tom@tromey.com>
5782
5783         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5784         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5785
5786 2019-05-04  Raul Tambre  <raul@tambre.ee>
5787
5788         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5789         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5790         operator for comparison.
5791
5792 2019-05-04  Tom Tromey  <tom@tromey.com>
5793
5794         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5795         (lookup_partial_symbol, print_partial_symbols)
5796         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5797         (psymbol_compare): Update.
5798         (add_psymbol_to_bcache): Clear the entire psymbol.
5799         (maintenance_check_psymtabs): Update.
5800         * psympriv.h (struct partial_symbol): Don't derive from
5801         general_symbol_info.
5802         <obj_section, unrelocated_address, address,
5803         set_unrelocated_address>: Update.
5804         <ginfo>: New member.
5805         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5806         (debug_names::write_psymbols): Update.
5807
5808 2019-05-04  Tom de Vries  <tdevries@suse.de>
5809
5810         * contrib/cc-with-tweaks.sh: Support -n arg.
5811
5812 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5813
5814         * corelow.c (core_target::detach): Ensure frame cache and
5815         register caches are cleared.
5816         inferior.c (exit_inferior_1): Likewise.
5817
5818 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5819             Tom Tromey  <tom@tromey.com>
5820
5821         * dictionary.c (collate_pending_symbols_by_language): Remove
5822         "struct" from foreach.
5823         * symtab.c (lookup_global_symbol_from_objfile)
5824         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5825         foreach.
5826         * ser-tcp.c (net_open): Remove "struct" from foreach.
5827         * objfiles.c (objfile_relocate, objfile_rebase)
5828         (objfile_has_symbols): Remove "struct" from foreach.
5829         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5830         from foreach.
5831         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5832         foreach.
5833         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5834         "struct" from foreach.
5835         * ada-lang.c (create_excep_cond_exprs)
5836         (ada_exception_catchpoint_cond_string): Remove "struct" from
5837         foreach.
5838
5839 2019-05-03  Tom Tromey  <tromey@adacore.com>
5840
5841         * ada-exp.y (convert_char_literal): Check suffix of each
5842         enumerator.
5843
5844 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5845
5846         PR ada/21406:
5847         * ada-exp.y (yywrap): Don't define.
5848         * ada-lex.l (%option): Add noyywrap
5849         (yywrap): Remove.
5850
5851 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5852
5853         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5854         _WIN32_WINNT to the XP level, unless already defined to a higher
5855         level.
5856
5857         * unittests/parse-connection-spec-selftests.c:
5858         * ser-tcp.c:
5859         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5860         override.
5861
5862         * symfile.c (find_separate_debug_file): Remove colon from the
5863         drive spec of DOS/Windows file names of the target, so that the
5864         file name produced from DEBUGDIR and the target's directory will
5865         be valid on DOS/Windows systems.
5866
5867 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * rust-lang.c (val_print_struct): Handle printing structures
5870         containing strings.
5871
5872 2019-05-02  Tom Tromey  <tromey@adacore.com>
5873
5874         * valarith.c (_initialize_valarith): Remove.
5875
5876 2019-05-01  Tom Tromey  <tromey@adacore.com>
5877
5878         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5879         bitfields.
5880
5881 2019-05-01  Tom Tromey  <tromey@adacore.com>
5882
5883         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5884         for big-endian copies.
5885
5886 2019-04-30  Ali Tamur  <tamur@google.com>
5887         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5888         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5889         (read_3_bytes): New function.
5890
5891 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5892
5893         * windows-nat.c (main_thread_id): Delete.
5894         (handle_output_debug_string): Replace main_thread_id by
5895         current_event.dwThreadId.
5896         (fake_create_process): Likewise.
5897         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5898         Do not set main_thread_id.
5899         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5900         current_event.dwThreadId.
5901         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5902
5903 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5904
5905         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5906         Use current_event.dwThreadId instead of main_thread_id.
5907
5908 2019-04-30  Tom Tromey  <tromey@adacore.com>
5909
5910         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5911         (create_excep_cond_exprs): Iterate over program spaces.
5912         (ada_exception_catchpoint_cond_string): Examine all minimal
5913         symbols for exception types.
5914
5915 2019-04-30  Tom Tromey  <tromey@adacore.com>
5916
5917         PR c++/24470:
5918         * dwarf2read.c (process_structure_scope): Handle case where type
5919         has template parameters but no symbol was created.
5920
5921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5922             Chris January  <chris.january@arm.com>
5923
5924         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5925         qualifier.
5926         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5927
5928 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * f-typeprint.c (f_print_type): Update rules for printing
5931         whitespace.
5932         (f_type_print_varspec_suffix): Likewise.
5933
5934 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5935             Chris January  <chris.january@arm.com>
5936
5937         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5938         function arguments.
5939
5940 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * f-lang.c (build_fortran_types): Change name of void type to
5943         lower case.
5944         * f-typeprint.c (f_type_print_base): Print the name of the void
5945         type, rather than a fixed string.
5946         * f-valprint.c (f_decorations): Use lower case void string.
5947
5948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5949             Chris January  <chris.january@arm.com>
5950
5951         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5952         types for Fortran.
5953
5954 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5955             Chris January  <chris.january@arm.com>
5956             David Lecomber  <david.lecomber@arm.com>
5957
5958         * f-exp.y (BINOP_INTRINSIC): New token.
5959         (exp): New parser rule handling BINOP_INTRINSIC.
5960         (f77_keywords): Add new builtin procedures.
5961         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5962         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5963         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5964         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5965         (print_unop_subexp_f): New function.
5966         (print_binop_subexp_f): New function.
5967         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5968         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5969         (dump_subexp_body_f): Likewise.
5970         (operator_check_f): Likewise.
5971         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5972         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5973
5974 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5975
5976         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5977         UNOP_KIND.
5978         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5979         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5980         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5981         (operator_length_f): New fuction.
5982         (print_subexp_f): New function.
5983         (op_name_f): New function.
5984         (dump_subexp_body_f): New function.
5985         (operator_check_f): New function.
5986         (exp_descriptor_f): Replace standard expression handling functions
5987         with new functions.
5988         * gdb/fortran-operator.def: New file.
5989         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5990         * gdb/std-operator.def: Remove UNOP_KIND.
5991
5992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5993
5994         * std-operator.def: Remove unbalanced, stray double quote
5995         character.
5996
5997 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5998             Chris January  <chris.january@arm.com>
5999             Daniel Everett  <daniel.everett@arm.com>
6000             Nick Forrington  <nick.forrington@arm.com>
6001             Richard Bunt  <richard.bunt@arm.com>
6002
6003         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6004         of depth when printing anonymous structs or unions.
6005         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6006         Don't print either the top-level value, or the children if the
6007         max-depth is exceeded.
6008         (ppscm_print_children): When printing the key of a map, allow one
6009         extra level of depth.
6010         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6011         print either the top-level value, or the children if the max-depth
6012         is exceeded.
6013         (print_children): When printing the key of a map, allow one extra
6014         level of depth.
6015         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6016         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6017         (user_print_options): Initialise max_depth field.
6018         (val_print_scalar_or_string_type_p): New function.
6019         (val_print): Check to see if the max depth has been reached.
6020         (val_print_check_max_depth): Define new function.
6021         (show_print_max_depth): New function.
6022         (_initialize_valprint): Add 'print max-depth' option.
6023         * valprint.h (struct value_print_options) <max_depth>: New field.
6024         (val_print_check_max_depth): Declare new function.
6025         * NEWS: Document new feature.
6026
6027 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * ada-lang.c (ada_language_defn): Initialise new field.
6030         * c-lang.c (c_is_string_type_p): New function.
6031         (c_language_defn): Initialise new field.
6032         (cplus_language_defn): Initialise new field.
6033         (asm_language_defn): Initialise new field.
6034         (minimal_language_defn): Initialise new field.
6035         * c-lang.h (c_is_string_type_p): Declare new function.
6036         * d-lang.c (d_language_defn): Initialise new field.
6037         * f-lang.c (f_is_string_type_p): New function.
6038         (f_language_defn): Initialise new field.
6039         * go-lang.c (go_is_string_type_p): New function.
6040         (go_language_defn): Initialise new field.
6041         * language.c (default_is_string_type_p): New function.
6042         (unknown_language_defn): Initialise new field.
6043         (auto_language_defn): Initialise new field.
6044         * language.h (struct language_defn) <la_is_string_type_p>: New
6045         member variable.
6046         (default_is_string_type_p): Declare new function.
6047         * m2-lang.c (m2_language_defn): Initialise new field.
6048         * objc-lang.c (objc_language_defn): Initialise new field.
6049         * opencl-lang.c (opencl_language_defn): Initialise new field.
6050         * p-lang.c (pascal_is_string_type_p): New function.
6051         (pascal_language_defn): Initialise new field.
6052         * rust-lang.c (rust_is_string_type_p): New function.
6053         (rust_language_defn): Initialise new field.
6054
6055 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6058         New field.
6059         * ada-lang.c (ada_language_defn): Initialise new field.
6060         * c-lang.c (c_language_defn): Likewise.
6061         (cplus_language_defn): Likewise.
6062         (asm_language_defn): Likewise.
6063         (minimal_language_defn): Likewise.
6064         * d-lang.c (d_language_defn): Likewise.
6065         * f-lang.c (f_language_defn): Likewise.
6066         * go-lang.c (go_language_defn): Likewise.
6067         * language.c (unknown_language_defn): Likewise.
6068         (auto_language_defn): Likewise.
6069         * m2-lang.c (m2_language_defn): Likewise.
6070         * objc-lang.c (objc_language_defn): Likewise.
6071         * opencl-lang.c (opencl_language_defn): Likewise.
6072         * p-lang.c (pascal_language_defn): Likewise.
6073         * rust-lang.c (rust_language_defn): Likewise.
6074
6075 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6076
6077         * ada-lang.c (ada_is_character_type): Change return type to bool.
6078         (ada_is_string_type): Likewise.
6079         * ada-lang.h (ada_is_character_type): Update declaration
6080         (ada_is_string_type): Likewise.
6081
6082 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6083
6084         Support style in 'frame|thread apply'
6085
6086         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6087         * record.c (record_start, record_stop): Update callers of
6088         execute_command_to_string with false.
6089         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6090         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6091         methods.
6092         (class string_file): New constructor with term_out parameter.
6093         Override methods term_out and can_emit_style_escape.  New member
6094         term_out.
6095         (class stdio_file): Override can_emit_style_escape.
6096         (class tee_file): Override term_out and can_emit_style_escape.
6097         * utils.h (can_emit_style_escape): Remove.
6098         * utils.c (can_emit_style_escape): Likewise.
6099         Update all callers of can_emit_style_escape (SOMESTREAM) to
6100         SOMESTREAM->can_emit_style_escape.
6101         * source-cache.c (source_cache::get_source_lines): Likewise.
6102         * stack.c (frame_apply_command_count): Call execute_command_to_string
6103         passing the term_out characteristic of the current gdb_stdout.
6104         * thread.c (thr_try_catch_cmd): Likewise.
6105         * top.c (execute_command_to_string): pass term_out parameter
6106         to construct the string_file for the command output.
6107         * ui-file.c (term_cli_styling): New function (most code moved
6108         from utils.c can_emit_style_escape).
6109         (string_file::string_file, string_file::can_emit_style_escape,
6110         stdio_file::can_emit_style_escape, tee_file::term_out,
6111         tee_file::can_emit_style_escape): New functions.
6112
6113 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6114
6115         * NEWS: Mention the new set|show may-call-functions.
6116         * infcall.c (may_call_functions_p): New variable.
6117         (show_may_call_functions_p): New function.
6118         (call_function_by_hand_dummy): Throws an error if not
6119         may-call-functions.
6120         (_initialize_infcall): Call add_setshow_boolean_cmd for
6121         may-call-functions.
6122
6123 2019-04-25  Keith Seitz  <keiths@redhat.com>
6124
6125         PR c++/24367
6126         * cp-support.c (inspect_type): Don't attempt substitutions
6127         of symbol with the same name.
6128
6129 2019-04-25  Tom Tromey  <tromey@adacore.com>
6130
6131         PR gdb/24475:
6132         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6133         static.
6134
6135 2019-04-25  Tom Tromey  <tromey@adacore.com>
6136
6137         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6138         rvalue reference.
6139         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6140         (gdb_xml_parser::parse): Use std::move.
6141         * python/python-internal.h (gdbpy_convert_exception): Take a const
6142         reference.
6143         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6144         std::move.
6145         * python/py-utils.c (gdbpy_convert_exception): Take a const
6146         reference.
6147         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6148         Use std::move.
6149         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6150         Use std::move.
6151         * mi/mi-main.c (mi_print_exception): Take a const reference.
6152         * main.c (handle_command_errors): Take a const reference.
6153         * linespec.c (parse_linespec): Use std::move.
6154         * infcall.c (run_inferior_call): Use std::move.
6155         (call_function_by_hand_dummy): Use std::move.
6156         * exec.c (try_open_exec_file): Use std::move.
6157         * exceptions.h (exception_print, exception_fprintf)
6158         (exception_print_same): Update.
6159         * exceptions.c (print_exception, exception_print)
6160         (exception_fprintf, exception_print_same): Change parameters to
6161         const reference.
6162         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6163         * common/new-op.c: Use std::move.
6164         * common/common-exceptions.h (struct gdb_exception): Add move
6165         constructor.
6166         (struct gdb_exception_error, struct gdb_exception_quit, struct
6167         gdb_quit_bad_alloc): Change constructor to move constructor.
6168         (throw_exception): Change parameter to rvalue reference.
6169         * common/common-exceptions.c (throw_exception): Take rvalue
6170         reference.
6171         * cli/cli-interp.c (safe_execute_command): Use std::move.
6172         * breakpoint.c (insert_bp_location, location_to_sals): Use
6173         std::move.
6174
6175 2019-04-25  Tom Tromey  <tromey@adacore.com>
6176
6177         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6178         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6179         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6180         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6181         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6182         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6183         guile/scm-value.c: Use unpack.
6184         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6185         gdbscm_gdb_exception.
6186         (gdbscm_throw_gdb_exception): Likewise.
6187         (struct gdbscm_gdb_exception): New.
6188         (unpack): New function.
6189         (gdbscm_wrap): Use unpack.
6190
6191 2019-04-25  Tom Tromey  <tromey@adacore.com>
6192
6193         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6194         (gdb_rl_callback_handler): Use std::move.
6195         * common/common-exceptions.h (struct gdb_exception): Add move
6196         assignment operator.
6197         (throw_exception_sjlj): Change "exception" to const reference.
6198         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6199         (throw_exception_sjlj): Change "exception" to const reference.
6200
6201 2019-04-25  Tom Tromey  <tromey@adacore.com>
6202
6203         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6204         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6205         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6206         Update.
6207         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6208         Update.
6209         * mi/mi-interp.c (mi_interp::exec): Update.
6210         * linespec.c (parse_linespec): Update.
6211         * infcall.c (run_inferior_call): Update.
6212         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6213         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6214         (gdbscm_lookup_global_symbol): Update.
6215         * guile/scm-param.c (gdbscm_parameter_value): Update.
6216         * guile/scm-frame.c (gdbscm_frame_read_register)
6217         (gdbscm_frame_read_var): Update.
6218         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6219         * exec.c (try_open_exec_file): Update.
6220         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6221         (gdb_rl_callback_handler): Update.
6222         * common/common-exceptions.h (exception_none): Don't declare.
6223         * common/common-exceptions.c (exception_none): Don't define.
6224         (struct catcher) <exception>: Update.
6225         * cli/cli-interp.c (safe_execute_command): Update.
6226         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6227
6228 2019-04-25  Ali Tamur  <tamur@google.com>
6229
6230         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6231         (read_attribute_value): Likewise.
6232         (dwarf2_read_addr_index): Update comment.
6233         (read_str_index): Add DW_FORM_strx.
6234         (dwarf2_string_attr): Likewise.
6235         (dwarf2_const_value_attr): Likewise.
6236         (dump_die_shallow): Likewise.
6237         (dwarf2_fetch_constant_bytes): Likewise.
6238         (skip_form_bytes): Likewise.
6239         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6240
6241 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6242
6243         PR corefiles/11608
6244         PR corefiles/18187
6245         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6246         OFFSET.  Verify if current mapping contains an ELF header.
6247         (linux_find_memory_regions_full): Adjust call to
6248         dump_mapping_p.
6249
6250 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6251             Kang Li <kanglictf@gmail.com>
6252
6253         PR gdb/21600
6254
6255         * dwarf2-frame.c (read_initial_length): Be consistent about using
6256         unsigned representation of length.
6257         (decode_frame_entry_1): Likewise.  Check for wraparound of
6258         end pointer as well as buffer overflow.
6259
6260 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6261
6262         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6263         "vq".
6264
6265 2019-04-24  Tom Tromey  <tromey@adacore.com>
6266
6267         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6268
6269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6270
6271         * s12z-tdep.c (s12z_unwind_pc): Delete.
6272         (s12z_unwind_sp): Delete.
6273         (s12z_gdbarch_init): Don't register deleted functions with
6274         gdbarch.
6275
6276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * rl78-tdep.c (rl78_unwind_sp): Delete.
6279         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6280
6281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6282
6283         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6284         (xstormy16_unwind_pc): Delete.
6285         (xstormy16_dummy_id): Delete.
6286         (xstormy16_gdbarch_init): Don't register deleted functions with
6287         gdbarch.
6288
6289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6290
6291         * vax-tdep.c (vax_unwind_pc): Delete.
6292         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6293
6294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * v850-tdep.c (v850_unwind_sp): Delete.
6297         (v850_unwind_pc): Delete.
6298         (v850_dummy_id): Delete.
6299         (v850_gdbarch_init): Don't register deleted functions with
6300         gdbarch.
6301
6302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6305         (tilegx_unwind_pc): Delete.
6306         (tilegx_unwind_dummy_id): Delete.
6307         (tilegx_gdbarch_init): Don't register deleted functions with
6308         gdbarch.
6309
6310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6311
6312         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6313         (tic6x_dummy_id): Delete.
6314         (tic6x_gdbarch_init): Don't register deleted functions with
6315         gdbarch.
6316
6317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * sparc-tdep.c (sparc_unwind_pc): Delete.
6320         (sparc32_gdbarch_init): Don't register deleted function with
6321         gdbarch.
6322
6323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6324
6325         * sh-tdep.c (sh_unwind_sp): Delete.
6326         (sh_unwind_pc): Delete.
6327         (sh_dummy_id): Delete.
6328         (sh_gdbarch_init): Don't register deleted functions with
6329         gdbarch.
6330
6331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6332
6333         * score-tdep.c (score_unwind_sp): Delete.
6334         (score_unwind_pc): Delete.
6335         (score_dummy_id): Delete.
6336         (score_gdbarch_init): Don't register deleted functions with
6337         gdbarch.
6338
6339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6340
6341         * rx-tdep.c (rx_unwind_pc): Delete.
6342         (rx_unwind_sp): Delete.
6343         (rx_dummy_id): Delete.
6344         (rx_gdbarch_init): Don't register deleted functions with
6345         gdbarch.  Update comment.
6346
6347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6350         (rs6000_dummy_id): Delete.
6351         (rs6000_gdbarch_init): Don't register deleted functions with
6352         gdbarch.
6353
6354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * or1k-tdep.c (or1k_dummy_id): Delete.
6357         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6358
6359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6360
6361         * nios2-tdep.c (nios2_dummy_id): Delete.
6362         (nios2_unwind_sp): Delete.
6363         (nios2_gdbarch_init): Don't register deleted functions with
6364         gdbarch.
6365
6366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * nds32-tdep.c (nds32_dummy_id): Delete.
6369         (nds32_unwind_pc): Delete.
6370         (nds32_unwind_sp): Delete.
6371         (nds32_gdbarch_init): Don't register deleted functions with
6372         gdbarch.
6373
6374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * msp430-tdep.c (msp430_unwind_pc): Delete.
6377         (msp430_unwind_sp): Delete.
6378         (msp430_dummy_id): Delete.
6379         (msp430_gdbarch_init): Don't register deleted functions with
6380         gdbarch.
6381
6382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6383
6384         * moxie-tdep.c (moxie_unwind_sp): Delete.
6385         (moxie_unwind_pc): Delete.
6386         (moxie_dummy_id): Delete.
6387         (moxie_gdbarch_init): Don't register deleted functions with
6388         gdbarch.
6389
6390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6391
6392         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6393         (mn10300_unwind_pc): Delete.
6394         (mn10300_unwind_sp): Delete.
6395         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6396         mn10300_unwind_sp.
6397         (mn10300_frame_unwind_init): Don't register deleted functions with
6398         gdbarch.
6399
6400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * mep-tdep.c (mep_unwind_pc): Delete.
6403         (mep_unwind_sp): Delete.
6404         (mep_dummy_id): Delete.
6405         (mep_gdbarch_init): Don't register deleted functions with
6406         gdbarch.
6407
6408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6411         (m68hc11_unwind_sp): Delete.
6412         (m68hc11_gdbarch_init): Don't register deleted functions with
6413         gdbarch.
6414
6415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * m32r-tdep.c (m32r_unwind_sp): Delete.
6418         (m32r_unwind_pc): Delete.
6419         (m32r_dummy_id): Delete.
6420         (m32r_gdbarch_init): Don't register deleted functions with
6421         gdbarch.
6422
6423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * m32c-tdep.c (m32c_unwind_pc): Delete.
6426         (m32c_unwind_sp): Delete.
6427         (m32c_dummy_id): Delete.
6428         (m32c_gdbarch_init): Don't register deleted functions with
6429         gdbarch.
6430
6431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6432
6433         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6434         (lm32_unwind_pc): Delete.
6435         (lm32_dummy_id): Delete.
6436         (lm32_gdbarch_init): Don't register deleted functions with
6437         gdbarch.
6438
6439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6440
6441         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6442         (iq2000_unwind_pc): Delete.
6443         (iq2000_dummy_id): Delete.
6444         (iq2000_gdbarch_init): Don't register deleted functions with
6445         gdbarch.
6446
6447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6448
6449         * nds32-tdep.c (nds32_type_align): Delete.
6450         (nds32_push_dummy_call): Use type_align instead.
6451
6452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6453
6454         * arm-tdep.c (arm_type_align): Only handle vector override case.
6455         (arm_push_dummy_call): Use type_align.
6456         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6457
6458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6461         case.
6462         (pass_on_stack): Use type_align.
6463         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6464         function.
6465
6466 2019-04-23  Tom Tromey  <tromey@adacore.com>
6467
6468         * dwarf2read.c (line_header::file_name_at): Remove unused
6469         overload.
6470
6471 2019-04-23  Tom de Vries  <tdevries@suse.de>
6472
6473         PR gdb/24438
6474         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6475         invocation.
6476
6477
6478 2019-03-27  Ali Tamur  <tamur@google.com>
6479
6480         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6481         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6482         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6483         (dwarf_expr_context::get_addr_index): Likewise
6484         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6485         (symbol_needs_eval_context::get_addr_index): Likewise
6486         (disassemble_dwarf_expression): Add DW_OP_addrx
6487         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6488         (read_cutu_die_from_dwo): Update comment
6489         (skip_one_die): Add DW_FORM_addrx
6490         (read_attribute_value): Likewise
6491         (var_decode_location): Add DW_OP_addrx
6492         (dwarf2_const_value_attr): Add DW_FORM_addrx
6493         (dump_die_shallow): Likewise
6494         (dwarf2_fetch_constant_bytes): Likewise
6495         (decode_locdesc): Add DW_OP_addrx
6496         (skip_form_bytes): Add DW_FORM_addrx
6497
6498 2019-04-22  Ali Tamur  <tamur@google.com>
6499
6500         * MAINTAINERS (Write After Approval): Add self.
6501
6502 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6503
6504         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6505         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6506         (open_symbol_file_object): Likewise.
6507         (svr4_default_sos): Add info parameter.
6508         (svr4_read_so_list): Likewise.
6509         (svr4_current_sos_direct): Adjust functions calls to pass down
6510         info.
6511         (svr4_current_sos_1): Add info parameter.
6512         (svr4_current_sos): Call get_svr4_info, pass info down to
6513         svr4_current_sos_1.
6514         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6515         get_svr4_info.
6516         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6517         get_svr4_info.
6518         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6519         to get_svr4_info.
6520         (probes_table_remove_objfile_probes): Likewise.
6521         (register_solib_event_probe): Add info parameter.
6522         (solist_update_incremental): Pass info parameter down to
6523         svr4_read_so_list.
6524         (disable_probes_interface): Add info parameter.
6525         (svr4_handle_solib_event): Pass current_program_space to
6526         get_svr4_info.  Adjust disable_probes_interface cleanup.
6527         (svr4_create_probe_breakpoints): Add info parameter, pass it
6528         down to register_solib_event_probe.
6529         (svr4_create_solib_event_breakpoints): Add info parameter,
6530         pass it down to svr4_create_probe_breakpoints.
6531         (enable_break): Pass info down to
6532         svr4_create_solib_event_breakpoints.
6533         (svr4_solib_create_inferior_hook): Pass current_program_space to
6534         get_svr4_info.
6535         (svr4_clear_solib): Likewise.
6536
6537 2019-04-22  Pedro Alves  <palves@redhat.com>
6538
6539         * solib-svr4.c (svr4_free_objfile_observer): New.
6540         (probe_and_action::objfile): New field.
6541         (probes_table_htab_remove_objfile_probes)
6542         (probes_table_remove_objfile_probes): New functions.
6543         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6544         in the new probe_and_action.  Don't store the probe in 'lookup'.
6545         (svr4_create_probe_breakpoints): Pass objfile to
6546         register_solib_event_probe.
6547         (_initialize_svr4_solib): Register a free_objfile observer.
6548
6549 2019-04-19  Tom Tromey  <tom@tromey.com>
6550
6551         * common/queue.h: Remove.
6552
6553 2019-04-19  Tom Tromey  <tom@tromey.com>
6554
6555         * event-loop.c: Don't include "common/queue.h".
6556
6557 2019-04-19  Tom Tromey  <tom@tromey.com>
6558
6559         * remote.c (remote_target): Use delete.
6560         * remote-notif.h: Include <list>, not "common/queue.h".
6561         (notif_client_p): Remove typedef.
6562         (remote_notif_state): Add constructor, destructor, initializer.
6563         <notif_queue>: Now a std::list.
6564         (remote_notif_state_xfree): Don't declare.
6565         * remote-notif.c (remote_notif_process, handle_notification)
6566         (remote_notif_state_allocate): Update.
6567         (~remote_notif_state): Rename from remote_notif_state_xfree.
6568
6569 2019-04-19  Tom Tromey  <tom@tromey.com>
6570
6571         * symfile.c (reread_symbols): Update.
6572         * objfiles.c (objfile_register_static_link)
6573         (objfile_lookup_static_link): Update
6574         (~objfile) Don't delete static_links.
6575         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6576
6577 2019-04-19  Tom Tromey  <tom@tromey.com>
6578
6579         * type-stack.h (struct type_stack) <insert>: Constify string.
6580         * type-stack.c (type_stack::insert): Constify string.
6581         * gdbtypes.h (lookup_template_type): Update.
6582         (address_space_name_to_int): Update.
6583         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6584         const.
6585         (lookup_template_type): Make name const.
6586         * c-exp.y: Update rules.
6587         (lex_one_token, classify_name, classify_inner_name)
6588         (c_print_token): Update.
6589         * p-exp.y: Update rules.
6590         (yylex): Update.
6591         * f-exp.y: Update rules.
6592         (yylex): Update.
6593         * d-exp.y: Update rules.
6594         (lex_one_token, classify_name, classify_inner_name): Update.
6595         * parse.c (write_dollar_variable, copy_name): Return std::string.
6596         * parser-defs.h (copy_name): Change return type.
6597         * m2-exp.y: Update rules.
6598         (yylex): Update.
6599         * go-exp.y (lex_one_token): Update.
6600         Update rules.
6601         (classify_unsafe_function, classify_packaged_name)
6602         (classify_name, yylex): Update.
6603
6604 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6605
6606         * configure.ac: add --enable-source-highlight switch.
6607         * configure: Regenerate.
6608         * top.c (print_gdb_version): plumb --enable-source-highlight
6609         status to "show configuration".
6610
6611 2019-04-19  Tom Tromey  <tromey@adacore.com>
6612
6613         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6614         Check ADA_TYPE_P.
6615         (empty_record, ada_template_to_fixed_record_type_1)
6616         (template_to_static_fixed_type)
6617         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6618         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6619         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6620         macros.
6621
6622 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6623
6624         PR symtab/24423:
6625         * source.c (print_source_lines_base): Advance "iter" when a
6626         control character is seen.
6627
6628 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6629
6630         * inferior.h (struct infcall_suspend_state_deleter):
6631         Catch exception in destructor to avoid crash.
6632
6633 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6634
6635         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6636         close to the add_com "shell".
6637
6638 2019-04-18  Tom Tromey  <tromey@adacore.com>
6639
6640         * process-stratum-target.h (class process_stratum_target)
6641         <stratum>: Add "final".
6642
6643 2019-04-17  Tom Tromey  <tromey@adacore.com>
6644
6645         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6646         against nullptr before use.
6647
6648 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6649
6650         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6651
6652 2019-04-17  Jim Wilson  <jimw@sifive.com>
6653             Andrew Burgess  <andrew.burgess@embecosm.com>
6654
6655         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6656         code read might fail, assume 4-byte breakpoint in that case.
6657
6658 2019-04-15  Leszek Swirski  <leszeks@google.com>
6659
6660         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6661         rather than a hand-rolled POD check when checking for forced MEMORY
6662         classification.
6663
6664 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6665
6666         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6667         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6668         function.
6669         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6670         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6671         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6672         declaration.
6673
6674 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6675
6676         * aarch64-linux-nat.c
6677         (aarch64_linux_nat_target::thread_architecture): Add override.
6678         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6679         each VQ.
6680
6681 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6682
6683         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6684
6685 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6686
6687         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6688         target types of size 96-bits, add some additional comments, and
6689         check that the builtin type we found was the correct size.
6690
6691 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6692
6693         * utils.c (prompt_for_continue): Don't restore the styling at the
6694         end, as applied_style has the wrong value.  This fixes styling in
6695         long lists of file names that are interrupted by the "Continue?"
6696         prompt.
6697
6698 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6699
6700         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6701         * c-lang.c (c_language_defn): Likewise.
6702         (cplus_language_defn): Likewise.
6703         (asm_language_defn): Likewise.
6704         (minimal_language_defn): Likewise.
6705         * d-lang.c (d_language_defn): Likewise.
6706         * f-lang.c (f_language_defn): Likewise.
6707         * go-lang.c (go_language_defn): Likewise.
6708         * language.c (unknown_language_defn): Likewise.
6709         (auto_language_defn): Likewise.
6710         * language.h (struct language_defn): Remove la_magic field.
6711         (LANG_MAGIC): Delete.
6712         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6713         * objc-lang.c (objc_language_defn): Likewise.
6714         * opencl-lang.c (opencl_language_defn): Likewise.
6715         * p-lang.c (pascal_language_defn): Likewise.
6716         * rust-lang.c (rust_language_defn): Likewise.
6717
6718 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6719
6720         * riscv-tdep.c (riscv_type_align): New function.
6721         (riscv_type_alignment): Delete.
6722         (riscv_arg_location): Use 'type_align'.
6723         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6724
6725 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * gdbtypes.c (type_align): A struct with no non-static fields also
6728         has alignment of 1.
6729
6730 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6733         component to 0.
6734         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6735         member.
6736         (riscv_struct_info::analyse): New implementation using new
6737         analyse_inner member function.
6738         (riscv_struct_info::field_offset): New member function.
6739         (riscv_struct_info::m_offsets): New member variable.
6740         (riscv_struct_info::analyse_inner): New private member function,
6741         takes the old implementation of riscv_struct_info::analyse but
6742         extended to track field offsets.
6743         (riscv_call_arg_struct): Update the struct folding special cases
6744         to handle cases where empty C++ structs, which are non-zero
6745         length, are found.
6746         (riscv_arg_location): Initialise the length of each location, a
6747         non-zero length now indicates the location is in use.
6748         (riscv_push_dummy_call): Allow for the first location having a
6749         non-zero offset when setting up arguments.
6750         (riscv_return_value): Likewise, but for return values.
6751
6752 2019-04-11  Tom Tromey  <tromey@adacore.com>
6753
6754         * utils.c (internal_vproblem): Make "msg" const.
6755
6756 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6757
6758         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6759         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6760         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6761         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6762
6763 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6764
6765         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6766         function.
6767         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6768         of amd64_collect_native_gregset.
6769         (amd64_linux_nat_target::store_registers): Likewise.
6770
6771 2019-04-10  Tom Tromey  <tom@tromey.com>
6772
6773         * symtab.c (lookup_global_symbol_from_objfile)
6774         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6775         * objfiles.h (class separate_debug_iterator): New.
6776         (class separate_debug_range): New.
6777         (struct objfile) <separate_debug_objfiles>: New method.
6778         (objfile_separate_debug_iterate): Don't declare.
6779         * objfiles.c (separate_debug_iterator::operator++): Rename from
6780         objfile_separate_debug_iterate.
6781         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6782         iterator.
6783         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6784         iterator.
6785
6786 2019-04-10  Tom Tromey  <tom@tromey.com>
6787
6788         * symfile.c (reread_symbols): Remove old comment.
6789         * objfiles.c (free_all_objfiles): Fix a typo.
6790
6791 2019-04-10  Tom Tromey  <tom@tromey.com>
6792
6793         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6794         * minsyms.c (lookup_minimal_symbol): Use foreach.
6795         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6796         (lookup_minimal_symbol_solib_trampoline): Likewise.
6797         * symfile.c (reread_symbols): Use foreach.
6798
6799 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6800             Tom Tromey  <tromey@adacore.com>
6801
6802         PR rust/24414:
6803         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6804         (rust_lex_int_test): Change "value" to be LONGEST.
6805         (rust_lex_tests): Add test for long integer literal.
6806
6807 2019-04-09  Tom Tromey  <tromey@adacore.com>
6808
6809         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6810         to bool.
6811         (extended_remote_target::attach): Update.
6812         (remote_target::remote_notice_new_inferior): Update.
6813         (remote_target::add_current_inferior_and_thread): Update.
6814         * inferior.c (exit_inferior_1): Use "false".
6815         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6816
6817 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6818
6819         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6820         the "start" command.
6821
6822 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6823
6824         * python/py-inferior.c (infpy_thread_from_thread_handle):
6825         Adjust comments to reflect renaming of thread_from_thread_handle
6826         to thread_from_handle.  Adjust keywords.  Fix type error message.
6827         (inferior_object_methods): Add thread_from_handle.  Retain
6828         thread_from_thread_handle, but mark it as deprecated.
6829
6830 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6831
6832         * gdbthread.h (find_thread_by_handle): Revise declaration.
6833         * thread.c (find_thread_by_handle): Likewise.  Adjust
6834         implementation too.
6835         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6836         support for buffer objects as handles.
6837
6838 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6839
6840         * python/py-infthread.c (thpy_thread_handle): New function.
6841         (thread_object_methods): Register thpy_thread_handle.
6842
6843 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6844
6845         * gdbthread.h (thread_to_thread_handle): Declare.
6846         * thread.c (gdbtypes.h): Include.
6847         (thread_to_thread_handle): New function.
6848
6849         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6850         (target_thread_info_to_thread_handle): Declare.
6851         * target.c (target_thread_info_to_thread_handle): New function.
6852         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6853         * target-delegates.c: Regenerate.
6854
6855         * linux-thread-db.c (class thread_db_target): Add method
6856         thread_info_to_thread_handle.
6857         (thread_db_target::thread_info_to_thread_handle): Define.
6858         * remote.c (class remote_target): Add new method
6859         thread_info_to_thread_handle.
6860         (remote_target::thread_info_to_thread_handle): Define.
6861
6862 2019-04-08  Pedro Alves  <palves@redhat.com>
6863
6864         * common/common-exceptions.c (throw_exception): Don't create
6865         named object to throw; throw directly.
6866         (throw_it): Likewise.  Don't initialize gdb_exception::message
6867         here, with new; pass FMT and AP to the ctor instead.
6868         * common/common-exceptions.h: Include <string>.
6869         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6870         const char *, va_list)): New ctor.  Use std::make_shared.
6871         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6872         errors)): Delete.
6873         (gdb_exception_error::gdb_exception_error(enum errors, const char
6874         *, va_list)): New.
6875         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6876         Add assertion.
6877         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6878         errors)): Delete.
6879         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6880         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6881         Add assertion.
6882
6883 2019-04-08  Tom Tromey  <tom@tromey.com>
6884
6885         * valops.c (value_rtti_indirect_type): Replace throw_exception
6886         with throw.
6887         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6888         with throw.
6889         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6890         throw.
6891         * target.c (target_translate_tls_address): Replace throw_exception
6892         with throw.
6893         * stack.c (frame_apply_command_count): Replace throw_exception
6894         with throw.
6895         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6896         throw.
6897         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6898         with throw.
6899         * rs6000-tdep.c (rs6000_frame_cache)
6900         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6901         * remote.c: Replace throw_exception with throw.
6902         * record-full.c (record_full_message, record_full_wait_1)
6903         (record_full_restore): Replace throw_exception with throw.
6904         * record-btrace.c:
6905         (get_thread_current_frame_id, record_btrace_start_replaying)
6906         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6907         (cmd_record_btrace_start): Replace throw_exception with throw.
6908         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6909         throw.
6910         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6911         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6912         * linespec.c:
6913         (find_linespec_symbols): Replace throw_exception with throw.
6914         * infrun.c (displaced_step_prepare, resume): Replace
6915         throw_exception with throw.
6916         * infcmd.c (post_create_inferior): Replace throw_exception with
6917         throw.
6918         * inf-loop.c (inferior_event_handler): Replace throw_exception
6919         with throw.
6920         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6921         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6922         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6923         (get_prev_frame_always, get_frame_pc_if_available)
6924         (get_frame_address_in_block_if_available, get_frame_language):
6925         Replace throw_exception with throw.
6926         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6927         throw_exception with throw.
6928         * eval.c (fetch_subexp_value, evaluate_var_value)
6929         (evaluate_funcall, evaluate_subexp_standard): Replace
6930         throw_exception with throw.
6931         * dwarf2loc.c (call_site_find_chain)
6932         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6933         Replace throw_exception with throw.
6934         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6935         with throw.
6936         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6937         throw.
6938         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6939         * completer.c (complete_line_internal): Replace throw_exception
6940         with throw.
6941         * compile/compile-object-run.c (compile_object_run): Replace
6942         throw_exception with throw.
6943         * cli/cli-script.c (process_next_line): Replace throw_exception
6944         with throw.
6945         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6946         (btrace_enable, btrace_maint_update_pt_packets): Replace
6947         throw_exception with throw.
6948         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6949         throw_exception with throw.
6950         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6951         throw_exception with throw.
6952         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6953         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6954         * aarch64-tdep.c (aarch64_make_prologue_cache)
6955         (aarch64_make_stub_cache): Replace throw_exception with throw.
6956
6957 2019-04-08  Tom Tromey  <tom@tromey.com>
6958
6959         * common/common-exceptions.c (throw_exception): Rename from
6960         throw_exception_cxx.  Remove old copy.  Make argument const.
6961         (throw_it): Create and throw exception objects directly.
6962         * common/common-exceptions.h (throw_exception): Make argument
6963         const.
6964         (struct gdb_exception_error): Add constructor.
6965         (struct gdb_exception_quit): Add constructor.
6966
6967 2019-04-08  Tom Tromey  <tom@tromey.com>
6968
6969         * common/common-exceptions.h (exception_rethrow): Don't declare.
6970         (TRY_SJLJ): Update comment.
6971         (TRY, CATCH, END_CATCH): Remove.
6972         * common/common-exceptions.c (exception_rethrow): Remove.
6973
6974 2019-04-08  Tom Tromey  <tom@tromey.com>
6975
6976         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6977         Remove.
6978         (gdb_exception_error): Rename from
6979         gdb_exception_RETURN_MASK_ERROR.
6980         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6981         (gdb_quit_bad_alloc): Update.
6982         * aarch64-tdep.c: Update.
6983         * ada-lang.c: Update.
6984         * ada-typeprint.c: Update.
6985         * ada-valprint.c: Update.
6986         * amd64-tdep.c: Update.
6987         * arch-utils.c: Update.
6988         * break-catch-throw.c: Update.
6989         * breakpoint.c: Update.
6990         * btrace.c: Update.
6991         * c-varobj.c: Update.
6992         * cli/cli-cmds.c: Update.
6993         * cli/cli-interp.c: Update.
6994         * cli/cli-script.c: Update.
6995         * common/common-exceptions.c: Update.
6996         * common/new-op.c: Update.
6997         * common/selftest.c: Update.
6998         * compile/compile-c-symbols.c: Update.
6999         * compile/compile-cplus-symbols.c: Update.
7000         * compile/compile-object-load.c: Update.
7001         * compile/compile-object-run.c: Update.
7002         * completer.c: Update.
7003         * corelow.c: Update.
7004         * cp-abi.c: Update.
7005         * cp-support.c: Update.
7006         * cp-valprint.c: Update.
7007         * darwin-nat.c: Update.
7008         * disasm-selftests.c: Update.
7009         * dtrace-probe.c: Update.
7010         * dwarf-index-cache.c: Update.
7011         * dwarf-index-write.c: Update.
7012         * dwarf2-frame-tailcall.c: Update.
7013         * dwarf2-frame.c: Update.
7014         * dwarf2loc.c: Update.
7015         * dwarf2read.c: Update.
7016         * eval.c: Update.
7017         * event-loop.c: Update.
7018         * event-top.c: Update.
7019         * exec.c: Update.
7020         * f-valprint.c: Update.
7021         * fbsd-tdep.c: Update.
7022         * frame-unwind.c: Update.
7023         * frame.c: Update.
7024         * gdbtypes.c: Update.
7025         * gnu-v3-abi.c: Update.
7026         * guile/guile-internal.h: Update.
7027         * guile/scm-block.c: Update.
7028         * guile/scm-breakpoint.c: Update.
7029         * guile/scm-cmd.c: Update.
7030         * guile/scm-disasm.c: Update.
7031         * guile/scm-frame.c: Update.
7032         * guile/scm-lazy-string.c: Update.
7033         * guile/scm-math.c: Update.
7034         * guile/scm-param.c: Update.
7035         * guile/scm-ports.c: Update.
7036         * guile/scm-pretty-print.c: Update.
7037         * guile/scm-symbol.c: Update.
7038         * guile/scm-symtab.c: Update.
7039         * guile/scm-type.c: Update.
7040         * guile/scm-value.c: Update.
7041         * i386-linux-tdep.c: Update.
7042         * i386-tdep.c: Update.
7043         * inf-loop.c: Update.
7044         * infcall.c: Update.
7045         * infcmd.c: Update.
7046         * infrun.c: Update.
7047         * jit.c: Update.
7048         * language.c: Update.
7049         * linespec.c: Update.
7050         * linux-fork.c: Update.
7051         * linux-nat.c: Update.
7052         * linux-tdep.c: Update.
7053         * linux-thread-db.c: Update.
7054         * main.c: Update.
7055         * mi/mi-cmd-break.c: Update.
7056         * mi/mi-cmd-stack.c: Update.
7057         * mi/mi-interp.c: Update.
7058         * mi/mi-main.c: Update.
7059         * objc-lang.c: Update.
7060         * p-valprint.c: Update.
7061         * parse.c: Update.
7062         * ppc-linux-tdep.c: Update.
7063         * printcmd.c: Update.
7064         * python/py-arch.c: Update.
7065         * python/py-breakpoint.c: Update.
7066         * python/py-cmd.c: Update.
7067         * python/py-finishbreakpoint.c: Update.
7068         * python/py-frame.c: Update.
7069         * python/py-framefilter.c: Update.
7070         * python/py-gdb-readline.c: Update.
7071         * python/py-inferior.c: Update.
7072         * python/py-infthread.c: Update.
7073         * python/py-lazy-string.c: Update.
7074         * python/py-linetable.c: Update.
7075         * python/py-objfile.c: Update.
7076         * python/py-param.c: Update.
7077         * python/py-prettyprint.c: Update.
7078         * python/py-progspace.c: Update.
7079         * python/py-record-btrace.c: Update.
7080         * python/py-record.c: Update.
7081         * python/py-symbol.c: Update.
7082         * python/py-type.c: Update.
7083         * python/py-unwind.c: Update.
7084         * python/py-utils.c: Update.
7085         * python/py-value.c: Update.
7086         * python/python.c: Update.
7087         * record-btrace.c: Update.
7088         * record-full.c: Update.
7089         * remote-fileio.c: Update.
7090         * remote.c: Update.
7091         * riscv-tdep.c: Update.
7092         * rs6000-aix-tdep.c: Update.
7093         * rs6000-tdep.c: Update.
7094         * rust-exp.y: Update.
7095         * rust-lang.c: Update.
7096         * s390-tdep.c: Update.
7097         * selftest-arch.c: Update.
7098         * solib-dsbt.c: Update.
7099         * solib-frv.c: Update.
7100         * solib-spu.c: Update.
7101         * solib-svr4.c: Update.
7102         * solib.c: Update.
7103         * sparc64-linux-tdep.c: Update.
7104         * stack.c: Update.
7105         * symfile-mem.c: Update.
7106         * symmisc.c: Update.
7107         * target.c: Update.
7108         * thread.c: Update.
7109         * top.c: Update.
7110         * tracefile-tfile.c: Update.
7111         * tui/tui.c: Update.
7112         * typeprint.c: Update.
7113         * unittests/cli-utils-selftests.c: Update.
7114         * unittests/parse-connection-spec-selftests.c: Update.
7115         * valops.c: Update.
7116         * valprint.c: Update.
7117         * value.c: Update.
7118         * varobj.c: Update.
7119         * windows-nat.c: Update.
7120         * x86-linux-nat.c: Update.
7121         * xml-support.c: Update.
7122
7123 2019-04-08  Tom Tromey  <tom@tromey.com>
7124
7125         * xml-support.c: Use C++ exception handling.
7126         * x86-linux-nat.c: Use C++ exception handling.
7127         * windows-nat.c: Use C++ exception handling.
7128         * varobj.c: Use C++ exception handling.
7129         * value.c: Use C++ exception handling.
7130         * valprint.c: Use C++ exception handling.
7131         * valops.c: Use C++ exception handling.
7132         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7133         handling.
7134         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7135         * typeprint.c: Use C++ exception handling.
7136         * tui/tui.c: Use C++ exception handling.
7137         * tracefile-tfile.c: Use C++ exception handling.
7138         * top.c: Use C++ exception handling.
7139         * thread.c: Use C++ exception handling.
7140         * target.c: Use C++ exception handling.
7141         * symmisc.c: Use C++ exception handling.
7142         * symfile-mem.c: Use C++ exception handling.
7143         * stack.c: Use C++ exception handling.
7144         * sparc64-linux-tdep.c: Use C++ exception handling.
7145         * solib.c: Use C++ exception handling.
7146         * solib-svr4.c: Use C++ exception handling.
7147         * solib-spu.c: Use C++ exception handling.
7148         * solib-frv.c: Use C++ exception handling.
7149         * solib-dsbt.c: Use C++ exception handling.
7150         * selftest-arch.c: Use C++ exception handling.
7151         * s390-tdep.c: Use C++ exception handling.
7152         * rust-lang.c: Use C++ exception handling.
7153         * rust-exp.y: Use C++ exception handling.
7154         * rs6000-tdep.c: Use C++ exception handling.
7155         * rs6000-aix-tdep.c: Use C++ exception handling.
7156         * riscv-tdep.c: Use C++ exception handling.
7157         * remote.c: Use C++ exception handling.
7158         * remote-fileio.c: Use C++ exception handling.
7159         * record-full.c: Use C++ exception handling.
7160         * record-btrace.c: Use C++ exception handling.
7161         * python/python.c: Use C++ exception handling.
7162         * python/py-value.c: Use C++ exception handling.
7163         * python/py-utils.c: Use C++ exception handling.
7164         * python/py-unwind.c: Use C++ exception handling.
7165         * python/py-type.c: Use C++ exception handling.
7166         * python/py-symbol.c: Use C++ exception handling.
7167         * python/py-record.c: Use C++ exception handling.
7168         * python/py-record-btrace.c: Use C++ exception handling.
7169         * python/py-progspace.c: Use C++ exception handling.
7170         * python/py-prettyprint.c: Use C++ exception handling.
7171         * python/py-param.c: Use C++ exception handling.
7172         * python/py-objfile.c: Use C++ exception handling.
7173         * python/py-linetable.c: Use C++ exception handling.
7174         * python/py-lazy-string.c: Use C++ exception handling.
7175         * python/py-infthread.c: Use C++ exception handling.
7176         * python/py-inferior.c: Use C++ exception handling.
7177         * python/py-gdb-readline.c: Use C++ exception handling.
7178         * python/py-framefilter.c: Use C++ exception handling.
7179         * python/py-frame.c: Use C++ exception handling.
7180         * python/py-finishbreakpoint.c: Use C++ exception handling.
7181         * python/py-cmd.c: Use C++ exception handling.
7182         * python/py-breakpoint.c: Use C++ exception handling.
7183         * python/py-arch.c: Use C++ exception handling.
7184         * printcmd.c: Use C++ exception handling.
7185         * ppc-linux-tdep.c: Use C++ exception handling.
7186         * parse.c: Use C++ exception handling.
7187         * p-valprint.c: Use C++ exception handling.
7188         * objc-lang.c: Use C++ exception handling.
7189         * mi/mi-main.c: Use C++ exception handling.
7190         * mi/mi-interp.c: Use C++ exception handling.
7191         * mi/mi-cmd-stack.c: Use C++ exception handling.
7192         * mi/mi-cmd-break.c: Use C++ exception handling.
7193         * main.c: Use C++ exception handling.
7194         * linux-thread-db.c: Use C++ exception handling.
7195         * linux-tdep.c: Use C++ exception handling.
7196         * linux-nat.c: Use C++ exception handling.
7197         * linux-fork.c: Use C++ exception handling.
7198         * linespec.c: Use C++ exception handling.
7199         * language.c: Use C++ exception handling.
7200         * jit.c: Use C++ exception handling.
7201         * infrun.c: Use C++ exception handling.
7202         * infcmd.c: Use C++ exception handling.
7203         * infcall.c: Use C++ exception handling.
7204         * inf-loop.c: Use C++ exception handling.
7205         * i386-tdep.c: Use C++ exception handling.
7206         * i386-linux-tdep.c: Use C++ exception handling.
7207         * guile/scm-value.c: Use C++ exception handling.
7208         * guile/scm-type.c: Use C++ exception handling.
7209         * guile/scm-symtab.c: Use C++ exception handling.
7210         * guile/scm-symbol.c: Use C++ exception handling.
7211         * guile/scm-pretty-print.c: Use C++ exception handling.
7212         * guile/scm-ports.c: Use C++ exception handling.
7213         * guile/scm-param.c: Use C++ exception handling.
7214         * guile/scm-math.c: Use C++ exception handling.
7215         * guile/scm-lazy-string.c: Use C++ exception handling.
7216         * guile/scm-frame.c: Use C++ exception handling.
7217         * guile/scm-disasm.c: Use C++ exception handling.
7218         * guile/scm-cmd.c: Use C++ exception handling.
7219         * guile/scm-breakpoint.c: Use C++ exception handling.
7220         * guile/scm-block.c: Use C++ exception handling.
7221         * guile/guile-internal.h: Use C++ exception handling.
7222         * gnu-v3-abi.c: Use C++ exception handling.
7223         * gdbtypes.c: Use C++ exception handling.
7224         * frame.c: Use C++ exception handling.
7225         * frame-unwind.c: Use C++ exception handling.
7226         * fbsd-tdep.c: Use C++ exception handling.
7227         * f-valprint.c: Use C++ exception handling.
7228         * exec.c: Use C++ exception handling.
7229         * event-top.c: Use C++ exception handling.
7230         * event-loop.c: Use C++ exception handling.
7231         * eval.c: Use C++ exception handling.
7232         * dwarf2read.c: Use C++ exception handling.
7233         * dwarf2loc.c: Use C++ exception handling.
7234         * dwarf2-frame.c: Use C++ exception handling.
7235         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7236         * dwarf-index-write.c: Use C++ exception handling.
7237         * dwarf-index-cache.c: Use C++ exception handling.
7238         * dtrace-probe.c: Use C++ exception handling.
7239         * disasm-selftests.c: Use C++ exception handling.
7240         * darwin-nat.c: Use C++ exception handling.
7241         * cp-valprint.c: Use C++ exception handling.
7242         * cp-support.c: Use C++ exception handling.
7243         * cp-abi.c: Use C++ exception handling.
7244         * corelow.c: Use C++ exception handling.
7245         * completer.c: Use C++ exception handling.
7246         * compile/compile-object-run.c: Use C++ exception handling.
7247         * compile/compile-object-load.c: Use C++ exception handling.
7248         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7249         * compile/compile-c-symbols.c: Use C++ exception handling.
7250         * common/selftest.c: Use C++ exception handling.
7251         * common/new-op.c: Use C++ exception handling.
7252         * cli/cli-script.c: Use C++ exception handling.
7253         * cli/cli-interp.c: Use C++ exception handling.
7254         * cli/cli-cmds.c: Use C++ exception handling.
7255         * c-varobj.c: Use C++ exception handling.
7256         * btrace.c: Use C++ exception handling.
7257         * breakpoint.c: Use C++ exception handling.
7258         * break-catch-throw.c: Use C++ exception handling.
7259         * arch-utils.c: Use C++ exception handling.
7260         * amd64-tdep.c: Use C++ exception handling.
7261         * ada-valprint.c: Use C++ exception handling.
7262         * ada-typeprint.c: Use C++ exception handling.
7263         * ada-lang.c: Use C++ exception handling.
7264         * aarch64-tdep.c: Use C++ exception handling.
7265
7266 2019-04-08  Tom Tromey  <tom@tromey.com>
7267
7268         * xml-support.c (gdb_xml_parser::parse): Update.
7269         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7270         * value.c (show_convenience): Update.
7271         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7272         (test_parse_flags_qcs): Update.
7273         * thread.c (thr_try_catch_cmd): Update.
7274         * target.c (target_translate_tls_address): Update.
7275         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7276         (info_frame_command_core, frame_apply_command_count): Update.
7277         * rust-exp.y (rust_lex_exception_test): Update.
7278         * riscv-tdep.c (riscv_print_one_register_info): Update.
7279         * remote.c (remote_target::enable_btrace): Update.
7280         * record-btrace.c (record_btrace_enable_warn): Update.
7281         * python/py-utils.c (gdbpy_convert_exception): Update.
7282         * printcmd.c (do_one_display, print_variable_and_value): Update.
7283         * mi/mi-main.c (mi_print_exception): Update.
7284         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7285         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7286         * linux-nat.c (linux_nat_target::attach): Update.
7287         * linux-fork.c (class scoped_switch_fork_info): Update.
7288         * infrun.c (displaced_step_prepare): Update.
7289         * infcall.c (call_function_by_hand_dummy): Update.
7290         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7291         * gnu-v3-abi.c (print_one_vtable): Update.
7292         * frame.c (get_prev_frame_always): Update.
7293         * f-valprint.c (info_common_command_for_block): Update.
7294         * exec.c (try_open_exec_file): Update.
7295         * exceptions.c (print_exception, exception_print)
7296         (exception_fprintf, exception_print_same): Update.
7297         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7298         * dwarf-index-cache.c (index_cache::store)
7299         (index_cache::lookup_gdb_index): Update.
7300         * darwin-nat.c (maybe_cache_shell): Update.
7301         * cp-valprint.c (cp_print_value_fields): Update.
7302         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7303         (gcc_cplus_symbol_address): Update.
7304         * compile/compile-c-symbols.c (gcc_convert_symbol)
7305         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7306         * common/selftest.c: Update.
7307         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7308         a std::string.
7309         (exception_try_scope_entry, exception_try_scope_exit): Don't
7310         declare.
7311         (struct exception_try_scope): Remove.
7312         (TRY): Don't use exception_try_scope.
7313         (struct gdb_exception): Add constructor, operator=.
7314         <what>: New method.
7315         (struct gdb_exception_RETURN_MASK_ALL)
7316         (struct gdb_exception_RETURN_MASK_ERROR)
7317         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7318         (struct gdb_quit_bad_alloc): Update.
7319         * common/common-exceptions.c (exception_none): Change
7320         initializer.
7321         (struct catcher) <state, exception>: Initialize inline.
7322         <prev>: Remove member.
7323         (current_catcher): Remove.
7324         (catchers): New global.
7325         (exceptions_state_mc_init): Simplify.
7326         (catcher_pop): Remove.
7327         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7328         (try_scope_depth, exception_try_scope_entry)
7329         (exception_try_scope_exit): Remove.
7330         (throw_exception_sjlj): Update.
7331         (exception_messages, exception_messages_size): Remove.
7332         (throw_it): Simplify.
7333         (gdb_exception_sliced_copy): Remove.
7334         (throw_exception_cxx): Update.
7335         * cli/cli-script.c (script_from_file): Update.
7336         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7337         Update.
7338         * ada-valprint.c (ada_val_print): Update.
7339         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7340         (create_excep_cond_exprs): Update.
7341
7342 2019-04-08  Tom Tromey  <tom@tromey.com>
7343
7344         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7345         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7346         (TRY, CATCH, END_CATCH): Remove some definitions.
7347         * common/common-exceptions.c: Don't use GDB_XCPT.
7348         (catcher_list_size): Remove.
7349         (throw_exception, throw_it): Simplify.
7350
7351 2019-04-05  Tom Tromey  <tom@tromey.com>
7352
7353         Revert the header-sorting patch.
7354         * ft32-tdep.c: Revert.
7355         * frv-tdep.c: Revert.
7356         * frv-linux-tdep.c: Revert.
7357         * frame.c: Revert.
7358         * frame-unwind.c: Revert.
7359         * frame-base.c: Revert.
7360         * fork-child.c: Revert.
7361         * findvar.c: Revert.
7362         * findcmd.c: Revert.
7363         * filesystem.c: Revert.
7364         * filename-seen-cache.h: Revert.
7365         * filename-seen-cache.c: Revert.
7366         * fbsd-tdep.c: Revert.
7367         * fbsd-nat.h: Revert.
7368         * fbsd-nat.c: Revert.
7369         * f-valprint.c: Revert.
7370         * f-typeprint.c: Revert.
7371         * f-lang.c: Revert.
7372         * extension.h: Revert.
7373         * extension.c: Revert.
7374         * extension-priv.h: Revert.
7375         * expprint.c: Revert.
7376         * exec.h: Revert.
7377         * exec.c: Revert.
7378         * exceptions.c: Revert.
7379         * event-top.c: Revert.
7380         * event-loop.c: Revert.
7381         * eval.c: Revert.
7382         * elfread.c: Revert.
7383         * dwarf2read.h: Revert.
7384         * dwarf2read.c: Revert.
7385         * dwarf2loc.c: Revert.
7386         * dwarf2expr.h: Revert.
7387         * dwarf2expr.c: Revert.
7388         * dwarf2-frame.c: Revert.
7389         * dwarf2-frame-tailcall.c: Revert.
7390         * dwarf-index-write.h: Revert.
7391         * dwarf-index-write.c: Revert.
7392         * dwarf-index-common.c: Revert.
7393         * dwarf-index-cache.h: Revert.
7394         * dwarf-index-cache.c: Revert.
7395         * dummy-frame.c: Revert.
7396         * dtrace-probe.c: Revert.
7397         * disasm.h: Revert.
7398         * disasm.c: Revert.
7399         * disasm-selftests.c: Revert.
7400         * dictionary.c: Revert.
7401         * dicos-tdep.c: Revert.
7402         * demangle.c: Revert.
7403         * dcache.h: Revert.
7404         * dcache.c: Revert.
7405         * darwin-nat.h: Revert.
7406         * darwin-nat.c: Revert.
7407         * darwin-nat-info.c: Revert.
7408         * d-valprint.c: Revert.
7409         * d-namespace.c: Revert.
7410         * d-lang.c: Revert.
7411         * ctf.c: Revert.
7412         * csky-tdep.c: Revert.
7413         * csky-linux-tdep.c: Revert.
7414         * cris-tdep.c: Revert.
7415         * cris-linux-tdep.c: Revert.
7416         * cp-valprint.c: Revert.
7417         * cp-support.c: Revert.
7418         * cp-namespace.c: Revert.
7419         * cp-abi.c: Revert.
7420         * corelow.c: Revert.
7421         * corefile.c: Revert.
7422         * continuations.c: Revert.
7423         * completer.h: Revert.
7424         * completer.c: Revert.
7425         * complaints.c: Revert.
7426         * coffread.c: Revert.
7427         * coff-pe-read.c: Revert.
7428         * cli-out.h: Revert.
7429         * cli-out.c: Revert.
7430         * charset.c: Revert.
7431         * c-varobj.c: Revert.
7432         * c-valprint.c: Revert.
7433         * c-typeprint.c: Revert.
7434         * c-lang.c: Revert.
7435         * buildsym.c: Revert.
7436         * buildsym-legacy.c: Revert.
7437         * build-id.h: Revert.
7438         * build-id.c: Revert.
7439         * btrace.c: Revert.
7440         * bsd-uthread.c: Revert.
7441         * breakpoint.h: Revert.
7442         * breakpoint.c: Revert.
7443         * break-catch-throw.c: Revert.
7444         * break-catch-syscall.c: Revert.
7445         * break-catch-sig.c: Revert.
7446         * blockframe.c: Revert.
7447         * block.c: Revert.
7448         * bfin-tdep.c: Revert.
7449         * bfin-linux-tdep.c: Revert.
7450         * bfd-target.c: Revert.
7451         * bcache.c: Revert.
7452         * ax-general.c: Revert.
7453         * ax-gdb.h: Revert.
7454         * ax-gdb.c: Revert.
7455         * avr-tdep.c: Revert.
7456         * auxv.c: Revert.
7457         * auto-load.c: Revert.
7458         * arm-wince-tdep.c: Revert.
7459         * arm-tdep.c: Revert.
7460         * arm-symbian-tdep.c: Revert.
7461         * arm-pikeos-tdep.c: Revert.
7462         * arm-obsd-tdep.c: Revert.
7463         * arm-nbsd-tdep.c: Revert.
7464         * arm-nbsd-nat.c: Revert.
7465         * arm-linux-tdep.c: Revert.
7466         * arm-linux-nat.c: Revert.
7467         * arm-fbsd-tdep.c: Revert.
7468         * arm-fbsd-nat.c: Revert.
7469         * arm-bsd-tdep.c: Revert.
7470         * arch-utils.c: Revert.
7471         * arc-tdep.c: Revert.
7472         * arc-newlib-tdep.c: Revert.
7473         * annotate.h: Revert.
7474         * annotate.c: Revert.
7475         * amd64-windows-tdep.c: Revert.
7476         * amd64-windows-nat.c: Revert.
7477         * amd64-tdep.c: Revert.
7478         * amd64-sol2-tdep.c: Revert.
7479         * amd64-obsd-tdep.c: Revert.
7480         * amd64-obsd-nat.c: Revert.
7481         * amd64-nbsd-tdep.c: Revert.
7482         * amd64-nbsd-nat.c: Revert.
7483         * amd64-nat.c: Revert.
7484         * amd64-linux-tdep.c: Revert.
7485         * amd64-linux-nat.c: Revert.
7486         * amd64-fbsd-tdep.c: Revert.
7487         * amd64-fbsd-nat.c: Revert.
7488         * amd64-dicos-tdep.c: Revert.
7489         * amd64-darwin-tdep.c: Revert.
7490         * amd64-bsd-nat.c: Revert.
7491         * alpha-tdep.c: Revert.
7492         * alpha-obsd-tdep.c: Revert.
7493         * alpha-nbsd-tdep.c: Revert.
7494         * alpha-mdebug-tdep.c: Revert.
7495         * alpha-linux-tdep.c: Revert.
7496         * alpha-linux-nat.c: Revert.
7497         * alpha-bsd-tdep.c: Revert.
7498         * alpha-bsd-nat.c: Revert.
7499         * aix-thread.c: Revert.
7500         * agent.c: Revert.
7501         * addrmap.c: Revert.
7502         * ada-varobj.c: Revert.
7503         * ada-valprint.c: Revert.
7504         * ada-typeprint.c: Revert.
7505         * ada-tasks.c: Revert.
7506         * ada-lang.c: Revert.
7507         * aarch64-tdep.c: Revert.
7508         * aarch64-ravenscar-thread.c: Revert.
7509         * aarch64-newlib-tdep.c: Revert.
7510         * aarch64-linux-tdep.c: Revert.
7511         * aarch64-linux-nat.c: Revert.
7512         * aarch64-fbsd-tdep.c: Revert.
7513         * aarch64-fbsd-nat.c: Revert.
7514         * aarch32-linux-nat.c: Revert.
7515
7516 2019-04-05  Tom Tromey  <tom@tromey.com>
7517
7518         * ft32-tdep.c: Sort headers.
7519         * frv-tdep.c: Sort headers.
7520         * frv-linux-tdep.c: Sort headers.
7521         * frame.c: Sort headers.
7522         * frame-unwind.c: Sort headers.
7523         * frame-base.c: Sort headers.
7524         * fork-child.c: Sort headers.
7525         * findvar.c: Sort headers.
7526         * findcmd.c: Sort headers.
7527         * filesystem.c: Sort headers.
7528         * filename-seen-cache.h: Sort headers.
7529         * filename-seen-cache.c: Sort headers.
7530         * fbsd-tdep.c: Sort headers.
7531         * fbsd-nat.h: Sort headers.
7532         * fbsd-nat.c: Sort headers.
7533         * f-valprint.c: Sort headers.
7534         * f-typeprint.c: Sort headers.
7535         * f-lang.c: Sort headers.
7536         * extension.h: Sort headers.
7537         * extension.c: Sort headers.
7538         * extension-priv.h: Sort headers.
7539         * expprint.c: Sort headers.
7540         * exec.h: Sort headers.
7541         * exec.c: Sort headers.
7542         * exceptions.c: Sort headers.
7543         * event-top.c: Sort headers.
7544         * event-loop.c: Sort headers.
7545         * eval.c: Sort headers.
7546         * elfread.c: Sort headers.
7547         * dwarf2read.h: Sort headers.
7548         * dwarf2read.c: Sort headers.
7549         * dwarf2loc.c: Sort headers.
7550         * dwarf2expr.h: Sort headers.
7551         * dwarf2expr.c: Sort headers.
7552         * dwarf2-frame.c: Sort headers.
7553         * dwarf2-frame-tailcall.c: Sort headers.
7554         * dwarf-index-write.h: Sort headers.
7555         * dwarf-index-write.c: Sort headers.
7556         * dwarf-index-common.c: Sort headers.
7557         * dwarf-index-cache.h: Sort headers.
7558         * dwarf-index-cache.c: Sort headers.
7559         * dummy-frame.c: Sort headers.
7560         * dtrace-probe.c: Sort headers.
7561         * disasm.h: Sort headers.
7562         * disasm.c: Sort headers.
7563         * disasm-selftests.c: Sort headers.
7564         * dictionary.c: Sort headers.
7565         * dicos-tdep.c: Sort headers.
7566         * demangle.c: Sort headers.
7567         * dcache.h: Sort headers.
7568         * dcache.c: Sort headers.
7569         * darwin-nat.h: Sort headers.
7570         * darwin-nat.c: Sort headers.
7571         * darwin-nat-info.c: Sort headers.
7572         * d-valprint.c: Sort headers.
7573         * d-namespace.c: Sort headers.
7574         * d-lang.c: Sort headers.
7575         * ctf.c: Sort headers.
7576         * csky-tdep.c: Sort headers.
7577         * csky-linux-tdep.c: Sort headers.
7578         * cris-tdep.c: Sort headers.
7579         * cris-linux-tdep.c: Sort headers.
7580         * cp-valprint.c: Sort headers.
7581         * cp-support.c: Sort headers.
7582         * cp-namespace.c: Sort headers.
7583         * cp-abi.c: Sort headers.
7584         * corelow.c: Sort headers.
7585         * corefile.c: Sort headers.
7586         * continuations.c: Sort headers.
7587         * completer.h: Sort headers.
7588         * completer.c: Sort headers.
7589         * complaints.c: Sort headers.
7590         * coffread.c: Sort headers.
7591         * coff-pe-read.c: Sort headers.
7592         * cli-out.h: Sort headers.
7593         * cli-out.c: Sort headers.
7594         * charset.c: Sort headers.
7595         * c-varobj.c: Sort headers.
7596         * c-valprint.c: Sort headers.
7597         * c-typeprint.c: Sort headers.
7598         * c-lang.c: Sort headers.
7599         * buildsym.c: Sort headers.
7600         * buildsym-legacy.c: Sort headers.
7601         * build-id.h: Sort headers.
7602         * build-id.c: Sort headers.
7603         * btrace.c: Sort headers.
7604         * bsd-uthread.c: Sort headers.
7605         * breakpoint.h: Sort headers.
7606         * breakpoint.c: Sort headers.
7607         * break-catch-throw.c: Sort headers.
7608         * break-catch-syscall.c: Sort headers.
7609         * break-catch-sig.c: Sort headers.
7610         * blockframe.c: Sort headers.
7611         * block.c: Sort headers.
7612         * bfin-tdep.c: Sort headers.
7613         * bfin-linux-tdep.c: Sort headers.
7614         * bfd-target.c: Sort headers.
7615         * bcache.c: Sort headers.
7616         * ax-general.c: Sort headers.
7617         * ax-gdb.h: Sort headers.
7618         * ax-gdb.c: Sort headers.
7619         * avr-tdep.c: Sort headers.
7620         * auxv.c: Sort headers.
7621         * auto-load.c: Sort headers.
7622         * arm-wince-tdep.c: Sort headers.
7623         * arm-tdep.c: Sort headers.
7624         * arm-symbian-tdep.c: Sort headers.
7625         * arm-pikeos-tdep.c: Sort headers.
7626         * arm-obsd-tdep.c: Sort headers.
7627         * arm-nbsd-tdep.c: Sort headers.
7628         * arm-nbsd-nat.c: Sort headers.
7629         * arm-linux-tdep.c: Sort headers.
7630         * arm-linux-nat.c: Sort headers.
7631         * arm-fbsd-tdep.c: Sort headers.
7632         * arm-fbsd-nat.c: Sort headers.
7633         * arm-bsd-tdep.c: Sort headers.
7634         * arch-utils.c: Sort headers.
7635         * arc-tdep.c: Sort headers.
7636         * arc-newlib-tdep.c: Sort headers.
7637         * annotate.h: Sort headers.
7638         * annotate.c: Sort headers.
7639         * amd64-windows-tdep.c: Sort headers.
7640         * amd64-windows-nat.c: Sort headers.
7641         * amd64-tdep.c: Sort headers.
7642         * amd64-sol2-tdep.c: Sort headers.
7643         * amd64-obsd-tdep.c: Sort headers.
7644         * amd64-obsd-nat.c: Sort headers.
7645         * amd64-nbsd-tdep.c: Sort headers.
7646         * amd64-nbsd-nat.c: Sort headers.
7647         * amd64-nat.c: Sort headers.
7648         * amd64-linux-tdep.c: Sort headers.
7649         * amd64-linux-nat.c: Sort headers.
7650         * amd64-fbsd-tdep.c: Sort headers.
7651         * amd64-fbsd-nat.c: Sort headers.
7652         * amd64-dicos-tdep.c: Sort headers.
7653         * amd64-darwin-tdep.c: Sort headers.
7654         * amd64-bsd-nat.c: Sort headers.
7655         * alpha-tdep.c: Sort headers.
7656         * alpha-obsd-tdep.c: Sort headers.
7657         * alpha-nbsd-tdep.c: Sort headers.
7658         * alpha-mdebug-tdep.c: Sort headers.
7659         * alpha-linux-tdep.c: Sort headers.
7660         * alpha-linux-nat.c: Sort headers.
7661         * alpha-bsd-tdep.c: Sort headers.
7662         * alpha-bsd-nat.c: Sort headers.
7663         * aix-thread.c: Sort headers.
7664         * agent.c: Sort headers.
7665         * addrmap.c: Sort headers.
7666         * ada-varobj.c: Sort headers.
7667         * ada-valprint.c: Sort headers.
7668         * ada-typeprint.c: Sort headers.
7669         * ada-tasks.c: Sort headers.
7670         * ada-lang.c: Sort headers.
7671         * aarch64-tdep.c: Sort headers.
7672         * aarch64-ravenscar-thread.c: Sort headers.
7673         * aarch64-newlib-tdep.c: Sort headers.
7674         * aarch64-linux-tdep.c: Sort headers.
7675         * aarch64-linux-nat.c: Sort headers.
7676         * aarch64-fbsd-tdep.c: Sort headers.
7677         * aarch64-fbsd-nat.c: Sort headers.
7678         * aarch32-linux-nat.c: Sort headers.
7679
7680 2019-04-04  Tom Tromey  <tom@tromey.com>
7681
7682         * varobj.c (varobj_create): Update.
7683         * rust-exp.y (struct rust_parser) <update_innermost_block,
7684         lookup_symbol>: New methods.
7685         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7686         Rename.
7687         (rust_parser::rust_lookup_type)
7688         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7689         * printcmd.c (display_command, do_one_display): Update.
7690         * parser-defs.h (struct parser_state) <parser_state>: Add
7691         "tracker" parameter.
7692         (block_tracker): New member.
7693         (class innermost_block_tracker) <innermost_block_tracker>: Add
7694         "types" parameter.
7695         <reset>: Remove method.
7696         (innermost_block): Don't declare.
7697         (null_post_parser): Update.
7698         * parse.c (innermost_block): Remove global.
7699         (write_dollar_variable): Update.
7700         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7701         Remove "tracker_types" parameter.
7702         (parse_expression): Add "tracker" parameter.
7703         (parse_expression_for_completion): Update.
7704         (null_post_parser): Add "tracker" parameter.
7705         * p-exp.y: Update rules.
7706         * m2-exp.y: Update rules.
7707         * language.h (struct language_defn) <la_post_parser>: Add
7708         "tracker" parameter.
7709         * go-exp.y: Update rules.
7710         * f-exp.y: Update rules.
7711         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7712         parameter.
7713         * d-exp.y: Update rules.
7714         * c-exp.y: Update rules.
7715         * breakpoint.c (set_breakpoint_condition): Create an
7716         innermost_block_tracker.
7717         (watch_command_1): Likewise.
7718         * ada-lang.c (resolve): Add "tracker" parameter.
7719         (resolve_subexp): Likewise.
7720         * ada-exp.y (write_var_from_sym): Update.
7721
7722 2019-04-04  Tom Tromey  <tom@tromey.com>
7723
7724         * type-stack.h: New file.
7725         * type-stack.c: New file.
7726         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7727         type-stack.h.
7728         (insert_into_type_stack, insert_type, push_type, push_type_int)
7729         (insert_type_address_space, pop_type, pop_type_int)
7730         (pop_typelist, pop_type_stack, append_type_stack)
7731         (push_type_stack, get_type_stack, push_typelist)
7732         (follow_type_instance_flags, follow_types): Don't declare.
7733         * parse.c (type_stack): Remove global.
7734         (parse_exp_in_context): Update.
7735         (insert_into_type_stack, insert_type, push_type, push_type_int)
7736         (insert_type_address_space, pop_type, pop_type_int)
7737         (pop_typelist, pop_type_stack, append_type_stack)
7738         (push_type_stack, get_type_stack, push_typelist)
7739         (follow_type_instance_flags, follow_types): Remove (moved to
7740         type-stack.c).
7741         * f-exp.y (type_stack): New global.
7742         Update rules.
7743         (push_kind_type, f_parse): Update.
7744         * d-exp.y (type_stack): New global.
7745         Update rules.
7746         (d_parse): Update.
7747         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7748         Update rules.
7749         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7750         (HFILES_NO_SRCDIR): Add type-stack.h.
7751
7752 2019-04-04  Tom Tromey  <tom@tromey.com>
7753
7754         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7755         (rust_parser::convert_ast_to_expression, rust_parse)
7756         (rust_lex_test_completion, rust_lex_tests): Update.
7757         * parser-defs.h (struct expr_completion_state): New.
7758         (struct parser_state) <parser_state>: Add completion parameter.
7759         <mark_struct_expression, mark_completion_tag>: New methods.
7760         <parse_completion, m_completion_state>: New members.
7761         (prefixify_expression, null_post_parser): Update.
7762         (mark_struct_expression, mark_completion_tag): Don't declare.
7763         * parse.c (parse_completion, expout_last_struct)
7764         (expout_tag_completion_type, expout_completion_name): Remove
7765         globals.
7766         (parser_state::mark_struct_expression)
7767         (parser_state::mark_completion_tag): Now methods.
7768         (prefixify_expression): Add last_struct parameter.
7769         (prefixify_subexp): Likewise.
7770         (parse_exp_1): Update.
7771         (parse_exp_in_context): Add cstate parameter.  Update.
7772         (parse_expression_for_completion): Create an
7773         expr_completion_state.
7774         (null_post_parser): Add "completion" parameter.
7775         * p-exp.y: Update rules.
7776         (yylex): Update.
7777         * language.h (struct language_defn) <la_post_parser>: Add
7778         "completing" parameter.
7779         * go-exp.y: Update rules.
7780         (lex_one_token): Update.
7781         * expression.h (parse_completion): Don't declare.
7782         * d-exp.y: Update rules.
7783         (lex_one_token): Update rules.
7784         * c-exp.y: Update rules.
7785         (lex_one_token): Update.
7786         * ada-lang.c (resolve): Add "parse_completion" parameter.
7787         (resolve_subexp): Likewise.
7788         (ada_resolve_function): Likewise.
7789
7790 2019-04-04  Tom Tromey  <tom@tromey.com>
7791
7792         * parser-defs.h (struct parser_state) <start_arglist,
7793         end_arglist>: New methods.
7794         <arglist_len, m_funcall_chain>: New members.
7795         (arglist_len, start_arglist, end_arglist): Don't declare.
7796         * parse.c (arglist_len, funcall_chain): Remove global.
7797         (start_arglist, end_arglist): Remove functions.
7798         (parse_exp_in_context): Update.
7799         * p-exp.y: Update rules.
7800         * m2-exp.y: Update rules.
7801         * go-exp.y: Update rules.
7802         * f-exp.y: Update rules.
7803         * d-exp.y: Update rules.
7804         * c-exp.y: Update rules.
7805
7806 2019-04-04  Tom Tromey  <tom@tromey.com>
7807
7808         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7809         lex_operator, push_back>: New methods.
7810         Update all rules.
7811         (rust_parser::lex_hex, lex_escape): Rename and update.
7812         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7813         (rust_parser::lex_operator): Rename and update.
7814         (rust_parser::lex_number, rustyylex, rustyyerror)
7815         (rust_lex_test_init, rust_lex_test_sequence)
7816         (rust_lex_test_push_back, rust_lex_tests): Update.
7817         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7818         parameter.
7819         <lexptr, prev_lexptr>: New members.
7820         (lexptr, prev_lexptr): Don't declare.
7821         * parse.c (lexptr, prev_lexptr): Remove globals.
7822         (parse_exp_in_context): Update.
7823         * p-exp.y (yylex, yyerror): Update.
7824         * m2-exp.y (parse_number, yylex, yyerror): Update.
7825         * go-exp.y (lex_one_token, yyerror): Update.
7826         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7827         * d-exp.y (lex_one_token, yyerror): Update.
7828         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7829         (lex_one_token, yyerror): Update.
7830         * ada-lex.l (YY_INPUT): Update.
7831         (rewind_to_char): Update.
7832         * ada-exp.y (yyerror): Update.
7833
7834 2019-04-04  Tom Tromey  <tom@tromey.com>
7835
7836         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7837         * parser-defs.h (struct parser_state) <parser_state>: Add new
7838         parameter.
7839         <comma_terminates>: New member.
7840         (comma_terminates): Don't declare global.
7841         * parse.c (comma_terminates): Remove global.
7842         (parse_exp_in_context): Update.
7843         * p-exp.y (yylex): Update.
7844         * m2-exp.y (yylex): Update.
7845         * go-exp.y (lex_one_token): Update.
7846         * f-exp.y (yylex): Update.
7847         * d-exp.y (lex_one_token): Update.
7848         * c-exp.y (lex_one_token): Update.
7849         * ada-lex.l: Update.
7850
7851 2019-04-04  Tom Tromey  <tom@tromey.com>
7852
7853         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7854         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7855         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7856         * parser-defs.h (paren_depth): Don't declare.
7857         * parse.c (paren_depth): Remove global.
7858         (parse_exp_in_context): Update.
7859         * p-exp.y (paren_depth): New global.
7860         (pascal_parse): Initialize it.
7861         * m2-exp.y (paren_depth): New global.
7862         (m2_parse): Initialize it.
7863         * go-exp.y (paren_depth): New global.
7864         (go_parse): Initialize it.
7865         * f-exp.y (paren_depth): New global.
7866         (f_parse): Initialize it.
7867         * d-exp.y (paren_depth): New global.
7868         (d_parse): Initialize it.
7869         * c-exp.y (paren_depth): New global.
7870         (c_parse): Initialize it.
7871         * ada-lex.l (paren_depth): New global.
7872         (lexer_init): Initialize it.
7873
7874 2019-04-04  Tom Tromey  <tom@tromey.com>
7875
7876         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7877         (rust_parser::convert_ast_to_type)
7878         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7879         * parser-defs.h (struct parser_state) <parser_state>: Add
7880         parameters.  Initialize new members.
7881         <expression_context_block, expression_context_pc>: New members.
7882         * parse.c (expression_context_block, expression_context_pc):
7883         Remove globals.
7884         (parse_exp_in_context): Update.
7885         * p-exp.y: Update all rules.
7886         (yylex): Update.
7887         * m2-exp.y: Update all rules.
7888         (yylex): Update.
7889         * go-exp.y (yylex): Update.
7890         * f-exp.y (yylex): Update.
7891         * d-exp.y: Update all rules.
7892         (yylex): Update.
7893         * c-exp.y: Update all rules.
7894         (lex_one_token, classify_name, yylex, c_parse): Update.
7895         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7896
7897 2019-04-04  Tom Tromey  <tom@tromey.com>
7898
7899         * gdbarch.h, gdbarch.c: Rebuild.
7900         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7901         * stap-probe.h:
7902         (struct stap_parse_info): Replace "parser_state" with
7903         "expr_builder".
7904         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7905         (parser_state): New class.
7906         * parse.c (expr_builder): Rename.
7907         (expr_builder::release): Rename.
7908         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7909         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7910         (write_exp_elt_longcst, write_exp_elt_floatcst)
7911         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7912         (write_exp_string_vector, write_exp_bitstring)
7913         (write_exp_msymbol, mark_struct_expression)
7914         (write_dollar_variable)
7915         (insert_type_address_space, increase_expout_size): Replace
7916         "parser_state" with "expr_builder".
7917         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7918         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7919         "parser_state" with "expr_builder".
7920
7921 2019-04-04  Tom Tromey  <tom@tromey.com>
7922
7923         * rust-exp.y: Replace "parse_language" with method call.
7924         * p-exp.y:
7925         (yylex): Replace "parse_language" with method call.
7926         * m2-exp.y:
7927         (yylex): Replace "parse_language" with method call.
7928         * go-exp.y (classify_name): Replace "parse_language" with method
7929         call.
7930         * f-exp.y (yylex): Replace "parse_language" with method call.
7931         * d-exp.y (lex_one_token): Replace "parse_language" with method
7932         call.
7933         * c-exp.y:
7934         (lex_one_token, classify_name, yylex): Replace "parse_language"
7935         with method call.
7936         * ada-exp.y (find_primitive_type, type_char)
7937         (type_system_address): Replace "parse_language" with method call.
7938
7939 2019-04-04  Tom Tromey  <tom@tromey.com>
7940
7941         * rust-exp.y: Replace "parse_gdbarch" with method call.
7942         * parse.c (write_dollar_variable, insert_type_address_space):
7943         Replace "parse_gdbarch" with method call.
7944         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7945         call.
7946         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7947         call.
7948         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7949         "parse_gdbarch" with method call.
7950         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7951         with method call.
7952         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7953         "parse_gdbarch" with method call.
7954         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7955         "parse_gdbarch" with method call.
7956         * c-exp.y (parse_type, parse_number, classify_name): Replace
7957         "parse_gdbarch" with method call.
7958         * ada-lex.l: Replace "parse_gdbarch" with method call.
7959         * ada-exp.y (parse_type, find_primitive_type, type_char)
7960         (type_system_address): Replace "parse_gdbarch" with method call.
7961
7962 2019-04-04  Tom Tromey  <tom@tromey.com>
7963
7964         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7965         * stap-probe.c (stap_parse_argument): Update.
7966         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7967         initial_size parameter.
7968         * rust-exp.y (rust_lex_tests): Update.
7969         * parse.c (parser_state): Update.
7970         (parse_exp_in_context): Update.
7971         * parser-defs.h (struct parser_state) <parser_state>: Remove
7972         "initial_size" parameter.
7973
7974 2019-04-04  Tom Tromey  <tom@tromey.com>
7975
7976         * parser-defs.h (increase_expout_size): Don't declare.
7977         * parse.c (increase_expout_size): Now static.
7978
7979 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7980
7981         * gnu-nat.c (gnu_nat_target::wait): Fix
7982         target_waitstatus_to_string call.
7983
7984 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7985
7986         * eval.c (evaluate_subexp_standard): Handle internal functions
7987         during Fortran function call handling.
7988
7989 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7990
7991         * NEWS: Mention new internal functions.
7992         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7993         (read_base_type): Use dwarf2_init_complex_target_type.
7994         * value.c (creal_internal_fn): New function.
7995         (cimag_internal_fn): New function.
7996         (_initialize_values): Register new internal functions.
7997
7998 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7999
8000         * infrun.c (stop_all_threads): If debug_infrun, always
8001         trace the wait status after wait_one, using
8002         target_waitstatus_to_string and target_pid_to_str.
8003         (handle_inferior_event): Replace various trace of
8004         wait status kind by a single trace.
8005         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8006         wait status kind image by target_waitstatus_to_string.
8007         * target/waitstatus.c (target_waitstatus_to_string): Fix
8008         obsolete comment.
8009
8010 2019-04-01  Tom Tromey  <tromey@adacore.com>
8011
8012         PR symtab/23331:
8013         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8014
8015 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8016             Pedro Alves  <palves@redhat.com>
8017
8018         * top.c (quit_force): Call 'finalize_values'.
8019         * value.c (finalize_values): New function.
8020         * value.h (finalize_values): Declare.
8021
8022 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8023
8024         * NEWS: Announce $_gdb_major and $_gdb_minor.
8025
8026         * top.c (init_gdb_version_vars): New function.
8027         (gdb_init): Call init_gdb_version_vars.
8028
8029 2019-03-29  Tom Tromey  <tromey@adacore.com>
8030
8031         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8032         help text.  Remove dead code.
8033
8034 2019-03-29  Keith Seitz  <keiths@redhat.com>
8035
8036         From Siddhesh Poyarekar:
8037         * f-lang.h (f77_get_upperbound): Return LONGEST.
8038         (f77_get_lowerbound): Likewise.
8039         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8040         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8041         print them.
8042         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8043         plongest to format print it.
8044         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8045         (f77_get_upperbound): Likewise.
8046         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8047         LOWER_BOUND to LONGEST.
8048         (f77_create_arrayprint_offset_tbl): Likewise.
8049
8050 2019-03-29  Keith Seitz  <keiths@redhat.com>
8051
8052         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8053         %s/pulongest for TYPE_LENGTH instead of %d in format
8054         strings.
8055         * ada-typerint.c (ada_print_type): Likewise.
8056         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8057         * compile/compile-c-support.c (generate_register_struct): Likewise.
8058         * gdbtypes.c (recursive_dump_type): Likewise.
8059         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8060         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8061         instead of %d in format strings.
8062         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8063         to std::min to ULONGEST.
8064         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8065         instead of %d in format strings.
8066         * tracepoint.c (info_scope_command): Likewise.
8067         * typeprint.c (print_offset_data::update)
8068         (print_offset_data::finish): Likewise.
8069         * xtensa-tdep.c (xtensa_store_return_value)
8070         (xtensa_push_dummy_call): Likewise.
8071
8072 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8073
8074         * windows-nat.c (display_selector): Fixed format specifications
8075         for 64-bit Cygwin.
8076
8077 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8078
8079         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8080
8081 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8082
8083         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8084         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8085         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8086         (nios2_linux_init_abi): Install it.
8087
8088 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8089
8090         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8091
8092 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8093
8094         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8095
8096 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8097             Tom Tromey  <tromey@adacore.com>
8098
8099         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8100
8101 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8102
8103         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8104         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8105         method to compute the bounds of range types. Also print "[evaluated]"
8106         if the bounds' values come from a dynamic evaluation.
8107
8108 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8109
8110         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8111         whitespace when pretty printing is on.
8112
8113 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8114
8115         * ppc-linux-nat.c: Add include.
8116
8117 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8118
8119         * NEWS: Mention AArch64 Pointer Authentication.
8120
8121 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8122
8123         * arm-linux-nat.c: Add include.
8124
8125 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8126
8127         * source-cache.c (source_cache::get_source_lines): Re-read
8128         fullname after calling open_source_file.
8129
8130 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8131
8132         * NEWS: Mention TLS support for FreeBSD.
8133
8134 2019-03-25  Tom Tromey  <tromey@adacore.com>
8135
8136         * minsyms.c (BUNCH_SIZE): Update comment.
8137         (~minimal_symbol_reader): Remove old comment.
8138         (compact_minimal_symbols): Update comment.
8139         (minimal_symbol_reader::install): Remove old comment.  Update
8140         other comments.
8141
8142 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8143
8144         * s390-linux-nat.c: Add include.
8145
8146 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8147
8148         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8149         Call linux_get_hwcap.
8150         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8151         Likewise.
8152         (aarch64_linux_get_hwcap): Remove function.
8153         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8154         declaration.
8155         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8156         linux_get_hwcap.
8157         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8158         * linux-tdep.c (linux_get_hwcap): Add function.
8159         (linux_get_hwcap2): Likewise.
8160         * linux-tdep.h (linux_get_hwcap): Add declaration.
8161         (linux_get_hwcap2): Likewise.
8162         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8163         (ppc_linux_get_hwcap2): Likewise.
8164         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8165         linux_get_hwcap.
8166         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8167         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8168         (ppc_linux_nat_target::read_description): Likewise.
8169         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8170         * s390-linux-nat.c: Likewise.
8171         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8172
8173 2019-03-24  Tom Tromey  <tom@tromey.com>
8174
8175         * ada-lang.c (standard_lookup): Simplify initialization.
8176         (ada_lookup_symbol_nonlocal): Simplify return.
8177         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8178         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8179         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8180         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8181         initialization.
8182         * solib.c (solib_global_lookup): Simplify.
8183         * symtab.c (null_block_symbol): Remove.
8184         (symbol_cache_lookup): Simplify returns.
8185         (lookup_language_this): Simplify returns.
8186         (lookup_symbol_aux): Simplify return.
8187         (lookup_local_symbol): Simplify returns.
8188         (lookup_global_symbol_from_objfile): Simplify return.
8189         (lookup_symbol_in_objfile_symtabs)
8190         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8191         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8192         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8193         * cp-namespace.c (cp_lookup_bare_symbol)
8194         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8195         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8196         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8197         (cp_lookup_symbol_via_imports): Simplify initialization.
8198         (find_symbol_in_baseclass): Likewise.
8199         * symtab.h (null_block_symbol): Remove.
8200         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8201         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8202         (d_lookup_symbol_module): Likewise.
8203         (find_symbol_in_baseclass): Simplify initialization.
8204
8205 2019-03-24  Tom Tromey  <tom@tromey.com>
8206
8207         * expression.h: Don't include symtab.h.
8208         (struct block): Forward declare.
8209
8210 2019-03-24  Tom Tromey  <tom@tromey.com>
8211
8212         * c-exp.y (typebase): Remove casts.
8213         * gdbtypes.c (lookup_unsigned_typename, )
8214         (lookup_signed_typename): Remove cast.
8215         * eval.c (parse_to_comma_and_eval): Remove cast.
8216         * parse.c (write_dollar_variable): Remove cast.
8217         * block.h (struct block) <superblock>: Now const.
8218         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8219         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8220         (map_block): Make "block" const.
8221         * symfile.h (struct quick_symbol_functions)
8222         <map_matching_symbols>: Constify block argument to "callback".
8223         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8224         const.
8225         (find_pc_sect_compunit_symtab): Make "b" const.
8226         (find_symbol_at_address): Likewise.
8227         (search_symbols): Likewise.
8228         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8229         (dw2_debug_names_lookup_symbol): Likewise.
8230         (dw2_map_matching_symbols): Update.
8231         * p-valprint.c (pascal_val_print): Remove "block".
8232         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8233         (aux_add_nonlocal_symbols): Make "block" const.
8234         (resolve_subexp): Remove cast.
8235         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8236         const.
8237         (iterate_over_file_blocks): Likewise.
8238         * f-exp.y (%union) <bval>: Remove.
8239         * coffread.c (patch_opaque_types): Make "b" const.
8240         * spu-tdep.c (spu_catch_start): Make "block" const.
8241         * c-valprint.c (print_unpacked_pointer): Remove "block".
8242         * symmisc.c (dump_symtab_1): Make "b" const.
8243         (block_depth): Make "block" const.
8244         * d-exp.y (%union) <bval>: Remove.
8245         * cp-support.h (cp_lookup_rtti_type): Update.
8246         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8247         * psymtab.c (psym_lookup_symbol): Make "block" const.
8248         (maintenance_check_psymtabs): Make "b" const.
8249         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8250         (enumerate_locals, enumerate_args): Update.
8251         * python/py-symtab.c (stpy_global_block): Make "block" const.
8252         (stpy_static_block): Likewise.
8253         * inline-frame.c (block_starting_point_at): Make "new_block"
8254         const.
8255         * block.c (find_block_in_blockvector): Make return type const.
8256         (blockvector_for_pc_sect): Make "b" const.
8257         (find_block_in_blockvector): Make "b" const.
8258
8259 2019-03-23  Tom Tromey  <tom@tromey.com>
8260
8261         * varobj.c (varobj_create): Update.
8262         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8263         * printcmd.c (display_command, do_one_display): Don't reset
8264         innermost_block.
8265         * parser-defs.h (enum innermost_block_tracker_type): Move to
8266         expression.h.
8267         (innermost_block): Update comment.
8268         * parse.c (parse_exp_1): Add tracker_types parameter.
8269         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8270         tracker_types parameter.  Reset innermost_block.
8271         (parse_exp_in_context): Remove.
8272         (parse_expression_for_completion): Update.
8273         * objfiles.c (~objfile): Don't reset expression_context_block or
8274         innermost_block.
8275         * expression.h (enum innermost_block_tracker_type): Move from
8276         parser-defs.h.
8277         (parse_exp_1): Add tracker_types parameter.
8278         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8279         reset innermost_block.
8280
8281 2019-03-23  Tom Tromey  <tom@tromey.com>
8282
8283         * objfiles.h: Include bcache.h.
8284
8285 2019-03-23  Tom Tromey  <tom@tromey.com>
8286
8287         * linespec.c (get_current_search_block): Use
8288         scoped_restore_current_language.
8289         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8290
8291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8292             Jiong Wang  <jiong.wang@arm.com>
8293
8294         * aarch64-linux-tdep.c
8295         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8296         section.
8297         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8298
8299 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8300             Jiong Wang  <jiong.wang@arm.com>
8301
8302         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8303         instructions.
8304         (aarch64_analyze_prologue_test): Add PACIASP test.
8305         (aarch64_prologue_prev_register): Unmask PC value.
8306
8307 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8308             Jiong Wang  <jiong.wang@arm.com>
8309
8310         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8311         (aarch64_dwarf2_prev_register): Unmask PC value.
8312         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8313         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8314         DW_CFA_AARCH64_negate_ra_state.
8315         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8316
8317 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8318             Jiong Wang  <jiong.wang@arm.com>
8319
8320         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8321         registers.
8322         (aarch64_pseudo_register_name): Likewise.
8323         (aarch64_pseudo_register_type): Likewise.
8324         (aarch64_pseudo_register_reggroup_p): Likewise.
8325         (aarch64_gdbarch_init): Add pauth registers.
8326         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8327         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8328         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8329         (struct gdbarch_tdep): Add regnum for ra_state.
8330
8331 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8332             Jiong Wang  <jiong.wang@arm.com>
8333
8334         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8335
8336 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8337             Jiong Wang  <jiong.wang@arm.com>
8338
8339         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8340         function.
8341         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8342         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8343         (aarch64_gdbarch_init): Add puth registers.
8344         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8345         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8346         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8347
8348 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8349             Jiong Wang  <jiong.wang@arm.com>
8350
8351         * aarch64-linux-nat.c
8352         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8353         * aarch64-linux-tdep.c
8354         (aarch64_linux_core_read_description): Likewise.
8355         (aarch64_linux_get_hwcap): New function.
8356         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8357         (aarch64_linux_get_hwcap): New declaration.
8358
8359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8360             Jiong Wang  <jiong.wang@arm.com>
8361
8362         * aarch64-linux-nat.c
8363         (aarch64_linux_nat_target::read_description): Add pauth param.
8364         * aarch64-linux-tdep.c
8365         (aarch64_linux_core_read_description): Likewise.
8366         * aarch64-tdep.c (struct target_desc): Add in pauth.
8367         (aarch64_read_description): Add pauth param.
8368         (aarch64_gdbarch_init): Likewise.
8369         * aarch64-tdep.h (aarch64_read_description): Likewise.
8370         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8371         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8372         * features/Makefile: Add new files.
8373         * features/aarch64-pauth.c: New file.
8374         * features/aarch64-pauth.xml: New file.
8375
8376 2019-03-20  Tom Tromey  <tromey@adacore.com>
8377
8378         * infrun.c (handle_inferior_event): Rename from
8379         handle_inferior_event_1.  Create a scoped_value_mark.
8380         (handle_inferior_event): Remove.
8381
8382 2019-03-19  Tom Tromey  <tromey@adacore.com>
8383
8384         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8385         * infrun.h (print_stop_event): Add "displays" parameter.
8386         * infrun.c (print_stop_event): Add "displays" parameter.
8387
8388 2019-03-19  Pedro Alves  <palves@redhat.com>
8389
8390         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8391         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8392         to -1.  Fix TABs vs spaces.
8393         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8394         * tui/tui-out.h (tui_ui_out) Add intro comments.
8395         <m_line, m_start_of_line>: In-class initialize, and add describing
8396         comment.
8397
8398 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8399
8400         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8401         variable names.
8402         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8403
8404 2019-03-18  Pedro Alves  <palves@redhat.com>
8405             Eli Zaretskii <eliz@gnu.org>
8406
8407         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8408         m_line and m_start_of_line.
8409
8410 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8411
8412         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8413         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8414         it returns a newline.  This fixes a regression in TU mode, whereby
8415         the next line is output on the same screen line as the user input.
8416
8417 2019-03-18  Tom Tromey  <tromey@adacore.com>
8418
8419         * minsyms.c (minimal_symbol_reader::install): Remove call to
8420         obstack_blank.
8421
8422 2019-03-18  Pedro Alves  <palves@redhat.com>
8423
8424         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8425         New globals.
8426         (apply_style): New, factored out from ...
8427         (apply_ansi_escape): ... this.  Handle reverse video mode.
8428         (tui_set_reverse_mode): New function.
8429         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8430         * tui/tui-winsource.c (tui_show_source_line): Use
8431         tui_set_reverse_mode instead of setting A_STANDOUT.
8432         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8433         New setter methods.
8434
8435 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8436
8437         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8438         Handle tabs.
8439
8440 2019-03-18  Tom Tromey  <tromey@adacore.com>
8441
8442         * ada-lang.c (empty_array): Add "high" parameter.
8443         (ada_evaluate_subexp): Update.
8444
8445 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8446
8447         * unittests/string_view-selftests.c: Define
8448         _initialize_string_view_selftests unconditionally.
8449
8450 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8451
8452         PR gdb/24350
8453         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8454
8455 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8456
8457         PR gdb/24351
8458         * windows-nat.c (display_selector): Fix format specifiers.
8459
8460 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8461
8462         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8463         tui_refill_source_window instead of tui_refresh_win, to update the
8464         current execution line.  This fixes redisplay of the current line
8465         when stepping through the code with "next" or "step".
8466
8467 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8468
8469         * source-cache.c (source_cache::get_source_lines): Call
8470         find_source_lines to initialize s->nlines.  This fixes vertical
8471         scrolling of TUI source window when the DOWN arrow is pressed.
8472
8473 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8474
8475         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8476         linux-thread-db.c (_initialize_thread_db): Likewise.
8477
8478 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8479
8480         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8481         wclrtoeol in tui_show_source_line".  This reverts changes made in
8482         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8483
8484 2019-03-15  Tom Tromey  <tom@tromey.com>
8485
8486         * symtab.h (struct minimal_symbol): Derive from
8487         general_symbol_info.
8488         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8489         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8490         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8491         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8492         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8493         (MSYMBOL_SEARCH_NAME): Update.
8494         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8495         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8496         * minsyms.c (minimal_symbol_reader::record_full): Update.
8497
8498 2019-03-15  Tom Tromey  <tom@tromey.com>
8499
8500         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8501
8502 2019-03-15  Tom Tromey  <tom@tromey.com>
8503
8504         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8505         unique_xmalloc_ptr.
8506         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8507         Update.
8508         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8509         (build_minimal_symbol_hash_tables)
8510         (minimal_symbol_reader::install): Update.
8511
8512 2019-03-15  Tom Tromey  <tom@tromey.com>
8513
8514         * symtab.c (create_demangled_names_hash): Update.
8515         (symbol_set_names): Update.
8516         * objfiles.h (struct objfile_per_bfd_storage)
8517         <demangled_names_hash>: Now an htab_up.
8518         * objfiles.c (objfile_per_bfd_storage): Simplify.
8519
8520 2019-03-15  Tom Tromey  <tom@tromey.com>
8521
8522         * objfiles.h (struct objfile_per_bfd_storage): Declare
8523         destructor.
8524         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8525         New.
8526         (get_objfile_bfd_data): Use new.  Don't initialize
8527         language_of_main.
8528         (free_objfile_per_bfd_storage): Remove.
8529         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8530
8531 2019-03-15  Tom Tromey  <tom@tromey.com>
8532
8533         * symfile.c (reread_symbols): Update.
8534         * objfiles.c (objfile::objfile): Update.
8535         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8536         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8537         comment.
8538         (minimal_symbol_reader::install): Update.
8539         (terminate_minimal_symbol_table): Remove.
8540         * jit.c (jit_object_close_impl): Update.
8541
8542 2019-03-15  Tom Tromey  <tom@tromey.com>
8543
8544         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8545         initializations.
8546
8547 2019-03-15  Tom Tromey  <tom@tromey.com>
8548
8549         * objfiles.h (struct objfile_per_bfd_storage)
8550         <demangled_hash_languages>: Now a bitset.
8551         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8552         (lookup_minimal_symbol): Update.
8553
8554 2019-03-15  Tom Tromey  <tom@tromey.com>
8555
8556         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8557         Don't return the symbol.
8558         * coffread.c (record_minimal_symbol): Use record_full.
8559
8560 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8561
8562         The MS-Windows port of ncurses fails to switch to a color pair if
8563         one or both of the colors are the implicit default colors.  This
8564         change records the default colors when TUI is initialized, and
8565         then specifies them explicitly when a color pair uses the default
8566         colors.  This allows color styling in TUI mode on MS-Windows.
8567
8568         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8569         ncurses_norm_attr.
8570         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8571         colors in ncurses_norm_attr.
8572         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8573         "none", replace it with the default color recorded in
8574         ncurses_norm_attr.
8575
8576 2019-03-14  Tom Tromey  <tromey@adacore.com>
8577
8578         * source-cache.h (class source_cache) <get_source_lines>: Return
8579         std::string.
8580         * source-cache.c (source_cache::extract_lines): Handle case where
8581         first_pos==npos.  Return std::string.
8582         (source_cache::get_source_lines): Update.
8583
8584 2019-03-14  Tom Tromey  <tromey@adacore.com>
8585
8586         * NEWS: Add item for "style sources" commands.
8587         * source-cache.c (source_cache::get_source_lines): Check
8588         source_styling.
8589         * cli/cli-style.c (source_styling): New global.
8590         (_initialize_cli_style): Add "style sources" commands.
8591         (show_style_sources): New function.
8592         * cli/cli-style.h (source_styling): Declare.
8593
8594 2019-03-14  Pedro Alves  <palves@redhat.com>
8595             Tom Tromey  <tromey@adacore.com>
8596
8597         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8598         * tui/tui-winsource.c (tui_refill_source_window): New function,
8599         from...
8600         (tui_horizontal_source_scroll): ... here.  Move some logic.
8601         * cli/cli-style.c (set_style_enabled): Notify new observable.
8602         * tui/tui-hooks.c (tui_redisplay_source): New function.
8603         (tui_attach_detach_observers): Attach or detach
8604         tui_redisplay_source.
8605         * observable.h (source_styling_changed): New observable.
8606         * observable.c: Define source_styling_changed observable.
8607
8608 2019-03-13  Tom Tromey  <tromey@adacore.com>
8609
8610         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8611         (i386_gnu_nat_target::store_registers): Update.
8612         * target-debug.h (target_debug_print_std_string): New macro.
8613         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8614         * windows-tdep.c (display_one_tib): Update.
8615         * tui/tui-stack.c (tui_make_status_line): Update.
8616         * top.c (print_inferior_quit_action): Update.
8617         * thread.c (thr_try_catch_cmd): Update.
8618         (add_thread_with_info): Update.
8619         (thread_target_id_str): Update.
8620         (thr_try_catch_cmd): Update.
8621         (thread_command): Update.
8622         (thread_find_command): Update.
8623         * record-btrace.c (record_btrace_target::info_record)
8624         (record_btrace_resume_thread, record_btrace_target::resume)
8625         (record_btrace_cancel_resume, record_btrace_step_thread)
8626         (record_btrace_target::wait, record_btrace_target::wait)
8627         (record_btrace_target::wait, record_btrace_target::stop): Update.
8628         * progspace.c (print_program_space): Update.
8629         * process-stratum-target.c
8630         (process_stratum_target::thread_address_space): Update.
8631         * linux-fork.c (linux_fork_mourn_inferior)
8632         (detach_checkpoint_command, info_checkpoints_command)
8633         (linux_fork_context): Update.
8634         (linux_fork_detach): Update.
8635         (class scoped_switch_fork_info): Update.
8636         (delete_checkpoint_command): Update.
8637         * infrun.c (follow_fork_inferior): Update.
8638         (follow_fork_inferior): Update.
8639         (proceed_after_vfork_done): Update.
8640         (handle_vfork_child_exec_or_exit): Update.
8641         (follow_exec): Update.
8642         (displaced_step_prepare_throw): Update.
8643         (displaced_step_restore): Update.
8644         (start_step_over): Update.
8645         (resume_1): Update.
8646         (clear_proceed_status_thread): Update.
8647         (proceed): Update.
8648         (print_target_wait_results): Update.
8649         (do_target_wait): Update.
8650         (context_switch): Update.
8651         (stop_all_threads): Update.
8652         (restart_threads): Update.
8653         (finish_step_over): Update.
8654         (handle_signal_stop): Update.
8655         (switch_back_to_stepped_thread): Update.
8656         (keep_going_pass_signal): Update.
8657         (print_exited_reason): Update.
8658         (normal_stop): Update.
8659         * inferior.c (inferior_pid_to_str): Change return type.
8660         (print_selected_inferior): Update.
8661         (add_inferior): Update.
8662         (detach_inferior): Update.
8663         * dummy-frame.c (fprint_dummy_frames): Update.
8664         * dcache.c (dcache_info_1): Update.
8665         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8666         (btrace_fetch, btrace_clear): Update.
8667         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8668         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8669         type.
8670         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8671         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8672         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8673         * gdbarch.c, gdbarch.h: Rebuild.
8674         * gdbarch.sh (core_pid_to_str): Change return type.
8675         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8676         return type.
8677         (windows_nat_target::pid_to_str): Change return type.
8678         (windows_delete_thread): Update.
8679         (windows_nat_target::attach): Update.
8680         (windows_nat_target::files_info): Update.
8681         * target-delegates.c: Rebuild.
8682         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8683         return type.
8684         (sol_thread_target::pid_to_str): Change return type.
8685         * remote.c (class remote_target) <pid_to_str>: Change return
8686         type.
8687         (remote_target::pid_to_str): Change return type.
8688         (extended_remote_target::attach, remote_target::remote_stop_ns)
8689         (remote_target::remote_notif_remove_queued_reply)
8690         (remote_target::push_stop_reply, remote_target::disable_btrace):
8691         Update.
8692         (extended_remote_target::attach): Update.
8693         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8694         type.
8695         (gdbsim_target::pid_to_str): Change return type.
8696         * ravenscar-thread.c (struct ravenscar_thread_target)
8697         <pid_to_str>: Change return type.
8698         (ravenscar_thread_target::pid_to_str): Change return type.
8699         * procfs.c (class procfs_target) <pid_to_str>: Change return
8700         type.
8701         (procfs_target::pid_to_str): Change return type.
8702         (procfs_target::attach): Update.
8703         (procfs_target::detach): Update.
8704         (procfs_target::fetch_registers): Update.
8705         (procfs_target::store_registers): Update.
8706         (procfs_target::wait): Update.
8707         (procfs_target::files_info): Update.
8708         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8709         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8710         return type.
8711         (nto_procfs_target::pid_to_str): Change return type.
8712         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8713         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8714         return type.
8715         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8716         (exit_lwp): Update.
8717         (attach_proc_task_lwp_callback, get_detach_signal)
8718         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8719         (linux_nat_target::resume, wait_lwp, stop_callback)
8720         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8721         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8722         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8723         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8724         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8725         type.
8726         (inf_ptrace_target::attach): Update.
8727         (inf_ptrace_target::files_info): Update.
8728         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8729         type.
8730         (go32_nat_target::pid_to_str): Change return type.
8731         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8732         (gnu_nat_target::wait): Update.
8733         (gnu_nat_target::wait): Update.
8734         (gnu_nat_target::resume): Update.
8735         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8736         (fbsd_nat_target::wait): Update.
8737         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8738         type.
8739         (darwin_nat_target::attach): Update.
8740         * corelow.c (class core_target) <pid_to_str>: Change return type.
8741         (core_target::pid_to_str): Change return type.
8742         * target.c (normal_pid_to_str): Change return type.
8743         (default_pid_to_str): Likewise.
8744         (target_pid_to_str): Change return type.
8745         (target_translate_tls_address): Update.
8746         (target_announce_detach): Update.
8747         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8748         return type.
8749         (bsd_uthread_target::pid_to_str): Change return type.
8750         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8751         type.
8752         (bsd_kvm_target::pid_to_str): Change return type.
8753         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8754         return type.
8755         (aix_thread_target::pid_to_str): Change return type.
8756         * target.h (struct target_ops) <pid_to_str>: Change return type.
8757         (target_pid_to_str, normal_pid_to_str): Likewise.
8758         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8759         type.
8760         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8761         type.
8762         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8763         return type.
8764         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8765         type.
8766         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8767         type.
8768         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8769         return type.
8770
8771 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8772
8773         * NEWS: Mention that the new default MI version is 3.  Mention
8774         changes to the output of commands and events that deal with
8775         multi-location breakpoints.
8776         * breakpoint.c: Include "mi/mi-out.h".
8777         (print_one_breakpoint): Change output syntax if using MI version
8778         >= 3.
8779         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8780         New.
8781         (mi_multi_location_breakpoint_output_fixed): New.
8782         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8783         (mi_cmd_fix_multi_location_breakpoint_output): New.
8784         (mi_multi_location_breakpoint_output_fixed): New.
8785         * mi/mi-cmds.c (mi_cmds): Register command
8786         -fix-multi-location-breakpoint-output.
8787         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8788         interpreter "mi".
8789
8790 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8791
8792         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8793         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8794         instantiate mi_ui_out based on interpreter name.
8795         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8796         * mi/mi-main.c (mi_load_progress): Likewise.
8797
8798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8799
8800         * NEWS: Combine separate "New targets" sections for 8.3.
8801
8802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8803
8804         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8805         (ppcfbsd_init_abi): Install gdbarch
8806         "fetch_tls_load_module_address" and "get_thread_local_address"
8807         methods.
8808
8809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8810
8811         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8812         (riscv_fbsd_init_abi): Install gdbarch
8813         "fetch_tls_load_module_address" and "get_thread_local_address"
8814         methods.
8815
8816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8817
8818         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8819         (i386fbsd_init_abi): Install gdbarch
8820         "fetch_tls_load_module_address" and "get_thread_local_address"
8821         methods.
8822
8823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8824
8825         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8826         (amd64fbsd_init_abi): Install gdbarch
8827         "fetch_tls_load_module_address" and "get_thread_local_address"
8828         methods.
8829
8830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8831
8832         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8833         (struct fbsd_pspace_data): New type.
8834         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8835         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8836         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8837         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8838         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8839
8840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8841
8842         * gdbtypes.c (lookup_struct_elt): New function.
8843         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8844         * gdbtypes.h (struct struct_elt): New type.
8845         (lookup_struct_elt): New prototype.
8846
8847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8848
8849         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8850         remove disabled code block.
8851
8852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8853
8854         * gdbarch.sh (get_thread_local_address): New method.
8855         * gdbarch.h, gdbarch.c: Regenerate.
8856         * target.c (target_translate_tls_address): Use
8857         gdbarch_get_thread_local_address if present instead of
8858         target::get_thread_local_address.
8859
8860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8861
8862         * target.h (target::get_thread_local_address): Update comment.
8863
8864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8865
8866         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8867         objfile->separate_debug_objfile_backlink if not NULL.
8868
8869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8870
8871         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8872         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8873         (amd64bsd_store_inferior_registers): Likewise.
8874         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8875         Enable segment base registers.
8876         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8877         PT_GETFSBASE and PT_GETGSBASE.
8878         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8879         PT_SETGSBASE.
8880         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8881         segment base registers.
8882         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8883
8884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8885
8886         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8887         Update calls to i386_target_description to add 'segments'
8888         parameter.
8889         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8890         add segment base registers.
8891         * arch/i386.c (i386_create_target_description): Add 'segments'
8892         parameter to enable segment base registers.
8893         * arch/i386.h (i386_create_target_description): Likewise.
8894         * features/i386/32bit-segments.xml: New file.
8895         * features/i386/32bit-segments.c: Generate.
8896         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8897         call to i386_target_description to add 'segments' parameter.
8898         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8899         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8900         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8901         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8902         if feature is present.
8903         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8904         Add 'segments' parameter to call to i386_target_description.
8905         (i386_target_description): Add 'segments' parameter to enable
8906         segment base registers.
8907         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8908         to call to i386_target_description.
8909         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8910         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8911         Define I386_NUM_REGS.
8912         (i386_target_description): Add 'segments' parameter to enable
8913         segment base registers.
8914
8915 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8916
8917         PR/24325
8918         * source-cache.c: #undef open and close, to avoid unresolved
8919         externals during linking.
8920
8921 2019-03-12  Tom Tromey  <tromey@adacore.com>
8922
8923         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8924         const.  Add initializers.
8925         (_initialize_remote): Don't initialize ptid globals.
8926
8927 2019-03-12  Pedro Alves  <palves@redhat.com>
8928
8929         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8930
8931 2019-03-12  Pedro Alves  <palves@redhat.com>
8932
8933         * cp-name-parser.y (main): Remove unused 'len' variable.
8934
8935 2019-03-12  Tom Tromey  <tromey@adacore.com>
8936
8937         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8938         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8939
8940 2019-03-12  Tom Tromey  <tromey@adacore.com>
8941
8942         * linux-nat.c (iterate_over_lwps): Update.
8943         (stop_callback): Remove parameter.
8944         (stop_wait_callback, detach_callback, resume_set_callback)
8945         (select_singlestep_lwp_callback, set_ignore_sigint)
8946         (status_callback, resumed_callback, resume_clear_callback)
8947         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8948         data parameter.
8949         (linux_nat_target::detach, linux_nat_target::resume)
8950         (linux_stop_and_wait_all_lwps, select_event_lwp)
8951         (linux_nat_filter_event, linux_nat_wait_1)
8952         (linux_nat_target::kill, linux_nat_target::stop)
8953         (linux_nat_target::stop): Update.
8954         (linux_nat_resume_callback): Change type.
8955         (resume_stopped_resumed_lwps, count_events_callback)
8956         (select_event_lwp_callback): Likewise.
8957         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8958         * arm-linux-nat.c (struct update_registers_data): Remove.
8959         (update_registers_callback): Change type.
8960         (arm_linux_insert_hw_breakpoint1): Update.
8961         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8962         parameter.
8963         (x86_linux_dr_set_addr): Update.
8964         (x86_linux_dr_set_control): Update.
8965         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8966         (iterate_over_lwps): Use gdb::function_view.
8967         * nat/aarch64-linux-hw-point.c (struct
8968         aarch64_dr_update_callback_param): Remove.
8969         (debug_reg_change_callback): Change type.
8970         (aarch64_notify_debug_reg_change): Update.
8971         * s390-linux-nat.c (s390_refresh_per_info): Update.
8972
8973 2019-03-11  Tom Tromey  <tromey@adacore.com>
8974
8975         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8976         redundant assignment to "this_cu".
8977
8978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8979
8980         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8981
8982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8983
8984         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8985         from...
8986         (rank_one_type): ... this.
8987
8988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8989
8990         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8991         from...
8992         (rank_one_type): ... this.
8993
8994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8995
8996         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8997         from...
8998         (rank_one_type): ... this.
8999
9000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9001
9002         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9003         from...
9004         (rank_one_type): ... this.
9005
9006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9007
9008         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9009         from...
9010         (rank_one_type): ... this.
9011
9012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9013
9014         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9015         from...
9016         (rank_one_type): ... this.
9017
9018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9019
9020         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9021         from...
9022         (rank_one_type): ... this.
9023
9024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9025
9026         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9027         from...
9028         (rank_one_type): ... this.
9029
9030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9031
9032         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9033         from...
9034         (rank_one_type): ... this.
9035
9036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9037
9038         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9039         from...
9040         (rank_one_type): ... this.
9041
9042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9043
9044         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9045         from...
9046         (rank_one_type): ... this.
9047
9048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9049
9050         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9051         from...
9052         (rank_one_type): ... this.
9053
9054 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9055
9056         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9057         inferior-events' shows the example events.
9058
9059 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9060
9061         Support styling on native MS-Windows console
9062
9063         PR/24315
9064         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9065         on MS-Windows if $TERM is not defined.
9066
9067         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9068
9069         * posix-hdep.c (gdb_console_fputs):
9070         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9071         functions.
9072         * ui-file.h (gdb_console_fputs): Add prototype.
9073
9074         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9075         back to fputs only if the former returns zero.
9076
9077 2019-03-07  Tom Tromey  <tom@tromey.com>
9078
9079         * symmisc.c (print_symbol_bcache_statistics): Update.
9080         (print_objfile_statistics): Update.
9081         * symfile.c (allocate_symtab): Update.
9082         * stabsread.c: Don't include bcache.h.
9083         * psymtab.h (struct psymbol_bcache): Don't declare.
9084         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9085         (psymbol_bcache_init, psymbol_bcache_free)
9086         (psymbol_bcache_get_bcache): Don't declare.
9087         * psymtab.c (struct psymbol_bcache): Remove.
9088         (psymtab_storage::psymtab_storage): Update.
9089         (psymtab_storage::~psymtab_storage): Update.
9090         (psymbol_bcache_init, psymbol_bcache_free)
9091         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9092         (add_psymbol_to_bcache): Update.
9093         (allocate_psymtab): Update.
9094         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9095         macro_cache>: No longer pointers.
9096         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9097         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9098         * macrotab.c (macro_bcache): Update.
9099         * macroexp.c: Don't include bcache.h.
9100         * gdbtypes.c (check_types_worklist): Update.
9101         (types_deeply_equal): Remove TRY/CATCH.  Update.
9102         * elfread.c (elf_symtab_read): Update.
9103         * dwarf2read.c: Don't include bcache.h.
9104         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9105         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9106         (print_bcache_statistics, bcache_memory_used): Don't declare.
9107         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9108         methods.  Rename all data members.
9109         * bcache.c (struct bcache): Move to bcache.h.
9110         (bcache::expand_hash_table): Rename from expand_hash_table.
9111         (bcache): Remove.
9112         (bcache::insert): Rename from bcache_full.
9113         (bcache::compare): Rename from bcache_compare.
9114         (bcache_xmalloc): Remove.
9115         (bcache::~bcache): Rename from bcache_xfree.
9116         (bcache::print_statistics): Rename from print_bcache_statistics.
9117         (bcache::memory_used): Rename from bcache_memory_used.
9118
9119 2019-03-07  Pedro Alves  <palves@redhat.com>
9120
9121         * infrun.c (normal_stop): Also check for
9122         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9123
9124 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9125
9126         * f-lang.c (value_from_host_double): Moved to...
9127         * value.c (value_from_host_double): ...here.
9128         * value.h (value_from_host_double): Declare.
9129         * guile/scm-math.c (vlscm_convert_typed_number): Use
9130         value_from_host_double.
9131         (vlscm_convert_number): Likewise.
9132         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9133         * python/py-value.c (convert_value_from_python): Likewise.
9134
9135 2019-03-06  Tom Tromey  <tom@tromey.com>
9136
9137         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9138
9139 2019-03-06  Tom Tromey  <tom@tromey.com>
9140
9141         * utils.h (free_current_contents): Don't declare.
9142         * utils.c (free_current_contents): Remove.
9143
9144 2019-03-06  Tom Tromey  <tom@tromey.com>
9145
9146         * top.c (quit_force): Update.
9147         * main.c (captured_command_loop): Update.
9148         * common/new-op.c (operator new): Update.
9149         * common/common-exceptions.c (struct catcher)
9150         <save_cleanup_chain>: Remove member.
9151         (exceptions_state_mc_init): Update.
9152         (exception_try_scope_entry): Return nullptr.
9153         (exception_try_scope_exit, exception_rethrow)
9154         (throw_exception_sjlj, throw_exception_cxx): Update.
9155         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9156         (all_cleanups, do_cleanups, discard_cleanups)
9157         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9158         (restore_cleanups, restore_final_cleanups): Don't declare.
9159         (do_final_cleanups): Remove parameter.
9160         * common/cleanups.c (cleanup_chain, make_cleanup)
9161         (make_cleanup_dtor, all_cleanups, do_cleanups)
9162         (discard_my_cleanups, discard_cleanups)
9163         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9164         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9165         (null_cleanup): Remove.
9166         (do_final_cleanups): Remove parameter.
9167
9168 2019-03-06  Tom Tromey  <tom@tromey.com>
9169
9170         * remote.c (remote_target::remote_parse_stop_reply): Use
9171         unique_xmalloc_ptr.
9172
9173 2019-03-06  Tom Tromey  <tom@tromey.com>
9174
9175         * stabsread.c (struct stabs_field_info): Rename from field_info.
9176         <list, fnlist>: Add initializers.
9177         <obstack>: New member.
9178         (read_member_functions, read_struct_fields, read_baseclasses):
9179         Allocate on obstack.  Don't use cleanups.
9180         (read_one_struct_field, read_member_functions, read_struct_fields)
9181         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9182         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9183         (read_struct_type): Update.
9184
9185 2019-03-06  Tom Tromey  <tom@tromey.com>
9186
9187         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9188         * common/filestuff.h (make_cleanup_close): Don't declare.
9189         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9190         Remove.
9191
9192 2019-03-06  Tom Tromey  <tom@tromey.com>
9193
9194         * solib-aix.c: Use make_scope_exit.
9195
9196 2019-03-06  Tom Tromey  <tom@tromey.com>
9197
9198         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9199         Use make_scope_exit.
9200
9201 2019-03-06  Tom Tromey  <tom@tromey.com>
9202
9203         * solib-svr4.c (disable_probes_interface): Remove parameter.
9204         (svr4_handle_solib_event): Use make_scope_exit.
9205
9206 2019-03-06  Tom Tromey  <tom@tromey.com>
9207
9208         * remote.c (struct stop_reply_deleter): Remove.
9209         (stop_reply_up): Update.
9210         (struct stop_reply): Derive from notif_event.  Don't typedef.
9211         <regcache>: Now a std::vector.
9212         (stop_reply_xfree): Remove.
9213         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9214         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9215         (remote_target::discard_pending_stop_replies): Use delete.
9216         (remote_target::remote_parse_stop_reply): Update.
9217         (remote_target::process_stop_reply): Update.
9218         * remote-notif.h (struct notif_event): Add virtual destructor.
9219         Remove "dtr" member.
9220         (struct notif_client) <alloc_event>: Return a unique_ptr.
9221         (notif_event_xfree): Don't declare.
9222         (notif_event_up): New typedef.
9223         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9224         (notif_event_xfree, do_notif_event_xfree): Remove.
9225         (remote_notif_state_xfree): Update.
9226
9227 2019-03-06  Tom Tromey  <tom@tromey.com>
9228
9229         * infrun.c (displaced_step_clear_cleanup): Now a
9230         forward_scope_exit type.
9231         (displaced_step_prepare_throw): Update.
9232         (displaced_step_fixup): Update.
9233
9234 2019-03-06  Tom Tromey  <tom@tromey.com>
9235
9236         * inferior.h (class inferior): Update comment.
9237         * gdbthread.h (class thread_info): Update comment.
9238
9239 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9240             Tom Tromey  <tom@tromey.com>
9241
9242         * stabsread.h (struct stab_section_list): Remove.
9243         (coffstab_build_psymtabs): Update.
9244         * dbxread.c (symbuf_sections): Now a std::vector.
9245         (sect_idx): New global.
9246         (fill_symbuf): Update.
9247         (coffstab_build_psymtabs): Change type of stabsects parameter.
9248         Update.
9249         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9250         std::vector.
9251         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9252         (coff_locate_sections): Update.
9253         (coff_symfile_read): Remove cleanups.  Update.
9254         (init_stringtab): Add storage parameter.
9255         (free_stringtab, free_stringtab_cleanup): Remove.
9256         (init_lineno): Add storage parameter.
9257         (free_linetab, free_linetab_cleanup): Remove.
9258
9259 2019-03-06  Pedro Alves  <palves@redhat.com>
9260
9261         * linux-fork.c (fork_info::clobber_regs): Delete.
9262         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9263         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9264         comment.  Adjust.
9265         (scoped_switch_fork_info::scoped_switch_fork_info)
9266         (checkpoint_command, linux_fork_context): Adjust
9267         fork_save_infrun_state calls.
9268
9269 2019-03-06  Pedro Alves  <palves@redhat.com>
9270
9271         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9272         (inf_has_multiple_threads): Return 'bool' and rewrite using
9273         inferior_info::threads().
9274
9275 2019-03-06  Pedro Alves  <palves@redhat.com>
9276
9277         * linux-fork.c: Include <list>.
9278         (fork_list): Now a std::list instance.
9279         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9280         (forks_exist_p, find_last_fork): Adjust.
9281         (new_fork): Delete.
9282         (one_fork_p): New.
9283         (add_fork): Adjust.
9284         (free_fork): Delete, folded into fork_info::~fork_info().
9285         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9286         Adjust.
9287         (init_fork_list): Delete.
9288         (linux_fork_killall, linux_fork_mourn_inferior)
9289         (linux_fork_detach, info_checkpoints_command): Adjust.
9290         (_initialize_linux_fork): No longer call init_fork_list.
9291
9292 2019-03-06  Pedro Alves  <palves@redhat.com>
9293
9294         * linux-fork.c (new_fork): New, split out of ...
9295         (add_fork): ... this.  Return void.  Move "first fork" special
9296         case from here, to ...
9297         (checkpoint_command): ... here.
9298         * linux-linux.h (add_fork): Return void.
9299
9300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9301
9302         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9303
9304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9305             Chris January  <chris.january@arm.com>
9306             David Lecomber  <david.lecomber@arm.com>
9307
9308         * f-exp.y: New token, UNOP_INTRINSIC.
9309         (exp): New pattern using UNOP_INTRINSIC token.
9310         (f77_keywords): Add 'abs' keyword.
9311         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9312         (value_from_host_double): New function.
9313         (evaluate_subexp_f): Support UNOP_ABS.
9314
9315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9316
9317         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9318         types.
9319
9320 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9323         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9324         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9325
9326 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9329
9330 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9331             Chris January  <chris.january@arm.com>
9332
9333         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9334         * f-exp.y: Define 'KIND' token.
9335         (exp): New pattern for KIND expressions.
9336         (ptype): Handle types with a kind extension.
9337         (direct_abs_decl): Extend to spot kind extensions.
9338         (f77_keywords): Add 'kind' to the list.
9339         (push_kind_type): New function.
9340         (convert_to_kind_type): New function.
9341         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9342         * parse.c (operator_length_standard): Likewise.
9343         * parser-defs.h (enum type_pieces): Add tp_kind.
9344         * std-operator.def: Add UNOP_KIND.
9345
9346 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9347
9348         * f-exp.y (f_parse): Set yydebug.
9349
9350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * f-lang.c (evaluate_subexp_f): New function.
9353         (exp_descriptor_f): New global.
9354         (f_language_defn): Use exp_descriptor_f instead of
9355         exp_descriptor_standard.
9356
9357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * f-exp.y (struct token): Add comments.
9360         (dot_ops): Remove uppercase versions and the end marker.
9361         (f77_keywords): Likewise.
9362         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9363         entries in the dot_ops array are case insensitive, and use
9364         strncasecmp to compare strings.  Also some whitespace cleanup in
9365         this area.  Similar for the f77_keywords array, except entries in
9366         this list might be case sensitive.
9367
9368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9369
9370         * f-exp.y (struct f77_boolean_val): Add comments.
9371         (boolean_values): Remove uppercase versions, and end marker.
9372         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9373         and use strncasecmp to achieve case insensitivity.  Additionally,
9374         perform whitespace cleanup around this code.
9375
9376 2019-03-06  Tom Tromey  <tromey@adacore.com>
9377
9378         * remote-sim.c (gdbsim_target_open): Use result of
9379         gdb_argv::release.
9380
9381 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9382         Dirk Schubert  <dirk.schubert@arm.com>
9383         Chris January  <chris.january@arm.com>
9384
9385         * eval.c (evaluate_subexp_standard): Call Fortran argument
9386         wrapping logic.
9387         * f-lang.c (struct value): A value which can be passed into a
9388         Fortran function call.
9389         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9390         where appropriate.
9391         (struct type): Value ready for a Fortran function call.
9392         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9393         is needed.
9394         * f-lang.h (fortran_argument_convert): Declaration.
9395         (fortran_preserve_arg_pointer): Declaration.
9396         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9397
9398 2019-03-05  Tom Tromey  <tromey@adacore.com>
9399
9400         * python/py-prettyprint.c (print_string_repr): Remove #if.
9401         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9402
9403 2019-03-05  Tom Tromey  <tromey@adacore.com>
9404
9405         * target.c (the_dummy_target): Move later.  Change type to
9406         "dummy_target".
9407         (initialize_targets): Don't initialize the_dummy_target.
9408
9409 2019-03-05  Tom Tromey  <tromey@adacore.com>
9410
9411         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9412         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9413
9414 2019-03-05  Tom Tromey  <tromey@adacore.com>
9415
9416         * windows-nat.c (windows_nat_target::attach)
9417         (windows_nat_target::detach): Don't call gdb_flush.
9418         * valprint.c (generic_val_print, val_print, val_print_string):
9419         Don't call gdb_flush.
9420         * utils.c (defaulted_query): Don't call gdb_flush.
9421         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9422         * target.c (target_announce_detach): Don't call gdb_flush.
9423         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9424         * remote.c (extended_remote_target::attach): Don't call
9425         gdb_flush.
9426         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9427         * printcmd.c (do_examine): Don't call gdb_flush.
9428         (info_display_command): Don't call gdb_flush.
9429         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9430         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9431         * memattr.c (info_mem_command): Don't call gdb_flush.
9432         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9433         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9434         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9435         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9436         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9437         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9438         (gnu_nat_target::detach): Don't call gdb_flush.
9439         * f-valprint.c (f_val_print): Don't call gdb_flush.
9440         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9441         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9442         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9443         gdb_flush.
9444         * c-valprint.c (c_val_print): Don't call gdb_flush.
9445         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9446
9447 2019-03-05  Tom Tromey  <tromey@adacore.com>
9448
9449         * varobj.c (update_dynamic_varobj_children): Update.
9450         (install_default_visualizer): Use reset, not release.
9451         * value.c (set_internalvar): Update.
9452         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9453         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9454         ATTRIBUTE_UNUSED_RESULT.
9455
9456 2019-03-05  Tom Tromey  <tromey@adacore.com>
9457
9458         * remote.c (class scoped_remote_fd) <release>: Add
9459         ATTRIBUTE_UNUSED_RESULT.
9460
9461 2019-03-05  Tom Tromey  <tromey@adacore.com>
9462
9463         * macroexp.c (struct macro_buffer) <release>: Add
9464         ATTRIBUTE_UNUSED_RESULT.
9465
9466 2019-03-05  Tom Tromey  <tromey@adacore.com>
9467
9468         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9469         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9470         ATTRIBUTE_UNUSED_RESULT.
9471
9472 2019-03-05  Tom Tromey  <tromey@adacore.com>
9473
9474         * common/scoped_fd.h (class scoped_fd) <release>: Add
9475         ATTRIBUTE_UNUSED_RESULT.
9476
9477 2019-03-05  Tom Tromey  <tromey@adacore.com>
9478
9479         * parser-defs.h (struct parser_state) <release>: Add
9480         ATTRIBUTE_UNUSED_RESULT.
9481
9482 2019-03-05  Tom Tromey  <tromey@adacore.com>
9483
9484         * utils.h (class gdb_argv) <release>: Add
9485         ATTRIBUTE_UNUSED_RESULT.
9486         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9487
9488 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9489
9490         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9491         for-loop range, to avoid compiler warnings.
9492
9493         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9494         avoid compiler warnings about unused variables.
9495
9496         * NEWS: Mention end of support for native debugging on MS-Windows
9497         before XP.
9498
9499         PR gdb/24292
9500         * common/netstuff.c:
9501         * gdbserver/gdbreplay.c
9502         * gdbserver/remote-utils.c:
9503         * ser-tcp.c:
9504         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9505         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9506         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9507         'getaddrinfo' and 'freeaddrinfo' were not available before
9508         Windows XP, and mingw.org's MinGW headers by default define
9509         _WIN32_WINNT to 0x500.
9510
9511 2019-03-01  Gary Benson <gbenson@redhat.com>
9512
9513         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9514
9515 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9516             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9517
9518         PR gdb/8527
9519         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9520         set_sigint_trap, clear_sigint_trap.
9521
9522 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9523
9524         * target.c (target_detach): Clear the regcache and the
9525         frame cache.
9526
9527 2019-02-27  Pedro Alves  <palves@redhat.com>
9528
9529         * utils.c (set_screen_size): When we cap the height/width sizes,
9530         tweak the corresponding command variable to show "unlimited":
9531
9532 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9533             Pedro Alves  <palves@redhat.com>
9534
9535         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9536         before calling rl_set_screen_size.
9537
9538 2019-02-27  Tom Tromey  <tromey@adacore.com>
9539
9540         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9541         define.
9542         * python/py-value.c: Remove Python 2.4 workaround.
9543         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9544         workaround.
9545         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9546         Python 2.4 workaround.
9547         * python/python-internal.h: Remove Python 2.4 comment.
9548         (Py_ssize_t): Don't define.
9549         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9550         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9551         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9552         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9553         * python/python.c (do_start_initialization): Remove Python 2.4
9554         workaround.
9555         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9556         (print_children): Remove Python 2.4 workaround.
9557         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9558         workaround.
9559         (CHARBUFFERPROC_NAME): Remove.
9560         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9561         Python 2.4 workaround.
9562
9563 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9564
9565         * NEWS: Note minimum Python version.
9566
9567 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9568
9569         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9570         code from these functions.  Remove corresponding ifdefs.  Use
9571         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9572         Remove gotos and target of gotos.
9573         (infpy_search_memory): Likewise.
9574
9575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9576
9577         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9578         (hppa_gdbarch_init): Don't register deleted functions with
9579         gdbarch.
9580
9581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9582
9583         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9584         (h8300_unwind_sp): Delete.
9585         (h8300_dummy_id): Delete.
9586         (h8300_gdbarch_init): Don't register deleted functions with
9587         gdbarch.
9588
9589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9590
9591         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9592         (ft32_unwind_pc): Delete.
9593         (ft32_unwind_sp): Delete.
9594         (ft32_gdbarch_init): Don't register deleted functions with
9595         gdbarch.
9596
9597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9598
9599         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9600         (frv_unwind_pc): Delete.
9601         (frv_unwind_sp): Delete.
9602         (frv_gdbarch_init): Don't register deleted functions with
9603         gdbarch.
9604
9605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9606
9607         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9608         (riscv_unwind_pc): Delete.
9609         (riscv_unwind_sp): Delete.
9610         (riscv_gdbarch_init): Don't register deleted functions with
9611         gdbarch.
9612
9613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9614
9615         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9616         (csky_unwind_pc): Delete.
9617         (csky_unwind_sp): Delete.
9618         (csky_gdbarch_init): Don't register deleted functions with
9619         gdbarch.
9620
9621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9622
9623         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9624         (cris_unwind_pc): Delete.
9625         (cris_unwind_sp): Delete.
9626         (cris_gdbarch_init): Don't register deleted functions with
9627         gdbarch.
9628
9629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9630
9631         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9632         (bfin_unwind_pc): Delete.
9633         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9634
9635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9636
9637         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9638         (arm_unwind_pc): Delete.
9639         (arm_unwind_sp): Delete.
9640         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9641
9642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9643
9644         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9645         (arc_unwind_pc): Delete.
9646         (arc_unwind_sp): Delete.
9647         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9648
9649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9650
9651         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9652         (alpha_unwind_pc): Delete.
9653         (alpha_gdbarch_init): Don't register deleted functions with
9654         gdbarch.
9655
9656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9657
9658         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9659         (aarch64_unwind_pc): Delete.
9660         (aarch64_unwind_sp): Delete.
9661         (aarch64_gdbarch_init): Don't register deleted functions with
9662         gdbarch.
9663
9664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9665
9666         * gdbtypes.c (type_align): Don't consider static members when
9667         computing structure alignment.
9668
9669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9670
9671         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9672         return 0 for other types.
9673         * arch-utils.c (default_type_align): Always return 0.
9674         * gdbarch.h: Regenerate.
9675         * gdbarch.sh (type_align): Extend comment.
9676         * gdbtypes.c (type_align): Add additional comments, always call
9677         gdbarch_type_align before applying the default rules.
9678         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9679         generic code will then apply a suitable default.
9680         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9681         types, return 0 for other types.
9682
9683 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9684
9685         * NEWS: Create a new section for the next release branch.
9686         Rename the section of the current branch, now that it has
9687         been cut.
9688
9689 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9690
9691         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9692         * version.in: Bump version to 8.3.50.DATE-git.
9693
9694 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9695
9696         * aix-thread.c (ptid_cmp): Remove unused variable.
9697         (get_signaled_thread): Likewise.
9698         (store_regs_user_thread): Likewise.
9699         (store_regs_kernel_thread): Likewise.
9700         (fetch_regs_kernel_thread): Remove shadowed variable.
9701
9702 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9703
9704         * features/riscv/32bit-cpu.xml: Add register numbers.
9705         * features/riscv/32bit-fpu.c: Regenerate.
9706         * features/riscv/32bit-fpu.xml: Add register numbers.
9707         * features/riscv/64bit-cpu.xml: Add register numbers.
9708         * features/riscv/64bit-fpu.c: Regenerate.
9709         * features/riscv/64bit-fpu.xml: Add register numbers.
9710
9711 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9712
9713         * NEWS: Mention two argument form of gdb.Value constructor.
9714         * python/py-value.c (convert_buffer_and_type_to_value): New
9715         function.
9716         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9717         Add support for handling an optional second argument.  Call
9718         convert_buffer_and_type_to_value as appropriate.
9719         * python/python-internal.h (Py_buffer_deleter): New struct.
9720         (Py_buffer_up): New typedef.
9721
9722 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9723
9724         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9725         instead of releasing ownership.
9726
9727 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9728
9729         * dwarf2read.c (open_and_init_dwp_file): Call
9730         elf_numsections instead of bfd_count_sections to initialize
9731         dwp_file->num_sections.
9732
9733 2019-02-25  Tom Tromey  <tromey@adacore.com>
9734
9735         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9736
9737 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9738
9739         * gcore.in: Add '--readnever' option when invoking GDB.
9740
9741 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9742
9743         * MAINTAINERS: Update my email address.
9744
9745 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9746
9747         * build-id.c (build_id_to_debug_bfd_1): New function.
9748         (build_id_to_debug_bfd): Look for separate debug file in
9749         sysroot.
9750
9751 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9752
9753         * gdbarch.sh: Update the copyright year range that is placed into
9754         generated files.
9755
9756 2019-02-22  Keith Seitz  <keiths@redhat.com>
9757
9758         PR symtab/23853
9759         * linespec.c (create_sals_line_offset): Search for the default
9760         symtab's filename instead of its fullname.
9761
9762 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9763
9764         * NEWS: Update style defaults.
9765
9766 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9767
9768         * main.c (captured_main_1): Disable styling in batch mode.
9769
9770 2019-02-20  Tom Tromey  <tom@tromey.com>
9771
9772         * symtab.c (symtab_symbol_info): Fix typos.
9773
9774 2019-02-20  Tom Tromey  <tromey@adacore.com>
9775
9776         * findcmd.c (_initialize_mem_search): Use upper case for
9777         metasyntactic variables.
9778
9779 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9780
9781         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9782         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9783
9784 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9785
9786         * top.h (source_file_name): Change to std::string.
9787         * top.c (source_file_name): Likewise.
9788         (command_line_input): Adjust.
9789         * cli/cli-script.c (script_from_file): Adjust.
9790
9791 2019-02-19  Tom Tromey  <tromey@adacore.com>
9792
9793         * ravenscar-thread.c
9794         (ravenscar_thread_target::update_thread_list): Don't call
9795         ada_build_task_list.
9796         * ada-lang.h (ada_build_task_list): Don't declare.
9797         * ada-tasks.c (struct ada_tasks_inferior_data)
9798         <task_list_valid_p>: Now bool.
9799         (read_known_tasks, ada_task_list_changed)
9800         (ada_tasks_invalidate_inferior_data): Update.
9801         (read_known_tasks_array): Return bool.
9802         (read_known_tasks_list): Likewise.
9803         (read_known_tasks): Return void.
9804         (ada_build_task_list): Now static.
9805
9806 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9807
9808         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9809         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9810
9811 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9812
9813         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9814         variant for ada_tasks_pspace_data_handle and
9815         ada_tasks_inferior_data_handle.
9816         (ada_tasks_pspace_data_cleanup): New function.
9817         (ada_tasks_inferior_data_cleanup): New function.
9818
9819 2019-02-17  Tom Tromey  <tom@tromey.com>
9820
9821         * macrotab.h (macro_source_fullname): Return a std::string.
9822         * macrotab.c (macro_include, check_for_redefinition)
9823         (macro_undef, macro_lookup_definition, foreach_macro)
9824         (foreach_macro_in_scope): Update.
9825         (macro_source_fullname): Return a std::string.
9826         * macrocmd.c (show_pp_source_pos): Update.
9827
9828 2019-02-17  Tom Tromey  <tom@tromey.com>
9829
9830         * macrocmd.c (show_pp_source_pos): Style the file names.
9831
9832 2019-02-17  Tom Tromey  <tom@tromey.com>
9833
9834         PR tui/24197:
9835         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9836
9837 2019-02-17  Tom Tromey  <tom@tromey.com>
9838
9839         * ada-lang.c (user_select_syms): Use filtered printing.
9840         * utils.c (wrap_style): New global.
9841         (desired_style): Remove.
9842         (emit_style_escape): Add stream parameter.
9843         (set_output_style, reset_terminal_style, prompt_for_continue):
9844         Update.
9845         (flush_wrap_buffer): Only flush gdb_stdout.
9846         (wrap_here): Set wrap_style.
9847         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9848         treat escape sequences as a character.  Change when wrap buffer is
9849         flushed.
9850         (fputs_styled): Do not set the output style when the default is
9851         requested.
9852         * ui-style.h (struct ui_file_style) <is_default>: New method.
9853         * source.c (print_source_lines_base): Emit escape sequences in one
9854         piece.
9855
9856 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9857
9858         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9859         integers and enumeration types.
9860
9861 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9862
9863         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9864         instead of lookup_symbol_in_language
9865         (do_exact_match): New function.
9866         (ada_get_symbol_name_matcher): Return do_exact_match when
9867         doing a verbatim match.
9868
9869 2019-02-15  Tom Tromey  <tromey@adacore.com>
9870
9871         * ravenscar-thread.c (ravenscar_thread_target::resume)
9872         (ravenscar_thread_target::wait): Special case wildcard requests.
9873
9874 2019-02-15  Tom Tromey  <tromey@adacore.com>
9875
9876         * ravenscar-thread.c (base_ptid): Remove.
9877         (struct ravenscar_thread_target) <close>: New method.
9878         <m_base_ptid>: New member.
9879         <update_inferior_ptid, active_task, task_is_currently_active,
9880         runtime_initialized>: Declare methods.
9881         <ravenscar_thread_target>: Add constructor.
9882         (ravenscar_thread_target::task_is_currently_active)
9883         (ravenscar_thread_target::update_inferior_ptid)
9884         (ravenscar_runtime_initialized): Rename.  Now methods.
9885         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9886         (ravenscar_thread_target::update_thread_list): Update.
9887         (ravenscar_thread_target::active_task): Now method.
9888         (ravenscar_thread_target::store_registers)
9889         (ravenscar_thread_target::prepare_to_store)
9890         (ravenscar_thread_target::prepare_to_store)
9891         (ravenscar_thread_target::mourn_inferior): Update.
9892         (ravenscar_inferior_created): Use "new" to create target.
9893         (ravenscar_thread_target::get_ada_task_ptid): Update.
9894         (_initialize_ravenscar): Don't initialize base_ptid.
9895         (ravenscar_ops): Remove global.
9896
9897 2019-02-15  Tom Tromey  <tromey@adacore.com>
9898
9899         * target.h (push_target): Declare new overload.
9900         * target.c (push_target): New overload, taking an rvalue reference.
9901         * remote.c (remote_target::open_1): Use push_target overload.
9902         * corelow.c (core_target_open): Use push_target overload.
9903
9904 2019-02-15  Tom Tromey  <tromey@adacore.com>
9905
9906         * ravenscar-thread.c (is_ravenscar_task)
9907         (ravenscar_task_is_currently_active): Return bool.
9908         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9909         (_initialize_ravenscar): Remove "(void)".
9910         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9911         Return bool.
9912
9913 2019-02-15  Tom Tromey  <tromey@adacore.com>
9914
9915         * ravenscar-thread.c (ravenscar_runtime_initializer)
9916         (has_ravenscar_runtime, get_running_thread_id)
9917         (ravenscar_thread_target::resume): Fix indentation.
9918
9919 2019-02-15  Tom Tromey  <tromey@adacore.com>
9920
9921         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9922         from ravenscar_arch_ops.
9923         (sparc_ravenscar_ops::fetch_registers)
9924         (sparc_ravenscar_ops::store_registers): Now methods.
9925         (sparc_ravenscar_prepare_to_store): Remove.
9926         (sparc_ravenscar_ops): Redefine.
9927         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9928         methods and destructor.  Remove members.
9929         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9930         (ravenscar_thread_target::store_registers)
9931         (ravenscar_thread_target::prepare_to_store): Update.
9932         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9933         Remove.
9934         (struct ppc_ravenscar_powerpc_ops): Derive from
9935         ravenscar_arch_ops.
9936         (ppc_ravenscar_powerpc_ops::fetch_registers)
9937         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9938         (ppc_ravenscar_powerpc_ops): Redefine.
9939         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9940         (ppc_ravenscar_e500_ops::fetch_registers)
9941         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9942         (ppc_ravenscar_e500_ops): Redefine.
9943         * aarch64-ravenscar-thread.c
9944         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9945         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9946         (aarch64_ravenscar_fetch_registers)
9947         (aarch64_ravenscar_store_registers): Now methods.
9948         (aarch64_ravenscar_ops): Redefine.
9949
9950 2019-02-15  Tom Tromey  <tromey@adacore.com>
9951
9952         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9953         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9954         (ravenscar_thread_target::stopped_by_watchpoint)
9955         (ravenscar_thread_target::stopped_data_address)
9956         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9957
9958 2019-02-15  Tom Tromey  <tromey@adacore.com>
9959
9960         * ravenscar-thread.c: Fix some typos.
9961
9962 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9963             Tom Tromey  <tromey@adacore.com>
9964
9965         * ada-lang.c (ada_exception_sal): Change addr_string to a
9966         std::string.
9967         (create_ada_exception_catchpoint): Update.
9968
9969 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9970             Tom Tromey  <tromey@adacore.com>
9971
9972         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9973         (bp_location_ops): Remove.
9974         (base_breakpoint_allocate_location): Update.
9975         (free_bp_location): Update.
9976         * ada-lang.c (class ada_catchpoint_location)
9977         <ada_catchpoint_location>: Remove ops parameter.
9978         (ada_catchpoint_location_dtor): Remove.
9979         (ada_catchpoint_location_ops): Remove.
9980         (allocate_location_exception): Update.
9981         * breakpoint.h (struct bp_location_ops): Remove.
9982         (class bp_location) <bp_location>: Remove bp_location_ops
9983         parameter.
9984         <~bp_location>: Add destructor.
9985         <ops>: Remove.
9986
9987 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9988             Pedro Alves  <palves@redhat.com>
9989
9990         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9991         'PATH_MAX'.
9992
9993 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9994             Samuel Thibault  <samuel.thibault@gnu.org>
9995             Thomas Schwinge  <thomas@codesourcery.com>
9996
9997         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9998         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9999
10000 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10001
10002         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10003         (check_empty): Use "const char *".
10004
10005         * gnu-nat.c (gnu_nat_target::detach): Instead of
10006         'detach_inferior (pid)' call
10007         'detach_inferior (find_inferior_pid (pid))'.
10008
10009         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10010         'nat/fork-inferior.o'.
10011         * gnu-nat.c: #include "nat/fork-inferior.h".
10012
10013         * gnu-nat.c (gnu_nat_target::detach): Instead of
10014         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10015         * gnu-nat.h: #include "inf-child.h".
10016         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10017         'i386_gnu_nat_target::fetch_registers'.
10018         (gnu_store_registers): Rename/move to
10019         'i386_gnu_nat_target::store_registers'.
10020
10021         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10022         * gnu-nat.h (mach_thread_info): New function.
10023         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10024
10025         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10026
10027 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10028
10029         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10030
10031 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10032
10033         * windows-nat.c (windows_add_thread): Add new parameter
10034         "main_thread_p" with default value set to false.  Update
10035         function documentation as well as all callers.
10036         (windows_delete_thread): Likewise.
10037         (fake_create_process): Update call to windows_add_thread.
10038         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10039         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10040         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10041         call to windows_delete_thread.
10042
10043 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10044
10045         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10046
10047 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10048
10049         * symfile.c (find_separate_debug_file): Use canonical path of
10050         sysroot with child_path instead of gdb_sysroot if it is valid.
10051
10052 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10053
10054         * symfile.c (find_separate_debug_file): Use child_path to
10055         determine if an object file is under a sysroot.
10056
10057 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10058
10059         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10060         unittests/child-path-selftests.c.
10061         * common/pathstuff.c (child_path): New function.
10062         * common/pathstuff.h (child_path): New prototype.
10063         * unittests/child-path-selftests.c: New file.
10064
10065 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10066
10067         * symfile.c (find_separate_debug_file): Look for separate debug
10068         files in debug directories under the sysroot.
10069
10070 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10071
10072         * symtab.h (struct minimal_symbol data_p): New const method.
10073         (struct minimal_symbol text_p): Likewise.
10074         * symtab.c (output_source_filename): Use file name style
10075         to print file name.
10076         (print_symbol_info): Likewise.
10077         (print_msymbol_info): Use address style to print addresses.
10078         Use function name style to print executable text symbols.
10079         (expand_symtab_containing_pc): Use data_p.
10080         (find_pc_sect_compunit_symtab): Likewise.
10081
10082 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10083
10084         * breakpoint.c (describe_other_breakpoints): Use address style
10085         to print addresses.
10086         (say_where): Likewise.
10087
10088 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10089
10090         * ada-typeprint.c (print_func_type): Print function name
10091         style to print function name.
10092         * c-typeprint.c (c_print_type_1): Likewise.
10093
10094 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10095
10096         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10097         for execve.
10098
10099 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10100
10101         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10102         type_stack.
10103
10104 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10105
10106         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10107         TYPE_CODE_REF types.
10108
10109 2019-02-08  Jim Wilson  <jimw@sifive.com>
10110
10111         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10112         (riscv_linux_fregset): New.
10113         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10114
10115 2019-02-07  Tom Tromey  <tom@tromey.com>
10116
10117         * thread.c (thread_cancel_execution_command): Update.
10118         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10119         methods.
10120         (struct thread_fsm_ops): Remove.
10121         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10122         (thread_fsm_should_stop, thread_fsm_return_value)
10123         (thread_fsm_set_finished, thread_fsm_finished_p)
10124         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10125         Don't declare.
10126         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10127         * infrun.c (clear_proceed_status_thread)
10128         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10129         (print_stop_event): Update.
10130         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10131         Add constructor.
10132         (step_command_fsm_ops): Remove.
10133         (new_step_command_fsm): Remove.
10134         (step_1): Update.
10135         (step_command_fsm::should_stop): Rename from
10136         step_command_fsm_should_stop.
10137         (step_command_fsm::clean_up): Rename from
10138         step_command_fsm_clean_up.
10139         (step_command_fsm::do_async_reply_reason): Rename from
10140         step_command_fsm_async_reply_reason.
10141         (struct until_next_fsm): Inherit from thread_fsm.  Add
10142         constructor.
10143         (until_next_fsm_ops): Remove.
10144         (new_until_next_fsm): Remove.
10145         (until_next_fsm::should_stop): Rename from
10146         until_next_fsm_should_stop.
10147         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10148         (until_next_fsm::do_async_reply_reason): Rename from
10149         until_next_fsm_async_reply_reason.
10150         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10151         constructor.  Change type of breakpoint.
10152         (finish_command_fsm_ops): Remove.
10153         (new_finish_command_fsm): Remove.
10154         (finish_command_fsm::should_stop): Rename from
10155         finish_command_fsm_should_stop.
10156         (finish_command_fsm::clean_up): Rename from
10157         finish_command_fsm_clean_up.
10158         (finish_command_fsm::return_value): Rename from
10159         finish_command_fsm_return_value.
10160         (finish_command_fsm::do_async_reply_reason): Rename from
10161         finish_command_fsm_async_reply_reason.
10162         (finish_command): Update.
10163         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10164         Add constructor.
10165         (call_thread_fsm_ops): Remove.
10166         (call_thread_fsm::call_thread_fsm): Rename from
10167         new_call_thread_fsm.
10168         (call_thread_fsm::should_stop): Rename from
10169         call_thread_fsm_should_stop.
10170         (call_thread_fsm::should_notify_stop): Rename from
10171         call_thread_fsm_should_notify_stop.
10172         (run_inferior_call, call_function_by_hand_dummy): Update.
10173         * cli/cli-interp.c (should_print_stop_to_console): Update.
10174         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10175         Add constructor.  Change type of location_breakpoint,
10176         caller_breakpoint.
10177         (until_break_fsm_ops): Remove.
10178         (new_until_break_fsm): Remove.
10179         (until_break_fsm::should_stop): Rename from
10180         until_break_fsm_should_stop.
10181         (until_break_fsm::clean_up): Rename from
10182         until_break_fsm_clean_up.
10183         (until_break_fsm::do_async_reply_reason): Rename from
10184         until_break_fsm_async_reply_reason.
10185         (until_break_command): Update.
10186         * thread-fsm.c: Remove.
10187         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10188
10189 2019-02-07  Tom Tromey  <tom@tromey.com>
10190
10191         * yy-remap.h: Add include guard.
10192         * xtensa-tdep.h: Add include guard.
10193         * xcoffread.h: Rename include guard.
10194         * varobj-iter.h: Add include guard.
10195         * tui/tui.h: Rename include guard.
10196         * tui/tui-winsource.h: Rename include guard.
10197         * tui/tui-wingeneral.h: Rename include guard.
10198         * tui/tui-windata.h: Rename include guard.
10199         * tui/tui-win.h: Rename include guard.
10200         * tui/tui-stack.h: Rename include guard.
10201         * tui/tui-source.h: Rename include guard.
10202         * tui/tui-regs.h: Rename include guard.
10203         * tui/tui-out.h: Rename include guard.
10204         * tui/tui-layout.h: Rename include guard.
10205         * tui/tui-io.h: Rename include guard.
10206         * tui/tui-hooks.h: Rename include guard.
10207         * tui/tui-file.h: Rename include guard.
10208         * tui/tui-disasm.h: Rename include guard.
10209         * tui/tui-data.h: Rename include guard.
10210         * tui/tui-command.h: Rename include guard.
10211         * tic6x-tdep.h: Add include guard.
10212         * target/waitstatus.h: Rename include guard.
10213         * target/wait.h: Rename include guard.
10214         * target/target.h: Rename include guard.
10215         * target/resume.h: Rename include guard.
10216         * target-float.h: Rename include guard.
10217         * stabsread.h: Add include guard.
10218         * rs6000-tdep.h: Add include guard.
10219         * riscv-fbsd-tdep.h: Add include guard.
10220         * regformats/regdef.h: Rename include guard.
10221         * record.h: Rename include guard.
10222         * python/python.h: Rename include guard.
10223         * python/python-internal.h: Rename include guard.
10224         * python/py-stopevent.h: Rename include guard.
10225         * python/py-ref.h: Rename include guard.
10226         * python/py-record.h: Rename include guard.
10227         * python/py-record-full.h: Rename include guard.
10228         * python/py-record-btrace.h: Rename include guard.
10229         * python/py-instruction.h: Rename include guard.
10230         * python/py-events.h: Rename include guard.
10231         * python/py-event.h: Rename include guard.
10232         * procfs.h: Add include guard.
10233         * proc-utils.h: Add include guard.
10234         * p-lang.h: Add include guard.
10235         * or1k-tdep.h: Rename include guard.
10236         * observable.h: Rename include guard.
10237         * nto-tdep.h: Rename include guard.
10238         * nat/x86-linux.h: Rename include guard.
10239         * nat/x86-linux-dregs.h: Rename include guard.
10240         * nat/x86-gcc-cpuid.h: Add include guard.
10241         * nat/x86-dregs.h: Rename include guard.
10242         * nat/x86-cpuid.h: Rename include guard.
10243         * nat/ppc-linux.h: Rename include guard.
10244         * nat/mips-linux-watch.h: Rename include guard.
10245         * nat/linux-waitpid.h: Rename include guard.
10246         * nat/linux-ptrace.h: Rename include guard.
10247         * nat/linux-procfs.h: Rename include guard.
10248         * nat/linux-osdata.h: Rename include guard.
10249         * nat/linux-nat.h: Rename include guard.
10250         * nat/linux-namespaces.h: Rename include guard.
10251         * nat/linux-btrace.h: Rename include guard.
10252         * nat/glibc_thread_db.h: Rename include guard.
10253         * nat/gdb_thread_db.h: Rename include guard.
10254         * nat/gdb_ptrace.h: Rename include guard.
10255         * nat/fork-inferior.h: Rename include guard.
10256         * nat/amd64-linux-siginfo.h: Rename include guard.
10257         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10258         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10259         * nat/aarch64-linux.h: Rename include guard.
10260         * nat/aarch64-linux-hw-point.h: Rename include guard.
10261         * mn10300-tdep.h: Add include guard.
10262         * mips-linux-tdep.h: Add include guard.
10263         * mi/mi-parse.h: Rename include guard.
10264         * mi/mi-out.h: Rename include guard.
10265         * mi/mi-main.h: Rename include guard.
10266         * mi/mi-interp.h: Rename include guard.
10267         * mi/mi-getopt.h: Rename include guard.
10268         * mi/mi-console.h: Rename include guard.
10269         * mi/mi-common.h: Rename include guard.
10270         * mi/mi-cmds.h: Rename include guard.
10271         * mi/mi-cmd-break.h: Rename include guard.
10272         * m2-lang.h: Add include guard.
10273         * location.h: Rename include guard.
10274         * linux-record.h: Rename include guard.
10275         * linux-nat.h: Add include guard.
10276         * linux-fork.h: Add include guard.
10277         * i386-darwin-tdep.h: Rename include guard.
10278         * hppa-linux-offsets.h: Add include guard.
10279         * guile/guile.h: Rename include guard.
10280         * guile/guile-internal.h: Rename include guard.
10281         * gnu-nat.h: Rename include guard.
10282         * gdb-stabs.h: Rename include guard.
10283         * frv-tdep.h: Add include guard.
10284         * f-lang.h: Add include guard.
10285         * event-loop.h: Add include guard.
10286         * darwin-nat.h: Rename include guard.
10287         * cp-abi.h: Rename include guard.
10288         * config/sparc/nm-sol2.h: Rename include guard.
10289         * config/nm-nto.h: Rename include guard.
10290         * config/nm-linux.h: Add include guard.
10291         * config/i386/nm-i386gnu.h: Rename include guard.
10292         * config/djgpp/nl_types.h: Rename include guard.
10293         * config/djgpp/langinfo.h: Rename include guard.
10294         * compile/gcc-cp-plugin.h: Add include guard.
10295         * compile/gcc-c-plugin.h: Add include guard.
10296         * compile/compile.h: Rename include guard.
10297         * compile/compile-object-run.h: Rename include guard.
10298         * compile/compile-object-load.h: Rename include guard.
10299         * compile/compile-internal.h: Rename include guard.
10300         * compile/compile-cplus.h: Rename include guard.
10301         * compile/compile-c.h: Rename include guard.
10302         * common/xml-utils.h: Rename include guard.
10303         * common/x86-xstate.h: Rename include guard.
10304         * common/version.h: Rename include guard.
10305         * common/vec.h: Rename include guard.
10306         * common/tdesc.h: Rename include guard.
10307         * common/selftest.h: Rename include guard.
10308         * common/scoped_restore.h: Rename include guard.
10309         * common/scoped_mmap.h: Rename include guard.
10310         * common/scoped_fd.h: Rename include guard.
10311         * common/safe-iterator.h: Rename include guard.
10312         * common/run-time-clock.h: Rename include guard.
10313         * common/refcounted-object.h: Rename include guard.
10314         * common/queue.h: Rename include guard.
10315         * common/ptid.h: Rename include guard.
10316         * common/print-utils.h: Rename include guard.
10317         * common/preprocessor.h: Rename include guard.
10318         * common/pathstuff.h: Rename include guard.
10319         * common/observable.h: Rename include guard.
10320         * common/netstuff.h: Rename include guard.
10321         * common/job-control.h: Rename include guard.
10322         * common/host-defs.h: Rename include guard.
10323         * common/gdb_wait.h: Rename include guard.
10324         * common/gdb_vecs.h: Rename include guard.
10325         * common/gdb_unlinker.h: Rename include guard.
10326         * common/gdb_unique_ptr.h: Rename include guard.
10327         * common/gdb_tilde_expand.h: Rename include guard.
10328         * common/gdb_sys_time.h: Rename include guard.
10329         * common/gdb_string_view.h: Rename include guard.
10330         * common/gdb_splay_tree.h: Rename include guard.
10331         * common/gdb_setjmp.h: Rename include guard.
10332         * common/gdb_ref_ptr.h: Rename include guard.
10333         * common/gdb_optional.h: Rename include guard.
10334         * common/gdb_locale.h: Rename include guard.
10335         * common/gdb_assert.h: Rename include guard.
10336         * common/filtered-iterator.h: Rename include guard.
10337         * common/filestuff.h: Rename include guard.
10338         * common/fileio.h: Rename include guard.
10339         * common/environ.h: Rename include guard.
10340         * common/common-utils.h: Rename include guard.
10341         * common/common-types.h: Rename include guard.
10342         * common/common-regcache.h: Rename include guard.
10343         * common/common-inferior.h: Rename include guard.
10344         * common/common-gdbthread.h: Rename include guard.
10345         * common/common-exceptions.h: Rename include guard.
10346         * common/common-defs.h: Rename include guard.
10347         * common/common-debug.h: Rename include guard.
10348         * common/cleanups.h: Rename include guard.
10349         * common/buffer.h: Rename include guard.
10350         * common/btrace-common.h: Rename include guard.
10351         * common/break-common.h: Rename include guard.
10352         * cli/cli-utils.h: Rename include guard.
10353         * cli/cli-style.h: Rename include guard.
10354         * cli/cli-setshow.h: Rename include guard.
10355         * cli/cli-script.h: Rename include guard.
10356         * cli/cli-interp.h: Rename include guard.
10357         * cli/cli-decode.h: Rename include guard.
10358         * cli/cli-cmds.h: Rename include guard.
10359         * charset-list.h: Add include guard.
10360         * buildsym-legacy.h: Rename include guard.
10361         * bfin-tdep.h: Add include guard.
10362         * ax.h: Rename include guard.
10363         * arm-linux-tdep.h: Add include guard.
10364         * arm-fbsd-tdep.h: Add include guard.
10365         * arch/xtensa.h: Rename include guard.
10366         * arch/tic6x.h: Add include guard.
10367         * arch/i386.h: Add include guard.
10368         * arch/arm.h: Rename include guard.
10369         * arch/arm-linux.h: Rename include guard.
10370         * arch/arm-get-next-pcs.h: Rename include guard.
10371         * arch/amd64.h: Add include guard.
10372         * arch/aarch64-insn.h: Rename include guard.
10373         * arch-utils.h: Rename include guard.
10374         * annotate.h: Add include guard.
10375         * amd64-darwin-tdep.h: Rename include guard.
10376         * aarch64-linux-tdep.h: Add include guard.
10377         * aarch64-fbsd-tdep.h: Add include guard.
10378         * aarch32-linux-nat.h: Add include guard.
10379
10380 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10381
10382         * macrotab.c (macro_define_internal): New function that
10383         factorizes macro_define_object_internal and macro_define_function
10384         code.
10385         (macro_define_object_internal): Use macro_define_internal.
10386         (macro_define_function): Likewise.
10387
10388 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10389
10390         * macrocmd.c (extract_identifier): Return
10391         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10392         callers.
10393
10394 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10395
10396         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10397
10398 2019-02-05  Tom Tromey  <tom@tromey.com>
10399
10400         * target.c (target_stack::unpush): Move assertion earlier.
10401
10402 2019-01-30  Tom Tromey  <tom@tromey.com>
10403
10404         PR python/23615:
10405         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10406         (gdbpy_parse_and_eval): Likewise.
10407         * python/python-internal.h (gdbpy_allow_threads): New class.
10408
10409 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10410
10411         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10412         (aarch64_fbsd_fpregmap): Move earlier.
10413         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10414         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10415         instead of individual calls to trad_frame_set_reg_addr.
10416         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10417         earlier.
10418         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10419         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10420         instead of individual calls to trad_frame_set_reg_addr.
10421
10422 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10423
10424         * CONTRIBUTE: Replace contribution list with wiki link.
10425
10426 2019-01-25  Tom Tromey  <tom@tromey.com>
10427
10428         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10429
10430 2019-01-25  Tom Tromey  <tom@tromey.com>
10431
10432         * xtensa-linux-nat.c: Fix common/ includes.
10433         * xml-support.h: Fix common/ includes.
10434         * xml-support.c: Fix common/ includes.
10435         * x86-linux-nat.c: Fix common/ includes.
10436         * windows-nat.c: Fix common/ includes.
10437         * varobj.h: Fix common/ includes.
10438         * varobj.c: Fix common/ includes.
10439         * value.c: Fix common/ includes.
10440         * valops.c: Fix common/ includes.
10441         * utils.c: Fix common/ includes.
10442         * unittests/xml-utils-selftests.c: Fix common/ includes.
10443         * unittests/utils-selftests.c: Fix common/ includes.
10444         * unittests/unpack-selftests.c: Fix common/ includes.
10445         * unittests/tracepoint-selftests.c: Fix common/ includes.
10446         * unittests/style-selftests.c: Fix common/ includes.
10447         * unittests/string_view-selftests.c: Fix common/ includes.
10448         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10449         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10450         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10451         * unittests/rsp-low-selftests.c: Fix common/ includes.
10452         * unittests/parse-connection-spec-selftests.c: Fix common/
10453         includes.
10454         * unittests/optional-selftests.c: Fix common/ includes.
10455         * unittests/offset-type-selftests.c: Fix common/ includes.
10456         * unittests/observable-selftests.c: Fix common/ includes.
10457         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10458         * unittests/memrange-selftests.c: Fix common/ includes.
10459         * unittests/memory-map-selftests.c: Fix common/ includes.
10460         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10461         * unittests/function-view-selftests.c: Fix common/ includes.
10462         * unittests/environ-selftests.c: Fix common/ includes.
10463         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10464         * unittests/common-utils-selftests.c: Fix common/ includes.
10465         * unittests/cli-utils-selftests.c: Fix common/ includes.
10466         * unittests/array-view-selftests.c: Fix common/ includes.
10467         * ui-file.c: Fix common/ includes.
10468         * tui/tui-io.c: Fix common/ includes.
10469         * tracepoint.h: Fix common/ includes.
10470         * tracepoint.c: Fix common/ includes.
10471         * tracefile-tfile.c: Fix common/ includes.
10472         * top.h: Fix common/ includes.
10473         * top.c: Fix common/ includes.
10474         * thread.c: Fix common/ includes.
10475         * target/waitstatus.h: Fix common/ includes.
10476         * target/waitstatus.c: Fix common/ includes.
10477         * target.h: Fix common/ includes.
10478         * target.c: Fix common/ includes.
10479         * target-memory.c: Fix common/ includes.
10480         * target-descriptions.c: Fix common/ includes.
10481         * symtab.h: Fix common/ includes.
10482         * symfile.c: Fix common/ includes.
10483         * stap-probe.c: Fix common/ includes.
10484         * spu-linux-nat.c: Fix common/ includes.
10485         * sparc-nat.c: Fix common/ includes.
10486         * source.c: Fix common/ includes.
10487         * solib.c: Fix common/ includes.
10488         * solib-target.c: Fix common/ includes.
10489         * ser-unix.c: Fix common/ includes.
10490         * ser-tcp.c: Fix common/ includes.
10491         * ser-pipe.c: Fix common/ includes.
10492         * ser-base.c: Fix common/ includes.
10493         * selftest-arch.c: Fix common/ includes.
10494         * s12z-tdep.c: Fix common/ includes.
10495         * rust-exp.y: Fix common/ includes.
10496         * rs6000-aix-tdep.c: Fix common/ includes.
10497         * riscv-tdep.c: Fix common/ includes.
10498         * remote.c: Fix common/ includes.
10499         * remote-notif.h: Fix common/ includes.
10500         * remote-fileio.h: Fix common/ includes.
10501         * remote-fileio.c: Fix common/ includes.
10502         * regcache.h: Fix common/ includes.
10503         * regcache.c: Fix common/ includes.
10504         * record-btrace.c: Fix common/ includes.
10505         * python/python.c: Fix common/ includes.
10506         * python/py-type.c: Fix common/ includes.
10507         * python/py-inferior.c: Fix common/ includes.
10508         * progspace.h: Fix common/ includes.
10509         * producer.c: Fix common/ includes.
10510         * procfs.c: Fix common/ includes.
10511         * proc-api.c: Fix common/ includes.
10512         * printcmd.c: Fix common/ includes.
10513         * ppc-linux-nat.c: Fix common/ includes.
10514         * parser-defs.h: Fix common/ includes.
10515         * osdata.c: Fix common/ includes.
10516         * obsd-nat.c: Fix common/ includes.
10517         * nat/x86-linux.c: Fix common/ includes.
10518         * nat/x86-linux-dregs.c: Fix common/ includes.
10519         * nat/x86-dregs.h: Fix common/ includes.
10520         * nat/x86-dregs.c: Fix common/ includes.
10521         * nat/ppc-linux.c: Fix common/ includes.
10522         * nat/mips-linux-watch.h: Fix common/ includes.
10523         * nat/mips-linux-watch.c: Fix common/ includes.
10524         * nat/linux-waitpid.c: Fix common/ includes.
10525         * nat/linux-ptrace.h: Fix common/ includes.
10526         * nat/linux-ptrace.c: Fix common/ includes.
10527         * nat/linux-procfs.c: Fix common/ includes.
10528         * nat/linux-personality.c: Fix common/ includes.
10529         * nat/linux-osdata.c: Fix common/ includes.
10530         * nat/linux-namespaces.c: Fix common/ includes.
10531         * nat/linux-btrace.h: Fix common/ includes.
10532         * nat/linux-btrace.c: Fix common/ includes.
10533         * nat/fork-inferior.c: Fix common/ includes.
10534         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10535         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10536         * nat/aarch64-linux.c: Fix common/ includes.
10537         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10538         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10539         * namespace.h: Fix common/ includes.
10540         * mips-linux-tdep.c: Fix common/ includes.
10541         * minsyms.c: Fix common/ includes.
10542         * mi/mi-parse.h: Fix common/ includes.
10543         * mi/mi-main.c: Fix common/ includes.
10544         * mi/mi-cmd-env.c: Fix common/ includes.
10545         * memrange.h: Fix common/ includes.
10546         * memattr.c: Fix common/ includes.
10547         * maint.h: Fix common/ includes.
10548         * maint.c: Fix common/ includes.
10549         * main.c: Fix common/ includes.
10550         * machoread.c: Fix common/ includes.
10551         * location.c: Fix common/ includes.
10552         * linux-thread-db.c: Fix common/ includes.
10553         * linux-nat.c: Fix common/ includes.
10554         * linux-fork.c: Fix common/ includes.
10555         * inline-frame.c: Fix common/ includes.
10556         * infrun.c: Fix common/ includes.
10557         * inflow.c: Fix common/ includes.
10558         * inferior.h: Fix common/ includes.
10559         * inferior.c: Fix common/ includes.
10560         * infcmd.c: Fix common/ includes.
10561         * inf-ptrace.c: Fix common/ includes.
10562         * inf-child.c: Fix common/ includes.
10563         * ia64-linux-nat.c: Fix common/ includes.
10564         * i387-tdep.c: Fix common/ includes.
10565         * i386-tdep.c: Fix common/ includes.
10566         * i386-linux-tdep.c: Fix common/ includes.
10567         * i386-linux-nat.c: Fix common/ includes.
10568         * i386-go32-tdep.c: Fix common/ includes.
10569         * i386-fbsd-tdep.c: Fix common/ includes.
10570         * i386-fbsd-nat.c: Fix common/ includes.
10571         * guile/scm-type.c: Fix common/ includes.
10572         * guile/guile.c: Fix common/ includes.
10573         * go32-nat.c: Fix common/ includes.
10574         * gnu-nat.c: Fix common/ includes.
10575         * gdbthread.h: Fix common/ includes.
10576         * gdbarch-selftests.c: Fix common/ includes.
10577         * gdb_usleep.c: Fix common/ includes.
10578         * gdb_select.h: Fix common/ includes.
10579         * gdb_bfd.c: Fix common/ includes.
10580         * gcore.c: Fix common/ includes.
10581         * fork-child.c: Fix common/ includes.
10582         * findvar.c: Fix common/ includes.
10583         * fbsd-nat.c: Fix common/ includes.
10584         * event-top.c: Fix common/ includes.
10585         * event-loop.c: Fix common/ includes.
10586         * dwarf2read.c: Fix common/ includes.
10587         * dwarf2loc.c: Fix common/ includes.
10588         * dwarf2-frame.c: Fix common/ includes.
10589         * dwarf-index-cache.c: Fix common/ includes.
10590         * dtrace-probe.c: Fix common/ includes.
10591         * disasm-selftests.c: Fix common/ includes.
10592         * defs.h: Fix common/ includes.
10593         * csky-tdep.c: Fix common/ includes.
10594         * cp-valprint.c: Fix common/ includes.
10595         * cp-support.h: Fix common/ includes.
10596         * cp-support.c: Fix common/ includes.
10597         * corelow.c: Fix common/ includes.
10598         * completer.h: Fix common/ includes.
10599         * completer.c: Fix common/ includes.
10600         * compile/compile.c: Fix common/ includes.
10601         * compile/compile-loc2c.c: Fix common/ includes.
10602         * compile/compile-cplus-types.c: Fix common/ includes.
10603         * compile/compile-cplus-symbols.c: Fix common/ includes.
10604         * command.h: Fix common/ includes.
10605         * cli/cli-dump.c: Fix common/ includes.
10606         * cli/cli-cmds.c: Fix common/ includes.
10607         * charset.c: Fix common/ includes.
10608         * build-id.c: Fix common/ includes.
10609         * btrace.h: Fix common/ includes.
10610         * btrace.c: Fix common/ includes.
10611         * breakpoint.h: Fix common/ includes.
10612         * breakpoint.c: Fix common/ includes.
10613         * ax.h:
10614         (enum agent_op): Fix common/ includes.
10615         * ax-general.c (struct aop_map): Fix common/ includes.
10616         * ax-gdb.c: Fix common/ includes.
10617         * auxv.c: Fix common/ includes.
10618         * auto-load.c: Fix common/ includes.
10619         * arm-tdep.c: Fix common/ includes.
10620         * arch/riscv.c: Fix common/ includes.
10621         * arch/ppc-linux-common.c: Fix common/ includes.
10622         * arch/i386.c: Fix common/ includes.
10623         * arch/arm.c: Fix common/ includes.
10624         * arch/arm-linux.c: Fix common/ includes.
10625         * arch/arm-get-next-pcs.c: Fix common/ includes.
10626         * arch/amd64.c: Fix common/ includes.
10627         * arch/aarch64.c: Fix common/ includes.
10628         * arch/aarch64-insn.c: Fix common/ includes.
10629         * arch-utils.c: Fix common/ includes.
10630         * amd64-windows-tdep.c: Fix common/ includes.
10631         * amd64-tdep.c: Fix common/ includes.
10632         * amd64-sol2-tdep.c: Fix common/ includes.
10633         * amd64-obsd-tdep.c: Fix common/ includes.
10634         * amd64-nbsd-tdep.c: Fix common/ includes.
10635         * amd64-linux-tdep.c: Fix common/ includes.
10636         * amd64-linux-nat.c: Fix common/ includes.
10637         * amd64-fbsd-tdep.c: Fix common/ includes.
10638         * amd64-fbsd-nat.c: Fix common/ includes.
10639         * amd64-dicos-tdep.c: Fix common/ includes.
10640         * amd64-darwin-tdep.c: Fix common/ includes.
10641         * agent.c: Fix common/ includes.
10642         * ada-lang.h: Fix common/ includes.
10643         * ada-lang.c: Fix common/ includes.
10644         * aarch64-tdep.c: Fix common/ includes.
10645
10646 2019-01-25  Tom Tromey  <tom@tromey.com>
10647
10648         * common/create-version.sh: Use common/version.h.
10649
10650 2019-01-24  Pedro Alves  <palves@redhat.com>
10651
10652         * infrun.c (signal_stop, signal_print, signal_program)
10653         (signal_catch, signal_pass): Now arrays instead of pointers.
10654         (update_signals_program_target, do_target_resume)
10655         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10656         * linux-nat.c (linux_nat_target::pass_signals)
10657         (linux_nat_target::create_inferior, linux_nat_target::attach):
10658         Adjust.
10659         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10660         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10661         * procfs.c (procfs_target::pass_signals): Adjust.
10662         * record-full.c (record_full_target::resume): Adjust.
10663         * remote.c (remote_target::pass_signals)
10664         (remote_target::program_signals): Adjust.
10665         * target-debug.h (target_debug_print_signals): Now takes a
10666         gdb::array_view as parameter.  Adjust.
10667         * target.h (target_ops) <pass_signals, program_signals>: Replace
10668         pointer and length parameters with gdb::array_view.
10669         (target_pass_signals, target_program_signals): Likewise.
10670         * target-delegates.c: Regenerate.
10671
10672 2019-01-24  Pedro Alves  <palves@redhat.com>
10673
10674         * common/forward-scope-exit.h
10675         (forward_scope_exit::forward_scope_exit): Pass arguments to
10676         m_bind_function directly, instead of creating a std::bind and
10677         copying that.
10678
10679 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10680
10681         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10682         for static members.
10683         (pass_in_v_vfp_candidate): Likewise.
10684
10685 2019-01-23  Tom Tromey  <tom@tromey.com>
10686             Pedro Alves  <palves@redhat.com>
10687
10688         * regcache.c (class regcache_invalidator): Remove.
10689         (regcache::raw_write): Use make_scope_exit.
10690
10691 2019-01-23  Tom Tromey  <tom@tromey.com>
10692
10693         * ui-out.h (class ui_out_emit_type): Update comment.
10694
10695 2019-01-23  Tom Tromey  <tom@tromey.com>
10696
10697         * infrun.c (fetch_inferior_event): Update comment.
10698
10699 2019-01-23  Tom Tromey  <tom@tromey.com>
10700             Pedro Alves  <palves@redhat.com>
10701
10702         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10703         parameter.
10704         (fetch_inferior_event): Use SCOPE_EXIT.
10705
10706
10707 2019-01-23  Tom Tromey  <tom@tromey.com>
10708             Pedro Alves  <palves@redhat.com>
10709
10710         * infrun.c (disable_thread_events): Delete.
10711         (stop_all_threads): Use SCOPE_EXIT.
10712
10713 2019-01-23  Tom Tromey  <tom@tromey.com>
10714             Pedro Alves  <palves@redhat.com>
10715
10716         * symfile.c: Include forward-scope-exit.h.
10717         (clear_symtab_users_cleanup): Replace forward declaration with
10718         a FORWARD_SCOPE_EXIT.
10719         (syms_from_objfile_1): Use the forward_scope_exit and
10720         gdb::optional instead of cleanup_function.
10721         (reread_symbols): Use the forward_scope_exit instead of
10722         cleanup_function.
10723         (clear_symtab_users_cleanup): Remove function.
10724
10725 2019-01-23  Tom Tromey  <tom@tromey.com>
10726             Pedro Alves  <palves@redhat.com>
10727
10728         * linux-nat.c: Include scope-exit.h.
10729         (cleanup_target_stop): Remove.
10730         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10731         SCOPE_EXIT.
10732
10733 2019-01-23  Tom Tromey  <tom@tromey.com>
10734             Pedro Alves  <palves@redhat.com>
10735
10736         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10737         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10738
10739 2019-01-23  Tom Tromey  <tom@tromey.com>
10740             Andrew Burgess  <andrew.burgess@embecosm.com>
10741             Pedro Alves  <palves@redhat.com>
10742
10743         * infrun.c (fetch_inferior_event): Use scope_exit.
10744         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10745         * top.c (execute_command): Use scope_exit.
10746         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10747         * utils.c (do_bpstat_clear_actions_cleanup)
10748         (make_bpstat_clear_actions_cleanup): Remove.
10749
10750 2019-01-23  Tom Tromey  <tom@tromey.com>
10751             Pedro Alves  <palves@redhat.com>
10752
10753         * infrun.c: Include "common/scope-exit.h"
10754         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10755         (wait_for_inferior): Use SCOPE_EXIT.
10756         (fetch_inferior_event): Use scope_exit.
10757
10758 2019-01-23  Tom Tromey  <tom@tromey.com>
10759             Pedro Alves  <palves@redhat.com>
10760
10761         * breakpoint.c (create_breakpoint): Remove cleanup.
10762
10763 2019-01-23  Tom Tromey  <tom@tromey.com>
10764             Andrew Burgess  <andrew.burgess@embecosm.com>
10765             Pedro Alves  <palves@redhat.com>
10766
10767 2019-01-23  Pedro Alves  <palves@redhat.com>
10768
10769         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10770
10771 2019-01-23  Pedro Alves  <palves@redhat.com>
10772             Andrew Burgess  <andrew.burgess@embecosm.com>
10773
10774         * gdbthread.h: Include "common/forward-scope-exit.h".
10775         (scoped_finish_thread_state): Redefine custom class in terms of
10776         forward_scope_exit.
10777
10778 2019-01-23  Pedro Alves  <palves@redhat.com>
10779             Andrew Burgess  <andrew.burgess@embecosm.com>
10780
10781         * common/forward-scope-exit.h: New file.
10782
10783 2019-01-23  Pedro Alves  <palves@redhat.com>
10784             Andrew Burgess  <andrew.burgess@embecosm.com>
10785             Tom Tromey  <tom@tromey.com>
10786
10787         * common/scope-exit.h: New file.
10788
10789 2019-01-23  Pedro Alves  <palves@redhat.com>
10790
10791         * common/preprocessor.h (ESC): Rename to ...
10792         (ESC_PARENS): ... this.
10793         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10794         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10795
10796 2019-01-23  Tom Tromey  <tom@tromey.com>
10797
10798         * language.h (class scoped_switch_to_sym_language_if_auto):
10799         Initialize m_lang in both cases.
10800
10801 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10802
10803         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10804         with XCNEW.
10805
10806 2019-01-22  Tom Tromey  <tom@tromey.com>
10807
10808         * corelow.c: Do not include sys/file.h.
10809
10810 2019-01-22  Tom Tromey  <tom@tromey.com>
10811
10812         * tui/tui-wingeneral.h: Include gdb_curses.h.
10813
10814 2019-01-22  Tom Tromey  <tom@tromey.com>
10815
10816         * source-cache.h (class source_cache) <get_source_lines,
10817         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10818
10819 2019-01-22  Tom Tromey  <tom@tromey.com>
10820
10821         * remote-fileio.h (struct remote_target): Declare.
10822
10823 2019-01-22  Tom Tromey  <tom@tromey.com>
10824
10825         * python/py-arch.c: Do not include py-ref.h.
10826         * python/py-bpevent.c: Do not include py-ref.h.
10827         * python/py-cmd.c: Do not include py-ref.h.
10828         * python/py-continueevent.c: Do not include py-ref.h.
10829         * python/py-event.h: Do not include py-ref.h.
10830         * python/py-evtregistry.c: Do not include py-ref.h.
10831         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10832         * python/py-frame.c: Do not include py-ref.h.
10833         * python/py-framefilter.c: Do not include py-ref.h.
10834         * python/py-function.c: Do not include py-ref.h.
10835         * python/py-infevents.c: Do not include py-ref.h.
10836         * python/py-linetable.c: Do not include py-ref.h.
10837         * python/py-objfile.c: Do not include py-ref.h.
10838         * python/py-param.c: Do not include py-ref.h.
10839         * python/py-prettyprint.c: Do not include py-ref.h.
10840         * python/py-progspace.c: Do not include py-ref.h.
10841         * python/py-symbol.c: Do not include py-ref.h.
10842         * python/py-symtab.c: Do not include py-ref.h.
10843         * python/py-type.c: Do not include py-ref.h.
10844         * python/py-unwind.c: Do not include py-ref.h.
10845         * python/py-utils.c: Do not include py-ref.h.
10846         * python/py-value.c: Do not include py-ref.h.
10847         * python/py-varobj.c: Do not include py-ref.h.
10848         * python/py-xmethods.c: Do not include py-ref.h.
10849         * python/python.c: Do not include py-ref.h.
10850         * varobj.c: Do not include py-ref.h.
10851
10852 2019-01-22  Tom Tromey  <tom@tromey.com>
10853
10854         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10855         keyword for bcache.
10856
10857 2019-01-22  Tom Tromey  <tom@tromey.com>
10858
10859         * compile/compile-cplus-types.c: Remove a comment by #include.
10860
10861 2019-01-22  Tom Tromey  <tom@tromey.com>
10862
10863         * compile/gcc-c-plugin.h: Include compile-internal.h.
10864
10865 2019-01-22  Tom Tromey  <tom@tromey.com>
10866
10867         * stabsread.c (EXTERN): Do not define.
10868         (symnum, next_symbol_text_func, processing_gcc_compilation)
10869         (within_function, global_sym_chain, global_stabs)
10870         (previous_stab_code, this_object_header_files)
10871         (n_this_object_header_files)
10872         (n_allocated_this_object_header_files): Define.
10873         * stabsread.h (EXTERN): Never define.  Use "extern".
10874
10875 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10876
10877         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10878         history_value.
10879
10880 2019-01-21  Tom Tromey  <tom@tromey.com>
10881
10882         * ui-out.c: Fix includes.
10883         * tui/tui-source.c: Fix includes.
10884         * target.c: Fix includes.
10885         * remote.c: Fix includes.
10886         * regcache.c: Fix includes.
10887         * python/py-block.c: Fix includes.
10888         * printcmd.c: Fix includes.
10889         * or1k-tdep.c: Fix includes.
10890         * mi/mi-main.c: Fix includes.
10891         * m32r-tdep.c: Fix includes.
10892         * csky-tdep.c: Fix includes.
10893         * compile/compile-cplus-types.c: Fix includes.
10894         * cli/cli-interp.c: Fix includes.
10895
10896 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10897
10898         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10899         for padding.
10900
10901 2019-01-16  Tom Tromey  <tom@tromey.com>
10902
10903         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10904         earlier.
10905         (struct objfile) <msymbols_range>: Move from top level.
10906         <msymbols>: New method.
10907         (class objfile_msymbols): Remove.
10908         * symtab.c (default_collect_symbol_completion_matches_break_on):
10909         Update.
10910         * symmisc.c (dump_msymbols): Update.
10911         * stabsread.c (scan_file_globals): Update.
10912         * objc-lang.c (info_selectors_command, info_classes_command)
10913         (find_methods): Update.
10914         * minsyms.c (find_solib_trampoline_target): Update.
10915         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10916         * coffread.c (coff_symfile_read): Update.
10917         * ada-lang.c (ada_lookup_simple_minsym)
10918         (ada_collect_symbol_completion_matches): Update.
10919
10920 2019-01-16  Tom Tromey  <tom@tromey.com>
10921
10922         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10923         type.  Remove no-argument constructor.
10924         <iterator::operator++>: Simplify.
10925         <begin>: Update.
10926         <end>: Use minimal_symbol_count.
10927
10928 2019-01-16  Tom Tromey  <tom@tromey.com>
10929
10930         * objfiles.h (struct objfile) <psymtabs>: New method.
10931         (class objfile_psymtabs): Remove.
10932         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10933         typedef.
10934         <range>: New method.
10935         (require_partial_symbols): Change return type.
10936         * psymtab.c (require_partial_symbols)
10937         (psym_expand_symtabs_matching): Update.
10938         * mdebugread.c (parse_partial_symbols): Update.
10939         * dbxread.c (dbx_end_psymtab): Update.
10940
10941 2019-01-15  Tom Tromey  <tom@tromey.com>
10942
10943         * symtab.c (lookup_objfile_from_block)
10944         (lookup_symbol_in_objfile_symtabs)
10945         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10946         (find_line_symtab, info_sources_command)
10947         (default_collect_symbol_completion_matches_break_on)
10948         (make_source_files_completion_list): Update.
10949         * symmisc.c (print_objfile_statistics, dump_objfile)
10950         (maintenance_print_symbols, maintenance_info_symtabs)
10951         (maintenance_check_symtabs, maintenance_info_line_tables):
10952         Update.
10953         * source.c (select_source_symtab)
10954         (forget_cached_source_info_for_objfile): Update.
10955         * objfiles.h (class objfile_compunits): Remove.
10956         (struct objfile) <compunits_range>: New typedef.
10957         (compunits): New method.
10958         * objfiles.c (objfile_relocate1): Update.
10959         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10960         * maint.c (count_symtabs_and_blocks): Update.
10961         * linespec.c (iterate_over_all_matching_symtabs): Update.
10962         * cp-support.c (add_symbol_overload_list_qualified): Update.
10963         * coffread.c (coff_symtab_read): Update.
10964         * ada-lang.c (add_nonlocal_symbols)
10965         (ada_collect_symbol_completion_matches)
10966         (ada_add_global_exceptions): Update.
10967
10968 2019-01-15  Tom Tromey  <tom@tromey.com>
10969
10970         * progspace.h (program_space) <objfiles_safe_range>: New
10971         typedef.
10972         <objfiles_safe>: New method.
10973         * objfiles.h (class all_objfiles_safe): Remove.
10974         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10975         * jit.c (jit_inferior_exit_hook): Update.
10976
10977 2019-01-17  Tom Tromey  <tom@tromey.com>
10978
10979         * progspace.h (program_space) <objfiles_range>: New typedef.
10980         <objfiles>: New method.
10981         <objfiles_head>: Rename from objfiles.
10982         (object_files): Update.
10983         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10984         * guile/scm-pretty-print.c
10985         (ppscm_find_pretty_printer_from_objfiles): Update.
10986         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10987         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10988         Update.
10989         * python/py-progspace.c (pspy_get_objfiles): Update.
10990         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10991         Update.
10992         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10993         (objfpy_lookup_objfile_by_build_id): Update.
10994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10995         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10996         Update.
10997         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10998         (expand_symtab_containing_pc, lookup_objfile_from_block)
10999         (lookup_static_symbol, basic_lookup_transparent_type)
11000         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11001         (find_line_symtab, info_sources_command)
11002         (default_collect_symbol_completion_matches_break_on)
11003         (make_source_files_completion_list, find_main_name): Update.
11004         * symmisc.c (print_symbol_bcache_statistics)
11005         (print_objfile_statistics, maintenance_print_symbols)
11006         (maintenance_print_msymbols, maintenance_print_objfiles)
11007         (maintenance_info_symtabs, maintenance_check_symtabs)
11008         (maintenance_expand_symtabs, maintenance_info_line_tables):
11009         Update.
11010         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11011         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11012         (map_overlay_command, unmap_overlay_command)
11013         (simple_overlay_update, expand_symtabs_matching)
11014         (map_symbol_filenames): Update.
11015         * symfile-debug.c (set_debug_symfile): Update.
11016         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11017         Update.
11018         * source.c (select_source_symtab, forget_cached_source_info):
11019         Update.
11020         * solib.c (solib_read_symbols): Update.
11021         * solib-spu.c (append_ocl_sos): Update.
11022         * psymtab.c (maintenance_print_psymbols)
11023         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11024         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11025         * printcmd.c (info_symbol_command): Update.
11026         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11027         Update.
11028         * objfiles.h (class all_objfiles): Remove.
11029         * objfiles.c (have_partial_symbols, have_full_symbols)
11030         (have_minimal_symbols, qsort_cmp, update_section_map)
11031         (shared_objfile_contains_address_p)
11032         (default_iterate_over_objfiles_in_search_order): Update.
11033         * objc-lang.c (info_selectors_command, info_classes_command)
11034         (find_methods): Update.
11035         * minsyms.c (find_solib_trampoline_target): Update.
11036         * maint.c (maintenance_info_sections)
11037         (maintenance_translate_address, count_symtabs_and_blocks):
11038         Update.
11039         * main.c (captured_main_1): Update.
11040         * linux-thread-db.c (try_thread_db_load_from_pdir)
11041         (has_libpthread): Update.
11042         * linespec.c (iterate_over_all_matching_symtabs)
11043         (search_minsyms_for_name): Update.
11044         * jit.c (jit_find_objf_with_entry_addr): Update.
11045         * hppa-tdep.c (find_unwind_entry)
11046         (hppa_lookup_stub_minimal_symbol): Update.
11047         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11048         Update.
11049         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11050         (elf_gnu_ifunc_resolve_by_got): Update.
11051         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11052         * dwarf-index-write.c (save_gdb_index_command): Update.
11053         * cp-support.c (add_symbol_overload_list_qualified): Update.
11054         * breakpoint.c (create_overlay_event_breakpoint)
11055         (create_longjmp_master_breakpoint)
11056         (create_std_terminate_master_breakpoint)
11057         (create_exception_master_breakpoint): Update.
11058         * blockframe.c (find_pc_partial_function): Update.
11059         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11060         (ada_collect_symbol_completion_matches)
11061         (ada_add_global_exceptions): Update.
11062
11063 2019-01-17  Tom Tromey  <tom@tromey.com>
11064
11065         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11066         declare VEC.
11067         (solib_target_parse_libraries): Change return type.
11068         (library_list_start_segment, library_list_start_section)
11069         (library_list_end_library, library_list_start_library); Update.
11070         (solib_target_free_library_list): Remove.
11071         (solib_target_parse_libraries): Remove cleanup.  Change return
11072         type.
11073         (solib_target_current_sos): Update.
11074
11075 2019-01-17  Tom Tromey  <tromey@bapiya>
11076
11077         * valprint.c: Replace "the the" with "the".
11078         * symtab.c: Replace "the the" with "the".
11079         * solib.c: Replace "the the" with "the".
11080         * solib-dsbt.c: Replace "the the" with "the".
11081         * linespec.c: Replace "the the" with "the".
11082         * dwarf2loc.h: Replace "the the" with "the".
11083         * amd64-windows-tdep.c: Replace "the the" with "the".
11084         * aarch64-tdep.c: Replace "the the" with "the".
11085
11086 2019-01-16  Keith Seitz  <keiths@redhat.com>
11087
11088         PR gdb/23773
11089         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11090         <builder>: Rename to ..
11091         <m_builder>: ... this and make private.
11092         (dwarf2_cu::get_builder): New method.  Change all users of
11093         `builder' to use this method.
11094         (dwarf2_start_symtab): Move to ...
11095         (dwarf2_cu::start_symtab): ... here.  Update all callers
11096         (setup_type_unit_groups): Move to ...
11097         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11098         callers.
11099         (dwarf2_cu::reset_builder): New method.
11100         (process_full_compunit, process_full_type_unit): Use
11101         dwarf2_cu::reset_builder.
11102         (follow_die_offset): Record the ancestor CU if it is different
11103         from the followed DIE's CU.
11104         (follow_die_sig_1): Likewise.
11105
11106 2019-01-15  Tom Tromey  <tom@tromey.com>
11107
11108         * remote.c (class remote_state) <buf>: Now a char_vector.
11109         <buf_size>: Remove.
11110         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11111         parameter.
11112         (remote_target::getpkt_or_notif_sane_1)
11113         (remote_target::getpkt_sane)
11114         (remote_target::getpkt_or_notif_sane): Likewise.
11115         (class remote_target) <putpkt>: New overload.
11116         (remote_target::read_frame): Change type of "buf_p".  Remove
11117         sizeof_p parameter.
11118         (packet_ok): New overload.
11119         (packet_check_result): New overload.
11120         Update all uses.
11121
11122 2019-01-14  Tom Tromey  <tom@tromey.com>
11123
11124         * remote-notif.c (handle_notification, remote_notif_ack)
11125         (remote_notif_parse): Make "buf" const.
11126         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11127         const.
11128         (remote_notif_parse, remote_notif_ack, handle_notification):
11129         Likewise.
11130         * remote.c (remote_notif_stop_parse): Make "buf" const.
11131         (remote_target::remote_parse_stop_reply): Make "buf" const.
11132         (remote_notif_stop_ack): Make "buf" const.
11133
11134 2019-01-14  Tom Tromey  <tom@tromey.com>
11135
11136         * remote.c (remote_console_output): Make parameter const.
11137
11138 2019-01-14  Tom Tromey  <tom@tromey.com>
11139
11140         * target-debug.h (target_debug_print_signals): Constify.
11141         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11142         * procfs.c (procfs_target::pass_signals): Update.
11143         * linux-nat.c (linux_nat_target::pass_signals): Update.
11144         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11145         * target-delegates.c: Rebuild.
11146         * remote.c (remote_target::program_signals): Update.
11147         (remote_target::pass_signals): Update.
11148         * target.c (target_pass_signals): Constify argument.
11149         (target_program_signals): Likewise.
11150         * target.h (struct target_ops) <pass_signals, program_signals>:
11151         Constify argument.
11152         (target_pass_signals, target_program_signals): Constify argument.
11153
11154 2019-01-14  Tom Tromey  <tom@tromey.com>
11155
11156         PR tui/28819:
11157         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11158
11159 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11160
11161         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11162         field.
11163         * rs6000-tdep.c: Include reggroups.h.
11164         (IS_V_ALIAS_PSEUDOREG): Define.
11165         (rs6000_register_name): Return names for the "vX" aliases.
11166         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11167         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11168         aliases.  Call default_register_reggroup_p for all other
11169         pseudo-registers.
11170         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11171         New functions.
11172         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11173         Handle "vX" aliases.
11174         (v_alias_pseudo_register_collect): New function.
11175         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11176         (rs6000_gdbarch_init): Initialize "vX" aliases as
11177         pseudo-registers.  Restore registration of
11178         rs6000_pseudo_register_reggroup_p with
11179         set_tdesc_pseudo_register_reggroup_p.
11180
11181 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11182
11183         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11184         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11185         set_gdbarch_num_pseudo_regs.
11186
11187 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11188
11189         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11190         Remove arg prefixname, add do_set and do_show.
11191         Add member functions set_list and show_list.
11192         * cli/cli-style.c (class cli_style_option): Update accordingly.
11193         (style_set_list): Move to file scope.
11194         (style_show_list): Likewise.
11195         (set_style): Call help_list.
11196         (show_style): Call cmd_show_list.
11197         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11198         Update to use the new macro.
11199
11200 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11201
11202         * ada-lang.c (_initialize_ada_language): Expand the help text
11203         for the "catch exception" command.
11204
11205 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11206
11207         * symtab.c (matching_obj_sections): Initialize obj,
11208         declare it closer to its usage.
11209
11210 2019-01-10  Tom Tromey  <tom@tromey.com>
11211
11212         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11213         (basic_inf_threads_range): Remove.
11214         (inf_threads_range, inf_non_exited_threads_range)
11215         (safe_inf_threads_range): Use next_adapter.
11216
11217 2019-01-10  Keith Seitz  <keiths@redhat.com>
11218
11219         PR gdb/23712
11220         PR symtab/23010
11221         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11222         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11223
11224 2019-01-10  Keith Seitz  <keiths@redhat.com>
11225
11226         PR gdb/23712
11227         PR symtab/23010
11228         * dictionary.c (pending_to_vector): Remove.
11229         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11230         Remove _1 suffix, replacing functions of the same name.  Update
11231         all callers.
11232         (dict_create_hashed, dict_create_hashed_expandable)
11233         (dict_create_linear, dict_create_linear_expandable, dict_free)
11234         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11235         Make functions static.
11236
11237 2019-01-10  Keith Seitz  <keiths@redhat.com>
11238
11239         PR gdb/23712
11240         PR symtab/23010
11241         * dictionary.h (struct dictionary): Replace declaration with
11242         multidictionary.
11243         (dict_create_hashed, dict_create_hashed_expandable)
11244         (dict_create_linear, dict_create_linear_expandable)
11245         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11246         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11247         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11248         taking multidictionary argument.
11249         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11250         * block.h (struct block) <dict>: Change to multidictionary
11251         and rename `multidict'.
11252         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11253         symmisc.c: Update all dictionary references to multidictionary.
11254
11255 2019-01-10  Keith Seitz  <keiths@redhat.com>
11256
11257         PR gdb/23712
11258         PR symtab/23010
11259         * dictionary.c: Include unordered_map.
11260         (pending_to_vector): New function.
11261         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11262         Rewrite the non-"_1" functions to take vector instead
11263         of linked list.
11264         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11265         "new" _1 versions of the same name.
11266         (multidictionary): Define.
11267         (std::hash<enum language): New definition.
11268         (collate_pending_symbols_by_language, mdict_create_hashed)
11269         (mdict_create_hashed_expandable, mdict_create_linear)
11270         (mdict_create_linear_expandable, mdict_free)
11271         (find_language_dictionary, create_new_language_dictionary)
11272         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11273         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11274         (mdict_size, mdict_empty): New functions.
11275         * dictionary.h (mdict_iterator): Define.
11276
11277 2019-01-10  Pedro Alves  <palves@redhat.com>
11278
11279         * breakpoint.c (read_uploaded_action)
11280         (create_tracepoint_from_upload): Adjust to use
11281         gdb::unique_xmalloc_ptr.
11282         * ctf.c (ctf_write_uploaded_tp):
11283         (SET_ARRAY_FIELD): Use emplace_back.
11284         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11285         * tracefile-tfile.c (tfile_write_uploaded_tp):
11286         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11287         gdb::unique_xmalloc_ptr.
11288         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11289         at_string, cond_string, cmd_strings>: Replace char pointers
11290         with gdb::unique_xmalloc_ptr.
11291
11292 2019-01-10  Pedro Alves  <palves@redhat.com>
11293
11294         * solib-target.c (library_list_start_library): Don't xstrdup name.
11295
11296 2019-01-10  Pedro Alves  <palves@redhat.com>
11297
11298         * mdebugread.c (parse_partial_symbols): Use
11299         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11300
11301 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * linux-fork.c (scoped_switch_fork_info)
11304         <~scoped_switch_fork_info>: Fix incorrect variable name.
11305
11306 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11307
11308         * linux-fork.c (scoped_switch_fork_info)
11309         <scoped_switch_fork_info>: Make explicit.
11310         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11311
11312 2019-01-10  Tom Tromey  <tom@tromey.com>
11313
11314         * objfiles.h (objfile::reset_psymtabs): Update.
11315         * objfiles.c (objfile::objfile): Update.
11316         * psymtab.h (psymtab_storage::obstack): Update.
11317         (psymtab_storage::m_obstack): Use gdb::optional.
11318         (class psymtab_storage): Update comment.  Remove objfile
11319         parameter.
11320         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11321
11322 2019-01-10  Tom Tromey  <tom@tromey.com>
11323
11324         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11325         <free_psymtabs>: Now private.
11326         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11327         (allocate_psymtab): Use new method.
11328
11329 2019-01-10  Tom Tromey  <tom@tromey.com>
11330
11331         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11332         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11333         * mdebugread.c (parse_partial_symbols): Use
11334         allocate_dependencies.
11335         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11336         allocate_dependencies.
11337         (process_psymtab_comp_unit_reader)
11338         (build_type_psymtab_dependencies): Likewise.
11339         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11340
11341 2019-01-10  Tom Tromey  <tom@tromey.com>
11342
11343         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11344         PSYMBOL_SET_LANGUAGE.
11345         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11346
11347 2019-01-10  Tom Tromey  <tom@tromey.com>
11348
11349         * psymtab.h (psymtab_storage::obstack): New method.
11350         <m_obstack>: Rename from obstack; now private.
11351         * psymtab.c (psymtab_storage): Update.
11352         * dwarf2read.c (create_addrmap_from_index)
11353         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11354         Update.
11355
11356 2019-01-10  Tom Tromey  <tom@tromey.com>
11357
11358         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11359         * objfiles.h (objfile::reset_psymtabs): New method.
11360
11361 2019-01-10  Tom Tromey  <tom@tromey.com>
11362
11363         * symmisc.c (print_symbol_bcache_statistics): Update.
11364         (print_objfile_statistics): Update.
11365         * symfile.c (reread_symbols): Update.
11366         * psymtab.h (class psymtab_storage): New.
11367         * psymtab.c (psymtab_storage): New constructor.
11368         (~psymtab_storage): New destructor.
11369         (require_partial_symbols): Update.
11370         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11371         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11372         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11373         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11374         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11375         (start_psymtab_common, end_psymtab_common)
11376         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11377         (allocate_psymtab): Update.
11378         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11379         Update.
11380         (dump_psymtab_addrmap, maintenance_print_psymbols)
11381         (maintenance_check_psymtabs): Update.
11382         (class objfile_psymtabs): Move to objfiles.h.
11383         * psympriv.h (discard_psymtab): Now inline.
11384         (psymtab_discarder::psymtab_discarder): Update.
11385         (psymtab_discarder::~psymtab_discarder): Update.
11386         (ALL_OBJFILE_PSYMTABS): Rewrite.
11387         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11388         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11389         Remove fields.
11390         <partial_symtabs>: New field.
11391         (class objfile_psymtabs): Move from psymtab.h.  Update.
11392         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11393         psymbol_cache.
11394         (objfile::~objfile): Don't destroy psymbol_cache.
11395         * mdebugread.c (parse_partial_symbols): Update.
11396         * dwarf2read.c (create_addrmap_from_index)
11397         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11398         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11399         (add_partial_subprogram, dwarf2_ranges_read): Update.
11400         * dwarf-index-write.c (write_address_map)
11401         (write_one_signatured_type, recursively_write_psymbols)
11402         (class debug_names, class debug_names, write_psymtabs_to_index):
11403         Update.
11404
11405 2019-01-10  Tom Tromey  <tom@tromey.com>
11406
11407         * symtab.h (SYMBOL_SET_NAMES): Update.
11408         (symbol_set_names): Update.
11409         (MSYMBOL_SET_NAMES): Update.
11410         * symtab.c (symbol_set_names): Change argument to be an
11411         objfile_per_bfd_storage.
11412         * psymtab.c (add_psymbol_to_bcache): Update.
11413         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11414
11415 2019-01-10  Tom Tromey  <tom@tromey.com>
11416
11417         * symtab.c (create_demangled_names_hash): Change argument to be an
11418         objfile_per_bfd_storage.
11419         (symbol_set_names): Update.
11420
11421 2019-01-10  Tom Tromey  <tom@tromey.com>
11422
11423         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11424         init_psymbol_list.
11425         * psymtab.c (init_psymbol_list): Do nothing if already called.
11426         * psympriv.h (init_psymbol_list): Add comment.
11427         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11428         init_psymbol_list.
11429         * dbxread.c (dbx_symfile_read): Unconditionally call
11430         init_psymbol_list.
11431
11432 2019-01-10  Tom Tromey  <tom@tromey.com>
11433
11434         * xcoffread.c (scan_xcoff_symtab): Update.
11435         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11436         "where".
11437         * mdebugread.c (parse_partial_symbols)
11438         (handle_psymbol_enumerators): Update.
11439         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11440         * dbxread.c (read_dbx_symtab): Update.
11441         * psympriv.h (psymbol_placement): New enum.
11442         (add_psymbol_to_list): Update.
11443
11444 2019-01-10  Tom Tromey  <tom@tromey.com>
11445
11446         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11447         static_psymbols parameters.
11448         (scan_xcoff_symtab): Update.
11449         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11450         static_psymbols parameters.
11451         * psympriv.h (start_psymtab_common): Update.
11452         * mdebugread.c (parse_partial_symbols): Update.
11453         * dwarf2read.c (create_partial_symtab): Update.
11454         * dbxread.c (read_dbx_symtab): Update.
11455         (start_psymtab): Remove global_psymbols and static_psymbols
11456         parameters.
11457
11458 2019-01-10  Tom Tromey  <tom@tromey.com>
11459
11460         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11461         * psymtab.c (allocate_psymtab): Add comment.
11462         * psympriv.h (allocate_psymtab): Add comment.
11463         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11464         initializations.
11465         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11466
11467 2019-01-10  Tom Tromey  <tom@tromey.com>
11468
11469         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11470         Don't declare.
11471         * mipsread.c: Include mdebugread.h.
11472         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11473         Declare.
11474         * elfread.c: Include mdebugread.h.
11475
11476 2019-01-09  Tom Tromey  <tom@tromey.com>
11477
11478         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11479         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11480         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11481         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11482         (psym_lookup_symbol, psym_find_last_source_symtab)
11483         (psym_forget_cached_source_info, psym_print_stats)
11484         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11485         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11486         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11487         (psym_find_compunit_symtab_by_address)
11488         (maintenance_print_psymbols, maintenance_info_psymtabs)
11489         (maintenance_check_psymtabs): Use ranged for.
11490         * psymtab.h (class objfile_psymtabs): New.
11491         (require_partial_symbols): Return objfile_psymtabs.
11492         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11493
11494 2019-01-09  Tom Tromey  <tom@tromey.com>
11495
11496         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11497         (find_pc_mapped_section, list_overlays_command)
11498         (map_overlay_command, unmap_overlay_command)
11499         (simple_overlay_update): Use all_objfiles.
11500         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11501         * printcmd.c (info_symbol_command): Use all_objfiles.
11502         * objfiles.h (ALL_OBJSECTIONS): Remove.
11503         * maint.c (maintenance_translate_address): Use all_objfiles.
11504         * gcore.c (gcore_create_callback): Use all_objfiles.
11505         (objfile_find_memory_regions): Likewise.
11506
11507 2019-01-09  Tom Tromey  <tom@tromey.com>
11508
11509         * symtab.c (find_line_symtab, info_sources_command)
11510         (make_source_files_completion_list): Use objfile_compunits.
11511         * source.c (select_source_symtab): Use objfile_compunits.
11512         * objfiles.h (struct objfile): Update comment.
11513         (ALL_OBJFILES): Remove.
11514         (ALL_FILETABS): Remove.
11515         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11516         objfile_compunits.
11517
11518 2019-01-09  Tom Tromey  <tom@tromey.com>
11519
11520         * symmisc.c (print_objfile_statistics, dump_objfile)
11521         (maintenance_print_symbols): Use compunit_filetabs.
11522         * source.c (forget_cached_source_info_for_objfile): Use
11523         compunit_filetabs.
11524         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11525         (ALL_FILETABS): Use compunit_filetabs.
11526         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11527         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11528
11529 2019-01-09  Tom Tromey  <tom@tromey.com>
11530
11531         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11532         (compunit_filetabs): New.
11533         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11534         compunit_filetabs.
11535         (info_sources_command, make_source_files_completion_list): Remove
11536         declaration.
11537         * symmisc.c (print_objfile_statistics, dump_objfile)
11538         (maintenance_print_symbols): Remove declaration.
11539         (maintenance_info_symtabs): Use compunit_filetabs.
11540         (maintenance_info_line_tables): Likewise.
11541         * source.c (select_source_symtab): Change local variable name.
11542         (forget_cached_source_info_for_objfile): Remove declaration.
11543         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11544         * objfiles.c (objfile_relocate1): Remove declaration.
11545         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11546         declaration.
11547         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11548         * coffread.c (coff_symtab_read): Remove declaration.
11549         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11550         compunit_filetabs.
11551
11552 2019-01-09  Tom Tromey  <tom@tromey.com>
11553
11554         * symtab.c (lookup_objfile_from_block)
11555         (find_pc_sect_compunit_symtab, search_symbols)
11556         (default_collect_symbol_completion_matches_break_on): Use
11557         objfile_compunits.
11558         * objfiles.h (ALL_COMPUNITS): Remove.
11559         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11560         * cp-support.c (add_symbol_overload_list_qualified): Use
11561         objfile_compunits.
11562         * ada-lang.c (ada_collect_symbol_completion_matches)
11563         (ada_add_global_exceptions): Use objfile_compunits.
11564
11565 2019-01-09  Tom Tromey  <tom@tromey.com>
11566
11567         * source.c (select_source_symtab)
11568         (forget_cached_source_info_for_objfile): Remove declaration.
11569         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11570         declaration.
11571         * maint.c (count_symtabs_and_blocks): Remove declaration.
11572         * cp-support.c (add_symbol_overload_list_qualified): Remove
11573         declaration.
11574         * coffread.c (coff_symtab_read): Remove declaration.
11575         * symtab.c (lookup_symbol_in_objfile_symtabs)
11576         (basic_lookup_transparent_type_1): Use objfile_compunits.
11577         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11578         (info_sources_command, search_symbols)
11579         (default_collect_symbol_completion_matches_break_on)
11580         (make_source_files_completion_list): Remove declaration.
11581         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11582         (ada_collect_symbol_completion_matches)
11583         (ada_add_global_exceptions): Remove declaration.
11584         * linespec.c (iterate_over_all_matching_symtabs): Use
11585         objfile_compunits.
11586         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11587         (class objfile_compunits): New.
11588         (ALL_COMPUNITS): Use objfile_compunits.
11589         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11590         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11591         objfile_compunits.
11592         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11593
11594 2019-01-09  Tom Tromey  <tom@tromey.com>
11595
11596         * symtab.c (search_symbols)
11597         (default_collect_symbol_completion_matches_break_on): Use
11598         objfile_msymbols.
11599         * ada-lang.c (ada_lookup_simple_minsym)
11600         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11601         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11602         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11603         objfile_msymbols.
11604         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11605         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11606         * objc-lang.c (find_methods): Use objfile_msymbols.
11607         (info_selectors_command, info_classes_command): Likewise.
11608         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11609         * objfiles.h (class objfile_msymbols): New.
11610         (ALL_OBJFILE_MSYMBOLS): Remove.
11611         (ALL_MSYMBOLS): Remove.
11612
11613 2019-01-09  Tom Tromey  <tom@tromey.com>
11614
11615         * common/next-iterator.h (next_adapter): Add Iterator template
11616         parameter.
11617         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11618         (class all_objfiles_safe): New.
11619         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11620         * objfiles.c (put_objfile_before): Update comment.
11621         (add_separate_debug_objfile): Likewise.
11622         (free_all_objfiles): Use all_objfiles_safe.
11623         (objfile_purge_solibs): Likewise.
11624
11625 2019-01-09  Tom Tromey  <tom@tromey.com>
11626
11627         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11628         (expand_symtab_containing_pc, lookup_static_symbol)
11629         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11630         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11631         all_objfiles.
11632         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11633         * breakpoint.c (create_overlay_event_breakpoint)
11634         (create_longjmp_master_breakpoint)
11635         (create_std_terminate_master_breakpoint)
11636         (create_exception_master_breakpoint): Use all_objfiles.
11637         * linux-thread-db.c (try_thread_db_load_from_pdir)
11638         (has_libpthread): Use all_objfiles.
11639         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11640         * linespec.c (iterate_over_all_matching_symtabs)
11641         (search_minsyms_for_name): Use all_objfiles.
11642         * maint.c (maintenance_info_sections): Use all_objfiles.
11643         * main.c (captured_main_1): Use all_objfiles.
11644         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11645         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11646         * guile/scm-pretty-print.c
11647         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11648         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11649         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11650         (maintenance_print_msymbols): Use all_objfiles.
11651         * source.c (select_source_symtab): Use all_objfiles.
11652         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11653         * symfile.c (remove_symbol_file_command)
11654         (expand_symtabs_matching, map_symbol_filenames): Use
11655         all_objfiles.
11656         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11657         all_objfiles.
11658         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11659         * objc-lang.c (find_methods): Use all_objfiles.
11660         * objfiles.c (have_partial_symbols, have_full_symbols)
11661         (have_minimal_symbols, qsort_cmp)
11662         (default_iterate_over_objfiles_in_search_order): Use
11663         all_objfiles.
11664         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11665         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11666         (maintenance_check_psymtabs): Use all_objfiles.
11667         (ALL_PSYMTABS): Remove.
11668         * compile/compile-object-run.c (do_module_cleanup): Use
11669         all_objfiles.
11670         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11671         * cp-support.c (add_symbol_overload_list_qualified): Use
11672         all_objfiles.
11673         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11674         Use all_objfiles.
11675         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11676         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11677         all_objfiles.
11678         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11679         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11680         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11681         Uses all_objfiles.
11682         * solib.c (solib_read_symbols): Use all_objfiles
11683
11684 2019-01-09  Tom Tromey  <tom@tromey.com>
11685
11686         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11687         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11688         all_objfiles.
11689         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11690         * symmisc.c (print_symbol_bcache_statistics)
11691         (print_objfile_statistics, maintenance_print_objfiles)
11692         (maintenance_info_symtabs, maintenance_check_symtabs)
11693         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11694         all_objfiles.
11695         * source.c (forget_cached_source_info): Use all_objfiles.
11696         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11697         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11698         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11699         * objfiles.c (update_section_map): Use all_objfiles.
11700         (shared_objfile_contains_address_p): Likewise.
11701         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11702         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11703
11704 2019-01-09  Tom Tromey  <tom@tromey.com>
11705
11706         * common/next-iterator.h: New file.
11707         * objfiles.h (class all_objfiles): New.
11708         (struct objfile_iterator): New.
11709
11710 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11711
11712         * NEWS: Move the description of the changed "frame", "select-frame",
11713          and "info frame" commands to the Changed commands section.
11714
11715 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11716
11717         * gdbtypes.c (check_stub_method_group): Remove handling of old
11718         mangling schemes.
11719         * linespec.c (find_methods): Likewise.
11720         * stabsread.c (read_member_functions): Likewise.
11721         * valops.c (search_struct_method): Likewise.
11722         (value_struct_elt_for_reference): Likewise.
11723         * NEWS: Mention this change.
11724
11725 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11726
11727         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11728         print_source_lines.
11729         * source.c (print_source_lines_base): Update line number check.
11730         (print_source_lines): New function.
11731         (source_lines_range::source_lines_range): New function.
11732         * source.h (class source_lines_range): New class.
11733         (print_source_lines): New declaration.
11734
11735 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11736
11737         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11738
11739 2019-01-08  Tom Tromey  <tom@tromey.com>
11740             Simon Marchi  <simon.marchi@ericsson.com>
11741
11742         PR gdb/24060
11743         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11744         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11745         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11746         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11747         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11748         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11749
11750 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11751
11752         * source.c (select_source_symtab): Move header comment to
11753         declaration in source.h.
11754         (forget_cached_source_info_for_objfile): Likewise.
11755         (forget_cached_source_info): Likewise.
11756         (identify_source_line): Likewise.
11757         * source.h (identify_source_line): Move declaration from symtab.h
11758         and add comment from source.c
11759         (print_source_lines): Likewise.
11760         (forget_cached_source_info_for_objfile): Likewise.
11761         (forget_cached_source_info): Likewise.
11762         (select_source_symtab): Likewise.
11763         (enum print_source_lines_flag): Move definition from symtab.h.
11764         * symtab.h (identify_source_line): Move declaration to source.h.
11765         (print_source_lines): Likewise.
11766         (forget_cached_source_info_for_objfile): Likewise.
11767         (forget_cached_source_info): Likewise.
11768         (select_source_symtab): Likewise.
11769         (enum print_source_lines_flag): Move definition to source.h.
11770         * tui/tui-hooks.c: Add 'source.h' include.
11771
11772 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11773
11774         * source.c (print_source_lines_base): Handle requests to print
11775         reverse line number sequences, and guard against empty lines
11776         string.
11777
11778 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11779
11780         * source.c (print_source_lines_base): Fix skip of '\r' if next
11781         character is '\n'.
11782
11783 2019-01-06  Tom Tromey  <tom@tromey.com>
11784
11785         * c-exp.y (struct c_parse_state) <macro_original_text,
11786         expansion_obstack>: New member.
11787         (macro_original_text, expansion_obstack): Remove globals.
11788         (scan_macro_expansion, scanning_macro_expansion)
11789         (finished_macro_expansion): Update.
11790         (scan_macro_cleanup): Remove.
11791         (yylex, c_parse): Update.
11792
11793 2019-01-06  Tom Tromey  <tom@tromey.com>
11794
11795         * c-exp.y (struct c_parse_state) <strings>: New member.
11796         (operator_stoken): Update.
11797
11798 2019-01-06  Tom Tromey  <tom@tromey.com>
11799
11800         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11801         (union type_stack_elt) <typelist_val>: Now a pointer to
11802         std::vector.
11803         (type_stack_cleanup): Don't declare.
11804         (push_typelist): Update.
11805         * parse.c (pop_typelist): Return a std::vector.
11806         (push_typelist): Take a std::vector.
11807         (follow_types): Update.  Do not free args.
11808         (type_stack_cleanup): Remove.
11809         * c-exp.y (struct c_parse_state): New.
11810         (cpstate): New global.
11811         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11812         (nonempty_typelist): Update.
11813         (func_mod): Create a new vector.
11814         (c_parse): Create a c_parse_state.
11815         (check_parameter_typelist): Do not delete params.
11816         (function_method): Update.  Do not delete type_list.
11817
11818 2019-01-06  Tom Tromey  <tom@tromey.com>
11819
11820         PR gdb/28155:
11821         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11822         check_typedef.
11823         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11824         (print_return_value): Likewise.
11825
11826 2019-01-05  Tom Tromey  <tom@tromey.com>
11827
11828         * contrib/cleanup_check.py: Remove.
11829         * contrib/gcc-with-excheck: Remove.
11830         * contrib/exsummary.py: Remove.
11831         * contrib/excheck.py: Remove.
11832
11833 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11834
11835         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11836         NULL. Initialize tpprev to NULL instead of assigning it
11837         to NULL on the next statement.
11838         * windows-nat.c (windows_delete_thread): Remove check for
11839         main_thread_id before printing thread exit notifications.
11840         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11841         Remove thread ID check against main_thread_id.
11842         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11843         windows_delete_thread.
11844         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11845
11846 2019-01-04  Tom Tromey  <tom@tromey.com>
11847
11848         * compile/compile.c (_initialize_compile): Use upper case for
11849         metasyntactic variables.
11850         * symmisc.c (_initialize_symmisc): Use upper case for
11851         metasyntactic variables.
11852         * psymtab.c (_initialize_psymtab): Use upper case for
11853         metasyntactic variables.
11854         * demangle.c (demangle_command): Use upper case for metasyntactic
11855         variables.
11856         (_initialize_demangler): Likewise.
11857         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11858         variables.
11859
11860 2019-01-03  Tom Tromey  <tom@tromey.com>
11861
11862         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11863
11864 2019-01-03  Tom Tromey  <tom@tromey.com>
11865
11866         * python/py-symtab.c (salpy_str): Update.
11867         (struct salpy_sal_object) <symtab>: Now a PyObject.
11868         (salpy_dealloc): Update.
11869         (del_objfile_sal): Use gdbpy_ref.
11870
11871 2019-01-03  Tom Tromey  <tom@tromey.com>
11872
11873         * python/py-type.c (convert_field): Use new_reference.  Return
11874         gdbpy_ref.
11875         (make_fielditem): Return gdbpy_ref.
11876         (typy_fields): Update.
11877         (typy_getitem): Update.
11878         (field_name): Return gdbpy_ref.  Use new_reference.
11879         (typy_iterator_iternext): Update.
11880
11881 2019-01-03  Tom Tromey  <tom@tromey.com>
11882
11883         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11884
11885 2019-01-03  Tom Tromey  <tom@tromey.com>
11886
11887         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11888         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11889         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11890         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11891         (pspy_set_type_printers): Likewise.
11892         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11893         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11894         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11895         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11896         (objfpy_set_type_printers): Likewise.
11897
11898 2019-01-03  Tom Tromey  <tom@tromey.com>
11899
11900         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11901         (gdbpy_print_stack): Use gdbpy_err_fetch.
11902         * python/python-internal.h (class gdbpy_err_fetch): New class.
11903         (class gdbpy_enter) <m_error_type, m_error_value,
11904         m_error_traceback>: Remove.
11905         <m_error>: New member.
11906         (gdbpy_exception_to_string): Don't declare.
11907         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11908         * python/py-value.c (convert_value_from_python): Use
11909         gdbpy_err_fetch.
11910         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11911         gdbpy_exception_to_string.
11912         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11913         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11914         gdbpy_err_fetch.
11915
11916 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11917
11918         * linux-nat.c (delete_lwp_cleanup): Delete.
11919         (struct lwp_deleter): New struct.
11920         (lwp_info_up): New typedef.
11921         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11922         lwp_info_up.
11923
11924 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11925
11926         * linux-fork.c (class scoped_switch_fork_info): New class.
11927         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11928
11929 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11930
11931         * valops.c (find_overload_match): Remove use of null_cleanup, and
11932         calls to do_cleanups.
11933
11934 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11935
11936         * compile/compile-cplus-types.c
11937         (compile_cplus_instance::decl_name): Handle changes to
11938         cp_func_name.
11939         * cp-support.c (cp_func_name): Update header comment, update
11940         return type.
11941         * cp-support.h (cp_func_name): Update return type in declaration.
11942         * valops.c (find_overload_match): Move temp_func local to top
11943         level of function and change its type.  Use temp_func to hold and
11944         delete temporary string obtained from cp_func_name.
11945
11946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11947
11948         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11949         gdb::char_vector, remove cleanup, and update uses of `msg`.
11950
11951 2019-01-03  Jim Wilson  <jimw@sifive.com>
11952
11953         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11954
11955 2019-01-02  Tom Tromey  <tom@tromey.com>
11956
11957         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11958         (tdesc_parse_xml): Remove cleanups.
11959         * target-descriptions.h (make_cleanup_free_target_description):
11960         Don't declare.
11961         (target_desc_deleter): New struct.
11962         (target_desc_up): New typedef.
11963         * target-descriptions.c (target_desc_deleter::operator()): Rename
11964         from free_target_description.
11965         (make_cleanup_free_target_description): Remove.
11966
11967 2019-01-02  Tom Tromey  <tom@tromey.com>
11968
11969         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11970         constructor, destructor.
11971         (linespec_parser): Remove typedef.
11972         (~linespec_parser): Rename from linespec_parser_delete.
11973         (linespec_lex_to_end, linespec_complete_label)
11974         (linespec_complete): Update.
11975         (decode_line_full): Remove cleanups.
11976         (decode_line_1): Update.
11977
11978 2019-01-02  Tom Tromey  <tom@tromey.com>
11979
11980         * python/python-internal.h (inferior_to_inferior_object): Change
11981         return type.
11982         * python/py-exitedevent.c (create_exited_event_object): Update.
11983         * python/py-inferior.c (inferior_to_inferior_object): Return
11984         gdbpy_ref.
11985         (python_new_inferior, python_inferior_deleted)
11986         (thread_to_thread_object, delete_thread_object)
11987         (build_inferior_list, gdbpy_selected_inferior): Update.
11988         * python/py-infthread.c (create_thread_object): Update.  Also fail
11989         if inferior_to_inferior_object fails.
11990
11991 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11992
11993         * inferior.h (class inferior) <displaced_step_state>: New field.
11994         * infrun.h (struct displaced_step_state): Move here from
11995         infrun.c.  Initialize fields, add constructor.
11996         <inf>: Remove field.
11997         <reset>: New method.
11998         * infrun.c (struct displaced_step_inferior_state): Move to
11999         infrun.h.
12000         (displaced_step_inferior_states): Remove.
12001         (get_displaced_stepping_state): Adust.
12002         (displaced_step_in_progress_any_inferior): Adjust.
12003         (displaced_step_in_progress_thread): Adjust.
12004         (displaced_step_in_progress): Adjust.
12005         (add_displaced_stepping_state): Remove.
12006         (get_displaced_step_closure_by_addr): Adjust.
12007         (remove_displaced_stepping_state): Remove.
12008         (infrun_inferior_exit): Call displaced_step_state.reset.
12009         (use_displaced_stepping): Don't check for NULL.
12010         (displaced_step_prepare_throw): Call
12011         get_displaced_stepping_state.
12012         (displaced_step_fixup): Don't check for NULL.
12013         (prepare_for_detach): Don't check for NULL.
12014
12015 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12016
12017         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12018          in case of call that did not complete.
12019
12020 2019-01-02  Andrey Utkin  <autkin@undo.io>
12021
12022         * symfile.c (find_separate_debug_file): Fix search of debug files for
12023         remote debuggee.
12024
12025 2019-01-02  Tom Tromey  <tom@tromey.com>
12026
12027         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12028         indentation.
12029         * python/py-frame.c (frapy_older): Remove cast.
12030         (frapy_newer): Likewise.
12031         * python/py-breakpoint.c (local_setattro): Remove cast.
12032         * python/py-arch.c (archpy_name): Remove local variable.
12033         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12034
12035 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12036
12037         * unittests/basic_string_view/element_access/char/empty.cc:
12038         Fix year range in copyright header.
12039
12040 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12041
12042         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12043         Delete.
12044         <operator==>: Update with for removed field.
12045         <hash>: Likewise.
12046         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12047         <isa_features>: ...this.
12048         <abi_features>: New field.
12049         (riscv_isa_flen): Update comment.
12050         (riscv_abi_xlen): New declaration.
12051         (riscv_abi_flen): New declaration.
12052         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12053         isa_features.
12054         (riscv_abi_xlen): New function.
12055         (riscv_isa_flen): Update to get answer from isa_features.
12056         (riscv_abi_flen): New function.
12057         (riscv_has_fp_abi): Update to get answer from abi_features.
12058         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12059         xlen and flen.
12060         (riscv_call_info) <xlen, flen>: Update comment.
12061         (riscv_call_arg_struct): Remove invalid assertions
12062         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12063         is removed.
12064         (riscv_gdbarch_init): Gather isa features and abi features
12065         separately, ensure both match on the gdbarch when reusing an old
12066         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12067         a target with 64-bit float hardware.
12068
12069 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12070
12071         * source.c (search_command_helper): Stop reverse search
12072         when line 1 has been searched.
12073
12074 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12075
12076         * record-full.c (record_full_base_target::close): Rewrite
12077         record_full_core_buf_list free logic.
12078
12079 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12080
12081         * break-catch-syscall.c (print_one_catch_syscall): xfree
12082         the last text.
12083
12084 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12085
12086         * top.c (print_gdb_version): Update Copyright year in version
12087         message.
12088
12089 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12090
12091         Update copyright year range in all GDB files.
12092
12093 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12094
12095         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12096
12097 For older changes see ChangeLog-2018.
12098 \f
12099 Local Variables:
12100 mode: change-log
12101 left-margin: 8
12102 fill-column: 74
12103 version-control: never
12104 coding: utf-8
12105 End:
12106