1 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
6 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
8 * ctf-impl.h (ctf_list_splice): New.
9 * ctf-util.h (ctf_list_splice): Likewise.
10 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
11 (ctf_link_sort_inputs): Likewise.
12 (ctf_link_deduplicating_count_inputs): Likewise.
13 (ctf_link_deduplicating_open_inputs): Likewise.
14 (ctf_link_deduplicating_close_inputs): Likewise.
15 (ctf_link_deduplicating_variables): Likewise.
16 (ctf_link_deduplicating_per_cu): Likewise.
17 (ctf_link_deduplicating): Likewise.
20 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
22 * ctf-link.c (ctf_link_one_input_archive_member): Check
23 CTF_LINK_OMIT_VARIABLES_SECTION.
25 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
27 * ctf-impl.h (ctf_type_id_key): New, the key in the
29 (ctf_dedup): New, core deduplicator state.
30 (ctf_file_t) <ctf_dedup>: New.
31 <ctf_dedup_atoms>: New.
32 <ctf_dedup_atoms_alloc>: New.
33 (ctf_hash_type_id_key): New prototype.
34 (ctf_hash_eq_type_id_key): Likewise.
35 (ctf_dedup_atoms_init): Likewise.
36 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
37 (ctf_dedup_atoms_init): Likewise.
38 * ctf-create.c (ctf_serialize): Adjusted.
39 (ctf_add_encoded): No longer static.
40 (ctf_add_reftype): Likewise.
41 * ctf-open.c (ctf_file_close): Destroy the
42 ctf_dedup_atoms_alloc.
43 * ctf-dedup.c: New file.
44 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
45 * configure.ac: Check for stpcpy.
46 * Makefile.am: Add it.
47 * Makefile.in: Regenerate.
48 * config.h.in: Regenerate.
49 * configure: Regenerate.
51 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
53 * configure.ac: Add --enable-libctf-hash-debugging.
54 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
55 * Makefile.in: Regenerated.
56 * configure: Likewise.
57 * config.h.in: Likewise.
58 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
59 (ctf_assert): Define to assert.
61 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
63 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
65 * ctf-impl.h: Include it.
67 (ctf_sha1_add): Likewise.
68 (ctf_sha1_fini): Likewise.
69 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
71 * Makefile.am: Add file.
72 * Makefile.in: Regenerate.
74 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
76 * libctf.ver (ctf_link_set_variable_filter): Add.
77 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
78 <ctf_link_variable_filter_arg>: Likewise.
79 * ctf-create.c (ctf_serialize): Adjust.
80 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
81 (ctf_link_one_variable): Call it if set.
83 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
85 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
86 conflicts, not the source type.
88 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
90 * ctf-impl.h (ctf_file_t): Improve comments.
91 <ctf_link_cu_mapping>: Split into...
92 <ctf_link_in_cu_mapping>: ... this...
93 <ctf_link_out_cu_mapping>: ... and this.
94 * ctf-create.c (ctf_serialize): Adjust.
95 * ctf-open.c (ctf_file_close): Likewise.
96 * ctf-link.c (ctf_create_per_cu): Look things up in the
97 in_cu_mapping instead of the cu_mapping.
98 (ctf_link_add_cu_mapping): The deduplicating link will define
99 what happens if many FROMs share a TO.
100 (ctf_link_add_cu_mapping): Create in_cu_mapping and
101 out_cu_mapping. Do not create ctf_link_outputs here any more, or
102 create per-CU dicts here: they are already created when needed.
103 (ctf_link_one_variable): Log a debug message if we skip a
104 variable due to its type being concealed in a CU-mapped link.
105 (This is probably too common a case to make into a warning.)
106 (ctf_link): Create empty per-CU dicts if requested.
108 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
110 * ctf-link.c (ctf_link_write): Close the fd.
112 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
114 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
115 * Makefile.in: Regenerated.
116 * ctf-impl.h (ctf_link_input_name): New.
117 (ctf_file_t) <ctf_link_flags>: New.
118 * ctf-create.c (ctf_serialize): Adjust accordingly.
119 * ctf-link.c: Define ctf_open as weak when PIC.
120 (ctf_arc_close_thunk): Remove unnecessary thunk.
121 (ctf_file_close_thunk): Likewise.
122 (ctf_link_input_name): New.
123 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
124 (ctf_link_input_close): Adjust accordingly.
125 (ctf_link_add_ctf_internal): New, split from...
126 (ctf_link_add_ctf): ... here. Return error if lazy loading of
127 CTF is not possible. Change to just call...
128 (ctf_link_add): ... this new function.
129 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
130 ctf_file_close_thunk.
131 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
132 <in_file_name>: ... this.
134 <share_mode>: Likewise (migrated to ctf_link_flags).
135 <done_main_member>: Rename to...
136 <done_parent>: ... this.
137 <main_input_fp>: Rename to...
138 <in_fp_parent>: ... this.
140 (ctf_link_one_type): Adjuwt accordingly. Transition to
141 ctf_err_warn, removing a TODO.
142 (ctf_link_one_variable): Note a case too common to warn about.
143 Report in the debug stream if a cu-mapped link prevents addition
144 of a conflicting variable.
145 (ctf_link_one_input_archive_member): Adjust.
146 (ctf_link_lazy_open): New, open a CTF archive for linking when
148 (ctf_link_close_one_input_archive): New, close it again.
149 (ctf_link_one_input_archive): Adjust for lazy opening, member
150 renames, and ctf_err_warn transition. Move the
151 empty_link_type_mapping call to...
152 (ctf_link): ... here. Adjut for renamings and thunk removal.
153 Don't spuriously fail if some input contains no CTF data.
154 (ctf_link_write): ctf_err_warn transition.
155 * libctf.ver: Remove not-yet-stable comment.
157 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
159 * ctf-impl.h (ctf_strerror): Delete.
160 * ctf-subr.c (ctf_strerror): Likewise.
161 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
164 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
166 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
167 (ctf_import_unref): New.
168 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
169 zero. Don't recurse back in if the refcount is already zero.
170 (ctf_import): Check ctf_parent_unreffed before deciding whether
171 to close a pre-existing parent. Set it to zero.
172 (ctf_import_unreffed): New, as above, setting
173 ctf_parent_unreffed to 1.
174 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
175 child: use direct assignment, and set unreffed on the new and
177 * ctf-link.c (ctf_create_per_cu): Import the parent using
180 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
182 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
183 (ctf_link_type_key): ... this, adjusting member prefixes to
185 (ctf_hash_type_mapping_key): Rename to...
186 (ctf_hash_type_key): ... this.
187 (ctf_hash_eq_type_mapping_key): Rename to...
188 (ctf_hash_eq_type_key): ... this.
189 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
190 (ctf_hash_type_key): ... this, and adjust for member name
192 (ctf_hash_eq_type_mapping_key): Rename to...
193 (ctf_hash_eq_type_key): ... this, and adjust for member name
195 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
196 need for out-of-memory checking in this code.
197 (ctf_type_mapping): Adjust.
199 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
201 configure.ac: Check for vasprintf.
202 configure: Regenerated.
203 config.h.in: Likewise.
205 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
207 * ctf-archive.c (ctf_arc_bufopen): Fix message.
209 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
211 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
213 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
214 if the input has no symtab, rather than dividing by
215 zero. Arrange to free it later via ctfi_free_ctfsect.
216 * ctf-archive.c (ctf_new_archive_internal): Do not
217 ctfi_free_strsect by default.
218 (ctf_arc_close): Possibly free it here.
220 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
222 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
223 (ctf_dump_format_type): improve slice formatting. Always print
224 the type size, even of slices.
225 (ctf_dump_member): Print slices (-> bitfields) differently from
226 non-slices. Failure to format a type is not an OOM.
228 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
230 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
231 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
232 (ctf_dump_objts): Likewise.
233 (ctf_dump_var): Likewise.
234 (ctf_dump_type): Do not emit a duplicate message. Move to
235 ctf_err_warning, and swallow all errors.
237 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
239 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
240 (ctf_decl_buf): Once it escapes, don't try to free it later.
242 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
244 * ctf-types.c (ctf_type_aname): Print arg types here...
245 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
246 in the type name here.
248 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
250 * ctf-impl.h (ctf_assert): New.
251 (ctf_err_warning_t): Likewise.
252 (ctf_file_t) <ctf_errs_warnings>: Likewise.
253 (ctf_err_warn): New prototype.
254 (ctf_assert_fail_internal): Likewise.
255 * ctf-inlines.h (ctf_assert_internal): Likewise.
256 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
257 * ctf-create.c (ctf_serialize): Copy it on serialization.
258 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
259 (ctf_errwarning_next): New iterator, free and pass back
260 errors/warnings in succession.
261 * libctf.ver (ctf_errwarning_next): Add.
263 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
265 * ctf-types.c (ctf_variable_iter): Fix error return.
267 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
269 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
271 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
273 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
275 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
277 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
279 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
280 ctf_dynhash_next_sorted.
281 <cu.ctn_h>: New, pointer to the dynhash under iteration.
282 <cu.ctn_s>: New, pointer to the dynset under iteration.
283 (ctf_hash_sort_f): Sorting function passed to...
284 (ctf_dynhash_next_sorted): ... this new function.
285 (ctf_dynhash_next): New.
286 (ctf_dynset_next): New.
287 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
288 (ctf_dynhash_cnext): New.
289 (ctf_dynset_cnext): New.
290 * ctf-hash.c (ctf_dynhash_next_sorted): New.
291 (ctf_dynhash_next): New.
292 (ctf_dynset_next): New.
293 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
295 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
297 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
299 * ctf-impl.h (ctf_next): New.
300 (ctf_get_dict): New prototype.
301 * ctf-lookup.c (ctf_get_dict): New, split out of...
302 (ctf_lookup_by_id): ... here.
303 * ctf-util.c (ctf_next_create): New.
304 (ctf_next_destroy): New.
305 (ctf_next_copy): New.
306 * ctf-types.c (includes): Add <assert.h>.
307 (ctf_member_next): New.
308 (ctf_enum_next): New.
309 (ctf_type_iter): Document the lack of iteration over parent
311 (ctf_type_next): New.
312 (ctf_variable_next): New.
313 * ctf-archive.c (ctf_archive_next): New.
314 * libctf.ver: Add new public functions.
316 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
318 * libctf.ver (ctf_ref): New.
319 * ctf-open.c (ctf_ref): Implement it.
321 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
323 * ctf-inlines.h (ctf_forwardable_kind): New.
324 * ctf-create.c (ctf_add_forward): Use it.
326 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
328 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
329 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
331 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
333 * ctf-hash.c (ctf_dynset_eq_string): New.
334 (ctf_dynset_create): New.
335 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
336 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
337 (key_to_internal): New.
338 (internal_to_key): New.
339 (ctf_dynset_insert): New.
340 (ctf_dynset_remove): New.
341 (ctf_dynset_destroy): New.
342 (ctf_dynset_lookup): New.
343 (ctf_dynset_exists): New.
344 (ctf_dynset_lookup_any): New.
345 (ctf_hash_insert_type): Coding style.
346 (ctf_hash_define_type): Likewise.
347 * ctf-impl.h (ctf_dynset_t): New.
348 (ctf_dynset_eq_string): New.
349 (ctf_dynset_create): New.
350 (ctf_dynset_insert): New.
351 (ctf_dynset_remove): New.
352 (ctf_dynset_destroy): New.
353 (ctf_dynset_lookup): New.
354 (ctf_dynset_exists): New.
355 (ctf_dynset_lookup_any): New.
356 * ctf-inlines.h (ctf_dynset_cinsert): New.
358 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
360 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
361 <value_free>: Likewise.
363 (ctf_dynhash_item_free): Indirect through the owner.
364 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
365 allocate space for the key_free and value_free fields fields
367 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
368 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
369 value_free if they will exist. Set the slot's owner, but only
371 (ctf_dynhash_remove): Adjust.
373 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
375 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
376 there is a key-freeing function and the key already exists.
378 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
380 * ctf-inlines.h: New file.
381 * ctf-impl.h: Include it.
382 (ctf_hash_iter_find_f): New typedef.
383 (ctf_dynhash_elements): New.
384 (ctf_dynhash_lookup_kv): New.
385 (ctf_dynhash_iter_find): New.
386 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
387 (ctf_traverse_find_cb_arg_t): New.
388 (ctf_hashtab_traverse_find): New.
389 (ctf_dynhash_iter_find): New.
390 (ctf_dynhash_elements): New.
392 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
394 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
396 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
398 * ctf-archive.c (ctf_archive_count): New.
399 * libctf.ver: New public function.
401 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
403 * ctf-types.c (ctf_member_count): New.
404 * libctf.ver: New public function.
406 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
408 * ctf-types.c (ctf_type_kind_forwarded): New.
410 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
412 * ctf-types.c (ctf_type_name_raw): New.
413 (ctf_type_aname_raw): Reimplement accordingly.
415 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
417 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
419 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
421 * ctf-impl.h (struct ctf_archive_internal)
422 <ctfi_unmap_on_close>: New.
423 (ctf_new_archive_internal): Adjust.
424 * ctf-archive.c (ctf_new_archive_internal): Likewise.
425 Initialize ctfi_unmap_on_close. Adjust error path.
426 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
427 (unmap_on_close is 0).
428 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
429 * ctf-open-bfd.c (ctf_fdopen): Adjust.
431 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
433 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
434 ints, floats or typedefs have no name. Fix comment typo.
436 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
438 * ctf-create.c (ctf_add_slice): Support slices of any kind that
439 resolves to an integral type.
440 * ctf-types.c (ctf_type_encoding): Resolve the type before
441 fishing its encoding out.
443 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
445 * ctf-create.c (ctf_create): Mark dirty.
447 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
449 * ctf-create.c (membcmp) Skip nameless members.
451 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
453 * ctf-create.c (ctf_add_member_offset): Support names of ""
454 as if they were the null pointer.
456 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
458 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
461 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
463 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
465 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
467 * ctf-create.c (ctf_serialize): Add cast.
468 (ctf_add_slice): Likewise.
470 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
472 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
473 * ctf-create.c (ctf_add_function): Check for unimplemented type
474 and populate at the same time. Populate one-by-one, not via
476 (ctf_serialize): Remove unnecessary cast.
477 * ctf-types.c (ctf_func_type_info): Likewise.
478 (ctf_func_type_args): Likewise. Fix comment typo.
480 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
482 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
483 (ctf_add_array): Support array contents of type zero.
484 (ctf_add_function): Support arguments and return types of
486 (ctf_add_typedef): Support typedefs to type zero.
487 (ctf_add_member_offset): Support members of type zero,
488 unless added at unspecified (naturally-aligned) offset.
490 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
492 * ctf-error.c: Include <stddef.h>, for offsetof.
493 (_ctf_errlist): Migrate to...
494 (_ctf_errlist_t): ... this.
495 (_ctf_erridx): New, indexes into _ctf_errlist_t.
497 (ctf_errmsg): Adjust accordingly.
498 * Makefile.am (BUILT_SOURCES): Note...
499 (ctf-error.h): ... this new rule.
500 * Makefile.in: Regenerate.
501 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
502 * .gitignore: New, ignore ctf-error.h.
504 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
506 * ctf-impl.h: Fix typos in comments.
508 2020-07-22 Nick Clifton <nickc@redhat.com>
510 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
511 same file descriptor.
513 2020-07-04 Nick Clifton <nickc@redhat.com>
515 Binutils 2.35 branch created.
517 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
519 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
521 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
522 * config.h.in: Regenerated.
523 * Makefile.in: Likewise.
524 * configure: Likewise.
526 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
528 * ctf-create.c: Include <unistd.h>.
529 * ctf-open-bfd.c: Likewise.
531 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
534 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
535 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
536 means this is declared.
537 (bswap_32): Likewise.
538 (bswap_64): Likewise.
539 (bswap_identity_64): Remove, unused.
540 * configure: Regenerated.
541 * config.h.in: Likewise.
543 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
546 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
547 (_libctf_unlikely_): Likewise.
548 (_libctf_unused): Likewise.
549 (_libctf_malloc_): Likewise.
551 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
554 * ctf-archive.c (search_nametbl): No longer global: declare...
555 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
556 (search_modent_by_name): Take and use ARG for the nametbl.
558 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
560 * ctf-impl.h (ctf_new_archive_internal): Declare.
561 (ctf_arc_bufopen): Remove.
562 (ctf_archive_internal) <ctfi_free_symsect>: New.
563 * ctf-archive.c (ctf_arc_close): Use it.
564 (ctf_arc_bufopen): Fuse into...
565 (ctf_new_archive_internal): ... this, moved across from...
566 * ctf-open-bfd.c: ... here.
567 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
568 * libctf.ver: Add it.
570 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
572 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
573 (ctf_dtd_delete): Remove correspondingly.
574 (ctf_rollback): Likewise.
576 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
578 * ctf-create.c (ctf_add_type_internal): Hand back existing types
581 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
583 * ctf-create.c (ctf_add_forward): Don't add forwards to
584 types that already exist.
586 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
588 * ctf-open.c (init_types): Only intern root-visible types.
589 * ctf-create.c (ctf_dtd_insert): Likewise.
590 (ctf_dtd_delete): Only remove root-visible types.
591 (ctf_rollback): Likewise.
592 (ctf_add_generic): Adjust.
593 (ctf_add_struct_sized): Adjust comment.
594 (ctf_add_union_sized): Likewise.
595 (ctf_add_enum): Likewise.
596 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
598 2020-03-11 John Baldwin <jhb@FreeBSD.org>
600 * swap.h (bswap_identity_64): Make static.
602 2020-01-18 Nick Clifton <nickc@redhat.com>
604 Binutils 2.34 branch created.
606 2020-01-05 Joel Brobecker <brobecker@adacore.com>
609 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
610 * configure, config.h.in: Regenerate.
612 2020-01-01 Alan Modra <amodra@gmail.com>
614 Update year range in copyright notice of all files.
616 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
618 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
620 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
622 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
623 * ctf-types.c (ctf_type_lname): Likewise.
625 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
627 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
628 ctf_import after the first for a given file.
630 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
632 * ctf-impl.h (ctf_str_append_noerr): Declare.
633 * ctf-util.c (ctf_str_append_noerr): Define in terms of
635 * ctf-dump.c (str_append): New, call it.
636 (ctf_dump_format_type): Use str_append, not ctf_str_append.
637 (ctf_dump_label): Likewise.
638 (ctf_dump_objts): Likewise.
639 (ctf_dump_funcs): Likewise.
640 (ctf_dump_var): Likewise.
641 (ctf_dump_member): Likewise.
642 (ctf_dump_type): Likewise.
643 (ctf_dump): Likewise.
645 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
647 * ctf-impl.h (ctf_alloc): Remove.
648 (ctf_free): Likewise.
649 (ctf_strdup): Likewise.
650 * ctf-subr.c (ctf_alloc): Remove.
651 (ctf_free): Likewise.
652 * ctf-util.c (ctf_strdup): Remove.
654 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
655 ctf_free; strdup, not ctf_strdup.
656 (ctf_dtd_delete): Likewise.
657 (ctf_dvd_delete): Likewise.
658 (ctf_add_generic): Likewise.
659 (ctf_add_function): Likewise.
660 (ctf_add_enumerator): Likewise.
661 (ctf_add_member_offset): Likewise.
662 (ctf_add_variable): Likewise.
664 (ctf_compress_write): Likewise.
665 (ctf_write_mem): Likewise.
666 * ctf-decl.c (ctf_decl_push): Likewise.
667 (ctf_decl_fini): Likewise.
668 (ctf_decl_sprintf): Likewise. Check for OOM.
669 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
670 ctf_free; strdup, not ctf_strdup.
671 (ctf_dump_free): Likewise.
672 (ctf_dump): Likewise.
673 * ctf-open.c (upgrade_types_v1): Likewise.
674 (init_types): Likewise.
675 (ctf_file_close): Likewise.
676 (ctf_bufopen_internal): Likewise. Check for OOM.
677 (ctf_parent_name_set): Likewise: report the OOM to the caller.
678 (ctf_cuname_set): Likewise.
679 (ctf_import): Likewise.
680 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
681 free, not ctf_free; strdup, not ctf_strdup.
682 (ctf_str_free_atom): Likewise.
683 (ctf_str_create_atoms): Likewise.
684 (ctf_str_add_ref_internal): Likewise.
685 (ctf_str_remove_ref): Likewise.
686 (ctf_str_write_strtab): Likewise.
688 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
690 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
691 work right for non-int/fps.
693 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
695 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
698 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
700 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
701 * ctf-open.c (ctf_file_close): Free it.
702 * ctf-create.c (ctf_serialize): Adjust.
703 (membcmp): When reporting a conflict due to an error, report the
705 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
706 (ctf_add_type_internal): ... this. Hand back types we are already
707 in the middle of adding immediately. Hand back structs/unions with
708 the same number of members immediately. Do not walk the dynamic
709 list. Call ctf_add_type_internal, not ctf_add_type. Handle
710 forwards promoted to other types and the inverse case identically.
711 Add structs to the mapping as soon as we intern them, before they
714 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
716 * ctf-impl.h (ctf_names_t): New.
717 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
718 (ctf_file_t) <ctf_structs>: Likewise.
719 <ctf_unions>: Likewise.
720 <ctf_enums>: Likewise.
721 <ctf_names>: Likewise.
722 <ctf_lookups>: Improve comment.
723 <ctf_ptrtab_len>: New.
724 <ctf_prov_strtab>: New.
725 <ctf_str_prov_offset>: New.
726 <ctf_dtbyname>: Remove, redundant to the names hashes.
727 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
728 (ctf_dtdef_t) <dtd_name>: Remove.
729 <dtd_data>: Note that the ctt_name is now populated.
730 (ctf_str_atom_t) <csa_offset>: This is now the strtab
731 offset for internal strings too.
732 <csa_external_offset>: New, the external strtab offset.
733 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
734 (ctf_name_table): New declaration.
735 (ctf_lookup_by_rawname): Likewise.
736 (ctf_lookup_by_rawhash): Likewise.
737 (ctf_set_ctl_hashes): Likewise.
738 (ctf_serialize): Likewise.
739 (ctf_dtd_insert): Adjust.
740 (ctf_simple_open_internal): Likewise.
741 (ctf_bufopen_internal): Likewise.
742 (ctf_list_empty_p): Likewise.
743 (ctf_str_remove_ref): Likewise.
744 (ctf_str_add): Returns uint32_t now.
745 (ctf_str_add_ref): Likewise.
746 (ctf_str_add_external): Now returns a boolean (int).
747 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
748 for strings in the appropriate range.
749 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
750 when adding the null string to the new strtab.
751 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
752 (ctf_str_add_ref_internal): Add make_provisional argument. If
753 make_provisional, populate the offset and fill in the
754 ctf_prov_strtab accordingly.
755 (ctf_str_add): Return the offset, not the string.
756 (ctf_str_add_ref): Likewise.
757 (ctf_str_add_external): Return a success integer.
758 (ctf_str_remove_ref): New, remove a single ref.
759 (ctf_str_count_strtab): Do not count the initial null string's
760 length or the existence or length of any unreferenced internal
762 (ctf_str_populate_sorttab): Skip atoms with no refs.
763 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
764 to the cts_len for the null string, since it is no longer done
765 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
766 Populate the csa_offset for both internal and external cases.
767 Flush the ctf_prov_strtab afterwards, and reset the
769 * ctf-create.c (ctf_grow_ptrtab): New.
770 (ctf_create): Call it. Initialize new fields rather than old
771 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
772 Set the ctl hashes and data model.
773 (ctf_update): Rename to...
774 (ctf_serialize): ... this. Leave a compatibility function behind.
775 Tell ctf_simple_open_internal that this is a writable dictionary.
776 Pass the new fields along from the old dictionary. Drop
777 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
778 Do not zero out the DTD's ctt_name.
779 (ctf_prefixed_name): Rename to...
780 (ctf_name_table): ... this. No longer return a prefixed name: return
781 the applicable name table instead.
782 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
783 kind we're adding. Migrate away from dtd_name.
784 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
786 (ctf_dtd_lookup_type_by_name): Remove.
787 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
788 No longer check ctf_dtnextid: check ctf_typemax instead.
789 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
790 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
791 ctf_name_table and the right name table, and migrate away from
792 dtd_name as in ctf_dtd_delete.
793 (ctf_add_generic): Pass in the kind explicitly and pass it to
794 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
795 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
796 Grow the ptrtab if needed.
797 (ctf_add_encoded): Pass in the kind.
798 (ctf_add_slice): Likewise.
799 (ctf_add_array): Likewise.
800 (ctf_add_function): Likewise.
801 (ctf_add_typedef): Likewise.
802 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
803 ctt_name rather than dtd_name.
804 (ctf_add_struct_sized): Pass in the kind. Use
805 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
806 ctf_dtd_lookup_type_by_name.
807 (ctf_add_union_sized): Likewise.
808 (ctf_add_enum): Likewise.
809 (ctf_add_enum_encoded): Likewise.
810 (ctf_add_forward): Likewise.
811 (ctf_add_type): Likewise.
812 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
813 being initialized until after the call.
814 (ctf_write_mem): Likewise.
815 (ctf_write): Likewise.
816 * ctf-archive.c (arc_write_one_ctf): Likewise.
817 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
818 ctf_hash_lookup_type.
819 (ctf_lookup_by_id): No longer check the readonly types if the
820 dictionary is writable.
821 * ctf-open.c (init_types): Assert that this dictionary is not
822 writable. Adjust to use the new name hashes, ctf_name_table,
823 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
824 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
825 if set. Drop out early when dictionary is writable. Split the
826 ctf_lookups initialization into...
827 (ctf_set_cth_hashes): ... this new function.
828 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
829 (ctf_simple_open): Adjust accordingly.
830 (ctf_bufopen): Likewise.
831 (ctf_file_close): Destroy the appropriate name hashes. No longer
832 destroy ctf_dtbyname, which is gone.
833 (ctf_getdatasect): Remove spurious "extern".
834 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
835 specified name table, given a kind.
836 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
837 (ctf_member_iter): Add support for iterating over the
839 (ctf_enum_iter): Likewise.
840 (ctf_variable_iter): Likewise.
841 (ctf_type_rvisit): Likewise.
842 (ctf_member_info): Add support for types in the dynamic type list.
843 (ctf_enum_name): Likewise.
844 (ctf_enum_value): Likewise.
845 (ctf_func_type_info): Likewise.
846 (ctf_func_type_args): Likewise.
847 * ctf-link.c (ctf_accumulate_archive_names): No longer call
849 (ctf_link_write): Likewise.
850 (ctf_link_intern_extern_string): Adjust for new
851 ctf_str_add_external return value.
852 (ctf_link_add_strtab): Likewise.
853 * ctf-util.c (ctf_list_empty_p): New.
855 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
857 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
859 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
861 (ctf_add_variable): Likewise for variables pointing to them.
862 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
863 type link failure, but do warn for others.
864 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
866 (ctf_dump_member): Likewise.
867 (ctf_dump_type): Likewise.
868 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
869 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
870 (ctf_dump_header): Likewise.
871 (ctf_dump_label): likewise.
872 (ctf_dump_objts): likewise.
873 (ctf_dump_funcs): likewise.
874 (ctf_dump_var): likewise.
875 (ctf_dump_str): Likewise.
877 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
879 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
881 (AM_INSTALL_LIBBFD): Likewise.
882 (dlopen): Note why this is necessary in a comment.
883 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
885 (SHARED_LDFLAGS): Likewise.
886 (BFD_LIBADD): Likewise, for libbfd.
887 (BFD_DEPENDENCIES): Likewise.
888 (VERSION_FLAGS): Initialize, using a version script if ld supports
889 one, or libtool -export-symbols-regex otherwise.
890 (AC_CONFIG_MACRO_DIR): Add ../BFD.
891 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
893 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
894 (noinst_LIBRARIES): Replace with...
895 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
896 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
897 libctf-nobfd.la as well.
898 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
899 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
900 (libctf_a_SOURCES): Rename to...
901 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
903 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
904 with ctf-open-bfd.c added.
905 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
906 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
907 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
908 * Makefile.am [INSTALL_LIBCTF]: Use it.
909 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
911 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
912 the unstable components).
913 * Makefile.in: Regenerated.
914 * config.h.in: Likewise.
915 * configure: Likewise.
917 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
919 * configure.ac (INSTALL_LIBCTF): New, controlled by
920 --enable-install-libctf.
921 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
922 * Makefile.in: Regenerated.
923 * configure: Regenerated.
925 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
927 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
928 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
930 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
932 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
934 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
936 * ctf-impl.h (includes): Include <sys/param.h> here.
938 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
940 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
941 (flip_objts): Likewise.
942 (flip_vars): Likewise.
943 (flip_types): Likewise.
945 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
947 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
948 freeing functions: if set, free the key and value if the slot
949 already exists. Always reassign the key.
950 (ctf_dynhash_insert): Adjust call appropriately.
951 (ctf_hash_insert_type): Likewise.
953 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
955 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
956 type kind. Allow forwards to unify with pre-existing structs/
959 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
961 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
962 <ctf_link_memb_name_changer>: Likewise.
963 <ctf_link_memb_name_changer_arg>: Likewise.
964 * ctf-create.c (ctf_update): Update accordingly.
965 * ctf-open.c (ctf_file_close): Likewise.
966 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
967 (ctf_link_add_cu_mapping): New.
968 (ctf_link_set_memb_name_changer): Likewise.
969 (ctf_change_parent_name): New.
970 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
971 allocated by the caller's ctf_link_memb_name_changer.
972 <ndynames>: Likewise.
973 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
974 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
975 ctf_change_parent_name. Free any resulting names.
977 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
979 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
980 (ctf_link_one_type): ... here, with parent-name setting added.
981 (check_variable): New.
982 (ctf_link_one_variable): Likewise.
983 (ctf_link_one_input_archive_member): Call it.
984 * ctf-error.c (_ctf_errlist): Updated with new errors.
986 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
988 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
989 (struct ctf_link_type_mapping_key): New.
990 (ctf_hash_type_mapping_key): Likewise.
991 (ctf_hash_eq_type_mapping_key): Likewise.
992 (ctf_add_type_mapping): Likewise.
993 (ctf_type_mapping): Likewise.
994 (ctf_dynhash_empty): Likewise.
995 * ctf-open.c (ctf_file_close): Update accordingly.
996 * ctf-create.c (ctf_update): Likewise.
997 (ctf_add_type): Populate the mapping.
998 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
999 (ctf_hash_eq_type_mapping_key): Check the key for equality.
1000 (ctf_dynhash_insert): Fix comment typo.
1001 (ctf_dynhash_empty): New.
1002 * ctf-link.c (ctf_add_type_mapping): New.
1003 (ctf_type_mapping): Likewise.
1004 (empty_link_type_mapping): New.
1005 (ctf_link_one_input_archive): Call it.
1007 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1009 * ctf-link.c: New file, linking of the string and type sections.
1010 * Makefile.am (libctf_a_SOURCES): Add it.
1011 * Makefile.in: Regenerate.
1013 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1015 * ctf-create.c (ctf_update): Update accordingly.
1016 * ctf-open.c (ctf_file_close): Likewise.
1017 * ctf-error.c (_ctf_errlist): Updated with new errors.
1019 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1021 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1023 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1025 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1027 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1028 (ctf_dump_format_type): Add non-root-type { } notation.
1029 Add root flag to prototype.
1030 (ctf_dump_label): Adjust accordingly.
1031 (ctf_dump_objts): Likewise.
1032 (ctf_dump_var): Likewise.
1034 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1036 * ctf-create.c (ctf_compress_write): Fix double-free.
1038 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1040 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1042 (ctf_arc_write_fd): ... this new function.
1043 * ctf-create.c (ctf_write_mem): New.
1045 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1047 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1048 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1049 (ctf_str_add_ref): Name the last arg.
1050 (ctf_str_add_external) New.
1051 (ctf_str_add_strraw_explicit): Likewise.
1052 (ctf_simple_open_internal): Likewise.
1053 (ctf_bufopen_internal): Likewise.
1055 * ctf-string.c (ctf_strraw_explicit): Split from...
1056 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1057 (ctf_str_add_ref_internal): Return the atom, not the
1059 (ctf_str_add): Adjust accordingly.
1060 (ctf_str_add_ref): Likewise. Move up in the file.
1061 (ctf_str_add_external): New: update the csa_offset.
1062 (ctf_str_count_strtab): Only account for strings with no csa_offset
1063 in the internal strtab length.
1064 (ctf_str_write_strtab): If the csa_offset is set, update the
1065 string's refs without writing the string out, and update the
1066 ctf_syn_ext_strtab. Make OOM handling less ugly.
1067 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1068 (ctf_update): Handle failure to populate the strtab. Pass in the
1069 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1070 Call ctf_simple_open_internal, not ctf_simple_open.
1071 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1073 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1074 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1075 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1076 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1077 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1078 (ctf_simple_open_internal): ... this new function, which calls
1079 ctf_bufopen_internal.
1080 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1081 (ctf_bufopen_internal): ... this new function, which sets
1084 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1086 * ctf_types.c (ctf_type_iter_all): New.
1088 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1090 * ctf-open.c (init_symtab): Check for overflow against the right
1092 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1093 (upgrade_types_v1): Note that these sections are not checked.
1094 (flip_header): Endian-swap the header fields.
1095 (flip_ctf): Endian-swap the sections.
1096 (flip_objts): Update comment.
1097 (ctf_bufopen): Check header offsets and alignment for validity.
1099 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1101 * ctf-open-bfd.c: Add <assert.h>.
1102 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1103 techniques borrowed from bfd_elf_sym_name.
1104 (ctf_new_archive_internal): Improve comment.
1105 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1106 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1107 no symbol section, but not vice versa.
1109 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1111 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1112 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1113 * ctf-dump.c (dump_header): New function, dump the CTF header.
1114 (ctf_dump): Call it.
1115 (ctf_dump_header_strfield): New function.
1116 (ctf_dump_header_sectfield): Likewise.
1118 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1120 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1121 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1122 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1123 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1124 Print out ctf_cuname: only print out ctf_parname if set.
1125 (ctf_free_base): Removed, ctf_base is no longer freed: free
1126 ctf_dynbase instead.
1127 (ctf_set_version): Fix spacing.
1128 (upgrade_header): New, in-place header upgrading.
1129 (upgrade_types): Rename to...
1130 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1131 longer track old and new headers separately. No longer allow for
1132 header sizes explicitly: squeeze the headers out on upgrade (they
1133 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1134 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1135 (upgrade_types): New, also handle ctf_parmax updating.
1136 (flip_header): Flip ctf_cuname.
1137 (flip_types): Flip BUF explicitly rather than deriving BUF from
1139 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1140 required alignment of objtoff and funcoff. No longer store it in
1141 the ctf_buf unless that buf is derived unmodified from the input.
1142 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1143 that duplicate fields in ctf_file: move allocation of ctf_file
1144 further up instead. Call upgrade_header as needed. Move
1145 version-specific ctf_parmax initialization into upgrade_types. More
1146 concise error handling.
1147 (ctf_file_close): No longer test for null pointers before freeing.
1148 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1151 (ctf_cuname_set): New.
1152 * ctf-create.c (ctf_update): Populate ctf_cuname.
1153 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1155 (ctf_write): Likewise.
1156 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1157 Fix the compression length: fp->ctf_size never counted the CTF
1158 header. Simplify the compress call accordingly.
1160 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1162 * ctf-endian.h: Don't assume htole64 and le64toh are always
1163 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1164 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1165 not bswap_identity_64.
1167 2019-09-18 Alan Modra <amodra@gmail.com>
1169 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1171 2019-09-09 Phil Blundell <pb@pbcl.net>
1173 binutils 2.33 branch created.
1175 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1177 * ctf-types.c (ctf_type_aname_raw): New.
1178 (ctf_func_type_info): Likewise.
1179 (ctf_func_type_args): Likewise.
1180 * ctf-error.c (_ctf_errlist): Fix description.
1181 * ctf-lookup.c: Fix file description.
1183 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1185 * ctf-create.c (ctf_create): Fix off-by-one error.
1187 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1189 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1191 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1192 (struct ctf_str_atom): New, disambiguated single string.
1193 (struct ctf_str_atom_ref): New, points to some other location that
1194 references this string's offset.
1195 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1196 Remove member ctf_dtvstrlen: we no longer track the total strlen
1198 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1199 (ctf_str_free_atoms): Likewise.
1200 (ctf_str_add): Likewise.
1201 (ctf_str_add_ref): Likewise.
1202 (ctf_str_rollback): Likewise.
1203 (ctf_str_purge_refs): Likewise.
1204 (ctf_str_write_strtab): Likewise.
1205 (ctf_realloc): Declare new function in ctf-util.c.
1207 * ctf-open.c (ctf_bufopen): Create the atoms table.
1208 (ctf_file_close): Destroy it.
1209 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1210 special-case the position of the parname string. Construct the
1211 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1212 rest of each buffer element is constructed, not via open-coding:
1213 realloc the CTF buffer and append the strtab to it. No longer
1214 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1215 strtab construction.
1216 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1217 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1218 after buffer element construction instead.
1219 (ctf_copy_lmembers): Likewise.
1220 (ctf_copy_emembers): Likewise.
1221 (ctf_create): No longer maintain the ctf_dtvstrlen.
1222 (ctf_dtd_delete): Likewise.
1223 (ctf_dvd_delete): Likewise.
1224 (ctf_add_generic): Likewise.
1225 (ctf_add_enumerator): Likewise.
1226 (ctf_add_member_offset): Likewise.
1227 (ctf_add_variable): Likewise.
1228 (membadd): Likewise.
1229 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1230 if there are active ctf_str_num_refs.
1231 (ctf_strraw): Move to ctf-string.c.
1232 (ctf_strptr): Likewise.
1233 * ctf-string.c: New file, strtab manipulation.
1235 * Makefile.am (libctf_a_SOURCES): Add it.
1236 * Makefile.in: Regenerate.
1238 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1240 * ctf-impl.h (ctf_hash_iter_f): New.
1241 (ctf_dynhash_iter): New declaration.
1242 (ctf_dynhash_iter_remove): New declaration.
1243 * ctf-hash.c (ctf_dynhash_iter): Define.
1244 (ctf_dynhash_iter_remove): Likewise.
1245 (ctf_hashtab_traverse): New.
1246 (ctf_hashtab_traverse_remove): Likewise.
1247 (struct ctf_traverse_cb_arg): Likewise.
1248 (struct ctf_traverse_remove_cb_arg): Likewise.
1250 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1252 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1254 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1256 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1257 (ctf_dump_funcs): Likewise.
1259 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1261 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1262 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1263 little-endian CTF archive magic. Do not check the CTF version:
1264 ctf_simple_open does that in endian-safe ways. Do not dereference
1265 null pointers on open failure.
1267 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1269 * ctf-open.c (get_vbytes_common): Return the new slice size.
1270 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1271 Remember to copy in the CTF data when opening an uncompressed
1272 foreign-endian CTF file. Prune useless variable manipulation.
1274 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1276 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1279 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1281 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1284 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1286 * ctf-subr.c (_PAGESIZE): Remove.
1287 (ctf_data_alloc): Likewise.
1288 (ctf_data_free): Likewise.
1289 (ctf_data_protect): Likewise.
1290 * ctf-impl.h: Remove declarations.
1291 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1292 ctf_free, not ctf_data_free.
1293 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1294 the buffer again on compression error.
1295 * ctf-open.c (ctf_set_base): No longer track the size: call
1296 ctf_free, not ctf_data_free.
1297 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1298 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1300 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1302 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1304 (ctf_dvd_insert): Likewise.
1305 (ctf_add_generic): Likewise.
1306 (ctf_add_variable): Likewise.
1307 * ctf-impl.h: Adjust declarations.
1309 2019-06-14 Alan Modra <amodra@gmail.com>
1311 * configure: Regenerate.
1313 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1315 * ctf-decls.h: Include <libiberty.h>.
1316 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1318 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1320 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1321 (ctf_dump_objts): Likewise.
1322 (ctf_dump_funcs): Likewise.
1323 (ctf_dump_member): Likewise.
1324 (ctf_dump_str): Likewise.
1326 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1328 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1329 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1331 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1333 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1334 (ctf_arc_open_by_offset): Likewise.
1335 * ctf-create.c (ctf_add_type): Likewise.
1337 2019-06-04 Tom Tromey <tromey@adacore.com>
1339 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1340 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1342 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1344 * configure.ac: Check for O_CLOEXEC.
1345 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1346 * config.h.in: Regenerate.
1347 * configure: Likewise.
1349 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1351 * qsort_r.c: Rename to...
1352 * ctf-qsort_r.c: ... this.
1353 (_quicksort): Define to ctf_qsort_r.
1354 * ctf-decls.h (qsort_r): Remove.
1356 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1357 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1358 * Makefile.am (libctf_a_LIBADD): Remove.
1359 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1360 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1361 * ctf-create.c (ctf_update): Likewise.
1362 * configure.ac: Check for BSD versus GNU qsort_r signature.
1363 * Makefile.in: Regenerate.
1364 * config.h.in: Likewise.
1365 * configure: Likewise.
1367 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1369 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1371 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1373 * Makefile.am (ZLIB): New.
1374 (ZLIBINC): Likewise.
1375 (AM_CFLAGS): Use them.
1376 (libctf_a_LIBADD): New, for LIBOBJS.
1377 * configure.ac: Check for zlib, endian.h, and qsort_r.
1378 * ctf-endian.h: New, providing htole64 and le64toh.
1379 * swap.h: Code style fixes.
1380 (bswap_identity_64): New.
1381 * qsort_r.c: New, from gnulib (with one added #include).
1382 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1383 and unconditional definitions of MIN and MAX.
1384 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1385 (ctf_set_errno): Now returns unsigned long.
1386 * ctf-util.c (ctf_set_errno): Adjust here too.
1387 * ctf-archive.c: Use ctf-endian.h.
1388 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1389 cts_flags and cts_offset.
1390 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1391 * ctf-create.c: Provide a definition of roundup if not defined.
1392 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1393 (ctf_add_reftype): Do not check if type IDs are below zero.
1394 (ctf_add_slice): Likewise.
1395 (ctf_add_typedef): Likewise.
1396 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1397 when known error-free. Drop CTF_ERR usage for functions returning
1399 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1401 (ctf_add_variable): Likewise.
1402 (enumcmp): Likewise.
1403 (enumadd): Likewise.
1404 (membcmp): Likewise.
1405 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1406 when known error-free.
1407 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1408 returning int: use CTF_ERR for functions returning ctf_type_id.
1409 (ctf_dump_label): Likewise.
1410 (ctf_dump_objts): Likewise.
1411 * ctf-labels.c (ctf_label_topmost): Likewise.
1412 (ctf_label_iter): Likewise.
1413 (ctf_label_info): Likewise.
1414 * ctf-lookup.c (ctf_func_args): Likewise.
1415 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1416 (ctf_bufopen): Likewise. Use zlib types as needed.
1417 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1419 (ctf_enum_iter): Likewise.
1420 (ctf_type_size): Likewise.
1421 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1422 (ctf_type_kind_unsliced): Likewise.
1423 (ctf_type_kind): Likewise.
1424 (ctf_type_encoding): Likewise.
1425 (ctf_member_info): Likewise.
1426 (ctf_array_info): Likewise.
1427 (ctf_enum_value): Likewise.
1428 (ctf_type_rvisit): Likewise.
1429 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1431 (ctf_simple_open): Likewise.
1432 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1433 * Makefile.in: Regenerate.
1434 * aclocal.m4: Likewise.
1435 * config.h: Likewise.
1436 * configure: Likewise.
1438 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1440 * configure.in: Check for bfd_section_from_elf_index.
1441 * configure: Regenerate.
1442 * config.h.in [HAVE_BFD_ELF]: Likewise.
1443 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1444 abfd is potentially unused now.
1446 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1449 * Makefile.in: Regenerated.
1450 * config.h.in: Likewise.
1451 * aclocal.m4: Likewise.
1452 * configure: Likewise.
1454 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1458 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1460 * ctf-labels.c: New.
1462 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1464 * ctf-impl.h (_libctf_version): New declaration.
1465 * ctf-subr.c (_libctf_version): Define it.
1468 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1470 * ctf-create.c (enumcmp): New.
1471 (enumadd): Likewise.
1472 (membcmp): Likewise.
1473 (membadd): Likewise.
1474 (ctf_add_type): Likewise.
1476 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1478 * ctf-lookup.c (isqualifier): New.
1479 (ctf_lookup_by_name): Likewise.
1480 (struct ctf_lookup_var_key): Likewise.
1481 (ctf_lookup_var): Likewise.
1482 (ctf_lookup_variable): Likewise.
1483 (ctf_lookup_symbol_name): Likewise.
1484 (ctf_lookup_by_symbol): Likewise.
1485 (ctf_func_info): Likewise.
1486 (ctf_func_args): Likewise.
1488 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1490 * ctf-decl.c: New file.
1491 * ctf-types.c: Likewise.
1492 * ctf-impl.h: New declarations.
1494 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1496 * ctf-open-bfd.c: New file.
1497 * ctf-open.c (ctf_close): New.
1498 * ctf-impl.h: Include bfd.h.
1499 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1500 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1502 (ctf_bfdopen_ctfsect): New declaration.
1503 (_CTF_SECTION): likewise.
1505 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1507 * ctf-archive.c: New.
1508 * ctf-impl.h (ctf_archive_internal): New type.
1509 (ctf_arc_open_internal): New declaration.
1510 (ctf_arc_bufopen): Likewise.
1511 (ctf_arc_close_internal): Likewise.
1513 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1515 * ctf-open.c: New file.
1518 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1520 * ctf-create.c: New file.
1521 * ctf-lookup.c: New file.
1523 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1525 * ctf-impl.h: New definitions and declarations for type creation
1528 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1530 * ctf-hash.c: New file.
1531 * ctf-impl.h: New declarations.
1533 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1535 * ctf-error.c: New file.
1537 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1539 * ctf-util.c: New file.
1541 * ctf-impl.h: Include it, and add declarations.
1543 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1545 * ctf-impl.h: New file.
1546 * ctf-subr.c: New file.
1553 version-control: never