1 2020-11-23 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-impl.h (ctf_dict_t) <ctf_symtab_little_endian>: New.
4 (struct ctf_archive_internal) <ctfi_symsect_little_endian>: Likewise.
5 * ctf-create.c (ctf_serialize): Adjust for new field.
6 * ctf-open.c (init_symtab): Note the semantics of repeated calls.
7 (ctf_symsect_endianness): New.
8 (ctf_bufopen_internal): Set ctf_symtab_little_endian suitably for
10 (_Static_assert): Moved...
11 (swap_thing): ... with this...
12 * swap.h: ... to here.
13 * ctf-util.c (ctf_elf32_to_link_sym): Use it, byteswapping the
14 Elf32_Sym if the ctf_symtab_little_endian demands it.
15 (ctf_elf64_to_link_sym): Likewise swap the Elf64_Sym if needed.
16 * ctf-archive.c (ctf_arc_symsect_endianness): New, set the
17 endianness of the symtab used by the dicts in an archive.
18 (ctf_archive_iter_internal): Initialize to unknown (assumed native,
19 do not call ctf_symsect_endianness).
20 (ctf_dict_open_by_offset): Call ctf_symsect_endianness if need be.
21 (ctf_dict_open_internal): Propagate the endianness down.
22 (ctf_dict_open_sections): Likewise.
23 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Get the endianness from the
24 struct bfd and pass it down to the archive.
25 * libctf.ver: Add ctf_symsect_endianness and
26 ctf_arc_symsect_endianness.
28 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
30 * ctf-link.c (ctf_link_deduplicating): Clean up the ctf_link_outputs
33 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
35 * ctf-create.c (ctf_dtd_insert): Set ENOMEM on the dict if out of memory.
36 (ctf_dvd_insert): Likewise.
37 (ctf_add_function): Report ECTF_RDONLY if this dict is not writable.
38 * ctf-subr.c (ctf_err_warn): Only debug-dump passed-in warnings if
39 the passed-in error code is nonzero: the error on the dict for
40 warnings may relate to a previous error.
42 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
44 * ctf-open.c (ctf_getsymsect): New.
45 (ctf_getstrsect): Likewise.
46 * libctf.ver: Add them.
48 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
50 * ctf-impl.h (struct ctf_archive_internal) <ctfi_dicts>: New, dicts
51 the archive machinery has opened and cached.
52 <ctfi_symdicts>: New, cache of dicts containing symbols looked up.
53 <ctfi_syms>: New, cache of types of symbols looked up.
54 * ctf-archive.c (ctf_arc_close): Free them on close.
55 (enosym): New, flag entry for 'symbol not present'.
56 (ctf_arc_import_parent): New, automatically import the parent from
57 ".ctf" if this is a child in an archive and ".ctf" is present.
58 (ctf_dict_open_sections): Use it.
59 (ctf_archive_iter_internal): Likewise.
60 (ctf_cached_dict_close): New, thunk around ctf_dict_close.
61 (ctf_dict_open_cached): New, open and cache a dict.
62 (ctf_arc_flush_caches): New, flush the caches.
63 (ctf_arc_lookup_symbol): New, look up a symbol in (all members of)
64 an archive, and cache the lookup.
65 (ctf_archive_iter): Note the new caching behaviour.
66 (ctf_archive_next): Use ctf_dict_open_cached.
67 * libctf.ver: Add ctf_arc_lookup_symbol and ctf_arc_flush_caches.
69 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
71 * ctf-dedup.c (ctf_dedup_rhash_type): Null out the names of nameless
72 type kinds, just in case the input has named them.
74 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
76 * ctf-dump.c (ctf_dump_header): Dump the new flags bits and the index
78 (ctf_dump_objts): Report indexed sections. Also dump functions. Use
79 ctf_symbol_next, not manual looping.
80 (ctf_dump_funcs): Delete.
81 (ctf_dump): Use ctf_dump_objts, not ctf_dump_funcs.
83 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
85 * ctf-impl.h (CTF_INDEX_PAD_THRESHOLD): New.
86 (_libctf_nonnull_): Likewise.
87 (ctf_in_flight_dynsym_t): New.
88 (ctf_dict_t) <ctf_funcidx_names>: Likewise.
89 <ctf_objtidx_names>: Likewise.
90 <ctf_nfuncidx>: Likewise.
91 <ctf_nobjtidx>: Likewise.
92 <ctf_funcidx_sxlate>: Likewise.
93 <ctf_objtidx_sxlate>: Likewise.
94 <ctf_objthash>: Likewise.
95 <ctf_funchash>: Likewise.
96 <ctf_dynsyms>: Likewise.
97 <ctf_dynsymidx>: Likewise.
98 <ctf_dynsymmax>: Likewise.
99 <ctf_in_flight_dynsym>: Likewise.
100 (struct ctf_next) <u.ctn_next>: Likewise.
101 (ctf_symtab_skippable): New prototype.
102 (ctf_add_funcobjt_sym): Likewise.
103 (ctf_dynhash_sort_by_name): Likewise.
104 (ctf_sym_to_elf64): Rename to...
105 (ctf_elf32_to_link_sym): ... this, and...
106 (ctf_elf64_to_link_sym): ... this.
107 * ctf-open.c (init_symtab): Check for lack of CTF_F_NEWFUNCINFO
108 flag, and presence of index sections. Refactor out
109 ctf_symtab_skippable and ctf_elf*_to_link_sym, and use them. Use
110 ctf_link_sym_t, not Elf64_Sym. Skip initializing objt or func
111 sxlate sections if corresponding index section is present. Adjust
112 for new func info section format.
113 (ctf_bufopen_internal): Add ctf_err_warn to corrupt-file error
114 handling. Report incorrect-length index sections. Always do an
115 init_symtab, even if there is no symtab section (there may be index
117 (flip_objts): Adjust comment: func and objt sections are actually
118 identical in structure now, no need to caveat.
119 (ctf_dict_close): Free newly-added data structures.
120 * ctf-create.c (ctf_create): Initialize them.
121 (ctf_symtab_skippable): New, refactored out of
122 init_symtab, with st_nameidx_set check added.
123 (ctf_add_funcobjt_sym): New, add a function or object symbol to the
124 ctf_objthash or ctf_funchash, by name.
125 (ctf_add_objt_sym): Call it.
126 (ctf_add_func_sym): Likewise.
127 (symtypetab_delete_nonstatic_vars): New, delete vars also present as
129 (CTF_SYMTYPETAB_EMIT_FUNCTION): New flag to symtypetab emitters:
130 this is a function emission, not a data object emission.
131 (CTF_SYMTYPETAB_EMIT_PAD): New flag to symtypetab emitters: emit
132 pads for symbols with no type (only set for unindexed sections).
133 (CTF_SYMTYPETAB_FORCE_INDEXED): New flag to symtypetab emitters:
135 (symtypetab_density): New, figure out section sizes.
136 (emit_symtypetab): New, emit a symtypetab.
137 (emit_symtypetab_index): New, emit a symtypetab index.
138 (ctf_serialize): Call them, emitting suitably sorted symtypetab
139 sections and indexes. Set suitable header flags. Copy over new
141 * ctf-hash.c (ctf_dynhash_sort_by_name): New, used to impose an
142 order on symtypetab index sections.
143 * ctf-link.c (ctf_add_type_mapping): Delete erroneous comment
144 relating to code that was never committed.
145 (ctf_link_one_variable): Improve variable name.
146 (check_sym): New, symtypetab analogue of check_variable.
147 (ctf_link_deduplicating_one_symtypetab): New.
148 (ctf_link_deduplicating_syms): Likewise.
149 (ctf_link_deduplicating): Call them.
150 (ctf_link_deduplicating_per_cu): Note that we don't call them in
152 (ctf_link_add_strtab): Set the error on the fp correctly.
153 (ctf_link_add_linker_symbol): New (no longer a do-nothing stub), add
154 a linker symbol to the in-flight list.
155 (ctf_link_shuffle_syms): New (no longer a do-nothing stub), turn the
156 in-flight list into a mapping we can use, now its names are
157 resolvable in the external strtab.
158 * ctf-string.c (ctf_str_rollback_atom): Don't roll back atoms with
159 external strtab offsets.
160 (ctf_str_rollback): Adjust comment.
161 (ctf_str_write_strtab): Migrate ctf_syn_ext_strtab population from
163 (ctf_str_add_external): ... to string addition time.
164 * ctf-lookup.c (ctf_lookup_var_key_t): Rename to...
165 (ctf_lookup_idx_key_t): ... this, now we use it for syms too.
166 <clik_names>: New member, a name table.
167 (ctf_lookup_var): Adjust accordingly.
168 (ctf_lookup_variable): Likewise.
169 (ctf_lookup_by_id): Shuffle further up in the file.
170 (ctf_symidx_sort_arg_cb): New, callback for...
171 (sort_symidx_by_name): ... this new function to sort a symidx
172 found to be unsorted (likely originating from the compiler).
173 (ctf_symidx_sort): New, sort a symidx.
174 (ctf_lookup_symbol_name): Support dynamic symbols with indexes
175 provided by the linker. Use ctf_link_sym_t, not Elf64_Sym.
176 Check the parent if a child lookup fails.
177 (ctf_lookup_by_symbol): Likewise. Work for function symbols too.
178 (ctf_symbol_next): New, iterate over symbols with types (without
180 (ctf_lookup_idx_name): New, bsearch for symbol names in indexes.
181 (ctf_try_lookup_indexed): New, attempt an indexed lookup.
182 (ctf_func_info): Reimplement in terms of ctf_lookup_by_symbol.
183 (ctf_func_args): Likewise.
184 (ctf_get_dict): Move...
185 * ctf-types.c (ctf_get_dict): ... here.
186 * ctf-util.c (ctf_sym_to_elf64): Re-express as...
187 (ctf_elf64_to_link_sym): ... this. Add new st_symidx field, and
188 st_nameidx_set (always 0, so st_nameidx can be ignored). Look in
189 the ELF strtab for names.
190 (ctf_elf32_to_link_sym): Likewise, for Elf32_Sym.
191 (ctf_next_destroy): Destroy ctf_next_t.u.ctn_next if need be.
192 * libctf.ver: Add ctf_symbol_next, ctf_add_objt_sym and
195 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
197 * ctf-link.c (ctf_link_shuffle_syms): Adjust.
198 (ctf_link_add_linker_symbol): New, unimplemented stub.
199 * libctf.ver: Add it.
200 * ctf-create.c (ctf_serialize): Set CTF_F_DYNSTR on newly-serialized
202 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Check for the flag: open the
203 symtab/strtab if not present, dynsym/dynstr otherwise.
204 * ctf-archive.c (ctf_arc_bufpreamble): New, get the preamble from
205 some arbitrary member of a CTF archive.
206 * ctf-impl.h (ctf_arc_bufpreamble): Declare it.
208 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
210 * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
211 (ctf_dict_open_by_offset): ... this. Adjust callers.
212 (ctf_arc_open_by_name_internal): Rename to...
213 (ctf_dict_open_internal): ... this. Adjust callers.
214 (ctf_arc_open_by_name_sections): Rename to...
215 (ctf_dict_open_sections): ... this, keeping compatibility function.
216 (ctf_arc_open_by_name): Rename to...
217 (ctf_dict_open): ... this, keeping compatibility function.
218 * libctf.ver: New functions added.
219 * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
220 (ctf_link_deduplicating_open_inputs): Likewise.
222 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
224 * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
226 (ctf_fileops): Rename to...
227 (ctf_dictops): ... this.
228 (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
229 <cd_id_to_dict_t>: ... this.
230 (ctf_file_t): Fix outdated comment.
231 <ctf_fileops>: Rename to...
232 <ctf_dictops>: ... this.
233 (struct ctf_archive_internal) <ctfi_file>: Rename to...
234 <ctfi_dict>: ... this.
235 * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
236 Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
237 Rename ctf_file_close to ctf_dict_close. All users adjusted.
238 * ctf-create.c: Likewise. Refer to CTF dicts, not CTF containers.
239 (ctf_bundle_t) <ctb_file>: Rename to...
240 <ctb_dict): ... this.
241 * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
242 * ctf-dedup.c: Likewise. Rename ctf_file_close to
243 ctf_dict_close. Refer to CTF dicts, not CTF containers.
244 * ctf-dump.c: Likewise.
245 * ctf-error.c: Likewise.
246 * ctf-hash.c: Likewise.
247 * ctf-inlines.h: Likewise.
248 * ctf-labels.c: Likewise.
249 * ctf-link.c: Likewise.
250 * ctf-lookup.c: Likewise.
251 * ctf-open-bfd.c: Likewise.
252 * ctf-string.c: Likewise.
253 * ctf-subr.c: Likewise.
254 * ctf-types.c: Likewise.
255 * ctf-util.c: Likewise.
256 * ctf-open.c: Likewise.
257 (ctf_file_close): Rename to...
258 (ctf_dict_close): ...this.
259 (ctf_file_close): New trivial wrapper around ctf_dict_close, for
261 (ctf_parent_file): Rename to...
262 (ctf_parent_dict): ... this.
263 (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
265 * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
267 2020-10-21 Tom Tromey <tromey@adacore.com>
269 * mkerrors.sed: Remove.
270 * ctf-error.c (_CTF_FIRST): New define.
271 (_CTF_ITEM): Define this, not _CTF_STR.
272 (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
273 (ERRSTRFIELD): Rewrite.
274 (ERRSTRFIELD1): Remove.
275 * Makefile.in: Rebuild.
276 * Makefile.am (BUILT_SOURCES): Remove.
277 (ctf-error.h): Remove.
279 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
281 * ctf-subr.c (open_errors): New list.
282 (ctf_err_warn): Calls with NULL fp append to open_errors. Add err
283 parameter, and use it to decorate the debug stream with errmsgs.
284 (ctf_err_warn_to_open): Splice errors from a CTF dict into the
286 (ctf_errwarning_next): Calls with NULL fp report from open_errors.
287 New err param to report iteration errors (including end-of-iteration)
289 (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
290 parameter: gettextize.
291 * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
292 (LCTF_VBYTES): Adjust.
293 (ctf_err_warn_to_open): New.
294 (ctf_err_warn): Adjust.
295 (ctf_bundle): Used in only one place: move...
296 * ctf-create.c: ... here.
297 (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
298 down as needed. Don't emit the errmsg. Gettextize.
300 (ctf_add_type_internal): Likewise.
301 (ctf_write_mem): Likewise.
302 (ctf_compress_write): Likewise. Report errors writing the header or
304 (ctf_write): Likewise.
305 * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
306 ctf_dprintf, and gettextize, as above.
307 (ctf_arc_write): Likewise.
308 (ctf_arc_bufopen): Likewise.
309 (ctf_arc_open_internal): Likewise.
310 * ctf-labels.c (ctf_label_iter): Likewise.
311 * ctf-open-bfd.c (ctf_bfdclose): Likewise.
312 (ctf_bfdopen): Likewise.
313 (ctf_bfdopen_ctfsect): Likewise.
314 (ctf_fdopen): Likewise.
315 * ctf-string.c (ctf_str_write_strtab): Likewise.
316 * ctf-types.c (ctf_type_resolve): Likewise.
317 * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
318 (get_vbytes_v1): Pass down the ctf dict.
319 (get_vbytes_v2): Likewise.
320 (flip_ctf): Likewise.
321 (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
322 gettextize, as above.
323 (upgrade_types_v1): Adjust calls.
324 (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
325 (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
326 emitted into individual dicts into the open errors if this turns
327 out to be a failed open in the end.
328 * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
329 argument. Gettextize. Don't emit the errmsg.
330 (ctf_dump_funcs): Likewise. Collapse err label into its only case.
331 (ctf_dump_type): Likewise.
332 * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
333 argument. Gettextize. Don't emit the errmsg.
334 (ctf_link_one_type): Likewise.
335 (ctf_link_lazy_open): Likewise.
336 (ctf_link_one_input_archive): Likewise.
337 (ctf_link_deduplicating_count_inputs): Likewise.
338 (ctf_link_deduplicating_open_inputs): Likewise.
339 (ctf_link_deduplicating_close_inputs): Likewise.
340 (ctf_link_deduplicating): Likewise.
341 (ctf_link): Likewise.
342 (ctf_link_deduplicating_per_cu): Likewise. Add some missed
343 ctf_set_errnos to obscure error cases.
344 * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
345 err argument. Gettextize. Don't emit the errmsg.
346 (ctf_dedup_populate_mappings): Likewise.
347 (ctf_dedup_detect_name_ambiguity): Likewise.
348 (ctf_dedup_init): Likewise.
349 (ctf_dedup_multiple_input_dicts): Likewise.
350 (ctf_dedup_conflictify_unshared): Likewise.
351 (ctf_dedup): Likewise.
352 (ctf_dedup_rwalk_one_output_mapping): Likewise.
353 (ctf_dedup_id_to_target): Likewise.
354 (ctf_dedup_emit_type): Likewise.
355 (ctf_dedup_emit_struct_members): Likewise.
356 (ctf_dedup_populate_type_mapping): Likewise.
357 (ctf_dedup_populate_type_mappings): Likewise.
358 (ctf_dedup_emit): Likewise.
359 (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
361 (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
362 unknown-type-kind messages (which signify file corruption).
364 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
366 * configure.ac: Adjust package name to simply 'libctf': arbitrarily
367 declare this to be version 1.2.0.
368 * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
369 * Makefile.in: Regenerated.
370 * configure: Regenerated.
371 * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
372 * ctf-impl.h: Include it.
373 * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
374 (ctf_errmsg): Actually translate them.
376 2020-07-26 Eli Zaretskii <eliz@gnu.org>
379 * ctf-create.c (EOVERFLOW): If not defined by system header,
380 redirect to ERANGE as a poor man's substitute.
381 * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
383 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
385 * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
386 (ctf_dtd_delete): Likewise.
387 (ctf_dtd_lookup): Likewise.
388 (ctf_rollback): Likewise.
389 * ctf-hash.c (ctf_hash_lookup_type): Likewise.
390 * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
392 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
394 * ctf-lookup.c (ctf_lookup_by_name): Adjust.
396 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
398 * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
401 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
403 * ctf-impl.h (ctf_list_splice): New.
404 * ctf-util.h (ctf_list_splice): Likewise.
405 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
406 (ctf_link_sort_inputs): Likewise.
407 (ctf_link_deduplicating_count_inputs): Likewise.
408 (ctf_link_deduplicating_open_inputs): Likewise.
409 (ctf_link_deduplicating_close_inputs): Likewise.
410 (ctf_link_deduplicating_variables): Likewise.
411 (ctf_link_deduplicating_per_cu): Likewise.
412 (ctf_link_deduplicating): Likewise.
415 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
417 * ctf-link.c (ctf_link_one_input_archive_member): Check
418 CTF_LINK_OMIT_VARIABLES_SECTION.
420 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
422 * ctf-impl.h (ctf_type_id_key): New, the key in the
424 (ctf_dedup): New, core deduplicator state.
425 (ctf_file_t) <ctf_dedup>: New.
426 <ctf_dedup_atoms>: New.
427 <ctf_dedup_atoms_alloc>: New.
428 (ctf_hash_type_id_key): New prototype.
429 (ctf_hash_eq_type_id_key): Likewise.
430 (ctf_dedup_atoms_init): Likewise.
431 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
432 (ctf_dedup_atoms_init): Likewise.
433 * ctf-create.c (ctf_serialize): Adjusted.
434 (ctf_add_encoded): No longer static.
435 (ctf_add_reftype): Likewise.
436 * ctf-open.c (ctf_file_close): Destroy the
437 ctf_dedup_atoms_alloc.
438 * ctf-dedup.c: New file.
439 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
440 * configure.ac: Check for stpcpy.
441 * Makefile.am: Add it.
442 * Makefile.in: Regenerate.
443 * config.h.in: Regenerate.
444 * configure: Regenerate.
446 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
448 * configure.ac: Add --enable-libctf-hash-debugging.
449 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
450 * Makefile.in: Regenerated.
451 * configure: Likewise.
452 * config.h.in: Likewise.
453 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
454 (ctf_assert): Define to assert.
456 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
458 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
460 * ctf-impl.h: Include it.
461 (ctf_sha1_init): New.
462 (ctf_sha1_add): Likewise.
463 (ctf_sha1_fini): Likewise.
464 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
466 * Makefile.am: Add file.
467 * Makefile.in: Regenerate.
469 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
471 * libctf.ver (ctf_link_set_variable_filter): Add.
472 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
473 <ctf_link_variable_filter_arg>: Likewise.
474 * ctf-create.c (ctf_serialize): Adjust.
475 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
476 (ctf_link_one_variable): Call it if set.
478 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
480 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
481 conflicts, not the source type.
483 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
485 * ctf-impl.h (ctf_file_t): Improve comments.
486 <ctf_link_cu_mapping>: Split into...
487 <ctf_link_in_cu_mapping>: ... this...
488 <ctf_link_out_cu_mapping>: ... and this.
489 * ctf-create.c (ctf_serialize): Adjust.
490 * ctf-open.c (ctf_file_close): Likewise.
491 * ctf-link.c (ctf_create_per_cu): Look things up in the
492 in_cu_mapping instead of the cu_mapping.
493 (ctf_link_add_cu_mapping): The deduplicating link will define
494 what happens if many FROMs share a TO.
495 (ctf_link_add_cu_mapping): Create in_cu_mapping and
496 out_cu_mapping. Do not create ctf_link_outputs here any more, or
497 create per-CU dicts here: they are already created when needed.
498 (ctf_link_one_variable): Log a debug message if we skip a
499 variable due to its type being concealed in a CU-mapped link.
500 (This is probably too common a case to make into a warning.)
501 (ctf_link): Create empty per-CU dicts if requested.
503 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
505 * ctf-link.c (ctf_link_write): Close the fd.
507 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
509 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
510 * Makefile.in: Regenerated.
511 * ctf-impl.h (ctf_link_input_name): New.
512 (ctf_file_t) <ctf_link_flags>: New.
513 * ctf-create.c (ctf_serialize): Adjust accordingly.
514 * ctf-link.c: Define ctf_open as weak when PIC.
515 (ctf_arc_close_thunk): Remove unnecessary thunk.
516 (ctf_file_close_thunk): Likewise.
517 (ctf_link_input_name): New.
518 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
519 (ctf_link_input_close): Adjust accordingly.
520 (ctf_link_add_ctf_internal): New, split from...
521 (ctf_link_add_ctf): ... here. Return error if lazy loading of
522 CTF is not possible. Change to just call...
523 (ctf_link_add): ... this new function.
524 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
525 ctf_file_close_thunk.
526 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
527 <in_file_name>: ... this.
529 <share_mode>: Likewise (migrated to ctf_link_flags).
530 <done_main_member>: Rename to...
531 <done_parent>: ... this.
532 <main_input_fp>: Rename to...
533 <in_fp_parent>: ... this.
535 (ctf_link_one_type): Adjuwt accordingly. Transition to
536 ctf_err_warn, removing a TODO.
537 (ctf_link_one_variable): Note a case too common to warn about.
538 Report in the debug stream if a cu-mapped link prevents addition
539 of a conflicting variable.
540 (ctf_link_one_input_archive_member): Adjust.
541 (ctf_link_lazy_open): New, open a CTF archive for linking when
543 (ctf_link_close_one_input_archive): New, close it again.
544 (ctf_link_one_input_archive): Adjust for lazy opening, member
545 renames, and ctf_err_warn transition. Move the
546 empty_link_type_mapping call to...
547 (ctf_link): ... here. Adjut for renamings and thunk removal.
548 Don't spuriously fail if some input contains no CTF data.
549 (ctf_link_write): ctf_err_warn transition.
550 * libctf.ver: Remove not-yet-stable comment.
552 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
554 * ctf-impl.h (ctf_strerror): Delete.
555 * ctf-subr.c (ctf_strerror): Likewise.
556 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
559 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
561 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
562 (ctf_import_unref): New.
563 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
564 zero. Don't recurse back in if the refcount is already zero.
565 (ctf_import): Check ctf_parent_unreffed before deciding whether
566 to close a pre-existing parent. Set it to zero.
567 (ctf_import_unreffed): New, as above, setting
568 ctf_parent_unreffed to 1.
569 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
570 child: use direct assignment, and set unreffed on the new and
572 * ctf-link.c (ctf_create_per_cu): Import the parent using
575 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
577 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
578 (ctf_link_type_key): ... this, adjusting member prefixes to
580 (ctf_hash_type_mapping_key): Rename to...
581 (ctf_hash_type_key): ... this.
582 (ctf_hash_eq_type_mapping_key): Rename to...
583 (ctf_hash_eq_type_key): ... this.
584 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
585 (ctf_hash_type_key): ... this, and adjust for member name
587 (ctf_hash_eq_type_mapping_key): Rename to...
588 (ctf_hash_eq_type_key): ... this, and adjust for member name
590 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
591 need for out-of-memory checking in this code.
592 (ctf_type_mapping): Adjust.
594 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
596 configure.ac: Check for vasprintf.
597 configure: Regenerated.
598 config.h.in: Likewise.
600 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
602 * ctf-archive.c (ctf_arc_bufopen): Fix message.
604 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
606 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
608 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
609 if the input has no symtab, rather than dividing by
610 zero. Arrange to free it later via ctfi_free_ctfsect.
611 * ctf-archive.c (ctf_new_archive_internal): Do not
612 ctfi_free_strsect by default.
613 (ctf_arc_close): Possibly free it here.
615 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
617 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
618 (ctf_dump_format_type): improve slice formatting. Always print
619 the type size, even of slices.
620 (ctf_dump_member): Print slices (-> bitfields) differently from
621 non-slices. Failure to format a type is not an OOM.
623 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
625 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
626 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
627 (ctf_dump_objts): Likewise.
628 (ctf_dump_var): Likewise.
629 (ctf_dump_type): Do not emit a duplicate message. Move to
630 ctf_err_warning, and swallow all errors.
632 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
634 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
635 (ctf_decl_buf): Once it escapes, don't try to free it later.
637 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
639 * ctf-types.c (ctf_type_aname): Print arg types here...
640 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
641 in the type name here.
643 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
645 * ctf-impl.h (ctf_assert): New.
646 (ctf_err_warning_t): Likewise.
647 (ctf_file_t) <ctf_errs_warnings>: Likewise.
648 (ctf_err_warn): New prototype.
649 (ctf_assert_fail_internal): Likewise.
650 * ctf-inlines.h (ctf_assert_internal): Likewise.
651 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
652 * ctf-create.c (ctf_serialize): Copy it on serialization.
653 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
654 (ctf_errwarning_next): New iterator, free and pass back
655 errors/warnings in succession.
656 * libctf.ver (ctf_errwarning_next): Add.
658 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
660 * ctf-types.c (ctf_variable_iter): Fix error return.
662 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
664 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
666 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
668 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
670 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
672 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
674 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
675 ctf_dynhash_next_sorted.
676 <cu.ctn_h>: New, pointer to the dynhash under iteration.
677 <cu.ctn_s>: New, pointer to the dynset under iteration.
678 (ctf_hash_sort_f): Sorting function passed to...
679 (ctf_dynhash_next_sorted): ... this new function.
680 (ctf_dynhash_next): New.
681 (ctf_dynset_next): New.
682 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
683 (ctf_dynhash_cnext): New.
684 (ctf_dynset_cnext): New.
685 * ctf-hash.c (ctf_dynhash_next_sorted): New.
686 (ctf_dynhash_next): New.
687 (ctf_dynset_next): New.
688 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
690 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
692 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
694 * ctf-impl.h (ctf_next): New.
695 (ctf_get_dict): New prototype.
696 * ctf-lookup.c (ctf_get_dict): New, split out of...
697 (ctf_lookup_by_id): ... here.
698 * ctf-util.c (ctf_next_create): New.
699 (ctf_next_destroy): New.
700 (ctf_next_copy): New.
701 * ctf-types.c (includes): Add <assert.h>.
702 (ctf_member_next): New.
703 (ctf_enum_next): New.
704 (ctf_type_iter): Document the lack of iteration over parent
706 (ctf_type_next): New.
707 (ctf_variable_next): New.
708 * ctf-archive.c (ctf_archive_next): New.
709 * libctf.ver: Add new public functions.
711 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
713 * libctf.ver (ctf_ref): New.
714 * ctf-open.c (ctf_ref): Implement it.
716 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
718 * ctf-inlines.h (ctf_forwardable_kind): New.
719 * ctf-create.c (ctf_add_forward): Use it.
721 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
723 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
724 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
726 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
728 * ctf-hash.c (ctf_dynset_eq_string): New.
729 (ctf_dynset_create): New.
730 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
731 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
732 (key_to_internal): New.
733 (internal_to_key): New.
734 (ctf_dynset_insert): New.
735 (ctf_dynset_remove): New.
736 (ctf_dynset_destroy): New.
737 (ctf_dynset_lookup): New.
738 (ctf_dynset_exists): New.
739 (ctf_dynset_lookup_any): New.
740 (ctf_hash_insert_type): Coding style.
741 (ctf_hash_define_type): Likewise.
742 * ctf-impl.h (ctf_dynset_t): New.
743 (ctf_dynset_eq_string): New.
744 (ctf_dynset_create): New.
745 (ctf_dynset_insert): New.
746 (ctf_dynset_remove): New.
747 (ctf_dynset_destroy): New.
748 (ctf_dynset_lookup): New.
749 (ctf_dynset_exists): New.
750 (ctf_dynset_lookup_any): New.
751 * ctf-inlines.h (ctf_dynset_cinsert): New.
753 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
755 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
756 <value_free>: Likewise.
758 (ctf_dynhash_item_free): Indirect through the owner.
759 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
760 allocate space for the key_free and value_free fields fields
762 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
763 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
764 value_free if they will exist. Set the slot's owner, but only
766 (ctf_dynhash_remove): Adjust.
768 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
770 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
771 there is a key-freeing function and the key already exists.
773 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
775 * ctf-inlines.h: New file.
776 * ctf-impl.h: Include it.
777 (ctf_hash_iter_find_f): New typedef.
778 (ctf_dynhash_elements): New.
779 (ctf_dynhash_lookup_kv): New.
780 (ctf_dynhash_iter_find): New.
781 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
782 (ctf_traverse_find_cb_arg_t): New.
783 (ctf_hashtab_traverse_find): New.
784 (ctf_dynhash_iter_find): New.
785 (ctf_dynhash_elements): New.
787 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
789 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
791 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
793 * ctf-archive.c (ctf_archive_count): New.
794 * libctf.ver: New public function.
796 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
798 * ctf-types.c (ctf_member_count): New.
799 * libctf.ver: New public function.
801 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
803 * ctf-types.c (ctf_type_kind_forwarded): New.
805 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
807 * ctf-types.c (ctf_type_name_raw): New.
808 (ctf_type_aname_raw): Reimplement accordingly.
810 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
812 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
814 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
816 * ctf-impl.h (struct ctf_archive_internal)
817 <ctfi_unmap_on_close>: New.
818 (ctf_new_archive_internal): Adjust.
819 * ctf-archive.c (ctf_new_archive_internal): Likewise.
820 Initialize ctfi_unmap_on_close. Adjust error path.
821 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
822 (unmap_on_close is 0).
823 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
824 * ctf-open-bfd.c (ctf_fdopen): Adjust.
826 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
828 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
829 ints, floats or typedefs have no name. Fix comment typo.
831 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
833 * ctf-create.c (ctf_add_slice): Support slices of any kind that
834 resolves to an integral type.
835 * ctf-types.c (ctf_type_encoding): Resolve the type before
836 fishing its encoding out.
838 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
840 * ctf-create.c (ctf_create): Mark dirty.
842 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
844 * ctf-create.c (membcmp) Skip nameless members.
846 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
848 * ctf-create.c (ctf_add_member_offset): Support names of ""
849 as if they were the null pointer.
851 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
853 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
856 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
858 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
860 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
862 * ctf-create.c (ctf_serialize): Add cast.
863 (ctf_add_slice): Likewise.
865 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
867 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
868 * ctf-create.c (ctf_add_function): Check for unimplemented type
869 and populate at the same time. Populate one-by-one, not via
871 (ctf_serialize): Remove unnecessary cast.
872 * ctf-types.c (ctf_func_type_info): Likewise.
873 (ctf_func_type_args): Likewise. Fix comment typo.
875 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
877 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
878 (ctf_add_array): Support array contents of type zero.
879 (ctf_add_function): Support arguments and return types of
881 (ctf_add_typedef): Support typedefs to type zero.
882 (ctf_add_member_offset): Support members of type zero,
883 unless added at unspecified (naturally-aligned) offset.
885 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
887 * ctf-error.c: Include <stddef.h>, for offsetof.
888 (_ctf_errlist): Migrate to...
889 (_ctf_errlist_t): ... this.
890 (_ctf_erridx): New, indexes into _ctf_errlist_t.
892 (ctf_errmsg): Adjust accordingly.
893 * Makefile.am (BUILT_SOURCES): Note...
894 (ctf-error.h): ... this new rule.
895 * Makefile.in: Regenerate.
896 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
897 * .gitignore: New, ignore ctf-error.h.
899 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
901 * ctf-impl.h: Fix typos in comments.
903 2020-07-22 Nick Clifton <nickc@redhat.com>
905 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
906 same file descriptor.
908 2020-07-04 Nick Clifton <nickc@redhat.com>
910 Binutils 2.35 branch created.
912 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
914 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
916 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
917 * config.h.in: Regenerated.
918 * Makefile.in: Likewise.
919 * configure: Likewise.
921 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
923 * ctf-create.c: Include <unistd.h>.
924 * ctf-open-bfd.c: Likewise.
926 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
929 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
930 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
931 means this is declared.
932 (bswap_32): Likewise.
933 (bswap_64): Likewise.
934 (bswap_identity_64): Remove, unused.
935 * configure: Regenerated.
936 * config.h.in: Likewise.
938 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
941 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
942 (_libctf_unlikely_): Likewise.
943 (_libctf_unused): Likewise.
944 (_libctf_malloc_): Likewise.
946 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
949 * ctf-archive.c (search_nametbl): No longer global: declare...
950 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
951 (search_modent_by_name): Take and use ARG for the nametbl.
953 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
955 * ctf-impl.h (ctf_new_archive_internal): Declare.
956 (ctf_arc_bufopen): Remove.
957 (ctf_archive_internal) <ctfi_free_symsect>: New.
958 * ctf-archive.c (ctf_arc_close): Use it.
959 (ctf_arc_bufopen): Fuse into...
960 (ctf_new_archive_internal): ... this, moved across from...
961 * ctf-open-bfd.c: ... here.
962 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
963 * libctf.ver: Add it.
965 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
967 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
968 (ctf_dtd_delete): Remove correspondingly.
969 (ctf_rollback): Likewise.
971 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
973 * ctf-create.c (ctf_add_type_internal): Hand back existing types
976 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
978 * ctf-create.c (ctf_add_forward): Don't add forwards to
979 types that already exist.
981 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
983 * ctf-open.c (init_types): Only intern root-visible types.
984 * ctf-create.c (ctf_dtd_insert): Likewise.
985 (ctf_dtd_delete): Only remove root-visible types.
986 (ctf_rollback): Likewise.
987 (ctf_add_generic): Adjust.
988 (ctf_add_struct_sized): Adjust comment.
989 (ctf_add_union_sized): Likewise.
990 (ctf_add_enum): Likewise.
991 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
993 2020-03-11 John Baldwin <jhb@FreeBSD.org>
995 * swap.h (bswap_identity_64): Make static.
997 2020-01-18 Nick Clifton <nickc@redhat.com>
999 Binutils 2.34 branch created.
1001 2020-01-05 Joel Brobecker <brobecker@adacore.com>
1004 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
1005 * configure, config.h.in: Regenerate.
1007 2020-01-01 Alan Modra <amodra@gmail.com>
1009 Update year range in copyright notice of all files.
1011 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
1013 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
1015 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
1017 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
1018 * ctf-types.c (ctf_type_lname): Likewise.
1020 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
1022 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
1023 ctf_import after the first for a given file.
1025 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
1027 * ctf-impl.h (ctf_str_append_noerr): Declare.
1028 * ctf-util.c (ctf_str_append_noerr): Define in terms of
1030 * ctf-dump.c (str_append): New, call it.
1031 (ctf_dump_format_type): Use str_append, not ctf_str_append.
1032 (ctf_dump_label): Likewise.
1033 (ctf_dump_objts): Likewise.
1034 (ctf_dump_funcs): Likewise.
1035 (ctf_dump_var): Likewise.
1036 (ctf_dump_member): Likewise.
1037 (ctf_dump_type): Likewise.
1038 (ctf_dump): Likewise.
1040 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
1042 * ctf-impl.h (ctf_alloc): Remove.
1043 (ctf_free): Likewise.
1044 (ctf_strdup): Likewise.
1045 * ctf-subr.c (ctf_alloc): Remove.
1046 (ctf_free): Likewise.
1047 * ctf-util.c (ctf_strdup): Remove.
1049 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
1050 ctf_free; strdup, not ctf_strdup.
1051 (ctf_dtd_delete): Likewise.
1052 (ctf_dvd_delete): Likewise.
1053 (ctf_add_generic): Likewise.
1054 (ctf_add_function): Likewise.
1055 (ctf_add_enumerator): Likewise.
1056 (ctf_add_member_offset): Likewise.
1057 (ctf_add_variable): Likewise.
1058 (membadd): Likewise.
1059 (ctf_compress_write): Likewise.
1060 (ctf_write_mem): Likewise.
1061 * ctf-decl.c (ctf_decl_push): Likewise.
1062 (ctf_decl_fini): Likewise.
1063 (ctf_decl_sprintf): Likewise. Check for OOM.
1064 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
1065 ctf_free; strdup, not ctf_strdup.
1066 (ctf_dump_free): Likewise.
1067 (ctf_dump): Likewise.
1068 * ctf-open.c (upgrade_types_v1): Likewise.
1069 (init_types): Likewise.
1070 (ctf_file_close): Likewise.
1071 (ctf_bufopen_internal): Likewise. Check for OOM.
1072 (ctf_parent_name_set): Likewise: report the OOM to the caller.
1073 (ctf_cuname_set): Likewise.
1074 (ctf_import): Likewise.
1075 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
1076 free, not ctf_free; strdup, not ctf_strdup.
1077 (ctf_str_free_atom): Likewise.
1078 (ctf_str_create_atoms): Likewise.
1079 (ctf_str_add_ref_internal): Likewise.
1080 (ctf_str_remove_ref): Likewise.
1081 (ctf_str_write_strtab): Likewise.
1083 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1085 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
1086 work right for non-int/fps.
1088 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
1090 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
1093 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
1095 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
1096 * ctf-open.c (ctf_file_close): Free it.
1097 * ctf-create.c (ctf_serialize): Adjust.
1098 (membcmp): When reporting a conflict due to an error, report the
1100 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
1101 (ctf_add_type_internal): ... this. Hand back types we are already
1102 in the middle of adding immediately. Hand back structs/unions with
1103 the same number of members immediately. Do not walk the dynamic
1104 list. Call ctf_add_type_internal, not ctf_add_type. Handle
1105 forwards promoted to other types and the inverse case identically.
1106 Add structs to the mapping as soon as we intern them, before they
1109 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1111 * ctf-impl.h (ctf_names_t): New.
1112 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
1113 (ctf_file_t) <ctf_structs>: Likewise.
1114 <ctf_unions>: Likewise.
1115 <ctf_enums>: Likewise.
1116 <ctf_names>: Likewise.
1117 <ctf_lookups>: Improve comment.
1118 <ctf_ptrtab_len>: New.
1119 <ctf_prov_strtab>: New.
1120 <ctf_str_prov_offset>: New.
1121 <ctf_dtbyname>: Remove, redundant to the names hashes.
1122 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
1123 (ctf_dtdef_t) <dtd_name>: Remove.
1124 <dtd_data>: Note that the ctt_name is now populated.
1125 (ctf_str_atom_t) <csa_offset>: This is now the strtab
1126 offset for internal strings too.
1127 <csa_external_offset>: New, the external strtab offset.
1128 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
1129 (ctf_name_table): New declaration.
1130 (ctf_lookup_by_rawname): Likewise.
1131 (ctf_lookup_by_rawhash): Likewise.
1132 (ctf_set_ctl_hashes): Likewise.
1133 (ctf_serialize): Likewise.
1134 (ctf_dtd_insert): Adjust.
1135 (ctf_simple_open_internal): Likewise.
1136 (ctf_bufopen_internal): Likewise.
1137 (ctf_list_empty_p): Likewise.
1138 (ctf_str_remove_ref): Likewise.
1139 (ctf_str_add): Returns uint32_t now.
1140 (ctf_str_add_ref): Likewise.
1141 (ctf_str_add_external): Now returns a boolean (int).
1142 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
1143 for strings in the appropriate range.
1144 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
1145 when adding the null string to the new strtab.
1146 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
1147 (ctf_str_add_ref_internal): Add make_provisional argument. If
1148 make_provisional, populate the offset and fill in the
1149 ctf_prov_strtab accordingly.
1150 (ctf_str_add): Return the offset, not the string.
1151 (ctf_str_add_ref): Likewise.
1152 (ctf_str_add_external): Return a success integer.
1153 (ctf_str_remove_ref): New, remove a single ref.
1154 (ctf_str_count_strtab): Do not count the initial null string's
1155 length or the existence or length of any unreferenced internal
1157 (ctf_str_populate_sorttab): Skip atoms with no refs.
1158 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
1159 to the cts_len for the null string, since it is no longer done
1160 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
1161 Populate the csa_offset for both internal and external cases.
1162 Flush the ctf_prov_strtab afterwards, and reset the
1163 ctf_str_prov_offset.
1164 * ctf-create.c (ctf_grow_ptrtab): New.
1165 (ctf_create): Call it. Initialize new fields rather than old
1166 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
1167 Set the ctl hashes and data model.
1168 (ctf_update): Rename to...
1169 (ctf_serialize): ... this. Leave a compatibility function behind.
1170 Tell ctf_simple_open_internal that this is a writable dictionary.
1171 Pass the new fields along from the old dictionary. Drop
1172 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
1173 Do not zero out the DTD's ctt_name.
1174 (ctf_prefixed_name): Rename to...
1175 (ctf_name_table): ... this. No longer return a prefixed name: return
1176 the applicable name table instead.
1177 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
1178 kind we're adding. Migrate away from dtd_name.
1179 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
1181 (ctf_dtd_lookup_type_by_name): Remove.
1182 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
1183 No longer check ctf_dtnextid: check ctf_typemax instead.
1184 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
1185 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
1186 ctf_name_table and the right name table, and migrate away from
1187 dtd_name as in ctf_dtd_delete.
1188 (ctf_add_generic): Pass in the kind explicitly and pass it to
1189 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
1190 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
1191 Grow the ptrtab if needed.
1192 (ctf_add_encoded): Pass in the kind.
1193 (ctf_add_slice): Likewise.
1194 (ctf_add_array): Likewise.
1195 (ctf_add_function): Likewise.
1196 (ctf_add_typedef): Likewise.
1197 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
1198 ctt_name rather than dtd_name.
1199 (ctf_add_struct_sized): Pass in the kind. Use
1200 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
1201 ctf_dtd_lookup_type_by_name.
1202 (ctf_add_union_sized): Likewise.
1203 (ctf_add_enum): Likewise.
1204 (ctf_add_enum_encoded): Likewise.
1205 (ctf_add_forward): Likewise.
1206 (ctf_add_type): Likewise.
1207 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1208 being initialized until after the call.
1209 (ctf_write_mem): Likewise.
1210 (ctf_write): Likewise.
1211 * ctf-archive.c (arc_write_one_ctf): Likewise.
1212 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1213 ctf_hash_lookup_type.
1214 (ctf_lookup_by_id): No longer check the readonly types if the
1215 dictionary is writable.
1216 * ctf-open.c (init_types): Assert that this dictionary is not
1217 writable. Adjust to use the new name hashes, ctf_name_table,
1218 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
1219 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
1220 if set. Drop out early when dictionary is writable. Split the
1221 ctf_lookups initialization into...
1222 (ctf_set_cth_hashes): ... this new function.
1223 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
1224 (ctf_simple_open): Adjust accordingly.
1225 (ctf_bufopen): Likewise.
1226 (ctf_file_close): Destroy the appropriate name hashes. No longer
1227 destroy ctf_dtbyname, which is gone.
1228 (ctf_getdatasect): Remove spurious "extern".
1229 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1230 specified name table, given a kind.
1231 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1232 (ctf_member_iter): Add support for iterating over the
1234 (ctf_enum_iter): Likewise.
1235 (ctf_variable_iter): Likewise.
1236 (ctf_type_rvisit): Likewise.
1237 (ctf_member_info): Add support for types in the dynamic type list.
1238 (ctf_enum_name): Likewise.
1239 (ctf_enum_value): Likewise.
1240 (ctf_func_type_info): Likewise.
1241 (ctf_func_type_args): Likewise.
1242 * ctf-link.c (ctf_accumulate_archive_names): No longer call
1244 (ctf_link_write): Likewise.
1245 (ctf_link_intern_extern_string): Adjust for new
1246 ctf_str_add_external return value.
1247 (ctf_link_add_strtab): Likewise.
1248 * ctf-util.c (ctf_list_empty_p): New.
1250 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
1252 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1254 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1256 (ctf_add_variable): Likewise for variables pointing to them.
1257 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1258 type link failure, but do warn for others.
1259 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
1260 errors to be ENOMEM.
1261 (ctf_dump_member): Likewise.
1262 (ctf_dump_type): Likewise.
1263 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1264 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1265 (ctf_dump_header): Likewise.
1266 (ctf_dump_label): likewise.
1267 (ctf_dump_objts): likewise.
1268 (ctf_dump_funcs): likewise.
1269 (ctf_dump_var): likewise.
1270 (ctf_dump_str): Likewise.
1272 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
1274 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1275 (LT_INIT): Likewise.
1276 (AM_INSTALL_LIBBFD): Likewise.
1277 (dlopen): Note why this is necessary in a comment.
1278 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1280 (SHARED_LDFLAGS): Likewise.
1281 (BFD_LIBADD): Likewise, for libbfd.
1282 (BFD_DEPENDENCIES): Likewise.
1283 (VERSION_FLAGS): Initialize, using a version script if ld supports
1284 one, or libtool -export-symbols-regex otherwise.
1285 (AC_CONFIG_MACRO_DIR): Add ../BFD.
1286 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1288 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1289 (noinst_LIBRARIES): Replace with...
1290 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1291 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1292 libctf-nobfd.la as well.
1293 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1294 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1295 (libctf_a_SOURCES): Rename to...
1296 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1298 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1299 with ctf-open-bfd.c added.
1300 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1301 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1302 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1303 * Makefile.am [INSTALL_LIBCTF]: Use it.
1304 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1306 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1307 the unstable components).
1308 * Makefile.in: Regenerated.
1309 * config.h.in: Likewise.
1310 * configure: Likewise.
1312 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1314 * configure.ac (INSTALL_LIBCTF): New, controlled by
1315 --enable-install-libctf.
1316 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1317 * Makefile.in: Regenerated.
1318 * configure: Regenerated.
1320 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1322 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1323 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1325 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1327 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1329 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1331 * ctf-impl.h (includes): Include <sys/param.h> here.
1333 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1335 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1336 (flip_objts): Likewise.
1337 (flip_vars): Likewise.
1338 (flip_types): Likewise.
1340 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1342 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1343 freeing functions: if set, free the key and value if the slot
1344 already exists. Always reassign the key.
1345 (ctf_dynhash_insert): Adjust call appropriately.
1346 (ctf_hash_insert_type): Likewise.
1348 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
1350 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1351 type kind. Allow forwards to unify with pre-existing structs/
1354 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1356 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1357 <ctf_link_memb_name_changer>: Likewise.
1358 <ctf_link_memb_name_changer_arg>: Likewise.
1359 * ctf-create.c (ctf_update): Update accordingly.
1360 * ctf-open.c (ctf_file_close): Likewise.
1361 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1362 (ctf_link_add_cu_mapping): New.
1363 (ctf_link_set_memb_name_changer): Likewise.
1364 (ctf_change_parent_name): New.
1365 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1366 allocated by the caller's ctf_link_memb_name_changer.
1367 <ndynames>: Likewise.
1368 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1369 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1370 ctf_change_parent_name. Free any resulting names.
1372 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1374 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1375 (ctf_link_one_type): ... here, with parent-name setting added.
1376 (check_variable): New.
1377 (ctf_link_one_variable): Likewise.
1378 (ctf_link_one_input_archive_member): Call it.
1379 * ctf-error.c (_ctf_errlist): Updated with new errors.
1381 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1383 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1384 (struct ctf_link_type_mapping_key): New.
1385 (ctf_hash_type_mapping_key): Likewise.
1386 (ctf_hash_eq_type_mapping_key): Likewise.
1387 (ctf_add_type_mapping): Likewise.
1388 (ctf_type_mapping): Likewise.
1389 (ctf_dynhash_empty): Likewise.
1390 * ctf-open.c (ctf_file_close): Update accordingly.
1391 * ctf-create.c (ctf_update): Likewise.
1392 (ctf_add_type): Populate the mapping.
1393 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1394 (ctf_hash_eq_type_mapping_key): Check the key for equality.
1395 (ctf_dynhash_insert): Fix comment typo.
1396 (ctf_dynhash_empty): New.
1397 * ctf-link.c (ctf_add_type_mapping): New.
1398 (ctf_type_mapping): Likewise.
1399 (empty_link_type_mapping): New.
1400 (ctf_link_one_input_archive): Call it.
1402 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1404 * ctf-link.c: New file, linking of the string and type sections.
1405 * Makefile.am (libctf_a_SOURCES): Add it.
1406 * Makefile.in: Regenerate.
1408 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1410 * ctf-create.c (ctf_update): Update accordingly.
1411 * ctf-open.c (ctf_file_close): Likewise.
1412 * ctf-error.c (_ctf_errlist): Updated with new errors.
1414 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1416 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1418 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1420 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1422 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1423 (ctf_dump_format_type): Add non-root-type { } notation.
1424 Add root flag to prototype.
1425 (ctf_dump_label): Adjust accordingly.
1426 (ctf_dump_objts): Likewise.
1427 (ctf_dump_var): Likewise.
1429 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1431 * ctf-create.c (ctf_compress_write): Fix double-free.
1433 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1435 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1437 (ctf_arc_write_fd): ... this new function.
1438 * ctf-create.c (ctf_write_mem): New.
1440 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1442 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1443 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1444 (ctf_str_add_ref): Name the last arg.
1445 (ctf_str_add_external) New.
1446 (ctf_str_add_strraw_explicit): Likewise.
1447 (ctf_simple_open_internal): Likewise.
1448 (ctf_bufopen_internal): Likewise.
1450 * ctf-string.c (ctf_strraw_explicit): Split from...
1451 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1452 (ctf_str_add_ref_internal): Return the atom, not the
1454 (ctf_str_add): Adjust accordingly.
1455 (ctf_str_add_ref): Likewise. Move up in the file.
1456 (ctf_str_add_external): New: update the csa_offset.
1457 (ctf_str_count_strtab): Only account for strings with no csa_offset
1458 in the internal strtab length.
1459 (ctf_str_write_strtab): If the csa_offset is set, update the
1460 string's refs without writing the string out, and update the
1461 ctf_syn_ext_strtab. Make OOM handling less ugly.
1462 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1463 (ctf_update): Handle failure to populate the strtab. Pass in the
1464 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1465 Call ctf_simple_open_internal, not ctf_simple_open.
1466 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1468 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1469 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1470 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1471 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1472 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1473 (ctf_simple_open_internal): ... this new function, which calls
1474 ctf_bufopen_internal.
1475 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1476 (ctf_bufopen_internal): ... this new function, which sets
1479 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1481 * ctf_types.c (ctf_type_iter_all): New.
1483 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1485 * ctf-open.c (init_symtab): Check for overflow against the right
1487 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1488 (upgrade_types_v1): Note that these sections are not checked.
1489 (flip_header): Endian-swap the header fields.
1490 (flip_ctf): Endian-swap the sections.
1491 (flip_objts): Update comment.
1492 (ctf_bufopen): Check header offsets and alignment for validity.
1494 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1496 * ctf-open-bfd.c: Add <assert.h>.
1497 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1498 techniques borrowed from bfd_elf_sym_name.
1499 (ctf_new_archive_internal): Improve comment.
1500 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1501 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1502 no symbol section, but not vice versa.
1504 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1506 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1507 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1508 * ctf-dump.c (dump_header): New function, dump the CTF header.
1509 (ctf_dump): Call it.
1510 (ctf_dump_header_strfield): New function.
1511 (ctf_dump_header_sectfield): Likewise.
1513 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1515 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1516 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1517 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1518 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1519 Print out ctf_cuname: only print out ctf_parname if set.
1520 (ctf_free_base): Removed, ctf_base is no longer freed: free
1521 ctf_dynbase instead.
1522 (ctf_set_version): Fix spacing.
1523 (upgrade_header): New, in-place header upgrading.
1524 (upgrade_types): Rename to...
1525 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1526 longer track old and new headers separately. No longer allow for
1527 header sizes explicitly: squeeze the headers out on upgrade (they
1528 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1529 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1530 (upgrade_types): New, also handle ctf_parmax updating.
1531 (flip_header): Flip ctf_cuname.
1532 (flip_types): Flip BUF explicitly rather than deriving BUF from
1534 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1535 required alignment of objtoff and funcoff. No longer store it in
1536 the ctf_buf unless that buf is derived unmodified from the input.
1537 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1538 that duplicate fields in ctf_file: move allocation of ctf_file
1539 further up instead. Call upgrade_header as needed. Move
1540 version-specific ctf_parmax initialization into upgrade_types. More
1541 concise error handling.
1542 (ctf_file_close): No longer test for null pointers before freeing.
1543 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1546 (ctf_cuname_set): New.
1547 * ctf-create.c (ctf_update): Populate ctf_cuname.
1548 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1550 (ctf_write): Likewise.
1551 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1552 Fix the compression length: fp->ctf_size never counted the CTF
1553 header. Simplify the compress call accordingly.
1555 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1557 * ctf-endian.h: Don't assume htole64 and le64toh are always
1558 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1559 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1560 not bswap_identity_64.
1562 2019-09-18 Alan Modra <amodra@gmail.com>
1564 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1566 2019-09-09 Phil Blundell <pb@pbcl.net>
1568 binutils 2.33 branch created.
1570 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1572 * ctf-types.c (ctf_type_aname_raw): New.
1573 (ctf_func_type_info): Likewise.
1574 (ctf_func_type_args): Likewise.
1575 * ctf-error.c (_ctf_errlist): Fix description.
1576 * ctf-lookup.c: Fix file description.
1578 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1580 * ctf-create.c (ctf_create): Fix off-by-one error.
1582 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1584 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1586 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1587 (struct ctf_str_atom): New, disambiguated single string.
1588 (struct ctf_str_atom_ref): New, points to some other location that
1589 references this string's offset.
1590 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1591 Remove member ctf_dtvstrlen: we no longer track the total strlen
1593 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1594 (ctf_str_free_atoms): Likewise.
1595 (ctf_str_add): Likewise.
1596 (ctf_str_add_ref): Likewise.
1597 (ctf_str_rollback): Likewise.
1598 (ctf_str_purge_refs): Likewise.
1599 (ctf_str_write_strtab): Likewise.
1600 (ctf_realloc): Declare new function in ctf-util.c.
1602 * ctf-open.c (ctf_bufopen): Create the atoms table.
1603 (ctf_file_close): Destroy it.
1604 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1605 special-case the position of the parname string. Construct the
1606 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1607 rest of each buffer element is constructed, not via open-coding:
1608 realloc the CTF buffer and append the strtab to it. No longer
1609 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1610 strtab construction.
1611 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1612 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1613 after buffer element construction instead.
1614 (ctf_copy_lmembers): Likewise.
1615 (ctf_copy_emembers): Likewise.
1616 (ctf_create): No longer maintain the ctf_dtvstrlen.
1617 (ctf_dtd_delete): Likewise.
1618 (ctf_dvd_delete): Likewise.
1619 (ctf_add_generic): Likewise.
1620 (ctf_add_enumerator): Likewise.
1621 (ctf_add_member_offset): Likewise.
1622 (ctf_add_variable): Likewise.
1623 (membadd): Likewise.
1624 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1625 if there are active ctf_str_num_refs.
1626 (ctf_strraw): Move to ctf-string.c.
1627 (ctf_strptr): Likewise.
1628 * ctf-string.c: New file, strtab manipulation.
1630 * Makefile.am (libctf_a_SOURCES): Add it.
1631 * Makefile.in: Regenerate.
1633 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1635 * ctf-impl.h (ctf_hash_iter_f): New.
1636 (ctf_dynhash_iter): New declaration.
1637 (ctf_dynhash_iter_remove): New declaration.
1638 * ctf-hash.c (ctf_dynhash_iter): Define.
1639 (ctf_dynhash_iter_remove): Likewise.
1640 (ctf_hashtab_traverse): New.
1641 (ctf_hashtab_traverse_remove): Likewise.
1642 (struct ctf_traverse_cb_arg): Likewise.
1643 (struct ctf_traverse_remove_cb_arg): Likewise.
1645 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1647 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1649 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1651 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1652 (ctf_dump_funcs): Likewise.
1654 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1656 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1657 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1658 little-endian CTF archive magic. Do not check the CTF version:
1659 ctf_simple_open does that in endian-safe ways. Do not dereference
1660 null pointers on open failure.
1662 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1664 * ctf-open.c (get_vbytes_common): Return the new slice size.
1665 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1666 Remember to copy in the CTF data when opening an uncompressed
1667 foreign-endian CTF file. Prune useless variable manipulation.
1669 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1671 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1674 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1676 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1679 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1681 * ctf-subr.c (_PAGESIZE): Remove.
1682 (ctf_data_alloc): Likewise.
1683 (ctf_data_free): Likewise.
1684 (ctf_data_protect): Likewise.
1685 * ctf-impl.h: Remove declarations.
1686 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1687 ctf_free, not ctf_data_free.
1688 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1689 the buffer again on compression error.
1690 * ctf-open.c (ctf_set_base): No longer track the size: call
1691 ctf_free, not ctf_data_free.
1692 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1693 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1695 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1697 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1699 (ctf_dvd_insert): Likewise.
1700 (ctf_add_generic): Likewise.
1701 (ctf_add_variable): Likewise.
1702 * ctf-impl.h: Adjust declarations.
1704 2019-06-14 Alan Modra <amodra@gmail.com>
1706 * configure: Regenerate.
1708 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1710 * ctf-decls.h: Include <libiberty.h>.
1711 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1713 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1715 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1716 (ctf_dump_objts): Likewise.
1717 (ctf_dump_funcs): Likewise.
1718 (ctf_dump_member): Likewise.
1719 (ctf_dump_str): Likewise.
1721 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1723 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1724 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1726 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1728 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1729 (ctf_arc_open_by_offset): Likewise.
1730 * ctf-create.c (ctf_add_type): Likewise.
1732 2019-06-04 Tom Tromey <tromey@adacore.com>
1734 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1735 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1737 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1739 * configure.ac: Check for O_CLOEXEC.
1740 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1741 * config.h.in: Regenerate.
1742 * configure: Likewise.
1744 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1746 * qsort_r.c: Rename to...
1747 * ctf-qsort_r.c: ... this.
1748 (_quicksort): Define to ctf_qsort_r.
1749 * ctf-decls.h (qsort_r): Remove.
1751 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1752 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1753 * Makefile.am (libctf_a_LIBADD): Remove.
1754 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1755 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1756 * ctf-create.c (ctf_update): Likewise.
1757 * configure.ac: Check for BSD versus GNU qsort_r signature.
1758 * Makefile.in: Regenerate.
1759 * config.h.in: Likewise.
1760 * configure: Likewise.
1762 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1764 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1766 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1768 * Makefile.am (ZLIB): New.
1769 (ZLIBINC): Likewise.
1770 (AM_CFLAGS): Use them.
1771 (libctf_a_LIBADD): New, for LIBOBJS.
1772 * configure.ac: Check for zlib, endian.h, and qsort_r.
1773 * ctf-endian.h: New, providing htole64 and le64toh.
1774 * swap.h: Code style fixes.
1775 (bswap_identity_64): New.
1776 * qsort_r.c: New, from gnulib (with one added #include).
1777 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1778 and unconditional definitions of MIN and MAX.
1779 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1780 (ctf_set_errno): Now returns unsigned long.
1781 * ctf-util.c (ctf_set_errno): Adjust here too.
1782 * ctf-archive.c: Use ctf-endian.h.
1783 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1784 cts_flags and cts_offset.
1785 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1786 * ctf-create.c: Provide a definition of roundup if not defined.
1787 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1788 (ctf_add_reftype): Do not check if type IDs are below zero.
1789 (ctf_add_slice): Likewise.
1790 (ctf_add_typedef): Likewise.
1791 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1792 when known error-free. Drop CTF_ERR usage for functions returning
1794 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1796 (ctf_add_variable): Likewise.
1797 (enumcmp): Likewise.
1798 (enumadd): Likewise.
1799 (membcmp): Likewise.
1800 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1801 when known error-free.
1802 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1803 returning int: use CTF_ERR for functions returning ctf_type_id.
1804 (ctf_dump_label): Likewise.
1805 (ctf_dump_objts): Likewise.
1806 * ctf-labels.c (ctf_label_topmost): Likewise.
1807 (ctf_label_iter): Likewise.
1808 (ctf_label_info): Likewise.
1809 * ctf-lookup.c (ctf_func_args): Likewise.
1810 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1811 (ctf_bufopen): Likewise. Use zlib types as needed.
1812 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1814 (ctf_enum_iter): Likewise.
1815 (ctf_type_size): Likewise.
1816 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1817 (ctf_type_kind_unsliced): Likewise.
1818 (ctf_type_kind): Likewise.
1819 (ctf_type_encoding): Likewise.
1820 (ctf_member_info): Likewise.
1821 (ctf_array_info): Likewise.
1822 (ctf_enum_value): Likewise.
1823 (ctf_type_rvisit): Likewise.
1824 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1826 (ctf_simple_open): Likewise.
1827 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1828 * Makefile.in: Regenerate.
1829 * aclocal.m4: Likewise.
1830 * config.h: Likewise.
1831 * configure: Likewise.
1833 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1835 * configure.in: Check for bfd_section_from_elf_index.
1836 * configure: Regenerate.
1837 * config.h.in [HAVE_BFD_ELF]: Likewise.
1838 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1839 abfd is potentially unused now.
1841 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1844 * Makefile.in: Regenerated.
1845 * config.h.in: Likewise.
1846 * aclocal.m4: Likewise.
1847 * configure: Likewise.
1849 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1853 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1855 * ctf-labels.c: New.
1857 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1859 * ctf-impl.h (_libctf_version): New declaration.
1860 * ctf-subr.c (_libctf_version): Define it.
1863 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1865 * ctf-create.c (enumcmp): New.
1866 (enumadd): Likewise.
1867 (membcmp): Likewise.
1868 (membadd): Likewise.
1869 (ctf_add_type): Likewise.
1871 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1873 * ctf-lookup.c (isqualifier): New.
1874 (ctf_lookup_by_name): Likewise.
1875 (struct ctf_lookup_var_key): Likewise.
1876 (ctf_lookup_var): Likewise.
1877 (ctf_lookup_variable): Likewise.
1878 (ctf_lookup_symbol_name): Likewise.
1879 (ctf_lookup_by_symbol): Likewise.
1880 (ctf_func_info): Likewise.
1881 (ctf_func_args): Likewise.
1883 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1885 * ctf-decl.c: New file.
1886 * ctf-types.c: Likewise.
1887 * ctf-impl.h: New declarations.
1889 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1891 * ctf-open-bfd.c: New file.
1892 * ctf-open.c (ctf_close): New.
1893 * ctf-impl.h: Include bfd.h.
1894 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1895 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1897 (ctf_bfdopen_ctfsect): New declaration.
1898 (_CTF_SECTION): likewise.
1900 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1902 * ctf-archive.c: New.
1903 * ctf-impl.h (ctf_archive_internal): New type.
1904 (ctf_arc_open_internal): New declaration.
1905 (ctf_arc_bufopen): Likewise.
1906 (ctf_arc_close_internal): Likewise.
1908 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1910 * ctf-open.c: New file.
1913 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1915 * ctf-create.c: New file.
1916 * ctf-lookup.c: New file.
1918 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1920 * ctf-impl.h: New definitions and declarations for type creation
1923 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1925 * ctf-hash.c: New file.
1926 * ctf-impl.h: New declarations.
1928 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1930 * ctf-error.c: New file.
1932 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1934 * ctf-util.c: New file.
1936 * ctf-impl.h: Include it, and add declarations.
1938 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1940 * ctf-impl.h: New file.
1941 * ctf-subr.c: New file.
1948 version-control: never