1 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-impl.h (ctf_list_splice): New.
4 * ctf-util.h (ctf_list_splice): Likewise.
5 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
6 (ctf_link_sort_inputs): Likewise.
7 (ctf_link_deduplicating_count_inputs): Likewise.
8 (ctf_link_deduplicating_open_inputs): Likewise.
9 (ctf_link_deduplicating_close_inputs): Likewise.
10 (ctf_link_deduplicating_variables): Likewise.
11 (ctf_link_deduplicating_per_cu): Likewise.
12 (ctf_link_deduplicating): Likewise.
15 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
17 * ctf-link.c (ctf_link_one_input_archive_member): Check
18 CTF_LINK_OMIT_VARIABLES_SECTION.
20 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
22 * ctf-impl.h (ctf_type_id_key): New, the key in the
24 (ctf_dedup): New, core deduplicator state.
25 (ctf_file_t) <ctf_dedup>: New.
26 <ctf_dedup_atoms>: New.
27 <ctf_dedup_atoms_alloc>: New.
28 (ctf_hash_type_id_key): New prototype.
29 (ctf_hash_eq_type_id_key): Likewise.
30 (ctf_dedup_atoms_init): Likewise.
31 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
32 (ctf_dedup_atoms_init): Likewise.
33 * ctf-create.c (ctf_serialize): Adjusted.
34 (ctf_add_encoded): No longer static.
35 (ctf_add_reftype): Likewise.
36 * ctf-open.c (ctf_file_close): Destroy the
37 ctf_dedup_atoms_alloc.
38 * ctf-dedup.c: New file.
39 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
40 * configure.ac: Check for stpcpy.
41 * Makefile.am: Add it.
42 * Makefile.in: Regenerate.
43 * config.h.in: Regenerate.
44 * configure: Regenerate.
46 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
48 * configure.ac: Add --enable-libctf-hash-debugging.
49 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
50 * Makefile.in: Regenerated.
51 * configure: Likewise.
52 * config.h.in: Likewise.
53 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
54 (ctf_assert): Define to assert.
56 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
58 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
60 * ctf-impl.h: Include it.
62 (ctf_sha1_add): Likewise.
63 (ctf_sha1_fini): Likewise.
64 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
66 * Makefile.am: Add file.
67 * Makefile.in: Regenerate.
69 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
71 * libctf.ver (ctf_link_set_variable_filter): Add.
72 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
73 <ctf_link_variable_filter_arg>: Likewise.
74 * ctf-create.c (ctf_serialize): Adjust.
75 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
76 (ctf_link_one_variable): Call it if set.
78 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
80 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
81 conflicts, not the source type.
83 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
85 * ctf-impl.h (ctf_file_t): Improve comments.
86 <ctf_link_cu_mapping>: Split into...
87 <ctf_link_in_cu_mapping>: ... this...
88 <ctf_link_out_cu_mapping>: ... and this.
89 * ctf-create.c (ctf_serialize): Adjust.
90 * ctf-open.c (ctf_file_close): Likewise.
91 * ctf-link.c (ctf_create_per_cu): Look things up in the
92 in_cu_mapping instead of the cu_mapping.
93 (ctf_link_add_cu_mapping): The deduplicating link will define
94 what happens if many FROMs share a TO.
95 (ctf_link_add_cu_mapping): Create in_cu_mapping and
96 out_cu_mapping. Do not create ctf_link_outputs here any more, or
97 create per-CU dicts here: they are already created when needed.
98 (ctf_link_one_variable): Log a debug message if we skip a
99 variable due to its type being concealed in a CU-mapped link.
100 (This is probably too common a case to make into a warning.)
101 (ctf_link): Create empty per-CU dicts if requested.
103 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
105 * ctf-link.c (ctf_link_write): Close the fd.
107 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
109 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
110 * Makefile.in: Regenerated.
111 * ctf-impl.h (ctf_link_input_name): New.
112 (ctf_file_t) <ctf_link_flags>: New.
113 * ctf-create.c (ctf_serialize): Adjust accordingly.
114 * ctf-link.c: Define ctf_open as weak when PIC.
115 (ctf_arc_close_thunk): Remove unnecessary thunk.
116 (ctf_file_close_thunk): Likewise.
117 (ctf_link_input_name): New.
118 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
119 (ctf_link_input_close): Adjust accordingly.
120 (ctf_link_add_ctf_internal): New, split from...
121 (ctf_link_add_ctf): ... here. Return error if lazy loading of
122 CTF is not possible. Change to just call...
123 (ctf_link_add): ... this new function.
124 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
125 ctf_file_close_thunk.
126 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
127 <in_file_name>: ... this.
129 <share_mode>: Likewise (migrated to ctf_link_flags).
130 <done_main_member>: Rename to...
131 <done_parent>: ... this.
132 <main_input_fp>: Rename to...
133 <in_fp_parent>: ... this.
135 (ctf_link_one_type): Adjuwt accordingly. Transition to
136 ctf_err_warn, removing a TODO.
137 (ctf_link_one_variable): Note a case too common to warn about.
138 Report in the debug stream if a cu-mapped link prevents addition
139 of a conflicting variable.
140 (ctf_link_one_input_archive_member): Adjust.
141 (ctf_link_lazy_open): New, open a CTF archive for linking when
143 (ctf_link_close_one_input_archive): New, close it again.
144 (ctf_link_one_input_archive): Adjust for lazy opening, member
145 renames, and ctf_err_warn transition. Move the
146 empty_link_type_mapping call to...
147 (ctf_link): ... here. Adjut for renamings and thunk removal.
148 Don't spuriously fail if some input contains no CTF data.
149 (ctf_link_write): ctf_err_warn transition.
150 * libctf.ver: Remove not-yet-stable comment.
152 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
154 * ctf-impl.h (ctf_strerror): Delete.
155 * ctf-subr.c (ctf_strerror): Likewise.
156 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
159 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
161 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
162 (ctf_import_unref): New.
163 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
164 zero. Don't recurse back in if the refcount is already zero.
165 (ctf_import): Check ctf_parent_unreffed before deciding whether
166 to close a pre-existing parent. Set it to zero.
167 (ctf_import_unreffed): New, as above, setting
168 ctf_parent_unreffed to 1.
169 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
170 child: use direct assignment, and set unreffed on the new and
172 * ctf-link.c (ctf_create_per_cu): Import the parent using
175 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
177 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
178 (ctf_link_type_key): ... this, adjusting member prefixes to
180 (ctf_hash_type_mapping_key): Rename to...
181 (ctf_hash_type_key): ... this.
182 (ctf_hash_eq_type_mapping_key): Rename to...
183 (ctf_hash_eq_type_key): ... this.
184 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
185 (ctf_hash_type_key): ... this, and adjust for member name
187 (ctf_hash_eq_type_mapping_key): Rename to...
188 (ctf_hash_eq_type_key): ... this, and adjust for member name
190 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
191 need for out-of-memory checking in this code.
192 (ctf_type_mapping): Adjust.
194 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
196 configure.ac: Check for vasprintf.
197 configure: Regenerated.
198 config.h.in: Likewise.
200 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
202 * ctf-archive.c (ctf_arc_bufopen): Fix message.
204 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
206 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
208 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
209 if the input has no symtab, rather than dividing by
210 zero. Arrange to free it later via ctfi_free_ctfsect.
211 * ctf-archive.c (ctf_new_archive_internal): Do not
212 ctfi_free_strsect by default.
213 (ctf_arc_close): Possibly free it here.
215 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
217 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
218 (ctf_dump_format_type): improve slice formatting. Always print
219 the type size, even of slices.
220 (ctf_dump_member): Print slices (-> bitfields) differently from
221 non-slices. Failure to format a type is not an OOM.
223 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
225 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
226 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
227 (ctf_dump_objts): Likewise.
228 (ctf_dump_var): Likewise.
229 (ctf_dump_type): Do not emit a duplicate message. Move to
230 ctf_err_warning, and swallow all errors.
232 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
234 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
235 (ctf_decl_buf): Once it escapes, don't try to free it later.
237 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
239 * ctf-types.c (ctf_type_aname): Print arg types here...
240 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
241 in the type name here.
243 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
245 * ctf-impl.h (ctf_assert): New.
246 (ctf_err_warning_t): Likewise.
247 (ctf_file_t) <ctf_errs_warnings>: Likewise.
248 (ctf_err_warn): New prototype.
249 (ctf_assert_fail_internal): Likewise.
250 * ctf-inlines.h (ctf_assert_internal): Likewise.
251 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
252 * ctf-create.c (ctf_serialize): Copy it on serialization.
253 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
254 (ctf_errwarning_next): New iterator, free and pass back
255 errors/warnings in succession.
256 * libctf.ver (ctf_errwarning_next): Add.
258 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
260 * ctf-types.c (ctf_variable_iter): Fix error return.
262 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
264 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
266 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
268 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
270 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
272 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
274 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
275 ctf_dynhash_next_sorted.
276 <cu.ctn_h>: New, pointer to the dynhash under iteration.
277 <cu.ctn_s>: New, pointer to the dynset under iteration.
278 (ctf_hash_sort_f): Sorting function passed to...
279 (ctf_dynhash_next_sorted): ... this new function.
280 (ctf_dynhash_next): New.
281 (ctf_dynset_next): New.
282 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
283 (ctf_dynhash_cnext): New.
284 (ctf_dynset_cnext): New.
285 * ctf-hash.c (ctf_dynhash_next_sorted): New.
286 (ctf_dynhash_next): New.
287 (ctf_dynset_next): New.
288 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
290 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
292 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
294 * ctf-impl.h (ctf_next): New.
295 (ctf_get_dict): New prototype.
296 * ctf-lookup.c (ctf_get_dict): New, split out of...
297 (ctf_lookup_by_id): ... here.
298 * ctf-util.c (ctf_next_create): New.
299 (ctf_next_destroy): New.
300 (ctf_next_copy): New.
301 * ctf-types.c (includes): Add <assert.h>.
302 (ctf_member_next): New.
303 (ctf_enum_next): New.
304 (ctf_type_iter): Document the lack of iteration over parent
306 (ctf_type_next): New.
307 (ctf_variable_next): New.
308 * ctf-archive.c (ctf_archive_next): New.
309 * libctf.ver: Add new public functions.
311 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
313 * libctf.ver (ctf_ref): New.
314 * ctf-open.c (ctf_ref): Implement it.
316 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
318 * ctf-inlines.h (ctf_forwardable_kind): New.
319 * ctf-create.c (ctf_add_forward): Use it.
321 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
323 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
324 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
326 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
328 * ctf-hash.c (ctf_dynset_eq_string): New.
329 (ctf_dynset_create): New.
330 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
331 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
332 (key_to_internal): New.
333 (internal_to_key): New.
334 (ctf_dynset_insert): New.
335 (ctf_dynset_remove): New.
336 (ctf_dynset_destroy): New.
337 (ctf_dynset_lookup): New.
338 (ctf_dynset_exists): New.
339 (ctf_dynset_lookup_any): New.
340 (ctf_hash_insert_type): Coding style.
341 (ctf_hash_define_type): Likewise.
342 * ctf-impl.h (ctf_dynset_t): New.
343 (ctf_dynset_eq_string): New.
344 (ctf_dynset_create): New.
345 (ctf_dynset_insert): New.
346 (ctf_dynset_remove): New.
347 (ctf_dynset_destroy): New.
348 (ctf_dynset_lookup): New.
349 (ctf_dynset_exists): New.
350 (ctf_dynset_lookup_any): New.
351 * ctf-inlines.h (ctf_dynset_cinsert): New.
353 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
355 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
356 <value_free>: Likewise.
358 (ctf_dynhash_item_free): Indirect through the owner.
359 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
360 allocate space for the key_free and value_free fields fields
362 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
363 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
364 value_free if they will exist. Set the slot's owner, but only
366 (ctf_dynhash_remove): Adjust.
368 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
370 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
371 there is a key-freeing function and the key already exists.
373 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
375 * ctf-inlines.h: New file.
376 * ctf-impl.h: Include it.
377 (ctf_hash_iter_find_f): New typedef.
378 (ctf_dynhash_elements): New.
379 (ctf_dynhash_lookup_kv): New.
380 (ctf_dynhash_iter_find): New.
381 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
382 (ctf_traverse_find_cb_arg_t): New.
383 (ctf_hashtab_traverse_find): New.
384 (ctf_dynhash_iter_find): New.
385 (ctf_dynhash_elements): New.
387 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
389 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
391 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
393 * ctf-archive.c (ctf_archive_count): New.
394 * libctf.ver: New public function.
396 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
398 * ctf-types.c (ctf_member_count): New.
399 * libctf.ver: New public function.
401 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
403 * ctf-types.c (ctf_type_kind_forwarded): New.
405 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
407 * ctf-types.c (ctf_type_name_raw): New.
408 (ctf_type_aname_raw): Reimplement accordingly.
410 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
412 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
414 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
416 * ctf-impl.h (struct ctf_archive_internal)
417 <ctfi_unmap_on_close>: New.
418 (ctf_new_archive_internal): Adjust.
419 * ctf-archive.c (ctf_new_archive_internal): Likewise.
420 Initialize ctfi_unmap_on_close. Adjust error path.
421 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
422 (unmap_on_close is 0).
423 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
424 * ctf-open-bfd.c (ctf_fdopen): Adjust.
426 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
428 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
429 ints, floats or typedefs have no name. Fix comment typo.
431 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
433 * ctf-create.c (ctf_add_slice): Support slices of any kind that
434 resolves to an integral type.
435 * ctf-types.c (ctf_type_encoding): Resolve the type before
436 fishing its encoding out.
438 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
440 * ctf-create.c (ctf_create): Mark dirty.
442 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
444 * ctf-create.c (membcmp) Skip nameless members.
446 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
448 * ctf-create.c (ctf_add_member_offset): Support names of ""
449 as if they were the null pointer.
451 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
453 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
456 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
458 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
460 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
462 * ctf-create.c (ctf_serialize): Add cast.
463 (ctf_add_slice): Likewise.
465 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
467 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
468 * ctf-create.c (ctf_add_function): Check for unimplemented type
469 and populate at the same time. Populate one-by-one, not via
471 (ctf_serialize): Remove unnecessary cast.
472 * ctf-types.c (ctf_func_type_info): Likewise.
473 (ctf_func_type_args): Likewise. Fix comment typo.
475 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
477 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
478 (ctf_add_array): Support array contents of type zero.
479 (ctf_add_function): Support arguments and return types of
481 (ctf_add_typedef): Support typedefs to type zero.
482 (ctf_add_member_offset): Support members of type zero,
483 unless added at unspecified (naturally-aligned) offset.
485 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
487 * ctf-error.c: Include <stddef.h>, for offsetof.
488 (_ctf_errlist): Migrate to...
489 (_ctf_errlist_t): ... this.
490 (_ctf_erridx): New, indexes into _ctf_errlist_t.
492 (ctf_errmsg): Adjust accordingly.
493 * Makefile.am (BUILT_SOURCES): Note...
494 (ctf-error.h): ... this new rule.
495 * Makefile.in: Regenerate.
496 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
497 * .gitignore: New, ignore ctf-error.h.
499 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
501 * ctf-impl.h: Fix typos in comments.
503 2020-07-22 Nick Clifton <nickc@redhat.com>
505 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
506 same file descriptor.
508 2020-07-04 Nick Clifton <nickc@redhat.com>
510 Binutils 2.35 branch created.
512 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
514 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
516 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
517 * config.h.in: Regenerated.
518 * Makefile.in: Likewise.
519 * configure: Likewise.
521 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
523 * ctf-create.c: Include <unistd.h>.
524 * ctf-open-bfd.c: Likewise.
526 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
529 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
530 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
531 means this is declared.
532 (bswap_32): Likewise.
533 (bswap_64): Likewise.
534 (bswap_identity_64): Remove, unused.
535 * configure: Regenerated.
536 * config.h.in: Likewise.
538 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
541 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
542 (_libctf_unlikely_): Likewise.
543 (_libctf_unused): Likewise.
544 (_libctf_malloc_): Likewise.
546 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
549 * ctf-archive.c (search_nametbl): No longer global: declare...
550 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
551 (search_modent_by_name): Take and use ARG for the nametbl.
553 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
555 * ctf-impl.h (ctf_new_archive_internal): Declare.
556 (ctf_arc_bufopen): Remove.
557 (ctf_archive_internal) <ctfi_free_symsect>: New.
558 * ctf-archive.c (ctf_arc_close): Use it.
559 (ctf_arc_bufopen): Fuse into...
560 (ctf_new_archive_internal): ... this, moved across from...
561 * ctf-open-bfd.c: ... here.
562 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
563 * libctf.ver: Add it.
565 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
567 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
568 (ctf_dtd_delete): Remove correspondingly.
569 (ctf_rollback): Likewise.
571 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
573 * ctf-create.c (ctf_add_type_internal): Hand back existing types
576 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
578 * ctf-create.c (ctf_add_forward): Don't add forwards to
579 types that already exist.
581 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
583 * ctf-open.c (init_types): Only intern root-visible types.
584 * ctf-create.c (ctf_dtd_insert): Likewise.
585 (ctf_dtd_delete): Only remove root-visible types.
586 (ctf_rollback): Likewise.
587 (ctf_add_generic): Adjust.
588 (ctf_add_struct_sized): Adjust comment.
589 (ctf_add_union_sized): Likewise.
590 (ctf_add_enum): Likewise.
591 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
593 2020-03-11 John Baldwin <jhb@FreeBSD.org>
595 * swap.h (bswap_identity_64): Make static.
597 2020-01-18 Nick Clifton <nickc@redhat.com>
599 Binutils 2.34 branch created.
601 2020-01-05 Joel Brobecker <brobecker@adacore.com>
604 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
605 * configure, config.h.in: Regenerate.
607 2020-01-01 Alan Modra <amodra@gmail.com>
609 Update year range in copyright notice of all files.
611 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
613 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
615 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
617 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
618 * ctf-types.c (ctf_type_lname): Likewise.
620 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
622 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
623 ctf_import after the first for a given file.
625 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
627 * ctf-impl.h (ctf_str_append_noerr): Declare.
628 * ctf-util.c (ctf_str_append_noerr): Define in terms of
630 * ctf-dump.c (str_append): New, call it.
631 (ctf_dump_format_type): Use str_append, not ctf_str_append.
632 (ctf_dump_label): Likewise.
633 (ctf_dump_objts): Likewise.
634 (ctf_dump_funcs): Likewise.
635 (ctf_dump_var): Likewise.
636 (ctf_dump_member): Likewise.
637 (ctf_dump_type): Likewise.
638 (ctf_dump): Likewise.
640 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
642 * ctf-impl.h (ctf_alloc): Remove.
643 (ctf_free): Likewise.
644 (ctf_strdup): Likewise.
645 * ctf-subr.c (ctf_alloc): Remove.
646 (ctf_free): Likewise.
647 * ctf-util.c (ctf_strdup): Remove.
649 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
650 ctf_free; strdup, not ctf_strdup.
651 (ctf_dtd_delete): Likewise.
652 (ctf_dvd_delete): Likewise.
653 (ctf_add_generic): Likewise.
654 (ctf_add_function): Likewise.
655 (ctf_add_enumerator): Likewise.
656 (ctf_add_member_offset): Likewise.
657 (ctf_add_variable): Likewise.
659 (ctf_compress_write): Likewise.
660 (ctf_write_mem): Likewise.
661 * ctf-decl.c (ctf_decl_push): Likewise.
662 (ctf_decl_fini): Likewise.
663 (ctf_decl_sprintf): Likewise. Check for OOM.
664 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
665 ctf_free; strdup, not ctf_strdup.
666 (ctf_dump_free): Likewise.
667 (ctf_dump): Likewise.
668 * ctf-open.c (upgrade_types_v1): Likewise.
669 (init_types): Likewise.
670 (ctf_file_close): Likewise.
671 (ctf_bufopen_internal): Likewise. Check for OOM.
672 (ctf_parent_name_set): Likewise: report the OOM to the caller.
673 (ctf_cuname_set): Likewise.
674 (ctf_import): Likewise.
675 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
676 free, not ctf_free; strdup, not ctf_strdup.
677 (ctf_str_free_atom): Likewise.
678 (ctf_str_create_atoms): Likewise.
679 (ctf_str_add_ref_internal): Likewise.
680 (ctf_str_remove_ref): Likewise.
681 (ctf_str_write_strtab): Likewise.
683 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
685 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
686 work right for non-int/fps.
688 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
690 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
693 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
695 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
696 * ctf-open.c (ctf_file_close): Free it.
697 * ctf-create.c (ctf_serialize): Adjust.
698 (membcmp): When reporting a conflict due to an error, report the
700 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
701 (ctf_add_type_internal): ... this. Hand back types we are already
702 in the middle of adding immediately. Hand back structs/unions with
703 the same number of members immediately. Do not walk the dynamic
704 list. Call ctf_add_type_internal, not ctf_add_type. Handle
705 forwards promoted to other types and the inverse case identically.
706 Add structs to the mapping as soon as we intern them, before they
709 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
711 * ctf-impl.h (ctf_names_t): New.
712 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
713 (ctf_file_t) <ctf_structs>: Likewise.
714 <ctf_unions>: Likewise.
715 <ctf_enums>: Likewise.
716 <ctf_names>: Likewise.
717 <ctf_lookups>: Improve comment.
718 <ctf_ptrtab_len>: New.
719 <ctf_prov_strtab>: New.
720 <ctf_str_prov_offset>: New.
721 <ctf_dtbyname>: Remove, redundant to the names hashes.
722 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
723 (ctf_dtdef_t) <dtd_name>: Remove.
724 <dtd_data>: Note that the ctt_name is now populated.
725 (ctf_str_atom_t) <csa_offset>: This is now the strtab
726 offset for internal strings too.
727 <csa_external_offset>: New, the external strtab offset.
728 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
729 (ctf_name_table): New declaration.
730 (ctf_lookup_by_rawname): Likewise.
731 (ctf_lookup_by_rawhash): Likewise.
732 (ctf_set_ctl_hashes): Likewise.
733 (ctf_serialize): Likewise.
734 (ctf_dtd_insert): Adjust.
735 (ctf_simple_open_internal): Likewise.
736 (ctf_bufopen_internal): Likewise.
737 (ctf_list_empty_p): Likewise.
738 (ctf_str_remove_ref): Likewise.
739 (ctf_str_add): Returns uint32_t now.
740 (ctf_str_add_ref): Likewise.
741 (ctf_str_add_external): Now returns a boolean (int).
742 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
743 for strings in the appropriate range.
744 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
745 when adding the null string to the new strtab.
746 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
747 (ctf_str_add_ref_internal): Add make_provisional argument. If
748 make_provisional, populate the offset and fill in the
749 ctf_prov_strtab accordingly.
750 (ctf_str_add): Return the offset, not the string.
751 (ctf_str_add_ref): Likewise.
752 (ctf_str_add_external): Return a success integer.
753 (ctf_str_remove_ref): New, remove a single ref.
754 (ctf_str_count_strtab): Do not count the initial null string's
755 length or the existence or length of any unreferenced internal
757 (ctf_str_populate_sorttab): Skip atoms with no refs.
758 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
759 to the cts_len for the null string, since it is no longer done
760 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
761 Populate the csa_offset for both internal and external cases.
762 Flush the ctf_prov_strtab afterwards, and reset the
764 * ctf-create.c (ctf_grow_ptrtab): New.
765 (ctf_create): Call it. Initialize new fields rather than old
766 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
767 Set the ctl hashes and data model.
768 (ctf_update): Rename to...
769 (ctf_serialize): ... this. Leave a compatibility function behind.
770 Tell ctf_simple_open_internal that this is a writable dictionary.
771 Pass the new fields along from the old dictionary. Drop
772 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
773 Do not zero out the DTD's ctt_name.
774 (ctf_prefixed_name): Rename to...
775 (ctf_name_table): ... this. No longer return a prefixed name: return
776 the applicable name table instead.
777 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
778 kind we're adding. Migrate away from dtd_name.
779 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
781 (ctf_dtd_lookup_type_by_name): Remove.
782 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
783 No longer check ctf_dtnextid: check ctf_typemax instead.
784 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
785 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
786 ctf_name_table and the right name table, and migrate away from
787 dtd_name as in ctf_dtd_delete.
788 (ctf_add_generic): Pass in the kind explicitly and pass it to
789 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
790 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
791 Grow the ptrtab if needed.
792 (ctf_add_encoded): Pass in the kind.
793 (ctf_add_slice): Likewise.
794 (ctf_add_array): Likewise.
795 (ctf_add_function): Likewise.
796 (ctf_add_typedef): Likewise.
797 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
798 ctt_name rather than dtd_name.
799 (ctf_add_struct_sized): Pass in the kind. Use
800 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
801 ctf_dtd_lookup_type_by_name.
802 (ctf_add_union_sized): Likewise.
803 (ctf_add_enum): Likewise.
804 (ctf_add_enum_encoded): Likewise.
805 (ctf_add_forward): Likewise.
806 (ctf_add_type): Likewise.
807 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
808 being initialized until after the call.
809 (ctf_write_mem): Likewise.
810 (ctf_write): Likewise.
811 * ctf-archive.c (arc_write_one_ctf): Likewise.
812 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
813 ctf_hash_lookup_type.
814 (ctf_lookup_by_id): No longer check the readonly types if the
815 dictionary is writable.
816 * ctf-open.c (init_types): Assert that this dictionary is not
817 writable. Adjust to use the new name hashes, ctf_name_table,
818 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
819 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
820 if set. Drop out early when dictionary is writable. Split the
821 ctf_lookups initialization into...
822 (ctf_set_cth_hashes): ... this new function.
823 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
824 (ctf_simple_open): Adjust accordingly.
825 (ctf_bufopen): Likewise.
826 (ctf_file_close): Destroy the appropriate name hashes. No longer
827 destroy ctf_dtbyname, which is gone.
828 (ctf_getdatasect): Remove spurious "extern".
829 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
830 specified name table, given a kind.
831 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
832 (ctf_member_iter): Add support for iterating over the
834 (ctf_enum_iter): Likewise.
835 (ctf_variable_iter): Likewise.
836 (ctf_type_rvisit): Likewise.
837 (ctf_member_info): Add support for types in the dynamic type list.
838 (ctf_enum_name): Likewise.
839 (ctf_enum_value): Likewise.
840 (ctf_func_type_info): Likewise.
841 (ctf_func_type_args): Likewise.
842 * ctf-link.c (ctf_accumulate_archive_names): No longer call
844 (ctf_link_write): Likewise.
845 (ctf_link_intern_extern_string): Adjust for new
846 ctf_str_add_external return value.
847 (ctf_link_add_strtab): Likewise.
848 * ctf-util.c (ctf_list_empty_p): New.
850 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
852 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
854 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
856 (ctf_add_variable): Likewise for variables pointing to them.
857 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
858 type link failure, but do warn for others.
859 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
861 (ctf_dump_member): Likewise.
862 (ctf_dump_type): Likewise.
863 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
864 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
865 (ctf_dump_header): Likewise.
866 (ctf_dump_label): likewise.
867 (ctf_dump_objts): likewise.
868 (ctf_dump_funcs): likewise.
869 (ctf_dump_var): likewise.
870 (ctf_dump_str): Likewise.
872 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
874 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
876 (AM_INSTALL_LIBBFD): Likewise.
877 (dlopen): Note why this is necessary in a comment.
878 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
880 (SHARED_LDFLAGS): Likewise.
881 (BFD_LIBADD): Likewise, for libbfd.
882 (BFD_DEPENDENCIES): Likewise.
883 (VERSION_FLAGS): Initialize, using a version script if ld supports
884 one, or libtool -export-symbols-regex otherwise.
885 (AC_CONFIG_MACRO_DIR): Add ../BFD.
886 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
888 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
889 (noinst_LIBRARIES): Replace with...
890 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
891 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
892 libctf-nobfd.la as well.
893 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
894 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
895 (libctf_a_SOURCES): Rename to...
896 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
898 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
899 with ctf-open-bfd.c added.
900 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
901 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
902 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
903 * Makefile.am [INSTALL_LIBCTF]: Use it.
904 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
906 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
907 the unstable components).
908 * Makefile.in: Regenerated.
909 * config.h.in: Likewise.
910 * configure: Likewise.
912 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
914 * configure.ac (INSTALL_LIBCTF): New, controlled by
915 --enable-install-libctf.
916 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
917 * Makefile.in: Regenerated.
918 * configure: Regenerated.
920 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
922 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
923 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
925 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
927 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
929 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
931 * ctf-impl.h (includes): Include <sys/param.h> here.
933 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
935 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
936 (flip_objts): Likewise.
937 (flip_vars): Likewise.
938 (flip_types): Likewise.
940 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
942 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
943 freeing functions: if set, free the key and value if the slot
944 already exists. Always reassign the key.
945 (ctf_dynhash_insert): Adjust call appropriately.
946 (ctf_hash_insert_type): Likewise.
948 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
950 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
951 type kind. Allow forwards to unify with pre-existing structs/
954 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
956 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
957 <ctf_link_memb_name_changer>: Likewise.
958 <ctf_link_memb_name_changer_arg>: Likewise.
959 * ctf-create.c (ctf_update): Update accordingly.
960 * ctf-open.c (ctf_file_close): Likewise.
961 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
962 (ctf_link_add_cu_mapping): New.
963 (ctf_link_set_memb_name_changer): Likewise.
964 (ctf_change_parent_name): New.
965 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
966 allocated by the caller's ctf_link_memb_name_changer.
967 <ndynames>: Likewise.
968 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
969 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
970 ctf_change_parent_name. Free any resulting names.
972 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
974 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
975 (ctf_link_one_type): ... here, with parent-name setting added.
976 (check_variable): New.
977 (ctf_link_one_variable): Likewise.
978 (ctf_link_one_input_archive_member): Call it.
979 * ctf-error.c (_ctf_errlist): Updated with new errors.
981 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
983 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
984 (struct ctf_link_type_mapping_key): New.
985 (ctf_hash_type_mapping_key): Likewise.
986 (ctf_hash_eq_type_mapping_key): Likewise.
987 (ctf_add_type_mapping): Likewise.
988 (ctf_type_mapping): Likewise.
989 (ctf_dynhash_empty): Likewise.
990 * ctf-open.c (ctf_file_close): Update accordingly.
991 * ctf-create.c (ctf_update): Likewise.
992 (ctf_add_type): Populate the mapping.
993 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
994 (ctf_hash_eq_type_mapping_key): Check the key for equality.
995 (ctf_dynhash_insert): Fix comment typo.
996 (ctf_dynhash_empty): New.
997 * ctf-link.c (ctf_add_type_mapping): New.
998 (ctf_type_mapping): Likewise.
999 (empty_link_type_mapping): New.
1000 (ctf_link_one_input_archive): Call it.
1002 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1004 * ctf-link.c: New file, linking of the string and type sections.
1005 * Makefile.am (libctf_a_SOURCES): Add it.
1006 * Makefile.in: Regenerate.
1008 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1010 * ctf-create.c (ctf_update): Update accordingly.
1011 * ctf-open.c (ctf_file_close): Likewise.
1012 * ctf-error.c (_ctf_errlist): Updated with new errors.
1014 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1016 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1018 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1020 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1022 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1023 (ctf_dump_format_type): Add non-root-type { } notation.
1024 Add root flag to prototype.
1025 (ctf_dump_label): Adjust accordingly.
1026 (ctf_dump_objts): Likewise.
1027 (ctf_dump_var): Likewise.
1029 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1031 * ctf-create.c (ctf_compress_write): Fix double-free.
1033 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1035 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1037 (ctf_arc_write_fd): ... this new function.
1038 * ctf-create.c (ctf_write_mem): New.
1040 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1042 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1043 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1044 (ctf_str_add_ref): Name the last arg.
1045 (ctf_str_add_external) New.
1046 (ctf_str_add_strraw_explicit): Likewise.
1047 (ctf_simple_open_internal): Likewise.
1048 (ctf_bufopen_internal): Likewise.
1050 * ctf-string.c (ctf_strraw_explicit): Split from...
1051 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1052 (ctf_str_add_ref_internal): Return the atom, not the
1054 (ctf_str_add): Adjust accordingly.
1055 (ctf_str_add_ref): Likewise. Move up in the file.
1056 (ctf_str_add_external): New: update the csa_offset.
1057 (ctf_str_count_strtab): Only account for strings with no csa_offset
1058 in the internal strtab length.
1059 (ctf_str_write_strtab): If the csa_offset is set, update the
1060 string's refs without writing the string out, and update the
1061 ctf_syn_ext_strtab. Make OOM handling less ugly.
1062 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1063 (ctf_update): Handle failure to populate the strtab. Pass in the
1064 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1065 Call ctf_simple_open_internal, not ctf_simple_open.
1066 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1068 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1069 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1070 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1071 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1072 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1073 (ctf_simple_open_internal): ... this new function, which calls
1074 ctf_bufopen_internal.
1075 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1076 (ctf_bufopen_internal): ... this new function, which sets
1079 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1081 * ctf_types.c (ctf_type_iter_all): New.
1083 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1085 * ctf-open.c (init_symtab): Check for overflow against the right
1087 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1088 (upgrade_types_v1): Note that these sections are not checked.
1089 (flip_header): Endian-swap the header fields.
1090 (flip_ctf): Endian-swap the sections.
1091 (flip_objts): Update comment.
1092 (ctf_bufopen): Check header offsets and alignment for validity.
1094 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1096 * ctf-open-bfd.c: Add <assert.h>.
1097 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1098 techniques borrowed from bfd_elf_sym_name.
1099 (ctf_new_archive_internal): Improve comment.
1100 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1101 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1102 no symbol section, but not vice versa.
1104 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1106 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1107 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1108 * ctf-dump.c (dump_header): New function, dump the CTF header.
1109 (ctf_dump): Call it.
1110 (ctf_dump_header_strfield): New function.
1111 (ctf_dump_header_sectfield): Likewise.
1113 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1115 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1116 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1117 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1118 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1119 Print out ctf_cuname: only print out ctf_parname if set.
1120 (ctf_free_base): Removed, ctf_base is no longer freed: free
1121 ctf_dynbase instead.
1122 (ctf_set_version): Fix spacing.
1123 (upgrade_header): New, in-place header upgrading.
1124 (upgrade_types): Rename to...
1125 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1126 longer track old and new headers separately. No longer allow for
1127 header sizes explicitly: squeeze the headers out on upgrade (they
1128 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1129 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1130 (upgrade_types): New, also handle ctf_parmax updating.
1131 (flip_header): Flip ctf_cuname.
1132 (flip_types): Flip BUF explicitly rather than deriving BUF from
1134 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1135 required alignment of objtoff and funcoff. No longer store it in
1136 the ctf_buf unless that buf is derived unmodified from the input.
1137 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1138 that duplicate fields in ctf_file: move allocation of ctf_file
1139 further up instead. Call upgrade_header as needed. Move
1140 version-specific ctf_parmax initialization into upgrade_types. More
1141 concise error handling.
1142 (ctf_file_close): No longer test for null pointers before freeing.
1143 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1146 (ctf_cuname_set): New.
1147 * ctf-create.c (ctf_update): Populate ctf_cuname.
1148 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1150 (ctf_write): Likewise.
1151 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1152 Fix the compression length: fp->ctf_size never counted the CTF
1153 header. Simplify the compress call accordingly.
1155 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1157 * ctf-endian.h: Don't assume htole64 and le64toh are always
1158 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1159 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1160 not bswap_identity_64.
1162 2019-09-18 Alan Modra <amodra@gmail.com>
1164 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1166 2019-09-09 Phil Blundell <pb@pbcl.net>
1168 binutils 2.33 branch created.
1170 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1172 * ctf-types.c (ctf_type_aname_raw): New.
1173 (ctf_func_type_info): Likewise.
1174 (ctf_func_type_args): Likewise.
1175 * ctf-error.c (_ctf_errlist): Fix description.
1176 * ctf-lookup.c: Fix file description.
1178 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1180 * ctf-create.c (ctf_create): Fix off-by-one error.
1182 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1184 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1186 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1187 (struct ctf_str_atom): New, disambiguated single string.
1188 (struct ctf_str_atom_ref): New, points to some other location that
1189 references this string's offset.
1190 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1191 Remove member ctf_dtvstrlen: we no longer track the total strlen
1193 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1194 (ctf_str_free_atoms): Likewise.
1195 (ctf_str_add): Likewise.
1196 (ctf_str_add_ref): Likewise.
1197 (ctf_str_rollback): Likewise.
1198 (ctf_str_purge_refs): Likewise.
1199 (ctf_str_write_strtab): Likewise.
1200 (ctf_realloc): Declare new function in ctf-util.c.
1202 * ctf-open.c (ctf_bufopen): Create the atoms table.
1203 (ctf_file_close): Destroy it.
1204 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1205 special-case the position of the parname string. Construct the
1206 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1207 rest of each buffer element is constructed, not via open-coding:
1208 realloc the CTF buffer and append the strtab to it. No longer
1209 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1210 strtab construction.
1211 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1212 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1213 after buffer element construction instead.
1214 (ctf_copy_lmembers): Likewise.
1215 (ctf_copy_emembers): Likewise.
1216 (ctf_create): No longer maintain the ctf_dtvstrlen.
1217 (ctf_dtd_delete): Likewise.
1218 (ctf_dvd_delete): Likewise.
1219 (ctf_add_generic): Likewise.
1220 (ctf_add_enumerator): Likewise.
1221 (ctf_add_member_offset): Likewise.
1222 (ctf_add_variable): Likewise.
1223 (membadd): Likewise.
1224 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1225 if there are active ctf_str_num_refs.
1226 (ctf_strraw): Move to ctf-string.c.
1227 (ctf_strptr): Likewise.
1228 * ctf-string.c: New file, strtab manipulation.
1230 * Makefile.am (libctf_a_SOURCES): Add it.
1231 * Makefile.in: Regenerate.
1233 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1235 * ctf-impl.h (ctf_hash_iter_f): New.
1236 (ctf_dynhash_iter): New declaration.
1237 (ctf_dynhash_iter_remove): New declaration.
1238 * ctf-hash.c (ctf_dynhash_iter): Define.
1239 (ctf_dynhash_iter_remove): Likewise.
1240 (ctf_hashtab_traverse): New.
1241 (ctf_hashtab_traverse_remove): Likewise.
1242 (struct ctf_traverse_cb_arg): Likewise.
1243 (struct ctf_traverse_remove_cb_arg): Likewise.
1245 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1247 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1249 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1251 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1252 (ctf_dump_funcs): Likewise.
1254 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1256 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1257 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1258 little-endian CTF archive magic. Do not check the CTF version:
1259 ctf_simple_open does that in endian-safe ways. Do not dereference
1260 null pointers on open failure.
1262 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1264 * ctf-open.c (get_vbytes_common): Return the new slice size.
1265 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1266 Remember to copy in the CTF data when opening an uncompressed
1267 foreign-endian CTF file. Prune useless variable manipulation.
1269 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1271 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1274 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1276 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1279 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1281 * ctf-subr.c (_PAGESIZE): Remove.
1282 (ctf_data_alloc): Likewise.
1283 (ctf_data_free): Likewise.
1284 (ctf_data_protect): Likewise.
1285 * ctf-impl.h: Remove declarations.
1286 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1287 ctf_free, not ctf_data_free.
1288 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1289 the buffer again on compression error.
1290 * ctf-open.c (ctf_set_base): No longer track the size: call
1291 ctf_free, not ctf_data_free.
1292 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1293 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1295 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1297 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1299 (ctf_dvd_insert): Likewise.
1300 (ctf_add_generic): Likewise.
1301 (ctf_add_variable): Likewise.
1302 * ctf-impl.h: Adjust declarations.
1304 2019-06-14 Alan Modra <amodra@gmail.com>
1306 * configure: Regenerate.
1308 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1310 * ctf-decls.h: Include <libiberty.h>.
1311 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1313 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1315 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1316 (ctf_dump_objts): Likewise.
1317 (ctf_dump_funcs): Likewise.
1318 (ctf_dump_member): Likewise.
1319 (ctf_dump_str): Likewise.
1321 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1323 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1324 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1326 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1328 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1329 (ctf_arc_open_by_offset): Likewise.
1330 * ctf-create.c (ctf_add_type): Likewise.
1332 2019-06-04 Tom Tromey <tromey@adacore.com>
1334 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1335 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1337 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1339 * configure.ac: Check for O_CLOEXEC.
1340 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1341 * config.h.in: Regenerate.
1342 * configure: Likewise.
1344 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1346 * qsort_r.c: Rename to...
1347 * ctf-qsort_r.c: ... this.
1348 (_quicksort): Define to ctf_qsort_r.
1349 * ctf-decls.h (qsort_r): Remove.
1351 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1352 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1353 * Makefile.am (libctf_a_LIBADD): Remove.
1354 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1355 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1356 * ctf-create.c (ctf_update): Likewise.
1357 * configure.ac: Check for BSD versus GNU qsort_r signature.
1358 * Makefile.in: Regenerate.
1359 * config.h.in: Likewise.
1360 * configure: Likewise.
1362 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1364 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1366 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1368 * Makefile.am (ZLIB): New.
1369 (ZLIBINC): Likewise.
1370 (AM_CFLAGS): Use them.
1371 (libctf_a_LIBADD): New, for LIBOBJS.
1372 * configure.ac: Check for zlib, endian.h, and qsort_r.
1373 * ctf-endian.h: New, providing htole64 and le64toh.
1374 * swap.h: Code style fixes.
1375 (bswap_identity_64): New.
1376 * qsort_r.c: New, from gnulib (with one added #include).
1377 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1378 and unconditional definitions of MIN and MAX.
1379 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1380 (ctf_set_errno): Now returns unsigned long.
1381 * ctf-util.c (ctf_set_errno): Adjust here too.
1382 * ctf-archive.c: Use ctf-endian.h.
1383 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1384 cts_flags and cts_offset.
1385 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1386 * ctf-create.c: Provide a definition of roundup if not defined.
1387 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1388 (ctf_add_reftype): Do not check if type IDs are below zero.
1389 (ctf_add_slice): Likewise.
1390 (ctf_add_typedef): Likewise.
1391 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1392 when known error-free. Drop CTF_ERR usage for functions returning
1394 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1396 (ctf_add_variable): Likewise.
1397 (enumcmp): Likewise.
1398 (enumadd): Likewise.
1399 (membcmp): Likewise.
1400 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1401 when known error-free.
1402 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1403 returning int: use CTF_ERR for functions returning ctf_type_id.
1404 (ctf_dump_label): Likewise.
1405 (ctf_dump_objts): Likewise.
1406 * ctf-labels.c (ctf_label_topmost): Likewise.
1407 (ctf_label_iter): Likewise.
1408 (ctf_label_info): Likewise.
1409 * ctf-lookup.c (ctf_func_args): Likewise.
1410 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1411 (ctf_bufopen): Likewise. Use zlib types as needed.
1412 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1414 (ctf_enum_iter): Likewise.
1415 (ctf_type_size): Likewise.
1416 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1417 (ctf_type_kind_unsliced): Likewise.
1418 (ctf_type_kind): Likewise.
1419 (ctf_type_encoding): Likewise.
1420 (ctf_member_info): Likewise.
1421 (ctf_array_info): Likewise.
1422 (ctf_enum_value): Likewise.
1423 (ctf_type_rvisit): Likewise.
1424 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1426 (ctf_simple_open): Likewise.
1427 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1428 * Makefile.in: Regenerate.
1429 * aclocal.m4: Likewise.
1430 * config.h: Likewise.
1431 * configure: Likewise.
1433 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1435 * configure.in: Check for bfd_section_from_elf_index.
1436 * configure: Regenerate.
1437 * config.h.in [HAVE_BFD_ELF]: Likewise.
1438 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1439 abfd is potentially unused now.
1441 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1444 * Makefile.in: Regenerated.
1445 * config.h.in: Likewise.
1446 * aclocal.m4: Likewise.
1447 * configure: Likewise.
1449 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1453 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1455 * ctf-labels.c: New.
1457 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1459 * ctf-impl.h (_libctf_version): New declaration.
1460 * ctf-subr.c (_libctf_version): Define it.
1463 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1465 * ctf-create.c (enumcmp): New.
1466 (enumadd): Likewise.
1467 (membcmp): Likewise.
1468 (membadd): Likewise.
1469 (ctf_add_type): Likewise.
1471 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1473 * ctf-lookup.c (isqualifier): New.
1474 (ctf_lookup_by_name): Likewise.
1475 (struct ctf_lookup_var_key): Likewise.
1476 (ctf_lookup_var): Likewise.
1477 (ctf_lookup_variable): Likewise.
1478 (ctf_lookup_symbol_name): Likewise.
1479 (ctf_lookup_by_symbol): Likewise.
1480 (ctf_func_info): Likewise.
1481 (ctf_func_args): Likewise.
1483 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1485 * ctf-decl.c: New file.
1486 * ctf-types.c: Likewise.
1487 * ctf-impl.h: New declarations.
1489 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1491 * ctf-open-bfd.c: New file.
1492 * ctf-open.c (ctf_close): New.
1493 * ctf-impl.h: Include bfd.h.
1494 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1495 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1497 (ctf_bfdopen_ctfsect): New declaration.
1498 (_CTF_SECTION): likewise.
1500 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1502 * ctf-archive.c: New.
1503 * ctf-impl.h (ctf_archive_internal): New type.
1504 (ctf_arc_open_internal): New declaration.
1505 (ctf_arc_bufopen): Likewise.
1506 (ctf_arc_close_internal): Likewise.
1508 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1510 * ctf-open.c: New file.
1513 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1515 * ctf-create.c: New file.
1516 * ctf-lookup.c: New file.
1518 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1520 * ctf-impl.h: New definitions and declarations for type creation
1523 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1525 * ctf-hash.c: New file.
1526 * ctf-impl.h: New declarations.
1528 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1530 * ctf-error.c: New file.
1532 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1534 * ctf-util.c: New file.
1536 * ctf-impl.h: Include it, and add declarations.
1538 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1540 * ctf-impl.h: New file.
1541 * ctf-subr.c: New file.
1548 version-control: never