1 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
4 (ctf_dtd_delete): Likewise.
5 (ctf_dtd_lookup): Likewise.
6 (ctf_rollback): Likewise.
7 * ctf-hash.c (ctf_hash_lookup_type): Likewise.
8 * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
10 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
12 * ctf-lookup.c (ctf_lookup_by_name): Adjust.
14 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
16 * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
19 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
21 * ctf-impl.h (ctf_list_splice): New.
22 * ctf-util.h (ctf_list_splice): Likewise.
23 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
24 (ctf_link_sort_inputs): Likewise.
25 (ctf_link_deduplicating_count_inputs): Likewise.
26 (ctf_link_deduplicating_open_inputs): Likewise.
27 (ctf_link_deduplicating_close_inputs): Likewise.
28 (ctf_link_deduplicating_variables): Likewise.
29 (ctf_link_deduplicating_per_cu): Likewise.
30 (ctf_link_deduplicating): Likewise.
33 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
35 * ctf-link.c (ctf_link_one_input_archive_member): Check
36 CTF_LINK_OMIT_VARIABLES_SECTION.
38 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
40 * ctf-impl.h (ctf_type_id_key): New, the key in the
42 (ctf_dedup): New, core deduplicator state.
43 (ctf_file_t) <ctf_dedup>: New.
44 <ctf_dedup_atoms>: New.
45 <ctf_dedup_atoms_alloc>: New.
46 (ctf_hash_type_id_key): New prototype.
47 (ctf_hash_eq_type_id_key): Likewise.
48 (ctf_dedup_atoms_init): Likewise.
49 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
50 (ctf_dedup_atoms_init): Likewise.
51 * ctf-create.c (ctf_serialize): Adjusted.
52 (ctf_add_encoded): No longer static.
53 (ctf_add_reftype): Likewise.
54 * ctf-open.c (ctf_file_close): Destroy the
55 ctf_dedup_atoms_alloc.
56 * ctf-dedup.c: New file.
57 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
58 * configure.ac: Check for stpcpy.
59 * Makefile.am: Add it.
60 * Makefile.in: Regenerate.
61 * config.h.in: Regenerate.
62 * configure: Regenerate.
64 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
66 * configure.ac: Add --enable-libctf-hash-debugging.
67 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
68 * Makefile.in: Regenerated.
69 * configure: Likewise.
70 * config.h.in: Likewise.
71 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
72 (ctf_assert): Define to assert.
74 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
76 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
78 * ctf-impl.h: Include it.
80 (ctf_sha1_add): Likewise.
81 (ctf_sha1_fini): Likewise.
82 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
84 * Makefile.am: Add file.
85 * Makefile.in: Regenerate.
87 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
89 * libctf.ver (ctf_link_set_variable_filter): Add.
90 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
91 <ctf_link_variable_filter_arg>: Likewise.
92 * ctf-create.c (ctf_serialize): Adjust.
93 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
94 (ctf_link_one_variable): Call it if set.
96 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
98 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
99 conflicts, not the source type.
101 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
103 * ctf-impl.h (ctf_file_t): Improve comments.
104 <ctf_link_cu_mapping>: Split into...
105 <ctf_link_in_cu_mapping>: ... this...
106 <ctf_link_out_cu_mapping>: ... and this.
107 * ctf-create.c (ctf_serialize): Adjust.
108 * ctf-open.c (ctf_file_close): Likewise.
109 * ctf-link.c (ctf_create_per_cu): Look things up in the
110 in_cu_mapping instead of the cu_mapping.
111 (ctf_link_add_cu_mapping): The deduplicating link will define
112 what happens if many FROMs share a TO.
113 (ctf_link_add_cu_mapping): Create in_cu_mapping and
114 out_cu_mapping. Do not create ctf_link_outputs here any more, or
115 create per-CU dicts here: they are already created when needed.
116 (ctf_link_one_variable): Log a debug message if we skip a
117 variable due to its type being concealed in a CU-mapped link.
118 (This is probably too common a case to make into a warning.)
119 (ctf_link): Create empty per-CU dicts if requested.
121 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
123 * ctf-link.c (ctf_link_write): Close the fd.
125 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
127 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
128 * Makefile.in: Regenerated.
129 * ctf-impl.h (ctf_link_input_name): New.
130 (ctf_file_t) <ctf_link_flags>: New.
131 * ctf-create.c (ctf_serialize): Adjust accordingly.
132 * ctf-link.c: Define ctf_open as weak when PIC.
133 (ctf_arc_close_thunk): Remove unnecessary thunk.
134 (ctf_file_close_thunk): Likewise.
135 (ctf_link_input_name): New.
136 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
137 (ctf_link_input_close): Adjust accordingly.
138 (ctf_link_add_ctf_internal): New, split from...
139 (ctf_link_add_ctf): ... here. Return error if lazy loading of
140 CTF is not possible. Change to just call...
141 (ctf_link_add): ... this new function.
142 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
143 ctf_file_close_thunk.
144 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
145 <in_file_name>: ... this.
147 <share_mode>: Likewise (migrated to ctf_link_flags).
148 <done_main_member>: Rename to...
149 <done_parent>: ... this.
150 <main_input_fp>: Rename to...
151 <in_fp_parent>: ... this.
153 (ctf_link_one_type): Adjuwt accordingly. Transition to
154 ctf_err_warn, removing a TODO.
155 (ctf_link_one_variable): Note a case too common to warn about.
156 Report in the debug stream if a cu-mapped link prevents addition
157 of a conflicting variable.
158 (ctf_link_one_input_archive_member): Adjust.
159 (ctf_link_lazy_open): New, open a CTF archive for linking when
161 (ctf_link_close_one_input_archive): New, close it again.
162 (ctf_link_one_input_archive): Adjust for lazy opening, member
163 renames, and ctf_err_warn transition. Move the
164 empty_link_type_mapping call to...
165 (ctf_link): ... here. Adjut for renamings and thunk removal.
166 Don't spuriously fail if some input contains no CTF data.
167 (ctf_link_write): ctf_err_warn transition.
168 * libctf.ver: Remove not-yet-stable comment.
170 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
172 * ctf-impl.h (ctf_strerror): Delete.
173 * ctf-subr.c (ctf_strerror): Likewise.
174 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
177 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
179 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
180 (ctf_import_unref): New.
181 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
182 zero. Don't recurse back in if the refcount is already zero.
183 (ctf_import): Check ctf_parent_unreffed before deciding whether
184 to close a pre-existing parent. Set it to zero.
185 (ctf_import_unreffed): New, as above, setting
186 ctf_parent_unreffed to 1.
187 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
188 child: use direct assignment, and set unreffed on the new and
190 * ctf-link.c (ctf_create_per_cu): Import the parent using
193 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
195 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
196 (ctf_link_type_key): ... this, adjusting member prefixes to
198 (ctf_hash_type_mapping_key): Rename to...
199 (ctf_hash_type_key): ... this.
200 (ctf_hash_eq_type_mapping_key): Rename to...
201 (ctf_hash_eq_type_key): ... this.
202 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
203 (ctf_hash_type_key): ... this, and adjust for member name
205 (ctf_hash_eq_type_mapping_key): Rename to...
206 (ctf_hash_eq_type_key): ... this, and adjust for member name
208 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
209 need for out-of-memory checking in this code.
210 (ctf_type_mapping): Adjust.
212 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
214 configure.ac: Check for vasprintf.
215 configure: Regenerated.
216 config.h.in: Likewise.
218 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
220 * ctf-archive.c (ctf_arc_bufopen): Fix message.
222 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
224 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
226 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
227 if the input has no symtab, rather than dividing by
228 zero. Arrange to free it later via ctfi_free_ctfsect.
229 * ctf-archive.c (ctf_new_archive_internal): Do not
230 ctfi_free_strsect by default.
231 (ctf_arc_close): Possibly free it here.
233 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
235 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
236 (ctf_dump_format_type): improve slice formatting. Always print
237 the type size, even of slices.
238 (ctf_dump_member): Print slices (-> bitfields) differently from
239 non-slices. Failure to format a type is not an OOM.
241 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
243 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
244 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
245 (ctf_dump_objts): Likewise.
246 (ctf_dump_var): Likewise.
247 (ctf_dump_type): Do not emit a duplicate message. Move to
248 ctf_err_warning, and swallow all errors.
250 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
252 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
253 (ctf_decl_buf): Once it escapes, don't try to free it later.
255 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
257 * ctf-types.c (ctf_type_aname): Print arg types here...
258 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
259 in the type name here.
261 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
263 * ctf-impl.h (ctf_assert): New.
264 (ctf_err_warning_t): Likewise.
265 (ctf_file_t) <ctf_errs_warnings>: Likewise.
266 (ctf_err_warn): New prototype.
267 (ctf_assert_fail_internal): Likewise.
268 * ctf-inlines.h (ctf_assert_internal): Likewise.
269 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
270 * ctf-create.c (ctf_serialize): Copy it on serialization.
271 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
272 (ctf_errwarning_next): New iterator, free and pass back
273 errors/warnings in succession.
274 * libctf.ver (ctf_errwarning_next): Add.
276 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
278 * ctf-types.c (ctf_variable_iter): Fix error return.
280 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
282 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
284 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
286 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
288 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
290 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
292 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
293 ctf_dynhash_next_sorted.
294 <cu.ctn_h>: New, pointer to the dynhash under iteration.
295 <cu.ctn_s>: New, pointer to the dynset under iteration.
296 (ctf_hash_sort_f): Sorting function passed to...
297 (ctf_dynhash_next_sorted): ... this new function.
298 (ctf_dynhash_next): New.
299 (ctf_dynset_next): New.
300 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
301 (ctf_dynhash_cnext): New.
302 (ctf_dynset_cnext): New.
303 * ctf-hash.c (ctf_dynhash_next_sorted): New.
304 (ctf_dynhash_next): New.
305 (ctf_dynset_next): New.
306 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
308 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
310 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
312 * ctf-impl.h (ctf_next): New.
313 (ctf_get_dict): New prototype.
314 * ctf-lookup.c (ctf_get_dict): New, split out of...
315 (ctf_lookup_by_id): ... here.
316 * ctf-util.c (ctf_next_create): New.
317 (ctf_next_destroy): New.
318 (ctf_next_copy): New.
319 * ctf-types.c (includes): Add <assert.h>.
320 (ctf_member_next): New.
321 (ctf_enum_next): New.
322 (ctf_type_iter): Document the lack of iteration over parent
324 (ctf_type_next): New.
325 (ctf_variable_next): New.
326 * ctf-archive.c (ctf_archive_next): New.
327 * libctf.ver: Add new public functions.
329 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
331 * libctf.ver (ctf_ref): New.
332 * ctf-open.c (ctf_ref): Implement it.
334 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
336 * ctf-inlines.h (ctf_forwardable_kind): New.
337 * ctf-create.c (ctf_add_forward): Use it.
339 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
341 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
342 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
344 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
346 * ctf-hash.c (ctf_dynset_eq_string): New.
347 (ctf_dynset_create): New.
348 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
349 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
350 (key_to_internal): New.
351 (internal_to_key): New.
352 (ctf_dynset_insert): New.
353 (ctf_dynset_remove): New.
354 (ctf_dynset_destroy): New.
355 (ctf_dynset_lookup): New.
356 (ctf_dynset_exists): New.
357 (ctf_dynset_lookup_any): New.
358 (ctf_hash_insert_type): Coding style.
359 (ctf_hash_define_type): Likewise.
360 * ctf-impl.h (ctf_dynset_t): New.
361 (ctf_dynset_eq_string): New.
362 (ctf_dynset_create): New.
363 (ctf_dynset_insert): New.
364 (ctf_dynset_remove): New.
365 (ctf_dynset_destroy): New.
366 (ctf_dynset_lookup): New.
367 (ctf_dynset_exists): New.
368 (ctf_dynset_lookup_any): New.
369 * ctf-inlines.h (ctf_dynset_cinsert): New.
371 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
373 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
374 <value_free>: Likewise.
376 (ctf_dynhash_item_free): Indirect through the owner.
377 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
378 allocate space for the key_free and value_free fields fields
380 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
381 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
382 value_free if they will exist. Set the slot's owner, but only
384 (ctf_dynhash_remove): Adjust.
386 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
388 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
389 there is a key-freeing function and the key already exists.
391 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
393 * ctf-inlines.h: New file.
394 * ctf-impl.h: Include it.
395 (ctf_hash_iter_find_f): New typedef.
396 (ctf_dynhash_elements): New.
397 (ctf_dynhash_lookup_kv): New.
398 (ctf_dynhash_iter_find): New.
399 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
400 (ctf_traverse_find_cb_arg_t): New.
401 (ctf_hashtab_traverse_find): New.
402 (ctf_dynhash_iter_find): New.
403 (ctf_dynhash_elements): New.
405 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
407 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
409 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
411 * ctf-archive.c (ctf_archive_count): New.
412 * libctf.ver: New public function.
414 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
416 * ctf-types.c (ctf_member_count): New.
417 * libctf.ver: New public function.
419 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
421 * ctf-types.c (ctf_type_kind_forwarded): New.
423 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
425 * ctf-types.c (ctf_type_name_raw): New.
426 (ctf_type_aname_raw): Reimplement accordingly.
428 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
430 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
432 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
434 * ctf-impl.h (struct ctf_archive_internal)
435 <ctfi_unmap_on_close>: New.
436 (ctf_new_archive_internal): Adjust.
437 * ctf-archive.c (ctf_new_archive_internal): Likewise.
438 Initialize ctfi_unmap_on_close. Adjust error path.
439 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
440 (unmap_on_close is 0).
441 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
442 * ctf-open-bfd.c (ctf_fdopen): Adjust.
444 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
446 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
447 ints, floats or typedefs have no name. Fix comment typo.
449 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
451 * ctf-create.c (ctf_add_slice): Support slices of any kind that
452 resolves to an integral type.
453 * ctf-types.c (ctf_type_encoding): Resolve the type before
454 fishing its encoding out.
456 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
458 * ctf-create.c (ctf_create): Mark dirty.
460 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
462 * ctf-create.c (membcmp) Skip nameless members.
464 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
466 * ctf-create.c (ctf_add_member_offset): Support names of ""
467 as if they were the null pointer.
469 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
471 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
474 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
476 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
478 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
480 * ctf-create.c (ctf_serialize): Add cast.
481 (ctf_add_slice): Likewise.
483 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
485 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
486 * ctf-create.c (ctf_add_function): Check for unimplemented type
487 and populate at the same time. Populate one-by-one, not via
489 (ctf_serialize): Remove unnecessary cast.
490 * ctf-types.c (ctf_func_type_info): Likewise.
491 (ctf_func_type_args): Likewise. Fix comment typo.
493 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
495 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
496 (ctf_add_array): Support array contents of type zero.
497 (ctf_add_function): Support arguments and return types of
499 (ctf_add_typedef): Support typedefs to type zero.
500 (ctf_add_member_offset): Support members of type zero,
501 unless added at unspecified (naturally-aligned) offset.
503 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
505 * ctf-error.c: Include <stddef.h>, for offsetof.
506 (_ctf_errlist): Migrate to...
507 (_ctf_errlist_t): ... this.
508 (_ctf_erridx): New, indexes into _ctf_errlist_t.
510 (ctf_errmsg): Adjust accordingly.
511 * Makefile.am (BUILT_SOURCES): Note...
512 (ctf-error.h): ... this new rule.
513 * Makefile.in: Regenerate.
514 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
515 * .gitignore: New, ignore ctf-error.h.
517 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
519 * ctf-impl.h: Fix typos in comments.
521 2020-07-22 Nick Clifton <nickc@redhat.com>
523 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
524 same file descriptor.
526 2020-07-04 Nick Clifton <nickc@redhat.com>
528 Binutils 2.35 branch created.
530 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
532 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
534 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
535 * config.h.in: Regenerated.
536 * Makefile.in: Likewise.
537 * configure: Likewise.
539 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
541 * ctf-create.c: Include <unistd.h>.
542 * ctf-open-bfd.c: Likewise.
544 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
547 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
548 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
549 means this is declared.
550 (bswap_32): Likewise.
551 (bswap_64): Likewise.
552 (bswap_identity_64): Remove, unused.
553 * configure: Regenerated.
554 * config.h.in: Likewise.
556 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
559 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
560 (_libctf_unlikely_): Likewise.
561 (_libctf_unused): Likewise.
562 (_libctf_malloc_): Likewise.
564 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
567 * ctf-archive.c (search_nametbl): No longer global: declare...
568 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
569 (search_modent_by_name): Take and use ARG for the nametbl.
571 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
573 * ctf-impl.h (ctf_new_archive_internal): Declare.
574 (ctf_arc_bufopen): Remove.
575 (ctf_archive_internal) <ctfi_free_symsect>: New.
576 * ctf-archive.c (ctf_arc_close): Use it.
577 (ctf_arc_bufopen): Fuse into...
578 (ctf_new_archive_internal): ... this, moved across from...
579 * ctf-open-bfd.c: ... here.
580 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
581 * libctf.ver: Add it.
583 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
585 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
586 (ctf_dtd_delete): Remove correspondingly.
587 (ctf_rollback): Likewise.
589 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
591 * ctf-create.c (ctf_add_type_internal): Hand back existing types
594 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
596 * ctf-create.c (ctf_add_forward): Don't add forwards to
597 types that already exist.
599 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
601 * ctf-open.c (init_types): Only intern root-visible types.
602 * ctf-create.c (ctf_dtd_insert): Likewise.
603 (ctf_dtd_delete): Only remove root-visible types.
604 (ctf_rollback): Likewise.
605 (ctf_add_generic): Adjust.
606 (ctf_add_struct_sized): Adjust comment.
607 (ctf_add_union_sized): Likewise.
608 (ctf_add_enum): Likewise.
609 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
611 2020-03-11 John Baldwin <jhb@FreeBSD.org>
613 * swap.h (bswap_identity_64): Make static.
615 2020-01-18 Nick Clifton <nickc@redhat.com>
617 Binutils 2.34 branch created.
619 2020-01-05 Joel Brobecker <brobecker@adacore.com>
622 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
623 * configure, config.h.in: Regenerate.
625 2020-01-01 Alan Modra <amodra@gmail.com>
627 Update year range in copyright notice of all files.
629 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
631 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
633 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
635 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
636 * ctf-types.c (ctf_type_lname): Likewise.
638 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
640 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
641 ctf_import after the first for a given file.
643 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
645 * ctf-impl.h (ctf_str_append_noerr): Declare.
646 * ctf-util.c (ctf_str_append_noerr): Define in terms of
648 * ctf-dump.c (str_append): New, call it.
649 (ctf_dump_format_type): Use str_append, not ctf_str_append.
650 (ctf_dump_label): Likewise.
651 (ctf_dump_objts): Likewise.
652 (ctf_dump_funcs): Likewise.
653 (ctf_dump_var): Likewise.
654 (ctf_dump_member): Likewise.
655 (ctf_dump_type): Likewise.
656 (ctf_dump): Likewise.
658 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
660 * ctf-impl.h (ctf_alloc): Remove.
661 (ctf_free): Likewise.
662 (ctf_strdup): Likewise.
663 * ctf-subr.c (ctf_alloc): Remove.
664 (ctf_free): Likewise.
665 * ctf-util.c (ctf_strdup): Remove.
667 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
668 ctf_free; strdup, not ctf_strdup.
669 (ctf_dtd_delete): Likewise.
670 (ctf_dvd_delete): Likewise.
671 (ctf_add_generic): Likewise.
672 (ctf_add_function): Likewise.
673 (ctf_add_enumerator): Likewise.
674 (ctf_add_member_offset): Likewise.
675 (ctf_add_variable): Likewise.
677 (ctf_compress_write): Likewise.
678 (ctf_write_mem): Likewise.
679 * ctf-decl.c (ctf_decl_push): Likewise.
680 (ctf_decl_fini): Likewise.
681 (ctf_decl_sprintf): Likewise. Check for OOM.
682 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
683 ctf_free; strdup, not ctf_strdup.
684 (ctf_dump_free): Likewise.
685 (ctf_dump): Likewise.
686 * ctf-open.c (upgrade_types_v1): Likewise.
687 (init_types): Likewise.
688 (ctf_file_close): Likewise.
689 (ctf_bufopen_internal): Likewise. Check for OOM.
690 (ctf_parent_name_set): Likewise: report the OOM to the caller.
691 (ctf_cuname_set): Likewise.
692 (ctf_import): Likewise.
693 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
694 free, not ctf_free; strdup, not ctf_strdup.
695 (ctf_str_free_atom): Likewise.
696 (ctf_str_create_atoms): Likewise.
697 (ctf_str_add_ref_internal): Likewise.
698 (ctf_str_remove_ref): Likewise.
699 (ctf_str_write_strtab): Likewise.
701 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
703 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
704 work right for non-int/fps.
706 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
708 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
711 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
713 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
714 * ctf-open.c (ctf_file_close): Free it.
715 * ctf-create.c (ctf_serialize): Adjust.
716 (membcmp): When reporting a conflict due to an error, report the
718 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
719 (ctf_add_type_internal): ... this. Hand back types we are already
720 in the middle of adding immediately. Hand back structs/unions with
721 the same number of members immediately. Do not walk the dynamic
722 list. Call ctf_add_type_internal, not ctf_add_type. Handle
723 forwards promoted to other types and the inverse case identically.
724 Add structs to the mapping as soon as we intern them, before they
727 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
729 * ctf-impl.h (ctf_names_t): New.
730 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
731 (ctf_file_t) <ctf_structs>: Likewise.
732 <ctf_unions>: Likewise.
733 <ctf_enums>: Likewise.
734 <ctf_names>: Likewise.
735 <ctf_lookups>: Improve comment.
736 <ctf_ptrtab_len>: New.
737 <ctf_prov_strtab>: New.
738 <ctf_str_prov_offset>: New.
739 <ctf_dtbyname>: Remove, redundant to the names hashes.
740 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
741 (ctf_dtdef_t) <dtd_name>: Remove.
742 <dtd_data>: Note that the ctt_name is now populated.
743 (ctf_str_atom_t) <csa_offset>: This is now the strtab
744 offset for internal strings too.
745 <csa_external_offset>: New, the external strtab offset.
746 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
747 (ctf_name_table): New declaration.
748 (ctf_lookup_by_rawname): Likewise.
749 (ctf_lookup_by_rawhash): Likewise.
750 (ctf_set_ctl_hashes): Likewise.
751 (ctf_serialize): Likewise.
752 (ctf_dtd_insert): Adjust.
753 (ctf_simple_open_internal): Likewise.
754 (ctf_bufopen_internal): Likewise.
755 (ctf_list_empty_p): Likewise.
756 (ctf_str_remove_ref): Likewise.
757 (ctf_str_add): Returns uint32_t now.
758 (ctf_str_add_ref): Likewise.
759 (ctf_str_add_external): Now returns a boolean (int).
760 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
761 for strings in the appropriate range.
762 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
763 when adding the null string to the new strtab.
764 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
765 (ctf_str_add_ref_internal): Add make_provisional argument. If
766 make_provisional, populate the offset and fill in the
767 ctf_prov_strtab accordingly.
768 (ctf_str_add): Return the offset, not the string.
769 (ctf_str_add_ref): Likewise.
770 (ctf_str_add_external): Return a success integer.
771 (ctf_str_remove_ref): New, remove a single ref.
772 (ctf_str_count_strtab): Do not count the initial null string's
773 length or the existence or length of any unreferenced internal
775 (ctf_str_populate_sorttab): Skip atoms with no refs.
776 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
777 to the cts_len for the null string, since it is no longer done
778 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
779 Populate the csa_offset for both internal and external cases.
780 Flush the ctf_prov_strtab afterwards, and reset the
782 * ctf-create.c (ctf_grow_ptrtab): New.
783 (ctf_create): Call it. Initialize new fields rather than old
784 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
785 Set the ctl hashes and data model.
786 (ctf_update): Rename to...
787 (ctf_serialize): ... this. Leave a compatibility function behind.
788 Tell ctf_simple_open_internal that this is a writable dictionary.
789 Pass the new fields along from the old dictionary. Drop
790 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
791 Do not zero out the DTD's ctt_name.
792 (ctf_prefixed_name): Rename to...
793 (ctf_name_table): ... this. No longer return a prefixed name: return
794 the applicable name table instead.
795 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
796 kind we're adding. Migrate away from dtd_name.
797 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
799 (ctf_dtd_lookup_type_by_name): Remove.
800 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
801 No longer check ctf_dtnextid: check ctf_typemax instead.
802 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
803 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
804 ctf_name_table and the right name table, and migrate away from
805 dtd_name as in ctf_dtd_delete.
806 (ctf_add_generic): Pass in the kind explicitly and pass it to
807 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
808 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
809 Grow the ptrtab if needed.
810 (ctf_add_encoded): Pass in the kind.
811 (ctf_add_slice): Likewise.
812 (ctf_add_array): Likewise.
813 (ctf_add_function): Likewise.
814 (ctf_add_typedef): Likewise.
815 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
816 ctt_name rather than dtd_name.
817 (ctf_add_struct_sized): Pass in the kind. Use
818 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
819 ctf_dtd_lookup_type_by_name.
820 (ctf_add_union_sized): Likewise.
821 (ctf_add_enum): Likewise.
822 (ctf_add_enum_encoded): Likewise.
823 (ctf_add_forward): Likewise.
824 (ctf_add_type): Likewise.
825 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
826 being initialized until after the call.
827 (ctf_write_mem): Likewise.
828 (ctf_write): Likewise.
829 * ctf-archive.c (arc_write_one_ctf): Likewise.
830 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
831 ctf_hash_lookup_type.
832 (ctf_lookup_by_id): No longer check the readonly types if the
833 dictionary is writable.
834 * ctf-open.c (init_types): Assert that this dictionary is not
835 writable. Adjust to use the new name hashes, ctf_name_table,
836 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
837 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
838 if set. Drop out early when dictionary is writable. Split the
839 ctf_lookups initialization into...
840 (ctf_set_cth_hashes): ... this new function.
841 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
842 (ctf_simple_open): Adjust accordingly.
843 (ctf_bufopen): Likewise.
844 (ctf_file_close): Destroy the appropriate name hashes. No longer
845 destroy ctf_dtbyname, which is gone.
846 (ctf_getdatasect): Remove spurious "extern".
847 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
848 specified name table, given a kind.
849 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
850 (ctf_member_iter): Add support for iterating over the
852 (ctf_enum_iter): Likewise.
853 (ctf_variable_iter): Likewise.
854 (ctf_type_rvisit): Likewise.
855 (ctf_member_info): Add support for types in the dynamic type list.
856 (ctf_enum_name): Likewise.
857 (ctf_enum_value): Likewise.
858 (ctf_func_type_info): Likewise.
859 (ctf_func_type_args): Likewise.
860 * ctf-link.c (ctf_accumulate_archive_names): No longer call
862 (ctf_link_write): Likewise.
863 (ctf_link_intern_extern_string): Adjust for new
864 ctf_str_add_external return value.
865 (ctf_link_add_strtab): Likewise.
866 * ctf-util.c (ctf_list_empty_p): New.
868 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
870 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
872 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
874 (ctf_add_variable): Likewise for variables pointing to them.
875 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
876 type link failure, but do warn for others.
877 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
879 (ctf_dump_member): Likewise.
880 (ctf_dump_type): Likewise.
881 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
882 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
883 (ctf_dump_header): Likewise.
884 (ctf_dump_label): likewise.
885 (ctf_dump_objts): likewise.
886 (ctf_dump_funcs): likewise.
887 (ctf_dump_var): likewise.
888 (ctf_dump_str): Likewise.
890 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
892 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
894 (AM_INSTALL_LIBBFD): Likewise.
895 (dlopen): Note why this is necessary in a comment.
896 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
898 (SHARED_LDFLAGS): Likewise.
899 (BFD_LIBADD): Likewise, for libbfd.
900 (BFD_DEPENDENCIES): Likewise.
901 (VERSION_FLAGS): Initialize, using a version script if ld supports
902 one, or libtool -export-symbols-regex otherwise.
903 (AC_CONFIG_MACRO_DIR): Add ../BFD.
904 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
906 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
907 (noinst_LIBRARIES): Replace with...
908 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
909 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
910 libctf-nobfd.la as well.
911 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
912 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
913 (libctf_a_SOURCES): Rename to...
914 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
916 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
917 with ctf-open-bfd.c added.
918 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
919 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
920 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
921 * Makefile.am [INSTALL_LIBCTF]: Use it.
922 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
924 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
925 the unstable components).
926 * Makefile.in: Regenerated.
927 * config.h.in: Likewise.
928 * configure: Likewise.
930 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
932 * configure.ac (INSTALL_LIBCTF): New, controlled by
933 --enable-install-libctf.
934 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
935 * Makefile.in: Regenerated.
936 * configure: Regenerated.
938 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
940 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
941 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
943 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
945 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
947 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
949 * ctf-impl.h (includes): Include <sys/param.h> here.
951 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
953 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
954 (flip_objts): Likewise.
955 (flip_vars): Likewise.
956 (flip_types): Likewise.
958 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
960 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
961 freeing functions: if set, free the key and value if the slot
962 already exists. Always reassign the key.
963 (ctf_dynhash_insert): Adjust call appropriately.
964 (ctf_hash_insert_type): Likewise.
966 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
968 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
969 type kind. Allow forwards to unify with pre-existing structs/
972 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
974 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
975 <ctf_link_memb_name_changer>: Likewise.
976 <ctf_link_memb_name_changer_arg>: Likewise.
977 * ctf-create.c (ctf_update): Update accordingly.
978 * ctf-open.c (ctf_file_close): Likewise.
979 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
980 (ctf_link_add_cu_mapping): New.
981 (ctf_link_set_memb_name_changer): Likewise.
982 (ctf_change_parent_name): New.
983 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
984 allocated by the caller's ctf_link_memb_name_changer.
985 <ndynames>: Likewise.
986 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
987 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
988 ctf_change_parent_name. Free any resulting names.
990 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
992 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
993 (ctf_link_one_type): ... here, with parent-name setting added.
994 (check_variable): New.
995 (ctf_link_one_variable): Likewise.
996 (ctf_link_one_input_archive_member): Call it.
997 * ctf-error.c (_ctf_errlist): Updated with new errors.
999 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1001 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1002 (struct ctf_link_type_mapping_key): New.
1003 (ctf_hash_type_mapping_key): Likewise.
1004 (ctf_hash_eq_type_mapping_key): Likewise.
1005 (ctf_add_type_mapping): Likewise.
1006 (ctf_type_mapping): Likewise.
1007 (ctf_dynhash_empty): Likewise.
1008 * ctf-open.c (ctf_file_close): Update accordingly.
1009 * ctf-create.c (ctf_update): Likewise.
1010 (ctf_add_type): Populate the mapping.
1011 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1012 (ctf_hash_eq_type_mapping_key): Check the key for equality.
1013 (ctf_dynhash_insert): Fix comment typo.
1014 (ctf_dynhash_empty): New.
1015 * ctf-link.c (ctf_add_type_mapping): New.
1016 (ctf_type_mapping): Likewise.
1017 (empty_link_type_mapping): New.
1018 (ctf_link_one_input_archive): Call it.
1020 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1022 * ctf-link.c: New file, linking of the string and type sections.
1023 * Makefile.am (libctf_a_SOURCES): Add it.
1024 * Makefile.in: Regenerate.
1026 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1028 * ctf-create.c (ctf_update): Update accordingly.
1029 * ctf-open.c (ctf_file_close): Likewise.
1030 * ctf-error.c (_ctf_errlist): Updated with new errors.
1032 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1034 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1036 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1038 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1040 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1041 (ctf_dump_format_type): Add non-root-type { } notation.
1042 Add root flag to prototype.
1043 (ctf_dump_label): Adjust accordingly.
1044 (ctf_dump_objts): Likewise.
1045 (ctf_dump_var): Likewise.
1047 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1049 * ctf-create.c (ctf_compress_write): Fix double-free.
1051 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1053 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1055 (ctf_arc_write_fd): ... this new function.
1056 * ctf-create.c (ctf_write_mem): New.
1058 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1060 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1061 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1062 (ctf_str_add_ref): Name the last arg.
1063 (ctf_str_add_external) New.
1064 (ctf_str_add_strraw_explicit): Likewise.
1065 (ctf_simple_open_internal): Likewise.
1066 (ctf_bufopen_internal): Likewise.
1068 * ctf-string.c (ctf_strraw_explicit): Split from...
1069 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1070 (ctf_str_add_ref_internal): Return the atom, not the
1072 (ctf_str_add): Adjust accordingly.
1073 (ctf_str_add_ref): Likewise. Move up in the file.
1074 (ctf_str_add_external): New: update the csa_offset.
1075 (ctf_str_count_strtab): Only account for strings with no csa_offset
1076 in the internal strtab length.
1077 (ctf_str_write_strtab): If the csa_offset is set, update the
1078 string's refs without writing the string out, and update the
1079 ctf_syn_ext_strtab. Make OOM handling less ugly.
1080 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1081 (ctf_update): Handle failure to populate the strtab. Pass in the
1082 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1083 Call ctf_simple_open_internal, not ctf_simple_open.
1084 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1086 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1087 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1088 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1089 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1090 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1091 (ctf_simple_open_internal): ... this new function, which calls
1092 ctf_bufopen_internal.
1093 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1094 (ctf_bufopen_internal): ... this new function, which sets
1097 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1099 * ctf_types.c (ctf_type_iter_all): New.
1101 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1103 * ctf-open.c (init_symtab): Check for overflow against the right
1105 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1106 (upgrade_types_v1): Note that these sections are not checked.
1107 (flip_header): Endian-swap the header fields.
1108 (flip_ctf): Endian-swap the sections.
1109 (flip_objts): Update comment.
1110 (ctf_bufopen): Check header offsets and alignment for validity.
1112 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1114 * ctf-open-bfd.c: Add <assert.h>.
1115 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1116 techniques borrowed from bfd_elf_sym_name.
1117 (ctf_new_archive_internal): Improve comment.
1118 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1119 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1120 no symbol section, but not vice versa.
1122 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1124 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1125 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1126 * ctf-dump.c (dump_header): New function, dump the CTF header.
1127 (ctf_dump): Call it.
1128 (ctf_dump_header_strfield): New function.
1129 (ctf_dump_header_sectfield): Likewise.
1131 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1133 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1134 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1135 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1136 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1137 Print out ctf_cuname: only print out ctf_parname if set.
1138 (ctf_free_base): Removed, ctf_base is no longer freed: free
1139 ctf_dynbase instead.
1140 (ctf_set_version): Fix spacing.
1141 (upgrade_header): New, in-place header upgrading.
1142 (upgrade_types): Rename to...
1143 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1144 longer track old and new headers separately. No longer allow for
1145 header sizes explicitly: squeeze the headers out on upgrade (they
1146 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1147 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1148 (upgrade_types): New, also handle ctf_parmax updating.
1149 (flip_header): Flip ctf_cuname.
1150 (flip_types): Flip BUF explicitly rather than deriving BUF from
1152 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1153 required alignment of objtoff and funcoff. No longer store it in
1154 the ctf_buf unless that buf is derived unmodified from the input.
1155 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1156 that duplicate fields in ctf_file: move allocation of ctf_file
1157 further up instead. Call upgrade_header as needed. Move
1158 version-specific ctf_parmax initialization into upgrade_types. More
1159 concise error handling.
1160 (ctf_file_close): No longer test for null pointers before freeing.
1161 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1164 (ctf_cuname_set): New.
1165 * ctf-create.c (ctf_update): Populate ctf_cuname.
1166 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1168 (ctf_write): Likewise.
1169 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1170 Fix the compression length: fp->ctf_size never counted the CTF
1171 header. Simplify the compress call accordingly.
1173 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1175 * ctf-endian.h: Don't assume htole64 and le64toh are always
1176 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1177 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1178 not bswap_identity_64.
1180 2019-09-18 Alan Modra <amodra@gmail.com>
1182 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1184 2019-09-09 Phil Blundell <pb@pbcl.net>
1186 binutils 2.33 branch created.
1188 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1190 * ctf-types.c (ctf_type_aname_raw): New.
1191 (ctf_func_type_info): Likewise.
1192 (ctf_func_type_args): Likewise.
1193 * ctf-error.c (_ctf_errlist): Fix description.
1194 * ctf-lookup.c: Fix file description.
1196 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1198 * ctf-create.c (ctf_create): Fix off-by-one error.
1200 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1202 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1204 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1205 (struct ctf_str_atom): New, disambiguated single string.
1206 (struct ctf_str_atom_ref): New, points to some other location that
1207 references this string's offset.
1208 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1209 Remove member ctf_dtvstrlen: we no longer track the total strlen
1211 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1212 (ctf_str_free_atoms): Likewise.
1213 (ctf_str_add): Likewise.
1214 (ctf_str_add_ref): Likewise.
1215 (ctf_str_rollback): Likewise.
1216 (ctf_str_purge_refs): Likewise.
1217 (ctf_str_write_strtab): Likewise.
1218 (ctf_realloc): Declare new function in ctf-util.c.
1220 * ctf-open.c (ctf_bufopen): Create the atoms table.
1221 (ctf_file_close): Destroy it.
1222 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1223 special-case the position of the parname string. Construct the
1224 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1225 rest of each buffer element is constructed, not via open-coding:
1226 realloc the CTF buffer and append the strtab to it. No longer
1227 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1228 strtab construction.
1229 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1230 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1231 after buffer element construction instead.
1232 (ctf_copy_lmembers): Likewise.
1233 (ctf_copy_emembers): Likewise.
1234 (ctf_create): No longer maintain the ctf_dtvstrlen.
1235 (ctf_dtd_delete): Likewise.
1236 (ctf_dvd_delete): Likewise.
1237 (ctf_add_generic): Likewise.
1238 (ctf_add_enumerator): Likewise.
1239 (ctf_add_member_offset): Likewise.
1240 (ctf_add_variable): Likewise.
1241 (membadd): Likewise.
1242 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1243 if there are active ctf_str_num_refs.
1244 (ctf_strraw): Move to ctf-string.c.
1245 (ctf_strptr): Likewise.
1246 * ctf-string.c: New file, strtab manipulation.
1248 * Makefile.am (libctf_a_SOURCES): Add it.
1249 * Makefile.in: Regenerate.
1251 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1253 * ctf-impl.h (ctf_hash_iter_f): New.
1254 (ctf_dynhash_iter): New declaration.
1255 (ctf_dynhash_iter_remove): New declaration.
1256 * ctf-hash.c (ctf_dynhash_iter): Define.
1257 (ctf_dynhash_iter_remove): Likewise.
1258 (ctf_hashtab_traverse): New.
1259 (ctf_hashtab_traverse_remove): Likewise.
1260 (struct ctf_traverse_cb_arg): Likewise.
1261 (struct ctf_traverse_remove_cb_arg): Likewise.
1263 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1265 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1267 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1269 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1270 (ctf_dump_funcs): Likewise.
1272 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1274 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1275 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1276 little-endian CTF archive magic. Do not check the CTF version:
1277 ctf_simple_open does that in endian-safe ways. Do not dereference
1278 null pointers on open failure.
1280 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1282 * ctf-open.c (get_vbytes_common): Return the new slice size.
1283 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1284 Remember to copy in the CTF data when opening an uncompressed
1285 foreign-endian CTF file. Prune useless variable manipulation.
1287 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1289 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1292 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1294 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1297 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1299 * ctf-subr.c (_PAGESIZE): Remove.
1300 (ctf_data_alloc): Likewise.
1301 (ctf_data_free): Likewise.
1302 (ctf_data_protect): Likewise.
1303 * ctf-impl.h: Remove declarations.
1304 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1305 ctf_free, not ctf_data_free.
1306 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1307 the buffer again on compression error.
1308 * ctf-open.c (ctf_set_base): No longer track the size: call
1309 ctf_free, not ctf_data_free.
1310 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1311 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1313 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1315 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1317 (ctf_dvd_insert): Likewise.
1318 (ctf_add_generic): Likewise.
1319 (ctf_add_variable): Likewise.
1320 * ctf-impl.h: Adjust declarations.
1322 2019-06-14 Alan Modra <amodra@gmail.com>
1324 * configure: Regenerate.
1326 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1328 * ctf-decls.h: Include <libiberty.h>.
1329 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1331 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1333 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1334 (ctf_dump_objts): Likewise.
1335 (ctf_dump_funcs): Likewise.
1336 (ctf_dump_member): Likewise.
1337 (ctf_dump_str): Likewise.
1339 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1341 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1342 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1344 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1346 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1347 (ctf_arc_open_by_offset): Likewise.
1348 * ctf-create.c (ctf_add_type): Likewise.
1350 2019-06-04 Tom Tromey <tromey@adacore.com>
1352 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1353 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1355 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1357 * configure.ac: Check for O_CLOEXEC.
1358 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1359 * config.h.in: Regenerate.
1360 * configure: Likewise.
1362 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1364 * qsort_r.c: Rename to...
1365 * ctf-qsort_r.c: ... this.
1366 (_quicksort): Define to ctf_qsort_r.
1367 * ctf-decls.h (qsort_r): Remove.
1369 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1370 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1371 * Makefile.am (libctf_a_LIBADD): Remove.
1372 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1373 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1374 * ctf-create.c (ctf_update): Likewise.
1375 * configure.ac: Check for BSD versus GNU qsort_r signature.
1376 * Makefile.in: Regenerate.
1377 * config.h.in: Likewise.
1378 * configure: Likewise.
1380 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1382 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1384 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1386 * Makefile.am (ZLIB): New.
1387 (ZLIBINC): Likewise.
1388 (AM_CFLAGS): Use them.
1389 (libctf_a_LIBADD): New, for LIBOBJS.
1390 * configure.ac: Check for zlib, endian.h, and qsort_r.
1391 * ctf-endian.h: New, providing htole64 and le64toh.
1392 * swap.h: Code style fixes.
1393 (bswap_identity_64): New.
1394 * qsort_r.c: New, from gnulib (with one added #include).
1395 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1396 and unconditional definitions of MIN and MAX.
1397 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1398 (ctf_set_errno): Now returns unsigned long.
1399 * ctf-util.c (ctf_set_errno): Adjust here too.
1400 * ctf-archive.c: Use ctf-endian.h.
1401 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1402 cts_flags and cts_offset.
1403 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1404 * ctf-create.c: Provide a definition of roundup if not defined.
1405 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1406 (ctf_add_reftype): Do not check if type IDs are below zero.
1407 (ctf_add_slice): Likewise.
1408 (ctf_add_typedef): Likewise.
1409 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1410 when known error-free. Drop CTF_ERR usage for functions returning
1412 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1414 (ctf_add_variable): Likewise.
1415 (enumcmp): Likewise.
1416 (enumadd): Likewise.
1417 (membcmp): Likewise.
1418 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1419 when known error-free.
1420 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1421 returning int: use CTF_ERR for functions returning ctf_type_id.
1422 (ctf_dump_label): Likewise.
1423 (ctf_dump_objts): Likewise.
1424 * ctf-labels.c (ctf_label_topmost): Likewise.
1425 (ctf_label_iter): Likewise.
1426 (ctf_label_info): Likewise.
1427 * ctf-lookup.c (ctf_func_args): Likewise.
1428 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1429 (ctf_bufopen): Likewise. Use zlib types as needed.
1430 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1432 (ctf_enum_iter): Likewise.
1433 (ctf_type_size): Likewise.
1434 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1435 (ctf_type_kind_unsliced): Likewise.
1436 (ctf_type_kind): Likewise.
1437 (ctf_type_encoding): Likewise.
1438 (ctf_member_info): Likewise.
1439 (ctf_array_info): Likewise.
1440 (ctf_enum_value): Likewise.
1441 (ctf_type_rvisit): Likewise.
1442 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1444 (ctf_simple_open): Likewise.
1445 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1446 * Makefile.in: Regenerate.
1447 * aclocal.m4: Likewise.
1448 * config.h: Likewise.
1449 * configure: Likewise.
1451 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1453 * configure.in: Check for bfd_section_from_elf_index.
1454 * configure: Regenerate.
1455 * config.h.in [HAVE_BFD_ELF]: Likewise.
1456 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1457 abfd is potentially unused now.
1459 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1462 * Makefile.in: Regenerated.
1463 * config.h.in: Likewise.
1464 * aclocal.m4: Likewise.
1465 * configure: Likewise.
1467 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1471 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1473 * ctf-labels.c: New.
1475 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1477 * ctf-impl.h (_libctf_version): New declaration.
1478 * ctf-subr.c (_libctf_version): Define it.
1481 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1483 * ctf-create.c (enumcmp): New.
1484 (enumadd): Likewise.
1485 (membcmp): Likewise.
1486 (membadd): Likewise.
1487 (ctf_add_type): Likewise.
1489 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1491 * ctf-lookup.c (isqualifier): New.
1492 (ctf_lookup_by_name): Likewise.
1493 (struct ctf_lookup_var_key): Likewise.
1494 (ctf_lookup_var): Likewise.
1495 (ctf_lookup_variable): Likewise.
1496 (ctf_lookup_symbol_name): Likewise.
1497 (ctf_lookup_by_symbol): Likewise.
1498 (ctf_func_info): Likewise.
1499 (ctf_func_args): Likewise.
1501 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1503 * ctf-decl.c: New file.
1504 * ctf-types.c: Likewise.
1505 * ctf-impl.h: New declarations.
1507 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1509 * ctf-open-bfd.c: New file.
1510 * ctf-open.c (ctf_close): New.
1511 * ctf-impl.h: Include bfd.h.
1512 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1513 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1515 (ctf_bfdopen_ctfsect): New declaration.
1516 (_CTF_SECTION): likewise.
1518 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1520 * ctf-archive.c: New.
1521 * ctf-impl.h (ctf_archive_internal): New type.
1522 (ctf_arc_open_internal): New declaration.
1523 (ctf_arc_bufopen): Likewise.
1524 (ctf_arc_close_internal): Likewise.
1526 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1528 * ctf-open.c: New file.
1531 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1533 * ctf-create.c: New file.
1534 * ctf-lookup.c: New file.
1536 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1538 * ctf-impl.h: New definitions and declarations for type creation
1541 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1543 * ctf-hash.c: New file.
1544 * ctf-impl.h: New declarations.
1546 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1548 * ctf-error.c: New file.
1550 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1552 * ctf-util.c: New file.
1554 * ctf-impl.h: Include it, and add declarations.
1556 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1558 * ctf-impl.h: New file.
1559 * ctf-subr.c: New file.
1566 version-control: never