libctf/ChangeLog

   1 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
   4         (ctf_dict_open_by_offset): ... this.  Adjust callers.
   5         (ctf_arc_open_by_name_internal): Rename to...
   6         (ctf_dict_open_internal): ... this.  Adjust callers.
   7         (ctf_arc_open_by_name_sections): Rename to...
   8         (ctf_dict_open_sections): ... this, keeping compatibility function.
   9         (ctf_arc_open_by_name): Rename to...
  10         (ctf_dict_open): ... this, keeping compatibility function.
  11         * libctf.ver: New functions added.
  12         * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
  13         (ctf_link_deduplicating_open_inputs): Likewise.
  14
  15 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
  16
  17         * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
  18         adjusted.
  19         (ctf_fileops): Rename to...
  20         (ctf_dictops): ... this.
  21         (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
  22         <cd_id_to_dict_t>: ... this.
  23         (ctf_file_t): Fix outdated comment.
  24         <ctf_fileops>: Rename to...
  25         <ctf_dictops>: ... this.
  26         (struct ctf_archive_internal) <ctfi_file>: Rename to...
  27         <ctfi_dict>: ... this.
  28         * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
  29         Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
  30         Rename ctf_file_close to ctf_dict_close.  All users adjusted.
  31         * ctf-create.c: Likewise.  Refer to CTF dicts, not CTF containers.
  32         (ctf_bundle_t) <ctb_file>: Rename to...
  33         <ctb_dict): ... this.
  34         * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
  35         * ctf-dedup.c: Likewise.  Rename ctf_file_close to
  36         ctf_dict_close. Refer to CTF dicts, not CTF containers.
  37         * ctf-dump.c: Likewise.
  38         * ctf-error.c: Likewise.
  39         * ctf-hash.c: Likewise.
  40         * ctf-inlines.h: Likewise.
  41         * ctf-labels.c: Likewise.
  42         * ctf-link.c: Likewise.
  43         * ctf-lookup.c: Likewise.
  44         * ctf-open-bfd.c: Likewise.
  45         * ctf-string.c: Likewise.
  46         * ctf-subr.c: Likewise.
  47         * ctf-types.c: Likewise.
  48         * ctf-util.c: Likewise.
  49         * ctf-open.c: Likewise.
  50         (ctf_file_close): Rename to...
  51         (ctf_dict_close): ...this.
  52         (ctf_file_close): New trivial wrapper around ctf_dict_close, for
  53         compatibility.
  54         (ctf_parent_file): Rename to...
  55         (ctf_parent_dict): ... this.
  56         (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
  57         compatibility.
  58         * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
  59
  60 2020-10-21  Tom Tromey  <tromey@adacore.com>
  61
  62         * mkerrors.sed: Remove.
  63         * ctf-error.c (_CTF_FIRST): New define.
  64         (_CTF_ITEM): Define this, not _CTF_STR.
  65         (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
  66         (ERRSTRFIELD): Rewrite.
  67         (ERRSTRFIELD1): Remove.
  68         * Makefile.in: Rebuild.
  69         * Makefile.am (BUILT_SOURCES): Remove.
  70         (ctf-error.h): Remove.
  71
  72 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
  73
  74         * ctf-subr.c (open_errors): New list.
  75         (ctf_err_warn): Calls with NULL fp append to open_errors.  Add err
  76         parameter, and use it to decorate the debug stream with errmsgs.
  77         (ctf_err_warn_to_open): Splice errors from a CTF dict into the
  78         open_errors.
  79         (ctf_errwarning_next): Calls with NULL fp report from open_errors.
  80         New err param to report iteration errors (including end-of-iteration)
  81         when fp is NULL.
  82         (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
  83         parameter: gettextize.
  84         * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
  85         (LCTF_VBYTES): Adjust.
  86         (ctf_err_warn_to_open): New.
  87         (ctf_err_warn): Adjust.
  88         (ctf_bundle): Used in only one place: move...
  89         * ctf-create.c: ... here.
  90         (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
  91         down as needed.  Don't emit the errmsg.  Gettextize.
  92         (membcmp): Likewise.
  93         (ctf_add_type_internal): Likewise.
  94         (ctf_write_mem): Likewise.
  95         (ctf_compress_write): Likewise.  Report errors writing the header or
  96         body.
  97         (ctf_write): Likewise.
  98         * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
  99         ctf_dprintf, and gettextize, as above.
 100         (ctf_arc_write): Likewise.
 101         (ctf_arc_bufopen): Likewise.
 102         (ctf_arc_open_internal): Likewise.
 103         * ctf-labels.c (ctf_label_iter): Likewise.
 104         * ctf-open-bfd.c (ctf_bfdclose): Likewise.
 105         (ctf_bfdopen): Likewise.
 106         (ctf_bfdopen_ctfsect): Likewise.
 107         (ctf_fdopen): Likewise.
 108         * ctf-string.c (ctf_str_write_strtab): Likewise.
 109         * ctf-types.c (ctf_type_resolve): Likewise.
 110         * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
 111         (get_vbytes_v1): Pass down the ctf dict.
 112         (get_vbytes_v2): Likewise.
 113         (flip_ctf): Likewise.
 114         (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
 115         gettextize, as above.
 116         (upgrade_types_v1): Adjust calls.
 117         (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
 118         (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
 119         emitted into individual dicts into the open errors if this turns
 120         out to be a failed open in the end.
 121         * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
 122         argument.  Gettextize.  Don't emit the errmsg.
 123         (ctf_dump_funcs): Likewise.  Collapse err label into its only case.
 124         (ctf_dump_type): Likewise.
 125         * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
 126         argument.  Gettextize.  Don't emit the errmsg.
 127         (ctf_link_one_type): Likewise.
 128         (ctf_link_lazy_open): Likewise.
 129         (ctf_link_one_input_archive): Likewise.
 130         (ctf_link_deduplicating_count_inputs): Likewise.
 131         (ctf_link_deduplicating_open_inputs): Likewise.
 132         (ctf_link_deduplicating_close_inputs): Likewise.
 133         (ctf_link_deduplicating): Likewise.
 134         (ctf_link): Likewise.
 135         (ctf_link_deduplicating_per_cu): Likewise. Add some missed
 136         ctf_set_errnos to obscure error cases.
 137         * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
 138         err argument.  Gettextize.  Don't emit the errmsg.
 139         (ctf_dedup_populate_mappings): Likewise.
 140         (ctf_dedup_detect_name_ambiguity): Likewise.
 141         (ctf_dedup_init): Likewise.
 142         (ctf_dedup_multiple_input_dicts): Likewise.
 143         (ctf_dedup_conflictify_unshared): Likewise.
 144         (ctf_dedup): Likewise.
 145         (ctf_dedup_rwalk_one_output_mapping): Likewise.
 146         (ctf_dedup_id_to_target): Likewise.
 147         (ctf_dedup_emit_type): Likewise.
 148         (ctf_dedup_emit_struct_members): Likewise.
 149         (ctf_dedup_populate_type_mapping): Likewise.
 150         (ctf_dedup_populate_type_mappings): Likewise.
 151         (ctf_dedup_emit): Likewise.
 152         (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
 153         status setting.
 154         (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
 155         unknown-type-kind messages (which signify file corruption).
 156
 157 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
 158
 159         * configure.ac: Adjust package name to simply 'libctf': arbitrarily
 160         declare this to be version 1.2.0.
 161         * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
 162         * Makefile.in: Regenerated.
 163         * configure: Regenerated.
 164         * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
 165         * ctf-impl.h: Include it.
 166         * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
 167         (ctf_errmsg): Actually translate them.
 168
 169 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 170
 171         PR binutils/25155:
 172         * ctf-create.c (EOVERFLOW): If not defined by system header,
 173         redirect to ERANGE as a poor man's substitute.
 174         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
 175
 176 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 177
 178         * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
 179         (ctf_dtd_delete): Likewise.
 180         (ctf_dtd_lookup): Likewise.
 181         (ctf_rollback): Likewise.
 182         * ctf-hash.c (ctf_hash_lookup_type): Likewise.
 183         * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
 184
 185 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 186
 187         * ctf-lookup.c (ctf_lookup_by_name): Adjust.
 188
 189 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 190
 191         * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
 192         number if needed.
 193
 194 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 195
 196         * ctf-impl.h (ctf_list_splice): New.
 197         * ctf-util.h (ctf_list_splice): Likewise.
 198         * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
 199         (ctf_link_sort_inputs): Likewise.
 200         (ctf_link_deduplicating_count_inputs): Likewise.
 201         (ctf_link_deduplicating_open_inputs): Likewise.
 202         (ctf_link_deduplicating_close_inputs): Likewise.
 203         (ctf_link_deduplicating_variables): Likewise.
 204         (ctf_link_deduplicating_per_cu): Likewise.
 205         (ctf_link_deduplicating): Likewise.
 206         (ctf_link): Call it.
 207
 208 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 209
 210         * ctf-link.c (ctf_link_one_input_archive_member): Check
 211         CTF_LINK_OMIT_VARIABLES_SECTION.
 212
 213 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 214
 215         * ctf-impl.h (ctf_type_id_key): New, the key in the
 216         cd_id_to_file_t.
 217         (ctf_dedup): New, core deduplicator state.
 218         (ctf_file_t) <ctf_dedup>: New.
 219         <ctf_dedup_atoms>: New.
 220         <ctf_dedup_atoms_alloc>: New.
 221         (ctf_hash_type_id_key): New prototype.
 222         (ctf_hash_eq_type_id_key): Likewise.
 223         (ctf_dedup_atoms_init): Likewise.
 224         * ctf-hash.c (ctf_hash_eq_type_id_key): New.
 225         (ctf_dedup_atoms_init): Likewise.
 226         * ctf-create.c (ctf_serialize): Adjusted.
 227         (ctf_add_encoded): No longer static.
 228         (ctf_add_reftype): Likewise.
 229         * ctf-open.c (ctf_file_close): Destroy the
 230         ctf_dedup_atoms_alloc.
 231         * ctf-dedup.c: New file.
 232         * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
 233         * configure.ac: Check for stpcpy.
 234         * Makefile.am: Add it.
 235         * Makefile.in: Regenerate.
 236         * config.h.in: Regenerate.
 237         * configure: Regenerate.
 238
 239 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 240
 241         * configure.ac: Add --enable-libctf-hash-debugging.
 242         * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
 243         * Makefile.in: Regenerated.
 244         * configure: Likewise.
 245         * config.h.in: Likewise.
 246         * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
 247         (ctf_assert): Define to assert.
 248
 249 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 250
 251         * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
 252         sha1_process_bytes.
 253         * ctf-impl.h: Include it.
 254         (ctf_sha1_init): New.
 255         (ctf_sha1_add): Likewise.
 256         (ctf_sha1_fini): Likewise.
 257         * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
 258         producing strings.
 259         * Makefile.am: Add file.
 260         * Makefile.in: Regenerate.
 261
 262 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 263
 264         * libctf.ver (ctf_link_set_variable_filter): Add.
 265         * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
 266         <ctf_link_variable_filter_arg>: Likewise.
 267         * ctf-create.c (ctf_serialize): Adjust.
 268         * ctf-link.c (ctf_link_set_variable_filter): New, set it.
 269         (ctf_link_one_variable): Call it if set.
 270
 271 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 272
 273         * ctf-link.c (ctf_link_one_variable): Check the dst_type for
 274         conflicts, not the source type.
 275
 276 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 277
 278         * ctf-impl.h (ctf_file_t): Improve comments.
 279         <ctf_link_cu_mapping>: Split into...
 280         <ctf_link_in_cu_mapping>: ... this...
 281         <ctf_link_out_cu_mapping>: ... and this.
 282         * ctf-create.c (ctf_serialize): Adjust.
 283         * ctf-open.c (ctf_file_close): Likewise.
 284         * ctf-link.c (ctf_create_per_cu): Look things up in the
 285         in_cu_mapping instead of the cu_mapping.
 286         (ctf_link_add_cu_mapping): The deduplicating link will define
 287         what happens if many FROMs share a TO.
 288         (ctf_link_add_cu_mapping): Create in_cu_mapping and
 289         out_cu_mapping. Do not create ctf_link_outputs here any more, or
 290         create per-CU dicts here: they are already created when needed.
 291         (ctf_link_one_variable): Log a debug message if we skip a
 292         variable due to its type being concealed in a CU-mapped link.
 293         (This is probably too common a case to make into a warning.)
 294         (ctf_link): Create empty per-CU dicts if requested.
 295
 296 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 297
 298         * ctf-link.c (ctf_link_write): Close the fd.
 299
 300 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 301
 302         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
 303         * Makefile.in: Regenerated.
 304         * ctf-impl.h (ctf_link_input_name): New.
 305         (ctf_file_t) <ctf_link_flags>: New.
 306         * ctf-create.c (ctf_serialize): Adjust accordingly.
 307         * ctf-link.c: Define ctf_open as weak when PIC.
 308         (ctf_arc_close_thunk): Remove unnecessary thunk.
 309         (ctf_file_close_thunk): Likewise.
 310         (ctf_link_input_name): New.
 311         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
 312         (ctf_link_input_close): Adjust accordingly.
 313         (ctf_link_add_ctf_internal): New, split from...
 314         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
 315         CTF is not possible.  Change to just call...
 316         (ctf_link_add): ... this new function.
 317         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
 318         ctf_file_close_thunk.
 319         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
 320         <in_file_name>: ... this.
 321         <arcname>: Drop.
 322         <share_mode>: Likewise (migrated to ctf_link_flags).
 323         <done_main_member>: Rename to...
 324         <done_parent>: ... this.
 325         <main_input_fp>: Rename to...
 326         <in_fp_parent>: ... this.
 327         <cu_mapped>: New.
 328         (ctf_link_one_type): Adjuwt accordingly.  Transition to
 329         ctf_err_warn, removing a TODO.
 330         (ctf_link_one_variable): Note a case too common to warn about.
 331         Report in the debug stream if a cu-mapped link prevents addition
 332         of a conflicting variable.
 333         (ctf_link_one_input_archive_member): Adjust.
 334         (ctf_link_lazy_open): New, open a CTF archive for linking when
 335         needed.
 336         (ctf_link_close_one_input_archive): New, close it again.
 337         (ctf_link_one_input_archive): Adjust for lazy opening, member
 338         renames, and ctf_err_warn transition.  Move the
 339         empty_link_type_mapping call to...
 340         (ctf_link): ... here.  Adjut for renamings and thunk removal.
 341         Don't spuriously fail if some input contains no CTF data.
 342         (ctf_link_write): ctf_err_warn transition.
 343         * libctf.ver: Remove not-yet-stable comment.
 344
 345 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 346
 347         * ctf-impl.h (ctf_strerror): Delete.
 348         * ctf-subr.c (ctf_strerror): Likewise.
 349         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
 350         strerror directly.
 351
 352 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 353
 354         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
 355         (ctf_import_unref): New.
 356         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
 357         zero.  Don't recurse back in if the refcount is already zero.
 358         (ctf_import): Check ctf_parent_unreffed before deciding whether
 359         to close a pre-existing parent.  Set it to zero.
 360         (ctf_import_unreffed): New, as above, setting
 361         ctf_parent_unreffed to 1.
 362         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
 363         child: use direct assignment, and set unreffed on the new and
 364         old children.
 365         * ctf-link.c (ctf_create_per_cu): Import the parent using
 366         ctf_import_unreffed.
 367
 368 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 369
 370         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
 371         (ctf_link_type_key): ... this, adjusting member prefixes to
 372         match.
 373         (ctf_hash_type_mapping_key): Rename to...
 374         (ctf_hash_type_key): ... this.
 375         (ctf_hash_eq_type_mapping_key): Rename to...
 376         (ctf_hash_eq_type_key): ... this.
 377         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
 378         (ctf_hash_type_key): ... this, and adjust for member name
 379         changes.
 380         (ctf_hash_eq_type_mapping_key): Rename to...
 381         (ctf_hash_eq_type_key): ... this, and adjust for member name
 382         changes.
 383         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
 384         need for out-of-memory checking in this code.
 385         (ctf_type_mapping): Adjust.
 386
 387 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 388
 389         configure.ac: Check for vasprintf.
 390         configure: Regenerated.
 391         config.h.in: Likewise.
 392
 393 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 394
 395         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 396
 397 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 398
 399         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 400         New.
 401         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 402         if the input has no symtab, rather than dividing by
 403         zero. Arrange to free it later via ctfi_free_ctfsect.
 404         * ctf-archive.c (ctf_new_archive_internal): Do not
 405         ctfi_free_strsect by default.
 406         (ctf_arc_close): Possibly free it here.
 407
 408 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 409
 410         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 411         (ctf_dump_format_type): improve slice formatting.  Always print
 412         the type size, even of slices.
 413         (ctf_dump_member): Print slices (-> bitfields) differently from
 414         non-slices.  Failure to format a type is not an OOM.
 415
 416 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 417
 418         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 419         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 420         (ctf_dump_objts): Likewise.
 421         (ctf_dump_var): Likewise.
 422         (ctf_dump_type): Do not emit a duplicate message.  Move to
 423         ctf_err_warning, and swallow all errors.
 424
 425 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 426
 427         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 428         (ctf_decl_buf): Once it escapes, don't try to free it later.
 429
 430 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 431
 432         * ctf-types.c (ctf_type_aname): Print arg types here...
 433         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 434         in the type name here.
 435
 436 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 437
 438         * ctf-impl.h (ctf_assert): New.
 439         (ctf_err_warning_t): Likewise.
 440         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 441         (ctf_err_warn): New prototype.
 442         (ctf_assert_fail_internal): Likewise.
 443         * ctf-inlines.h (ctf_assert_internal): Likewise.
 444         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 445         * ctf-create.c (ctf_serialize): Copy it on serialization.
 446         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 447         (ctf_errwarning_next): New iterator, free and pass back
 448         errors/warnings in succession.
 449         * libctf.ver (ctf_errwarning_next): Add.
 450
 451 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 452
 453         * ctf-types.c (ctf_variable_iter): Fix error return.
 454
 455 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 456
 457         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 458
 459 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 460
 461         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 462
 463 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 464
 465         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 466         sorting functions.
 467         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 468         ctf_dynhash_next_sorted.
 469         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 470         <cu.ctn_s>: New, pointer to the dynset under iteration.
 471         (ctf_hash_sort_f): Sorting function passed to...
 472         (ctf_dynhash_next_sorted): ... this new function.
 473         (ctf_dynhash_next): New.
 474         (ctf_dynset_next): New.
 475         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 476         (ctf_dynhash_cnext): New.
 477         (ctf_dynset_cnext): New.
 478         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 479         (ctf_dynhash_next): New.
 480         (ctf_dynset_next): New.
 481         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 482         needed.
 483         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 484
 485 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 486
 487         * ctf-impl.h (ctf_next): New.
 488         (ctf_get_dict): New prototype.
 489         * ctf-lookup.c (ctf_get_dict): New, split out of...
 490         (ctf_lookup_by_id): ... here.
 491         * ctf-util.c (ctf_next_create): New.
 492         (ctf_next_destroy): New.
 493         (ctf_next_copy): New.
 494         * ctf-types.c (includes): Add <assert.h>.
 495         (ctf_member_next): New.
 496         (ctf_enum_next): New.
 497         (ctf_type_iter): Document the lack of iteration over parent
 498         types.
 499         (ctf_type_next): New.
 500         (ctf_variable_next): New.
 501         * ctf-archive.c (ctf_archive_next): New.
 502         * libctf.ver: Add new public functions.
 503
 504 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 505
 506         * libctf.ver (ctf_ref): New.
 507         * ctf-open.c (ctf_ref): Implement it.
 508
 509 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 510
 511         * ctf-inlines.h (ctf_forwardable_kind): New.
 512         * ctf-create.c (ctf_add_forward): Use it.
 513
 514 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 515
 516         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 517         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 518
 519 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 520
 521         * ctf-hash.c (ctf_dynset_eq_string): New.
 522         (ctf_dynset_create): New.
 523         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 524         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 525         (key_to_internal): New.
 526         (internal_to_key): New.
 527         (ctf_dynset_insert): New.
 528         (ctf_dynset_remove): New.
 529         (ctf_dynset_destroy): New.
 530         (ctf_dynset_lookup): New.
 531         (ctf_dynset_exists): New.
 532         (ctf_dynset_lookup_any): New.
 533         (ctf_hash_insert_type): Coding style.
 534         (ctf_hash_define_type): Likewise.
 535         * ctf-impl.h (ctf_dynset_t): New.
 536         (ctf_dynset_eq_string): New.
 537         (ctf_dynset_create): New.
 538         (ctf_dynset_insert): New.
 539         (ctf_dynset_remove): New.
 540         (ctf_dynset_destroy): New.
 541         (ctf_dynset_lookup): New.
 542         (ctf_dynset_exists): New.
 543         (ctf_dynset_lookup_any): New.
 544         * ctf-inlines.h (ctf_dynset_cinsert): New.
 545
 546 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 547
 548         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 549         <value_free>: Likewise.
 550         <owner>: New.
 551         (ctf_dynhash_item_free): Indirect through the owner.
 552         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 553         allocate space for the key_free and value_free fields fields
 554         if necessary.
 555         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 556         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 557         value_free if they will exist.  Set the slot's owner, but only
 558         if it exists.
 559         (ctf_dynhash_remove): Adjust.
 560
 561 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 562
 563         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 564         there is a key-freeing function and the key already exists.
 565
 566 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 567
 568         * ctf-inlines.h: New file.
 569         * ctf-impl.h: Include it.
 570         (ctf_hash_iter_find_f): New typedef.
 571         (ctf_dynhash_elements): New.
 572         (ctf_dynhash_lookup_kv): New.
 573         (ctf_dynhash_iter_find): New.
 574         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 575         (ctf_traverse_find_cb_arg_t): New.
 576         (ctf_hashtab_traverse_find): New.
 577         (ctf_dynhash_iter_find): New.
 578         (ctf_dynhash_elements): New.
 579
 580 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 581
 582         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 583
 584 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 585
 586         * ctf-archive.c (ctf_archive_count): New.
 587         * libctf.ver: New public function.
 588
 589 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 590
 591         * ctf-types.c (ctf_member_count): New.
 592         * libctf.ver: New public function.
 593
 594 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 595
 596         * ctf-types.c (ctf_type_kind_forwarded): New.
 597
 598 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 599
 600         * ctf-types.c (ctf_type_name_raw): New.
 601         (ctf_type_aname_raw): Reimplement accordingly.
 602
 603 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 604
 605         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 606
 607 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 608
 609         * ctf-impl.h (struct ctf_archive_internal)
 610         <ctfi_unmap_on_close>: New.
 611         (ctf_new_archive_internal): Adjust.
 612         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 613         Initialize ctfi_unmap_on_close.  Adjust error path.
 614         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 615         (unmap_on_close is 0).
 616         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 617         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 618
 619 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 620
 621         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 622         ints, floats or typedefs have no name.  Fix comment typo.
 623
 624 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 625
 626         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 627         resolves to an integral type.
 628         * ctf-types.c (ctf_type_encoding): Resolve the type before
 629         fishing its encoding out.
 630
 631 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 632
 633         * ctf-create.c (ctf_create): Mark dirty.
 634
 635 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 636
 637         * ctf-create.c (membcmp)  Skip nameless members.
 638
 639 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 640
 641         * ctf-create.c (ctf_add_member_offset): Support names of ""
 642         as if they were the null pointer.
 643
 644 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 645
 646         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 647         special-casing.
 648
 649 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 650
 651         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 652
 653 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 654
 655         * ctf-create.c (ctf_serialize): Add cast.
 656         (ctf_add_slice): Likewise.
 657
 658 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 659
 660         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 661         * ctf-create.c (ctf_add_function): Check for unimplemented type
 662         and populate at the same time.  Populate one-by-one, not via
 663         memcpy.
 664         (ctf_serialize): Remove unnecessary cast.
 665         * ctf-types.c (ctf_func_type_info): Likewise.
 666         (ctf_func_type_args): Likewise.  Fix comment typo.
 667
 668 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 669
 670         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 671         (ctf_add_array): Support array contents of type zero.
 672         (ctf_add_function): Support arguments and return types of
 673         type zero.
 674         (ctf_add_typedef): Support typedefs to type zero.
 675         (ctf_add_member_offset): Support members of type zero,
 676         unless added at unspecified (naturally-aligned) offset.
 677
 678 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 679
 680         * ctf-error.c: Include <stddef.h>, for offsetof.
 681         (_ctf_errlist): Migrate to...
 682         (_ctf_errlist_t): ... this.
 683         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 684         (_ctf_nerr): Remove.
 685         (ctf_errmsg): Adjust accordingly.
 686         * Makefile.am (BUILT_SOURCES): Note...
 687         (ctf-error.h): ... this new rule.
 688         * Makefile.in: Regenerate.
 689         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 690         * .gitignore: New, ignore ctf-error.h.
 691
 692 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 693
 694         * ctf-impl.h: Fix typos in comments.
 695
 696 2020-07-22  Nick Clifton  <nickc@redhat.com>
 697
 698         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 699         same file descriptor.
 700
 701 2020-07-04  Nick Clifton  <nickc@redhat.com>
 702
 703         Binutils 2.35 branch created.
 704
 705 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 706
 707         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 708         alphabetical order.
 709         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 710         * config.h.in: Regenerated.
 711         * Makefile.in: Likewise.
 712         * configure: Likewise.
 713
 714 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 715
 716         * ctf-create.c: Include <unistd.h>.
 717         * ctf-open-bfd.c: Likewise.
 718
 719 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 720
 721         PR libctf/25120
 722         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 723         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 724         means this is declared.
 725         (bswap_32): Likewise.
 726         (bswap_64): Likewise.
 727         (bswap_identity_64): Remove, unused.
 728         * configure: Regenerated.
 729         * config.h.in: Likewise.
 730
 731 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 732
 733         PR libctf/25120
 734         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 735         (_libctf_unlikely_): Likewise.
 736         (_libctf_unused): Likewise.
 737         (_libctf_malloc_): Likewise.
 738
 739 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 740
 741         PR libctf/25120
 742         * ctf-archive.c (search_nametbl): No longer global: declare...
 743         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 744         (search_modent_by_name): Take and use ARG for the nametbl.
 745
 746 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 747
 748         * ctf-impl.h (ctf_new_archive_internal): Declare.
 749         (ctf_arc_bufopen): Remove.
 750         (ctf_archive_internal) <ctfi_free_symsect>: New.
 751         * ctf-archive.c (ctf_arc_close): Use it.
 752         (ctf_arc_bufopen): Fuse into...
 753         (ctf_new_archive_internal): ... this, moved across from...
 754         * ctf-open-bfd.c: ... here.
 755         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 756         * libctf.ver: Add it.
 757
 758 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 759
 760         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 761         (ctf_dtd_delete): Remove correspondingly.
 762         (ctf_rollback): Likewise.
 763
 764 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 765
 766         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 767         unchanged.
 768
 769 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 770
 771         * ctf-create.c (ctf_add_forward): Don't add forwards to
 772         types that already exist.
 773
 774 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 775
 776         * ctf-open.c (init_types): Only intern root-visible types.
 777         * ctf-create.c (ctf_dtd_insert): Likewise.
 778         (ctf_dtd_delete): Only remove root-visible types.
 779         (ctf_rollback): Likewise.
 780         (ctf_add_generic): Adjust.
 781         (ctf_add_struct_sized): Adjust comment.
 782         (ctf_add_union_sized): Likewise.
 783         (ctf_add_enum): Likewise.
 784         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 785
 786 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 787
 788         * swap.h (bswap_identity_64): Make static.
 789
 790 2020-01-18  Nick Clifton  <nickc@redhat.com>
 791
 792         Binutils 2.34 branch created.
 793
 794 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 795
 796         PR binutils/25155:
 797         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 798         * configure, config.h.in: Regenerate.
 799
 800 2020-01-01  Alan Modra  <amodra@gmail.com>
 801
 802         Update year range in copyright notice of all files.
 803
 804 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 805
 806         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 807
 808 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 809
 810         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 811         * ctf-types.c (ctf_type_lname): Likewise.
 812
 813 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 814
 815         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 816         ctf_import after the first for a given file.
 817
 818 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 819
 820         * ctf-impl.h (ctf_str_append_noerr): Declare.
 821         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 822         ctf_str_append.
 823         * ctf-dump.c (str_append): New, call it.
 824         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 825         (ctf_dump_label): Likewise.
 826         (ctf_dump_objts): Likewise.
 827         (ctf_dump_funcs): Likewise.
 828         (ctf_dump_var): Likewise.
 829         (ctf_dump_member): Likewise.
 830         (ctf_dump_type): Likewise.
 831         (ctf_dump): Likewise.
 832
 833 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 834
 835         * ctf-impl.h (ctf_alloc): Remove.
 836         (ctf_free): Likewise.
 837         (ctf_strdup): Likewise.
 838         * ctf-subr.c (ctf_alloc): Remove.
 839         (ctf_free): Likewise.
 840         * ctf-util.c (ctf_strdup): Remove.
 841
 842         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 843         ctf_free; strdup, not ctf_strdup.
 844         (ctf_dtd_delete): Likewise.
 845         (ctf_dvd_delete): Likewise.
 846         (ctf_add_generic): Likewise.
 847         (ctf_add_function): Likewise.
 848         (ctf_add_enumerator): Likewise.
 849         (ctf_add_member_offset): Likewise.
 850         (ctf_add_variable): Likewise.
 851         (membadd): Likewise.
 852         (ctf_compress_write): Likewise.
 853         (ctf_write_mem): Likewise.
 854         * ctf-decl.c (ctf_decl_push): Likewise.
 855         (ctf_decl_fini): Likewise.
 856         (ctf_decl_sprintf): Likewise.  Check for OOM.
 857         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 858         ctf_free; strdup, not ctf_strdup.
 859         (ctf_dump_free): Likewise.
 860         (ctf_dump): Likewise.
 861         * ctf-open.c (upgrade_types_v1): Likewise.
 862         (init_types): Likewise.
 863         (ctf_file_close): Likewise.
 864         (ctf_bufopen_internal): Likewise.  Check for OOM.
 865         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 866         (ctf_cuname_set): Likewise.
 867         (ctf_import): Likewise.
 868         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 869         free, not ctf_free; strdup, not ctf_strdup.
 870         (ctf_str_free_atom): Likewise.
 871         (ctf_str_create_atoms): Likewise.
 872         (ctf_str_add_ref_internal): Likewise.
 873         (ctf_str_remove_ref): Likewise.
 874         (ctf_str_write_strtab): Likewise.
 875
 876 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 877
 878         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 879         work right for non-int/fps.
 880
 881 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 882
 883         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 884         null pointer.
 885
 886 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 887
 888         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 889         * ctf-open.c (ctf_file_close): Free it.
 890         * ctf-create.c (ctf_serialize): Adjust.
 891         (membcmp): When reporting a conflict due to an error, report the
 892         error.
 893         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 894         (ctf_add_type_internal): ... this.  Hand back types we are already
 895         in the middle of adding immediately.  Hand back structs/unions with
 896         the same number of members immediately.  Do not walk the dynamic
 897         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 898         forwards promoted to other types and the inverse case identically.
 899         Add structs to the mapping as soon as we intern them, before they
 900         gain any members.
 901
 902 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 903
 904         * ctf-impl.h (ctf_names_t): New.
 905         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 906         (ctf_file_t) <ctf_structs>: Likewise.
 907         <ctf_unions>: Likewise.
 908         <ctf_enums>: Likewise.
 909         <ctf_names>: Likewise.
 910         <ctf_lookups>: Improve comment.
 911         <ctf_ptrtab_len>: New.
 912         <ctf_prov_strtab>: New.
 913         <ctf_str_prov_offset>: New.
 914         <ctf_dtbyname>: Remove, redundant to the names hashes.
 915         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 916         (ctf_dtdef_t) <dtd_name>: Remove.
 917         <dtd_data>: Note that the ctt_name is now populated.
 918         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 919         offset for internal strings too.
 920         <csa_external_offset>: New, the external strtab offset.
 921         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 922         (ctf_name_table): New declaration.
 923         (ctf_lookup_by_rawname): Likewise.
 924         (ctf_lookup_by_rawhash): Likewise.
 925         (ctf_set_ctl_hashes): Likewise.
 926         (ctf_serialize): Likewise.
 927         (ctf_dtd_insert): Adjust.
 928         (ctf_simple_open_internal): Likewise.
 929         (ctf_bufopen_internal): Likewise.
 930         (ctf_list_empty_p): Likewise.
 931         (ctf_str_remove_ref): Likewise.
 932         (ctf_str_add): Returns uint32_t now.
 933         (ctf_str_add_ref): Likewise.
 934         (ctf_str_add_external): Now returns a boolean (int).
 935         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 936         for strings in the appropriate range.
 937         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 938         when adding the null string to the new strtab.
 939         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 940         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 941         make_provisional, populate the offset and fill in the
 942         ctf_prov_strtab accordingly.
 943         (ctf_str_add): Return the offset, not the string.
 944         (ctf_str_add_ref): Likewise.
 945         (ctf_str_add_external): Return a success integer.
 946         (ctf_str_remove_ref): New, remove a single ref.
 947         (ctf_str_count_strtab): Do not count the initial null string's
 948         length or the existence or length of any unreferenced internal
 949         atoms.
 950         (ctf_str_populate_sorttab): Skip atoms with no refs.
 951         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 952         to the cts_len for the null string, since it is no longer done
 953         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 954         Populate the csa_offset for both internal and external cases.
 955         Flush the ctf_prov_strtab afterwards, and reset the
 956         ctf_str_prov_offset.
 957         * ctf-create.c (ctf_grow_ptrtab): New.
 958         (ctf_create): Call it.  Initialize new fields rather than old
 959         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 960         Set the ctl hashes and data model.
 961         (ctf_update): Rename to...
 962         (ctf_serialize): ... this.  Leave a compatibility function behind.
 963         Tell ctf_simple_open_internal that this is a writable dictionary.
 964         Pass the new fields along from the old dictionary.  Drop
 965         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 966         Do not zero out the DTD's ctt_name.
 967         (ctf_prefixed_name): Rename to...
 968         (ctf_name_table): ... this.  No longer return a prefixed name: return
 969         the applicable name table instead.
 970         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 971         kind we're adding.  Migrate away from dtd_name.
 972         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 973         deleted ctt_name.
 974         (ctf_dtd_lookup_type_by_name): Remove.
 975         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 976         No longer check ctf_dtnextid: check ctf_typemax instead.
 977         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 978         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 979         ctf_name_table and the right name table, and migrate away from
 980         dtd_name as in ctf_dtd_delete.
 981         (ctf_add_generic): Pass in the kind explicitly and pass it to
 982         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 983         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 984         Grow the ptrtab if needed.
 985         (ctf_add_encoded): Pass in the kind.
 986         (ctf_add_slice): Likewise.
 987         (ctf_add_array): Likewise.
 988         (ctf_add_function): Likewise.
 989         (ctf_add_typedef): Likewise.
 990         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 991         ctt_name rather than dtd_name.
 992         (ctf_add_struct_sized): Pass in the kind.  Use
 993         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 994         ctf_dtd_lookup_type_by_name.
 995         (ctf_add_union_sized): Likewise.
 996         (ctf_add_enum): Likewise.
 997         (ctf_add_enum_encoded): Likewise.
 998         (ctf_add_forward): Likewise.
 999         (ctf_add_type): Likewise.
1000         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1001         being initialized until after the call.
1002         (ctf_write_mem): Likewise.
1003         (ctf_write): Likewise.
1004         * ctf-archive.c (arc_write_one_ctf): Likewise.
1005         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1006         ctf_hash_lookup_type.
1007         (ctf_lookup_by_id): No longer check the readonly types if the
1008         dictionary is writable.
1009         * ctf-open.c (init_types): Assert that this dictionary is not
1010         writable.  Adjust to use the new name hashes, ctf_name_table,
1011         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
1012         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
1013         if set.  Drop out early when dictionary is writable.  Split the
1014         ctf_lookups initialization into...
1015         (ctf_set_cth_hashes): ... this new function.
1016         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
1017         (ctf_simple_open): Adjust accordingly.
1018         (ctf_bufopen): Likewise.
1019         (ctf_file_close): Destroy the appropriate name hashes.  No longer
1020         destroy ctf_dtbyname, which is gone.
1021         (ctf_getdatasect): Remove spurious "extern".
1022         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1023         specified name table, given a kind.
1024         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1025         (ctf_member_iter): Add support for iterating over the
1026         dynamic type list.
1027         (ctf_enum_iter): Likewise.
1028         (ctf_variable_iter): Likewise.
1029         (ctf_type_rvisit): Likewise.
1030         (ctf_member_info): Add support for types in the dynamic type list.
1031         (ctf_enum_name): Likewise.
1032         (ctf_enum_value): Likewise.
1033         (ctf_func_type_info): Likewise.
1034         (ctf_func_type_args): Likewise.
1035         * ctf-link.c (ctf_accumulate_archive_names): No longer call
1036         ctf_update.
1037         (ctf_link_write): Likewise.
1038         (ctf_link_intern_extern_string): Adjust for new
1039         ctf_str_add_external return value.
1040         (ctf_link_add_strtab): Likewise.
1041         * ctf-util.c (ctf_list_empty_p): New.
1042
1043 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
1044
1045         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1046         type zero.
1047         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1048         members and types.
1049         (ctf_add_variable): Likewise for variables pointing to them.
1050         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1051         type link failure, but do warn for others.
1052         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
1053         errors to be ENOMEM.
1054         (ctf_dump_member): Likewise.
1055         (ctf_dump_type): Likewise.
1056         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1057         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1058         (ctf_dump_header): Likewise.
1059         (ctf_dump_label): likewise.
1060         (ctf_dump_objts): likewise.
1061         (ctf_dump_funcs): likewise.
1062         (ctf_dump_var): likewise.
1063         (ctf_dump_str): Likewise.
1064
1065 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
1066
1067         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1068         (LT_INIT): Likewise.
1069         (AM_INSTALL_LIBBFD): Likewise.
1070         (dlopen): Note why this is necessary in a comment.
1071         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1072         opcodes/.
1073         (SHARED_LDFLAGS): Likewise.
1074         (BFD_LIBADD): Likewise, for libbfd.
1075         (BFD_DEPENDENCIES): Likewise.
1076         (VERSION_FLAGS): Initialize, using a version script if ld supports
1077         one, or libtool -export-symbols-regex otherwise.
1078         (AC_CONFIG_MACRO_DIR): Add ../BFD.
1079         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1080         (INCDIR): New.
1081         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1082         (noinst_LIBRARIES): Replace with...
1083         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1084         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1085         libctf-nobfd.la as well.
1086         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1087         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1088         (libctf_a_SOURCES): Rename to...
1089         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1090         ctf-open-bfd.c.
1091         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1092         with ctf-open-bfd.c added.
1093         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1094         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1095         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1096         * Makefile.am [INSTALL_LIBCTF]: Use it.
1097         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1098         libtool macros.
1099         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1100         the unstable components).
1101         * Makefile.in: Regenerated.
1102         * config.h.in: Likewise.
1103         * configure: Likewise.
1104
1105 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1106
1107         * configure.ac (INSTALL_LIBCTF): New, controlled by
1108         --enable-install-libctf.
1109         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1110         * Makefile.in: Regenerated.
1111         * configure: Regenerated.
1112
1113 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1114
1115         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1116         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1117
1118 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1119
1120         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1121
1122 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1123
1124         * ctf-impl.h (includes): Include <sys/param.h> here.
1125
1126 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1127
1128         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1129         (flip_objts): Likewise.
1130         (flip_vars): Likewise.
1131         (flip_types): Likewise.
1132
1133 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1134
1135         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1136         freeing functions: if set, free the key and value if the slot
1137         already exists.  Always reassign the key.
1138         (ctf_dynhash_insert): Adjust call appropriately.
1139         (ctf_hash_insert_type): Likewise.
1140
1141 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
1142
1143         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1144         type kind.  Allow forwards to unify with pre-existing structs/
1145         unions/enums.
1146
1147 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1148
1149         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1150         <ctf_link_memb_name_changer>: Likewise.
1151         <ctf_link_memb_name_changer_arg>: Likewise.
1152         * ctf-create.c (ctf_update): Update accordingly.
1153         * ctf-open.c (ctf_file_close): Likewise.
1154         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1155         (ctf_link_add_cu_mapping): New.
1156         (ctf_link_set_memb_name_changer): Likewise.
1157         (ctf_change_parent_name): New.
1158         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1159         allocated by the caller's ctf_link_memb_name_changer.
1160         <ndynames>: Likewise.
1161         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1162         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1163         ctf_change_parent_name.  Free any resulting names.
1164
1165 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1166
1167         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1168         (ctf_link_one_type): ... here, with parent-name setting added.
1169         (check_variable): New.
1170         (ctf_link_one_variable): Likewise.
1171         (ctf_link_one_input_archive_member): Call it.
1172         * ctf-error.c (_ctf_errlist): Updated with new errors.
1173
1174 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1175
1176         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1177         (struct ctf_link_type_mapping_key): New.
1178         (ctf_hash_type_mapping_key): Likewise.
1179         (ctf_hash_eq_type_mapping_key): Likewise.
1180         (ctf_add_type_mapping): Likewise.
1181         (ctf_type_mapping): Likewise.
1182         (ctf_dynhash_empty): Likewise.
1183         * ctf-open.c (ctf_file_close): Update accordingly.
1184         * ctf-create.c (ctf_update): Likewise.
1185         (ctf_add_type): Populate the mapping.
1186         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1187         (ctf_hash_eq_type_mapping_key): Check the key for equality.
1188         (ctf_dynhash_insert): Fix comment typo.
1189         (ctf_dynhash_empty): New.
1190         * ctf-link.c (ctf_add_type_mapping): New.
1191         (ctf_type_mapping): Likewise.
1192         (empty_link_type_mapping): New.
1193         (ctf_link_one_input_archive): Call it.
1194
1195 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1196
1197         * ctf-link.c: New file, linking of the string and type sections.
1198         * Makefile.am (libctf_a_SOURCES): Add it.
1199         * Makefile.in: Regenerate.
1200
1201         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1202         ctf_link_outputs.
1203         * ctf-create.c (ctf_update): Update accordingly.
1204         * ctf-open.c (ctf_file_close): Likewise.
1205         * ctf-error.c (_ctf_errlist): Updated with new errors.
1206
1207 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1208
1209         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1210
1211 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1212
1213         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1214         ctf_type_iter.
1215         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1216         (ctf_dump_format_type): Add non-root-type { } notation.
1217         Add root flag to prototype.
1218         (ctf_dump_label): Adjust accordingly.
1219         (ctf_dump_objts): Likewise.
1220         (ctf_dump_var): Likewise.
1221
1222 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1223
1224         * ctf-create.c (ctf_compress_write): Fix double-free.
1225
1226 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1227
1228         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1229         of...
1230         (ctf_arc_write_fd): ... this new function.
1231         * ctf-create.c (ctf_write_mem): New.
1232
1233 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1234
1235         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1236         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1237         (ctf_str_add_ref): Name the last arg.
1238         (ctf_str_add_external) New.
1239         (ctf_str_add_strraw_explicit): Likewise.
1240         (ctf_simple_open_internal): Likewise.
1241         (ctf_bufopen_internal): Likewise.
1242
1243         * ctf-string.c (ctf_strraw_explicit): Split from...
1244         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1245         (ctf_str_add_ref_internal): Return the atom, not the
1246         string.
1247         (ctf_str_add): Adjust accordingly.
1248         (ctf_str_add_ref): Likewise.  Move up in the file.
1249         (ctf_str_add_external): New: update the csa_offset.
1250         (ctf_str_count_strtab): Only account for strings with no csa_offset
1251         in the internal strtab length.
1252         (ctf_str_write_strtab): If the csa_offset is set, update the
1253         string's refs without writing the string out, and update the
1254         ctf_syn_ext_strtab.  Make OOM handling less ugly.
1255         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1256         (ctf_update): Handle failure to populate the strtab.  Pass in the
1257         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
1258         Call ctf_simple_open_internal, not ctf_simple_open.
1259         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1260         strings by hand.
1261         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1262         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
1263         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1264         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1265         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1266         (ctf_simple_open_internal): ... this new function, which calls
1267         ctf_bufopen_internal.
1268         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1269         (ctf_bufopen_internal): ... this new function, which sets
1270         ctf_syn_ext_strtab.
1271
1272 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1273
1274         * ctf_types.c (ctf_type_iter_all): New.
1275
1276 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1277
1278         * ctf-open.c (init_symtab): Check for overflow against the right
1279         section.
1280         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1281         (upgrade_types_v1): Note that these sections are not checked.
1282         (flip_header): Endian-swap the header fields.
1283         (flip_ctf): Endian-swap the sections.
1284         (flip_objts): Update comment.
1285         (ctf_bufopen): Check header offsets and alignment for validity.
1286
1287 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1288
1289         * ctf-open-bfd.c: Add <assert.h>.
1290         (ctf_bfdopen_ctfsect): Open string and symbol tables using
1291         techniques borrowed from bfd_elf_sym_name.
1292         (ctf_new_archive_internal): Improve comment.
1293         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1294         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1295         no symbol section, but not vice versa.
1296
1297 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1298
1299         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1300         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1301         * ctf-dump.c (dump_header): New function, dump the CTF header.
1302         (ctf_dump): Call it.
1303         (ctf_dump_header_strfield): New function.
1304         (ctf_dump_header_sectfield): Likewise.
1305
1306 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1307
1308         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1309         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1310         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1311         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1312         Print out ctf_cuname: only print out ctf_parname if set.
1313         (ctf_free_base): Removed, ctf_base is no longer freed: free
1314         ctf_dynbase instead.
1315         (ctf_set_version): Fix spacing.
1316         (upgrade_header): New, in-place header upgrading.
1317         (upgrade_types): Rename to...
1318         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1319         longer track old and new headers separately.  No longer allow for
1320         header sizes explicitly: squeeze the headers out on upgrade (they
1321         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1322         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1323         (upgrade_types): New, also handle ctf_parmax updating.
1324         (flip_header): Flip ctf_cuname.
1325         (flip_types): Flip BUF explicitly rather than deriving BUF from
1326         BASE.
1327         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1328         required alignment of objtoff and funcoff.  No longer store it in
1329         the ctf_buf unless that buf is derived unmodified from the input.
1330         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1331         that duplicate fields in ctf_file: move allocation of ctf_file
1332         further up instead.  Call upgrade_header as needed.  Move
1333         version-specific ctf_parmax initialization into upgrade_types.  More
1334         concise error handling.
1335         (ctf_file_close): No longer test for null pointers before freeing.
1336         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1337         ctf_free_base.
1338         (ctf_cuname): New.
1339         (ctf_cuname_set): New.
1340         * ctf-create.c (ctf_update): Populate ctf_cuname.
1341         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1342         comment.
1343         (ctf_write): Likewise.
1344         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1345         Fix the compression length: fp->ctf_size never counted the CTF
1346         header.  Simplify the compress call accordingly.
1347
1348 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1349
1350         * ctf-endian.h: Don't assume htole64 and le64toh are always
1351         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1352         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1353         not bswap_identity_64.
1354
1355 2019-09-18  Alan Modra  <amodra@gmail.com>
1356
1357         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1358
1359 2019-09-09  Phil Blundell  <pb@pbcl.net>
1360
1361         binutils 2.33 branch created.
1362
1363 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1364
1365         * ctf-types.c (ctf_type_aname_raw): New.
1366         (ctf_func_type_info): Likewise.
1367         (ctf_func_type_args): Likewise.
1368         * ctf-error.c (_ctf_errlist): Fix description.
1369         * ctf-lookup.c: Fix file description.
1370
1371 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1372
1373         * ctf-create.c (ctf_create): Fix off-by-one error.
1374
1375 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1376
1377         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1378         struct ctf_strs.
1379         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1380         (struct ctf_str_atom): New, disambiguated single string.
1381         (struct ctf_str_atom_ref): New, points to some other location that
1382         references this string's offset.
1383         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1384         Remove member ctf_dtvstrlen: we no longer track the total strlen
1385         as we add strings.
1386         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1387         (ctf_str_free_atoms): Likewise.
1388         (ctf_str_add): Likewise.
1389         (ctf_str_add_ref): Likewise.
1390         (ctf_str_rollback): Likewise.
1391         (ctf_str_purge_refs): Likewise.
1392         (ctf_str_write_strtab): Likewise.
1393         (ctf_realloc): Declare new function in ctf-util.c.
1394
1395         * ctf-open.c (ctf_bufopen): Create the atoms table.
1396         (ctf_file_close): Destroy it.
1397         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1398         special-case the position of the parname string.  Construct the
1399         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1400         rest of each buffer element is constructed, not via open-coding:
1401         realloc the CTF buffer and append the strtab to it.  No longer
1402         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1403         strtab construction.
1404         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1405         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1406         after buffer element construction instead.
1407         (ctf_copy_lmembers): Likewise.
1408         (ctf_copy_emembers): Likewise.
1409         (ctf_create): No longer maintain the ctf_dtvstrlen.
1410         (ctf_dtd_delete): Likewise.
1411         (ctf_dvd_delete): Likewise.
1412         (ctf_add_generic): Likewise.
1413         (ctf_add_enumerator): Likewise.
1414         (ctf_add_member_offset): Likewise.
1415         (ctf_add_variable): Likewise.
1416         (membadd): Likewise.
1417         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1418         if there are active ctf_str_num_refs.
1419         (ctf_strraw): Move to ctf-string.c.
1420         (ctf_strptr): Likewise.
1421         * ctf-string.c: New file, strtab manipulation.
1422
1423         * Makefile.am (libctf_a_SOURCES): Add it.
1424         * Makefile.in: Regenerate.
1425
1426 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1427
1428         * ctf-impl.h (ctf_hash_iter_f): New.
1429         (ctf_dynhash_iter): New declaration.
1430         (ctf_dynhash_iter_remove): New declaration.
1431         * ctf-hash.c (ctf_dynhash_iter): Define.
1432         (ctf_dynhash_iter_remove): Likewise.
1433         (ctf_hashtab_traverse): New.
1434         (ctf_hashtab_traverse_remove): Likewise.
1435         (struct ctf_traverse_cb_arg): Likewise.
1436         (struct ctf_traverse_remove_cb_arg): Likewise.
1437
1438 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1439
1440         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1441
1442 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1443
1444         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1445         (ctf_dump_funcs): Likewise.
1446
1447 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1448
1449         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1450         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1451         little-endian CTF archive magic.  Do not check the CTF version:
1452         ctf_simple_open does that in endian-safe ways.  Do not dereference
1453         null pointers on open failure.
1454
1455 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1456
1457         * ctf-open.c (get_vbytes_common): Return the new slice size.
1458         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1459         Remember to copy in the CTF data when opening an uncompressed
1460         foreign-endian CTF file.  Prune useless variable manipulation.
1461
1462 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1463
1464         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1465         seen.
1466
1467 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1468
1469         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1470         output.
1471
1472 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1473
1474         * ctf-subr.c (_PAGESIZE): Remove.
1475         (ctf_data_alloc): Likewise.
1476         (ctf_data_free): Likewise.
1477         (ctf_data_protect): Likewise.
1478         * ctf-impl.h: Remove declarations.
1479         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1480         ctf_free, not ctf_data_free.
1481         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1482         the buffer again on compression error.
1483         * ctf-open.c (ctf_set_base): No longer track the size: call
1484         ctf_free, not ctf_data_free.
1485         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1486         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1487
1488 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1489
1490         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1491         ctf_dynhash_insert.
1492         (ctf_dvd_insert): Likewise.
1493         (ctf_add_generic): Likewise.
1494         (ctf_add_variable): Likewise.
1495         * ctf-impl.h: Adjust declarations.
1496
1497 2019-06-14  Alan Modra  <amodra@gmail.com>
1498
1499         * configure: Regenerate.
1500
1501 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1502
1503         * ctf-decls.h: Include <libiberty.h>.
1504         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1505
1506 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1507
1508         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1509         (ctf_dump_objts): Likewise.
1510         (ctf_dump_funcs): Likewise.
1511         (ctf_dump_member): Likewise.
1512         (ctf_dump_str): Likewise.
1513
1514 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1515
1516         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1517         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1518
1519 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1520
1521         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1522         (ctf_arc_open_by_offset): Likewise.
1523         * ctf-create.c (ctf_add_type): Likewise.
1524
1525 2019-06-04  Tom Tromey  <tromey@adacore.com>
1526
1527         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1528         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1529
1530 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1531
1532         * configure.ac: Check for O_CLOEXEC.
1533         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1534         * config.h.in: Regenerate.
1535         * configure: Likewise.
1536
1537 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1538
1539         * qsort_r.c: Rename to...
1540         * ctf-qsort_r.c: ... this.
1541         (_quicksort): Define to ctf_qsort_r.
1542         * ctf-decls.h (qsort_r): Remove.
1543         (ctf_qsort_r): Add.
1544         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1545         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1546         * Makefile.am (libctf_a_LIBADD): Remove.
1547         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1548         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1549         * ctf-create.c (ctf_update): Likewise.
1550         * configure.ac: Check for BSD versus GNU qsort_r signature.
1551         * Makefile.in: Regenerate.
1552         * config.h.in: Likewise.
1553         * configure: Likewise.
1554
1555 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1556
1557         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1558
1559 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1560
1561         * Makefile.am (ZLIB): New.
1562         (ZLIBINC): Likewise.
1563         (AM_CFLAGS): Use them.
1564         (libctf_a_LIBADD): New, for LIBOBJS.
1565         * configure.ac: Check for zlib, endian.h, and qsort_r.
1566         * ctf-endian.h: New, providing htole64 and le64toh.
1567         * swap.h: Code style fixes.
1568         (bswap_identity_64): New.
1569         * qsort_r.c: New, from gnulib (with one added #include).
1570         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1571         and unconditional definitions of MIN and MAX.
1572         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1573         (ctf_set_errno): Now returns unsigned long.
1574         * ctf-util.c (ctf_set_errno): Adjust here too.
1575         * ctf-archive.c: Use ctf-endian.h.
1576         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1577         cts_flags and cts_offset.
1578         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1579         * ctf-create.c: Provide a definition of roundup if not defined.
1580         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1581         (ctf_add_reftype): Do not check if type IDs are below zero.
1582         (ctf_add_slice): Likewise.
1583         (ctf_add_typedef): Likewise.
1584         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1585         when known error-free.  Drop CTF_ERR usage for functions returning
1586         int.
1587         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1588         int.
1589         (ctf_add_variable): Likewise.
1590         (enumcmp): Likewise.
1591         (enumadd): Likewise.
1592         (membcmp): Likewise.
1593         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1594         when known error-free.
1595         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1596         returning int: use CTF_ERR for functions returning ctf_type_id.
1597         (ctf_dump_label): Likewise.
1598         (ctf_dump_objts): Likewise.
1599         * ctf-labels.c (ctf_label_topmost): Likewise.
1600         (ctf_label_iter): Likewise.
1601         (ctf_label_info): Likewise.
1602         * ctf-lookup.c (ctf_func_args): Likewise.
1603         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1604         (ctf_bufopen): Likewise.  Use zlib types as needed.
1605         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1606         returning int.
1607         (ctf_enum_iter): Likewise.
1608         (ctf_type_size): Likewise.
1609         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1610         (ctf_type_kind_unsliced): Likewise.
1611         (ctf_type_kind): Likewise.
1612         (ctf_type_encoding): Likewise.
1613         (ctf_member_info): Likewise.
1614         (ctf_array_info): Likewise.
1615         (ctf_enum_value): Likewise.
1616         (ctf_type_rvisit): Likewise.
1617         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1618         cts_offset.
1619         (ctf_simple_open): Likewise.
1620         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1621         * Makefile.in: Regenerate.
1622         * aclocal.m4: Likewise.
1623         * config.h: Likewise.
1624         * configure: Likewise.
1625
1626 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1627
1628         * configure.in: Check for bfd_section_from_elf_index.
1629         * configure: Regenerate.
1630         * config.h.in [HAVE_BFD_ELF]: Likewise.
1631         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1632         abfd is potentially unused now.
1633
1634 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1635
1636         * Makefile.am: New.
1637         * Makefile.in: Regenerated.
1638         * config.h.in: Likewise.
1639         * aclocal.m4: Likewise.
1640         * configure: Likewise.
1641
1642 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1643
1644         * ctf-dump.c: New.
1645
1646 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1647
1648         * ctf-labels.c: New.
1649
1650 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1651
1652         * ctf-impl.h (_libctf_version): New declaration.
1653         * ctf-subr.c (_libctf_version): Define it.
1654         (ctf_version): New.
1655
1656 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1657
1658         * ctf-create.c (enumcmp): New.
1659         (enumadd): Likewise.
1660         (membcmp): Likewise.
1661         (membadd): Likewise.
1662         (ctf_add_type): Likewise.
1663
1664 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1665
1666         * ctf-lookup.c (isqualifier): New.
1667         (ctf_lookup_by_name): Likewise.
1668         (struct ctf_lookup_var_key): Likewise.
1669         (ctf_lookup_var): Likewise.
1670         (ctf_lookup_variable): Likewise.
1671         (ctf_lookup_symbol_name): Likewise.
1672         (ctf_lookup_by_symbol): Likewise.
1673         (ctf_func_info): Likewise.
1674         (ctf_func_args): Likewise.
1675
1676 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1677
1678         * ctf-decl.c: New file.
1679         * ctf-types.c: Likewise.
1680         * ctf-impl.h: New declarations.
1681
1682 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1683
1684         * ctf-open-bfd.c: New file.
1685         * ctf-open.c (ctf_close): New.
1686         * ctf-impl.h: Include bfd.h.
1687         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1688         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1689         ctfi_bfd_close.
1690         (ctf_bfdopen_ctfsect): New declaration.
1691         (_CTF_SECTION): likewise.
1692
1693 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1694
1695         * ctf-archive.c: New.
1696         * ctf-impl.h (ctf_archive_internal): New type.
1697         (ctf_arc_open_internal): New declaration.
1698         (ctf_arc_bufopen): Likewise.
1699         (ctf_arc_close_internal): Likewise.
1700
1701 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1702
1703         * ctf-open.c: New file.
1704         * swap.h: Likewise.
1705
1706 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1707
1708         * ctf-create.c: New file.
1709         * ctf-lookup.c: New file.
1710
1711 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1712
1713         * ctf-impl.h: New definitions and declarations for type creation
1714         and lookup.
1715
1716 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1717
1718         * ctf-hash.c: New file.
1719         * ctf-impl.h: New declarations.
1720
1721 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1722
1723         * ctf-error.c: New file.
1724
1725 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1726
1727         * ctf-util.c: New file.
1728         * elf.h: Likewise.
1729         * ctf-impl.h: Include it, and add declarations.
1730
1731 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1732
1733         * ctf-impl.h: New file.
1734         * ctf-subr.c: New file.
1735
1736 \f
1737 Local Variables:
1738 mode: change-log
1739 left-margin: 8
1740 fill-column: 76
1741 version-control: never
1742 End: