]> git.ipfire.org Git - thirdparty/openssl.git/blob - util/check-format.pl
Update copyright year
[thirdparty/openssl.git] / util / check-format.pl
1 #!/usr/bin/perl
2 #
3 # Copyright 2020-2021 The OpenSSL Project Authors. All Rights Reserved.
4 # Copyright Siemens AG 2019-2020
5 #
6 # Licensed under the Apache License 2.0 (the "License").
7 # You may not use this file except in compliance with the License.
8 # You can obtain a copy in the file LICENSE in the source distribution
9 # or at https://www.openssl.org/source/license.html
10 #
11 # check-format.pl
12 # - check formatting of C source according to OpenSSL coding style
13 #
14 # usage:
15 # check-format.pl [-l|--sloppy-len] [-l|--sloppy-bodylen]
16 # [-s|--sloppy-spc] [-c|--sloppy-cmt] [-m|--sloppy-macro]
17 # [-h|--sloppy-hang] [-1|--1-stmt]
18 # <files>
19 #
20 # run self-tests:
21 # util/check-format.pl util/check-format-test-positives.c
22 # util/check-format.pl util/check-format-test-negatives.c
23 #
24 # checks adherence to the formatting rules of the OpenSSL coding guidelines
25 # assuming that the input files contain syntactically correct C code.
26 # This pragmatic tool is incomplete and yields some false positives.
27 # Still it should be useful for detecting most typical glitches.
28 #
29 # options:
30 # -l | --sloppy-len increase accepted max line length from 80 to 84
31 # -l | --sloppy-bodylen do not report function body length > 200
32 # -s | --sloppy-spc do not report whitespace nits
33 # -c | --sloppy-cmt do not report indentation of comments
34 # Otherwise for each multi-line comment the indentation of
35 # its lines is checked for consistency. For each comment
36 # that does not begin to the right of normal code its
37 # indentation must be as for normal code, while in case it
38 # also has no normal code to its right it is considered to
39 # refer to the following line and may be indented equally.
40 # -m | --sloppy-macro allow missing extra indentation of macro bodies
41 # -h | --sloppy-hang when checking hanging indentation, do not report
42 # * same indentation as on line before
43 # * same indentation as non-hanging indent level
44 # * indentation moved left (not beyond non-hanging indent)
45 # just to fit contents within the line length limit
46 # -1 | --1-stmt do more aggressive checks for { 1 stmt } - see below
47 #
48 # There are non-trivial false positives and negatives such as the following.
49 #
50 # * When a line contains several issues of the same kind only one is reported.
51 #
52 # * When a line contains more than one statement this is (correctly) reported
53 # but in some situations the indentation checks for subsequent lines go wrong.
54 #
55 # * There is the special OpenSSL rule not to unnecessarily use braces around
56 # single statements:
57 # {
58 # stmt;
59 # }
60 # except within if ... else constructs where some branch contains more than one
61 # statement. Since the exception is hard to recognize when such branches occur
62 # after the current position (such that false positives would be reported)
63 # the tool by checks for this rule by defaul only for do/while/for bodies.
64 # Yet with the --1-stmt option false positives are preferred over negatives.
65 # False negatives occur if the braces are more than two non-empty lines apart.
66 #
67 # * Use of multiple consecutive spaces is regarded a coding style nit except
68 # when done in order to align certain columns over multiple lines, e.g.:
69 # # define AB 1
70 # # define CDE 22
71 # # define F 3333
72 # This pattern is recognized - and consequently double space not reported -
73 # for a given line if in the nonempty line before or after (if existing)
74 # for each occurrence of " \S" (where \S means non-space) in the given line
75 # there is " \S" in the other line in the respective column position.
76 # This may lead to both false negatives (in case of coincidental " \S")
77 # and false positives (in case of more complex multi-column alignment).
78 #
79 # * When just part of control structures depend on #if(n)(def), which can be
80 # considered bad programming style, indentation false positives occur, e.g.:
81 # #if X
82 # if (1) /* bad style */
83 # #else
84 # if (2) /* bad style resulting in false positive */
85 # #endif
86 # c; /* resulting further false positive */
87
88 use strict;
89 # use List::Util qw[min max];
90 use POSIX;
91
92 use constant INDENT_LEVEL => 4;
93 use constant MAX_LINE_LENGTH => 80;
94 use constant MAX_BODY_LENGTH => 200;
95
96 # global variables @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
97
98 # command-line options
99 my $max_length = MAX_LINE_LENGTH;
100 my $sloppy_bodylen = 0;
101 my $sloppy_SPC = 0;
102 my $sloppy_hang = 0;
103 my $sloppy_cmt = 0;
104 my $sloppy_macro = 0;
105 my $extended_1_stmt = 0;
106
107 while ($ARGV[0] =~ m/^-(\w|-[\w\-]+)$/) {
108 my $arg = $1; shift;
109 if ($arg =~ m/^(l|-sloppy-len)$/) {
110 $max_length += INDENT_LEVEL;
111 } elsif ($arg =~ m/^(b|-sloppy-bodylen)$/) {
112 $sloppy_bodylen = 1;
113 } elsif ($arg =~ m/^(s|-sloppy-spc)$/) {
114 $sloppy_SPC = 1;
115 } elsif ($arg =~ m/^(c|-sloppy-cmt)$/) {
116 $sloppy_cmt = 1;
117 } elsif ($arg =~ m/^(m|-sloppy-macro)$/) {
118 $sloppy_macro = 1;
119 } elsif ($arg =~ m/^(h|-sloppy-hang)$/) {
120 $sloppy_hang = 1;
121 } elsif ($arg =~ m/^(1|-1-stmt)$/) {
122 $extended_1_stmt = 1;
123 } else {
124 die("unknown option: -$arg");
125 }
126 }
127
128 # status variables
129 my $self_test; # whether the current input file is regarded to contain (positive/negative) self-tests
130 my $line; # current line number
131 my $line_before; # number of previous not essentially empty line (containing at most whitespace and '\')
132 my $line_before2; # number of not essentially empty line before previous not essentially empty line
133 my $contents; # contents of current line
134 my $contents_before; # contents of $line_before, if $line_before > 0
135 my $contents_before_; # contents of $line_before after blinding comments etc., if $line_before > 0
136 my $contents_before2; # contents of $line_before2, if $line_before2 > 0
137 my $contents_before_2; # contents of $line_before2 after blinding comments etc., if $line_before2 > 0
138 my $in_multiline_string; # line starts within multi-line string literal
139 my $count; # -1 or number of leading whitespace characters (except newline) in current line,
140 # which should be $block_indent + $hanging_offset + $local_offset or $expr_indent
141 my $count_before; # number of leading whitespace characters (except line ending chars) in $contents_before
142 my $has_label; # current line contains label
143 my $local_offset; # current extra indent due to label, switch case/default, or leading closing brace(s)
144 my $line_body_start; # number of line where last function body started, or 0
145 my $line_function_start; # number of line where last function definition started, used if $line_body_start != 0
146 my $last_function_header; # header containing name of last function defined, used if $line_function_start != 0
147 my $line_opening_brace; # number of previous line with opening brace after do/while/for, optionally for if/else
148
149 my $keyword_opening_brace; # name of previous keyword, used if $line_opening_brace != 0
150 my $ifdef__cplusplus; # line before contained '#ifdef __cplusplus' (used in header files)
151 my $block_indent; # currently required normal indentation at block/statement level
152 my $hanging_offset; # extra indent, which may be nested, for just one hanging statement or expr or typedef
153 my @in_do_hanging_offsets; # stack of hanging offsets for nested 'do' ... 'while'
154 my @in_if_hanging_offsets; # stack of hanging offsets for nested 'if' (but not its potential 'else' branch)
155 my $if_maybe_terminated; # 'if' ends and $hanging_offset should be reset unless the next line starts with 'else'
156 my @nested_block_indents; # stack of indentations at block/statement level, needed due to hanging statements
157 my @nested_hanging_offsets;# stack of nested $hanging_offset values, in parallel to @nested_block_indents
158 my @nested_in_typedecl; # stack of nested $in_typedecl values, partly in parallel to @nested_block_indents
159 my @nested_indents; # stack of hanging indents due to parentheses, braces, brackets, or conditionals
160 my @nested_symbols; # stack of hanging symbols '(', '{', '[', or '?', in parallel to @nested_indents
161 my @nested_conds_indents; # stack of hanging indents due to conditionals ('?' ... ':')
162 my $expr_indent; # resulting hanging indent within (multi-line) expressions including type exprs, else 0
163 my $hanging_symbol; # character ('(', '{', '[', not: '?') responsible for $expr_indent, if $expr_indent != 0
164 my $in_expr; # in expression after if/while/for/switch/return/enum/LHS of assignment
165 my $in_paren_expr; # in parenthesized if/while/for condition and switch expression, if $expr_indent != 0
166 my $in_typedecl; # nesting level of typedef/struct/union/enum
167 my $in_directive; # number of lines so far within preprocessor directive, e.g., macro definition
168 my $directive_nesting; # currently required indentation of preprocessor directive according to #if(n)(def)
169 my $directive_offset; # indent offset within multi-line preprocessor directive, if $in_directive > 0
170 my $in_macro_header; # number of open parentheses + 1 in (multi-line) header of #define, if $in_directive > 0
171 my $in_comment; # number of lines so far within multi-line comment, or < 0 when end is on current line
172 my $leading_comment; # multi-line comment has no code before its beginning delimiter
173 my $formatted_comment; # multi-line comment beginning with "/*-", which indicates/allows special formatting
174 my $comment_indent; # comment indent, if $in_comment != 0
175 my $num_reports_line = 0; # number of issues found on current line
176 my $num_reports = 0; # total number of issues found
177 my $num_indent_reports = 0;# total number of indentation issues found
178 my $num_nesting_issues = 0;# total number of directive nesting issues found
179 my $num_syntax_issues = 0; # total number of syntax issues found during sanity checks
180 my $num_SPC_reports = 0; # total number of whitespace issues found
181 my $num_length_reports = 0;# total number of line length issues found
182
183 sub reset_file_state {
184 $line = 0;
185 $line_before = 0;
186 $line_before2 = 0;
187 @nested_block_indents = ();
188 @nested_hanging_offsets = ();
189 @nested_in_typedecl = ();
190 @nested_symbols = ();
191 @nested_indents = ();
192 @nested_conds_indents = ();
193 $expr_indent = 0;
194 $in_paren_expr = 0;
195 $in_expr = 0;
196 $hanging_offset = 0;
197 @in_do_hanging_offsets = ();
198 @in_if_hanging_offsets = ();
199 $if_maybe_terminated = 0;
200 $block_indent = 0;
201 $ifdef__cplusplus = 0;
202 $in_multiline_string = 0;
203 $line_body_start = 0;
204 $line_opening_brace = 0;
205 $in_typedecl = 0;
206 $in_directive = 0;
207 $directive_nesting = 0;
208 $in_comment = 0;
209 }
210
211 # auxiliary submodules @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
212
213 sub report_flexibly {
214 my $line = shift;
215 my $msg = shift;
216 my $contents = shift;
217 my $report_SPC = $msg =~ /SPC/;
218 return if $report_SPC && $sloppy_SPC;
219
220 print "$ARGV:$line:$msg:$contents" unless $self_test;
221 $num_reports_line++;
222 $num_reports++;
223 $num_indent_reports++ if $msg =~ m/indent/;
224 $num_nesting_issues++ if $msg =~ m/directive nesting/;
225 $num_syntax_issues++ if $msg =~ m/unclosed|unexpected/;
226 $num_SPC_reports++ if $report_SPC;
227 $num_length_reports++ if $msg =~ m/length/;
228 }
229
230 sub report {
231 my $msg = shift;
232 report_flexibly($line, $msg, $contents);
233 }
234
235 sub parens_balance { # count balance of opening parentheses - closing parentheses
236 my $str = shift;
237 return $str =~ tr/\(// - $str =~ tr/\)//;
238 }
239
240 sub blind_nonspace { # blind non-space text of comment as @, preserving length and spaces
241 # the @ character is used because it cannot occur in normal program code so there is no confusion
242 # comment text is not blinded to whitespace in order to be able to check double SPC also in comments
243 my $comment_text = shift;
244 $comment_text =~ s/([\.\?\!])\s\s/$1. /g; # in double SPC checks allow one extra space after period '.', '?', or '!' in comments
245 return $comment_text =~ tr/ /@/cr;
246 }
247
248 # submodule for indentation checking/reporting @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
249
250 sub check_indent { # used for lines outside multi-line string literals
251 my $stmt_indent = $block_indent + $hanging_offset + $local_offset;
252 $stmt_indent = 0 if $stmt_indent < 0; # TODO maybe give warning/error
253 my $stmt_desc = $contents =~
254 m/^\s*\/\*/ ? "intra-line comment" :
255 $has_label ? "label" :
256 ($hanging_offset != 0 ? "hanging " : "").
257 ($hanging_offset != 0 ? "stmt/expr" : "stmt/decl"); # $in_typedecl is not fully to the point here
258 my ($ref_desc, $ref_indent) = $expr_indent == 0 ? ($stmt_desc, $stmt_indent)
259 : ("hanging '$hanging_symbol'", $expr_indent);
260 my ($alt_desc, $alt_indent) = ("", $ref_indent);
261
262 # allow indent 1 for labels - this cannot happen for leading ':'
263 ($alt_desc, $alt_indent) = ("outermost position", 1) if $expr_indent == 0 && $has_label;
264
265 if (@nested_conds_indents != 0 && substr($_, $count, 1) eq ":") {
266 # leading ':' within stmt/expr/decl - this cannot happen for labels, leading '&&', or leading '||'
267 # allow special indent at level of corresponding "?"
268 ($alt_desc, $alt_indent) = ("leading ':'", @nested_conds_indents[-1]);
269 }
270 # allow extra indent offset leading '&&' or '||' - this cannot happen for leading ":"
271 ($alt_desc, $alt_indent) = ("leading '$1'", $ref_indent + INDENT_LEVEL) if $contents =~ m/^[\s@]*(\&\&|\|\|)/;
272
273 if ($expr_indent < 0) { # implies @nested_symbols != 0 && @nested_symbols[0] eq "{" && @nested_indents[-1] < 0
274 # allow normal stmt indentation level for hanging initializer/enum expressions after trailing '{'
275 # this cannot happen for labels and overrides special treatment of ':', '&&' and '||' for this line
276 ($alt_desc, $alt_indent) = ("lines after '{'", $stmt_indent);
277 # decide depending on current actual indentation, preventing forth and back
278 @nested_indents[-1] = $count == $stmt_indent ? $stmt_indent : -@nested_indents[-1]; # allow $stmt_indent
279 $ref_indent = $expr_indent = @nested_indents[-1];
280 }
281
282 # check consistency of indentation within multi-line comment (i.e., between its first, inner, and last lines)
283 if ($in_comment != 0 && $in_comment != 1) { # in multi-line comment but not on its first line
284 if (!$sloppy_cmt) {
285 if ($in_comment > 0) { # not at its end
286 report("indent = $count != $comment_indent within multi-line comment")
287 if $count != $comment_indent;
288 } else {
289 my $tweak = $in_comment == -2 ? 1 : 0;
290 report("indent = ".($count + $tweak)." != $comment_indent at end of multi-line comment")
291 if $count + $tweak != $comment_indent;
292 }
293 }
294 # do not check indentation of last line of non-leading multi-line comment
295 if ($in_comment < 0 && !$leading_comment) {
296 s/^(\s*)@/$1*/; # blind first '@' as '*' to prevent below delayed check for the line before
297 return;
298 }
299 return if $in_comment > 0; # not on its last line
300 # $comment_indent will be checked by the below checks for end of multi-line comment
301 }
302
303 # else check indentation of entire-line comment or entire-line end of multi-line comment
304 # ... w.r.t. indent of the following line by delayed check for the line before
305 if (($in_comment == 0 || $in_comment == 1) # no comment, intra-line comment, or begin of multi-line comment
306 && $line_before > 0 # there is a line before
307 && $contents_before_ =~ m/^(\s*)@[\s@]*$/) { # line before begins with '@', no code follows (except '\')
308 report_flexibly($line_before, "entire-line comment indent = $count_before != $count (of following line)",
309 $contents_before) if !$sloppy_cmt && $count_before != $count;
310 }
311 # ... but allow normal indentation for the current line, else above check will be done for the line before
312 if (($in_comment == 0 || $in_comment < 0) # (no commment,) intra-line comment or end of multi-line comment
313 && m/^(\s*)@[\s@]*$/) { # line begins with '@', no code follows (except '\')
314 if ($count == $ref_indent) { # indentation is like for (normal) code in this line
315 s/^(\s*)@/$1*/; # blind first '@' as '*' to prevent above delayed check for the line before
316 return;
317 }
318 return if !eof; # defer check of entire-line comment to next line
319 }
320
321 # else check indentation of leading intra-line comment or end of multi-line comment
322 if (m/^(\s*)@/) { # line begins with '@', i.e., any (remaining type of) comment
323 if (!$sloppy_cmt && $count != $ref_indent) {
324 report("intra-line comment indent = $count != $ref_indent") if $in_comment == 0;
325 report("multi-line comment indent = $count != $ref_indent") if $in_comment < 0;
326 }
327 return;
328 }
329
330 if ($sloppy_hang && ($hanging_offset != 0 || $expr_indent != 0)) {
331 # do not report same indentation as on the line before (potentially due to same violations)
332 return if $line_before > 0 && $count == $count_before;
333
334 # do not report indentation at normal indentation level while hanging expression indent would be required
335 return if $expr_indent != 0 && $count == $stmt_indent;
336
337 # do not report if contents have been shifted left of nested expr indent (but not as far as stmt indent)
338 # apparently aligned to the right in order to fit within line length limit
339 return if $stmt_indent < $count && $count < $expr_indent &&
340 length($contents) == MAX_LINE_LENGTH + length("\n");
341 }
342
343 report("indent = $count != $ref_indent for $ref_desc".
344 ($alt_desc eq ""
345 || $alt_indent == $ref_indent # prevent showing alternative that happens to have equal value
346 ? "" : " or $alt_indent for $alt_desc"))
347 if $count != $ref_indent && $count != $alt_indent;
348 }
349
350 # submodules handling indentation within expressions @@@@@@@@@@@@@@@@@@@@@@@@@@@
351
352 sub update_nested_indents { # may reset $in_paren_expr and in this case also resets $in_expr
353 my $str = shift;
354 my $start = shift; # defaults to 0
355 my $terminator_position = -1;
356 for (my $i = $start; $i < length($str); $i++) {
357 my $c;
358 my $curr = substr($str, $i);
359 if ($curr =~ m/^(.*?)([{}()?:;\[\]])(.*)$/) { # match from position $i the first {}()?:;[]
360 $c = $2;
361 } else {
362 last;
363 }
364 my ($head, $tail) = (substr($str, 0, $i).$1, $3);
365 $i += length($1) + length($2) - 1;
366
367 # stop at terminator outside 'for(..;..;..)', assuming that 'for' is followed by '('
368 return $i if $c eq ";" && (!$in_paren_expr || @nested_indents == 0);
369
370 my $in_stmt = $in_expr || @nested_symbols != 0; # not: || $in_typedecl != 0
371 if ($c =~ m/[{([?]/) { # $c is '{', '(', '[', or '?'
372 if ($c eq "{") { # '{' in any context
373 # cancel newly hanging_offset if opening brace '{' is after non-whitespace non-comment:
374 $hanging_offset -= INDENT_LEVEL if $hanging_offset > 0 && $head =~ m/[^\s\@]/;
375 push @nested_block_indents, $block_indent;
376 push @nested_hanging_offsets, $in_expr ? $hanging_offset : 0;
377 push @nested_in_typedecl, $in_typedecl if $in_typedecl != 0;
378 $block_indent += INDENT_LEVEL + $hanging_offset;
379 $hanging_offset = 0;
380 }
381 if ($c ne "{" || $in_stmt) { # for '{' inside stmt/expr (not: decl), for '(', '[', or '?' anywhere
382 $tail =~ m/^([\s@]*)([^\s\@])/;
383 push @nested_indents, defined $2
384 ? $i + 1 + length($1) # actual indentation of following non-space non-comment
385 : $c ne "{" ? +($i + 1) # just after '(' or '[' if only whitespace thereafter
386 : -($i + 1); # allow also $stmt_indent if '{' with only whitespace thereafter
387 push @nested_symbols, $c; # done also for '?' to be able to check correct nesting
388 push @nested_conds_indents, $i if $c eq "?"; # remember special alternative indent for ':'
389 }
390 } elsif ($c =~ m/[})\]:]/) { # $c is '}', ')', ']', or ':'
391 my $opening_c = ($c =~ tr/})]:/{([/r);
392 if (($c ne ":" || $in_stmt # ignore ':' outside stmt/expr/decl
393 # in the presence of ':', one could add this sanity check:
394 # && !(# ':' after initial label/case/default
395 # $head =~ m/^([\s@]*)(case\W.*$|\w+$)/ || # this matching would not work for
396 # # multi-line expr after 'case'
397 # # bitfield length within unsigned type decl
398 # $tail =~ m/^[\s@]*\d+/ # this matching would need improvement
399 # )
400 )) {
401 if ($c ne "}" || $in_stmt) { # for '}' inside stmt/expr/decl, ')', ']', or ':'
402 if (@nested_symbols != 0 &&
403 @nested_symbols[-1] == $opening_c) { # for $c there was a corresponding $opening_c
404 pop @nested_indents;
405 pop @nested_symbols;
406 pop @nested_conds_indents if $opening_c eq "?";
407 } else {
408 report("unexpected '$c' @ ".($in_paren_expr ? "(expr)" : "expr"));
409 next;
410 }
411 }
412 if ($c eq "}") { # '}' at block level but also inside stmt/expr/decl
413 if (@nested_block_indents == 0) {
414 report("unexpected '}'");
415 } else {
416 $block_indent = pop @nested_block_indents;
417 $hanging_offset = pop @nested_hanging_offsets;
418 $in_typedecl = pop @nested_in_typedecl if @nested_in_typedecl != 0;
419 }
420 }
421 if ($in_paren_expr && !grep(/\(/, @nested_symbols)) { # end of (expr)
422 check_nested_nonblock_indents("(expr)");
423 $in_paren_expr = $in_expr = 0;
424 report("code after (expr)")
425 if $tail =~ m/^([^{]*)/ && $1 =~ m/[^\s\@;]/; # non-space non-';' before any '{'
426 }
427 }
428 }
429 }
430 return -1;
431 }
432
433 sub check_nested_nonblock_indents {
434 my $position = shift;
435 while (@nested_symbols != 0) {
436 my $symbol = pop @nested_symbols;
437 report("unclosed '$symbol' in $position");
438 if ($symbol eq "{") { # repair stack of blocks
439 $block_indent = pop @nested_block_indents;
440 $hanging_offset = pop @nested_hanging_offsets;
441 $in_typedecl = pop @nested_in_typedecl if @nested_in_typedecl != 0;
442 }
443 }
444 @nested_indents = ();
445 @nested_conds_indents = ();
446 }
447
448 # start of main program @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
449
450 reset_file_state();
451
452 while (<>) { # loop over all lines of all input files
453 $self_test = $ARGV =~ m/check-format-test/;
454 $line++;
455 s/\r$//; # strip any trailing CR '\r' (which are typical on Windows systems)
456 $contents = $_;
457
458 # check for illegal characters
459 if (m/(.*?)([\x00-\x09\x0B-\x1F\x7F-\xFF])/) {
460 my $col = length($1);
461 report(($2 eq "\x09" ? "TAB" : $2 eq "\x0D" ? "CR " : $2 =~ m/[\x00-\x1F]/ ? "non-printable"
462 : "non-7bit char") . " at column $col") ;
463 }
464
465 # check for whitespace at EOL
466 report("trailing whitespace at EOL") if m/\s\n$/;
467
468 # assign to $count the actual indentation level of the current line
469 chomp; # remove trailing NL '\n'
470 m/^(\s*)/;
471 $count = length($1); # actual indentation
472 $has_label = 0;
473 $local_offset = 0;
474
475 # character/string literals @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
476
477 s/\\["']/@@/g; # blind all '"' and "'" escaped by '\' (typically within character literals or string literals)
478
479 # handle multi-line string literals to avoid confusion on starting/ending '"' and trailing '\'
480 if ($in_multiline_string) {
481 if (s#^([^"]*)"#($1 =~ tr/"/@/cr).'@'#e) { # string literal terminated by '"'
482 # string contents and its terminating '"' have been blinded as '@'
483 $count = -1; # do not check indentation
484 } else {
485 report("multi-line string literal not terminated by '\"' and trailing '\' is missing")
486 unless s#^([^\\]*)\s*\\\s*$#$1#; # strip trailing '\' plus any whitespace around
487 goto LINE_FINISHED;
488 }
489 }
490
491 # blind contents of character and string literals as @, preserving length (but not spaces)
492 # this prevents confusing any of the matching below, e.g., of whitespace and comment delimiters
493 s#('[^']*')#$1 =~ tr/'/@/cr#eg; # handle all intra-line character literals
494 s#("[^"]*")#$1 =~ tr/"/@/cr#eg; # handle all intra-line string literals
495 $in_multiline_string = # handle trailing string literal terminated by '\'
496 s#^(([^"]*"[^"]*")*[^"]*)("[^"]*)\\(\s*)$#$1.($3 =~ tr/"/@/cr).'"'.$4#e;
497 # its contents have been blinded and the trailing '\' replaced by '"'
498
499 # strip any other trailing '\' along with any whitespace around it such that it does not interfere with various
500 # matching below; the later handling of multi-line macro definitions uses $contents where it is not stripped
501 s#^(.*?)\s*\\\s*$#$1#; # trailing '\' possibly preceded and/or followed by whitespace
502
503 # comments @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
504
505 # do/prepare checks within multi-line comments
506 my $self_test_exception = $self_test ? "@" : "";
507 if ($in_comment > 0) { # this still includes the last line of multi-line commment
508 my ($head, $any_symbol, $cmt_text) = m/^(\s*)(.?)(.*)$/;
509 if ($any_symbol eq "*") {
510 report("no SPC after leading '*' in multi-line comment") if $cmt_text =~ m|^[^/\s$self_test_exception]|;
511 } else {
512 report("no leading '*' in multi-line comment");
513 }
514 $in_comment++;
515 }
516
517 # detect end of comment, must be within multi-line comment, check if it is preceded by non-whitespace text
518 if ((my ($head, $tail) = m|^(.*?)\*/(.*)$|) && $1 ne '/') { # ending comment: '*/'
519 report("neither SPC nor '*' before '*/'") if $head =~ m/[^*\s]$/;
520 report("no SPC after '*/'") if $tail =~ m/^[^\s,;)}\]]/; # no space or ,;)}] after '*/'
521 if (!($head =~ m|/\*|)) { # not begin of comment '/*', which is is handled below
522 if ($in_comment == 0) {
523 report("unexpected '*/' outside comment");
524 $_ = "$head@@".$tail; # blind the "*/"
525 } else {
526 report("text before '*/' in multi-line comment") if ($head =~ m/\S/); # non-SPC before '*/'
527 $in_comment = -1; # indicate that multi-line comment ends on current line
528 if ($count > 0) {
529 # make indentation of end of multi-line comment appear like of leading intra-line comment
530 $head =~ s/^(\s*)\s/$1@/; # replace the last leading space by '@'
531 $count--;
532 $in_comment = -2; # indicate that multi-line comment ends on current line, with tweak
533 }
534 my $cmt_text = $head;
535 $_ = blind_nonspace($cmt_text)."@@".$tail;
536 }
537 }
538 }
539
540 # detect begin of comment, check if it is followed by non-space text
541 MATCH_COMMENT:
542 if (my ($head, $opt_minus, $tail) = m|^(.*?)/\*(-?)(.*)$|) { # begin of comment: '/*'
543 report("no SPC before '/*'")
544 if $head =~ m/[^\s(\*]$/; # not space, '(', or or '*' (needed to allow '*/') before comment delimiter
545 report("neither SPC nor '*' after '/*' or '/*-'") if $tail =~ m/^[^\s*$self_test_exception]/;
546 my $cmt_text = $opt_minus.$tail; # preliminary
547 if ($in_comment > 0) {
548 report("unexpected '/*' inside multi-line comment");
549 } elsif ($tail =~ m|^(.*?)\*/(.*)$|) { # comment end: */ on same line
550 report("unexpected '/*' inside intra-line comment") if $1 =~ /\/\*/;
551 # blind comment text, preserving length and spaces
552 ($cmt_text, my $rest) = ($opt_minus.$1, $2);
553 $_ = "$head@@".blind_nonspace($cmt_text)."@@".$rest;
554 goto MATCH_COMMENT;
555 } else { # begin of multi-line comment
556 my $self_test_exception = $self_test ? "(@\d?)?" : "";
557 report("text after '/*' in multi-line comment")
558 unless $tail =~ m/^$self_test_exception.?\s*$/;
559 # tail not essentially empty, first char already checked
560 # adapt to actual indentation of first line
561 $comment_indent = length($head) + 1;
562 $_ = "$head@@".blind_nonspace($cmt_text);
563 $in_comment = 1;
564 $leading_comment = $head =~ m/^\s*$/; # there is code before beginning delimiter
565 $formatted_comment = $opt_minus eq "-";
566 }
567 }
568
569 if ($in_comment > 1) { # still inside multi-line comment (not at its begin or end)
570 m/^(\s*)\*?(\s*)(.*)$/;
571 $_ = $1."@".$2.blind_nonspace($3);
572 }
573
574 # handle special case of line after '#ifdef __cplusplus' (which typically appears in header files)
575 if ($ifdef__cplusplus) {
576 $ifdef__cplusplus = 0;
577 $_ = "$1 $2" if $contents =~ m/^(\s*extern\s*"C"\s*)\{(\s*)$/; # ignore opening brace in 'extern "C" {'
578 goto LINE_FINISHED if m/^\s*\}\s*$/; # ignore closing brace '}'
579 }
580
581 # check for over-long lines,
582 # while allowing trailing (also multi-line) string literals to go past $max_length
583 my $len = length; # total line length (without trailing '\n')
584 if ($len > $max_length &&
585 !(m/^(.*)"[^"]*"\s*[\)\}\]]*[,;]?\s*$/ # string literal terminated by '"' (or '\'), then maybe )}],;
586 && length($1) < $max_length)
587 # this allows over-long trailing string literals with beginning col before $max_length
588 ) {
589 report("line length = $len > ".MAX_LINE_LENGTH);
590 }
591
592 # handle C++ / C99 - style end-of-line comments
593 if (my ($head, $cmt_text) = m|^(.*?)//(.*$)|) {
594 report("'//' end-of-line comment"); # the '//' comment style is not allowed for C90
595 # blind comment text, preserving length and spaces
596 $_ = "$head@@".blind_nonspace($cmt_text);
597 }
598
599 # at this point all non-space portions of any types of comments have been blinded as @
600
601 goto LINE_FINISHED if m/^\s*$/; # essentially empty line: just whitespace (and maybe a trailing '\')
602
603 # intra-line whitespace nits @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
604
605 my $in_multiline_comment = ($in_comment > 1 || $in_comment < 0); # $in_multiline_comment refers to line before
606 if (!$sloppy_SPC && !($in_multiline_comment && $formatted_comment)) {
607 sub dbl_SPC {
608 my $intra_line = shift;
609 return "double SPC".($intra_line =~ m/@\s\s/ ?
610 $in_comment != 0 ? " in multi-line comment"
611 : " in intra-line comment" : "");
612 }
613 sub split_line_head {
614 my $comment_symbol =
615 $in_comment != 0 ? "@" : ""; # '@' will match the blinded leading '*' in multi-line comment
616 # $in_comment may pertain to the following line due to delayed check
617 # do not check for double SPC in leading spaces including any '#' (or '*' within multi-line comment)
618 shift =~ m/^(\s*([#$comment_symbol]\s*)?)(.*?)\s*$/;
619 return ($1, $3);
620 }
621 my ($head , $intra_line ) = split_line_head($_);
622 my ($head1, $intra_line1) = split_line_head($contents_before_ ) if $line_before > 0;
623 my ($head2, $intra_line2) = split_line_head($contents_before_2) if $line_before2 > 0;
624 if ($line_before > 0) { # check with one line delay, such that at least $contents_before is available
625 sub column_alignments_only {
626 my $head = shift;
627 my $intra = shift;
628 my $contents = shift;
629 # check if all double SPC in $intra is used only for multi-line column alignment with $contents
630 my $offset = length($head);
631 for (my $col = 0; $col < length($intra) - 2; $col++) {
632 return 0 if substr($intra , $col, 3) =~ m/\s\s\S/ # double space (after leading space)
633 && !(substr($contents, $col + $offset + 1, 2) =~ m/\s\S/)
634 }
635 return 1;
636 }
637 report_flexibly($line_before, dbl_SPC($intra_line1), $contents_before) if $intra_line1 =~ m/\s\s\S/ &&
638 !( column_alignments_only($head1, $intra_line1, $_ ) # compare with $line
639 || ($line_before2 > 0 &&
640 column_alignments_only($head1, $intra_line1, $contents_before_2))); # compare w/ $line_before2
641 report(dbl_SPC($intra_line)) if $intra_line =~ m/\s\s\S/ && eof
642 && ! column_alignments_only($head , $intra_line , $contents_before_ ) ; # compare w/ $line_before
643 } elsif (eof) { # special case: just one line exists
644 report(dbl_SPC($intra_line)) if $intra_line =~ m/\s\s\S/;
645 }
646 # ignore paths in #include
647 $intra_line =~ s/^(include\s*)(".*?"|<.*?>)/$1/e if $head =~ m/#/;
648 # treat op= and comparison operators as simple '=', simplifying matching below
649 $intra_line =~ s/([\+\-\*\/\/%\&\|\^\!<>=]|<<|>>)=/=/g;
650 # treat (type) variables within macro, indicated by trailing '\', as 'int' simplifying matching below
651 $intra_line =~ s/[A-Z_]+/int/g if $contents =~ m/^(.*?)\s*\\\s*$/;
652 # treat double &&, ||, <<, and >> as single ones, simplifying matching below
653 $intra_line =~ s/(&&|\|\||<<|>>)/substr($1, 0, 1)/eg;
654 # remove blinded comments etc. directly after [{(
655 while ($intra_line =~ s/([\[\{\(])@+\s?/$1/e) {} # /g does not work here
656 # remove blinded comments etc. directly before ,;)}]
657 while ($intra_line =~ s/\s?@+([,;\)\}\]])/$1/e) {} # /g does not work here
658 # treat remaining blinded comments and string literal contents as (single) space during matching below
659 $intra_line =~ s/@+/ /g; # note that double SPC has already been handled above
660 $intra_line =~ s/\s+$//; # strip any (resulting) space at EOL
661 $intra_line =~ s/(for\s*\([^;]*);;(\))/"$1$2"/eg; # strip trailing ';;' in for (;;)
662 $intra_line =~ s/(for\s*\([^;]+;[^;]+);(\))/"$1$2"/eg; # strip trailing ';' in for (;;)
663 $intra_line =~ s/(=\s*)\{ /"$1@ "/eg; # do not report {SPC in initializers such as ' = { 0, };'
664 $intra_line =~ s/, \};/, @;/g; # do not report SPC} in initializers such as ' = { 0, };'
665 report("SPC before '$1'") if $intra_line =~ m/[\w)\]]\s+(\+\+|--)/; # postfix ++/-- with preceding space
666 report("SPC after '$1'") if $intra_line =~ m/(\+\+|--)\s+[a-zA-Z_(]/; # prefix ++/-- with following space
667 $intra_line =~ s/\.\.\./@/g; # blind '...'
668 report("SPC before '$1'") if $intra_line =~ m/\s(\.|->)/; # '.' or '->' with preceding space
669 report("SPC after '$1'") if $intra_line =~ m/(\.|->)\s/; # '.' or '->' with following space
670 $intra_line =~ s/\-\>|\+\+|\-\-/@/g; # blind '->,', '++', and '--'
671 report("SPC before '$2'") if $intra_line =~ m/[^:]\s+(;)/; # space before ';' but not after ':'
672 report("SPC before '$1'") if $intra_line =~ m/\s([,)\]])/; # space before ,)]
673 report("SPC after '$1'") if $intra_line =~ m/([(\[~!])\s/; # space after ([~!
674 report("SPC after '$1'") if $intra_line =~ m/(defined)\s/; # space after 'defined'
675 report("no SPC before '=' or '<op>='") if $intra_line =~ m/\S(=)/; # '=' etc. without preceding space
676 report("no SPC before '$1'") if $intra_line =~ m/\S([|\/%<>^\?])/; # |/%<>^? without preceding space
677 # TODO ternary ':' without preceding SPC, while allowing no SPC before ':' after 'case'
678 report("no SPC before binary '$1'") if $intra_line =~ m/[^\s{()\[]([+\-])/;# +/- without preceding space or {()[
679 # or ')' (which is used f type casts)
680 report("no SPC before binary '$1'") if $intra_line =~ m/[^\s{()\[*]([*])/; # '*' without preceding space or {()[*
681 report("no SPC before binary '$1'") if $intra_line =~ m/[^\s{()\[]([&])/; # '&' without preceding space or {()[
682 report("no SPC after ternary '$1'") if $intra_line =~ m/(:)[^\s\d]/; # ':' without following space or digit
683 report("no SPC after '$1'") if $intra_line =~ m/([,;=|\/%<>^\?])\S/; # ,;=|/%<>^? without following space
684 report("no SPC after binary '$1'") if $intra_line=~m/[^{(\[]([*])[^\sa-zA-Z_(),*]/;# '*' w/o space or \w(),* after
685 # TODO unary '*' must not be followed by SPC
686 report("no SPC after binary '$1'") if $intra_line=~m/([&])[^\sa-zA-Z_(]/; # '&' w/o following space or \w(
687 # TODO unary '&' must not be followed by SPC
688 report("no SPC after binary '$1'") if $intra_line=~m/[^{(\[]([+\-])[^\s\d(]/; # +/- w/o following space or \d(
689 # TODO unary '+' and '-' must not be followed by SPC
690 report("no SPC after '$2'") if $intra_line =~ m/(^|\W)(if|while|for|switch|case)[^\w\s]/; # kw w/o SPC
691 report("no SPC after '$2'") if $intra_line =~ m/(^|\W)(return)[^\w\s;]/; # return w/o SPC or ';'
692 report("SPC after function/macro name")
693 if $intra_line =~ m/(\w+)\s+\(/ # fn/macro name with space before '('
694 && !($1 =~ m/^(if|while|for|switch|return|typedef|void|char|unsigned|int|long|float|double)$/) # not keyword
695 && !(m/^\s*#\s*define\s/); # we skip macro definitions here because macros
696 # without parameters but with body beginning with '(', e.g., '#define X (1)',
697 # would lead to false positives - TODO also check for macros with parameters
698 report("no SPC before '{'") if $intra_line =~ m/[^\s{(\[]\{/; # '{' without preceding space or {([
699 report("no SPC after '}'") if $intra_line =~ m/\}[^\s,;\])}]/; # '}' without following space or ,;])}
700 }
701
702 # preprocessor directives @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
703
704 # handle preprocessor directives
705 if (m/^\s*#(\s*)(\w+)/) { # line beginning with '#'
706 my $space_count = length($1); # maybe could also use indentation before '#'
707 my $directive = $2;
708 report("indent = $count != 0 for '#'") if $count != 0;
709 $directive_nesting-- if $directive =~ m/^(else|elif|endif)$/;
710 if ($directive_nesting < 0) {
711 $directive_nesting = 0;
712 report("unexpected '#$directive'");
713 }
714 report("'#' directive nesting = $space_count != $directive_nesting") if $space_count != $directive_nesting;
715 $directive_nesting++ if $directive =~ m/^if|ifdef|ifndef|else|elif$/;
716 $ifdef__cplusplus = m/^\s*#\s*ifdef\s+__cplusplus\s*$/;
717 goto POSTPROCESS_DIRECTIVE unless $directive =~ m/^define$/; # skip normal code handling except for #define
718 # TODO improve handling of indents of preprocessor directives ('\', $in_directive != 0) vs. normal C code
719 $count = -1; # do not check indentation of #define
720 }
721
722 # adapt required indentation @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
723
724 s/(\w*ASN1_[A-Z_]+END\w*([^(]|\(.*?\)|$))/$1;/g; # treat *ASN1_*END*(..) macro calls as if followed by ';'
725
726 my $nested_indents_position = 0;
727
728 # update indents according to leading closing brace(s) '}' or label or switch case
729 my $in_stmt = $in_expr || @nested_symbols != 0 || $in_typedecl != 0;
730 if ($in_stmt) { # expr/stmt/type decl/var def/fn hdr, i.e., not at block level
731 if (m/^([\s@]*\})/) { # leading '}', any preceding blinded comment must not be matched
732 my $head = $1;
733 update_nested_indents($head);
734 $nested_indents_position = length($head);
735 if (@nested_symbols >= 1) {
736 $hanging_symbol = @nested_symbols[-1];
737 $expr_indent = @nested_indents[-1];
738 } else { # typically end of initialiizer expr or enum
739 $expr_indent = 0;
740 }
741 } elsif (m/^([\s@]*)(static_)?ASN1_ITEM_TEMPLATE_END(\W|$)/) { # workaround for ASN1 macro indented as '}'
742 $local_offset = -INDENT_LEVEL;
743 $expr_indent = 0;
744 } elsif (m/;.*?\}/) { # expr ends with ';' before '}'
745 report("code before '}'");
746 }
747 }
748 if (@in_do_hanging_offsets != 0 && # note there is nothing like "unexpected 'while'"
749 m/^[\s@]*while(\W|$)/) { # leading 'while'
750 $hanging_offset = pop @in_do_hanging_offsets;
751 }
752 if ($if_maybe_terminated) {
753 if (m/(^|\W)else(\W|$)/) { # (not necessarily leading) 'else'
754 if (@in_if_hanging_offsets == 0) {
755 report("unexpected 'else'");
756 } else {
757 $hanging_offset = pop @in_if_hanging_offsets;
758 }
759 } else {
760 @in_if_hanging_offsets = (); # note there is nothing like "unclosed 'if'"
761 $hanging_offset = 0;
762 }
763 }
764 if (!$in_stmt) { # at block level, i.e., outside expr/stmt/type decl/var def/fn hdr
765 $if_maybe_terminated = 0;
766 if (my ($head, $before, $tail) = m/^([\s@]*([^{}]*)\})[\s@]*(.*)$/) { # leading closing '}', but possibly
767 # with non-whitespace non-'{' before
768 report("code after '}'") unless $tail eq "" || $tail =~ m/(else|while|OSSL_TRACE_END)(\W|$)/;
769 my $outermost_level = @nested_block_indents == 1 && @nested_block_indents[0] == 0;
770 if (!$sloppy_bodylen && $outermost_level && $line_body_start != 0) {
771 my $body_len = $line - $line_body_start - 1;
772 report_flexibly($line_function_start, "function body length = $body_len > ".MAX_BODY_LENGTH." lines",
773 $last_function_header) if $body_len > MAX_BODY_LENGTH;
774 $line_body_start = 0;
775 }
776 if ($before ne "") { # non-whitespace non-'{' before '}'
777 report("code before '}'");
778 } else { # leading '}', any preceding blinded comment must not be matched
779 $local_offset = $block_indent + $hanging_offset - INDENT_LEVEL;
780 update_nested_indents($head);
781 $nested_indents_position = length($head);
782 $local_offset -= ($block_indent + $hanging_offset);
783 # in effect $local_offset = -INDENT_LEVEL relative to $block_indent + $hanging_offset values before
784 }
785 }
786
787 # handle opening brace '{' after if/else/while/for/switch/do on line before
788 if ($hanging_offset > 0 && m/^[\s@]*{/ && # leading opening '{'
789 $line_before > 0 &&
790 $contents_before_ =~ m/(^|^.*\W)(if|else|while|for|switch|do)(\W.*$|$)/) {
791 $keyword_opening_brace = $1;
792 $hanging_offset -= INDENT_LEVEL; # cancel newly hanging_offset
793 }
794
795 if (m/^[\s@]*(case|default)(\W.*$|$)/) { # leading 'case' or 'default'
796 my $keyword = $1;
797 report("code after $keyword: ") if $2 =~ /:.*[^\s@].*$/;
798 $local_offset = -INDENT_LEVEL;
799 } else {
800 if (m/^([\s@]*)(\w+):/) { # (leading) label, cannot be "default"
801 $local_offset = -INDENT_LEVEL;
802 $has_label = 1;
803 }
804 }
805 }
806
807 # potential adaptations of indent in first line of macro body in multi-line macro definition
808 if ($in_directive > 0 && $in_macro_header > 0) {
809 if ($in_macro_header > 1) { # still in macro definition header
810 $in_macro_header += parens_balance($_);
811 } else { # begin of macro body
812 $in_macro_header = 0;
813 if ($count == $block_indent - $directive_offset # body began with same indentation as preceding code
814 && $sloppy_macro) { # workaround for this situation is enabled
815 $block_indent -= $directive_offset;
816 $directive_offset = 0;
817 }
818 }
819 }
820
821 # check required indentation @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
822
823 check_indent() if $count >= 0; # not for #define and not if multi-line string literal is continued
824
825 $in_comment = 0 if $in_comment < 0; # multi-line comment has ended
826
827 # do some further checks @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
828
829 my $outermost_level = $block_indent == 0 + ($in_directive > 0 ? $directive_offset : 0);
830
831 report("more than one stmt") if !m/(^|\W)for(\W.*|$)/ && # no 'for' - TODO improve matching
832 m/;.*;/; # two or more terminators ';', so more than one statement
833
834 # check for code block containing a single line/statement
835 if ($line_before2 > 0 && !$outermost_level && # within function body
836 $in_typedecl == 0 && @nested_indents == 0 && # neither within type declaration nor inside stmt/expr
837 m/^[\s@]*\}/) { # leading closing brace '}', any preceding blinded comment must not be matched
838 # TODO extend detection from single-line to potentially multi-line statement
839 if ($line_opening_brace > 0 &&
840 ($line_opening_brace == $line_before2 ||
841 $line_opening_brace == $line_before)
842 && $contents_before =~ m/;/) { # there is at least one terminator ';', so there is some stmt
843 # TODO do not report cases where a further else branch
844 # follows with a block containg more than one line/statement
845 report_flexibly($line_before, "'$keyword_opening_brace' { 1 stmt }", $contents_before);
846 }
847 }
848
849 report("one-letter name '$2'") if (m/(^|.*\W)([lIO])(\W.*|$)/); # single-letter name 'l', 'I', or 'O'
850
851 # TODO report empty line within local variable definitions
852
853 # TODO report missing empty line after local variable definitions
854
855 # TODO report needless use of parentheses, while
856 # macro parameters should always be in parens (except when passed on), e.g., '#define ID(x) (x)'
857
858 # adapt required indentation for following lines @@@@@@@@@@@@@@@@@@@@@@@@@@@
859
860 # set $in_expr, $in_paren_expr, and $hanging_offset for if/while/for/switch, return/enum, and assignment RHS
861 my $paren_expr_start = 0;
862 my $return_enum_start = 0;
863 my $assignment_start = 0;
864 my $tmp = $_;
865 $tmp =~ s/[\!<>=]=/@@/g; # blind (in-)equality symbols like '<=' as '@@' to prevent matching them as '=' below
866 if (m/^((^|.*\W)(if|while|for|switch))(\W.*|$)$/) { # (last) if/for/while/switch
867 $paren_expr_start = 1;
868 } elsif (m/^((^|.*\W)(return|enum))(\W.*|$)/ # (last) return/enum
869 && !$in_expr && @nested_indents == 0 && parens_balance($1) == 0) { # not nested enum
870 $return_enum_start = 1;
871 } elsif ($tmp =~ m/^(([^=]*)(=))(.*)$/ # (last) '=', i.e., assignment
872 && !$in_expr && @nested_indents == 0 && parens_balance($1) == 0) { # not nested assignment
873 $assignment_start = 1;
874 }
875 if ($paren_expr_start || $return_enum_start || $assignment_start)
876 {
877 my ($head, $mid, $tail) = ($1, $3, $4);
878 $keyword_opening_brace = $mid if $mid ne "=";
879 # to cope with multi-line expressions, do this also if !($tail =~ m/\{/)
880 push @in_if_hanging_offsets, $hanging_offset if $mid eq "if";
881
882 # already handle $head, i.e., anything before expression
883 update_nested_indents($head, $nested_indents_position);
884 $nested_indents_position = length($head);
885 # now can set $in_expr and $in_paren_expr
886 $in_expr = 1;
887 $in_paren_expr = 1 if $paren_expr_start;
888 if ($mid eq "while" && @in_do_hanging_offsets != 0) {
889 $hanging_offset = pop @in_do_hanging_offsets;
890 } else {
891 $hanging_offset += INDENT_LEVEL; # tentatively set hanging_offset, may be canceled by following '{'
892 }
893 }
894
895 # set $hanging_offset and $keyword_opening_brace for do/else
896 if (my ($head, $mid, $tail) = m/(^|^.*\W)(else|do)(\W.*|$)$/) { # last else/do, where 'do' is preferred
897 my $code_before = $head =~ m/[^\s\@}]/; # leading non-whitespace non-comment non-'}'
898 report("code before '$mid'") if $code_before;
899 report("code after '$mid'" ) if $tail =~ m/[^\s\@{]/# trailing non-whitespace non-comment non-'{' (non-'\')
900 && !($mid eq "else" && $tail =~ m/[\s@]*if(\W|$)/);
901 if ($mid eq "do") { # workarounds for code before 'do'
902 if ($head =~ m/(^|^.*\W)(else)(\W.*$|$)/) { # 'else' ... 'do'
903 $hanging_offset += INDENT_LEVEL; # tentatively set hanging_offset, may be canceled by following '{'
904 }
905 if ($head =~ m/;/) { # terminator ';' ... 'do'
906 @in_if_hanging_offsets = (); # note there is nothing like "unclosed 'if'"
907 $hanging_offset = 0;
908 }
909 }
910 push @in_do_hanging_offsets, $hanging_offset if $mid eq "do";
911 if ($code_before && $mid eq "do") {
912 $hanging_offset = length($head) - $block_indent;
913 }
914 if (!$in_paren_expr) {
915 $keyword_opening_brace = $mid if $tail =~ m/\{/;
916 $hanging_offset += INDENT_LEVEL;
917 }
918 }
919
920 # set $in_typedecl and potentially $hanging_offset for type declaration
921 if (!$in_expr && @nested_indents == 0 && # not in expression
922 m/(^|^.*\W)(typedef|struct|union|enum)(\W.*|$)$/ &&
923 parens_balance($1) == 0) { # not in newly started expression
924 # not needed: $keyword_opening_brace = $2 if $3 =~ m/\{/;
925 $in_typedecl++;
926 $hanging_offset += INDENT_LEVEL if m/\*.*\(/; # '*' followed by '(' - seems consistent with Emacs C mode
927 }
928
929 my $bak_in_expr = $in_expr;
930 my $terminator_position = update_nested_indents($_, $nested_indents_position);
931
932 if ($bak_in_expr) {
933 # on end of non-if/while/for/switch (multi-line) expression (i.e., return/enum/assignment) and
934 # on end of statement/type declaration/variable definition/function header
935 if ($terminator_position >= 0 && ($in_typedecl == 0 || @nested_indents == 0)) {
936 check_nested_nonblock_indents("expr");
937 $in_expr = 0;
938 }
939 } else {
940 check_nested_nonblock_indents($in_typedecl == 0 ? "stmt" : "decl") if $terminator_position >= 0;
941 }
942
943 # on ';', which terminates the current statement/type declaration/variable definition/function declaration
944 if ($terminator_position >= 0) {
945 my $tail = substr($_, $terminator_position + 1);
946 if (@in_if_hanging_offsets != 0) {
947 if ($tail =~ m/\s*else(\W|$)/) {
948 pop @in_if_hanging_offsets;
949 $hanging_offset -= INDENT_LEVEL;
950 } elsif ($tail =~ m/[^\s@]/) { # code (not just comment) follows
951 @in_if_hanging_offsets = (); # note there is nothing like "unclosed 'if'"
952 $hanging_offset = 0;
953 } else {
954 $if_maybe_terminated = 1;
955 }
956 } elsif ($tail =~ m/^[\s@]*$/) { # ';' has been trailing, i.e. there is nothing but whitespace and comments
957 $hanging_offset = 0; # reset in case of terminated assignment ('=') etc.
958 }
959 $in_typedecl-- if $in_typedecl != 0 && @nested_in_typedecl == 0; # TODO handle multiple type decls per line
960 m/(;[^;]*)$/; # match last ';'
961 $terminator_position = length($_) - length($1) if $1;
962 # new $terminator_position value may be after the earlier one in case multiple terminators on current line
963 # TODO check treatment in case of multiple terminators on current line
964 update_nested_indents($_, $terminator_position + 1);
965 }
966
967 # set hanging expression indent according to nested indents - TODO maybe do better in update_nested_indents()
968 # also if $in_expr is 0: in statement/type declaration/variable definition/function header
969 $expr_indent = 0;
970 for (my $i = -1; $i >= -@nested_symbols; $i--) {
971 if (@nested_symbols[$i] ne "?") { # conditionals '?' ... ':' are treated specially in check_indent()
972 $hanging_symbol = @nested_symbols[$i];
973 $expr_indent = $nested_indents[$i];
974 # $expr_indent is guaranteed to be != 0 unless @nested_indents contains just outer conditionals
975 last;
976 }
977 }
978
979 # remember line number and header containing name of last function defined for reports w.r.t. MAX_BODY_LENGTH
980 if ($outermost_level && m/(\w+)\s*\(/ && $1 ne "STACK_OF") {
981 $line_function_start = $line;
982 $last_function_header = $contents;
983 }
984
985 # special checks for last, typically trailing opening brace '{' in line
986 if (my ($head, $tail) = m/^(.*)\{(.*)$/) { # match last ... '{'
987 if ($in_directive == 0 && !$in_expr && $in_typedecl == 0) {
988 if ($outermost_level) {
989 if (!$assignment_start && !$bak_in_expr) {
990 # at end of function definition header (or stmt or var definition)
991 report("'{' not at beginning") if $head ne "";
992 $line_body_start = $contents =~ m/LONG BODY/ ? 0 : $line;
993 }
994 } else {
995 $line_opening_brace = $line if $keyword_opening_brace =~ m/do|while|for/;
996 # using, not assigning, $keyword_opening_brace here because it could be on an earlier line
997 $line_opening_brace = $line if $keyword_opening_brace =~ m/if|else/ && $extended_1_stmt &&
998 # TODO prevent false positives for if/else where braces around single-statement branches
999 # should be avoided but only if all branches have just single statements
1000 # The following helps detecting the exception when handling multiple 'if ... else' branches:
1001 !($keyword_opening_brace eq "else" && $line_opening_brace < $line_before2);
1002 }
1003 report("code after '{'") if $tail=~ m/[^\s\@]/ && # trailing non-whitespace non-comment (non-'\')
1004 !($tail=~ m/\}/); # no '}' after last '{'
1005 }
1006 }
1007
1008 # check for opening brace after if/while/for/switch/do not on same line
1009 # note that "no '{' on same line after '} else'" is handled further below
1010 if (/^[\s@]*{/ && # leading '{'
1011 $line_before > 0 && !($contents_before_ =~ m/^\s*#/) && # not preprocessor directive '#if
1012 (my ($head, $mid, $tail) = ($contents_before_ =~ m/(^|^.*\W)(if|while|for|switch|do)(\W.*$|$)/))) {
1013 my $brace_after = $tail =~ /^[\s@]*{/; # any whitespace or comments then '{'
1014 report("'{' not on same line as preceding '$mid'") if !$brace_after;
1015 }
1016 # check for closing brace on line before 'else' not followed by leading '{'
1017 elsif (my ($head, $tail) = m/(^|^.*\W)else(\W.*$|$)/) {
1018 if (parens_balance($tail) == 0 && # avoid false positive due to unfinished expr on current line
1019 !($tail =~ m/{/) && # after 'else' no '{' on same line
1020 !($head =~ m/}[\s@]*$/) && # not: '}' then any whitespace or comments before 'else'
1021 $line_before > 0 && $contents_before_ =~ /}[\s@]*$/) { # trailing '}' on line before
1022 report("no '{' after '} else'");
1023 }
1024 }
1025
1026 # check for closing brace before 'while' not on same line
1027 if (my ($head, $tail) = m/(^|^.*\W)while(\W.*$|$)/) {
1028 my $brace_before = $head =~ m/}[\s@]*$/; # '}' then any whitespace or comments
1029 # possibly 'if (...)' (with potentially inner '(' and ')') then any whitespace or comments then '{'
1030 if (!$brace_before &&
1031 # does not work here: @in_do_hanging_offsets != 0 && #'while' terminates loop
1032 parens_balance($tail) == 0 && # avoid false positive due to unfinished expr on current line
1033 $tail =~ /;/ && # 'while' terminates loop (by ';')
1034 $line_before > 0 &&
1035 $contents_before_ =~ /}[\s@]*$/) { # on line before: '}' then any whitespace or comments
1036 report("'while' not on same line as preceding '}'");
1037 }
1038 }
1039
1040 # check for missing brace on same line before or after 'else'
1041 if (my ($head, $tail) = m/(^|^.*\W)else(\W.*$|$)/) {
1042 my $brace_before = $head =~ /}[\s@]*$/; # '}' then any whitespace or comments
1043 my $brace_after = $tail =~ /^[\s@]*if[\s@]*\(.*\)[\s@]*{|[\s@]*{/;
1044 # possibly 'if (...)' (with potentially inner '(' and ')') then any whitespace or comments then '{'
1045 if (!$brace_before) {
1046 if ($line_before > 0 && $contents_before_ =~ /}[\s@]*$/) {
1047 report("'else' not on same line as preceding '}'");
1048 } elsif (parens_balance($tail) == 0) { # avoid false positive due to unfinished expr on current line
1049 report("no '}' on same line before 'else ... {'") if $brace_after;
1050 }
1051 } elsif (parens_balance($tail) == 0) { # avoid false positive due to unfinished expr on current line
1052 report("no '{' on same line after '} else'") if $brace_before && !$brace_after;
1053 }
1054 }
1055
1056 POSTPROCESS_DIRECTIVE:
1057 # on begin of multi-line preprocessor directive, adapt indent
1058 # need to use original line contents because trailing '\' may have been stripped above
1059 if ($contents =~ m/^(.*?)[\s@]*\\[\s@]*$/) { # trailing '\' (which is not stripped from $contents),
1060 # typically used in macro definitions (or other preprocessor directives)
1061 if ($in_directive == 0) {
1062 $in_macro_header = m/^\s*#\s*define(\W|$)?(.*)/ ? 1 + parens_balance($2) : 0; # '#define' is beginning
1063 $directive_offset = INDENT_LEVEL;
1064 $block_indent += $directive_offset;
1065 }
1066 $in_directive += 1;
1067 }
1068
1069 # post-processing at end of line @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
1070
1071 LINE_FINISHED:
1072 # on end of multi-line preprocessor directive, adapt indent
1073 if ($in_directive > 0 &&
1074 # need to use original line contents because trailing \ may have been stripped
1075 !($contents =~ m/^(.*?)[\s@]*\\[\s@]*$/)) { # no trailing '\'
1076 $block_indent -= $directive_offset;
1077 $in_directive = 0;
1078 # macro body typically does not include terminating ';'
1079 $hanging_offset = 0; # compensate for this in case macro ends, e.g., as 'while (0)'
1080 }
1081
1082 if (m/^\s*$/) { # essentially empty line: just whitespace (and maybe a '\')
1083 report("empty line at beginnig of file") if $line == 1 && !$sloppy_SPC;
1084 } else {
1085 if ($line_before > 0) {
1086 my $linediff = $line - $line_before - 1;
1087 report("$linediff empty lines before") if $linediff > 1 && !$sloppy_SPC;
1088 }
1089 $line_before2 = $line_before;
1090 $contents_before2 = $contents_before;
1091 $contents_before_2 = $contents_before_;
1092 $line_before = $line;
1093 $contents_before = $contents;
1094 $contents_before_ = $_;
1095 $count_before = $count;
1096 }
1097
1098 if ($self_test) { # debugging
1099 my $should_report = $contents =~ m/\*@(\d)?/ ? 1 : 0;
1100 $should_report = +$1 if $should_report != 0 && defined $1;
1101 print("$ARGV:$line:$num_reports_line reports on:$contents")
1102 if $num_reports_line != $should_report;
1103 }
1104 $num_reports_line = 0;
1105
1106 # post-processing at end of file @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
1107
1108 if (eof) {
1109 # check for essentially empty line (which may include a '\') just before EOF
1110 report(($1 eq "\n" ? "empty line" : $2 ne "" ? "'\\'" : "whitespace")." at EOF")
1111 if $contents =~ m/^(\s*(\\?)\s*)$/ && !$sloppy_SPC;
1112
1113 # report unclosed expression-level nesting
1114 check_nested_nonblock_indents("expr at EOF"); # also adapts @nested_block_indents
1115
1116 # sanity-check balance of block-level { ... } via final $block_indent at end of file
1117 report_flexibly($line, +@nested_block_indents." unclosed '{'", "(EOF)\n") if @nested_block_indents != 0;
1118
1119 # sanity-check balance of #if ... #endif via final preprocessor directive indent at end of file
1120 report_flexibly($line, "$directive_nesting unclosed '#if'", "(EOF)\n") if $directive_nesting != 0;
1121
1122 reset_file_state();
1123 }
1124 }
1125
1126 # final summary report @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
1127
1128 my $num_other_reports = $num_reports - $num_indent_reports - $num_nesting_issues
1129 - $num_syntax_issues - $num_SPC_reports - $num_length_reports;
1130 print "$num_reports ($num_indent_reports indentation, $num_nesting_issues directive nesting, ".
1131 "$num_syntax_issues syntax, $num_SPC_reports whitespace, $num_length_reports length, $num_other_reports other)".
1132 " issues have been found by $0\n" if $num_reports != 0 && !$self_test;