]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - Assemble.c
super1: PPL support
[thirdparty/mdadm.git] / Assemble.c
index 0661e8d275f829694c2ffe88d86a60d7c8ccaee7..c09842016c0afcbca48c2262da5f09b2f347e80c 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * mdadm - manage Linux "md" devices aka RAID arrays.
  *
- * Copyright (C) 2001-2013 Neil Brown <neilb@suse.de>
+ * Copyright (C) 2001-2016 Neil Brown <neilb@suse.com>
  *
  *
  *    This program is free software; you can redistribute it and/or modify
@@ -599,18 +599,9 @@ static int load_devices(struct devs *devices, char *devmap,
                        int err;
                        fstat(mdfd, &stb2);
 
-                       if (strcmp(c->update, "uuid")==0 &&
-                           !ident->uuid_set) {
-                               int rfd;
-                               if ((rfd = open("/dev/urandom", O_RDONLY)) < 0 ||
-                                   read(rfd, ident->uuid, 16) != 16) {
-                                       *(__u32*)(ident->uuid) = random();
-                                       *(__u32*)(ident->uuid+1) = random();
-                                       *(__u32*)(ident->uuid+2) = random();
-                                       *(__u32*)(ident->uuid+3) = random();
-                               }
-                               if (rfd >= 0) close(rfd);
-                       }
+                       if (strcmp(c->update, "uuid") == 0 && !ident->uuid_set)
+                               random_uuid((__u8 *)ident->uuid);
+
                        dfd = dev_open(devname,
                                       tmpdev->disposition == 'I'
                                       ? O_RDWR : (O_RDWR|O_EXCL));
@@ -643,7 +634,14 @@ static int load_devices(struct devs *devices, char *devmap,
                        } else if (strcmp(c->update, "nodes") == 0) {
                                tst->nodes = c->nodes;
                                err = tst->ss->write_bitmap(tst, dfd, NodeNumUpdate);
-                       } else
+                       } else if (strcmp(c->update, "revert-reshape") == 0 &&
+                                  c->invalid_backup)
+                               err = tst->ss->update_super(tst, content,
+                                                           "revert-reshape-nobackup",
+                                                           devname, c->verbose,
+                                                           ident->uuid_set,
+                                                           c->homehost);
+                       else
                                err = tst->ss->update_super(tst, content, c->update,
                                                            devname, c->verbose,
                                                            ident->uuid_set,
@@ -948,16 +946,14 @@ static int start_array(int mdfd,
                       int clean, char *avail,
                       int start_partial_ok,
                       int err_ok,
-                      int was_forced,
-                      int expect_journal,
-                      int journal_clean
+                      int was_forced
        )
 {
        int rv;
        int i;
        unsigned int req_cnt;
 
-       if (expect_journal && (journal_clean == 0)) {
+       if (content->journal_device_required && (content->journal_clean == 0)) {
                if (!c->force) {
                        pr_err("Not safe to assemble with missing or stale journal device, consider --force.\n");
                        return 1;
@@ -966,6 +962,9 @@ static int start_array(int mdfd,
                c->readonly = 1;
        }
 
+       if (content->consistency_policy == CONSISTENCY_POLICY_PPL)
+               clean = 1;
+
        rv = set_array_info(mdfd, st, content);
        if (rv && !err_ok) {
                pr_err("failed to set array info for %s: %s\n",
@@ -1130,7 +1129,7 @@ static int start_array(int mdfd,
                                        fprintf(stderr, "%s %d rebuilding", sparecnt?",":" and", rebuilding_cnt);
                                if (sparecnt)
                                        fprintf(stderr, " and %d spare%s", sparecnt, sparecnt==1?"":"s");
-                               if (journal_clean)
+                               if (content->journal_clean)
                                        fprintf(stderr, " and %d journal", journalcnt);
                                fprintf(stderr, ".\n");
                        }
@@ -1304,11 +1303,10 @@ int Assemble(struct supertype *st, char *mddev,
        int bestcnt = 0;
        int devcnt;
        unsigned int okcnt, sparecnt, rebuilding_cnt, replcnt, journalcnt;
+       int journal_clean = 0;
        int i;
        int was_forced = 0;
        int most_recent = 0;
-       int expect_journal = 0;
-       int journal_clean = 0;
        int chosen_drive;
        int change = 0;
        int inargv = 0;
@@ -1371,14 +1369,6 @@ try_again:
        if (!st || !st->sb || !content)
                return 2;
 
-       if (st->ss->require_journal) {
-               expect_journal = st->ss->require_journal(st);
-               if (expect_journal == 2) {
-                       pr_err("BUG: Superblock not loaded in Assemble.c:Assemble\n");
-                       return 1;
-               }
-       }
-
        /* We have a full set of devices - we now need to find the
         * array device.
         * However there is a risk that we are racing with "mdadm -I"
@@ -1567,7 +1557,7 @@ try_again:
                 */
                if (content->array.level != LEVEL_MULTIPATH) {
                        if (devices[j].i.disk.state & (1<<MD_DISK_JOURNAL)) {
-                               if (expect_journal)
+                               if (content->journal_device_required)
                                        journalcnt++;
                                else    /* unexpected journal, mark as faulty */
                                        devices[j].i.disk.state |= (1<<MD_DISK_FAULTY);
@@ -1676,6 +1666,8 @@ try_again:
 #ifndef MDASSEMBLE
        sysfs_init(content, mdfd, NULL);
 #endif
+       /* after reload context, store journal_clean in context */
+       content->journal_clean = journal_clean;
        for (i=0; i<bestcnt; i++) {
                int j = best[i];
                unsigned int desired_state;
@@ -1833,7 +1825,7 @@ try_again:
                         c,
                         clean, avail, start_partial_ok,
                         pre_exist != NULL,
-                        was_forced, expect_journal, journal_clean);
+                        was_forced);
        if (rv == 1 && !pre_exist)
                ioctl(mdfd, STOP_ARRAY, NULL);
        free(devices);
@@ -1882,10 +1874,9 @@ int assemble_container_content(struct supertype *st, int mdfd,
        struct mdinfo *dev, *sra, *dev2;
        int working = 0, preexist = 0;
        int expansion = 0;
-       struct map_ent *map = NULL;
        int old_raid_disks;
        int start_reshape;
-       char *avail = NULL;
+       char *avail;
        int err;
 
        sysfs_init(content, mdfd, NULL);
@@ -1898,8 +1889,7 @@ int assemble_container_content(struct supertype *st, int mdfd,
                    content->text_version[0] == '/')
                        content->text_version[0] = '-';
                if (sysfs_set_array(content, md_get_version(mdfd)) != 0) {
-                       if (sra)
-                               sysfs_free(sra);
+                       sysfs_free(sra);
                        return 1;
                }
        }
@@ -1952,10 +1942,57 @@ int assemble_container_content(struct supertype *st, int mdfd,
                free(avail);
                return 1;/* Nothing new, don't try to start */
        }
-       map_update(&map, fd2devnm(mdfd),
-                  content->text_version,
+       map_update(NULL, fd2devnm(mdfd), content->text_version,
                   content->uuid, chosen_name);
 
+       if (content->consistency_policy == CONSISTENCY_POLICY_PPL &&
+           st->ss->validate_ppl) {
+               content->array.state |= 1;
+               err = 0;
+
+               for (dev = content->devs; dev; dev = dev->next) {
+                       int dfd;
+                       char *devpath;
+                       int ret;
+
+                       ret = st->ss->validate_ppl(st, content, dev);
+                       if (ret == 0)
+                               continue;
+
+                       if (ret < 0) {
+                               err = 1;
+                               break;
+                       }
+
+                       if (!c->force) {
+                               pr_err("%s contains invalid PPL - consider --force or --update-subarray with --update=no-ppl\n",
+                                       chosen_name);
+                               content->array.state &= ~1;
+                               avail[dev->disk.raid_disk] = 0;
+                               break;
+                       }
+
+                       /* have --force - overwrite the invalid ppl */
+                       devpath = map_dev(dev->disk.major, dev->disk.minor, 0);
+                       dfd = dev_open(devpath, O_RDWR);
+                       if (dfd < 0) {
+                               pr_err("Failed to open %s\n", devpath);
+                               err = 1;
+                               break;
+                       }
+
+                       err = st->ss->write_init_ppl(st, content, dfd);
+                       close(dfd);
+
+                       if (err)
+                               break;
+               }
+
+               if (err) {
+                       free(avail);
+                       return err;
+               }
+       }
 
        if (enough(content->array.level, content->array.raid_disks,
                   content->array.layout, content->array.state & 1, avail) == 0) {