]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blobdiff - bfd/elf-m10300.c
Touches most files in bfd/, so likely will be blamed for everything..
[thirdparty/binutils-gdb.git] / bfd / elf-m10300.c
index 6601447e6933f235082d4acf5029c63c0096df57..01211ba9d3215db2a58de5e14870d94583a27dec 100644 (file)
@@ -1,5 +1,6 @@
 /* Matsushita 10300 specific support for 32-bit ELF
-   Copyright (C) 1996, 1997, 1998 Free Software Foundation, Inc.
+   Copyright 1996, 1997, 1998, 1999, 2000, 2001
+   Free Software Foundation, Inc.
 
 This file is part of BFD, the Binary File Descriptor library.
 
@@ -23,8 +24,25 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
 #include "elf-bfd.h"
 #include "elf/mn10300.h"
 
-struct elf32_mn10300_link_hash_entry
-{
+static bfd_reloc_status_type mn10300_elf_final_link_relocate
+  PARAMS ((reloc_howto_type *, bfd *, bfd *, asection *, bfd_byte *,
+          bfd_vma, bfd_vma, bfd_vma, struct bfd_link_info *,
+          asection *, int));
+static boolean mn10300_elf_relocate_section
+  PARAMS ((bfd *, struct bfd_link_info *, bfd *, asection *, bfd_byte *,
+          Elf_Internal_Rela *, Elf_Internal_Sym *, asection **));
+static boolean mn10300_elf_relax_section
+  PARAMS ((bfd *, asection *, struct bfd_link_info *, boolean *));
+static bfd_byte * mn10300_elf_get_relocated_section_contents
+  PARAMS ((bfd *, struct bfd_link_info *, struct bfd_link_order *,
+          bfd_byte *, boolean, asymbol **));
+static unsigned long elf_mn10300_mach PARAMS ((flagword));
+
+void    _bfd_mn10300_elf_final_write_processing PARAMS ((bfd *, boolean));
+boolean _bfd_mn10300_elf_object_p PARAMS ((bfd *));
+boolean _bfd_mn10300_elf_merge_private_bfd_data PARAMS ((bfd *,bfd *));
+
+struct elf32_mn10300_link_hash_entry {
   /* The basic elf link hash table entry.  */
   struct elf_link_hash_entry root;
 
@@ -62,8 +80,7 @@ struct elf32_mn10300_link_hash_entry
 /* We derive a hash table from the main elf linker hash table so
    we can store state variables and a secondary hash table without
    resorting to global variables.  */
-struct elf32_mn10300_link_hash_table
-{
+struct elf32_mn10300_link_hash_table {
   /* The main hash table.  */
   struct elf_link_hash_table root;
 
@@ -119,9 +136,7 @@ static void compute_function_info
    does absolutely nothing.  */
 #define USE_RELA
 
-
-static reloc_howto_type elf_mn10300_howto_table[] =
-{
+static reloc_howto_type elf_mn10300_howto_table[] = {
   /* Dummy relocation.  Does nothing.  */
   HOWTO (R_MN10300_NONE,
         0,
@@ -265,17 +280,14 @@ static reloc_howto_type elf_mn10300_howto_table[] =
         0xffffff,
         0xffffff,
         false),
-
 };
 
-struct mn10300_reloc_map
-{
-  unsigned char bfd_reloc_val;
+struct mn10300_reloc_map {
+  bfd_reloc_code_real_type bfd_reloc_val;
   unsigned char elf_reloc_val;
 };
 
-static const struct mn10300_reloc_map mn10300_reloc_map[] =
-{
+static const struct mn10300_reloc_map mn10300_reloc_map[] = {
   { BFD_RELOC_NONE, R_MN10300_NONE, },
   { BFD_RELOC_32, R_MN10300_32, },
   { BFD_RELOC_16, R_MN10300_16, },
@@ -290,7 +302,7 @@ static const struct mn10300_reloc_map mn10300_reloc_map[] =
 
 static reloc_howto_type *
 bfd_elf32_bfd_reloc_type_lookup (abfd, code)
-     bfd *abfd;
+     bfd *abfd ATTRIBUTE_UNUSED;
      bfd_reloc_code_real_type code;
 {
   unsigned int i;
@@ -310,7 +322,7 @@ bfd_elf32_bfd_reloc_type_lookup (abfd, code)
 
 static void
 mn10300_info_to_howto (abfd, cache_ptr, dst)
-     bfd *abfd;
+     bfd *abfd ATTRIBUTE_UNUSED;
      arelent *cache_ptr;
      Elf32_Internal_Rela *dst;
 {
@@ -342,7 +354,7 @@ mn10300_elf_check_relocs (abfd, info, sec, relocs)
 
   symtab_hdr = &elf_tdata (abfd)->symtab_hdr;
   sym_hashes = elf_sym_hashes (abfd);
-  sym_hashes_end = sym_hashes + symtab_hdr->sh_size/sizeof(Elf32_External_Sym);
+  sym_hashes_end = sym_hashes + symtab_hdr->sh_size/sizeof (Elf32_External_Sym);
   if (!elf_bad_symtab (abfd))
     sym_hashes_end -= symtab_hdr->sh_info;
 
@@ -385,7 +397,7 @@ mn10300_elf_check_relocs (abfd, info, sec, relocs)
 static asection *
 mn10300_elf_gc_mark_hook (abfd, info, rel, h, sym)
      bfd *abfd;
-     struct bfd_link_info *info;
+     struct bfd_link_info *info ATTRIBUTE_UNUSED;
      Elf_Internal_Rela *rel;
      struct elf_link_hash_entry *h;
      Elf_Internal_Sym *sym;
@@ -407,6 +419,9 @@ mn10300_elf_gc_mark_hook (abfd, info, rel, h, sym)
 
            case bfd_link_hash_common:
              return h->root.u.c.p->section;
+
+           default:
+             break;
            }
        }
     }
@@ -431,15 +446,15 @@ mn10300_elf_final_link_relocate (howto, input_bfd, output_bfd,
                                 addend, info, sym_sec, is_local)
      reloc_howto_type *howto;
      bfd *input_bfd;
-     bfd *output_bfd;
+     bfd *output_bfd ATTRIBUTE_UNUSED;
      asection *input_section;
      bfd_byte *contents;
      bfd_vma offset;
      bfd_vma value;
      bfd_vma addend;
-     struct bfd_link_info *info;
-     asection *sym_sec;
-     int is_local;
+     struct bfd_link_info *info ATTRIBUTE_UNUSED;
+     asection *sym_sec ATTRIBUTE_UNUSED;
+     int is_local ATTRIBUTE_UNUSED;
 {
   unsigned long r_type = howto->type;
   bfd_byte *hit_data = contents + offset;
@@ -457,7 +472,7 @@ mn10300_elf_final_link_relocate (howto, input_bfd, output_bfd,
     case R_MN10300_24:
       value += addend;
 
-      if ((long)value > 0x7fffff || (long)value < -0x800000)
+      if ((long) value > 0x7fffff || (long) value < -0x800000)
        return bfd_reloc_overflow;
 
       bfd_put_8 (input_bfd, value & 0xff, hit_data);
@@ -468,7 +483,7 @@ mn10300_elf_final_link_relocate (howto, input_bfd, output_bfd,
     case R_MN10300_16:
       value += addend;
 
-      if ((long)value > 0x7fff || (long)value < -0x8000)
+      if ((long) value > 0x7fff || (long) value < -0x8000)
        return bfd_reloc_overflow;
 
       bfd_put_16 (input_bfd, value, hit_data);
@@ -477,7 +492,7 @@ mn10300_elf_final_link_relocate (howto, input_bfd, output_bfd,
     case R_MN10300_8:
       value += addend;
 
-      if ((long)value > 0x7f || (long)value < -0x80)
+      if ((long) value > 0x7f || (long) value < -0x80)
        return bfd_reloc_overflow;
 
       bfd_put_8 (input_bfd, value, hit_data);
@@ -489,7 +504,7 @@ mn10300_elf_final_link_relocate (howto, input_bfd, output_bfd,
       value -= offset;
       value += addend;
 
-      if ((long)value > 0xff || (long)value < -0x100)
+      if ((long) value > 0xff || (long) value < -0x100)
        return bfd_reloc_overflow;
 
       bfd_put_8 (input_bfd, value, hit_data);
@@ -501,7 +516,7 @@ mn10300_elf_final_link_relocate (howto, input_bfd, output_bfd,
       value -= offset;
       value += addend;
 
-      if ((long)value > 0xffff || (long)value < -0x10000)
+      if ((long) value > 0xffff || (long) value < -0x10000)
        return bfd_reloc_overflow;
 
       bfd_put_16 (input_bfd, value, hit_data);
@@ -524,7 +539,6 @@ mn10300_elf_final_link_relocate (howto, input_bfd, output_bfd,
       return bfd_reloc_notsupported;
     }
 }
-
 \f
 /* Relocate an MN10300 ELF section.  */
 static boolean
@@ -603,8 +617,8 @@ mn10300_elf_relocate_section (output_bfd, info, input_bfd, input_section,
       else
        {
          h = sym_hashes[r_symndx - symtab_hdr->sh_info];
-         while (h->root.type == bfd_link_hash_indirect
-                || h->root.type == bfd_link_hash_warning)
+         while (h->root.root.type == bfd_link_hash_indirect
+                || h->root.root.type == bfd_link_hash_warning)
            h = (struct elf32_mn10300_link_hash_entry *) h->root.root.u.i.link;
          if (h->root.root.type == bfd_link_hash_defined
              || h->root.root.type == bfd_link_hash_defweak)
@@ -620,7 +634,7 @@ mn10300_elf_relocate_section (output_bfd, info, input_bfd, input_section,
            {
              if (! ((*info->callbacks->undefined_symbol)
                     (info, h->root.root.root.string, input_bfd,
-                     input_section, rel->r_offset)))
+                     input_section, rel->r_offset, true)))
                return false;
              relocation = 0;
            }
@@ -635,7 +649,7 @@ mn10300_elf_relocate_section (output_bfd, info, input_bfd, input_section,
       if (r != bfd_reloc_ok)
        {
          const char *name;
-         const char *msg = (const char *)0;
+         const char *msg = (const char *) 0;
 
          if (h != NULL)
            name = h->root.root.root.string;
@@ -659,7 +673,7 @@ mn10300_elf_relocate_section (output_bfd, info, input_bfd, input_section,
            case bfd_reloc_undefined:
              if (! ((*info->callbacks->undefined_symbol)
                     (info, name, input_bfd, input_section,
-                     rel->r_offset)))
+                     rel->r_offset, true)))
                return false;
              break;
 
@@ -696,12 +710,12 @@ mn10300_elf_relocate_section (output_bfd, info, input_bfd, input_section,
 static boolean
 elf32_mn10300_finish_hash_table_entry (gen_entry, in_args)
      struct bfd_hash_entry *gen_entry;
-     PTR in_args;
+     PTR in_args ATTRIBUTE_UNUSED;
 {
   struct elf32_mn10300_link_hash_entry *entry;
   unsigned int byte_count = 0;
 
-  entry = (struct elf32_mn10300_link_hash_entry *)gen_entry;
+  entry = (struct elf32_mn10300_link_hash_entry *) gen_entry;
 
   /* If we already know we want to convert "call" to "calls" for calls
      to this symbol, then return now.  */
@@ -764,7 +778,6 @@ elf32_mn10300_finish_hash_table_entry (gen_entry, in_args)
                This is only done if the resulting code is no larger
                than the original code.
 
-
        * jmp:32 -> jmp:16                                         2 bytes
        * jmp:16 -> bra:8                                          1 byte
 
@@ -822,22 +835,21 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          /* We're going to need all the symbols for each bfd.  */
          symtab_hdr = &elf_tdata (input_bfd)->symtab_hdr;
 
-          /* Get cached copy if it exists.  */
-          if (symtab_hdr->contents != NULL)
-            extsyms = (Elf32_External_Sym *) symtab_hdr->contents;
-          else
-            {
-              /* Go get them off disk.  */
-              extsyms = ((Elf32_External_Sym *)
-                         bfd_malloc (symtab_hdr->sh_size));
-              if (extsyms == NULL)
-                goto error_return;
-              free_extsyms = extsyms;
-              if (bfd_seek (input_bfd, symtab_hdr->sh_offset, SEEK_SET) != 0
-                  || (bfd_read (extsyms, 1, symtab_hdr->sh_size, input_bfd)
-                      != symtab_hdr->sh_size))
-                goto error_return;
-            }
+         /* Get cached copy if it exists.  */
+         if (symtab_hdr->contents != NULL)
+           extsyms = (Elf32_External_Sym *) symtab_hdr->contents;
+         else
+           {
+             bfd_size_type amt = symtab_hdr->sh_size;
+             /* Go get them off disk.  */
+             extsyms = (Elf32_External_Sym *) bfd_malloc (amt);
+             if (extsyms == NULL)
+               goto error_return;
+             free_extsyms = extsyms;
+             if (bfd_seek (input_bfd, symtab_hdr->sh_offset, SEEK_SET) != 0
+                 || bfd_bread (extsyms, amt, input_bfd) != amt)
+               goto error_return;
+           }
 
          /* Iterate over each section in this bfd.  */
          for (section = input_bfd->sections;
@@ -846,10 +858,9 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
            {
              struct elf32_mn10300_link_hash_entry *hash;
              Elf_Internal_Sym *sym;
-             asection *sym_sec;
+             asection *sym_sec = NULL;
              const char *sym_name;
              char *new_name;
-             Elf_Internal_Shdr *hdr;
 
              /* Get cached copy of section contents if it exists.  */
              if (elf_section_data (section)->this_hdr.contents != NULL)
@@ -857,7 +868,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
              else if (section->_raw_size != 0)
                {
                  /* Go get them off disk.  */
-                 contents = (bfd_byte *)bfd_malloc (section->_raw_size);
+                 contents = (bfd_byte *) bfd_malloc (section->_raw_size);
                  if (contents == NULL)
                    goto error_return;
                  free_contents = contents;
@@ -900,7 +911,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                      r_type = ELF32_R_TYPE (irel->r_info);
                      r_index = ELF32_R_SYM (irel->r_info);
 
-                     if (r_type < 0 || r_type >= (int)R_MN10300_MAX)
+                     if (r_type < 0 || r_type >= (int) R_MN10300_MAX)
                        goto error_return;
 
                      /* We need the name and hash table entry of the target
@@ -913,6 +924,8 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                        {
                          /* A local symbol.  */
                          Elf_Internal_Sym isym;
+                         struct elf_link_hash_table *elftab;
+                         bfd_size_type amt;
 
                          bfd_elf32_swap_symbol_in (input_bfd,
                                                    extsyms + r_index, &isym);
@@ -941,14 +954,20 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
 
                          /* Tack on an ID so we can uniquely identify this
                             local symbol in the global hash table.  */
-                         new_name = alloca (strlen (sym_name) + 10);
-                         sprintf (new_name, "%s_%08x", sym_name, (int)sym_sec);
+                         amt = strlen (sym_name) + 10;
+                         new_name = bfd_malloc (amt);
+                         if (new_name == 0)
+                           goto error_return;
+
+                         sprintf (new_name, "%s_%08x",
+                                  sym_name, (int) sym_sec);
                          sym_name = new_name;
 
-                         hash = (struct elf32_mn10300_link_hash_entry *)
-                                  elf_link_hash_lookup (&hash_table->static_hash_table->root,
-                                                        sym_name, true,
-                                                        true, false);
+                         elftab = &hash_table->static_hash_table->root;
+                         hash = ((struct elf32_mn10300_link_hash_entry *)
+                                 elf_link_hash_lookup (elftab, sym_name,
+                                                       true, true, false));
+                         free (new_name);
                        }
                      else
                        {
@@ -987,7 +1006,6 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                  shndx = _bfd_elf_section_from_bfd_section (input_bfd,
                                                             section);
 
-
                  /* Look at each function defined in this section and
                     update info for that function.  */
                  esym = extsyms;
@@ -1000,6 +1018,9 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                      if (isym.st_shndx == shndx
                          && ELF_ST_TYPE (isym.st_info) == STT_FUNC)
                        {
+                         struct elf_link_hash_table *elftab;
+                         bfd_size_type amt;
+
                          if (isym.st_shndx == SHN_UNDEF)
                            sym_sec = bfd_und_section_ptr;
                          else if (isym.st_shndx > 0
@@ -1012,22 +1033,28 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                          else if (isym.st_shndx == SHN_COMMON)
                            sym_sec = bfd_com_section_ptr;
 
-                         sym_name = bfd_elf_string_from_elf_section (input_bfd,
-                                                       symtab_hdr->sh_link,
-                                                       isym.st_name);
+                         sym_name = (bfd_elf_string_from_elf_section
+                                     (input_bfd, symtab_hdr->sh_link,
+                                      isym.st_name));
 
                          /* Tack on an ID so we can uniquely identify this
                             local symbol in the global hash table.  */
-                         new_name = alloca (strlen (sym_name) + 10);
-                         sprintf (new_name, "%s_%08x", sym_name, (int)sym_sec);
+                         amt = strlen (sym_name) + 10;
+                         new_name = bfd_malloc (amt);
+                         if (new_name == 0)
+                           goto error_return;
+
+                         sprintf (new_name, "%s_%08x",
+                                  sym_name, (int) sym_sec);
                          sym_name = new_name;
 
-                         hash = (struct elf32_mn10300_link_hash_entry *)
-                                   elf_link_hash_lookup (&hash_table->static_hash_table->root,
-                                                         sym_name, true,
-                                                         true, false);
+                         elftab = &hash_table->static_hash_table->root;
+                         hash = ((struct elf32_mn10300_link_hash_entry *)
+                                 elf_link_hash_lookup (elftab, sym_name,
+                                                       true, true, false));
+                         free (new_name);
                          compute_function_info (input_bfd, hash,
-                                                isym.st_value, contents);
+                                                isym.st_value, contents);
                        }
                    }
 
@@ -1112,22 +1139,21 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          /* We're going to need all the symbols for each bfd.  */
          symtab_hdr = &elf_tdata (input_bfd)->symtab_hdr;
 
-          /* Get cached copy if it exists.  */
-          if (symtab_hdr->contents != NULL)
-            extsyms = (Elf32_External_Sym *) symtab_hdr->contents;
-          else
-            {
-              /* Go get them off disk.  */
-              extsyms = ((Elf32_External_Sym *)
-                         bfd_malloc (symtab_hdr->sh_size));
-              if (extsyms == NULL)
-                goto error_return;
-              free_extsyms = extsyms;
-              if (bfd_seek (input_bfd, symtab_hdr->sh_offset, SEEK_SET) != 0
-                  || (bfd_read (extsyms, 1, symtab_hdr->sh_size, input_bfd)
-                      != symtab_hdr->sh_size))
-                goto error_return;
-            }
+         /* Get cached copy if it exists.  */
+         if (symtab_hdr->contents != NULL)
+           extsyms = (Elf32_External_Sym *) symtab_hdr->contents;
+         else
+           {
+             bfd_size_type amt = symtab_hdr->sh_size;
+             /* Go get them off disk.  */
+             extsyms = (Elf32_External_Sym *) bfd_malloc (amt);
+             if (extsyms == NULL)
+               goto error_return;
+             free_extsyms = extsyms;
+             if (bfd_seek (input_bfd, symtab_hdr->sh_offset, SEEK_SET) != 0
+                 || bfd_bread (extsyms, amt, input_bfd) != amt)
+               goto error_return;
+           }
 
          /* Walk over each section in this bfd.  */
          for (section = input_bfd->sections;
@@ -1144,15 +1170,15 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
 
              if (section->reloc_count != 0)
                {
-                  /* Get a copy of the native relocations.  */
-                  internal_relocs = (_bfd_elf32_link_read_relocs
-                                     (input_bfd, section, (PTR) NULL,
-                                      (Elf_Internal_Rela *) NULL,
-                                      link_info->keep_memory));
-                  if (internal_relocs == NULL)
-                    goto error_return;
-                  if (! link_info->keep_memory)
-                    free_relocs = internal_relocs;
+                 /* Get a copy of the native relocations.  */
+                 internal_relocs = (_bfd_elf32_link_read_relocs
+                                    (input_bfd, section, (PTR) NULL,
+                                     (Elf_Internal_Rela *) NULL,
+                                     link_info->keep_memory));
+                 if (internal_relocs == NULL)
+                   goto error_return;
+                 if (! link_info->keep_memory)
+                   free_relocs = internal_relocs;
                }
 
              /* Get cached copy of section contents if it exists.  */
@@ -1161,7 +1187,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
              else
                {
                  /* Go get them off disk.  */
-                 contents = (bfd_byte *)bfd_malloc (section->_raw_size);
+                 contents = (bfd_byte *) bfd_malloc (section->_raw_size);
                  if (contents == NULL)
                    goto error_return;
                  free_contents = contents;
@@ -1172,7 +1198,6 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                    goto error_return;
                }
 
-
              shndx = _bfd_elf_section_from_bfd_section (input_bfd, section);
 
              /* Now look for any function in this section which needs
@@ -1183,10 +1208,11 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                {
                  Elf_Internal_Sym isym;
                  struct elf32_mn10300_link_hash_entry *sym_hash;
-                 asection *sym_sec;
+                 asection *sym_sec = NULL;
                  const char *sym_name;
-                 Elf_Internal_Shdr *hdr;
                  char *new_name;
+                 struct elf_link_hash_table *elftab;
+                 bfd_size_type amt;
 
                  bfd_elf32_swap_symbol_in (input_bfd, esym, &isym);
 
@@ -1202,6 +1228,8 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                    sym_sec = bfd_abs_section_ptr;
                  else if (isym.st_shndx == SHN_COMMON)
                    sym_sec = bfd_com_section_ptr;
+                 else
+                   abort ();
 
                  sym_name = bfd_elf_string_from_elf_section (input_bfd,
                                                        symtab_hdr->sh_link,
@@ -1209,15 +1237,19 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
 
                  /* Tack on an ID so we can uniquely identify this
                     local symbol in the global hash table.  */
-                 new_name = alloca (strlen (sym_name) + 10);
-                 sprintf (new_name, "%s_%08x", sym_name, (int)sym_sec);
+                 amt = strlen (sym_name) + 10;
+                 new_name = bfd_malloc (amt);
+                 if (new_name == 0)
+                   goto error_return;
+                 sprintf (new_name, "%s_%08x", sym_name, (int) sym_sec);
                  sym_name = new_name;
 
-                 sym_hash = (struct elf32_mn10300_link_hash_entry *)
-                           elf_link_hash_lookup (&hash_table->static_hash_table->root,
-                                                 sym_name, false,
-                                                 false, false);
+                 elftab = &hash_table->static_hash_table->root;
+                 sym_hash = ((struct elf32_mn10300_link_hash_entry *)
+                             elf_link_hash_lookup (elftab, sym_name,
+                                                   false, false, false));
 
+                 free (new_name);
                  if (sym_hash == NULL)
                    continue;
 
@@ -1233,7 +1265,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                      elf_section_data (section)->this_hdr.contents = contents;
                      free_contents = NULL;
 
-                     symtab_hdr->contents = (bfd_byte *)extsyms;
+                     symtab_hdr->contents = (bfd_byte *) extsyms;
                      free_extsyms = NULL;
 
                      /* Count how many bytes we're going to delete.  */
@@ -1290,7 +1322,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                      elf_section_data (section)->this_hdr.contents = contents;
                      free_contents = NULL;
 
-                     symtab_hdr->contents = (bfd_byte *)extsyms;
+                     symtab_hdr->contents = (bfd_byte *) extsyms;
                      free_extsyms = NULL;
 
                      /* Count how many bytes we're going to delete.  */
@@ -1356,7 +1388,6 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
        }
     }
 
-
   /* (Re)initialize for the basic instruction shortening/relaxing pass.  */
   contents = NULL;
   extsyms = NULL;
@@ -1432,15 +1463,14 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
            extsyms = (Elf32_External_Sym *) symtab_hdr->contents;
          else
            {
+             bfd_size_type amt = symtab_hdr->sh_size;
              /* Go get them off disk.  */
-             extsyms = ((Elf32_External_Sym *)
-                        bfd_malloc (symtab_hdr->sh_size));
+             extsyms = (Elf32_External_Sym *) bfd_malloc (amt);
              if (extsyms == NULL)
                goto error_return;
              free_extsyms = extsyms;
              if (bfd_seek (abfd, symtab_hdr->sh_offset, SEEK_SET) != 0
-                 || (bfd_read (extsyms, 1, symtab_hdr->sh_size, abfd)
-                     != symtab_hdr->sh_size))
+                 || bfd_bread (extsyms, amt, abfd) != amt)
                goto error_return;
            }
        }
@@ -1449,8 +1479,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
       if (ELF32_R_SYM (irel->r_info) < symtab_hdr->sh_info)
        {
          Elf_Internal_Sym isym;
-         asection *sym_sec;
-         Elf_Internal_Shdr *hdr;
+         asection *sym_sec = NULL;
          const char *sym_name;
          char *new_name;
 
@@ -1467,6 +1496,8 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
            sym_sec = bfd_abs_section_ptr;
          else if (isym.st_shndx == SHN_COMMON)
            sym_sec = bfd_com_section_ptr;
+         else
+           abort ();
 
          symval = (isym.st_value
                    + sym_sec->output_section->vma
@@ -1477,13 +1508,16 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
 
          /* Tack on an ID so we can uniquely identify this
             local symbol in the global hash table.  */
-         new_name = alloca (strlen (sym_name) + 10);
-         sprintf (new_name, "%s_%08x", sym_name, (int)sym_sec);
+         new_name = bfd_malloc ((bfd_size_type) strlen (sym_name) + 10);
+         if (new_name == 0)
+           goto error_return;
+         sprintf (new_name, "%s_%08x", sym_name, (int) sym_sec);
          sym_name = new_name;
 
          h = (struct elf32_mn10300_link_hash_entry *)
                elf_link_hash_lookup (&hash_table->static_hash_table->root,
                                      sym_name, false, false, false);
+         free (new_name);
        }
       else
        {
@@ -1591,7 +1625,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          /* See if the value will fit in 16 bits, note the high value is
             0x7fff + 2 as the target will be two bytes closer if we are
             able to relax.  */
-         if ((long)value < 0x8001 && (long)value > -0x8000)
+         if ((long) value < 0x8001 && (long) value > -0x8000)
            {
              unsigned char code;
 
@@ -1706,7 +1740,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          /* See if the value will fit in 8 bits, note the high value is
             0x7f + 1 as the target will be one bytes closer if we are
             able to relax.  */
-         if ((long)value < 0x80 && (long)value > -0x80)
+         if ((long) value < 0x80 && (long) value > -0x80)
            {
              unsigned char code;
 
@@ -1753,7 +1787,6 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
            bra lab2
           lab1:               lab1:
 
-
         This happens when the bCC can't reach lab2 at assembly time,
         but due to other relaxations it can reach at link time.  */
       if (ELF32_R_TYPE (irel->r_info) == (int) R_MN10300_PCREL8)
@@ -1826,48 +1859,48 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          /* Reverse the condition of the first branch.  */
          switch (code)
            {
-             case 0xc8:
-               code = 0xc9;
-               break;
-             case 0xc9:
-               code = 0xc8;
-               break;
-             case 0xc0:
-               code = 0xc2;
-               break;
-             case 0xc2:
-               code = 0xc0;
-               break;
-             case 0xc3:
-               code = 0xc1;
-               break;
-             case 0xc1:
-               code = 0xc3;
-               break;
-             case 0xc4:
-               code = 0xc6;
-               break;
-             case 0xc6:
-               code = 0xc4;
-               break;
-             case 0xc7:
-               code = 0xc5;
-               break;
-             case 0xc5:
-               code = 0xc7;
-               break;
-             case 0xe8:
-               code = 0xe9;
-               break;
-             case 0x9d:
-               code = 0xe8;
-               break;
-             case 0xea:
-               code = 0xeb;
-               break;
-             case 0xeb:
-               code = 0xea;
-               break;
+           case 0xc8:
+             code = 0xc9;
+             break;
+           case 0xc9:
+             code = 0xc8;
+             break;
+           case 0xc0:
+             code = 0xc2;
+             break;
+           case 0xc2:
+             code = 0xc0;
+             break;
+           case 0xc3:
+             code = 0xc1;
+             break;
+           case 0xc1:
+             code = 0xc3;
+             break;
+           case 0xc4:
+             code = 0xc6;
+             break;
+           case 0xc6:
+             code = 0xc4;
+             break;
+           case 0xc7:
+             code = 0xc5;
+             break;
+           case 0xc5:
+             code = 0xc7;
+             break;
+           case 0xe8:
+             code = 0xe9;
+             break;
+           case 0x9d:
+             code = 0xe8;
+             break;
+           case 0xea:
+             code = 0xeb;
+             break;
+           case 0xeb:
+             code = 0xea;
+             break;
            }
          bfd_put_8 (abfd, code, contents + irel->r_offset - 1);
 
@@ -1889,7 +1922,6 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          *again = true;
        }
 
-      /* start-sanitize-am33 */
       /* Try to turn a 24 immediate, displacement or absolute address
         into a 8 immediate, displacement or absolute address.  */
       if (ELF32_R_TYPE (irel->r_info) == (int) R_MN10300_24)
@@ -1897,8 +1929,8 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          bfd_vma value = symval;
          value += irel->r_addend;
 
-         /* See if the value will fit in 8 bits.
-         if ((long)value < 0x7f && (long)value > -0x80)
+         /* See if the value will fit in 8 bits.  */
+         if ((long) value < 0x7f && (long) value > -0x80)
            {
              unsigned char code;
 
@@ -1910,12 +1942,16 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
 
              if (code == 0xfd)
                {
-                 /* Get the second opcode.  */
-                 code = bfd_get_8 (abfd, contents + irel->r_offset - 2);
-
-                 if ((code & 0x0f) == 0x09 || (code & 0x0f) == 0x08
-                     || (code & 0x0f) == 0x0a || (code & 0x0f) == 0x0b
-                     || (code & 0x0f) == 0x0e)
+                 /* Get the second opcode.  */
+                 code = bfd_get_8 (abfd, contents + irel->r_offset - 2);
+
+                 /* We can not relax 0x6b, 0x7b, 0x8b, 0x9b as no 24bit
+                    equivalent instructions exists.  */
+                 if (code != 0x6b && code != 0x7b
+                     && code != 0x8b && code != 0x9b
+                     && ((code & 0x0f) == 0x09 || (code & 0x0f) == 0x08
+                         || (code & 0x0f) == 0x0a || (code & 0x0f) == 0x0b
+                         || (code & 0x0f) == 0x0e))
                    {
                      /* Not safe if the high bit is on as relaxing may
                         move the value out of high mem and thus not fit
@@ -1939,27 +1975,25 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                          bfd_put_8 (abfd, code, contents + irel->r_offset - 2);
 
                          /* Fix the relocation's type.  */
-                         irel->r_info
-                           ELF32_R_INFO (ELF32_R_SYM (irel->r_info),
-                                                        R_MN10300_8);
+                         irel->r_info =
+                           ELF32_R_INFO (ELF32_R_SYM (irel->r_info),
+                                         R_MN10300_8);
 
                          /* Delete two bytes of data.  */
                          if (!mn10300_elf_relax_delete_bytes (abfd, sec,
-                                                              irel->r_offset + 3, 2))
+                                                              irel->r_offset + 1, 2))
                            goto error_return;
 
                          /* That will change things, so, we should relax
                             again.  Note that this is not required, and it
-                             may be slow.  */
+                            may be slow.  */
                          *again = true;
                          break;
                        }
                    }
-
                }
            }
        }
-      /* end-sanitize-am33 */
 
       /* Try to turn a 32bit immediate, displacement or absolute address
         into a 16bit immediate, displacement or absolute address.  */
@@ -1968,11 +2002,10 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
          bfd_vma value = symval;
          value += irel->r_addend;
 
-         /* start-sanitize-am33 */
          /* See if the value will fit in 24 bits.
             We allow any 16bit match here.  We prune those we can't
             handle below.  */
-         if ((long)value < 0x7fffff && (long)value > -0x800000)
+         if ((long) value < 0x7fffff && (long) value > -0x800000)
            {
              unsigned char code;
 
@@ -1988,9 +2021,13 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                  code = bfd_get_8 (abfd, contents + irel->r_offset - 2);
 
                  /* All the am33 32 -> 24 relaxing possibilities.  */
-                 if ((code & 0x0f) == 0x09 || (code & 0x0f) == 0x08
-                     || (code & 0x0f) == 0x0a || (code & 0x0f) == 0x0b
-                     || (code & 0x0f) == 0x0e)
+                 /* We can not relax 0x6b, 0x7b, 0x8b, 0x9b as no 24bit
+                    equivalent instructions exists.  */
+                 if (code != 0x6b && code != 0x7b
+                     && code != 0x8b && code != 0x9b
+                     && ((code & 0x0f) == 0x09 || (code & 0x0f) == 0x08
+                         || (code & 0x0f) == 0x0a || (code & 0x0f) == 0x0b
+                         || (code & 0x0f) == 0x0e))
                    {
                      /* Not safe if the high bit is on as relaxing may
                         move the value out of high mem and thus not fit
@@ -2014,9 +2051,9 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                          bfd_put_8 (abfd, code, contents + irel->r_offset - 2);
 
                          /* Fix the relocation's type.  */
-                         irel->r_info
-                           ELF32_R_INFO (ELF32_R_SYM (irel->r_info),
-                                                        R_MN10300_24);
+                         irel->r_info =
+                           ELF32_R_INFO (ELF32_R_SYM (irel->r_info),
+                                         R_MN10300_24);
 
                          /* Delete one byte of data.  */
                          if (!mn10300_elf_relax_delete_bytes (abfd, sec,
@@ -2025,20 +2062,18 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
 
                          /* That will change things, so, we should relax
                             again.  Note that this is not required, and it
-                             may be slow.  */
+                            may be slow.  */
                          *again = true;
                          break;
                        }
                    }
-
                }
            }
-         /* end-sanitize-am33 */
 
          /* See if the value will fit in 16 bits.
             We allow any 16bit match here.  We prune those we can't
             handle below.  */
-         if ((long)value < 0x7fff && (long)value > -0x8000)
+         if ((long) value < 0x7fff && (long) value > -0x8000)
            {
              unsigned char code;
 
@@ -2173,6 +2208,11 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                  case 0x91:
                  case 0x92:
                  case 0x93:
+                   /* sp-based offsets are zero-extended.  */
+                   if (code >= 0x90 && code <= 0x93
+                       && (long)value < 0)
+                     continue;
+
                    /* Note that we've changed the relocation contents, etc.  */
                    elf_section_data (sec)->relocs = internal_relocs;
                    free_relocs = NULL;
@@ -2221,6 +2261,11 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                        && (value & 0x8000))
                      continue;
 
+                   /* mov imm16, an zero-extends the immediate.  */
+                   if (code == 0xdc
+                       && (long)value < 0)
+                     continue;
+
                    /* Note that we've changed the relocation contents, etc.  */
                    elf_section_data (sec)->relocs = internal_relocs;
                    free_relocs = NULL;
@@ -2266,18 +2311,18 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                    break;
 
                  /* mov (abs32),an    -> mov (abs16),an
-                    mov (d32,sp),an   -> mov (d32,sp),an
-                    mov (d32,sp),dn   -> mov (d32,sp),dn
-                    movbu (d32,sp),dn -> movbu (d32,sp),dn
-                    movhu (d32,sp),dn -> movhu (d32,sp),dn
+                    mov (d32,sp),an   -> mov (d16,sp),an
+                    mov (d32,sp),dn   -> mov (d16,sp),dn
+                    movbu (d32,sp),dn -> movbu (d16,sp),dn
+                    movhu (d32,sp),dn -> movhu (d16,sp),dn
                     add imm32,dn      -> add imm16,dn
                     cmp imm32,dn      -> cmp imm16,dn
                     add imm32,an      -> add imm16,an
                     cmp imm32,an      -> cmp imm16,an
-                    and imm32,dn      -> and imm32,dn
-                    or imm32,dn       -> or imm32,dn
-                    xor imm32,dn      -> xor imm32,dn
-                    btst imm32,dn     -> btst imm32,dn */
+                    and imm32,dn      -> and imm16,dn
+                    or imm32,dn       -> or imm16,dn
+                    xor imm32,dn      -> xor imm16,dn
+                    btst imm32,dn     -> btst imm16,dn */
 
                  case 0xa0:
                  case 0xb0:
@@ -2293,6 +2338,16 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
                  case 0xe1:
                  case 0xe2:
                  case 0xe3:
+                   /* cmp imm16, an zero-extends the immediate.  */
+                   if (code == 0xdc
+                       && (long)value < 0)
+                     continue;
+
+                   /* So do sp-based offsets.  */
+                   if (code >= 0xb0 && code <= 0xb3
+                       && (long)value < 0)
+                     continue;
+
                    /* Note that we've changed the relocation contents, etc.  */
                    elf_section_data (sec)->relocs = internal_relocs;
                    free_relocs = NULL;
@@ -2341,7 +2396,7 @@ mn10300_elf_relax_section (abfd, sec, link_info, again)
 
                  /* Fix the relocation's type.  */
                  irel->r_info = ELF32_R_INFO (ELF32_R_SYM (irel->r_info),
-                                                R_MN10300_16);
+                                              R_MN10300_16);
 
                  /* Delete two bytes of data.  */
                  if (!mn10300_elf_relax_delete_bytes (abfd, sec,
@@ -2456,7 +2511,6 @@ compute_function_info (abfd, hash, addr, contents)
       if (hash->movm_args & 0x08)
        hash->movm_stack_size += 8 * 4;
 
-      /* start-sanitize-am33 */
       if (bfd_get_mach (abfd) == bfd_mach_am33)
        {
          /* "exother" space.  e0, e1, mdrq, mcrh, mcrl, mcvf */
@@ -2471,7 +2525,6 @@ compute_function_info (abfd, hash, addr, contents)
          if (hash->movm_args & 0x4)
            hash->movm_stack_size += 2 * 4;
        }
-      /* end-sanitize-am33 */
     }
 
   /* Now look for the two stack adjustment variants.  */
@@ -2537,7 +2590,8 @@ mn10300_elf_relax_delete_bytes (abfd, sec, addr, count)
   irelend = irel + sec->reloc_count;
 
   /* Actually delete the bytes.  */
-  memmove (contents + addr, contents + addr + count, toaddr - addr - count);
+  memmove (contents + addr, contents + addr + count,
+          (size_t) (toaddr - addr - count));
   sec->_cooked_size -= count;
 
   /* Adjust all the relocs.  */
@@ -2622,7 +2676,7 @@ mn10300_elf_symbol_address_p (abfd, sec, extsyms, addr)
        return true;
     }
 
-  sym_hash = (struct elf32_mn10300_link_hash_entry **)(elf_sym_hashes (abfd));
+  sym_hash = (struct elf32_mn10300_link_hash_entry **) (elf_sym_hashes (abfd));
   sym_hash_end = (sym_hash
                  + (symtab_hdr->sh_size / sizeof (Elf32_External_Sym)
                     - symtab_hdr->sh_info));
@@ -2670,7 +2724,7 @@ mn10300_elf_get_relocated_section_contents (output_bfd, link_info, link_order,
   symtab_hdr = &elf_tdata (input_bfd)->symtab_hdr;
 
   memcpy (data, elf_section_data (input_section)->this_hdr.contents,
-         input_section->_raw_size);
+         (size_t) input_section->_raw_size);
 
   if ((input_section->flags & SEC_RELOC) != 0
       && input_section->reloc_count > 0)
@@ -2678,20 +2732,19 @@ mn10300_elf_get_relocated_section_contents (output_bfd, link_info, link_order,
       Elf_Internal_Sym *isymp;
       asection **secpp;
       Elf32_External_Sym *esym, *esymend;
+      bfd_size_type size;
 
       if (symtab_hdr->contents != NULL)
        external_syms = (Elf32_External_Sym *) symtab_hdr->contents;
       else
        {
-         external_syms = ((Elf32_External_Sym *)
-                          bfd_malloc (symtab_hdr->sh_info
-                                      * sizeof (Elf32_External_Sym)));
-         if (external_syms == NULL && symtab_hdr->sh_info > 0)
+         size = symtab_hdr->sh_info;
+         size *= sizeof (Elf32_External_Sym);
+         external_syms = (Elf32_External_Sym *) bfd_malloc (size);
+         if (external_syms == NULL && size != 0)
            goto error_return;
          if (bfd_seek (input_bfd, symtab_hdr->sh_offset, SEEK_SET) != 0
-             || (bfd_read (external_syms, sizeof (Elf32_External_Sym),
-                           symtab_hdr->sh_info, input_bfd)
-                 != (symtab_hdr->sh_info * sizeof (Elf32_External_Sym))))
+             || bfd_bread (external_syms, size, input_bfd) != size)
            goto error_return;
        }
 
@@ -2701,15 +2754,16 @@ mn10300_elf_get_relocated_section_contents (output_bfd, link_info, link_order,
       if (internal_relocs == NULL)
        goto error_return;
 
-      internal_syms = ((Elf_Internal_Sym *)
-                      bfd_malloc (symtab_hdr->sh_info
-                                  * sizeof (Elf_Internal_Sym)));
-      if (internal_syms == NULL && symtab_hdr->sh_info > 0)
+      size = symtab_hdr->sh_info;
+      size *= sizeof (Elf_Internal_Sym);
+      internal_syms = (Elf_Internal_Sym *) bfd_malloc (size);
+      if (internal_syms == NULL && size != 0)
        goto error_return;
 
-      sections = (asection **) bfd_malloc (symtab_hdr->sh_info
-                                          * sizeof (asection *));
-      if (sections == NULL && symtab_hdr->sh_info > 0)
+      size = symtab_hdr->sh_info;
+      size *= sizeof (asection *);
+      sections = (asection **) bfd_malloc (size);
+      if (sections == NULL && size != 0)
        goto error_return;
 
       isymp = internal_syms;
@@ -2820,9 +2874,9 @@ elf32_mn10300_link_hash_table_create (abfd)
      bfd *abfd;
 {
   struct elf32_mn10300_link_hash_table *ret;
+  bfd_size_type amt = sizeof (struct elf32_mn10300_link_hash_table);
 
-  ret = ((struct elf32_mn10300_link_hash_table *)
-        bfd_alloc (abfd, sizeof (struct elf32_mn10300_link_hash_table)));
+  ret = (struct elf32_mn10300_link_hash_table *) bfd_alloc (abfd, amt);
   if (ret == (struct elf32_mn10300_link_hash_table *) NULL)
     return NULL;
 
@@ -2834,9 +2888,9 @@ elf32_mn10300_link_hash_table_create (abfd)
     }
 
   ret->flags = 0;
+  amt = sizeof (struct elf_link_hash_table);
   ret->static_hash_table
-    = ((struct elf32_mn10300_link_hash_table *)
-       bfd_alloc (abfd, sizeof (struct elf_link_hash_table)));
+    = (struct elf32_mn10300_link_hash_table *) bfd_alloc (abfd, amt);
   if (ret->static_hash_table == NULL)
     {
       bfd_release (abfd, ret);
@@ -2853,20 +2907,18 @@ elf32_mn10300_link_hash_table_create (abfd)
   return &ret->root.root;
 }
 
-static int
+static unsigned long
 elf_mn10300_mach (flags)
      flagword flags;
 {
   switch (flags & EF_MN10300_MACH)
     {
-      case E_MN10300_MACH_MN10300:
-      default:
-        return bfd_mach_mn10300;
-
-      /* start-sanitize-am33 */
-      case E_MN10300_MACH_AM33:
-        return bfd_mach_am33;
-      /* end-sanitize-am33 */
+    case E_MN10300_MACH_MN10300:
+    default:
+      return bfd_mach_mn10300;
+
+    case E_MN10300_MACH_AM33:
+      return bfd_mach_am33;
     }
 }
 
@@ -2874,30 +2926,23 @@ elf_mn10300_mach (flags)
    file.  This gets the MN10300 architecture right based on the machine
    number.  */
 
-/*ARGSUSED*/
 void
 _bfd_mn10300_elf_final_write_processing (abfd, linker)
      bfd *abfd;
-     boolean linker;
+     boolean linker ATTRIBUTE_UNUSED;
 {
   unsigned long val;
-  unsigned int i;
-  Elf_Internal_Shdr **hdrpp;
-  const char *name;
-  asection *sec;
 
   switch (bfd_get_mach (abfd))
     {
-      default:
-      case bfd_mach_mn10300:
-       val = E_MN10300_MACH_MN10300;
-       break;
-
-      /* start-sanitize-am33 */
-      case bfd_mach_am33:
-       val = E_MN10300_MACH_AM33;
-       break;
-      /* end-sanitize-am33 */
+    default:
+    case bfd_mach_mn10300:
+      val = E_MN10300_MACH_MN10300;
+      break;
+
+    case bfd_mach_am33:
+      val = E_MN10300_MACH_AM33;
+      break;
     }
 
   elf_elfheader (abfd)->e_flags &= ~ (EF_MN10300_MACH);
@@ -2909,7 +2954,7 @@ _bfd_mn10300_elf_object_p (abfd)
      bfd *abfd;
 {
   bfd_default_set_arch_mach (abfd, bfd_arch_mn10300,
-                             elf_mn10300_mach (elf_elfheader (abfd)->e_flags));
+                            elf_mn10300_mach (elf_elfheader (abfd)->e_flags));
   return true;
 }
 
@@ -2936,11 +2981,11 @@ _bfd_mn10300_elf_merge_private_bfd_data (ibfd, obfd)
   return true;
 }
 
-
 #define TARGET_LITTLE_SYM      bfd_elf32_mn10300_vec
 #define TARGET_LITTLE_NAME     "elf32-mn10300"
 #define ELF_ARCH               bfd_arch_mn10300
-#define ELF_MACHINE_CODE       EM_CYGNUS_MN10300
+#define ELF_MACHINE_CODE       EM_MN10300
+#define ELF_MACHINE_ALT1       EM_CYGNUS_MN10300
 #define ELF_MAXPAGESIZE                0x1000
 
 #define elf_info_to_howto              mn10300_info_to_howto
@@ -2965,5 +3010,4 @@ _bfd_mn10300_elf_merge_private_bfd_data (ibfd, obfd)
 #define bfd_elf32_bfd_merge_private_bfd_data \
                                         _bfd_mn10300_elf_merge_private_bfd_data
 
-
 #include "elf32-target.h"