/* rddbg.c -- Read debugging information into a generic form.
- Copyright (C) 1995-2014 Free Software Foundation, Inc.
+ Copyright (C) 1995-2021 Free Software Foundation, Inc.
Written by Ian Lance Taylor <ian@cygnus.com>.
This file is part of GNU Binutils.
#include "debug.h"
#include "budbg.h"
-static bfd_boolean read_section_stabs_debugging_info
- (bfd *, asymbol **, long, void *, bfd_boolean *);
-static bfd_boolean read_symbol_stabs_debugging_info
- (bfd *, asymbol **, long, void *, bfd_boolean *);
-static bfd_boolean read_ieee_debugging_info (bfd *, void *, bfd_boolean *);
+static bool read_section_stabs_debugging_info
+ (bfd *, asymbol **, long, void *, bool *);
+static bool read_symbol_stabs_debugging_info
+ (bfd *, asymbol **, long, void *, bool *);
static void save_stab (int, int, bfd_vma, const char *);
static void stab_context (void);
static void free_saved_stabs (void);
pointer. */
void *
-read_debugging_info (bfd *abfd, asymbol **syms, long symcount, bfd_boolean no_messages)
+read_debugging_info (bfd *abfd, asymbol **syms, long symcount,
+ bool no_messages)
{
void *dhandle;
- bfd_boolean found;
+ bool found;
dhandle = debug_init ();
if (dhandle == NULL)
if (! read_section_stabs_debugging_info (abfd, syms, symcount, dhandle,
&found))
- return NULL;
+ goto err_exit;
if (bfd_get_flavour (abfd) == bfd_target_aout_flavour)
{
if (! read_symbol_stabs_debugging_info (abfd, syms, symcount, dhandle,
&found))
- return NULL;
- }
-
- if (bfd_get_flavour (abfd) == bfd_target_ieee_flavour)
- {
- if (! read_ieee_debugging_info (abfd, dhandle, &found))
- return NULL;
+ goto err_exit;
}
/* Try reading the COFF symbols if we didn't find any stabs in COFF
&& symcount > 0)
{
if (! parse_coff (abfd, syms, symcount, dhandle))
- return NULL;
- found = TRUE;
+ goto err_exit;
+ found = true;
}
if (! found)
if (! no_messages)
non_fatal (_("%s: no recognized debugging information"),
bfd_get_filename (abfd));
+ err_exit:
+ free (dhandle);
return NULL;
}
/* Read stabs in sections debugging information from a BFD. */
-static bfd_boolean
+static bool
read_section_stabs_debugging_info (bfd *abfd, asymbol **syms, long symcount,
- void *dhandle, bfd_boolean *pfound)
+ void *dhandle, bool *pfound)
{
static struct
{
unsigned int i;
void *shandle;
- *pfound = FALSE;
+ *pfound = false;
shandle = NULL;
for (i = 0; i < sizeof names / sizeof names[0]; i++)
bfd_byte *stab;
bfd_size_type stroff, next_stroff;
- stabsize = bfd_section_size (abfd, sec);
+ stabsize = bfd_section_size (sec);
stabs = (bfd_byte *) xmalloc (stabsize);
if (! bfd_get_section_contents (abfd, sec, stabs, 0, stabsize))
{
fprintf (stderr, "%s: %s: %s\n",
bfd_get_filename (abfd), names[i].secname,
bfd_errmsg (bfd_get_error ()));
- return FALSE;
+ free (shandle);
+ free (stabs);
+ return false;
}
- strsize = bfd_section_size (abfd, strsec);
- strings = (bfd_byte *) xmalloc (strsize);
+ strsize = bfd_section_size (strsec);
+ strings = (bfd_byte *) xmalloc (strsize + 1);
if (! bfd_get_section_contents (abfd, strsec, strings, 0, strsize))
{
fprintf (stderr, "%s: %s: %s\n",
bfd_get_filename (abfd), names[i].strsecname,
bfd_errmsg (bfd_get_error ()));
- return FALSE;
+ free (shandle);
+ free (strings);
+ free (stabs);
+ return false;
}
-
+ /* Zero terminate the strings table, just in case. */
+ strings [strsize] = 0;
if (shandle == NULL)
{
- shandle = start_stab (dhandle, abfd, TRUE, syms, symcount);
+ shandle = start_stab (dhandle, abfd, true, syms, symcount);
if (shandle == NULL)
- return FALSE;
+ {
+ free (strings);
+ free (stabs);
+ return false;
+ }
}
- *pfound = TRUE;
+ *pfound = true;
stroff = 0;
next_stroff = 0;
- for (stab = stabs; stab < stabs + stabsize; stab += 12)
+ /* PR 17512: file: 078-60391-0.001:0.1. */
+ for (stab = stabs; stab <= (stabs + stabsize) - 12; stab += 12)
{
unsigned int strx;
int type;
}
else
{
+ size_t len;
char *f, *s;
- f = NULL;
-
- if (stroff + strx > strsize)
+ if (stroff + strx >= strsize)
{
- fprintf (stderr, "%s: %s: stab entry %ld is corrupt, strx = 0x%x, type = %d\n",
+ fprintf (stderr, _("%s: %s: stab entry %ld is corrupt, strx = 0x%x, type = %d\n"),
bfd_get_filename (abfd), names[i].secname,
(long) (stab - stabs) / 12, strx, type);
continue;
}
s = (char *) strings + stroff + strx;
+ f = NULL;
- while (s[strlen (s) - 1] == '\\'
+ /* PR 17512: file: 002-87578-0.001:0.1.
+ It is possible to craft a file where, without the 'strlen (s) > 0',
+ an attempt to read the byte before 'strings' would occur. */
+ while ((len = strlen (s)) > 0
+ && s[len - 1] == '\\'
&& stab + 12 < stabs + stabsize)
{
char *p;
stab += 12;
- p = s + strlen (s) - 1;
+ p = s + len - 1;
*p = '\0';
- s = concat (s,
- ((char *) strings
- + stroff
- + bfd_get_32 (abfd, stab)),
+ strx = stroff + bfd_get_32 (abfd, stab);
+ if (strx >= strsize)
+ {
+ fprintf (stderr, _("%s: %s: stab entry %ld is corrupt\n"),
+ bfd_get_filename (abfd), names[i].secname,
+ (long) (stab - stabs) / 12);
+ break;
+ }
+
+ s = concat (s, (char *) strings + strx,
(const char *) NULL);
/* We have to restore the backslash, because, if
see the same string more than once. */
*p = '\\';
- if (f != NULL)
- free (f);
+ free (f);
f = s;
}
{
stab_context ();
free_saved_stabs ();
- return FALSE;
+ free (f);
+ free (shandle);
+ free (stabs);
+ free (strings);
+ return false;
}
/* Don't free f, since I think the stabs code
if (shandle != NULL)
{
if (! finish_stab (dhandle, shandle))
- return FALSE;
+ return false;
}
- return TRUE;
+ return true;
}
/* Read stabs in the symbol table. */
-static bfd_boolean
+static bool
read_symbol_stabs_debugging_info (bfd *abfd, asymbol **syms, long symcount,
- void *dhandle, bfd_boolean *pfound)
+ void *dhandle, bool *pfound)
{
void *shandle;
asymbol **ps, **symend;
if (shandle == NULL)
{
- shandle = start_stab (dhandle, abfd, FALSE, syms, symcount);
+ shandle = start_stab (dhandle, abfd, false, syms, symcount);
if (shandle == NULL)
- return FALSE;
+ return false;
}
- *pfound = TRUE;
+ *pfound = true;
s = i.name;
+ if (s == NULL || strlen (s) < 1)
+ return false;
f = NULL;
- while (s[strlen (s) - 1] == '\\'
+
+ while (strlen (s) > 0
+ && s[strlen (s) - 1] == '\\'
&& ps + 1 < symend)
{
char *sc, *n;
sc[strlen (sc) - 1] = '\0';
n = concat (sc, bfd_asymbol_name (*ps), (const char *) NULL);
free (sc);
- if (f != NULL)
- free (f);
+ free (f);
f = n;
s = n;
}
{
stab_context ();
free_saved_stabs ();
- return FALSE;
+ return false;
}
/* Don't free f, since I think the stabs code expects
if (shandle != NULL)
{
if (! finish_stab (dhandle, shandle))
- return FALSE;
+ return false;
}
- return TRUE;
-}
-
-/* Read IEEE debugging information. */
-
-static bfd_boolean
-read_ieee_debugging_info (bfd *abfd, void *dhandle, bfd_boolean *pfound)
-{
- asection *dsec;
- bfd_size_type size;
- bfd_byte *contents;
-
- /* The BFD backend puts the debugging information into a section
- named .debug. */
-
- dsec = bfd_get_section_by_name (abfd, ".debug");
- if (dsec == NULL)
- return TRUE;
-
- size = bfd_section_size (abfd, dsec);
- contents = (bfd_byte *) xmalloc (size);
- if (! bfd_get_section_contents (abfd, dsec, contents, 0, size))
- return FALSE;
-
- if (! parse_ieee (dhandle, abfd, contents, size))
- return FALSE;
-
- free (contents);
-
- *pfound = TRUE;
-
- return TRUE;
+ return true;
}
\f
/* Record stabs strings, so that we can give some context for errors. */
static void
save_stab (int type, int desc, bfd_vma value, const char *string)
{
- if (saved_stabs[saved_stabs_index].string != NULL)
- free (saved_stabs[saved_stabs_index].string);
+ free (saved_stabs[saved_stabs_index].string);
saved_stabs[saved_stabs_index].type = type;
saved_stabs[saved_stabs_index].desc = desc;
saved_stabs[saved_stabs_index].value = value;
for (i = 0; i < SAVE_STABS_COUNT; i++)
{
- if (saved_stabs[i].string != NULL)
- {
- free (saved_stabs[i].string);
- saved_stabs[i].string = NULL;
- }
+ free (saved_stabs[i].string);
+ saved_stabs[i].string = NULL;
}
saved_stabs_index = 0;
projects / thirdparty / binutils-gdb.git / blobdiff