]> git.ipfire.org Git - thirdparty/e2fsprogs.git/blobdiff - debugfs/debugfs.c
ext4.5: add preprocessor hint
[thirdparty/e2fsprogs.git] / debugfs / debugfs.c
index cef4ec2834fa0fb75f5e2adacf3338d40e7dabb1..909c1df39bbf1fc27f1e2c5c306e338f75587f34 100644 (file)
@@ -48,20 +48,28 @@ extern char *optarg;
 int journal_enable_debug = -1;
 #endif
 
+/*
+ * There must be only one definition if we're hooking in extra commands or
+ * changing default prompt. Use -DSKIP_GLOBDEF for that.
+ */
+#ifndef SKIP_GLOBDEFS
 ss_request_table *extra_cmds;
 const char *debug_prog_name;
-int sci_idx;
+#endif
+int ss_sci_idx;
 
 ext2_filsys    current_fs;
 quota_ctx_t    current_qctx;
 ext2_ino_t     root, cwd;
+int            no_copy_xattrs;
 
 static int debugfs_setup_tdb(const char *device_name, char *undo_file,
                             io_manager *io_ptr)
 {
        errcode_t retval = ENOMEM;
-       char *tdb_dir = NULL, *tdb_file = NULL;
-       char *dev_name, *tmp_name;
+       const char      *tdb_dir = NULL;
+       char            *tdb_file = NULL;
+       char            *dev_name, *tmp_name;
 
        /* (re)open a specific undo file */
        if (undo_file && undo_file[0] != 0) {
@@ -159,13 +167,8 @@ static void open_filesystem(char *device, int open_flags, blk64_t superblock,
                }
        }
 
-       if (catastrophic && (open_flags & EXT2_FLAG_RW)) {
-               com_err(device, 0,
-                       "opening read-only because of catastrophic mode");
-               open_flags &= ~EXT2_FLAG_RW;
-       }
        if (catastrophic)
-               open_flags |= EXT2_FLAG_SKIP_MMP;
+               open_flags |= EXT2_FLAG_SKIP_MMP | EXT2_FLAG_IGNORE_SB_ERRORS;
 
        if (undo_file) {
                retval = debugfs_setup_tdb(device, undo_file, &io_ptr);
@@ -176,13 +179,15 @@ static void open_filesystem(char *device, int open_flags, blk64_t superblock,
 try_open_again:
        retval = ext2fs_open(device, open_flags, superblock, blocksize,
                             io_ptr, &current_fs);
-       if (retval && !(open_flags & EXT2_FLAG_IGNORE_CSUM_ERRORS)) {
+       if (retval && (retval == EXT2_ET_SB_CSUM_INVALID) &&
+           !(open_flags & EXT2_FLAG_IGNORE_CSUM_ERRORS)) {
                open_flags |= EXT2_FLAG_IGNORE_CSUM_ERRORS;
                printf("Checksum errors in superblock!  Retrying...\n");
                goto try_open_again;
        }
        if (retval) {
-               com_err(device, retval, "while opening filesystem");
+               com_err(debug_prog_name, retval,
+                       "while trying to open %s", device);
                if (retval == EXT2_ET_BAD_MAGIC)
                        check_plausibility(device, CHECK_FS_EXIST, NULL);
                current_fs = NULL;
@@ -190,17 +195,11 @@ try_open_again:
        }
        current_fs->default_bitmap_type = EXT2FS_BMAP64_RBTREE;
 
-       if (catastrophic)
-               com_err(device, 0, "catastrophic mode - not reading inode or group bitmaps");
-       else {
-               retval = ext2fs_read_inode_bitmap(current_fs);
+       if (!catastrophic) {
+               retval = ext2fs_read_bitmaps(current_fs);
                if (retval) {
-                       com_err(device, retval, "while reading inode bitmap");
-                       goto errout;
-               }
-               retval = ext2fs_read_block_bitmap(current_fs);
-               if (retval) {
-                       com_err(device, retval, "while reading block bitmap");
+                       com_err(device, retval,
+                               "while reading allocation bitmaps");
                        goto errout;
                }
        }
@@ -223,13 +222,15 @@ errout:
                com_err(device, retval, "while trying to close filesystem");
 }
 
-void do_open_filesys(int argc, char **argv)
+void do_open_filesys(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                    void *infop EXT2FS_ATTR((unused)))
 {
        int     c, err;
        int     catastrophic = 0;
        blk64_t superblock = 0;
        blk64_t blocksize = 0;
-       int     open_flags = EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS; 
+       int     open_flags = EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS |
+               EXT2_FLAG_THREADS;
        char    *data_filename = 0;
        char    *undo_file = NULL;
 
@@ -274,7 +275,11 @@ void do_open_filesys(int argc, char **argv)
                                return;
                        break;
                case 'z':
+#ifdef READ_ONLY
+                       goto print_usage;
+#else
                        undo_file = optarg;
+#endif
                        break;
                default:
                        goto print_usage;
@@ -292,14 +297,16 @@ void do_open_filesys(int argc, char **argv)
 
 print_usage:
        fprintf(stderr, "%s: Usage: open [-s superblock] [-b blocksize] "
-               "[-d image_filename] [-c] [-i] [-f] [-e] [-D] "
-#ifndef READ_ONLY
-               "[-w] "
+#ifdef READ_ONLY
+               "[-d image_filename] [-z undo_file] [-c] [-i] [-f] [-e] [-D] "
+#else
+               "[-d image_filename] [-c] [-i] [-f] [-e] [-D] [-w] "
 #endif
                "<device>\n", argv[0]);
 }
 
-void do_lcd(int argc, char **argv)
+void do_lcd(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+           void *infop EXT2FS_ATTR((unused)))
 {
        if (argc != 2) {
                com_err(argv[0], 0, "Usage: %s %s", argv[0], "<native dir>");
@@ -336,7 +343,8 @@ static void close_filesystem(NOARGS)
        return;
 }
 
-void do_close_filesys(int argc, char **argv)
+void do_close_filesys(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                     void *infop EXT2FS_ATTR((unused)))
 {
        int     c;
 
@@ -364,7 +372,8 @@ void do_close_filesys(int argc, char **argv)
 }
 
 #ifndef READ_ONLY
-void do_init_filesys(int argc, char **argv)
+void do_init_filesys(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                    void *infop EXT2FS_ATTR((unused)))
 {
        struct ext2_super_block param;
        errcode_t       retval;
@@ -424,7 +433,9 @@ static void print_bg_opts(ext2_filsys fs, dgrp_t group, int mask,
        }
 }
 
-void do_show_super_stats(int argc, char *argv[])
+void do_show_super_stats(int argc, ss_argv_t argv,
+                        int sci_idx EXT2FS_ATTR((unused)),
+                        void *infop EXT2FS_ATTR((unused)))
 {
        const char *units ="block";
        dgrp_t  i;
@@ -466,7 +477,7 @@ void do_show_super_stats(int argc, char *argv[])
        }
        for (i=0; i < current_fs->group_desc_count; i++)
                numdirs += ext2fs_bg_used_dirs_count(current_fs, i);
-       fprintf(out, "Directories:              %d\n", numdirs);
+       fprintf(out, "Directories:              %u\n", numdirs);
 
        if (header_only) {
                close_pager(out);
@@ -480,11 +491,12 @@ void do_show_super_stats(int argc, char *argv[])
                        "inode table at %llu\n"
                        "           %u free %s%s, "
                        "%u free %s, "
-                       "%u used %s%s",
-                       i, ext2fs_block_bitmap_loc(current_fs, i),
-                       ext2fs_inode_bitmap_loc(current_fs, i),
-                       ext2fs_inode_table_loc(current_fs, i),
-                       ext2fs_bg_free_blocks_count(current_fs, i), units,
+                       "%u used %s%s", i,
+                       (unsigned long long) ext2fs_block_bitmap_loc(current_fs, i),
+                       (unsigned long long) ext2fs_inode_bitmap_loc(current_fs, i),
+                       (unsigned long long) ext2fs_inode_table_loc(current_fs, i),
+                       ext2fs_bg_free_blocks_count(current_fs, i),
+                       units,
                        ext2fs_bg_free_blocks_count(current_fs, i) != 1 ?
                        "s" : "",
                        ext2fs_bg_free_inodes_count(current_fs, i),
@@ -514,12 +526,14 @@ void do_show_super_stats(int argc, char *argv[])
        close_pager(out);
        return;
 print_usage:
-       fprintf(stderr, "%s: Usage: show_super [-h]\n", argv[0]);
+       fprintf(stderr, "%s: Usage: show_super_stats [-h]\n", argv[0]);
 }
 
 #ifndef READ_ONLY
 void do_dirty_filesys(int argc EXT2FS_ATTR((unused)),
-                     char **argv EXT2FS_ATTR((unused)))
+                     ss_argv_t argv EXT2FS_ATTR((unused)),
+                     int sci_idx EXT2FS_ATTR((unused)),
+                     void *infop EXT2FS_ATTR((unused)))
 {
        if (check_fs_open(argv[0]))
                return;
@@ -552,11 +566,13 @@ static void finish_range(struct list_blocks_struct *lb)
                fprintf(lb->f, ", ");
        if (lb->first_block == lb->last_block)
                fprintf(lb->f, "(%lld):%llu",
-                       (long long)lb->first_bcnt, lb->first_block);
+                       (long long)lb->first_bcnt,
+                       (unsigned long long) lb->first_block);
        else
                fprintf(lb->f, "(%lld-%lld):%llu-%llu",
                        (long long)lb->first_bcnt, (long long)lb->last_bcnt,
-                       lb->first_block, lb->last_block);
+                       (unsigned long long) lb->first_block,
+                       (unsigned long long) lb->last_block);
        lb->first_block = 0;
 }
 
@@ -706,18 +722,18 @@ static void dump_extents(FILE *f, const char *prefix, ext2_ino_t ino,
                                        info.curr_level, info.max_depth,
                                        info.curr_entry, info.num_entries,
                                        logical_width,
-                                       extent.e_lblk,
+                                       (unsigned long long) extent.e_lblk,
                                        logical_width,
-                                       extent.e_lblk + (extent.e_len - 1),
+                                       (unsigned long long) extent.e_lblk + (extent.e_len - 1),
                                        physical_width,
-                                       extent.e_pblk,
+                                       (unsigned long long) extent.e_pblk,
                                        physical_width+3, "", extent.e_len);
                                continue;
                        }
 
-                       fprintf(f, "%s(ETB%d):%lld",
+                       fprintf(f, "%s(ETB%d):%llu",
                                printed ? ", " : "", info.curr_level,
-                               extent.e_pblk);
+                               (unsigned long long) extent.e_pblk);
                        printed = 1;
                        continue;
                }
@@ -728,13 +744,13 @@ static void dump_extents(FILE *f, const char *prefix, ext2_ino_t ino,
                                info.curr_level, info.max_depth,
                                info.curr_entry, info.num_entries,
                                logical_width,
-                               extent.e_lblk,
+                               (unsigned long long) extent.e_lblk,
                                logical_width,
-                               extent.e_lblk + (extent.e_len - 1),
+                               (unsigned long long) extent.e_lblk + (extent.e_len - 1),
                                physical_width,
-                               extent.e_pblk,
+                               (unsigned long long) extent.e_pblk,
                                physical_width,
-                               extent.e_pblk + (extent.e_len - 1),
+                               (unsigned long long) extent.e_pblk + (extent.e_len - 1),
                                extent.e_len,
                                extent.e_flags & EXT2_EXTENT_FLAGS_UNINIT ?
                                        "Uninit" : "");
@@ -747,20 +763,20 @@ static void dump_extents(FILE *f, const char *prefix, ext2_ino_t ino,
                        fprintf(f,
                                "%s(%lld%s):%lld",
                                printed ? ", " : "",
-                               extent.e_lblk,
+                               (unsigned long long) extent.e_lblk,
                                extent.e_flags & EXT2_EXTENT_FLAGS_UNINIT ?
                                "[u]" : "",
-                               extent.e_pblk);
+                               (unsigned long long) extent.e_pblk);
                else
                        fprintf(f,
                                "%s(%lld-%lld%s):%lld-%lld",
                                printed ? ", " : "",
-                               extent.e_lblk,
-                               extent.e_lblk + (extent.e_len - 1),
+                               (unsigned long long) extent.e_lblk,
+                               (unsigned long long) extent.e_lblk + (extent.e_len - 1),
                                extent.e_flags & EXT2_EXTENT_FLAGS_UNINIT ?
                                        "[u]" : "",
-                               extent.e_pblk,
-                               extent.e_pblk + (extent.e_len - 1));
+                               (unsigned long long) extent.e_pblk,
+                               (unsigned long long) extent.e_pblk + (extent.e_len - 1));
                printed = 1;
        }
        if (printed)
@@ -778,41 +794,31 @@ static void dump_inline_data(FILE *out, const char *prefix, ext2_ino_t inode_num
                fprintf(out, "%sSize of inline data: %zu\n", prefix, size);
 }
 
-static void dump_fast_link(FILE *out, ext2_ino_t inode_num,
-                          struct ext2_inode *inode, const char *prefix)
+static void dump_inline_symlink(FILE *out, ext2_ino_t inode_num,
+                               struct ext2_inode *inode, const char *prefix)
 {
-       errcode_t retval = 0;
-       char *buf;
+       errcode_t retval;
+       char *buf = NULL;
        size_t size;
 
-       if (inode->i_flags & EXT4_INLINE_DATA_FL) {
-               retval = ext2fs_inline_data_size(current_fs, inode_num, &size);
-               if (retval)
-                       goto out;
-
-               retval = ext2fs_get_memzero(size + 1, &buf);
-               if (retval)
-                       goto out;
+       retval = ext2fs_inline_data_size(current_fs, inode_num, &size);
+       if (retval)
+               goto out;
 
-               retval = ext2fs_inline_data_get(current_fs, inode_num,
-                                               inode, buf, &size);
-               if (retval)
-                       goto out;
-               fprintf(out, "%sFast link dest: \"%.*s\"\n", prefix,
-                       (int)size, buf);
+       retval = ext2fs_get_memzero(size + 1, &buf);
+       if (retval)
+               goto out;
 
-               retval = ext2fs_free_mem(&buf);
-               if (retval)
-                       goto out;
-       } else {
-               size_t sz = EXT2_I_SIZE(inode);
+       retval = ext2fs_inline_data_get(current_fs, inode_num,
+                                       inode, buf, &size);
+       if (retval)
+               goto out;
 
-               if (sz > sizeof(inode->i_block))
-                       sz = sizeof(inode->i_block);
-               fprintf(out, "%sFast link dest: \"%.*s\"\n", prefix, (int) sz,
-                       (char *)inode->i_block);
-       }
+       fprintf(out, "%sFast link dest: \"%.*s\"\n", prefix,
+               (int)size, buf);
 out:
+       if (buf)
+               ext2fs_free_mem(&buf);
        if (retval)
                com_err(__func__, retval, "while dumping link destination");
 }
@@ -825,11 +831,13 @@ void internal_dump_inode(FILE *out, const char *prefix,
        char frag, fsize;
        int os = current_fs->super->s_creator_os;
        struct ext2_inode_large *large_inode;
-       int is_large_inode = 0;
+       size_t inode_size;
 
-       if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
-               is_large_inode = 1;
        large_inode = (struct ext2_inode_large *) inode;
+       if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
+               inode_size = ext2fs_inode_actual_size(large_inode);
+       else
+               inode_size = EXT2_GOOD_OLD_INODE_SIZE;
 
        if (LINUX_S_ISDIR(inode->i_mode)) i_type = "directory";
        else if (LINUX_S_ISREG(inode->i_mode)) i_type = "regular";
@@ -840,9 +848,9 @@ void internal_dump_inode(FILE *out, const char *prefix,
        else if (LINUX_S_ISSOCK(inode->i_mode)) i_type = "socket";
        else i_type = "bad type";
        fprintf(out, "%sInode: %u   Type: %s    ", prefix, inode_num, i_type);
-       fprintf(out, "%sMode:  %04o   Flags: 0x%x\n",
-               prefix, inode->i_mode & 0777, inode->i_flags);
-       if (is_large_inode && large_inode->i_extra_isize >= 24) {
+       fprintf(out, "%sMode:  0%03o   Flags: 0x%x\n",
+               prefix, inode->i_mode & 07777, inode->i_flags);
+       if (ext2fs_inode_includes(inode_size, i_version_hi)) {
                fprintf(out, "%sGeneration: %u    Version: 0x%08x:%08x\n",
                        prefix, inode->i_generation, large_inode->i_version_hi,
                        inode->osd1.linux1.l_i_version);
@@ -852,16 +860,16 @@ void internal_dump_inode(FILE *out, const char *prefix,
        }
        fprintf(out, "%sUser: %5d   Group: %5d",
                prefix, inode_uid(*inode), inode_gid(*inode));
-       if (is_large_inode && large_inode->i_extra_isize >= 32)
+       if (ext2fs_inode_includes(inode_size, i_projid))
                fprintf(out, "   Project: %5d", large_inode->i_projid);
        fputs("   Size: ", out);
-       if (LINUX_S_ISREG(inode->i_mode))
-               fprintf(out, "%llu\n", EXT2_I_SIZE(inode));
+       if (LINUX_S_ISREG(inode->i_mode) || LINUX_S_ISDIR(inode->i_mode))
+               fprintf(out, "%llu\n", (unsigned long long) EXT2_I_SIZE(inode));
        else
-               fprintf(out, "%d\n", inode->i_size);
+               fprintf(out, "%u\n", inode->i_size);
        if (os == EXT2_OS_HURD)
                fprintf(out,
-                       "%sFile ACL: %d Translator: %d\n",
+                       "%sFile ACL: %u Translator: %u\n",
                        prefix,
                        inode->i_file_acl,
                        inode->osd1.hurd1.h_i_translator);
@@ -871,13 +879,13 @@ void internal_dump_inode(FILE *out, const char *prefix,
                        inode->i_file_acl | ((long long)
                                (inode->osd2.linux2.l_i_file_acl_high) << 32));
        if (os != EXT2_OS_HURD)
-               fprintf(out, "%sLinks: %d   Blockcount: %llu\n",
+               fprintf(out, "%sLinks: %u   Blockcount: %llu\n",
                        prefix, inode->i_links_count,
                        (((unsigned long long)
                          inode->osd2.linux2.l_i_blocks_hi << 32)) +
                        inode->i_blocks);
        else
-               fprintf(out, "%sLinks: %d   Blockcount: %u\n",
+               fprintf(out, "%sLinks: %u   Blockcount: %u\n",
                        prefix, inode->i_links_count, inode->i_blocks);
        switch (os) {
            case EXT2_OS_HURD:
@@ -887,41 +895,53 @@ void internal_dump_inode(FILE *out, const char *prefix,
            default:
                frag = fsize = 0;
        }
-       fprintf(out, "%sFragment:  Address: %d    Number: %d    Size: %d\n",
+       fprintf(out, "%sFragment:  Address: %u    Number: %u    Size: %u\n",
                prefix, inode->i_faddr, frag, fsize);
-       if (is_large_inode && large_inode->i_extra_isize >= 24) {
+       if (ext2fs_inode_includes(inode_size, i_ctime_extra))
                fprintf(out, "%s ctime: 0x%08x:%08x -- %s", prefix,
                        inode->i_ctime, large_inode->i_ctime_extra,
-                       inode_time_to_string(inode->i_ctime,
-                                            large_inode->i_ctime_extra));
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_ctime)));
+       else
+               fprintf(out, "%sctime: 0x%08x -- %s", prefix, inode->i_ctime,
+                       time_to_string((__s32) inode->i_ctime));
+       if (ext2fs_inode_includes(inode_size, i_atime_extra))
                fprintf(out, "%s atime: 0x%08x:%08x -- %s", prefix,
                        inode->i_atime, large_inode->i_atime_extra,
-                       inode_time_to_string(inode->i_atime,
-                                            large_inode->i_atime_extra));
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_atime)));
+       else
+               fprintf(out, "%satime: 0x%08x -- %s", prefix, inode->i_atime,
+                       time_to_string((__s32) inode->i_atime));
+       if (ext2fs_inode_includes(inode_size, i_mtime_extra))
                fprintf(out, "%s mtime: 0x%08x:%08x -- %s", prefix,
                        inode->i_mtime, large_inode->i_mtime_extra,
-                       inode_time_to_string(inode->i_mtime,
-                                            large_inode->i_mtime_extra));
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_mtime)));
+       else
+               fprintf(out, "%smtime: 0x%08x -- %s", prefix, inode->i_mtime,
+                       time_to_string((__s32) inode->i_mtime));
+       if (ext2fs_inode_includes(inode_size, i_crtime_extra))
                fprintf(out, "%scrtime: 0x%08x:%08x -- %s", prefix,
                        large_inode->i_crtime, large_inode->i_crtime_extra,
-                       inode_time_to_string(large_inode->i_crtime,
-                                            large_inode->i_crtime_extra));
-               if (inode->i_dtime)
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_crtime)));
+       if (inode->i_dtime) {
+               if (ext2fs_inode_includes(inode_size, i_ctime_extra)) {
+                       time_t tm;
+
+                       /* dtime doesn't have its own i_dtime_extra field, so
+                        * approximate this with i_ctime_extra instead. */
+                       tm = __decode_extra_sec(inode->i_dtime,
+                                               large_inode->i_ctime_extra);
                        fprintf(out, "%s dtime: 0x%08x:(%08x) -- %s", prefix,
-                               large_inode->i_dtime, large_inode->i_ctime_extra,
-                               inode_time_to_string(inode->i_dtime,
-                                                    large_inode->i_ctime_extra));
-       } else {
-               fprintf(out, "%sctime: 0x%08x -- %s", prefix, inode->i_ctime,
-                       time_to_string((__s32) inode->i_ctime));
-               fprintf(out, "%satime: 0x%08x -- %s", prefix, inode->i_atime,
-                       time_to_string((__s32) inode->i_atime));
-               fprintf(out, "%smtime: 0x%08x -- %s", prefix, inode->i_mtime,
-                       time_to_string((__s32) inode->i_mtime));
-               if (inode->i_dtime)
+                               inode->i_dtime, large_inode->i_ctime_extra,
+                               time_to_string(tm));
+               } else {
                        fprintf(out, "%sdtime: 0x%08x -- %s", prefix,
                                inode->i_dtime,
                                time_to_string((__s32) inode->i_dtime));
+               }
        }
        if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
                internal_dump_inode_extra(out, prefix, inode_num,
@@ -929,18 +949,17 @@ void internal_dump_inode(FILE *out, const char *prefix,
        dump_inode_attributes(out, inode_num);
        if (ext2fs_has_feature_metadata_csum(current_fs->super)) {
                __u32 crc = inode->i_checksum_lo;
-               if (is_large_inode &&
-                   large_inode->i_extra_isize >=
-                               (offsetof(struct ext2_inode_large,
-                                         i_checksum_hi) -
-                                EXT2_GOOD_OLD_INODE_SIZE))
+               if (ext2fs_inode_includes(inode_size, i_checksum_hi))
                        crc |= ((__u32)large_inode->i_checksum_hi) << 16;
                fprintf(out, "Inode checksum: 0x%08x\n", crc);
        }
 
-       if (LINUX_S_ISLNK(inode->i_mode) &&
-           ext2fs_inode_data_blocks(current_fs, inode) == 0)
-               dump_fast_link(out, inode_num, inode, prefix);
+       if (LINUX_S_ISLNK(inode->i_mode) && ext2fs_is_fast_symlink(inode))
+               fprintf(out, "%sFast link dest: \"%.*s\"\n", prefix,
+                       (int)EXT2_I_SIZE(inode), (char *)inode->i_block);
+       else if (LINUX_S_ISLNK(inode->i_mode) &&
+                  (inode->i_flags & EXT4_INLINE_DATA_FL))
+               dump_inline_symlink(out, inode_num, inode, prefix);
        else if (LINUX_S_ISBLK(inode->i_mode) || LINUX_S_ISCHR(inode->i_mode)) {
                int major, minor;
                const char *devnote;
@@ -977,7 +996,8 @@ static void dump_inode(ext2_ino_t inode_num, struct ext2_inode *inode)
        close_pager(out);
 }
 
-void do_stat(int argc, char *argv[])
+void do_stat(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+            void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      inode;
        struct ext2_inode * inode_buf;
@@ -997,8 +1017,8 @@ void do_stat(int argc, char *argv[])
                return;
        }
 
-       if (debugfs_read_inode_full(inode, inode_buf, argv[0],
-                                       EXT2_INODE_SIZE(current_fs->super))) {
+       if (debugfs_read_inode2(inode, inode_buf, argv[0],
+                               EXT2_INODE_SIZE(current_fs->super), 0)) {
                free(inode_buf);
                return;
        }
@@ -1008,7 +1028,8 @@ void do_stat(int argc, char *argv[])
        return;
 }
 
-void do_dump_extents(int argc, char **argv)
+void do_dump_extents(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                    void *infop EXT2FS_ATTR((unused)))
 {
        struct ext2_inode inode;
        ext2_ino_t      ino;
@@ -1075,11 +1096,12 @@ static int print_blocks_proc(ext2_filsys fs EXT2FS_ATTR((unused)),
                             int ref_offset EXT2FS_ATTR((unused)),
                             void *private EXT2FS_ATTR((unused)))
 {
-       printf("%llu ", *blocknr);
+       printf("%llu ", (unsigned long long) *blocknr);
        return 0;
 }
 
-void do_blocks(int argc, char *argv[])
+void do_blocks(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+              void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      inode;
 
@@ -1096,7 +1118,8 @@ void do_blocks(int argc, char *argv[])
        return;
 }
 
-void do_chroot(int argc, char *argv[])
+void do_chroot(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+              void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
        int retval;
@@ -1113,7 +1136,8 @@ void do_chroot(int argc, char *argv[])
 }
 
 #ifndef READ_ONLY
-void do_clri(int argc, char *argv[])
+void do_clri(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+            void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
        struct ext2_inode inode_buf;
@@ -1128,7 +1152,8 @@ void do_clri(int argc, char *argv[])
                return;
 }
 
-void do_freei(int argc, char *argv[])
+void do_freei(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        unsigned int    len = 1;
        int             err = 0;
@@ -1158,7 +1183,8 @@ void do_freei(int argc, char *argv[])
        ext2fs_mark_ib_dirty(current_fs);
 }
 
-void do_seti(int argc, char *argv[])
+void do_seti(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+            void *infop EXT2FS_ATTR((unused)))
 {
        unsigned int    len = 1;
        int             err = 0;
@@ -1189,7 +1215,8 @@ void do_seti(int argc, char *argv[])
 }
 #endif /* READ_ONLY */
 
-void do_testi(int argc, char *argv[])
+void do_testi(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
 
@@ -1203,7 +1230,8 @@ void do_testi(int argc, char *argv[])
 }
 
 #ifndef READ_ONLY
-void do_freeb(int argc, char *argv[])
+void do_freeb(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        blk64_t block;
        blk64_t count = 1;
@@ -1215,14 +1243,15 @@ void do_freeb(int argc, char *argv[])
        while (count-- > 0) {
                if (!ext2fs_test_block_bitmap2(current_fs->block_map,block))
                        com_err(argv[0], 0, "Warning: block %llu already clear",
-                               block);
+                               (unsigned long long) block);
                ext2fs_unmark_block_bitmap2(current_fs->block_map,block);
                block++;
        }
        ext2fs_mark_bb_dirty(current_fs);
 }
 
-void do_setb(int argc, char *argv[])
+void do_setb(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+            void *infop EXT2FS_ATTR((unused)))
 {
        blk64_t block;
        blk64_t count = 1;
@@ -1234,7 +1263,7 @@ void do_setb(int argc, char *argv[])
        while (count-- > 0) {
                if (ext2fs_test_block_bitmap2(current_fs->block_map,block))
                        com_err(argv[0], 0, "Warning: block %llu already set",
-                               block);
+                               (unsigned long long) block);
                ext2fs_mark_block_bitmap2(current_fs->block_map,block);
                block++;
        }
@@ -1242,7 +1271,8 @@ void do_setb(int argc, char *argv[])
 }
 #endif /* READ_ONLY */
 
-void do_testb(int argc, char *argv[])
+void do_testb(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        blk64_t block;
        blk64_t count = 1;
@@ -1251,9 +1281,11 @@ void do_testb(int argc, char *argv[])
                return;
        while (count-- > 0) {
                if (ext2fs_test_block_bitmap2(current_fs->block_map,block))
-                       printf("Block %llu marked in use\n", block);
+                       printf("Block %llu marked in use\n",
+                              (unsigned long long) block);
                else
-                       printf("Block %llu not in use\n", block);
+                       printf("Block %llu not in use\n",
+                              (unsigned long long) block);
                block++;
        }
 }
@@ -1326,7 +1358,8 @@ static void modify_u32(char *com, const char *prompt,
 }
 
 
-void do_modify_inode(int argc, char *argv[])
+void do_modify_inode(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                    void *infop EXT2FS_ATTR((unused)))
 {
        struct ext2_inode inode;
        ext2_ino_t      inode_num;
@@ -1389,7 +1422,7 @@ void do_modify_inode(int argc, char *argv[])
                modify_u8(argv[0], "Fragment size", decimal_format, fsize);
 
        for (i=0;  i < EXT2_NDIR_BLOCKS; i++) {
-               sprintf(buf, "Direct Block #%d", i);
+               sprintf(buf, "Direct Block #%u", i);
                modify_u32(argv[0], buf, decimal_format, &inode.i_block[i]);
        }
        modify_u32(argv[0], "Indirect Block", decimal_format,
@@ -1403,7 +1436,9 @@ void do_modify_inode(int argc, char *argv[])
 }
 #endif /* READ_ONLY */
 
-void do_change_working_dir(int argc, char *argv[])
+void do_change_working_dir(int argc, ss_argv_t argv,
+                          int sci_idx EXT2FS_ATTR((unused)),
+                          void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      inode;
        int             retval;
@@ -1420,7 +1455,9 @@ void do_change_working_dir(int argc, char *argv[])
        return;
 }
 
-void do_print_working_directory(int argc, char *argv[])
+void do_print_working_directory(int argc, ss_argv_t argv,
+                               int sci_idx EXT2FS_ATTR((unused)),
+                               void *infop EXT2FS_ATTR((unused)))
 {
        int     retval;
        char    *pathname = NULL;
@@ -1509,7 +1546,8 @@ static void make_link(char *sourcename, char *destname)
 }
 
 
-void do_link(int argc, char *argv[])
+void do_link(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+            void *infop EXT2FS_ATTR((unused)))
 {
        if (common_args_process(argc, argv, 3, 3, "link",
                                "<source file> <dest_name>", CHECK_FS_RW))
@@ -1531,7 +1569,8 @@ static int mark_blocks_proc(ext2_filsys fs, blk64_t *blocknr,
        return 0;
 }
 
-void do_undel(int argc, char *argv[])
+void do_undel(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
        struct ext2_inode inode;
@@ -1594,7 +1633,8 @@ static void unlink_file_by_name(char *filename)
        return;
 }
 
-void do_unlink(int argc, char *argv[])
+void do_unlink(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+              void *infop EXT2FS_ATTR((unused)))
 {
        if (common_args_process(argc, argv, 2, 2, "link",
                                "<pathname>", CHECK_FS_RW))
@@ -1603,7 +1643,8 @@ void do_unlink(int argc, char *argv[])
        unlink_file_by_name(argv[1]);
 }
 
-void do_copy_inode(int argc, char *argv[])
+void do_copy_inode(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                  void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      src_ino, dest_ino;
        unsigned char   buf[4096];
@@ -1620,18 +1661,20 @@ void do_copy_inode(int argc, char *argv[])
        if (!dest_ino)
                return;
 
-       if (debugfs_read_inode_full(src_ino, (struct ext2_inode *) buf,
-                                   argv[0], sizeof(buf)))
+       if (debugfs_read_inode2(src_ino, (struct ext2_inode *) buf,
+                               argv[0], sizeof(buf), 0))
                return;
 
-       if (debugfs_write_inode_full(dest_ino, (struct ext2_inode *) buf,
-                                    argv[0], sizeof(buf)))
+       if (debugfs_write_inode2(dest_ino, (struct ext2_inode *) buf,
+                                argv[0], sizeof(buf), 0))
                return;
 }
 
 #endif /* READ_ONLY */
 
-void do_find_free_block(int argc, char *argv[])
+void do_find_free_block(int argc, ss_argv_t argv,
+                       int sci_idx EXT2FS_ATTR((unused)),
+                       void *infop EXT2FS_ATTR((unused)))
 {
        blk64_t free_blk, goal, first_free = 0;
        int             count;
@@ -1678,12 +1721,14 @@ void do_find_free_block(int argc, char *argv[])
                        com_err("ext2fs_new_block", retval, 0);
                        return;
                } else
-                       printf("%llu ", free_blk);
+                       printf("%llu ", (unsigned long long) free_blk);
        }
        printf("\n");
 }
 
-void do_find_free_inode(int argc, char *argv[])
+void do_find_free_inode(int argc, ss_argv_t argv,
+                       int sci_idx EXT2FS_ATTR((unused)),
+                       void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      free_inode, dir;
        int             mode;
@@ -1691,7 +1736,7 @@ void do_find_free_inode(int argc, char *argv[])
        char            *tmp;
 
        if (argc > 3 || (argc>1 && *argv[1] == '?')) {
-               com_err(argv[0], 0, "Usage: find_free_inode [dir] [mode]");
+               com_err(argv[0], 0, "Usage: find_free_inode [dir [mode]]");
                return;
        }
        if (check_fs_open(argv[0]))
@@ -1723,7 +1768,8 @@ void do_find_free_inode(int argc, char *argv[])
 }
 
 #ifndef READ_ONLY
-void do_write(int argc, char *argv[])
+void do_write(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        errcode_t       retval;
 
@@ -1736,7 +1782,8 @@ void do_write(int argc, char *argv[])
                com_err(argv[0], retval, 0);
 }
 
-void do_mknod(int argc, char *argv[])
+void do_mknod(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        unsigned long   major, minor;
        errcode_t       retval;
@@ -1770,9 +1817,12 @@ void do_mknod(int argc, char *argv[])
        }
 
        if (nr == 5) {
-               major = strtoul(argv[3], argv+3, 0);
-               minor = strtoul(argv[4], argv+4, 0);
-               if (major > 65535 || minor > 65535 || argv[3][0] || argv[4][0])
+               char *end1 = NULL, *end2 = NULL;
+
+               major = strtoul(argv[3], &end1, 0);
+               minor = strtoul(argv[4], &end2, 0);
+               if (major > 65535 || minor > 65535 ||
+                   (end1 && *end1) || (end2 && *end2))
                        nr = 0;
        }
 
@@ -1780,12 +1830,14 @@ void do_mknod(int argc, char *argv[])
                goto usage;
 
        st.st_rdev = makedev(major, minor);
-       retval = do_mknod_internal(current_fs, cwd, argv[1], &st);
+       retval = do_mknod_internal(current_fs, cwd, argv[1],
+                                  st.st_mode, st.st_rdev);
        if (retval)
                com_err(argv[0], retval, 0);
 }
 
-void do_mkdir(int argc, char *argv[])
+void do_mkdir(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        errcode_t retval;
 
@@ -1803,11 +1855,17 @@ static int release_blocks_proc(ext2_filsys fs, blk64_t *blocknr,
                               e2_blkcnt_t blockcnt EXT2FS_ATTR((unused)),
                               blk64_t ref_block EXT2FS_ATTR((unused)),
                               int ref_offset EXT2FS_ATTR((unused)),
-                              void *private EXT2FS_ATTR((unused)))
+                              void *private)
 {
-       blk64_t block;
+       blk64_t block = *blocknr;
+       blk64_t *last_cluster = (blk64_t *)private;
+       blk64_t cluster = EXT2FS_B2C(fs, block);
+
+       if (cluster == *last_cluster)
+               return 0;
+
+       *last_cluster = cluster;
 
-       block = *blocknr;
        ext2fs_block_alloc_stats2(fs, block, -1);
        return 0;
 }
@@ -1818,12 +1876,13 @@ static void kill_file_by_inode(ext2_ino_t inode)
 
        if (debugfs_read_inode(inode, &inode_buf, 0))
                return;
-       inode_buf.i_dtime = current_fs->now ? current_fs->now : time(0);
+       ext2fs_set_dtime(current_fs,  &inode_buf);
        if (debugfs_write_inode(inode, &inode_buf, 0))
                return;
        if (ext2fs_inode_has_valid_blocks2(current_fs, &inode_buf)) {
+               blk64_t last_cluster = 0;
                ext2fs_block_iterate3(current_fs, inode, BLOCK_FLAG_READ_ONLY,
-                                     NULL, release_blocks_proc, NULL);
+                                     NULL, release_blocks_proc, &last_cluster);
        }
        printf("\n");
        ext2fs_inode_alloc_stats2(current_fs, inode, -1,
@@ -1831,7 +1890,8 @@ static void kill_file_by_inode(ext2_ino_t inode)
 }
 
 
-void do_kill_file(int argc, char *argv[])
+void do_kill_file(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                 void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode_num;
 
@@ -1841,7 +1901,8 @@ void do_kill_file(int argc, char *argv[])
        kill_file_by_inode(inode_num);
 }
 
-void do_rm(int argc, char *argv[])
+void do_rm(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+          void *infop EXT2FS_ATTR((unused)))
 {
        int retval;
        ext2_ino_t inode_num;
@@ -1902,7 +1963,8 @@ static int rmdir_proc(ext2_ino_t dir EXT2FS_ATTR((unused)),
        return 0;
 }
 
-void do_rmdir(int argc, char *argv[])
+void do_rmdir(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        int retval;
        ext2_ino_t inode_num;
@@ -1960,7 +2022,9 @@ void do_rmdir(int argc, char *argv[])
 #endif /* READ_ONLY */
 
 void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
-                           char *argv[] EXT2FS_ATTR((unused)))
+                           ss_argv_t argv EXT2FS_ATTR((unused)),
+                           int sci_idx EXT2FS_ATTR((unused)),
+                           void *infop EXT2FS_ATTR((unused)))
 {
        if (current_fs)
                printf("Open mode: read-%s\n",
@@ -1970,7 +2034,8 @@ void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
 }
 
 #ifndef READ_ONLY
-void do_expand_dir(int argc, char *argv[])
+void do_expand_dir(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                   void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
        int retval;
@@ -1984,7 +2049,8 @@ void do_expand_dir(int argc, char *argv[])
        return;
 }
 
-void do_features(int argc, char *argv[])
+void do_features(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                void *infop EXT2FS_ATTR((unused)))
 {
        int     i;
 
@@ -2005,7 +2071,8 @@ void do_features(int argc, char *argv[])
 }
 #endif /* READ_ONLY */
 
-void do_bmap(int argc, char *argv[])
+void do_bmap(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+            void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
        blk64_t         blk, pblk = 0;
@@ -2059,16 +2126,18 @@ void do_bmap(int argc, char *argv[])
                               &ret_flags, &pblk);
        if (errcode) {
                com_err(argv[0], errcode,
-                       "while mapping logical block %llu\n", blk);
+                       "while mapping logical block %llu\n",
+                       (unsigned long long) blk);
                return;
        }
-       printf("%llu", pblk);
+       printf("%llu", (unsigned long long) pblk);
        if (ret_flags & BMAP_RET_UNINIT)
                fputs(" (uninit)", stdout);
        fputc('\n', stdout);
 }
 
-void do_imap(int argc, char *argv[])
+void do_imap(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+            void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
        unsigned long   group, block, block_nr, offset;
@@ -2093,23 +2162,38 @@ void do_imap(int argc, char *argv[])
                block;
        offset &= (EXT2_BLOCK_SIZE(current_fs->super) - 1);
 
-       printf("Inode %d is part of block group %lu\n"
+       printf("Inode %u is part of block group %lu\n"
               "\tlocated at block %lu, offset 0x%04lx\n", ino, group,
               block_nr, offset);
 
 }
 
-void do_idump(int argc, char *argv[])
+void do_idump(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
+       struct ext2_inode_large *inode;
        ext2_ino_t      ino;
        unsigned char   *buf;
        errcode_t       err;
-       int             isize;
+       unsigned int    isize, size, offset = 0;
+       int             c, mode = 0;
 
-       if (common_args_process(argc, argv, 2, 2, argv[0],
-                               "<file>", 0))
+       reset_getopt();
+       while ((c = getopt (argc, argv, "bex")) != EOF) {
+               if (mode || c == '?') {
+                       com_err(argv[0], 0,
+                               "Usage: inode_dump [-b]|[-e] <file>");
+                       return;
+               }
+               mode = c;
+       }
+       if (optind != argc-1)
                return;
-       ino = string_to_inode(argv[1]);
+
+       if (check_fs_open(argv[0]))
+               return;
+
+       ino = string_to_inode(argv[optind]);
        if (!ino)
                return;
 
@@ -2123,17 +2207,41 @@ void do_idump(int argc, char *argv[])
        err = ext2fs_read_inode_full(current_fs, ino,
                                     (struct ext2_inode *)buf, isize);
        if (err) {
-               com_err(argv[0], err, "while reading inode %d", ino);
+               com_err(argv[0], err, "while reading inode %u", ino);
                goto err;
        }
 
-       do_byte_hexdump(stdout, buf, isize);
+       inode = (struct ext2_inode_large *) buf;
+       size = isize;
+       switch (mode) {
+       case 'b':
+               offset = ((char *) (&inode->i_block)) - ((char *) buf);
+               size = sizeof(inode->i_block);
+               break;
+       case 'x':
+       case 'e':
+               if (size <= EXT2_GOOD_OLD_INODE_SIZE) {
+                       com_err(argv[0], 0, "No extra space in inode");
+                       goto err;
+               }
+               offset = EXT2_GOOD_OLD_INODE_SIZE + inode->i_extra_isize;
+               if (offset > size)
+                       goto err;
+               size -= offset;
+               break;
+       }
+       if (mode == 'x')
+               raw_inode_xattr_dump(stdout, buf + offset, size);
+       else
+               do_byte_hexdump(stdout, buf + offset, size);
 err:
        ext2fs_free_mem(&buf);
 }
 
 #ifndef READ_ONLY
-void do_set_current_time(int argc, char *argv[])
+void do_set_current_time(int argc, ss_argv_t argv,
+                        int sci_idx EXT2FS_ATTR((unused)),
+                        void *infop EXT2FS_ATTR((unused)))
 {
        __s64 now;
 
@@ -2192,15 +2300,17 @@ static int find_supp_feature(__u32 *supp, int feature_type, char *name)
        return 0;
 }
 
-void do_supported_features(int argc, char *argv[])
+void do_supported_features(int argc, ss_argv_t argv,
+                          int sci_idx EXT2FS_ATTR((unused)),
+                          void *infop EXT2FS_ATTR((unused)))
 {
         int    ret;
        __u32   supp[3] = { EXT2_LIB_FEATURE_COMPAT_SUPP,
                            EXT2_LIB_FEATURE_INCOMPAT_SUPP,
                            EXT2_LIB_FEATURE_RO_COMPAT_SUPP };
-       __u32   jrnl_supp[3] = { JFS_KNOWN_COMPAT_FEATURES,
-                                JFS_KNOWN_INCOMPAT_FEATURES,
-                                JFS_KNOWN_ROCOMPAT_FEATURES };
+       __u32   jrnl_supp[3] = { JBD2_KNOWN_COMPAT_FEATURES,
+                                JBD2_KNOWN_INCOMPAT_FEATURES,
+                                JBD2_KNOWN_ROCOMPAT_FEATURES };
 
        if (argc > 1) {
                ret = find_supp_feature(supp, E2P_FS_FEATURE, argv[1]);
@@ -2220,7 +2330,8 @@ void do_supported_features(int argc, char *argv[])
 }
 
 #ifndef READ_ONLY
-void do_punch(int argc, char *argv[])
+void do_punch(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+             void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
        blk64_t         start, end;
@@ -2255,7 +2366,8 @@ void do_punch(int argc, char *argv[])
        }
 }
 
-void do_fallocate(int argc, char *argv[])
+void do_fallocate(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+                 void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
        blk64_t         start, end;
@@ -2290,9 +2402,9 @@ void do_fallocate(int argc, char *argv[])
                return;
        }
 }
-#endif /* READ_ONLY */
 
-void do_symlink(int argc, char *argv[])
+void do_symlink(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
+               void *infop EXT2FS_ATTR((unused)))
 {
        errcode_t       retval;
 
@@ -2305,9 +2417,12 @@ void do_symlink(int argc, char *argv[])
                com_err(argv[0], retval, 0);
 
 }
+#endif /* READ_ONLY */
 
 #if CONFIG_MMP
-void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
+void do_dump_mmp(int argc EXT2FS_ATTR((unused)), ss_argv_t argv,
+                int sci_idx EXT2FS_ATTR((unused)),
+                void *infop EXT2FS_ATTR((unused)))
 {
        struct mmp_struct *mmp_s;
        unsigned long long mmp_block;
@@ -2349,27 +2464,31 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
        retval = ext2fs_mmp_read(current_fs, mmp_block, current_fs->mmp_buf);
        if (retval) {
                com_err(argv[0], retval, "reading MMP block %llu.\n",
-                       mmp_block);
+                       (unsigned long long) mmp_block);
                return;
        }
 
        t = mmp_s->mmp_time;
-       fprintf(stdout, "block_number: %llu\n", current_fs->super->s_mmp_block);
+       fprintf(stdout, "block_number: %llu\n",
+               (unsigned long long) current_fs->super->s_mmp_block);
        fprintf(stdout, "update_interval: %d\n",
                current_fs->super->s_mmp_update_interval);
        fprintf(stdout, "check_interval: %d\n", mmp_s->mmp_check_interval);
        fprintf(stdout, "sequence: %08x\n", mmp_s->mmp_seq);
-       fprintf(stdout, "time: %lld -- %s", mmp_s->mmp_time, ctime(&t));
-       fprintf(stdout, "node_name: %s\n", mmp_s->mmp_nodename);
-       fprintf(stdout, "device_name: %s\n", mmp_s->mmp_bdevname);
+       fprintf(stdout, "time: %llu -- %s",
+               (unsigned long long) mmp_s->mmp_time, ctime(&t));
+       fprintf(stdout, "node_name: %.*s\n",
+               EXT2_LEN_STR(mmp_s->mmp_nodename));
+       fprintf(stdout, "device_name: %.*s\n",
+               EXT2_LEN_STR(mmp_s->mmp_bdevname));
        fprintf(stdout, "magic: 0x%x\n", mmp_s->mmp_magic);
        fprintf(stdout, "checksum: 0x%08x\n", mmp_s->mmp_checksum);
-       fprintf(stdout, "MMP is unsupported, please recompile with "
-                       "--enable-mmp\n");
 }
 #else
 void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
-                char *argv[] EXT2FS_ATTR((unused)))
+                ss_argv_t argv EXT2FS_ATTR((unused)),
+                int sci_idx EXT2FS_ATTR((unused)),
+                void *infop EXT2FS_ATTR((unused)))
 {
        fprintf(stdout, "MMP is unsupported, please recompile with "
                        "--enable-mmp\n");
@@ -2400,6 +2519,10 @@ static int source_file(const char *cmd_file, int ss_idx)
        while (!feof(f)) {
                if (fgets(buf, sizeof(buf), f) == NULL)
                        break;
+               if (buf[0] == '#') {
+                       printf("%s", buf);
+                       continue;
+               }
                cp = strchr(buf, '\n');
                if (cp)
                        *cp = 0;
@@ -2423,13 +2546,14 @@ int main(int argc, char **argv)
        int             retval;
        const char      *usage = 
                "Usage: %s [-b blocksize] [-s superblock] [-f cmd_file] "
-               "[-R request] [-V] ["
+               "[-R request] [-d data_source_device] [-i] [-n] [-D] [-V] ["
 #ifndef READ_ONLY
                "[-w] [-z undo_file] "
 #endif
-               "[-c] device]";
+               "[-c]] [device]";
        int             c;
-       int             open_flags = EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS;
+       int             open_flags = EXT2_FLAG_SOFTSUPP_FEATURES |
+                               EXT2_FLAG_64BITS | EXT2_FLAG_THREADS;
        char            *request = 0;
        int             exit_status = 0;
        char            *cmd_file = 0;
@@ -2441,8 +2565,8 @@ int main(int argc, char **argv)
        const char      *opt_string = "nicR:f:b:s:Vd:D";
 #else
        const char      *opt_string = "niwcR:f:b:s:Vd:Dz:";
-       char            *undo_file = NULL;
 #endif
+       char            *undo_file = NULL;
 #ifdef CONFIG_JBD_DEBUG
        char            *jbd_debug;
 #endif
@@ -2514,9 +2638,11 @@ int main(int argc, char **argv)
                        fprintf(stderr, "\tUsing %s\n",
                                error_message(EXT2_ET_BASE));
                        exit(0);
+#ifndef READ_ONLY
                case 'z':
                        undo_file = optarg;
                        break;
+#endif
                default:
                        com_err(argv[0], 0, usage, debug_prog_name);
                        return 1;
@@ -2527,39 +2653,39 @@ int main(int argc, char **argv)
                                superblock, blocksize, catastrophic,
                                data_filename, undo_file);
 
-       sci_idx = ss_create_invocation(debug_prog_name, "0.0", (char *) NULL,
-                                      &debug_cmds, &retval);
+       ss_sci_idx = ss_create_invocation(debug_prog_name, "0.0", (char *) NULL,
+                                         &debug_cmds, &retval);
        if (retval) {
-               ss_perror(sci_idx, retval, "creating invocation");
+               ss_perror(ss_sci_idx, retval, "creating invocation");
                exit(1);
        }
-       ss_get_readline(sci_idx);
+       ss_get_readline(ss_sci_idx);
 
-       (void) ss_add_request_table (sci_idx, &ss_std_requests, 1, &retval);
+       (void) ss_add_request_table(ss_sci_idx, &ss_std_requests, 1, &retval);
        if (retval) {
-               ss_perror(sci_idx, retval, "adding standard requests");
+               ss_perror(ss_sci_idx, retval, "adding standard requests");
                exit (1);
        }
        if (extra_cmds)
-               ss_add_request_table (sci_idx, extra_cmds, 1, &retval);
+               ss_add_request_table(ss_sci_idx, extra_cmds, 1, &retval);
        if (retval) {
-               ss_perror(sci_idx, retval, "adding extra requests");
+               ss_perror(ss_sci_idx, retval, "adding extra requests");
                exit (1);
        }
        if (request) {
                retval = 0;
-               retval = ss_execute_line(sci_idx, request);
+               retval = ss_execute_line(ss_sci_idx, request);
                if (retval) {
-                       ss_perror(sci_idx, retval, request);
+                       ss_perror(ss_sci_idx, retval, request);
                        exit_status++;
                }
        } else if (cmd_file) {
-               exit_status = source_file(cmd_file, sci_idx);
+               exit_status = source_file(cmd_file, ss_sci_idx);
        } else {
-               ss_listen(sci_idx);
+               ss_listen(ss_sci_idx);
        }
 
-       ss_delete_invocation(sci_idx);
+       ss_delete_invocation(ss_sci_idx);
 
        if (current_fs)
                close_filesystem();