]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blobdiff - gdb/ChangeLog
Style field names in "print"
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
index ab208775b6cdc615040858337a9bd0cf7f7fc07a..ecdce315f7e02747bb7be6e569bd969f7637bea1 100644 (file)
@@ -1,3 +1,628 @@
+2020-02-22  Tom Tromey  <tom@tromey.com>
+
+       * valprint.c (generic_val_print_enum_1)
+       (val_print_type_code_flags): Style member names.
+       * rust-lang.c (val_print_struct, rust_print_enum)
+       (rust_print_struct_def, rust_internal_print_type): Style member
+       names.
+       * p-valprint.c (pascal_object_print_value_fields): Style member
+       names.  Only call fprintf_symbol_filtered for static members.
+       * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
+       * f-valprint.c (f_val_print): Style member names.
+       * f-typeprint.c (f_type_print_base): Style member names.
+       * cp-valprint.c (cp_print_value_fields): Style member names.  Only
+       call fprintf_symbol_filtered for static members.
+       (cp_print_class_member): Style member names.
+       * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
+       member names.
+       * ada-valprint.c (ada_print_scalar): Style enum names.
+       (ada_val_print_enum): Likewise.
+       * ada-typeprint.c (print_enum_type): Style enum names.
+
+2020-02-21  Tom Tromey  <tom@tromey.com>
+
+       * psympriv.h (struct partial_symtab): Update comment.
+
+2020-02-21  Tom Tromey  <tromey@adacore.com>
+
+       * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
+       type is CORE_ADDR.
+
+2020-02-21  Tom de Vries  <tdevries@suse.de>
+
+       PR gdb/25534
+       * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
+       if dependencies[i]->user != NULL.
+
+2020-02-21  Ali Tamur  <tamur@google.com>
+
+       * dwarf2/read.c (dwarf2_name): Add null check.
+
+2020-02-20  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
+       ">=", in binary search.
+       (dwarf2_find_containing_comp_unit): New overload.
+       (run_test): New self-test.
+       (_initialize_dwarf2_read): Register new test.
+
+2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
+
+       * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
+       * riscv-tdep.h: Likewise.
+       * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
+       rv32-only CSR.
+       * features/riscv/64bit-csr.xml: Regenerated.
+
+2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
+           Tom Tromey  <tom@tromey.com>
+
+       * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
+       of 'fputc_unfiltered'.
+       (putchar_unfiltered): Call 'fputc_unfiltered'.
+       (fputc_unfiltered): Call 'fputs_unfiltered'.
+
+2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * config.in: Regenerate.
+       * configure: Regenerate.
+       * configure.ac: Add --with-python-libdir option.
+       * main.c: Use WITH_PYTHON_LIBDIR.
+
+2020-02-19  Tom Tromey  <tom@tromey.com>
+
+       * symtab.c (general_symbol_info::compute_and_set_names): Use
+       obstack_strndup.  Simplify call to symbol_set_demangled_name.
+
+2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
+
+       * dwarf2/read.c (allocate_signatured_type_table,
+       allocate_dwo_unit_table, allocate_type_unit_groups_table,
+       allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
+       Remove objfile parameter, update all callers.
+
+2020-02-19  Doug Evans  <dje@google.com>
+
+       PR rust/25535
+       * rust-lang.c (rust_print_enum): Apply embedded_offset to
+       rust_enum_variant calculation.
+
+2020-02-19  Tom Tromey  <tromey@adacore.com>
+
+       * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
+
+2020-02-19  Tom Tromey  <tromey@adacore.com>
+
+       * ada-lang.c (cache_symbol): Use obstack_strdup.
+
+2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * configure: Regenerate.
+
+2020-02-19  Tom Tromey  <tromey@adacore.com>
+
+       * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
+       NULL check.
+
+2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
+
+       * NEWS: Mention RISC-V GNU/Linux GDBserver support.
+
+2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
+       if GDBSERVER is not defined.
+       (riscv_tdesc_cache): Likewise, also store const target_desc.
+       (STATIC_IN_GDB): Define.
+       (riscv_create_target_description): Update declaration with
+       STATIC_IN_GDB.
+       (riscv_lookup_target_description): New function, only define if
+       GDBSERVER is not defined.
+       * arch/riscv.h (riscv_create_target_description): Declare only
+       when GDBSERVER is defined.
+       (riscv_lookup_target_description): New declaration when GDBSERVER
+       is not defined.
+       * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
+       (riscv_linux_read_features): ...this, and return
+       riscv_gdbarch_features instead of target_desc.
+       * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
+       (riscv_linux_read_description): Rename to...
+       (riscv_linux_read_features): ...this.
+       * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
+       Update to use riscv_gdbarch_features and
+       riscv_lookup_target_description.
+       * riscv-tdep.c (riscv_find_default_target_description): Use
+       riscv_lookup_target_description instead of
+       riscv_create_target_description.
+
+2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
+
+       * valprint.c (generic_val_print_enum_1): When printing a flag
+       enum with value 0 and there is no enumerator with value 0, print
+       just "0" instead of "(unknown: 0x0)".
+
+2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
+
+       * valprint.c (generic_val_print_enum_1): Print unknown part of
+       flag enum in hex.
+
+2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
+
+       * dwarf2/read.c (update_enumeration_type_from_children): Allow
+       flag enums to contain duplicate enumerators.
+       * valprint.c (generic_val_print_enum_1): Update comment.
+
+2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
+
+       * dwarf2/read.c: Include "count-one-bits.h".
+       (update_enumeration_type_from_children): If an enumerator has
+       multiple bits set, don't treat the enumeration as a "flag enum".
+       * valprint.c (generic_val_print_enum_1): Assert that enumerators
+       of flag enums have 0 or 1 bit set.
+
+2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
+
+       * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
+       conversion.
+       * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
+       * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
+       * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
+       * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
+       * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
+
+2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
+
+       * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
+
+2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
+
+       * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
+       displaced_step_closure_up.
+       * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
+       (struct displaced_step_closure_up):
+       * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
+       * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
+       * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
+       Likewise.
+       * gdbarch.sh (displaced_step_copy_insn): Likewise.
+       * gdbarch.c, gdbarch.h: Re-generate.
+       * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
+       displaced_step_closure_up.
+       * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
+       * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
+       * infrun.h (displaced_step_closure_up): New type alias.
+       (struct displaced_step_inferior_state) <step_closure>: Change
+       type to displaced_step_closure_up.
+       * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
+       displaced_step_closure_up.
+       * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
+
+2020-02-14  Tom Tromey  <tom@tromey.com>
+
+       * minidebug.c (gnu_debug_key): New global.
+       (find_separate_debug_file_in_section): Use it.
+
+2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
+
+       * gdbarch.sh (displaced_step_copy_insn): Change return type to an
+       std::unique_ptr.
+       * gdbarch.c: Re-generate.
+       * gdbarch.h: Re-generate.
+       * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
+       change.
+       * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
+       type to std::unique_ptr.
+       * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
+       * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
+       * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
+       * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
+       * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
+       * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
+       * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
+       * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
+       * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
+
+2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
+
+       * infrun.c (get_displaced_step_closure_by_addr): Adjust to
+       std::unique_ptr.
+       (displaced_step_clear): Rename to...
+       (displaced_step_reset): ... this.  Just call displaced->reset ().
+       (displaced_step_clear_cleanup): Rename to...
+       (displaced_step_reset_cleanup): ... this.
+       (displaced_step_prepare_throw): Adjust to std::unique_ptr.
+       (displaced_step_fixup): Likewise.
+       (resume_1): Likewise.
+       (handle_inferior_event): Restore child's memory before calling
+       displaced_step_fixup on the parent.
+       * infrun.h (displaced_step_inferior_state) <reset>: Adjust
+       to std::unique_ptr.
+       <step_closure>: Change type to std::unique_ptr.
+
+2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
+
+       * arm-tdep.c: Include count-one-bits.h.
+       (cleanup_block_store_pc): Use count_one_bits.
+       (cleanup_block_load_pc): Use count_one_bits.
+       (arm_copy_block_xfer): Use count_one_bits.
+       (thumb2_copy_block_xfer): Use count_one_bits.
+       (thumb_copy_pop_pc_16bit): Use count_one_bits.
+       * arch/arm-get-next-pcs.c: Include count-one-bits.h.
+       (thumb_get_next_pcs_raw): Use count_one_bits.
+       (arm_get_next_pcs_raw): Use count_one_bits_l.
+       * arch/arm.c (bitcount): Remove.
+       * arch/arm.h (bitcount): Remove.
+
+2020-02-14  Tom Tromey  <tromey@adacore.com>
+
+       * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
+       Update.
+       * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
+       * dwarf2/loc.c (call_site_find_chain_1): Return
+       unique_xmalloc_ptr.
+       (call_site_find_chain): Likewise.
+
+2020-02-14  Richard Biener  <rguenther@suse.de>
+
+       * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
+       on expression with division operators.
+
+2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
+
+       * MAINTAINERS (Write After Approval): Adding myself.
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * event-loop.c (event_data, gdb_event, event_handler_func):
+       Remove.
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
+       (dwarf2_frame_objfile_data): Add comment.
+       (find_comp_unit, set_comp_unit): New functions.
+       (dwarf2_frame_find_fde): Use find_comp_unit.
+       (dwarf2_build_frame_info): Use set_comp_unit.
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
+       (comp_unit): Don't initialize objfile.
+       (execute_cfa_program): Add text_offset parameter.
+       (execute_cfa_program_test, dwarf2_fetch_cfa_info)
+       (dwarf2_frame_cache): Update.
+       (dwarf2_build_frame_info): Don't set "objfile" member.
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
+       (decode_frame_entry): Likewise.
+       (dwarf2_build_frame_info): Update.
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
+       (decode_frame_entry_1): Use the comp_unit obstack.
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/frame.c (struct comp_unit): Add initializers and
+       constructor.
+       (dwarf2_frame_objfile_data): Store a comp_unit.
+       (dwarf2_frame_find_fde): Update.
+       (dwarf2_build_frame_info): Use "new".
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
+       (dwarf2_fde_table): Typedef for std::vector.
+       (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
+       (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
+       (decode_frame_entry): Update.
+       (dwarf2_build_frame_info): Use "new".
+
+2020-02-12  Christian Biesinger  <cbiesinger@google.com>
+
+       * arm-tdep.c (arm_gdbarch_init): Update.
+       * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
+       have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
+       have_neon, is_m>: Change to bool.
+
+2020-02-12  Christian Biesinger  <cbiesinger@google.com>
+
+       * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
+
+2020-02-12  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
+
+2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
+
+       * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
+       (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
+
+2020-02-11  Tom Tromey  <tom@tromey.com>
+
+       * psymtab.h: Update comment.
+
+2020-02-11  Tom Tromey  <tom@tromey.com>
+
+       * gdb_obstack.h (struct auto_obstack): Use
+       DISABLE_COPY_AND_ASSIGN.
+
+2020-02-11  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/frame.h (struct objfile): Don't forward declare.
+
+2020-02-11  Christian Biesinger  <cbiesinger@google.com>
+
+       * cris-tdep.c (cris_supply_gregset): Change signature to match
+       what struct regset expects.
+       (cris_regset): New struct.
+       (fetch_core_registers): Remove.
+       (cris_iterate_over_regset_sections): New function.
+       (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
+       (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
+
+2020-02-11  Christian Biesinger  <cbiesinger@google.com>
+
+       * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
+       registers.
+
+2020-02-11  Christian Biesinger  <cbiesinger@google.com>
+
+       * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
+
+2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
+
+       * configure: Re-generate.
+
+2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
+
+       * configure: Re-generate.
+
+2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
+
+       * acinclude: Update warning.m4 path.
+       * warning.m4: Move to gdbsupport.
+
+2020-02-11  Tom Tromey  <tromey@adacore.com>
+
+       * remote.c (remote_console_output): Update.
+       * printcmd.c (printf_command): Update.
+       * event-loop.c (gdb_wait_for_event): Update.
+       * linux-nat.c (sigchld_handler): Update.
+       * remote-sim.c (gdb_os_write_stdout): Update.
+       (gdb_os_flush_stdout): Update.
+       (gdb_os_flush_stderr): Update.
+       (gdb_os_write_stderr): Update.
+       * exceptions.c (print_exception): Update.
+       * remote-fileio.c (remote_fileio_func_read): Update.
+       (remote_fileio_func_write): Update.
+       * tui/tui.c (tui_enable): Update.
+       * tui/tui-interp.c (tui_interp::init): Update.
+       * utils.c (init_page_info): Update.
+       (putchar_unfiltered, fputc_unfiltered): Update.
+       (gdb_flush): Update.
+       (emit_style_escape): Update.
+       (flush_wrap_buffer, fputs_maybe_filtered): Update.
+       * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
+       (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
+       (stderr_file::write): Update.
+       (stderr_file::puts): Update.
+       * ui-file.h (ui_file_isatty, ui_file_write)
+       (ui_file_write_async_safe, ui_file_read, ui_file_flush)
+       (ui_file_puts): Don't declare.
+
+2020-02-10  Tom de Vries  <tdevries@suse.de>
+
+       * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
+       sentinel to char *.
+
+2020-02-09  Tom de Vries  <tdevries@suse.de>
+
+       * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
+       filename if it matches "<artificial>".
+
+2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
+
+       * windows-tdep.c (struct enum_value_name): New struct.
+       (create_enum): New function.
+       (windows_get_siginfo_type): Create and use enum types.
+
+2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
+
+       * NEWS: Mention $_siginfo support for Windows.
+       * windows-nat.c (handle_exception): Set siginfo_er.
+       (windows_nat_target::mourn_inferior): Reset siginfo_er.
+       (windows_xfer_siginfo): New function.
+       (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
+       * windows-tdep.c (struct windows_gdbarch_data): New struct.
+       (init_windows_gdbarch_data): New function.
+       (get_windows_gdbarch_data): New function.
+       (windows_get_siginfo_type): New function.
+       (windows_init_abi): Register windows_get_siginfo_type.
+       (_initialize_windows_tdep): Register init_windows_gdbarch_data.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (class cutu_reader) <cutu_reader,
+       init_tu_and_read_dwo_dies>: Remove "keep" parameter.
+       <keep>: Declare method.
+       <m_keep>: Remove member.
+       <~cutu_reader>: Remove.
+       (cutu_reader::init_tu_and_read_dwo_dies): Update.
+       (cutu_reader::cutu_reader): Update.
+       (cutu_reader::keep): Rename from ~cutu_reader.
+       (process_psymtab_comp_unit, build_type_psymtabs_1)
+       (process_skeletonless_type_unit, load_partial_comp_unit)
+       (load_full_comp_unit, dwarf2_read_addr_index)
+       (read_signatured_type): Update.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
+       "want_partial_unit" parameter.
+       (process_psymtab_comp_unit): Change want_partial_unit to bool.
+       Inline check for DW_TAG_partial_unit.
+       (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
+       read.c.
+       * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
+       read.c.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (read_address): Move to comp-unit.c.
+       (dwarf2_rnglists_process, dwarf2_ranges_process)
+       (read_attribute_value, dwarf_decode_lines_1)
+       (var_decode_location, decode_locdesc): Update.
+       * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
+       read.c.  Remove "cu" parameter.
+       * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
+       method.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (read_attribute_value, read_indirect_string)
+       (read_indirect_line_string): Update.
+       * dwarf2/comp-unit.c (read_offset): Remove.
+       (read_comp_unit_head): Update.
+       * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
+       method.
+       (read_offset): Don't declare.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
+       * dwarf2/read.c (struct comp_unit_head): Move to
+       dwarf2/comp-unit.h.
+       (enum class rcuh_kind): Move to comp-unit.h.
+       (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
+       (read_comp_unit_head, error_check_comp_unit_head)
+       (read_and_check_comp_unit_head): Move to comp-unit.c.
+       (read_offset, dwarf_unit_type_name): Likewise.
+       (create_debug_type_hash_table, read_cutu_die_from_dwo)
+       (cutu_reader::cutu_reader, read_call_site_scope)
+       (find_partial_die, follow_die_offset): Update.
+       * dwarf2/comp-unit.h: New file, from dwarf2read.c.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (read_offset_1): Move to leb.c.
+       (read_abbrev_offset, read_offset, dwarf_decode_line_header)
+       (dwarf_decode_macro_bytes): Update.
+       * dwarf2/leb.c (read_offset): Rename; move from read.c.
+       * dwarf2/leb.h (read_offset): Declare.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (dwarf2_section_size): Remove.
+       (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
+       Update.
+       * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (read_initial_length): Move to leb.c.
+       * dwarf2/leb.h (read_initial_length): Declare.
+       * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
+       handle_nonstd parameter.
+       * dwarf2/frame.c (read_initial_length): Remove.
+       (decode_frame_entry_1): Update.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/loc.c (dwarf2_find_location_expression)
+       (dwarf_evaluate_loc_desc::get_tls_address)
+       (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
+       (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
+       (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
+       (dwarf2_compile_property_to_c)
+       (dwarf2_loc_desc_get_symbol_read_needs)
+       (dwarf2_compile_expr_to_ax, locexpr_describe_location)
+       (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
+       (loclist_describe_location, loclist_tracepoint_var_ref)
+       (loclist_generate_c_location): Update.
+       * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
+       * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
+       (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
+       (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
+       * dwarf2/read.c (dwarf2_per_cu_data::objfile)
+       (dwarf2_per_cu_data::addr_size)
+       (dwarf2_per_cu_data::ref_addr_size)
+       (dwarf2_per_cu_data::text_offset)
+       (dwarf2_per_cu_data::addr_type): Now methods.
+       (per_cu_header_read_in): Make per_cu "const".
+       (dwarf2_version): Remove.
+       (dwarf2_per_cu_data::int_type): Now a method.
+       (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
+       (set_die_type, read_array_type, read_subrange_index_type)
+       (read_tag_string_type, read_subrange_type): Update.
+       * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
+       offset_size, ref_addr_size, text_offset, addr_type, version,
+       objfile, int_type, addr_sized_int_type>: Declare methods.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
+       Move earlier.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.h (dwarf_line_debug): Declare.
+       * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
+       * dwarf2/read.c: Move line_header code to new files.
+       (dwarf_line_debug): No longer static.
+       * dwarf2/line-header.c: New file.
+       * dwarf2/line-header.h: New file.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (struct line_header) <file_full_name,
+       file_file_name>: Return unique_xmalloc_ptr.
+       (line_header::file_file_name): Update.
+       (line_header::file_full_name): Update.
+       (dw2_get_file_names_reader): Update.
+       (macro_start_file): Update.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (struct line_header) <file_full_name,
+       file_file_name>: Declare methods.
+       (dw2_get_file_names_reader): Update.
+       (file_file_name): Now a method.
+       (file_full_name): Likewise.
+       (macro_start_file): Update.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (dwarf_always_disassemble)
+       (show_dwarf_always_disassemble): Move to loc.c.
+       (_initialize_dwarf2_read): Move "always-disassemble" registration
+       to loc.c.
+       * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
+       * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
+       static.
+       (show_dwarf_always_disassemble): Move from read.c.
+       (_initialize_dwarf2loc): Move always-disassemble from read.c.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/read.c (~dwarf2_per_objfile): Update.
+       (create_quick_file_names_table): Return htab_up.
+       (dw2_get_file_names_reader, dw2_forget_cached_source_info):
+       Update.
+       * dwarf2/read.h (struct dwarf2_per_objfile)
+       <quick_file_names_table>: Now htab_up.
+
+2020-02-08  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2/abbrev.c (abbrev_table::read): Simplify.
+
 2020-02-08  Tom Tromey  <tom@tromey.com>
 
        * dwarf2/abbrev.c (abbrev_table): Move constructor from header.