]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blobdiff - gdb/p-exp.y
Fix powerpc-power8.exp test with new mnemonics
[thirdparty/binutils-gdb.git] / gdb / p-exp.y
index fa6b22c03b37993e9544701f19fbaf44dbc9ba17..f496ce2016e5ac78b5264c2d603dc2e707ca760a 100644 (file)
@@ -1,5 +1,5 @@
 /* YACC parser for Pascal expressions, for GDB.
-   Copyright (C) 2000-2016 Free Software Foundation, Inc.
+   Copyright (C) 2000-2021 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -55,8 +55,9 @@
 #include "objfiles.h" /* For have_full_symbols and have_partial_symbols.  */
 #include "block.h"
 #include "completer.h"
+#include "expop.h"
 
-#define parse_type(ps) builtin_type (parse_gdbarch (ps))
+#define parse_type(ps) builtin_type (ps->gdbarch ())
 
 /* Remap normal yacc parser interface names (yyparse, yylex, yyerror,
    etc).  */
 
 static struct parser_state *pstate = NULL;
 
+/* Depth of parentheses.  */
+static int paren_depth;
+
 int yyparse (void);
 
 static int yylex (void);
 
-void yyerror (char *);
+static void yyerror (const char *);
 
 static char *uptok (const char *, int);
+
+using namespace expr;
 %}
 
 /* Although the yacc "value" of an expression is not used,
@@ -89,7 +95,7 @@ static char *uptok (const char *, int);
       struct type *type;
     } typed_val_int;
     struct {
-      DOUBLEST dval;
+      gdb_byte val[16];
       struct type *type;
     } typed_val_float;
     struct symbol *sym;
@@ -112,7 +118,6 @@ static int parse_number (struct parser_state *,
                         const char *, int, int, YYSTYPE *);
 
 static struct type *current_type;
-static struct internalvar *intvar;
 static int leftdiv_is_integer;
 static void push_current_type (void);
 static void pop_current_type (void);
@@ -158,7 +163,7 @@ static int search_field;
 /* Special type cases, put in to allow the parser to distinguish different
    legal basetypes.  */
 
-%token <voidval> VARIABLE
+%token <sval> DOLLAR_VARIABLE
 
 
 /* Object pascal */
@@ -189,7 +194,6 @@ static int search_field;
 %%
 
 start   :      { current_type = NULL;
-                 intvar = NULL;
                  search_field = 0;
                  leftdiv_is_integer = 0;
                }
@@ -202,44 +206,43 @@ normal_start      :
        ;
 
 type_exp:      type
-                       { write_exp_elt_opcode (pstate, OP_TYPE);
-                         write_exp_elt_type (pstate, $1);
-                         write_exp_elt_opcode (pstate, OP_TYPE);
+                       {
+                         pstate->push_new<type_operation> ($1);
                          current_type = $1; } ;
 
 /* Expressions, including the comma operator.  */
 exp1   :       exp
        |       exp1 ',' exp
-                       { write_exp_elt_opcode (pstate, BINOP_COMMA); }
+                       { pstate->wrap2<comma_operation> (); }
        ;
 
 /* Expressions, not including the comma operator.  */
 exp    :       exp '^'   %prec UNARY
-                       { write_exp_elt_opcode (pstate, UNOP_IND);
+                       { pstate->wrap<unop_ind_operation> ();
                          if (current_type)
                            current_type = TYPE_TARGET_TYPE (current_type); }
        ;
 
 exp    :       '@' exp    %prec UNARY
-                       { write_exp_elt_opcode (pstate, UNOP_ADDR);
+                       { pstate->wrap<unop_addr_operation> ();
                          if (current_type)
                            current_type = TYPE_POINTER_TYPE (current_type); }
        ;
 
 exp    :       '-' exp    %prec UNARY
-                       { write_exp_elt_opcode (pstate, UNOP_NEG); }
+                       { pstate->wrap<unary_neg_operation> (); }
        ;
 
 exp    :       NOT exp    %prec UNARY
-                       { write_exp_elt_opcode (pstate, UNOP_LOGICAL_NOT); }
+                       { pstate->wrap<unary_logical_not_operation> (); }
        ;
 
 exp    :       INCREMENT '(' exp ')'   %prec UNARY
-                       { write_exp_elt_opcode (pstate, UNOP_PREINCREMENT); }
+                       { pstate->wrap<preinc_operation> (); }
        ;
 
 exp    :       DECREMENT  '(' exp ')'   %prec UNARY
-                       { write_exp_elt_opcode (pstate, UNOP_PREDECREMENT); }
+                       { pstate->wrap<predec_operation> (); }
        ;
 
 
@@ -248,13 +251,13 @@ field_exp :       exp '.' %prec UNARY
        ;
 
 exp    :       field_exp FIELDNAME
-                       { write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
-                         write_exp_string (pstate, $2);
-                         write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
+                       {
+                         pstate->push_new<structop_operation>
+                           (pstate->pop (), copy_name ($2));
                          search_field = 0;
                          if (current_type)
                            {
-                             while (TYPE_CODE (current_type)
+                             while (current_type->code ()
                                     == TYPE_CODE_PTR)
                                current_type =
                                  TYPE_TARGET_TYPE (current_type);
@@ -266,13 +269,13 @@ exp       :       field_exp FIELDNAME
 
 
 exp    :       field_exp name
-                       { write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
-                         write_exp_string (pstate, $2);
-                         write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
+                       {
+                         pstate->push_new<structop_operation>
+                           (pstate->pop (), copy_name ($2));
                          search_field = 0;
                          if (current_type)
                            {
-                             while (TYPE_CODE (current_type)
+                             while (current_type->code ()
                                     == TYPE_CODE_PTR)
                                current_type =
                                  TYPE_TARGET_TYPE (current_type);
@@ -282,47 +285,41 @@ exp       :       field_exp name
                        }
        ;
 exp    :       field_exp  name COMPLETE
-                       { mark_struct_expression (pstate);
-                         write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
-                         write_exp_string (pstate, $2);
-                         write_exp_elt_opcode (pstate, STRUCTOP_STRUCT); }
+                       {
+                         structop_base_operation *op
+                           = new structop_ptr_operation (pstate->pop (),
+                                                         copy_name ($2));
+                         pstate->mark_struct_expression (op);
+                         pstate->push (operation_up (op));
+                       }
        ;
 exp    :       field_exp COMPLETE
-                       { struct stoken s;
-                         mark_struct_expression (pstate);
-                         write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
-                         s.ptr = "";
-                         s.length = 0;
-                         write_exp_string (pstate, s);
-                         write_exp_elt_opcode (pstate, STRUCTOP_STRUCT); }
+                       {
+                         structop_base_operation *op
+                           = new structop_ptr_operation (pstate->pop (), "");
+                         pstate->mark_struct_expression (op);
+                         pstate->push (operation_up (op));
+                       }
        ;
 
 exp    :       exp '['
                        /* We need to save the current_type value.  */
                        { const char *arrayname;
-                         int arrayfieldindex;
-                         arrayfieldindex = is_pascal_string_type (
-                               current_type, NULL, NULL,
-                               NULL, NULL, &arrayname);
+                         int arrayfieldindex
+                           = pascal_is_string_type (current_type, NULL, NULL,
+                                                    NULL, NULL, &arrayname);
                          if (arrayfieldindex)
                            {
-                             struct stoken stringsval;
-                             char *buf;
-
-                             buf = (char *) alloca (strlen (arrayname) + 1);
-                             stringsval.ptr = buf;
-                             stringsval.length = strlen (arrayname);
-                             strcpy (buf, arrayname);
-                             current_type = TYPE_FIELD_TYPE (current_type,
-                               arrayfieldindex - 1);
-                             write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
-                             write_exp_string (pstate, stringsval);
-                             write_exp_elt_opcode (pstate, STRUCTOP_STRUCT);
+                             current_type
+                               = (current_type
+                                  ->field (arrayfieldindex - 1).type ());
+                             pstate->push_new<structop_operation>
+                               (pstate->pop (), arrayname);
                            }
                          push_current_type ();  }
                exp1 ']'
                        { pop_current_type ();
-                         write_exp_elt_opcode (pstate, BINOP_SUBSCRIPT);
+                         pstate->wrap2<subscript_operation> ();
                          if (current_type)
                            current_type = TYPE_TARGET_TYPE (current_type); }
        ;
@@ -331,12 +328,13 @@ exp       :       exp '('
                        /* This is to save the value of arglist_len
                           being accumulated by an outer function call.  */
                        { push_current_type ();
-                         start_arglist (); }
+                         pstate->start_arglist (); }
                arglist ')'     %prec ARROW
-                       { write_exp_elt_opcode (pstate, OP_FUNCALL);
-                         write_exp_elt_longcst (pstate,
-                                                (LONGEST) end_arglist ());
-                         write_exp_elt_opcode (pstate, OP_FUNCALL);
+                       {
+                         std::vector<operation_up> args
+                           = pstate->pop_vector (pstate->end_arglist ());
+                         pstate->push_new<funcall_operation>
+                           (pstate->pop (), std::move (args));
                          pop_current_type ();
                          if (current_type)
                            current_type = TYPE_TARGET_TYPE (current_type);
@@ -344,24 +342,23 @@ exp       :       exp '('
        ;
 
 arglist        :
-         | exp
-                       { arglist_len = 1; }
+        | exp
+                       { pstate->arglist_len = 1; }
         | arglist ',' exp   %prec ABOVE_COMMA
-                       { arglist_len++; }
+                       { pstate->arglist_len++; }
        ;
 
 exp    :       type '(' exp ')' %prec UNARY
                        { if (current_type)
                            {
                              /* Allow automatic dereference of classes.  */
-                             if ((TYPE_CODE (current_type) == TYPE_CODE_PTR)
-                                 && (TYPE_CODE (TYPE_TARGET_TYPE (current_type)) == TYPE_CODE_STRUCT)
-                                 && (TYPE_CODE ($1) == TYPE_CODE_STRUCT))
-                               write_exp_elt_opcode (pstate, UNOP_IND);
+                             if ((current_type->code () == TYPE_CODE_PTR)
+                                 && (TYPE_TARGET_TYPE (current_type)->code () == TYPE_CODE_STRUCT)
+                                 && (($1)->code () == TYPE_CODE_STRUCT))
+                               pstate->wrap<unop_ind_operation> ();
                            }
-                         write_exp_elt_opcode (pstate, UNOP_CAST);
-                         write_exp_elt_type (pstate, $1);
-                         write_exp_elt_opcode (pstate, UNOP_CAST);
+                         pstate->push_new<unop_cast_operation>
+                           (pstate->pop (), $1);
                          current_type = $1; }
        ;
 
@@ -372,7 +369,7 @@ exp :       '(' exp1 ')'
 /* Binary operators in order of decreasing precedence.  */
 
 exp    :       exp '*' exp
-                       { write_exp_elt_opcode (pstate, BINOP_MUL); }
+                       { pstate->wrap2<mul_operation> (); }
        ;
 
 exp    :       exp '/' {
@@ -384,171 +381,183 @@ exp     :       exp '/' {
                          if (leftdiv_is_integer && current_type
                              && is_integral_type (current_type))
                            {
-                             write_exp_elt_opcode (pstate, UNOP_CAST);
-                             write_exp_elt_type (pstate,
-                                                 parse_type (pstate)
-                                                 ->builtin_long_double);
+                             pstate->push_new<unop_cast_operation>
+                               (pstate->pop (),
+                                parse_type (pstate)->builtin_long_double);
                              current_type
                                = parse_type (pstate)->builtin_long_double;
-                             write_exp_elt_opcode (pstate, UNOP_CAST);
                              leftdiv_is_integer = 0;
                            }
 
-                         write_exp_elt_opcode (pstate, BINOP_DIV);
+                         pstate->wrap2<div_operation> ();
                        }
        ;
 
 exp    :       exp DIV exp
-                       { write_exp_elt_opcode (pstate, BINOP_INTDIV); }
+                       { pstate->wrap2<intdiv_operation> (); }
        ;
 
 exp    :       exp MOD exp
-                       { write_exp_elt_opcode (pstate, BINOP_REM); }
+                       { pstate->wrap2<rem_operation> (); }
        ;
 
 exp    :       exp '+' exp
-                       { write_exp_elt_opcode (pstate, BINOP_ADD); }
+                       { pstate->wrap2<add_operation> (); }
        ;
 
 exp    :       exp '-' exp
-                       { write_exp_elt_opcode (pstate, BINOP_SUB); }
+                       { pstate->wrap2<sub_operation> (); }
        ;
 
 exp    :       exp LSH exp
-                       { write_exp_elt_opcode (pstate, BINOP_LSH); }
+                       { pstate->wrap2<lsh_operation> (); }
        ;
 
 exp    :       exp RSH exp
-                       { write_exp_elt_opcode (pstate, BINOP_RSH); }
+                       { pstate->wrap2<rsh_operation> (); }
        ;
 
 exp    :       exp '=' exp
-                       { write_exp_elt_opcode (pstate, BINOP_EQUAL);
+                       {
+                         pstate->wrap2<equal_operation> ();
                          current_type = parse_type (pstate)->builtin_bool;
                        }
        ;
 
 exp    :       exp NOTEQUAL exp
-                       { write_exp_elt_opcode (pstate, BINOP_NOTEQUAL);
+                       {
+                         pstate->wrap2<notequal_operation> ();
                          current_type = parse_type (pstate)->builtin_bool;
                        }
        ;
 
 exp    :       exp LEQ exp
-                       { write_exp_elt_opcode (pstate, BINOP_LEQ);
+                       {
+                         pstate->wrap2<leq_operation> ();
                          current_type = parse_type (pstate)->builtin_bool;
                        }
        ;
 
 exp    :       exp GEQ exp
-                       { write_exp_elt_opcode (pstate, BINOP_GEQ);
+                       {
+                         pstate->wrap2<geq_operation> ();
                          current_type = parse_type (pstate)->builtin_bool;
                        }
        ;
 
 exp    :       exp '<' exp
-                       { write_exp_elt_opcode (pstate, BINOP_LESS);
+                       {
+                         pstate->wrap2<less_operation> ();
                          current_type = parse_type (pstate)->builtin_bool;
                        }
        ;
 
 exp    :       exp '>' exp
-                       { write_exp_elt_opcode (pstate, BINOP_GTR);
+                       {
+                         pstate->wrap2<gtr_operation> ();
                          current_type = parse_type (pstate)->builtin_bool;
                        }
        ;
 
 exp    :       exp ANDAND exp
-                       { write_exp_elt_opcode (pstate, BINOP_BITWISE_AND); }
+                       { pstate->wrap2<bitwise_and_operation> (); }
        ;
 
 exp    :       exp XOR exp
-                       { write_exp_elt_opcode (pstate, BINOP_BITWISE_XOR); }
+                       { pstate->wrap2<bitwise_xor_operation> (); }
        ;
 
 exp    :       exp OR exp
-                       { write_exp_elt_opcode (pstate, BINOP_BITWISE_IOR); }
+                       { pstate->wrap2<bitwise_ior_operation> (); }
        ;
 
 exp    :       exp ASSIGN exp
-                       { write_exp_elt_opcode (pstate, BINOP_ASSIGN); }
+                       { pstate->wrap2<assign_operation> (); }
        ;
 
 exp    :       TRUEKEYWORD
-                       { write_exp_elt_opcode (pstate, OP_BOOL);
-                         write_exp_elt_longcst (pstate, (LONGEST) $1);
+                       {
+                         pstate->push_new<bool_operation> ($1);
                          current_type = parse_type (pstate)->builtin_bool;
-                         write_exp_elt_opcode (pstate, OP_BOOL); }
+                       }
        ;
 
 exp    :       FALSEKEYWORD
-                       { write_exp_elt_opcode (pstate, OP_BOOL);
-                         write_exp_elt_longcst (pstate, (LONGEST) $1);
+                       {
+                         pstate->push_new<bool_operation> ($1);
                          current_type = parse_type (pstate)->builtin_bool;
-                         write_exp_elt_opcode (pstate, OP_BOOL); }
+                       }
        ;
 
 exp    :       INT
-                       { write_exp_elt_opcode (pstate, OP_LONG);
-                         write_exp_elt_type (pstate, $1.type);
+                       {
+                         pstate->push_new<long_const_operation>
+                           ($1.type, $1.val);
                          current_type = $1.type;
-                         write_exp_elt_longcst (pstate, (LONGEST)($1.val));
-                         write_exp_elt_opcode (pstate, OP_LONG); }
+                       }
        ;
 
 exp    :       NAME_OR_INT
                        { YYSTYPE val;
                          parse_number (pstate, $1.stoken.ptr,
                                        $1.stoken.length, 0, &val);
-                         write_exp_elt_opcode (pstate, OP_LONG);
-                         write_exp_elt_type (pstate, val.typed_val_int.type);
+                         pstate->push_new<long_const_operation>
+                           (val.typed_val_int.type,
+                            val.typed_val_int.val);
                          current_type = val.typed_val_int.type;
-                         write_exp_elt_longcst (pstate, (LONGEST)
-                                                val.typed_val_int.val);
-                         write_exp_elt_opcode (pstate, OP_LONG);
                        }
        ;
 
 
 exp    :       FLOAT
-                       { write_exp_elt_opcode (pstate, OP_DOUBLE);
-                         write_exp_elt_type (pstate, $1.type);
-                         current_type = $1.type;
-                         write_exp_elt_dblcst (pstate, $1.dval);
-                         write_exp_elt_opcode (pstate, OP_DOUBLE); }
+                       {
+                         float_data data;
+                         std::copy (std::begin ($1.val), std::end ($1.val),
+                                    std::begin (data));
+                         pstate->push_new<float_const_operation> ($1.type, data);
+                       }
        ;
 
 exp    :       variable
        ;
 
-exp    :       VARIABLE
-                       /* Already written by write_dollar_variable.
-                          Handle current_type.  */
-                       {  if (intvar) {
-                            struct value * val, * mark;
-
-                            mark = value_mark ();
-                            val = value_of_internalvar (parse_gdbarch (pstate),
-                                                        intvar);
-                            current_type = value_type (val);
-                            value_release_to_mark (mark);
-                          }
+exp    :       DOLLAR_VARIABLE
+                       {
+                         pstate->push_dollar ($1);
+
+                         /* $ is the normal prefix for pascal
+                            hexadecimal values but this conflicts
+                            with the GDB use for debugger variables
+                            so in expression to enter hexadecimal
+                            values we still need to use C syntax with
+                            0xff */
+                         std::string tmp ($1.ptr, $1.length);
+                         /* Handle current_type.  */
+                         struct internalvar *intvar
+                           = lookup_only_internalvar (tmp.c_str () + 1);
+                         if (intvar != nullptr)
+                           {
+                             scoped_value_mark mark;
+
+                             value *val
+                               = value_of_internalvar (pstate->gdbarch (),
+                                                       intvar);
+                             current_type = value_type (val);
+                           }
                        }
        ;
 
 exp    :       SIZEOF '(' type ')'     %prec UNARY
-                       { write_exp_elt_opcode (pstate, OP_LONG);
-                         write_exp_elt_type (pstate,
-                                           parse_type (pstate)->builtin_int);
+                       {
                          current_type = parse_type (pstate)->builtin_int;
                          $3 = check_typedef ($3);
-                         write_exp_elt_longcst (pstate,
-                                                (LONGEST) TYPE_LENGTH ($3));
-                         write_exp_elt_opcode (pstate, OP_LONG); }
+                         pstate->push_new<long_const_operation>
+                           (parse_type (pstate)->builtin_int,
+                            TYPE_LENGTH ($3)); }
        ;
 
 exp    :       SIZEOF  '(' exp ')'      %prec UNARY
-                       { write_exp_elt_opcode (pstate, UNOP_SIZEOF);
+                       { pstate->wrap<unop_sizeof_operation> ();
                          current_type = parse_type (pstate)->builtin_int; }
 
 exp    :       STRING
@@ -559,27 +568,17 @@ exp       :       STRING
                             string.  */
                          const char *sp = $1.ptr; int count = $1.length;
 
-                         while (count-- > 0)
-                           {
-                             write_exp_elt_opcode (pstate, OP_LONG);
-                             write_exp_elt_type (pstate,
-                                                 parse_type (pstate)
-                                                 ->builtin_char);
-                             write_exp_elt_longcst (pstate,
-                                                    (LONGEST) (*sp++));
-                             write_exp_elt_opcode (pstate, OP_LONG);
-                           }
-                         write_exp_elt_opcode (pstate, OP_LONG);
-                         write_exp_elt_type (pstate,
-                                             parse_type (pstate)
-                                             ->builtin_char);
-                         write_exp_elt_longcst (pstate, (LONGEST)'\0');
-                         write_exp_elt_opcode (pstate, OP_LONG);
-                         write_exp_elt_opcode (pstate, OP_ARRAY);
-                         write_exp_elt_longcst (pstate, (LONGEST) 0);
-                         write_exp_elt_longcst (pstate,
-                                                (LONGEST) ($1.length));
-                         write_exp_elt_opcode (pstate, OP_ARRAY); }
+                         std::vector<operation_up> args (count + 1);
+                         for (int i = 0; i < count; ++i)
+                           args[i] = (make_operation<long_const_operation>
+                                      (parse_type (pstate)->builtin_char,
+                                       *sp++));
+                         args[count] = (make_operation<long_const_operation>
+                                        (parse_type (pstate)->builtin_char,
+                                         '\0'));
+                         pstate->push_new<array_operation>
+                           (0, $1.length, std::move (args));
+                       }
        ;
 
 /* Object pascal  */
@@ -587,21 +586,20 @@ exp       :       THIS
                        {
                          struct value * this_val;
                          struct type * this_type;
-                         write_exp_elt_opcode (pstate, OP_THIS);
-                         write_exp_elt_opcode (pstate, OP_THIS);
+                         pstate->push_new<op_this_operation> ();
                          /* We need type of this.  */
                          this_val
-                           = value_of_this_silent (parse_language (pstate));
+                           = value_of_this_silent (pstate->language ());
                          if (this_val)
                            this_type = value_type (this_val);
                          else
                            this_type = NULL;
                          if (this_type)
                            {
-                             if (TYPE_CODE (this_type) == TYPE_CODE_PTR)
+                             if (this_type->code () == TYPE_CODE_PTR)
                                {
                                  this_type = TYPE_TARGET_TYPE (this_type);
-                                 write_exp_elt_opcode (pstate, UNOP_IND);
+                                 pstate->wrap<unop_ind_operation> ();
                                }
                            }
 
@@ -617,89 +615,69 @@ block     :       BLOCKNAME
                              $$ = SYMBOL_BLOCK_VALUE ($1.sym.symbol);
                          else
                            {
+                             std::string copy = copy_name ($1.stoken);
                              struct symtab *tem =
-                                 lookup_symtab (copy_name ($1.stoken));
+                                 lookup_symtab (copy.c_str ());
                              if (tem)
                                $$ = BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (tem),
                                                        STATIC_BLOCK);
                              else
                                error (_("No file or function \"%s\"."),
-                                      copy_name ($1.stoken));
+                                      copy.c_str ());
                            }
                        }
        ;
 
 block  :       block COLONCOLON name
-                       { struct symbol *tem
-                           = lookup_symbol (copy_name ($3), $1,
+                       {
+                         std::string copy = copy_name ($3);
+                         struct symbol *tem
+                           = lookup_symbol (copy.c_str (), $1,
                                             VAR_DOMAIN, NULL).symbol;
 
                          if (!tem || SYMBOL_CLASS (tem) != LOC_BLOCK)
                            error (_("No function \"%s\" in specified context."),
-                                  copy_name ($3));
+                                  copy.c_str ());
                          $$ = SYMBOL_BLOCK_VALUE (tem); }
        ;
 
 variable:      block COLONCOLON name
                        { struct block_symbol sym;
 
-                         sym = lookup_symbol (copy_name ($3), $1,
+                         std::string copy = copy_name ($3);
+                         sym = lookup_symbol (copy.c_str (), $1,
                                               VAR_DOMAIN, NULL);
                          if (sym.symbol == 0)
                            error (_("No symbol \"%s\" in specified context."),
-                                  copy_name ($3));
+                                  copy.c_str ());
 
-                         write_exp_elt_opcode (pstate, OP_VAR_VALUE);
-                         write_exp_elt_block (pstate, sym.block);
-                         write_exp_elt_sym (pstate, sym.symbol);
-                         write_exp_elt_opcode (pstate, OP_VAR_VALUE); }
+                         pstate->push_new<var_value_operation> (sym);
+                       }
        ;
 
 qualified_name:        typebase COLONCOLON name
                        {
                          struct type *type = $1;
 
-                         if (TYPE_CODE (type) != TYPE_CODE_STRUCT
-                             && TYPE_CODE (type) != TYPE_CODE_UNION)
+                         if (type->code () != TYPE_CODE_STRUCT
+                             && type->code () != TYPE_CODE_UNION)
                            error (_("`%s' is not defined as an aggregate type."),
-                                  TYPE_NAME (type));
+                                  type->name ());
 
-                         write_exp_elt_opcode (pstate, OP_SCOPE);
-                         write_exp_elt_type (pstate, type);
-                         write_exp_string (pstate, $3);
-                         write_exp_elt_opcode (pstate, OP_SCOPE);
+                         pstate->push_new<scope_operation>
+                           (type, copy_name ($3));
                        }
        ;
 
 variable:      qualified_name
        |       COLONCOLON name
                        {
-                         char *name = copy_name ($2);
-                         struct symbol *sym;
-                         struct bound_minimal_symbol msymbol;
-
-                         sym =
-                           lookup_symbol (name, (const struct block *) NULL,
-                                          VAR_DOMAIN, NULL).symbol;
-                         if (sym)
-                           {
-                             write_exp_elt_opcode (pstate, OP_VAR_VALUE);
-                             write_exp_elt_block (pstate, NULL);
-                             write_exp_elt_sym (pstate, sym);
-                             write_exp_elt_opcode (pstate, OP_VAR_VALUE);
-                             break;
-                           }
+                         std::string name = copy_name ($2);
 
-                         msymbol = lookup_bound_minimal_symbol (name);
-                         if (msymbol.minsym != NULL)
-                           write_exp_msymbol (pstate, msymbol);
-                         else if (!have_full_symbols ()
-                                  && !have_partial_symbols ())
-                           error (_("No symbol table is loaded.  "
-                                  "Use the \"file\" command."));
-                         else
-                           error (_("No symbol \"%s\" in current context."),
-                                  name);
+                         struct block_symbol sym
+                           = lookup_symbol (name.c_str (), nullptr,
+                                            VAR_DOMAIN, nullptr);
+                         pstate->push_symbol (name.c_str (), sym);
                        }
        ;
 
@@ -709,37 +687,25 @@ variable: name_not_typename
                          if (sym.symbol)
                            {
                              if (symbol_read_needs_frame (sym.symbol))
-                               {
-                                 if (innermost_block == 0
-                                     || contained_in (sym.block,
-                                                      innermost_block))
-                                   innermost_block = sym.block;
-                               }
+                               pstate->block_tracker->update (sym);
 
-                             write_exp_elt_opcode (pstate, OP_VAR_VALUE);
-                             write_exp_elt_block (pstate, sym.block);
-                             write_exp_elt_sym (pstate, sym.symbol);
-                             write_exp_elt_opcode (pstate, OP_VAR_VALUE);
+                             pstate->push_new<var_value_operation> (sym);
                              current_type = sym.symbol->type; }
                          else if ($1.is_a_field_of_this)
                            {
                              struct value * this_val;
                              struct type * this_type;
                              /* Object pascal: it hangs off of `this'.  Must
-                                not inadvertently convert from a method call
+                                not inadvertently convert from a method call
                                 to data ref.  */
-                             if (innermost_block == 0
-                                 || contained_in (sym.block,
-                                                  innermost_block))
-                               innermost_block = sym.block;
-                             write_exp_elt_opcode (pstate, OP_THIS);
-                             write_exp_elt_opcode (pstate, OP_THIS);
-                             write_exp_elt_opcode (pstate, STRUCTOP_PTR);
-                             write_exp_string (pstate, $1.stoken);
-                             write_exp_elt_opcode (pstate, STRUCTOP_PTR);
+                             pstate->block_tracker->update (sym);
+                             operation_up thisop
+                               = make_operation<op_this_operation> ();
+                             pstate->push_new<structop_operation>
+                               (std::move (thisop), copy_name ($1.stoken));
                              /* We need type of this.  */
                              this_val
-                               = value_of_this_silent (parse_language (pstate));
+                               = value_of_this_silent (pstate->language ());
                              if (this_val)
                                this_type = value_type (this_val);
                              else
@@ -747,26 +713,27 @@ variable: name_not_typename
                              if (this_type)
                                current_type = lookup_struct_elt_type (
                                  this_type,
-                                 copy_name ($1.stoken), 0);
+                                 copy_name ($1.stoken).c_str (), 0);
                              else
                                current_type = NULL;
                            }
                          else
                            {
                              struct bound_minimal_symbol msymbol;
-                             char *arg = copy_name ($1.stoken);
+                             std::string arg = copy_name ($1.stoken);
 
                              msymbol =
-                               lookup_bound_minimal_symbol (arg);
+                               lookup_bound_minimal_symbol (arg.c_str ());
                              if (msymbol.minsym != NULL)
-                               write_exp_msymbol (pstate, msymbol);
+                               pstate->push_new<var_msym_value_operation>
+                                 (msymbol);
                              else if (!have_full_symbols ()
                                       && !have_partial_symbols ())
                                error (_("No symbol table is loaded.  "
                                       "Use the \"file\" command."));
                              else
                                error (_("No symbol \"%s\" in current context."),
-                                      copy_name ($1.stoken));
+                                      arg.c_str ());
                            }
                        }
        ;
@@ -792,11 +759,15 @@ typebase  /* Implements (approximately): (type-qualifier)* type-specifier */
        |       TYPENAME
                        { $$ = $1.type; }
        |       STRUCT name
-                       { $$ = lookup_struct (copy_name ($2),
-                                             expression_context_block); }
+                       { $$
+                           = lookup_struct (copy_name ($2).c_str (),
+                                            pstate->expression_context_block);
+                       }
        |       CLASS name
-                       { $$ = lookup_struct (copy_name ($2),
-                                             expression_context_block); }
+                       { $$
+                           = lookup_struct (copy_name ($2).c_str (),
+                                            pstate->expression_context_block);
+                       }
        /* "const" and "volatile" are curently ignored.  A type qualifier
           after the type is handled in the ptype rule.  I think these could
           be too.  */
@@ -854,9 +825,30 @@ parse_number (struct parser_state *par_state,
 
   if (parsed_float)
     {
-      if (! parse_c_float (parse_gdbarch (par_state), p, len,
-                          &putithere->typed_val_float.dval,
-                          &putithere->typed_val_float.type))
+      /* Handle suffixes: 'f' for float, 'l' for long double.
+        FIXME: This appears to be an extension -- do we want this?  */
+      if (len >= 1 && tolower (p[len - 1]) == 'f')
+       {
+         putithere->typed_val_float.type
+           = parse_type (par_state)->builtin_float;
+         len--;
+       }
+      else if (len >= 1 && tolower (p[len - 1]) == 'l')
+       {
+         putithere->typed_val_float.type
+           = parse_type (par_state)->builtin_long_double;
+         len--;
+       }
+      /* Default type for floating-point literals is double.  */
+      else
+       {
+         putithere->typed_val_float.type
+           = parse_type (par_state)->builtin_double;
+       }
+
+      if (!parse_float (p, len,
+                       putithere->typed_val_float.type,
+                       putithere->typed_val_float.val))
        return ERROR;
       return FLOAT;
     }
@@ -960,10 +952,10 @@ parse_number (struct parser_state *par_state,
 
   un = (ULONGEST)n >> 2;
   if (long_p == 0
-      && (un >> (gdbarch_int_bit (parse_gdbarch (par_state)) - 2)) == 0)
+      && (un >> (gdbarch_int_bit (par_state->gdbarch ()) - 2)) == 0)
     {
       high_bit
-       = ((ULONGEST)1) << (gdbarch_int_bit (parse_gdbarch (par_state)) - 1);
+       = ((ULONGEST)1) << (gdbarch_int_bit (par_state->gdbarch ()) - 1);
 
       /* A large decimal (not hex or octal) constant (between INT_MAX
         and UINT_MAX) is a long or unsigned long, according to ANSI,
@@ -975,10 +967,10 @@ parse_number (struct parser_state *par_state,
       signed_type = parse_type (par_state)->builtin_int;
     }
   else if (long_p <= 1
-          && (un >> (gdbarch_long_bit (parse_gdbarch (par_state)) - 2)) == 0)
+          && (un >> (gdbarch_long_bit (par_state->gdbarch ()) - 2)) == 0)
     {
       high_bit
-       = ((ULONGEST)1) << (gdbarch_long_bit (parse_gdbarch (par_state)) - 1);
+       = ((ULONGEST)1) << (gdbarch_long_bit (par_state->gdbarch ()) - 1);
       unsigned_type = parse_type (par_state)->builtin_unsigned_long;
       signed_type = parse_type (par_state)->builtin_long;
     }
@@ -986,11 +978,11 @@ parse_number (struct parser_state *par_state,
     {
       int shift;
       if (sizeof (ULONGEST) * HOST_CHAR_BIT
-         < gdbarch_long_long_bit (parse_gdbarch (par_state)))
+         < gdbarch_long_long_bit (par_state->gdbarch ()))
        /* A long long does not fit in a LONGEST.  */
        shift = (sizeof (ULONGEST) * HOST_CHAR_BIT - 1);
       else
-       shift = (gdbarch_long_long_bit (parse_gdbarch (par_state)) - 1);
+       shift = (gdbarch_long_long_bit (par_state->gdbarch ()) - 1);
       high_bit = (ULONGEST) 1 << shift;
       unsigned_type = parse_type (par_state)->builtin_unsigned_long_long;
       signed_type = parse_type (par_state)->builtin_long_long;
@@ -1047,32 +1039,32 @@ pop_current_type (void)
 
 struct token
 {
-  char *oper;
+  const char *oper;
   int token;
   enum exp_opcode opcode;
 };
 
 static const struct token tokentab3[] =
   {
-    {"shr", RSH, BINOP_END},
-    {"shl", LSH, BINOP_END},
-    {"and", ANDAND, BINOP_END},
-    {"div", DIV, BINOP_END},
-    {"not", NOT, BINOP_END},
-    {"mod", MOD, BINOP_END},
-    {"inc", INCREMENT, BINOP_END},
-    {"dec", DECREMENT, BINOP_END},
-    {"xor", XOR, BINOP_END}
+    {"shr", RSH, OP_NULL},
+    {"shl", LSH, OP_NULL},
+    {"and", ANDAND, OP_NULL},
+    {"div", DIV, OP_NULL},
+    {"not", NOT, OP_NULL},
+    {"mod", MOD, OP_NULL},
+    {"inc", INCREMENT, OP_NULL},
+    {"dec", DECREMENT, OP_NULL},
+    {"xor", XOR, OP_NULL}
   };
 
 static const struct token tokentab2[] =
   {
-    {"or", OR, BINOP_END},
-    {"<>", NOTEQUAL, BINOP_END},
-    {"<=", LEQ, BINOP_END},
-    {">=", GEQ, BINOP_END},
-    {":=", ASSIGN, BINOP_END},
-    {"::", COLONCOLON, BINOP_END} };
+    {"or", OR, OP_NULL},
+    {"<>", NOTEQUAL, OP_NULL},
+    {"<=", LEQ, OP_NULL},
+    {">=", GEQ, OP_NULL},
+    {":=", ASSIGN, OP_NULL},
+    {"::", COLONCOLON, OP_NULL} };
 
 /* Allocate uppercased var: */
 /* make an uppercased copy of tokstart.  */
@@ -1084,9 +1076,9 @@ uptok (const char *tokstart, int namelen)
   for (i = 0;i <= namelen;i++)
     {
       if ((tokstart[i]>='a' && tokstart[i]<='z'))
-        uptokstart[i] = tokstart[i]-('a'-'A');
+       uptokstart[i] = tokstart[i]-('a'-'A');
       else
-        uptokstart[i] = tokstart[i];
+       uptokstart[i] = tokstart[i];
     }
   uptokstart[namelen]='\0';
   return uptokstart;
@@ -1099,7 +1091,6 @@ yylex (void)
 {
   int c;
   int namelen;
-  unsigned int i;
   const char *tokstart;
   char *uptokstart;
   const char *tokptr;
@@ -1109,41 +1100,41 @@ yylex (void)
 
  retry:
 
-  prev_lexptr = lexptr;
+  pstate->prev_lexptr = pstate->lexptr;
 
-  tokstart = lexptr;
-  explen = strlen (lexptr);
+  tokstart = pstate->lexptr;
+  explen = strlen (pstate->lexptr);
 
   /* See if it is a special token of length 3.  */
   if (explen > 2)
-    for (i = 0; i < sizeof (tokentab3) / sizeof (tokentab3[0]); i++)
+    for (int i = 0; i < sizeof (tokentab3) / sizeof (tokentab3[0]); i++)
       if (strncasecmp (tokstart, tokentab3[i].oper, 3) == 0
-          && (!isalpha (tokentab3[i].oper[0]) || explen == 3
-              || (!isalpha (tokstart[3])
+         && (!isalpha (tokentab3[i].oper[0]) || explen == 3
+             || (!isalpha (tokstart[3])
                  && !isdigit (tokstart[3]) && tokstart[3] != '_')))
-        {
-          lexptr += 3;
-          yylval.opcode = tokentab3[i].opcode;
-          return tokentab3[i].token;
-        }
+       {
+         pstate->lexptr += 3;
+         yylval.opcode = tokentab3[i].opcode;
+         return tokentab3[i].token;
+       }
 
   /* See if it is a special token of length 2.  */
   if (explen > 1)
-  for (i = 0; i < sizeof (tokentab2) / sizeof (tokentab2[0]); i++)
+  for (int i = 0; i < sizeof (tokentab2) / sizeof (tokentab2[0]); i++)
       if (strncasecmp (tokstart, tokentab2[i].oper, 2) == 0
-          && (!isalpha (tokentab2[i].oper[0]) || explen == 2
-              || (!isalpha (tokstart[2])
+         && (!isalpha (tokentab2[i].oper[0]) || explen == 2
+             || (!isalpha (tokstart[2])
                  && !isdigit (tokstart[2]) && tokstart[2] != '_')))
-        {
-          lexptr += 2;
-          yylval.opcode = tokentab2[i].opcode;
-          return tokentab2[i].token;
-        }
+       {
+         pstate->lexptr += 2;
+         yylval.opcode = tokentab2[i].opcode;
+         return tokentab2[i].token;
+       }
 
   switch (c = *tokstart)
     {
     case 0:
-      if (search_field && parse_completion)
+      if (search_field && pstate->parse_completion)
        return COMPLETE;
       else
        return 0;
@@ -1151,35 +1142,35 @@ yylex (void)
     case ' ':
     case '\t':
     case '\n':
-      lexptr++;
+      pstate->lexptr++;
       goto retry;
 
     case '\'':
       /* We either have a character constant ('0' or '\177' for example)
         or we have a quoted symbol reference ('foo(int,int)' in object pascal
         for example).  */
-      lexptr++;
-      c = *lexptr++;
+      pstate->lexptr++;
+      c = *pstate->lexptr++;
       if (c == '\\')
-       c = parse_escape (parse_gdbarch (pstate), &lexptr);
+       c = parse_escape (pstate->gdbarch (), &pstate->lexptr);
       else if (c == '\'')
        error (_("Empty character constant."));
 
       yylval.typed_val_int.val = c;
       yylval.typed_val_int.type = parse_type (pstate)->builtin_char;
 
-      c = *lexptr++;
+      c = *pstate->lexptr++;
       if (c != '\'')
        {
          namelen = skip_quoted (tokstart) - tokstart;
          if (namelen > 2)
            {
-             lexptr = tokstart + namelen;
-             if (lexptr[-1] != '\'')
+             pstate->lexptr = tokstart + namelen;
+             if (pstate->lexptr[-1] != '\'')
                error (_("Unmatched single quote."));
              namelen -= 2;
-              tokstart++;
-              uptokstart = uptok(tokstart,namelen);
+             tokstart++;
+             uptokstart = uptok(tokstart,namelen);
              goto tryname;
            }
          error (_("Invalid character constant."));
@@ -1188,30 +1179,30 @@ yylex (void)
 
     case '(':
       paren_depth++;
-      lexptr++;
+      pstate->lexptr++;
       return c;
 
     case ')':
       if (paren_depth == 0)
        return 0;
       paren_depth--;
-      lexptr++;
+      pstate->lexptr++;
       return c;
 
     case ',':
-      if (comma_terminates && paren_depth == 0)
+      if (pstate->comma_terminates && paren_depth == 0)
        return 0;
-      lexptr++;
+      pstate->lexptr++;
       return c;
 
     case '.':
       /* Might be a floating point number.  */
-      if (lexptr[1] < '0' || lexptr[1] > '9')
+      if (pstate->lexptr[1] < '0' || pstate->lexptr[1] > '9')
        {
          goto symbol;          /* Nope, must be a symbol.  */
        }
 
-      /* FALL THRU into number case.  */
+      /* FALL THRU.  */
 
     case '0':
     case '1':
@@ -1266,7 +1257,7 @@ yylex (void)
          }
        toktype = parse_number (pstate, tokstart,
                                p - tokstart, got_dot | got_e, &yylval);
-        if (toktype == ERROR)
+       if (toktype == ERROR)
          {
            char *err_copy = (char *) alloca (p - tokstart + 1);
 
@@ -1274,7 +1265,7 @@ yylex (void)
            err_copy[p - tokstart] = 0;
            error (_("Invalid number \"%s\"."), err_copy);
          }
-       lexptr = p;
+       pstate->lexptr = p;
        return toktype;
       }
 
@@ -1298,7 +1289,7 @@ yylex (void)
     case '{':
     case '}':
     symbol:
-      lexptr++;
+      pstate->lexptr++;
       return c;
 
     case '"':
@@ -1331,7 +1322,7 @@ yylex (void)
            break;
          case '\\':
            ++tokptr;
-           c = parse_escape (parse_gdbarch (pstate), &tokptr);
+           c = parse_escape (pstate->gdbarch (), &tokptr);
            if (c == -1)
              {
                continue;
@@ -1350,7 +1341,7 @@ yylex (void)
       tempbuf[tempbufindex] = '\0';    /* See note above.  */
       yylval.sval.ptr = tempbuf;
       yylval.sval.length = tempbufindex;
-      lexptr = tokptr;
+      pstate->lexptr = tokptr;
       return (STRING);
     }
 
@@ -1401,7 +1392,7 @@ yylex (void)
       return 0;
     }
 
-  lexptr += namelen;
+  pstate->lexptr += namelen;
 
   tryname:
 
@@ -1433,25 +1424,25 @@ yylex (void)
        }
       if (strcmp (uptokstart, "FALSE") == 0)
        {
-          yylval.lval = 0;
+         yylval.lval = 0;
          free (uptokstart);
-          return FALSEKEYWORD;
-        }
+         return FALSEKEYWORD;
+       }
       break;
     case 4:
       if (strcmp (uptokstart, "TRUE") == 0)
        {
-          yylval.lval = 1;
+         yylval.lval = 1;
          free (uptokstart);
          return TRUEKEYWORD;
-        }
+       }
       if (strcmp (uptokstart, "SELF") == 0)
-        {
-          /* Here we search for 'this' like
-             inserted in FPC stabs debug info.  */
+       {
+         /* Here we search for 'this' like
+            inserted in FPC stabs debug info.  */
          static const char this_name[] = "this";
 
-         if (lookup_symbol (this_name, expression_context_block,
+         if (lookup_symbol (this_name, pstate->expression_context_block,
                             VAR_DOMAIN, NULL).symbol)
            {
              free (uptokstart);
@@ -1468,19 +1459,8 @@ yylex (void)
 
   if (*tokstart == '$')
     {
-      char *tmp;
-
-      /* $ is the normal prefix for pascal hexadecimal values
-        but this conflicts with the GDB use for debugger variables
-        so in expression to enter hexadecimal values
-        we still need to use C syntax with 0xff  */
-      write_dollar_variable (pstate, yylval.sval);
-      tmp = (char *) alloca (namelen + 1);
-      memcpy (tmp, tokstart, namelen);
-      tmp[namelen] = '\0';
-      intvar = lookup_only_internalvar (tmp + 1);
       free (uptokstart);
-      return VARIABLE;
+      return DOLLAR_VARIABLE;
     }
 
   /* Use token-type BLOCKNAME for symbols that happen to be defined as
@@ -1489,7 +1469,7 @@ yylex (void)
      currently as names of types; NAME for other symbols.
      The caller is not constrained to care about the distinction.  */
   {
-    char *tmp = copy_name (yylval.sval);
+    std::string tmp = copy_name (yylval.sval);
     struct symbol *sym;
     struct field_of_this_result is_a_field_of_this;
     int is_a_field = 0;
@@ -1497,62 +1477,65 @@ yylex (void)
 
     is_a_field_of_this.type = NULL;
     if (search_field && current_type)
-      is_a_field = (lookup_struct_elt_type (current_type, tmp, 1) != NULL);
+      is_a_field = (lookup_struct_elt_type (current_type,
+                                           tmp.c_str (), 1) != NULL);
     if (is_a_field)
       sym = NULL;
     else
-      sym = lookup_symbol (tmpexpression_context_block,
+      sym = lookup_symbol (tmp.c_str (), pstate->expression_context_block,
                           VAR_DOMAIN, &is_a_field_of_this).symbol;
     /* second chance uppercased (as Free Pascal does).  */
     if (!sym && is_a_field_of_this.type == NULL && !is_a_field)
       {
-       for (i = 0; i <= namelen; i++)
-         {
-           if ((tmp[i] >= 'a' && tmp[i] <= 'z'))
-             tmp[i] -= ('a'-'A');
-         }
+       for (int i = 0; i <= namelen; i++)
+        {
+          if ((tmp[i] >= 'a' && tmp[i] <= 'z'))
+            tmp[i] -= ('a'-'A');
+        }
        if (search_field && current_type)
-        is_a_field = (lookup_struct_elt_type (current_type, tmp, 1) != NULL);
+        is_a_field = (lookup_struct_elt_type (current_type,
+                                              tmp.c_str (), 1) != NULL);
        if (is_a_field)
         sym = NULL;
        else
-        sym = lookup_symbol (tmpexpression_context_block,
+        sym = lookup_symbol (tmp.c_str (), pstate->expression_context_block,
                              VAR_DOMAIN, &is_a_field_of_this).symbol;
       }
     /* Third chance Capitalized (as GPC does).  */
     if (!sym && is_a_field_of_this.type == NULL && !is_a_field)
       {
-       for (i = 0; i <= namelen; i++)
-         {
-           if (i == 0)
-             {
-              if ((tmp[i] >= 'a' && tmp[i] <= 'z'))
-                tmp[i] -= ('a'-'A');
-             }
-           else
-           if ((tmp[i] >= 'A' && tmp[i] <= 'Z'))
-             tmp[i] -= ('A'-'a');
-          }
+       for (int i = 0; i <= namelen; i++)
+        {
+          if (i == 0)
+            {
+             if ((tmp[i] >= 'a' && tmp[i] <= 'z'))
+               tmp[i] -= ('a'-'A');
+            }
+          else
+          if ((tmp[i] >= 'A' && tmp[i] <= 'Z'))
+            tmp[i] -= ('A'-'a');
+         }
        if (search_field && current_type)
-        is_a_field = (lookup_struct_elt_type (current_type, tmp, 1) != NULL);
+        is_a_field = (lookup_struct_elt_type (current_type,
+                                              tmp.c_str (), 1) != NULL);
        if (is_a_field)
         sym = NULL;
        else
-        sym = lookup_symbol (tmpexpression_context_block,
+        sym = lookup_symbol (tmp.c_str (), pstate->expression_context_block,
                              VAR_DOMAIN, &is_a_field_of_this).symbol;
       }
 
     if (is_a_field || (is_a_field_of_this.type != NULL))
       {
        tempbuf = (char *) realloc (tempbuf, namelen + 1);
-       strncpy (tempbuf, tmp, namelen);
+       strncpy (tempbuf, tmp.c_str (), namelen);
        tempbuf [namelen] = 0;
        yylval.sval.ptr = tempbuf;
        yylval.sval.length = namelen;
        yylval.ssym.sym.symbol = NULL;
        yylval.ssym.sym.block = NULL;
        free (uptokstart);
-        yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL;
+       yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL;
        if (is_a_field)
          return FIELDNAME;
        else
@@ -1562,7 +1545,7 @@ yylex (void)
        no psymtabs (coff, xcoff, or some future change to blow away the
        psymtabs once once symbols are read).  */
     if ((sym && SYMBOL_CLASS (sym) == LOC_BLOCK)
-        || lookup_symtab (tmp))
+       || lookup_symtab (tmp.c_str ()))
       {
        yylval.ssym.sym.symbol = sym;
        yylval.ssym.sym.block = NULL;
@@ -1571,7 +1554,7 @@ yylex (void)
        return BLOCKNAME;
       }
     if (sym && SYMBOL_CLASS (sym) == LOC_TYPEDEF)
-        {
+       {
 #if 1
          /* Despite the following flaw, we need to keep this code enabled.
             Because we can get called from check_stub_method, if we don't
@@ -1597,7 +1580,7 @@ yylex (void)
             us whether a type is nested), we just ignore the
             containing type.  */
 
-         p = lexptr;
+         p = pstate->lexptr;
          best_sym = sym;
          while (1)
            {
@@ -1622,25 +1605,27 @@ yylex (void)
                      /* As big as the whole rest of the expression, which is
                         at least big enough.  */
                      char *ncopy
-                       = (char *) alloca (strlen (tmp) + strlen (namestart)
+                       = (char *) alloca (tmp.size () + strlen (namestart)
                                           + 3);
                      char *tmp1;
 
                      tmp1 = ncopy;
-                     memcpy (tmp1, tmp, strlen (tmp));
-                     tmp1 += strlen (tmp);
+                     memcpy (tmp1, tmp.c_str (), tmp.size ());
+                     tmp1 += tmp.size ();
                      memcpy (tmp1, "::", 2);
                      tmp1 += 2;
                      memcpy (tmp1, namestart, p - namestart);
                      tmp1[p - namestart] = '\0';
-                     cur_sym = lookup_symbol (ncopy, expression_context_block,
-                                              VAR_DOMAIN, NULL).symbol;
+                     cur_sym
+                       = lookup_symbol (ncopy,
+                                        pstate->expression_context_block,
+                                        VAR_DOMAIN, NULL).symbol;
                      if (cur_sym)
                        {
                          if (SYMBOL_CLASS (cur_sym) == LOC_TYPEDEF)
                            {
                              best_sym = cur_sym;
-                             lexptr = p;
+                             pstate->lexptr = p;
                            }
                          else
                            break;
@@ -1661,10 +1646,10 @@ yylex (void)
 #endif /* not 0 */
          free (uptokstart);
          return TYPENAME;
-        }
+       }
     yylval.tsym.type
-      = language_lookup_primitive_type (parse_language (pstate),
-                                       parse_gdbarch (pstate), tmp);
+      = language_lookup_primitive_type (pstate->language (),
+                                       pstate->gdbarch (), tmp.c_str ());
     if (yylval.tsym.type != NULL)
       {
        free (uptokstart);
@@ -1675,8 +1660,8 @@ yylex (void)
        when the input radix permits them, can be names or numbers
        depending on the parse.  Note we support radixes > 16 here.  */
     if (!sym
-        && ((tokstart[0] >= 'a' && tokstart[0] < 'a' + input_radix - 10)
-            || (tokstart[0] >= 'A' && tokstart[0] < 'A' + input_radix - 10)))
+       && ((tokstart[0] >= 'a' && tokstart[0] < 'a' + input_radix - 10)
+           || (tokstart[0] >= 'A' && tokstart[0] < 'A' + input_radix - 10)))
       {
        YYSTYPE newlval;        /* Its value is ignored.  */
        hextype = parse_number (pstate, tokstart, namelen, 0, &newlval);
@@ -1698,26 +1683,28 @@ yylex (void)
   }
 }
 
+/* See language.h.  */
+
 int
-pascal_parse (struct parser_state *par_state)
+pascal_language::parser (struct parser_state *par_state) const
 {
-  int result;
-  struct cleanup *c = make_cleanup_clear_parser_state (&pstate);
-
   /* Setting up the parser state.  */
+  scoped_restore pstate_restore = make_scoped_restore (&pstate);
   gdb_assert (par_state != NULL);
   pstate = par_state;
+  paren_depth = 0;
 
-  result = yyparse ();
-  do_cleanups (c);
+  int result = yyparse ();
+  if (!result)
+    pstate->set_operation (pstate->pop ());
   return result;
 }
 
-void
-yyerror (char *msg)
+static void
+yyerror (const char *msg)
 {
-  if (prev_lexptr)
-    lexptr = prev_lexptr;
+  if (pstate->prev_lexptr)
+    pstate->lexptr = pstate->prev_lexptr;
 
-  error (_("A %s in expression, near `%s'."), (msg ? msg : "error"), lexptr);
+  error (_("A %s in expression, near `%s'."), msg, pstate->lexptr);
 }