]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blobdiff - gdb/tui/tui-win.c
Copyright year update in most files of the GDB Project.
[thirdparty/binutils-gdb.git] / gdb / tui / tui-win.c
index 443172d4085507baea049c176fbe54c0645a8145..0a49697d69e7a9ee944184eee57154837bcc945d 100644 (file)
@@ -1,7 +1,6 @@
 /* TUI window generic functions.
 
-   Copyright 1998, 1999, 2000, 2001, 2002, 2003, 2004 Free Software
-   Foundation, Inc.
+   Copyright (C) 1998-2004, 2006-2012 Free Software Foundation, Inc.
 
    Contributed by Hewlett-Packard Company.
 
@@ -9,7 +8,7 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
 
    This program is distributed in the hope that it will be useful,
@@ -18,9 +17,7 @@
    GNU General Public License for more details.
 
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place - Suite 330,
-   Boston, MA 02111-1307, USA.  */
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 /* This module contains procedures for handling tui window functions
    like resize, scrolling, scrolling, changing focus, etc.
@@ -45,6 +42,7 @@
 #include "tui/tui-source.h"
 #include "tui/tui-winsource.h"
 #include "tui/tui-windata.h"
+#include "tui/tui-win.h"
 
 #include "gdb_curses.h"
 
 #include <ctype.h>
 #include "readline/readline.h"
 
+#include <signal.h>
+
 /*******************************
 ** Static Local Decls
 ********************************/
 static void make_visible_with_new_height (struct tui_win_info *);
-static void make_invisible_and_set_new_height (struct tui_win_info *, int);
-static enum tui_status tui_adjust_win_heights (struct tui_win_info *, int);
+static void make_invisible_and_set_new_height (struct tui_win_info *, 
+                                              int);
+static enum tui_status tui_adjust_win_heights (struct tui_win_info *, 
+                                              int);
 static int new_height_ok (struct tui_win_info *, int);
 static void tui_set_tab_width_command (char *, int);
 static void tui_refresh_all_command (char *, int);
@@ -69,15 +71,17 @@ static void tui_scroll_forward_command (char *, int);
 static void tui_scroll_backward_command (char *, int);
 static void tui_scroll_left_command (char *, int);
 static void tui_scroll_right_command (char *, int);
-static void parse_scrolling_args (char *, struct tui_win_info * *, int *);
+static void parse_scrolling_args (char *, 
+                                 struct tui_win_info **, 
+                                 int *);
 
 
 /***************************************
 ** DEFINITIONS
 ***************************************/
-#define WIN_HEIGHT_USAGE      "Usage: winheight <win_name> [+ | -] <#lines>\n"
-#define XDBWIN_HEIGHT_USAGE   "Usage: w <#lines>\n"
-#define FOCUS_USAGE           "Usage: focus {<win> | next | prev}\n"
+#define WIN_HEIGHT_USAGE    "Usage: winheight <win_name> [+ | -] <#lines>\n"
+#define XDBWIN_HEIGHT_USAGE "Usage: w <#lines>\n"
+#define FOCUS_USAGE         "Usage: focus {<win> | next | prev}\n"
 
 /***************************************
 ** PUBLIC FUNCTIONS
@@ -198,11 +202,43 @@ struct tui_translate tui_border_kind_translate_lrcorner[] = {
 
 /* Tui configuration variables controlled with set/show command.  */
 const char *tui_active_border_mode = "bold-standout";
+static void
+show_tui_active_border_mode (struct ui_file *file,
+                            int from_tty,
+                            struct cmd_list_element *c, 
+                            const char *value)
+{
+  fprintf_filtered (file, _("\
+The attribute mode to use for the active TUI window border is \"%s\".\n"),
+                   value);
+}
+
 const char *tui_border_mode = "normal";
+static void
+show_tui_border_mode (struct ui_file *file, 
+                     int from_tty,
+                     struct cmd_list_element *c, 
+                     const char *value)
+{
+  fprintf_filtered (file, _("\
+The attribute mode to use for the TUI window borders is \"%s\".\n"),
+                   value);
+}
+
 const char *tui_border_kind = "acs";
+static void
+show_tui_border_kind (struct ui_file *file, 
+                     int from_tty,
+                     struct cmd_list_element *c, 
+                     const char *value)
+{
+  fprintf_filtered (file, _("The kind of border for TUI windows is \"%s\".\n"),
+                   value);
+}
 
-/* Tui internal configuration variables.  These variables are
-   updated by tui_update_variables to reflect the tui configuration
+
+/* Tui internal configuration variables.  These variables are updated
+   by tui_update_variables to reflect the tui configuration
    variables.  */
 chtype tui_border_vline;
 chtype tui_border_hline;
@@ -295,8 +331,8 @@ static struct cmd_list_element *tuilist;
 static void
 tui_command (char *args, int from_tty)
 {
-  printf_unfiltered ("\"tui\" must be followed by the name of a "
-                     "tui command.\n");
+  printf_unfiltered (_("\"tui\" must be followed by the name of a "
+                     "tui command.\n"));
   help_list (tuilist, "tui ", -1, gdb_stdout);
 }
 
@@ -305,111 +341,122 @@ tui_get_cmd_list (void)
 {
   if (tuilist == 0)
     add_prefix_cmd ("tui", class_tui, tui_command,
-                    "Text User Interface commands.",
+                    _("Text User Interface commands."),
                     &tuilist, "tui ", 0, &cmdlist);
   return &tuilist;
 }
 
-/* Function to initialize gdb commands, for tui window manipulation.  */
+/* Function to initialize gdb commands, for tui window
+   manipulation.  */
+
+/* Provide a prototype to silence -Wmissing-prototypes.  */
+extern initialize_file_ftype _initialize_tui_win;
+
 void
 _initialize_tui_win (void)
 {
-  struct cmd_list_element *c;
   static struct cmd_list_element *tui_setlist;
   static struct cmd_list_element *tui_showlist;
 
   /* Define the classes of commands.
      They will appear in the help list in the reverse of this order.  */
   add_prefix_cmd ("tui", class_tui, set_tui_cmd,
-                  "TUI configuration variables",
+                  _("TUI configuration variables"),
                  &tui_setlist, "set tui ",
-                 0/*allow-unknown*/, &setlist);
+                 0 /* allow-unknown */, &setlist);
   add_prefix_cmd ("tui", class_tui, show_tui_cmd,
-                  "TUI configuration variables",
+                  _("TUI configuration variables"),
                  &tui_showlist, "show tui ",
-                 0/*allow-unknown*/, &showlist);
+                 0 /* allow-unknown */, &showlist);
 
   add_com ("refresh", class_tui, tui_refresh_all_command,
-           "Refresh the terminal display.\n");
+           _("Refresh the terminal display.\n"));
   if (xdb_commands)
     add_com_alias ("U", "refresh", class_tui, 0);
-  add_com ("tabset", class_tui, tui_set_tab_width_command,
-           "Set the width (in characters) of tab stops.\n\
-Usage: tabset <n>\n");
-  add_com ("winheight", class_tui, tui_set_win_height_command,
-           "Set the height of a specified window.\n\
+  add_com ("tabset", class_tui, tui_set_tab_width_command, _("\
+Set the width (in characters) of tab stops.\n\
+Usage: tabset <n>\n"));
+  add_com ("winheight", class_tui, tui_set_win_height_command, _("\
+Set the height of a specified window.\n\
 Usage: winheight <win_name> [+ | -] <#lines>\n\
 Window names are:\n\
 src  : the source window\n\
 cmd  : the command window\n\
 asm  : the disassembly window\n\
-regs : the register display\n");
+regs : the register display\n"));
   add_com_alias ("wh", "winheight", class_tui, 0);
   add_info ("win", tui_all_windows_info,
-            "List of all displayed windows.\n");
-  add_com ("focus", class_tui, tui_set_focus_command,
-           "Set focus to named window or next/prev window.\n\
+           _("List of all displayed windows.\n"));
+  add_com ("focus", class_tui, tui_set_focus_command, _("\
+Set focus to named window or next/prev window.\n\
 Usage: focus {<win> | next | prev}\n\
 Valid Window names are:\n\
 src  : the source window\n\
 asm  : the disassembly window\n\
 regs : the register display\n\
-cmd  : the command window\n");
+cmd  : the command window\n"));
   add_com_alias ("fs", "focus", class_tui, 0);
-  add_com ("+", class_tui, tui_scroll_forward_command,
-           "Scroll window forward.\nUsage: + [win] [n]\n");
-  add_com ("-", class_tui, tui_scroll_backward_command,
-           "Scroll window backward.\nUsage: - [win] [n]\n");
-  add_com ("<", class_tui, tui_scroll_left_command,
-           "Scroll window forward.\nUsage: < [win] [n]\n");
-  add_com (">", class_tui, tui_scroll_right_command,
-           "Scroll window backward.\nUsage: > [win] [n]\n");
+  add_com ("+", class_tui, tui_scroll_forward_command, _("\
+Scroll window forward.\n\
+Usage: + [win] [n]\n"));
+  add_com ("-", class_tui, tui_scroll_backward_command, _("\
+Scroll window backward.\n\
+Usage: - [win] [n]\n"));
+  add_com ("<", class_tui, tui_scroll_left_command, _("\
+Scroll window forward.\n\
+Usage: < [win] [n]\n"));
+  add_com (">", class_tui, tui_scroll_right_command, _("\
+Scroll window backward.\n\
+Usage: > [win] [n]\n"));
   if (xdb_commands)
-    add_com ("w", class_xdb, tui_xdb_set_win_height_command,
-             "XDB compatibility command for setting the height of a command window.\n\
-Usage: w <#lines>\n");
+    add_com ("w", class_xdb, tui_xdb_set_win_height_command, _("\
+XDB compatibility command for setting the height of a command window.\n\
+Usage: w <#lines>\n"));
 
   /* Define the tui control variables.  */
-  c = add_set_enum_cmd
-    ("border-kind", no_class,
-     tui_border_kind_enums, &tui_border_kind,
-     "Set the kind of border for TUI windows.\n"
-     "This variable controls the border of TUI windows:\n"
-     "space           use a white space\n"
-     "ascii           use ascii characters + - | for the border\n"
-     "acs             use the Alternate Character Set\n",
-     &tui_setlist);
-  deprecated_add_show_from_set (c, &tui_showlist);
-
-  c = add_set_enum_cmd
-    ("border-mode", no_class,
-     tui_border_mode_enums, &tui_border_mode,
-     "Set the attribute mode to use for the TUI window borders.\n"
-     "This variable controls the attributes to use for the window borders:\n"
-     "normal          normal display\n"
-     "standout        use highlight mode of terminal\n"
-     "reverse         use reverse video mode\n"
-     "half            use half bright\n"
-     "half-standout   use half bright and standout mode\n"
-     "bold            use extra bright or bold\n"
-     "bold-standout   use extra bright or bold with standout mode\n",
-     &tui_setlist);
-  deprecated_add_show_from_set (c, &tui_showlist);
-
-  c = add_set_enum_cmd
-    ("active-border-mode", no_class,
-     tui_border_mode_enums, &tui_active_border_mode,
-     "Set the attribute mode to use for the active TUI window border.\n"
-     "This variable controls the attributes to use for the active window border:\n"
-     "normal          normal display\n"
-     "standout        use highlight mode of terminal\n"
-     "reverse         use reverse video mode\n"
-     "half            use half bright\n"
-     "half-standout   use half bright and standout mode\n"
-     "bold            use extra bright or bold\n"
-     "bold-standout   use extra bright or bold with standout mode\n",
-     &tui_setlist);
-  deprecated_add_show_from_set (c, &tui_showlist);
+  add_setshow_enum_cmd ("border-kind", no_class, tui_border_kind_enums,
+                       &tui_border_kind, _("\
+Set the kind of border for TUI windows."), _("\
+Show the kind of border for TUI windows."), _("\
+This variable controls the border of TUI windows:\n\
+space           use a white space\n\
+ascii           use ascii characters + - | for the border\n\
+acs             use the Alternate Character Set"),
+                       NULL,
+                       show_tui_border_kind,
+                       &tui_setlist, &tui_showlist);
+
+  add_setshow_enum_cmd ("border-mode", no_class, tui_border_mode_enums,
+                       &tui_border_mode, _("\
+Set the attribute mode to use for the TUI window borders."), _("\
+Show the attribute mode to use for the TUI window borders."), _("\
+This variable controls the attributes to use for the window borders:\n\
+normal          normal display\n\
+standout        use highlight mode of terminal\n\
+reverse         use reverse video mode\n\
+half            use half bright\n\
+half-standout   use half bright and standout mode\n\
+bold            use extra bright or bold\n\
+bold-standout   use extra bright or bold with standout mode"),
+                       NULL,
+                       show_tui_border_mode,
+                       &tui_setlist, &tui_showlist);
+
+  add_setshow_enum_cmd ("active-border-mode", no_class, tui_border_mode_enums,
+                       &tui_active_border_mode, _("\
+Set the attribute mode to use for the active TUI window border."), _("\
+Show the attribute mode to use for the active TUI window border."), _("\
+This variable controls the attributes to use for the active window border:\n\
+normal          normal display\n\
+standout        use highlight mode of terminal\n\
+reverse         use reverse video mode\n\
+half            use half bright\n\
+half-standout   use half bright and standout mode\n\
+bold            use extra bright or bold\n\
+bold-standout   use extra bright or bold with standout mode"),
+                       NULL,
+                       show_tui_active_border_mode,
+                       &tui_setlist, &tui_showlist);
 }
 
 /* Update gdb's knowledge of the terminal size.  */
@@ -417,26 +464,24 @@ void
 tui_update_gdb_sizes (void)
 {
   char cmd[50];
-  int screenheight, screenwidth;
 
-  rl_get_screen_size (&screenheight, &screenwidth);
   /* Set to TUI command window dimension or use readline values.  */
   sprintf (cmd, "set width %d",
-           tui_active ? TUI_CMD_WIN->generic.width : screenwidth);
+           tui_active ? TUI_CMD_WIN->generic.width : tui_term_width());
   execute_command (cmd, 0);
   sprintf (cmd, "set height %d",
-           tui_active ? TUI_CMD_WIN->generic.height : screenheight);
+           tui_active ? TUI_CMD_WIN->generic.height : tui_term_height());
   execute_command (cmd, 0);
 }
 
 
-/* Set the logical focus to win_info.    */
+/* Set the logical focus to win_info.  */
 void
-tui_set_win_focus_to (struct tui_win_info * win_info)
+tui_set_win_focus_to (struct tui_win_info *win_info)
 {
   if (win_info != NULL)
     {
-      struct tui_win_info * win_with_focus = tui_win_with_focus ();
+      struct tui_win_info *win_with_focus = tui_win_with_focus ();
 
       if (win_with_focus != NULL
          && win_with_focus->generic.type != CMD_WIN)
@@ -449,7 +494,8 @@ tui_set_win_focus_to (struct tui_win_info * win_info)
 
 
 void
-tui_scroll_forward (struct tui_win_info * win_to_scroll, int num_to_scroll)
+tui_scroll_forward (struct tui_win_info *win_to_scroll, 
+                   int num_to_scroll)
 {
   if (win_to_scroll != TUI_CMD_WIN)
     {
@@ -457,12 +503,12 @@ tui_scroll_forward (struct tui_win_info * win_to_scroll, int num_to_scroll)
 
       if (num_to_scroll == 0)
        _num_to_scroll = win_to_scroll->generic.height - 3;
-      /*
-         ** If we are scrolling the source or disassembly window, do a
-         ** "psuedo" scroll since not all of the source is in memory,
-         ** only what is in the viewport.  If win_to_scroll is the
-         ** command window do nothing since the term should handle it.
-       */
+
+      /* If we are scrolling the source or disassembly window, do a
+         "psuedo" scroll since not all of the source is in memory,
+         only what is in the viewport.  If win_to_scroll is the
+         command window do nothing since the term should handle
+         it.  */
       if (win_to_scroll == TUI_SRC_WIN)
        tui_vertical_source_scroll (FORWARD_SCROLL, _num_to_scroll);
       else if (win_to_scroll == TUI_DISASM_WIN)
@@ -473,7 +519,8 @@ tui_scroll_forward (struct tui_win_info * win_to_scroll, int num_to_scroll)
 }
 
 void
-tui_scroll_backward (struct tui_win_info * win_to_scroll, int num_to_scroll)
+tui_scroll_backward (struct tui_win_info *win_to_scroll, 
+                    int num_to_scroll)
 {
   if (win_to_scroll != TUI_CMD_WIN)
     {
@@ -481,12 +528,12 @@ tui_scroll_backward (struct tui_win_info * win_to_scroll, int num_to_scroll)
 
       if (num_to_scroll == 0)
        _num_to_scroll = win_to_scroll->generic.height - 3;
-      /*
-         ** If we are scrolling the source or disassembly window, do a
-         ** "psuedo" scroll since not all of the source is in memory,
-         ** only what is in the viewport.  If win_to_scroll is the
-         ** command window do nothing since the term should handle it.
-       */
+
+      /* If we are scrolling the source or disassembly window, do a
+         "psuedo" scroll since not all of the source is in memory,
+         only what is in the viewport.  If win_to_scroll is the
+         command window do nothing since the term should handle
+         it.  */
       if (win_to_scroll == TUI_SRC_WIN)
        tui_vertical_source_scroll (BACKWARD_SCROLL, _num_to_scroll);
       else if (win_to_scroll == TUI_DISASM_WIN)
@@ -498,7 +545,8 @@ tui_scroll_backward (struct tui_win_info * win_to_scroll, int num_to_scroll)
 
 
 void
-tui_scroll_left (struct tui_win_info * win_to_scroll, int num_to_scroll)
+tui_scroll_left (struct tui_win_info *win_to_scroll,
+                int num_to_scroll)
 {
   if (win_to_scroll != TUI_CMD_WIN)
     {
@@ -506,20 +554,22 @@ tui_scroll_left (struct tui_win_info * win_to_scroll, int num_to_scroll)
 
       if (_num_to_scroll == 0)
        _num_to_scroll = 1;
-      /*
-         ** If we are scrolling the source or disassembly window, do a
-         ** "psuedo" scroll since not all of the source is in memory,
-         ** only what is in the viewport. If win_to_scroll is the
-         ** command window do nothing since the term should handle it.
-       */
-      if (win_to_scroll == TUI_SRC_WIN || win_to_scroll == TUI_DISASM_WIN)
-       tui_horizontal_source_scroll (win_to_scroll, LEFT_SCROLL, _num_to_scroll);
+
+      /* If we are scrolling the source or disassembly window, do a
+         "psuedo" scroll since not all of the source is in memory,
+         only what is in the viewport. If win_to_scroll is the command
+         window do nothing since the term should handle it.  */
+      if (win_to_scroll == TUI_SRC_WIN
+         || win_to_scroll == TUI_DISASM_WIN)
+       tui_horizontal_source_scroll (win_to_scroll, LEFT_SCROLL,
+                                     _num_to_scroll);
     }
 }
 
 
 void
-tui_scroll_right (struct tui_win_info * win_to_scroll, int num_to_scroll)
+tui_scroll_right (struct tui_win_info *win_to_scroll, 
+                 int num_to_scroll)
 {
   if (win_to_scroll != TUI_CMD_WIN)
     {
@@ -527,22 +577,23 @@ tui_scroll_right (struct tui_win_info * win_to_scroll, int num_to_scroll)
 
       if (_num_to_scroll == 0)
        _num_to_scroll = 1;
-      /*
-         ** If we are scrolling the source or disassembly window, do a
-         ** "psuedo" scroll since not all of the source is in memory,
-         ** only what is in the viewport. If win_to_scroll is the
-         ** command window do nothing since the term should handle it.
-       */
-      if (win_to_scroll == TUI_SRC_WIN || win_to_scroll == TUI_DISASM_WIN)
-       tui_horizontal_source_scroll (win_to_scroll, RIGHT_SCROLL, _num_to_scroll);
+
+      /* If we are scrolling the source or disassembly window, do a
+         "psuedo" scroll since not all of the source is in memory,
+         only what is in the viewport. If win_to_scroll is the command
+         window do nothing since the term should handle it.  */
+      if (win_to_scroll == TUI_SRC_WIN
+         || win_to_scroll == TUI_DISASM_WIN)
+       tui_horizontal_source_scroll (win_to_scroll, RIGHT_SCROLL,
+                                     _num_to_scroll);
     }
 }
 
 
-/* Scroll a window.  Arguments are passed through a va_list.    */
+/* Scroll a window.  Arguments are passed through a va_list.  */
 void
 tui_scroll (enum tui_scroll_direction direction,
-           struct tui_win_info * win_to_scroll,
+           struct tui_win_info *win_to_scroll,
            int num_to_scroll)
 {
   switch (direction)
@@ -574,7 +625,8 @@ tui_refresh_all_win (void)
   tui_refresh_all (tui_win_list);
   for (type = SRC_WIN; type < MAX_MAJOR_WINDOWS; type++)
     {
-      if (tui_win_list[type] && tui_win_list[type]->generic.is_visible)
+      if (tui_win_list[type] 
+         && tui_win_list[type]->generic.is_visible)
        {
          switch (type)
            {
@@ -597,8 +649,8 @@ tui_refresh_all_win (void)
 }
 
 
-/* Resize all the windows based on the the terminal size.  This
-   function gets called from within the readline sinwinch handler.  */
+/* Resize all the windows based on the terminal size.  This function
+   gets called from within the readline sinwinch handler.  */
 void
 tui_resize_all (void)
 {
@@ -611,24 +663,25 @@ tui_resize_all (void)
   if (height_diff || width_diff)
     {
       enum tui_layout_type cur_layout = tui_current_layout ();
-      struct tui_win_info * win_with_focus = tui_win_with_focus ();
+      struct tui_win_info *win_with_focus = tui_win_with_focus ();
       struct tui_win_info *first_win;
       struct tui_win_info *second_win;
-      struct tui_gen_win_info * locator = tui_locator_win_info_ptr ();
+      struct tui_gen_win_info *locator = tui_locator_win_info_ptr ();
       enum tui_win_type win_type;
       int new_height, split_diff, cmd_split_diff, num_wins_displayed = 2;
 
 #ifdef HAVE_RESIZE_TERM
       resize_term (screenheight, screenwidth);
 #endif      
-      /* turn keypad off while we resize */
+      /* Turn keypad off while we resize.  */
       if (win_with_focus != TUI_CMD_WIN)
        keypad (TUI_CMD_WIN->generic.handle, FALSE);
       tui_update_gdb_sizes ();
       tui_set_term_height_to (screenheight);
       tui_set_term_width_to (screenwidth);
-      if (cur_layout == SRC_DISASSEM_COMMAND ||
-       cur_layout == SRC_DATA_COMMAND || cur_layout == DISASSEM_DATA_COMMAND)
+      if (cur_layout == SRC_DISASSEM_COMMAND 
+         || cur_layout == SRC_DATA_COMMAND
+         || cur_layout == DISASSEM_DATA_COMMAND)
        num_wins_displayed++;
       split_diff = height_diff / num_wins_displayed;
       cmd_split_diff = split_diff;
@@ -639,7 +692,7 @@ tui_resize_all (void)
          else
            cmd_split_diff++;
        }
-      /* now adjust each window */
+      /* Now adjust each window.  */
       clear ();
       refresh ();
       switch (cur_layout)
@@ -649,7 +702,7 @@ tui_resize_all (void)
          first_win = (struct tui_win_info *) (tui_source_windows ())->list[0];
          first_win->generic.width += width_diff;
          locator->width += width_diff;
-         /* check for invalid heights */
+         /* Check for invalid heights.  */
          if (height_diff == 0)
            new_height = first_win->generic.height;
          else if ((first_win->generic.height + split_diff) >=
@@ -660,6 +713,7 @@ tui_resize_all (void)
          else
            new_height = first_win->generic.height + split_diff;
 
+         locator->origin.y = new_height + 1;
          make_invisible_and_set_new_height (first_win, new_height);
          TUI_CMD_WIN->generic.origin.y = locator->origin.y + 1;
          TUI_CMD_WIN->generic.width += width_diff;
@@ -682,11 +736,12 @@ tui_resize_all (void)
            {
              first_win = TUI_DATA_WIN;
              first_win->generic.width += width_diff;
-             second_win = (struct tui_win_info *) (tui_source_windows ())->list[0];
+             second_win = (struct tui_win_info *)
+               (tui_source_windows ())->list[0];
              second_win->generic.width += width_diff;
            }
-         /* Change the first window's height/width */
-         /* check for invalid heights */
+         /* Change the first window's height/width */
+         /* Check for invalid heights.  */
          if (height_diff == 0)
            new_height = first_win->generic.height;
          else if ((first_win->generic.height +
@@ -701,8 +756,8 @@ tui_resize_all (void)
 
          locator->width += width_diff;
 
-         /* Change the second window's height/width */
-         /* check for invalid heights */
+         /* Change the second window's height/width */
+         /* Check for invalid heights.  */
          if (height_diff == 0)
            new_height = second_win->generic.height;
          else if ((first_win->generic.height +
@@ -722,10 +777,11 @@ tui_resize_all (void)
          second_win->generic.origin.y = first_win->generic.height - 1;
          make_invisible_and_set_new_height (second_win, new_height);
 
-         /* Change the command window's height/width */
+         /* Change the command window's height/width */
          TUI_CMD_WIN->generic.origin.y = locator->origin.y + 1;
-         make_invisible_and_set_new_height (
-                            TUI_CMD_WIN, TUI_CMD_WIN->generic.height + cmd_split_diff);
+         make_invisible_and_set_new_height (TUI_CMD_WIN,
+                                            TUI_CMD_WIN->generic.height
+                                            + cmd_split_diff);
          make_visible_with_new_height (first_win);
          make_visible_with_new_height (second_win);
          make_visible_with_new_height (TUI_CMD_WIN);
@@ -735,40 +791,54 @@ tui_resize_all (void)
            tui_erase_source_content (second_win, EMPTY_SOURCE_PROMPT);
          break;
        }
-      /*
-         ** Now remove all invisible windows, and their content so that they get
-         ** created again when called for with the new size
-       */
+      /* Now remove all invisible windows, and their content so that
+         they get created again when called for with the new size.  */
       for (win_type = SRC_WIN; (win_type < MAX_MAJOR_WINDOWS); win_type++)
        {
-         if (win_type != CMD_WIN && (tui_win_list[win_type] != NULL)
+         if (win_type != CMD_WIN 
+             && (tui_win_list[win_type] != NULL)
              && !tui_win_list[win_type]->generic.is_visible)
            {
              tui_free_window (tui_win_list[win_type]);
              tui_win_list[win_type] = (struct tui_win_info *) NULL;
            }
        }
-      tui_set_win_resized_to (TRUE);
-      /* turn keypad back on, unless focus is in the command window */
+      /* Turn keypad back on, unless focus is in the command
+        window.  */
       if (win_with_focus != TUI_CMD_WIN)
        keypad (TUI_CMD_WIN->generic.handle, TRUE);
     }
 }
 
-
+#ifdef SIGWINCH
 /* SIGWINCH signal handler for the tui.  This signal handler is always
    called, even when the readline package clears signals because it is
    set as the old_sigwinch() (TUI only).  */
-void
+static void
 tui_sigwinch_handler (int signal)
 {
-  /*
-     ** Say that a resize was done so that the readline can do it
-     ** later when appropriate.
-   */
+  /* Say that a resize was done so that the readline can do it later
+     when appropriate.  */
   tui_set_win_resized_to (TRUE);
 }
+#endif
 
+/* Initializes SIGWINCH signal handler for the tui.  */
+void
+tui_initialize_win (void)
+{
+#ifdef SIGWINCH
+#ifdef HAVE_SIGACTION
+  struct sigaction old_winch;
+
+  memset (&old_winch, 0, sizeof (old_winch));
+  old_winch.sa_handler = &tui_sigwinch_handler;
+  sigaction (SIGWINCH, &old_winch, NULL);
+#else
+  signal (SIGWINCH, &tui_sigwinch_handler);
+#endif
+#endif
+}
 
 
 /*************************
@@ -780,7 +850,7 @@ static void
 tui_scroll_forward_command (char *arg, int from_tty)
 {
   int num_to_scroll = 1;
-  struct tui_win_info * win_to_scroll;
+  struct tui_win_info *win_to_scroll;
 
   /* Make sure the curses mode is enabled.  */
   tui_enable ();
@@ -796,7 +866,7 @@ static void
 tui_scroll_backward_command (char *arg, int from_tty)
 {
   int num_to_scroll = 1;
-  struct tui_win_info * win_to_scroll;
+  struct tui_win_info *win_to_scroll;
 
   /* Make sure the curses mode is enabled.  */
   tui_enable ();
@@ -812,7 +882,7 @@ static void
 tui_scroll_left_command (char *arg, int from_tty)
 {
   int num_to_scroll;
-  struct tui_win_info * win_to_scroll;
+  struct tui_win_info *win_to_scroll;
 
   /* Make sure the curses mode is enabled.  */
   tui_enable ();
@@ -825,7 +895,7 @@ static void
 tui_scroll_right_command (char *arg, int from_tty)
 {
   int num_to_scroll;
-  struct tui_win_info * win_to_scroll;
+  struct tui_win_info *win_to_scroll;
 
   /* Make sure the curses mode is enabled.  */
   tui_enable ();
@@ -842,7 +912,7 @@ tui_set_focus (char *arg, int from_tty)
     {
       char *buf_ptr = (char *) xstrdup (arg);
       int i;
-      struct tui_win_info * win_info = (struct tui_win_info *) NULL;
+      struct tui_win_info *win_info = (struct tui_win_info *) NULL;
 
       for (i = 0; (i < strlen (buf_ptr)); i++)
        buf_ptr[i] = toupper (arg[i]);
@@ -854,7 +924,8 @@ tui_set_focus (char *arg, int from_tty)
       else
        win_info = tui_partial_win_by_name (buf_ptr);
 
-      if (win_info == (struct tui_win_info *) NULL || !win_info->generic.is_visible)
+      if (win_info == (struct tui_win_info *) NULL
+         || !win_info->generic.is_visible)
        warning (_("Invalid window specified. \n\
 The window name specified must be valid and visible.\n"));
       else
@@ -866,8 +937,9 @@ The window name specified must be valid and visible.\n"));
       if (TUI_DATA_WIN && TUI_DATA_WIN->generic.is_visible)
        tui_refresh_data_win ();
       xfree (buf_ptr);
-      printf_filtered ("Focus set to %s window.\n",
-                      tui_win_name ((struct tui_gen_win_info *) tui_win_with_focus ()));
+      printf_filtered (_("Focus set to %s window.\n"),
+                      tui_win_name ((struct tui_gen_win_info *)
+                                    tui_win_with_focus ()));
     }
   else
     warning (_("Incorrect Number of Arguments.\n%s"), FOCUS_USAGE);
@@ -886,10 +958,11 @@ static void
 tui_all_windows_info (char *arg, int from_tty)
 {
   enum tui_win_type type;
-  struct tui_win_info * win_with_focus = tui_win_with_focus ();
+  struct tui_win_info *win_with_focus = tui_win_with_focus ();
 
   for (type = SRC_WIN; (type < MAX_MAJOR_WINDOWS); type++)
-    if (tui_win_list[type] && tui_win_list[type]->generic.is_visible)
+    if (tui_win_list[type] 
+       && tui_win_list[type]->generic.is_visible)
       {
        if (win_with_focus == tui_win_list[type])
          printf_filtered ("        %s\t(%d lines)  <has focus>\n",
@@ -913,7 +986,7 @@ tui_refresh_all_command (char *arg, int from_tty)
 }
 
 
-/* Set the height of the specified window.   */
+/* Set the height of the specified window.  */
 static void
 tui_set_tab_width_command (char *arg, int from_tty)
 {
@@ -932,7 +1005,7 @@ tui_set_tab_width_command (char *arg, int from_tty)
 }
 
 
-/* Set the height of the specified window.   */
+/* Set the height of the specified window.  */
 static void
 tui_set_win_height (char *arg, int from_tty)
 {
@@ -944,7 +1017,7 @@ tui_set_win_height (char *arg, int from_tty)
       char *buf_ptr = buf;
       char *wname = (char *) NULL;
       int new_height, i;
-      struct tui_win_info * win_info;
+      struct tui_win_info *win_info;
 
       wname = buf_ptr;
       buf_ptr = strchr (buf_ptr, ' ');
@@ -952,19 +1025,18 @@ tui_set_win_height (char *arg, int from_tty)
        {
          *buf_ptr = (char) 0;
 
-         /*
-            ** Validate the window name
-          */
+         /* Validate the window name.  */
          for (i = 0; i < strlen (wname); i++)
            wname[i] = toupper (wname[i]);
          win_info = tui_partial_win_by_name (wname);
 
-         if (win_info == (struct tui_win_info *) NULL || !win_info->generic.is_visible)
+         if (win_info == (struct tui_win_info *) NULL
+             || !win_info->generic.is_visible)
            warning (_("Invalid window specified. \n\
 The window name specified must be valid and visible.\n"));
          else
            {
-             /* Process the size */
+             /* Process the size */
              while (*(++buf_ptr) == ' ')
                ;
 
@@ -990,10 +1062,9 @@ The window name specified must be valid and visible.\n"));
                        new_height = input_no;
                      else
                        new_height = win_info->generic.height + input_no;
-                     /*
-                        ** Now change the window's height, and adjust all
-                        ** other windows around it
-                      */
+
+                     /* Now change the window's height, and adjust
+                        all other windows around it.  */
                      if (tui_adjust_win_heights (win_info,
                                                new_height) == TUI_FAILURE)
                        warning (_("Invalid window height specified.\n%s"),
@@ -1017,7 +1088,7 @@ The window name specified must be valid and visible.\n"));
     printf_filtered (WIN_HEIGHT_USAGE);
 }
 
-/* Set the height of the specified window, with va_list.    */
+/* Set the height of the specified window, with va_list.  */
 static void
 tui_set_win_height_command (char *arg, int from_tty)
 {
@@ -1028,7 +1099,8 @@ tui_set_win_height_command (char *arg, int from_tty)
 
 
 /* XDB Compatibility command for setting the window height.  This will
-   increase or decrease the command window by the specified amount.  */
+   increase or decrease the command window by the specified
+   amount.  */
 static void
 tui_xdb_set_win_height (char *arg, int from_tty)
 {
@@ -1039,12 +1111,12 @@ tui_xdb_set_win_height (char *arg, int from_tty)
       int input_no = atoi (arg);
 
       if (input_no > 0)
-       {                       /* Add 1 for the locator */
+       {                       /* Add 1 for the locator */
          int new_height = tui_term_height () - (input_no + 1);
 
-         if (!new_height_ok (tui_win_list[CMD_WIN], new_height) ||
-             tui_adjust_win_heights (tui_win_list[CMD_WIN],
-                                   new_height) == TUI_FAILURE)
+         if (!new_height_ok (tui_win_list[CMD_WIN], new_height)
+             || tui_adjust_win_heights (tui_win_list[CMD_WIN],
+                                        new_height) == TUI_FAILURE)
            warning (_("Invalid window height specified.\n%s"),
                     XDBWIN_HEIGHT_USAGE);
        }
@@ -1066,7 +1138,8 @@ tui_xdb_set_win_height_command (char *arg, int from_tty)
 
 /* Function to adjust all window heights around the primary.   */
 static enum tui_status
-tui_adjust_win_heights (struct tui_win_info * primary_win_info, int new_height)
+tui_adjust_win_heights (struct tui_win_info *primary_win_info,
+                       int new_height)
 {
   enum tui_status status = TUI_FAILURE;
 
@@ -1076,19 +1149,20 @@ tui_adjust_win_heights (struct tui_win_info * primary_win_info, int new_height)
       if (new_height != primary_win_info->generic.height)
        {
          int diff;
-         struct tui_win_info * win_info;
-         struct tui_gen_win_info * locator = tui_locator_win_info_ptr ();
+         struct tui_win_info *win_info;
+         struct tui_gen_win_info *locator = tui_locator_win_info_ptr ();
          enum tui_layout_type cur_layout = tui_current_layout ();
 
          diff = (new_height - primary_win_info->generic.height) * (-1);
-         if (cur_layout == SRC_COMMAND || cur_layout == DISASSEM_COMMAND)
+         if (cur_layout == SRC_COMMAND 
+             || cur_layout == DISASSEM_COMMAND)
            {
-             struct tui_win_info * src_win_info;
+             struct tui_win_info *src_win_info;
 
              make_invisible_and_set_new_height (primary_win_info, new_height);
              if (primary_win_info->generic.type == CMD_WIN)
                {
-                 win_info = (struct tui_win_info *) (tui_source_windows ())->list[0];
+                 win_info = (tui_source_windows ())->list[0];
                  src_win_info = win_info;
                }
              else
@@ -1117,14 +1191,13 @@ tui_adjust_win_heights (struct tui_win_info * primary_win_info, int new_height)
              else
                {
                  first_win = TUI_DATA_WIN;
-                 second_win = (struct tui_win_info *) (tui_source_windows ())->list[0];
+                 second_win = (tui_source_windows ())->list[0];
                }
              if (primary_win_info == TUI_CMD_WIN)
-               {               /*
-                                  ** Split the change in height accross the 1st & 2nd windows
-                                  ** adjusting them as well.
-                                */
-                 int first_split_diff = diff / 2;      /* subtract the locator */
+               { /* Split the change in height accross the 1st & 2nd
+                    windows, adjusting them as well.  */
+                 /* Subtract the locator.  */
+                 int first_split_diff = diff / 2;
                  int second_split_diff = first_split_diff;
 
                  if (diff % 2)
@@ -1143,7 +1216,8 @@ tui_adjust_win_heights (struct tui_win_info * primary_win_info, int new_height)
                            second_split_diff++;
                        }
                    }
-                 /* make sure that the minimum hieghts are honored */
+                 /* Make sure that the minimum hieghts are
+                    honored.  */
                  while ((first_win->generic.height + first_split_diff) < 3)
                    {
                      first_split_diff++;
@@ -1158,21 +1232,22 @@ tui_adjust_win_heights (struct tui_win_info * primary_win_info, int new_height)
                                                  first_win,
                                 first_win->generic.height + first_split_diff);
                  second_win->generic.origin.y = first_win->generic.height - 1;
-                 make_invisible_and_set_new_height (
-                   second_win, second_win->generic.height + second_split_diff);
+                 make_invisible_and_set_new_height (second_win,
+                                                    second_win->generic.height
+                                                    + second_split_diff);
                  TUI_CMD_WIN->generic.origin.y = locator->origin.y + 1;
                  make_invisible_and_set_new_height (TUI_CMD_WIN, new_height);
                }
              else
                {
                  if ((TUI_CMD_WIN->generic.height + diff) < 1)
-                   {           /*
-                                  ** If there is no way to increase the command window
-                                  ** take real estate from the 1st or 2nd window.
-                                */
+                   { /* If there is no way to increase the command
+                        window take real estate from the 1st or 2nd
+                        window.  */
                      if ((TUI_CMD_WIN->generic.height + diff) < 1)
                        {
                          int i;
+
                          for (i = TUI_CMD_WIN->generic.height + diff;
                               (i < 1); i++)
                            if (primary_win_info == first_win)
@@ -1197,8 +1272,8 @@ tui_adjust_win_heights (struct tui_win_info * primary_win_info, int new_height)
                  if ((TUI_CMD_WIN->generic.height + diff) < 1)
                    make_invisible_and_set_new_height (TUI_CMD_WIN, 1);
                  else
-                   make_invisible_and_set_new_height (
-                                    TUI_CMD_WIN, TUI_CMD_WIN->generic.height + diff);
+                   make_invisible_and_set_new_height (TUI_CMD_WIN,
+                                                      TUI_CMD_WIN->generic.height + diff);
                }
              make_visible_with_new_height (TUI_CMD_WIN);
              make_visible_with_new_height (second_win);
@@ -1216,12 +1291,14 @@ tui_adjust_win_heights (struct tui_win_info * primary_win_info, int new_height)
 
 
 /* Function make the target window (and auxillary windows associated
-   with the targer) invisible, and set the new height and location.  */
+   with the targer) invisible, and set the new height and
+   location.  */
 static void
-make_invisible_and_set_new_height (struct tui_win_info * win_info, int height)
+make_invisible_and_set_new_height (struct tui_win_info *win_info, 
+                                  int height)
 {
   int i;
-  struct tui_gen_win_info * gen_win_info;
+  struct tui_gen_win_info *gen_win_info;
 
   tui_make_invisible (&win_info->generic);
   win_info->generic.height = height;
@@ -1232,7 +1309,7 @@ make_invisible_and_set_new_height (struct tui_win_info * win_info, int height)
   if (win_info != TUI_CMD_WIN)
     win_info->generic.viewport_height--;
 
-  /* Now deal with the auxillary windows associated with win_info */
+  /* Now deal with the auxillary windows associated with win_info */
   switch (win_info->generic.type)
     {
     case SRC_WIN:
@@ -1256,11 +1333,12 @@ make_invisible_and_set_new_height (struct tui_win_info * win_info, int height)
        }
       break;
     case DATA_WIN:
-      /* delete all data item windows */
+      /* Delete all data item windows.  */
       for (i = 0; i < win_info->generic.content_size; i++)
        {
-         gen_win_info = (struct tui_gen_win_info *) & ((struct tui_win_element *)
-                     win_info->generic.content[i])->which_element.data_window;
+         gen_win_info = (struct tui_gen_win_info *)
+           &((struct tui_win_element *)
+             win_info->generic.content[i])->which_element.data_window;
          tui_delete_win (gen_win_info->handle);
          gen_win_info->handle = (WINDOW *) NULL;
        }
@@ -1275,7 +1353,7 @@ make_invisible_and_set_new_height (struct tui_win_info * win_info, int height)
    re-creating the windows' content since the window had to be
    destroyed to be made invisible.  */
 static void
-make_visible_with_new_height (struct tui_win_info * win_info)
+make_visible_with_new_height (struct tui_win_info *win_info)
 {
   struct symtab *s;
 
@@ -1289,33 +1367,36 @@ make_visible_with_new_height (struct tui_win_info * win_info)
       tui_make_visible (win_info->detail.source_info.execution_info);
       if (win_info->generic.content != NULL)
        {
-         union tui_line_or_address line_or_addr;
+         struct gdbarch *gdbarch = win_info->detail.source_info.gdbarch;
+         struct tui_line_or_address line_or_addr;
          struct symtab_and_line cursal
            = get_current_source_symtab_and_line ();
 
-         if (win_info->generic.type == SRC_WIN)
-           line_or_addr.line_no =
-             win_info->detail.source_info.start_line_or_addr.line_no;
-         else
-           line_or_addr.addr =
-             win_info->detail.source_info.start_line_or_addr.addr;
+         line_or_addr = win_info->detail.source_info.start_line_or_addr;
          tui_free_win_content (&win_info->generic);
-         tui_update_source_window (win_info, cursal.symtab, line_or_addr, TRUE);
+         tui_update_source_window (win_info, gdbarch,
+                                   cursal.symtab, line_or_addr, TRUE);
        }
-      else if (deprecated_selected_frame != (struct frame_info *) NULL)
+      else if (deprecated_safe_get_selected_frame () != NULL)
        {
-         union tui_line_or_address line;
-         struct symtab_and_line cursal = get_current_source_symtab_and_line ();
-
+         struct tui_line_or_address line;
+         struct symtab_and_line cursal
+           = get_current_source_symtab_and_line ();
+         struct frame_info *frame = deprecated_safe_get_selected_frame ();
+         struct gdbarch *gdbarch = get_frame_arch (frame);
 
-         s = find_pc_symtab (get_frame_pc (deprecated_selected_frame));
+         s = find_pc_symtab (get_frame_pc (frame));
          if (win_info->generic.type == SRC_WIN)
-           line.line_no = cursal.line;
+           {
+             line.loa = LOA_LINE;
+             line.u.line_no = cursal.line;
+           }
          else
            {
-             find_line_pc (s, cursal.line, &line.addr);
+             line.loa = LOA_ADDRESS;
+             find_line_pc (s, cursal.line, &line.u.addr);
            }
-         tui_update_source_window (win_info, s, line, TRUE);
+         tui_update_source_window (win_info, gdbarch, s, line, TRUE);
        }
       if (tui_win_has_locator (win_info))
        {
@@ -1329,6 +1410,14 @@ make_visible_with_new_height (struct tui_win_info * win_info)
     case CMD_WIN:
       win_info->detail.command_info.cur_line = 0;
       win_info->detail.command_info.curch = 0;
+#ifdef HAVE_WRESIZE
+      wresize (TUI_CMD_WIN->generic.handle,
+              TUI_CMD_WIN->generic.height,
+              TUI_CMD_WIN->generic.width);
+#endif
+      mvwin (TUI_CMD_WIN->generic.handle,
+            TUI_CMD_WIN->generic.origin.y,
+            TUI_CMD_WIN->generic.origin.x);
       wmove (win_info->generic.handle,
             win_info->detail.command_info.cur_line,
             win_info->detail.command_info.curch);
@@ -1340,7 +1429,8 @@ make_visible_with_new_height (struct tui_win_info * win_info)
 
 
 static int
-new_height_ok (struct tui_win_info * primary_win_info, int new_height)
+new_height_ok (struct tui_win_info *primary_win_info, 
+              int new_height)
 {
   int ok = (new_height < tui_term_height ());
 
@@ -1352,18 +1442,18 @@ new_height_ok (struct tui_win_info * primary_win_info, int new_height)
       diff = (new_height - primary_win_info->generic.height) * (-1);
       if (cur_layout == SRC_COMMAND || cur_layout == DISASSEM_COMMAND)
        {
-         ok = ((primary_win_info->generic.type == CMD_WIN &&
-                new_height <= (tui_term_height () - 4) &&
-                new_height >= MIN_CMD_WIN_HEIGHT) ||
-               (primary_win_info->generic.type != CMD_WIN &&
-                new_height <= (tui_term_height () - 2) &&
-                new_height >= MIN_WIN_HEIGHT));
+         ok = ((primary_win_info->generic.type == CMD_WIN 
+                && new_height <= (tui_term_height () - 4) 
+                && new_height >= MIN_CMD_WIN_HEIGHT) 
+               || (primary_win_info->generic.type != CMD_WIN 
+                   && new_height <= (tui_term_height () - 2) 
+                   && new_height >= MIN_WIN_HEIGHT));
          if (ok)
-           {                   /* check the total height */
-             struct tui_win_info * win_info;
+           {                   /* Check the total height.  */
+             struct tui_win_info *win_info;
 
              if (primary_win_info == TUI_CMD_WIN)
-               win_info = (struct tui_win_info *) (tui_source_windows ())->list[0];
+               win_info = (tui_source_windows ())->list[0];
              else
                win_info = TUI_CMD_WIN;
              ok = ((new_height +
@@ -1384,45 +1474,41 @@ new_height_ok (struct tui_win_info * primary_win_info, int new_height)
          else
            {
              first_win = TUI_DATA_WIN;
-             second_win = (struct tui_win_info *) (tui_source_windows ())->list[0];
+             second_win = (tui_source_windows ())->list[0];
            }
-         /*
-            ** We could simply add all the heights to obtain the same result
-            ** but below is more explicit since we subtract 1 for the
-            ** line that the first and second windows share, and add one
-            ** for the locator.
-          */
+         /* We could simply add all the heights to obtain the same
+            result but below is more explicit since we subtract 1 for
+            the line that the first and second windows share, and add
+            one for the locator.  */
          total_height = cur_total_height =
            (first_win->generic.height + second_win->generic.height - 1)
-           + TUI_CMD_WIN->generic.height + 1 /*locator */ ;
+           + TUI_CMD_WIN->generic.height + 1;  /* Locator. */
          if (primary_win_info == TUI_CMD_WIN)
            {
-             /* locator included since first & second win share a line */
+             /* Locator included since first & second win share a line.  */
              ok = ((first_win->generic.height +
                     second_win->generic.height + diff) >=
-                   (MIN_WIN_HEIGHT * 2) &&
-                   new_height >= MIN_CMD_WIN_HEIGHT);
+                   (MIN_WIN_HEIGHT * 2) 
+                   && new_height >= MIN_CMD_WIN_HEIGHT);
              if (ok)
                {
-                 total_height = new_height + (first_win->generic.height +
-                                         second_win->generic.height + diff);
+                 total_height = new_height + 
+                   (first_win->generic.height +
+                    second_win->generic.height + diff);
                  min_height = MIN_CMD_WIN_HEIGHT;
                }
            }
          else
            {
              min_height = MIN_WIN_HEIGHT;
-             /*
-                ** First see if we can increase/decrease the command
-                ** window.  And make sure that the command window is
-                ** at least 1 line
-              */
+
+             /* First see if we can increase/decrease the command
+                window.  And make sure that the command window is at
+                least 1 line.  */
              ok = ((TUI_CMD_WIN->generic.height + diff) > 0);
              if (!ok)
-               {               /*
-                                  ** Looks like we have to increase/decrease one of
-                                  ** the other windows
-                                */
+               { /* Looks like we have to increase/decrease one of
+                    the other windows.  */
                  if (primary_win_info == first_win)
                    ok = (second_win->generic.height + diff) >= min_height;
                  else
@@ -1440,12 +1526,11 @@ new_height_ok (struct tui_win_info * primary_win_info, int new_height)
                      TUI_CMD_WIN->generic.height + diff;
                }
            }
-         /*
-            ** Now make sure that the proposed total height doesn't exceed
-            ** the old total height.
-          */
+         /* Now make sure that the proposed total height doesn't
+            exceed the old total height.  */
          if (ok)
-           ok = (new_height >= min_height && total_height <= cur_total_height);
+           ok = (new_height >= min_height 
+                 && total_height <= cur_total_height);
        }
     }
 
@@ -1454,22 +1539,21 @@ new_height_ok (struct tui_win_info * primary_win_info, int new_height)
 
 
 static void
-parse_scrolling_args (char *arg, struct tui_win_info * * win_to_scroll,
+parse_scrolling_args (char *arg, 
+                     struct tui_win_info **win_to_scroll,
                      int *num_to_scroll)
 {
   if (num_to_scroll)
     *num_to_scroll = 0;
   *win_to_scroll = tui_win_with_focus ();
 
-  /*
-     ** First set up the default window to scroll, in case there is no
-     ** window name arg
-   */
+  /* First set up the default window to scroll, in case there is no
+     window name arg.  */
   if (arg != (char *) NULL)
     {
       char *buf, *buf_ptr;
 
-      /* process the number of lines to scroll */
+      /* Process the number of lines to scroll.  */
       buf = buf_ptr = xstrdup (arg);
       if (isdigit (*buf_ptr))
        {
@@ -1488,7 +1572,7 @@ parse_scrolling_args (char *arg, struct tui_win_info * * win_to_scroll,
            *num_to_scroll = atoi (num_str);
        }
 
-      /* process the window name if one is specified */
+      /* Process the window name if one is specified.  */
       if (buf_ptr != (char *) NULL)
        {
          char *wname;
@@ -1503,17 +1587,17 @@ parse_scrolling_args (char *arg, struct tui_win_info * * win_to_scroll,
          else
            wname = "?";
          
-         /* Validate the window name */
+         /* Validate the window name */
          for (i = 0; i < strlen (wname); i++)
            wname[i] = toupper (wname[i]);
          *win_to_scroll = tui_partial_win_by_name (wname);
 
-         if (*win_to_scroll == (struct tui_win_info *) NULL ||
-             !(*win_to_scroll)->generic.is_visible)
-           warning (_("Invalid window specified. \n\
+         if (*win_to_scroll == (struct tui_win_info *) NULL
+             || !(*win_to_scroll)->generic.is_visible)
+           error (_("Invalid window specified. \n\
 The window name specified must be valid and visible.\n"));
          else if (*win_to_scroll == TUI_CMD_WIN)
-           *win_to_scroll = (struct tui_win_info *) (tui_source_windows ())->list[0];
+           *win_to_scroll = (tui_source_windows ())->list[0];
        }
       xfree (buf);
     }