]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/blobdiff - html/cgi-bin/services.cgi
services.cgi: Fix status/actions on services with name != addon name
[people/pmueller/ipfire-2.x.git] / html / cgi-bin / services.cgi
index 2374757350d674cf1b5babd421532ad53607bc44..de946d755b422334ebdcd248d5b046f9a942c748 100644 (file)
@@ -20,7 +20,7 @@
 ###############################################################################
 
 use strict;
-
+use feature "switch";
 # enable only the following on debugging purpose
 #use warnings;
 #use CGI::Carp 'fatalsToBrowser';
@@ -29,6 +29,7 @@ require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/lang.pl";
 require "${General::swroot}/header.pl";
 require "${General::swroot}/graphs.pl";
+require "/opt/pakfire/lib/functions.pl";
 
 my %color = ();
 my %mainsettings = ();
@@ -64,7 +65,7 @@ my %link =(
        $Lang::tr{'dhcp server'} => "<a href=\'dhcp.cgi\'>$Lang::tr{'dhcp server'}</a>",
        $Lang::tr{'web server'} => $Lang::tr{'web server'},
        $Lang::tr{'cron server'} => $Lang::tr{'cron server'},
-       $Lang::tr{'dns proxy server'} => $Lang::tr{'dns proxy server'},
+       $Lang::tr{'dns proxy server'} => "<a href=\'dns.cgi\'>$Lang::tr{'dns proxy server'}</a>",
        $Lang::tr{'logging server'} => $Lang::tr{'logging server'},
        $Lang::tr{'kernel logging server'} => $Lang::tr{'kernel logging server'},
        $Lang::tr{'ntp server'} => "<a href=\'time.cgi\'>$Lang::tr{'ntp server'}</a>",
@@ -140,15 +141,22 @@ END
        &Header::openbox('100%', 'left', "Addon - $Lang::tr{services}");
        my $paramstr=$ENV{QUERY_STRING};
        my @param=split(/!/, $paramstr);
-       if ($param[1] ne ''){
-               &General::system("/usr/local/bin/addonctrl", "$param[0]", "$param[1]");
+       # Make sure action parameter is actually one of the allowed service actions
+       given ($param[1]) {
+               when ( ['start', 'stop', 'enable', 'disable'] ) {
+                       # Make sure pak-name and service name don't contain any illegal character
+                       if ( $param[0] !~ /[^a-zA-Z_0-9\-]/ &&
+                            $param[2] !~ /[^a-zA-Z_0-9\-]/ ) {
+                               &General::system("/usr/local/bin/addonctrl", "$param[0]", "$param[1]", "$param[2]");
+                       }
+               }
        }
 
        print <<END
 <div align='center'>
 <table width='80%' cellspacing='1' class='tbl'>
 <tr>
-       <th align='center'><b>Addon</b></th>
+       <th align='left'><b>Addon $Lang::tr{service}</b></th>
        <th align='center'><b>Boot</b></th>
        <th align='center' colspan=2><b>$Lang::tr{'action'}</b></th>
        <th align='center'><b>$Lang::tr{'status'}</b></th>
@@ -160,43 +168,38 @@ END
 
        my $lines=0; # Used to count the outputlines to make different bgcolor
 
-       # Generate list of installed addon pak's
-       opendir (DIR, "/opt/pakfire/db/installed") || die "Cannot opendir /opt/pakfire/db/installed/: $!";
-       my @pak = sort readdir DIR;
-       closedir(DIR);
-
-       foreach (@pak){
-               chomp($_);
-               next unless (m/^meta-/);
-               s/^meta-//;
-
-               # Check which of the paks are services
-               if (-e "/etc/init.d/$_") {
-                       # blacklist some packages
-                       #
-                       # alsa has trouble with the volume saving and was not really stopped
-                       # mdadm should not stopped with webif because this could crash the system
-                       #
-                       if ( $_ eq 'squid' ) {
-                               next;
-                       }
-                       if ( ($_ ne "alsa") && ($_ ne "mdadm") ) {
+       my @paks;
+       my @addon_services;
+
+       # Generate list of installed addon pak services
+       my %paklist = &Pakfire::dblist("installed");
+
+       foreach my $pak (keys %paklist) {
+               my %metadata = &Pakfire::getmetadata($pak, "installed");
+                       
+               my $service;
+
+               if ("$metadata{'Services'}") {
+                       foreach $service (split(/ /, "$metadata{'Services'}")) {
                                $lines++;
-                               if ($lines % 2){
+                               if ($lines % 2) {
                                        print "<tr>";
                                        $col="bgcolor='$color{'color22'}'";
-                               }else{
+                               } else {
                                        print "<tr>";
                                        $col="bgcolor='$color{'color20'}'";
                                }
 
-                               print "<td align='left' $col width='31%'>$_</td> ";
-                               my $status = isautorun($_,$col);
+                               # Add addon name to displayname of service if servicename differs from addon
+                               my $displayname = ($pak ne $service) ? "$service ($pak)" : $service;
+                               print "<td align='left' $col width='31%'>$displayname</td> ";
+
+                               my $status = isautorun($pak,$service,$col);
                                print "$status ";
-                               print "<td align='center' $col width='8%'><a href='services.cgi?$_!start'><img alt='$Lang::tr{'start'}' title='$Lang::tr{'start'}' src='/images/go-up.png' border='0' /></a></td>";
-                               print "<td align='center' $col width='8%'><a href='services.cgi?$_!stop'><img alt='$Lang::tr{'stop'}' title='$Lang::tr{'stop'}' src='/images/go-down.png' border='0' /></a></td> ";
-                               my $status = &isrunningaddon($_,$col);
-                               $status =~ s/\\e\[[0-1]\;[0-9]+m//g;
+                               print "<td align='center' $col width='8%'><a href='services.cgi?$pak!start!$service'><img alt='$Lang::tr{'start'}' title='$Lang::tr{'start'}' src='/images/go-up.png' border='0' /></a></td>";
+                               print "<td align='center' $col width='8%'><a href='services.cgi?$pak!stop!$service'><img alt='$Lang::tr{'stop'}' title='$Lang::tr{'stop'}' src='/images/go-down.png' border='0' /></a></td> ";
+                               my $status = isrunningaddon($pak,$service,$col);
+                               $status =~ s/\\e\[[0-1]\;[0-9]+m//g;
 
                                chomp($status);
                                print "$status";
@@ -221,51 +224,24 @@ END
 }
 
 sub isautorun (@) {
-       my ($cmd, $col) = @_;
-
-       # Init directory.
-       my $initdir = "/etc/rc.d/rc3.d/";
-
-       my $status = "<td align='center' $col></td>";
+       my ($pak, $service, $col) = @_;
+       my @testcmd = &General::system_output("/usr/local/bin/addonctrl", "$pak", "boot-status", "$service");
+       my $testcmd = @testcmd[0];
+       my $status = "<td align='center' $col><img alt='$Lang::tr{'service boot setting unavailable'}' title='$Lang::tr{'service boot setting unavailable'}' src='/images/dialog-warning.png' border='0' width='16' height='16' /></td>";
 
-       # Check if autorun for the given cmd is enabled.
-       if ( &find_init("$cmd", "$initdir") ) {
+       # Check if autorun for the given service is enabled.
+       if ( $testcmd =~ /enabled\ on\ boot/ ) {
                # Adjust status.
-               $status = "<td align='center' $col><a href='services.cgi?$_!disable'><img alt='$Lang::tr{'deactivate'}' title='$Lang::tr{'deactivate'}' src='/images/on.gif' border='0' width='16' height='16' /></a></td>";
-       } else {
+               $status = "<td align='center' $col><a href='services.cgi?$pak!disable!$service'><img alt='$Lang::tr{'deactivate'}' title='$Lang::tr{'deactivate'}' src='/images/on.gif' border='0' width='16' height='16' /></a></td>";
+       } elsif ( $testcmd =~ /disabled\ on\ boot/ ) {
                # Adjust status.
-               $status = "<td align='center' $col><a href='services.cgi?$_!enable'><img alt='$Lang::tr{'activate'}' title='$Lang::tr{'activate'}' src='/images/off.gif' border='0' width='16' height='16' /></a></td>";
+               $status = "<td align='center' $col><a href='services.cgi?$pak!enable!$service'><img alt='$Lang::tr{'activate'}' title='$Lang::tr{'activate'}' src='/images/off.gif' border='0' width='16' height='16' /></a></td>";
        }
 
        # Return the status.
        return $status;
 }
 
-sub find_init (@) {
-       my ($cmd, $dir) = @_;
-
-       # Open given init directory.
-       opendir (INITDIR, "$dir") || die "Cannot opendir $dir: $!";
-
-       # Read-in init files from directory.
-       my @inits = readdir(INITDIR);
-
-       # Close directory handle.
-       closedir(INITDIR);
-
-       # Loop through the directory.
-       foreach my $init (@inits) {
-               # Check if the current processed file belongs to the given command.
-               if ($init =~ /S\d+\d+$cmd\z/) {
-                       # Found, return "1" - True.
-                       return "1";
-               }
-        }
-
-       # Nothing found, return nothing.
-       return;
-}
-
 sub isrunning (@) {
        my ($cmd, $col) = @_;
        my $status = "<td align='center' bgcolor='${Header::colourred}'><font color='white'><b>$Lang::tr{'stopped'}</b></font></td><td colspan='2' $col></td>";
@@ -319,7 +295,7 @@ sub isrunning (@) {
 }
 
 sub isrunningaddon (@) {
-       my ($cmd, $col) = @_;
+       my ($pak, $service, $col) = @_;
 
        my $status = "<td align='center' bgcolor='${Header::colourred}'><font color='white'><b>$Lang::tr{'stopped'}</b></font></td><td colspan='2' $col></td>";
        my $pid = '';
@@ -327,7 +303,7 @@ sub isrunningaddon (@) {
        my $exename;
        my @memory;
 
-       my @testcmd = &General::system_output("/usr/local/bin/addonctrl", "$cmd", "status");
+       my @testcmd = &General::system_output("/usr/local/bin/addonctrl", "$pak", "status", "$service");
        my $testcmd = @testcmd[0];
 
        if ( $testcmd =~ /is\ running/ && $testcmd !~ /is\ not\ running/){