x86: fix processing of -M disassembler option

[thirdparty/binutils-gdb.git] / opcodes / i386-dis.c

diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 6ac1d7416a9b1d2cea2a726ca4849de235ba52d3..f57409dd17a89a2326f3a1689763dfec47682641 100644 (file)
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -2252,7 +2252,7 @@ struct dis386 {
    'H' => print ",pt" or ",pn" branch hint
    'I' => honor following macro letter even in Intel mode (implemented only
          for some of the macro letters)
-   'J' => print 'l'
+   'J' unused.
    'K' => print 'd' or 'q' if rex prefix is present.
    'L' => print 'l' if suffix_always is true
    'M' => print 'r' if intel_mnemonic is false.
@@ -2290,8 +2290,9 @@ struct dis386 {
    "XZ" => print 'x', 'y', or 'z' if suffix_always is true or no
           register operands and no broadcast.
    "XW" => print 's', 'd' depending on the VEX.W bit (for FMA)
-   "LQ" => print 'l' ('d' in Intel mode) or 'q' for memory operand
-          or suffix_always is true
+   "LQ" => print 'l' ('d' in Intel mode) or 'q' for memory
+          operand or no operand at all in 64bit mode, or if suffix_always
+          is true.
    "LB" => print "abs" in 64bit mode and behave as 'B' otherwise
    "LS" => print "abs" in 64bit mode and behave as 'S' otherwise
    "LV" => print "abs" for 64bit operand and behave as 'S' otherwise
@@ -2535,8 +2536,8 @@ static const struct dis386 dis386[] = {
   /* c8 */
   { "enterT",          { Iw, Ib }, 0 },
   { "leaveT",          { XX }, 0 },
-  { "Jret{|f}P",       { Iw }, 0 },
-  { "Jret{|f}P",       { XX }, 0 },
+  { "{l|}ret{|f}P",    { Iw }, 0 },
+  { "{l|}ret{|f}P",    { XX }, 0 },
   { "int3",            { XX }, 0 },
   { "int",             { Ib }, 0 },
   { X86_64_TABLE (X86_64_CE) },
@@ -2606,7 +2607,7 @@ static const struct dis386 dis386_twobyte[] = {
   { Bad_Opcode },
   { "syscall",         { XX }, 0 },
   { "clts",            { XX }, 0 },
-  { "sysret%LP",               { XX }, 0 },
+  { "sysret%LQ",               { XX }, 0 },
   /* 08 */
   { "invd",            { XX }, 0 },
   { PREFIX_TABLE (PREFIX_0F09) },
@@ -3576,6 +3577,8 @@ static const struct dis386 prefix_table[][4] = {
   {
     { "vmmcall",       { Skip_MODRM }, 0 },
     { "vmgexit",       { Skip_MODRM }, 0 },
+    { Bad_Opcode },
+    { "vmgexit",       { Skip_MODRM }, 0 },
   },
 
   /* PREFIX_0F01_REG_5_MOD_0 */
@@ -6854,7 +6857,7 @@ static const struct dis386 x86_64_table[][2] = {
 
   /* X86_64_9A */
   {
-    { "Jcall{T|}", { Ap }, 0 },
+    { "{l|}call{T|}", { Ap }, 0 },
   },
 
   /* X86_64_C2 */
@@ -6910,7 +6913,7 @@ static const struct dis386 x86_64_table[][2] = {
 
   /* X86_64_EA */
   {
-    { "Jjmp{T|}", { Ap }, 0 },
+    { "{l|}jmp{T|}", { Ap }, 0 },
   },
 
   /* X86_64_0F01_REG_0 */
@@ -10177,11 +10180,11 @@ static const struct dis386 mod_table[][2] = {
   },
   {
     /* MOD_FF_REG_3 */
-    { "Jcall^", { indirEp }, 0 },
+    { "{l|}call^", { indirEp }, 0 },
   },
   {
     /* MOD_FF_REG_5 */
-    { "Jjmp^", { indirEp }, 0 },
+    { "{l|}jmp^", { indirEp }, 0 },
   },
   {
     /* MOD_0F01_REG_0 */
@@ -11848,17 +11851,17 @@ print_insn (bfd_vma pc, disassemble_info *info)
       else if (CONST_STRNEQ (p, "x86-64"))
        {
          address_mode = mode_64bit;
-         priv.orig_sizeflag = AFLAG | DFLAG;
+         priv.orig_sizeflag |= AFLAG | DFLAG;
        }
       else if (CONST_STRNEQ (p, "i386"))
        {
          address_mode = mode_32bit;
-         priv.orig_sizeflag = AFLAG | DFLAG;
+         priv.orig_sizeflag |= AFLAG | DFLAG;
        }
       else if (CONST_STRNEQ (p, "i8086"))
        {
          address_mode = mode_16bit;
-         priv.orig_sizeflag = 0;
+         priv.orig_sizeflag &= ~(AFLAG | DFLAG);
        }
       else if (CONST_STRNEQ (p, "intel"))
        {
@@ -12339,9 +12342,9 @@ static const char *float_mem[] = {
   "fist{l|}",
   "fistp{l|}",
   "(bad)",
-  "fld{t||t|}",
+  "fld{t|}",
   "(bad)",
-  "fstp{t||t|}",
+  "fstp{t|}",
   /* dc */
   "fadd{l|}",
   "fmul{l|}",
@@ -12864,11 +12867,6 @@ putop (const char *in_template, int sizeflag)
                *obufp++ = 'n';
            }
          break;
-       case 'J':
-         if (intel_syntax)
-           break;
-         *obufp++ = 'l';
-         break;
        case 'K':
          USED_REX (REX_W);
          if (rex & REX_W)
@@ -13064,7 +13062,7 @@ putop (const char *in_template, int sizeflag)
                  SAVE_LAST (*p);
                  break;
                }
-             if (intel_syntax
+             if ((intel_syntax && need_modrm)
                  || (modrm.mod == 3 && !(sizeflag & SUFFIX_ALWAYS)))
                break;
              if ((rex & REX_W))
@@ -13072,8 +13070,9 @@ putop (const char *in_template, int sizeflag)
                  USED_REX (REX_W);
                  *obufp++ = 'q';
                }
-             else
-               *obufp++ = 'l';
+             else if((address_mode == mode_64bit && need_modrm)
+                     || (sizeflag & SUFFIX_ALWAYS))
+               *obufp++ = intel_syntax? 'd' : 'l';
            }
          break;
        case 'R':