setpci: Fixed a typo in parsing of values, causing SIGSEGV on some bad inputs.

[thirdparty/pciutils.git] / setpci.c

diff --git a/setpci.c b/setpci.c
index 55212853a9a84709ed6e0d512998f145c03322f4..21858bdfdddec8be1a9f674bdd777b1d88b2c32f 100644 (file)
--- a/setpci.c
+++ b/setpci.c
@@ -630,13 +630,13 @@ static void parse_op(char *c, struct pci_dev **selected_devices)
       e = strchr(value, ',');
       if (e)
        *e++ = 0;
-      if (parse_x32(value, &f, &ll) < 0 || *f && *f != ':')
+      if (parse_x32(value, &f, &ll) < 0 || f && *f != ':')
        parse_err("Invalid value \"%s\"", value);
       lim = max_values[op->width];
       if (ll > lim && ll < ~0UL - lim)
        parse_err("Value \"%s\" is out of range", value);
       op->values[j].value = ll;
-      if (*f == ':')
+      if (f && *f == ':')
        {
          if (parse_x32(f+1, NULL, &ll) <= 0)
            parse_err("Invalid mask \"%s\"", f+1);