port: ethernet: Correctly create new configurations

[people/ms/network.git] / src / functions / functions.settings

diff --git a/src/functions/functions.settings b/src/functions/functions.settings
index becf3f0f16a67cf22f1e2b9fb0c79b8423594c41..69f4c238c286f36b20c9ee57633a0b597f2f3b60 100644 (file)
--- a/src/functions/functions.settings
+++ b/src/functions/functions.settings
@@ -153,15 +153,16 @@ settings_write() {
                return ${EXIT_ERROR}
        fi
 
-       log DEBUG "Writing settings file '${settings_file}'"
+       if ! make_parent_directory "${settings_file}"; then
+               return ${EXIT_ERROR}
+       fi
 
-       mkdir -p $(dirname ${settings_file}) 2>/dev/null
-       > ${settings_file}
+       log DEBUG "Writing settings file '${settings_file}'"
 
        local param
        for param in $(list_sort "$@"); do
-               echo "${param}=\"${!param}\"" >> ${settings_file}
-       done
+               echo "${param}=\"${!param}\""
+       done > ${settings_file}
 }
 
 settings_remove() {