]> git.ipfire.org Git - ipfire-2.x.git/blobdiff - src/installer/hw.c
Merge branch 'cake' into next
[ipfire-2.x.git] / src / installer / hw.c
index d74526050037e48a1458fa04403430b631903221..17e0bbb01ef35fddff59cc787a1c1881331b72fb 100644 (file)
@@ -24,6 +24,7 @@
 
 #include <assert.h>
 #include <blkid/blkid.h>
+#include <errno.h>
 #include <fcntl.h>
 #include <libudev.h>
 #include <linux/loop.h>
@@ -36,6 +37,7 @@
 #include <sys/stat.h>
 #include <sys/swap.h>
 #include <sys/sysinfo.h>
+#include <sys/utsname.h>
 #include <unistd.h>
 
 #include <linux/fs.h>
 
 #include "hw.h"
 
-const char* other_filesystems[] = {
-       "/dev",
-       "/proc",
-       "/sys",
-       NULL
-};
-
 static int system_chroot(const char* output, const char* path, const char* cmd) {
        char chroot_cmd[STRING_SIZE];
 
@@ -60,7 +55,7 @@ static int system_chroot(const char* output, const char* path, const char* cmd)
 }
 
 struct hw* hw_init() {
-       struct hw* hw = malloc(sizeof(*hw));
+       struct hw* hw = calloc(1, sizeof(*hw));
        assert(hw);
 
        // Initialize libudev
@@ -70,6 +65,16 @@ struct hw* hw_init() {
                exit(1);
        }
 
+       // What architecture are we running on?
+       struct utsname uname_data;
+       int ret = uname(&uname_data);
+       if (ret == 0)
+               snprintf(hw->arch, sizeof(hw->arch), "%s", uname_data.machine);
+
+       // Should we install in EFI mode?
+       if ((strcmp(hw->arch, "x86_64") == 0) || (strcmp(hw->arch, "aarch64") == 0))
+               hw->efi = 1;
+
        return hw;
 }
 
@@ -137,13 +142,75 @@ int hw_mount(const char* source, const char* target, const char* fs, int flags)
        return mount(source, target, fs, flags, NULL);
 }
 
-int hw_umount(const char* target) {
-       return umount2(target, 0);
+static int hw_bind_mount(const char* source, const char* prefix) {
+       if (!source || !prefix) {
+               errno = EINVAL;
+               return 1;
+       }
+
+       char target[PATH_MAX];
+       int r;
+
+       // Format target
+       r = snprintf(target, sizeof(target) - 1, "%s/%s", prefix, source);
+       if (r < 0)
+               return 1;
+
+       // Ensure target exists
+       mkdir(target, S_IRWXU|S_IRWXG|S_IRWXO);
+
+       return hw_mount(source, target, NULL, MS_BIND);
+}
+
+int hw_umount(const char* source, const char* prefix) {
+       char target[PATH_MAX];
+       int r;
+
+       if (prefix)
+               r = snprintf(target, sizeof(target) - 1, "%s/%s", prefix, source);
+       else
+               r = snprintf(target, sizeof(target) - 1, "%s", source);
+       if (r < 0)
+               return r;
+
+       // Perform umount
+       r = umount2(target, 0);
+       if (r) {
+               switch (errno) {
+                       // Try again with force if umount wasn't successful
+                       case EBUSY:
+                               sleep(1);
+
+                               r = umount2(target, MNT_FORCE);
+                               break;
+
+                       // target wasn't a mountpoint. Ignore.
+                       case EINVAL:
+                               r = 0;
+                               break;
+
+                       // target doesn't exist
+                       case ENOENT:
+                               r = 0;
+                               break;
+               }
+       }
+
+       return r;
 }
 
 static int hw_test_source_medium(const char* path) {
        int ret = hw_mount(path, SOURCE_MOUNT_PATH, "iso9660", MS_RDONLY);
 
+       if (ret != 0) {
+               // 2nd try, ntfs for a rufus converted usb key
+               ret = hw_mount(path, SOURCE_MOUNT_PATH, "ntfs3", MS_RDONLY);
+       }
+       if (ret != 0) {
+               // 3rd try, vfat for a rufus converted usb key
+               ret = hw_mount(path, SOURCE_MOUNT_PATH, "vfat", MS_RDONLY);
+       }
+
        // If the source could not be mounted we
        // cannot proceed.
        if (ret != 0)
@@ -153,9 +220,9 @@ static int hw_test_source_medium(const char* path) {
        ret = access(SOURCE_TEST_FILE, R_OK);
 
        // Umount the test device.
-       hw_umount(SOURCE_MOUNT_PATH);
+       hw_umount(SOURCE_MOUNT_PATH, NULL);
 
-       return (ret == 0);
+       return ret;
 }
 
 char* hw_find_source_medium(struct hw* hw) {
@@ -217,6 +284,20 @@ struct hw_disk** hw_find_disks(struct hw* hw, const char* sourcedrive) {
        struct hw_disk** ret = hw_create_disks();
        struct hw_disk** disks = ret;
 
+       // Determine the disk device of source if it is a partition
+       char* sourcedisk = NULL;
+       char syssource[PATH_MAX];
+       (void)snprintf(syssource, sizeof(syssource) - 1, "/sys/class/block/%s", sourcedrive + 5);
+       struct udev_device* s_dev = udev_device_new_from_syspath(hw->udev, syssource);
+       const char* s_devtype = udev_device_get_property_value(s_dev, "DEVTYPE");
+       if (s_devtype && (strcmp(s_devtype, "partition") == 0)) {
+               struct udev_device* p_dev = udev_device_get_parent_with_subsystem_devtype(s_dev,"block","disk");
+               if (p_dev) {
+                       sourcedisk = udev_device_get_devnode(p_dev);
+               }
+       }
+       if (!sourcedisk) sourcedisk = sourcedrive;
+
        struct udev_enumerate* enumerate = udev_enumerate_new(hw->udev);
 
        udev_enumerate_add_match_subsystem(enumerate, "block");
@@ -240,8 +321,8 @@ struct hw_disk** hw_find_disks(struct hw* hw, const char* sourcedrive) {
                        continue;
                }
 
-               // Skip sourcedrive if we need to
-               if (sourcedrive && (strcmp(dev_path, sourcedrive) == 0)) {
+               // Skip sourcedisk if we need to
+               if (sourcedisk && (strcmp(dev_path, sourcedisk) == 0)) {
                        udev_device_unref(dev);
                        continue;
                }
@@ -312,6 +393,9 @@ struct hw_disk** hw_find_disks(struct hw* hw, const char* sourcedrive) {
                                "%s - %s", size_str, p);
                }
 
+               // Cut off the description string after 40 characters
+               disk->description[41] = '\0';
+
                *disks++ = disk;
 
                if (--i == 0)
@@ -407,23 +491,8 @@ static unsigned long long hw_swap_size(struct hw_destination* dest) {
        return swap_size;
 }
 
-static unsigned long long hw_root_size(struct hw_destination* dest) {
-       unsigned long long root_size;
-
-       if (dest->size < MB2BYTES(2048))
-               root_size = MB2BYTES(1024);
-
-       else if (dest->size >= MB2BYTES(2048) && dest->size <= MB2BYTES(3072))
-               root_size = MB2BYTES(1536);
-
-       else
-               root_size = MB2BYTES(2048);
-
-       return root_size;
-}
-
 static unsigned long long hw_boot_size(struct hw_destination* dest) {
-       return MB2BYTES(64);
+       return MB2BYTES(128);
 }
 
 static int hw_device_has_p_suffix(const struct hw_destination* dest) {
@@ -440,7 +509,7 @@ static int hw_device_has_p_suffix(const struct hw_destination* dest) {
        return 0;
 }
 
-static int hw_calculate_partition_table(struct hw_destination* dest, int disable_swap) {
+static int hw_calculate_partition_table(struct hw* hw, struct hw_destination* dest, int disable_swap) {
        char path[DEV_SIZE];
        int part_idx = 1;
 
@@ -467,6 +536,10 @@ static int hw_calculate_partition_table(struct hw_destination* dest, int disable
        // Add some more space for partition tables, etc.
        dest->size -= MB2BYTES(1);
 
+       // The disk has to have at least 2GB
+       if (dest->size <= MB2BYTES(2048))
+               return -1;
+
        // Determine partition table
        dest->part_table = HW_PART_TABLE_MSDOS;
 
@@ -493,7 +566,20 @@ static int hw_calculate_partition_table(struct hw_destination* dest, int disable
        }
 
        dest->size_boot = hw_boot_size(dest);
-       dest->size_root = hw_root_size(dest);
+
+       // Create an EFI partition when running in EFI mode
+       if (hw->efi)
+               dest->size_boot_efi = MB2BYTES(32);
+       else
+               dest->size_boot_efi = 0;
+
+       // Determine the size of the data partition.
+       unsigned long long space_left = dest->size - \
+               (dest->size_bootldr + dest->size_boot + dest->size_boot_efi);
+
+       // If we have less than 2GB left, we disable swap
+       if (space_left <= MB2BYTES(2048))
+               disable_swap = 1;
 
        // Should we use swap?
        if (disable_swap)
@@ -501,21 +587,11 @@ static int hw_calculate_partition_table(struct hw_destination* dest, int disable
        else
                dest->size_swap = hw_swap_size(dest);
 
-       // Determine the size of the data partition.
-       unsigned long long used_space = dest->size_bootldr + dest->size_boot
-               + dest->size_swap + dest->size_root;
+       // Subtract swap
+       space_left -= dest->size_swap;
 
-       // Disk is way too small
-       if (used_space >= dest->size)
-               return -1;
-
-       dest->size_data = dest->size - used_space;
-
-       // If it gets too small, we remove the swap space.
-       if (dest->size_data <= MB2BYTES(256)) {
-               dest->size_data += dest->size_swap;
-               dest->size_swap = 0;
-       }
+       // Root is getting what ever is left
+       dest->size_root = space_left;
 
        // Set partition names
        if (dest->size_boot > 0) {
@@ -526,6 +602,16 @@ static int hw_calculate_partition_table(struct hw_destination* dest, int disable
        } else
                *dest->part_boot = '\0';
 
+       if (dest->size_boot_efi > 0) {
+               dest->part_boot_efi_idx = part_idx;
+
+               snprintf(dest->part_boot_efi, sizeof(dest->part_boot_efi),
+                       "%s%d", path, part_idx++);
+       } else {
+               *dest->part_boot_efi = '\0';
+               dest->part_boot_efi_idx = 0;
+       }
+
        if (dest->size_swap > 0)
                snprintf(dest->part_swap, sizeof(dest->part_swap), "%s%d", path, part_idx++);
        else
@@ -537,15 +623,10 @@ static int hw_calculate_partition_table(struct hw_destination* dest, int disable
 
        snprintf(dest->part_root, sizeof(dest->part_root), "%s%d", path, part_idx++);
 
-       if (dest->size_data > 0)
-               snprintf(dest->part_data, sizeof(dest->part_data), "%s%d", path, part_idx++);
-       else
-               *dest->part_data = '\0';
-
        return 0;
 }
 
-struct hw_destination* hw_make_destination(int part_type, struct hw_disk** disks, int disable_swap) {
+struct hw_destination* hw_make_destination(struct hw* hw, int part_type, struct hw_disk** disks, int disable_swap) {
        struct hw_destination* dest = malloc(sizeof(*dest));
 
        if (part_type == HW_PART_TYPE_NORMAL) {
@@ -565,7 +646,7 @@ struct hw_destination* hw_make_destination(int part_type, struct hw_disk** disks
        // Is this a RAID device?
        dest->is_raid = (part_type > HW_PART_TYPE_NORMAL);
 
-       int r = hw_calculate_partition_table(dest, disable_swap);
+       int r = hw_calculate_partition_table(hw, dest, disable_swap);
        if (r)
                return NULL;
 
@@ -653,6 +734,14 @@ int hw_create_partitions(struct hw_destination* dest, const char* output) {
                part_start += dest->size_boot;
        }
 
+       if (*dest->part_boot_efi) {
+               asprintf(&cmd, "%s mkpart %s fat32 %lluB %lluB", cmd,
+                       (dest->part_table == HW_PART_TABLE_GPT) ? "ESP" : "primary",
+                       part_start, part_start + dest->size_boot_efi - 1);
+
+               part_start += dest->size_boot_efi;
+       }
+
        if (*dest->part_swap) {
                asprintf(&cmd, "%s mkpart %s linux-swap %lluB %lluB", cmd,
                        (dest->part_table == HW_PART_TABLE_GPT) ? "SWAP" : "primary",
@@ -669,22 +758,16 @@ int hw_create_partitions(struct hw_destination* dest, const char* output) {
                part_start += dest->size_root;
        }
 
-       if (*dest->part_data) {
-               asprintf(&cmd, "%s mkpart %s ext2 %lluB %lluB", cmd,
-                       (dest->part_table == HW_PART_TABLE_GPT) ? "DATA" : "primary",
-                       part_start, part_start + dest->size_data - 1);
-
-               part_start += dest->size_data;
-       }
-
        if (dest->part_boot_idx > 0)
                asprintf(&cmd, "%s set %d boot on", cmd, dest->part_boot_idx);
 
+       if (dest->part_boot_efi_idx > 0)
+               asprintf(&cmd, "%s set %d esp on", cmd, dest->part_boot_efi_idx);
+
        if (dest->part_table == HW_PART_TABLE_GPT) {
                if (*dest->part_bootldr) {
                        asprintf(&cmd, "%s set %d bios_grub on", cmd, dest->part_boot_idx);
                }
-               asprintf(&cmd, "%s disk_set pmbr_boot on", cmd);
        }
 
        r = mysystem(output, cmd);
@@ -702,13 +785,13 @@ int hw_create_partitions(struct hw_destination* dest, const char* output) {
                        if (*dest->part_boot && (try_open(dest->part_boot) != 0))
                                continue;
 
-                       if (*dest->part_swap && (try_open(dest->part_swap) != 0))
+                       if (*dest->part_boot_efi && (try_open(dest->part_boot_efi) != 0))
                                continue;
 
-                       if (*dest->part_root && (try_open(dest->part_root) != 0))
+                       if (*dest->part_swap && (try_open(dest->part_swap) != 0))
                                continue;
 
-                       if (*dest->part_data && (try_open(dest->part_data) != 0))
+                       if (*dest->part_root && (try_open(dest->part_root) != 0))
                                continue;
 
                        // All partitions do exist, exiting the loop.
@@ -734,15 +817,19 @@ static int hw_format_filesystem(const char* path, int fs, const char* output) {
 
        // EXT4
        } else if (fs == HW_FS_EXT4) {
-               snprintf(cmd, sizeof(cmd), "/sbin/mke2fs -T ext4 %s", path);
+               snprintf(cmd, sizeof(cmd), "/sbin/mke2fs -FF -T ext4 %s", path);
 
        // EXT4 w/o journal
        } else if (fs == HW_FS_EXT4_WO_JOURNAL) {
-               snprintf(cmd, sizeof(cmd), "/sbin/mke2fs -T ext4 -O ^has_journal %s", path);
+               snprintf(cmd, sizeof(cmd), "/sbin/mke2fs -FF -T ext4 -O ^has_journal %s", path);
 
        // XFS
        } else if (fs == HW_FS_XFS) {
                snprintf(cmd, sizeof(cmd), "/sbin/mkfs.xfs -f %s", path);
+
+       // FAT32
+       } else if (fs == HW_FS_FAT32) {
+               snprintf(cmd, sizeof(cmd), "/sbin/mkfs.vfat %s", path);
        }
 
        assert(*cmd);
@@ -762,6 +849,13 @@ int hw_create_filesystems(struct hw_destination* dest, const char* output) {
                        return r;
        }
 
+       // ESP
+       if (*dest->part_boot_efi) {
+               r = hw_format_filesystem(dest->part_boot_efi, HW_FS_FAT32, output);
+               if (r)
+                       return r;
+       }
+
        // swap
        if (*dest->part_swap) {
                r = hw_format_filesystem(dest->part_swap, HW_FS_SWAP, output);
@@ -774,13 +868,6 @@ int hw_create_filesystems(struct hw_destination* dest, const char* output) {
        if (r)
                return r;
 
-       // data
-       if (*dest->part_data) {
-               r = hw_format_filesystem(dest->part_data, dest->filesystem, output);
-               if (r)
-                       return r;
-       }
-
        return 0;
 }
 
@@ -804,6 +891,10 @@ int hw_mount_filesystems(struct hw_destination* dest, const char* prefix) {
                        filesystem = "xfs";
                        break;
 
+               case HW_FS_FAT32:
+                       filesystem = "vfat";
+                       break;
+
                default:
                        assert(0);
        }
@@ -826,12 +917,12 @@ int hw_mount_filesystems(struct hw_destination* dest, const char* prefix) {
                }
        }
 
-       // data
-       if (*dest->part_data) {
-               snprintf(target, sizeof(target), "%s%s", prefix, HW_PATH_DATA);
+       // ESP
+       if (*dest->part_boot_efi) {
+               snprintf(target, sizeof(target), "%s%s", prefix, HW_PATH_BOOT_EFI);
                mkdir(target, S_IRWXU|S_IRWXG|S_IRWXO);
 
-               r = hw_mount(dest->part_data, target, filesystem, 0);
+               r = hw_mount(dest->part_boot_efi, target, "vfat", 0);
                if (r) {
                        hw_umount_filesystems(dest, prefix);
 
@@ -850,54 +941,72 @@ int hw_mount_filesystems(struct hw_destination* dest, const char* prefix) {
        }
 
        // bind-mount misc filesystems
-       char** otherfs = other_filesystems;
-       while (*otherfs) {
-               snprintf(target, sizeof(target), "%s%s", prefix, *otherfs);
+       r = hw_bind_mount("/dev", prefix);
+       if (r)
+               return r;
 
-               mkdir(target, S_IRWXU|S_IRWXG|S_IRWXO);
-               r = hw_mount(*otherfs, target, NULL, MS_BIND);
-               if (r) {
-                       hw_umount_filesystems(dest, prefix);
+       r = hw_bind_mount("/proc", prefix);
+       if (r)
+               return r;
 
-                       return r;
-               }
+       r = hw_bind_mount("/sys", prefix);
+       if (r)
+               return r;
 
-               otherfs++;
-       }
+       r = hw_bind_mount("/sys/firmware/efi/efivars", prefix);
+       if (r && errno != ENOENT)
+               return r;
 
        return 0;
 }
 
 int hw_umount_filesystems(struct hw_destination* dest, const char* prefix) {
+       int r;
+       char target[STRING_SIZE];
+
        // Write all buffers to disk before umounting
        hw_sync();
 
-       // boot
-       if (*dest->part_boot) {
-               hw_umount(dest->part_boot);
+       // ESP
+       if (*dest->part_boot_efi) {
+               r = hw_umount(HW_PATH_BOOT_EFI, prefix);
+               if (r)
+                       return -1;
        }
 
-       // data
-       if (*dest->part_data) {
-               hw_umount(dest->part_data);
+       // boot
+       if (*dest->part_boot) {
+               r = hw_umount(HW_PATH_BOOT, prefix);
+               if (r)
+                       return -1;
        }
 
-       // root
-       hw_umount(dest->part_root);
-
        // swap
        if (*dest->part_swap) {
                swapoff(dest->part_swap);
        }
 
        // misc filesystems
-       char target[STRING_SIZE];
-       char** otherfs = other_filesystems;
+       r = hw_umount("/sys/firmware/efi/efivars", prefix);
+       if (r)
+               return -1;
 
-       while (*otherfs) {
-               snprintf(target, sizeof(target), "%s%s", prefix, *otherfs++);
-               hw_umount(target);
-       }
+       r = hw_umount("/sys", prefix);
+       if (r)
+               return -1;
+
+       r = hw_umount("/proc", prefix);
+       if (r)
+               return -1;
+
+       r = hw_umount("/dev", prefix);
+       if (r)
+               return -1;
+
+       // root
+       r = hw_umount(prefix, NULL);
+       if (r)
+               return -1;
 
        return 0;
 }
@@ -986,33 +1095,17 @@ int hw_stop_all_raid_arrays(const char* output) {
        return mysystem(output, "/sbin/mdadm --stop --scan --verbose");
 }
 
-int hw_install_bootloader(struct hw_destination* dest, const char* output) {
+int hw_install_bootloader(struct hw* hw, struct hw_destination* dest, const char* output) {
        char cmd[STRING_SIZE];
-       int r;
 
-       // Generate configuration file
-       snprintf(cmd, sizeof(cmd), "/usr/sbin/grub-mkconfig -o /boot/grub/grub.cfg");
-       r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
+       snprintf(cmd, sizeof(cmd), "/usr/bin/install-bootloader %s", dest->path);
+       int r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
        if (r)
                return r;
 
-       char cmd_grub[STRING_SIZE];
-       snprintf(cmd_grub, sizeof(cmd_grub), "/usr/sbin/grub-install --no-floppy --recheck");
-
-       if (dest->is_raid) {
-               snprintf(cmd, sizeof(cmd), "%s %s", cmd_grub, dest->disk1->path);
-               r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
-               if (r)
-                       return r;
-
-               snprintf(cmd, sizeof(cmd), "%s %s", cmd_grub, dest->disk2->path);
-               r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
-       } else {
-               snprintf(cmd, sizeof(cmd), "%s %s", cmd_grub, dest->path);
-               r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
-       }
+       hw_sync();
 
-       return r;
+       return 0;
 }
 
 static char* hw_get_uuid(const char* dev) {
@@ -1053,6 +1146,17 @@ int hw_write_fstab(struct hw_destination* dest) {
                }
        }
 
+       // ESP
+       if (*dest->part_boot_efi) {
+               uuid = hw_get_uuid(dest->part_boot_efi);
+
+               if (uuid) {
+                       fprintf(f, FSTAB_FMT, uuid, "/boot/efi", "auto", "defaults", 1, 2);
+                       free(uuid);
+               }
+       }
+
+
        // swap
        if (*dest->part_swap) {
                uuid = hw_get_uuid(dest->part_swap);
@@ -1070,16 +1174,6 @@ int hw_write_fstab(struct hw_destination* dest) {
                free(uuid);
        }
 
-       // data
-       if (*dest->part_data) {
-               uuid = hw_get_uuid(dest->part_data);
-
-               if (uuid) {
-                       fprintf(f, FSTAB_FMT, uuid, "/var", "auto", "defaults", 1, 1);
-                       free(uuid);
-               }
-       }
-
        fclose(f);
 
        return 0;