captivectrl: Allow empty IP addresses

[ipfire-2.x.git] / src / misc-progs / captivectrl.c

diff --git a/src/misc-progs/captivectrl.c b/src/misc-progs/captivectrl.c
index 975264952318d6f0e51523f3ed4cb3d1b39e88b5..97d5c19d63e10aab4d450d714fe24fb44d31c8a9 100644 (file)
--- a/src/misc-progs/captivectrl.c
+++ b/src/misc-progs/captivectrl.c
@@ -148,8 +148,15 @@ static int add_client_rules(const client_t* clients) {
                char* time_start = format_time(&clients->time_start);
                char* time_end   = format_time(&expires);
 
-               snprintf(match, sizeof(match), "-s %s -m mac --mac-source %s"
-                       " -m time --datestart %s --datestop %s", clients->ipaddr,
+               size_t len = 0;
+
+               if (*clients->ipaddr) {
+                       len += snprintf(match + len, sizeof(match) - len,
+                               "-s %s", clients->ipaddr);
+               }
+
+               len += snprintf(match + len, sizeof(match) - len,
+                       " -m mac --mac-source %s -m time --datestart %s --datestop %s",
                        clients->etheraddr, time_start, time_end);
 
                free(time_start);