X-Git-Url: http://git.ipfire.org/?a=blobdiff_plain;f=src%2Fpatches%2Fsuse-2.6.27.39%2Fpatches.drivers%2Flibfc-improve-fc_rport-c-locki.diff;fp=src%2Fpatches%2Fsuse-2.6.27.39%2Fpatches.drivers%2Flibfc-improve-fc_rport-c-locki.diff;h=755a646ff8d3f473d7b0a841310f3dc9a9c22a79;hb=4d1e5b6247e01d75a7d072fc11817db5a537e94f;hp=0000000000000000000000000000000000000000;hpb=4fbd28efc59f7bc864449c987e30c02eaa40675a;p=ipfire-2.x.git diff --git a/src/patches/suse-2.6.27.39/patches.drivers/libfc-improve-fc_rport-c-locki.diff b/src/patches/suse-2.6.27.39/patches.drivers/libfc-improve-fc_rport-c-locki.diff new file mode 100644 index 0000000000..755a646ff8 --- /dev/null +++ b/src/patches/suse-2.6.27.39/patches.drivers/libfc-improve-fc_rport-c-locki.diff @@ -0,0 +1,50 @@ +From: Robert Love +Subject: Improve fc_rport.c locking comment block +References: 459142 + +checkpatch.pl was complaining about having spaces +after '*'s. It seemed to be a false positive. I split +the comment block into two blocks and it resolved the +ERROR. + +Signed-off-by: Robert Love +Acked-by: Bernhard Walle +--- + + drivers/scsi/libfc/fc_rport.c | 17 ++++++++++------- + 1 file changed, 10 insertions(+), 7 deletions(-) + + +--- a/drivers/scsi/libfc/fc_rport.c ++++ b/drivers/scsi/libfc/fc_rport.c +@@ -18,20 +18,23 @@ + */ + + /* ++ * RPORT GENERAL INFO ++ * + * This file contains all processing regarding fc_rports. It contains the + * rport state machine and does all rport interaction with the transport class. + * There should be no other places in libfc that interact directly with the + * transport class in regards to adding and deleting rports. + * + * fc_rport's represent N_Port's within the fabric. ++ */ ++ ++/* ++ * RPORT LOCKING + * +- * rport locking notes: +- * +- * The rport should never hold the rport mutex and then lock the lport +- * mutex. The rport's mutex is considered lesser than the lport's mutex, so +- * the lport mutex can be held before locking the rport mutex, but not the +- * other way around. See the comment block at the top of fc_lport.c for more +- * details. ++ * The rport should never hold the rport mutex and then attempt to acquire ++ * either the lport or disc mutexes. The rport's mutex is considered lesser ++ * than both the lport's mutex and the disc mutex. Refer to fc_lport.c for ++ * more comments on the heirarchy. + * + * The locking strategy is similar to the lport's strategy. The lock protects + * the rport's states and is held and released by the entry points to the rport