]> git.ipfire.org Git - thirdparty/squid.git/commit - acinclude/squid-util.m4
autoconf upgrade: basic_auth helpers (and Bug 3793)
authorAmos Jeffries <squid3@treenet.co.nz>
Wed, 1 May 2013 06:59:12 +0000 (00:59 -0600)
committerAmos Jeffries <squid3@treenet.co.nz>
Wed, 1 May 2013 06:59:12 +0000 (00:59 -0600)
commit5a0c5a92d4f5d1e8650b7e20b27eb7dd3c30eed9
tree81ec1ed944f1970c733e8f29f075e7fba007aaaf
parent80c1bddbb7cb2aafa15d4c30f78558cac47c69b7
autoconf upgrade: basic_auth helpers (and Bug 3793)

Convert the basic_auth bundled helpers from using bash to m4 scripts
when testgn which helpers are able to be built.

This conversion allows us to leverage existing information found by
./configure in the helper test scritps, and to de-duplicate and simplify
many of the testing checks.

This required shuffling the SASL checks into a custom macro, which is
altered from a halting ERROR when SASL is absent to a softer WARNING,
but prevents the SASL helpers building - which the old checks did not
guarantee. Resolving Bug 3793.

The nature of m4 macros adds two small long term issues. Both
well-known issues with m4_include() expansion:
 * the macro is expanded in-place without scoping separation.
 So any brokenness in the child scripts will be a little harder to
 identify and may result in breakage of modues other than the one whose
 child script was the cause.

 * the macro takes literal arguments without variable expansion.
 So a "full" path relative to the main configure.ac script is required
 in every include. Meaning the modules.m4 file cannot simply
 sub-include using the $helper script variable, but must be a full
 expansion of the modules set.
31 files changed:
acinclude/squid-util.m4
configure.ac
helpers/basic_auth/DB/config.test [deleted file]
helpers/basic_auth/DB/required.m4 [new file with mode: 0755]
helpers/basic_auth/LDAP/config.test [deleted file]
helpers/basic_auth/LDAP/required.m4 [new file with mode: 0755]
helpers/basic_auth/MSNT-multi-domain/config.test [deleted file]
helpers/basic_auth/MSNT-multi-domain/required.m4 [new file with mode: 0755]
helpers/basic_auth/MSNT/config.test [deleted file]
helpers/basic_auth/MSNT/required.m4 [new file with mode: 0755]
helpers/basic_auth/NCSA/config.test [deleted file]
helpers/basic_auth/NCSA/required.m4 [new file with mode: 0755]
helpers/basic_auth/NIS/config.test [deleted file]
helpers/basic_auth/NIS/required.m4 [new file with mode: 0755]
helpers/basic_auth/PAM/config.test [deleted file]
helpers/basic_auth/PAM/required.m4 [new file with mode: 0755]
helpers/basic_auth/POP3/config.test [deleted file]
helpers/basic_auth/POP3/required.m4 [new file with mode: 0755]
helpers/basic_auth/RADIUS/config.test [deleted file]
helpers/basic_auth/RADIUS/required.m4 [new file with mode: 0755]
helpers/basic_auth/SASL/config.test [deleted file]
helpers/basic_auth/SASL/required.m4 [new file with mode: 0755]
helpers/basic_auth/SMB/config.test [deleted file]
helpers/basic_auth/SMB/required.m4 [new file with mode: 0755]
helpers/basic_auth/SSPI/config.test [deleted file]
helpers/basic_auth/SSPI/required.m4 [new file with mode: 0755]
helpers/basic_auth/fake/config.test [deleted file]
helpers/basic_auth/fake/required.m4 [new file with mode: 0755]
helpers/basic_auth/getpwnam/config.test [deleted file]
helpers/basic_auth/getpwnam/required.m4 [new file with mode: 0755]
helpers/basic_auth/modules.m4 [new file with mode: 0644]