]> git.ipfire.org Git - thirdparty/git.git/commit - archive.c
archive: initialize archivers earlier
authorJosh Steadmon <steadmon@google.com>
Thu, 25 Oct 2018 20:32:14 +0000 (13:32 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 26 Oct 2018 01:17:59 +0000 (10:17 +0900)
commit00436bf1b1c2a8fe6cf5d2c2457d419d683042f4
tree8ebc2b31bba3bec7673287db8b4b96257df8635f
parentc4df23f7927d8d00e666a3c8d1b3375f1dc8a3c1
archive: initialize archivers earlier

Initialize archivers as soon as possible when running git-archive.
Various non-obvious behavior depends on having the archivers
initialized, such as determining the desired archival format from the
provided filename.

Since 08716b3c11 ("archive: refactor file extension format-guessing",
2011-06-21), archive_format_from_filename() has used the registered
archivers to match filenames (provided via --output) to archival
formats. However, when git-archive is executed with --remote, format
detection happens before the archivers have been registered. This causes
archives from remotes to always be generated as TAR files, regardless of
the actual filename (unless an explicit --format is provided).

This patch fixes that behavior; archival format is determined properly
from the output filename, even when --remote is used.

Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Josh Steadmon <steadmon@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
archive.c
archive.h
builtin/archive.c
builtin/upload-archive.c
t/t5000-tar-tree.sh
t/t5003-archive-zip.sh