]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/checkout.c
branch,checkout: fix --track usage strings
authorJosh Steadmon <steadmon@google.com>
Tue, 18 Jan 2022 20:49:46 +0000 (12:49 -0800)
committerJunio C Hamano <gitster@pobox.com>
Tue, 18 Jan 2022 22:08:15 +0000 (14:08 -0800)
commit15f002812f858b49ce7641eb191561843cf31f00
tree0dd6567e4958899495c6adbb6c0829f36e8df961
parent44f14a9d24cd9f04a0a789e58968d52d44d7f332
branch,checkout: fix --track usage strings

As Ævar pointed out in [1], the use of PARSE_OPT_LITERAL_ARGHELP with a
list of allowed parameters is not recommended. Both git-branch and
git-checkout were changed in d311566 (branch: add flags and config to
inherit tracking, 2021-12-20) to use this discouraged combination for
their --track flags.

Fix this by removing PARSE_OPT_LITERAL_ARGHELP, and changing the arghelp
to simply be "mode". Users may discover allowed values in the manual
pages.

[1]: https://lore.kernel.org/git/220111.86a6g3yqf9.gmgdl@evledraar.gmail.com/

Signed-off-by: Josh Steadmon <steadmon@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/branch.c
builtin/checkout.c