]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/pack-objects.c
treewide: include parse-options.h in source files
authorSZEDER Gábor <szeder.dev@gmail.com>
Sun, 19 Mar 2023 16:27:11 +0000 (17:27 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 20 Mar 2023 18:26:47 +0000 (11:26 -0700)
commit49fd5511945977882ef2cd8b3c00ed25ac208512
treee1f21f3e6b4bc3301a490404ab790637ae86689e
parent73876f4861cd3d187a4682290ab75c9dccadbc56
treewide: include parse-options.h in source files

The builtins 'ls-remote', 'pack-objects', 'receive-pack', 'reflog' and
'send-pack' use parse_options(), but their source files don't directly
include 'parse-options.h'.  Furthermore, the source files
'diagnose.c', 'list-objects-filter-options.c', 'remote.c' and
'send-pack.c' define option parsing callback functions, while
'revision.c' defines an option parsing helper function, and thus need
access to various fields in 'struct option' and 'struct
parse_opt_ctx_t', but they don't directly include 'parse-options.h'
either.  They all can still be built, of course, because they include
one of the header files that does include 'parse-options.h' (though
unnecessarily, see the next commit).

Add those missing includes to these files, as our general rule is that
"a C file must directly include the header files that declare the
functions and the types it uses".

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/ls-remote.c
builtin/pack-objects.c
builtin/receive-pack.c
builtin/reflog.c
builtin/send-pack.c
diagnose.c
list-objects-filter-options.c
remote.c
revision.c
send-pack.c