]> git.ipfire.org Git - people/ms/linux.git/commit - fs/btrfs/block-group.c
btrfs: zoned: activate block group only for extent allocation
authorNaohiro Aota <naohiro.aota@wdc.com>
Tue, 22 Mar 2022 09:11:34 +0000 (18:11 +0900)
committerDavid Sterba <dsterba@suse.com>
Tue, 5 Apr 2022 22:50:41 +0000 (00:50 +0200)
commit760e69c4c2e2f475a812bdd414b62758215ce9cb
treee7c664538a587650a344fc5569f43b2b889ba709
parent820c363bd526ec8e133e4b84e6ad1fda12023b4b
btrfs: zoned: activate block group only for extent allocation

In btrfs_make_block_group(), we activate the allocated block group,
expecting that the block group is soon used for allocation. However, the
chunk allocation from flush_space() context broke the assumption. There
can be a large time gap between the chunk allocation time and the extent
allocation time from the chunk.

Activating the empty block groups pre-allocated from flush_space()
context can exhaust the active zone counter of a device. Once we use all
the active zone counts for empty pre-allocated block groups, we cannot
activate new block group for the other things: metadata, tree-log, or
data relocation block group.  That failure results in a fake -ENOSPC.

This patch introduces CHUNK_ALLOC_FORCE_FOR_EXTENT to distinguish the
chunk allocation from find_free_extent(). Now, the new block group is
activated only in that context.

Fixes: eb66a010d518 ("btrfs: zoned: activate new block group")
CC: stable@vger.kernel.org # 5.16+
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Tested-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/block-group.c
fs/btrfs/block-group.h
fs/btrfs/extent-tree.c