]> git.ipfire.org Git - people/ms/linux.git/commit - fs/btrfs/ioctl.c
Btrfs: fix error check of btrfs_lookup_dentry()
authorTsutomu Itoh <t-itoh@jp.fujitsu.com>
Fri, 13 Dec 2013 00:51:42 +0000 (09:51 +0900)
committerChris Mason <clm@fb.com>
Tue, 28 Jan 2014 21:19:56 +0000 (13:19 -0800)
commit5662344b3c0d9ddd9afd48716d795166f982d5e2
treef96a684a9d279e0d283ace433f4f72c9c9959d66
parent783577663507411e36e459390ef056556e93ef29
Btrfs: fix error check of btrfs_lookup_dentry()

Clean up btrfs_lookup_dentry() to never return NULL, but PTR_ERR(-ENOENT)
instead. This keeps the return value convention consistent.

Callers who use btrfs_lookup_dentry() require a trivial update.

create_snapshot() in particular looks like it can also lose a BUG_ON(!inode)
which is not really needed - there seems less harm in returning ENOENT to
userspace at that point in the stack than there is to crash the machine.

Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/inode.c
fs/btrfs/ioctl.c