]> git.ipfire.org Git - people/ms/linux.git/commit - fs/btrfs/super.c
btrfs: prevent remounting to v1 space cache for subpage mount
authorQu Wenruo <wqu@suse.com>
Wed, 18 May 2022 05:03:09 +0000 (13:03 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 6 Jun 2022 14:18:59 +0000 (16:18 +0200)
commit0591f04036218d572d54349ea8c7914ad9c82b2b
treedd7c2f03d703a3b6f92abb3db7d0798c4058ce86
parent31e70e527806c546a72262f2fc3d982ee23c42d3
btrfs: prevent remounting to v1 space cache for subpage mount

Upstream commit 9f73f1aef98b ("btrfs: force v2 space cache usage for
subpage mount") forces subpage mount to use v2 cache, to avoid
deprecated v1 cache which doesn't support subpage properly.

But there is a loophole that user can still remount to v1 cache.

The existing check will only give users a warning, but does not really
prevent to do the remount.

Although remounting to v1 will not cause any problems since the v1 cache
will always be marked invalid when mounted with a different page size,
it's still better to prevent v1 cache at all for subpage mounts.

Fixes: 9f73f1aef98b ("btrfs: force v2 space cache usage for subpage mount")
CC: stable@vger.kernel.org # 5.15+
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/super.c