]> git.ipfire.org Git - people/ms/linux.git/commit - fs/char_dev.c
chardev: set variable ret to -EBUSY before checking minor range overlap
authorChengguang Xu <cgxu519@gmail.com>
Thu, 2 May 2019 12:15:05 +0000 (20:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 May 2019 18:50:36 +0000 (20:50 +0200)
commit7ef0b1524417743e6861490420225affe451486b
treecd11afb441a7cd2abc48bc1a0860482a540e4abd
parent17aa207e6e08b0bcf92cf7b473fae9a70e325dbe
chardev: set variable ret to -EBUSY before checking minor range overlap

When allocating dynamic major, the minor range overlap check
in __register_chrdev_region() will not fail, so actually
there is no real case to passing non negative error code to
caller. However, set variable ret to -EBUSY before checking
minor range overlap will avoid false-positive warning from
code analyzing tool(like Smatch) and also make the code more
easy to understand.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chengguang Xu <cgxu519@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/char_dev.c