]> git.ipfire.org Git - people/ms/linux.git/commit - fs/cifs/cifs_debug.c
cifs: try to handle the MUST SecurityFlags sanely
authorJeff Layton <jlayton@redhat.com>
Sun, 26 May 2013 11:01:02 +0000 (07:01 -0400)
committerSteve French <smfrench@gmail.com>
Wed, 26 Jun 2013 22:31:55 +0000 (17:31 -0500)
commit52dfb446dbc1915e1df89f8ea9cae1fee7ab3d5e
tree69ab965c02081ef4a2ac82e3958a724e4ac6baa5
parent5d875cc928aa7c95c8c1e89497a9a644f32213d4
cifs: try to handle the MUST SecurityFlags sanely

The cifs.ko SecurityFlags interface wins my award for worst-designed
interface ever, but we're sort of stuck with it since it's documented
and people do use it (even if it doesn't work correctly).

Case in point -- you can specify multiple sets of "MUST" flags. It makes
absolutely no sense, but you can do it.

What should the effect be in such a case? No one knows or seems to have
considered this so far, so let's define it now. If you try to specify
multiple MUST flags, clear any other MAY or MUST bits except for the
ones that involve signing.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Pavel Shilovsky <piastry@etersoft.ru>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/cifs_debug.c