]> git.ipfire.org Git - people/ms/linux.git/commit - fs/cifs/cifsglob.h
cifs: set a minimum of 120s for next dns resolution
authorPaulo Alcantara <pc@cjr.nz>
Thu, 4 Nov 2021 16:13:28 +0000 (13:13 -0300)
committerSteve French <stfrench@microsoft.com>
Wed, 10 Nov 2021 05:03:08 +0000 (23:03 -0600)
commit4ac0536f8874a903a72bddc57eb88db774261e3a
treee596ccf5a96d47d4a35a4b097f8f4140ca8112ca
parentbbcce368044572d0802c3bbb8ef3fe98f581d803
cifs: set a minimum of 120s for next dns resolution

With commit 506c1da44fee ("cifs: use the expiry output of dns_query to
schedule next resolution") and after triggering the first reconnect,
the next async dns resolution of tcp server's hostname would be
scheduled based on dns_resolver's key expiry default, which happens to
default to 5s on most systems that use key.dns_resolver for upcall.

As per key.dns_resolver.conf(5):

       default_ttl=<number>
              The  number  of  seconds  to  set  as the expiration on a cached
              record.  This will be overridden if the program manages  to  re-
              trieve  TTL  information along with the addresses (if, for exam-
              ple, it accesses the DNS directly).  The default is  5  seconds.
              The value must be in the range 1 to INT_MAX.

Make the next async dns resolution no shorter than 120s as we do not
want to be upcalling too often.

Cc: stable@vger.kernel.org
Fixes: 506c1da44fee ("cifs: use the expiry output of dns_query to schedule next resolution")
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/cifsglob.h
fs/cifs/connect.c