]> git.ipfire.org Git - people/ms/linux.git/commit - fs/cifs/file.c
CIFS: Fix use after free of file info structures
authorPavel Shilovsky <pshilov@microsoft.com>
Wed, 23 Oct 2019 22:37:19 +0000 (15:37 -0700)
committerSteve French <stfrench@microsoft.com>
Fri, 25 Oct 2019 02:32:35 +0000 (21:32 -0500)
commit1a67c415965752879e2e9fad407bc44fc7f25f23
treec66e3fc9f7fb3181082d2982b1f5db7278ba8ad7
parentabe57073d08c13b95a46ccf48cc9dc957d5c6fdb
CIFS: Fix use after free of file info structures

Currently the code assumes that if a file info entry belongs
to lists of open file handles of an inode and a tcon then
it has non-zero reference. The recent changes broke that
assumption when putting the last reference of the file info.
There may be a situation when a file is being deleted but
nothing prevents another thread to reference it again
and start using it. This happens because we do not hold
the inode list lock while checking the number of references
of the file info structure. Fix this by doing the proper
locking when doing the check.

Fixes: 487317c99477d ("cifs: add spinlock for the openFileList to cifsInodeInfo")
Fixes: cb248819d209d ("cifs: use cifsInodeInfo->open_file_lock while iterating to avoid a panic")
Cc: Stable <stable@vger.kernel.org>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/file.c