]> git.ipfire.org Git - people/ms/linux.git/commit - fs/dax.c
fs/dax: Fix pmd vs pte conflict detection
authorDan Williams <dan.j.williams@intel.com>
Mon, 21 Oct 2019 16:29:20 +0000 (09:29 -0700)
committerDan Williams <dan.j.williams@intel.com>
Wed, 23 Oct 2019 05:53:02 +0000 (22:53 -0700)
commit6370740e5f8ef12de7f9a9bf48a0393d202cd827
tree193c82c6296d07c5ef4da78ea8c0fa0f2ff9b80e
parent4f5cafb5cb8471e54afdc9054d973535614f7675
fs/dax: Fix pmd vs pte conflict detection

Users reported a v5.3 performance regression and inability to establish
huge page mappings. A revised version of the ndctl "dax.sh" huge page
unit test identifies commit 23c84eb78375 "dax: Fix missed wakeup with
PMD faults" as the source.

Update get_unlocked_entry() to check for NULL entries before checking
the entry order, otherwise NULL is misinterpreted as a present pte
conflict. The 'order' check needs to happen before the locked check as
an unlocked entry at the wrong order must fallback to lookup the correct
order.

Reported-by: Jeff Smits <jeff.smits@intel.com>
Reported-by: Doug Nelson <doug.nelson@intel.com>
Cc: <stable@vger.kernel.org>
Fixes: 23c84eb78375 ("dax: Fix missed wakeup with PMD faults")
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Link: https://lore.kernel.org/r/157167532455.3945484.11971474077040503994.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
fs/dax.c