]> git.ipfire.org Git - people/ms/linux.git/commit - fs/ext4/mballoc.c
ext4: use ext4_grp_locked_error in mb_find_extent
authorStephen Brennan <stephen.s.brennan@oracle.com>
Wed, 23 Jun 2021 23:21:14 +0000 (16:21 -0700)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 1 Jul 2021 21:14:07 +0000 (17:14 -0400)
commitcd84bbbac12a173a381a64c6ec8b76a5277b87b5
tree185caf1ac954570d0137e7679dc0152d19a75682
parent558d6450c7755aa005d89021204b6cdcae5e848f
ext4: use ext4_grp_locked_error in mb_find_extent

Commit 5d1b1b3f492f ("ext4: fix BUG when calling ext4_error with locked
block group") introduces ext4_grp_locked_error to handle unlocking a
group in error cases. Otherwise, there is a possibility of a sleep while
atomic. However, since 43c73221b3b1 ("ext4: replace BUG_ON with WARN_ON
in mb_find_extent()"), mb_find_extent() has contained a ext4_error()
call while a group spinlock is held. Replace this with
ext4_grp_locked_error.

Fixes: 43c73221b3b1 ("ext4: replace BUG_ON with WARN_ON in mb_find_extent()")
Cc: <stable@vger.kernel.org> # 4.14+
Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Junxiao Bi <junxiao.bi@oracle.com>
Link: https://lore.kernel.org/r/20210623232114.34457-1-stephen.s.brennan@oracle.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/mballoc.c