]> git.ipfire.org Git - people/ms/linux.git/commit - fs/gfs2/file.c
gfs2: Fix fallocate chunk size
authorAndreas Gruenbacher <agruenba@redhat.com>
Tue, 20 Feb 2018 15:03:24 +0000 (08:03 -0700)
committerBob Peterson <rpeterso@redhat.com>
Thu, 8 Mar 2018 16:26:20 +0000 (09:26 -0700)
commit174d1232ebc84fcde8f5889d1171c9c7e74a10a7
tree755eabd7f57703c96d0979a52cc555d0c0deecb3
parent1b88accf6a659c46d5c8e68912896f112bf882bb
gfs2: Fix fallocate chunk size

The chunk size of allocations in __gfs2_fallocate is calculated
incorrectly.  The size can collapse, causing __gfs2_fallocate to
allocate one block at a time, which is very inefficient.  This needs
fixing in two places:

In gfs2_quota_lock_check, always set ap->allowed to UINT_MAX to indicate
that there is no quota limit.  This fixes callers that rely on
ap->allowed to be set even when quotas are off.

In __gfs2_fallocate, reset max_blks to UINT_MAX in each iteration of the
loop to make sure that allocation limits from one resource group won't
spill over into another resource group.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/file.c
fs/gfs2/quota.h