]> git.ipfire.org Git - people/ms/linux.git/commit - fs/nfsd/nfs4xdr.c
nfsd4: decoding errors can still be cached and require space
authorJ. Bruce Fields <bfields@redhat.com>
Mon, 19 May 2014 16:27:11 +0000 (12:27 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 23 May 2014 13:03:44 +0000 (09:03 -0400)
commite372ba60def1af33e1c0b9bbfa5c8f8559c1ad6b
tree93ab5ea032f80a87a60bc681e809b908aaa3612c
parentf34e432b673781175c782fa8c5a619114340ba38
nfsd4: decoding errors can still be cached and require space

Currently a non-idempotent op reply may be cached if it fails in the
proc code but not if it fails at xdr decoding.  I doubt there are any
xdr-decoding-time errors that would make this a problem in practice, so
this probably isn't a serious bug.

The space estimates should also take into account space required for
encoding of error returns.  Again, not a practical problem, though it
would become one after future patches which will tighten the space
estimates.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4proc.c
fs/nfsd/nfs4xdr.c