]> git.ipfire.org Git - people/ms/linux.git/commit - fs/quota/dquot.c
fs: quota: Replace GFP_ATOMIC with GFP_KERNEL in dquot_init
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 9 Apr 2018 14:31:19 +0000 (22:31 +0800)
committerJan Kara <jack@suse.cz>
Mon, 9 Apr 2018 15:48:54 +0000 (17:48 +0200)
commit1aa3b3e0cbdb32439f04842e88fc7557a0777660
tree1c49cc6fd8d4af5b2c3bb22acb4d9f55f82eb513
parent54a307ba8d3cd00a3902337ffaae28f436eeb1a4
fs: quota: Replace GFP_ATOMIC with GFP_KERNEL in dquot_init

dquot_init() is never called in atomic context.
This function is only set as a parameter of fs_initcall().

Despite never getting called from atomic context,
dquot_init() calls __get_free_pages() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/quota/dquot.c