]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/testsuite/gdb.python/py-framefilter.exp
fix erroneous error-handling in frame filter code
authorTom Tromey <tromey@redhat.com>
Wed, 22 Jan 2014 15:44:41 +0000 (08:44 -0700)
committerTom Tromey <tromey@redhat.com>
Thu, 23 Jan 2014 15:03:51 +0000 (08:03 -0700)
commit0740f8d82dd18e48d1531c8d86b531341fc9e099
tree6440d7d659446284e1d3a8a2a0586154704d0cba
parent21909fa1c6d934bfa0c7ad3ef95909db48f6f756
fix erroneous error-handling in frame filter code

This fixes PR python/16487.

The bug here is that the function-name-handling code in py_print_frame
had a small logic error (really a misplaced closing brace).  This
error could lead to a Py_DECREF(NULL), which crashes.

This patch fixes the bug in the obvious way.

Built and regtested on x86-64 Fedora 18.  New test case included.

2014-01-23  Tom Tromey  <tromey@redhat.com>

PR python/16487:
* python/py-framefilter.c (py_print_frame): Don't call Py_DECREF
on a NULL pointer.  Move "goto error" to correct place.

2014-01-23  Tom Tromey  <tromey@redhat.com>

PR python/16487:
* gdb.python/py-framefilter.exp: Add test using "Error" filter.
* gdb.python/py-framefilter.py (ErrorInName, ErrorFilter): New
classes.
gdb/ChangeLog
gdb/python/py-framefilter.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.python/py-framefilter.exp
gdb/testsuite/gdb.python/py-framefilter.py