]> git.ipfire.org Git - thirdparty/linux.git/commit - include/linux/blkdev.h
blk-mq: support concurrent queue quiesce/unquiesce
authorMing Lei <ming.lei@redhat.com>
Thu, 14 Oct 2021 08:17:10 +0000 (16:17 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 20 Oct 2021 00:27:58 +0000 (18:27 -0600)
commite70feb8b3e6886c525c88943b5f1508d02f5a683
treeb0bb0d783c033f32f32145e993a163477b651f4f
parent1d35d519d8bf224ccdb43f9a235b8bda2d6d453c
blk-mq: support concurrent queue quiesce/unquiesce

blk_mq_quiesce_queue() has been used a bit wide now, so far we don't support
concurrent/nested quiesce. One biggest issue is that unquiesce can happen
unexpectedly in case that quiesce/unquiesce are run concurrently from
more than one context.

This patch introduces q->mq_quiesce_depth to deal concurrent quiesce,
and we only unquiesce queue when it is the last/outer-most one of all
contexts.

Several kernel panic issue has been reported[1][2][3] when running stress
quiesce test. And this patch has been verified in these reports.

[1] https://lore.kernel.org/linux-block/9b21c797-e505-3821-4f5b-df7bf9380328@huawei.com/T/#m1fc52431fad7f33b1ffc3f12c4450e4238540787
[2] https://lore.kernel.org/linux-block/9b21c797-e505-3821-4f5b-df7bf9380328@huawei.com/T/#m10ad90afeb9c8cc318334190a7c24c8b5c5e0722
[3] https://listman.redhat.com/archives/dm-devel/2021-September/msg00189.html

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211014081710.1871747-7-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c
include/linux/blkdev.h