]> git.ipfire.org Git - thirdparty/qemu.git/commit - meson.build
configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 23 Sep 2020 09:26:17 +0000 (05:26 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 6 Oct 2020 06:34:49 +0000 (08:34 +0200)
commit47b30835e48d9bc061cbf0bd606a4925303971a4
treefdbdf2e8b65fc784f3e2630eb2de7e23a807a4b5
parent5770e8afd629cc8a83dc41e2524258c73c1b301e
configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson

Environment variables like CFLAGS are easy to accidentally change.  Meson
warns if that happens, but in a project with a lot of configuration that
is easy to lose.  It is also surprising behavior since meson caches -D
options and remembers those on reconfiguration (which we rely on,
since configure options become -D options).

By placing the user-provided CFLAGS, CXXFLAGS and LDFLAGS in the
cross file, we at least get consistent behavior.  These environment
variables are still ugly and not really recommended, but there are
distros that rely on them.  For the gory details, refer to
https://github.com/mesonbuild/meson/issues/4664.

Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200923092617.1593722-5-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
configure
meson.build