]> git.ipfire.org Git - thirdparty/git.git/commit - pack-mtimes.c
projects / thirdparty / git.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 652891d) | patch
pack-mtimes: avoid closing a bogus file descriptor
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Wed, 15 Jun 2022 23:35:43 +0000 (23:35 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 16 Jun 2022 20:22:03 +0000 (13:22 -0700)
commit41f1a8e6a417bc3e56a0eef687e28247138276d1
treec14f4396511c8d270b66516f4c58196949ae0cc8tree | snapshot
parent652891de4ff164d545daa5472ab67f4f9d41319bcommit | diff
pack-mtimes: avoid closing a bogus file descriptor

In 94cd775a6c52 (pack-mtimes: support reading .mtimes files,
2022-05-20), code was added to close the file descriptor corresponding
to the mtimes file.

However, it is possible that opening that file failed, in which case we
are closing a file descriptor with the value `-1`. Let's guard that
`close()` call.

Reported by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pack-mtimes.c diff | blob | blame | history
Unnamed repository; edit this file 'description' to name the repository.