]> git.ipfire.org Git - people/ms/suricata.git/commit - rust/src/dcerpc/dcerpc_udp.rs
rust: functions that reference raw pointers are unsafe
authorJason Ish <jason.ish@oisf.net>
Mon, 26 Jul 2021 21:53:44 +0000 (15:53 -0600)
committerVictor Julien <victor@inliniac.net>
Mon, 23 Aug 2021 08:03:12 +0000 (10:03 +0200)
commit363b5f99c36fda06f185e446ca28dff6da81fbcc
tree62ad78abbffc720908fd6f998db477c6ca3e200a
parent53413f2d7af513f631fcae316a5ea2142d94e977
rust: functions that reference raw pointers are unsafe

Based on the Rust clippy lint that recommends that any public
function that dereferences a raw pointer, mark all FFI functions
that reference raw pointers with build_slice and cast_pointer
as unsafe.

This commits starts by removing the unsafe wrapper inside
the build_slice and cast_pointer macros then marks all
functions that use these macros as unsafe.

Then fix all not_unsafe_ptr_arg_deref warnings from clippy.

Fixes clippy lint:
https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
36 files changed:
rust/src/applayer.rs
rust/src/applayertemplate/logger.rs
rust/src/applayertemplate/template.rs
rust/src/asn1/mod.rs
rust/src/dcerpc/dcerpc.rs
rust/src/dcerpc/dcerpc_udp.rs
rust/src/dhcp/dhcp.rs
rust/src/dhcp/logger.rs
rust/src/dns/dns.rs
rust/src/ftp/mod.rs
rust/src/http2/detect.rs
rust/src/http2/http2.rs
rust/src/http2/logger.rs
rust/src/ike/ike.rs
rust/src/ike/logger.rs
rust/src/krb/krb5.rs
rust/src/modbus/modbus.rs
rust/src/mqtt/detect.rs
rust/src/mqtt/logger.rs
rust/src/mqtt/mqtt.rs
rust/src/nfs/nfs.rs
rust/src/ntp/ntp.rs
rust/src/rdp/rdp.rs
rust/src/rfb/logger.rs
rust/src/rfb/rfb.rs
rust/src/sip/sip.rs
rust/src/smb/detect.rs
rust/src/smb/files.rs
rust/src/smb/smb.rs
rust/src/snmp/detect.rs
rust/src/snmp/snmp.rs
rust/src/ssh/detect.rs
rust/src/ssh/logger.rs
rust/src/ssh/ssh.rs
rust/src/tftp/tftp.rs
rust/src/x509/mod.rs