]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/basic/barrier.c
barrier: fix up constructor error handling
authorDavid Herrmann <dh.herrmann@gmail.com>
Thu, 2 Oct 2014 06:31:28 +0000 (08:31 +0200)
committerDavid Herrmann <dh.herrmann@gmail.com>
Thu, 2 Oct 2014 06:40:43 +0000 (08:40 +0200)
commitfc808616227115ccab8c04f00f8f7472c7353ae5
tree5a3602427608b7fb975dacdc19579a28261d0ec1
parentdda57d9143644d39091207b287f142f91f55d0ad
barrier: fix up constructor error handling

We cannot rely on "errno" to be non-zero on failure, if we perform
multiple glibc calls. That is, if the first eventfd() call fails, but the
second succeeds, we cleanup the barrier but return 0.

Fix this by always testing the return value immediately. This should also
fix all the coverity warnings.
src/shared/barrier.c
src/shared/barrier.h