]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/basic/fd-util.c
tree-wide: use c99 static for array size declarations
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 4 Jan 2019 11:30:45 +0000 (12:30 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 4 Jan 2019 11:37:25 +0000 (12:37 +0100)
commit3042bbebddb819371aa2ee0811a1f9d3d38f7b94
tree50a6d8b8a03ef12c9842fe53cbc9577b04fed09e
parentd27d60b3bca61684a2b6e14f984e02d8a7ecd15c
tree-wide: use c99 static for array size declarations

https://hamberg.no/erlend/posts/2013-02-18-static-array-indices.html

This only works with clang, unfortunately gcc doesn't seem to implement the check
(tested with gcc-8.2.1-5.fc29.x86_64).

Simulated error:
[2/3] Compiling C object 'systemd-nspawn@exe/src_nspawn_nspawn.c.o'.
../src/nspawn/nspawn.c:3179:45: warning: array argument is too small; contains 15 elements, callee requires at least 16 [-Warray-bounds]
                        candidate = (uid_t) siphash24(arg_machine, strlen(arg_machine), hash_key);
                                            ^                                           ~~~~~~~~
../src/basic/siphash24.h:24:64: note: callee declares array parameter as static here
uint64_t siphash24(const void *in, size_t inlen, const uint8_t k[static 16]);
                                                               ^~~~~~~~~~~~
13 files changed:
src/basic/fd-util.c
src/basic/fd-util.h
src/basic/siphash24.c
src/basic/siphash24.h
src/basic/string-util.c
src/boot/efi/disk.c
src/boot/efi/disk.h
src/core/dynamic-user.c
src/core/execute.c
src/core/namespace.c
src/core/namespace.h
src/shared/efivars.c
src/socket-proxy/socket-proxyd.c