]> git.ipfire.org Git - thirdparty/git.git/commit - t/test-lib-functions.sh
cherry-pick: don't forget -s on failure
authorMiklos Vajna <vmiklos@suse.cz>
Fri, 14 Sep 2012 06:52:03 +0000 (08:52 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 14 Sep 2012 17:04:29 +0000 (10:04 -0700)
commit5ed75e2a3fb30f93fea7772e481ec6091e9a2c5f
treeea0dc3f146a6a31dcb166dc3310376a1c8ddecc9
parentce5cf6ffc6feb9fb4f9a50cdfa2f527fa119c94f
cherry-pick: don't forget -s on failure

In case 'git cherry-pick -s <commit>' failed, the user had to use 'git
commit -s' (i.e. state the -s option again), which is easy to forget
about.  Instead, write the signed-off-by line early, so plain 'git
commit' will have the same result.

Also update 'git commit -s', so that in case there is already a relevant
Signed-off-by line before the Conflicts: line, it won't add one more at
the end of the message. If there is no such line, then add it before the
the Conflicts: line.

Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/commit.c
sequencer.c
sequencer.h
t/t3507-cherry-pick-conflict.sh
t/t3510-cherry-pick-sequence.sh
t/test-lib-functions.sh