]> git.ipfire.org Git - thirdparty/hostap.git/commit - tests/hwsim/test_ap_wps.py
WPS: Add prefixes to public event_* functions
authorBrian Norris <briannorris@chromium.org>
Mon, 2 Dec 2019 20:14:47 +0000 (12:14 -0800)
committerJouni Malinen <j@w1.fi>
Sun, 22 Dec 2019 09:24:28 +0000 (11:24 +0200)
commite6d3aca9cf6e251eb19874bd2fa790cf7f0ead88
tree4825d2b6b2c1ea2af65603fb6ba8e05406e8b3db
parente371d3771c7b16fcc9f5007b231f2294e3db0272
WPS: Add prefixes to public event_* functions

openssl engines may dynamically load external libraries. Our event_*()
functions happen to be named very generically, such that event_add()
collides with the libevent library (https://libevent.org/). This can
have disastrous effects (esp. when using CONFIG_WPA_TRACE, which enables
partial linking) when our SSL engines call into the WPS event_add()
instead of their intended libevent event_add().

Resolve this by providing a more unique prefix to these functions.

Rename performed via:

  sed -i -E \
    's:\<event_(add|delete_all|send_all_later|send_stop_all)\>:wps_upnp_event_\1:g' \
     $(git grep -l event_)

Tested via (among other things) hwsim '-f ap_wps' module.

Signed-off-by: Brian Norris <briannorris@chromium.org>
src/wps/wps_upnp.c
src/wps/wps_upnp_event.c
src/wps/wps_upnp_i.h
tests/hwsim/test_ap_wps.py